RequestListenerTest::getEvent() - Code Metrics - Inspection of "Fix EZP-26188: Add twig globals to fields template..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp26188-render_field_twig_glo... ( 6b91c6...a62256 )

unknown

created 2016-08-22 13:14 UTC

RequestListenerTest::getEvent() A

↳ Parent: RequestListenerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * File containing the RequestListenerTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Bundle\EzPublishRestBundle\Tests\EventListener;

use eZ\Publish\Core\REST\Server\View\AcceptHeaderVisitorDispatcher;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use eZ\Bundle\EzPublishRestBundle\EventListener\RequestListener;
use Symfony\Component\HttpKernel\KernelEvents;

class RequestListenerTest extends EventListenerTest
{
    const REST_PREFIX = '/rest/prefix';

    public function provideExpectedSubscribedEventTypes()
    {
        return array(
            array(array(KernelEvents::REQUEST)),
        );
    }

    public function testOnKernelRequestNotMasterRequest()
    {
        $event = $this->getEvent(self::REST_PREFIX . '/', HttpKernelInterface::SUB_REQUEST);
        $this->getEventListener()->onKernelRequest($event);

        self::assertTrue(
            $event->getRequest()->attributes->get('is_rest_request')
        );
    }

    public function testOnKernelRequestNotRestRequest()
    {
        $event = $this->getEvent('/');
        $this->getEventListener()->onKernelRequest($event);

        self::assertFalse(
            $event->getRequest()->attributes->get('is_rest_request')
        );
    }

    public function testOnKernelRequestRestRequest()
    {
        $event = $this->getEvent(self::REST_PREFIX . '/');
        $this->getEventListener()->onKernelRequest($event);

        self::assertTrue(
            $event->getRequest()->attributes->get('is_rest_request')
        );
    }

    /**
     * @return RequestListener
     */
    protected function getEventListener()
    {
        return new RequestListener(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            self::REST_PREFIX,
            $this->getVisitorDispatcherMock()
        );
    }

    /**
     * @return AcceptHeaderVisitorDispatcher|\PHPUnit_Framework_MockObject_MockObject
     */
    public function getVisitorDispatcherMock()
    {
        return $this->getMock(
            'eZ\Publish\Core\REST\Server\View\AcceptHeaderVisitorDispatcher'
        );
    }

    /**
     * @return GetResponseEvent
     */
    public function getEvent($uri, $type = HttpKernelInterface::MASTER_REQUEST)
    {
        return new GetResponseEvent(
            $this->getMock('Symfony\Component\HttpKernel\HttpKernelInterface'),
            Request::create($uri),
            $type
        );
    }
}


1		<?php
2
3		/**
4		* File containing the RequestListenerTest class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*
9		* @version //autogentag//
10		*/
11		namespace eZ\Bundle\EzPublishRestBundle\Tests\EventListener;
12
13		use eZ\Publish\Core\REST\Server\View\AcceptHeaderVisitorDispatcher;
14		use Symfony\Component\HttpFoundation\Request;
15		use Symfony\Component\HttpKernel\Event\GetResponseEvent;
16		use Symfony\Component\HttpKernel\HttpKernelInterface;
17		use eZ\Bundle\EzPublishRestBundle\EventListener\RequestListener;
18		use Symfony\Component\HttpKernel\KernelEvents;
19
20		class RequestListenerTest extends EventListenerTest
21		{
22		const REST_PREFIX = '/rest/prefix';
23
24		public function provideExpectedSubscribedEventTypes()
25		{
26		return array(
27		array(array(KernelEvents::REQUEST)),
28		);
29		}
30
31		public function testOnKernelRequestNotMasterRequest()
32		{
33		$event = $this->getEvent(self::REST_PREFIX . '/', HttpKernelInterface::SUB_REQUEST);
34		$this->getEventListener()->onKernelRequest($event);
35
36		self::assertTrue(
37		$event->getRequest()->attributes->get('is_rest_request')
38		);
39		}
40
41	View Code Duplication	public function testOnKernelRequestNotRestRequest()
42		{
43		$event = $this->getEvent('/');
44		$this->getEventListener()->onKernelRequest($event);
45
46		self::assertFalse(
47		$event->getRequest()->attributes->get('is_rest_request')
48		);
49		}
50
51	View Code Duplication	public function testOnKernelRequestRestRequest()
52		{
53		$event = $this->getEvent(self::REST_PREFIX . '/');
54		$this->getEventListener()->onKernelRequest($event);
55
56		self::assertTrue(
57		$event->getRequest()->attributes->get('is_rest_request')
58		);
59		}
60
61		/**
62		* @return RequestListener
63		*/
64		protected function getEventListener()
65		{
66		return new RequestListener(
		0 ignored issues – show Bug Best Practice introduced 2015-11-21 14:36 UTC by Report Bug Copy Issue Report The return type of `return new \eZ\Bundle\Ez...sitorDispatcherMock());` (`eZ\Bundle\EzPublishRestB...istener\RequestListener`) is incompatible with the return type declared by the abstract method `eZ\Bundle\EzPublishRestB...rTest::getEventListener` of type `eZ\Bundle\EzPublishRestB...ntListener\CsrfListener`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
67		self::REST_PREFIX,
68		$this->getVisitorDispatcherMock()
69		);
70		}
71
72		/**
73		* @return AcceptHeaderVisitorDispatcher\|\PHPUnit_Framework_MockObject_MockObject
74		*/
75		public function getVisitorDispatcherMock()
76		{
77		return $this->getMock(
78		'eZ\Publish\Core\REST\Server\View\AcceptHeaderVisitorDispatcher'
79		);
80		}
81
82		/**
83		* @return GetResponseEvent
84		*/
85		public function getEvent($uri, $type = HttpKernelInterface::MASTER_REQUEST)
86		{
87		return new GetResponseEvent(
88		$this->getMock('Symfony\Component\HttpKernel\HttpKernelInterface'),
89		Request::create($uri),
90		$type
91		);
92		}
93		}
94

ezsystems / ezpublish-kernel

Push — ezp26188-render_field_twig_glo... ( 6b91c6...a62256 )

RequestListenerTest::getEvent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like