VersionBuilderTest::providerForTestBuild() - Code Metrics - Inspection of "EZP-30548: Romanian special characters addition" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — EZP-30548-Romanian_special_cha... ( 38d0c8...2c2658 )

unknown

created 2019-06-03 12:23 UTC

VersionBuilderTest::providerForTestBuild() B

↳ Parent: VersionBuilderTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	58
rs	8.9163
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Publish\SPI\Tests\Limitation\Target\Builder;

use eZ\Publish\API\Repository\Values\Content\Field;
use eZ\Publish\API\Repository\Values\Content\VersionInfo;
use eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder;
use eZ\Publish\SPI\Limitation\Target;
use PHPUnit\Framework\TestCase;

/**
 * @covers \eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder
 */
class VersionBuilderTest extends TestCase
{
    /**
     * Data provider for testBuild.
     *
     * @see testBuild
     *
     * @return array
     */
    public function providerForTestBuild(): array
    {
        $versionStatuses = [
            VersionInfo::STATUS_DRAFT,
            VersionInfo::STATUS_PUBLISHED,
            VersionInfo::STATUS_ARCHIVED,
        ];

        $data = [];
        foreach ($versionStatuses as $versionStatus) {
            $languagesList = ['ger-DE', 'eng-US', 'eng-GB'];
            $contentTypeIdsList = [1, 2];
            $initialLanguageCode = 'eng-US';
            $fields = [
                new Field(['languageCode' => 'ger-DE']),
                new Field(['languageCode' => 'ger-DE']),
                new Field(['languageCode' => 'eng-US']),
            ];
            $updateTranslationsLanguageCodes = ['ger-DE', 'eng-US'];

            $data[] = [
                new Target\Version(
                    [
                        'newStatus' => $versionStatus,
                        'allLanguageCodesList' => $languagesList,
                        'allContentTypeIdsList' => $contentTypeIdsList,
                        'forUpdateLanguageCodesList' => $updateTranslationsLanguageCodes,
                        'forUpdateInitialLanguageCode' => $initialLanguageCode,
                    ]
                ),
                $versionStatus,
                $initialLanguageCode,
                $fields,
                $languagesList,
                $contentTypeIdsList,
            ];

            // no published content
            $data[] = [
                new Target\Version(
                    [
                        'newStatus' => $versionStatus,
                        'allLanguageCodesList' => $languagesList,
                        'allContentTypeIdsList' => $contentTypeIdsList,
                        'forUpdateLanguageCodesList' => $updateTranslationsLanguageCodes,
                        'forUpdateInitialLanguageCode' => $initialLanguageCode,
                    ]
                ),
                $versionStatus,
                $initialLanguageCode,
                $fields,
                $languagesList,
                $contentTypeIdsList,
            ];
        }

        return $data;
    }

    /**
     * @covers       \eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder::build
     *
     * @dataProvider providerForTestBuild
     *
     * @param \eZ\Publish\SPI\Limitation\Target\Version $expectedTargetVersion
     * @param int $newStatus
     * @param string $initialLanguageCode
     * @param \eZ\Publish\API\Repository\Values\Content\Field[] $newFields
     * @param string[] $languagesList
     * @param int[] $contentTypeIdsList
     *
     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
     */
    public function testBuild(
        Target\Version $expectedTargetVersion,
        int $newStatus,
        string $initialLanguageCode,
        array $newFields,
        array $languagesList,
        array $contentTypeIdsList
    ): void {
        $versionBuilder = new VersionBuilder();
        $versionBuilder
            ->changeStatusTo($newStatus)
            ->updateFieldsTo($initialLanguageCode, $newFields)
            ->translateToAnyLanguageOf($languagesList)
            ->createFromAnyContentTypeOf($contentTypeIdsList);

        self::assertInstanceOf(VersionBuilder::class, $versionBuilder);
        self::assertEquals($expectedTargetVersion, $versionBuilder->build());
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace eZ\Publish\SPI\Tests\Limitation\Target\Builder;
10
11			use eZ\Publish\API\Repository\Values\Content\Field;
12			use eZ\Publish\API\Repository\Values\Content\VersionInfo;
13			use eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder;
14			use eZ\Publish\SPI\Limitation\Target;
15			use PHPUnit\Framework\TestCase;
16
17			/**
18			* @covers \eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder
19			*/
20			class VersionBuilderTest extends TestCase
21			{
22			/**
23			* Data provider for testBuild.
24			*
25			* @see testBuild
26			*
27			* @return array
28			*/
29			public function providerForTestBuild(): array
30			{
31			$versionStatuses = [
32			VersionInfo::STATUS_DRAFT,
33			VersionInfo::STATUS_PUBLISHED,
34			VersionInfo::STATUS_ARCHIVED,
35			];
36
37			$data = [];
38			foreach ($versionStatuses as $versionStatus) {
39			$languagesList = ['ger-DE', 'eng-US', 'eng-GB'];
40			$contentTypeIdsList = [1, 2];
41			$initialLanguageCode = 'eng-US';
42			$fields = [
43			new Field(['languageCode' => 'ger-DE']),
44			new Field(['languageCode' => 'ger-DE']),
45			new Field(['languageCode' => 'eng-US']),
46			];
47			$updateTranslationsLanguageCodes = ['ger-DE', 'eng-US'];
48
49			$data[] = [
50			new Target\Version(
51			[
52			'newStatus' => $versionStatus,
53			'allLanguageCodesList' => $languagesList,
54			'allContentTypeIdsList' => $contentTypeIdsList,
55			'forUpdateLanguageCodesList' => $updateTranslationsLanguageCodes,
56			'forUpdateInitialLanguageCode' => $initialLanguageCode,
57			]
58			),
59			$versionStatus,
60			$initialLanguageCode,
61			$fields,
62			$languagesList,
63			$contentTypeIdsList,
64			];
65
66			// no published content
67			$data[] = [
68			new Target\Version(
69			[
70			'newStatus' => $versionStatus,
71			'allLanguageCodesList' => $languagesList,
72			'allContentTypeIdsList' => $contentTypeIdsList,
73			'forUpdateLanguageCodesList' => $updateTranslationsLanguageCodes,
74			'forUpdateInitialLanguageCode' => $initialLanguageCode,
75			]
76			),
77			$versionStatus,
78			$initialLanguageCode,
79			$fields,
80			$languagesList,
81			$contentTypeIdsList,
82			];
83			}
84
85			return $data;
86			}
87
88			/**
89			* @covers \eZ\Publish\SPI\Limitation\Target\Builder\VersionBuilder::build
90			*
91			* @dataProvider providerForTestBuild
92			*
93			* @param \eZ\Publish\SPI\Limitation\Target\Version $expectedTargetVersion
94			* @param int $newStatus
95			* @param string $initialLanguageCode
96			* @param \eZ\Publish\API\Repository\Values\Content\Field[] $newFields
97			* @param string[] $languagesList
98			* @param int[] $contentTypeIdsList
99			*
100			* @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
101			*/
102			public function testBuild(
103			Target\Version $expectedTargetVersion,
104			int $newStatus,
105			string $initialLanguageCode,
106			array $newFields,
107			array $languagesList,
108			array $contentTypeIdsList
109			): void {
110			$versionBuilder = new VersionBuilder();
111			$versionBuilder
112			->changeStatusTo($newStatus)
113			->updateFieldsTo($initialLanguageCode, $newFields)
114			->translateToAnyLanguageOf($languagesList)
115			->createFromAnyContentTypeOf($contentTypeIdsList);
116
117			self::assertInstanceOf(VersionBuilder::class, $versionBuilder);
118			self::assertEquals($expectedTargetVersion, $versionBuilder->build());
119			}
120			}
121

ezsystems / ezpublish-kernel

Push — EZP-30548-Romanian_special_cha... ( 38d0c8...2c2658 )

VersionBuilderTest::providerForTestBuild() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like