eZ\Bundle\EzPublishCoreBundle\Imagine\Cache\Resolver\RelativeResolver

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	rewriteUrl()	0	4	1

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Bundle\EzPublishCoreBundle\Imagine\Cache\Resolver;

use Liip\ImagineBundle\Imagine\Cache\Resolver\ResolverInterface;
use Liip\ImagineBundle\Imagine\Cache\Resolver\ProxyResolver as ImagineProxyResolver;

/**
 * Relative resolver, omits host info.
 */
class RelativeResolver extends ImagineProxyResolver
{
    /**
     * @param \Liip\ImagineBundle\Imagine\Cache\Resolver\ResolverInterface $resolver
     */
    public function __construct(ResolverInterface $resolver)
    {
        parent::__construct($resolver, []);
    }

    /**
     * Returns relative image path.
     *
     * @param $url string
     * @return string
     */
    protected function rewriteUrl($url)
    {
        return parse_url($url, PHP_URL_PATH);

The expression parse_url($url, PHP_URL_PATH); of type string|false adds false to the return on line 33 which is incompatible with the return type of the parent method Liip\ImagineBundle\Imagine\Cache\Resolver\ProxyResolver::rewriteUrl of type string. It seems like you forgot to handle an error condition.

    }
}