Completed
Push — ezp-26146_location_swap_incons... ( 268337 )
by
unknown
82:52 queued 48:18
created
Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +26 added lines, -23 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
      *
92 92
      * @todo optimize
93 93
      *
94
-     * @param mixed $remoteId
94
+     * @param string $remoteId
95 95
      *
96 96
      * @return array
97 97
      */
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     /**
247 247
      * Returns data for the first level children of the location identified by given $locationId.
248 248
      *
249
-     * @param mixed $locationId
249
+     * @param integer $locationId
250 250
      *
251 251
      * @return array
252 252
      */
@@ -373,6 +373,9 @@  discard block
 block discarded – undo
373 373
         }
374 374
     }
375 375
 
376
+    /**
377
+     * @param string $pathString
378
+     */
376 379
     private function isHiddenByParent($pathString, array $rows)
377 380
     {
378 381
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -573,10 +576,10 @@  discard block
 block discarded – undo
573 576
      * Make the location identified by $locationId1 refer to the Content
574 577
      * referred to by $locationId2 and vice versa.
575 578
      *
576
-     * @param mixed $locationId1
577
-     * @param mixed $locationId2
579
+     * @param integer $locationId1
580
+     * @param integer $locationId2
578 581
      *
579
-     * @return bool
582
+     * @return false|null
580 583
      */
581 584
     public function swap($locationId1, $locationId2)
582 585
     {
@@ -777,7 +780,7 @@  discard block
 block discarded – undo
777 780
      * Create an entry in the node assignment table.
778 781
      *
779 782
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
780
-     * @param mixed $parentNodeId
783
+     * @param string $parentNodeId
781 784
      * @param int $type
782 785
      */
783 786
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -905,8 +908,8 @@  discard block
 block discarded – undo
905 908
      *
906 909
      * Convert existing node assignments into real locations.
907 910
      *
908
-     * @param mixed $contentId
909
-     * @param mixed $versionNo
911
+     * @param integer $contentId
912
+     * @param integer $versionNo
910 913
      */
911 914
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
912 915
     {
@@ -974,8 +977,8 @@  discard block
 block discarded – undo
974 977
     /**
975 978
      * Updates all Locations of content identified with $contentId with $versionNo.
976 979
      *
977
-     * @param mixed $contentId
978
-     * @param mixed $versionNo
980
+     * @param integer $contentId
981
+     * @param integer $versionNo
979 982
      */
980 983
     public function updateLocationsContentVersionNo($contentId, $versionNo)
981 984
     {
@@ -1134,8 +1137,8 @@  discard block
 block discarded – undo
1134 1137
      * the node identified by given $locationId (current main node).
1135 1138
      * Assumes that content has more than one location.
1136 1139
      *
1137
-     * @param mixed $contentId
1138
-     * @param mixed $locationId
1140
+     * @param integer $contentId
1141
+     * @param integer $locationId
1139 1142
      *
1140 1143
      * @return array
1141 1144
      */
@@ -1171,9 +1174,9 @@  discard block
 block discarded – undo
1171 1174
      *
1172 1175
      * The associated content object is left untouched.
1173 1176
      *
1174
-     * @param mixed $locationId
1177
+     * @param integer $locationId
1175 1178
      *
1176
-     * @return bool
1179
+     * @return boolean|null
1177 1180
      */
1178 1181
     public function trashLocation($locationId)
1179 1182
     {
@@ -1202,8 +1205,8 @@  discard block
 block discarded – undo
1202 1205
      * at the old position. If this is not possible ( because the old location
1203 1206
      * does not exist any more) and exception is thrown.
1204 1207
      *
1205
-     * @param mixed $locationId
1206
-     * @param mixed|null $newParentId
1208
+     * @param integer $locationId
1209
+     * @param integer $newParentId
1207 1210
      *
1208 1211
      * @return \eZ\Publish\SPI\Persistence\Content\Location
1209 1212
      */
@@ -1377,10 +1380,10 @@  discard block
 block discarded – undo
1377 1380
     /**
1378 1381
      * Set section on all content objects in the subtree.
1379 1382
      *
1380
-     * @param mixed $pathString
1381
-     * @param mixed $sectionId
1383
+     * @param string $pathString
1384
+     * @param integer $sectionId
1382 1385
      *
1383
-     * @return bool
1386
+     * @return boolean|null
1384 1387
      */
1385 1388
     public function setSectionForSubtree($pathString, $sectionId)
1386 1389
     {
@@ -1446,10 +1449,10 @@  discard block
 block discarded – undo
1446 1449
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
1447 1450
      * $contentId, $parentLocationId and $versionNo
1448 1451
      *
1449
-     * @param mixed $contentId
1450
-     * @param mixed $locationId
1451
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
1452
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
1452
+     * @param integer $contentId
1453
+     * @param integer $locationId
1454
+     * @param integer $versionNo version number, needed to update eznode_assignment table
1455
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
1453 1456
      *        eznode_assignment table
1454 1457
      */
1455 1458
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
      *
251 251
      * @param string $action
252 252
      * @param mixed $languageId
253
-     * @param mixed $newId
253
+     * @param integer $newId
254 254
      * @param mixed $parentId
255 255
      * @param string $textMD5
256 256
      */
@@ -447,8 +447,8 @@  discard block
 block discarded – undo
447 447
      *
448 448
      * Update includes history entries.
449 449
      *
450
-     * @param mixed $oldParentId
451
-     * @param mixed $newParentId
450
+     * @param integer $oldParentId
451
+     * @param integer $newParentId
452 452
      */
453 453
     public function reparent($oldParentId, $newParentId)
454 454
     {
@@ -594,7 +594,7 @@  discard block
 block discarded – undo
594 594
     /**
595 595
      * Returns next value for "id" column.
596 596
      *
597
-     * @return mixed
597
+     * @return string
598 598
      */
599 599
     public function getNextId()
600 600
     {
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
     /**
910 910
      * Deletes single custom alias row matched by composite primary key.
911 911
      *
912
-     * @param mixed $parentId
912
+     * @param integer $parentId
913 913
      * @param string $textMD5
914 914
      *
915 915
      * @return bool
@@ -947,10 +947,10 @@  discard block
 block discarded – undo
947 947
      *
948 948
      * If $id is set only autogenerated entries will be removed.
949 949
      *
950
-     * @param mixed $action
951
-     * @param mixed|null $id
950
+     * @param string $action
951
+     * @param integer $id
952 952
      *
953
-     * @return bool
953
+     * @return boolean|null
954 954
      */
955 955
     public function remove($action, $id = null)
956 956
     {
@@ -1040,7 +1040,7 @@  discard block
 block discarded – undo
1040 1040
      * @param mixed $locationId1
1041 1041
      * @param mixed $locationId2
1042 1042
      *
1043
-     * @return bool
1043
+     * @return false|null
1044 1044
      */
1045 1045
     public function swap($locationId1, $locationId2)
1046 1046
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php 1 patch
Doc Comments   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -101,8 +101,8 @@  discard block
 block discarded – undo
101 101
      * $alwaysAvailable controls whether the url alias is accessible in all
102 102
      * languages.
103 103
      *
104
-     * @param mixed $locationId
105
-     * @param mixed $parentLocationId
104
+     * @param integer $locationId
105
+     * @param integer $parentLocationId
106 106
      * @param string $name the new name computed by the name schema or url alias schema
107 107
      * @param string $languageCode
108 108
      * @param bool $alwaysAvailable
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      * If $languageCode is null the $alias is created in the system's default
232 232
      * language. $alwaysAvailable makes the alias available in all languages.
233 233
      *
234
-     * @param mixed $locationId
234
+     * @param integer $locationId
235 235
      * @param string $path
236 236
      * @param bool $forwarding
237 237
      * @param string $languageCode
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
     /**
394 394
      * List of user generated or autogenerated url entries, pointing to $locationId.
395 395
      *
396
-     * @param mixed $locationId
396
+     * @param integer $locationId
397 397
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
398 398
      *
399 399
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -522,9 +522,9 @@  discard block
 block discarded – undo
522 522
      *
523 523
      * This method triggers the change of the autogenerated aliases.
524 524
      *
525
-     * @param mixed $locationId
526
-     * @param mixed $oldParentId
527
-     * @param mixed $newParentId
525
+     * @param integer $locationId
526
+     * @param integer $oldParentId
527
+     * @param integer $newParentId
528 528
      */
529 529
     public function locationMoved($locationId, $oldParentId, $newParentId)
530 530
     {
@@ -552,9 +552,9 @@  discard block
 block discarded – undo
552 552
      *
553 553
      * This method triggers the creation of the autogenerated aliases for the copied locations
554 554
      *
555
-     * @param mixed $locationId
556
-     * @param mixed $newLocationId
557
-     * @param mixed $newParentId
555
+     * @param integer $locationId
556
+     * @param integer $newLocationId
557
+     * @param integer $newParentId
558 558
      */
559 559
     public function locationCopied($locationId, $newLocationId, $newParentId)
560 560
     {
@@ -580,7 +580,7 @@  discard block
 block discarded – undo
580 580
      * @param mixed $locationId1
581 581
      * @param mixed $locationId2
582 582
      *
583
-     * @return bool
583
+     * @return boolean|null
584 584
      */
585 585
     public function swap($locationId1, $locationId2)
586 586
     {
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
     /**
674 674
      * Notifies the underlying engine that a location was deleted or moved to trash.
675 675
      *
676
-     * @param mixed $locationId
676
+     * @param integer $locationId
677 677
      */
678 678
     public function locationDeleted($locationId)
679 679
     {
Please login to merge, or discard this patch.