SectionBase - Code Metrics - Inspection of "EZP-29385: Richtext : blockquote does not allow mu..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix_ezp29385 ( 36b56f...415bc3 )

unknown

created 2018-07-04 08:57 UTC

SectionBase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	395
Duplicated Lines	33.67 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
dl	133
loc	395
rs	10
c	0
b	0
f	0
wmc	26
lcom	1
cbo	8

21 Methods

Rating	Name	Duplication	Size	Complexity
A	testNewClass()	0	13	1
A	testMissingProperty()	0	9	2
A	testReadOnlyProperty()	0	9	2
A	testIsPropertySet()	0	9	1
A	testUnsetProperty()	0	9	2
A	testCreateSection()	18	18	1
A	testCreateSectionThrowsInvalidArgumentException()	0	10	1
A	testUpdateSection()	19	19	1
A	testUpdateSectionThrowsInvalidArgumentException()	0	12	1
A	testLoadSection()	15	15	1
A	testLoadSectionThrowsNotFoundException()	0	6	1
A	testLoadSections()	0	11	2
A	testLoadSectionByIdentifier()	15	15	1
A	testLoadSectionByIdentifierThrowsNotFoundException()	0	6	1
A	testCountAssignedContents()	0	18	1
A	testAssignSection()	16	16	1
A	testDeleteSection()	18	18	2
A	testDeleteSectionThrowsNotFoundException()	0	8	1
A	testDeleteSectionThrowsBadStateException()	0	8	1
A	testNewSectionCreateStruct()	16	16	1
A	testNewSectionUpdateStruct()	16	16	1

How to fix Duplicated Code

<?php

/**
 * File contains: eZ\Publish\Core\Repository\Tests\Service\Integration\SectionTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Repository\Tests\Service\Integration;

use eZ\Publish\Core\Repository\Tests\Service\Integration\Base as BaseServiceTest;
use eZ\Publish\API\Repository\Values\Content\Section;
use eZ\Publish\API\Repository\Exceptions\NotFoundException;
use eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException;
use eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException as PropertyNotFound;
use eZ\Publish\API\Repository\Tests\BaseTest as APIBaseTest;

/**
 * Test case for Section Service using InMemory storage class.
 */
abstract class SectionBase extends BaseServiceTest
{
    /**
     * Test a new class and default values on properties.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\Section::__construct
     */
    public function testNewClass()
    {
        $section = new Section();

        $this->assertPropertiesCorrect(
            array(
                'id' => null,
                'identifier' => null,
                'name' => null,
            ),
            $section
        );
    }

    /**
     * Test retrieving missing property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\Section::__get
     */
    public function testMissingProperty()
    {
        try {
            $section = new Section();
            $value = $section->notDefined;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            self::fail('Succeeded getting non existing property');
        } catch (PropertyNotFound $e) {

        }
    }

    /**
     * Test setting read only property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\Section::__set
     */
    public function testReadOnlyProperty()
    {
        try {
            $section = new Section();
            $section->id = 22;
            self::fail('Succeeded setting read only property');
        } catch (PropertyReadOnlyException $e) {

        }
    }

    /**
     * Test if property exists.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\Section::__isset
     */
    public function testIsPropertySet()
    {
        $section = new Section();
        $value = isset($section->notDefined);
        self::assertEquals(false, $value);

        $value = isset($section->id);
        self::assertEquals(true, $value);
    }

    /**
     * Test unsetting a property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\Section::__unset
     */
    public function testUnsetProperty()
    {
        $section = new Section(array('id' => 1));
        try {
            unset($section->id);
            self::fail('Unsetting read-only property succeeded');
        } catch (PropertyReadOnlyException $e) {

        }
    }

    /**
     * Test service function for creating sections.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::createSection
     */
    public function testCreateSection()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionCreateStruct = $sectionService->newSectionCreateStruct();
        $sectionCreateStruct->identifier = 'test';
        $sectionCreateStruct->name = 'Test';

        $createdSection = $sectionService->createSection($sectionCreateStruct);

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Section', $createdSection);
        self::assertGreaterThan(0, $createdSection->id);

        $this->assertStructPropertiesCorrect(
            $sectionCreateStruct,
            $createdSection
        );
    }

    /**
     * Test service function for creating sections throwing InvalidArgumentException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
     * @covers \eZ\Publish\Core\Repository\SectionService::createSection
     */
    public function testCreateSectionThrowsInvalidArgumentException()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionCreateStruct = $sectionService->newSectionCreateStruct();
        $sectionCreateStruct->identifier = 'standard';
        $sectionCreateStruct->name = 'Standard';

        $sectionService->createSection($sectionCreateStruct);
    }

    /**
     * Test service function for updating sections.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::updateSection
     */
    public function testUpdateSection()
    {
        $sectionService = $this->repository->getSectionService();

        $loadedSection = $sectionService->loadSection(1);

        $sectionUpdateStruct = $sectionService->newSectionUpdateStruct();
        $sectionUpdateStruct->identifier = 'test';
        $sectionUpdateStruct->name = 'Test';

        $updatedSection = $sectionService->updateSection($loadedSection, $sectionUpdateStruct);

        self::assertEquals($loadedSection->id, $updatedSection->id);

        $this->assertStructPropertiesCorrect(
            $sectionUpdateStruct,
            $updatedSection
        );
    }

    /**
     * Test service function for updating sections.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
     * @covers \eZ\Publish\Core\Repository\SectionService::updateSection
     */
    public function testUpdateSectionThrowsInvalidArgumentException()
    {
        $sectionService = $this->repository->getSectionService();

        $loadedSection = $sectionService->loadSectionByIdentifier('standard');

        $sectionUpdateStruct = $sectionService->newSectionUpdateStruct();
        $sectionUpdateStruct->identifier = 'media';
        $sectionUpdateStruct->name = 'Media';

        $sectionService->updateSection($loadedSection, $sectionUpdateStruct);
    }

    /**
     * Test service function for loading sections.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::loadSection
     */
    public function testLoadSection()
    {
        $sectionService = $this->repository->getSectionService();

        $section = $sectionService->loadSection(1);

        $this->assertPropertiesCorrect(
            array(
                'id' => 1,
                'name' => 'Standard',
                'identifier' => 'standard',
            ),
            $section
        );
    }

    /**
     * Test service function for loading sections throwing NotFoundException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\Core\Repository\SectionService::loadSection
     */
    public function testLoadSectionThrowsNotFoundException()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionService->loadSection(APIBaseTest::DB_INT_MAX);
    }

    /**
     * Test service function for loading all sections.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::loadSections
     */
    public function testLoadSections()
    {
        $sections = $this->repository->getSectionService()->loadSections();

        self::assertInternalType('array', $sections);
        self::assertGreaterThan(0, count($sections));

        foreach ($sections as $section) {
            self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Section', $section);
        }
    }

    /**
     * Test service function for loading section by identifier.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::loadSectionByIdentifier
     */
    public function testLoadSectionByIdentifier()
    {
        $sectionService = $this->repository->getSectionService();

        $section = $sectionService->loadSectionByIdentifier('standard');

        $this->assertPropertiesCorrect(
            array(
                'id' => 1,
                'name' => 'Standard',
                'identifier' => 'standard',
            ),
            $section
        );
    }

    /**
     * Test service function for loading section by identifier throwing NotFoundException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\Core\Repository\SectionService::loadSectionByIdentifier
     */
    public function testLoadSectionByIdentifierThrowsNotFoundException()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionService->loadSectionByIdentifier('non-existing');
    }

    /**
     * Test service function for counting content assigned to section.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::countAssignedContents
     */
    public function testCountAssignedContents()
    {
        $sectionService = $this->repository->getSectionService();

        $section = $sectionService->loadSection(1);
        $contentCount = $sectionService->countAssignedContents($section);


        self::assertGreaterThan(0, $contentCount);

        $sectionCreateStruct = $sectionService->newSectionCreateStruct();
        $sectionCreateStruct->identifier = 'test';
        $sectionCreateStruct->name = 'Test';

        $newSection = $sectionService->createSection($sectionCreateStruct);
        $contentCount = $sectionService->countAssignedContents($newSection);


        self::assertEquals(0, $contentCount);
    }

    /**
     * Test service function for assigning section to content.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::assignSection
     */
    public function testAssignSection()
    {
        $sectionService = $this->repository->getSectionService();
        $contentService = $this->repository->getContentService();

        $section = $sectionService->loadSection(1);
        $contentInfo = $contentService->loadContentInfo(4);

        self::assertEquals(2, $contentInfo->sectionId);

        $sectionService->assignSection($contentInfo, $section);

        $contentInfo = $contentService->loadContentInfo(4);

        self::assertEquals($section->id, $contentInfo->sectionId);
    }

    /**
     * Test service function for deleting sections.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
     */
    public function testDeleteSection()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionCreateStruct = $sectionService->newSectionCreateStruct();
        $sectionCreateStruct->identifier = 'test';
        $sectionCreateStruct->name = 'Test';

        $newSection = $sectionService->createSection($sectionCreateStruct);
        $sectionService->deleteSection($newSection);

        try {
            $sectionService->loadSection($newSection->id);
            self::fail('Section is still returned after being deleted');
        } catch (NotFoundException $e) {
            // Do nothing
        }
    }

    /**
     * Test service function for deleting sections throwing NotFoundException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
     */
    public function testDeleteSectionThrowsNotFoundException()
    {
        $sectionService = $this->repository->getSectionService();

        $section = new Section(array('id' => APIBaseTest::DB_INT_MAX));

        $sectionService->deleteSection($section);
    }

    /**
     * Test service function for deleting sections throwing BadStateException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\BadStateException
     * @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
     */
    public function testDeleteSectionThrowsBadStateException()
    {
        $sectionService = $this->repository->getSectionService();

        $section = $sectionService->loadSection(1);

        $sectionService->deleteSection($section);
    }

    /**
     * Test service function for creating new SectionCreateStruct.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::newSectionCreateStruct
     */
    public function testNewSectionCreateStruct()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionCreateStruct = $sectionService->newSectionCreateStruct();

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\SectionCreateStruct', $sectionCreateStruct);

        $this->assertPropertiesCorrect(
            array(
                'identifier' => null,
                'name' => null,
            ),
            $sectionCreateStruct
        );
    }

    /**
     * Test service function for creating new SectionUpdateStruct.
     *
     * @covers \eZ\Publish\Core\Repository\SectionService::newSectionUpdateStruct
     */
    public function testNewSectionUpdateStruct()
    {
        $sectionService = $this->repository->getSectionService();

        $sectionUpdateStruct = $sectionService->newSectionUpdateStruct();

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\SectionUpdateStruct', $sectionUpdateStruct);

        $this->assertPropertiesCorrect(
            array(
                'identifier' => null,
                'name' => null,
            ),
            $sectionUpdateStruct
        );
    }
}


1		<?php
2
3		/**
4		* File contains: eZ\Publish\Core\Repository\Tests\Service\Integration\SectionTest class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Repository\Tests\Service\Integration;
10
11		use eZ\Publish\Core\Repository\Tests\Service\Integration\Base as BaseServiceTest;
12		use eZ\Publish\API\Repository\Values\Content\Section;
13		use eZ\Publish\API\Repository\Exceptions\NotFoundException;
14		use eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException;
15		use eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException as PropertyNotFound;
16		use eZ\Publish\API\Repository\Tests\BaseTest as APIBaseTest;
17
18		/**
19		* Test case for Section Service using InMemory storage class.
20		*/
21		abstract class SectionBase extends BaseServiceTest
22		{
23		/**
24		* Test a new class and default values on properties.
25		*
26		* @covers \eZ\Publish\API\Repository\Values\Content\Section::__construct
27		*/
28		public function testNewClass()
29		{
30		$section = new Section();
31
32		$this->assertPropertiesCorrect(
33		array(
34		'id' => null,
35		'identifier' => null,
36		'name' => null,
37		),
38		$section
39		);
40		}
41
42		/**
43		* Test retrieving missing property.
44		*
45		* @covers \eZ\Publish\API\Repository\Values\Content\Section::__get
46		*/
47		public function testMissingProperty()
48		{
49		try {
50		$section = new Section();
51		$value = $section->notDefined;
		0 ignored issues – show Documentation introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report The property `notDefined` does not exist on `object<eZ\Publish\API\Re...Values\Content\Section>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Unused Code introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52		self::fail('Succeeded getting non existing property');
53		} catch (PropertyNotFound $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
54		}
55		}
56
57		/**
58		* Test setting read only property.
59		*
60		* @covers \eZ\Publish\API\Repository\Values\Content\Section::__set
61		*/
62		public function testReadOnlyProperty()
63		{
64		try {
65		$section = new Section();
66		$section->id = 22;
67		self::fail('Succeeded setting read only property');
68		} catch (PropertyReadOnlyException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
69		}
70		}
71
72		/**
73		* Test if property exists.
74		*
75		* @covers \eZ\Publish\API\Repository\Values\Content\Section::__isset
76		*/
77		public function testIsPropertySet()
78		{
79		$section = new Section();
80		$value = isset($section->notDefined);
81		self::assertEquals(false, $value);
82
83		$value = isset($section->id);
84		self::assertEquals(true, $value);
85		}
86
87		/**
88		* Test unsetting a property.
89		*
90		* @covers \eZ\Publish\API\Repository\Values\Content\Section::__unset
91		*/
92		public function testUnsetProperty()
93		{
94		$section = new Section(array('id' => 1));
95		try {
96		unset($section->id);
97		self::fail('Unsetting read-only property succeeded');
98		} catch (PropertyReadOnlyException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
99		}
100		}
101
102		/**
103		* Test service function for creating sections.
104		*
105		* @covers \eZ\Publish\Core\Repository\SectionService::createSection
106		*/
107	View Code Duplication	public function testCreateSection()
108		{
109		$sectionService = $this->repository->getSectionService();
110
111		$sectionCreateStruct = $sectionService->newSectionCreateStruct();
112		$sectionCreateStruct->identifier = 'test';
113		$sectionCreateStruct->name = 'Test';
114
115		$createdSection = $sectionService->createSection($sectionCreateStruct);
116
117		self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Section', $createdSection);
118		self::assertGreaterThan(0, $createdSection->id);
119
120		$this->assertStructPropertiesCorrect(
121		$sectionCreateStruct,
122		$createdSection
123		);
124		}
125
126		/**
127		* Test service function for creating sections throwing InvalidArgumentException.
128		*
129		* @expectedException \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
130		* @covers \eZ\Publish\Core\Repository\SectionService::createSection
131		*/
132		public function testCreateSectionThrowsInvalidArgumentException()
133		{
134		$sectionService = $this->repository->getSectionService();
135
136		$sectionCreateStruct = $sectionService->newSectionCreateStruct();
137		$sectionCreateStruct->identifier = 'standard';
138		$sectionCreateStruct->name = 'Standard';
139
140		$sectionService->createSection($sectionCreateStruct);
141		}
142
143		/**
144		* Test service function for updating sections.
145		*
146		* @covers \eZ\Publish\Core\Repository\SectionService::updateSection
147		*/
148	View Code Duplication	public function testUpdateSection()
149		{
150		$sectionService = $this->repository->getSectionService();
151
152		$loadedSection = $sectionService->loadSection(1);
153
154		$sectionUpdateStruct = $sectionService->newSectionUpdateStruct();
155		$sectionUpdateStruct->identifier = 'test';
156		$sectionUpdateStruct->name = 'Test';
157
158		$updatedSection = $sectionService->updateSection($loadedSection, $sectionUpdateStruct);
159
160		self::assertEquals($loadedSection->id, $updatedSection->id);
161
162		$this->assertStructPropertiesCorrect(
163		$sectionUpdateStruct,
164		$updatedSection
165		);
166		}
167
168		/**
169		* Test service function for updating sections.
170		*
171		* @expectedException \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
172		* @covers \eZ\Publish\Core\Repository\SectionService::updateSection
173		*/
174		public function testUpdateSectionThrowsInvalidArgumentException()
175		{
176		$sectionService = $this->repository->getSectionService();
177
178		$loadedSection = $sectionService->loadSectionByIdentifier('standard');
179
180		$sectionUpdateStruct = $sectionService->newSectionUpdateStruct();
181		$sectionUpdateStruct->identifier = 'media';
182		$sectionUpdateStruct->name = 'Media';
183
184		$sectionService->updateSection($loadedSection, $sectionUpdateStruct);
185		}
186
187		/**
188		* Test service function for loading sections.
189		*
190		* @covers \eZ\Publish\Core\Repository\SectionService::loadSection
191		*/
192	View Code Duplication	public function testLoadSection()
193		{
194		$sectionService = $this->repository->getSectionService();
195
196		$section = $sectionService->loadSection(1);
197
198		$this->assertPropertiesCorrect(
199		array(
200		'id' => 1,
201		'name' => 'Standard',
202		'identifier' => 'standard',
203		),
204		$section
205		);
206		}
207
208		/**
209		* Test service function for loading sections throwing NotFoundException.
210		*
211		* @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
212		* @covers \eZ\Publish\Core\Repository\SectionService::loadSection
213		*/
214		public function testLoadSectionThrowsNotFoundException()
215		{
216		$sectionService = $this->repository->getSectionService();
217
218		$sectionService->loadSection(APIBaseTest::DB_INT_MAX);
219		}
220
221		/**
222		* Test service function for loading all sections.
223		*
224		* @covers \eZ\Publish\Core\Repository\SectionService::loadSections
225		*/
226		public function testLoadSections()
227		{
228		$sections = $this->repository->getSectionService()->loadSections();
229
230		self::assertInternalType('array', $sections);
231		self::assertGreaterThan(0, count($sections));
232
233		foreach ($sections as $section) {
234		self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Section', $section);
235		}
236		}
237
238		/**
239		* Test service function for loading section by identifier.
240		*
241		* @covers \eZ\Publish\Core\Repository\SectionService::loadSectionByIdentifier
242		*/
243	View Code Duplication	public function testLoadSectionByIdentifier()
244		{
245		$sectionService = $this->repository->getSectionService();
246
247		$section = $sectionService->loadSectionByIdentifier('standard');
248
249		$this->assertPropertiesCorrect(
250		array(
251		'id' => 1,
252		'name' => 'Standard',
253		'identifier' => 'standard',
254		),
255		$section
256		);
257		}
258
259		/**
260		* Test service function for loading section by identifier throwing NotFoundException.
261		*
262		* @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
263		* @covers \eZ\Publish\Core\Repository\SectionService::loadSectionByIdentifier
264		*/
265		public function testLoadSectionByIdentifierThrowsNotFoundException()
266		{
267		$sectionService = $this->repository->getSectionService();
268
269		$sectionService->loadSectionByIdentifier('non-existing');
270		}
271
272		/**
273		* Test service function for counting content assigned to section.
274		*
275		* @covers \eZ\Publish\Core\Repository\SectionService::countAssignedContents
276		*/
277		public function testCountAssignedContents()
278		{
279		$sectionService = $this->repository->getSectionService();
280
281		$section = $sectionService->loadSection(1);
282		$contentCount = $sectionService->countAssignedContents($section);
		0 ignored issues – show Deprecated Code introduced 2015-11-26 11:30 UTC by Report Bug Copy Issue Report The method `eZ\Publish\API\Repositor...countAssignedContents()` has been deprecated with message: since 6.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
283
284		self::assertGreaterThan(0, $contentCount);
285
286		$sectionCreateStruct = $sectionService->newSectionCreateStruct();
287		$sectionCreateStruct->identifier = 'test';
288		$sectionCreateStruct->name = 'Test';
289
290		$newSection = $sectionService->createSection($sectionCreateStruct);
291		$contentCount = $sectionService->countAssignedContents($newSection);
		0 ignored issues – show Deprecated Code introduced 2015-11-26 11:30 UTC by Report Bug Copy Issue Report The method `eZ\Publish\API\Repositor...countAssignedContents()` has been deprecated with message: since 6.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
292
293		self::assertEquals(0, $contentCount);
294		}
295
296		/**
297		* Test service function for assigning section to content.
298		*
299		* @covers \eZ\Publish\Core\Repository\SectionService::assignSection
300		*/
301	View Code Duplication	public function testAssignSection()
302		{
303		$sectionService = $this->repository->getSectionService();
304		$contentService = $this->repository->getContentService();
305
306		$section = $sectionService->loadSection(1);
307		$contentInfo = $contentService->loadContentInfo(4);
308
309		self::assertEquals(2, $contentInfo->sectionId);
310
311		$sectionService->assignSection($contentInfo, $section);
312
313		$contentInfo = $contentService->loadContentInfo(4);
314
315		self::assertEquals($section->id, $contentInfo->sectionId);
316		}
317
318		/**
319		* Test service function for deleting sections.
320		*
321		* @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
322		*/
323	View Code Duplication	public function testDeleteSection()
324		{
325		$sectionService = $this->repository->getSectionService();
326
327		$sectionCreateStruct = $sectionService->newSectionCreateStruct();
328		$sectionCreateStruct->identifier = 'test';
329		$sectionCreateStruct->name = 'Test';
330
331		$newSection = $sectionService->createSection($sectionCreateStruct);
332		$sectionService->deleteSection($newSection);
333
334		try {
335		$sectionService->loadSection($newSection->id);
336		self::fail('Section is still returned after being deleted');
337		} catch (NotFoundException $e) {
338		// Do nothing
339		}
340		}
341
342		/**
343		* Test service function for deleting sections throwing NotFoundException.
344		*
345		* @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
346		* @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
347		*/
348		public function testDeleteSectionThrowsNotFoundException()
349		{
350		$sectionService = $this->repository->getSectionService();
351
352		$section = new Section(array('id' => APIBaseTest::DB_INT_MAX));
353
354		$sectionService->deleteSection($section);
355		}
356
357		/**
358		* Test service function for deleting sections throwing BadStateException.
359		*
360		* @expectedException \eZ\Publish\API\Repository\Exceptions\BadStateException
361		* @covers \eZ\Publish\Core\Repository\SectionService::deleteSection
362		*/
363		public function testDeleteSectionThrowsBadStateException()
364		{
365		$sectionService = $this->repository->getSectionService();
366
367		$section = $sectionService->loadSection(1);
368
369		$sectionService->deleteSection($section);
370		}
371
372		/**
373		* Test service function for creating new SectionCreateStruct.
374		*
375		* @covers \eZ\Publish\Core\Repository\SectionService::newSectionCreateStruct
376		*/
377	View Code Duplication	public function testNewSectionCreateStruct()
378		{
379		$sectionService = $this->repository->getSectionService();
380
381		$sectionCreateStruct = $sectionService->newSectionCreateStruct();
382
383		self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\SectionCreateStruct', $sectionCreateStruct);
384
385		$this->assertPropertiesCorrect(
386		array(
387		'identifier' => null,
388		'name' => null,
389		),
390		$sectionCreateStruct
391		);
392		}
393
394		/**
395		* Test service function for creating new SectionUpdateStruct.
396		*
397		* @covers \eZ\Publish\Core\Repository\SectionService::newSectionUpdateStruct
398		*/
399	View Code Duplication	public function testNewSectionUpdateStruct()
400		{
401		$sectionService = $this->repository->getSectionService();
402
403		$sectionUpdateStruct = $sectionService->newSectionUpdateStruct();
404
405		self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\SectionUpdateStruct', $sectionUpdateStruct);
406
407		$this->assertPropertiesCorrect(
408		array(
409		'identifier' => null,
410		'name' => null,
411		),
412		$sectionUpdateStruct
413		);
414		}
415		}
416

ezsystems / ezpublish-kernel

Push — fix_ezp29385 ( 36b56f...415bc3 )

SectionBase A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like