Social - Code Metrics - eyecatchup/SEOstats - Measure and Improve Code Quality continuously with Scrutinizer

Social A
last analyzed 2016-07-15 22:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	227
Duplicated Lines	31.28 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes	4
Bugs	3	Features	2

Metric	Value
wmc	28
c	4
b	3
f	2
lcom	0
cbo	2
dl	71
loc	227
ccs	0
cts	82
cp	0
rs	10

12 Methods

Rating	Name	Duplication	Size	Complexity
A	getGoogleShares()	0	3	1
A	getGooglePlusShares()	0	9	3
A	getFacebookShares()	11	11	2
A	getTwitterShares()	10	10	2
A	getDeliciousShares()	10	10	2
A	getDeliciousTopTags()	0	16	4
A	getDiggShares()	10	10	2
A	getLinkedInShares()	10	10	2
A	getPinterestShares()	10	10	2
A	getStumbleUponShares()	0	11	3
A	getVKontakteShares()	10	10	2
A	getXingShares()	0	19	3

How to fix Duplicated Code

<?php
namespace SEOstats\Services;

/**
 *  SEOstats extension for Social-Media data.
 *
 * @package    SEOstats
 * @author     Stephan Schmitz <[email protected]>
 * @copyright  Copyright (c) 2010 - present Stephan Schmitz
 * @license    http://eyecatchup.mit-license.org/  MIT License
 * @updated    2014/01/19
 */

use SEOstats\SEOstats as SEOstats;
use SEOstats\Config as Config;
use SEOstats\Helper as Helper;

class Social extends SEOstats
{
    /**
     * For backward compatibility
     * @deprecated
     */
    public static function getGoogleShares($url = false) {
        return self::getGooglePlusShares($url);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
    /**
     * Returns the total count of +1s for $url on Google+.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of Plus Ones for a URL.
     */
    public static function getGooglePlusShares($url = false)
    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::GOOGLE_PLUSONE_URL, urlencode($url));
        $html    = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        @preg_match_all('/window\.__SSR\s\=\s\{c:\s(\d+?)\./', $html, $match, PREG_SET_ORDER);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return (1 === sizeof($match) && 2 === sizeof($match[0])) ? intval($match[0][1]) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns an array of interaction counts (shares, likes, comments, clicks) for $url on Facebook.
     *
     * @access        public
     * @link          http://developers.facebook.com/docs/reference/fql/link_stat/
     * @param   url   string     The URL to check.
     * @return        array      Returns an array of total counts for 1. all Facebook interactions,
     *                           2. FB shares, 3. FB likes, 4. FB comments and 5. outgoing clicks for a URL.
     */
    public static function getFacebookShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $fql     = sprintf('SELECT total_count, share_count, like_count, comment_count, commentsbox_count, click_count FROM link_stat WHERE url="%s"', $url);
        $dataUrl = sprintf(Config\Services::FB_LINKSTATS_URL, rawurlencode($fql));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode($jsonData, true);

        return isset($phpArray[0]) ? $phpArray[0] : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of mentions of $url on Twitter.
     *
     * @access       public
     * @param   url  string             The URL to check.
     * @return       integer            Returns the total count of Twitter mentions for a URL.
     * @link         https://dev.twitter.com/discussions/5653#comment-11514
     */
    public static function getTwitterShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::TWEETCOUNT_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode($jsonData, true);

        return isset($phpArray['count']) ? intval($phpArray['count']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of shares for $url via Delicious.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getDeliciousShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::DELICIOUS_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode($jsonData, true);

        return isset($phpArray[0]['total_posts']) ? intval($phpArray[0]['total_posts']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the Top10 tags for $url from Delicious.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        array      Returns the top ten delicious tags for a URL (if exist; else an empty array).
     */
    public static function getDeliciousTopTags($url = false)
    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::DELICIOUS_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode($jsonData, true);

        $ret = array();
        if (isset($phpArray[0]['top_tags']) && 0 < sizeof($phpArray[0]['top_tags'])) {
            foreach($phpArray[0]['top_tags'] as $k => $v) {
                $ret[] = $k;
            }
        }
        return $ret;
    }

    /**
     * Returns the total count of shares for $url via Digg.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getDiggShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::DIGG_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode(substr($jsonData, 2, -2), true);

        return isset($phpArray['diggs']) ? intval($phpArray['diggs']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of shares for $url via LinkedIn.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getLinkedInShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::LINKEDIN_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode(substr($jsonData, 2, -2), true);

        return isset($phpArray['count']) ? intval($phpArray['count']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of shares for $url via Pinterest.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getPinterestShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::PINTEREST_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode(substr($jsonData, 2, -1), true);

        return isset($phpArray['count']) ? intval($phpArray['count']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of shares for $url via StumpleUpon.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getStumbleUponShares($url = false)
    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::STUMBLEUPON_INFO_URL, urlencode($url));

        $jsonData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $phpArray = Helper\Json::decode($jsonData, true);

        return isset($phpArray['result']['in_index']) && true == $phpArray['result']['in_index']
            ? intval($phpArray['result']['views']) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns the total count of shares for $url via VKontakte.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        integer    Returns the total count of URL shares.
     */
    public static function getVKontakteShares($url = false)

    {
        $url     = parent::getUrl($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::VKONTAKTE_INFO_URL, urlencode($url));

        $htmlData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        @preg_match_all('#^VK\.Share\.count\(1, (\d+)\);$#si', $htmlData, $matches);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return isset($matches[1][0]) ? intval($matches[1][0]) : parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns an array of interaction counts (shares, comments, clicks, reach) for host of $url on Xing.
     *
     * @access        public
     * @param   url   string     The URL to check.
     * @return        array      Returns URL shares, comments, clicks and 'reach'.
     * @link          https://blog.xing.com/2012/01/xing-share-button/ Return values explained (German)
     */
    public static function getXingShares($url = false)
    {
        $host    = parent::getHost($url);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $dataUrl = sprintf(Config\Services::XING_SHAREBUTTON_URL, urlencode($host));

        $htmlData = parent::_getPage($dataUrl);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        @preg_match_all('/\r?\n(\d+)\r?\n/s', $htmlData, $matches);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        if (isset($matches[1]) && 4 == sizeof($matches[1])) {
            return array(
                'shares'   => intval($matches[1][0]),
                'comments' => intval($matches[1][1]),
                'clicks'   => intval($matches[1][2]),
                'reach'    => intval($matches[1][3]),
            );
        }

        return parent::noDataDefaultValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2			namespace SEOstats\Services;
3
4			/**
5			* SEOstats extension for Social-Media data.
6			*
7			* @package SEOstats
8			* @author Stephan Schmitz <[email protected]>
9			* @copyright Copyright (c) 2010 - present Stephan Schmitz
10			* @license http://eyecatchup.mit-license.org/ MIT License
11			* @updated 2014/01/19
12			*/
13
14			use SEOstats\SEOstats as SEOstats;
15			use SEOstats\Config as Config;
16			use SEOstats\Helper as Helper;
17
18			class Social extends SEOstats
19			{
20			/**
21			* For backward compatibility
22			* @deprecated
23			*/
24			public static function getGoogleShares($url = false) {
25			return self::getGooglePlusShares($url);
			0 ignored issues – show Documentation introduced 2016-02-03 09:33 UTC by Report Bug Copy Issue Report `$url` is of type `boolean`, but the function expects a `false\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			}
27			/**
28			* Returns the total count of +1s for $url on Google+.
29			*
30			* @access public
31			* @param url string The URL to check.
32			* @return integer Returns the total count of Plus Ones for a URL.
33			*/
34			public static function getGooglePlusShares($url = false)
35			{
36			$url = parent::getUrl($url);
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-03 09:33 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getUrl()` instead of `getGooglePlusShares()`). Are you sure this is correct? If so, you might want to change this to `$this->getUrl()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Bug introduced 2016-02-06 15:51 UTC by Report Bug Copy Issue Report It seems like `$url` defined by `parent::getUrl($url)` on line `36` can also be of type `string`; however, `SEOstats\SEOstats::getUrl()` does only seem to accept `boolean`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37			$dataUrl = sprintf(Config\Services::GOOGLE_PLUSONE_URL, urlencode($url));
38			$html = parent::_getPage($dataUrl);

eyecatchup / SEOstats

Social A last analyzed 2016-07-15 22:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Social A
last analyzed 2016-07-15 22:55 UTC