PhpStanRelatedTest::testRelatedMethods() - Code Metrics - Inspection of "Fix tests and small logic change" - exussum12/coverageChecker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3f2b6b...56185f )

by Scott

created 2017-10-05 18:25 UTC

PhpStanRelatedTest::testRelatedMethods() A

↳ Parent: PhpStanRelatedTest

Complexity

Conditions	2
Paths	3

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	2
eloc	15
c	1
b	0
f	1
nc	3
nop	0
dl	0
loc	21
rs	9.3142

<?php
namespace exussum12\CoverageChecker\tests;

use Exception;
use PHPUnit\Framework\TestCase;

class PhpStanRelatedTest extends TestCase
{
    public function testRelatedMethods()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $GLOBALS['argv'] = [
            'diffFilter',
            '--phpstan',
            '--autoload=' . __DIR__ . '/fixtures/phpstanTypeError.php',
            __DIR__ . '/fixtures/addTypeError.txt',
            __DIR__ . '/fixtures/phpstanTypeError.txt'
        ];

        try {
            ob_start();
            require(__DIR__ . "/../src/Runners/generic.php");
        } catch (Exception $exception) {
            $output = ob_get_clean();
            $this->assertContains('used test.php', $output);
            return true;
        }

        $this->fail('Exception not thrown when Expected');
    }
}


1			<?php
2			namespace exussum12\CoverageChecker\tests;
3
4			use Exception;
5			use PHPUnit\Framework\TestCase;
6
7			class PhpStanRelatedTest extends TestCase
8			{
9			public function testRelatedMethods()
			0 ignored issues – show Coding Style introduced 2017-10-02 21:58 UTC by Report Bug Copy Issue Report `testRelatedMethods` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
10			{
11			$GLOBALS['argv'] = [
12			'diffFilter',
13			'--phpstan',
14			'--autoload=' . __DIR__ . '/fixtures/phpstanTypeError.php',
15			__DIR__ . '/fixtures/addTypeError.txt',
16			__DIR__ . '/fixtures/phpstanTypeError.txt'
17			];
18
19			try {
20			ob_start();
21			require(__DIR__ . "/../src/Runners/generic.php");
22			} catch (Exception $exception) {
23			$output = ob_get_clean();
24			$this->assertContains('used test.php', $output);
25			return true;
26			}
27
28			$this->fail('Exception not thrown when Expected');
29			}
30			}
31

exussum12 / coverageChecker

Push — master ( 3f2b6b...56185f )

PhpStanRelatedTest::testRelatedMethods() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like