CheckstyleLoader::handleNotFoundFile() - Code Metrics - Inspection of "Phan" - exussum12/coverageChecker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Scott

created 2017-09-10 10:25 UTC

CheckstyleLoader::handleNotFoundFile() A

↳ Parent: CheckstyleLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
namespace exussum12\CoverageChecker;

use XMLReader;

/**
 * Class CheckstyleLoader
 * Used for reading in a report in checkstyle format
 * @package exussum12\CoverageChecker
 */
class CheckstyleLoader implements FileChecker
{
    /**
     * @var string
     */
    protected $file;
    /**
     * @var array
     */
    protected $coveredLines;

    /**
     * XMLReport constructor.
     * @param string $file the path the to phpunit clover file
     */
    public function __construct($file)
    {
        $this->file = $file;
    }

    /**
     * {@inheritdoc}
     */
    public function getLines()
    {
        $this->coveredLines = [];
        $reader = new XMLReader;
        $reader->open($this->file);
        $currentFile = '';
        while ($reader->read()) {
            if ((
                $reader->name === "file" &&
                $reader->nodeType == XMLReader::ELEMENT
            )) {
                $currentFile = $reader->getAttribute('name');
                $trim = './';
                $currentFile = substr($currentFile, strlen($trim));
                $this->coveredLines[$currentFile] = [];
            }

            if ($reader->name === "error") {

                $this->coveredLines
                    [$currentFile]
                    [$reader->getAttribute('line')]
                    = $reader->getAttribute("message");
            }
        }

        return $this->coveredLines;
    }

    /**
     * {@inheritdoc}
     */
    public function isValidLine($file, $line)
    {
        return empty($this->coveredLines[$file][$line]);
    }

    /**
     * {@inheritdoc}
     */
    public function handleNotFoundFile()
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public static function getDescription()
    {
        return 'Parses a report in checkstyle format';
    }
}


1		<?php
2		namespace exussum12\CoverageChecker;
3
4		use XMLReader;
5
6		/**
7		* Class CheckstyleLoader
8		* Used for reading in a report in checkstyle format
9		* @package exussum12\CoverageChecker
10		*/
11		class CheckstyleLoader implements FileChecker
12		{
13		/**
14		* @var string
15		*/
16		protected $file;
17		/**
18		* @var array
19		*/
20		protected $coveredLines;
21
22		/**
23		* XMLReport constructor.
24		* @param string $file the path the to phpunit clover file
25		*/
26		public function __construct($file)
27		{
28		$this->file = $file;
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34		public function getLines()
35		{
36		$this->coveredLines = [];
37		$reader = new XMLReader;
38		$reader->open($this->file);
39		$currentFile = '';
40		while ($reader->read()) {
41		if ((
42		$reader->name === "file" &&
43		$reader->nodeType == XMLReader::ELEMENT
44		)) {
45		$currentFile = $reader->getAttribute('name');
46		$trim = './';
47		$currentFile = substr($currentFile, strlen($trim));
48		$this->coveredLines[$currentFile] = [];
49		}
50
51	View Code Duplication	if ($reader->name === "error") {
		0 ignored issues – show Duplication introduced 2017-09-10 10:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		$this->coveredLines
53		[$currentFile]
54		[$reader->getAttribute('line')]
55		= $reader->getAttribute("message");
56		}
57		}
58
59		return $this->coveredLines;
60		}
61
62		/**
63		* {@inheritdoc}
64		*/
65		public function isValidLine($file, $line)
66		{
67		return empty($this->coveredLines[$file][$line]);
68		}
69
70		/**
71		* {@inheritdoc}
72		*/
73		public function handleNotFoundFile()
74		{
75		return true;
76		}
77
78		/**
79		* {@inheritdoc}
80		*/
81		public static function getDescription()
82		{
83		return 'Parses a report in checkstyle format';
84		}
85		}
86

exussum12 / coverageChecker

Pull Request — master (#14)

CheckstyleLoader::handleNotFoundFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like