Harmonic::getStringLengthsFromNumber() - Code Metrics - Inspection of "Add Harmonic::getStringLengthsFromNumber" - extended-strings/strings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a935a...3298fc )

by Patrick

created 2017-05-27 20:52 UTC

Harmonic::getStringLengthsFromNumber() A

↳ Parent: Harmonic

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1

<?php

declare(strict_types=1);

namespace ExtendedStrings\Strings;

class Harmonic
{
    private $halfStop;
    private $baseStop;

    /**
     * @param float $halfStop
     * @param float $baseStop
     */
    public function __construct(float $halfStop, float $baseStop = 1.0)
    {
        if ($halfStop > $baseStop) {
            throw new \InvalidArgumentException("The half-stop's string length cannot be longer than the base stop's.");
        }

        $this->baseStop = $baseStop;
        $this->halfStop = $halfStop;
    }

    /**
     * @param \ExtendedStrings\Strings\VibratingString $string
     *
     * @return float
     */
    public function getSoundingPitch(VibratingString $string): float
    {
        // Transpose the half-stop onto the new string length, which was formed
        // by the stop.
        $pseudoString = new VibratingString($string->getStoppedFrequency($this->baseStop));
        $pseudoHalfStop = $this->halfStop / $this->baseStop;

        return $pseudoString->getHarmonicSoundingFrequency($pseudoHalfStop);
    }

    /**
     * @param int $number
     *
     * @return float[]
     */
    public static function getStringLengthsFromNumber(int $number): array
    {
        $harmonics = [];
        for ($numerator = 1; $numerator <= $number; $numerator++) {
            if ((int) Math::gcd($numerator, $number) === 1) {
                $harmonics[] = $numerator / $number;
            }
        }

        return $harmonics;
    }

    /**
     * @param int $limit
     *
     * @return float[]
     */
    public static function getSeries(int $limit): array
    {
        $series = [];
        $base = 0;
        for ($denominator = 1; $denominator <= $limit; $denominator++) {
            $base = $series[$denominator] = $base + 1 / $denominator;
        }

        return $series;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ExtendedStrings\Strings;
6
7			class Harmonic
8			{
9			private $halfStop;
10			private $baseStop;
11
12			/**
13			* @param float $halfStop
14			* @param float $baseStop
15			*/
16			public function __construct(float $halfStop, float $baseStop = 1.0)
17			{
18			if ($halfStop > $baseStop) {
19			throw new \InvalidArgumentException("The half-stop's string length cannot be longer than the base stop's.");
20			}
21
22			$this->baseStop = $baseStop;
23			$this->halfStop = $halfStop;
24			}
25
26			/**
27			* @param \ExtendedStrings\Strings\VibratingString $string
28			*
29			* @return float
30			*/
31			public function getSoundingPitch(VibratingString $string): float
32			{
33			// Transpose the half-stop onto the new string length, which was formed
34			// by the stop.
35			$pseudoString = new VibratingString($string->getStoppedFrequency($this->baseStop));
36			$pseudoHalfStop = $this->halfStop / $this->baseStop;
37
38			return $pseudoString->getHarmonicSoundingFrequency($pseudoHalfStop);
39			}
40
41			/**
42			* @param int $number
43			*
44			* @return float[]
45			*/
46			public static function getStringLengthsFromNumber(int $number): array
47			{
48			$harmonics = [];
49			for ($numerator = 1; $numerator <= $number; $numerator++) {
50			if ((int) Math::gcd($numerator, $number) === 1) {
51			$harmonics[] = $numerator / $number;
52			}
53			}
54
55			return $harmonics;
56			}
57
58			/**
59			* @param int $limit
60			*
61			* @return float[]
62			*/
63			public static function getSeries(int $limit): array
64			{
65			$series = [];
66			$base = 0;
67			for ($denominator = 1; $denominator <= $limit; $denominator++) {
68			$base = $series[$denominator] = $base + 1 / $denominator;
69			}
70
71			return $series;
72			}
73			}
74

extended-strings / strings

Push — master ( 0a935a...3298fc )

Harmonic::getStringLengthsFromNumber() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like