ToArrayConverter::convertEncoding() - Code Metrics - Inspection of "optimization" - execut/yii2-import - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9acc18...c6ef98 )

by eXeCUT

created 2020-03-26 13:34 UTC

ToArrayConverter::convertEncoding() A

↳ Parent: ToArrayConverter

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php
/**
 * User: execut
 * Date: 19.07.16
 * Time: 11:55
 */

namespace execut\import\components;


use PhpOffice\PhpSpreadsheet\IOFactory;
use PhpOffice\PhpSpreadsheet\Reader\Csv;
use PhpOffice\PhpSpreadsheet\Reader\Html;
use yii\base\Component;

class ToArrayConverter extends Component
{
    public $file;
    public $fileExtension;
    public $cache = null;
    public $encoding = 'UTF-8';
    public $enclosure = '"';
    public $delimiter = ',';
    public $trim = null;
    public $limit = null;
    public $mimeType = null;
    public function convert() {
        $file = $this->file;
        if (!is_string($file)) {
            $isUnlinkFile = true;
            $fileContent = stream_get_contents($file);
            $file = tempnam('/tmp', 'test_');
            file_put_contents($file, $fileContent);
        } else {
            $isUnlinkFile = false;
        }

        if ($this->mimeType === 'application/x-rar' || ($this->mimeType === null && mime_content_type($file) === 'application/x-rar')) {
            exec('unrar lb "' . $file . '"', $out);
            $unpackedFile = tempnam('/tmp', 'test_') . $out[0];
            exec('unrar p -inul "' . $file . '" > "' . $unpackedFile . '"');
            if ($isUnlinkFile) {
                unlink($file);
            }

            $file = $unpackedFile;
            $isUnlinkFile = true;
        }

        if ($this->mimeType === 'application/zip' || ($this->mimeType === null && mime_content_type($file) === 'application/zip')) {
            $unpackedFile = '/tmp/' . exec('unzip -l "' . $file . '" | awk \'/-----/ {p = ++p % 2; next} p {print $NF}\'');
            exec('unzip -cqq "' . $file . '" > ' . $unpackedFile);
            if ($isUnlinkFile) {
                unlink($file);
            }

            $file = $unpackedFile;
            $isUnlinkFile = true;
        }

        $cache = $this->getCache();
        if ($cache) {

            $md5 = md5_file($file);
            $cacheKey = $md5 . $this->delimiter . '-' . $this->enclosure . '-' . $this->encoding . '-' . $this->trim;
            if ($result = $cache->get($cacheKey)) {
//                $result = array_splice($result, 0, 10);
                return $result;
            }
        }

//        \PHPExcel_Settings::setLocale('ru_RU');
        \PhpOffice\PhpSpreadsheet\Shared\StringHelper::setDecimalSeparator('.');
        \PhpOffice\PhpSpreadsheet\Shared\StringHelper::setThousandsSeparator('');
        try {
            $reader = IOFactory::createReaderForFile($file);
        } catch (\PhpOffice\PhpSpreadsheet\Reader\Exception $e) {
            $ext = pathinfo($file, PATHINFO_EXTENSION);
            if ($ext === 'xls') {
                $reader = IOFactory::createReader('Xls');
            } else {
                throw $e;
            }
        }

        if (($reader instanceof Csv) || ($reader instanceof Html)) {
            $result = [];
            $content = str_replace(["\r\n", "\n\r", "\r"], "\n", file_get_contents($file));
            $content = explode("\n", $content);
            $delimiter = $this->delimiter;
            foreach ($content as $value) {
                $value = $this->convertEncoding($value);
                if ($this->delimiter) {
                    if (strlen($this->delimiter) == 2) {
                        $delimiter = '~';
                        $value = str_replace($this->delimiter, $delimiter, $value);
                    }
                }

                $parts = str_getcsv($value, $delimiter, $this->enclosure);
                $result[] = $parts;
            }
        } else {
//            $cacheMethod = \PHPExcel_CachedObjectStorageFactory::cache_to_phpTemp;
//            $cacheSettings = array( 'memoryCacheSize' => '500MB');
//            \PHPExcel_Settings::setCacheStorageMethod($cacheMethod, $cacheSettings);
//            $reader->setReadDataOnly(true);
            $oldReporting = error_reporting();
            error_reporting(E_ALL & ~E_NOTICE);
            try {
                $table = $reader->load($file);
            } catch (\PhpOffice\PhpSpreadsheet\Reader\Exception $e) {
                $reader = \PHPExcel_IOFactory::createReaderForFile($file);
filter:
    dependency_paths: ["lib/*"]
                $table = $reader->load($file);
            }

            error_reporting($oldReporting);

            $result = [];
            $sheets = $table->getAllSheets();
            foreach ($sheets as $sheet) {
                $result = array_merge($result, $sheet->toArray(null, false));
            }

            if ($this->encoding !== null) {
                foreach ($result as &$row) {
                    foreach ($row as $key => $value) {
                        $value = $this->convertEncoding($value);

                        $row[$key] = $value;
                    }
                }
            }
        }

        if ($this->trim !== null) {
            foreach ($result as &$row) {
                foreach ($row as $key => $value) {
                    $value = trim($value, $this->trim);

                    $row[$key] = $value;
                }
            }
        }


        if ($isUnlinkFile) {
            unlink($file);
        }

        $cache = $this->getCache();
        if ($cache) {

            $cache->set($cacheKey, $result, 3600);

        }

        return $result;
    }

    public function getCache() {
        return false;
        if ($this->cache !== null) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            return $this->cache;
        }

        if (YII_ENV !== 'test') {
            return $this->cache = \yii::$app->cache;
        }
    }

    /**
     * @param $value
     * @return mixed|string
     */
    protected function convertEncoding($value)
    {
        if ($this->encoding === 'ISO-8859-1') {
            $value = \mb_convert_encoding(mb_convert_encoding($value, 'ISO-8859-1', 'UTF-8'), 'UTF-8', 'cp1251');
        } else {
            $value = \mb_convert_encoding($value, 'UTF-8', $this->encoding);
        }

        return $value;
    }
}

1		<?php
2		/**
3		* User: execut
4		* Date: 19.07.16
5		* Time: 11:55
6		*/
7
8		namespace execut\import\components;
9
10
11		use PhpOffice\PhpSpreadsheet\IOFactory;
12		use PhpOffice\PhpSpreadsheet\Reader\Csv;
13		use PhpOffice\PhpSpreadsheet\Reader\Html;
14		use yii\base\Component;
15
16		class ToArrayConverter extends Component
17		{
18		public $file;
19		public $fileExtension;
20		public $cache = null;
21		public $encoding = 'UTF-8';
22		public $enclosure = '"';
23		public $delimiter = ',';
24		public $trim = null;
25		public $limit = null;
26		public $mimeType = null;
27	10	public function convert() {
28	10	$file = $this->file;
29	10	if (!is_string($file)) {
30	4	$isUnlinkFile = true;
31	4	$fileContent = stream_get_contents($file);
32	4	$file = tempnam('/tmp', 'test_');
33	4	file_put_contents($file, $fileContent);
34		} else {
35	6	$isUnlinkFile = false;
36		}
37
38	10	if ($this->mimeType === 'application/x-rar' \|\| ($this->mimeType === null && mime_content_type($file) === 'application/x-rar')) {
39	1	exec('unrar lb "' . $file . '"', $out);
40	1	$unpackedFile = tempnam('/tmp', 'test_') . $out[0];
41	1	exec('unrar p -inul "' . $file . '" > "' . $unpackedFile . '"');
42	1	if ($isUnlinkFile) {
43	1	unlink($file);
44		}
45
46	1	$file = $unpackedFile;
47	1	$isUnlinkFile = true;
48		}
49
50	10	if ($this->mimeType === 'application/zip' \|\| ($this->mimeType === null && mime_content_type($file) === 'application/zip')) {
51	1	$unpackedFile = '/tmp/' . exec('unzip -l "' . $file . '" \| awk \'/-----/ {p = ++p % 2; next} p {print $NF}\'');
52	1	exec('unzip -cqq "' . $file . '" > ' . $unpackedFile);
53	1	if ($isUnlinkFile) {
54	1	unlink($file);
55		}
56
57	1	$file = $unpackedFile;
58	1	$isUnlinkFile = true;
59		}
60
61	10	$cache = $this->getCache();
62	10	if ($cache) {
		0 ignored issues – show introduced 2020-03-26 13:40 UTC by Report Bug Copy Issue Report The condition `$cache` is always `false`. Loading history...
63		$md5 = md5_file($file);
64		$cacheKey = $md5 . $this->delimiter . '-' . $this->enclosure . '-' . $this->encoding . '-' . $this->trim;
65		if ($result = $cache->get($cacheKey)) {
66		// $result = array_splice($result, 0, 10);
67		return $result;
68		}
69		}
70
71		// \PHPExcel_Settings::setLocale('ru_RU');
72	10	\PhpOffice\PhpSpreadsheet\Shared\StringHelper::setDecimalSeparator('.');
73	10	\PhpOffice\PhpSpreadsheet\Shared\StringHelper::setThousandsSeparator('');
74		try {
75	10	$reader = IOFactory::createReaderForFile($file);
76		} catch (\PhpOffice\PhpSpreadsheet\Reader\Exception $e) {
77		$ext = pathinfo($file, PATHINFO_EXTENSION);
78		if ($ext === 'xls') {
79		$reader = IOFactory::createReader('Xls');
80		} else {
81		throw $e;
82		}
83		}
84
85	10	if (($reader instanceof Csv) \|\| ($reader instanceof Html)) {
86	9	$result = [];
87	9	$content = str_replace(["\r\n", "\n\r", "\r"], "\n", file_get_contents($file));
88	9	$content = explode("\n", $content);
89	9	$delimiter = $this->delimiter;
90	9	foreach ($content as $value) {
91	9	$value = $this->convertEncoding($value);
92	9	if ($this->delimiter) {
93	9	if (strlen($this->delimiter) == 2) {
94	1	$delimiter = '~';
95	1	$value = str_replace($this->delimiter, $delimiter, $value);
96		}
97		}
98
99	9	$parts = str_getcsv($value, $delimiter, $this->enclosure);
100	9	$result[] = $parts;
101		}
102		} else {
103		// $cacheMethod = \PHPExcel_CachedObjectStorageFactory::cache_to_phpTemp;
104		// $cacheSettings = array( 'memoryCacheSize' => '500MB');
105		// \PHPExcel_Settings::setCacheStorageMethod($cacheMethod, $cacheSettings);
106		// $reader->setReadDataOnly(true);
107	1	$oldReporting = error_reporting();
108	1	error_reporting(E_ALL & ~E_NOTICE);
109		try {
110	1	$table = $reader->load($file);
111		} catch (\PhpOffice\PhpSpreadsheet\Reader\Exception $e) {
112		$reader = \PHPExcel_IOFactory::createReaderForFile($file);
		0 ignored issues – show Bug introduced 2019-07-18 08:19 UTC by Report Bug Copy Issue Report The type `PHPExcel_IOFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
113		$table = $reader->load($file);
114		}
115
116	1	error_reporting($oldReporting);
117
118	1	$result = [];
119	1	$sheets = $table->getAllSheets();
120	1	foreach ($sheets as $sheet) {
121	1	$result = array_merge($result, $sheet->toArray(null, false));
122		}
123
124	1	if ($this->encoding !== null) {
125	1	foreach ($result as &$row) {
126	1	foreach ($row as $key => $value) {
127	1	$value = $this->convertEncoding($value);
128
129	1	$row[$key] = $value;
130		}
131		}
132		}
133		}
134
135	10	if ($this->trim !== null) {
136	1	foreach ($result as &$row) {
137	1	foreach ($row as $key => $value) {
138	1	$value = trim($value, $this->trim);
139
140	1	$row[$key] = $value;
141		}
142		}
143		}
144
145
146	10	if ($isUnlinkFile) {
147	4	unlink($file);
148		}
149
150	10	$cache = $this->getCache();
151	10	if ($cache) {
		0 ignored issues – show introduced 2020-03-26 13:40 UTC by Report Bug Copy Issue Report The condition `$cache` is always `false`. Loading history...
152		$cache->set($cacheKey, $result, 3600);
		0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-18 08:19 UTC by Report Bug Copy Issue Report The variable `$cacheKey` does not seem to be defined for all execution paths leading up to this point. Loading history...
153		}
154
155	10	return $result;
156		}
157
158	10	public function getCache() {
159	10	return false;
160		if ($this->cache !== null) {
		0 ignored issues – show Unused Code introduced 2020-03-26 13:40 UTC by Report Bug Copy Issue Report `IfNode` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
161		return $this->cache;
162		}
163
164		if (YII_ENV !== 'test') {
165		return $this->cache = \yii::$app->cache;
166		}
167		}
168
169		/**
170		* @param $value
171		* @return mixed\|string
172		*/
173	10	protected function convertEncoding($value)
174		{
175	10	if ($this->encoding === 'ISO-8859-1') {
176	1	$value = \mb_convert_encoding(mb_convert_encoding($value, 'ISO-8859-1', 'UTF-8'), 'UTF-8', 'cp1251');
177		} else {
178	9	$value = \mb_convert_encoding($value, 'UTF-8', $this->encoding);
179		}
180
181	10	return $value;
182		}
183		}

execut / yii2-import

Push — master ( 9acc18...c6ef98 )

ToArrayConverter::convertEncoding() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like