Issues in sqlParser.class.php (develop) - Issues in develop - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3885)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

install/src/sqlParser.class.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

// MySQL Dump Parser
// SNUFFKIN/ Alex 2004

class SqlParser {
	public $host;
	public $dbname;
	public $prefix;
	public $user;
	public $password;
	public $mysqlErrors;
	public $conn;
	public $installFailed;
	public $sitename;
	public $adminname;
	public $adminemail;
	public $adminpass;
	public $managerlanguage;
	public $mode;
	public $fileManagerPath;
	public $imgPath;
	public $imgUrl;
	public $dbMODx;
	public $dbVersion;
    public $connection_charset;
    public $connection_method;
    public $ignoreDuplicateErrors;
    public $autoTemplateLogic;

	public function __construct($host, $user, $password, $db, $prefix='modx_', $adminname, $adminemail, $adminpass, $connection_charset= 'utf8', $managerlanguage='english', $connection_method = 'SET CHARACTER SET', $auto_template_logic = 'parent') {
		$this->host = $host;
		$this->dbname = $db;
		$this->prefix = $prefix;
		$this->user = $user;
		$this->password = $password;
		$this->adminpass = $adminpass;
		$this->adminname = $adminname;
		$this->adminemail = $adminemail;
		$this->connection_charset = $connection_charset;
		$this->connection_method = $connection_method;
		$this->ignoreDuplicateErrors = false;
		$this->managerlanguage = $managerlanguage;
        $this->autoTemplateLogic = $auto_template_logic;
	}

	public function connect() {
        $host = explode(':', $this->host, 2);
        $this->conn = mysqli_connect($host[0], $this->user, $this->password,'', isset($host[1]) ? $host[1] : null);
		mysqli_select_db($this->conn, $this->dbname);
		if (function_exists('mysqli_set_charset')) mysqli_set_charset($this->conn, $this->connection_charset);

		$this->dbVersion = 3.23; // assume version 3.23
		if(function_exists("mysqli_get_server_info")) {
			$ver = mysqli_get_server_info($this->conn);
			$this->dbMODx 	 = version_compare($ver,"4.0.2");
			$this->dbVersion = (float) $ver; // Typecasting (float) instead of floatval() [PHP < 4.2]
		}

        mysqli_query($this->conn,"{$this->connection_method} {$this->connection_charset}");
	}

    public function process($filename) {
	    global $custom_placeholders;

		// check to make sure file exists
		if (!file_exists($filename)) {
			$this->mysqlErrors[] = array("error" => "File '$filename' not found");
			$this->installFailed = true ;
			return false;
		}

		$fh = fopen($filename, 'r');
		$idata = '';

		while (!feof($fh)) {
			$idata .= fread($fh, 1024);
		}

		fclose($fh);
		$idata = str_replace("\r", '', $idata);

		// check if in upgrade mode
		if ($this->mode === 'upd') {
			// remove non-upgradeable parts
			$s = strpos($idata,'non-upgrade-able[[');
			$e = strpos($idata,']]non-upgrade-able') + 17;
			if($s && $e) {
			    $idata = str_replace(substr($idata, $s,$e-$s),' Removed non upgradeable items', $idata);
            }
		}

		// replace {} tags
		$idata = str_replace('{PREFIX}', $this->prefix, $idata);
        $idata = str_replace('{TABLEENCODING}', $this->getTableEncoding(), $idata);
		$idata = str_replace('{ADMIN}', $this->adminname, $idata);
		$idata = str_replace('{ADMINEMAIL}', $this->adminemail, $idata);
		$idata = str_replace('{ADMINPASS}', $this->adminpass, $idata);
		$idata = str_replace('{IMAGEPATH}', $this->imgPath, $idata);
		$idata = str_replace('{IMAGEURL}', $this->imgUrl, $idata);
		$idata = str_replace('{FILEMANAGERPATH}', $this->fileManagerPath, $idata);
		$idata = str_replace('{MANAGERLANGUAGE}', $this->managerlanguage, $idata);
		$idata = str_replace('{AUTOTEMPLATELOGIC}', $this->autoTemplateLogic, $idata);
		/*$idata = str_replace('{VERSION}', $modx_version, $idata);*/

		// Replace custom placeholders
		foreach($custom_placeholders as $key=>$val) {
			if (strpos($idata, '{'.$key.'}') !== false) {
				$idata = str_replace('{'.$key.'}', $val, $idata);
			}
		}

		$sql_array = explode("\n\n", $idata);

		$num = 0;
		foreach($sql_array as $sql_entry) {
			$sql_do = trim($sql_entry, "\r\n; ");

			if (preg_match('/^\#/', $sql_do)) continue;

			// strip out comments and \n for mysql 3.x
			if ($this->dbVersion <4.0) {
				$sql_do = preg_replace("~COMMENT.*[^']?'.*[^']?'~","",$sql_do);
				$sql_do = str_replace('\r', "", $sql_do);
				$sql_do = str_replace('\n', "", $sql_do);
			}


			$num = $num + 1;
			if ($sql_do) mysqli_query($this->conn, $sql_do);
			if(mysqli_error($this->conn)) {
				// Ignore duplicate and drop errors - Raymond
				if ($this->ignoreDuplicateErrors){
					if (mysqli_errno($this->conn) == 1060 || mysqli_errno($this->conn) == 1061 || mysqli_errno($this->conn) == 1062 ||mysqli_errno($this->conn) == 1091) continue;
				}
				// End Ignore duplicate
				$this->mysqlErrors[] = array("error" => mysqli_error($this->conn), "sql" => $sql_do);
				$this->installFailed = true;
			}
		}
	}

    public function getTableEncoding()
    {
        $out = 'DEFAULT CHARSET=' . $this->connection_charset;
        if (!empty($this->database_collation)) {
            $out .= ' COLLATE=' . $this->database_collation;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        return $out;
    }

    public function close() {
		mysqli_close($this->conn);
	}
}


1		<?php
2
3		// MySQL Dump Parser
4		// SNUFFKIN/ Alex 2004
5
6		class SqlParser {
7		public $host;
8		public $dbname;
9		public $prefix;
10		public $user;
11		public $password;
12		public $mysqlErrors;
13		public $conn;
14		public $installFailed;
15		public $sitename;
16		public $adminname;
17		public $adminemail;
18		public $adminpass;
19		public $managerlanguage;
20		public $mode;
21		public $fileManagerPath;
22		public $imgPath;
23		public $imgUrl;
24		public $dbMODx;
25		public $dbVersion;
26		public $connection_charset;
27		public $connection_method;
28		public $ignoreDuplicateErrors;
29		public $autoTemplateLogic;
30
31		public function __construct($host, $user, $password, $db, $prefix='modx_', $adminname, $adminemail, $adminpass, $connection_charset= 'utf8', $managerlanguage='english', $connection_method = 'SET CHARACTER SET', $auto_template_logic = 'parent') {
32		$this->host = $host;
33		$this->dbname = $db;
34		$this->prefix = $prefix;
35		$this->user = $user;
36		$this->password = $password;
37		$this->adminpass = $adminpass;
38		$this->adminname = $adminname;
39		$this->adminemail = $adminemail;
40		$this->connection_charset = $connection_charset;
41		$this->connection_method = $connection_method;
42		$this->ignoreDuplicateErrors = false;
43		$this->managerlanguage = $managerlanguage;
44		$this->autoTemplateLogic = $auto_template_logic;
45		}
46
47		public function connect() {
48		$host = explode(':', $this->host, 2);
49		$this->conn = mysqli_connect($host[0], $this->user, $this->password,'', isset($host[1]) ? $host[1] : null);
50		mysqli_select_db($this->conn, $this->dbname);
51		if (function_exists('mysqli_set_charset')) mysqli_set_charset($this->conn, $this->connection_charset);
52
53		$this->dbVersion = 3.23; // assume version 3.23
54		if(function_exists("mysqli_get_server_info")) {
55		$ver = mysqli_get_server_info($this->conn);
56		$this->dbMODx = version_compare($ver,"4.0.2");
57		$this->dbVersion = (float) $ver; // Typecasting (float) instead of floatval() [PHP < 4.2]
58		}
59
60		mysqli_query($this->conn,"{$this->connection_method} {$this->connection_charset}");
61		}
62
63		public function process($filename) {
64		global $custom_placeholders;
65
66		// check to make sure file exists
67		if (!file_exists($filename)) {
68		$this->mysqlErrors[] = array("error" => "File '$filename' not found");
69		$this->installFailed = true ;
70		return false;
71		}
72
73		$fh = fopen($filename, 'r');
74		$idata = '';
75
76		while (!feof($fh)) {
77		$idata .= fread($fh, 1024);
78		}
79
80		fclose($fh);
81		$idata = str_replace("\r", '', $idata);
82
83		// check if in upgrade mode
84		if ($this->mode === 'upd') {
85		// remove non-upgradeable parts
86		$s = strpos($idata,'non-upgrade-able[[');
87		$e = strpos($idata,']]non-upgrade-able') + 17;
88		if($s && $e) {
89		$idata = str_replace(substr($idata, $s,$e-$s),' Removed non upgradeable items', $idata);
90		}
91		}
92
93		// replace {} tags
94		$idata = str_replace('{PREFIX}', $this->prefix, $idata);
95		$idata = str_replace('{TABLEENCODING}', $this->getTableEncoding(), $idata);
96		$idata = str_replace('{ADMIN}', $this->adminname, $idata);
97		$idata = str_replace('{ADMINEMAIL}', $this->adminemail, $idata);
98		$idata = str_replace('{ADMINPASS}', $this->adminpass, $idata);
99		$idata = str_replace('{IMAGEPATH}', $this->imgPath, $idata);
100		$idata = str_replace('{IMAGEURL}', $this->imgUrl, $idata);
101		$idata = str_replace('{FILEMANAGERPATH}', $this->fileManagerPath, $idata);
102		$idata = str_replace('{MANAGERLANGUAGE}', $this->managerlanguage, $idata);
103		$idata = str_replace('{AUTOTEMPLATELOGIC}', $this->autoTemplateLogic, $idata);
104		/$idata = str_replace('{VERSION}', $modx_version, $idata);/
105
106		// Replace custom placeholders
107		foreach($custom_placeholders as $key=>$val) {
108	View Code Duplication	if (strpos($idata, '{'.$key.'}') !== false) {
109		$idata = str_replace('{'.$key.'}', $val, $idata);
110		}
111		}
112
113		$sql_array = explode("\n\n", $idata);
114
115		$num = 0;
116		foreach($sql_array as $sql_entry) {
117		$sql_do = trim($sql_entry, "\r\n; ");
118
119		if (preg_match('/^\#/', $sql_do)) continue;
120
121		// strip out comments and \n for mysql 3.x
122		if ($this->dbVersion <4.0) {
123		$sql_do = preg_replace("~COMMENT.[^']?'.[^']?'~","",$sql_do);
124		$sql_do = str_replace('\r', "", $sql_do);
125		$sql_do = str_replace('\n', "", $sql_do);
126		}
127
128
129		$num = $num + 1;
130		if ($sql_do) mysqli_query($this->conn, $sql_do);
131		if(mysqli_error($this->conn)) {
132		// Ignore duplicate and drop errors - Raymond
133		if ($this->ignoreDuplicateErrors){
134		if (mysqli_errno($this->conn) == 1060 \|\| mysqli_errno($this->conn) == 1061 \|\| mysqli_errno($this->conn) == 1062 \|\|mysqli_errno($this->conn) == 1091) continue;
135		}
136		// End Ignore duplicate
137		$this->mysqlErrors[] = array("error" => mysqli_error($this->conn), "sql" => $sql_do);
138		$this->installFailed = true;
139		}
140		}
141		}
142
143		public function getTableEncoding()
144		{
145		$out = 'DEFAULT CHARSET=' . $this->connection_charset;
146		if (!empty($this->database_collation)) {
147		$out .= ' COLLATE=' . $this->database_collation;
		0 ignored issues – show Bug introduced 2018-11-09 14:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `database_collation` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
148		}
149		return $out;
150		}
151
152		public function close() {
153		mysqli_close($this->conn);
154		}
155		}
156

evolution-cms / evolution

Issues (3885)

Security Analysis not enabled

install/src/sqlParser.class.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like