Completed
Push — develop ( 0132ab...e45b08 )
by Dmytro
13:40 queued 05:11
created
manager/includes/extenders/modifiers.class.inc.php 1 patch
Braces   +544 added lines, -282 removed lines patch added patch discarded remove patch
@@ -1,8 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('MODX_CORE_PATH')) define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
3
+if(!defined('MODX_CORE_PATH')) {
4
+    define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
5
+}
4 6
 
5
-class MODIFIERS {
7
+class MODIFIERS
8
+{
6 9
     /**
7 10
      * @var array
8 11
      */
@@ -60,7 +63,9 @@  discard block
 block discarded – undo
60 63
     public function __construct()
61 64
     {
62 65
         $modx = evolutionCMS();
63
-        if (function_exists('mb_internal_encoding')) mb_internal_encoding($modx->config['modx_charset']);
66
+        if (function_exists('mb_internal_encoding')) {
67
+            mb_internal_encoding($modx->config['modx_charset']);
68
+        }
64 69
         $this->condModifiers = '=,is,eq,equals,ne,neq,notequals,isnot,isnt,not,%,isempty,isnotempty,isntempty,>=,gte,eg,gte,greaterthan,>,gt,isgreaterthan,isgt,lowerthan,<,lt,<=,lte,islte,islowerthan,islt,el,find,in,inarray,in_array,fnmatch,wcard,wcard_match,wildcard,wildcard_match,is_file,is_dir,file_exists,is_readable,is_writable,is_image,regex,preg,preg_match,memberof,mo,isinrole,ir';
65 70
     }
66 71
 
@@ -73,7 +78,9 @@  discard block
 block discarded – undo
73 78
     public function phxFilter($key,$value,$modifiers)
74 79
     {
75 80
         $modx = evolutionCMS();
76
-        if(substr($modifiers,0,3)!=='id(') $value = $this->parseDocumentSource($value);
81
+        if(substr($modifiers,0,3)!=='id(') {
82
+            $value = $this->parseDocumentSource($value);
83
+        }
77 84
         $this->srcValue = $value;
78 85
         $modifiers = trim($modifiers);
79 86
         $modifiers = ':'.trim($modifiers,':');
@@ -96,13 +103,18 @@  discard block
 block discarded – undo
96 103
      * @param string $modifiers
97 104
      * @return bool|string
98 105
      */
99
-    public function _getDelim($mode,$modifiers) {
106
+    public function _getDelim($mode,$modifiers)
107
+    {
100 108
         $c = substr($modifiers,0,1);
101
-        if(!in_array($c, array('"', "'", '`')) ) return false;
109
+        if(!in_array($c, array('"', "'", '`')) ) {
110
+            return false;
111
+        }
102 112
 
103 113
         $modifiers = substr($modifiers,1);
104 114
         $closure = $mode=='(' ? "{$c})" : $c;
105
-        if(strpos($modifiers, $closure)===false) return false;
115
+        if(strpos($modifiers, $closure)===false) {
116
+            return false;
117
+        }
106 118
 
107 119
         return  $c;
108 120
     }
@@ -113,52 +125,65 @@  discard block
 block discarded – undo
113 125
      * @param string $modifiers
114 126
      * @return bool|string
115 127
      */
116
-    public function _getOpt($mode,$delim,$modifiers) {
128
+    public function _getOpt($mode,$delim,$modifiers)
129
+    {
117 130
         if($delim) {
118
-            if($mode=='(') return substr($modifiers,1,strpos($modifiers, $delim . ')' )-1);
131
+            if($mode=='(') {
132
+                return substr($modifiers,1,strpos($modifiers, $delim . ')' )-1);
133
+            }
119 134
 
120 135
             return substr($modifiers,1,strpos($modifiers,$delim,1)-1);
121
-        }
122
-        else {
123
-            if($mode=='(') return substr($modifiers,0,strpos($modifiers, ')') );
136
+        } else {
137
+            if($mode=='(') {
138
+                return substr($modifiers,0,strpos($modifiers, ')') );
139
+            }
124 140
 
125 141
             $chars = str_split($modifiers);
126 142
             $opt='';
127 143
             foreach($chars as $c) {
128
-                if($c==':' || $c==')') break;
144
+                if($c==':' || $c==')') {
145
+                    break;
146
+                }
129 147
                 $opt .=$c;
130 148
             }
131 149
             return $opt;
132 150
         }
133 151
     }
134
-    public function _getRemainModifiers($mode,$delim,$modifiers) {
152
+    public function _getRemainModifiers($mode,$delim,$modifiers)
153
+    {
135 154
         if($delim) {
136
-            if($mode=='(')
137
-                return $this->_fetchContent($modifiers, $delim . ')');
138
-            else {
155
+            if($mode=='(') {
156
+                            return $this->_fetchContent($modifiers, $delim . ')');
157
+            } else {
139 158
                 $modifiers = trim($modifiers);
140 159
                 $modifiers = substr($modifiers,1);
141 160
                 return $this->_fetchContent($modifiers, $delim);
142 161
             }
143
-        }
144
-        else {
145
-            if($mode=='(') return $this->_fetchContent($modifiers, ')');
162
+        } else {
163
+            if($mode=='(') {
164
+                return $this->_fetchContent($modifiers, ')');
165
+            }
146 166
             $chars = str_split($modifiers);
147 167
             foreach($chars as $c) {
148
-                if($c==':') return $modifiers;
149
-                else $modifiers = substr($modifiers,1);
168
+                if($c==':') {
169
+                    return $modifiers;
170
+                } else {
171
+                    $modifiers = substr($modifiers,1);
172
+                }
150 173
             }
151 174
             return $modifiers;
152 175
         }
153 176
     }
154 177
 
155
-    public function _fetchContent($string,$delim) {
178
+    public function _fetchContent($string,$delim)
179
+    {
156 180
         $len = strlen($delim);
157 181
         $string = $this->parseDocumentSource($string);
158 182
         return substr($string,strpos($string, $delim)+$len);
159 183
     }
160 184
 
161
-    public function splitEachModifiers($modifiers) {
185
+    public function splitEachModifiers($modifiers)
186
+    {
162 187
         $modx = evolutionCMS();
163 188
 
164 189
         $cmd = '';
@@ -169,11 +194,15 @@  discard block
 block discarded – undo
169 194
             $c = substr($modifiers,0,1);
170 195
             $modifiers = substr($modifiers,1);
171 196
 
172
-            if($c===':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) { // :=, :!=, :<=, :>=, :!<=, :!>=
197
+            if($c===':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) {
198
+// :=, :!=, :<=, :>=, :!<=, :!>=
173 199
                 $c = substr($modifiers,strlen($match[1]),1);
174 200
                 $debuginfo = "#i=0 #c=[{$c}] #m=[{$modifiers}]";
175
-                if($c==='(') $modifiers = substr($modifiers,strlen($match[1])+1);
176
-                else         $modifiers = substr($modifiers,strlen($match[1]));
201
+                if($c==='(') {
202
+                    $modifiers = substr($modifiers,strlen($match[1])+1);
203
+                } else {
204
+                    $modifiers = substr($modifiers,strlen($match[1]));
205
+                }
177 206
 
178 207
                 $delim     = $this->_getDelim($c,$modifiers);
179 208
                 $opt       = $this->_getOpt($c,$delim,$modifiers);
@@ -181,13 +210,12 @@  discard block
 block discarded – undo
181 210
 
182 211
                 $result[]=array('cmd'=>trim($match[1]),'opt'=>$opt,'debuginfo'=>$debuginfo);
183 212
                 $cmd = '';
184
-            }
185
-            elseif(in_array($c,array('+','-','*','/')) && preg_match('@^[0-9]+@', $modifiers, $match)) { // :+3, :-3, :*3 ...
213
+            } elseif(in_array($c,array('+','-','*','/')) && preg_match('@^[0-9]+@', $modifiers, $match)) {
214
+// :+3, :-3, :*3 ...
186 215
                 $modifiers = substr($modifiers,strlen($match[0]));
187 216
                 $result[]=array('cmd'=>'math','opt'=>'%s'.$c.$match[0]);
188 217
                 $cmd = '';
189
-            }
190
-            elseif($c==='(' || $c==='=') {
218
+            } elseif($c==='(' || $c==='=') {
191 219
                 $modifiers = $m1 = trim($modifiers);
192 220
                 $delim     = $this->_getDelim($c,$modifiers);
193 221
                 $opt       = $this->_getOpt($c,$delim,$modifiers);
@@ -197,29 +225,29 @@  discard block
 block discarded – undo
197 225
                 $result[]=array('cmd'=>trim($cmd),'opt'=>$opt,'debuginfo'=>$debuginfo);
198 226
 
199 227
                 $cmd = '';
200
-            }
201
-            elseif($c==':') {
228
+            } elseif($c==':') {
202 229
                 $debuginfo = "#i=2 #c=[{$c}] #m=[{$modifiers}]";
203
-                if($cmd!=='') $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
230
+                if($cmd!=='') {
231
+                    $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
232
+                }
204 233
 
205 234
                 $cmd = '';
206
-            }
207
-            elseif(trim($modifiers)=='' && trim($cmd)!=='') {
235
+            } elseif(trim($modifiers)=='' && trim($cmd)!=='') {
208 236
                 $debuginfo = "#i=3 #c=[{$c}] #m=[{$modifiers}]";
209 237
                 $cmd .= $c;
210 238
                 $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
211 239
 
212 240
                 break;
213
-            }
214
-            else {
241
+            } else {
215 242
                 $cmd .= $c;
216 243
             }
217 244
         }
218 245
 
219
-        if(empty($result)) return array();
246
+        if(empty($result)) {
247
+            return array();
248
+        }
220 249
 
221
-        foreach($result as $i=>$a)
222
-        {
250
+        foreach($result as $i=>$a) {
223 251
             $a['opt'] = $this->parseDocumentSource($a['opt']);
224 252
             $result[$i]['opt'] = $modx->mergePlaceholderContent($a['opt'],$this->placeholders);
225 253
         }
@@ -232,22 +260,23 @@  discard block
 block discarded – undo
232 260
         $modx = evolutionCMS();
233 261
         $lastKey = '';
234 262
         $cacheKey = md5(sprintf('parsePhx#%s#%s#%s',$key,$value,print_r($modifiers,true)));
235
-        if(isset($this->tmpCache[$cacheKey])) return $this->tmpCache[$cacheKey];
236
-        if(empty($modifiers)) return '';
263
+        if(isset($this->tmpCache[$cacheKey])) {
264
+            return $this->tmpCache[$cacheKey];
265
+        }
266
+        if(empty($modifiers)) {
267
+            return '';
268
+        }
237 269
 
238
-        foreach($modifiers as $m)
239
-        {
270
+        foreach($modifiers as $m) {
240 271
             $lastKey = strtolower($m['cmd']);
241 272
         }
242 273
         $_ = explode(',',$this->condModifiers);
243
-        if(in_array($lastKey,$_))
244
-        {
274
+        if(in_array($lastKey,$_)) {
245 275
             $modifiers[] = array('cmd'=>'then','opt'=>'1');
246 276
             $modifiers[] = array('cmd'=>'else','opt'=>'0');
247 277
         }
248 278
 
249
-        foreach($modifiers as $i=>$a)
250
-        {
279
+        foreach($modifiers as $i=>$a) {
251 280
             $value = $this->Filter($key,$value, $a['cmd'], $a['opt']);
252 281
         }
253 282
         $this->tmpCache[$cacheKey] = $value;
@@ -259,25 +288,32 @@  discard block
 block discarded – undo
259 288
     {
260 289
         $modx = evolutionCMS();
261 290
 
262
-        if($key==='documentObject') $value = $modx->documentIdentifier;
291
+        if($key==='documentObject') {
292
+            $value = $modx->documentIdentifier;
293
+        }
263 294
         $cmd = $this->parseDocumentSource($cmd);
264
-        if(preg_match('@^[1-9][/0-9]*$@',$cmd))
265
-        {
266
-            if(strpos($cmd,'/')!==false)
267
-                $cmd = $this->substr($cmd,strrpos($cmd,'/')+1);
295
+        if(preg_match('@^[1-9][/0-9]*$@',$cmd)) {
296
+            if(strpos($cmd,'/')!==false) {
297
+                            $cmd = $this->substr($cmd,strrpos($cmd,'/')+1);
298
+            }
268 299
             $opt = $cmd;
269 300
             $cmd = 'id';
270 301
         }
271 302
 
272
-        if(isset($modx->snippetCache["phx:{$cmd}"]))   $this->elmName = "phx:{$cmd}";
273
-        elseif(isset($modx->chunkCache["phx:{$cmd}"])) $this->elmName = "phx:{$cmd}";
274
-        else                                           $this->elmName = '';
303
+        if(isset($modx->snippetCache["phx:{$cmd}"])) {
304
+            $this->elmName = "phx:{$cmd}";
305
+        } elseif(isset($modx->chunkCache["phx:{$cmd}"])) {
306
+            $this->elmName = "phx:{$cmd}";
307
+        } else {
308
+            $this->elmName = '';
309
+        }
275 310
 
276 311
         $cmd = strtolower($cmd);
277
-        if($this->elmName!=='')
278
-            $value = $this->getValueFromElement($key, $value, $cmd, $opt);
279
-        else
280
-            $value = $this->getValueFromPreset($key, $value, $cmd, $opt);
312
+        if($this->elmName!=='') {
313
+                    $value = $this->getValueFromElement($key, $value, $cmd, $opt);
314
+        } else {
315
+                    $value = $this->getValueFromPreset($key, $value, $cmd, $opt);
316
+        }
281 317
 
282 318
         $value = str_replace('[+key+]', $key, $value);
283 319
 
@@ -286,29 +322,37 @@  discard block
 block discarded – undo
286 322
 
287 323
     public function isEmpty($cmd,$value)
288 324
     {
289
-        if($value!=='') return false;
325
+        if($value!=='') {
326
+            return false;
327
+        }
290 328
 
291 329
         $_ = explode(',', $this->condModifiers . ',_default,default,if,input,or,and,show,this,select,switch,then,else,id,ifempty,smart_desc,smart_description,summary');
292
-        if(in_array($cmd,$_)) return false;
293
-        else                  return true;
330
+        if(in_array($cmd,$_)) {
331
+            return false;
332
+        } else {
333
+            return true;
334
+        }
294 335
     }
295 336
 
296 337
     public function getValueFromPreset($key, $value, $cmd, $opt)
297 338
     {
298 339
         $modx = evolutionCMS();
299 340
 
300
-        if($this->isEmpty($cmd,$value)) return '';
341
+        if($this->isEmpty($cmd,$value)) {
342
+            return '';
343
+        }
301 344
 
302 345
         $this->key = $key;
303 346
         $this->value  = $value;
304 347
         $this->opt    = $opt;
305 348
 
306
-        switch ($cmd)
307
-        {
349
+        switch ($cmd) {
308 350
             #####  Conditional Modifiers
309 351
             case 'input':
310 352
             case 'if':
311
-                if(!$opt) return $value;
353
+                if(!$opt) {
354
+                    return $value;
355
+                }
312 356
                 return $opt;
313 357
             case '=':
314 358
             case 'eq':
@@ -369,14 +413,24 @@  discard block
 block discarded – undo
369 413
             case 'file_exists':
370 414
             case 'is_readable':
371 415
             case 'is_writable':
372
-                if(!$opt) $path = $value;
373
-                else      $path = $opt;
374
-                if(strpos($path,MODX_MANAGER_PATH)!==false) exit('Can not read core path');
375
-                if(strpos($path,$modx->config['base_path'])===false) $path = ltrim($path,'/');
416
+                if(!$opt) {
417
+                    $path = $value;
418
+                } else {
419
+                    $path = $opt;
420
+                }
421
+                if(strpos($path,MODX_MANAGER_PATH)!==false) {
422
+                    exit('Can not read core path');
423
+                }
424
+                if(strpos($path,$modx->config['base_path'])===false) {
425
+                    $path = ltrim($path,'/');
426
+                }
376 427
                 $this->condition[] = (int)($cmd($path)!==false);break;
377 428
             case 'is_image':
378
-                if(!$opt) $path = $value;
379
-                else      $path = $opt;
429
+                if(!$opt) {
430
+                    $path = $value;
431
+                } else {
432
+                    $path = $opt;
433
+                }
380 434
                 if(!is_file($path)) {$this->condition[]='0';break;}
381 435
                 $_ = getimagesize($path);
382 436
                 $this->condition[] = (int)($_[0]);break;
@@ -399,17 +453,23 @@  discard block
 block discarded – undo
399 453
             case 'this':
400 454
                 $conditional = implode(' ',$this->condition);
401 455
                 $isvalid = (int)(eval("return ({$conditional});"));
402
-                if ($isvalid) return $this->srcValue;
456
+                if ($isvalid) {
457
+                    return $this->srcValue;
458
+                }
403 459
                 return NULL;
404 460
             case 'then':
405 461
                 $conditional = implode(' ',$this->condition);
406 462
                 $isvalid = (int)eval("return ({$conditional});");
407
-                if ($isvalid)  return $opt;
463
+                if ($isvalid) {
464
+                    return $opt;
465
+                }
408 466
                 return null;
409 467
             case 'else':
410 468
                 $conditional = implode(' ',$this->condition);
411 469
                 $isvalid = (int)eval("return ({$conditional});");
412
-                if (!$isvalid) return $opt;
470
+                if (!$isvalid) {
471
+                    return $opt;
472
+                }
413 473
                 break;
414 474
             case 'select':
415 475
             case 'switch':
@@ -420,8 +480,11 @@  discard block
 block discarded – undo
420 480
                     $mi = explode('=',$raw[$m],2);
421 481
                     $map[$mi[0]] = $mi[1];
422 482
                 }
423
-                if(isset($map[$value])) return $map[$value];
424
-                else                    return '';
483
+                if(isset($map[$value])) {
484
+                    return $map[$value];
485
+                } else {
486
+                    return '';
487
+                }
425 488
             ##### End of Conditional Modifiers
426 489
 
427 490
             #####  Encode / Decode / Hash / Escape
@@ -447,24 +510,25 @@  discard block
 block discarded – undo
447 510
             case 'spam_protect':
448 511
                 return str_replace(array('@','.'),array('&#64;','&#46;'),$value);
449 512
             case 'strip':
450
-                if($opt==='') $opt = ' ';
513
+                if($opt==='') {
514
+                    $opt = ' ';
515
+                }
451 516
                 return preg_replace('/[\n\r\t\s]+/', $opt, $value);
452 517
             case 'strip_linefeeds':
453 518
                 return str_replace(array("\n","\r"), '', $value);
454 519
             case 'notags':
455 520
             case 'strip_tags':
456 521
             case 'remove_html':
457
-                if($opt!=='')
458
-                {
522
+                if($opt!=='') {
459 523
                     $param = array();
460
-                    foreach(explode(',',$opt) as $v)
461
-                    {
524
+                    foreach(explode(',',$opt) as $v) {
462 525
                         $v = trim($v,'</> ');
463 526
                         $param[] = "<{$v}>";
464 527
                     }
465 528
                     $params = implode(',',$param);
529
+                } else {
530
+                    $params = '';
466 531
                 }
467
-                else $params = '';
468 532
                 if(!strpos($params,'<br>')===false) {
469 533
                     $value = preg_replace('@(<br[ /]*>)\n@','$1',$value);
470 534
                     $value = preg_replace('@<br[ /]*>@',"\n",$value);
@@ -475,8 +539,11 @@  discard block
 block discarded – undo
475 539
             case 'encode_url':
476 540
                 return urlencode($value);
477 541
             case 'base64_decode':
478
-                if($opt!=='false') $opt = true;
479
-                else               $opt = false;
542
+                if($opt!=='false') {
543
+                    $opt = true;
544
+                } else {
545
+                    $opt = false;
546
+                }
480 547
                 return base64_decode($value,$opt);
481 548
             case 'encode_sha1': $cmd = 'sha1';
482 549
             case 'addslashes':
@@ -502,16 +569,19 @@  discard block
 block discarded – undo
502 569
                 return $this->strtoupper($value);
503 570
             case 'capitalize':
504 571
                 $_ = explode(' ',$value);
505
-                foreach($_ as $i=>$v)
506
-                {
572
+                foreach($_ as $i=>$v) {
507 573
                     $_[$i] = ucfirst($v);
508 574
                 }
509 575
                 return implode(' ',$_);
510 576
             case 'zenhan':
511
-                if(empty($opt)) $opt='VKas';
577
+                if(empty($opt)) {
578
+                    $opt='VKas';
579
+                }
512 580
                 return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
513 581
             case 'hanzen':
514
-                if(empty($opt)) $opt='VKAS';
582
+                if(empty($opt)) {
583
+                    $opt='VKAS';
584
+                }
515 585
                 return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
516 586
             case 'str_shuffle':
517 587
             case 'shuffle':
@@ -536,13 +606,18 @@  discard block
 block discarded – undo
536 606
                 $value = preg_replace('/\r/', '', $value);
537 607
                 return count(preg_split('/\n+/',$value));
538 608
             case 'strpos':
539
-                if($opt!=0&&empty($opt)) return $value;
609
+                if($opt!=0&&empty($opt)) {
610
+                    return $value;
611
+                }
540 612
                 return $this->strpos($value,$opt);
541 613
             case 'wordwrap':
542 614
                 // default: 70
543 615
                   $wrapat = (int)$opt > 0 ? (int)$opt : 70;
544
-                if (version_compare(PHP_VERSION, '5.3.0') >= 0) return $this->includeMdfFile('wordwrap');
545
-                else return preg_replace("@(\b\w+\b)@e","wordwrap('\\1',\$wrapat,' ',1)",$value);
616
+                if (version_compare(PHP_VERSION, '5.3.0') >= 0) {
617
+                    return $this->includeMdfFile('wordwrap');
618
+                } else {
619
+                    return preg_replace("@(\b\w+\b)@e","wordwrap('\\1',\$wrapat,' ',1)",$value);
620
+                }
546 621
             case 'wrap_text':
547 622
                 $width = preg_match('/^[1-9][0-9]*$/',$opt) ? $opt : 70;
548 623
                 if($modx->config['manager_language']==='japanese-utf8') {
@@ -558,30 +633,36 @@  discard block
 block discarded – undo
558 633
                         $value = $this->substr($value,$width);
559 634
                     }
560 635
                     return implode("\n",$chunk);
636
+                } else {
637
+                                    return wordwrap($value,$width,"\n",true);
561 638
                 }
562
-                else
563
-                    return wordwrap($value,$width,"\n",true);
564 639
             case 'substr':
565
-                if(empty($opt)) break;
640
+                if(empty($opt)) {
641
+                    break;
642
+                }
566 643
                 if(strpos($opt,',')!==false) {
567 644
                     list($b,$e) = explode(',',$opt,2);
568 645
                     return $this->substr($value,$b,(int)$e);
646
+                } else {
647
+                    return $this->substr($value,$opt);
569 648
                 }
570
-                else return $this->substr($value,$opt);
571 649
             case 'limit':
572 650
             case 'trim_to': // http://www.movabletype.jp/documentation/appendices/modifiers/trim_to.html
573
-                if(strpos($opt,'+')!==false)
574
-                    list($len,$str) = explode('+',$opt,2);
575
-                else {
651
+                if(strpos($opt,'+')!==false) {
652
+                                    list($len,$str) = explode('+',$opt,2);
653
+                } else {
576 654
                     $len = $opt;
577 655
                     $str = '';
578 656
                 }
579
-                if($len==='') $len = 100;
580
-                if(abs($len) > $this->strlen($value)) $str ='';
657
+                if($len==='') {
658
+                    $len = 100;
659
+                }
660
+                if(abs($len) > $this->strlen($value)) {
661
+                    $str ='';
662
+                }
581 663
                 if(preg_match('/^[1-9][0-9]*$/',$len)) {
582 664
                     return $this->substr($value,0,$len) . $str;
583
-                }
584
-                elseif(preg_match('/^\-[1-9][0-9]*$/',$len)) {
665
+                } elseif(preg_match('/^\-[1-9][0-9]*$/',$len)) {
585 666
                     return $str . $this->substr($value,$len);
586 667
                 }
587 668
                 break;
@@ -591,18 +672,30 @@  discard block
 block discarded – undo
591 672
                 return $this->includeMdfFile('summary');
592 673
             case 'replace':
593 674
             case 'str_replace':
594
-                if(empty($opt) || strpos($opt,',')===false) break;
595
-                if    (substr_count($opt, ',') ==1) $delim = ',';
596
-                elseif(substr_count($opt, '|') ==1) $delim = '|';
597
-                elseif(substr_count($opt, '=>')==1) $delim = '=>';
598
-                elseif(substr_count($opt, '/') ==1) $delim = '/';
599
-                else break;
675
+                if(empty($opt) || strpos($opt,',')===false) {
676
+                    break;
677
+                }
678
+                if    (substr_count($opt, ',') ==1) {
679
+                    $delim = ',';
680
+                } elseif(substr_count($opt, '|') ==1) {
681
+                    $delim = '|';
682
+                } elseif(substr_count($opt, '=>')==1) {
683
+                    $delim = '=>';
684
+                } elseif(substr_count($opt, '/') ==1) {
685
+                    $delim = '/';
686
+                } else {
687
+                    break;
688
+                }
600 689
                 list($s,$r) = explode($delim,$opt);
601
-                if($value!=='') return str_replace($s,$r,$value);
690
+                if($value!=='') {
691
+                    return str_replace($s,$r,$value);
692
+                }
602 693
                 break;
603 694
             case 'replace_to':
604 695
             case 'tpl':
605
-                if($value!=='') return str_replace(array('[+value+]','[+output+]','{value}','%s'),$value,$opt);
696
+                if($value!=='') {
697
+                    return str_replace(array('[+value+]','[+output+]','{value}','%s'),$value,$opt);
698
+                }
606 699
                 break;
607 700
             case 'eachtpl':
608 701
                 $value = explode('||',$value);
@@ -613,59 +706,83 @@  discard block
 block discarded – undo
613 706
                 return implode("\n", $_);
614 707
             case 'array_pop':
615 708
             case 'array_shift':
616
-                if(strpos($value,'||')!==false) $delim = '||';
617
-                else                            $delim = ',';
709
+                if(strpos($value,'||')!==false) {
710
+                    $delim = '||';
711
+                } else {
712
+                    $delim = ',';
713
+                }
618 714
                 return $cmd(explode($delim,$value));
619 715
             case 'preg_replace':
620 716
             case 'regex_replace':
621
-                if(empty($opt) || strpos($opt,',')===false) break;
717
+                if(empty($opt) || strpos($opt,',')===false) {
718
+                    break;
719
+                }
622 720
                 list($s,$r) = explode(',',$opt,2);
623
-                if($value!=='') return preg_replace($s,$r,$value);
721
+                if($value!=='') {
722
+                    return preg_replace($s,$r,$value);
723
+                }
624 724
                 break;
625 725
             case 'cat':
626 726
             case 'concatenate':
627 727
             case '.':
628
-                if($value!=='') return $value . $opt;
728
+                if($value!=='') {
729
+                    return $value . $opt;
730
+                }
629 731
                 break;
630 732
             case 'sprintf':
631 733
             case 'string_format':
632
-                if($value!=='') return sprintf($opt,$value);
734
+                if($value!=='') {
735
+                    return sprintf($opt,$value);
736
+                }
633 737
                 break;
634 738
             case 'number_format':
635
-                    if($opt=='') $opt = 0;
739
+                    if($opt=='') {
740
+                        $opt = 0;
741
+                    }
636 742
                     return number_format($value,$opt);
637 743
             case 'money_format':
638 744
                     setlocale(LC_MONETARY,setlocale(LC_TIME,0));
639
-                    if($value!=='') return money_format($opt,(double)$value);
745
+                    if($value!=='') {
746
+                        return money_format($opt,(double)$value);
747
+                    }
640 748
                     break;
641 749
             case 'tobool':
642 750
                 return boolval($value);
643 751
             case 'nl2lf':
644
-                if($value!=='') return str_replace(array("\r\n","\n", "\r"), '\n', $value);
752
+                if($value!=='') {
753
+                    return str_replace(array("\r\n","\n", "\r"), '\n', $value);
754
+                }
645 755
                 break;
646 756
             case 'br2nl':
647 757
                 return preg_replace('@<br[\s/]*>@i', "\n", $value);
648 758
             case 'nl2br':
649
-                if (version_compare(PHP_VERSION, '5.3.0', '<'))
650
-                    return nl2br($value);
651
-                if($opt!=='')
652
-                {
759
+                if (version_compare(PHP_VERSION, '5.3.0', '<')) {
760
+                                    return nl2br($value);
761
+                }
762
+                if($opt!=='') {
653 763
                     $opt = trim($opt);
654 764
                     $opt = strtolower($opt);
655
-                    if($opt==='false') $opt = false;
656
-                    elseif($opt==='0') $opt = false;
657
-                    else               $opt = true;
765
+                    if($opt==='false') {
766
+                        $opt = false;
767
+                    } elseif($opt==='0') {
768
+                        $opt = false;
769
+                    } else {
770
+                        $opt = true;
771
+                    }
772
+                } elseif(isset($modx->config['mce_element_format'])&&$modx->config['mce_element_format']==='html') {
773
+                                                       $opt = false;
774
+                } else {
775
+                    $opt = true;
658 776
                 }
659
-                elseif(isset($modx->config['mce_element_format'])&&$modx->config['mce_element_format']==='html')
660
-                                       $opt = false;
661
-                else                   $opt = true;
662 777
                 return nl2br($value,$opt);
663 778
             case 'ltrim':
664 779
             case 'rtrim':
665 780
             case 'trim': // ref http://mblo.info/modifiers/custom-modifiers/rtrim_opt.html
666
-                if($opt==='')
667
-                    return $cmd($value);
668
-                else return $cmd($value,$opt);
781
+                if($opt==='') {
782
+                                    return $cmd($value);
783
+                } else {
784
+                    return $cmd($value,$opt);
785
+                }
669 786
             // These are all straight wrappers for PHP functions
670 787
             case 'ucfirst':
671 788
             case 'lcfirst':
@@ -676,15 +793,24 @@  discard block
 block discarded – undo
676 793
             case 'strftime':
677 794
             case 'date':
678 795
             case 'dateformat':
679
-                if(empty($opt)) $opt = $modx->toDateFormat(null, 'formatOnly');
680
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
681
-                if(strpos($opt,'%')!==false)
682
-                    return strftime($opt,0+$value);
683
-                else
684
-                    return date($opt,0+$value);
796
+                if(empty($opt)) {
797
+                    $opt = $modx->toDateFormat(null, 'formatOnly');
798
+                }
799
+                if(!preg_match('@^[0-9]+$@',$value)) {
800
+                    $value = strtotime($value);
801
+                }
802
+                if(strpos($opt,'%')!==false) {
803
+                                    return strftime($opt,0+$value);
804
+                } else {
805
+                                    return date($opt,0+$value);
806
+                }
685 807
             case 'time':
686
-                if(empty($opt)) $opt = '%H:%M';
687
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
808
+                if(empty($opt)) {
809
+                    $opt = '%H:%M';
810
+                }
811
+                if(!preg_match('@^[0-9]+$@',$value)) {
812
+                    $value = strtotime($value);
813
+                }
688 814
                 return strftime($opt,0+$value);
689 815
             case 'strtotime':
690 816
                 return strtotime($value);
@@ -694,7 +820,9 @@  discard block
 block discarded – undo
694 820
             case 'tofloat':
695 821
                 return floatval($value);
696 822
             case 'round':
697
-                if(!$opt) $opt = 0;
823
+                if(!$opt) {
824
+                    $opt = 0;
825
+                }
698 826
                 return $cmd($value,$opt);
699 827
             case 'max':
700 828
             case 'min':
@@ -706,28 +834,42 @@  discard block
 block discarded – undo
706 834
             case 'math':
707 835
             case 'calc':
708 836
                 $value = (int)$value;
709
-                if(empty($value)) $value = '0';
837
+                if(empty($value)) {
838
+                    $value = '0';
839
+                }
710 840
                 $filter = str_replace(array('[+value+]','[+output+]','{value}','%s'),'?',$opt);
711 841
                 $filter = preg_replace('@([a-zA-Z\n\r\t\s])@','',$filter);
712
-                if(strpos($filter,'?')===false) $filter = "?{$filter}";
842
+                if(strpos($filter,'?')===false) {
843
+                    $filter = "?{$filter}";
844
+                }
713 845
                 $filter = str_replace('?',$value,$filter);
714 846
                 return eval("return {$filter};");
715 847
             case 'count':
716
-                if($value=='') return 0;
848
+                if($value=='') {
849
+                    return 0;
850
+                }
717 851
                 $value = explode(',',$value);
718 852
                 return count($value);
719 853
             case 'sort':
720 854
             case 'rsort':
721
-                if(strpos($value,"\n")!==false) $delim="\n";
722
-                else $delim = ',';
855
+                if(strpos($value,"\n")!==false) {
856
+                    $delim="\n";
857
+                } else {
858
+                    $delim = ',';
859
+                }
723 860
                 $swap = explode($delim,$value);
724
-                if(!$opt) $opt = SORT_REGULAR;
725
-                else      $opt = constant($opt);
861
+                if(!$opt) {
862
+                    $opt = SORT_REGULAR;
863
+                } else {
864
+                    $opt = constant($opt);
865
+                }
726 866
                 $cmd($swap,$opt);
727 867
                 return implode($delim,$swap);
728 868
             #####  Resource fields
729 869
             case 'id':
730
-                if($opt) return $this->getDocumentObject($opt,$key);
870
+                if($opt) {
871
+                    return $this->getDocumentObject($opt,$key);
872
+                }
731 873
                 break;
732 874
             case 'type':
733 875
             case 'contenttype':
@@ -764,7 +906,9 @@  discard block
 block discarded – undo
764 906
             case 'privatemgr':
765 907
             case 'content_dispo':
766 908
             case 'hidemenu':
767
-                if($cmd==='contenttype') $cmd = 'contentType';
909
+                if($cmd==='contenttype') {
910
+                    $cmd = 'contentType';
911
+                }
768 912
                 return $this->getDocumentObject($value,$cmd);
769 913
             case 'title':
770 914
                 $pagetitle = $this->getDocumentObject($value,'pagetitle');
@@ -779,13 +923,20 @@  discard block
 block discarded – undo
779 923
                 $templateName = $modx->db->getValue($rs);
780 924
                 return !$templateName ? '(blank)' : $templateName;
781 925
             case 'getfield':
782
-                if(!$opt) $opt = 'content';
926
+                if(!$opt) {
927
+                    $opt = 'content';
928
+                }
783 929
                 return $modx->getField($opt,$value);
784 930
             case 'children':
785 931
             case 'childids':
786
-                if($value=='') $value = 0; // 値がない場合はルートと見なす
932
+                if($value=='') {
933
+                    $value = 0;
934
+                }
935
+                // 値がない場合はルートと見なす
787 936
                 $published = 1;
788
-                if($opt=='') $opt = 'page';
937
+                if($opt=='') {
938
+                    $opt = 'page';
939
+                }
789 940
                 $_ = explode(',',$opt);
790 941
                 $where = array();
791 942
                 foreach($_ as $opt) {
@@ -801,29 +952,43 @@  discard block
 block discarded – undo
801 952
                 $where = implode(' AND ', $where);
802 953
                 $children = $modx->getDocumentChildren($value, $published, '0', 'id', $where);
803 954
                 $result = array();
804
-                foreach((array)$children as $child){
955
+                foreach((array)$children as $child) {
805 956
                     $result[] = $child['id'];
806 957
                 }
807 958
                 return implode(',', $result);
808 959
             case 'fullurl':
809
-                if(!is_numeric($value)) return $value;
960
+                if(!is_numeric($value)) {
961
+                    return $value;
962
+                }
810 963
                 return $modx->makeUrl($value);
811 964
             case 'makeurl':
812
-                if(!is_numeric($value)) return $value;
813
-                if(!$opt) $opt = 'full';
965
+                if(!is_numeric($value)) {
966
+                    return $value;
967
+                }
968
+                if(!$opt) {
969
+                    $opt = 'full';
970
+                }
814 971
                 return $modx->makeUrl($value,'','',$opt);
815 972
 
816 973
             #####  File system
817 974
             case 'getimageinfo':
818 975
             case 'imageinfo':
819
-                if(!is_file($value)) return '';
976
+                if(!is_file($value)) {
977
+                    return '';
978
+                }
820 979
                 $_ = getimagesize($value);
821
-                if(!$_[0]) return '';
980
+                if(!$_[0]) {
981
+                    return '';
982
+                }
822 983
                 $info['width']  = $_[0];
823 984
                 $info['height'] = $_[1];
824
-                if    ($_[0] > $_[1]) $info['aspect'] = 'landscape';
825
-                elseif($_[0] < $_[1]) $info['aspect'] = 'portrait';
826
-                else                  $info['aspect'] = 'square';
985
+                if    ($_[0] > $_[1]) {
986
+                    $info['aspect'] = 'landscape';
987
+                } elseif($_[0] < $_[1]) {
988
+                    $info['aspect'] = 'portrait';
989
+                } else {
990
+                    $info['aspect'] = 'square';
991
+                }
827 992
                 switch($_[2]) {
828 993
                     case IMAGETYPE_GIF  : $info['type'] = 'gif'; break;
829 994
                     case IMAGETYPE_JPEG : $info['type'] = 'jpg'; break;
@@ -842,33 +1007,47 @@  discard block
 block discarded – undo
842 1007
 
843 1008
             case 'file_get_contents':
844 1009
             case 'readfile':
845
-                if(!is_file($value)) return $value;
1010
+                if(!is_file($value)) {
1011
+                    return $value;
1012
+                }
846 1013
                 $value = realpath($value);
847
-                if(strpos($value,MODX_MANAGER_PATH)!==false) exit('Can not read core file');
1014
+                if(strpos($value,MODX_MANAGER_PATH)!==false) {
1015
+                    exit('Can not read core file');
1016
+                }
848 1017
                 $ext = strtolower(substr($value,-4));
849
-                if($ext==='.php') exit('Can not read php file');
850
-                if($ext==='.cgi') exit('Can not read cgi file');
1018
+                if($ext==='.php') {
1019
+                    exit('Can not read php file');
1020
+                }
1021
+                if($ext==='.cgi') {
1022
+                    exit('Can not read cgi file');
1023
+                }
851 1024
                 return file_get_contents($value);
852 1025
             case 'filesize':
853
-                if($value == '') return '';
1026
+                if($value == '') {
1027
+                    return '';
1028
+                }
854 1029
                 $filename = $value;
855 1030
 
856 1031
                 $site_url = $modx->config['site_url'];
857
-                if(strpos($filename,$site_url) === 0)
858
-                    $filename = substr($filename,0,strlen($site_url));
1032
+                if(strpos($filename,$site_url) === 0) {
1033
+                                    $filename = substr($filename,0,strlen($site_url));
1034
+                }
859 1035
                 $filename = trim($filename,'/');
860 1036
 
861 1037
                 $opt = trim($opt,'/');
862
-                if($opt!=='') $opt .= '/';
1038
+                if($opt!=='') {
1039
+                    $opt .= '/';
1040
+                }
863 1041
 
864 1042
                 $filename = MODX_BASE_PATH.$opt.$filename;
865 1043
 
866
-                if(is_file($filename)){
1044
+                if(is_file($filename)) {
867 1045
                     clearstatcache();
868 1046
                     $size = filesize($filename);
869 1047
                     return $size;
1048
+                } else {
1049
+                    return '';
870 1050
                 }
871
-                else return '';
872 1051
             #####  User info
873 1052
             case 'username':
874 1053
             case 'fullname':
@@ -896,32 +1075,47 @@  discard block
 block discarded – undo
896 1075
                 $this->opt = $cmd;
897 1076
                 return $this->includeMdfFile('moduser');
898 1077
             case 'userinfo':
899
-                if(empty($opt)) $this->opt = 'username';
1078
+                if(empty($opt)) {
1079
+                    $this->opt = 'username';
1080
+                }
900 1081
                 return $this->includeMdfFile('moduser');
901 1082
             case 'webuserinfo':
902
-                if(empty($opt)) $this->opt = 'username';
1083
+                if(empty($opt)) {
1084
+                    $this->opt = 'username';
1085
+                }
903 1086
                 $this->value = -$value;
904 1087
                 return $this->includeMdfFile('moduser');
905 1088
             #####  Special functions
906 1089
             case 'ifempty':
907 1090
             case '_default':
908 1091
             case 'default':
909
-                if (empty($value)) return $opt; break;
1092
+                if (empty($value)) {
1093
+                    return $opt;
1094
+                }
1095
+                break;
910 1096
             case 'ifnotempty':
911
-                if (!empty($value)) return $opt; break;
1097
+                if (!empty($value)) {
1098
+                    return $opt;
1099
+                }
1100
+                break;
912 1101
             case 'datagrid':
913 1102
                 include_once(MODX_CORE_PATH . 'controls/datagrid.class.php');
914 1103
                 $grd = new DataGrid(null, trim($value));
915 1104
                 $grd->itemStyle = '';
916 1105
                 $grd->altItemStyle = '';
917 1106
                 $pos = strpos($value,"\n");
918
-                if($pos) $_ = substr($value,0,$pos);
919
-                else $_ = $pos;
1107
+                if($pos) {
1108
+                    $_ = substr($value,0,$pos);
1109
+                } else {
1110
+                    $_ = $pos;
1111
+                }
920 1112
                 $grd->cdelim = strpos($_,"\t")!==false ? 'tab' : ',';
921 1113
                 return $grd->render();
922 1114
             case 'rotate':
923 1115
             case 'evenodd':
924
-                if(strpos($opt,',')===false) $opt = 'odd,even';
1116
+                if(strpos($opt,',')===false) {
1117
+                    $opt = 'odd,even';
1118
+                }
925 1119
                 $_ = explode(',', $opt);
926 1120
                 $c = count($_);
927 1121
                 $i = $value + $c;
@@ -930,7 +1124,9 @@  discard block
 block discarded – undo
930 1124
             case 'takeval':
931 1125
                 $arr = explode(",",$opt);
932 1126
                 $idx = $value;
933
-                if(!is_numeric($idx)) return $value;
1127
+                if(!is_numeric($idx)) {
1128
+                    return $value;
1129
+                }
934 1130
                 return $arr[$idx];
935 1131
             case 'getimage':
936 1132
                 return $this->includeMdfFile('getimage');
@@ -938,14 +1134,18 @@  discard block
 block discarded – undo
938 1134
                     return $modx->nicesize($value);
939 1135
             case 'googlemap':
940 1136
             case 'googlemaps':
941
-                if(empty($opt)) $opt = 'border:none;width:500px;height:350px;';
1137
+                if(empty($opt)) {
1138
+                    $opt = 'border:none;width:500px;height:350px;';
1139
+                }
942 1140
                 $tpl = '<iframe style="[+style+]" src="https://maps.google.co.jp/maps?ll=[+value+]&output=embed&z=15"></iframe>';
943 1141
                 $ph['style'] = $opt;
944 1142
                 $ph['value'] = $value;
945 1143
                 return $modx->parseText($tpl,$ph);
946 1144
             case 'youtube':
947 1145
             case 'youtube16x9':
948
-                if(empty($opt)) $opt = 560;
1146
+                if(empty($opt)) {
1147
+                    $opt = 560;
1148
+                }
949 1149
                 $h = round($opt*0.5625);
950 1150
                 $tpl = '<iframe width="%s" height="%s" src="https://www.youtube.com/embed/%s" frameborder="0" allowfullscreen></iframe>';
951 1151
                 return sprintf($tpl,$opt,$h,$value);
@@ -978,7 +1178,8 @@  discard block
 block discarded – undo
978 1178
         return $value;
979 1179
     }
980 1180
 
981
-    public function includeMdfFile($cmd) {
1181
+    public function includeMdfFile($cmd)
1182
+    {
982 1183
         $modx = evolutionCMS();
983 1184
         $key = $this->key;
984 1185
         $value  = $this->value;
@@ -989,55 +1190,65 @@  discard block
 block discarded – undo
989 1190
     public function getValueFromElement($key, $value, $cmd, $opt)
990 1191
     {
991 1192
         $modx = evolutionCMS();
992
-        if( isset($modx->snippetCache[$this->elmName]) )
993
-        {
1193
+        if( isset($modx->snippetCache[$this->elmName]) ) {
994 1194
             $php = $modx->snippetCache[$this->elmName];
995
-        }
996
-        else
997
-        {
1195
+        } else {
998 1196
             $esc_elmName = $modx->db->escape($this->elmName);
999 1197
             $result = $modx->db->select('snippet','[+prefix+]site_snippets',"name='{$esc_elmName}'");
1000 1198
             $total = $modx->db->getRecordCount($result);
1001
-            if($total == 1)
1002
-            {
1199
+            if($total == 1) {
1003 1200
                 $row = $modx->db->getRow($result);
1004 1201
                 $php = $row['snippet'];
1005
-            }
1006
-            elseif($total == 0)
1007
-            {
1202
+            } elseif($total == 0) {
1008 1203
                 $assets_path = MODX_BASE_PATH.'assets/';
1009
-                if(is_file($assets_path."modifiers/mdf_{$cmd}.inc.php"))
1010
-                    $modifiers_path = $assets_path."modifiers/mdf_{$cmd}.inc.php";
1011
-                elseif(is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php"))
1012
-                    $modifiers_path = $assets_path."plugins/phx/modifiers/{$cmd}.phx.php";
1013
-                elseif(is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php"))
1014
-                    $modifiers_path = MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php";
1015
-                else $modifiers_path = false;
1204
+                if(is_file($assets_path."modifiers/mdf_{$cmd}.inc.php")) {
1205
+                                    $modifiers_path = $assets_path."modifiers/mdf_{$cmd}.inc.php";
1206
+                } elseif(is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php")) {
1207
+                                    $modifiers_path = $assets_path."plugins/phx/modifiers/{$cmd}.phx.php";
1208
+                } elseif(is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php")) {
1209
+                                    $modifiers_path = MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php";
1210
+                } else {
1211
+                    $modifiers_path = false;
1212
+                }
1016 1213
 
1017 1214
                 if($modifiers_path !== false) {
1018 1215
                     $php = @file_get_contents($modifiers_path);
1019 1216
                     $php = trim($php);
1020
-                    if(substr($php,0,5)==='<?php') $php = substr($php,6);
1021
-                    if(substr($php,0,2)==='<?')    $php = substr($php,3);
1022
-                    if(substr($php,-2)==='?>')     $php = substr($php,0,-2);
1023
-                    if($this->elmName!=='')
1024
-                        $modx->snippetCache[$this->elmName.'Props'] = '';
1025
-                }
1026
-                else
1027
-                    $php = false;
1217
+                    if(substr($php,0,5)==='<?php') {
1218
+                        $php = substr($php,6);
1219
+                    }
1220
+                    if(substr($php,0,2)==='<?') {
1221
+                        $php = substr($php,3);
1222
+                    }
1223
+                    if(substr($php,-2)==='?>') {
1224
+                        $php = substr($php,0,-2);
1225
+                    }
1226
+                    if($this->elmName!=='') {
1227
+                                            $modx->snippetCache[$this->elmName.'Props'] = '';
1228
+                    }
1229
+                } else {
1230
+                                    $php = false;
1231
+                }
1232
+            } else {
1233
+                $php = false;
1234
+            }
1235
+            if($this->elmName!=='') {
1236
+                $modx->snippetCache[$this->elmName]= $php;
1028 1237
             }
1029
-            else $php = false;
1030
-            if($this->elmName!=='') $modx->snippetCache[$this->elmName]= $php;
1031 1238
         }
1032
-        if($php==='') $php=false;
1239
+        if($php==='') {
1240
+            $php=false;
1241
+        }
1033 1242
 
1034
-        if($php===false) $html = $modx->getChunk($this->elmName);
1035
-        else             $html = false;
1243
+        if($php===false) {
1244
+            $html = $modx->getChunk($this->elmName);
1245
+        } else {
1246
+            $html = false;
1247
+        }
1036 1248
 
1037 1249
         $self = '[+output+]';
1038 1250
 
1039
-        if($php !== false)
1040
-        {
1251
+        if($php !== false) {
1041 1252
             ob_start();
1042 1253
             $options = $opt;
1043 1254
             $output = $value;
@@ -1049,19 +1260,19 @@  discard block
 block discarded – undo
1049 1260
             $this->vars['options'] = & $opt;
1050 1261
             $custom = eval($php);
1051 1262
             $msg = ob_get_contents();
1052
-            if($value===$this->bt) $value = $msg . $custom;
1263
+            if($value===$this->bt) {
1264
+                $value = $msg . $custom;
1265
+            }
1053 1266
             ob_end_clean();
1054
-        }
1055
-        elseif($html!==false && isset($value) && $value!=='')
1056
-        {
1267
+        } elseif($html!==false && isset($value) && $value!=='') {
1057 1268
             $html = str_replace(array($self,'[+value+]'), $value, $html);
1058 1269
             $value = str_replace(array('[+options+]','[+param+]'), $opt, $html);
1270
+        } else {
1271
+            return false;
1059 1272
         }
1060
-        else return false;
1061 1273
 
1062 1274
         if($php===false && $html===false && $value!==''
1063
-           && (strpos($cmd,'[+value+]')!==false || strpos($cmd,$self)!==false))
1064
-        {
1275
+           && (strpos($cmd,'[+value+]')!==false || strpos($cmd,$self)!==false)) {
1065 1276
             $value = str_replace(array('[+value+]',$self),$value,$cmd);
1066 1277
         }
1067 1278
         return $value;
@@ -1071,23 +1282,39 @@  discard block
 block discarded – undo
1071 1282
     {
1072 1283
         $modx = evolutionCMS();
1073 1284
 
1074
-        if(strpos($content,'[')===false && strpos($content,'{')===false) return $content;
1285
+        if(strpos($content,'[')===false && strpos($content,'{')===false) {
1286
+            return $content;
1287
+        }
1075 1288
 
1076
-        if(!$modx->maxParserPasses) $modx->maxParserPasses = 10;
1289
+        if(!$modx->maxParserPasses) {
1290
+            $modx->maxParserPasses = 10;
1291
+        }
1077 1292
         $bt='';
1078 1293
         $i=0;
1079
-        while($bt!==$content)
1080
-        {
1294
+        while($bt!==$content) {
1081 1295
             $bt = $content;
1082
-            if(strpos($content,'[*')!==false && $modx->documentIdentifier)
1083
-                                              $content = $modx->mergeDocumentContent($content);
1084
-            if(strpos($content,'[(')!==false) $content = $modx->mergeSettingsContent($content);
1085
-            if(strpos($content,'{{')!==false) $content = $modx->mergeChunkContent($content);
1086
-            if(strpos($content,'[!')!==false) $content = str_replace(array('[!','!]'),array('[[',']]'),$content);
1087
-            if(strpos($content,'[[')!==false) $content = $modx->evalSnippets($content);
1088
-
1089
-            if($content===$bt)              break;
1090
-            if($modx->maxParserPasses < $i) break;
1296
+            if(strpos($content,'[*')!==false && $modx->documentIdentifier) {
1297
+                                                          $content = $modx->mergeDocumentContent($content);
1298
+            }
1299
+            if(strpos($content,'[(')!==false) {
1300
+                $content = $modx->mergeSettingsContent($content);
1301
+            }
1302
+            if(strpos($content,'{{')!==false) {
1303
+                $content = $modx->mergeChunkContent($content);
1304
+            }
1305
+            if(strpos($content,'[!')!==false) {
1306
+                $content = str_replace(array('[!','!]'),array('[[',']]'),$content);
1307
+            }
1308
+            if(strpos($content,'[[')!==false) {
1309
+                $content = $modx->evalSnippets($content);
1310
+            }
1311
+
1312
+            if($content===$bt) {
1313
+                break;
1314
+            }
1315
+            if($modx->maxParserPasses < $i) {
1316
+                break;
1317
+            }
1091 1318
             $i++;
1092 1319
         }
1093 1320
         return $content;
@@ -1098,103 +1325,138 @@  discard block
 block discarded – undo
1098 1325
         $modx = evolutionCMS();
1099 1326
 
1100 1327
         $target = trim($target);
1101
-        if(empty($target)) $target = $modx->config['site_start'];
1102
-        if(preg_match('@^[1-9][0-9]*$@',$target)) $method='id';
1103
-        else $method = 'alias';
1328
+        if(empty($target)) {
1329
+            $target = $modx->config['site_start'];
1330
+        }
1331
+        if(preg_match('@^[1-9][0-9]*$@',$target)) {
1332
+            $method='id';
1333
+        } else {
1334
+            $method = 'alias';
1335
+        }
1104 1336
 
1105
-        if(!isset($this->documentObject[$target]))
1106
-        {
1337
+        if(!isset($this->documentObject[$target])) {
1107 1338
             $this->documentObject[$target] = $modx->getDocumentObject($method,$target,'direct');
1108 1339
         }
1109 1340
 
1110
-        if($this->documentObject[$target]['publishedon']==='0')
1111
-            return '';
1112
-        elseif(isset($this->documentObject[$target][$field]))
1113
-        {
1114
-            if(is_array($this->documentObject[$target][$field]))
1115
-            {
1341
+        if($this->documentObject[$target]['publishedon']==='0') {
1342
+                    return '';
1343
+        } elseif(isset($this->documentObject[$target][$field])) {
1344
+            if(is_array($this->documentObject[$target][$field])) {
1116 1345
                 $a = $modx->getTemplateVarOutput($field,$target);
1117 1346
                 $this->documentObject[$target][$field] = $a[$field];
1118 1347
             }
1348
+        } else {
1349
+            $this->documentObject[$target][$field] = false;
1119 1350
         }
1120
-        else $this->documentObject[$target][$field] = false;
1121 1351
 
1122 1352
         return $this->documentObject[$target][$field];
1123 1353
     }
1124 1354
 
1125
-    public function setPlaceholders($value = '', $key = '', $path = '') {
1126
-        if($path!=='') $key = "{$path}.{$key}";
1355
+    public function setPlaceholders($value = '', $key = '', $path = '')
1356
+    {
1357
+        if($path!=='') {
1358
+            $key = "{$path}.{$key}";
1359
+        }
1127 1360
         if (is_array($value)) {
1128 1361
             foreach ($value as $subkey => $subval) {
1129 1362
                 $this->setPlaceholders($subval, $subkey, $key);
1130 1363
             }
1364
+        } else {
1365
+            $this->setModifiersVariable($key, $value);
1131 1366
         }
1132
-        else $this->setModifiersVariable($key, $value);
1133 1367
     }
1134 1368
 
1135 1369
     // Sets a placeholder variable which can only be access by Modifiers
1136
-    public function setModifiersVariable($key, $value) {
1137
-        if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1370
+    public function setModifiersVariable($key, $value)
1371
+    {
1372
+        if ($key != 'phx' && $key != 'dummy') {
1373
+            $this->placeholders[$key] = $value;
1374
+        }
1138 1375
     }
1139 1376
 
1140 1377
     //mbstring
1141
-    public function substr($str, $s, $l = null) {
1378
+    public function substr($str, $s, $l = null)
1379
+    {
1142 1380
         $modx = evolutionCMS();
1143
-        if(is_null($l)) $l = $this->strlen($str);
1144
-        if (function_exists('mb_substr'))
1145
-        {
1146
-            if(strpos($str,"\r")!==false)
1147
-                $str = str_replace(array("\r\n","\r"), "\n", $str);
1381
+        if(is_null($l)) {
1382
+            $l = $this->strlen($str);
1383
+        }
1384
+        if (function_exists('mb_substr')) {
1385
+            if(strpos($str,"\r")!==false) {
1386
+                            $str = str_replace(array("\r\n","\r"), "\n", $str);
1387
+            }
1148 1388
             return mb_substr($str, $s, $l, $modx->config['modx_charset']);
1149 1389
         }
1150 1390
         return substr($str, $s, $l);
1151 1391
     }
1152
-    public function strpos($haystack,$needle,$offset=0) {
1392
+    public function strpos($haystack,$needle,$offset=0)
1393
+    {
1153 1394
         $modx = evolutionCMS();
1154
-        if (function_exists('mb_strpos')) return mb_strpos($haystack,$needle,$offset,$modx->config['modx_charset']);
1395
+        if (function_exists('mb_strpos')) {
1396
+            return mb_strpos($haystack,$needle,$offset,$modx->config['modx_charset']);
1397
+        }
1155 1398
         return strpos($haystack,$needle,$offset);
1156 1399
     }
1157
-    public function strlen($str) {
1400
+    public function strlen($str)
1401
+    {
1158 1402
         $modx = evolutionCMS();
1159
-        if (function_exists('mb_strlen')) return mb_strlen(str_replace("\r\n", "\n", $str),$modx->config['modx_charset']);
1403
+        if (function_exists('mb_strlen')) {
1404
+            return mb_strlen(str_replace("\r\n", "\n", $str),$modx->config['modx_charset']);
1405
+        }
1160 1406
         return strlen($str);
1161 1407
     }
1162
-    public function strtolower($str) {
1163
-        if (function_exists('mb_strtolower')) return mb_strtolower($str);
1408
+    public function strtolower($str)
1409
+    {
1410
+        if (function_exists('mb_strtolower')) {
1411
+            return mb_strtolower($str);
1412
+        }
1164 1413
         return strtolower($str);
1165 1414
     }
1166
-    public function strtoupper($str) {
1167
-        if (function_exists('mb_strtoupper')) return mb_strtoupper($str);
1415
+    public function strtoupper($str)
1416
+    {
1417
+        if (function_exists('mb_strtoupper')) {
1418
+            return mb_strtoupper($str);
1419
+        }
1168 1420
         return strtoupper($str);
1169 1421
     }
1170
-    public function ucfirst($str) {
1171
-        if (function_exists('mb_strtoupper'))
1172
-            return mb_strtoupper($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1422
+    public function ucfirst($str)
1423
+    {
1424
+        if (function_exists('mb_strtoupper')) {
1425
+                    return mb_strtoupper($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1426
+        }
1173 1427
         return ucfirst($str);
1174 1428
     }
1175
-    public function lcfirst($str) {
1176
-        if (function_exists('mb_strtolower'))
1177
-            return mb_strtolower($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1429
+    public function lcfirst($str)
1430
+    {
1431
+        if (function_exists('mb_strtolower')) {
1432
+                    return mb_strtolower($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1433
+        }
1178 1434
         return lcfirst($str);
1179 1435
     }
1180
-    public function ucwords($str) {
1181
-        if (function_exists('mb_convert_case'))
1182
-            return mb_convert_case($str, MB_CASE_TITLE);
1436
+    public function ucwords($str)
1437
+    {
1438
+        if (function_exists('mb_convert_case')) {
1439
+                    return mb_convert_case($str, MB_CASE_TITLE);
1440
+        }
1183 1441
         return ucwords($str);
1184 1442
     }
1185
-    public function strrev($str) {
1443
+    public function strrev($str)
1444
+    {
1186 1445
         preg_match_all('/./us', $str, $ar);
1187 1446
         return implode(array_reverse($ar[0]));
1188 1447
     }
1189
-    public function str_shuffle($str) {
1448
+    public function str_shuffle($str)
1449
+    {
1190 1450
         preg_match_all('/./us', $str, $ar);
1191 1451
         shuffle($ar[0]);
1192 1452
         return implode($ar[0]);
1193 1453
     }
1194
-    public function str_word_count($str) {
1454
+    public function str_word_count($str)
1455
+    {
1195 1456
         return count(preg_split('~[^\p{L}\p{N}\']+~u',$str));
1196 1457
     }
1197
-    public function strip_tags($value,$params='') {
1458
+    public function strip_tags($value,$params='')
1459
+    {
1198 1460
         $modx = evolutionCMS();
1199 1461
 
1200 1462
         if(stripos($params,'style')===false && stripos($value,'</style>')!==false) {
Please login to merge, or discard this patch.
manager/includes/extenders/deprecated.functions.inc.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,8 @@
 block discarded – undo
177 177
      * @return bool|string
178 178
      */
179 179
     public function putChunk($chunkName)
180
-    { // alias name >.<
180
+    {
181
+// alias name >.<
181 182
         $modx = evolutionCMS();
182 183
 
183 184
         return $modx->getChunk($chunkName);
Please login to merge, or discard this patch.
manager/includes/controls/datagrid.class.php 1 patch
Braces   +15 added lines, -7 removed lines patch added patch discarded remove patch
@@ -10,7 +10,8 @@  discard block
 block discarded – undo
10 10
 
11 11
 $__DataGridCnt = 0;
12 12
 
13
-class DataGrid {
13
+class DataGrid
14
+{
14 15
 
15 16
 	public $ds; // datasource
16 17
     public $id;
@@ -72,7 +73,8 @@  discard block
 block discarded – undo
72 73
      */
73 74
     public $cdelim;
74 75
 
75
-    public function __construct($id, $ds, $pageSize = 20, $pageNumber = -1) {
76
+    public function __construct($id, $ds, $pageSize = 20, $pageNumber = -1)
77
+    {
76 78
 		global $__DataGridCnt;
77 79
 
78 80
 		// set id
@@ -88,11 +90,13 @@  discard block
 block discarded – undo
88 90
 		$this->pagerLocation = 'top-right';
89 91
 	}
90 92
 
91
-    public function setDataSource($ds) {
93
+    public function setDataSource($ds)
94
+    {
92 95
 		$this->ds = $ds;
93 96
 	}
94 97
 
95
-    public function render() {
98
+    public function render()
99
+    {
96 100
         $modx = evolutionCMS();
97 101
 		$columnHeaderStyle = ($this->columnHeaderStyle) ? "style='" . $this->columnHeaderStyle . "'" : '';
98 102
 		$columnHeaderClass = ($this->columnHeaderClass) ? "class='" . $this->columnHeaderClass . "'" : "";
@@ -127,7 +131,9 @@  discard block
 block discarded – undo
127 131
 
128 132
 		if($this->_isDataset && !$this->columns) {
129 133
 			$cols = $modx->db->numFields($this->ds);
130
-			for($i = 0; $i < $cols; $i++) $this->columns .= ($i ? "," : "") . $modx->db->fieldName($this->ds, $i);
134
+			for($i = 0; $i < $cols; $i++) {
135
+			    $this->columns .= ($i ? "," : "") . $modx->db->fieldName($this->ds, $i);
136
+			}
131 137
 		}
132 138
 
133 139
 		// start grid
@@ -207,7 +213,8 @@  discard block
 block discarded – undo
207 213
 
208 214
 	// format column values
209 215
 
210
-    public function RenderRowFnc($n, $row) {
216
+    public function RenderRowFnc($n, $row)
217
+    {
211 218
 		if($this->_alt == 0) {
212 219
 			$Style = $this->_itemStyle;
213 220
 			$Class = $this->_itemClass;
@@ -237,7 +244,8 @@  discard block
 block discarded – undo
237 244
 		return $o;
238 245
 	}
239 246
 
240
-    public function formatColumnValue($row, $value, $type, &$align) {
247
+    public function formatColumnValue($row, $value, $type, &$align)
248
+    {
241 249
 		if(strpos($type, ":") !== false) {
242 250
 			list($type, $type_format) = explode(":", $type, 2);
243 251
 		}
Please login to merge, or discard this patch.
manager/includes/controls/datasetpager.class.php 1 patch
Braces   +21 added lines, -10 removed lines patch added patch discarded remove patch
@@ -10,7 +10,8 @@  discard block
 block discarded – undo
10 10
 
11 11
 $__DataSetPagerCnt = 0;
12 12
 
13
-class DataSetPager {
13
+class DataSetPager
14
+{
14 15
 
15 16
 	public $ds; // datasource
16 17
     public $pageSize;
@@ -31,7 +32,8 @@  discard block
 block discarded – undo
31 32
     public $renderPagerFnc;
32 33
     public $renderPagerFncArgs;
33 34
 
34
-    public function __construct($id, $ds, $pageSize = 10, $pageNumber = -1) {
35
+    public function __construct($id, $ds, $pageSize = 10, $pageNumber = -1)
36
+    {
35 37
 		global $_PAGE; // use view state object
36 38
 
37 39
 		global $__DataSetPagerCnt;
@@ -61,35 +63,42 @@  discard block
 block discarded – undo
61 63
 		$this->pager = '';
62 64
 	}
63 65
 
64
-    public function getRenderedPager() {
66
+    public function getRenderedPager()
67
+    {
65 68
 		return $this->pager;
66 69
 	}
67 70
 
68
-    public function getRenderedRows() {
71
+    public function getRenderedRows()
72
+    {
69 73
 		return $this->rows;
70 74
 	}
71 75
 
72
-    public function setDataSource($ds) {
76
+    public function setDataSource($ds)
77
+    {
73 78
 		$this->ds = $ds;
74 79
 	}
75 80
 
76
-    public function setPageSize($ps) {
81
+    public function setPageSize($ps)
82
+    {
77 83
 		$this->pageSize = $ps;
78 84
 	}
79 85
 
80
-    public function setRenderRowFnc($fncName, $args = "") {
86
+    public function setRenderRowFnc($fncName, $args = "")
87
+    {
81 88
 		$this->renderRowFnc = &$fncName;
82 89
 		$this->renderRowFncArgs = $args;    // extra agruments
83 90
 
84 91
 
85 92
 	}
86 93
 
87
-    public function setRenderPagerFnc($fncName, $args = "") {
94
+    public function setRenderPagerFnc($fncName, $args = "")
95
+    {
88 96
 		$this->renderPagerFnc = $fncName;
89 97
 		$this->renderPagerFncArgs = $args;    // extra agruments
90 98
 	}
91 99
 
92
-    public function render() {
100
+    public function render()
101
+    {
93 102
 		$modx = evolutionCMS(); global $_PAGE;
94 103
 
95 104
 		$isDataset = $modx->db->isResult($this->ds);
@@ -142,8 +151,10 @@  discard block
 block discarded – undo
142 151
 					$url = $_SERVER['PHP_SELF'] . '?';
143 152
 				}
144 153
 				$i = 0;
145
-				foreach($_GET as $n => $v) if($n != 'dpgn' . $this->id) {
154
+				foreach($_GET as $n => $v) {
155
+				    if($n != 'dpgn' . $this->id) {
146 156
 					$i++;
157
+				}
147 158
 					$url .= (($i > 1) ? "&" : "") . "$n=$v";
148 159
 				}
149 160
 				if($i >= 1) {
Please login to merge, or discard this patch.
manager/includes/config_check.inc.php 1 patch
Braces   +22 added lines, -9 removed lines patch added patch discarded remove patch
@@ -19,12 +19,12 @@  discard block
 block discarded – undo
19 19
 $warningspresent = 0;
20 20
 
21 21
 $sysfiles_check = $modx->manager->checkSystemChecksum();
22
-if ($sysfiles_check!=='0'){
22
+if ($sysfiles_check!=='0') {
23 23
       $warningspresent = 1;
24 24
       $warnings[] = array($_lang['configcheck_sysfiles_mod']);
25 25
 }
26 26
 
27
-if (is_writable("includes/config.inc.php")){
27
+if (is_writable("includes/config.inc.php")) {
28 28
     // Warn if world writable
29 29
     if(@fileperms('includes/config.inc.php') & 0x0002) {
30 30
       $warningspresent = 1;
@@ -120,7 +120,8 @@  discard block
 block discarded – undo
120 120
     /**
121 121
      * @return bool
122 122
      */
123
-    function checkSiteCache() {
123
+    function checkSiteCache()
124
+    {
124 125
         $modx = evolutionCMS();
125 126
         $checked= true;
126 127
         if (file_exists($modx->config['base_path'] . 'assets/cache/siteCache.idx.php')) {
@@ -159,26 +160,36 @@  discard block
 block discarded – undo
159 160
 
160 161
 if ($warningspresent==1) {
161 162
 
162
-if(!isset($modx->config['send_errormail'])) $modx->config['send_errormail']='3';
163
+if(!isset($modx->config['send_errormail'])) {
164
+    $modx->config['send_errormail']='3';
165
+}
163 166
 $config_check_results = "<h3>".$_lang['configcheck_notok']."</h3>";
164 167
 
165 168
 for ($i=0;$i<count($warnings);$i++) {
166 169
     switch ($warnings[$i][0]) {
167 170
         case $_lang['configcheck_configinc'];
168 171
             $warnings[$i][1] = $_lang['configcheck_configinc_msg'];
169
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_configinc']);
172
+            if(!$_SESSION["mgrConfigCheck"]) {
173
+                $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_configinc']);
174
+            }
170 175
             break;
171 176
         case $_lang['configcheck_installer'] :
172 177
             $warnings[$i][1] = $_lang['configcheck_installer_msg'];
173
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_installer']);
178
+            if(!$_SESSION["mgrConfigCheck"]) {
179
+                $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_installer']);
180
+            }
174 181
             break;
175 182
         case $_lang['configcheck_cache'] :
176 183
             $warnings[$i][1] = $_lang['configcheck_cache_msg'];
177
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_cache']);
184
+            if(!$_SESSION["mgrConfigCheck"]) {
185
+                $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_cache']);
186
+            }
178 187
             break;
179 188
         case $_lang['configcheck_images'] :
180 189
             $warnings[$i][1] = $_lang['configcheck_images_msg'];
181
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_images']);
190
+            if(!$_SESSION["mgrConfigCheck"]) {
191
+                $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_images']);
192
+            }
182 193
             break;
183 194
         case $_lang['configcheck_sysfiles_mod']:
184 195
             $warnings[$i][1] = $_lang["configcheck_sysfiles_mod_msg"];
@@ -186,7 +197,9 @@  discard block
 block discarded – undo
186 197
 			if($modx->hasPermission('settings')) {
187 198
 				$warnings[$i][2] .= '<ul class="actionButtons" style="float:right"><li><a href="index.php?a=2&b=resetSysfilesChecksum" onclick="return confirm(\'' . $_lang["reset_sysfiles_checksum_alert"] . '\')">' . $_lang["reset_sysfiles_checksum_button"] . '</a></li></ul>';
188 199
 			}
189
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1]." ".implode(', ',$sysfiles_check),$_lang['configcheck_sysfiles_mod']);
200
+            if(!$_SESSION["mgrConfigCheck"]) {
201
+                $modx->logEvent(0,3,$warnings[$i][1]." ".implode(', ',$sysfiles_check),$_lang['configcheck_sysfiles_mod']);
202
+            }
190 203
             break;
191 204
         case $_lang['configcheck_lang_difference'] :
192 205
             $warnings[$i][1] = $_lang['configcheck_lang_difference_msg'];
Please login to merge, or discard this patch.
manager/includes/tmplvars.commands.inc.php 1 patch
Braces   +22 added lines, -18 removed lines patch added patch discarded remove patch
@@ -22,16 +22,16 @@  discard block
 block discarded – undo
22 22
  * @param array $tvsArray
23 23
  * @return string
24 24
  */
25
-function ProcessTVCommand($value, $name = '', $docid = '', $src='docform', $tvsArray = array()) {
25
+function ProcessTVCommand($value, $name = '', $docid = '', $src='docform', $tvsArray = array())
26
+{
26 27
     $modx = evolutionCMS();
27 28
     $docid = (int)$docid > 0 ? (int)$docid : $modx->documentIdentifier;
28 29
     $nvalue = trim($value);
29
-    if (substr($nvalue, 0, 1) != '@')
30
-        return $value;
31
-    elseif(isset($modx->config['enable_bindings']) && $modx->config['enable_bindings']!=1 && $src==='docform') {
30
+    if (substr($nvalue, 0, 1) != '@') {
31
+            return $value;
32
+    } elseif(isset($modx->config['enable_bindings']) && $modx->config['enable_bindings']!=1 && $src==='docform') {
32 33
         return '@Bindings is disabled.';
33
-    }
34
-    else {
34
+    } else {
35 35
         list ($cmd, $param) = ParseCommand($nvalue);
36 36
         $cmd = trim($cmd);
37 37
         $param = parseTvValues($param, $tvsArray);
@@ -47,10 +47,11 @@  discard block
 block discarded – undo
47 47
 
48 48
             case "DOCUMENT" : // retrieve a document and process it's content
49 49
                 $rs = $modx->getDocument($param);
50
-                if (is_array($rs))
51
-                    $output = $rs['content'];
52
-                else
53
-                    $output = "Unable to locate document $param";
50
+                if (is_array($rs)) {
51
+                                    $output = $rs['content'];
52
+                } else {
53
+                                    $output = "Unable to locate document $param";
54
+                }
54 55
                 break;
55 56
 
56 57
             case "SELECT" : // selects a record from the cms database
@@ -80,8 +81,10 @@  discard block
 block discarded – undo
80 81
 
81 82
                     // Grab document regardless of publish status
82 83
                     $doc = $modx->getPageInfo($parent_id, 0, 'id,parent,published');
83
-                    if ($doc['parent'] != 0 && !$doc['published'])
84
-                        continue; // hide unpublished docs if we're not at the top
84
+                    if ($doc['parent'] != 0 && !$doc['published']) {
85
+                                            continue;
86
+                    }
87
+                    // hide unpublished docs if we're not at the top
85 88
 
86 89
                     $tv = $modx->getTemplateVar($name, '*', $doc['id'], $doc['published']);
87 90
 
@@ -129,10 +132,13 @@  discard block
 block discarded – undo
129 132
  * @param $file
130 133
  * @return string
131 134
  */
132
-function ProcessFile($file) {
135
+function ProcessFile($file)
136
+{
133 137
     // get the file
134 138
 	$buffer = @file_get_contents($file);
135
-	if ($buffer === false) $buffer = " Could not retrieve document '$file'.";
139
+	if ($buffer === false) {
140
+	    $buffer = " Could not retrieve document '$file'.";
141
+	}
136 142
     return $buffer;
137 143
 }
138 144
 
@@ -146,10 +152,8 @@  discard block
 block discarded – undo
146 152
 {
147 153
     global $BINDINGS;
148 154
     $binding_array = array();
149
-    foreach($BINDINGS as $cmd)
150
-    {
151
-        if(strpos($binding_string,'@'.$cmd)===0)
152
-        {
155
+    foreach($BINDINGS as $cmd) {
156
+        if(strpos($binding_string,'@'.$cmd)===0) {
153 157
             $code = substr($binding_string,strlen($cmd)+1);
154 158
             $binding_array = array($cmd,trim($code));
155 159
             break;
Please login to merge, or discard this patch.
manager/includes/template.parser.class.inc.php 1 patch
Braces   +24 added lines, -21 removed lines patch added patch discarded remove patch
@@ -7,53 +7,55 @@  discard block
 block discarded – undo
7 7
  *
8 8
  */
9 9
 
10
-Class TemplateParser {
10
+Class TemplateParser
11
+{
11 12
 
12 13
     /**
13 14
 	 * @param array $config [action, tabs, toArray]
14 15
 	 * @param array $data
15 16
 	 * @return string
16 17
 	 */
17
-	public function output($config = array(), $data = array()) {
18
+	public function output($config = array(), $data = array())
19
+	{
18 20
         $modx = evolutionCMS();
19 21
 
20 22
 		$output = '';
21 23
 		$action = !empty($config['action']) ? $config['action'] : (!empty($_REQUEST['a']) ? $_REQUEST['a'] : '');
22 24
 		$tab = isset($config['tab']) ? ' AND tab IN(' . $config['tab'] . ')' : '';
23 25
 
24
-		if($action) {
26
+		if($action) {
25 27
 			$sql = $modx->db->query('SELECT t1.*, IF(t1.alias=\'\',t1.name,t1.alias) AS alias, t2.category AS category_name
26 28
 			FROM ' . $modx->getFullTableName('system_templates') . ' AS t1
27 29
 			INNER JOIN ' . $modx->getFullTableName('categories') . ' AS t2 ON t2.id=t1.category
28 30
 			WHERE t1.action IN(' . $action . ') ' . $tab . '
29 31
 			ORDER BY t1.tab ASC, t1.rank ASC');
30 32
 
31
-			if($modx->db->getRecordCount($sql)) {
33
+			if($modx->db->getRecordCount($sql)) {
32 34
 				$tabs = array();
33
-				while($row = $modx->db->getRow($sql)) {
34
-					if(!$row['value'] && !empty($data[$row['name']])) {
35
+				while($row = $modx->db->getRow($sql)) {
36
+					if(!$row['value'] && !empty($data[$row['name']])) {
35 37
 						$row['value'] = $data[$row['name']];
36 38
 					}
37 39
 					$tabs[$row['tab']]['category_name'] = $row['category_name'];
38 40
 					$tabs[$row['tab']][$row['name']] = TemplateParser::render($row);
39 41
 				}
40 42
 
41
-				if(!empty($config['toArray'])) {
43
+				if(!empty($config['toArray'])) {
42 44
 					$output = $tabs;
43
-				} else {
45
+				} else {
44 46
 					$output .= '<div class="tab-pane" id="pane_' . $action . '">';
45 47
 					$output .= '
46 48
 					<script type="text/javascript">
47 49
 						var pane_' . $action . ' = new WebFXTabPane(document.getElementById("pane_' . $action . '"), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false') . ');
48 50
 					</script>';
49 51
 
50
-					foreach($tabs as $idTab => $tab) {
52
+					foreach($tabs as $idTab => $tab) {
51 53
 						$output .= '<div class="tab-page" id="tab_' . $action . '_' . $idTab . '">';
52 54
 						$output .= '
53 55
 						<h2 class="tab">' . (!empty($config['tabs'][$idTab]) ? $config['tabs'][$idTab] : $tab['category_name']) . '</h2>
54 56
 						<script type="text/javascript">pane_' . $action . '.addTabPage(document.getElementById("tab_' . $action . '_' . $idTab . '"));</script>';
55 57
 						unset($tab['category_name']);
56
-						foreach($tab as $item) {
58
+						foreach($tab as $item) {
57 59
 							$output .= $item;
58 60
 						}
59 61
 						$output .= '</div>';
@@ -70,7 +72,8 @@  discard block
 block discarded – undo
70 72
      * @param array $data
71 73
      * @return string
72 74
      */
73
-	private function render($data) {
75
+	private function render($data)
76
+	{
74 77
 		$modx = evolutionCMS(); global $_lang, $_country_lang;
75 78
 
76 79
 		$data['lang.name'] = (isset($_lang[$data['alias']]) ? $_lang[$data['alias']] : $data['alias']);
@@ -80,7 +83,7 @@  discard block
 block discarded – undo
80 83
 		$output = '';
81 84
 		$output .= '<div class="form-group row">';
82 85
 
83
-		switch($data['type']) {
86
+		switch($data['type']) {
84 87
 
85 88
 			case 'text':
86 89
 				$output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>
@@ -114,16 +117,16 @@  discard block
 block discarded – undo
114 117
 				$output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
115 118
 				$output .= '<div class="col-sm-7">';
116 119
 				$output .= '<select name="[+name+]" class="form-control" id="[+name+]" onChange="documentDirty=true;">';
117
-				if($data['name'] == 'country' && isset($_country_lang)) {
120
+				if($data['name'] == 'country' && isset($_country_lang)) {
118 121
 					$chosenCountry = isset($_POST['country']) ? $_POST['country'] : $data['country'];
119 122
 					$output .= '<option value=""' . (!isset($chosenCountry) ? ' selected' : '') . '>&nbsp;</option>';
120
-					foreach($_country_lang as $key => $value) {
123
+					foreach($_country_lang as $key => $value) {
121 124
 						$output .= '<option value="' . $key . '"' . (isset($chosenCountry) && $chosenCountry == $key ? ' selected' : '') . '>' . $value . '</option>';
122 125
 					}
123
-				} else {
124
-					if($data['elements']) {
126
+				} else {
127
+					if($data['elements']) {
125 128
 						$elements = explode('||', $data['elements']);
126
-						foreach($elements as $key => $value) {
129
+						foreach($elements as $key => $value) {
127 130
 							$value = explode('==', $value);
128 131
 							$output .= '<option value="' . $value[1] . '">' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]) . '</option>';
129 132
 						}
@@ -139,9 +142,9 @@  discard block
 block discarded – undo
139 142
 				$output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
140 143
 				$output .= '<div class="col-sm-7">';
141 144
 				$output .= '<input type="checkbox" name="[+name+]" class="form-control" id="[+name+]" value="[+value+]" onChange="documentDirty=true;"[+readonly+] />';
142
-				if($data['elements']) {
145
+				if($data['elements']) {
143 146
 					$elements = explode('||', $data['elements']);
144
-					foreach($elements as $key => $value) {
147
+					foreach($elements as $key => $value) {
145 148
 						$value = explode('==', $value);
146 149
 						$output .= '<br /><input type="checkbox" name="' . $value[0] . '" class="form-control" id="' . $value[0] . '" value="' . $value[1] . '" onChange="documentDirty=true;"[+readonly+] /> ' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
147 150
 					}
@@ -155,9 +158,9 @@  discard block
 block discarded – undo
155 158
 				$output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
156 159
 				$output .= '<div class="col-sm-7">';
157 160
 				$output .= '<input type="radio" name="[+name+]" class="form-control" id="[+name+]" value="[+value+]" onChange="documentDirty=true;"[+readonly+] />';
158
-				if($data['elements']) {
161
+				if($data['elements']) {
159 162
 					$elements = explode('||', $data['elements']);
160
-					foreach($elements as $key => $value) {
163
+					foreach($elements as $key => $value) {
161 164
 						$value = explode('==', $value);
162 165
 						$output .= '<br /><input type="radio" name="[+name+]" class="form-control" id="[+name+]_' . $key . '" value="' . $value[1] . '" onChange="documentDirty=true;"[+readonly+] /> ' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
163 166
 					}
Please login to merge, or discard this patch.
manager/includes/tmplvars.format.inc.php 1 patch
Braces   +21 added lines, -8 removed lines patch added patch discarded remove patch
@@ -15,7 +15,8 @@  discard block
 block discarded – undo
15 15
  * @param string $sep
16 16
  * @return mixed|string
17 17
  */
18
-function getTVDisplayFormat($name, $value, $format, $paramstring = "", $tvtype = "", $docid = "", $sep = '') {
18
+function getTVDisplayFormat($name, $value, $format, $paramstring = "", $tvtype = "", $docid = "", $sep = '')
19
+{
19 20
 
20 21
     $modx = evolutionCMS();
21 22
     $o = '';
@@ -59,7 +60,9 @@  discard block
 block discarded – undo
59 60
 					if(isset($params['align']) && $params['align'] != 'none') {
60 61
 						$attr['align'] = $params['align'];
61 62
 					}
62
-					foreach($attr as $k => $v) $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
63
+					foreach($attr as $k => $v) {
64
+					    $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
65
+					}
63 66
 					$attributes .= ' ' . $params['attrib'];
64 67
 
65 68
 					// Output the image with attributes
@@ -128,7 +131,9 @@  discard block
 block discarded – undo
128 131
 						'style' => $params['style'],
129 132
 						'target' => $params['target'],
130 133
 					);
131
-					foreach($attr as $k => $v) $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
134
+					foreach($attr as $k => $v) {
135
+					    $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
136
+					}
132 137
 					$attributes .= ' ' . $params['attrib']; // add extra
133 138
 
134 139
 					// Output the link
@@ -157,7 +162,9 @@  discard block
 block discarded – undo
157 162
 					'class' => $params['class'],
158 163
 					'style' => $params['style'],
159 164
 				);
160
-				foreach($attr as $k => $v) $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
165
+				foreach($attr as $k => $v) {
166
+				    $attributes .= ($v ? ' ' . $k . '="' . $v . '"' : '');
167
+				}
161 168
 				$attributes .= ' ' . $params['attrib']; // add extra
162 169
 
163 170
 				// Output the HTML Tag
@@ -341,7 +348,8 @@  discard block
 block discarded – undo
341 348
  * @param string $s
342 349
  * @return string
343 350
  */
344
-function decodeParamValue($s) {
351
+function decodeParamValue($s)
352
+{
345 353
 	$s = str_replace("%3D", '=', $s); // =
346 354
 	return str_replace("%26", '&', $s); // &
347 355
 }
@@ -355,12 +363,16 @@  discard block
 block discarded – undo
355 363
  * @param bool $columns
356 364
  * @return array|string
357 365
  */
358
-function parseInput($src, $delim = "||", $type = "string", $columns = true) { // type can be: string, array
366
+function parseInput($src, $delim = "||", $type = "string", $columns = true)
367
+{
368
+// type can be: string, array
359 369
     $modx = evolutionCMS();
360 370
 	if($modx->db->isResult($src)) {
361 371
 		// must be a recordset
362 372
 		$rows = array();
363
-		while($cols = $modx->db->getRow($src, 'num')) $rows[] = ($columns) ? $cols : implode(" ", $cols);
373
+		while($cols = $modx->db->getRow($src, 'num')) {
374
+		    $rows[] = ($columns) ? $cols : implode(" ", $cols);
375
+		}
364 376
 		return ($type == "array") ? $rows : implode($delim, $rows);
365 377
 	} else {
366 378
 		// must be a text
@@ -376,7 +388,8 @@  discard block
 block discarded – undo
376 388
  * @param string $value
377 389
  * @return bool|false|int
378 390
  */
379
-function getUnixtimeFromDateString($value) {
391
+function getUnixtimeFromDateString($value)
392
+{
380 393
 	$timestamp = false;
381 394
 	// Check for MySQL or legacy style date
382 395
 	$date_match_1 = '/^([0-9]{2})-([0-9]{2})-([0-9]{4})\ ([0-9]{2}):([0-9]{2}):([0-9]{2})$/';
Please login to merge, or discard this patch.
manager/media/calendar/datepicker.inc.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,10 +1,13 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-class DATEPICKER {
4
-	function __construct() {
3
+class DATEPICKER
4
+{
5
+	function __construct()
6
+	{
5 7
 	}
6 8
 
7
-	function getDP() {
9
+	function getDP()
10
+	{
8 11
 		$modx = evolutionCMS(); global $_lang;
9 12
 
10 13
 		$tpl = file_get_contents(dirname(__FILE__) . '/datepicker.tpl');
Please login to merge, or discard this patch.