evolution-cms / evolution

manager/media/browser/mcpuk/lib/class_image_imagick.php

Indentation +10 added lines, -10 removed lines

@@ -1,16 +1,16 @@
 <?php
 
 /** This file is part of KCFinder project
-  *
-  *      @desc ImageMagick image driver class
-  *   @package KCFinder
-  *   @version 2.54
-  *    @author Pavel Tzonkov <sunhater@sunhater.com>
-  * @copyright 2010-2014 KCFinder Project
-  *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
-  *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
-  *      @link http://kcfinder.sunhater.com
-  */
+ *
+ *      @desc ImageMagick image driver class
+ *   @package KCFinder
+ *   @version 2.54
+ *    @author Pavel Tzonkov <sunhater@sunhater.com>
+ * @copyright 2010-2014 KCFinder Project
+ *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
+ *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
+ *      @link http://kcfinder.sunhater.com
+ */
 
 class image_imagick extends image
 {

Spacing +7 added lines, -7 removed lines

@@ -39,7 +39,7 @@ 
         return true;
     }
 
-    public function resizeFit($width, $height, $background=false)
+    public function resizeFit($width, $height, $background = false)
     {//
         if (!$width) {
             $width = 1;
@@ -74,7 +74,7 @@ 
         }
     }
 
-    public function resizeCrop($width, $height, $offset=false)
+    public function resizeCrop($width, $height, $offset = false)
     {
         if (!$width) {
             $width = 1;
@@ -138,7 +138,7 @@ 
         return true;
     }
 
-    public function rotate($angle, $background="#000000")
+    public function rotate($angle, $background = "#000000")
     {
         try {
             $this->image->rotateImage(new ImagickPixel($background), $angle);
@@ -171,7 +171,7 @@ 
         return true;
     }
 
-    public function watermark($file, $left=false, $top=false)
+    public function watermark($file, $left = false, $top = false)
     {
         try {
             $wm = new Imagick($file);
@@ -279,7 +279,7 @@ 
 
     // INHERIT METHODS
 
-    public function output($type="jpeg", array $options=array())
+    public function output($type = "jpeg", array $options = array())
     {
         $type = strtolower($type);
         try {
@@ -299,7 +299,7 @@ 
             }
             echo $this->image;
         } else {
-            $file = $options['file'] . ".$type";
+            $file = $options['file'].".$type";
             try {
                 $this->image->writeImage($file);
             } catch (Exception $e) {
@@ -319,7 +319,7 @@ 
 
     // OWN METHODS
 
-    protected function optimize_jpeg(array $options=array())
+    protected function optimize_jpeg(array $options = array())
     {
         $quality = isset($options['quality']) ? $options['quality'] : self::DEFAULT_JPEG_QUALITY;
         try {

Braces +4 added lines, -2 removed lines

@@ -22,7 +22,8 @@ 
     // ABSTRACT PUBLIC METHODS
 
     public function resize($width, $height)
-    {//
+    {
+//
         if (!$width) {
             $width = 1;
         }
@@ -40,7 +41,8 @@ 
     }
 
     public function resizeFit($width, $height, $background=false)
-    {//
+    {
+//
         if (!$width) {
             $width = 1;
         }

manager/media/browser/mcpuk/lib/helper_dir.php

Indentation +27 added lines, -27 removed lines

@@ -1,24 +1,24 @@ 
 <?php
 
 /** This file is part of KCFinder project
-  *
-  *      @desc Directory helper class
-  *   @package KCFinder
-  *   @version 2.54
-  *    @author Pavel Tzonkov <sunhater@sunhater.com>
-  * @copyright 2010-2014 KCFinder Project
-  *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
-  *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
-  *      @link http://kcfinder.sunhater.com
-  */
+ *
+ *      @desc Directory helper class
+ *   @package KCFinder
+ *   @version 2.54
+ *    @author Pavel Tzonkov <sunhater@sunhater.com>
+ * @copyright 2010-2014 KCFinder Project
+ *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
+ *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
+ *      @link http://kcfinder.sunhater.com
+ */
 
 class dir
 {
 
-  /** Checks if the given directory is really writable. The standard PHP
-    * function is_writable() does not work properly on Windows servers
-    * @param string $dir
-    * @return bool */
+    /** Checks if the given directory is really writable. The standard PHP
+     * function is_writable() does not work properly on Windows servers
+     * @param string $dir
+     * @return bool */
 
     public static function isWritable($dir)
     {
@@ -38,15 +38,15 @@ 
     }
 
     /** Recursively delete the given directory. Returns TRUE on success.
-      * If $firstFailExit parameter is true (default), the method returns the
-      * path to the first failed file or directory which cannot be deleted.
-      * If $firstFailExit is false, the method returns an array with failed
-      * files and directories which cannot be deleted. The third parameter
-      * $failed is used for internal use only.
-      * @param string $dir
-      * @param bool $firstFailExit
-      * @param array $failed
-      * @return mixed */
+     * If $firstFailExit parameter is true (default), the method returns the
+     * path to the first failed file or directory which cannot be deleted.
+     * If $firstFailExit is false, the method returns an array with failed
+     * files and directories which cannot be deleted. The third parameter
+     * $failed is used for internal use only.
+     * @param string $dir
+     * @param bool $firstFailExit
+     * @param array $failed
+     * @return mixed */
 
     public static function prune($dir, $firstFailExit=true, array $failed=null)
     {
@@ -94,10 +94,10 @@ 
     }
 
     /** Get the content of the given directory. Returns an array with filenames
-      * or FALSE on failure
-      * @param string $dir
-      * @param array $options
-      * @return mixed */
+     * or FALSE on failure
+     * @param string $dir
+     * @param array $options
+     * @return mixed */
 
     public static function content($dir, array $options=null)
     {

Spacing +5 added lines, -5 removed lines

@@ -28,7 +28,7 @@ 
         }
         $i = 0;
         do {
-            $file = "$dir/is_writable_" . md5($i++);
+            $file = "$dir/is_writable_".md5($i++);
         } while (file_exists($file));
         if (!@touch($file)) {
             return false;
@@ -48,7 +48,7 @@ 
       * @param array $failed
       * @return mixed */
 
-    public static function prune($dir, $firstFailExit=true, array $failed=null)
+    public static function prune($dir, $firstFailExit = true, array $failed = null)
     {
         if ($failed === null) {
             $failed = array();
@@ -99,12 +99,12 @@ 
       * @param array $options
       * @return mixed */
 
-    public static function content($dir, array $options=null)
+    public static function content($dir, array $options = null)
     {
         $defaultOptions = array(
-            'types' => "all",   // Allowed: "all" or possible return values
+            'types' => "all", // Allowed: "all" or possible return values
                                 // of filetype(), or an array with them
-            'addPath' => true,  // Whether to add directory path to filenames
+            'addPath' => true, // Whether to add directory path to filenames
             'pattern' => '/./', // Regular expression pattern for filename
             'followLinks' => true
         );

manager/media/browser/mcpuk/browse.php

Indentation +10 added lines, -10 removed lines

@@ -1,16 +1,16 @@
 <?php
 
 /** This file is part of KCFinder project
-  *
-  *      @desc Browser calling script
-  *   @package KCFinder
-  *   @version 2.54
-  *    @author Pavel Tzonkov <sunhater@sunhater.com>
-  * @copyright 2010-2014 KCFinder Project
-  *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
-  *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
-  *      @link http://kcfinder.sunhater.com
-  */
+ *
+ *      @desc Browser calling script
+ *   @package KCFinder
+ *   @version 2.54
+ *    @author Pavel Tzonkov <sunhater@sunhater.com>
+ * @copyright 2010-2014 KCFinder Project
+ *   @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
+ *   @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
+ *      @link http://kcfinder.sunhater.com
+ */
 
 require "core/autoload.php"; // Init MODX
 

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 if ($_GET['type'] == 'images' && !$modx->hasPermission('file_manager') && !$modx->hasPermission('assets_images')) {
     returnNoPermissionsMessage('assets_images');
 }
-if ($_GET['type'] == 'files'  && !$modx->hasPermission('file_manager') && !$modx->hasPermission('assets_files')) {
+if ($_GET['type'] == 'files' && !$modx->hasPermission('file_manager') && !$modx->hasPermission('assets_files')) {
     returnNoPermissionsMessage('assets_files');
 }
 

manager/media/browser/mcpuk/lang/uk.php

Indentation +3 added lines, -3 removed lines

@@ -1,9 +1,9 @@
 <?php
 
 /** Ukrainian localization file for KCFinder
-    * author: Myroslav Dobra
-    * E-mail: dmaraptor@mail.ru
-  */
+ * author: Myroslav Dobra
+ * E-mail: dmaraptor@mail.ru
+ */
 
 $lang = array(
 

manager/media/browser/mcpuk/browser.php

Spacing +2 added lines, -2 removed lines

@@ -18,11 +18,11 @@
         $type = 'images';

     }

     

-    if ($type==='image') {

+    if ($type === 'image') {

         $type = 'images';

     }

     

-    $opener = (isset($_GET['editor'])) ? 'opener=' . htmlspecialchars(trim($_GET['editor']), ENT_QUOTES) : '';

+    $opener = (isset($_GET['editor'])) ? 'opener='.htmlspecialchars(trim($_GET['editor']), ENT_QUOTES) : '';

     $request_uri = "{$opener}&type={$type}";

 ?>

 		window.location.href = "browse.php?<?php echo $request_uri; ?>";

Braces +4 added lines, -4 removed lines

@@ -10,15 +10,15 @@
 			}

 		};

 <?php

-    if (isset($_GET['type'])) {

+    if (isset($_GET['type'])) {
         $type = htmlspecialchars(trim($_GET['type']), ENT_QUOTES);

-    } elseif (isset($_GET['Type'])) {

+    } elseif (isset($_GET['Type'])) {
         $type = htmlspecialchars(trim($_GET['Type']), ENT_QUOTES);

-    } else {

+    } else {
         $type = 'images';

     }

     

-    if ($type==='image') {

+    if ($type==='image') {
         $type = 'images';

     }

     

manager/media/script/air-datepicker/datepicker.inc.php

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
     {
         $modx = evolutionCMS();
 
-        $load_script = file_get_contents(dirname(__FILE__) . '/datepicker.tpl');
+        $load_script = file_get_contents(dirname(__FILE__).'/datepicker.tpl');
         if (!isset($modx->config['lang_code'])) {
             $modx->config['lang_code'] = $this->getLangCode();
         }

manager/media/style/default/style.php

Spacing +106 added lines, -106 removed lines

@@ -8,7 +8,7 @@ 
  * Version:        1.1

  * MODX version:   1.0.3

  */

-$style_path = 'media/style/' . $modx->config['manager_theme'] . '/images/';

+$style_path = 'media/style/'.$modx->config['manager_theme'].'/images/';

 $modx->config['mgr_date_picker_path'] = 'media/calendar/datepicker.inc.php';

 if (!$modx->config['lang_code']) {

     global $modx_lang_attribute;

@@ -20,7 +20,7 @@ 
 }

 

 // Favicon

-$_style['favicon']                  = (file_exists(MODX_BASE_PATH . 'favicon.ico') ? MODX_SITE_URL . 'favicon.ico' : 'media/style/' . $modx->config['manager_theme'] . '/images/favicon.ico');

+$_style['favicon']                  = (file_exists(MODX_BASE_PATH.'favicon.ico') ? MODX_SITE_URL . 'favicon.ico' : 'media/style/'.$modx->config['manager_theme'].'/images/favicon.ico');

 

 //Main Menu

 $_style['menu_search']              = '<i class="fa fa-search"></i>';

@@ -52,7 +52,7 @@ 
 $_style['expand_tree']              = '<i class="fa fa-arrow-circle-down"></i>';

 $_style['hide_tree']                = '<i class="fa fa-caret-square-o-left"></i>';

 $_style['refresh_tree']             = '<i class="fa fa-refresh"></i>';

-$_style['show_tree']                = $style_path . 'tree/expand.png';

+$_style['show_tree']                = $style_path.'tree/expand.png';

 $_style['sort_tree']                = '<i class="fa fa-sort"></i>';

 $_style['sort_menuindex']           = '<i class="fa fa-sort-numeric-asc"></i>';

 $_style['element_management']       = '<i class="fa fa-th"></i>';

@@ -76,9 +76,9 @@ 
 

 // Tree Icons

 $_style['tree_deletedpage']         = "<i class='fa fa-ban'></i>";

-$_style['tree_folder']              = $style_path . 'tree/folder-close-alt.png'; /* folder.png */

-$_style['tree_folderopen']          = $style_path . 'tree/folder-open-alt.png'; /* folder-open.png */

-$_style['tree_globe']               = $style_path . 'tree/globe.png';

+$_style['tree_folder']              = $style_path.'tree/folder-close-alt.png'; /* folder.png */

+$_style['tree_folderopen']          = $style_path.'tree/folder-open-alt.png'; /* folder-open.png */

+$_style['tree_globe']               = $style_path.'tree/globe.png';

 $_style['tree_folder_new']          = "<i class='fa fa-folder'></i>"; /* folder.png */

 $_style['tree_folderopen_new']      = "<i class='fa fa-folder-open'></i>"; /* folder-open.png */

 $_style['tree_folder_secure']       = "<i class='fa fa-folder'><i class='fa fa-lock'></i></i>";

@@ -99,10 +99,10 @@ 
 $_style['tree_page_word']           = "<i class='fa fa-file-word-o'></i>";

 $_style['tree_page_excel']          = "<i class='fa fa-file-excel-o'></i>";

 

-$_style['tree_minusnode']           = "<i class='fa fa-angle-down'></i>";//$style_path.'tree/angle-down.png';

-$_style['tree_plusnode']            = "<i class='fa fa-angle-right'></i>";//$style_path.'tree/angle-right.png';

-$_style['tree_weblink']             = $style_path . 'tree/link.png';

-$_style['tree_preview_resource']    = "<i class='fa fa-eye'></i>";//$style_path.'icons/eye.png';

+$_style['tree_minusnode']           = "<i class='fa fa-angle-down'></i>"; //$style_path.'tree/angle-down.png';

+$_style['tree_plusnode']            = "<i class='fa fa-angle-right'></i>"; //$style_path.'tree/angle-right.png';

+$_style['tree_weblink']             = $style_path.'tree/link.png';

+$_style['tree_preview_resource']    = "<i class='fa fa-eye'></i>"; //$style_path.'icons/eye.png';

 

 $_style['tree_showtree']            = '<i class="fa fa-sitemap"></i>';

 $_style['tree_working']             = '<i class="fa fa-warning"></i>';

@@ -133,12 +133,12 @@ 
 $_style['icons_resource_overview']  = 'fa fa-info';

 $_style['icons_edit_resource']      = 'fa fa-pencil-square-o';

 //context menu

-$_style['icons_resource_duplicate'] = $style_path . 'icons/clone.png';

-$_style['icons_edit_document']      = $style_path . 'icons/save.png';

-$_style['icons_delete_document']    = $style_path . 'icons/trash.png';

+$_style['icons_resource_duplicate'] = $style_path.'icons/clone.png';

+$_style['icons_edit_document']      = $style_path.'icons/save.png';

+$_style['icons_delete_document']    = $style_path.'icons/trash.png';

 //locks

-$_style['icons_preview_resource']   = $style_path . 'icons/eye.png';//$style_path.'icons/eye.png';

-$_style['icons_secured']            = "<i class='fa fa-lock'></i>";//$style_path.'icons/lock.png';

+$_style['icons_preview_resource']   = $style_path.'icons/eye.png'; //$style_path.'icons/eye.png';

+$_style['icons_secured']            = "<i class='fa fa-lock'></i>"; //$style_path.'icons/lock.png';

 

 //file manager icons

 $_style['files_save']               = 'fa fa-floppy-o';

@@ -199,66 +199,66 @@ 
 

 //for back compatibility

 

-$_style['icons_save']               = $style_path . 'icons/save.png';

-$_style['icons_delete']             = $style_path . 'icons/trash.png';

-$_style['icons_deleted_folder']     = $style_path . 'tree/deletedfolder.png';

-$_style['icons_unzip']              = $style_path . 'icons/download-alt.png';

+$_style['icons_save']               = $style_path.'icons/save.png';

+$_style['icons_delete']             = $style_path.'icons/trash.png';

+$_style['icons_deleted_folder']     = $style_path.'tree/deletedfolder.png';

+$_style['icons_unzip']              = $style_path.'icons/download-alt.png';

 

 

 // Indicators

 $_style['icons_tooltip']            = 'fa fa-question-circle';

-$_style['icons_tooltip_over']       = $style_path . 'icons/question-sign.png';

-$_style['icons_cal']                = $style_path . 'icons/calendar.png';

-$_style['icons_cal_nodate']         = $style_path . 'icons/calendar.png';

-$_style['icons_set_parent']         = $style_path . 'icons/folder-open.png';

+$_style['icons_tooltip_over']       = $style_path.'icons/question-sign.png';

+$_style['icons_cal']                = $style_path.'icons/calendar.png';

+$_style['icons_cal_nodate']         = $style_path.'icons/calendar.png';

+$_style['icons_set_parent']         = $style_path.'icons/folder-open.png';

 

 //modules

-$_style['icons_module']            = 'fa fa-cube';

+$_style['icons_module'] = 'fa fa-cube';

 $_style['icons_modules']            = 'fa fa-cubes'; //$style_path.'icons/modules.png';

-$_style['icons_run']                = $style_path . 'icons/play.png';

+$_style['icons_run']                = $style_path.'icons/play.png';

 

 //users and webusers

 $_style['icons_user']               = 'fa fa-user'; //$style_path.'icons/user.png';

 

 //Messages

-$_style['icons_message_unread']     = $style_path . 'icons/email.png';

-$_style['icons_message_forward']    = $style_path . 'icons/forward.png';

-$_style['icons_message_reply']      = $style_path . 'icons/reply.png';

+$_style['icons_message_unread']     = $style_path.'icons/email.png';

+$_style['icons_message_forward']    = $style_path.'icons/forward.png';

+$_style['icons_message_reply']      = $style_path.'icons/reply.png';

 

 // Icons

-$_style['icons_add']                = $style_path . 'icons/add.png';

-$_style['icons_cancel']             = $style_path . 'icons/cancel.png';

-$_style['icons_close']              = $style_path . 'icons/stop.png';

-$_style['icons_refresh']            = $style_path . 'icons/refresh.png';

-$_style['icons_table']              = $style_path . 'icons/table.png';

+$_style['icons_add']                = $style_path.'icons/add.png';

+$_style['icons_cancel']             = $style_path.'icons/cancel.png';

+$_style['icons_close']              = $style_path.'icons/stop.png';

+$_style['icons_refresh']            = $style_path.'icons/refresh.png';

+$_style['icons_table']              = $style_path.'icons/table.png';

 

 // top bar

-$_style['icons_loading_doc_tree']   = $style_path . 'icons/info-sign.png';

-$_style['icons_mail']               = $style_path . 'icons/email.png';

-$_style['icons_working']            = $style_path . 'icons/exclamation.png';

+$_style['icons_loading_doc_tree']   = $style_path.'icons/info-sign.png';

+$_style['icons_mail']               = $style_path.'icons/email.png';

+$_style['icons_working']            = $style_path.'icons/exclamation.png';

 

 //event log

-$_style['icons_event1']             = $style_path . 'icons/event1.png';

-$_style['icons_event2']             = $style_path . 'icons/event2.png';

-$_style['icons_event3']             = $style_path . 'icons/event3.png';

+$_style['icons_event1']             = $style_path.'icons/event1.png';

+$_style['icons_event2']             = $style_path.'icons/event2.png';

+$_style['icons_event3']             = $style_path.'icons/event3.png';

 

 

 //nowhere in the manager

-$_style['icons_folder']             = $style_path . 'icons/folder.png';

-$_style['icons_email']              = $style_path . 'icons/email.png';

-$_style['icons_home']               = $style_path . 'icons/home.png';

-$_style['icons_sort_menuindex']     = $style_path . 'icons/sort_index.png';

-$_style['icons_weblink']            = $style_path . 'icons/world_link.png';

-$_style['icons_tab_preview']        = $style_path . 'icons/preview.png'; // Tabs

-$_style['icons_information']        = $style_path . 'icons/info-sign.png';

+$_style['icons_folder']             = $style_path.'icons/folder.png';

+$_style['icons_email']              = $style_path.'icons/email.png';

+$_style['icons_home']               = $style_path.'icons/home.png';

+$_style['icons_sort_menuindex']     = $style_path.'icons/sort_index.png';

+$_style['icons_weblink']            = $style_path.'icons/world_link.png';

+$_style['icons_tab_preview']        = $style_path.'icons/preview.png'; // Tabs

+$_style['icons_information']        = $style_path.'icons/info-sign.png';

 

 

 // Miscellaneous

-$_style['ajax_loader']              = '<p>' . $_lang['loading_page'] . '</p><p><i class="fa fa-spinner fa-spin"></i></p>';

-$_style['tx']                       = $style_path . 'misc/_tx_.gif';

-$_style['icons_right_arrow']        = $style_path . 'icons/arrow-right.png';

-$_style['fade']                     = $style_path . 'misc/fade.gif';

-$_style['ed_save']                  = $style_path . 'misc/ed_save.gif';

+$_style['ajax_loader']              = '<p>'.$_lang['loading_page'].'</p><p><i class="fa fa-spinner fa-spin"></i></p>';

+$_style['tx']                       = $style_path.'misc/_tx_.gif';

+$_style['icons_right_arrow']        = $style_path.'icons/arrow-right.png';

+$_style['fade']                     = $style_path.'misc/fade.gif';

+$_style['ed_save']                  = $style_path.'misc/ed_save.gif';

 

 // actions buttons templates

 $action = isset($_REQUEST['a']) ? $_REQUEST['a'] : '';

@@ -337,30 +337,30 @@ 
 			<div class="btn-group">

 				<div class="btn-group">

 					<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.save();">

-						<i class="' . $_style["actions_save"] . '"></i><span>' . $_lang['save'] . '</span>

+						<i class="' . $_style["actions_save"].'"></i><span>'.$_lang['save'].'</span>

 					</a>

 					<span class="btn btn-success plus dropdown-toggle"></span>

 					<select id="stay" name="stay">

 						' . ($addnew ? '

-							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '') . '>' . $_lang['stay_new'] . '</option>

-						' : '') . '

-						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '') . '>' . $_lang['stay'] . '</option>

-						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '') . '>' . $_lang['close'] . '</option>

+							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '').'>'.$_lang['stay_new'].'</option>

+						' : '').'

+						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '').'>'.$_lang['stay'].'</option>

+						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '').'>'.$_lang['close'].'</option>

 					</select>

 				</div>' .

                     ($addnew ? '

-					<a id="Button6" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.duplicate();">

-						<i class="' . $_style["actions_duplicate"] . '"></i><span>' . $_lang['duplicate'] . '</span>

+					<a id="Button6" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.duplicate();">

+						<i class="' . $_style["actions_duplicate"].'"></i><span>'.$_lang['duplicate'].'</span>

 					</a>

-					' : '') . '

-				<a id="Button3" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+					' : '').'

+				<a id="Button3" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.delete();">

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 				<a id="Button4" class="btn btn-secondary" href="javascript:;" onclick="actions.view();">

-					<i class="' . $_style["actions_preview"] . '"></i><span>' . $_lang['preview'] . '</span>

+					<i class="' . $_style["actions_preview"].'"></i><span>'.$_lang['preview'].'</span>

 				</a>

 			</div>

 		</div>',

@@ -368,22 +368,22 @@ 
 			<div class="btn-group">

 				<div class="btn-group">

 					<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.save();">

-						<i class="' . $_style["actions_save"] . '"></i><span>' . $_lang['save'] . '</span>

+						<i class="' . $_style["actions_save"].'"></i><span>'.$_lang['save'].'</span>

 					</a>

 					<span class="btn btn-success plus dropdown-toggle"></span>

 					<select id="stay" name="stay">

 						' . ($addnew ? '

-							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '') . '>' . $_lang['stay_new'] . '</option>

-						' : '') . '

-						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '') . '>' . $_lang['stay'] . '</option>

-						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '') . '>' . $_lang['close'] . '</option>

+							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '').'>'.$_lang['stay_new'].'</option>

+						' : '').'

+						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '').'>'.$_lang['stay'].'</option>

+						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '').'>'.$_lang['close'].'</option>

 					</select>

 				</div>

-				<a id="Button3" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+				<a id="Button3" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.delete();">

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

@@ -391,86 +391,86 @@ 
 			<div class="btn-group">

 				<div class="btn-group">

 					<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.save();">

-						<i class="' . $_style["actions_save"] . '"></i><span>' . $_lang['save'] . '</span>

+						<i class="' . $_style["actions_save"].'"></i><span>'.$_lang['save'].'</span>

 					</a>

 					<span class="btn btn-success plus dropdown-toggle"></span>

 					<select id="stay" name="stay">

 						' . ($addnew ? '

-							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '') . '>' . $_lang['stay_new'] . '</option>

-						' : '') . '

-						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '') . '>' . $_lang['stay'] . '</option>

-						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '') . '>' . $_lang['close'] . '</option>

+							<option id="stay1" value="1" ' . ($stay == '1' ? ' selected="selected"' : '').'>'.$_lang['stay_new'].'</option>

+						' : '').'

+						<option id="stay2" value="2" ' . ($stay == '2' ? ' selected="selected"' : '').'>'.$_lang['stay'].'</option>

+						<option id="stay3" value="" ' . ($stay == '' ? ' selected="selected"' : '').'>'.$_lang['close'].'</option>

 					</select>

 				</div>

 				' . ($addnew ? '

-				<a id="Button6" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.duplicate();">

-					<i class="' . $_style["actions_duplicate"] . '"></i><span>' . $_lang['duplicate'] . '</span>

+				<a id="Button6" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.duplicate();">

+					<i class="' . $_style["actions_duplicate"].'"></i><span>'.$_lang['duplicate'].'</span>

 				</a>

-				' : '') . '

-				<a id="Button3" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+				' : '').'

+				<a id="Button3" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.delete();">

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 				' . ($run ? '

-				<a id="Button4" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.run();">

-					<i class="' . $_style["actions_run"] . '"></i><span>' . $_lang['run_module'] . '</span>

+				<a id="Button4" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.run();">

+					<i class="' . $_style["actions_run"].'"></i><span>'.$_lang['run_module'].'</span>

 				</a>

-				' : '') . '

+				' : '').'

 			</div>

 		</div>',

         'newmodule' => ($addnew ? '<div id="actions">

 			<div class="btn-group">

 				<a id="newModule" class="btn btn-secondary" href="javascript:;" onclick="actions.new();">

-					<i class="' . $_style["actions_new"] . '"></i><span>' . $_lang['new_module'] . '</span>

+					<i class="' . $_style["actions_new"].'"></i><span>'.$_lang['new_module'].'</span>

 				</a>

 			</div>

 		</div>' : ''),

         'close' => '<div id="actions">

 			<div class="btn-group">

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.close();">

-					<i class="' . $_style["actions_close"] . '"></i><span>' . $_lang['close'] . '</span>

+					<i class="' . $_style["actions_close"].'"></i><span>'.$_lang['close'].'</span>

 				</a>

 			</div>

 		</div>',

         'save' => '<div id="actions">

 			<div class="btn-group">

 				<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.save();">

-					<i class="' . $_style["actions_save"] . '"></i><span>' . $_lang['save'] . '</span>

+					<i class="' . $_style["actions_save"].'"></i><span>'.$_lang['save'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

         'savedelete' => '<div id="actions">

 			<div class="btn-group">

 				<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.save();">

-					<i class="' . $_style["actions_save"] . '"></i><span>' . $_lang['save'] . '</span>

+					<i class="' . $_style["actions_save"].'"></i><span>'.$_lang['save'].'</span>

 				</a>

-				<a id="Button3" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+				<a id="Button3" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.delete();">

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

         'cancel' => '<div id="actions">

 			<div class="btn-group">

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

         'canceldelete' => '<div id="actions">

 			<div class="btn-group">

-				<a id="Button3" class="btn btn-secondary' . $disabled . '" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+				<a id="Button3" class="btn btn-secondary' . $disabled.'" href="javascript:;" onclick="actions.delete();">

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

@@ -480,33 +480,33 @@ 
 			<div class="btn-group">' .

                 ($addnew ? '

 					<a class="btn btn-secondary" href="javascript:;" onclick="actions.new();">

-						<i class="' . $_style["icons_new_document"] . '"></i><span>' . $_lang['create_resource_here'] . '</span>

+						<i class="' . $_style["icons_new_document"].'"></i><span>'.$_lang['create_resource_here'].'</span>

 					</a>

 					<a class="btn btn-secondary" href="javascript:;" onclick="actions.newlink();">

-						<i class="' . $_style["icons_new_weblink"] . '"></i><span>' . $_lang['create_weblink_here'] . '</span>

+						<i class="' . $_style["icons_new_weblink"].'"></i><span>'.$_lang['create_weblink_here'].'</span>

 					</a>

-				' : '') . '

+				' : '').'

 				<a id="Button1" class="btn btn-success" href="javascript:;" onclick="actions.edit();">

-					<i class="' . $_style["actions_edit"] . '"></i><span>' . $_lang['edit'] . '</span>

+					<i class="' . $_style["actions_edit"].'"></i><span>'.$_lang['edit'].'</span>

 				</a>

 				<a id="Button2" class="btn btn-secondary" href="javascript:;" onclick="actions.move();">

-					<i class="' . $_style["actions_move"] . '"></i><span>' . $_lang['move'] . '</span>

+					<i class="' . $_style["actions_move"].'"></i><span>'.$_lang['move'].'</span>

 				</a>

 				<a id="Button6" class="btn btn-secondary" href="javascript:;" onclick="actions.duplicate();">

-					<i class="' . $_style["actions_duplicate"] . '"></i><span>' . $_lang['duplicate'] . '</span>

+					<i class="' . $_style["actions_duplicate"].'"></i><span>'.$_lang['duplicate'].'</span>

 				</a>

 				<a id="Button3" class="btn btn-secondary" href="javascript:;" onclick="actions.delete();">

-					<i class="' . $_style["actions_delete"] . '"></i><span>' . $_lang['delete'] . '</span>

+					<i class="' . $_style["actions_delete"].'"></i><span>'.$_lang['delete'].'</span>

 				</a>

 				<a id="Button4" class="btn btn-secondary" href="javascript:;" onclick="actions.view();">

-					<i class="' . $_style["actions_preview"] . '"></i><span>' . $_lang['preview'] . '</span>

+					<i class="' . $_style["actions_preview"].'"></i><span>'.$_lang['preview'].'</span>

 				</a>

 			</div>

 		</div>',

         'cancel' => '<div id="actions">

 			<div class="btn-group">

 				<a id="Button5" class="btn btn-secondary" href="javascript:;" onclick="actions.cancel();">

-					<i class="' . $_style["actions_cancel"] . '"></i><span>' . $_lang['cancel'] . '</span>

+					<i class="' . $_style["actions_cancel"].'"></i><span>'.$_lang['cancel'].'</span>

 				</a>

 			</div>

 		</div>',

Braces +15 added lines, -15 removed lines

@@ -10,12 +10,12 @@ 
  */

 $style_path = 'media/style/' . $modx->config['manager_theme'] . '/images/';

 $modx->config['mgr_date_picker_path'] = 'media/calendar/datepicker.inc.php';

-if (!$modx->config['lang_code']) {

+if (!$modx->config['lang_code']) {
     global $modx_lang_attribute;

     $modx->config['lang_code'] = !$modx_lang_attribute ? 'en' : $modx_lang_attribute;

 }

 

-if ($_GET['a'] == 2) {

+if ($_GET['a'] == 2) {
     include_once('welcome.php');

 }

 

@@ -262,68 +262,68 @@ 
 

 // actions buttons templates

 $action = isset($_REQUEST['a']) ? $_REQUEST['a'] : '';

-if (!empty($modx->config['global_tabs']) && !isset($_SESSION['stay'])) {

+if (!empty($modx->config['global_tabs']) && !isset($_SESSION['stay'])) {
     $_REQUEST['stay'] = 2;

 }

-if (isset($_REQUEST['stay'])) {

+if (isset($_REQUEST['stay'])) {
     $_SESSION['stay'] = $_REQUEST['stay'];

-} elseif (isset($_SESSION['stay'])) {

+} elseif (isset($_SESSION['stay'])) {
     $_REQUEST['stay'] = $_SESSION['stay'];

 }

 $stay = isset($_REQUEST['stay']) ? $_REQUEST['stay'] : '';

 $addnew = 0;

 $run = 0;

-switch ($action) {

+switch ($action) {
     case '3':

     case '4':

     case '27':

     case '72':

-        if ($modx->hasPermission('new_document')) {

+        if ($modx->hasPermission('new_document')) {
             $addnew = 1;

         }

         break;

     case '16':

     case '19':

-        if ($modx->hasPermission('new_template')) {

+        if ($modx->hasPermission('new_template')) {
             $addnew = 1;

         }

         break;

     case '300':

     case '301':

-        if ($modx->hasPermission('new_snippet') && $modx->hasPermission('new_chunk') && $modx->hasPermission('new_plugin')) {

+        if ($modx->hasPermission('new_snippet') && $modx->hasPermission('new_chunk') && $modx->hasPermission('new_plugin')) {
             $addnew = 1;

         }

         break;

     case '77':

     case '78':

-        if ($modx->hasPermission('new_chunk')) {

+        if ($modx->hasPermission('new_chunk')) {
             $addnew = 1;

         }

         break;

     case '22':

     case '23':

-        if ($modx->hasPermission('new_snippet')) {

+        if ($modx->hasPermission('new_snippet')) {
             $addnew = 1;

         }

         break;

     case '101':

     case '102':

-        if ($modx->hasPermission('new_plugin')) {

+        if ($modx->hasPermission('new_plugin')) {
             $addnew = 1;

         }

         break;

     case '106':

     case '107':

     case '108':

-        if ($modx->hasPermission('new_module')) {

+        if ($modx->hasPermission('new_module')) {
             $addnew = 1;

         }

-        if ($modx->hasPermission('exec_module')) {

+        if ($modx->hasPermission('exec_module')) {
             $run = 1;

         }

         break;

     case '88':

-        if ($modx->hasPermission('new_web_user')) {

+        if ($modx->hasPermission('new_web_user')) {
             $addnew = 1;

         }

         break;

manager/media/style/default/ajax.php

Spacing +98 added lines, -98 removed lines

@@ -19,11 +19,11 @@ 
 $modx->loadExtension("ManagerAPI");

 

 $_lang = array();

-include_once MODX_MANAGER_PATH . '/includes/lang/english.inc.php';

+include_once MODX_MANAGER_PATH.'/includes/lang/english.inc.php';

 if ($modx->config['manager_language'] != 'english') {

-    include_once MODX_MANAGER_PATH . '/includes/lang/' . $modx->config['manager_language'] . '.inc.php';

+    include_once MODX_MANAGER_PATH.'/includes/lang/'.$modx->config['manager_language'].'.inc.php';

 }

-include_once MODX_MANAGER_PATH . '/media/style/' . $modx->config['manager_theme'] . '/style.php';

+include_once MODX_MANAGER_PATH.'/media/style/'.$modx->config['manager_theme'].'/style.php';

 

 $action = isset($_REQUEST['a']) ? $_REQUEST['a'] : '';

 $frame = isset($_REQUEST['f']) ? $_REQUEST['f'] : '';

@@ -40,7 +40,7 @@ 
 

             switch ($frame) {

                 case 'nodes':

-                    include_once MODX_MANAGER_PATH . '/frames/nodes.php';

+                    include_once MODX_MANAGER_PATH.'/frames/nodes.php';

 

                     break;

             }

@@ -58,21 +58,21 @@ 
                 $sql = '';

                 $a = '';

                 $filter = !empty($_REQUEST['filter']) && is_scalar($_REQUEST['filter']) ? addcslashes(trim($_REQUEST['filter']), '%*_') : '';

-                $sqlLike = $filter ? 'WHERE t1.name LIKE "' . $modx->db->escape($filter) . '%"' : '';

-                $sqlLimit = $sqlLike ? '' : 'LIMIT ' . $limit;

+                $sqlLike = $filter ? 'WHERE t1.name LIKE "'.$modx->db->escape($filter).'%"' : '';

+                $sqlLimit = $sqlLike ? '' : 'LIMIT '.$limit;

 

                 switch ($elements) {

                     case 'element_templates':

                         $a = 16;

-                        $sqlLike = $filter ? 'WHERE t1.templatename LIKE "' . $modx->db->escape($filter) . '%"' : '';

+                        $sqlLike = $filter ? 'WHERE t1.templatename LIKE "'.$modx->db->escape($filter).'%"' : '';

                         $sql = $modx->db->query('SELECT t1.*, t1.templatename AS name

-                        FROM ' . $modx->getFullTableName('site_templates') . ' AS t1

-                        ' . $sqlLike . '

+                        FROM ' . $modx->getFullTableName('site_templates').' AS t1

+                        ' . $sqlLike.'

                         ORDER BY t1.templatename ASC

                         ' . $sqlLimit);

 

                         if ($modx->hasPermission('new_template')) {

-                            $output .= '<li><a id="a_19" href="index.php?a=19" target="main"><i class="fa fa-plus"></i>' . $_lang['new_template'] . '</a></li>';

+                            $output .= '<li><a id="a_19" href="index.php?a=19" target="main"><i class="fa fa-plus"></i>'.$_lang['new_template'].'</a></li>';

                         }

 

                         break;

@@ -80,15 +80,15 @@ 
                     case 'element_tplvars':

                         $a = 301;

                         $sql = $modx->db->query('SELECT t1.id,t1.name,t1.locked, IF(MIN(t2.tmplvarid),0,1) AS disabled

-                        FROM ' . $modx->getFullTableName('site_tmplvars') . ' AS t1

-                        LEFT JOIN ' . $modx->getFullTableName('site_tmplvar_templates') . ' AS t2 ON t1.id=t2.tmplvarid

-                        ' . $sqlLike . '

+                        FROM ' . $modx->getFullTableName('site_tmplvars').' AS t1

+                        LEFT JOIN ' . $modx->getFullTableName('site_tmplvar_templates').' AS t2 ON t1.id=t2.tmplvarid

+                        ' . $sqlLike.'

                         GROUP BY t1.id

                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

                         if ($modx->hasPermission('edit_template') && $modx->hasPermission('edit_snippet') && $modx->hasPermission('edit_chunk') && $modx->hasPermission('edit_plugin')) {

-                            $output .= '<li><a id="a_300" href="index.php?a=300" target="main"><i class="fa fa-plus"></i>' . $_lang['new_tmplvars'] . '</a></li>';

+                            $output .= '<li><a id="a_300" href="index.php?a=300" target="main"><i class="fa fa-plus"></i>'.$_lang['new_tmplvars'].'</a></li>';

                         }

 

                         break;

@@ -96,13 +96,13 @@ 
                     case 'element_htmlsnippets':

                         $a = 78;

                         $sql = $modx->db->query('SELECT t1.*

-                        FROM ' . $modx->getFullTableName('site_htmlsnippets') . ' AS t1

-                        ' . $sqlLike . '

+                        FROM ' . $modx->getFullTableName('site_htmlsnippets').' AS t1

+                        ' . $sqlLike.'

                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

                         if ($modx->hasPermission('new_chunk')) {

-                            $output .= '<li><a id="a_77" href="index.php?a=77" target="main"><i class="fa fa-plus"></i>' . $_lang['new_htmlsnippet'] . '</a></li>';

+                            $output .= '<li><a id="a_77" href="index.php?a=77" target="main"><i class="fa fa-plus"></i>'.$_lang['new_htmlsnippet'].'</a></li>';

                         }

 

                         break;

@@ -110,13 +110,13 @@ 
                     case 'element_snippets':

                         $a = 22;

                         $sql = $modx->db->query('SELECT t1.*

-                        FROM ' . $modx->getFullTableName('site_snippets') . ' AS t1

-                        ' . $sqlLike . '

+                        FROM ' . $modx->getFullTableName('site_snippets').' AS t1

+                        ' . $sqlLike.'

                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

                         if ($modx->hasPermission('new_snippet')) {

-                            $output .= '<li><a id="a_23" href="index.php?a=23" target="main"><i class="fa fa-plus"></i>' . $_lang['new_snippet'] . '</a></li>';

+                            $output .= '<li><a id="a_23" href="index.php?a=23" target="main"><i class="fa fa-plus"></i>'.$_lang['new_snippet'].'</a></li>';

                         }

 

                         break;

@@ -124,13 +124,13 @@ 
                     case 'element_plugins':

                         $a = 102;

                         $sql = $modx->db->query('SELECT t1.*

-                        FROM ' . $modx->getFullTableName('site_plugins') . ' AS t1

-                        ' . $sqlLike . '

+                        FROM ' . $modx->getFullTableName('site_plugins').' AS t1

+                        ' . $sqlLike.'

                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

                         if ($modx->hasPermission('new_plugin')) {

-                            $output .= '<li><a id="a_101" href="index.php?a=101" target="main"><i class="fa fa-plus"></i>' . $_lang['new_plugin'] . '</a></li>';

+                            $output .= '<li><a id="a_101" href="index.php?a=101" target="main"><i class="fa fa-plus"></i>'.$_lang['new_plugin'].'</a></li>';

                         }

 

                         break;

@@ -145,7 +145,7 @@ 
                             continue;

                         }

 

-                        $items .= '<li class="item ' . ($row['disabled'] ? 'disabled' : '') . ($row['locked'] ? ' locked' : '') . '"><a id="a_' . $a . '__id_' . $row['id'] . '" href="index.php?a=' . $a . '&id=' . $row['id'] . '" target="main" data-parent-id="a_76__elements_' . $elements . '">' . $row['name'] . ' <small>(' . $row['id'] . ')</small></a></li>' . "\n";

+                        $items .= '<li class="item '.($row['disabled'] ? 'disabled' : '').($row['locked'] ? ' locked' : '').'"><a id="a_'.$a.'__id_'.$row['id'].'" href="index.php?a='.$a.'&id='.$row['id'].'" target="main" data-parent-id="a_76__elements_'.$elements.'">'.$row['name'].' <small>('.$row['id'].')</small></a></li>'."\n";

                     }

                 }

 

@@ -166,18 +166,18 @@ 
             $output = '';

             $items = '';

             $filter = !empty($_REQUEST['filter']) && is_scalar($_REQUEST['filter']) ? addcslashes(trim($_REQUEST['filter']), '\%*_') : '';

-            $sqlLike = $filter ? 'WHERE t1.username LIKE "' . $modx->db->escape($filter) . '%"' : '';

-            $sqlLimit = $sqlLike ? '' : 'LIMIT ' . $limit;

+            $sqlLike = $filter ? 'WHERE t1.username LIKE "'.$modx->db->escape($filter).'%"' : '';

+            $sqlLimit = $sqlLike ? '' : 'LIMIT '.$limit;

 

             $sql = $modx->db->query('SELECT t1.*, t1.username AS name, t2.blocked

-				FROM ' . $modx->getFullTableName('manager_users') . ' AS t1

-				LEFT JOIN ' . $modx->getFullTableName('user_attributes') . ' AS t2 ON t1.id=t2.internalKey

-				' . $sqlLike . '

+				FROM ' . $modx->getFullTableName('manager_users').' AS t1

+				LEFT JOIN ' . $modx->getFullTableName('user_attributes').' AS t2 ON t1.id=t2.internalKey

+				' . $sqlLike.'

 				ORDER BY t1.username ASC

 				' . $sqlLimit);

 

             if ($modx->hasPermission('new_user')) {

-                $output .= '<li><a id="a_11" href="index.php?a=11" target="main"><i class="fa fa-plus"></i>' . $_lang['new_user'] . '</a></li>';

+                $output .= '<li><a id="a_11" href="index.php?a=11" target="main"><i class="fa fa-plus"></i>'.$_lang['new_user'].'</a></li>';

             }

 

             if ($count = $modx->db->getRecordCount($sql)) {

@@ -185,7 +185,7 @@ 
                     $output .= '<li class="item-input"><input type="text" name="filter" class="dropdown-item form-control form-control-sm" autocomplete="off" /></li>';

                 }

                 while ($row = $modx->db->getRow($sql)) {

-                    $items .= '<li class="item ' . ($row['blocked'] ? 'disabled' : '') . '"><a id="a_' . $a . '__id_' . $row['id'] . '" href="index.php?a=' . $a . '&id=' . $row['id'] . '" target="main">' . $row['name'] . ' <small>(' . $row['id'] . ')</small></a></li>';

+                    $items .= '<li class="item '.($row['blocked'] ? 'disabled' : '').'"><a id="a_'.$a.'__id_'.$row['id'].'" href="index.php?a='.$a.'&id='.$row['id'].'" target="main">'.$row['name'].' <small>('.$row['id'].')</small></a></li>';

                 }

             }

 

@@ -205,18 +205,18 @@ 
             $output = '';

             $items = '';

             $filter = !empty($_REQUEST['filter']) && is_scalar($_REQUEST['filter']) ? addcslashes(trim($_REQUEST['filter']), '\%*_') : '';

-            $sqlLike = $filter ? 'WHERE t1.username LIKE "' . $modx->db->escape($filter) . '%"' : '';

-            $sqlLimit = $sqlLike ? '' : 'LIMIT ' . $limit;

+            $sqlLike = $filter ? 'WHERE t1.username LIKE "'.$modx->db->escape($filter).'%"' : '';

+            $sqlLimit = $sqlLike ? '' : 'LIMIT '.$limit;

 

             $sql = $modx->db->query('SELECT t1.*, t1.username AS name, t2.blocked

-				FROM ' . $modx->getFullTableName('web_users') . ' AS t1

-				LEFT JOIN ' . $modx->getFullTableName('web_user_attributes') . ' AS t2 ON t1.id=t2.internalKey

-				' . $sqlLike . '

+				FROM ' . $modx->getFullTableName('web_users').' AS t1

+				LEFT JOIN ' . $modx->getFullTableName('web_user_attributes').' AS t2 ON t1.id=t2.internalKey

+				' . $sqlLike.'

 				ORDER BY t1.username ASC

 				' . $sqlLimit);

 

             if ($modx->hasPermission('new_web_user')) {

-                $output .= '<li><a id="a_87" href="index.php?a=87" target="main"><i class="fa fa-plus"></i>' . $_lang['new_web_user'] . '</a></li>';

+                $output .= '<li><a id="a_87" href="index.php?a=87" target="main"><i class="fa fa-plus"></i>'.$_lang['new_web_user'].'</a></li>';

             }

 

             if ($count = $modx->db->getRecordCount($sql)) {

@@ -224,7 +224,7 @@ 
                     $output .= '<li class="item-input"><input type="text" name="filter" class="dropdown-item form-control form-control-sm" autocomplete="off" /></li>';

                 }

                 while ($row = $modx->db->getRow($sql)) {

-                    $items .= '<li class="item ' . ($row['blocked'] ? 'disabled' : '') . '"><a id="a_' . $a . '__id_' . $row['id'] . '" href="index.php?a=' . $a . '&id=' . $row['id'] . '" target="main">' . $row['name'] . ' <small>(' . $row['id'] . ')</small></a></li>';

+                    $items .= '<li class="item '.($row['blocked'] ? 'disabled' : '').'"><a id="a_'.$a.'__id_'.$row['id'].'" href="index.php?a='.$a.'&id='.$row['id'].'" target="main">'.$row['name'].' <small>('.$row['id'].')</small></a></li>';

                 }

             }

 

@@ -250,35 +250,35 @@ 
                     case 'SnippetNoCache': {

 

                         $sql = $modx->db->query('SELECT *

-						FROM ' . $modx->getFullTableName('site_snippets') . '

-						WHERE name="' . $name . '"

+						FROM ' . $modx->getFullTableName('site_snippets').'

+						WHERE name="' . $name.'"

 						LIMIT 1');

 

                         if ($modx->db->getRecordCount($sql)) {

                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-code"></i> ' . $row['name']

+                                    'innerHTML' => '<i class="fa fa-code"></i> '.$row['name']

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> ' . $_lang['edit'],

-                                    'url' => "index.php?a=22&id=" . $row['id']

+                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> '.$_lang['edit'],

+                                    'url' => "index.php?a=22&id=".$row['id']

                                 )

                             );

                             if (!empty($row['description'])) {

                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

-                                    'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

+                                    'innerHTML' => '<i class="fa fa-info"></i> '.$row['description']

                                 );

                             }

                         } else {

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-code"></i> ' . $name

+                                    'innerHTML' => '<i class="fa fa-code"></i> '.$name

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-plus"></i> ' . $_lang['new_snippet'],

-                                    'url' => "index.php?a=23&itemname=" . $name

+                                    'innerHTML' => '<i class="fa fa-plus"></i> '.$_lang['new_snippet'],

+                                    'url' => "index.php?a=23&itemname=".$name

                                 )

                             );

                         }

@@ -288,35 +288,35 @@ 
                     case 'Chunk': {

 

                         $sql = $modx->db->query('SELECT *

-						FROM ' . $modx->getFullTableName('site_htmlsnippets') . '

-						WHERE name="' . $name . '"

+						FROM ' . $modx->getFullTableName('site_htmlsnippets').'

+						WHERE name="' . $name.'"

 						LIMIT 1');

 

                         if ($modx->db->getRecordCount($sql)) {

                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-th-large"></i> ' . $row['name']

+                                    'innerHTML' => '<i class="fa fa-th-large"></i> '.$row['name']

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> ' . $_lang['edit'],

-                                    'url' => "index.php?a=78&id=" . $row['id']

+                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> '.$_lang['edit'],

+                                    'url' => "index.php?a=78&id=".$row['id']

                                 )

                             );

                             if (!empty($row['description'])) {

                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

-                                    'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

+                                    'innerHTML' => '<i class="fa fa-info"></i> '.$row['description']

                                 );

                             }

                         } else {

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-th-large"></i> ' . $name

+                                    'innerHTML' => '<i class="fa fa-th-large"></i> '.$name

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-plus"></i> ' . $_lang['new_htmlsnippet'],

-                                    'url' => "index.php?a=77&itemname=" . $name

+                                    'innerHTML' => '<i class="fa fa-plus"></i> '.$_lang['new_htmlsnippet'],

+                                    'url' => "index.php?a=77&itemname=".$name

                                 )

                             );

                         }

@@ -325,8 +325,8 @@ 
                     }

                     case 'AttributeValue': {

                         $sql = $modx->db->query('SELECT *

-						FROM ' . $modx->getFullTableName('site_htmlsnippets') . '

-						WHERE name="' . $name . '"

+						FROM ' . $modx->getFullTableName('site_htmlsnippets').'

+						WHERE name="' . $name.'"

 						LIMIT 1');

 

                         if ($modx->db->getRecordCount($sql)) {

@@ -336,51 +336,51 @@ 
                                     'innerText' => $row['name']

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> ' . $_lang['edit'],

-                                    'url' => "index.php?a=78&id=" . $row['id']

+                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> '.$_lang['edit'],

+                                    'url' => "index.php?a=78&id=".$row['id']

                                 )

                             );

                             if (!empty($row['description'])) {

                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

-                                    'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

+                                    'innerHTML' => '<i class="fa fa-info"></i> '.$row['description']

                                 );

                             }

                         } else {

                             $sql = $modx->db->query('SELECT *

-							FROM ' . $modx->getFullTableName('site_snippets') . '

-							WHERE name="' . $name . '"

+							FROM ' . $modx->getFullTableName('site_snippets').'

+							WHERE name="' . $name.'"

 							LIMIT 1');

 

                             if ($modx->db->getRecordCount($sql)) {

                                 $row = $modx->db->getRow($sql);

                                 $contextmenu = array(

                                     'header' => array(

-                                        'innerHTML' => '<i class="fa fa-code"></i> ' . $row['name']

+                                        'innerHTML' => '<i class="fa fa-code"></i> '.$row['name']

                                     ),

                                     'item' => array(

-                                        'innerHTML' => '<i class="fa fa-pencil-square-o"></i> ' . $_lang['edit'],

-                                        'url' => "index.php?a=22&id=" . $row['id']

+                                        'innerHTML' => '<i class="fa fa-pencil-square-o"></i> '.$_lang['edit'],

+                                        'url' => "index.php?a=22&id=".$row['id']

                                     )

                                 );

                                 if (!empty($row['description'])) {

                                     $contextmenu['seperator'] = '';

                                     $contextmenu['description'] = array(

-                                        'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

+                                        'innerHTML' => '<i class="fa fa-info"></i> '.$row['description']

                                     );

                                 }

                             } else {

                                 $contextmenu = array(

                                     'header' => array(

-                                        'innerHTML' => '<i class="fa fa-code"></i> ' . $name

+                                        'innerHTML' => '<i class="fa fa-code"></i> '.$name

                                     ),

                                     'item' => array(

-                                        'innerHTML' => '<i class="fa fa-plus"></i> ' . $_lang['new_htmlsnippet'],

-                                        'url' => "index.php?a=77&itemname=" . $name

+                                        'innerHTML' => '<i class="fa fa-plus"></i> '.$_lang['new_htmlsnippet'],

+                                        'url' => "index.php?a=77&itemname=".$name

                                     ),

                                     'item2' => array(

-                                        'innerHTML' => '<i class="fa fa-plus"></i> ' . $_lang['new_snippet'],

-                                        'url' => "index.php?a=23&itemname=" . $name

+                                        'innerHTML' => '<i class="fa fa-plus"></i> '.$_lang['new_snippet'],

+                                        'url' => "index.php?a=23&itemname=".$name

                                     )

                                 );

                             }

@@ -436,35 +436,35 @@ 
                         }

 

                         $sql = $modx->db->query('SELECT *

-						FROM ' . $modx->getFullTableName('site_tmplvars') . '

-						WHERE name="' . $name . '"

+						FROM ' . $modx->getFullTableName('site_tmplvars').'

+						WHERE name="' . $name.'"

 						LIMIT 1');

 

                         if ($modx->db->getRecordCount($sql)) {

                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-list-alt"></i> ' . $row['name']

+                                    'innerHTML' => '<i class="fa fa-list-alt"></i> '.$row['name']

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> ' . $_lang['edit'],

-                                    'url' => "index.php?a=301&id=" . $row['id']

+                                    'innerHTML' => '<i class="fa fa-pencil-square-o"></i> '.$_lang['edit'],

+                                    'url' => "index.php?a=301&id=".$row['id']

                                 )

                             );

                             if (!empty($row['description'])) {

                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

-                                    'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

+                                    'innerHTML' => '<i class="fa fa-info"></i> '.$row['description']

                                 );

                             }

                         } else {

                             $contextmenu = array(

                                 'header' => array(

-                                    'innerHTML' => '<i class="fa fa-list-alt"></i> ' . $name

+                                    'innerHTML' => '<i class="fa fa-list-alt"></i> '.$name

                                 ),

                                 'item' => array(

-                                    'innerHTML' => '<i class="fa fa-plus"></i> ' . $_lang['new_tmplvars'],

-                                    'url' => "index.php?a=300&itemname=" . $name

+                                    'innerHTML' => '<i class="fa fa-plus"></i> '.$_lang['new_tmplvars'],

+                                    'url' => "index.php?a=300&itemname=".$name

                                 )

                             );

                         }

@@ -483,15 +483,15 @@ 
             $json = array();

 

             if ($modx->hasPermission('new_document') && $modx->hasPermission('edit_document') && $modx->hasPermission('save_document')) {

-                $id = !empty($_REQUEST['id']) ? (int)$_REQUEST['id'] : '';

-                $parent = isset($_REQUEST['parent']) ? (int)$_REQUEST['parent'] : 0;

+                $id = !empty($_REQUEST['id']) ? (int) $_REQUEST['id'] : '';

+                $parent = isset($_REQUEST['parent']) ? (int) $_REQUEST['parent'] : 0;

                 $menuindex = isset($_REQUEST['menuindex']) && is_scalar($_REQUEST['menuindex']) ? $_REQUEST['menuindex'] : 0;

 

                 // set parent

                 if ($id && $parent >= 0) {

 

                     // find older parent

-                    $parentOld = $modx->db->getValue($modx->db->select('parent', $modx->getFullTableName('site_content'), 'id=' . $id));

+                    $parentOld = $modx->db->getValue($modx->db->select('parent', $modx->getFullTableName('site_content'), 'id='.$id));

 

                     $eventOut = $modx->invokeEvent('onBeforeMoveDocument', array(

                         'id_document' => $id,

@@ -512,7 +512,7 @@ 
                     if (empty($json['errors'])) {

                         // check privileges user for move docs

                         if (!empty($modx->config['tree_show_protected']) && $role != 1) {

-                            $sql = $modx->db->select('*', $modx->getFullTableName('document_groups'), 'document IN(' . $id . ',' . $parent . ',' . $parentOld . ')');

+                            $sql = $modx->db->select('*', $modx->getFullTableName('document_groups'), 'document IN('.$id.','.$parent.','.$parentOld.')');

                             if ($modx->db->getRecordCount($sql)) {

                                 $document_groups = array();

                                 while ($row = $modx->db->getRow($sql)) {

@@ -537,22 +537,22 @@ 
                             // set new parent

                             $modx->db->update(array(

                                 'parent' => $parent

-                            ), $modx->getFullTableName('site_content'), 'id=' . $id);

+                            ), $modx->getFullTableName('site_content'), 'id='.$id);

                             // set parent isfolder = 1

                             $modx->db->update(array(

                                 'isfolder' => 1

-                            ), $modx->getFullTableName('site_content'), 'id=' . $parent);

+                            ), $modx->getFullTableName('site_content'), 'id='.$parent);

 

                             if ($parent != $parentOld) {

                                 // check children docs and set parent isfolder

-                                if ($modx->db->getRecordCount($modx->db->select('id', $modx->getFullTableName('site_content'), 'parent=' . $parentOld))) {

+                                if ($modx->db->getRecordCount($modx->db->select('id', $modx->getFullTableName('site_content'), 'parent='.$parentOld))) {

                                     $modx->db->update(array(

                                         'isfolder' => 1

-                                    ), $modx->getFullTableName('site_content'), 'id=' . $parentOld);

+                                    ), $modx->getFullTableName('site_content'), 'id='.$parentOld);

                                 } else {

                                     $modx->db->update(array(

                                         'isfolder' => 0

-                                    ), $modx->getFullTableName('site_content'), 'id=' . $parentOld);

+                                    ), $modx->getFullTableName('site_content'), 'id='.$parentOld);

                                 }

                             }

 

@@ -560,7 +560,7 @@ 
                             if (!empty($menuindex)) {

                                 $menuindex = explode(',', $menuindex);

                                 foreach ($menuindex as $key => $value) {

-                                    $modx->db->query('UPDATE ' . $modx->getFullTableName('site_content') . ' SET menuindex=' . $key . ' WHERE id=' . $value);

+                                    $modx->db->query('UPDATE '.$modx->getFullTableName('site_content').' SET menuindex='.$key.' WHERE id='.$value);

                                 }

                             } else {

                                 // TODO: max(*) menuindex

@@ -589,19 +589,19 @@ 
         }

 

         case 'getLockedElements': {

-            $type = isset($_REQUEST['type']) ? (int)$_REQUEST['type'] : 0;

-            $id = isset($_REQUEST['id']) ? (int)$_REQUEST['id'] : 0;

+            $type = isset($_REQUEST['type']) ? (int) $_REQUEST['type'] : 0;

+            $id = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : 0;

 

             $output = !!$modx->elementIsLocked($type, $id, true);

 

             if (!$output) {

                 $docgrp = (isset($_SESSION['mgrDocgroups']) && is_array($_SESSION['mgrDocgroups'])) ? implode(',', $_SESSION['mgrDocgroups']) : '';

-                $docgrp_cond = $docgrp ? ' OR dg.document_group IN (' . $docgrp . ')' : '';

+                $docgrp_cond = $docgrp ? ' OR dg.document_group IN ('.$docgrp.')' : '';

                 $sql = '

-                    SELECT MAX(IF(1=' . $role . ' OR sc.privatemgr=0' . $docgrp_cond . ', 0, 1)) AS locked

-                    FROM ' . $modx->getFullTableName('site_content') . ' AS sc 

-                    LEFT JOIN ' . $modx->getFullTableName('document_groups') . ' dg ON dg.document=sc.id

-                    WHERE sc.id=' . $id . ' GROUP BY sc.id';

+                    SELECT MAX(IF(1=' . $role.' OR sc.privatemgr=0'.$docgrp_cond.', 0, 1)) AS locked

+                    FROM ' . $modx->getFullTableName('site_content').' AS sc 

+                    LEFT JOIN ' . $modx->getFullTableName('document_groups').' dg ON dg.document=sc.id

+                    WHERE sc.id=' . $id.' GROUP BY sc.id';

                 $sql = $modx->db->query($sql);

                 if ($modx->db->getRecordCount($sql)) {

                     $row = $modx->db->getRow($sql);

Braces +73 added lines, -73 removed lines

@@ -7,11 +7,11 @@ 
 

 $modx->db->connect();

 

-if (empty($modx->config)) {

+if (empty($modx->config)) {
     $modx->getSettings();

 }

 

-if (!isset($_SESSION['mgrValidated']) || !isset($_SERVER['HTTP_X_REQUESTED_WITH']) || (strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) != 'xmlhttprequest') || ($_SERVER['REQUEST_METHOD'] != 'POST')) {

+if (!isset($_SESSION['mgrValidated']) || !isset($_SERVER['HTTP_X_REQUESTED_WITH']) || (strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) != 'xmlhttprequest') || ($_SERVER['REQUEST_METHOD'] != 'POST')) {
     $modx->sendErrorPage();

 }

 

@@ -20,7 +20,7 @@ 
 

 $_lang = array();

 include_once MODX_MANAGER_PATH . '/includes/lang/english.inc.php';

-if ($modx->config['manager_language'] != 'english') {

+if ($modx->config['manager_language'] != 'english') {
     include_once MODX_MANAGER_PATH . '/includes/lang/' . $modx->config['manager_language'] . '.inc.php';

 }

 include_once MODX_MANAGER_PATH . '/media/style/' . $modx->config['manager_theme'] . '/style.php';

@@ -33,12 +33,12 @@ 
 // set limit sql query

 $limit = !empty($modx->config['number_of_results']) ? (int) $modx->config['number_of_results'] : 100;

 

-if (isset($action)) {

-    switch ($action) {

+if (isset($action)) {
+    switch ($action) {
 

         case '1': {

 

-            switch ($frame) {

+            switch ($frame) {
                 case 'nodes':

                     include_once MODX_MANAGER_PATH . '/frames/nodes.php';

 

@@ -52,7 +52,7 @@ 
 

             $elements = isset($_REQUEST['elements']) && is_scalar($_REQUEST['elements']) ? htmlentities($_REQUEST['elements']) : '';

 

-            if ($elements) {

+            if ($elements) {
                 $output = '';

                 $items = '';

                 $sql = '';

@@ -61,7 +61,7 @@ 
                 $sqlLike = $filter ? 'WHERE t1.name LIKE "' . $modx->db->escape($filter) . '%"' : '';

                 $sqlLimit = $sqlLike ? '' : 'LIMIT ' . $limit;

 

-                switch ($elements) {

+                switch ($elements) {
                     case 'element_templates':

                         $a = 16;

                         $sqlLike = $filter ? 'WHERE t1.templatename LIKE "' . $modx->db->escape($filter) . '%"' : '';

@@ -71,7 +71,7 @@ 
                         ORDER BY t1.templatename ASC

                         ' . $sqlLimit);

 

-                        if ($modx->hasPermission('new_template')) {

+                        if ($modx->hasPermission('new_template')) {
                             $output .= '<li><a id="a_19" href="index.php?a=19" target="main"><i class="fa fa-plus"></i>' . $_lang['new_template'] . '</a></li>';

                         }

 

@@ -87,7 +87,7 @@ 
                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

-                        if ($modx->hasPermission('edit_template') && $modx->hasPermission('edit_snippet') && $modx->hasPermission('edit_chunk') && $modx->hasPermission('edit_plugin')) {

+                        if ($modx->hasPermission('edit_template') && $modx->hasPermission('edit_snippet') && $modx->hasPermission('edit_chunk') && $modx->hasPermission('edit_plugin')) {
                             $output .= '<li><a id="a_300" href="index.php?a=300" target="main"><i class="fa fa-plus"></i>' . $_lang['new_tmplvars'] . '</a></li>';

                         }

 

@@ -101,7 +101,7 @@ 
                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

-                        if ($modx->hasPermission('new_chunk')) {

+                        if ($modx->hasPermission('new_chunk')) {
                             $output .= '<li><a id="a_77" href="index.php?a=77" target="main"><i class="fa fa-plus"></i>' . $_lang['new_htmlsnippet'] . '</a></li>';

                         }

 

@@ -115,7 +115,7 @@ 
                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

-                        if ($modx->hasPermission('new_snippet')) {

+                        if ($modx->hasPermission('new_snippet')) {
                             $output .= '<li><a id="a_23" href="index.php?a=23" target="main"><i class="fa fa-plus"></i>' . $_lang['new_snippet'] . '</a></li>';

                         }

 

@@ -129,19 +129,19 @@ 
                         ORDER BY t1.name ASC

                         ' . $sqlLimit);

 

-                        if ($modx->hasPermission('new_plugin')) {

+                        if ($modx->hasPermission('new_plugin')) {
                             $output .= '<li><a id="a_101" href="index.php?a=101" target="main"><i class="fa fa-plus"></i>' . $_lang['new_plugin'] . '</a></li>';

                         }

 

                         break;

                 }

 

-                if ($count = $modx->db->getRecordCount($sql)) {

-                    if ($count == $limit) {

+                if ($count = $modx->db->getRecordCount($sql)) {
+                    if ($count == $limit) {
                         $output .= '<li class="item-input"><input type="text" name="filter" class="dropdown-item form-control form-control-sm" autocomplete="off" /></li>';

                     }

-                    while ($row = $modx->db->getRow($sql)) {

-                        if (($row['disabled'] || $row['locked']) && $role != 1) {

+                    while ($row = $modx->db->getRow($sql)) {
+                        if (($row['disabled'] || $row['locked']) && $role != 1) {
                             continue;

                         }

 

@@ -149,9 +149,9 @@ 
                     }

                 }

 

-                if (isset($_REQUEST['filter'])) {

+                if (isset($_REQUEST['filter'])) {
                     $output = $items;

-                } else {

+                } else {
                     $output .= $items;

                 }

 

@@ -176,22 +176,22 @@ 
 				ORDER BY t1.username ASC

 				' . $sqlLimit);

 

-            if ($modx->hasPermission('new_user')) {

+            if ($modx->hasPermission('new_user')) {
                 $output .= '<li><a id="a_11" href="index.php?a=11" target="main"><i class="fa fa-plus"></i>' . $_lang['new_user'] . '</a></li>';

             }

 

-            if ($count = $modx->db->getRecordCount($sql)) {

-                if ($count == $limit) {

+            if ($count = $modx->db->getRecordCount($sql)) {
+                if ($count == $limit) {
                     $output .= '<li class="item-input"><input type="text" name="filter" class="dropdown-item form-control form-control-sm" autocomplete="off" /></li>';

                 }

-                while ($row = $modx->db->getRow($sql)) {

+                while ($row = $modx->db->getRow($sql)) {
                     $items .= '<li class="item ' . ($row['blocked'] ? 'disabled' : '') . '"><a id="a_' . $a . '__id_' . $row['id'] . '" href="index.php?a=' . $a . '&id=' . $row['id'] . '" target="main">' . $row['name'] . ' <small>(' . $row['id'] . ')</small></a></li>';

                 }

             }

 

-            if (isset($_REQUEST['filter'])) {

+            if (isset($_REQUEST['filter'])) {
                 $output = $items;

-            } else {

+            } else {
                 $output .= $items;

             }

 

@@ -215,22 +215,22 @@ 
 				ORDER BY t1.username ASC

 				' . $sqlLimit);

 

-            if ($modx->hasPermission('new_web_user')) {

+            if ($modx->hasPermission('new_web_user')) {
                 $output .= '<li><a id="a_87" href="index.php?a=87" target="main"><i class="fa fa-plus"></i>' . $_lang['new_web_user'] . '</a></li>';

             }

 

-            if ($count = $modx->db->getRecordCount($sql)) {

-                if ($count == $limit) {

+            if ($count = $modx->db->getRecordCount($sql)) {
+                if ($count == $limit) {
                     $output .= '<li class="item-input"><input type="text" name="filter" class="dropdown-item form-control form-control-sm" autocomplete="off" /></li>';

                 }

-                while ($row = $modx->db->getRow($sql)) {

+                while ($row = $modx->db->getRow($sql)) {
                     $items .= '<li class="item ' . ($row['blocked'] ? 'disabled' : '') . '"><a id="a_' . $a . '__id_' . $row['id'] . '" href="index.php?a=' . $a . '&id=' . $row['id'] . '" target="main">' . $row['name'] . ' <small>(' . $row['id'] . ')</small></a></li>';

                 }

             }

 

-            if (isset($_REQUEST['filter'])) {

+            if (isset($_REQUEST['filter'])) {
                 $output = $items;

-            } else {

+            } else {
                 $output .= $items;

             }

 

@@ -244,8 +244,8 @@ 
             $type = isset($_REQUEST['type']) && is_scalar($_REQUEST['type']) ? $modx->db->escape($_REQUEST['type']) : false;

             $contextmenu = '';

 

-            if ($role && $name && $type) {

-                switch ($type) {

+            if ($role && $name && $type) {
+                switch ($type) {
                     case 'Snippet':

                     case 'SnippetNoCache': {

 

@@ -254,7 +254,7 @@ 
 						WHERE name="' . $name . '"

 						LIMIT 1');

 

-                        if ($modx->db->getRecordCount($sql)) {

+                        if ($modx->db->getRecordCount($sql)) {
                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

@@ -265,13 +265,13 @@ 
                                     'url' => "index.php?a=22&id=" . $row['id']

                                 )

                             );

-                            if (!empty($row['description'])) {

+                            if (!empty($row['description'])) {
                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

                                     'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

                                 );

                             }

-                        } else {

+                        } else {
                             $contextmenu = array(

                                 'header' => array(

                                     'innerHTML' => '<i class="fa fa-code"></i> ' . $name

@@ -292,7 +292,7 @@ 
 						WHERE name="' . $name . '"

 						LIMIT 1');

 

-                        if ($modx->db->getRecordCount($sql)) {

+                        if ($modx->db->getRecordCount($sql)) {
                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

@@ -303,13 +303,13 @@ 
                                     'url' => "index.php?a=78&id=" . $row['id']

                                 )

                             );

-                            if (!empty($row['description'])) {

+                            if (!empty($row['description'])) {
                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

                                     'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

                                 );

                             }

-                        } else {

+                        } else {
                             $contextmenu = array(

                                 'header' => array(

                                     'innerHTML' => '<i class="fa fa-th-large"></i> ' . $name

@@ -329,7 +329,7 @@ 
 						WHERE name="' . $name . '"

 						LIMIT 1');

 

-                        if ($modx->db->getRecordCount($sql)) {

+                        if ($modx->db->getRecordCount($sql)) {
                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

@@ -340,19 +340,19 @@ 
                                     'url' => "index.php?a=78&id=" . $row['id']

                                 )

                             );

-                            if (!empty($row['description'])) {

+                            if (!empty($row['description'])) {
                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

                                     'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

                                 );

                             }

-                        } else {

+                        } else {
                             $sql = $modx->db->query('SELECT *

 							FROM ' . $modx->getFullTableName('site_snippets') . '

 							WHERE name="' . $name . '"

 							LIMIT 1');

 

-                            if ($modx->db->getRecordCount($sql)) {

+                            if ($modx->db->getRecordCount($sql)) {
                                 $row = $modx->db->getRow($sql);

                                 $contextmenu = array(

                                     'header' => array(

@@ -363,13 +363,13 @@ 
                                         'url' => "index.php?a=22&id=" . $row['id']

                                     )

                                 );

-                                if (!empty($row['description'])) {

+                                if (!empty($row['description'])) {
                                     $contextmenu['seperator'] = '';

                                     $contextmenu['description'] = array(

                                         'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

                                     );

                                 }

-                            } else {

+                            } else {
                                 $contextmenu = array(

                                     'header' => array(

                                         'innerHTML' => '<i class="fa fa-code"></i> ' . $name

@@ -431,7 +431,7 @@ 
                             'alias_visible'

                         );

 

-                        if (in_array($name, $default_field)) {

+                        if (in_array($name, $default_field)) {
                             return;

                         }

 

@@ -440,7 +440,7 @@ 
 						WHERE name="' . $name . '"

 						LIMIT 1');

 

-                        if ($modx->db->getRecordCount($sql)) {

+                        if ($modx->db->getRecordCount($sql)) {
                             $row = $modx->db->getRow($sql);

                             $contextmenu = array(

                                 'header' => array(

@@ -451,13 +451,13 @@ 
                                     'url' => "index.php?a=301&id=" . $row['id']

                                 )

                             );

-                            if (!empty($row['description'])) {

+                            if (!empty($row['description'])) {
                                 $contextmenu['seperator'] = '';

                                 $contextmenu['description'] = array(

                                     'innerHTML' => '<i class="fa fa-info"></i> ' . $row['description']

                                 );

                             }

-                        } else {

+                        } else {
                             $contextmenu = array(

                                 'header' => array(

                                     'innerHTML' => '<i class="fa fa-list-alt"></i> ' . $name

@@ -482,13 +482,13 @@ 
         case 'movedocument': {

             $json = array();

 

-            if ($modx->hasPermission('new_document') && $modx->hasPermission('edit_document') && $modx->hasPermission('save_document')) {

+            if ($modx->hasPermission('new_document') && $modx->hasPermission('edit_document') && $modx->hasPermission('save_document')) {
                 $id = !empty($_REQUEST['id']) ? (int)$_REQUEST['id'] : '';

                 $parent = isset($_REQUEST['parent']) ? (int)$_REQUEST['parent'] : 0;

                 $menuindex = isset($_REQUEST['menuindex']) && is_scalar($_REQUEST['menuindex']) ? $_REQUEST['menuindex'] : 0;

 

                 // set parent

-                if ($id && $parent >= 0) {

+                if ($id && $parent >= 0) {
 

                     // find older parent

                     $parentOld = $modx->db->getValue($modx->db->select('parent', $modx->getFullTableName('site_content'), 'id=' . $id));

@@ -499,31 +499,31 @@ 
                         'new_parent'  => $parent,

                     ));

 

-                    if (is_array($eventOut) && count($eventOut) > 0) {

+                    if (is_array($eventOut) && count($eventOut) > 0) {
                         $eventParent = array_pop($eventOut);

 

-                        if ($eventParent == $parentOld) {

+                        if ($eventParent == $parentOld) {
                             $json['errors'] = $_lang['error_movedocument2'];

-                        } else {

+                        } else {
                             $parent = $eventParent;

                         }

                     }

 

-                    if (empty($json['errors'])) {

+                    if (empty($json['errors'])) {
                         // check privileges user for move docs

-                        if (!empty($modx->config['tree_show_protected']) && $role != 1) {

+                        if (!empty($modx->config['tree_show_protected']) && $role != 1) {
                             $sql = $modx->db->select('*', $modx->getFullTableName('document_groups'), 'document IN(' . $id . ',' . $parent . ',' . $parentOld . ')');

-                            if ($modx->db->getRecordCount($sql)) {

+                            if ($modx->db->getRecordCount($sql)) {
                                 $document_groups = array();

-                                while ($row = $modx->db->getRow($sql)) {

+                                while ($row = $modx->db->getRow($sql)) {
                                     $document_groups[$row['document']]['groups'][] = $row['document_group'];

                                 }

-                                foreach ($document_groups as $key => $value) {

-                                    if (($key == $parent || $key == $parentOld || $key == $id) && !in_array($role, $value['groups'])) {

+                                foreach ($document_groups as $key => $value) {
+                                    if (($key == $parent || $key == $parentOld || $key == $id) && !in_array($role, $value['groups'])) {
                                         $json['errors'] = $_lang["error_no_privileges"];

                                     }

                                 }

-                                if ($json['errors']) {

+                                if ($json['errors']) {
                                     header('content-type: application/json');

                                     echo json_encode($json, JSON_FORCE_OBJECT | JSON_UNESCAPED_UNICODE);

                                     break;

@@ -531,9 +531,9 @@ 
                             }

                         }

 

-                        if ($parent == 0 && $parent != $parentOld && !$modx->config['udperms_allowroot'] && $role != 1) {

+                        if ($parent == 0 && $parent != $parentOld && !$modx->config['udperms_allowroot'] && $role != 1) {
                             $json['errors'] = $_lang["error_no_privileges"];

-                        } else {

+                        } else {
                             // set new parent

                             $modx->db->update(array(

                                 'parent' => $parent

@@ -543,13 +543,13 @@ 
                                 'isfolder' => 1

                             ), $modx->getFullTableName('site_content'), 'id=' . $parent);

 

-                            if ($parent != $parentOld) {

+                            if ($parent != $parentOld) {
                                 // check children docs and set parent isfolder

-                                if ($modx->db->getRecordCount($modx->db->select('id', $modx->getFullTableName('site_content'), 'parent=' . $parentOld))) {

+                                if ($modx->db->getRecordCount($modx->db->select('id', $modx->getFullTableName('site_content'), 'parent=' . $parentOld))) {
                                     $modx->db->update(array(

                                         'isfolder' => 1

                                     ), $modx->getFullTableName('site_content'), 'id=' . $parentOld);

-                                } else {

+                                } else {
                                     $modx->db->update(array(

                                         'isfolder' => 0

                                     ), $modx->getFullTableName('site_content'), 'id=' . $parentOld);

@@ -557,16 +557,16 @@ 
                             }

 

                             // set menuindex

-                            if (!empty($menuindex)) {

+                            if (!empty($menuindex)) {
                                 $menuindex = explode(',', $menuindex);

-                                foreach ($menuindex as $key => $value) {

+                                foreach ($menuindex as $key => $value) {
                                     $modx->db->query('UPDATE ' . $modx->getFullTableName('site_content') . ' SET menuindex=' . $key . ' WHERE id=' . $value);

                                 }

-                            } else {

+                            } else {
                                 // TODO: max(*) menuindex

                             }

 

-                            if (!$json['errors']) {

+                            if (!$json['errors']) {
                                 $json['success'] = $_lang["actioncomplete"];

 

                                 $modx->invokeEvent('onAfterMoveDocument', array(

@@ -578,7 +578,7 @@ 
                         }

                     }

                 }

-            } else {

+            } else {
                 $json['errors'] = $_lang["error_no_privileges"];

             }

 

@@ -594,7 +594,7 @@ 
 

             $output = !!$modx->elementIsLocked($type, $id, true);

 

-            if (!$output) {

+            if (!$output) {
                 $docgrp = (isset($_SESSION['mgrDocgroups']) && is_array($_SESSION['mgrDocgroups'])) ? implode(',', $_SESSION['mgrDocgroups']) : '';

                 $docgrp_cond = $docgrp ? ' OR dg.document_group IN (' . $docgrp . ')' : '';

                 $sql = '

@@ -603,7 +603,7 @@ 
                     LEFT JOIN ' . $modx->getFullTableName('document_groups') . ' dg ON dg.document=sc.id

                     WHERE sc.id=' . $id . ' GROUP BY sc.id';

                 $sql = $modx->db->query($sql);

-                if ($modx->db->getRecordCount($sql)) {

+                if ($modx->db->getRecordCount($sql)) {
                     $row = $modx->db->getRow($sql);

                     $output = !!$row['locked'];

                 }

manager/media/style/default/welcome.php

Braces +2 added lines, -2 removed lines

@@ -3,9 +3,9 @@
 

 $modx->addSnippet('hasPermission', 'return $modx->hasPermission($key);');

 

-if ($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {

+if ($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
     $hasAnyPermission = 1;

-} else {

+} else {
     $hasAnyPermission = 0;

 }

 $modx->addSnippet('hasAnyPermission', 'global $hasAnyPermission; return $hasAnyPermission;');