evolution-cms / evolution

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php

Doc Comments +1 added lines

@@ -1630,6 +1630,7 @@
      * {@inheritdoc}
      *
      * Modifies column declaration order as it differs in Microsoft SQL Server.
+     * @param string $name
      */
     public function getColumnDeclarationSQL($name, array $field)
     {

Spacing +112 added lines, -112 removed lines

@@ -105,7 +105,7 @@ 
             $factorClause = '-1 * ';
         }
 
-        return 'DATEADD(' . $unit . ', ' . $factorClause . $interval . ', ' . $date . ')';
+        return 'DATEADD('.$unit.', '.$factorClause.$interval.', '.$date.')';
     }
 
     /**
@@ -113,7 +113,7 @@ 
      */
     public function getDateDiffExpression($date1, $date2)
     {
-        return 'DATEDIFF(day, ' . $date2 . ',' . $date1 . ')';
+        return 'DATEDIFF(day, '.$date2.','.$date1.')';
     }
 
     /**
@@ -182,7 +182,7 @@ 
      */
     public function getCreateDatabaseSQL($name)
     {
-        return 'CREATE DATABASE ' . $name;
+        return 'CREATE DATABASE '.$name;
     }
 
     /**
@@ -190,7 +190,7 @@ 
      */
     public function getDropDatabaseSQL($name)
     {
-        return 'DROP DATABASE ' . $name;
+        return 'DROP DATABASE '.$name;
     }
 
     /**
@@ -206,7 +206,7 @@ 
      */
     public function getCreateSchemaSQL($schemaName)
     {
-        return 'CREATE SCHEMA ' . $schemaName;
+        return 'CREATE SCHEMA '.$schemaName;
     }
 
     /**
@@ -214,18 +214,18 @@ 
      */
     public function getDropForeignKeySQL($foreignKey, $table)
     {
-        if (! $foreignKey instanceof ForeignKeyConstraint) {
+        if (!$foreignKey instanceof ForeignKeyConstraint) {
             $foreignKey = new Identifier($foreignKey);
         }
 
-        if (! $table instanceof Table) {
+        if (!$table instanceof Table) {
             $table = new Identifier($table);
         }
 
         $foreignKey = $foreignKey->getQuotedName($this);
         $table = $table->getQuotedName($this);
 
-        return 'ALTER TABLE ' . $table . ' DROP CONSTRAINT ' . $foreignKey;
+        return 'ALTER TABLE '.$table.' DROP CONSTRAINT '.$foreignKey;
     }
 
     /**
@@ -240,7 +240,7 @@ 
         }
 
         if (!isset($table)) {
-            return 'DROP INDEX ' . $index;
+            return 'DROP INDEX '.$index;
         }
 
         if ($table instanceof Table) {
@@ -248,9 +248,9 @@ 
         }
 
         return "IF EXISTS (SELECT * FROM sysobjects WHERE name = '$index')
-                    ALTER TABLE " . $table . " DROP CONSTRAINT " . $index . "
+                    ALTER TABLE ".$table." DROP CONSTRAINT ".$index."
                 ELSE
-                    DROP INDEX " . $index . " ON " . $table;
+                    DROP INDEX " . $index." ON ".$table;
     }
 
     /**
@@ -270,11 +270,11 @@ 
 
             // Build default constraints SQL statements.
             if (isset($column['default'])) {
-                $defaultConstraintsSql[] = 'ALTER TABLE ' . $tableName .
-                    ' ADD' . $this->getDefaultConstraintDeclarationSQL($tableName, $column);
+                $defaultConstraintsSql[] = 'ALTER TABLE '.$tableName.
+                    ' ADD'.$this->getDefaultConstraintDeclarationSQL($tableName, $column);
             }
 
-            if ( ! empty($column['comment']) || is_numeric($column['comment'])) {
+            if (!empty($column['comment']) || is_numeric($column['comment'])) {
                 $commentsSql[] = $this->getCreateColumnCommentSQL($tableName, $column['name'], $column['comment']);
             }
         }
@@ -283,7 +283,7 @@ 
 
         if (isset($options['uniqueConstraints']) && !empty($options['uniqueConstraints'])) {
             foreach ($options['uniqueConstraints'] as $name => $definition) {
-                $columnListSql .= ', ' . $this->getUniqueConstraintDeclarationSQL($name, $definition);
+                $columnListSql .= ', '.$this->getUniqueConstraintDeclarationSQL($name, $definition);
             }
         }
 
@@ -292,14 +292,14 @@ 
             if (isset($options['primary_index']) && $options['primary_index']->hasFlag('nonclustered')) {
                 $flags = ' NONCLUSTERED';
             }
-            $columnListSql .= ', PRIMARY KEY' . $flags . ' (' . implode(', ', array_unique(array_values($options['primary']))) . ')';
+            $columnListSql .= ', PRIMARY KEY'.$flags.' ('.implode(', ', array_unique(array_values($options['primary']))).')';
         }
 
-        $query = 'CREATE TABLE ' . $tableName . ' (' . $columnListSql;
+        $query = 'CREATE TABLE '.$tableName.' ('.$columnListSql;
 
         $check = $this->getCheckDeclarationSQL($columns);
         if (!empty($check)) {
-            $query .= ', ' . $check;
+            $query .= ', '.$check;
         }
         $query .= ')';
 
@@ -330,7 +330,7 @@ 
             $flags = ' NONCLUSTERED';
         }
 
-        return 'ALTER TABLE ' . $table . ' ADD PRIMARY KEY' . $flags . ' (' . $this->getIndexFieldDeclarationListSQL($index->getQuotedColumns($this)) . ')';
+        return 'ALTER TABLE '.$table.' ADD PRIMARY KEY'.$flags.' ('.$this->getIndexFieldDeclarationListSQL($index->getQuotedColumns($this)).')';
     }
 
     /**
@@ -385,17 +385,17 @@ 
      */
     public function getDefaultConstraintDeclarationSQL($table, array $column)
     {
-        if ( ! isset($column['default'])) {
+        if (!isset($column['default'])) {
             throw new \InvalidArgumentException("Incomplete column definition. 'default' required.");
         }
 
         $columnName = new Identifier($column['name']);
 
         return
-            ' CONSTRAINT ' .
-            $this->generateDefaultConstraintName($table, $column['name']) .
-            $this->getDefaultValueDeclarationSQL($column) .
-            ' FOR ' . $columnName->getQuotedName($this);
+            ' CONSTRAINT '.
+            $this->generateDefaultConstraintName($table, $column['name']).
+            $this->getDefaultValueDeclarationSQL($column).
+            ' FOR '.$columnName->getQuotedName($this);
     }
 
     /**
@@ -456,10 +456,10 @@ 
         $fields = [];
 
         foreach ($index->getQuotedColumns($this) as $field) {
-            $fields[] = $field . ' IS NOT NULL';
+            $fields[] = $field.' IS NOT NULL';
         }
 
-        return $sql . ' WHERE ' . implode(' AND ', $fields);
+        return $sql.' WHERE '.implode(' AND ', $fields);
     }
 
     /**
@@ -479,7 +479,7 @@ 
             }
 
             $columnDef = $column->toArray();
-            $queryParts[] = 'ADD ' . $this->getColumnDeclarationSQL($column->getQuotedName($this), $columnDef);
+            $queryParts[] = 'ADD '.$this->getColumnDeclarationSQL($column->getQuotedName($this), $columnDef);
 
             if (isset($columnDef['default'])) {
                 $queryParts[] = $this->getAlterTableAddDefaultConstraintClause($diff->name, $column);
@@ -487,7 +487,7 @@ 
 
             $comment = $this->getColumnComment($column);
 
-            if ( ! empty($comment) || is_numeric($comment)) {
+            if (!empty($comment) || is_numeric($comment)) {
                 $commentsSql[] = $this->getCreateColumnCommentSQL(
                     $diff->name,
                     $column->getQuotedName($this),
@@ -501,7 +501,7 @@ 
                 continue;
             }
 
-            $queryParts[] = 'DROP COLUMN ' . $column->getQuotedName($this);
+            $queryParts[] = 'DROP COLUMN '.$column->getQuotedName($this);
         }
 
         /* @var $columnDiff \Doctrine\DBAL\Schema\ColumnDiff */
@@ -512,11 +512,11 @@ 
 
             $column     = $columnDiff->column;
             $comment    = $this->getColumnComment($column);
-            $hasComment = ! empty ($comment) || is_numeric($comment);
+            $hasComment = !empty ($comment) || is_numeric($comment);
 
             if ($columnDiff->fromColumn instanceof Column) {
                 $fromComment    = $this->getColumnComment($columnDiff->fromColumn);
-                $hasFromComment = ! empty ($fromComment) || is_numeric($fromComment);
+                $hasFromComment = !empty ($fromComment) || is_numeric($fromComment);
 
                 if ($hasFromComment && $hasComment && $fromComment != $comment) {
                     $commentsSql[] = $this->getAlterColumnCommentSQL(
@@ -524,7 +524,7 @@ 
                         $column->getQuotedName($this),
                         $comment
                     );
-                } elseif ($hasFromComment && ! $hasComment) {
+                } elseif ($hasFromComment && !$hasComment) {
                     $commentsSql[] = $this->getDropColumnCommentSQL($diff->name, $column->getQuotedName($this));
                 } elseif ($hasComment) {
                     $commentsSql[] = $this->getCreateColumnCommentSQL(
@@ -553,7 +553,7 @@ 
 
             $columnDef = $column->toArray();
 
-            $queryParts[] = 'ALTER COLUMN ' .
+            $queryParts[] = 'ALTER COLUMN '.
                     $this->getColumnDeclarationSQL($column->getQuotedName($this), $columnDef);
 
             if (isset($columnDef['default']) && ($requireDropDefaultConstraint || $columnDiff->hasChanged('default'))) {
@@ -568,9 +568,9 @@ 
 
             $oldColumnName = new Identifier($oldColumnName);
 
-            $sql[] = "sp_RENAME '" .
-                $diff->getName($this)->getQuotedName($this) . "." . $oldColumnName->getQuotedName($this) .
-                "', '" . $column->getQuotedName($this) . "', 'COLUMN'";
+            $sql[] = "sp_RENAME '".
+                $diff->getName($this)->getQuotedName($this).".".$oldColumnName->getQuotedName($this).
+                "', '".$column->getQuotedName($this)."', 'COLUMN'";
 
             // Recreate default constraint with new column name if necessary (for future reference).
             if ($column->getDefault() !== null) {
@@ -589,13 +589,13 @@ 
         }
 
         foreach ($queryParts as $query) {
-            $sql[] = 'ALTER TABLE ' . $diff->getName($this)->getQuotedName($this) . ' ' . $query;
+            $sql[] = 'ALTER TABLE '.$diff->getName($this)->getQuotedName($this).' '.$query;
         }
 
         $sql = array_merge($sql, $commentsSql);
 
         if ($diff->newName !== false) {
-            $sql[] = "sp_RENAME '" . $diff->getName($this)->getQuotedName($this) . "', '" . $diff->getNewName()->getName() . "'";
+            $sql[] = "sp_RENAME '".$diff->getName($this)->getQuotedName($this)."', '".$diff->getNewName()->getName()."'";
 
             /**
              * Rename table's default constraints names
@@ -605,13 +605,13 @@ 
              * alterations as the table name is encoded in
              * default constraints' names.
              */
-            $sql[] = "DECLARE @sql NVARCHAR(MAX) = N''; " .
-                "SELECT @sql += N'EXEC sp_rename N''' + dc.name + ''', N''' " .
-                "+ REPLACE(dc.name, '" . $this->generateIdentifierName($diff->name) . "', " .
-                "'" . $this->generateIdentifierName($diff->newName) . "') + ''', ''OBJECT'';' " .
-                "FROM sys.default_constraints dc " .
-                "JOIN sys.tables tbl ON dc.parent_object_id = tbl.object_id " .
-                "WHERE tbl.name = '" . $diff->getNewName()->getName() . "';" .
+            $sql[] = "DECLARE @sql NVARCHAR(MAX) = N''; ".
+                "SELECT @sql += N'EXEC sp_rename N''' + dc.name + ''', N''' ".
+                "+ REPLACE(dc.name, '".$this->generateIdentifierName($diff->name)."', ".
+                "'".$this->generateIdentifierName($diff->newName)."') + ''', ''OBJECT'';' ".
+                "FROM sys.default_constraints dc ".
+                "JOIN sys.tables tbl ON dc.parent_object_id = tbl.object_id ".
+                "WHERE tbl.name = '".$diff->getNewName()->getName()."';".
                 "EXEC sp_executesql @sql";
         }
 
@@ -637,7 +637,7 @@ 
         $columnDef = $column->toArray();
         $columnDef['name'] = $column->getQuotedName($this);
 
-        return 'ADD' . $this->getDefaultConstraintDeclarationSQL($tableName, $columnDef);
+        return 'ADD'.$this->getDefaultConstraintDeclarationSQL($tableName, $columnDef);
     }
 
     /**
@@ -650,7 +650,7 @@ 
      */
     private function getAlterTableDropDefaultConstraintClause($tableName, $columnName)
     {
-        return 'DROP CONSTRAINT ' . $this->generateDefaultConstraintName($tableName, $columnName);
+        return 'DROP CONSTRAINT '.$this->generateDefaultConstraintName($tableName, $columnName);
     }
 
     /**
@@ -669,7 +669,7 @@ 
     {
         // We can only decide whether to drop an existing default constraint
         // if we know the original default value.
-        if ( ! $columnDiff->fromColumn instanceof Column) {
+        if (!$columnDiff->fromColumn instanceof Column) {
             return false;
         }
 
@@ -808,12 +808,12 @@ 
         $level1Name = null,
         $level2Type = null,
         $level2Name = null
-    ) {
-        return "EXEC sp_addextendedproperty " .
-            "N" . $this->quoteStringLiteral($name) . ", N" . $this->quoteStringLiteral($value) . ", " .
-            "N" . $this->quoteStringLiteral($level0Type) . ", " . $level0Name . ', ' .
-            "N" . $this->quoteStringLiteral($level1Type) . ", " . $level1Name . ', ' .
-            "N" . $this->quoteStringLiteral($level2Type) . ", " . $level2Name;
+    ){
+        return "EXEC sp_addextendedproperty ".
+            "N".$this->quoteStringLiteral($name).", N".$this->quoteStringLiteral($value).", ".
+            "N".$this->quoteStringLiteral($level0Type).", ".$level0Name.', '.
+            "N".$this->quoteStringLiteral($level1Type).", ".$level1Name.', '.
+            "N".$this->quoteStringLiteral($level2Type).", ".$level2Name;
     }
 
     /**
@@ -839,12 +839,12 @@ 
         $level1Name = null,
         $level2Type = null,
         $level2Name = null
-    ) {
-        return "EXEC sp_dropextendedproperty " .
-            "N" . $this->quoteStringLiteral($name) . ", " .
-            "N" . $this->quoteStringLiteral($level0Type) . ", " . $level0Name . ', ' .
-            "N" . $this->quoteStringLiteral($level1Type) . ", " . $level1Name . ', ' .
-            "N" . $this->quoteStringLiteral($level2Type) . ", " . $level2Name;
+    ){
+        return "EXEC sp_dropextendedproperty ".
+            "N".$this->quoteStringLiteral($name).", ".
+            "N".$this->quoteStringLiteral($level0Type).", ".$level0Name.', '.
+            "N".$this->quoteStringLiteral($level1Type).", ".$level1Name.', '.
+            "N".$this->quoteStringLiteral($level2Type).", ".$level2Name;
     }
 
     /**
@@ -872,12 +872,12 @@ 
         $level1Name = null,
         $level2Type = null,
         $level2Name = null
-    ) {
-        return "EXEC sp_updateextendedproperty " .
-        "N" . $this->quoteStringLiteral($name) . ", N" . $this->quoteStringLiteral($value) . ", " .
-        "N" . $this->quoteStringLiteral($level0Type) . ", " . $level0Name . ', ' .
-        "N" . $this->quoteStringLiteral($level1Type) . ", " . $level1Name . ', ' .
-        "N" . $this->quoteStringLiteral($level2Type) . ", " . $level2Name;
+    ){
+        return "EXEC sp_updateextendedproperty ".
+        "N".$this->quoteStringLiteral($name).", N".$this->quoteStringLiteral($value).", ".
+        "N".$this->quoteStringLiteral($level0Type).", ".$level0Name.', '.
+        "N".$this->quoteStringLiteral($level1Type).", ".$level1Name.', '.
+        "N".$this->quoteStringLiteral($level2Type).", ".$level2Name;
     }
 
     /**
@@ -885,7 +885,7 @@ 
      */
     public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName)
     {
-        return 'INSERT INTO ' . $quotedTableName . ' DEFAULT VALUES';
+        return 'INSERT INTO '.$quotedTableName.' DEFAULT VALUES';
     }
 
     /**
@@ -972,7 +972,7 @@ 
                 JOIN sys.indexes AS idx ON tbl.object_id = idx.object_id
                 JOIN sys.index_columns AS idxcol ON idx.object_id = idxcol.object_id AND idx.index_id = idxcol.index_id
                 JOIN sys.columns AS col ON idxcol.object_id = col.object_id AND idxcol.column_id = col.column_id
-                WHERE " . $this->getTableWhereClause($table, 'scm.name', 'tbl.name') . "
+                WHERE " . $this->getTableWhereClause($table, 'scm.name', 'tbl.name')."
                 ORDER BY idx.index_id ASC, idxcol.key_ordinal ASC";
     }
 
@@ -981,7 +981,7 @@ 
      */
     public function getCreateViewSQL($name, $sql)
     {
-        return 'CREATE VIEW ' . $name . ' AS ' . $sql;
+        return 'CREATE VIEW '.$name.' AS '.$sql;
     }
 
     /**
@@ -1020,7 +1020,7 @@ 
      */
     public function getDropViewSQL($name)
     {
-        return 'DROP VIEW ' . $name;
+        return 'DROP VIEW '.$name;
     }
 
     /**
@@ -1039,10 +1039,10 @@ 
     public function getLocateExpression($str, $substr, $startPos = false)
     {
         if ($startPos == false) {
-            return 'CHARINDEX(' . $substr . ', ' . $str . ')';
+            return 'CHARINDEX('.$substr.', '.$str.')';
         }
 
-        return 'CHARINDEX(' . $substr . ', ' . $str . ', ' . $startPos . ')';
+        return 'CHARINDEX('.$substr.', '.$str.', '.$startPos.')';
     }
 
     /**
@@ -1050,7 +1050,7 @@ 
      */
     public function getModExpression($expression1, $expression2)
     {
-        return $expression1 . ' % ' . $expression2;
+        return $expression1.' % '.$expression2;
     }
 
     /**
@@ -1058,7 +1058,7 @@ 
      */
     public function getTrimExpression($str, $pos = TrimMode::UNSPECIFIED, $char = false)
     {
-        if ( ! $char) {
+        if (!$char) {
             switch ($pos) {
                 case TrimMode::LEADING:
                     $trimFn = 'LTRIM';
@@ -1069,10 +1069,10 @@ 
                     break;
 
                 default:
-                    return 'LTRIM(RTRIM(' . $str . '))';
+                    return 'LTRIM(RTRIM('.$str.'))';
             }
 
-            return $trimFn . '(' . $str . ')';
+            return $trimFn.'('.$str.')';
         }
 
         /** Original query used to get those expressions
@@ -1087,14 +1087,14 @@ 
         $pattern = "'%[^' + $char + ']%'";
 
         if ($pos === TrimMode::LEADING) {
-            return 'stuff(' . $str . ', 1, patindex(' . $pattern . ', ' . $str . ') - 1, null)';
+            return 'stuff('.$str.', 1, patindex('.$pattern.', '.$str.') - 1, null)';
         }
 
         if ($pos === TrimMode::TRAILING) {
-            return 'reverse(stuff(reverse(' . $str . '), 1, patindex(' . $pattern . ', reverse(' . $str . ')) - 1, null))';
+            return 'reverse(stuff(reverse('.$str.'), 1, patindex('.$pattern.', reverse('.$str.')) - 1, null))';
         }
 
-        return 'reverse(stuff(reverse(stuff(' . $str . ', 1, patindex(' . $pattern . ', ' . $str . ') - 1, null)), 1, patindex(' . $pattern . ', reverse(stuff(' . $str . ', 1, patindex(' . $pattern . ', ' . $str . ') - 1, null))) - 1, null))';
+        return 'reverse(stuff(reverse(stuff('.$str.', 1, patindex('.$pattern.', '.$str.') - 1, null)), 1, patindex('.$pattern.', reverse(stuff('.$str.', 1, patindex('.$pattern.', '.$str.') - 1, null))) - 1, null))';
     }
 
     /**
@@ -1104,7 +1104,7 @@ 
     {
         $args = func_get_args();
 
-        return '(' . implode(' + ', $args) . ')';
+        return '('.implode(' + ', $args).')';
     }
 
     /**
@@ -1129,10 +1129,10 @@ 
     public function getSubstringExpression($value, $from, $length = null)
     {
         if ($length !== null) {
-            return 'SUBSTRING(' . $value . ', ' . $from . ', ' . $length . ')';
+            return 'SUBSTRING('.$value.', '.$from.', '.$length.')';
         }
 
-        return 'SUBSTRING(' . $value . ', ' . $from . ', LEN(' . $value . ') - ' . $from . ' + 1)';
+        return 'SUBSTRING('.$value.', '.$from.', LEN('.$value.') - '.$from.' + 1)';
     }
 
     /**
@@ -1140,7 +1140,7 @@ 
      */
     public function getLengthExpression($column)
     {
-        return 'LEN(' . $column . ')';
+        return 'LEN('.$column.')';
     }
 
     /**
@@ -1148,7 +1148,7 @@ 
      */
     public function getSetTransactionIsolationSQL($level)
     {
-        return 'SET TRANSACTION ISOLATION LEVEL ' . $this->_getTransactionIsolationLevelSQL($level);
+        return 'SET TRANSACTION ISOLATION LEVEL '.$this->_getTransactionIsolationLevelSQL($level);
     }
 
     /**
@@ -1156,7 +1156,7 @@ 
      */
     public function getIntegerTypeDeclarationSQL(array $field)
     {
-        return 'INT' . $this->_getCommonIntegerTypeDeclarationSQL($field);
+        return 'INT'.$this->_getCommonIntegerTypeDeclarationSQL($field);
     }
 
     /**
@@ -1164,7 +1164,7 @@ 
      */
     public function getBigIntTypeDeclarationSQL(array $field)
     {
-        return 'BIGINT' . $this->_getCommonIntegerTypeDeclarationSQL($field);
+        return 'BIGINT'.$this->_getCommonIntegerTypeDeclarationSQL($field);
     }
 
     /**
@@ -1172,7 +1172,7 @@ 
      */
     public function getSmallIntTypeDeclarationSQL(array $field)
     {
-        return 'SMALLINT' . $this->_getCommonIntegerTypeDeclarationSQL($field);
+        return 'SMALLINT'.$this->_getCommonIntegerTypeDeclarationSQL($field);
     }
 
     /**
@@ -1188,7 +1188,7 @@ 
      */
     protected function getVarcharTypeDeclarationSQLSnippet($length, $fixed)
     {
-        return $fixed ? ($length ? 'NCHAR(' . $length . ')' : 'CHAR(255)') : ($length ? 'NVARCHAR(' . $length . ')' : 'NVARCHAR(255)');
+        return $fixed ? ($length ? 'NCHAR('.$length.')' : 'CHAR(255)') : ($length ? 'NVARCHAR('.$length.')' : 'NVARCHAR(255)');
     }
 
     /**
@@ -1196,7 +1196,7 @@ 
      */
     protected function getBinaryTypeDeclarationSQLSnippet($length, $fixed)
     {
-        return $fixed ? 'BINARY(' . ($length ?: 255) . ')' : 'VARBINARY(' . ($length ?: 255) . ')';
+        return $fixed ? 'BINARY('.($length ?: 255).')' : 'VARBINARY('.($length ?: 255).')';
     }
 
     /**
@@ -1343,7 +1343,7 @@ 
             }
 
             if ($currentPosition < $qLen - 1) {
-                $query = substr($query, 0, $orderByPos) . substr($query, $currentPosition - 1);
+                $query = substr($query, 0, $orderByPos).substr($query, $currentPosition - 1);
                 $offset = $orderByPos;
             }
         }
@@ -1373,7 +1373,7 @@ 
             }
 
             // Only yank query text on the same nesting level as the ORDER BY clause.
-            $subQueryBuffer = ($parenCount === 0 ? $query[$currentPosition] : ' ') . $subQueryBuffer;
+            $subQueryBuffer = ($parenCount === 0 ? $query[$currentPosition] : ' ').$subQueryBuffer;
 
             $currentPosition--;
         }
@@ -1420,7 +1420,7 @@ 
      */
     public function getTemporaryTableName($tableName)
     {
-        return '#' . $tableName;
+        return '#'.$tableName;
     }
 
     /**
@@ -1502,7 +1502,7 @@ 
      */
     public function createSavePoint($savepoint)
     {
-        return 'SAVE TRANSACTION ' . $savepoint;
+        return 'SAVE TRANSACTION '.$savepoint;
     }
 
     /**
@@ -1518,7 +1518,7 @@ 
      */
     public function rollbackSavePoint($savepoint)
     {
-        return 'ROLLBACK TRANSACTION ' . $savepoint;
+        return 'ROLLBACK TRANSACTION '.$savepoint;
     }
 
     /**
@@ -1541,13 +1541,13 @@ 
     {
         switch (true) {
             case LockMode::NONE === $lockMode:
-                return $fromClause . ' WITH (NOLOCK)';
+                return $fromClause.' WITH (NOLOCK)';
 
             case LockMode::PESSIMISTIC_READ === $lockMode:
-                return $fromClause . ' WITH (HOLDLOCK, ROWLOCK)';
+                return $fromClause.' WITH (HOLDLOCK, ROWLOCK)';
 
             case LockMode::PESSIMISTIC_WRITE === $lockMode:
-                return $fromClause . ' WITH (UPDLOCK, ROWLOCK)';
+                return $fromClause.' WITH (UPDLOCK, ROWLOCK)';
 
             default:
                 return $fromClause;
@@ -1575,7 +1575,7 @@ 
      */
     public function quoteSingleIdentifier($str)
     {
-        return "[" . str_replace("]", "][", $str) . "]";
+        return "[".str_replace("]", "][", $str)."]";
     }
 
     /**
@@ -1585,7 +1585,7 @@ 
     {
         $tableIdentifier = new Identifier($tableName);
 
-        return 'TRUNCATE TABLE ' . $tableIdentifier->getQuotedName($this);
+        return 'TRUNCATE TABLE '.$tableIdentifier->getQuotedName($this);
     }
 
     /**
@@ -1601,29 +1601,29 @@ 
      */
     public function getDefaultValueDeclarationSQL($field)
     {
-        if ( ! isset($field['default'])) {
+        if (!isset($field['default'])) {
             return empty($field['notnull']) ? ' NULL' : '';
         }
 
-        if ( ! isset($field['type'])) {
-            return " DEFAULT '" . $field['default'] . "'";
+        if (!isset($field['type'])) {
+            return " DEFAULT '".$field['default']."'";
         }
 
         $type = $field['type'];
 
         if ($type instanceof Types\PhpIntegerMappingType) {
-            return " DEFAULT " . $field['default'];
+            return " DEFAULT ".$field['default'];
         }
 
         if ($type instanceof Types\PhpDateTimeMappingType && $field['default'] === $this->getCurrentTimestampSQL()) {
-            return " DEFAULT " . $this->getCurrentTimestampSQL();
+            return " DEFAULT ".$this->getCurrentTimestampSQL();
         }
 
         if ($type instanceof Types\BooleanType) {
-            return " DEFAULT '" . $this->convertBooleans($field['default']) . "'";
+            return " DEFAULT '".$this->convertBooleans($field['default'])."'";
         }
 
-        return " DEFAULT '" . $field['default'] . "'";
+        return " DEFAULT '".$field['default']."'";
     }
 
     /**
@@ -1637,21 +1637,21 @@ 
             $columnDef = $this->getCustomTypeDeclarationSQL($field);
         } else {
             $collation = (isset($field['collation']) && $field['collation']) ?
-                ' ' . $this->getColumnCollationDeclarationSQL($field['collation']) : '';
+                ' '.$this->getColumnCollationDeclarationSQL($field['collation']) : '';
 
             $notnull = (isset($field['notnull']) && $field['notnull']) ? ' NOT NULL' : '';
 
             $unique = (isset($field['unique']) && $field['unique']) ?
-                ' ' . $this->getUniqueFieldDeclarationSQL() : '';
+                ' '.$this->getUniqueFieldDeclarationSQL() : '';
 
             $check = (isset($field['check']) && $field['check']) ?
-                ' ' . $field['check'] : '';
+                ' '.$field['check'] : '';
 
             $typeDecl = $field['type']->getSQLDeclaration($field, $this);
-            $columnDef = $typeDecl . $collation . $notnull . $unique . $check;
+            $columnDef = $typeDecl.$collation.$notnull.$unique.$check;
         }
 
-        return $name . ' ' . $columnDef;
+        return $name.' '.$columnDef;
     }
 
     /**
@@ -1664,7 +1664,7 @@ 
      */
     private function generateDefaultConstraintName($table, $column)
     {
-        return 'DF_' . $this->generateIdentifierName($table) . '_' . $this->generateIdentifierName($column);
+        return 'DF_'.$this->generateIdentifierName($table).'_'.$this->generateIdentifierName($column);
     }
 
     /**

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -19,9 +19,9 @@
 
 namespace Doctrine\DBAL\Query;
 
+use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Query\Expression\CompositeExpression;
-use Doctrine\DBAL\Connection;
 use function array_key_exists;
 use function array_keys;
 use function array_unshift;

Spacing +30 added lines, -30 removed lines

@@ -536,7 +536,7 @@ 
     {
         $this->type = self::DELETE;
 
-        if ( ! $delete) {
+        if (!$delete) {
             return $this;
         }
 
@@ -566,7 +566,7 @@ 
     {
         $this->type = self::UPDATE;
 
-        if ( ! $update) {
+        if (!$update) {
             return $this;
         }
 
@@ -599,7 +599,7 @@ 
     {
         $this->type = self::INSERT;
 
-        if ( ! $insert) {
+        if (!$insert) {
             return $this;
         }
 
@@ -757,7 +757,7 @@ 
      */
     public function set($key, $value)
     {
-        return $this->add('set', $key .' = ' . $value, true);
+        return $this->add('set', $key.' = '.$value, true);
     }
 
     /**
@@ -788,7 +788,7 @@ 
      */
     public function where($predicates)
     {
-        if ( ! (func_num_args() == 1 && $predicates instanceof CompositeExpression)) {
+        if (!(func_num_args() == 1 && $predicates instanceof CompositeExpression)) {
             $predicates = new CompositeExpression(CompositeExpression::TYPE_AND, func_get_args());
         }
 
@@ -974,7 +974,7 @@ 
      */
     public function having($having)
     {
-        if ( ! (func_num_args() == 1 && $having instanceof CompositeExpression)) {
+        if (!(func_num_args() == 1 && $having instanceof CompositeExpression)) {
             $having = new CompositeExpression(CompositeExpression::TYPE_AND, func_get_args());
         }
 
@@ -1038,7 +1038,7 @@ 
      */
     public function orderBy($sort, $order = null)
     {
-        return $this->add('orderBy', $sort . ' ' . (! $order ? 'ASC' : $order), false);
+        return $this->add('orderBy', $sort.' '.(!$order ? 'ASC' : $order), false);
     }
 
     /**
@@ -1051,7 +1051,7 @@ 
      */
     public function addOrderBy($sort, $order = null)
     {
-        return $this->add('orderBy', $sort . ' ' . (! $order ? 'ASC' : $order), true);
+        return $this->add('orderBy', $sort.' '.(!$order ? 'ASC' : $order), true);
     }
 
     /**
@@ -1120,13 +1120,13 @@ 
      */
     private function getSQLForSelect()
     {
-        $query = 'SELECT ' . implode(', ', $this->sqlParts['select']);
+        $query = 'SELECT '.implode(', ', $this->sqlParts['select']);
 
-        $query .= ($this->sqlParts['from'] ? ' FROM ' . implode(', ', $this->getFromClauses()) : '')
-            . ($this->sqlParts['where'] !== null ? ' WHERE ' . ((string) $this->sqlParts['where']) : '')
-            . ($this->sqlParts['groupBy'] ? ' GROUP BY ' . implode(', ', $this->sqlParts['groupBy']) : '')
-            . ($this->sqlParts['having'] !== null ? ' HAVING ' . ((string) $this->sqlParts['having']) : '')
-            . ($this->sqlParts['orderBy'] ? ' ORDER BY ' . implode(', ', $this->sqlParts['orderBy']) : '');
+        $query .= ($this->sqlParts['from'] ? ' FROM '.implode(', ', $this->getFromClauses()) : '')
+            . ($this->sqlParts['where'] !== null ? ' WHERE '.((string) $this->sqlParts['where']) : '')
+            . ($this->sqlParts['groupBy'] ? ' GROUP BY '.implode(', ', $this->sqlParts['groupBy']) : '')
+            . ($this->sqlParts['having'] !== null ? ' HAVING '.((string) $this->sqlParts['having']) : '')
+            . ($this->sqlParts['orderBy'] ? ' ORDER BY '.implode(', ', $this->sqlParts['orderBy']) : '');
 
         if ($this->isLimitQuery()) {
             return $this->connection->getDatabasePlatform()->modifyLimitQuery(
@@ -1153,13 +1153,13 @@ 
                 $tableSql = $from['table'];
                 $tableReference = $from['table'];
             } else {
-                $tableSql = $from['table'] . ' ' . $from['alias'];
+                $tableSql = $from['table'].' '.$from['alias'];
                 $tableReference = $from['alias'];
             }
 
             $knownAliases[$tableReference] = true;
 
-            $fromClauses[$tableReference] = $tableSql . $this->getSQLForJoins($tableReference, $knownAliases);
+            $fromClauses[$tableReference] = $tableSql.$this->getSQLForJoins($tableReference, $knownAliases);
         }
 
         $this->verifyAllAliasesAreKnown($knownAliases);
@@ -1175,7 +1175,7 @@ 
     private function verifyAllAliasesAreKnown(array $knownAliases)
     {
         foreach ($this->sqlParts['join'] as $fromAlias => $joins) {
-            if ( ! isset($knownAliases[$fromAlias])) {
+            if (!isset($knownAliases[$fromAlias])) {
                 throw QueryException::unknownAlias($fromAlias, array_keys($knownAliases));
             }
         }
@@ -1196,9 +1196,9 @@ 
      */
     private function getSQLForInsert()
     {
-        return 'INSERT INTO ' . $this->sqlParts['from']['table'] .
-        ' (' . implode(', ', array_keys($this->sqlParts['values'])) . ')' .
-        ' VALUES(' . implode(', ', $this->sqlParts['values']) . ')';
+        return 'INSERT INTO '.$this->sqlParts['from']['table'].
+        ' ('.implode(', ', array_keys($this->sqlParts['values'])).')'.
+        ' VALUES('.implode(', ', $this->sqlParts['values']).')';
     }
 
     /**
@@ -1208,10 +1208,10 @@ 
      */
     private function getSQLForUpdate()
     {
-        $table = $this->sqlParts['from']['table'] . ($this->sqlParts['from']['alias'] ? ' ' . $this->sqlParts['from']['alias'] : '');
-        $query = 'UPDATE ' . $table
-            . ' SET ' . implode(", ", $this->sqlParts['set'])
-            . ($this->sqlParts['where'] !== null ? ' WHERE ' . ((string) $this->sqlParts['where']) : '');
+        $table = $this->sqlParts['from']['table'].($this->sqlParts['from']['alias'] ? ' '.$this->sqlParts['from']['alias'] : '');
+        $query = 'UPDATE '.$table
+            . ' SET '.implode(", ", $this->sqlParts['set'])
+            . ($this->sqlParts['where'] !== null ? ' WHERE '.((string) $this->sqlParts['where']) : '');
 
         return $query;
     }
@@ -1223,8 +1223,8 @@ 
      */
     private function getSQLForDelete()
     {
-        $table = $this->sqlParts['from']['table'] . ($this->sqlParts['from']['alias'] ? ' ' . $this->sqlParts['from']['alias'] : '');
-        $query = 'DELETE FROM ' . $table . ($this->sqlParts['where'] !== null ? ' WHERE ' . ((string) $this->sqlParts['where']) : '');
+        $table = $this->sqlParts['from']['table'].($this->sqlParts['from']['alias'] ? ' '.$this->sqlParts['from']['alias'] : '');
+        $query = 'DELETE FROM '.$table.($this->sqlParts['where'] !== null ? ' WHERE '.((string) $this->sqlParts['where']) : '');
 
         return $query;
     }
@@ -1273,7 +1273,7 @@ 
     {
         if ($placeHolder === null) {
             $this->boundCounter++;
-            $placeHolder = ":dcValue" . $this->boundCounter;
+            $placeHolder = ":dcValue".$this->boundCounter;
         }
         $this->setParameter(substr($placeHolder, 1), $value, $type);
 
@@ -1327,9 +1327,9 @@ 
                 if (array_key_exists($join['joinAlias'], $knownAliases)) {
                     throw QueryException::nonUniqueAlias($join['joinAlias'], array_keys($knownAliases));
                 }
-                $sql .= ' ' . strtoupper($join['joinType'])
-                    . ' JOIN ' . $join['joinTable'] . ' ' . $join['joinAlias']
-                    . ' ON ' . ((string) $join['joinCondition']);
+                $sql .= ' '.strtoupper($join['joinType'])
+                    . ' JOIN '.$join['joinTable'].' '.$join['joinAlias']
+                    . ' ON '.((string) $join['joinCondition']);
                 $knownAliases[$join['joinAlias']] = true;
             }
 

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -983,7 +983,7 @@ 
     /**
      * @param array $view
      *
-     * @return mixed
+     * @return boolean
      */
     protected function _getPortableViewDefinition($view)
     {
@@ -1090,7 +1090,7 @@ 
      * For databases that don't support subschema/namespaces this method
      * returns the name of the currently connected database.
      *
-     * @return array
+     * @return string[]
      */
     public function getSchemaSearchPaths()
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -19,10 +19,10 @@
 
 namespace Doctrine\DBAL\Schema;
 
-use Doctrine\DBAL\Events;
+use Doctrine\DBAL\DBALException;
 use Doctrine\DBAL\Event\SchemaColumnDefinitionEventArgs;
 use Doctrine\DBAL\Event\SchemaIndexDefinitionEventArgs;
-use Doctrine\DBAL\DBALException;
+use Doctrine\DBAL\Events;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use function array_filter;
 use function array_map;

Spacing +9 added lines, -9 removed lines

@@ -175,7 +175,7 @@ 
      */
     public function listTableColumns($table, $database = null)
     {
-        if ( ! $database) {
+        if (!$database) {
             $database = $this->_conn->getDatabase();
         }
 
@@ -244,12 +244,12 @@ 
     protected function filterAssetNames($assetNames)
     {
         $filterExpr = $this->getFilterSchemaAssetsExpression();
-        if ( ! $filterExpr) {
+        if (!$filterExpr) {
             return $assetNames;
         }
 
         return array_values(
-            array_filter($assetNames, function ($assetName) use ($filterExpr) {
+            array_filter($assetNames, function($assetName) use ($filterExpr) {
                 $assetName = ($assetName instanceof AbstractAsset) ? $assetName->getName() : $assetName;
 
                 return preg_match($filterExpr, $assetName);
@@ -450,7 +450,7 @@ 
      */
     public function createTable(Table $table)
     {
-        $createFlags = AbstractPlatform::CREATE_INDEXES|AbstractPlatform::CREATE_FOREIGNKEYS;
+        $createFlags = AbstractPlatform::CREATE_INDEXES | AbstractPlatform::CREATE_FOREIGNKEYS;
         $this->_execSql($this->_platform->getCreateTableSQL($table, $createFlags));
     }
 
@@ -827,7 +827,7 @@ 
                 $column = $eventArgs->getColumn();
             }
 
-            if ( ! $defaultPrevented) {
+            if (!$defaultPrevented) {
                 $column = $this->_getPortableTableColumnDefinition($tableColumn);
             }
 
@@ -857,7 +857,7 @@ 
      *
      * @return array
      */
-    protected function _getPortableTableIndexesList($tableIndexRows, $tableName=null)
+    protected function _getPortableTableIndexesList($tableIndexRows, $tableName = null)
     {
         $result = [];
         foreach ($tableIndexRows as $tableIndex) {
@@ -896,7 +896,7 @@ 
                 $index = $eventArgs->getIndex();
             }
 
-            if ( ! $defaultPrevented) {
+            if (!$defaultPrevented) {
                 $index = new Index($data['name'], $data['columns'], $data['unique'], $data['primary'], $data['flags'], $data['options']);
             }
 
@@ -1069,10 +1069,10 @@ 
         }
 
         $params = $this->_conn->getParams();
-        if (! isset($params['defaultTableOptions'])) {
+        if (!isset($params['defaultTableOptions'])) {
             $params['defaultTableOptions'] = [];
         }
-        if (! isset($params['defaultTableOptions']['charset']) && isset($params['charset'])) {
+        if (!isset($params['defaultTableOptions']['charset']) && isset($params['charset'])) {
             $params['defaultTableOptions']['charset'] = $params['charset'];
         }
         $schemaConfig->setDefaultTableOptions($params['defaultTableOptions']);

Braces +1 added lines, -1 removed lines

@@ -249,7 +249,7 @@
         }
 
         return array_values(
-            array_filter($assetNames, function ($assetName) use ($filterExpr) {
+            array_filter($assetNames, function ($assetName) use ($filterExpr){
                 $assetName = ($assetName instanceof AbstractAsset) ? $assetName->getName() : $assetName;
 
                 return preg_match($filterExpr, $assetName);

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Constraint.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
      * Returns the names of the referencing table columns
      * the constraint is associated with.
      *
-     * @return array
+     * @return integer[]
      */
     public function getColumns();
 

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/ForeignKeyConstraint.php

Doc Comments +5 added lines, -5 removed lines

@@ -141,7 +141,7 @@ 
      * Returns the names of the referencing table columns
      * the foreign key constraint is associated with.
      *
-     * @return array
+     * @return integer[]
      */
     public function getLocalColumns()
     {
@@ -264,7 +264,7 @@ 
      * Returns the names of the referenced table columns
      * the foreign key constraint is associated with.
      *
-     * @return array
+     * @return integer[]
      */
     public function getForeignColumns()
     {
@@ -333,7 +333,7 @@ 
      * Returns the referential action for UPDATE operations
      * on the referenced table the foreign key constraint is associated with.
      *
-     * @return string|null
+     * @return string|false
      */
     public function onUpdate()
     {
@@ -344,7 +344,7 @@ 
      * Returns the referential action for DELETE operations
      * on the referenced table the foreign key constraint is associated with.
      *
-     * @return string|null
+     * @return string|false
      */
     public function onDelete()
     {
@@ -357,7 +357,7 @@ 
      *
      * @param string $event Name of the database operation/event to return the referential action for.
      *
-     * @return string|null
+     * @return string|false
      */
     private function onEvent($event)
     {

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
     public function __construct(array $localColumnNames, $foreignTableName, array $foreignColumnNames, $name = null, array $options = [])
     {
         $this->_setName($name);
-        $identifierConstructorCallback = function ($column) {
+        $identifierConstructorCallback = function($column){
             return new Identifier($column);
         };
         $this->_localColumnNames = $localColumnNames
@@ -364,7 +364,7 @@ 
         if (isset($this->_options[$event])) {
             $onEvent = strtoupper($this->_options[$event]);
 
-            if ( ! in_array($onEvent, ['NO ACTION', 'RESTRICT'])) {
+            if (!in_array($onEvent, ['NO ACTION', 'RESTRICT'])) {
                 return $onEvent;
             }
         }

Braces +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
     public function __construct(array $localColumnNames, $foreignTableName, array $foreignColumnNames, $name = null, array $options = [])
     {
         $this->_setName($name);
-        $identifierConstructorCallback = function ($column) {
+        $identifierConstructorCallback = function ($column){
             return new Identifier($column);
         };
         $this->_localColumnNames = $localColumnNames

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Schema.php

Doc Comments +1 added lines, -1 removed lines

@@ -266,7 +266,7 @@
     /**
      * Gets all table names, prefixed with a schema name, even the default one if present.
      *
-     * @return array
+     * @return integer[]
      */
     public function getTableNames()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -19,11 +19,11 @@
 
 namespace Doctrine\DBAL\Schema;
 
+use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\Visitor\CreateSchemaSqlCollector;
 use Doctrine\DBAL\Schema\Visitor\DropSchemaSqlCollector;
 use Doctrine\DBAL\Schema\Visitor\NamespaceVisitor;
 use Doctrine\DBAL\Schema\Visitor\Visitor;
-use Doctrine\DBAL\Platforms\AbstractPlatform;
 use function array_keys;
 use function strpos;
 use function strtolower;

Spacing +5 added lines, -5 removed lines

@@ -91,7 +91,7 @@ 
         array $sequences = [],
         SchemaConfig $schemaConfig = null,
         array $namespaces = []
-    ) {
+    ){
         if ($schemaConfig == null) {
             $schemaConfig = new SchemaConfig();
         }
@@ -135,7 +135,7 @@ 
             throw SchemaException::tableAlreadyExists($tableName);
         }
 
-        if ( ! $table->isInDefaultNamespace($this->getName()) && ! $this->hasNamespace($namespaceName)) {
+        if (!$table->isInDefaultNamespace($this->getName()) && !$this->hasNamespace($namespaceName)) {
             $this->createNamespace($namespaceName);
         }
 
@@ -159,7 +159,7 @@ 
             throw SchemaException::sequenceAlreadyExists($seqName);
         }
 
-        if ( ! $sequence->isInDefaultNamespace($this->getName()) && ! $this->hasNamespace($namespaceName)) {
+        if (!$sequence->isInDefaultNamespace($this->getName()) && !$this->hasNamespace($namespaceName)) {
             $this->createNamespace($namespaceName);
         }
 
@@ -213,7 +213,7 @@ 
         $name = $this->getUnquotedAssetName($name);
 
         if (strpos($name, ".") === false) {
-            $name = $this->getName() . "." . $name;
+            $name = $this->getName().".".$name;
         }
 
         return strtolower($name);
@@ -395,7 +395,7 @@ 
      *
      * @return \Doctrine\DBAL\Schema\Sequence
      */
-    public function createSequence($sequenceName, $allocationSize=1, $initialValue=1)
+    public function createSequence($sequenceName, $allocationSize = 1, $initialValue = 1)
     {
         $seq = new Sequence($sequenceName, $allocationSize, $initialValue);
         $this->_addSequence($seq);

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Table.php

Doc Comments +2 added lines, -2 removed lines

@@ -205,7 +205,7 @@ 
     }
 
     /**
-     * @param array       $columnNames
+     * @param integer[]       $columnNames
      * @param string|null $indexName
      * @param array       $options
      *
@@ -800,7 +800,7 @@ 
     /**
      * @param string $name
      *
-     * @return mixed
+     * @return string
      */
     public function getOption($name)
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -19,9 +19,9 @@
 
 namespace Doctrine\DBAL\Schema;
 
-use Doctrine\DBAL\Types\Type;
-use Doctrine\DBAL\Schema\Visitor\Visitor;
 use Doctrine\DBAL\DBALException;
+use Doctrine\DBAL\Schema\Visitor\Visitor;
+use Doctrine\DBAL\Types\Type;
 use const ARRAY_FILTER_USE_KEY;
 use function array_filter;
 use function array_merge;

Spacing +19 added lines, -19 removed lines

@@ -91,7 +91,7 @@ 
      *
      * @throws DBALException
      */
-    public function __construct($tableName, array $columns=[], array $indexes=[], array $fkConstraints=[], $idGeneratorType = 0, array $options=[])
+    public function __construct($tableName, array $columns = [], array $indexes = [], array $fkConstraints = [], $idGeneratorType = 0, array $options = [])
     {
         if (strlen($tableName) == 0) {
             throw DBALException::invalidTableName($tableName);
@@ -198,7 +198,7 @@ 
     public function dropIndex($indexName)
     {
         $indexName = $this->normalizeIdentifier($indexName);
-        if ( ! $this->hasIndex($indexName)) {
+        if (!$this->hasIndex($indexName)) {
             throw SchemaException::indexDoesNotExist($indexName, $this->_name);
         }
         unset($this->_indexes[$indexName]);
@@ -243,7 +243,7 @@ 
             return $this;
         }
 
-        if ( ! $this->hasIndex($oldIndexName)) {
+        if (!$this->hasIndex($oldIndexName)) {
             throw SchemaException::indexDoesNotExist($oldIndexName, $this->_name);
         }
 
@@ -310,7 +310,7 @@ 
                 $columnName = $indexColOptions;
             }
 
-            if ( ! $this->hasColumn($columnName)) {
+            if (!$this->hasColumn($columnName)) {
                 throw SchemaException::columnDoesNotExist($columnName, $this->_name);
             }
         }
@@ -325,7 +325,7 @@ 
      *
      * @return Column
      */
-    public function addColumn($columnName, $typeName, array $options=[])
+    public function addColumn($columnName, $typeName, array $options = [])
     {
         $column = new Column($columnName, Type::getType($typeName), $options);
 
@@ -346,8 +346,8 @@ 
      */
     public function renameColumn($oldColumnName, $newColumnName)
     {
-        throw new DBALException("Table#renameColumn() was removed, because it drops and recreates " .
-            "the column instead. There is no fix available, because a schema diff cannot reliably detect if a " .
+        throw new DBALException("Table#renameColumn() was removed, because it drops and recreates ".
+            "the column instead. There is no fix available, because a schema diff cannot reliably detect if a ".
             "column was renamed or one column was created and another one dropped.");
     }
 
@@ -395,7 +395,7 @@ 
      *
      * @return self
      */
-    public function addForeignKeyConstraint($foreignTable, array $localColumnNames, array $foreignColumnNames, array $options=[], $constraintName = null)
+    public function addForeignKeyConstraint($foreignTable, array $localColumnNames, array $foreignColumnNames, array $options = [], $constraintName = null)
     {
         $constraintName = $constraintName ?: $this->_generateIdentifierName(array_merge((array) $this->getName(), $localColumnNames), "fk", $this->_getMaxIdentifierLength());
 
@@ -416,7 +416,7 @@ 
      *
      * @return self
      */
-    public function addUnnamedForeignKeyConstraint($foreignTable, array $localColumnNames, array $foreignColumnNames, array $options=[])
+    public function addUnnamedForeignKeyConstraint($foreignTable, array $localColumnNames, array $foreignColumnNames, array $options = [])
     {
         return $this->addForeignKeyConstraint($foreignTable, $localColumnNames, $foreignColumnNames, $options);
     }
@@ -436,18 +436,18 @@ 
      *
      * @throws SchemaException
      */
-    public function addNamedForeignKeyConstraint($name, $foreignTable, array $localColumnNames, array $foreignColumnNames, array $options=[])
+    public function addNamedForeignKeyConstraint($name, $foreignTable, array $localColumnNames, array $foreignColumnNames, array $options = [])
     {
         if ($foreignTable instanceof Table) {
             foreach ($foreignColumnNames as $columnName) {
-                if ( ! $foreignTable->hasColumn($columnName)) {
+                if (!$foreignTable->hasColumn($columnName)) {
                     throw SchemaException::columnDoesNotExist($columnName, $foreignTable->getName());
                 }
             }
         }
 
         foreach ($localColumnNames as $columnName) {
-            if ( ! $this->hasColumn($columnName)) {
+            if (!$this->hasColumn($columnName)) {
                 throw SchemaException::columnDoesNotExist($columnName, $this->_name);
             }
         }
@@ -513,7 +513,7 @@ 
             }
         }
 
-        if ((isset($this->_indexes[$indexName]) && ! in_array($indexName, $replacedImplicitIndexes, true)) ||
+        if ((isset($this->_indexes[$indexName]) && !in_array($indexName, $replacedImplicitIndexes, true)) ||
             ($this->_primaryKeyName != false && $indexCandidate->isPrimary())
         ) {
             throw SchemaException::indexAlreadyExists($indexName, $this->_name);
@@ -659,7 +659,7 @@ 
      */
     private function filterColumns(array $columnNames)
     {
-        return array_filter($this->_columns, function ($columnName) use ($columnNames) {
+        return array_filter($this->_columns, function($columnName) use ($columnNames) {
             return in_array($columnName, $columnNames, true);
         }, ARRAY_FILTER_USE_KEY);
     }
@@ -690,7 +690,7 @@ 
     public function getColumn($columnName)
     {
         $columnName = $this->normalizeIdentifier($columnName);
-        if ( ! $this->hasColumn($columnName)) {
+        if (!$this->hasColumn($columnName)) {
             throw SchemaException::columnDoesNotExist($columnName, $this->_name);
         }
 
@@ -704,7 +704,7 @@ 
      */
     public function getPrimaryKey()
     {
-        if ( ! $this->hasPrimaryKey()) {
+        if (!$this->hasPrimaryKey()) {
             return null;
         }
 
@@ -720,8 +720,8 @@ 
      */
     public function getPrimaryKeyColumns()
     {
-        if ( ! $this->hasPrimaryKey()) {
-            throw new DBALException("Table " . $this->getName() . " has no primary key.");
+        if (!$this->hasPrimaryKey()) {
+            throw new DBALException("Table ".$this->getName()." has no primary key.");
         }
         return $this->getPrimaryKey()->getColumns();
     }
@@ -762,7 +762,7 @@ 
     public function getIndex($indexName)
     {
         $indexName = $this->normalizeIdentifier($indexName);
-        if ( ! $this->hasIndex($indexName)) {
+        if (!$this->hasIndex($indexName)) {
             throw SchemaException::indexDoesNotExist($indexName, $this->_name);
         }
 

Braces +1 added lines, -1 removed lines

@@ -659,7 +659,7 @@
      */
     private function filterColumns(array $columnNames)
     {
-        return array_filter($this->_columns, function ($columnName) use ($columnNames) {
+        return array_filter($this->_columns, function ($columnName) use ($columnNames){
             return in_array($columnName, $columnNames, true);
         }, ARRAY_FILTER_USE_KEY);
     }

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Visitor/NamespaceVisitor.php

Doc Comments +1 added lines

@@ -32,6 +32,7 @@
      * Accepts a schema namespace name.
      *
      * @param string $namespaceName The schema namespace name to accept.
+     * @return void
      */
     public function acceptNamespace($namespaceName);
 }

core/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Visitor/SchemaDiffVisitor.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -19,10 +19,10 @@
 
 namespace Doctrine\DBAL\Schema\Visitor;
 
-use Doctrine\DBAL\Schema\Table;
-use Doctrine\DBAL\Schema\TableDiff;
 use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use Doctrine\DBAL\Schema\Sequence;
+use Doctrine\DBAL\Schema\Table;
+use Doctrine\DBAL\Schema\TableDiff;
 
 /**
  * Visit a SchemaDiff.