evolution-cms / evolution

manager/actions/export_site.static.php

Indentation +9 added lines, -9 removed lines

@@ -1,9 +1,9 @@ 
 <?php
 if(IN_MANAGER_MODE != "true") {
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 if(!$modx->hasPermission('export_static')) {
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
 // figure out the base of the server, so we know where to get the documents in order to export them
@@ -35,11 +35,11 @@ 
 
 		<div class="container container-body">
 			<?php
-			if(isset($_POST['export'])) {
-				$rs = include_once(MODX_MANAGER_PATH . 'processors/export_site.processor.php');
-				echo $rs;
-			} else {
-				?>
+            if(isset($_POST['export'])) {
+                $rs = include_once(MODX_MANAGER_PATH . 'processors/export_site.processor.php');
+                echo $rs;
+            } else {
+                ?>
 				<form action="index.php" method="post" name="exportFrm">
 					<input type="hidden" name="export" value="export" />
 					<input type="hidden" name="a" value="83" />
@@ -81,8 +81,8 @@ 
 					</script>
 				</form>
 				<?php
-			}
-			?>
+            }
+            ?>
 		</div>
 	</div>
 

Spacing +5 added lines, -5 removed lines

@@ -1,8 +1,8 @@ 
 <?php
-if(IN_MANAGER_MODE != "true") {
+if (IN_MANAGER_MODE != "true") {
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
-if(!$modx->hasPermission('export_static')) {
+if (!$modx->hasPermission('export_static')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
@@ -35,8 +35,8 @@ 
 
 		<div class="container container-body">
 			<?php
-			if(isset($_POST['export'])) {
-				$rs = include_once(MODX_MANAGER_PATH . 'processors/export_site.processor.php');
+			if (isset($_POST['export'])) {
+				$rs = include_once(MODX_MANAGER_PATH.'processors/export_site.processor.php');
 				echo $rs;
 			} else {
 				?>
@@ -76,7 +76,7 @@ 
 					<a href="javascript:;" class="btn btn-primary" onclick="document.exportFrm.submit();jQuery(this).hide();"><i class="<?= $_style["actions_save"] ?>"></i> <?= $_lang["export_site_start"] ?></a>
 					<script>
 						jQuery('#exportButton a').click(function() {
-							jQuery(this).parent().html('<?= $_style['ajax_loader'];?>');
+							jQuery(this).parent().html('<?= $_style['ajax_loader']; ?>');
 						});
 					</script>
 				</form>

manager/actions/role_management.static.php

Indentation +16 added lines, -16 removed lines

@@ -1,9 +1,9 @@ 
 <?php
 if(IN_MANAGER_MODE != "true") {
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 if(!$modx->hasPermission('edit_user')) {
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
 ?>
@@ -18,14 +18,14 @@ 
 		<div class="form-group"><?= $_lang['role_management_msg'] ?> <a class="btn btn-secondary btn-sm" href="index.php?a=38"><i class="<?= $_style["actions_new"] ?> hide4desktop"></i> <?= $_lang['new_role'] ?></a></div>
 		<div class="form-group">
 			<?php
-			$rs = $modx->db->select('name, id, description', $modx->getFullTableName('user_roles'), '', 'name');
-			$limit = $modx->db->getRecordCount($rs);
-			if($limit < 1) {
-				?>
+            $rs = $modx->db->select('name, id, description', $modx->getFullTableName('user_roles'), '', 'name');
+            $limit = $modx->db->getRecordCount($rs);
+            if($limit < 1) {
+                ?>
 				<p><?= $_lang["no_records_found"] ?></p>
 				<?php
-			} else {
-				?>
+            } else {
+                ?>
 				<div class="row">
 					<div class="table-responsive">
 						<table class="table data">
@@ -37,24 +37,24 @@ 
 							</thead>
 							<tbody>
 							<?php
-							while($row = $modx->db->getRow($rs)) {
-								if($row['id'] == 1) {
-									?>
+                            while($row = $modx->db->getRow($rs)) {
+                                if($row['id'] == 1) {
+                                    ?>
 									<tr class="text-muted disabled">
 										<td><b><?= $row['name'] ?></b></td>
 										<td><span><?= $_lang['administrator_role_message'] ?></span></td>
 									</tr>
 									<?php
-								} else {
-									?>
+                                } else {
+                                    ?>
 									<tr>
 										<td><a class="text-primary" href="index.php?id=<?= $row['id'] ?>&a=35"><?= $row['name'] ?></a></td>
 										<td><?= $row['description'] ?></td>
 									</tr>
 									<?php
-								}
-							}
-							?>
+                                }
+                            }
+                            ?>
 							</tbody>
 						</table>
 					</div>

Spacing +5 added lines, -5 removed lines

@@ -1,8 +1,8 @@ 
 <?php
-if(IN_MANAGER_MODE != "true") {
+if (IN_MANAGER_MODE != "true") {
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
-if(!$modx->hasPermission('edit_user')) {
+if (!$modx->hasPermission('edit_user')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
@@ -20,7 +20,7 @@ 
 			<?php
 			$rs = $modx->db->select('name, id, description', $modx->getFullTableName('user_roles'), '', 'name');
 			$limit = $modx->db->getRecordCount($rs);
-			if($limit < 1) {
+			if ($limit < 1) {
 				?>
 				<p><?= $_lang["no_records_found"] ?></p>
 				<?php
@@ -37,8 +37,8 @@ 
 							</thead>
 							<tbody>
 							<?php
-							while($row = $modx->db->getRow($rs)) {
-								if($row['id'] == 1) {
+							while ($row = $modx->db->getRow($rs)) {
+								if ($row['id'] == 1) {
 									?>
 									<tr class="text-muted disabled">
 										<td><b><?= $row['name'] ?></b></td>

manager/actions/eventlog_details.dynamic.php

Indentation +14 added lines, -14 removed lines

@@ -1,9 +1,9 @@ 
 <?php
 if(IN_MANAGER_MODE != "true") {
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 if(!$modx->hasPermission('view_eventlog')) {
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
 // get id
@@ -41,18 +41,18 @@ 
 	<div class="tab-page">
 		<div class="container container-body">
 			<?php
-			$date = $modx->toDateFormat($content["createdon"]);
-			if($content["type"] == 1) {
-				$icon = $_style['actions_info'] . ' text-info';
-				$msgtype = $_lang["information"];
-			} else if($content["type"] == 2) {
-				$icon = $_style['actions_triangle'] . ' text-warning';
-				$msgtype = $_lang["warning"];
-			} else if($content["type"] == 3) {
-				$icon = $_style['actions_error'] . ' text-danger';
-				$msgtype = $_lang["error"];
-			}
-			?>
+            $date = $modx->toDateFormat($content["createdon"]);
+            if($content["type"] == 1) {
+                $icon = $_style['actions_info'] . ' text-info';
+                $msgtype = $_lang["information"];
+            } else if($content["type"] == 2) {
+                $icon = $_style['actions_triangle'] . ' text-warning';
+                $msgtype = $_lang["warning"];
+            } else if($content["type"] == 3) {
+                $icon = $_style['actions_error'] . ' text-danger';
+                $msgtype = $_lang["error"];
+            }
+            ?>
 			<p><b><?= $content['source'] . " - " . $_lang['eventlog_viewer'] ?></b></p>
 			<p>
 				<i class="<?= $icon ?>"></i> <?= $msgtype ?>

Spacing +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@ 
 <?php
-if(IN_MANAGER_MODE != "true") {
+if (IN_MANAGER_MODE != "true") {
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
-if(!$modx->hasPermission('view_eventlog')) {
+if (!$modx->hasPermission('view_eventlog')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
 // get id
 $id = isset($_REQUEST['id']) ? intval($_REQUEST['id']) : 0;
 
-$ds = $modx->db->select('el.*, IFNULL(wu.username,mu.username) as username', $modx->getFullTableName("event_log") . " el 
-		LEFT JOIN " . $modx->getFullTableName("manager_users") . " mu ON mu.id=el.user AND el.usertype=0
-		LEFT JOIN " . $modx->getFullTableName("web_users") . " wu ON wu.id=el.user AND el.usertype=1", "el.id='{$id}'");
+$ds = $modx->db->select('el.*, IFNULL(wu.username,mu.username) as username', $modx->getFullTableName("event_log")." el 
+		LEFT JOIN " . $modx->getFullTableName("manager_users")." mu ON mu.id=el.user AND el.usertype=0
+		LEFT JOIN " . $modx->getFullTableName("web_users")." wu ON wu.id=el.user AND el.usertype=1", "el.id='{$id}'");
 $content = $modx->db->getRow($ds);
 
 ?>
@@ -42,18 +42,18 @@ 
 		<div class="container container-body">
 			<?php
 			$date = $modx->toDateFormat($content["createdon"]);
-			if($content["type"] == 1) {
-				$icon = $_style['actions_info'] . ' text-info';
+			if ($content["type"] == 1) {
+				$icon = $_style['actions_info'].' text-info';
 				$msgtype = $_lang["information"];
-			} else if($content["type"] == 2) {
-				$icon = $_style['actions_triangle'] . ' text-warning';
+			} else if ($content["type"] == 2) {
+				$icon = $_style['actions_triangle'].' text-warning';
 				$msgtype = $_lang["warning"];
-			} else if($content["type"] == 3) {
-				$icon = $_style['actions_error'] . ' text-danger';
+			} else if ($content["type"] == 3) {
+				$icon = $_style['actions_error'].' text-danger';
 				$msgtype = $_lang["error"];
 			}
 			?>
-			<p><b><?= $content['source'] . " - " . $_lang['eventlog_viewer'] ?></b></p>
+			<p><b><?= $content['source']." - ".$_lang['eventlog_viewer'] ?></b></p>
 			<p>
 				<i class="<?= $icon ?>"></i> <?= $msgtype ?>
 			</p>

manager/processors/purge_plugin.processor.php

Indentation +2 added lines, -2 removed lines

@@ -2,8 +2,8 @@
 if(!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE != 'true') exit();
 
 if(!$modx->hasPermission('delete_plugin')) {	
-	$e->setError(3);
-	$e->dumpError();	
+    $e->setError(3);
+    $e->dumpError();	
 }
 
 $tbl_site_plugins = $modx->getFullTablename('site_plugins');

Spacing +5 added lines, -5 removed lines

@@ -1,7 +1,7 @@ 
 <?php
-if(!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE != 'true') exit();
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE != 'true') exit();
 
-if(!$modx->hasPermission('delete_plugin')) {	
+if (!$modx->hasPermission('delete_plugin')) {	
 	$e->setError(3);
 	$e->dumpError();	
 }
@@ -12,18 +12,18 @@ 
 // Get unique list of latest added plugins by highest sql-id
 $rs = $modx->db->query("SELECT t1.id FROM {$tbl_site_plugins} t1 LEFT JOIN {$tbl_site_plugins} t2 ON (t1.name = t2.name AND t1.id < t2.id) WHERE t2.id IS NULL;");
 $latestIds = array();
-while($row = $modx->db->getRow($rs)) {
+while ($row = $modx->db->getRow($rs)) {
     $latestIds[] = $row['id'];
 }
 
 // Get list of plugins with disabled and enabled versions
 $rs = $modx->db->query("SELECT id FROM {$tbl_site_plugins} t1 WHERE disabled = 1 AND name IN (SELECT name FROM {$tbl_site_plugins} t2 WHERE t1.name = t2.name AND t1.id != t2.id)");
 
-while($row = $modx->db->getRow($rs)) {
+while ($row = $modx->db->getRow($rs)) {
 
     $id = $row['id'];
 
-    if(in_array($id,$latestIds)) continue;	// Keep latest version of disabled plugins 
+    if (in_array($id, $latestIds)) continue; // Keep latest version of disabled plugins 
     
     // invoke OnBeforePluginFormDelete event
     $modx->invokeEvent('OnBeforePluginFormDelete', array('id'=> $id));

Braces +9 added lines, -4 removed lines

@@ -1,7 +1,9 @@ 
 <?php
-if(!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE != 'true') exit();
+if(!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE != 'true') {
+    exit();
+}
 
-if(!$modx->hasPermission('delete_plugin')) {	
+if(!$modx->hasPermission('delete_plugin')) {
 	$e->setError(3);
 	$e->dumpError();	
 }
@@ -23,7 +25,10 @@ 
 
     $id = $row['id'];
 
-    if(in_array($id,$latestIds)) continue;	// Keep latest version of disabled plugins 
+    if(in_array($id,$latestIds)) {
+        continue;
+    }
+    // Keep latest version of disabled plugins 
     
     // invoke OnBeforePluginFormDelete event
     $modx->invokeEvent('OnBeforePluginFormDelete', array('id'=> $id));
@@ -37,7 +42,7 @@ 
         if (!$modx->db->delete($tbl_site_plugin_events, "pluginid={$id}")) {
             echo "Something went wrong while trying to delete the plugin events for plugin {$id}";
             exit;
-        } else {		
+        } else {
             // invoke OnPluginFormDelete event
             $modx->invokeEvent('OnPluginFormDelete', array('id'=>$id));
         }

manager/processors/logout.processor.php

Indentation +8 added lines, -8 removed lines

@@ -7,10 +7,10 @@ 
 
 // invoke OnBeforeManagerLogout event
 $modx->invokeEvent("OnBeforeManagerLogout",
-						array(
-							"userid"		=> $internalKey,
-							"username"		=> $username
-						));
+                        array(
+                            "userid"		=> $internalKey,
+                            "username"		=> $username
+                        ));
 
 //// Unset all of the session variables.
 //$_SESSION = array();
@@ -33,10 +33,10 @@ 
 
 // invoke OnManagerLogout event
 $modx->invokeEvent("OnManagerLogout",
-						array(
-							"userid"		=> $internalKey,
-							"username"		=> $username
-						));
+                        array(
+                            "userid"		=> $internalKey,
+                            "username"		=> $username
+                        ));
 
 // show login screen
 header('Location: ' . MODX_MANAGER_URL);

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+if (IN_MANAGER_MODE != "true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 
 $internalKey = $modx->getLoginUserID();
 $username = $_SESSION['mgrShortname'];
@@ -39,4 +39,4 @@ 
 						));
 
 // show login screen
-header('Location: ' . MODX_MANAGER_URL);
+header('Location: '.MODX_MANAGER_URL);

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+if(IN_MANAGER_MODE!="true") {
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+}
 
 $internalKey = $modx->getLoginUserID();
 $username = $_SESSION['mgrShortname'];

manager/processors/save_htmlsnippet.processor.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 } elseif (empty($_POST['newcategory']) && $_POST['categoryid'] <= 0) {
     $categoryid = 0;
 } else {
-    include_once(MODX_MANAGER_PATH . 'includes/categories.inc.php');
+    include_once(MODX_MANAGER_PATH.'includes/categories.inc.php');
     $categoryid = checkCategory($_POST['newcategory']);
     if (!$categoryid) {
         $categoryid = newCategory($_POST['newcategory']);
@@ -80,7 +80,7 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "78&id=$newid" : "77";
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
+            $header = "Location: index.php?a=".$a."&r=2&stay=".$_POST['stay'];
             header($header);
         } else {
             $header = "Location: index.php?a=76&r=2";
@@ -129,7 +129,7 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "78&id=$id" : "77";
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
+            $header = "Location: index.php?a=".$a."&r=2&stay=".$_POST['stay'];
             header($header);
         } else {
             $modx->unlockElement(3, $id);

manager/processors/remove_content.processor.php

Indentation +14 added lines, -14 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 if(!$modx->hasPermission('delete_document')) {
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
 $rs = $modx->db->select('id', $modx->getFullTableName('site_content'), "deleted=1");
@@ -9,9 +9,9 @@ 
 
 // invoke OnBeforeEmptyTrash event
 $modx->invokeEvent("OnBeforeEmptyTrash",
-						array(
-							"ids"=>$ids
-						));
+                        array(
+                            "ids"=>$ids
+                        ));
 
 // remove the document groups link.
 $sql = "DELETE document_groups
@@ -30,15 +30,15 @@ 
 //'undelete' the document.
 $modx->db->delete($modx->getFullTableName('site_content'), "deleted=1");
 
-	// invoke OnEmptyTrash event
-	$modx->invokeEvent("OnEmptyTrash",
-						array(
-							"ids"=>$ids
-						));
+    // invoke OnEmptyTrash event
+    $modx->invokeEvent("OnEmptyTrash",
+                        array(
+                            "ids"=>$ids
+                        ));
 
-	// empty cache
-	$modx->clearCache('full');
+    // empty cache
+    $modx->clearCache('full');
 
-	// finished emptying cache - redirect
-	$header="Location: index.php?a=2&r=1";
-	header($header);
+    // finished emptying cache - redirect
+    $header="Location: index.php?a=2&r=1";
+    header($header);

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
-if(!$modx->hasPermission('delete_document')) {
+if (IN_MANAGER_MODE != "true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+if (!$modx->hasPermission('delete_document')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
@@ -40,5 +40,5 @@ 
 	$modx->clearCache('full');
 
 	// finished emptying cache - redirect
-	$header="Location: index.php?a=2&r=1";
+	$header = "Location: index.php?a=2&r=1";
 	header($header);

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+if(IN_MANAGER_MODE!="true") {
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
+}
 if(!$modx->hasPermission('delete_document')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }

manager/processors/save_plugin.processor.php

Spacing +13 added lines, -13 removed lines

@@ -24,7 +24,7 @@ 
 } elseif (empty($_POST['newcategory']) && $_POST['categoryid'] <= 0) {
     $categoryid = 0;
 } else {
-    include_once(MODX_MANAGER_PATH . 'includes/categories.inc.php');
+    include_once(MODX_MANAGER_PATH.'includes/categories.inc.php');
     $categoryid = getCategory($_POST['newcategory']);
 }
 
@@ -40,12 +40,12 @@ 
     $moduleguid = isset($parsed['guid']) ? $parsed['guid'] : $moduleguid;
 
     $description = isset($parsed['description']) ? $parsed['description'] : $description;
-    $version = isset($parsed['version']) ? '<b>' . $parsed['version'] . '</b> ' : '';
+    $version = isset($parsed['version']) ? '<b>'.$parsed['version'].'</b> ' : '';
     if ($version) {
-        $description = $version . trim(preg_replace('/(<b>.+?)+(<\/b>)/i', '', $description));
+        $description = $version.trim(preg_replace('/(<b>.+?)+(<\/b>)/i', '', $description));
     }
     if (isset($parsed['modx_category'])) {
-        include_once(MODX_MANAGER_PATH . 'includes/categories.inc.php');
+        include_once(MODX_MANAGER_PATH.'includes/categories.inc.php');
         $categoryid = getCategory($parsed['modx_category']);
     }
 }
@@ -103,7 +103,7 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "102&id=$newid" : '101';
-            $header = 'Location: index.php?a=' . $a . '&r=2&stay=' . $_POST['stay'];
+            $header = 'Location: index.php?a='.$a.'&r=2&stay='.$_POST['stay'];
             header($header);
         } else {
             $header = 'Location: index.php?a=76&r=2';
@@ -158,7 +158,7 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "102&id=$id" : '101';
-            $header = 'Location: index.php?a=' . $a . '&r=2&stay=' . $_POST['stay'];
+            $header = 'Location: index.php?a='.$a.'&r=2&stay='.$_POST['stay'];
             header($header);
         } else {
             $modx->unlockElement(5, $id);
@@ -177,7 +177,7 @@ 
     // save selected system events
     $formEventList = array();
     foreach ($sysevents as $evtId) {
-        if(!preg_match('@^[1-9][0-9]*$@',$evtId)) $evtId = getEventIdByName($evtId);
+        if (!preg_match('@^[1-9][0-9]*$@', $evtId)) $evtId = getEventIdByName($evtId);
         if ($mode == '101') {
             $rs = $modx->db->select('max(priority) as priority', '[+prefix+]site_plugin_events', "evtid='{$evtId}'");
         } else {
@@ -202,13 +202,13 @@ 
     $rs = $modx->db->select('*', '[+prefix+]site_plugin_events', sprintf("pluginid='%s'", $id));
     $dbEventList = array();
     $del = array();
-    while($row = $modx->db->getRow($rs)) {
-        if(!in_array($row['evtid'], $evtids)) $del[] = $row['evtid'];
+    while ($row = $modx->db->getRow($rs)) {
+        if (!in_array($row['evtid'], $evtids)) $del[] = $row['evtid'];
     }
     
-    if(!$del) return;
+    if (!$del) return;
     
-    foreach($del as $delid) {
+    foreach ($del as $delid) {
         $modx->db->delete('[+prefix+]site_plugin_events', sprintf("evtid='%s' AND pluginid='%s'", $delid, $id));
     }
 }
@@ -216,9 +216,9 @@ 
 function getEventIdByName($name)
 {
     global $modx;
-    static $eventIds=array();
+    static $eventIds = array();
     
-    if(isset($eventIds[$name])) return $eventIds[$name];
+    if (isset($eventIds[$name])) return $eventIds[$name];
     
     $rs = $modx->db->select('id, name', '[+prefix+]system_eventnames');
     while ($row = $modx->db->getRow($rs)) {

Braces +12 added lines, -4 removed lines

@@ -177,7 +177,9 @@ 
     // save selected system events
     $formEventList = array();
     foreach ($sysevents as $evtId) {
-        if(!preg_match('@^[1-9][0-9]*$@',$evtId)) $evtId = getEventIdByName($evtId);
+        if(!preg_match('@^[1-9][0-9]*$@',$evtId)) {
+            $evtId = getEventIdByName($evtId);
+        }
         if ($mode == '101') {
             $rs = $modx->db->select('max(priority) as priority', '[+prefix+]site_plugin_events', "evtid='{$evtId}'");
         } else {
@@ -203,10 +205,14 @@ 
     $dbEventList = array();
     $del = array();
     while($row = $modx->db->getRow($rs)) {
-        if(!in_array($row['evtid'], $evtids)) $del[] = $row['evtid'];
+        if(!in_array($row['evtid'], $evtids)) {
+            $del[] = $row['evtid'];
+        }
     }
     
-    if(!$del) return;
+    if(!$del) {
+        return;
+    }
     
     foreach($del as $delid) {
         $modx->db->delete('[+prefix+]site_plugin_events', sprintf("evtid='%s' AND pluginid='%s'", $delid, $id));
@@ -218,7 +224,9 @@ 
     global $modx;
     static $eventIds=array();
     
-    if(isset($eventIds[$name])) return $eventIds[$name];
+    if(isset($eventIds[$name])) {
+        return $eventIds[$name];
+    }
     
     $rs = $modx->db->select('id, name', '[+prefix+]system_eventnames');
     while ($row = $modx->db->getRow($rs)) {

manager/processors/save_tmplvars.processor.php

Spacing +4 added lines, -4 removed lines

@@ -27,7 +27,7 @@ 
 } elseif (empty($_POST['newcategory']) && $_POST['categoryid'] <= 0) {
     $categoryid = 0;
 } else {
-    include_once(MODX_MANAGER_PATH . 'includes/categories.inc.php');
+    include_once(MODX_MANAGER_PATH.'includes/categories.inc.php');
     $categoryid = checkCategory($_POST['newcategory']);
     if (!$categoryid) {
         $categoryid = newCategory($_POST['newcategory']);
@@ -99,7 +99,7 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "301&id=$newid" : "300";
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
+            $header = "Location: index.php?a=".$a."&r=2&stay=".$_POST['stay'];
             header($header);
         } else {
             $header = "Location: index.php?a=76&r=2";
@@ -160,11 +160,11 @@ 
         // finished emptying cache - redirect
         if ($_POST['stay'] != '') {
             $a = ($_POST['stay'] == '2') ? "301&id=$id" : "300";
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'] . "&or=" . $origin . "&oid=" . $originId;
+            $header = "Location: index.php?a=".$a."&r=2&stay=".$_POST['stay']."&or=".$origin."&oid=".$originId;
             header($header);
         } else {
             $modx->unlockElement(2, $id);
-            $header = "Location: index.php?a=" . $origin . "&r=2" . ($originId != null ? '&id=' . $originId : '');
+            $header = "Location: index.php?a=".$origin."&r=2".($originId != null ? '&id='.$originId : '');
             header($header);
         }