Completed
Pull Request — develop (#713)
by
unknown
08:07
created
manager/includes/extenders/modifiers.class.inc.php 1 patch
Doc Comments   +27 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     /**
95 95
      * @param string $mode
96 96
      * @param string $modifiers
97
-     * @return bool|string
97
+     * @return false|string
98 98
      */
99 99
     public function _getDelim($mode,$modifiers) {
100 100
         $c = substr($modifiers,0,1);
@@ -131,6 +131,14 @@  discard block
 block discarded – undo
131 131
             return $opt;
132 132
         }
133 133
     }
134
+
135
+    /**
136
+     * @param string $mode
137
+     * @param false|string $delim
138
+     * @param string $modifiers
139
+     *
140
+     * @return string
141
+     */
134 142
     public function _getRemainModifiers($mode,$delim,$modifiers) {
135 143
         if($delim) {
136 144
             if($mode=='(')
@@ -158,6 +166,9 @@  discard block
 block discarded – undo
158 166
         return substr($string,strpos($string, $delim)+$len);
159 167
     }
160 168
 
169
+    /**
170
+     * @param string $modifiers
171
+     */
161 172
     public function splitEachModifiers($modifiers) {
162 173
         $modx = evolutionCMS();
163 174
 
@@ -227,6 +238,10 @@  discard block
 block discarded – undo
227 238
         return $result;
228 239
     }
229 240
 
241
+    /**
242
+     * @param string $key
243
+     * @param string $value
244
+     */
230 245
     public function parsePhx($key,$value,$modifiers)
231 246
     {
232 247
         $modx = evolutionCMS();
@@ -293,6 +308,10 @@  discard block
 block discarded – undo
293 308
         else                  return true;
294 309
     }
295 310
 
311
+    /**
312
+     * @param string $cmd
313
+     * @param string $opt
314
+     */
296 315
     public function getValueFromPreset($key, $value, $cmd, $opt)
297 316
     {
298 317
         $modx = evolutionCMS();
@@ -978,6 +997,9 @@  discard block
 block discarded – undo
978 997
         return $value;
979 998
     }
980 999
 
1000
+    /**
1001
+     * @param string $cmd
1002
+     */
981 1003
     public function includeMdfFile($cmd) {
982 1004
         $modx = evolutionCMS();
983 1005
         $key = $this->key;
@@ -1133,6 +1155,10 @@  discard block
 block discarded – undo
1133 1155
     }
1134 1156
 
1135 1157
     // Sets a placeholder variable which can only be access by Modifiers
1158
+
1159
+    /**
1160
+     * @param string $value
1161
+     */
1136 1162
     public function setModifiersVariable($key, $value) {
1137 1163
         if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1138 1164
     }
Please login to merge, or discard this patch.
install/cli-install.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
      * duplicate of method in documentParser class
131 131
      *
132 132
      * @param string $propertyString
133
-     * @return array
133
+     * @return string
134 134
      */
135 135
     function parseProperties($propertyString) {
136 136
         $parameter= array ();
Please login to merge, or discard this patch.
manager/includes/document.parser.class.inc.php 1 patch
Doc Comments   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
      * MODX_MANAGER_PATH."includes/extenders/ex_{$extname}.inc.php"
277 277
      * $extname - extension name in lowercase
278 278
      *
279
-     * @param $extname
279
+     * @param string $extname
280 280
      * @param bool $reload
281 281
      * @return bool
282 282
      */
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
      * @param int $count_attempts
320 320
      * @param string $type $type
321 321
      * @param string $responseCode
322
-     * @return bool|null
322
+     * @return false|null
323 323
      * @global string $base_url
324 324
      * @global string $site_url
325 325
      */
@@ -1021,7 +1021,7 @@  discard block
 block discarded – undo
1021 1021
     }
1022 1022
 
1023 1023
     /**
1024
-     * @param $contents
1024
+     * @param string $contents
1025 1025
      * @return mixed
1026 1026
      */
1027 1027
     public function RecoveryEscapedTags($contents)
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
     }
1046 1046
 
1047 1047
     /**
1048
-     * @param $tstart
1048
+     * @param double $tstart
1049 1049
      * @return array
1050 1050
      */
1051 1051
     public function getTimerStats($tstart)
@@ -1813,7 +1813,7 @@  discard block
 block discarded – undo
1813 1813
 
1814 1814
     /**
1815 1815
      * Remove Comment-Tags from output like <!--@- Comment -@-->
1816
-     * @param $content
1816
+     * @param string $content
1817 1817
      * @param string $left
1818 1818
      * @param string $right
1819 1819
      * @return mixed
@@ -1986,7 +1986,7 @@  discard block
 block discarded – undo
1986 1986
     /**
1987 1987
      * Run snippets as per the tags in $documentSource and replace the tags with the returned values.
1988 1988
      *
1989
-     * @param $content
1989
+     * @param string $content
1990 1990
      * @return string
1991 1991
      * @internal param string $documentSource
1992 1992
      */
@@ -3023,7 +3023,7 @@  discard block
 block discarded – undo
3023 3023
 
3024 3024
     /**
3025 3025
      * @param $templateID
3026
-     * @return mixed
3026
+     * @return string
3027 3027
      */
3028 3028
     public function _getTemplateCodeFromDB($templateID)
3029 3029
     {
@@ -3066,7 +3066,7 @@  discard block
 block discarded – undo
3066 3066
     /**
3067 3067
      * @param $id
3068 3068
      * @param int $top
3069
-     * @return mixed
3069
+     * @return string
3070 3070
      */
3071 3071
     public function getUltimateParentId($id, $top = 0)
3072 3072
     {
@@ -3397,7 +3397,7 @@  discard block
 block discarded – undo
3397 3397
      *
3398 3398
      * @param int $type Types: 1=template, 2=tv, 3=chunk, 4=snippet, 5=plugin, 6=module, 7=resource, 8=role
3399 3399
      * @param int $id Element- / Resource-id
3400
-     * @return bool
3400
+     * @return false|null
3401 3401
      */
3402 3402
     public function lockElement($type, $id)
3403 3403
     {
@@ -3419,7 +3419,7 @@  discard block
 block discarded – undo
3419 3419
      * @param int $type Types: 1=template, 2=tv, 3=chunk, 4=snippet, 5=plugin, 6=module, 7=resource, 8=role
3420 3420
      * @param int $id Element- / Resource-id
3421 3421
      * @param bool $includeAllUsers true = Deletes not only own user-locks
3422
-     * @return bool
3422
+     * @return false|null
3423 3423
      */
3424 3424
     public function unlockElement($type, $id, $includeAllUsers = false)
3425 3425
     {
@@ -3527,7 +3527,7 @@  discard block
 block discarded – undo
3527 3527
      * @param array $params
3528 3528
      * @param string $msg
3529 3529
      * @param array $files
3530
-     * @return mixed
3530
+     * @return boolean
3531 3531
      */
3532 3532
     public function sendmail($params = array(), $msg = '', $files = array())
3533 3533
     {
@@ -3931,7 +3931,7 @@  discard block
 block discarded – undo
3931 3931
      *                     Default: 1
3932 3932
      * @param string $fields List of fields
3933 3933
      *                       Default: id, pagetitle, description, alias
3934
-     * @return boolean|array
3934
+     * @return string
3935 3935
      */
3936 3936
     public function getPageInfo($pageid = -1, $active = 1, $fields = 'id, pagetitle, description, alias')
3937 3937
     {
@@ -4023,7 +4023,7 @@  discard block
 block discarded – undo
4023 4023
      *
4024 4024
      * @param string $type
4025 4025
      * @param bool $report
4026
-     * @return bool
4026
+     * @return boolean|null
4027 4027
      */
4028 4028
     public function clearCache($type = '', $report = false)
4029 4029
     {
@@ -4390,7 +4390,7 @@  discard block
 block discarded – undo
4390 4390
      * - Placeholders prefix. Default: '{'.
4391 4391
      * @param string $suffix {string}
4392 4392
      * - Placeholders suffix. Default: '}'.
4393
-     * @return bool|mixed|string {string; false} - Parsed chunk or false if $chunkArr is not array.
4393
+     * @return false|string {string; false} - Parsed chunk or false if $chunkArr is not array.
4394 4394
      * - Parsed chunk or false if $chunkArr is not array.
4395 4395
      */
4396 4396
     public function parseChunk($chunkName, $chunkArr, $prefix = '{', $suffix = '}')
@@ -5366,7 +5366,7 @@  discard block
 block discarded – undo
5366 5366
      * Remove event listener - only for use within the current execution cycle
5367 5367
      *
5368 5368
      * @param string $evtName
5369
-     * @return boolean
5369
+     * @return false|null
5370 5370
      */
5371 5371
     public function removeEventListener($evtName)
5372 5372
     {
@@ -5390,7 +5390,7 @@  discard block
 block discarded – undo
5390 5390
      *
5391 5391
      * @param string $evtName
5392 5392
      * @param array $extParams Parameters available to plugins. Each array key will be the PHP variable name, and the array value will be the variable value.
5393
-     * @return boolean|array
5393
+     * @return false|null
5394 5394
      */
5395 5395
     public function invokeEvent($evtName, $extParams = array())
5396 5396
     {
@@ -5985,7 +5985,7 @@  discard block
 block discarded – undo
5985 5985
 
5986 5986
     /**
5987 5987
      * @param string $str
5988
-     * @return bool|mixed|string
5988
+     * @return string
5989 5989
      */
5990 5990
     public function atBindFileContent($str = '')
5991 5991
     {
@@ -6036,8 +6036,8 @@  discard block
 block discarded – undo
6036 6036
     }
6037 6037
 
6038 6038
     /**
6039
-     * @param $str
6040
-     * @return bool|string
6039
+     * @param string $str
6040
+     * @return false|string
6041 6041
      */
6042 6042
     public function getExtFromFilename($str)
6043 6043
     {
@@ -6065,7 +6065,7 @@  discard block
 block discarded – undo
6065 6065
      * @param string $text Error message
6066 6066
      * @param string $file File where the error was detected
6067 6067
      * @param string $line Line number within $file
6068
-     * @return boolean
6068
+     * @return boolean|null
6069 6069
      */
6070 6070
     public function phpError($nr, $text, $file, $line)
6071 6071
     {
@@ -6117,7 +6117,7 @@  discard block
 block discarded – undo
6117 6117
      * @param string $text
6118 6118
      * @param string $line
6119 6119
      * @param string $output
6120
-     * @return bool
6120
+     * @return null|boolean
6121 6121
      */
6122 6122
     public function messageQuit($msg = 'unspecified error', $query = '', $is_error = true, $nr = '', $file = '', $source = '', $text = '', $line = '', $output = '')
6123 6123
     {
@@ -6539,7 +6539,7 @@  discard block
 block discarded – undo
6539 6539
 
6540 6540
     /**
6541 6541
      * @param string $str
6542
-     * @return bool|mixed|string
6542
+     * @return string
6543 6543
      */
6544 6544
     public function atBindInclude($str = '')
6545 6545
     {
@@ -6590,7 +6590,7 @@  discard block
 block discarded – undo
6590 6590
      * @param $str
6591 6591
      * @param int $flags
6592 6592
      * @param string $encode
6593
-     * @return mixed
6593
+     * @return string
6594 6594
      */
6595 6595
     public function htmlspecialchars($str, $flags = ENT_COMPAT, $encode = '')
6596 6596
     {
@@ -6599,7 +6599,7 @@  discard block
 block discarded – undo
6599 6599
     }
6600 6600
 
6601 6601
     /**
6602
-     * @param $string
6602
+     * @param string $string
6603 6603
      * @param bool $returnData
6604 6604
      * @return bool|mixed
6605 6605
      */
@@ -6763,7 +6763,7 @@  discard block
 block discarded – undo
6763 6763
     }
6764 6764
 
6765 6765
     /**
6766
-     * @return mixed
6766
+     * @return string
6767 6767
      */
6768 6768
     public function getOutput()
6769 6769
     {
Please login to merge, or discard this patch.