Inspection of "fix undefined" - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( dba6d0...45e39e )

by Agel_Nash

created 2018-06-19 07:41 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
  * Message Quit Template
  *
  */
-if(( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) && IN_PARSER_MODE!="true") {
+if ((!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) && IN_PARSER_MODE != "true") {
     die("<b>INCLUDE ACCESS ERROR</b><br /><br />Direct access to this file prohibited.");
 }
 
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
 </script>
 </head><body>
 ";
-if($is_error) {
+if ($is_error) {
 	$parsedMessageString .= "<h3 style='color:red;background:#e0e0e0;padding:2px;'>&nbsp;MODX Parse Error </h3>
 	<table border='0' cellpadding='1' cellspacing='0'>
 	<tr><td colspan='3'>MODX encountered the following error while attempting to parse the requested resource:</td></tr>
@@ -32,14 +32,14 @@  discard block
 block discarded – undo
 	<tr><td colspan='3'><b style='color:#003399;'>&laquo; $msg &raquo;</b></td></tr>";
 }
 
-if(!empty($query)) {
+if (!empty($query)) {
 	$parsedMessageString .= "<tr><td colspan='3'><hr size='1' width='98%' style='color:#e0e0e0'/><b style='color:#999;font-size: 9px;border-left:1px solid #c0c0c0; margin-left:10px;'>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;SQL:&nbsp;<span id='sqlHolder'>$query</span></b><hr size='1' width='98%' style='color:#e0e0e0'/>
 	&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href='javascript:copyToClip();' style='color:#821517;font-size: 9px; text-decoration: none'>[Copy SQL to ClipBoard]</a><textarea id='holdtext' style='display:none;'></textarea></td></tr>";
 }
 
-if($text!='') {
+if ($text != '') {
 
-	$errortype = array (
+	$errortype = array(
 		E_ERROR          => "Error",
 		E_WARNING        => "Warning",
 		E_PARSE          => "Parsing Error",
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
 	$parsedMessageString .= "<tr><td>&nbsp;&nbsp;Line: </td>";
 	$parsedMessageString .= "<td colspan='2'>$line</td><td>&nbsp;</td>";
 	$parsedMessageString .= "</tr>";
-	if($source!='') {
+	if ($source != '') {
 		$parsedMessageString .= "<tr><td valign='top'>&nbsp;&nbsp;Line $line source: </td>";
 		$parsedMessageString .= "<td colspan='2'>$source</td><td>&nbsp;</td>";
 		$parsedMessageString .= "</tr>";

Please login to merge, or discard this patch.

manager/includes/debug.inc.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@  discard block
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 
 // show debug information
-if(isset($enable_debug) && $enable_debug==true) {
+if (isset($enable_debug) && $enable_debug == true) {
 	?>
 	<script language="javascript">
 	//document.onload = removeDebug();
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
 	}
 	</style>
 	<?php
-	$mtime = microtime(); $mtime = explode(" ",$mtime); $mtime = $mtime[1] + $mtime[0]; $tend = $mtime; $totaltime = ($tend - $tstart);
+	$mtime = microtime(); $mtime = explode(" ", $mtime); $mtime = $mtime[1] + $mtime[0]; $tend = $mtime; $totaltime = ($tend - $tstart);
 	?>
 	<div class='debug' id='debug' name='debug' onClick="removeDebugDiv();">
 		<table border="0" cellspacing="0" cellpadding="0">
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 		  </tr>
 		  <tr>
 			<td width="70">Time taken</td>
-			<td width="80"><?php echo printf ("%6.5f s", $totaltime); ?></td>
+			<td width="80"><?php echo printf("%6.5f s", $totaltime); ?></td>
 		  </tr>
 		</table>
 	</div>

Please login to merge, or discard this patch.

manager/processors/logout.processor.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-if( ! defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
	2	+if (!defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
3	3	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4	4	}
5	5
		@@ -41,4 +41,4 @@ discard block
		block discarded – undo
41	41	));
42	42
43	43	// show login screen
44		-header('Location: ' . MODX_MANAGER_URL);
	44	+header('Location: '.MODX_MANAGER_URL);

Please login to merge, or discard this patch.

manager/processors/remove_content.processor.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,8 +1,8 @@  discard block
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
-if(!$modx->hasPermission('delete_document')) {
+if (!$modx->hasPermission('delete_document')) {
 	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
 }
 
@@ -42,5 +42,5 @@  discard block
 block discarded – undo
 	$modx->clearCache('full');
 
 	// finished emptying cache - redirect
-	$header="Location: index.php?a=2&r=1";
+	$header = "Location: index.php?a=2&r=1";
 	header($header);

Please login to merge, or discard this patch.

manager/actions/help/version_notices/1.2.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 ?>

Please login to merge, or discard this patch.

manager/actions/help/version_notices/1.3.4.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 ?>

Please login to merge, or discard this patch.

manager/actions/help/version_notices/1.2.1.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 ?>

Please login to merge, or discard this patch.

manager/actions/help/version_notices/1.1.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 ?>

Please login to merge, or discard this patch.

manager/actions/help/version_notices/1.1.1.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 ?>

Please login to merge, or discard this patch.

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	* Message Quit Template
4	4	*
5	5	*/
6		-if(( ! defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) && IN_PARSER_MODE!="true") {
	6	+if ((!defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) && IN_PARSER_MODE != "true") {
7	7	die("<b>INCLUDE ACCESS ERROR</b><br /><br />Direct access to this file prohibited.");
8	8	}
9	9
		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	</script>
21	21	</head><body>
22	22	";
23		-if($is_error) {
	23	+if ($is_error) {
24	24	$parsedMessageString .= "<h3 style='color:red;background:#e0e0e0;padding:2px;'> MODX Parse Error </h3>
25	25	<table border='0' cellpadding='1' cellspacing='0'>
26	26	<tr><td colspan='3'>MODX encountered the following error while attempting to parse the requested resource:</td></tr>
		@@ -32,14 +32,14 @@ discard block
		block discarded – undo
32	32	<tr><td colspan='3'><b style='color:#003399;'>« $msg »</b></td></tr>";
33	33	}
34	34
35		-if(!empty($query)) {
	35	+if (!empty($query)) {
36	36	$parsedMessageString .= "<tr><td colspan='3'><hr size='1' width='98%' style='color:#e0e0e0'/><b style='color:#999;font-size: 9px;border-left:1px solid #c0c0c0; margin-left:10px;'>      SQL: <span id='sqlHolder'>$query</span></b><hr size='1' width='98%' style='color:#e0e0e0'/>
37	37	<a href='javascript:copyToClip();' style='color:#821517;font-size: 9px; text-decoration: none'>[Copy SQL to ClipBoard]</a><textarea id='holdtext' style='display:none;'></textarea></td></tr>";
38	38	}
39	39
40		-if($text!='') {
	40	+if ($text != '') {
41	41
42		- $errortype = array (
	42	+ $errortype = array(
43	43	E_ERROR => "Error",
44	44	E_WARNING => "Warning",
45	45	E_PARSE => "Parsing Error",
		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70	$parsedMessageString .= "<tr><td>  Line: </td>";
71	71	$parsedMessageString .= "<td colspan='2'>$line</td><td> </td>";
72	72	$parsedMessageString .= "</tr>";
73		- if($source!='') {
	73	+ if ($source != '') {
74	74	$parsedMessageString .= "<tr><td valign='top'>  Line $line source: </td>";
75	75	$parsedMessageString .= "<td colspan='2'>$source</td><td> </td>";
76	76	$parsedMessageString .= "</tr>";

		@@ -1,10 +1,10 @@ discard block
		block discarded – undo
1	1	<?php
2		-if( ! defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
	2	+if (!defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
3	3	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4	4	}
5	5
6	6	// show debug information
7		-if(isset($enable_debug) && $enable_debug==true) {
	7	+if (isset($enable_debug) && $enable_debug == true) {
8	8	?>
9	9	<script language="javascript">
10	10	//document.onload = removeDebug();
		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35	}
36	36	</style>
37	37	<?php
38		- $mtime = microtime(); $mtime = explode(" ",$mtime); $mtime = $mtime[1] + $mtime[0]; $tend = $mtime; $totaltime = ($tend - $tstart);
	38	+ $mtime = microtime(); $mtime = explode(" ", $mtime); $mtime = $mtime[1] + $mtime[0]; $tend = $mtime; $totaltime = ($tend - $tstart);
39	39	?>
40	40	<div class='debug' id='debug' name='debug' onClick="removeDebugDiv();">
41	41	<table border="0" cellspacing="0" cellpadding="0">
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	</tr>
45	45	<tr>
46	46	<td width="70">Time taken</td>
47		- <td width="80"><?php echo printf ("%6.5f s", $totaltime); ?></td>
	47	+ <td width="80"><?php echo printf("%6.5f s", $totaltime); ?></td>
48	48	</tr>
49	49	</table>
50	50	</div>

		@@ -1,8 +1,8 @@ discard block
		block discarded – undo
1	1	<?php
2		-if( ! defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
	2	+if (!defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
3	3	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4	4	}
5		-if(!$modx->hasPermission('delete_document')) {
	5	+if (!$modx->hasPermission('delete_document')) {
6	6	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
7	7	}
8	8
		@@ -42,5 +42,5 @@ discard block
		block discarded – undo
42	42	$modx->clearCache('full');
43	43
44	44	// finished emptying cache - redirect
45		- $header="Location: index.php?a=2&r=1";
	45	+ $header = "Location: index.php?a=2&r=1";
46	46	header($header);

		@@ -1,5 +1,5 @@
		block discarded – undo
1	1	<?php
2		-if( ! defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
	2	+if (!defined('IN_MANAGER_MODE') \|\| IN_MANAGER_MODE !== true) {
3	3	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4	4	}
5	5	?>

evolution-cms / evolution

Push — develop ( dba6d0...45e39e )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch