evolution-cms / evolution

manager/includes/src/Interfaces/ManagerThemeInterface.php

Braces +3 added lines, -1 removed lines

@@ -1,3 +1,5 @@
 <?php namespace EvolutionCMS\Interfaces;
 
-interface ManagerThemeInterface{}
+interface ManagerThemeInterface
+{
+}

manager/media/style/default/style.php

Braces +15 added lines, -15 removed lines

@@ -10,12 +10,12 @@ 
  */

 $style_path = 'media/style/' . $modx->config['manager_theme'] . '/images/';

 $modx->config['mgr_date_picker_path'] = 'media/calendar/datepicker.inc.php';

-if(!$modx->config['lang_code']) {

+if(!$modx->config['lang_code']) {
 	global $modx_lang_attribute;

 	$modx->config['lang_code'] = !$modx_lang_attribute ? 'en' : $modx_lang_attribute;

 }

 

-if(!empty($_GET['a']) && $_GET['a'] == 2) {

+if(!empty($_GET['a']) && $_GET['a'] == 2) {
 	include_once('welcome.php');

 }

 

@@ -262,68 +262,68 @@ 
 

 // actions buttons templates

 $action = isset($_REQUEST['a']) ? $_REQUEST['a'] : '';

-if (!empty($modx->config['global_tabs']) && !isset($_SESSION['stay'])) {

+if (!empty($modx->config['global_tabs']) && !isset($_SESSION['stay'])) {
     $_REQUEST['stay'] = 2;

 }

-if (isset($_REQUEST['stay'])) {

+if (isset($_REQUEST['stay'])) {
     $_SESSION['stay'] = $_REQUEST['stay'];

-} else if (isset($_SESSION['stay'])) {

+} else if (isset($_SESSION['stay'])) {
     $_REQUEST['stay'] = $_SESSION['stay'];

 }

 $stay = isset($_REQUEST['stay']) ? $_REQUEST['stay'] : '';

 $addnew = 0;

 $run = 0;

-switch($action) {

+switch($action) {
 	case '3':

 	case '4':

 	case '27':

 	case '72':

-		if($modx->hasPermission('new_document')) {

+		if($modx->hasPermission('new_document')) {
 			$addnew = 1;

 		}

 		break;

 	case '16':

 	case '19':

-		if($modx->hasPermission('new_template')) {

+		if($modx->hasPermission('new_template')) {
 			$addnew = 1;

 		}

 		break;

 	case '300':

 	case '301':

-		if($modx->hasPermission('new_snippet') && $modx->hasPermission('new_chunk') && $modx->hasPermission('new_plugin')) {

+		if($modx->hasPermission('new_snippet') && $modx->hasPermission('new_chunk') && $modx->hasPermission('new_plugin')) {
 			$addnew = 1;

 		}

 		break;

 	case '77':

 	case '78':

-		if($modx->hasPermission('new_chunk')) {

+		if($modx->hasPermission('new_chunk')) {
 			$addnew = 1;

 		}

 		break;

 	case '22':

 	case '23':

-		if($modx->hasPermission('new_snippet')) {

+		if($modx->hasPermission('new_snippet')) {
 			$addnew = 1;

 		}

 		break;

 	case '101':

 	case '102':

-		if($modx->hasPermission('new_plugin')) {

+		if($modx->hasPermission('new_plugin')) {
 			$addnew = 1;

 		}

 		break;

 	case '106':

 	case '107':

 	case '108':

-		if($modx->hasPermission('new_module')) {

+		if($modx->hasPermission('new_module')) {
 			$addnew = 1;

 		}

-		if($modx->hasPermission('exec_module')) {

+		if($modx->hasPermission('exec_module')) {
 			$run = 1;

 		}

 		break;

 	case '88':

-		if($modx->hasPermission('new_web_user')) {

+		if($modx->hasPermission('new_web_user')) {
 			$addnew = 1;

 		}

 		break;

install/src/template/actions/install.php

Braces +80 added lines, -32 removed lines

@@ -16,7 +16,8 @@ 
         <span class="notok"><?=$_lang['setup_database_create_connection_failed']?></span>
     </p>
     <p><?=$_lang['setup_database_create_connection_failed_note']?></p>
-<?php else : ?>
+<?php else {
+    : ?>
     <p><?=$_lang['setup_database_create_connection']?> <span class="ok"><?=$_lang['ok']?></span></p>
     <?php if ($selectDatabase === false) : ?>
         <p><?=rtrim($_lang['setup_database_selection'], '`')?> <strong><?=trim($dbase, '`')?></strong>:
@@ -41,13 +42,18 @@ 
                 <?=rtrim($_lang['setup_database_creation'], '`')?> <strong><?=trim($dbase, '`')?></strong>:
                 <span class="ok"><?=$_lang['ok']?></span>
             </p>
-        <?php endif; ?>
-    <?php else : ?>
+        <?php endif;
+}
+?>
+    <?php else {
+    : ?>
         <p>
             <?=rtrim($_lang['setup_database_selection'], '`')?> <strong><?=trim($dbase, '`')?></strong>:
             <span class="ok"><?=$_lang['ok']?></span>
         </p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 <?php endif; ?>
 
 <?php if ($installLevel >= 1) : ?>
@@ -57,12 +63,15 @@ 
             <span class="notok"><?=$_lang['failed']?></span> <?=$_lang['table_prefix_already_inuse']?>
         </p>
         <p><?=$_lang['table_prefix_already_inuse_note']?></p>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <p>
             <?=rtrim($_lang['checking_table_prefix'], '`')?> <strong><?=trim($table_prefix, '`')?></strong>:
             <span class="ok"><?=$_lang['ok']?></span>
         </p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 <?php endif; ?>
 
 <?php if ($installLevel >=  2 && $moduleSQLBaseFile) : ?>
@@ -81,9 +90,12 @@ 
             <hr />
         <?php endfor; ?>
         <p><?=$_lang['some_tables_not_updated']?></p>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <p><?=$_lang['setup_database_creating_tables']?> <span class="ok"><?=$_lang['ok']?></span></p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 <?php endif; ?>
 
 <?php if ($installLevel >= 3) : ?>
@@ -94,11 +106,14 @@ 
         <p><?=$_lang['cant_write_config_file']?> <span class="mono"><?=MGR_DIR?>/includes/config.inc.php</span></p>
         <textarea style="width:400px; height:160px;"><?=$configString?></textarea>
         <p><?=$_lang['cant_write_config_file_note']?></p>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <p>
             <?=$_lang['writing_config_file']?> <span class="ok"><?=$_lang['ok']?></span>
         </p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 <?php endif; ?>
 
 <?php if ($installLevel >= 4 && $installData && $moduleSQLDataFile && $moduleSQLResetFile) : ?>
@@ -117,12 +132,15 @@ 
         <?php endfor; ?>
         </p>
         <p><?=$_lang['some_tables_not_updated']?></p>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <p>
             <?=$_lang['resetting_database']?>
             <span class="ok"><?=$_lang['ok']?></span>
         </p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 <?php endif; ?>
 
 <?php if ($installLevel >= 5) : ?>
@@ -135,7 +153,8 @@ 
                 <?php elseif($itemData['type'] === 'update') : ?>
                     <p>&nbsp;&nbsp;&#10003;&nbsp;&nbsp;<?=$itemName?>: <span class="ok"><?=$_lang['upgraded']?></span></p>
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
                 <?php elseif ($itemData['error']['type'] === 'file_not_found') : ?>
@@ -145,7 +164,9 @@ 
                             <?=$_lang['not_found']?>.
                         </span>
                     </p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -161,10 +182,13 @@ 
                 <?php elseif($itemData['type'] === 'skip') : ?>
                     <!-- SKIP -->
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -182,7 +206,8 @@ 
                 <?php elseif($itemData['type'] === 'skip') : ?>
                     <!-- SKIP -->
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
                 <?php elseif ($itemData['error']['type'] === 'file_not_found') : ?>
@@ -192,7 +217,9 @@ 
                             <?=$_lang['not_found']?>.
                         </span>
                     </p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -208,7 +235,8 @@ 
                 <?php elseif($itemData['type'] === 'skip') : ?>
                     <!-- SKIP -->
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
                 <?php elseif ($itemData['error']['type'] === 'file_not_found') : ?>
@@ -218,7 +246,9 @@ 
                             <?=$_lang['not_found']?>.
                         </span>
                     </p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -234,7 +264,8 @@ 
                 <?php elseif($itemData['type'] === 'skip') : ?>
                     <!-- SKIP -->
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
                 <?php elseif ($itemData['error']['type'] === 'file_not_found') : ?>
@@ -244,7 +275,9 @@ 
                             <?=$_lang['not_found']?>.
                         </span>
                     </p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -262,7 +295,8 @@ 
                 <?php elseif($itemData['type'] === 'skip') : ?>
                     <!-- SKIP -->
                 <?php endif; ?>
-            <?php else : ?>
+            <?php else {
+    : ?>
                 <?php if ($itemData['error']['type'] === 'sql') : ?>
                     <p>&#10060; <?=$itemData['error']['content']?></p>
                 <?php elseif ($itemData['error']['type'] === 'file_not_found') : ?>
@@ -272,7 +306,9 @@ 
                             <?=$_lang['not_found']?>.
                         </span>
                     </p>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <?php endforeach; ?>
     <?php endif; ?>
@@ -281,7 +317,8 @@ 
         <h3><?=$_lang['installing_demo_site']?></h3>
         <?php if (empty($installDataLevel['demo']['error'])) : ?>
             <p>&nbsp;&nbsp;&#10003;&nbsp;&nbsp<span class="ok"><?=$_lang['ok']?></span></p>
-        <?php else : ?>
+        <?php else {
+    : ?>
             <p><span class="notok"><b><?=$_lang['database_alerts']?></span></p>
             <p><?=$_lang['setup_couldnt_install']?></p>
             <p><?=$_lang['installation_error_occured']?></p>
@@ -291,7 +328,9 @@ 
                 <?=$_lang['during_execution_of_sql']?>
                 <span class="mono"><?=htmlspecialchars($error['sql'])?></span>
                 <hr />
-            <?php endforeach; ?>
+            <?php endforeach;
+}
+?>
             <p><?=$_lang['some_tables_not_updated']?></p>
         <?php endif; ?>
     <?php endif; ?>
@@ -316,10 +355,13 @@ 
                     <span class="ok"><?=$_lang['guid_set']?></span>
                 </p>
             <?php endif; ?>
-        <?php else : ?>
+        <?php else {
+    : ?>
             <?php if ($itemData['error']['type'] === 'sql') : ?>
                 <p>&#10060; <?=$itemData['error']['content']?></p>
-            <?php endif; ?>
+            <?php endif;
+}
+?>
         <?php endif; ?>
     <?php endforeach; ?>
 <?php endif; ?>
@@ -332,12 +374,15 @@ 
             <img src="img/ico_info.png" width="40" height="42" align="left" style="margin-right:10px;" />
             <?=$_lang['installation_note']?>
         </p>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <p>
             <img src="img/ico_info.png" width="40" height="42" align="left" style="margin-right:10px;" />
             <?=$_lang['upgrade_note']?>
         </p>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
 
     <form name="install" id="install_form" action="index.php?action=options" method="post">
             <?php if ($errors === 0) : ?>
@@ -350,11 +395,14 @@ 
                       />
                         <?=$_lang['remove_install_folder_auto'] ?>
                 </span>
-                <?php else : ?>
+                <?php else {
+    : ?>
                     <span id="removeinstall" style="float:left;color:#505050;line-height:18px;">
                     <?=$_lang['remove_install_folder_manual'] ?>
                 </span>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             <?php endif; ?>
         <p class="buttonlinks">
             <a href="javascript:closepage();" title="<?=$_lang['btnclose_value'] ?>">

manager/includes/manager.lockout.inc.php

Braces +8 added lines, -13 removed lines

@@ -3,7 +3,7 @@ 
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
 }
 
-if($modx->getManagerApi()->action!='8' && isset($_SESSION['mgrValidated'])){
+if($modx->getManagerApi()->action!='8' && isset($_SESSION['mgrValidated'])) {
 
     $homeurl = $modx->makeUrl($manager_login_startup>0 ? $manager_login_startup:$site_start);
     $logouturl = MODX_MANAGER_URL.'index.php?a=8';
@@ -35,8 +35,7 @@ 
     	if(substr($target,0,6)==='@CHUNK') {
     		$target = trim(substr($target,7));
     		$lockout_tpl = $modx->getChunk($target);
-    	}
-    	elseif(substr($target,0,5)==='@FILE') {
+    	} elseif(substr($target,0,5)==='@FILE') {
     		$target = trim(substr($target,6));
     		$lockout_tpl = file_get_contents($target);
     	}
@@ -44,24 +43,20 @@ 
     	$chunk = $modx->getChunk($target);
     	if($chunk!==false && !empty($chunk)) {
     		$lockout_tpl = $chunk;
-    	}
-    	elseif(is_file(MODX_BASE_PATH . $target)) {
+    	} elseif(is_file(MODX_BASE_PATH . $target)) {
     		$target = MODX_BASE_PATH . $target;
     		$lockout_tpl = file_get_contents($target);
-    	}
-    	elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/manager.lockout.tpl')) {
+    	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/manager.lockout.tpl')) {
     		$target = MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/manager.lockout.tpl';
     		$lockout_tpl = file_get_contents($target);
-    	}
-	elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/templates/actions/manager.lockout.tpl')) {
+    	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/templates/actions/manager.lockout.tpl')) {
 		$target = MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/templates/actions/manager.lockout.tpl';
 		$login_tpl = file_get_contents($target);
-	}
-    	elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/manager.lockout.html')) { // ClipperCMS compatible
+	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/manager.lockout.html')) {
+// ClipperCMS compatible
     		$target = MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/manager.lockout.html';
     		$lockout_tpl = file_get_contents($target);
-    	}
-    	else {
+    	} else {
     		$target = MODX_MANAGER_PATH . 'media/style/common/manager.lockout.tpl';
     		$lockout_tpl = file_get_contents($target);
     	}

manager/includes/config_check.inc.php

Braces +22 added lines, -9 removed lines

@@ -19,12 +19,12 @@ 
 $warningspresent = 0;
 
 $sysfiles_check = $modx->getManagerApi()->checkSystemChecksum();
-if ($sysfiles_check!=='0'){
+if ($sysfiles_check!=='0') {
       $warningspresent = 1;
       $warnings[] = array($_lang['configcheck_sysfiles_mod']);
 }
 
-if (is_writable("includes/config.inc.php")){
+if (is_writable("includes/config.inc.php")) {
     // Warn if world writable
     if(@fileperms('includes/config.inc.php') & 0x0002) {
       $warningspresent = 1;
@@ -120,7 +120,8 @@ 
     /**
      * @return bool
      */
-    function checkSiteCache() {
+    function checkSiteCache()
+    {
         $modx = evolutionCMS();
         $checked= true;
         if (file_exists($modx->config['base_path'] . 'assets/cache/siteCache.idx.php')) {
@@ -159,26 +160,36 @@ 
 
 if ($warningspresent==1) {
 
-if(!isset($modx->config['send_errormail'])) $modx->config['send_errormail']='3';
+if(!isset($modx->config['send_errormail'])) {
+    $modx->config['send_errormail']='3';
+}
 $config_check_results = "<h3>".$_lang['configcheck_notok']."</h3>";
 
 for ($i=0;$i<count($warnings);$i++) {
     switch ($warnings[$i][0]) {
         case $_lang['configcheck_configinc'];
             $warnings[$i][1] = $_lang['configcheck_configinc_msg'];
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_configinc']);
+            if(!$_SESSION["mgrConfigCheck"]) {
+                $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_configinc']);
+            }
             break;
         case $_lang['configcheck_installer'] :
             $warnings[$i][1] = $_lang['configcheck_installer_msg'];
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_installer']);
+            if(!$_SESSION["mgrConfigCheck"]) {
+                $modx->logEvent(0,3,$warnings[$i][1],$_lang['configcheck_installer']);
+            }
             break;
         case $_lang['configcheck_cache'] :
             $warnings[$i][1] = $_lang['configcheck_cache_msg'];
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_cache']);
+            if(!$_SESSION["mgrConfigCheck"]) {
+                $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_cache']);
+            }
             break;
         case $_lang['configcheck_images'] :
             $warnings[$i][1] = $_lang['configcheck_images_msg'];
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_images']);
+            if(!$_SESSION["mgrConfigCheck"]) {
+                $modx->logEvent(0,2,$warnings[$i][1],$_lang['configcheck_images']);
+            }
             break;
         case $_lang['configcheck_sysfiles_mod']:
             $warnings[$i][1] = $_lang["configcheck_sysfiles_mod_msg"];
@@ -186,7 +197,9 @@ 
 			if($modx->hasPermission('settings')) {
 				$warnings[$i][2] .= '<ul class="actionButtons" style="float:right"><li><a href="index.php?a=2&b=resetSysfilesChecksum" onclick="return confirm(\'' . $_lang["reset_sysfiles_checksum_alert"] . '\')">' . $_lang["reset_sysfiles_checksum_button"] . '</a></li></ul>';
 			}
-            if(!$_SESSION["mgrConfigCheck"]) $modx->logEvent(0,3,$warnings[$i][1]." ".implode(', ',$sysfiles_check),$_lang['configcheck_sysfiles_mod']);
+            if(!$_SESSION["mgrConfigCheck"]) {
+                $modx->logEvent(0,3,$warnings[$i][1]." ".implode(', ',$sysfiles_check),$_lang['configcheck_sysfiles_mod']);
+            }
             break;
         case $_lang['configcheck_lang_difference'] :
             $warnings[$i][1] = $_lang['configcheck_lang_difference_msg'];

manager/includes/src/Legacy/ManagerApi.php

Braces +4 added lines, -2 removed lines

@@ -116,7 +116,8 @@ 
      * @return string
      */
     public function getHashType($db_value = '')
-    { // md5 | v1 | phpass
+    {
+// md5 | v1 | phpass
         $c = substr($db_value, 0, 1);
         if ($c === '$') {
             return 'phpass';
@@ -135,7 +136,8 @@ 
      * @return string
      */
     public function genV1Hash($password, $seed = '1')
-    { // $seed is user_id basically
+    {
+// $seed is user_id basically
         $modx = evolutionCMS();
 
         if (isset($modx->config['pwd_hash_algo']) && !empty($modx->config['pwd_hash_algo'])) {

manager/includes/src/Legacy/ExportSite.php

Braces +4 added lines, -2 removed lines

@@ -279,7 +279,8 @@ 
             $row['count'] = $this->count;
             $row['url'] = $modx->makeUrl($row['id']);
 
-            if (!$row['wasNull']) { // needs writing a document
+            if (!$row['wasNull']) {
+// needs writing a document
                 $docname = $this->getFileName($row['id'], $row['alias'], $prefix, $suffix);
                 $filename = $dirpath . $docname;
                 if (!is_file($filename)) {
@@ -307,7 +308,8 @@ 
                 $this->output[] = $this->parsePlaceholder($_lang['export_site_exporting_document'], $row);
             }
             if ($row['isfolder'] === '1' && ($modx->config['suffix_mode'] !== '1' || strpos($row['alias'],
-                        '.') === false)) { // needs making a folder
+                        '.') === false)) {
+// needs making a folder
                 $end_dir = ($row['alias'] !== '') ? $row['alias'] : $row['id'];
                 $dir_path = $dirpath . $end_dir;
                 if (strpos($dir_path, MODX_BASE_PATH) === false) {

manager/includes/src/Legacy/DeprecatedCore.php

Braces +2 added lines, -1 removed lines

@@ -177,7 +177,8 @@
      * @return bool|string
      */
     public function putChunk($chunkName)
-    { // alias name >.<
+    {
+// alias name >.<
         $modx = evolutionCMS();
 
         return $modx->getChunk($chunkName);

manager/includes/src/Exceptions/ServiceNotFoundException.php

Braces +3 added lines, -1 removed lines

@@ -2,4 +2,6 @@
 
 use Exception;
 
-class ServiceNotFoundException extends Exception{}
+class ServiceNotFoundException extends Exception
+{
+}