evolution-cms / evolution

manager/includes/src/Support/Paginate.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
     /**
      * This function returns the current page number.
      *
-     * @return int
+     * @return string
      */
     public function getCurrentPage()
     {

Spacing +6 added lines, -6 removed lines

@@ -101,14 +101,14 @@ 
         $array_paging['total'] = $this->int_nbr_row;
 
         if ($this->int_cur_position != 0) {
-            $array_paging['first_link'] = "<a href=\"$PHP_SELF?int_cur_position=0" . $this->str_ext_argv . "\">";
-            $array_paging['previous_link'] = "<a href=\"$PHP_SELF?int_cur_position=" . ($this->int_cur_position - $this->int_num_result) . $this->str_ext_argv . "\">";
+            $array_paging['first_link'] = "<a href=\"$PHP_SELF?int_cur_position=0".$this->str_ext_argv."\">";
+            $array_paging['previous_link'] = "<a href=\"$PHP_SELF?int_cur_position=".($this->int_cur_position - $this->int_num_result).$this->str_ext_argv."\">";
         }
 
         if (($this->int_nbr_row - $this->int_cur_position) > $this->int_num_result) {
             $int_new_position = $this->int_cur_position + $this->int_num_result;
-            $array_paging['last_link'] = "<a href=\"$PHP_SELF?int_cur_position=" . $this->int_nbr_row . $this->str_ext_argv . "\">";
-            $array_paging['next_link'] = "<a href=\"$PHP_SELF?int_cur_position=$int_new_position" . $this->str_ext_argv . "\">";
+            $array_paging['last_link'] = "<a href=\"$PHP_SELF?int_cur_position=".$this->int_nbr_row.$this->str_ext_argv."\">";
+            $array_paging['next_link'] = "<a href=\"$PHP_SELF?int_cur_position=$int_new_position".$this->str_ext_argv."\">";
         }
 
         return $array_paging;
@@ -126,10 +126,10 @@ 
         for ($i = 0; $i < $this->getNumberOfPage(); $i++) {
             // if current page, do not make a link
             if ($i == $this->getCurrentPage()) {
-                $array_all_page[$i] = "<b>" . ($i + 1) . "</b>&nbsp;";
+                $array_all_page[$i] = "<b>".($i + 1)."</b>&nbsp;";
             } else {
                 $int_new_position = ($i * $this->int_num_result);
-                $array_all_page[$i] = "<a href=\"" . $PHP_SELF . "?int_cur_position=$int_new_position$this->str_ext_argv\">" . ($i + 1) . "</a>&nbsp;";
+                $array_all_page[$i] = "<a href=\"".$PHP_SELF."?int_cur_position=$int_new_position$this->str_ext_argv\">".($i + 1)."</a>&nbsp;";
             }
         }
 

manager/includes/error.class.inc.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * @deprecated EvolutionCMS\Legacy\ErrorHandler
  * @todo could be unnecessary
  */
-class errorHandler extends EvolutionCMS\Legacy\ErrorHandler {
+class errorHandler extends EvolutionCMS\Legacy\ErrorHandler{
     public function include_lang($context = 'common')
     {
         parent::includeLang($context);

Braces +2 added lines, -1 removed lines

@@ -5,7 +5,8 @@
  * @deprecated EvolutionCMS\Legacy\ErrorHandler
  * @todo could be unnecessary
  */
-class errorHandler extends EvolutionCMS\Legacy\ErrorHandler {
+class errorHandler extends EvolutionCMS\Legacy\ErrorHandler
+{
     public function include_lang($context = 'common')
     {
         parent::includeLang($context);

manager/includes/log.class.inc.php

Braces +3 added lines, -1 removed lines

@@ -3,4 +3,6 @@
 /**
  * @deprecated use EvolutionCMS\Legacy\LogHandler
  */
-class logHandler extends EvolutionCMS\Legacy\LogHandler{}
+class logHandler extends EvolutionCMS\Legacy\LogHandler
+{
+}

manager/includes/src/Legacy/Permissions.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
         $role = $this->role;
 
         if ($role == 1) {
-            return true;  // administrator - grant all document permissions
+            return true; // administrator - grant all document permissions
         }
 
         if ($modx->config['use_udperms'] == 0 || $modx->config['use_udperms'] == "" || !isset($modx->config['use_udperms'])) {
@@ -63,14 +63,14 @@ 
             are private to the manager users will not be private to web users if the
             document group is not assigned to a web user group and visa versa.
          */
-        $permissionsok = false;  // set permissions to false
+        $permissionsok = false; // set permissions to false
 
         $rs = $modx->db->select(
             'count(DISTINCT sc.id)',
             "{$tblsc} AS sc 
 				LEFT JOIN {$tbldg} AS dg on dg.document = sc.id 
 				LEFT JOIN {$tbldgn} dgn ON dgn.id = dg.document_group",
-            "sc.id='{$this->document}' AND (" . (empty($docgrp) ? '' : "dg.document_group = " . $docgrp . " ||") . " sc.privatemgr = 0)"
+            "sc.id='{$this->document}' AND (".(empty($docgrp) ? '' : "dg.document_group = ".$docgrp." ||")." sc.privatemgr = 0)"
         );
         $limit = $modx->db->getValue($rs);
         if ($limit == 1) {

manager/includes/src/Legacy/ErrorHandler.php

Spacing +3 added lines, -3 removed lines

@@ -71,11 +71,11 @@
         }
 
         if ($context === 'common') {
-            $lang_path = MODX_MANAGER_PATH . 'includes/lang/';
+            $lang_path = MODX_MANAGER_PATH.'includes/lang/';
         } else {
-            $lang_path = MODX_MANAGER_PATH . "includes/lang/{$context}/";
+            $lang_path = MODX_MANAGER_PATH."includes/lang/{$context}/";
         }
-        include_once($lang_path . 'english.inc.php');
+        include_once($lang_path.'english.inc.php');
         $manager_language = $modx->config['manager_language'];
         if (is_file("{$lang_path}{$manager_language}.inc.php")) {
             include_once("{$lang_path}{$manager_language}.inc.php");

manager/includes/src/Legacy/Categories.php

Spacing +11 added lines, -11 removed lines

@@ -20,7 +20,7 @@ 
         $this->db_tbl['categories'] = $modx->getFullTableName('categories');
 
         foreach ($this->elements as $element) {
-            $this->db_tbl[$element] = $modx->getFullTableName('site_' . $element);
+            $this->db_tbl[$element] = $modx->getFullTableName('site_'.$element);
         }
     }
 
@@ -54,7 +54,7 @@ 
             $this->db->select(
                 '*',
                 $this->db_tbl['categories'],
-                "`" . $where . "` = '" . $this->db->escape($search) . "'"
+                "`".$where."` = '".$this->db->escape($search)."'"
             )
         );
 
@@ -71,9 +71,9 @@ 
     {
         $_value = $this->db->getValue(
             $this->db->select(
-                '`' . $value . '`',
+                '`'.$value.'`',
                 $this->db_tbl['categories'],
-                "`" . $where . "` = '" . $this->db->escape($search) . "'"
+                "`".$where."` = '".$this->db->escape($search)."'"
             )
         );
 
@@ -92,7 +92,7 @@ 
                 $this->db->select(
                     '*',
                     $this->db_tbl[$element],
-                    "`category` = '" . (int)$category_id . "'"
+                    "`category` = '".(int) $category_id."'"
                 )
             );
 
@@ -135,13 +135,13 @@ 
             $this->db->update(
                 $_update,
                 $this->db_tbl[$element],
-                "`category` = '" . (int)$category_id . "'"
+                "`category` = '".(int) $category_id."'"
             );
         }
 
         $this->db->delete(
             $this->db_tbl['categories'],
-            "`id` = '" . (int)$category_id . "'"
+            "`id` = '".(int) $category_id."'"
         );
 
         return $this->db->getAffectedRows() === 1;
@@ -160,13 +160,13 @@ 
 
         $_update = array(
             'category' => $this->db->escape($data['category']),
-            'rank'     => (int)$data['rank']
+            'rank'     => (int) $data['rank']
         );
 
         $this->db->update(
             $_update,
             $this->db_tbl['categories'],
-            "`id` = '" . (int)$category_id . "'"
+            "`id` = '".(int) $category_id."'"
         );
 
         if ($this->db->getAffectedRows() === 1) {
@@ -189,7 +189,7 @@ 
 
         $_insert = array(
             'category' => $this->db->escape($category_name),
-            'rank'     => (int)$category_rank
+            'rank'     => (int) $category_rank
         );
 
         $this->db->insert(
@@ -216,7 +216,7 @@ 
             $this->db->select(
                 '`id`',
                 $this->db_tbl['categories'],
-                "`category` = '" . $category . "'"
+                "`category` = '".$category."'"
             )
         );
 

manager/includes/src/Legacy/LogHandler.php

Spacing +10 added lines, -10 removed lines

@@ -36,16 +36,16 @@ 
         $action = "",
         $itemid = "",
         $itemname = ""
-    ) {
+    ){
         $modx = evolutionCMS();
         $this->entry['msg'] = $msg; // writes testmessage to the object
-        $this->entry['action'] = empty($action) ? $modx->manager->action : $action;    // writes the action to the object
+        $this->entry['action'] = empty($action) ? $modx->manager->action : $action; // writes the action to the object
 
         // User Credentials
         $this->entry['internalKey'] = $internalKey == "" ? $modx->getLoginUserID() : $internalKey;
         $this->entry['username'] = $username == "" ? $modx->getLoginUserName() : $username;
 
-        $this->entry['itemId'] = (empty($itemid) && isset($_REQUEST['id'])) ? (int)$_REQUEST['id'] : $itemid;  // writes the id to the object
+        $this->entry['itemId'] = (empty($itemid) && isset($_REQUEST['id'])) ? (int) $_REQUEST['id'] : $itemid; // writes the id to the object
         if ($this->entry['itemId'] == 0) {
             $this->entry['itemId'] = "-";
         } // to stop items having id 0
@@ -96,20 +96,20 @@ 
             
         $insert_id = $modx->db->insert($fields, $tbl_manager_log);
         if (!$insert_id) {
-            $modx->messageQuit("Logging error: couldn't save log to table! Error code: " . $modx->db->getLastError());
+            $modx->messageQuit("Logging error: couldn't save log to table! Error code: ".$modx->db->getLastError());
         } else {
-            $limit = (isset($modx->config['manager_log_limit'])) ? (int)$modx->config['manager_log_limit'] : 3000;
-            $trim = (isset($modx->config['manager_log_trim'])) ? (int)$modx->config['manager_log_trim'] : 100;
+            $limit = (isset($modx->config['manager_log_limit'])) ? (int) $modx->config['manager_log_limit'] : 3000;
+            $trim = (isset($modx->config['manager_log_trim'])) ? (int) $modx->config['manager_log_trim'] : 100;
             if (($insert_id % $trim) === 0) {
                 $modx->rotate_log('manager_log', $limit, $trim);
             }
         }
     }
 
-    private function getUserIP() {
-        if( array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER) && !empty($_SERVER['HTTP_X_FORWARDED_FOR']) ) {
-            if (strpos($_SERVER['HTTP_X_FORWARDED_FOR'], ',')>0) {
-                $addr = explode(",",$_SERVER['HTTP_X_FORWARDED_FOR']);
+    private function getUserIP(){
+        if (array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER) && !empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
+            if (strpos($_SERVER['HTTP_X_FORWARDED_FOR'], ',') > 0) {
+                $addr = explode(",", $_SERVER['HTTP_X_FORWARDED_FOR']);
                 return trim($addr[0]);
             } else {
                 return $_SERVER['HTTP_X_FORWARDED_FOR'];

Braces +3 added lines, -3 removed lines

@@ -105,7 +105,8 @@ 
         }
     }
 
-    private function getUserIP() {
+    private function getUserIP()
+    {
         if( array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER) && !empty($_SERVER['HTTP_X_FORWARDED_FOR']) ) {
             if (strpos($_SERVER['HTTP_X_FORWARDED_FOR'], ',')>0) {
                 $addr = explode(",",$_SERVER['HTTP_X_FORWARDED_FOR']);
@@ -113,8 +114,7 @@ 
             } else {
                 return $_SERVER['HTTP_X_FORWARDED_FOR'];
             }
-        }
-        else {
+        } else {
             return $_SERVER['REMOTE_ADDR'];
         }
     }

manager/includes/src/Legacy/mgrResources.php

Spacing +36 added lines, -36 removed lines

@@ -1,6 +1,6 @@ 
 <?php namespace EvolutionCMS\Legacy;
 
-class mgrResources {
+class mgrResources{
     /**
      * @var array
      */
@@ -21,7 +21,7 @@ 
     /**
      * mgrResources constructor.
      */
-    public function __construct() {
+    public function __construct(){
         $this->setTypes();
         $this->queryItemsFromDB();
         $this->prepareCategoryArrays();
@@ -30,47 +30,47 @@ 
     /**
      * @return void
      */
-    public function setTypes() {
+    public function setTypes(){
         global $_lang;
-        $this->types['site_templates']    = array(
+        $this->types['site_templates'] = array(
             'title'=>$_lang["manage_templates"],
-            'actions'=>array( 'edit'=>array(16,'edit_template'), 'duplicate'=>array(96,'new_template'), 'remove'=>array(21,'delete_template') ),
-            'permissions'=>array('new_template','edit_template'),
+            'actions'=>array('edit'=>array(16, 'edit_template'), 'duplicate'=>array(96, 'new_template'), 'remove'=>array(21, 'delete_template')),
+            'permissions'=>array('new_template', 'edit_template'),
             'name'=>'templatename'
         );
-        $this->types['site_tmplvars']     = array(
+        $this->types['site_tmplvars'] = array(
             'title'=>$_lang["tmplvars"],
-            'actions'=>array('edit'=>array(301,'edit_template'), 'duplicate'=>array(304,'edit_template'), 'remove'=>array(303,'edit_template')),
-            'permissions'=>array('new_template','edit_template'),
+            'actions'=>array('edit'=>array(301, 'edit_template'), 'duplicate'=>array(304, 'edit_template'), 'remove'=>array(303, 'edit_template')),
+            'permissions'=>array('new_template', 'edit_template'),
         );
         $this->types['site_htmlsnippets'] = array(
             'title'=>$_lang["manage_htmlsnippets"],
-            'actions'=>array('edit'=>array(78,'edit_chunk'), 'duplicate'=>array(97,'new_chunk'), 'remove'=>array(80,'delete_chunk')),
-            'permissions'=>array('new_chunk','edit_chunk'),
+            'actions'=>array('edit'=>array(78, 'edit_chunk'), 'duplicate'=>array(97, 'new_chunk'), 'remove'=>array(80, 'delete_chunk')),
+            'permissions'=>array('new_chunk', 'edit_chunk'),
         );
-        $this->types['site_snippets']     = array(
+        $this->types['site_snippets'] = array(
             'title'=>$_lang["manage_snippets"],
-            'actions'=>array('edit'=>array(22,'edit_snippet'), 'duplicate'=>array(98,'new_snippet'), 'remove'=>array(25,'delete_snippet')),
-            'permissions'=>array('new_snippet','edit_snippet'),
+            'actions'=>array('edit'=>array(22, 'edit_snippet'), 'duplicate'=>array(98, 'new_snippet'), 'remove'=>array(25, 'delete_snippet')),
+            'permissions'=>array('new_snippet', 'edit_snippet'),
         );
-        $this->types['site_plugins']      = array(
+        $this->types['site_plugins'] = array(
             'title'=>$_lang["manage_plugins"],
-            'actions'=>array('edit'=>array(102,'edit_plugin'), 'duplicate'=>array(105,'new_plugin'), 'remove'=>array(104,'delete_plugin')),
-            'permissions'=>array('new_plugin','edit_plugin'),
+            'actions'=>array('edit'=>array(102, 'edit_plugin'), 'duplicate'=>array(105, 'new_plugin'), 'remove'=>array(104, 'delete_plugin')),
+            'permissions'=>array('new_plugin', 'edit_plugin'),
         );
-        $this->types['site_modules']      = array(
+        $this->types['site_modules'] = array(
             'title'=>$_lang["manage_modules"],
-            'actions'=>array('edit'=>array(108,'edit_module'), 'duplicate'=>array(111,'new_module'), 'remove'=>array(110,'delete_module')),
-            'permissions'=>array('new_module','edit_module'),
+            'actions'=>array('edit'=>array(108, 'edit_module'), 'duplicate'=>array(111, 'new_module'), 'remove'=>array(110, 'delete_module')),
+            'permissions'=>array('new_module', 'edit_module'),
         );
     }
 
     /**
      * @return void
      */
-    public function queryItemsFromDB() {
-        foreach($this->types as $resourceTable=>$type) {
-            if($this->hasAnyPermissions($type['permissions'])) {
+    public function queryItemsFromDB(){
+        foreach ($this->types as $resourceTable=>$type) {
+            if ($this->hasAnyPermissions($type['permissions'])) {
                 $nameField = isset($type['name']) ? $type['name'] : 'name';
                 $this->items[$resourceTable] = $this->queryResources($resourceTable, $nameField);
             }
@@ -81,11 +81,11 @@ 
      * @param array $permissions
      * @return bool
      */
-    public function hasAnyPermissions($permissions) {
+    public function hasAnyPermissions($permissions){
         $modx = evolutionCMS();
 
-        foreach($permissions as $p)
-            if($modx->hasPermission($p)) return true;
+        foreach ($permissions as $p)
+            if ($modx->hasPermission($p)) return true;
 
         return false;
     }
@@ -95,7 +95,7 @@ 
      * @param string $nameField
      * @return array|bool
      */
-    public function queryResources($resourceTable, $nameField = 'name') {
+    public function queryResources($resourceTable, $nameField = 'name'){
         $modx = evolutionCMS(); global $_lang;
 
         $allowed = array(
@@ -104,7 +104,7 @@ 
             'site_plugins',
             'site_modules'
         );
-        $pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable . '.disabled, ' : '';
+        $pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable.'.disabled, ' : '';
 
         $tvsql  = '';
         $tvjoin = '';
@@ -119,14 +119,14 @@ 
 
         $rs = $modx->db->select(
             "{$sttfield} {$pluginsql} {$tvsql} {$resourceTable}.{$nameField} as name, {$resourceTable}.id, {$resourceTable}.description, {$resourceTable}.locked, {$selectableTemplates}IF(isnull(categories.category),'{$_lang['no_category']}',categories.category) as category, categories.id as catid",
-            $modx->getFullTableName($resourceTable) . " AS {$resourceTable}
-	            LEFT JOIN " . $modx->getFullTableName('categories') . " AS categories ON {$resourceTable}.category = categories.id {$tvjoin}",
+            $modx->getFullTableName($resourceTable)." AS {$resourceTable}
+	            LEFT JOIN ".$modx->getFullTableName('categories')." AS categories ON {$resourceTable}.category = categories.id {$tvjoin}",
             "",
             "category,name"
         );
         $limit = $modx->db->getRecordCount($rs);
 
-        if($limit < 1) return false;
+        if ($limit < 1) return false;
 
         $result = array();
         while ($row = $modx->db->getRow($rs)) {
@@ -138,9 +138,9 @@ 
     /**
      * @return void
      */
-    public function prepareCategoryArrays() {
-        foreach($this->items as $type=>$items) {
-            foreach((array)$items as $item) {
+    public function prepareCategoryArrays(){
+        foreach ($this->items as $type=>$items) {
+            foreach ((array) $items as $item) {
                 $catid = $item['catid'] ? $item['catid'] : 0;
                 $this->categories[$catid] = $item['category'];
 
@@ -153,8 +153,8 @@ 
         natcasesort($this->categories);
 
         // Now sort by name
-        foreach($this->itemsPerCategory as $catid=>$items) {
-            usort($this->itemsPerCategory[$catid], function ($a, $b) {
+        foreach ($this->itemsPerCategory as $catid=>$items) {
+            usort($this->itemsPerCategory[$catid], function($a, $b){
                 return strcasecmp($a['name'], $b['name']);
             });
         }

Braces +23 added lines, -12 removed lines

@@ -1,6 +1,7 @@ 
 <?php namespace EvolutionCMS\Legacy;
 
-class mgrResources {
+class mgrResources
+{
     /**
      * @var array
      */
@@ -21,7 +22,8 @@ 
     /**
      * mgrResources constructor.
      */
-    public function __construct() {
+    public function __construct()
+    {
         $this->setTypes();
         $this->queryItemsFromDB();
         $this->prepareCategoryArrays();
@@ -30,7 +32,8 @@ 
     /**
      * @return void
      */
-    public function setTypes() {
+    public function setTypes()
+    {
         global $_lang;
         $this->types['site_templates']    = array(
             'title'=>$_lang["manage_templates"],
@@ -68,7 +71,8 @@ 
     /**
      * @return void
      */
-    public function queryItemsFromDB() {
+    public function queryItemsFromDB()
+    {
         foreach($this->types as $resourceTable=>$type) {
             if($this->hasAnyPermissions($type['permissions'])) {
                 $nameField = isset($type['name']) ? $type['name'] : 'name';
@@ -81,11 +85,13 @@ 
      * @param array $permissions
      * @return bool
      */
-    public function hasAnyPermissions($permissions) {
+    public function hasAnyPermissions($permissions)
+    {
         $modx = evolutionCMS();
 
-        foreach($permissions as $p)
-            if($modx->hasPermission($p)) return true;
+        foreach($permissions as $p) {
+                    if($modx->hasPermission($p)) return true;
+        }
 
         return false;
     }
@@ -95,7 +101,8 @@ 
      * @param string $nameField
      * @return array|bool
      */
-    public function queryResources($resourceTable, $nameField = 'name') {
+    public function queryResources($resourceTable, $nameField = 'name')
+    {
         $modx = evolutionCMS(); global $_lang;
 
         $allowed = array(
@@ -112,8 +119,9 @@ 
             $tvsql    = 'site_tmplvars.caption, ';
             $tvjoin   = sprintf('LEFT JOIN %s AS stt ON site_tmplvars.id=stt.tmplvarid GROUP BY site_tmplvars.id,reltpl', $modx->getFullTableName('site_tmplvar_templates'));
             $sttfield = 'IF(stt.templateid,1,0) AS reltpl,';
+        } else {
+            $sttfield = '';
         }
-        else $sttfield = '';
 
         $selectableTemplates = $resourceTable === 'site_templates' ? "{$resourceTable}.selectable, " : "";
 
@@ -126,7 +134,9 @@ 
         );
         $limit = $modx->db->getRecordCount($rs);
 
-        if($limit < 1) return false;
+        if($limit < 1) {
+            return false;
+        }
 
         $result = array();
         while ($row = $modx->db->getRow($rs)) {
@@ -138,7 +148,8 @@ 
     /**
      * @return void
      */
-    public function prepareCategoryArrays() {
+    public function prepareCategoryArrays()
+    {
         foreach($this->items as $type=>$items) {
             foreach((array)$items as $item) {
                 $catid = $item['catid'] ? $item['catid'] : 0;
@@ -154,7 +165,7 @@ 
 
         // Now sort by name
         foreach($this->itemsPerCategory as $catid=>$items) {
-            usort($this->itemsPerCategory[$catid], function ($a, $b) {
+            usort($this->itemsPerCategory[$catid], function ($a, $b){
                 return strcasecmp($a['name'], $b['name']);
             });
         }

manager/includes/src/Legacy/TemplateParser.php

Spacing +32 added lines, -32 removed lines

@@ -8,46 +8,46 @@ 
      * @param array $data
      * @return string
      */
-    public function output($config = array(), $data = array()) {
+    public function output($config = array(), $data = array()){
         $modx = evolutionCMS();
 
         $output = '';
         $action = !empty($config['action']) ? $config['action'] : (!empty($_REQUEST['a']) ? $_REQUEST['a'] : '');
-        $tab = isset($config['tab']) ? ' AND tab IN(' . $config['tab'] . ')' : '';
+        $tab = isset($config['tab']) ? ' AND tab IN('.$config['tab'].')' : '';
 
-        if($action) {
+        if ($action) {
             $sql = $modx->db->query('SELECT t1.*, IF(t1.alias=\'\',t1.name,t1.alias) AS alias, t2.category AS category_name
-			FROM ' . $modx->getFullTableName('system_templates') . ' AS t1
-			INNER JOIN ' . $modx->getFullTableName('categories') . ' AS t2 ON t2.id=t1.category
-			WHERE t1.action IN(' . $action . ') ' . $tab . '
+			FROM ' . $modx->getFullTableName('system_templates').' AS t1
+			INNER JOIN ' . $modx->getFullTableName('categories').' AS t2 ON t2.id=t1.category
+			WHERE t1.action IN(' . $action.') '.$tab.'
 			ORDER BY t1.tab ASC, t1.rank ASC');
 
-            if($modx->db->getRecordCount($sql)) {
+            if ($modx->db->getRecordCount($sql)) {
                 $tabs = array();
-                while($row = $modx->db->getRow($sql)) {
-                    if(!$row['value'] && !empty($data[$row['name']])) {
+                while ($row = $modx->db->getRow($sql)) {
+                    if (!$row['value'] && !empty($data[$row['name']])) {
                         $row['value'] = $data[$row['name']];
                     }
                     $tabs[$row['tab']]['category_name'] = $row['category_name'];
                     $tabs[$row['tab']][$row['name']] = $this->render($row);
                 }
 
-                if(!empty($config['toArray'])) {
+                if (!empty($config['toArray'])) {
                     $output = $tabs;
                 } else {
-                    $output .= '<div class="tab-pane" id="pane_' . $action . '">';
+                    $output .= '<div class="tab-pane" id="pane_'.$action.'">';
                     $output .= '
 					<script type="text/javascript">
-						var pane_' . $action . ' = new WebFXTabPane(document.getElementById("pane_' . $action . '"), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false') . ');
+						var pane_' . $action.' = new WebFXTabPane(document.getElementById("pane_'.$action.'"), '.($modx->config['remember_last_tab'] == 1 ? 'true' : 'false').');
 					</script>';
 
-                    foreach($tabs as $idTab => $tab) {
-                        $output .= '<div class="tab-page" id="tab_' . $action . '_' . $idTab . '">';
+                    foreach ($tabs as $idTab => $tab) {
+                        $output .= '<div class="tab-page" id="tab_'.$action.'_'.$idTab.'">';
                         $output .= '
-						<h2 class="tab">' . (!empty($config['tabs'][$idTab]) ? $config['tabs'][$idTab] : $tab['category_name']) . '</h2>
-						<script type="text/javascript">pane_' . $action . '.addTabPage(document.getElementById("tab_' . $action . '_' . $idTab . '"));</script>';
+						<h2 class="tab">' . (!empty($config['tabs'][$idTab]) ? $config['tabs'][$idTab] : $tab['category_name']).'</h2>
+						<script type="text/javascript">pane_' . $action.'.addTabPage(document.getElementById("tab_'.$action.'_'.$idTab.'"));</script>';
                         unset($tab['category_name']);
-                        foreach($tab as $item) {
+                        foreach ($tab as $item) {
                             $output .= $item;
                         }
                         $output .= '</div>';
@@ -64,7 +64,7 @@ 
      * @param array $data
      * @return string
      */
-    private function render($data) {
+    private function render($data){
         $modx = evolutionCMS(); global $_lang, $_country_lang;
 
         $data['lang.name'] = (isset($_lang[$data['alias']]) ? $_lang[$data['alias']] : $data['alias']);
@@ -74,7 +74,7 @@ 
         $output = '';
         $output .= '<div class="form-group row">';
 
-        switch($data['type']) {
+        switch ($data['type']) {
 
             case 'text':
                 $output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>
@@ -108,18 +108,18 @@ 
                 $output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
                 $output .= '<div class="col-sm-7">';
                 $output .= '<select name="[+name+]" class="form-control" id="[+name+]" onChange="documentDirty=true;">';
-                if($data['name'] == 'country' && isset($_country_lang)) {
+                if ($data['name'] == 'country' && isset($_country_lang)) {
                     $chosenCountry = isset($_POST['country']) ? $_POST['country'] : $data['country'];
-                    $output .= '<option value=""' . (!isset($chosenCountry) ? ' selected' : '') . '>&nbsp;</option>';
-                    foreach($_country_lang as $key => $value) {
-                        $output .= '<option value="' . $key . '"' . (isset($chosenCountry) && $chosenCountry == $key ? ' selected' : '') . '>' . $value . '</option>';
+                    $output .= '<option value=""'.(!isset($chosenCountry) ? ' selected' : '').'>&nbsp;</option>';
+                    foreach ($_country_lang as $key => $value) {
+                        $output .= '<option value="'.$key.'"'.(isset($chosenCountry) && $chosenCountry == $key ? ' selected' : '').'>'.$value.'</option>';
                     }
                 } else {
-                    if($data['elements']) {
+                    if ($data['elements']) {
                         $elements = explode('||', $data['elements']);
-                        foreach($elements as $key => $value) {
+                        foreach ($elements as $key => $value) {
                             $value = explode('==', $value);
-                            $output .= '<option value="' . $value[1] . '">' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]) . '</option>';
+                            $output .= '<option value="'.$value[1].'">'.(isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]).'</option>';
                         }
                     }
                 }
@@ -133,11 +133,11 @@ 
                 $output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
                 $output .= '<div class="col-sm-7">';
                 $output .= '<input type="checkbox" name="[+name+]" class="form-control" id="[+name+]" value="[+value+]" onChange="documentDirty=true;"[+readonly+] />';
-                if($data['elements']) {
+                if ($data['elements']) {
                     $elements = explode('||', $data['elements']);
-                    foreach($elements as $key => $value) {
+                    foreach ($elements as $key => $value) {
                         $value = explode('==', $value);
-                        $output .= '<br /><input type="checkbox" name="' . $value[0] . '" class="form-control" id="' . $value[0] . '" value="' . $value[1] . '" onChange="documentDirty=true;"[+readonly+] /> ' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
+                        $output .= '<br /><input type="checkbox" name="'.$value[0].'" class="form-control" id="'.$value[0].'" value="'.$value[1].'" onChange="documentDirty=true;"[+readonly+] /> '.(isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
                     }
                 }
                 $output .= $data['content'];
@@ -149,11 +149,11 @@ 
                 $output .= '<label class="col-sm-3" for="[+name+]">[+lang.name+]</label>';
                 $output .= '<div class="col-sm-7">';
                 $output .= '<input type="radio" name="[+name+]" class="form-control" id="[+name+]" value="[+value+]" onChange="documentDirty=true;"[+readonly+] />';
-                if($data['elements']) {
+                if ($data['elements']) {
                     $elements = explode('||', $data['elements']);
-                    foreach($elements as $key => $value) {
+                    foreach ($elements as $key => $value) {
                         $value = explode('==', $value);
-                        $output .= '<br /><input type="radio" name="[+name+]" class="form-control" id="[+name+]_' . $key . '" value="' . $value[1] . '" onChange="documentDirty=true;"[+readonly+] /> ' . (isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
+                        $output .= '<br /><input type="radio" name="[+name+]" class="form-control" id="[+name+]_'.$key.'" value="'.$value[1].'" onChange="documentDirty=true;"[+readonly+] /> '.(isset($_lang[$value[0]]) ? $_lang[$value[0]] : $value[0]);
                     }
                 }
                 $output .= $data['content'];

Braces +4 added lines, -2 removed lines

@@ -8,7 +8,8 @@ 
      * @param array $data
      * @return string
      */
-    public function output($config = array(), $data = array()) {
+    public function output($config = array(), $data = array())
+    {
         $modx = evolutionCMS();
 
         $output = '';
@@ -64,7 +65,8 @@ 
      * @param array $data
      * @return string
      */
-    private function render($data) {
+    private function render($data)
+    {
         $modx = evolutionCMS(); global $_lang, $_country_lang;
 
         $data['lang.name'] = (isset($_lang[$data['alias']]) ? $_lang[$data['alias']] : $data['alias']);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php namespace EvolutionCMS\Legacy;
 
-Class TemplateParser
+class TemplateParser
 {
 
     /**