Database::getConfig() - Code Metrics - Inspection of "Add Database::getConfig(), Database::getTableName(..." - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 48041c...eb8457 )

by Agel_Nash

created 2018-06-16 01:04 UTC

Database::getConfig() A

↳ Parent: Database

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php namespace EvolutionCMS;

use mysqli;
use mysqli_result;

class Database implements Interfaces\DatabaseInterface

{
    /**
     * @var mysqli
     */
    public $conn;
    public $config;
    public $lastQuery;
    public $isConnected;
    public $_dbconnectionmethod;

    /**
     * DBAPI constructor.
     *
     * @param string $host
     * @param string $dbase
     * @param string $uid
     * @param string $pwd
     * @param null|string $pre
     * @param string $charset
     * @param string $connection_method
     */
    public function __construct(
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $host = '',
        $dbase = '',
        $uid = '',
        $pwd = '',
        $pre = null,
        $charset = '',
        $connection_method = 'SET CHARACTER SET'
    ) {
        $this->config['host'] = $host ? $host : $GLOBALS['database_server'];
        $this->config['dbase'] = $dbase ? $dbase : $GLOBALS['dbase'];
        $this->config['user'] = $uid ? $uid : $GLOBALS['database_user'];
        $this->config['pass'] = $pwd ? $pwd : $GLOBALS['database_password'];
        $this->config['charset'] = $charset ? $charset : $GLOBALS['database_connection_charset'];
        $this->config['connection_method'] = $this->_dbconnectionmethod = (isset($GLOBALS['database_connection_method']) ? $GLOBALS['database_connection_method'] : $connection_method);
        $this->config['table_prefix'] = ($pre !== null) ? $pre : $GLOBALS['table_prefix'];
    }

    /**
     * @param null $key
     * @return mixed
     */
    public function getConfig($key = null)
    {
        return $key === null ? $this->config : get_by_key($this->config, $key);
    }

    /**
     * @param string $host
     * @param string $dbase
     * @param string $uid
     * @param string $pwd
     * @return mysqli

     */
    public function connect($host = '', $dbase = '', $uid = '', $pwd = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $modx = evolutionCMS();
        $uid = $uid ? $uid : $this->getConfig('user');
        $pwd = $pwd ? $pwd : $this->getConfig('pass');
        $host = $host ? $host : $this->getConfig('host');
        $dbase = $dbase ? $dbase : $this->getConfig('dbase');
        $dbase = trim($dbase, '`'); // remove the `` chars
        $charset = $this->getConfig('charset');
        $connection_method = $this->getConfig('connection_method');
        $tstart = $modx->getMicroTime();
        $safe_count = 0;
        do {
            $this->conn = new mysqli($host, $uid, $pwd, $dbase);
            if ($this->conn->connect_error) {
                $this->conn = null;
                if (isset($modx->config['send_errormail']) && $modx->config['send_errormail'] !== '0') {
                    if ($modx->config['send_errormail'] <= 2) {
                        $logtitle = 'Failed to create the database connection!';
                        $request_uri = $modx->getPhpCompat()->htmlspecialchars($_SERVER['REQUEST_URI']);
                        $ua = $modx->getPhpCompat()->htmlspecialchars($_SERVER['HTTP_USER_AGENT']);

                        $referer = $modx->getPhpCompat()->htmlspecialchars($_SERVER['HTTP_REFERER']);
                        $modx->sendmail(array(
                            'subject' => 'Missing to create the database connection! from ' . $modx->getPhpCompat()->entities($modx->config['site_name']),
                            'body'    => "{$logtitle}\n{$request_uri}\n{$ua}\n{$referer}",
                            'type'    => 'text'
                        ));
                    }
                }
                sleep(1);
                $safe_count++;
            }
        } while (!$this->conn && $safe_count < 3);
        if ($this->conn instanceof mysqli) {
            $this->conn->query("{$connection_method} {$charset}");
            $tend = $modx->getMicroTime();
            $totaltime = $tend - $tstart;
            if ($modx->dumpSQL) {
                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Database connection</legend>" . sprintf("Database connection was created in %2.4f s",
                        $totaltime) . "</fieldset><br />";
            }
            $this->conn->set_charset($this->getConfig('charset'));
            $this->isConnected = true;
            $modx->queryTime += $totaltime;
        } else {
            $modx->messageQuit("Failed to create the database connection!");
            exit;

        }
        return $this->conn;
    }

    /**
     * @return void
     */
    public function disconnect()
    {
        $this->conn->close();
        $this->conn = null;
        $this->isConnected = false;
    }

    /**
     * @param array|string $s
     * @param int $safeCount
     * @return array|string
     */
    public function escape($s, $safeCount = 0)

    {
        $safeCount++;
        if (1000 < $safeCount) {
            exit("Too many loops '{$safeCount}'");

        }
        if ( ! ($this->conn instanceof mysqli)) {
            $this->connect();
        }
        if (is_array($s)) {
            if (count($s) === 0) {
                $s = '';
            } else {
                foreach ($s as $i => $v) {
                    $s[$i] = $this->escape($v, $safeCount);
                }
            }
        } else {
            $s = $this->conn->escape_string($s);
        }

        return $s;
    }

    /**
     * @param string|array|mysqli_result $sql
     * @param bool $watchError
     * @return bool|mysqli_result
     */
    public function query($sql, $watchError = true)
    {
        $modx = evolutionCMS();
        if ( ! ($this->conn instanceof mysqli)) {
            $this->connect();
        }
        $tStart = $modx->getMicroTime();
        if (is_array($sql)) {
            $sql = implode("\n", $sql);
        }
        $this->lastQuery = $sql;
        if (!($result = $this->conn->query($sql))) {
            if (!$watchError) {
                return false;
            }
            switch (mysqli_errno($this->conn)) {
                case 1054:
                case 1060:
                case 1061:
                case 1062:
                case 1091:
                    break;
                default:
                    $modx->messageQuit('Execution of a query to the database failed - ' . $this->getLastError(), $sql);

            }
        } else {
            $tend = $modx->getMicroTime();
            $totalTime = $tend - $tStart;
            $modx->queryTime += $totalTime;
            if ($modx->dumpSQL) {
                $debug = debug_backtrace();
                array_shift($debug);
                $debug_path = array();
                foreach ($debug as $line) {
                    $debug_path[] = $line['function'];
                }
                $debug_path = implode(' > ', array_reverse($debug_path));
                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Query " . ($modx->executedQueries + 1) . " - " . sprintf("%2.2f ms",
                        $totalTime * 1000) . "</legend>";
                $modx->queryCode .= $sql . '<br><br>';
                if ($modx->event->name) {
                    $modx->queryCode .= 'Current Event  => ' . $modx->event->name . '<br>';
                }
                if ($modx->event->activePlugin) {
                    $modx->queryCode .= 'Current Plugin => ' . $modx->event->activePlugin . '<br>';
                }
                if ($modx->currentSnippet) {
                    $modx->queryCode .= 'Current Snippet => ' . $modx->currentSnippet . '<br>';
                }
                if (stripos($sql, 'select') === 0) {
                    $modx->queryCode .= 'Record Count => ' . $this->getRecordCount($result) . '<br>';
                } else {
                    $modx->queryCode .= 'Affected Rows => ' . $this->getAffectedRows() . '<br>';
                }
                $modx->queryCode .= 'Functions Path => ' . $debug_path . '<br>';
                $modx->queryCode .= "</fieldset><br />";
            }
            $modx->executedQueries++;

            return $result;
        }
        return false;
    }

    /**
     * @param string $from
     * @param string $where
     * @param string $orderBy
     * @param string $limit
     * @return bool|mysqli_result
     */
    public function delete($from, $where = '', $orderBy = '', $limit = '')
    {
        $modx = evolutionCMS();
        $out = false;
        if (!$from) {
            $modx->messageQuit("Empty \$from parameters in DBAPI::delete().");
        } else {
            $from = $this->replaceFullTableName($from);
            $where = trim($where);
            $orderBy = trim($orderBy);
            $limit = trim($limit);
            if ($where !== '' && stripos($where, 'WHERE') !== 0) {
                $where = "WHERE {$where}";
            }
            if ($orderBy !== '' && stripos($orderBy, 'ORDER BY') !== 0) {
                $orderBy = "ORDER BY {$orderBy}";
            }
            if ($limit !== '' && stripos($limit, 'LIMIT') !== 0) {
                $limit = "LIMIT {$limit}";
            }

            $out = $this->query("DELETE FROM {$from} {$where} {$orderBy} {$limit}");
        }
        return $out;
    }

    /**
     * @param string|array $fields
     * @param string|array $from
     * @param string|array $where
     * @param string $orderBy
     * @param string $limit
     * @return bool|mysqli_result
     */
    public function select($fields = "*", $from = "", $where = "", $orderBy = "", $limit = "")
    {
        $modx = evolutionCMS();

        if (is_array($fields)) {
            $fields = $this->_getFieldsStringFromArray($fields);
        }
        if (is_array($from)) {
            $from = $this->_getFromStringFromArray($from);
        }
        if (is_array($where)) {
            $where = implode(' ', $where);
        }

        if (!$from) {
            $modx->messageQuit("Empty \$from parameters in DBAPI::select().");
            exit;

        }

        $fields = $this->replaceFullTableName($fields);
        $from = $this->replaceFullTableName($from);
        $where = trim($where);
        $orderBy = trim($orderBy);
        $limit = trim($limit);
        if ($where !== '' && stripos($where, 'WHERE') !== 0) {
            $where = "WHERE {$where}";
        }
        if ($orderBy !== '' && stripos($orderBy, 'ORDER') !== 0) {
            $orderBy = "ORDER BY {$orderBy}";
        }
        if ($limit !== '' && stripos($limit, 'LIMIT') !== 0) {
            $limit = "LIMIT {$limit}";
        }

        return $this->query("SELECT {$fields} FROM {$from} {$where} {$orderBy} {$limit}");
    }

    /**
     * @param array|string $fields
     * @param $table
     * @param string $where
     * @return bool|mysqli_result
     */
    public function update($fields, $table, $where = "")
    {
        $modx = evolutionCMS();
        $out = false;
        if (!$table) {
            $modx->messageQuit('Empty '.$table.' parameter in DBAPI::update().');
        } else {
            $table = $this->replaceFullTableName($table);
            if (is_array($fields)) {
                foreach ($fields as $key => $value) {
                    if ($value === null || strtolower($value) === 'null') {
                        $f = 'NULL';
                    } else {
                        $f = "'" . $value . "'";
                    }
                    $fields[$key] = "`{$key}` = " . $f;
                }
                $fields = implode(',', $fields);
            }
            $where = trim($where);
            if ($where !== '' && stripos($where, 'WHERE') !== 0) {
                $where = 'WHERE '.$where;
            }

            return $this->query('UPDATE '.$table.' SET '.$fields.' '.$where);
        }
        return $out;
    }

    /**
     * @param string|array $fields
     * @param string $intotable
     * @param string $fromfields
     * @param string $fromtable
     * @param string $where
     * @param string $limit
     * @return mixed
     */
    public function insert($fields, $intotable, $fromfields = "*", $fromtable = "", $where = "", $limit = "")
    {
        $modx = evolutionCMS();
        $out = false;
        if (!$intotable) {
            $modx->messageQuit("Empty \$intotable parameters in DBAPI::insert().");
        } else {
            $intotable = $this->replaceFullTableName($intotable);
            if (!is_array($fields)) {
                $this->query("INSERT INTO {$intotable} {$fields}");
            } else {
                if (empty($fromtable)) {
                    $fields = "(`" . implode("`, `", array_keys($fields)) . "`) VALUES('" . implode("', '",
                            array_values($fields)) . "')";
                    $this->query("INSERT INTO {$intotable} {$fields}");
                } else {
                    $fromtable = $this->replaceFullTableName($fromtable);
                    $fields = "(" . implode(",", array_keys($fields)) . ")";
                    $where = trim($where);
                    $limit = trim($limit);
                    if ($where !== '' && stripos($where, 'WHERE') !== 0) {
                        $where = "WHERE {$where}";
                    }
                    if ($limit !== '' && stripos($limit, 'LIMIT') !== 0) {
                        $limit = "LIMIT {$limit}";
                    }
                    $this->query("INSERT INTO {$intotable} {$fields} SELECT {$fromfields} FROM {$fromtable} {$where} {$limit}");
                }
            }
            if (($lid = $this->getInsertId()) === false) {
                $modx->messageQuit("Couldn't get last insert key!");
            }

            $out = $lid;
        }
        return $out;
    }

    /**
     * @param $fields
     * @param $table
     * @param string $where
     * @return bool|mixed|mysqli_result
     */
    public function save($fields, $table, $where = '')
    { // This is similar to "replace into table".

        if ($where === '') {
            $mode = 'insert';
        } elseif ($this->getRecordCount($this->select('*', $table, $where)) === 0) {

            $mode = 'insert';
        } else {
            $mode = 'update';
        }

        return ($mode === 'insert') ? $this->insert($fields, $table) : $this->update($fields, $table, $where);
    }

    /**
     * @param mixed $rs
     * @return bool
     */
    public function isResult($rs)

    {
        return $rs instanceof mysqli_result;
    }

    /**
     * @param mysqli_result $rs
     */
    public function freeResult($rs)

    {
        $rs->free_result();
    }

    /**
     * @param mysqli_result $rs
     * @return mixed
     */
    public function numFields($rs)

    {
        return $rs->field_count;
    }

    /**
     * @param mysqli_result $rs
     * @param int $col
     * @return string|null
     */
    public function fieldName($rs, $col = 0)

    {
        $field = $rs->fetch_field_direct($col);

        return isset($field->name) ? $field->name : null;
    }

    /**
     * @param $name
     */
    public function selectDb($name)
    {
        $this->conn->select_db($name);
    }


    /**
     * @param null|mysqli $conn
     * @return mixed
     */
    public function getInsertId($conn = null)
    {
        if (! ($conn instanceof mysqli)) {
            $conn =& $this->conn;
        }

        return $conn->insert_id;
    }

    /**
     * @param null|mysqli $conn
     * @return int
     */
    public function getAffectedRows($conn = null)
    {
        if (! ($conn instanceof mysqli)) {
            $conn =& $this->conn;
        }

        return $conn->affected_rows;
    }

    /**
     * @param null|mysqli $conn
     * @return string
     */
    public function getLastError($conn = null)
    {
        if (! ($conn instanceof mysqli)) {
            $conn =& $this->conn;
        }

        return $conn->error;
    }

    /**
     * @param mysqli_result $ds
     * @return int
     */
    public function getRecordCount($ds)

    {
        return ($ds instanceof mysqli_result) ? $ds->num_rows : 0;
    }

    /**
     * @param mysqli_result $ds
     * @param string $mode
     * @return array|bool|mixed|object|stdClass
     */
    public function getRow($ds, $mode = 'assoc')

    {
        $out = false;
        if ($ds instanceof mysqli_result) {
            switch($mode){
                case 'assoc':
                    $out = $ds->fetch_assoc();
                    break;
                case 'num':
                    $out = $ds->fetch_row();
                    break;
                case 'object':
                    $out = $ds->fetch_object();
                    break;
                case 'both':
                    $out = $ds->fetch_array(MYSQLI_BOTH);
                    break;
                default:
                    $modx = evolutionCMS();
                    $modx->messageQuit("Unknown get type ($mode) specified for fetchRow - must be empty, 'assoc', 'num' or 'both'.");

            }
        }
        return $out;
    }

    /**
     * @param $name
     * @param mysqli_result|string $dsq
     * @return array
     */
    public function getColumn($name, $dsq)
    {
        $col = array();
        if ( ! ($dsq instanceof mysqli_result)) {
            $dsq = $this->query($dsq);
        }
        if ($dsq) {
            while ($row = $this->getRow($dsq)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $col[] = $row[$name];
            }
        }

        return $col;
    }

    /**
     * @param mysqli_result|string $dsq
     * @return array
     */
    public function getColumnNames($dsq)
    {
        $names = array();
        if ( ! ($dsq instanceof mysqli_result)) {
            $dsq = $this->query($dsq);
        }
        if ($dsq) {
            $limit = $this->numFields($dsq);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            for ($i = 0; $i < $limit; $i++) {
                $names[] = $this->fieldName($dsq, $i);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            }
        }

        return $names;
    }

    /**
     * @param mysqli_result|string $dsq
     * @return bool|string|int
     */
    public function getValue($dsq)
    {
        $out = false;
        if ( ! ($dsq instanceof mysqli_result)) {
            $dsq = $this->query($dsq);
        }
        if ($dsq) {
            $r = $this->getRow($dsq, 'num');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $out = isset($r[0]) ? $r[0] : false;
        }

        return $out;
    }

    /**
     * @param string $table
     * @return array
     */
    public function getTableMetaData($table)
    {
        $metadata = array();
        if (!empty($table) && is_scalar($table)) {
            $sql = 'SHOW FIELDS FROM '.$table;
            if ($ds = $this->query($sql)) {

                while ($row = $this->getRow($ds)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $fieldName = $row['Field'];
                    $metadata[$fieldName] = $row;
                }
            }
        }

        return $metadata;
    }

    /**
     * @param int $timestamp
     * @param string $fieldType
     * @return false|string
     */
    public function prepareDate($timestamp, $fieldType = 'DATETIME')
    {
        $date = false;
        if (!$timestamp === false && $timestamp > 0) {
            switch ($fieldType) {
                case 'DATE' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                    $date = date('Y-m-d', $timestamp);
                    break;
                case 'TIME' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                    $date = date('H:i:s', $timestamp);
                    break;
                case 'YEAR' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                    $date = date('Y', $timestamp);
                    break;
                default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                    $date = date('Y-m-d H:i:s', $timestamp);
                    break;
            }
        }

        return $date;
    }

    /**
     * @param string|mysqli_result $rs
     * @param bool $index
     * @return array
     */
    public function makeArray($rs = '', $index = false)

    {
        $rsArray = array();
        if (!$rs) {
            return $rsArray;
        }
        $iterator = 0;
        while ($row = $this->getRow($rs)) {

            $returnIndex = $index !== false && isset($row[$index]) ? $row[$index] : $iterator;
            $rsArray[$returnIndex] = $row;
            $iterator++;
        }

        return $rsArray;
    }

    /**
     * @return string
     */
    public function getVersion()
    {
        return $this->conn->server_info;
    }

    public function getTableName($table, $escape = true)
    {
        $out = $this->getConfig('table_prefix') . $table;
        return $escape ? '`' . $out . '`' : $out;
    }

    /**
     * @param $tbl
     * @return string
     */
    public function getFullTableName($tbl)
    {
        return $this->getConfig('dbase') . "." . $this->getTableName($tbl);
    }

    /**
     * @param string $tableName
     * @param bool $force
     * @return string
     */
    public function replaceFullTableName($tableName, $force = false)
    {
        $tableName = trim($tableName);
        $dbase = trim($this->getConfig('dbase'), '`');
        $prefix = $this->getConfig('table_prefix');
        if ((bool)$force === true) {
            $result = "`{$dbase}`.`{$prefix}{$tableName}`";
        } elseif (strpos($tableName, '[+prefix+]') !== false) {
            $result = preg_replace('@\[\+prefix\+\]([0-9a-zA-Z_]+)@', "`{$dbase}`.`{$prefix}$1`", $tableName);
        } else {
            $result = $tableName;
        }

        return $result;
    }

    /**
     * @param string $table_name
     * @return bool|mysqli_result
     */
    public function optimize($table_name)

    {
        $rs = $this->query('OPTIMIZE TABLE '.$table_name);

        if ($rs) {
            $rs = $this->query('ALTER TABLE '.$table_name);
        }

        return $rs;
    }

    /**
     * @param string $table_name
     * @return bool|mysqli_result
     */
    public function truncate($table_name)

    {
        return $this->query('TRUNCATE '.$table_name);
    }

    /**
     * @param mysqli_result $result
     * @param int $row_number
     * @return bool
     */
    public function dataSeek($result, $row_number)

    {
        return $result->data_seek($row_number);
    }

    /**
     * @param array $fields
     * @return string
     */
    public function _getFieldsStringFromArray($fields = array())
    {

        if (empty($fields)) {
            return '*';
        }

        $_ = array();

        foreach ($fields as $k => $v) {
            if ($k !== $v) {
                $_[] = $v.' as '.$k;
            } else {
                $_[] = $v;
            }
        }

        return implode(',', $_);
    }

    /**
     * @param array $tables
     * @return string
     */
    public function _getFromStringFromArray($tables = array())
    {
        $_ = array();

        foreach ($tables as $k => $v) {
            $_[] = $v;
        }

        return implode(' ', $_);
    }
}


1			<?php namespace EvolutionCMS;
2
3			use mysqli;
4			use mysqli_result;
5
6			class Database implements Interfaces\DatabaseInterface
			0 ignored issues – show Coding Style introduced 2018-06-12 09:22 UTC by Report Bug Copy Issue Report The property $_dbconnectionmethod is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
7			{
8			/**
9			* @var mysqli
10			*/
11			public $conn;
12			public $config;
13			public $lastQuery;
14			public $isConnected;
15			public $_dbconnectionmethod;
16
17			/**
18			* DBAPI constructor.
19			*
20			* @param string $host
21			* @param string $dbase
22			* @param string $uid
23			* @param string $pwd
24			* @param null\|string $pre
25			* @param string $charset
26			* @param string $connection_method
27			*/
28			public function __construct(
			0 ignored issues – show Coding Style introduced 2018-02-25 17:05 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style Naming introduced 2018-02-25 17:05 UTC by Report Bug Copy Issue Report The parameter $connection_method is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
29			$host = '',
30			$dbase = '',
31			$uid = '',
32			$pwd = '',
33			$pre = null,
34			$charset = '',
35			$connection_method = 'SET CHARACTER SET'
36			) {
37			$this->config['host'] = $host ? $host : $GLOBALS['database_server'];
38			$this->config['dbase'] = $dbase ? $dbase : $GLOBALS['dbase'];

evolution-cms / evolution

Push — develop ( 48041c...eb8457 )

Database::getConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like