evolution-cms / evolution

manager/media/browser/mcpuk/core/browser.php

Doc Comments +9 added lines

@@ -666,6 +666,9 @@ 
             return json_encode(array('version' => false));
     }
 
+    /**
+     * @param string $dir
+     */
     protected function moveUploadFile($file, $dir) {
         $message = $this->checkUploadedFile($file);
 
@@ -697,6 +700,9 @@ 
         return "/" . basename($target);
     }
 
+    /**
+     * @param string $file
+     */
     protected function sendDefaultThumb($file=null) {
         if ($file !== null) {
             $ext = file::getExtension($file);
@@ -873,6 +879,9 @@ 
         return "";
     }
 
+    /**
+     * @param string $message
+     */
     protected function errorMsg($message, array $data=null) {
         if (in_array($this->action, array("thumb", "upload", "download", "downloadDir")))
             die($this->label($message, $data));

Spacing +88 added lines, -88 removed lines

@@ -12,12 +12,12 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-class browser extends uploader {
+class browser extends uploader{
     protected $action;
     protected $thumbsDir;
     protected $thumbsTypeDir;
 
-    public function __construct($modx) {
+    public function __construct($modx){
         parent::__construct($modx);
 
         if (isset($this->post['dir'])) {
@@ -32,7 +32,7 @@ 
             $this->get['dir'] = $dir;
         }
 
-        $thumbsDir = $this->config['uploadDir'] . "/" . $this->config['thumbsDir'];
+        $thumbsDir = $this->config['uploadDir']."/".$this->config['thumbsDir'];
         if ((
                 !is_dir($thumbsDir) &&
                 !@mkdir($thumbsDir, $this->config['dirPerms'])
@@ -70,9 +70,9 @@ 
             $this->config['theme'] = $this->get['theme'];
     }
 
-    public function action() {
+    public function action(){
         $act = isset($this->get['act']) ? $this->get['act'] : "browser";
-        if(!preg_match('@^[0-9a-zA-Z_]+$@', $act)) $this->errorMsg("Unknown error.");
+        if (!preg_match('@^[0-9a-zA-Z_]+$@', $act)) $this->errorMsg("Unknown error.");
         if (!method_exists($this, "act_$act"))
             $act = "browser";
         $this->action = $act;
@@ -94,7 +94,7 @@ 
             $this->session['dir'] = $this->type;
         else {
             $type = $this->getTypeFromPath($this->session['dir']);
-            $dir = $this->config['uploadDir'] . "/" . $this->session['dir'];
+            $dir = $this->config['uploadDir']."/".$this->session['dir'];
             if (($type != $this->type) || !is_dir($dir) || !is_readable($dir))
                 $this->session['dir'] = $this->type;
         }
@@ -115,7 +115,7 @@ 
             : $return;
     }
 
-    protected function act_browser() {
+    protected function act_browser(){
         if (isset($this->get['dir']) &&
             is_dir("{$this->typeDir}/{$this->get['dir']}") &&
             is_readable("{$this->typeDir}/{$this->get['dir']}")
@@ -125,7 +125,7 @@ 
         return $this->output();
     }
 
-    protected function act_init() {
+    protected function act_init(){
         $tree = $this->getDirInfo($this->typeDir);
         $tree['dirs'] = $this->getTree($this->session['dir']);
         if (!is_array($tree['dirs']) || !count($tree['dirs']))
@@ -140,7 +140,7 @@ 
         return json_encode($data);
     }
 
-    protected function act_thumb() {
+    protected function act_thumb(){
         $this->getDir($this->get['dir'], true);
         if (!isset($this->get['file']) || !isset($this->get['dir']))
             $this->sendDefaultThumb();
@@ -149,7 +149,7 @@ 
             $this->sendDefaultThumb();
         $file = "{$this->thumbsDir}/{$this->type}/{$this->get['dir']}/$file";
         if (!is_file($file) || !is_readable($file)) {
-            $file = "{$this->config['uploadDir']}/{$this->type}/{$this->get['dir']}/" . basename($file);
+            $file = "{$this->config['uploadDir']}/{$this->type}/{$this->get['dir']}/".basename($file);
             if (!is_file($file) || !is_readable($file))
                 $this->sendDefaultThumb($file);
             $image = image::factory($this->imageDriver, $file);
@@ -171,13 +171,13 @@ 
         httpCache::file($file, "image/jpeg");
     }
 
-    protected function act_expand() {
+    protected function act_expand(){
         return json_encode(array('dirs' => $this->getDirs($this->postDir())));
     }
 
-    protected function act_chDir() {
+    protected function act_chDir(){
         $this->postDir(); // Just for existing check
-        $this->session['dir'] = $this->type . "/" . $this->post['dir'];
+        $this->session['dir'] = $this->type."/".$this->post['dir'];
         $dirWritable = dir::isWritable("{$this->config['uploadDir']}/{$this->session['dir']}");
         return json_encode(array(
             'files' => $this->getFiles($this->session['dir']),
@@ -185,7 +185,7 @@ 
         ));
     }
 
-    protected function act_newDir() {
+    protected function act_newDir(){
         if (!$this->config['access']['dirs']['create'] ||
             !isset($this->post['dir']) ||
             !isset($this->post['newDir'])
@@ -207,7 +207,7 @@ 
         return true;
     }
 
-    protected function act_renameDir() {
+    protected function act_renameDir(){
         if (!$this->config['access']['dirs']['rename'] ||
             !isset($this->post['dir']) ||
             !isset($this->post['newName'])
@@ -222,15 +222,15 @@ 
             $this->errorMsg("Unallowable characters in folder name.");
         if (substr($newName, 0, 1) == ".")
             $this->errorMsg("Folder name shouldn't begins with '.'");
-        if (!@rename($dir, dirname($dir) . "/$newName"))
+        if (!@rename($dir, dirname($dir)."/$newName"))
             $this->errorMsg("Cannot rename the folder.");
         $thumbDir = "$this->thumbsTypeDir/{$this->post['dir']}";
         if (is_dir($thumbDir))
-            @rename($thumbDir, dirname($thumbDir) . "/$newName");
+            @rename($thumbDir, dirname($thumbDir)."/$newName");
         return json_encode(array('name' => $newName));
     }
 
-    protected function act_deleteDir() {
+    protected function act_deleteDir(){
         if (!$this->config['access']['dirs']['delete'] ||
             !isset($this->post['dir']) ||
             !strlen(trim($this->post['dir']))
@@ -250,7 +250,7 @@ 
         return true;
     }
 
-    protected function act_upload() {
+    protected function act_upload(){
         if (!$this->config['access']['files']['upload'] ||
             !isset($this->post['dir'])
         )
@@ -275,11 +275,11 @@ 
             return $this->moveUploadFile($this->file, $dir);
     }
 
-    protected function act_download() {
+    protected function act_download(){
         $dir = $this->postDir();
         if (!isset($this->post['dir']) ||
             !isset($this->post['file']) ||
-            strpos($this->post['file'],'../')!==false ||
+            strpos($this->post['file'], '../') !== false ||
             (false === ($file = "$dir/{$this->post['file']}")) ||
             !file_exists($file) || !is_readable($file)
         )
@@ -290,19 +290,19 @@ 
         header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
         header("Cache-Control: private", false);
         header("Content-Type: application/octet-stream");
-        header('Content-Disposition: attachment; filename="' . str_replace('"', "_", $this->post['file']) . '"');
+        header('Content-Disposition: attachment; filename="'.str_replace('"', "_", $this->post['file']).'"');
         header("Content-Transfer-Encoding:­ binary");
-        header("Content-Length: " . filesize($file));
+        header("Content-Length: ".filesize($file));
         readfile($file);
         die;
     }
 
-    protected function act_rename() {
+    protected function act_rename(){
         $dir = $this->postDir();
         if (!$this->config['access']['files']['rename'] ||
             !isset($this->post['dir']) ||
             !isset($this->post['file']) ||
-            strpos($this->post['file'],'../')!==false ||
+            strpos($this->post['file'], '../') !== false ||
             !isset($this->post['newName']) ||
             (false === ($file = "$dir/{$this->post['file']}")) ||
             !file_exists($file) || !is_readable($file) || !file::isWritable($file)
@@ -337,16 +337,16 @@ 
         $thumbFile = "$thumbDir/{$this->post['file']}";
 
         if (file_exists($thumbFile))
-            @rename($thumbFile, "$thumbDir/" . basename($newName));
+            @rename($thumbFile, "$thumbDir/".basename($newName));
         return true;
     }
 
-    protected function act_delete() {
+    protected function act_delete(){
         $dir = $this->postDir();
         if (!$this->config['access']['files']['delete'] ||
             !isset($this->post['dir']) ||
             !isset($this->post['file']) ||
-            strpos($this->post['file'],'../')!==false ||
+            strpos($this->post['file'], '../') !== false ||
             (false === ($file = "$dir/{$this->post['file']}")) ||
             !file_exists($file) || !is_readable($file) || !file::isWritable($file) ||
             !@unlink($file)
@@ -358,7 +358,7 @@ 
         return true;
     }
 
-    protected function act_cp_cbd() {
+    protected function act_cp_cbd(){
         $dir = $this->postDir();
         if (!$this->config['access']['files']['copy'] ||
             !isset($this->post['dir']) ||
@@ -369,7 +369,7 @@ 
             $this->errorMsg("Unknown error.");
 
         $error = array();
-        foreach($this->post['files'] as $file) {
+        foreach ($this->post['files'] as $file) {
             $file = path::normalize($file);
             if (substr($file, 0, 1) == ".") continue;
             $type = explode("/", $file);
@@ -382,11 +382,11 @@ 
             if (!file_exists($path))
                 $error[] = $this->label("The file '{file}' does not exist.", $replace);
             elseif (substr($base, 0, 1) == ".")
-                $error[] = "$base: " . $this->label("File name shouldn't begins with '.'");
+                $error[] = "$base: ".$this->label("File name shouldn't begins with '.'");
             elseif (!$this->validateExtension($ext, $type))
-                $error[] = "$base: " . $this->label("Denied file extension.");
+                $error[] = "$base: ".$this->label("Denied file extension.");
             elseif (file_exists("$dir/$base"))
-                $error[] = "$base: " . $this->label("A file or folder with that name already exists.");
+                $error[] = "$base: ".$this->label("A file or folder with that name already exists.");
             elseif (!is_readable($path) || !is_file($path))
                 $error[] = $this->label("Cannot read '{file}'.", $replace);
             elseif (!@copy($path, "$dir/$base"))
@@ -409,7 +409,7 @@ 
         return true;
     }
 
-    protected function act_mv_cbd() {
+    protected function act_mv_cbd(){
         $dir = $this->postDir();
         if (!$this->config['access']['files']['move'] ||
             !isset($this->post['dir']) ||
@@ -420,7 +420,7 @@ 
             $this->errorMsg("Unknown error.");
 
         $error = array();
-        foreach($this->post['files'] as $file) {
+        foreach ($this->post['files'] as $file) {
             $file = path::normalize($file);
             if (substr($file, 0, 1) == ".") continue;
             $type = explode("/", $file);
@@ -433,11 +433,11 @@ 
             if (!file_exists($path))
                 $error[] = $this->label("The file '{file}' does not exist.", $replace);
             elseif (substr($base, 0, 1) == ".")
-                $error[] = "$base: " . $this->label("File name shouldn't begins with '.'");
+                $error[] = "$base: ".$this->label("File name shouldn't begins with '.'");
             elseif (!$this->validateExtension($ext, $type))
-                $error[] = "$base: " . $this->label("Denied file extension.");
+                $error[] = "$base: ".$this->label("Denied file extension.");
             elseif (file_exists("$dir/$base"))
-                $error[] = "$base: " . $this->label("A file or folder with that name already exists.");
+                $error[] = "$base: ".$this->label("A file or folder with that name already exists.");
             elseif (!is_readable($path) || !is_file($path))
                 $error[] = $this->label("Cannot read '{file}'.", $replace);
             elseif (!file::isWritable($path) || !@rename($path, "$dir/$base"))
@@ -460,7 +460,7 @@ 
         return true;
     }
 
-    protected function act_rm_cbd() {
+    protected function act_rm_cbd(){
         if (!$this->config['access']['files']['delete'] ||
             !isset($this->post['files']) ||
             !is_array($this->post['files']) ||
@@ -469,7 +469,7 @@ 
             $this->errorMsg("Unknown error.");
 
         $error = array();
-        foreach($this->post['files'] as $file) {
+        foreach ($this->post['files'] as $file) {
             $file = path::normalize($file);
             if (substr($file, 0, 1) == ".") continue;
             $type = explode("/", $file);
@@ -492,25 +492,25 @@ 
         return true;
     }
 
-    protected function act_downloadDir() {
+    protected function act_downloadDir(){
         $dir = $this->postDir();
         if (!isset($this->post['dir']) || $this->config['denyZipDownload'])
             $this->errorMsg("Unknown error.");
-        $filename = basename($dir) . ".zip";
+        $filename = basename($dir).".zip";
         do {
-            $file = md5(time() . session_id());
+            $file = md5(time().session_id());
             $file = "{$this->config['uploadDir']}/$file.zip";
         } while (file_exists($file));
         new zipFolder($file, $dir);
         header("Content-Type: application/x-zip");
-        header('Content-Disposition: attachment; filename="' . str_replace('"', "_", $filename) . '"');
-        header("Content-Length: " . filesize($file));
+        header('Content-Disposition: attachment; filename="'.str_replace('"', "_", $filename).'"');
+        header("Content-Length: ".filesize($file));
         readfile($file);
         unlink($file);
         die;
     }
 
-    protected function act_downloadSelected() {
+    protected function act_downloadSelected(){
         $dir = $this->postDir();
         if (!isset($this->post['dir']) ||
             !isset($this->post['files']) ||
@@ -531,7 +531,7 @@ 
         }
 
         do {
-            $file = md5(time() . session_id());
+            $file = md5(time().session_id());
             $file = "{$this->config['uploadDir']}/$file.zip";
         } while (file_exists($file));
 
@@ -543,14 +543,14 @@ 
             $zip->close();
         }
         header("Content-Type: application/x-zip");
-        header('Content-Disposition: attachment; filename="selected_files_' . basename($file) . '"');
-        header("Content-Length: " . filesize($file));
+        header('Content-Disposition: attachment; filename="selected_files_'.basename($file).'"');
+        header("Content-Length: ".filesize($file));
         readfile($file);
         unlink($file);
         die;
     }
 
-    protected function act_downloadClipboard() {
+    protected function act_downloadClipboard(){
         if (!isset($this->post['files']) ||
             !is_array($this->post['files']) ||
             $this->config['denyZipDownload']
@@ -566,14 +566,14 @@ 
             $type = $type[0];
             if ($type != $this->type)
                 continue;
-            $file = $this->config['uploadDir'] . "/$file";
+            $file = $this->config['uploadDir']."/$file";
             if (!is_file($file) || !is_readable($file))
                 continue;
             $zipFiles[] = $file;
         }
 
         do {
-            $file = md5(time() . session_id());
+            $file = md5(time().session_id());
             $file = "{$this->config['uploadDir']}/$file.zip";
         } while (file_exists($file));
 
@@ -585,14 +585,14 @@ 
             $zip->close();
         }
         header("Content-Type: application/x-zip");
-        header('Content-Disposition: attachment; filename="clipboard_' . basename($file) . '"');
-        header("Content-Length: " . filesize($file));
+        header('Content-Disposition: attachment; filename="clipboard_'.basename($file).'"');
+        header("Content-Length: ".filesize($file));
         readfile($file);
         unlink($file);
         die;
     }
 
-    protected function act_check4Update() {
+    protected function act_check4Update(){
         if ($this->config['denyUpdateCheck'])
             return json_encode(array('version' => false));
 
@@ -632,24 +632,24 @@ 
         // Curl extension
         ) {} elseif (
             function_exists("curl_init") &&
-            (false !== (   $curl = @curl_init($url)                                    )) &&
-            (              @ob_start()                 ||  (@curl_close($curl) && false)) &&
-            (              @curl_exec($curl)           ||  (@curl_close($curl) && false)) &&
-            ((false !== (  $ver = @ob_get_clean()   )) ||  (@curl_close($curl) && false)) &&
-            (              @curl_close($curl)          ||  true                         ) &&
+            (false !== ($curl = @curl_init($url))) &&
+            (@ob_start() || (@curl_close($curl) && false)) &&
+            (@curl_exec($curl) || (@curl_close($curl) && false)) &&
+            ((false !== ($ver = @ob_get_clean())) || (@curl_close($curl) && false)) &&
+            (@curl_close($curl) || true) &&
             preg_match($pattern, $ver)
 
         // Socket extension
         ) {} elseif (function_exists('socket_create')) {
             $cmd =
-                "GET $path " . strtoupper($protocol) . "/1.1\r\n" .
-                "Host: $host\r\n" .
+                "GET $path ".strtoupper($protocol)."/1.1\r\n".
+                "Host: $host\r\n".
                 "Connection: Close\r\n\r\n";
 
-            if ((false !== (  $socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP)  )) &&
-                (false !==    @socket_connect($socket, $host, $port)                    ) &&
-                (false !==    @socket_write($socket, $cmd, strlen($cmd))                ) &&
-                (false !== (  $ver = @socket_read($socket, 2048)                       )) &&
+            if ((false !== ($socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP))) &&
+                (false !== @socket_connect($socket, $host, $port)) &&
+                (false !== @socket_write($socket, $cmd, strlen($cmd))) &&
+                (false !== ($ver = @socket_read($socket, 2048))) &&
                 preg_match($responsePattern, $ver, $match)
             )
                 $ver = $match[2];
@@ -666,7 +666,7 @@ 
             return json_encode(array('version' => false));
     }
 
-    protected function moveUploadFile($file, $dir) {
+    protected function moveUploadFile($file, $dir){
         $message = $this->checkUploadedFile($file);
 
         if ($message !== true) {
@@ -676,28 +676,28 @@ 
         }
 
         $filename = $this->normalizeFilename($file['name']);
-        $target = "$dir/" . file::getInexistantFilename($filename, $dir);
+        $target = "$dir/".file::getInexistantFilename($filename, $dir);
 
         if (!@move_uploaded_file($file['tmp_name'], $target) &&
             !@rename($file['tmp_name'], $target) &&
             !@copy($file['tmp_name'], $target)
         ) {
             @unlink($file['tmp_name']);
-            return "{$file['name']}: " . $this->label("Cannot move uploaded file to target folder.");
+            return "{$file['name']}: ".$this->label("Cannot move uploaded file to target folder.");
         } elseif (function_exists('chmod'))
             chmod($target, $this->config['filePerms']);
         
-        $this->modx->invokeEvent('OnFileBrowserUpload',array(
+        $this->modx->invokeEvent('OnFileBrowserUpload', array(
             'filepath'=>realpath($dir),
-            'filename'=>str_replace("/","",str_replace($dir,"",realpath($target)))
+            'filename'=>str_replace("/", "", str_replace($dir, "", realpath($target)))
         ));
         
         $this->makeThumb($target);
         
-        return "/" . basename($target);
+        return "/".basename($target);
     }
 
-    protected function sendDefaultThumb($file=null) {
+    protected function sendDefaultThumb($file = null){
         if ($file !== null) {
             $ext = file::getExtension($file);
             $thumb = "themes/{$this->config['theme']}/img/files/big/$ext.png";
@@ -709,7 +709,7 @@ 
         die;
     }
 
-	protected function getFiles($dir) {
+	protected function getFiles($dir){
 		$thumbDir = "{$this->config['uploadDir']}/{$this->config['thumbsDir']}/$dir";
 		$dir = "{$this->config['uploadDir']}/$dir";
 		$return = array();
@@ -720,10 +720,10 @@ 
 		foreach ($files as $file) {
 			$ext = file::getExtension($file);
 			$smallThumb = false;
-			if (in_array(strtolower($ext), array('png', 'jpg', 'gif', 'jpeg' )) ) {
+			if (in_array(strtolower($ext), array('png', 'jpg', 'gif', 'jpeg'))) {
 				$size = @getimagesize($file);
 				if (is_array($size) && count($size)) {
-					$thumb_file = "$thumbDir/" . basename($file);
+					$thumb_file = "$thumbDir/".basename($file);
 					if (!is_file($thumb_file) || filemtime($file) > filemtime($thumb_file))
 						$this->makeThumb($file);
 					$smallThumb =
@@ -736,9 +736,9 @@ 
 			if ($stat === false) continue;
 			$name = basename($file);
 			$types = $this->config['types'];
-			$types = explode(' ',$types['images'].' '.$types['image']);
-			if (substr($name,0,1) == '.' && !$this->config['showHiddenFiles']) continue;
-			if ($this->type == 'images' && !in_array(strtolower($ext),$types)) continue;
+			$types = explode(' ', $types['images'].' '.$types['image']);
+			if (substr($name, 0, 1) == '.' && !$this->config['showHiddenFiles']) continue;
+			if ($this->type == 'images' && !in_array(strtolower($ext), $types)) continue;
 			$bigIcon = file_exists("themes/{$this->config['theme']}/img/files/big/$ext.png");
 			$smallIcon = file_exists("themes/{$this->config['theme']}/img/files/small/$ext.png");
 			$thumb = file_exists("$thumbDir/$name");
@@ -758,7 +758,7 @@ 
 		return $return;
 	}
 
-    protected function getTree($dir, $index=0) {
+    protected function getTree($dir, $index = 0){
         $path = explode("/", $dir);
 
         $pdir = "";
@@ -793,25 +793,25 @@ 
         return $dirs;
     }
 
-    protected function postDir($existent=true) {
+    protected function postDir($existent = true){
         $dir = $this->typeDir;
         if (isset($this->post['dir']))
-            $dir .= "/" . $this->post['dir'];
+            $dir .= "/".$this->post['dir'];
         if ($existent && (!is_dir($dir) || !is_readable($dir)))
             $this->errorMsg("Inexistant or inaccessible folder.");
         return $dir;
     }
 
-    protected function getDir($existent=true) {
+    protected function getDir($existent = true){
         $dir = $this->typeDir;
         if (isset($this->get['dir']))
-            $dir .= "/" . $this->get['dir'];
+            $dir .= "/".$this->get['dir'];
         if ($existent && (!is_dir($dir) || !is_readable($dir)))
             $this->errorMsg("Inexistant or inaccessible folder.");
         return $dir;
     }
 
-    protected function getDirs($dir) {
+    protected function getDirs($dir){
         $dirs = dir::content($dir, array('types' => "dir"));
         $return = array();
         if (is_array($dirs)) {
@@ -826,7 +826,7 @@ 
         return $return;
     }
 
-    protected function getDirInfo($dir, $removable=false) {
+    protected function getDirInfo($dir, $removable = false){
         if ((substr(basename($dir), 0, 1) == ".") || !is_dir($dir) || !is_readable($dir))
             return false;
         $dirs = dir::content($dir, array('types' => "dir"));
@@ -853,7 +853,7 @@ 
         return $info;
     }
 
-    protected function output($data=null, $template=null) {
+    protected function output($data = null, $template = null){
         if (!is_array($data)) $data = array();
         if ($template === null)
             $template = $this->action;
@@ -873,7 +873,7 @@ 
         return "";
     }
 
-    protected function errorMsg($message, array $data=null) {
+    protected function errorMsg($message, array $data = null){
         if (in_array($this->action, array("thumb", "upload", "download", "downloadDir")))
             die($this->label($message, $data));
         if (($this->action === null) || ($this->action == "browser"))

manager/media/browser/mcpuk/core/uploader.php

Doc Comments +18 added lines

@@ -385,6 +385,9 @@ 
 	}
 
 
+	/**
+	 * @return string
+	 */
 	protected function normalizeFilename($filename) {
 		if ($this->getTransaliasSettings()) {
         		$format = strrchr($filename, ".");
@@ -394,6 +397,9 @@ 
         	return $filename;
 	}
 
+	/**
+	 * @param string $dirname
+	 */
 	protected function normalizeDirname($dirname) {
         return $this->modx->stripAlias($dirname);
     }
@@ -506,6 +512,9 @@ 
         return (is_dir($path) && is_readable($path)) ? $return : false;
     }
 
+    /**
+     * @param string $ext
+     */
     protected function validateExtension($ext, $type) {
         $ext = trim(strtolower($ext));
         if (!isset($this->types[$type]))
@@ -531,11 +540,17 @@ 
         return in_array($ext, $exts);
     }
 
+    /**
+     * @return string
+     */
     protected function getTypeFromPath($path) {
         return preg_match('/^([^\/]*)\/.*$/', $path, $patt)
             ? $patt[1] : $path;
     }
 
+    /**
+     * @param string $path
+     */
     protected function removeTypeFromPath($path) {
         return preg_match('/^[^\/]*\/(.*)$/', $path, $patt)
             ? $patt[1] : "";
@@ -728,6 +743,9 @@ 
         die;
     }
 
+    /**
+     * @param string $url
+     */
     protected function callBack($url, $message="") {
         $message = text::jsValue($message);
         $CKfuncNum = isset($this->opener['CKEditor']['funcNum'])

Spacing +46 added lines, -47 removed lines

@@ -12,7 +12,7 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-class uploader {
+class uploader{
 
 /** Release version */
     const VERSION = "2.54";
@@ -72,8 +72,8 @@ 
 
 /** Next three properties are got from the current language file
   * @var string */
-    protected $dateTimeFull;   // Currently not used
-    protected $dateTimeMid;    // Currently not used
+    protected $dateTimeFull; // Currently not used
+    protected $dateTimeMid; // Currently not used
     protected $dateTimeSmall;
 
 /** Contain Specified language labels
@@ -104,11 +104,11 @@ 
 /** Magic method which allows read-only access to protected or private class properties
   * @param string $property
   * @return mixed */
-    public function __get($property) {
+    public function __get($property){
         return property_exists($this, $property) ? $this->$property : null;
     }
 
-    public function __construct($modx) {
+    public function __construct($modx){
 
         //MODX
         try {
@@ -206,7 +206,7 @@ 
 
         // COOKIES INIT
         $ip = '(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)';
-        $ip = '/^' . implode('\.', array($ip, $ip, $ip, $ip)) . '$/';
+        $ip = '/^'.implode('\.', array($ip, $ip, $ip, $ip)).'$/';
         if (preg_match($ip, $_SERVER['HTTP_HOST']) ||
             preg_match('/^[^\.]+$/', $_SERVER['HTTP_HOST'])
         )
@@ -224,7 +224,7 @@ 
         ) {
             list($unused, $protocol, $domain, $unused, $port, $path) = $patt;
             $path = path::normalize($path);
-            $this->config['uploadURL'] = "$protocol://$domain" . (strlen($port) ? ":$port" : "") . "/$path";
+            $this->config['uploadURL'] = "$protocol://$domain".(strlen($port) ? ":$port" : "")."/$path";
             $this->config['uploadDir'] = strlen($this->config['uploadDir'])
                 ? path::normalize($this->config['uploadDir'])
                 : path::url2fullPath("/$path");
@@ -267,7 +267,7 @@ 
         foreach ($this->langInputNames as $key)
             if (isset($this->get[$key]) &&
                 preg_match('/^[a-z][a-z\._\-]*$/i', $this->get[$key]) &&
-                file_exists("lang/" . strtolower($this->get[$key]) . ".php")
+                file_exists("lang/".strtolower($this->get[$key]).".php")
             ) {
                 $this->lang = $this->get[$key];
                 break;
@@ -298,7 +298,7 @@ 
             $this->backMsg("Cannot read upload folder.");
     }
 
-    public function upload() {
+    public function upload(){
         $config = &$this->config;
         $file = &$this->file;
         $url = $message = "";
@@ -329,7 +329,7 @@ 
                     @mkdir(path::normalize($dir), $this->config['dirPerms'], true);
 
                 $filename = $this->normalizeFilename($file['name']);
-                $target = file::getInexistantFilename($dir . $filename);
+                $target = file::getInexistantFilename($dir.$filename);
 
                 if (!@move_uploaded_file($file['tmp_name'], $target) &&
                     !@rename($file['tmp_name'], $target) &&
@@ -342,11 +342,11 @@ 
                     $this->makeThumb($target);
                     $url = $this->typeURL;
                     if (isset($udir)) $url .= "/$udir";
-                    $url .= "/" . basename($target);
+                    $url .= "/".basename($target);
                     if (preg_match('/^([a-z]+)\:\/\/([^\/^\:]+)(\:(\d+))?\/(.+)$/', $url, $patt)) {
                         list($unused, $protocol, $domain, $unused, $port, $path) = $patt;
-                        $base = "$protocol://$domain" . (strlen($port) ? ":$port" : "") . "/";
-                        $url = $base . path::urlPathEncode($path);
+                        $base = "$protocol://$domain".(strlen($port) ? ":$port" : "")."/";
+                        $url = $base.path::urlPathEncode($path);
                     } else
                         $url = path::urlPathEncode($url);
                 }
@@ -365,12 +365,12 @@ 
     }
 
 
-	protected function getTransaliasSettings() {
+	protected function getTransaliasSettings(){
 		$modx = evolutionCMS();
 
 		// Cleaning uploaded filename?
 		$setting = $modx->db->select('count(*)', $modx->getFullTableName('system_settings'), 'setting_name="clean_uploaded_filename" AND setting_value=1');
-		if ($modx->db->getValue($setting)>0) {
+		if ($modx->db->getValue($setting) > 0) {
 			// Transalias plugin active?
 			$res = $modx->db->select('properties', $modx->getFullTableName('site_plugins'), 'name="TransAlias" AND disabled=0');
 			if ($properties = $modx->db->getValue($res)) {
@@ -385,7 +385,7 @@ 
 	}
 
 
-	protected function normalizeFilename($filename) {
+	protected function normalizeFilename($filename){
 		if ($this->getTransaliasSettings()) {
         		$format = strrchr($filename, ".");
         		$filename = str_replace($format, "", $filename);
@@ -394,11 +394,11 @@ 
         	return $filename;
 	}
 
-	protected function normalizeDirname($dirname) {
+	protected function normalizeDirname($dirname){
         return $this->modx->stripAlias($dirname);
     }
 
-    protected function checkUploadedFile(array $aFile=null) {
+    protected function checkUploadedFile(array $aFile = null){
         $config = &$this->config;
         $file = ($aFile === null) ? $this->file : $aFile;
 
@@ -437,8 +437,7 @@ 
                 ($file['error'] == UPLOAD_ERR_NO_TMP_DIR) ?
                     $this->label("Missing a temporary folder.") : (
                 ($file['error'] == UPLOAD_ERR_CANT_WRITE) ?
-                    $this->label("Failed to write file.") :
-                    $this->label("Unknown error.")
+                    $this->label("Failed to write file.") : $this->label("Unknown error.")
             )))));
 
         // HIDDEN FILENAMES CHECK
@@ -473,14 +472,14 @@ 
 
 
 	// CHECK FOR MODX MAX FILE SIZE
-	$actualfilesize=filesize($file['tmp_name']);
+	$actualfilesize = filesize($file['tmp_name']);
 	if (isset($this->config['maxfilesize']) && $actualfilesize > $this->config['maxfilesize'])
 	    return $this->label("File is too big: ".$actualfilesize." Bytes. (max ".$this->config['maxfilesize']." Bytes)");
 
         return true;
     }
 
-    protected function checkInputDir($dir, $inclType=true, $existing=true) {
+    protected function checkInputDir($dir, $inclType = true, $existing = true){
         $dir = path::normalize($dir);
         if (substr($dir, 0, 1) == "/")
             $dir = substr($dir, 1);
@@ -506,7 +505,7 @@ 
         return (is_dir($path) && is_readable($path)) ? $return : false;
     }
 
-    protected function validateExtension($ext, $type) {
+    protected function validateExtension($ext, $type){
         $ext = trim(strtolower($ext));
         if (!isset($this->types[$type]))
             return false;
@@ -531,17 +530,17 @@ 
         return in_array($ext, $exts);
     }
 
-    protected function getTypeFromPath($path) {
+    protected function getTypeFromPath($path){
         return preg_match('/^([^\/]*)\/.*$/', $path, $patt)
             ? $patt[1] : $path;
     }
 
-    protected function removeTypeFromPath($path) {
+    protected function removeTypeFromPath($path){
         return preg_match('/^[^\/]*\/(.*)$/', $path, $patt)
             ? $patt[1] : "";
     }
 
-    protected function imageResize($image, $file=null) {
+    protected function imageResize($image, $file = null){
 
         if (!($image instanceof image)) {
             $img = image::factory($this->imageDriver, $image);
@@ -629,24 +628,24 @@ 
             $img->watermark($this->config['watermark']['file'], $left, $top);
 		}
 
-        $options = array( 'file' => $file );
+        $options = array('file' => $file);
 
-        $type = exif_imagetype( $file );
+        $type = exif_imagetype($file);
 
-        switch ( $type ) {
+        switch ($type) {
             case IMAGETYPE_GIF:
-                return $img->output( 'gif', $options );
+                return $img->output('gif', $options);
 
             case IMAGETYPE_PNG:
-                return $img->output( 'png', $options );
+                return $img->output('png', $options);
 
             default:
-                return $img->output( 'jpeg', array_merge( $options, array( 'quality' => $this->config['jpegQuality'] ) ) );
+                return $img->output('jpeg', array_merge($options, array('quality' => $this->config['jpegQuality'])));
         }
 
     }
 
-    protected function makeThumb($file, $overwrite=true) {
+    protected function makeThumb($file, $overwrite = true){
         $img = image::factory($this->imageDriver, $file);
 
         // Drop files which are not images
@@ -654,7 +653,7 @@ 
             return true;
 
         $thumb = substr($file, strlen($this->config['uploadDir']));
-        $thumb = $this->config['uploadDir'] . "/" . $this->config['thumbsDir'] . "/" . $thumb;
+        $thumb = $this->config['uploadDir']."/".$this->config['thumbsDir']."/".$thumb;
         $thumb = path::normalize($thumb);
         $thumbDir = dirname($thumb);
         if (!is_dir($thumbDir) && !@mkdir($thumbDir, $this->config['dirPerms'], true))
@@ -677,15 +676,15 @@ 
         if (!$img->resizeFit($this->config['thumbWidth'], $this->config['thumbHeight']))
             return false;
 
-        if ( $this->imageDriver == 'gd' ) {
-            $width  = imagesx( $img->image );
-            $height = imagesy( $img->image );
-            $back   = image::factory( $this->imageDriver, array( $width, $height ) );
-            $tile   = image::factory( $this->imageDriver, __DIR__ . '/../themes/' . $this->config['theme'] . '/img/bg_transparent.png' );
+        if ($this->imageDriver == 'gd') {
+            $width  = imagesx($img->image);
+            $height = imagesy($img->image);
+            $back   = image::factory($this->imageDriver, array($width, $height));
+            $tile   = image::factory($this->imageDriver, __DIR__.'/../themes/'.$this->config['theme'].'/img/bg_transparent.png');
 
-            imagesettile( $back->image, $tile->image );
-            imagefilledrectangle( $back->image, 0, 0, $width, $height, IMG_COLOR_TILED );
-            imagecopy( $back->image, $img->image, 0, 0, 0, 0, $width, $height );
+            imagesettile($back->image, $tile->image);
+            imagefilledrectangle($back->image, 0, 0, $width, $height, IMG_COLOR_TILED);
+            imagecopy($back->image, $img->image, 0, 0, 0, 0, $width, $height);
 
             $img = $back;
         }
@@ -697,7 +696,7 @@ 
         ));
     }
 
-    protected function localize($langCode) {
+    protected function localize($langCode){
         require "lang/{$langCode}.php";
         setlocale(LC_ALL, $lang['_locale']);
         $this->charset = $lang['_charset'];
@@ -712,7 +711,7 @@ 
         $this->labels = $lang;
     }
 
-    protected function label($string, array $data=null) {
+    protected function label($string, array $data = null){
         $return = isset($this->labels[$string]) ? $this->labels[$string] : $string;
         if (is_array($data))
             foreach ($data as $key => $val)
@@ -720,7 +719,7 @@ 
         return $return;
     }
 
-    protected function backMsg($message, array $data=null) {
+    protected function backMsg($message, array $data = null){
         $message = $this->label($message, $data);
         if (isset($this->file['tmp_name']) && file_exists($this->file['tmp_name']))
             @unlink($this->file['tmp_name']);
@@ -728,7 +727,7 @@ 
         die;
     }
 
-    protected function callBack($url, $message="") {
+    protected function callBack($url, $message = ""){
         $message = text::jsValue($message);
         $CKfuncNum = isset($this->opener['CKEditor']['funcNum'])
             ? $this->opener['CKEditor']['funcNum'] : 0;
@@ -769,7 +768,7 @@ 
 
     }
 
-    protected function get_htaccess() {
+    protected function get_htaccess(){
         return "<IfModule mod_php4.c>
   php_value engine off
 </IfModule>

manager/media/browser/mcpuk/lib/class_fastImage.php

Doc Comments +6 added lines

@@ -183,6 +183,9 @@ 
 	}
 
 
+	/**
+	 * @param integer $n
+	 */
 	private function getChars($n)
 	{
 		$response = null;
@@ -225,6 +228,9 @@ 
 	}
 
 
+	/**
+	 * @param false|string $str
+	 */
 	private function readInt($str)
 	{
 		$size = unpack("C*", $str);

Spacing +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
 					{
 						$state = 'skipframe';
 					}
-					elseif (in_array($b, array_merge(range(0xC0,0xC3), range(0xC5,0xC7), range(0xC9,0xCB), range(0xCD,0xCF))))
+					elseif (in_array($b, array_merge(range(0xC0, 0xC3), range(0xC5, 0xC7), range(0xC9, 0xCB), range(0xCD, 0xCF))))
 					{
 						$state = 'readsize';
 					}
@@ -188,7 +188,7 @@ 
 		$response = null;
 
 		// do we need more data?
-		if ($this->strpos + $n -1 >= strlen($this->str))
+		if ($this->strpos + $n - 1 >= strlen($this->str))
 		{
 			$end = ($this->strpos + $n);
 

manager/media/browser/mcpuk/lib/class_gd.php

Doc Comments +8 added lines, -2 removed lines

@@ -168,7 +168,7 @@ 
     * The parameter $bigger_size is the bigger dimension (width or height) of calculated sizes.

     * The other dimension (height or width) will be calculated autamaticaly

     * @param integer $bigger_size

-    * @return array */

+    * @return integer[] */

 

     public function get_prop_size($bigger_size) {

 

@@ -255,7 +255,7 @@ 
     * no samo po edno (x ili y) izmerenie

     * @param integer $width

     * @param integer $height

-    * @return bool */

+    * @return gd */

 

     public function resize_overflow($width, $height) {

 

@@ -397,6 +397,12 @@ 
             return false;

     }

 

+    /**
+     * @param integer $x1
+     * @param integer $y1
+     * @param integer $x2
+     * @param integer $y2
+     */
     public function imagefilledrectangle($x1, $y1, $x2, $y2, $color) {

         $color = $this->gd_color($color);

         if ($color === false) return false;

Spacing +39 added lines, -39 removed lines

@@ -12,7 +12,7 @@ 
   *      @link http://kcfinder.sunhater.com

   */

 

-class gd {

+class gd{

 

   /** GD resource

     * @var resource */

@@ -40,7 +40,7 @@ 
     * @param mixed $image

     * @return array */

 

-    protected function build_image($image) {

+    protected function build_image($image){

 

         if ($image instanceof gd) {

             $width = $image->get_width();

@@ -58,12 +58,12 @@ 
 

         } elseif (false !== (list($width, $height, $type) = @getimagesize($image))) {

             $image =

-                ($type == IMAGETYPE_GIF)      ? @imagecreatefromgif($image)  : (

-                ($type == IMAGETYPE_WBMP)     ? @imagecreatefromwbmp($image) : (

-                ($type == IMAGETYPE_JPEG)     ? @imagecreatefromjpeg($image) : (

+                ($type == IMAGETYPE_GIF) ? @imagecreatefromgif($image) : (

+                ($type == IMAGETYPE_WBMP) ? @imagecreatefromwbmp($image) : (

+                ($type == IMAGETYPE_JPEG) ? @imagecreatefromjpeg($image) : (

                 ($type == IMAGETYPE_JPEG2000) ? @imagecreatefromjpeg($image) : (

-                ($type == IMAGETYPE_PNG)      ? @imagecreatefrompng($image)  : (

-                ($type == IMAGETYPE_XBM)      ? @imagecreatefromxbm($image)  : false

+                ($type == IMAGETYPE_PNG) ? @imagecreatefrompng($image) : (

+                ($type == IMAGETYPE_XBM) ? @imagecreatefromxbm($image) : false

             )))));

 

             if ($type == IMAGETYPE_PNG)

@@ -98,7 +98,7 @@ 
     * @param integer $bigger_size

     * @return gd */

 

-    public function __construct($image, $bigger_size=null) {

+    public function __construct($image, $bigger_size = null){

         $this->image = $this->width = $this->height = null;

 

         $image_details = $this->build_image($image);

@@ -126,21 +126,21 @@ 
   /** Returns the GD resource

     * @return resource */

 

-    public function get_image() {

+    public function get_image(){

         return $this->image;

     }

 

   /** Returns the image width

     * @return integer */

 

-    public function get_width() {

+    public function get_width(){

         return $this->width;

     }

 

   /** Returns the image height

     * @return integer */

 

-    public function get_height() {

+    public function get_height(){

         return $this->height;

     }

 

@@ -148,7 +148,7 @@ 
     * @param integer $resized_height

     * @return integer */

 

-    public function get_prop_width($resized_height) {

+    public function get_prop_width($resized_height){

         $width = intval(($this->width * $resized_height) / $this->height);

         if (!$width) $width = 1;

         return $width;

@@ -158,7 +158,7 @@ 
     * @param integer $resized_width

     * @return integer */

 

-    public function get_prop_height($resized_width) {

+    public function get_prop_height($resized_width){

         $height = intval(($this->height * $resized_width) / $this->width);

         if (!$height) $height = 1;

         return $height;

@@ -170,7 +170,7 @@ 
     * @param integer $bigger_size

     * @return array */

 

-    public function get_prop_size($bigger_size) {

+    public function get_prop_size($bigger_size){

 

         if ($this->width > $this->height) {

             $width = $bigger_size;

@@ -191,7 +191,7 @@ 
     * @param integer $height

     * @return bool */

 

-    public function resize($width, $height) {

+    public function resize($width, $height){

         if (!$width) $width = 1;

         if (!$height) $height = 1;

         return (

@@ -208,7 +208,7 @@ 
     * @param mixed $src

     * @return bool */

 

-    public function resize_crop($src) {

+    public function resize_crop($src){

         $image_details = $this->build_image($src);

 

         if ($image_details !== false) {

@@ -238,7 +238,7 @@ 
     * @param integer $height

     * @return bool */

 

-    public function resize_fit($width, $height) {

+    public function resize_fit($width, $height){

         if ((!$width && !$height) || (($width == $this->width) && ($height == $this->height)))

             return true;

         if (!$width || (($height / $width) < ($this->height / $this->width)))

@@ -257,7 +257,7 @@ 
     * @param integer $height

     * @return bool */

 

-    public function resize_overflow($width, $height) {

+    public function resize_overflow($width, $height){

 

         $big = (($this->width / $this->height) > ($width / $height))

             ? ($this->width * $height) / $this->height

@@ -275,7 +275,7 @@ 
         return $return;

     }

 

-    public function gd_color() {

+    public function gd_color(){

         $args = func_get_args();

 

         $expr_rgb = '/^rgb\(\s*(\d{1,3})\s*\,\s*(\d{1,3})\s*\,\s*(\d{1,3})\s*\)$/i';

@@ -317,7 +317,7 @@ 
         return imagecolorallocate($this->image, $r, $g, $b);

     }

 

-    public function fill_color($color) {

+    public function fill_color($color){

         return $this->imagefilledrectangle(0, 0, $this->width - 1, $this->height - 1, $color);

     }

 

@@ -326,11 +326,11 @@ 
 

     public function imagecopy(

         $src,

-        $dst_x=0, $dst_y=0,

-        $src_x=0, $src_y=0,

-        $dst_w=null, $dst_h=null,

-        $src_w=null, $src_h=null

-    ) {

+        $dst_x = 0, $dst_y = 0,

+        $src_x = 0, $src_y = 0,

+        $dst_w = null, $dst_h = null,

+        $src_w = null, $src_h = null

+    ){

         $image_details = $this->build_image($src);

 

         if ($image_details !== false) {

@@ -348,11 +348,11 @@ 
 

     public function imagecopyresampled(

         $src,

-        $dst_x=0, $dst_y=0,

-        $src_x=0, $src_y=0,

-        $dst_w=null, $dst_h=null,

-        $src_w=null, $src_h=null

-    ) {

+        $dst_x = 0, $dst_y = 0,

+        $src_x = 0, $src_y = 0,

+        $dst_w = null, $dst_h = null,

+        $src_w = null, $src_h = null

+    ){

         $image_details = $this->build_image($src);

 

         if ($image_details !== false) {

@@ -363,7 +363,7 @@ 
             if (is_null($src_w)) $src_w = $src_width - $src_x;

             if (is_null($src_h)) $src_h = $src_height - $src_y;

             imagealphablending($this->image, false);

-            imagesavealpha($this->image,true);

+            imagesavealpha($this->image, true);

 

 

 

@@ -372,7 +372,7 @@ 
 

 			$transindex = imagecolortransparent($src);

 			$palletsize = imagecolorstotal($src);

-			if($transindex >= 0 && $transindex < $palletsize) {

+			if ($transindex >= 0 && $transindex < $palletsize) {

 				$transcol = imagecolorsforindex($src, $transindex);

 

 			/*** end gif transparent fix ***/

@@ -381,9 +381,9 @@ 
 				imagefilledrectangle($this->image, 0, 0, $dst_w, $dst_h, $transindex);

 				imagecopyresampled($this->image, $src, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);

 				imagecolortransparent($this->image, $transindex);

-				for($y=0; $y<$dst_h; ++$y)

-					for($x=0; $x<$dst_w; ++$x)

-						if(((imagecolorat($this->image, $x, $y)>>24) & 0x7F) >= 100) imagesetpixel($this->image, $x, $y, $transindex);

+				for ($y = 0; $y < $dst_h; ++$y)

+					for ($x = 0; $x < $dst_w; ++$x)

+						if (((imagecolorat($this->image, $x, $y) >> 24) & 0x7F) >= 100) imagesetpixel($this->image, $x, $y, $transindex);

 				imagetruecolortopalette($this->image, true, 255);

 			}

 			else {

@@ -397,26 +397,26 @@ 
             return false;

     }

 

-    public function imagefilledrectangle($x1, $y1, $x2, $y2, $color) {

+    public function imagefilledrectangle($x1, $y1, $x2, $y2, $color){

         $color = $this->gd_color($color);

         if ($color === false) return false;

         return imagefilledrectangle($this->image, $x1, $y1, $x2, $y2, $color);

     }

 

-    public function imagepng($filename=null, $quality=null, $filters=null) {

+    public function imagepng($filename = null, $quality = null, $filters = null){

         if (is_null($filename) && !headers_sent())

             header("Content-Type: image/png");

         @imagesavealpha($this->image, true);

         return imagepng($this->image, $filename, $quality, $filters);

     }

 

-    public function imagejpeg($filename=null, $quality=75) {

+    public function imagejpeg($filename = null, $quality = 75){

         if (is_null($filename) && !headers_sent())

             header("Content-Type: image/jpeg");

         return imagejpeg($this->image, $filename, $quality);

     }

 

-    public function imagegif($filename=null) {

+    public function imagegif($filename = null){

         if (is_null($filename) && !headers_sent())

             header("Content-Type: image/gif");

 			@imagesavealpha($this->image, true);

manager/media/browser/mcpuk/lib/class_image.php

Doc Comments -1 removed lines

@@ -179,7 +179,6 @@
 
 /** Resize and crop the image to fit in given resolution. Returns TRUE on
   * success or FALSE on failure
-  * @param mixed $src
   * @param integer $offset
   * @return bool */
     abstract public function resizeCrop($width, $height, $offset=false);

Spacing +15 added lines, -15 removed lines

@@ -12,7 +12,7 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-abstract class image {
+abstract class image{
     const DEFAULT_JPEG_QUALITY = 75;
 
 /** Image resource or object
@@ -41,7 +41,7 @@ 
   * @param string $property
   * @return mixed */
 
-    final public function __get($property) {
+    final public function __get($property){
         return property_exists($this, $property) ? $this->$property : null;
     }
 
@@ -57,7 +57,7 @@ 
   * @param mixed $image
   * @param array $options */
 
-    public function __construct($image, array $options=array()) {
+    public function __construct($image, array $options = array()){
         $this->image = $this->width = $this->height = null;
         $imageDetails = $this->buildImage($image);
 
@@ -75,7 +75,7 @@ 
   * @param mixed $image
   * @return object */
 
-    final static function factory($driver, $image, array $options=array()) {
+    final static function factory($driver, $image, array $options = array()){
         $class = "image_$driver";
         return new $class($image, $options);
     }
@@ -86,7 +86,7 @@ 
   * @param array $drivers
   * @return string */
 
-    final static function getDriver(array $drivers=array('gd')) {
+    final static function getDriver(array $drivers = array('gd')){
         foreach ($drivers as $driver) {
             if (!preg_match('/^[a-z0-9\_]+$/i', $driver))
                 continue;
@@ -105,7 +105,7 @@ 
   * @param mixed $image
   * @return array */
 
-    final protected function buildImage($image) {
+    final protected function buildImage($image){
         $class = get_class($this);
 
         if ($image instanceof $class) {
@@ -131,7 +131,7 @@ 
   * @param integer $resizedHeight
   * @return integer */
 
-    final public function getPropWidth($resizedHeight) {
+    final public function getPropWidth($resizedHeight){
         $width = round(($this->width * $resizedHeight) / $this->height);
         if (!$width) $width = 1;
         return $width;
@@ -142,7 +142,7 @@ 
   * @param integer $resizedWidth
   * @return integer */
 
-    final public function getPropHeight($resizedWidth) {
+    final public function getPropHeight($resizedWidth){
         $height = round(($this->height * $resizedWidth) / $this->width);
         if (!$height) $height = 1;
         return $height;
@@ -153,13 +153,13 @@ 
   * static method should be implemented into driver classes like abstract
   * methods
   * @return bool */
-    static function available() { return false; }
+    static function available(){ return false; }
 
 /** Checks if file is an image. This static method should be implemented into
   * driver classes like abstract methods
   * @param string $file
   * @return bool */
-    static function checkImage($file) { return false; }
+    static function checkImage($file){ return false; }
 
 /** Resize image. Should return TRUE on success or FALSE on failure
   * @param integer $width
@@ -175,21 +175,21 @@ 
   * @param integer $height
   * @param mixed $background
   * @return bool */
-    abstract public function resizeFit($width, $height, $background=false);
+    abstract public function resizeFit($width, $height, $background = false);
 
 /** Resize and crop the image to fit in given resolution. Returns TRUE on
   * success or FALSE on failure
   * @param mixed $src
   * @param integer $offset
   * @return bool */
-    abstract public function resizeCrop($width, $height, $offset=false);
+    abstract public function resizeCrop($width, $height, $offset = false);
 
 
 /** Rotate image
   * @param integer $angle
   * @param string $background
   * @return bool */
-    abstract public function rotate($angle, $background="#000000");
+    abstract public function rotate($angle, $background = "#000000");
 
     abstract public function flipHorizontal();
 
@@ -205,7 +205,7 @@ 
   * @param mixed $top
   * @param mixed $left
   * @return bool */
-    abstract public function watermark($file, $left=false, $top=false);
+    abstract public function watermark($file, $left = false, $top = false);
 
 /** Should output the image. Second parameter is used to pass some options like
   *   'file' - if is set, the output will be written to a file
@@ -214,7 +214,7 @@ 
   * @param string $type
   * @param array $options
   * @return bool */
-    abstract public function output($type='jpeg', array $options=array());
+    abstract public function output($type = 'jpeg', array $options = array());
 
 /** This method should create a blank image with selected size. Should returns
   * resource or object related to the created image, which will be passed to

manager/media/browser/mcpuk/lib/class_image_gd.php

Doc Comments +5 added lines

@@ -327,6 +327,11 @@
         return imagecolorallocate($this->image, $r, $g, $b);
     }
 
+    /**
+     * @param integer $x1
+     * @param integer $y1
+     * @param boolean $color
+     */
     protected function imageFilledRectangle($x1, $y1, $x2, $y2, $color) {
         $color = $this->gdColor($color);
         if ($color === false) return false;

Spacing +26 added lines, -26 removed lines

@@ -12,12 +12,12 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-class image_gd extends image {
+class image_gd extends image{
 
 
     // ABSTRACT PUBLIC METHODS
 
-    public function resize($width, $height) {
+    public function resize($width, $height){
         if (!$width) $width = 1;
         if (!$height) $height = 1;
         return (
@@ -29,7 +29,7 @@ 
         );
     }
 
-    public function resizeFit($width, $height, $background=false) {
+    public function resizeFit($width, $height, $background = false){
         if ((!$width && !$height) || (($width == $this->width) && ($height == $this->height)))
             return true;
         if (!$width || (($height / $width) < ($this->height / $this->width))) {
@@ -67,7 +67,7 @@ 
         }
     }
 
-    public function resizeCrop($width, $height, $offset=false) {
+    public function resizeCrop($width, $height, $offset = false){
 
         if (($this->width / $this->height) > ($width / $height)) {
             $h = $height;
@@ -117,7 +117,7 @@ 
         return $return;
     }
 
-    public function rotate($angle, $background="#000000") {
+    public function rotate($angle, $background = "#000000"){
         $angle = -$angle;
         $img = @imagerotate($this->image, $angle, $this->gdColor($background));
         if ($img === false)
@@ -128,7 +128,7 @@ 
         return true;
     }
 
-    public function flipHorizontal() {
+    public function flipHorizontal(){
         $img = imagecreatetruecolor($this->width, $this->height);
             imagealphablending($img, false);
             imagesavealpha($img, true);
@@ -139,7 +139,7 @@ 
         return true;
     }
 
-    public function flipVertical() {
+    public function flipVertical(){
         $img = imagecreatetruecolor($this->width, $this->height);
             imagealphablending($img, false);
             imagesavealpha($img, true);
@@ -150,7 +150,7 @@ 
         return true;
     }
 
-    public function watermark($file, $left=false, $top=false) {
+    public function watermark($file, $left = false, $top = false){
         $info = getimagesize($file);
         list($w, $h, $t) = $info;
         if (!in_array($t, array(IMAGETYPE_PNG, IMAGETYPE_GIF)))
@@ -187,7 +187,7 @@ 
         return true;
     }
 
-    public function output($type='jpeg', array $options=array()) {
+    public function output($type = 'jpeg', array $options = array()){
         $method = "output_$type";
         if (!method_exists($this, $method))
             return false;
@@ -197,7 +197,7 @@ 
 
     // ABSTRACT PROTECTED METHODS
 
-    protected function getBlankImage($width, $height) {
+    protected function getBlankImage($width, $height){
         $img = @imagecreatetruecolor($width, $height);
 //        imagealphablending($img, false);
 //        imagesavealpha($img, true);
@@ -207,7 +207,7 @@ 
         return $img;
     }
 
-    protected function getImage($image, &$width, &$height) {
+    protected function getImage($image, &$width, &$height){
 
         if (is_resource($image) && (get_resource_type($image) == "gd")) {
             $width = @imagesx($image);
@@ -218,11 +218,11 @@ 
             (false !== (list($width, $height, $t) = @getimagesize($image)))
         ) {
             $image =
-                ($t == IMAGETYPE_GIF)  ? @imagecreatefromgif($image)  : (
+                ($t == IMAGETYPE_GIF) ? @imagecreatefromgif($image) : (
                 ($t == IMAGETYPE_WBMP) ? @imagecreatefromwbmp($image) : (
                 ($t == IMAGETYPE_JPEG) ? @imagecreatefromjpeg($image) : (
-                ($t == IMAGETYPE_PNG)  ? @imagecreatefrompng($image)  : (
-                ($t == IMAGETYPE_XBM)  ? @imagecreatefromxbm($image)  : false
+                ($t == IMAGETYPE_PNG) ? @imagecreatefrompng($image) : (
+                ($t == IMAGETYPE_XBM) ? @imagecreatefromxbm($image) : false
             ))));
 
             return $image;
@@ -234,22 +234,22 @@ 
 
     // PSEUDO-ABSTRACT STATIC METHODS
 
-    static function available() {
+    static function available(){
         return function_exists("imagecreatefromjpeg");
     }
 
-    static function checkImage($file) {
+    static function checkImage($file){
         if (!is_string($file) ||
             ((false === (list($width, $height, $t) = @getimagesize($file))))
         )
             return false;
 
         $img =
-            ($t == IMAGETYPE_GIF)  ? @imagecreatefromgif($file)  : (
+            ($t == IMAGETYPE_GIF) ? @imagecreatefromgif($file) : (
             ($t == IMAGETYPE_WBMP) ? @imagecreatefromwbmp($file) : (
             ($t == IMAGETYPE_JPEG) ? @imagecreatefromjpeg($file) : (
-            ($t == IMAGETYPE_PNG)  ? @imagecreatefrompng($file)  : (
-            ($t == IMAGETYPE_XBM)  ? @imagecreatefromxbm($file)  : false
+            ($t == IMAGETYPE_PNG) ? @imagecreatefrompng($file) : (
+            ($t == IMAGETYPE_XBM) ? @imagecreatefromxbm($file) : false
         ))));
 
         return ($img !== false);
@@ -258,7 +258,7 @@ 
 
     // OWN METHODS
 
-    protected function output_png(array $options=array()) {
+    protected function output_png(array $options = array()){
         $file = isset($options['file']) ? $options['file'] : null;
         $quality = isset($options['quality']) ? $options['quality'] : null;
         $filters = isset($options['filters']) ? $options['filters'] : null;
@@ -268,7 +268,7 @@ 
         return imagepng($this->image, $file, $quality, $filters);
     }
 
-    protected function output_jpeg(array $options=array()) {
+    protected function output_jpeg(array $options = array()){
         $file = isset($options['file']) ? $options['file'] : null;
         $quality = isset($options['quality'])
             ? $options['quality']
@@ -278,14 +278,14 @@ 
         return imagejpeg($this->image, $file, $quality);
     }
 
-    protected function output_gif(array $options=array()) {
+    protected function output_gif(array $options = array()){
         $file = isset($options['file']) ? $options['file'] : null;
         if (isset($options['file']) && !headers_sent())
             header("Content-Type: image/gif");
         return imagegif($this->image, $file);
     }
 
-    protected function gdColor() {
+    protected function gdColor(){
         $args = func_get_args();
 
         $exprRGB = '/^rgb\(\s*(\d{1,3})\s*\,\s*(\d{1,3})\s*\,\s*(\d{1,3})\s*\)$/i';
@@ -327,15 +327,15 @@ 
         return imagecolorallocate($this->image, $r, $g, $b);
     }
 
-    protected function imageFilledRectangle($x1, $y1, $x2, $y2, $color) {
+    protected function imageFilledRectangle($x1, $y1, $x2, $y2, $color){
         $color = $this->gdColor($color);
         if ($color === false) return false;
         return imageFilledRectangle($this->image, $x1, $y1, $x2, $y2, $color);
     }
 
     protected function imageCopyResampled(
-        $src, $dstX=0, $dstY=0, $srcX=0, $srcY=0, $dstW=null, $dstH=null, $srcW=null, $srcH=null
-    ) {
+        $src, $dstX = 0, $dstY = 0, $srcX = 0, $srcY = 0, $dstW = null, $dstH = null, $srcW = null, $srcH = null
+    ){
         $imageDetails = $this->buildImage($src);
 
         if ($imageDetails === false)

manager/media/browser/mcpuk/lib/class_zipFolder.php

Doc Comments +6 added lines

@@ -18,6 +18,9 @@ 
     protected $root;
     protected $ignored;
 
+    /**
+     * @param string $folder
+     */
     function __construct($file, $folder, $ignored=null) {
         $this->zip = new ZipArchive();
 
@@ -39,6 +42,9 @@ 
         $this->zip->close();
     }
 
+    /**
+     * @param string $folder
+     */
     function zip($folder, $parent=null) {
         $full_path = "{$this->root}$parent$folder";
         $zip_path = "$parent$folder";

Spacing +3 added lines, -3 removed lines

@@ -13,12 +13,12 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-class zipFolder {
+class zipFolder{
     protected $zip;
     protected $root;
     protected $ignored;
 
-    function __construct($file, $folder, $ignored=null) {
+    function __construct($file, $folder, $ignored = null){
         $this->zip = new ZipArchive();
 
         $this->ignored = is_array($ignored)
@@ -39,7 +39,7 @@ 
         $this->zip->close();
     }
 
-    function zip($folder, $parent=null) {
+    function zip($folder, $parent = null){
         $full_path = "{$this->root}$parent$folder";
         $zip_path = "$parent$folder";
         $this->zip->addEmptyDir($zip_path);

manager/media/browser/mcpuk/lib/helper_file.php

Doc Comments -2 removed lines

@@ -102,7 +102,6 @@ 
 
   /** Checks if the given file is really writable. The standard PHP function
     * is_writable() does not work properly on Windows servers.
-    * @param string $dir
     * @return bool */
 
     static function isWritable($filename) {
@@ -114,7 +113,6 @@ 
     }
 
   /** Get the extension from filename
-    * @param string $file
     * @param bool $toLower
     * @return string */
 

Spacing +7 added lines, -7 removed lines

@@ -12,7 +12,7 @@ 
   *      @link http://kcfinder.sunhater.com
   */
 
-class file {
+class file{
 
     static $MIME = array(
         'ai'    => 'application/postscript',
@@ -105,7 +105,7 @@ 
     * @param string $dir
     * @return bool */
 
-    static function isWritable($filename) {
+    static function isWritable($filename){
         $filename = path::normalize($filename);
         if (!is_file($filename) || (false === ($fp = @fopen($filename, 'a+'))))
             return false;
@@ -118,7 +118,7 @@ 
     * @param bool $toLower
     * @return string */
 
-    static function getExtension($filename, $toLower=true) {
+    static function getExtension($filename, $toLower = true){
         return preg_match('/^.*\.([^\.]*)$/s', $filename, $patt)
             ? ($toLower ? strtolower($patt[1]) : $patt[1]) : "";
     }
@@ -134,7 +134,7 @@ 
     * @param string $magic
     * @return string */
 
-    static function getMimeType($filename, $magic=null) {
+    static function getMimeType($filename, $magic = null){
         if (class_exists("finfo")) {
             $finfo = ($magic === null)
                 ? new finfo(FILEINFO_MIME)
@@ -170,7 +170,7 @@ 
     * @param string $tpl
     * @return string */
 
-    static function getInexistantFilename($filename, $dir=null, $tpl=null) {
+    static function getInexistantFilename($filename, $dir = null, $tpl = null){
         if ($tpl === null)  $tpl = "{name}({sufix}){ext}";
         $fullPath = ($dir === null);
         if ($fullPath)
@@ -188,12 +188,12 @@ 
         $tpl = str_replace('{ext}', (strlen($ext) ? ".$ext" : ""), $tpl);
         $i = 1; $file = "$dir/$filename";
         while (file_exists($file))
-            $file = "$dir/" . str_replace('{sufix}', $i++, $tpl);
+            $file = "$dir/".str_replace('{sufix}', $i++, $tpl);
 
         return $fullPath
             ? $file
             : (strlen($fdir)
-                ? "$fdir/" . basename($file)
+                ? "$fdir/".basename($file)
                 : basename($file));
     }
 

manager/actions/mutate_settings/tab7_filebrowser_settings.inc.php

Spacing +58 added lines, -58 removed lines

@@ -6,8 +6,8 @@ 
   <tr>

     <td nowrap class="warning"><?php echo $_lang['rb_title']?><br><small>[(use_browser)]</small></td>

     <td>

-        <?php echo wrap_label($_lang['yes'],form_radio('use_browser', 1, 'id="rbRowOn"'));?><br />

-        <?php echo wrap_label($_lang['no'], form_radio('use_browser', 0, 'id="rbRowOff"'));?>

+        <?php echo wrap_label($_lang['yes'], form_radio('use_browser', 1, 'id="rbRowOn"')); ?><br />

+        <?php echo wrap_label($_lang['no'], form_radio('use_browser', 0, 'id="rbRowOff"')); ?>

     </td>

   </tr>

   <tr>

@@ -18,7 +18,7 @@ 
     <td colspan="2"><div class="split"></div></td>

   </tr>

   

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['which_browser_default_title']?><br><small>[(which_browser)]</small></td>

     <td>

         <select name="which_browser" size="1" class="inputBox" onchange="documentDirty=true;">

@@ -27,206 +27,206 @@ 
                 $dir = str_replace('\\', '/', $dir);

                 $browser_name = substr($dir, strrpos($dir, '/') + 1);

                 $selected = $browser_name == $which_browser ? ' selected="selected"' : '';

-                echo '<option value="' . $browser_name . '"' . $selected . '>' . "{$browser_name}</option>\n";

+                echo '<option value="'.$browser_name.'"'.$selected.'>'."{$browser_name}</option>\n";

             }

             ?>

         </select>

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['which_browser_default_msg']?></td>

   </tr>

   <tr>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['rb_webuser_title']?><br><small>[(rb_webuser)]</small></td>

     <td>

-      <label><input type="radio" name="rb_webuser" value="1" <?php echo $rb_webuser=='1' ? 'checked="checked"' : "" ; ?> />

+      <label><input type="radio" name="rb_webuser" value="1" <?php echo $rb_webuser == '1' ? 'checked="checked"' : ""; ?> />

       <?php echo $_lang['yes']?></label><br />

-      <label><input type="radio" name="rb_webuser" value="0" <?php echo $rb_webuser=='0' ? 'checked="checked"' : "" ; ?> />

+      <label><input type="radio" name="rb_webuser" value="0" <?php echo $rb_webuser == '0' ? 'checked="checked"' : ""; ?> />

       <?php echo $_lang['no']?></label>

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['rb_webuser_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['rb_base_dir_title']?><br><small>[(rb_base_dir)]</small></td>

     <td>

         <?php echo $_lang['default']; ?> <span id="default_rb_base_dir">[(base_path)]assets/</span><br />

         <input onchange="documentDirty=true;" type="text" maxlength="255" style="width: 250px;" name="rb_base_dir" id="rb_base_dir" value="<?php echo $rb_base_dir; ?>" /> <input type="button" onclick="reset_path('rb_base_dir');" value="<?php echo $_lang['reset']; ?>" name="reset_rb_base_dir">

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['rb_base_dir_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['rb_base_url_title']?><br><small>[(rb_base_url)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="255" style="width: 250px;" name="rb_base_url" value="<?php echo $rb_base_url; ?>" />

       </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['rb_base_url_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

       <td nowrap class="warning"><?php echo $_lang['clean_uploaded_filename']?><br><small>[(clean_uploaded_filename)]</small></td>

       <td>

-        <label><input type="radio" name="clean_uploaded_filename" value="1" <?php echo $clean_uploaded_filename=='1' ? 'checked="checked"' : "" ; ?> />

+        <label><input type="radio" name="clean_uploaded_filename" value="1" <?php echo $clean_uploaded_filename == '1' ? 'checked="checked"' : ""; ?> />

         <?php echo $_lang['yes']?></label><br />

-        <label><input type="radio" name="clean_uploaded_filename" value="0" <?php echo $clean_uploaded_filename=='0' ? 'checked="checked"' : "" ; ?> />

+        <label><input type="radio" name="clean_uploaded_filename" value="0" <?php echo $clean_uploaded_filename == '0' ? 'checked="checked"' : ""; ?> />

         <?php echo $_lang['no']?></label>

       </td>

   </tr>

-    <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+    <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

       <td width="200">&nbsp;</td>

-      <td class="comment"><?php echo $_lang['clean_uploaded_filename_message'];?></td>

+      <td class="comment"><?php echo $_lang['clean_uploaded_filename_message']; ?></td>

     </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

   <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['settings_strip_image_paths_title']?><br><small>[(strip_image_paths)]</small></td>

     <td>

-      <label><input type="radio" name="strip_image_paths" value="1" <?php echo $strip_image_paths=='1' ? 'checked="checked"' : "" ; ?> />

+      <label><input type="radio" name="strip_image_paths" value="1" <?php echo $strip_image_paths == '1' ? 'checked="checked"' : ""; ?> />

       <?php echo $_lang['yes']?></label><br />

-      <label><input type="radio" name="strip_image_paths" value="0" <?php echo $strip_image_paths=='0' ? 'checked="checked"' : "" ; ?> />

+      <label><input type="radio" name="strip_image_paths" value="0" <?php echo $strip_image_paths == '0' ? 'checked="checked"' : ""; ?> />

       <?php echo $_lang['no']?></label>

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['settings_strip_image_paths_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['maxImageWidth']?><br><small>[(maxImageWidth)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="4" style="width: 50px;" name="maxImageWidth" value="<?php echo $maxImageWidth; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['maxImageWidth_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['maxImageHeight']?><br><small>[(maxImageHeight)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="4" style="width: 50px;" name="maxImageHeight" value="<?php echo $maxImageHeight; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['maxImageHeight_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['thumbWidth']?><br><small>[(thumbWidth)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="4" style="width: 50px;" name="thumbWidth" value="<?php echo $thumbWidth; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['thumbWidth_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['thumbHeight']?><br><small>[(thumbHeight)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="4" style="width: 50px;" name="thumbHeight" value="<?php echo $thumbHeight; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['thumbHeight_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['thumbsDir']?><br><small>[(thumbsDir)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="255" style="width: 250px;" name="thumbsDir" value="<?php echo $thumbsDir; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['thumbsDir_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td nowrap class="warning"><?php echo $_lang['jpegQuality']?><br><small>[(jpegQuality)]</small></td>

     <td>

       <input onchange="documentDirty=true;" type="text" maxlength="4" style="width: 50px;" name="jpegQuality" value="<?php echo $jpegQuality; ?>" />

     </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td width="200">&nbsp;</td>

     <td class="comment"><?php echo $_lang['jpegQuality_message']?></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

        <td nowrap class="warning"><?php echo $_lang['denyZipDownload'] ?><br><small>[(denyZipDownload)]</small></td>

         <td>

-          <label><input type="radio" name="denyZipDownload" value="0" <?php echo $denyZipDownload=='0' ? 'checked="checked"' : ""; ?> />

+          <label><input type="radio" name="denyZipDownload" value="0" <?php echo $denyZipDownload == '0' ? 'checked="checked"' : ""; ?> />

           <?php echo $_lang['no']?></label><br />

-          <label><input type="radio" name="denyZipDownload" value="1" <?php echo $denyZipDownload=='1' ? 'checked="checked"' : ""; ?> />

+          <label><input type="radio" name="denyZipDownload" value="1" <?php echo $denyZipDownload == '1' ? 'checked="checked"' : ""; ?> />

           <?php echo $_lang['yes']?></label>

         </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

         <td nowrap class="warning"><?php echo $_lang['denyExtensionRename'] ?><br><small>[(denyExtensionRename)]</small></td>

         <td>

-           <label><input type="radio" name="denyExtensionRename" value="0" <?php echo $denyExtensionRename=='0' ? 'checked="checked"' : ""; ?> />

+           <label><input type="radio" name="denyExtensionRename" value="0" <?php echo $denyExtensionRename == '0' ? 'checked="checked"' : ""; ?> />

            <?php echo $_lang['no']?></label><br />

-           <label><input type="radio" name="denyExtensionRename" value="1" <?php echo $denyExtensionRename=='1' ? 'checked="checked"' : ""; ?> />

+           <label><input type="radio" name="denyExtensionRename" value="1" <?php echo $denyExtensionRename == '1' ? 'checked="checked"' : ""; ?> />

            <?php echo $_lang['yes']?></label>

         </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

        <td nowrap class="warning"><?php echo $_lang['showHiddenFiles'] ?><br><small>[(showHiddenFiles)]</small></td>

        <td>

-         <label><input type="radio" name="showHiddenFiles" value="0" <?php echo $showHiddenFiles=='0' ? 'checked="checked"' : ""; ?> />

+         <label><input type="radio" name="showHiddenFiles" value="0" <?php echo $showHiddenFiles == '0' ? 'checked="checked"' : ""; ?> />

          <?php echo $_lang['no']?></label><br />

-         <label><input type="radio" name="showHiddenFiles" value="1" <?php echo $showHiddenFiles=='1' ? 'checked="checked"' : ""; ?> />

+         <label><input type="radio" name="showHiddenFiles" value="1" <?php echo $showHiddenFiles == '1' ? 'checked="checked"' : ""; ?> />

          <?php echo $_lang['yes']?></label>

         </td>

   </tr>

-  <tr class="rbRow" <?php echo showHide($use_browser==1);?>>

+  <tr class="rbRow" <?php echo showHide($use_browser == 1); ?>>

     <td colspan="2"><div class="split"></div></td>

   </tr>

   

@@ -235,7 +235,7 @@ 
         <?php

             // invoke OnMiscSettingsRender event

             $evtOut = $modx->invokeEvent('OnMiscSettingsRender');

-            if(is_array($evtOut)) echo implode("",$evtOut);

+            if (is_array($evtOut)) echo implode("", $evtOut);

         ?>

     </td>

   </tr>