Completed
Push — develop ( e6bcf2...351294 )
by Dmytro
06:18
created
manager/includes/controls/phpmailer/PHPMailer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3968,7 +3968,7 @@
 block discarded – undo
3968 3968
      * @param int|string $options Either a PATHINFO_* constant,
3969 3969
      *                            or a string name to return only the specified piece
3970 3970
      *
3971
-     * @return string|array
3971
+     * @return string
3972 3972
      */
3973 3973
     public static function mb_pathinfo($path, $options = null)
3974 3974
     {
Please login to merge, or discard this patch.
manager/includes/controls/phpmailer/POP3.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@
 block discarded – undo
209 209
      * Connect to a POP3 server.
210 210
      *
211 211
      * @param string   $host
212
-     * @param int|bool $port
212
+     * @param integer $port
213 213
      * @param int      $tval
214 214
      *
215 215
      * @return bool
Please login to merge, or discard this patch.
manager/includes/controls/phpmailer/SMTP.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1314,7 +1314,7 @@
 block discarded – undo
1314 1314
      * If no reply has been received yet, it will return null.
1315 1315
      * If no pattern was matched, it will return false.
1316 1316
      *
1317
-     * @return bool|null|string
1317
+     * @return string
1318 1318
      *
1319 1319
      * @see recordLastTransactionID()
1320 1320
      */
Please login to merge, or discard this patch.
manager/media/rss/extlib/Snoopy.class.inc 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -616,6 +616,9 @@  discard block
 block discarded – undo
616 616
         Output:
617 617
     \*======================================================================*/
618 618
 
619
+    /**
620
+     * @param string $http_method
621
+     */
619 622
     function _httprequest($url, $fp, $URI, $http_method, $content_type = "", $body = "")
620 623
     {
621 624
         $cookie_headers = '';
@@ -923,6 +926,10 @@  discard block
 block discarded – undo
923 926
         Output:		post body
924 927
     \*======================================================================*/
925 928
 
929
+    /**
930
+     * @param string $formvars
931
+     * @param string $formfiles
932
+     */
926 933
     function _prepare_post_body($formvars, $formfiles)
927 934
     {
928 935
         settype($formvars, "array");
Please login to merge, or discard this patch.
manager/media/rss/rss_fetch.inc 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -243,6 +243,9 @@  discard block
 block discarded – undo
243 243
         }
244 244
 }
245 245
 
246
+/**
247
+ * @param integer $lvl
248
+ */
246 249
 function debug ($debugmsg, $lvl=E_USER_NOTICE) {
247 250
     trigger_error("MagpieRSS [debug] $debugmsg", $lvl);
248 251
 }
@@ -289,6 +292,9 @@  discard block
 block discarded – undo
289 292
     Input:      an HTTP response object (see Snoopy)
290 293
     Output:     parsed RSS object (see rss_parse)
291 294
 \*=======================================================================*/
295
+/**
296
+ * @param Snoopy $resp
297
+ */
292 298
 function _response_to_rss ($resp) {
293 299
     $rss = new MagpieRSS( $resp->results, MAGPIE_OUTPUT_ENCODING, MAGPIE_INPUT_ENCODING, MAGPIE_DETECT_ENCODING );
294 300
     
Please login to merge, or discard this patch.
manager/processors/save_snippet.processor.php 1 patch
Switch Indentation   +107 added lines, -107 removed lines patch added patch discarded remove patch
@@ -66,111 +66,111 @@
 block discarded – undo
66 66
 }
67 67
 
68 68
 switch ($_POST['mode']) {
69
-    case '23': // Save new snippet
70
-
71
-        // invoke OnBeforeSnipFormSave event
72
-        $modx->invokeEvent("OnBeforeSnipFormSave", array(
73
-            "mode" => "new",
74
-            "id" => $id
75
-        ));
76
-
77
-        // disallow duplicate names for new snippets
78
-        $rs = $modx->db->select('COUNT(id)', $modx->getFullTableName('site_snippets'), "name='{$name}'");
79
-        $count = $modx->db->getValue($rs);
80
-        if ($count > 0) {
81
-            $modx->manager->saveFormValues(23);
82
-            $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['snippet'], $name), "index.php?a=23");
83
-        }
84
-
85
-        //do stuff to save the new doc
86
-        $newid = $modx->db->insert(array(
87
-            'name' => $name,
88
-            'description' => $description,
89
-            'snippet' => $snippet,
90
-            'moduleguid' => $moduleguid,
91
-            'locked' => $locked,
92
-            'properties' => $properties,
93
-            'category' => $categoryid,
94
-            'disabled' => $disabled,
95
-            'createdon' => $currentdate,
96
-            'editedon' => $currentdate
97
-        ), $modx->getFullTableName('site_snippets'));
98
-
99
-        // invoke OnSnipFormSave event
100
-        $modx->invokeEvent("OnSnipFormSave", array(
101
-            "mode" => "new",
102
-            "id" => $newid
103
-        ));
104
-
105
-        // Set the item name for logger
106
-        $_SESSION['itemname'] = $name;
107
-
108
-        // empty cache
109
-        $modx->clearCache('full');
110
-
111
-        // finished emptying cache - redirect
112
-        if ($_POST['stay'] != '') {
113
-            $a = ($_POST['stay'] == '2') ? "22&id=$newid" : "23";
114
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
115
-            header($header);
116
-        } else {
117
-            $header = "Location: index.php?a=76&r=2";
118
-            header($header);
119
-        }
120
-        break;
121
-    case '22': // Save existing snippet
122
-        // invoke OnBeforeSnipFormSave event
123
-        $modx->invokeEvent("OnBeforeSnipFormSave", array(
124
-            "mode" => "upd",
125
-            "id" => $id
126
-        ));
127
-
128
-        // disallow duplicate names for snippets
129
-        $rs = $modx->db->select('COUNT(*)', $modx->getFullTableName('site_snippets'), "name='{$name}' AND id!='{$id}'");
130
-        if ($modx->db->getValue($rs) > 0) {
131
-            $modx->manager->saveFormValues(22);
132
-            $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['snippet'], $name), "index.php?a=22&id={$id}");
133
-        }
134
-
135
-        //do stuff to save the edited doc
136
-        $modx->db->update(array(
137
-            'name' => $name,
138
-            'description' => $description,
139
-            'snippet' => $snippet,
140
-            'moduleguid' => $moduleguid,
141
-            'locked' => $locked,
142
-            'properties' => $properties,
143
-            'category' => $categoryid,
144
-            'disabled' => $disabled,
145
-            'editedon' => $currentdate
146
-        ), $modx->getFullTableName('site_snippets'), "id='{$id}'");
147
-
148
-        // invoke OnSnipFormSave event
149
-        $modx->invokeEvent("OnSnipFormSave", array(
150
-            "mode" => "upd",
151
-            "id" => $id
152
-        ));
153
-
154
-        // Set the item name for logger
155
-        $_SESSION['itemname'] = $name;
156
-
157
-        // empty cache
158
-        $modx->clearCache('full');
159
-
160
-        if ($_POST['runsnippet']) {
161
-            run_snippet($snippet);
162
-        }
163
-        // finished emptying cache - redirect
164
-        if ($_POST['stay'] != '') {
165
-            $a = ($_POST['stay'] == '2') ? "22&id=$id" : "23";
166
-            $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
167
-            header($header);
168
-        } else {
169
-            $modx->unlockElement(4, $id);
170
-            $header = "Location: index.php?a=76&r=2";
171
-            header($header);
172
-        }
173
-        break;
174
-    default:
175
-        $modx->webAlertAndQuit("No operation set in request.");
69
+        case '23': // Save new snippet
70
+
71
+            // invoke OnBeforeSnipFormSave event
72
+            $modx->invokeEvent("OnBeforeSnipFormSave", array(
73
+                "mode" => "new",
74
+                "id" => $id
75
+            ));
76
+
77
+            // disallow duplicate names for new snippets
78
+            $rs = $modx->db->select('COUNT(id)', $modx->getFullTableName('site_snippets'), "name='{$name}'");
79
+            $count = $modx->db->getValue($rs);
80
+            if ($count > 0) {
81
+                $modx->manager->saveFormValues(23);
82
+                $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['snippet'], $name), "index.php?a=23");
83
+            }
84
+
85
+            //do stuff to save the new doc
86
+            $newid = $modx->db->insert(array(
87
+                'name' => $name,
88
+                'description' => $description,
89
+                'snippet' => $snippet,
90
+                'moduleguid' => $moduleguid,
91
+                'locked' => $locked,
92
+                'properties' => $properties,
93
+                'category' => $categoryid,
94
+                'disabled' => $disabled,
95
+                'createdon' => $currentdate,
96
+                'editedon' => $currentdate
97
+            ), $modx->getFullTableName('site_snippets'));
98
+
99
+            // invoke OnSnipFormSave event
100
+            $modx->invokeEvent("OnSnipFormSave", array(
101
+                "mode" => "new",
102
+                "id" => $newid
103
+            ));
104
+
105
+            // Set the item name for logger
106
+            $_SESSION['itemname'] = $name;
107
+
108
+            // empty cache
109
+            $modx->clearCache('full');
110
+
111
+            // finished emptying cache - redirect
112
+            if ($_POST['stay'] != '') {
113
+                $a = ($_POST['stay'] == '2') ? "22&id=$newid" : "23";
114
+                $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
115
+                header($header);
116
+            } else {
117
+                $header = "Location: index.php?a=76&r=2";
118
+                header($header);
119
+            }
120
+            break;
121
+        case '22': // Save existing snippet
122
+            // invoke OnBeforeSnipFormSave event
123
+            $modx->invokeEvent("OnBeforeSnipFormSave", array(
124
+                "mode" => "upd",
125
+                "id" => $id
126
+            ));
127
+
128
+            // disallow duplicate names for snippets
129
+            $rs = $modx->db->select('COUNT(*)', $modx->getFullTableName('site_snippets'), "name='{$name}' AND id!='{$id}'");
130
+            if ($modx->db->getValue($rs) > 0) {
131
+                $modx->manager->saveFormValues(22);
132
+                $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['snippet'], $name), "index.php?a=22&id={$id}");
133
+            }
134
+
135
+            //do stuff to save the edited doc
136
+            $modx->db->update(array(
137
+                'name' => $name,
138
+                'description' => $description,
139
+                'snippet' => $snippet,
140
+                'moduleguid' => $moduleguid,
141
+                'locked' => $locked,
142
+                'properties' => $properties,
143
+                'category' => $categoryid,
144
+                'disabled' => $disabled,
145
+                'editedon' => $currentdate
146
+            ), $modx->getFullTableName('site_snippets'), "id='{$id}'");
147
+
148
+            // invoke OnSnipFormSave event
149
+            $modx->invokeEvent("OnSnipFormSave", array(
150
+                "mode" => "upd",
151
+                "id" => $id
152
+            ));
153
+
154
+            // Set the item name for logger
155
+            $_SESSION['itemname'] = $name;
156
+
157
+            // empty cache
158
+            $modx->clearCache('full');
159
+
160
+            if ($_POST['runsnippet']) {
161
+                run_snippet($snippet);
162
+            }
163
+            // finished emptying cache - redirect
164
+            if ($_POST['stay'] != '') {
165
+                $a = ($_POST['stay'] == '2') ? "22&id=$id" : "23";
166
+                $header = "Location: index.php?a=" . $a . "&r=2&stay=" . $_POST['stay'];
167
+                header($header);
168
+            } else {
169
+                $modx->unlockElement(4, $id);
170
+                $header = "Location: index.php?a=76&r=2";
171
+                header($header);
172
+            }
173
+            break;
174
+        default:
175
+            $modx->webAlertAndQuit("No operation set in request.");
176 176
 }
Please login to merge, or discard this patch.
manager/media/rss/rss_cache.inc 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
     Input:      url from wich the rss file was fetched
49 49
     Output:     true on sucess
50 50
 \*=======================================================================*/
51
+    /**
52
+     * @param string $url
53
+     */
51 54
     function set ($url, $rss) {
52 55
         $this->ERROR = "";
53 56
         $cache_file = $this->file_name( $url );
@@ -74,6 +77,9 @@  discard block
 block discarded – undo
74 77
     Input:      url from wich the rss file was fetched
75 78
     Output:     cached object on HIT, false on MISS
76 79
 \*=======================================================================*/
80
+    /**
81
+     * @param string $url
82
+     */
77 83
     function get ($url) {
78 84
         $this->ERROR = "";
79 85
         $cache_file = $this->file_name( $url );
@@ -110,6 +116,9 @@  discard block
 block discarded – undo
110 116
     Input:      url from wich the rss file was fetched
111 117
     Output:     cached object on HIT, false on MISS
112 118
 \*=======================================================================*/
119
+    /**
120
+     * @param string $url
121
+     */
113 122
     function check_cache ( $url ) {
114 123
         $this->ERROR = "";
115 124
         $filename = $this->file_name( $url );
@@ -156,6 +165,9 @@  discard block
 block discarded – undo
156 165
 /*=======================================================================*\
157 166
     Function:   unserialize
158 167
 \*=======================================================================*/
168
+    /**
169
+     * @param string $data
170
+     */
159 171
     function unserialize ( $data ) {
160 172
         return unserialize( $data );
161 173
     }
Please login to merge, or discard this patch.
install/actions/action_options.php 1 patch
Switch Indentation   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -190,53 +190,53 @@
 block discarded – undo
190 190
 }
191 191
 
192 192
 switch($installMode){
193
-    case 0:
194
-    case 2:
195
-        $database_collation = isset($_POST['database_collation']) ? $_POST['database_collation'] : 'utf8_general_ci';
196
-        $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
197
-        $_POST['database_connection_charset'] = $database_charset;
198
-        if(empty($_SESSION['databaseloginpassword']))
199
-            $_SESSION['databaseloginpassword'] = $_POST['databaseloginpassword'];
200
-        if(empty($_SESSION['databaseloginname']))
201
-            $_SESSION['databaseloginname'] = $_POST['databaseloginname'];
202
-        break;
203
-    case 1:
204
-        include $base_path . MGR_DIR . '/includes/config.inc.php';
205
-        if (@ $conn = mysqli_connect($database_server, $database_user, $database_password)) {
206
-            if (@ mysqli_query($conn, "USE {$dbase}")) {
207
-                if (!$rs = mysqli_query($conn, "show session variables like 'collation_database'")) {
208
-                    $rs = mysqli_query($conn, "show session variables like 'collation_server'");
209
-                }
210
-                if ($rs && $collation = mysqli_fetch_row($rs)) {
211
-                    $database_collation = trim($collation[1]);
193
+        case 0:
194
+        case 2:
195
+            $database_collation = isset($_POST['database_collation']) ? $_POST['database_collation'] : 'utf8_general_ci';
196
+            $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
197
+            $_POST['database_connection_charset'] = $database_charset;
198
+            if(empty($_SESSION['databaseloginpassword']))
199
+                $_SESSION['databaseloginpassword'] = $_POST['databaseloginpassword'];
200
+            if(empty($_SESSION['databaseloginname']))
201
+                $_SESSION['databaseloginname'] = $_POST['databaseloginname'];
202
+            break;
203
+        case 1:
204
+            include $base_path . MGR_DIR . '/includes/config.inc.php';
205
+            if (@ $conn = mysqli_connect($database_server, $database_user, $database_password)) {
206
+                if (@ mysqli_query($conn, "USE {$dbase}")) {
207
+                    if (!$rs = mysqli_query($conn, "show session variables like 'collation_database'")) {
208
+                        $rs = mysqli_query($conn, "show session variables like 'collation_server'");
209
+                    }
210
+                    if ($rs && $collation = mysqli_fetch_row($rs)) {
211
+                        $database_collation = trim($collation[1]);
212
+                    }
212 213
                 }
213 214
             }
214
-        }
215
-        if (empty ($database_collation)) $database_collation = 'utf8_general_ci';
215
+            if (empty ($database_collation)) $database_collation = 'utf8_general_ci';
216 216
 
217
-        $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
218
-        if (!isset ($database_connection_charset) || empty ($database_connection_charset)) {
219
-            $database_connection_charset = $database_charset;
220
-        }
217
+            $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
218
+            if (!isset ($database_connection_charset) || empty ($database_connection_charset)) {
219
+                $database_connection_charset = $database_charset;
220
+            }
221 221
 
222
-        if (!isset ($database_connection_method) || empty ($database_connection_method)) {
223
-            $database_connection_method = 'SET CHARACTER SET';
224
-            if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_connection_charset);
225
-        }
226
-        if ($database_connection_method != 'SET NAMES' && $database_connection_charset != $database_charset) {
227
-            $database_connection_method = 'SET NAMES';
228
-        }
222
+            if (!isset ($database_connection_method) || empty ($database_connection_method)) {
223
+                $database_connection_method = 'SET CHARACTER SET';
224
+                if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_connection_charset);
225
+            }
226
+            if ($database_connection_method != 'SET NAMES' && $database_connection_charset != $database_charset) {
227
+                $database_connection_method = 'SET NAMES';
228
+            }
229 229
 
230
-        $_POST['database_name'] = $dbase;
231
-        $_POST['tableprefix'] = $table_prefix;
232
-        $_POST['database_connection_charset'] = $database_connection_charset;
233
-        $_POST['database_connection_method'] = $database_connection_method;
234
-        $_POST['databasehost'] = $database_server;
235
-        $_SESSION['databaseloginname'] = $database_user;
236
-        $_SESSION['databaseloginpassword'] = $database_password;
237
-        break;
238
-    default:
239
-        throw new Exception('installmode is undefined');
230
+            $_POST['database_name'] = $dbase;
231
+            $_POST['tableprefix'] = $table_prefix;
232
+            $_POST['database_connection_charset'] = $database_connection_charset;
233
+            $_POST['database_connection_method'] = $database_connection_method;
234
+            $_POST['databasehost'] = $database_server;
235
+            $_SESSION['databaseloginname'] = $database_user;
236
+            $_SESSION['databaseloginpassword'] = $database_password;
237
+            break;
238
+        default:
239
+            throw new Exception('installmode is undefined');
240 240
 }
241 241
 
242 242
 $ph['install_language'] = $install_language;
Please login to merge, or discard this patch.
manager/actions/mutate_htmlsnippet.dynamic.php 1 patch
Switch Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -4,18 +4,18 @@
 block discarded – undo
4 4
 }
5 5
 
6 6
 switch ($modx->manager->action) {
7
-    case 78:
8
-        if (!$modx->hasPermission('edit_chunk')) {
9
-            $modx->webAlertAndQuit($_lang["error_no_privileges"]);
10
-        }
11
-        break;
12
-    case 77:
13
-        if (!$modx->hasPermission('new_chunk')) {
7
+        case 78:
8
+            if (!$modx->hasPermission('edit_chunk')) {
9
+                $modx->webAlertAndQuit($_lang["error_no_privileges"]);
10
+            }
11
+            break;
12
+        case 77:
13
+            if (!$modx->hasPermission('new_chunk')) {
14
+                $modx->webAlertAndQuit($_lang["error_no_privileges"]);
15
+            }
16
+            break;
17
+        default:
14 18
             $modx->webAlertAndQuit($_lang["error_no_privileges"]);
15
-        }
16
-        break;
17
-    default:
18
-        $modx->webAlertAndQuit($_lang["error_no_privileges"]);
19 19
 }
20 20
 
21 21
 $id = isset($_REQUEST['id']) ? (int)$_REQUEST['id'] : 0;
Please login to merge, or discard this patch.