Completed
Push — develop ( e6bcf2...351294 )
by Dmytro
06:18
created
install/actions/action_install.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@
 block discarded – undo
43 43
 	var chk = document.install.rminstaller;
44 44
 	if(chk && chk.checked) {
45 45
 		// remove install folder and files
46
-		window.location.href = "../<?php echo MGR_DIR;?>/processors/remove_installer.processor.php?rminstall=1";
46
+		window.location.href = "../<?php echo MGR_DIR; ?>/processors/remove_installer.processor.php?rminstall=1";
47 47
 	}
48 48
 	else {
49
-		window.location.href = "../<?php echo MGR_DIR;?>/";
49
+		window.location.href = "../<?php echo MGR_DIR; ?>/";
50 50
 	}
51 51
 }
52 52
 /* ]]> */
Please login to merge, or discard this patch.
install/connection.databasetest.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,12 +6,12 @@  discard block
 block discarded – undo
6 6
 $installMode = $_POST['installMode'];
7 7
 
8 8
 $self = 'install/connection.databasetest.php';
9
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
9
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
10 10
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
11 11
 	include_once("{$base_path}assets/cache/siteManager.php");
12 12
 }
13
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
14
-	define('MGR_DIR','manager');
13
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
14
+	define('MGR_DIR', 'manager');
15 15
 }
16 16
 require_once("lang.php");
17 17
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
32 32
         $query = "CREATE DATABASE `".$database_name."` CHARACTER SET ".$database_charset." COLLATE ".$database_collation.";";
33 33
 
34
-        if (! mysqli_query($conn, $query)){
34
+        if (!mysqli_query($conn, $query)) {
35 35
             $output .= '<span id="database_fail" style="color:#FF0000;">'.$_lang['status_failed_could_not_create_database'].'</span>';
36 36
         }
37 37
         else {
Please login to merge, or discard this patch.
Braces   +6 added lines, -11 removed lines patch added patch discarded remove patch
@@ -18,8 +18,7 @@  discard block
 block discarded – undo
18 18
 $output = $_lang["status_checking_database"];
19 19
 if (!$conn = mysqli_connect($host, $uid, $pwd)) {
20 20
     $output .= '<span id="database_fail" style="color:#FF0000;">'.$_lang['status_failed'].'</span>';
21
-}
22
-else {
21
+} else {
23 22
     $database_name = mysqli_real_escape_string($conn, $_POST['database_name']);
24 23
     $database_name = str_replace("`", "", $database_name);
25 24
     $tableprefix = mysqli_real_escape_string($conn, $_POST['tableprefix']);
@@ -31,20 +30,16 @@  discard block
 block discarded – undo
31 30
         $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
32 31
         $query = "CREATE DATABASE `".$database_name."` CHARACTER SET ".$database_charset." COLLATE ".$database_collation.";";
33 32
 
34
-        if (! mysqli_query($conn, $query)){
33
+        if (! mysqli_query($conn, $query)) {
35 34
             $output .= '<span id="database_fail" style="color:#FF0000;">'.$_lang['status_failed_could_not_create_database'].'</span>';
36
-        }
37
-        else {
35
+        } else {
38 36
             $output .= '<span id="database_pass" style="color:#80c000;">'.$_lang['status_passed_database_created'].'</span>';
39 37
         }
40
-    }
41
-    elseif (($installMode == 0) && (mysqli_query($conn, "SELECT COUNT(*) FROM {$database_name}.`{$tableprefix}site_content`"))) {
38
+    } elseif (($installMode == 0) && (mysqli_query($conn, "SELECT COUNT(*) FROM {$database_name}.`{$tableprefix}site_content`"))) {
42 39
         $output .= '<span id="database_fail" style="color:#FF0000;">'.$_lang['status_failed_table_prefix_already_in_use'].'</span>';
43
-    }
44
-    elseif (($database_connection_method != 'SET NAMES') && ($rs = mysqli_query($conn, "show variables like 'collation_database'")) && ($row = mysqli_fetch_row($rs)) && ($row[1] != $database_collation)) {
40
+    } elseif (($database_connection_method != 'SET NAMES') && ($rs = mysqli_query($conn, "show variables like 'collation_database'")) && ($row = mysqli_fetch_row($rs)) && ($row[1] != $database_collation)) {
45 41
         $output .= '<span id="database_fail" style="color:#FF0000;">'.sprintf($_lang['status_failed_database_collation_does_not_match'], $row[1]).'</span>';
46
-    }
47
-    else {
42
+    } else {
48 43
         $output .= '<span id="database_pass" style="color:#80c000;">'.$_lang['status_passed'].'</span>';
49 44
     }
50 45
 }
Please login to merge, or discard this patch.
install/index.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 }
10 10
 
11 11
 $self = 'install/index.php';
12
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
12
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
13 13
 require_once("{$base_path}install/functions.php");
14 14
 
15 15
 // set error reporting
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
19 19
 	include_once("{$base_path}assets/cache/siteManager.php");
20 20
 }
21
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
21
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
22 22
 	define('MGR_DIR', 'manager');
23 23
 }
24 24
 
@@ -38,26 +38,26 @@  discard block
 block discarded – undo
38 38
 $moduleSQLDataFile = "setup.data.sql";
39 39
 $moduleSQLResetFile = "setup.data.reset.sql";
40 40
 
41
-$moduleChunks = array (); // chunks - array : name, description, type - 0:file or 1:content, file or content
42
-$moduleTemplates = array (); // templates - array : name, description, type - 0:file or 1:content, file or content
43
-$moduleSnippets = array (); // snippets - array : name, description, type - 0:file or 1:content, file or content,properties
44
-$modulePlugins = array (); // plugins - array : name, description, type - 0:file or 1:content, file or content,properties, events,guid
45
-$moduleModules = array (); // modules - array : name, description, type - 0:file or 1:content, file or content,properties, guid
46
-$moduleTemplates = array (); // templates - array : name, description, type - 0:file or 1:content, file or content,properties
47
-$moduleTVs = array (); // template variables - array : name, description, type - 0:file or 1:content, file or content,properties
41
+$moduleChunks = array(); // chunks - array : name, description, type - 0:file or 1:content, file or content
42
+$moduleTemplates = array(); // templates - array : name, description, type - 0:file or 1:content, file or content
43
+$moduleSnippets = array(); // snippets - array : name, description, type - 0:file or 1:content, file or content,properties
44
+$modulePlugins = array(); // plugins - array : name, description, type - 0:file or 1:content, file or content,properties, events,guid
45
+$moduleModules = array(); // modules - array : name, description, type - 0:file or 1:content, file or content,properties, guid
46
+$moduleTemplates = array(); // templates - array : name, description, type - 0:file or 1:content, file or content,properties
47
+$moduleTVs = array(); // template variables - array : name, description, type - 0:file or 1:content, file or content,properties
48 48
 $moduleDependencies = array(); // module depedencies - array : module, table, column, type, name
49 49
 
50
-$errors= 0;
50
+$errors = 0;
51 51
 
52 52
 // get post back status
53 53
 $isPostBack = (count($_POST));
54 54
 
55 55
 $ph = ph();
56
-$ph = array_merge($ph,$_lang);
56
+$ph = array_merge($ph, $_lang);
57 57
 $ph['install_language'] = $install_language;
58 58
 
59 59
 ob_start();
60
-$action= isset ($_GET['action']) ? trim(strip_tags($_GET['action'])) : 'language';
60
+$action = isset ($_GET['action']) ? trim(strip_tags($_GET['action'])) : 'language';
61 61
 if (!@include_once("actions/action_{$action}.php")) {
62 62
     die ("Invalid install action attempted. [action={$action}]");
63 63
 }
@@ -65,5 +65,5 @@  discard block
 block discarded – undo
65 65
 ob_end_clean();
66 66
 
67 67
 $tpl = file_get_contents("{$base_path}install/template.tpl");
68
-echo parse($tpl,$ph);
68
+echo parse($tpl, $ph);
69 69
 
Please login to merge, or discard this patch.
manager/actions/mutate_settings/tab4_manager_settings.inc.php 2 patches
Braces   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,9 +49,9 @@  discard block
 block discarded – undo
49 49
                 <select name="manager_theme" size="1" class="inputBox" onChange="documentDirty=true; document.forms['settings'].theme_refresher.value = Date.parse(new Date());">
50 50
                     <?php
51 51
                     $dir = dir("media/style/");
52
-                    while ($file = $dir->read()) {
53
-                        if ($file != "." && $file != ".." && is_dir("media/style/$file") && substr($file, 0, 1) != '.') {
54
-                            if ($file === 'common') {
52
+                    while ($file = $dir->read()) {
53
+                        if ($file != "." && $file != ".." && is_dir("media/style/$file") && substr($file, 0, 1) != '.') {
54
+                            if ($file === 'common') {
55 55
                                 continue;
56 56
                             }
57 57
                             $themename = $file;
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
                     $tpl = '<option value="[+value+]" [+selected+]>[+title+]</option>' . "\n";
210 210
                     $option = explode(',', $_lang['settings_group_tv_options']);
211 211
                     $output = array();
212
-                    foreach ($option as $k => $v) {
212
+                    foreach ($option as $k => $v) {
213 213
                         $selected = ($k == $group_tvs) ? 'selected' : '';
214 214
                         $s = array('[+value+]', '[+selected+]', '[+title+]');
215 215
                         $r = array($k, $selected, $v);
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
                     $tpl = '<option value="[+value+]" [+selected+]>[*[+value+]*]</option>' . "\n";
283 283
                     $option = array('pagetitle', 'longtitle', 'menutitle', 'alias', 'createdon', 'editedon', 'publishedon');
284 284
                     $output = array();
285
-                    foreach ($option as $v) {
285
+                    foreach ($option as $v) {
286 286
                         $selected = ($v == $resource_tree_node_name) ? 'selected' : '';
287 287
                         $s = array('[+value+]', '[+selected+]');
288 288
                         $r = array($v, $selected);
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
                     <?php
364 364
                     $datetime_format_list = array('dd-mm-YYYY', 'mm/dd/YYYY', 'YYYY/mm/dd');
365 365
                     $str = '';
366
-                    foreach ($datetime_format_list as $value) {
366
+                    foreach ($datetime_format_list as $value) {
367 367
                         $selectedtext = ($datetime_format == $value) ? ' selected' : '';
368 368
                         $str .= '<option value="' . $value . '"' . $selectedtext . '>';
369 369
                         $str .= $value . '</option>' . PHP_EOL;
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
         <?php
446 446
         // invoke OnRichTextEditorRegister event
447 447
         $evtOut = $modx->invokeEvent('OnRichTextEditorRegister');
448
-        if (!is_array($evtOut)) {
448
+        if (!is_array($evtOut)) {
449 449
             $evtOut = array();
450 450
             $use_editor = 0;
451 451
         }
@@ -477,8 +477,8 @@  discard block
 block discarded – undo
477 477
                     <?php
478 478
                     // invoke OnRichTextEditorRegister event
479 479
                     echo "<option value='none'" . ($which_editor == 'none' ? " selected='selected'" : "") . ">" . $_lang['none'] . "</option>\n";
480
-                    if (is_array($evtOut)) {
481
-                        foreach ($evtOut as $editor) {
480
+                    if (is_array($evtOut)) {
481
+                        foreach ($evtOut as $editor) {
482 482
                             echo "<option value='$editor'" . ($which_editor == $editor ? " selected='selected'" : "") . ">$editor</option>\n";
483 483
                         }
484 484
                     }
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
                 <?php
535 535
                 // invoke OnInterfaceSettingsRender event
536 536
                 $evtOut = $modx->invokeEvent('OnInterfaceSettingsRender');
537
-                if (is_array($evtOut)) {
537
+                if (is_array($evtOut)) {
538 538
                     echo implode("", $evtOut);
539 539
                 }
540 540
                 ?>
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
                             }
57 57
                             $themename = $file;
58 58
                             $selectedtext = $themename == $manager_theme ? "selected='selected'" : "";
59
-                            echo "<option value='$themename' $selectedtext>" . ucwords(str_replace("_", " ", $themename)) . "</option>";
59
+                            echo "<option value='$themename' $selectedtext>".ucwords(str_replace("_", " ", $themename))."</option>";
60 60
                         }
61 61
                     }
62 62
                     $dir->close();
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             function BrowseServer() {
125 125
               var w = screen.width * 0.7;
126 126
               var h = screen.height * 0.7;
127
-              OpenServerBrowser("<?php echo MODX_MANAGER_URL; ?>media/browser/<?php echo $which_browser;?>/browser.php?Type=images", w, h);
127
+              OpenServerBrowser("<?php echo MODX_MANAGER_URL; ?>media/browser/<?php echo $which_browser; ?>/browser.php?Type=images", w, h);
128 128
             }
129 129
 
130 130
             function SetUrl(url, width, height, alt) {
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
             function BrowseServer() {
163 163
               var w = screen.width * 0.7;
164 164
               var h = screen.height * 0.7;
165
-              OpenServerBrowser("<?php echo MODX_MANAGER_URL; ?>media/browser/<?php echo $which_browser;?>/browser.php?Type=images", w, h);
165
+              OpenServerBrowser("<?php echo MODX_MANAGER_URL; ?>media/browser/<?php echo $which_browser; ?>/browser.php?Type=images", w, h);
166 166
             }
167 167
 
168 168
             function SetUrl(url, width, height, alt) {
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
       <tr>
181 181
         <th><?php echo $_lang['login_form_position_title'] ?><br><small>[(login_form_position)]</small></th>
182 182
         <td>
183
-            <?php echo wrap_label($_lang['login_form_position_left'], form_radio('login_form_position', 'left'));?><br />
184
-            <?php echo wrap_label($_lang['login_form_position_center'], form_radio('login_form_position', 'center'));?><br />
185
-            <?php echo wrap_label($_lang['login_form_position_right'], form_radio('login_form_position', 'right'));?>
183
+            <?php echo wrap_label($_lang['login_form_position_left'], form_radio('login_form_position', 'left')); ?><br />
184
+            <?php echo wrap_label($_lang['login_form_position_center'], form_radio('login_form_position', 'center')); ?><br />
185
+            <?php echo wrap_label($_lang['login_form_position_right'], form_radio('login_form_position', 'right')); ?>
186 186
         </td>
187 187
       </tr>
188 188
          <tr>
@@ -194,8 +194,8 @@  discard block
 block discarded – undo
194 194
       <tr>
195 195
         <th><?php echo $_lang['manager_menu_position_title'] ?><br><small>[(manager_menu_position)]</small></th>
196 196
         <td>
197
-            <?php echo wrap_label($_lang['manager_menu_position_top'], form_radio('manager_menu_position', 'top'));?><br />
198
-            <?php echo wrap_label($_lang['manager_menu_position_left'], form_radio('manager_menu_position', 'left'));?><br />
197
+            <?php echo wrap_label($_lang['manager_menu_position_top'], form_radio('manager_menu_position', 'top')); ?><br />
198
+            <?php echo wrap_label($_lang['manager_menu_position_left'], form_radio('manager_menu_position', 'left')); ?><br />
199 199
         </td>
200 200
       </tr>
201 201
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
             <td>
338 338
                 <select name="group_tvs" size="1" class="form-control">
339 339
                     <?php
340
-                    $tpl = '<option value="[+value+]" [+selected+]>[+title+]</option>' . "\n";
340
+                    $tpl = '<option value="[+value+]" [+selected+]>[+title+]</option>'."\n";
341 341
                     $option = explode(',', $_lang['settings_group_tv_options']);
342 342
                     $output = array();
343 343
                     foreach ($option as $k => $v) {
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
             <td>
411 411
                 <select name="resource_tree_node_name" size="1" class="inputBox">
412 412
                     <?php
413
-                    $tpl = '<option value="[+value+]" [+selected+]>[*[+value+]*]</option>' . "\n";
413
+                    $tpl = '<option value="[+value+]" [+selected+]>[*[+value+]*]</option>'."\n";
414 414
                     $option = array('pagetitle', 'longtitle', 'menutitle', 'alias', 'createdon', 'editedon', 'publishedon');
415 415
                     $output = array();
416 416
                     foreach ($option as $v) {
@@ -496,8 +496,8 @@  discard block
 block discarded – undo
496 496
                     $str = '';
497 497
                     foreach ($datetime_format_list as $value) {
498 498
                         $selectedtext = ($datetime_format == $value) ? ' selected' : '';
499
-                        $str .= '<option value="' . $value . '"' . $selectedtext . '>';
500
-                        $str .= $value . '</option>' . PHP_EOL;
499
+                        $str .= '<option value="'.$value.'"'.$selectedtext.'>';
500
+                        $str .= $value.'</option>'.PHP_EOL;
501 501
                     }
502 502
                     echo $str;
503 503
                     ?>
@@ -607,10 +607,10 @@  discard block
 block discarded – undo
607 607
                 <select name="which_editor" onChange="documentDirty=true;">
608 608
                     <?php
609 609
                     // invoke OnRichTextEditorRegister event
610
-                    echo "<option value='none'" . ($which_editor == 'none' ? " selected='selected'" : "") . ">" . $_lang['none'] . "</option>\n";
610
+                    echo "<option value='none'".($which_editor == 'none' ? " selected='selected'" : "").">".$_lang['none']."</option>\n";
611 611
                     if (is_array($evtOut)) {
612 612
                         foreach ($evtOut as $editor) {
613
-                            echo "<option value='$editor'" . ($which_editor == $editor ? " selected='selected'" : "") . ">$editor</option>\n";
613
+                            echo "<option value='$editor'".($which_editor == $editor ? " selected='selected'" : "").">$editor</option>\n";
614 614
                         }
615 615
                     }
616 616
                     ?>
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lang/pt-br.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,8 +9,8 @@
 block discarded – undo
9 9
 
10 10
 $lang = array(
11 11
 
12
-    '_locale' => "pt_BR.UTF-8",  // UNIX localization code
13
-    '_charset' => "utf-8",       // Browser charset
12
+    '_locale' => "pt_BR.UTF-8", // UNIX localization code
13
+    '_charset' => "utf-8", // Browser charset
14 14
 
15 15
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
16 16
     '_dateTimeFull' => "%A, %e %B, %Y %H:%M",
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lang/de.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -6,8 +6,8 @@
 block discarded – undo
6 6
 
7 7
 $lang = array(
8 8
 
9
-    '_locale' => "de_DE.UTF-8",  // UNIX localization code
10
-    '_charset' => "utf-8",       // Browser charset
9
+    '_locale' => "de_DE.UTF-8", // UNIX localization code
10
+    '_charset' => "utf-8", // Browser charset
11 11
 
12 12
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
13 13
     '_dateTimeFull' => "%A, %e.%B.%Y %I:%M %p",
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lang/uk.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@
 block discarded – undo
7 7
 
8 8
 $lang = array(
9 9
 
10
-    '_locale' => "uk_UA.UTF-8",  // UNIX localization code
11
-    '_charset' => "utf-8",       // Browser charset
10
+    '_locale' => "uk_UA.UTF-8", // UNIX localization code
11
+    '_charset' => "utf-8", // Browser charset
12 12
 
13 13
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
14 14
     '_dateTimeFull' => "%A, %e %B, %Y %H:%M",
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lang/ja.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,8 +11,8 @@
 block discarded – undo
11 11
 
12 12
 $lang = array(
13 13
 
14
-    '_locale' => "ja_JP.UTF-8",  // UNIX localization code
15
-    '_charset' => "utf-8",       // Browser charset
14
+    '_locale' => "ja_JP.UTF-8", // UNIX localization code
15
+    '_charset' => "utf-8", // Browser charset
16 16
 
17 17
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
18 18
     '_dateTimeFull' => "%Y/%m/%d %H:%M",
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lang/fr.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@
 block discarded – undo
7 7
 
8 8
 $lang = array(
9 9
 
10
-    '_locale' => "fr_FR.UTF-8",  // UNIX localization code
11
-    '_charset' => "utf-8",       // Browser charset
10
+    '_locale' => "fr_FR.UTF-8", // UNIX localization code
11
+    '_charset' => "utf-8", // Browser charset
12 12
 
13 13
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
14 14
     '_dateTimeFull' => "%A %e %B %Y %H:%M",
Please login to merge, or discard this patch.