Completed
Push — develop ( e6bcf2...351294 )
by Dmytro
06:18
created
manager/includes/extenders/export.class.inc.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -279,7 +279,8 @@  discard block
 block discarded – undo
279 279
             $row['count'] = $this->count;
280 280
             $row['url'] = $modx->makeUrl($row['id']);
281 281
 
282
-            if (!$row['wasNull']) { // needs writing a document
282
+            if (!$row['wasNull']) {
283
+// needs writing a document
283 284
                 $docname = $this->getFileName($row['id'], $row['alias'], $prefix, $suffix);
284 285
                 $filename = $dirpath . $docname;
285 286
                 if (!is_file($filename)) {
@@ -307,7 +308,8 @@  discard block
 block discarded – undo
307 308
                 $this->output[] = $this->parsePlaceholder($_lang['export_site_exporting_document'], $row);
308 309
             }
309 310
             if ($row['isfolder'] === '1' && ($modx->config['suffix_mode'] !== '1' || strpos($row['alias'],
310
-                        '.') === false)) { // needs making a folder
311
+                        '.') === false)) {
312
+// needs making a folder
311 313
                 $end_dir = ($row['alias'] !== '') ? $row['alias'] : $row['id'];
312 314
                 $dir_path = $dirpath . $end_dir;
313 315
                 if (strpos($dir_path, MODX_BASE_PATH) === false) {
Please login to merge, or discard this patch.
manager/includes/extenders/maketable.class.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -457,7 +457,8 @@
 block discarded – undo
457 457
             if ($this->formElementType) {
458 458
                 $table = "\n" . '<form id="' . $this->formName . '" name="' . $this->formName . '" action="' . $this->formAction . '" method="POST">' . $table;
459 459
             }
460
-            if (strlen($this->pageNav) > 1) {//changed to display the pagination if exists.
460
+            if (strlen($this->pageNav) > 1) {
461
+//changed to display the pagination if exists.
461 462
                 /* commented this part because of cookie
462 463
                 $table .= '<div id="max-display-records" ><select style="display:inline" onchange="javascript:updatePageSize(this[this.selectedIndex].value);">';
463 464
                 $pageSizes= array (10, 25, 50, 100, 250);
Please login to merge, or discard this patch.
manager/includes/accesscontrol.inc.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,8 @@  discard block
 block discarded – undo
21 21
 if (file_exists(MODX_BASE_PATH . 'assets/cache/installProc.inc.php')) {
22 22
     include_once(MODX_BASE_PATH . 'assets/cache/installProc.inc.php');
23 23
     if (isset($installStartTime)) {
24
-        if ((time() - $installStartTime) > 5 * 60) { // if install flag older than 5 minutes, discard
24
+        if ((time() - $installStartTime) > 5 * 60) {
25
+// if install flag older than 5 minutes, discard
25 26
             unset($installStartTime);
26 27
             @ chmod(MODX_BASE_PATH . 'assets/cache/installProc.inc.php', 0755);
27 28
             unlink(MODX_BASE_PATH . 'assets/cache/installProc.inc.php');
@@ -163,7 +164,8 @@  discard block
 block discarded – undo
163 164
         } elseif (is_file($theme_path . 'templates/actions/login.tpl')) {
164 165
             $target = $theme_path . 'templates/actions/login.tpl';
165 166
             $login_tpl = file_get_contents($target);
166
-        } elseif (is_file($theme_path . 'html/login.html')) { // ClipperCMS compatible
167
+        } elseif (is_file($theme_path . 'html/login.html')) {
168
+// ClipperCMS compatible
167 169
             $target = $theme_path . 'html/login.html';
168 170
             $login_tpl = file_get_contents($target);
169 171
         } else {
Please login to merge, or discard this patch.
manager/includes/extenders/manager.api.class.inc.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,7 +116,8 @@  discard block
 block discarded – undo
116 116
      * @return string
117 117
      */
118 118
     public function getHashType($db_value = '')
119
-    { // md5 | v1 | phpass
119
+    {
120
+// md5 | v1 | phpass
120 121
         $c = substr($db_value, 0, 1);
121 122
         if ($c === '$') {
122 123
             return 'phpass';
@@ -135,7 +136,8 @@  discard block
 block discarded – undo
135 136
      * @return string
136 137
      */
137 138
     public function genV1Hash($password, $seed = '1')
138
-    { // $seed is user_id basically
139
+    {
140
+// $seed is user_id basically
139 141
         $modx = evolutionCMS();
140 142
 
141 143
         if (isset($modx->config['pwd_hash_algo']) && !empty($modx->config['pwd_hash_algo'])) {
Please login to merge, or discard this patch.
manager/includes/extenders/deprecated.functions.inc.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,8 @@
 block discarded – undo
177 177
      * @return bool|string
178 178
      */
179 179
     public function putChunk($chunkName)
180
-    { // alias name >.<
180
+    {
181
+// alias name >.<
181 182
         $modx = evolutionCMS();
182 183
 
183 184
         return $modx->getChunk($chunkName);
Please login to merge, or discard this patch.
manager/processors/cache_sync.class.processor.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@  discard block
 block discarded – undo
79 79
      * @return string
80 80
      */
81 81
     public function getParents($id, $path = '')
82
-    { // modx:returns child's parent
82
+    {
83
+// modx:returns child's parent
83 84
         $modx = evolutionCMS();
84 85
         if (empty($this->aliases)) {
85 86
             $f = "id, IF(alias='', id, alias) AS alias, parent, alias_visible";
@@ -456,7 +457,8 @@  discard block
 block discarded – undo
456 457
                         $_ = trim($_);
457 458
                     }
458 459
                     $lastChar = substr($_, -1);
459
-                    if (!in_array($lastChar, $chars)) {// ,320,327,288,284,289
460
+                    if (!in_array($lastChar, $chars)) {
461
+// ,320,327,288,284,289
460 462
                         if (!in_array($prev_token,
461 463
                             array(T_FOREACH, T_WHILE, T_FOR, T_BOOLEAN_AND, T_BOOLEAN_OR, T_DOUBLE_ARROW))) {
462 464
                             $_ .= ' ';
Please login to merge, or discard this patch.
install/actions/action_mode.php 1 patch
Braces   +12 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,20 +1,22 @@
 block discarded – undo
1 1
 <?php
2 2
 // Determine upgradeability
3 3
 $upgradeable = 0;
4
-if (is_file($base_path . MGR_DIR . '/includes/config.inc.php')) { // Include the file so we can test its validity
4
+if (is_file($base_path . MGR_DIR . '/includes/config.inc.php')) {
5
+// Include the file so we can test its validity
5 6
     include_once $base_path . MGR_DIR . '/includes/config.inc.php';
6 7
     // We need to have all connection settings - tho prefix may be empty so we have to ignore it
7 8
     if (isset($dbase)) {
8
-        if (!$conn = @mysqli_connect($database_server, $database_user, $database_password))
9
-            $upgradeable = isset($_POST['installmode']) && $_POST['installmode'] == 'new' ? 0 : 2;
10
-        elseif (!@mysqli_select_db($conn, trim($dbase, '`')))
11
-            $upgradeable = isset($_POST['installmode']) && $_POST['installmode'] == 'new' ? 0 : 2;
12
-        else
13
-            $upgradeable = 1;
9
+        if (!$conn = @mysqli_connect($database_server, $database_user, $database_password)) {
10
+                    $upgradeable = isset($_POST['installmode']) && $_POST['installmode'] == 'new' ? 0 : 2;
11
+        } elseif (!@mysqli_select_db($conn, trim($dbase, '`'))) {
12
+                    $upgradeable = isset($_POST['installmode']) && $_POST['installmode'] == 'new' ? 0 : 2;
13
+        } else {
14
+                    $upgradeable = 1;
15
+        }
16
+    } else {
17
+            $upgradeable = 2;
18
+    }
14 19
     }
15
-    else
16
-        $upgradeable = 2;
17
-}
18 20
 
19 21
 $ph['moduleName']       = $moduleName;
20 22
 $ph['displayNew']       = ($upgradeable!=0) ? 'display:none;' : '';
Please login to merge, or discard this patch.
install/cli-install.php 1 patch
Braces   +98 added lines, -66 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 $args = array_slice($argv, 1);
59 59
 
60
-if ( empty($args) ){
60
+if ( empty($args) ) {
61 61
     echo 'Install Evolution CMS'.PHP_EOL;
62 62
     //$installYes = readline("Type 'y' to continue: ");
63 63
     //if ($installYes != 'y') return;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     $managerlanguage = readline('Мanager language:' . ' [en] ');
77 77
     $installData = readline('Instal demo-site (y/n):' . ' [n] ');
78 78
     
79
-}else{
79
+} else {
80 80
     
81 81
     $cli_variables = [];
82 82
     foreach ($args as $arg) {
@@ -130,21 +130,24 @@  discard block
 block discarded – undo
130 130
 }
131 131
 
132 132
 //////////////////////////////////////////////////////////////////////////////////////
133
-if( ! function_exists('f_owc')){
133
+if( ! function_exists('f_owc')) {
134 134
     /**
135 135
      * @param $path
136 136
      * @param $data
137 137
      * @param null|int $mode
138 138
      */
139
-    function f_owc($path, $data, $mode = null){
139
+    function f_owc($path, $data, $mode = null)
140
+    {
140 141
         try {
141 142
             // make an attempt to create the file
142 143
             $hnd = fopen($path, 'w');
143 144
             fwrite($hnd, $data);
144 145
             fclose($hnd);
145 146
 
146
-            if(null !== $mode) chmod($path, $mode);
147
-        }catch(Exception $e){
147
+            if(null !== $mode) {
148
+                chmod($path, $mode);
149
+            }
150
+        } catch(Exception $e) {
148 151
             // Nothing, this is NOT normal
149 152
             unset($e);
150 153
         }
@@ -210,7 +213,7 @@  discard block
 block discarded – undo
210 213
 
211 214
 // File Browser directories exists?
212 215
 echo strip_tags($_lang['checking_if_images_exist']);
213
-switch(true){
216
+switch(true) {
214 217
     case !file_exists($path."../assets/images"):
215 218
     case !file_exists($path."../assets/files"):
216 219
     case !file_exists($path."../assets/backup"):
@@ -225,7 +228,7 @@  discard block
 block discarded – undo
225 228
 
226 229
 // File Browser directories writable?
227 230
 echo strip_tags($_lang['checking_if_images_writable']);
228
-switch(true){
231
+switch(true) {
229 232
     case !is_writable($path."../assets/images"):
230 233
     case !is_writable($path."../assets/files"):
231 234
     case !is_writable($path."../assets/backup"):
@@ -361,7 +364,7 @@  discard block
 block discarded – undo
361 364
 if ($conn) {
362 365
     echo $_lang['checking_mysql_strict_mode'];
363 366
     $mysqlmode = mysqli_query($conn, "SELECT @@global.sql_mode");
364
-    if (mysqli_num_rows($mysqlmode) > 0){
367
+    if (mysqli_num_rows($mysqlmode) > 0) {
365 368
         $modes = mysqli_fetch_array($mysqlmode, MYSQLI_NUM);
366 369
         //$modes = array("STRICT_TRANS_TABLES"); // for testing
367 370
         // print_r($modes);
@@ -397,9 +400,9 @@  discard block
 block discarded – undo
397 400
 if ($errors > 0) {
398 401
     echo $_lang['setup_cannot_continue'] . ' ';
399 402
 
400
-    if($errors > 1){
403
+    if($errors > 1) {
401 404
         echo $errors . " " . $_lang['errors'] . $_lang['please_correct_errors'] . $_lang['and_try_again_plural'];
402
-    }else{
405
+    } else {
403 406
         echo $_lang['error'] . $_lang['please_correct_error'] . $_lang['and_try_again']. PHP_EOL;
404 407
     }
405 408
 
@@ -445,13 +448,15 @@  discard block
 block discarded – undo
445 448
 
446 449
 // get base path and url
447 450
 $a = explode("install", str_replace("\\", "/", dirname($_SERVER["PHP_SELF"])));
448
-if (count($a) > 1)
451
+if (count($a) > 1) {
449 452
     array_pop($a);
453
+}
450 454
 $url = implode("install", $a);
451 455
 reset($a);
452 456
 $a = explode("install", str_replace("\\", "/", realpath(dirname(__FILE__))));
453
-if (count($a) > 1)
457
+if (count($a) > 1) {
454 458
     array_pop($a);
459
+}
455 460
 $pth = implode("install", $a);
456 461
 unset ($a);
457 462
 $base_url = $url . (substr($url, -1) != "/" ? "/" : "");
@@ -472,7 +477,9 @@  discard block
 block discarded – undo
472 477
     echo $_lang['setup_database_selection_failed']." ".$_lang['setup_database_selection_failed_note'].PHP_EOL;
473 478
     $create = true;
474 479
 } else {
475
-    if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_charset);
480
+    if (function_exists('mysqli_set_charset')) {
481
+        mysqli_set_charset($conn, $database_charset);
482
+    }
476 483
     mysqli_query($conn, "{$database_connection_method} {$database_connection_charset}");
477 484
     echo $_lang['ok'].PHP_EOL;
478 485
 }
@@ -518,7 +525,8 @@  discard block
 block discarded – undo
518 525
      * @param string $propertyString
519 526
      * @return array
520 527
      */
521
-    function parseProperties($propertyString) {
528
+    function parseProperties($propertyString)
529
+    {
522 530
         $parameter= array ();
523 531
         if (!empty ($propertyString)) {
524 532
             $tmpParams= explode("&", $propertyString);
@@ -527,11 +535,14 @@  discard block
 block discarded – undo
527 535
                 if (strpos($tmpParams[$x], '=', 0)) {
528 536
                     $pTmp= explode("=", $tmpParams[$x]);
529 537
                     $pvTmp= explode(";", trim($pTmp[1]));
530
-                    if ($pvTmp[1] == 'list' && $pvTmp[3] != "")
531
-                        $parameter[trim($pTmp[0])]= $pvTmp[3]; //list default
538
+                    if ($pvTmp[1] == 'list' && $pvTmp[3] != "") {
539
+                                            $parameter[trim($pTmp[0])]= $pvTmp[3];
540
+                    }
541
+                    //list default
532 542
                     else
533
-                        if ($pvTmp[1] != 'list' && $pvTmp[2] != "")
534
-                            $parameter[trim($pTmp[0])]= $pvTmp[2];
543
+                        if ($pvTmp[1] != 'list' && $pvTmp[2] != "") {
544
+                                                    $parameter[trim($pTmp[0])]= $pvTmp[2];
545
+                        }
535 546
                 }
536 547
             }
537 548
         }
@@ -579,12 +590,12 @@  discard block
 block discarded – undo
579 590
 $mt = &$moduleTemplates;
580 591
 if(is_dir($templatePath) && is_readable($templatePath)) {
581 592
     $d = dir($templatePath);
582
-    while (false !== ($tplfile = $d->read()))
583
-    {
584
-        if(substr($tplfile, -4) != '.tpl') continue;
593
+    while (false !== ($tplfile = $d->read())) {
594
+        if(substr($tplfile, -4) != '.tpl') {
595
+            continue;
596
+        }
585 597
         $params = parse_docblock($templatePath, $tplfile);
586
-        if(is_array($params) && (count($params)>0))
587
-        {
598
+        if(is_array($params) && (count($params)>0)) {
588 599
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
589 600
             $mt[] = array
590 601
             (
@@ -608,7 +619,9 @@  discard block
 block discarded – undo
608 619
 if(is_dir($tvPath) && is_readable($tvPath)) {
609 620
     $d = dir($tvPath);
610 621
     while (false !== ($tplfile = $d->read())) {
611
-        if(substr($tplfile, -4) != '.tpl') continue;
622
+        if(substr($tplfile, -4) != '.tpl') {
623
+            continue;
624
+        }
612 625
         $params = parse_docblock($tvPath, $tplfile);
613 626
         if(is_array($params) && (count($params)>0)) {
614 627
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
@@ -801,7 +814,8 @@  discard block
 block discarded – undo
801 814
 // setup callback function
802 815
 $callBackFnc = "clean_up";
803 816
 
804
-function clean_up($sqlParser) {
817
+function clean_up($sqlParser)
818
+{
805 819
     $ids = array();
806 820
 
807 821
     // secure web documents - privateweb
@@ -814,9 +828,10 @@  discard block
 block discarded – undo
814 828
     $ds = mysqli_query($sqlParser->conn,$sql);
815 829
     if(!$ds) {
816 830
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
817
-    }
818
-    else {
819
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
831
+    } else {
832
+        while($r = mysqli_fetch_assoc($ds)) {
833
+            $ids[]=$r["id"];
834
+        }
820 835
         if(count($ids)>0) {
821 836
             mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 1 WHERE id IN (".implode(", ",$ids).")");
822 837
             unset($ids);
@@ -833,9 +848,10 @@  discard block
 block discarded – undo
833 848
     $ds = mysqli_query($sqlParser->conn,$sql);
834 849
     if(!$ds) {
835 850
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
836
-    }
837
-    else {
838
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
851
+    } else {
852
+        while($r = mysqli_fetch_assoc($ds)) {
853
+            $ids[]=$r["id"];
854
+        }
839 855
         if(count($ids)>0) {
840 856
             mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 1 WHERE id IN (".implode(", ",$ids).")");
841 857
             unset($ids);
@@ -843,7 +859,8 @@  discard block
 block discarded – undo
843 859
     }
844 860
 }
845 861
 
846
-function parse_docblock($element_dir, $filename) {
862
+function parse_docblock($element_dir, $filename)
863
+{
847 864
     $params = array();
848 865
     $fullpath = $element_dir . '/' . $filename;
849 866
     if(is_readable($fullpath)) {
@@ -944,7 +961,7 @@  discard block
 block discarded – undo
944 961
 // custom or not
945 962
 if (file_exists($path."../assets/cache/siteManager.php")) {
946 963
     $mgrdir = 'include_once(dirname(__FILE__)."/../../assets/cache/siteManager.php");';
947
-}else{
964
+} else {
948 965
     $mgrdir = 'define(\'MGR_DIR\', \'manager\');';
949 966
 }
950 967
 
@@ -1084,7 +1101,9 @@  discard block
 block discarded – undo
1084 1101
                         echo mysqli_error($sqlParser->conn) . PHP_EOL;
1085 1102
                         die();
1086 1103
                     }
1087
-                    if(!is_null($save_sql_id_as)) $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
1104
+                    if(!is_null($save_sql_id_as)) {
1105
+                        $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
1106
+                    }
1088 1107
                     echo "  $name: " . $_lang['installed'] . PHP_EOL;
1089 1108
                 }
1090 1109
             }
@@ -1179,9 +1198,9 @@  discard block
 block discarded – undo
1179 1198
             $overwrite = mysqli_real_escape_string($conn, $moduleChunk[4]);
1180 1199
             $filecontent = $moduleChunk[2];
1181 1200
 
1182
-            if (!file_exists($filecontent))
1183
-                echo "  $name: " . $_lang['unable_install_chunk'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1184
-            else {
1201
+            if (!file_exists($filecontent)) {
1202
+                            echo "  $name: " . $_lang['unable_install_chunk'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1203
+            } else {
1185 1204
 
1186 1205
                 // Create the category if it does not already exist
1187 1206
                 $category_id = getCreateDbCategory($category, $sqlParser);
@@ -1234,9 +1253,9 @@  discard block
 block discarded – undo
1234 1253
             $guid = mysqli_real_escape_string($conn, $moduleModule[4]);
1235 1254
             $shared = mysqli_real_escape_string($conn, $moduleModule[5]);
1236 1255
             $category = mysqli_real_escape_string($conn, $moduleModule[6]);
1237
-            if (!file_exists($filecontent))
1238
-                echo "  $name: " . $_lang['unable_install_module'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1239
-            else {
1256
+            if (!file_exists($filecontent)) {
1257
+                            echo "  $name: " . $_lang['unable_install_module'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1258
+            } else {
1240 1259
 
1241 1260
                 // Create the category if it does not already exist
1242 1261
                 $category = getCreateDbCategory($category, $sqlParser);
@@ -1254,7 +1273,7 @@  discard block
 block discarded – undo
1254 1273
                     }
1255 1274
                     echo "  $name: " . $_lang['upgraded'] . PHP_EOL;
1256 1275
                 } else {
1257
-                    if ($properties != NULL ){
1276
+                    if ($properties != NULL ) {
1258 1277
                         $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
1259 1278
                     }
1260 1279
                     if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_modules` (name,description,modulecode,properties,guid,enable_sharedparams,category) VALUES('$name','$desc','$module','$properties','$guid','$shared', $category);")) {
@@ -1289,9 +1308,9 @@  discard block
 block discarded – undo
1289 1308
                 // parse comma-separated legacy names and prepare them for sql IN clause
1290 1309
                 $leg_names = "'" . implode("','", preg_split('/\s*,\s*/', mysqli_real_escape_string($conn, $modulePlugin[7]))) . "'";
1291 1310
             }
1292
-            if (!file_exists($filecontent))
1293
-                echo "  $name: " . $_lang['unable_install_plugin'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1294
-            else {
1311
+            if (!file_exists($filecontent)) {
1312
+                            echo "  $name: " . $_lang['unable_install_plugin'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1313
+            } else {
1295 1314
 
1296 1315
                 // disable legacy versions based on legacy_names provided
1297 1316
                 if(!empty($leg_names)) {
@@ -1310,7 +1329,7 @@  discard block
 block discarded – undo
1310 1329
                     $insert = true;
1311 1330
                     while($row = mysqli_fetch_assoc($rs)) {
1312 1331
                         $props = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
1313
-                        if($row['description'] == $desc){
1332
+                        if($row['description'] == $desc) {
1314 1333
                             if (! mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_plugins` SET plugincode='$plugin', description='$desc', properties='$props' WHERE id={$row['id']};")) {
1315 1334
                                 echo mysqli_error($sqlParser->conn) . PHP_EOL;
1316 1335
                                 return;
@@ -1332,7 +1351,7 @@  discard block
 block discarded – undo
1332 1351
                     }
1333 1352
                     echo "  $name: " . $_lang['upgraded'] . PHP_EOL;
1334 1353
                 } else {
1335
-                    if ($properties != NULL ){
1354
+                    if ($properties != NULL ) {
1336 1355
                         $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
1337 1356
                     }
1338 1357
                     if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_plugins` (name,description,plugincode,properties,moduleguid,category,disabled) VALUES('$name','$desc','$plugin','$properties','$guid',$category,$disabled);")) {
@@ -1371,9 +1390,9 @@  discard block
 block discarded – undo
1371 1390
             $filecontent = $moduleSnippet[2];
1372 1391
             $properties = $moduleSnippet[3];
1373 1392
             $category = mysqli_real_escape_string($conn, $moduleSnippet[4]);
1374
-            if (!file_exists($filecontent))
1375
-                echo "  $name: " . $_lang['unable_install_snippet'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1376
-            else {
1393
+            if (!file_exists($filecontent)) {
1394
+                            echo "  $name: " . $_lang['unable_install_snippet'] . " '$filecontent' " . $_lang['not_found'] . PHP_EOL;
1395
+            } else {
1377 1396
 
1378 1397
                 // Create the category if it does not already exist
1379 1398
                 $category = getCreateDbCategory($category, $sqlParser);
@@ -1391,7 +1410,7 @@  discard block
 block discarded – undo
1391 1410
                     }
1392 1411
                     echo "  $name: " . $_lang['upgraded'] . PHP_EOL;
1393 1412
                 } else {
1394
-                    if ($properties != NULL ){
1413
+                    if ($properties != NULL ) {
1395 1414
                         $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
1396 1415
                     }
1397 1416
                     if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_snippets` (name,description,snippet,properties,category) VALUES('$name','$desc','$snippet','$properties',$category);")) {
@@ -1484,11 +1503,14 @@  discard block
 block discarded – undo
1484 1503
 }
1485 1504
 
1486 1505
 // call back function
1487
-if ($callBackFnc != "")
1506
+if ($callBackFnc != "") {
1488 1507
     $callBackFnc ($sqlParser);
1508
+}
1489 1509
 
1490 1510
 // Setup the MODX API -- needed for the cache processor
1491
-if (!defined('MODX_MANAGER_PATH')) define('MODX_MANAGER_PATH', $base_path.MGR_DIR.'/');
1511
+if (!defined('MODX_MANAGER_PATH')) {
1512
+    define('MODX_MANAGER_PATH', $base_path.MGR_DIR.'/');
1513
+}
1492 1514
 $database_type = 'mysqli';
1493 1515
 // initiate a new document parser
1494 1516
 include_once($path.'../'.MGR_DIR.'/includes/document.parser.class.inc.php');
@@ -1527,7 +1549,7 @@  discard block
 block discarded – undo
1527 1549
 }
1528 1550
 
1529 1551
 
1530
-if ( empty($args) ){
1552
+if ( empty($args) ) {
1531 1553
     echo PHP_EOL . 'Remove install folder?'.PHP_EOL;
1532 1554
     $removeInstall = readline("Type 'y' or 'n' to continue: ");
1533 1555
 }
@@ -1543,11 +1565,12 @@  discard block
 block discarded – undo
1543 1565
  * @param string $old
1544 1566
  * @return string
1545 1567
  */
1546
-function propUpdate($new,$old){
1568
+function propUpdate($new,$old)
1569
+{
1547 1570
     $newArr = parseProperties($new);
1548 1571
     $oldArr = parseProperties($old);
1549
-    foreach ($oldArr as $k => $v){
1550
-        if (isset($v['0']['options'])){
1572
+    foreach ($oldArr as $k => $v) {
1573
+        if (isset($v['0']['options'])) {
1551 1574
             $oldArr[$k]['0']['options'] = $newArr[$k]['0']['options'];
1552 1575
         }
1553 1576
     }
@@ -1562,12 +1585,17 @@  discard block
 block discarded – undo
1562 1585
  * @param bool|mixed $json
1563 1586
  * @return string
1564 1587
  */
1565
-function parseProperties($propertyString, $json=false) {
1588
+function parseProperties($propertyString, $json=false)
1589
+{
1566 1590
     $propertyString = str_replace('{}', '', $propertyString );
1567 1591
     $propertyString = str_replace('} {', ',', $propertyString );
1568 1592
 
1569
-    if(empty($propertyString)) return array();
1570
-    if($propertyString=='{}' || $propertyString=='[]') return array();
1593
+    if(empty($propertyString)) {
1594
+        return array();
1595
+    }
1596
+    if($propertyString=='{}' || $propertyString=='[]') {
1597
+        return array();
1598
+    }
1571 1599
 
1572 1600
     $jsonFormat = isJson($propertyString, true);
1573 1601
     $property = array();
@@ -1609,7 +1637,7 @@  discard block
 block discarded – undo
1609 1637
 
1610 1638
         }
1611 1639
     // new json-format
1612
-    } else if(!empty($jsonFormat)){
1640
+    } else if(!empty($jsonFormat)) {
1613 1641
         $property = $jsonFormat;
1614 1642
     }
1615 1643
     if ($json) {
@@ -1624,7 +1652,8 @@  discard block
 block discarded – undo
1624 1652
  * @param bool $returnData
1625 1653
  * @return bool|mixed
1626 1654
  */
1627
-function isJson($string, $returnData=false) {
1655
+function isJson($string, $returnData=false)
1656
+{
1628 1657
     $data = json_decode($string, true);
1629 1658
     return (json_last_error() == JSON_ERROR_NONE) ? ($returnData ? $data : true) : false;
1630 1659
 }
@@ -1634,7 +1663,8 @@  discard block
 block discarded – undo
1634 1663
  * @param SqlParser $sqlParser
1635 1664
  * @return int
1636 1665
  */
1637
-function getCreateDbCategory($category, $sqlParser) {
1666
+function getCreateDbCategory($category, $sqlParser)
1667
+{
1638 1668
     $dbase = $sqlParser->dbname;
1639 1669
     $dbase = '`' . trim($dbase,'`') . '`';
1640 1670
     $table_prefix = $sqlParser->prefix;
@@ -1662,7 +1692,8 @@  discard block
 block discarded – undo
1662 1692
  * @param string $type
1663 1693
  * @return string
1664 1694
  */
1665
-function removeDocblock($code, $type) {
1695
+function removeDocblock($code, $type)
1696
+{
1666 1697
 
1667 1698
     $cleaned = preg_replace("/^.*?\/\*\*.*?\*\/\s+/s", '', $code, 1);
1668 1699
 
@@ -1683,8 +1714,9 @@  discard block
 block discarded – undo
1683 1714
         default:
1684 1715
             return $cleaned;
1685 1716
     };
1686
-    if(substr(trim($cleaned),0,$count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/')
1687
-        return $cleaned;
1717
+    if(substr(trim($cleaned),0,$count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/') {
1718
+            return $cleaned;
1719
+    }
1688 1720
 
1689 1721
     // fileBinding not found - return code incl docblock
1690 1722
     return $code;
Please login to merge, or discard this patch.
manager/frames/tree.php 1 patch
Braces   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if (! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6 6
 // invoke OnManagerTreeInit event
7 7
 $evtOut = $modx->invokeEvent('OnManagerTreeInit', $_REQUEST);
8
-if (is_array($evtOut)) {
8
+if (is_array($evtOut)) {
9 9
     echo implode("\n", $evtOut);
10 10
 }
11 11
 ?>
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
 		<a class="treeButton" id="treeMenu_collapsetree" onclick="modx.tree.collapseTree();" title="<?php echo $_lang['collapse_tree']; ?>"><?php echo $_style['collapse_tree']; ?></a>
19 19
 
20
-		<?php if ($modx->hasPermission('new_document')) {
20
+		<?php if ($modx->hasPermission('new_document')) {
21 21
     ?>
22 22
 			<a class="treeButton" id="treeMenu_addresource" onclick="modx.tabs({url:'<?= MODX_MANAGER_URL ?>?a=4', title: '<?php echo $_lang['add_resource']; ?>'});" title="<?php echo $_lang['add_resource']; ?>"><?php echo $_style['add_doc_tree']; ?></a>
23 23
 			<a class="treeButton" id="treeMenu_addweblink" onclick="modx.tabs({url:'<?= MODX_MANAGER_URL ?>?a=72', title: '<?php echo $_lang['add_weblink']; ?>'});" title="<?php echo $_lang['add_weblink']; ?>"><?php echo $_style['add_weblink_tree']; ?></a>
@@ -28,31 +28,31 @@  discard block
 block discarded – undo
28 28
 
29 29
 		<a class="treeButton" id="treeMenu_sortingtree" onclick="modx.tree.showSorter(event);" title="<?php echo $_lang['sort_tree']; ?>"><?php echo $_style['sort_tree']; ?></a>
30 30
 
31
-		<?php if ($modx->hasPermission('edit_document') && $modx->hasPermission('save_document')) {
31
+		<?php if ($modx->hasPermission('edit_document') && $modx->hasPermission('save_document')) {
32 32
         ?>
33 33
 			<a class="treeButton" id="treeMenu_sortingindex" onclick="modx.tabs({url: '<?= MODX_MANAGER_URL ?>?a=56&id=0', title: '<?php echo $_lang['sort_menuindex']; ?>'});" title="<?php echo $_lang['sort_menuindex']; ?>"><?php echo $_style['sort_menuindex']; ?></a>
34 34
 		<?php
35 35
     } ?>
36 36
 
37
-		<?php if ($use_browser && $modx->hasPermission('assets_images')) {
37
+		<?php if ($use_browser && $modx->hasPermission('assets_images')) {
38 38
         ?>
39 39
 			<a class="treeButton" id="treeMenu_openimages" title="<?php echo $_lang["images_management"] . "\n" . $_lang['em_button_shift'] ?>"><?php echo $_style['images_management']; ?></a>
40 40
 		<?php
41 41
     } ?>
42 42
 
43
-		<?php if ($use_browser && $modx->hasPermission('assets_files')) {
43
+		<?php if ($use_browser && $modx->hasPermission('assets_files')) {
44 44
         ?>
45 45
 			<a class="treeButton" id="treeMenu_openfiles" title="<?php echo $_lang["files_management"] . "\n" . $_lang['em_button_shift'] ?>"><?php echo $_style['files_management']; ?></a>
46 46
 		<?php
47 47
     } ?>
48 48
 
49
-		<?php if ($modx->hasPermission('edit_template') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('edit_chunk') || $modx->hasPermission('edit_plugin')) {
49
+		<?php if ($modx->hasPermission('edit_template') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('edit_chunk') || $modx->hasPermission('edit_plugin')) {
50 50
         ?>
51 51
 			<a class="treeButton" id="treeMenu_openelements" title="<?php echo $_lang["element_management"] . "\n" . $_lang['em_button_shift'] ?>"><?php echo $_style['element_management']; ?></a>
52 52
 		<?php
53 53
     } ?>
54 54
 
55
-		<?php if ($modx->hasPermission('empty_trash')) {
55
+		<?php if ($modx->hasPermission('empty_trash')) {
56 56
         ?>
57 57
 			<a class="treeButton treeButtonDisabled" id="treeMenu_emptytrash" title="<?php echo $_lang['empty_recycle_bin_empty']; ?>"><?php echo $_style['empty_recycle_bin_empty']; ?></a>
58 58
 		<?php
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 		<?php
67 67
         // invoke OnManagerTreePrerender event
68 68
         $evtOut = $modx->invokeEvent('OnManagerTreePrerender', $modx->db->escape($_REQUEST));
69
-        if (is_array($evtOut)) {
69
+        if (is_array($evtOut)) {
70 70
             echo implode("\n", $evtOut);
71 71
         }
72 72
         ?>
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 		<?php
79 79
         // invoke OnManagerTreeRender event
80 80
         $evtOut = $modx->invokeEvent('OnManagerTreeRender', $modx->db->escape($_REQUEST));
81
-        if (is_array($evtOut)) {
81
+        if (is_array($evtOut)) {
82 82
             echo implode("\n", $evtOut);
83 83
         }
84 84
         ?>
Please login to merge, or discard this patch.