Completed
Pull Request — develop (#725)
by Agel_Nash
08:07
created
manager/includes/src/Support/Paginate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
     /**
150 150
      * This function returns the current page number.
151 151
      *
152
-     * @return int
152
+     * @return string
153 153
      */
154 154
     public function getCurrentPage()
155 155
     {
Please login to merge, or discard this patch.
manager/includes/functions/actions/import.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -357,7 +357,7 @@
 block discarded – undo
357 357
 if(!function_exists('getFileContent')) {
358 358
     /**
359 359
      * @param string $filepath
360
-     * @return bool|string
360
+     * @return null|string
361 361
      */
362 362
     function getFileContent($filepath)
363 363
     {
Please login to merge, or discard this patch.
manager/includes/functions/actions/files.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 if(!function_exists('removeLastPath')) {
189 189
     /**
190 190
      * @param string $string
191
-     * @return bool|string
191
+     * @return string|false
192 192
      */
193 193
     function removeLastPath($string)
194 194
     {
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 if(!function_exists('getExtension')) {
207 207
     /**
208 208
      * @param string $string
209
-     * @return bool|string
209
+     * @return string|false
210 210
      *
211 211
      * @TODO: not work if $string contains folder name with dot
212 212
      */
Please login to merge, or discard this patch.
manager/includes/src/Interfaces/CoreInterface.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@  discard block
 block discarded – undo
3 3
 interface CoreInterface
4 4
 {
5 5
     /**
6
-     * @param $type
7
-     * @param $scanPath
8
-     * @param array $ext
6
+     * @param string $type
7
+     * @param string $scanPath
8
+     * @param string[] $ext
9 9
      *
10 10
      * @return array
11 11
      *
@@ -18,6 +18,7 @@  discard block
 block discarded – undo
18 18
      * @param string $phpCode
19 19
      * @param string $namespace
20 20
      * @param array defaultParams
21
+     * @return void
21 22
      */
22 23
     public function addSnippet($name, $phpCode, $namespace = '#', array $defaultParams = array());
23 24
 
@@ -25,6 +26,7 @@  discard block
 block discarded – undo
25 26
      * @param string $name
26 27
      * @param string $text
27 28
      * @param string $namespace
29
+     * @return void
28 30
      */
29 31
     public function addChunk($name, $text, $namespace = '#');
30 32
 }
Please login to merge, or discard this patch.
manager/includes/src/Core.php 1 patch
Doc Comments   +26 added lines, -24 removed lines patch added patch discarded remove patch
@@ -212,7 +212,6 @@  discard block
 block discarded – undo
212 212
 
213 213
     /**
214 214
      * @param array $services
215
-     * @param array $parameters
216 215
      */
217 216
     public function __construct(array $services = array())
218 217
     {
@@ -282,6 +281,9 @@  discard block
 block discarded – undo
282 281
         return $service;
283 282
     }
284 283
 
284
+    /**
285
+     * @param string $name
286
+     */
285 287
     private function checkServiceAlias($name){
286 288
         foreach ($this->providerAliases as $alias => $interface) {
287 289
             if($name === $interface) {
@@ -319,7 +321,7 @@  discard block
 block discarded – undo
319 321
      *
320 322
      * @param object $service         The service.
321 323
      * @param string $name            The service name.
322
-     * @param array  $callDefinitions The service calls definition.
324
+     * @param boolean  $callDefinitions The service calls definition.
323 325
      *
324 326
      * @throws Exceptions\ContainerException On failure.
325 327
      */
@@ -561,7 +563,7 @@  discard block
 block discarded – undo
561 563
      * @param int $count_attempts
562 564
      * @param string $type $type
563 565
      * @param string $responseCode
564
-     * @return bool|null
566
+     * @return false|null
565 567
      * @global string $base_url
566 568
      * @global string $site_url
567 569
      */
@@ -1262,7 +1264,7 @@  discard block
 block discarded – undo
1262 1264
     }
1263 1265
 
1264 1266
     /**
1265
-     * @param $contents
1267
+     * @param string $contents
1266 1268
      * @return mixed
1267 1269
      */
1268 1270
     public function RecoveryEscapedTags($contents)
@@ -1286,7 +1288,7 @@  discard block
 block discarded – undo
1286 1288
     }
1287 1289
 
1288 1290
     /**
1289
-     * @param $tstart
1291
+     * @param double $tstart
1290 1292
      * @return array
1291 1293
      */
1292 1294
     public function getTimerStats($tstart)
@@ -2052,7 +2054,7 @@  discard block
 block discarded – undo
2052 2054
 
2053 2055
     /**
2054 2056
      * Remove Comment-Tags from output like <!--@- Comment -@-->
2055
-     * @param $content
2057
+     * @param string $content
2056 2058
      * @param string $left
2057 2059
      * @param string $right
2058 2060
      * @return mixed
@@ -2228,7 +2230,7 @@  discard block
 block discarded – undo
2228 2230
     /**
2229 2231
      * Run snippets as per the tags in $documentSource and replace the tags with the returned values.
2230 2232
      *
2231
-     * @param $content
2233
+     * @param string $content
2232 2234
      * @return string
2233 2235
      * @internal param string $documentSource
2234 2236
      */
@@ -3263,7 +3265,7 @@  discard block
 block discarded – undo
3263 3265
 
3264 3266
     /**
3265 3267
      * @param $templateID
3266
-     * @return mixed
3268
+     * @return string
3267 3269
      */
3268 3270
     public function _getTemplateCodeFromDB($templateID)
3269 3271
     {
@@ -3306,7 +3308,7 @@  discard block
 block discarded – undo
3306 3308
     /**
3307 3309
      * @param $id
3308 3310
      * @param int $top
3309
-     * @return mixed
3311
+     * @return string
3310 3312
      */
3311 3313
     public function getUltimateParentId($id, $top = 0)
3312 3314
     {
@@ -3646,7 +3648,7 @@  discard block
 block discarded – undo
3646 3648
      *
3647 3649
      * @param int $type Types: 1=template, 2=tv, 3=chunk, 4=snippet, 5=plugin, 6=module, 7=resource, 8=role
3648 3650
      * @param int $id Element- / Resource-id
3649
-     * @return bool
3651
+     * @return false|null
3650 3652
      */
3651 3653
     public function lockElement($type, $id)
3652 3654
     {
@@ -3668,7 +3670,7 @@  discard block
 block discarded – undo
3668 3670
      * @param int $type Types: 1=template, 2=tv, 3=chunk, 4=snippet, 5=plugin, 6=module, 7=resource, 8=role
3669 3671
      * @param int $id Element- / Resource-id
3670 3672
      * @param bool $includeAllUsers true = Deletes not only own user-locks
3671
-     * @return bool
3673
+     * @return false|null
3672 3674
      */
3673 3675
     public function unlockElement($type, $id, $includeAllUsers = false)
3674 3676
     {
@@ -4181,7 +4183,7 @@  discard block
 block discarded – undo
4181 4183
      *                     Default: 1
4182 4184
      * @param string $fields List of fields
4183 4185
      *                       Default: id, pagetitle, description, alias
4184
-     * @return boolean|array
4186
+     * @return string
4185 4187
      */
4186 4188
     public function getPageInfo($pageid = -1, $active = 1, $fields = 'id, pagetitle, description, alias')
4187 4189
     {
@@ -4273,7 +4275,7 @@  discard block
 block discarded – undo
4273 4275
      *
4274 4276
      * @param string $type
4275 4277
      * @param bool $report
4276
-     * @return bool
4278
+     * @return boolean|null
4277 4279
      */
4278 4280
     public function clearCache($type = '', $report = false)
4279 4281
     {
@@ -4639,7 +4641,7 @@  discard block
 block discarded – undo
4639 4641
      * - Placeholders prefix. Default: '{'.
4640 4642
      * @param string $suffix {string}
4641 4643
      * - Placeholders suffix. Default: '}'.
4642
-     * @return bool|mixed|string {string; false} - Parsed chunk or false if $chunkArr is not array.
4644
+     * @return false|string {string; false} - Parsed chunk or false if $chunkArr is not array.
4643 4645
      * - Parsed chunk or false if $chunkArr is not array.
4644 4646
      */
4645 4647
     public function parseChunk($chunkName, $chunkArr, $prefix = '{', $suffix = '}')
@@ -5611,7 +5613,7 @@  discard block
 block discarded – undo
5611 5613
      * Remove event listener - only for use within the current execution cycle
5612 5614
      *
5613 5615
      * @param string $evtName
5614
-     * @return boolean
5616
+     * @return false|null
5615 5617
      */
5616 5618
     public function removeEventListener($evtName)
5617 5619
     {
@@ -5635,7 +5637,7 @@  discard block
 block discarded – undo
5635 5637
      *
5636 5638
      * @param string $evtName
5637 5639
      * @param array $extParams Parameters available to plugins. Each array key will be the PHP variable name, and the array value will be the variable value.
5638
-     * @return boolean|array
5640
+     * @return false|null
5639 5641
      */
5640 5642
     public function invokeEvent($evtName, $extParams = array())
5641 5643
     {
@@ -6280,7 +6282,7 @@  discard block
 block discarded – undo
6280 6282
 
6281 6283
     /**
6282 6284
      * @param string $str
6283
-     * @return bool|mixed|string
6285
+     * @return string
6284 6286
      */
6285 6287
     public function atBindFileContent($str = '')
6286 6288
     {
@@ -6331,8 +6333,8 @@  discard block
 block discarded – undo
6331 6333
     }
6332 6334
 
6333 6335
     /**
6334
-     * @param $str
6335
-     * @return bool|string
6336
+     * @param string $str
6337
+     * @return false|string
6336 6338
      */
6337 6339
     public function getExtFromFilename($str)
6338 6340
     {
@@ -6360,7 +6362,7 @@  discard block
 block discarded – undo
6360 6362
      * @param string $text Error message
6361 6363
      * @param string $file File where the error was detected
6362 6364
      * @param string $line Line number within $file
6363
-     * @return boolean
6365
+     * @return boolean|null
6364 6366
      */
6365 6367
     public function phpError($nr, $text, $file, $line)
6366 6368
     {
@@ -6412,7 +6414,7 @@  discard block
 block discarded – undo
6412 6414
      * @param string $text
6413 6415
      * @param string $line
6414 6416
      * @param string $output
6415
-     * @return bool
6417
+     * @return null|boolean
6416 6418
      */
6417 6419
     public function messageQuit($msg = 'unspecified error', $query = '', $is_error = true, $nr = '', $file = '', $source = '', $text = '', $line = '', $output = '')
6418 6420
     {
@@ -6827,7 +6829,7 @@  discard block
 block discarded – undo
6827 6829
 
6828 6830
     /**
6829 6831
      * @param string $str
6830
-     * @return bool|mixed|string
6832
+     * @return string
6831 6833
      */
6832 6834
     public function atBindInclude($str = '')
6833 6835
     {
@@ -6878,7 +6880,7 @@  discard block
 block discarded – undo
6878 6880
      * @param $str
6879 6881
      * @param int $flags
6880 6882
      * @param string $encode
6881
-     * @return mixed
6883
+     * @return null|string
6882 6884
      */
6883 6885
     public function htmlspecialchars($str, $flags = ENT_COMPAT, $encode = '')
6884 6886
     {
@@ -6886,7 +6888,7 @@  discard block
 block discarded – undo
6886 6888
     }
6887 6889
 
6888 6890
     /**
6889
-     * @param $string
6891
+     * @param string $string
6890 6892
      * @param bool $returnData
6891 6893
      * @return bool|mixed
6892 6894
      */
Please login to merge, or discard this patch.
manager/includes/src/Database.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 
372 372
     /**
373 373
      * @param $fields
374
-     * @param $table
374
+     * @param string $table
375 375
      * @param string $where
376 376
      * @return bool|mixed|mysqli_result
377 377
      */
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
     }
517 517
 
518 518
     /**
519
-     * @param $name
519
+     * @param string $name
520 520
      * @param mysqli_result|string $dsq
521 521
      * @return array
522 522
      */
Please login to merge, or discard this patch.
manager/includes/src/Legacy/Modifiers.php 1 patch
Doc Comments   +27 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     /**
95 95
      * @param string $mode
96 96
      * @param string $modifiers
97
-     * @return bool|string
97
+     * @return false|string
98 98
      */
99 99
     public function _getDelim($mode,$modifiers) {
100 100
         $c = substr($modifiers,0,1);
@@ -131,6 +131,14 @@  discard block
 block discarded – undo
131 131
             return $opt;
132 132
         }
133 133
     }
134
+
135
+    /**
136
+     * @param string $mode
137
+     * @param false|string $delim
138
+     * @param string $modifiers
139
+     *
140
+     * @return string
141
+     */
134 142
     public function _getRemainModifiers($mode,$delim,$modifiers) {
135 143
         if($delim) {
136 144
             if($mode=='(')
@@ -158,6 +166,9 @@  discard block
 block discarded – undo
158 166
         return substr($string,strpos($string, $delim)+$len);
159 167
     }
160 168
 
169
+    /**
170
+     * @param string $modifiers
171
+     */
161 172
     public function splitEachModifiers($modifiers) {
162 173
         $modx = evolutionCMS();
163 174
 
@@ -227,6 +238,10 @@  discard block
 block discarded – undo
227 238
         return $result;
228 239
     }
229 240
 
241
+    /**
242
+     * @param string $key
243
+     * @param string $value
244
+     */
230 245
     public function parsePhx($key,$value,$modifiers)
231 246
     {
232 247
         $modx = evolutionCMS();
@@ -293,6 +308,10 @@  discard block
 block discarded – undo
293 308
         else                  return true;
294 309
     }
295 310
 
311
+    /**
312
+     * @param string $cmd
313
+     * @param string $opt
314
+     */
296 315
     public function getValueFromPreset($key, $value, $cmd, $opt)
297 316
     {
298 317
         $modx = evolutionCMS();
@@ -978,6 +997,9 @@  discard block
 block discarded – undo
978 997
         return $value;
979 998
     }
980 999
 
1000
+    /**
1001
+     * @param string $cmd
1002
+     */
981 1003
     public function includeMdfFile($cmd) {
982 1004
         $modx = evolutionCMS();
983 1005
         $key = $this->key;
@@ -1133,6 +1155,10 @@  discard block
 block discarded – undo
1133 1155
     }
1134 1156
 
1135 1157
     // Sets a placeholder variable which can only be access by Modifiers
1158
+
1159
+    /**
1160
+     * @param string $value
1161
+     */
1136 1162
     public function setModifiersVariable($key, $value) {
1137 1163
         if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1138 1164
     }
Please login to merge, or discard this patch.
manager/includes/src/Legacy/PhpCompat.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
      * @param int $flags
11 11
      * @param string $encode
12 12
      * @param int $safecount
13
-     * @return string|array
13
+     * @return null|string
14 14
      */
15 15
     public function htmlspecialchars($str = '', $flags = ENT_COMPAT, $encode = '', $safecount = 0)
16 16
     {
Please login to merge, or discard this patch.
manager/includes/src/Support/DataGrid.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -207,6 +207,9 @@
 block discarded – undo
207 207
 
208 208
 	// format column values
209 209
 
210
+    /**
211
+     * @param integer $n
212
+     */
210 213
     public function RenderRowFnc($n, $row) {
211 214
 		if($this->_alt == 0) {
212 215
 			$Style = $this->_itemStyle;
Please login to merge, or discard this patch.