Completed
Pull Request — develop (#522)
by Agel_Nash
07:16
created
manager/includes/extenders/modxmailer.class.inc.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,8 +8,8 @@
 block discarded – undo
8 8
  *******************************************************
9 9
  */
10 10
 
11
-use PHPMailer\PHPMailer\PHPMailer;
12 11
 use PHPMailer\PHPMailer\Exception;
12
+use PHPMailer\PHPMailer\PHPMailer;
13 13
 
14 14
 require MODX_MANAGER_PATH . 'includes/controls/phpmailer/Exception.php';
15 15
 require MODX_MANAGER_PATH . 'includes/controls/phpmailer/PHPMailer.php';
Please login to merge, or discard this patch.
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -11,9 +11,9 @@  discard block
 block discarded – undo
11 11
 use PHPMailer\PHPMailer\PHPMailer;
12 12
 use PHPMailer\PHPMailer\Exception;
13 13
 
14
-require MODX_MANAGER_PATH . 'includes/controls/phpmailer/Exception.php';
15
-require MODX_MANAGER_PATH . 'includes/controls/phpmailer/PHPMailer.php';
16
-require MODX_MANAGER_PATH . 'includes/controls/phpmailer/SMTP.php';
14
+require MODX_MANAGER_PATH.'includes/controls/phpmailer/Exception.php';
15
+require MODX_MANAGER_PATH.'includes/controls/phpmailer/PHPMailer.php';
16
+require MODX_MANAGER_PATH.'includes/controls/phpmailer/SMTP.php';
17 17
 
18 18
 /**
19 19
  * Class MODxMailer
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
     public function init(\DocumentParser $modx)
32 32
     {
33 33
         $this->modx = $modx;
34
-        $this->PluginDir = MODX_MANAGER_PATH . 'includes/controls/phpmailer/';
34
+        $this->PluginDir = MODX_MANAGER_PATH.'includes/controls/phpmailer/';
35 35
 
36 36
         switch ($modx->config['email_method']) {
37 37
             case 'smtp':
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
             mb_language($this->mb_language);
96 96
             mb_internal_encoding($modx->config['modx_charset']);
97 97
         }
98
-        $exconf = MODX_MANAGER_PATH . 'includes/controls/phpmailer/config.inc.php';
98
+        $exconf = MODX_MANAGER_PATH.'includes/controls/phpmailer/config.inc.php';
99 99
         if (is_file($exconf)) {
100 100
             include($exconf);
101 101
         }
@@ -163,12 +163,12 @@  discard block
 block discarded – undo
163 163
         }
164 164
 
165 165
         if ($this->modx->debug) {
166
-            $debug_info = 'CharSet = ' . $this->CharSet . "\n";
167
-            $debug_info .= 'Encoding = ' . $this->Encoding . "\n";
168
-            $debug_info .= 'mb_language = ' . $this->mb_language . "\n";
169
-            $debug_info .= 'encode_header_method = ' . $this->encode_header_method . "\n";
166
+            $debug_info = 'CharSet = '.$this->CharSet."\n";
167
+            $debug_info .= 'Encoding = '.$this->Encoding."\n";
168
+            $debug_info .= 'mb_language = '.$this->mb_language."\n";
169
+            $debug_info .= 'encode_header_method = '.$this->encode_header_method."\n";
170 170
             $debug_info .= "send_mode = {$mode}\n";
171
-            $debug_info .= 'Subject = ' . $this->Subject . "\n";
171
+            $debug_info .= 'Subject = '.$this->Subject."\n";
172 172
             $log = "<pre>{$debug_info}\n{$header}\n{$org_body}</pre>";
173 173
             $this->modx->logEvent(1, 1, $log, 'MODxMailer debug information');
174 174
 
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
             ini_set('sendmail_from', $old_from);
233 233
         }
234 234
         if (!$rt) {
235
-            $msg = $this->Lang('instantiate') . "<br />\n";
235
+            $msg = $this->Lang('instantiate')."<br />\n";
236 236
             $msg .= "{$this->Subject}<br />\n";
237 237
             $msg .= "{$this->FromName}&lt;{$this->From}&gt;<br />\n";
238 238
             $msg .= mb_convert_encoding($body, $this->modx->config['modx_charset'], $this->CharSet);
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
      */
252 252
     public function SetError($msg)
253 253
     {
254
-        $msg .= '<pre>' . print_r(get_object_vars($this), true) . '</pre>';
254
+        $msg .= '<pre>'.print_r(get_object_vars($this), true).'</pre>';
255 255
         $this->modx->config['send_errormail'] = '0';
256 256
         $this->modx->logEvent(0, 3, $msg, 'phpmailer');
257 257
 
@@ -280,14 +280,14 @@  discard block
 block discarded – undo
280 280
     /**
281 281
      * @return string
282 282
      */
283
-    public function getMIMEHeader() {
283
+    public function getMIMEHeader(){
284 284
         return $this->MIMEHeader;
285 285
     }
286 286
 
287 287
     /**
288 288
      * @return string
289 289
      */
290
-    public function getMIMEBody() {
290
+    public function getMIMEBody(){
291 291
         return $this->MIMEBody;
292 292
     }
293 293
 
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
      *
297 297
      * @return $this
298 298
      */
299
-    public function setMIMEHeader($header = '') {
299
+    public function setMIMEHeader($header = ''){
300 300
         $this->MIMEHeader = $header;
301 301
 
302 302
         return $this;
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
      *
308 308
      * @return $this
309 309
      */
310
-    public function setMIMEBody($body = '') {
310
+    public function setMIMEBody($body = ''){
311 311
         $this->MIMEBody = $body;
312 312
 
313 313
         return $this;
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
      *
319 319
      * @return $this
320 320
      */
321
-    public function setMailHeader($header = '') {
321
+    public function setMailHeader($header = ''){
322 322
         $this->mailHeader = $header;
323 323
 
324 324
         return $this;
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
     /**
328 328
      * @return string
329 329
      */
330
-    public function getMessageID() {
331
-        return trim($this->lastMessageID,'<>');
330
+    public function getMessageID(){
331
+        return trim($this->lastMessageID, '<>');
332 332
     }
333 333
 }
Please login to merge, or discard this patch.
install/actions/action_install.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@
 block discarded – undo
43 43
 	var chk = document.install.rminstaller;
44 44
 	if(chk && chk.checked) {
45 45
 		// remove install folder and files
46
-		window.location.href = "../<?php echo MGR_DIR;?>/processors/remove_installer.processor.php?rminstall=1";
46
+		window.location.href = "../<?php echo MGR_DIR; ?>/processors/remove_installer.processor.php?rminstall=1";
47 47
 	}
48 48
 	else {
49
-		window.location.href = "../<?php echo MGR_DIR;?>/";
49
+		window.location.href = "../<?php echo MGR_DIR; ?>/";
50 50
 	}
51 51
 }
52 52
 /* ]]> */
Please login to merge, or discard this patch.
install/connection.databasetest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,12 +6,12 @@  discard block
 block discarded – undo
6 6
 $installMode = $_POST['installMode'];
7 7
 
8 8
 $self = 'install/connection.databasetest.php';
9
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
9
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
10 10
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
11 11
 	include_once("{$base_path}assets/cache/siteManager.php");
12 12
 }
13
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
14
-	define('MGR_DIR','manager');
13
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
14
+	define('MGR_DIR', 'manager');
15 15
 }
16 16
 require_once("lang.php");
17 17
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
32 32
         $query = "CREATE DATABASE `".$database_name."` CHARACTER SET ".$database_charset." COLLATE ".$database_collation.";";
33 33
 
34
-        if (! mysqli_query($conn, $query)){
34
+        if (!mysqli_query($conn, $query)) {
35 35
             $output .= '<span id="database_fail" style="color:#FF0000;">'.$_lang['status_failed_could_not_create_database'].'</span>';
36 36
         }
37 37
         else {
Please login to merge, or discard this patch.
install/functions.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -4,9 +4,9 @@  discard block
 block discarded – undo
4 4
 	global $_lang;
5 5
 	
6 6
 	// session loop-back tester
7
-	if(!isset($_GET['action']) || $_GET['action']!=='mode')
7
+	if (!isset($_GET['action']) || $_GET['action'] !== 'mode')
8 8
 	{
9
-		if(!isset($_SESSION['test']) || $_SESSION['test']!=1)
9
+		if (!isset($_SESSION['test']) || $_SESSION['test'] != 1)
10 10
 		{
11 11
 			echo '
12 12
 <html>
@@ -22,8 +22,8 @@  discard block
 block discarded – undo
22 22
 </head>
23 23
 <body>
24 24
 	<div class="install">
25
-		<p>' . $_lang["session_problem"] . '</p>
26
-		<p><a href="./">' .$_lang["session_problem_try_again"] . '</a></p>
25
+		<p>' . $_lang["session_problem"].'</p>
26
+		<p><a href="./">' .$_lang["session_problem_try_again"].'</a></p>
27 27
 	</div>
28 28
 </body>
29 29
 </html>';
@@ -32,28 +32,28 @@  discard block
 block discarded – undo
32 32
 	}
33 33
 }
34 34
 
35
-function parse($src,$ph,$left='[+',$right='+]')
35
+function parse($src, $ph, $left = '[+', $right = '+]')
36 36
 {
37
-	foreach($ph as $k=>$v)
37
+	foreach ($ph as $k=>$v)
38 38
 	{
39
-		$k = $left . $k . $right;
40
-		$src = str_replace($k,$v,$src);
39
+		$k = $left.$k.$right;
40
+		$src = str_replace($k, $v, $src);
41 41
 	}
42 42
 	return $src;
43 43
 }
44 44
 
45 45
 function ph()
46 46
 {
47
-	global $_lang,$moduleName,$moduleVersion,$modx_textdir,$modx_release_date;
47
+	global $_lang, $moduleName, $moduleVersion, $modx_textdir, $modx_release_date;
48 48
 
49
-	if(isset($_SESSION['installmode'])) $installmode = $_SESSION['installmode'];
49
+	if (isset($_SESSION['installmode'])) $installmode = $_SESSION['installmode'];
50 50
 	else                                $installmode = get_installmode();
51 51
 
52 52
 	$ph['pagetitle']     = $_lang['modx_install'];
53
-	$ph['textdir']       = $modx_textdir ? ' id="rtl"':'';
53
+	$ph['textdir']       = $modx_textdir ? ' id="rtl"' : '';
54 54
 	$ph['help_link']     = $installmode == 0 ? $_lang['help_link_new'] : $_lang['help_link_upd'];
55 55
 	$ph['version']       = $moduleVersion;
56
-	$ph['release_date']  = ($modx_textdir ? '&rlm;':'') . $modx_release_date;
56
+	$ph['release_date']  = ($modx_textdir ? '&rlm;' : '').$modx_release_date;
57 57
 	$ph['footer1']       = $_lang['modx_footer1'];
58 58
 	$ph['footer2']       = $_lang['modx_footer2'];
59 59
 	$ph['current_year']  = date('Y');
@@ -62,20 +62,20 @@  discard block
 block discarded – undo
62 62
 
63 63
 function get_installmode()
64 64
 {
65
-	global $base_path,$database_server, $database_user, $database_password, $dbase, $table_prefix;
65
+	global $base_path, $database_server, $database_user, $database_password, $dbase, $table_prefix;
66 66
 	
67 67
 	$conf_path = "{$base_path}manager/includes/config.inc.php";
68 68
 	if (!is_file($conf_path)) $installmode = 0;
69
-	elseif(isset($_POST['installmode'])) $installmode = $_POST['installmode'];
69
+	elseif (isset($_POST['installmode'])) $installmode = $_POST['installmode'];
70 70
 	else
71 71
 	{
72 72
 		include_once("{$base_path}manager/includes/config.inc.php");
73 73
 		
74
-		if(!isset($dbase) || empty($dbase)) $installmode = 0;
74
+		if (!isset($dbase) || empty($dbase)) $installmode = 0;
75 75
 		else
76 76
 		{
77 77
 			$conn = mysqli_connect($database_server, $database_user, $database_password);
78
-			if($conn)
78
+			if ($conn)
79 79
 			{
80 80
 				$_SESSION['database_server']   = $database_server;
81 81
 				$_SESSION['database_user']     = $database_user;
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 			}
87 87
 			else $rs = false;
88 88
 			
89
-			if($rs)
89
+			if ($rs)
90 90
 			{
91 91
 				$_SESSION['dbase']                      = $dbase;
92 92
 				$_SESSION['table_prefix']               = $table_prefix;
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 				
96 96
 				$tbl_system_settings = "`{$dbase}`.`{$table_prefix}system_settings`";
97 97
 				$rs = mysqli_query($conn, "SELECT setting_value FROM {$tbl_system_settings} WHERE setting_name='settings_version'");
98
-				if($rs)
98
+				if ($rs)
99 99
 				{
100 100
 					$row = mysqli_fetch_assoc($rs);
101 101
 					$settings_version = $row['setting_value'];
Please login to merge, or discard this patch.
install/connection.servertest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -5,12 +5,12 @@  discard block
 block discarded – undo
5 5
 $pwd = $_POST['pwd'];
6 6
 
7 7
 $self = 'install/connection.servertest.php';
8
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
8
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
9 9
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
10 10
 	include_once("{$base_path}assets/cache/siteManager.php");
11 11
 }
12
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
13
-	define('MGR_DIR','manager');
12
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
13
+	define('MGR_DIR', 'manager');
14 14
 }
15 15
 require_once("lang.php");
16 16
 
@@ -22,12 +22,12 @@  discard block
 block discarded – undo
22 22
     $output .= '<span id="server_pass" style="color:#80c000;"> '.$_lang['status_passed_server'].'</span>';
23 23
 
24 24
     // Mysql version check
25
-    if ( version_compare(mysqli_get_server_info($conn), '5.0.51', '=') ) {
25
+    if (version_compare(mysqli_get_server_info($conn), '5.0.51', '=')) {
26 26
         $output .= '<br /><span style="color:#FF0000;"> '.$_lang['mysql_5051'].'</span>';
27 27
     }
28 28
     // Mode check
29 29
     $mysqlmode = mysqli_query($conn, "SELECT @@session.sql_mode");
30
-    if (@mysqli_num_rows($mysqlmode) > 0){
30
+    if (@mysqli_num_rows($mysqlmode) > 0) {
31 31
         $modes = mysqli_fetch_array($mysqlmode, MYSQLI_NUM);
32 32
         $strictMode = false;
33 33
         foreach ($modes as $mode) {
Please login to merge, or discard this patch.
install/connection.collation.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -5,17 +5,17 @@  discard block
 block discarded – undo
5 5
 $pwd = $_POST['pwd'];
6 6
 
7 7
 $self = 'install/connection.collation.php';
8
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
8
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
9 9
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
10 10
 	include_once("{$base_path}assets/cache/siteManager.php");
11 11
 }
12
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
13
-	define('MGR_DIR','manager');
12
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
13
+	define('MGR_DIR', 'manager');
14 14
 }
15 15
 require_once('lang.php');
16 16
 
17 17
 $conn = mysqli_connect($host, $uid, $pwd);
18
-if(!$conn) exit('can not connect');
18
+if (!$conn) exit('can not connect');
19 19
 
20 20
 // get collation
21 21
 $rs = mysqli_query($conn, "SHOW COLLATION");
@@ -29,20 +29,20 @@  discard block
 block discarded – undo
29 29
     $database_collation = htmlentities($_POST['database_collation']);
30 30
     $recommend_collation = $_lang['recommend_collation'];
31 31
     
32
-    if    (isset($_[$recommend_collation])) $_[$recommend_collation] = ' selected';
33
-    elseif(isset($_['utf8mb4_general_ci'])) $_['utf8mb4_general_ci'] = ' selected';
34
-    elseif(isset($_['utf8_general_ci']))    $_['utf8_general_ci']    = ' selected';
35
-    elseif(isset($_[$database_collation]))  $_[$database_collation]  = ' selected';
32
+    if (isset($_[$recommend_collation])) $_[$recommend_collation] = ' selected';
33
+    elseif (isset($_['utf8mb4_general_ci'])) $_['utf8mb4_general_ci'] = ' selected';
34
+    elseif (isset($_['utf8_general_ci']))    $_['utf8_general_ci']    = ' selected';
35
+    elseif (isset($_[$database_collation]))  $_[$database_collation]  = ' selected';
36 36
     
37
-    $_ = sortItem($_,$_lang['recommend_collations_order']);
37
+    $_ = sortItem($_, $_lang['recommend_collations_order']);
38 38
     
39
-    foreach($_ as $collation=>$selected) {
39
+    foreach ($_ as $collation=>$selected) {
40 40
         $collation = htmlentities($collation);
41 41
         // if(substr($collation,0,4)!=='utf8') continue;
42
-        if(strpos($collation,'sjis')===0) continue;
43
-        if($collation=='recommend')
42
+        if (strpos($collation, 'sjis') === 0) continue;
43
+        if ($collation == 'recommend')
44 44
             $output .= '<optgroup label="recommend">';
45
-        elseif($collation=='unrecommend')
45
+        elseif ($collation == 'unrecommend')
46 46
             $output .= '</optgroup><optgroup label="unrecommend">';
47 47
         else
48 48
             $output .= sprintf('<option value="%s" %s>%s</option>', $collation, $selected, $collation);
@@ -55,17 +55,17 @@  discard block
 block discarded – undo
55 55
 
56 56
 
57 57
 
58
-function sortItem($array=array(),$order='utf8mb4,utf8') {
58
+function sortItem($array = array(), $order = 'utf8mb4,utf8'){
59 59
     $rs = array('recommend'=>'');
60 60
     $order = explode(',', $order);
61
-    foreach($order as $v) {
62
-    	foreach($array as $name=>$sel) {
63
-        	if(strpos($name,$v)!==false) {
61
+    foreach ($order as $v) {
62
+    	foreach ($array as $name=>$sel) {
63
+        	if (strpos($name, $v) !== false) {
64 64
         		$rs[$name] = $array[$name];
65 65
         		unset($array[$name]);
66 66
         	}
67 67
     	}
68 68
     }
69
-    $rs['unrecommend']='';
69
+    $rs['unrecommend'] = '';
70 70
     return $rs + $array;
71 71
 }
Please login to merge, or discard this patch.
install/index.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 }
10 10
 
11 11
 $self = 'install/index.php';
12
-$base_path = str_replace($self,'',str_replace('\\','/', __FILE__));
12
+$base_path = str_replace($self, '', str_replace('\\', '/', __FILE__));
13 13
 require_once("{$base_path}install/functions.php");
14 14
 
15 15
 // set error reporting
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 if (is_file("{$base_path}assets/cache/siteManager.php")) {
19 19
 	include_once("{$base_path}assets/cache/siteManager.php");
20 20
 }
21
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
21
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
22 22
 	define('MGR_DIR', 'manager');
23 23
 }
24 24
 
@@ -38,26 +38,26 @@  discard block
 block discarded – undo
38 38
 $moduleSQLDataFile = "setup.data.sql";
39 39
 $moduleSQLResetFile = "setup.data.reset.sql";
40 40
 
41
-$moduleChunks = array (); // chunks - array : name, description, type - 0:file or 1:content, file or content
42
-$moduleTemplates = array (); // templates - array : name, description, type - 0:file or 1:content, file or content
43
-$moduleSnippets = array (); // snippets - array : name, description, type - 0:file or 1:content, file or content,properties
44
-$modulePlugins = array (); // plugins - array : name, description, type - 0:file or 1:content, file or content,properties, events,guid
45
-$moduleModules = array (); // modules - array : name, description, type - 0:file or 1:content, file or content,properties, guid
46
-$moduleTemplates = array (); // templates - array : name, description, type - 0:file or 1:content, file or content,properties
47
-$moduleTVs = array (); // template variables - array : name, description, type - 0:file or 1:content, file or content,properties
41
+$moduleChunks = array(); // chunks - array : name, description, type - 0:file or 1:content, file or content
42
+$moduleTemplates = array(); // templates - array : name, description, type - 0:file or 1:content, file or content
43
+$moduleSnippets = array(); // snippets - array : name, description, type - 0:file or 1:content, file or content,properties
44
+$modulePlugins = array(); // plugins - array : name, description, type - 0:file or 1:content, file or content,properties, events,guid
45
+$moduleModules = array(); // modules - array : name, description, type - 0:file or 1:content, file or content,properties, guid
46
+$moduleTemplates = array(); // templates - array : name, description, type - 0:file or 1:content, file or content,properties
47
+$moduleTVs = array(); // template variables - array : name, description, type - 0:file or 1:content, file or content,properties
48 48
 $moduleDependencies = array(); // module depedencies - array : module, table, column, type, name
49 49
 
50
-$errors= 0;
50
+$errors = 0;
51 51
 
52 52
 // get post back status
53 53
 $isPostBack = (count($_POST));
54 54
 
55 55
 $ph = ph();
56
-$ph = array_merge($ph,$_lang);
56
+$ph = array_merge($ph, $_lang);
57 57
 $ph['install_language'] = $install_language;
58 58
 
59 59
 ob_start();
60
-$action= isset ($_GET['action']) ? trim(strip_tags($_GET['action'])) : 'language';
60
+$action = isset ($_GET['action']) ? trim(strip_tags($_GET['action'])) : 'language';
61 61
 if (!@include_once("actions/action_{$action}.php")) {
62 62
     die ("Invalid install action attempted. [action={$action}]");
63 63
 }
@@ -65,5 +65,5 @@  discard block
 block discarded – undo
65 65
 ob_end_clean();
66 66
 
67 67
 $tpl = file_get_contents("{$base_path}install/template.tpl");
68
-echo parse($tpl,$ph);
68
+echo parse($tpl, $ph);
69 69
 
Please login to merge, or discard this patch.
manager/actions/mutate_settings/tab5_security_settings.inc.php 1 patch
Spacing   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
     $MODX_SITE_HOSTNAMES = MODX_SITE_HOSTNAMES; // Fix for PHP 5.4
3
-    if(empty($valid_hostnames) && empty($MODX_SITE_HOSTNAMES)) $valid_hostnames = $_SERVER['HTTP_HOST'];
3
+    if (empty($valid_hostnames) && empty($MODX_SITE_HOSTNAMES)) $valid_hostnames = $_SERVER['HTTP_HOST'];
4 4
 ?>
5 5
 <!-- Interface & editor settings -->
6 6
 <div class="tab-page" id="tabPageSecurity">
@@ -11,10 +11,10 @@  discard block
 block discarded – undo
11 11
 <tr>
12 12
 <th><?php echo $_lang['allow_eval_title']; ?><br><small>[(allow_eval)]</small></th>
13 13
 <td>
14
-<?php echo wrap_label($_lang['allow_eval_with_scan']         , form_radio('allow_eval','with_scan'));?><br />
15
-<?php echo wrap_label($_lang['allow_eval_with_scan_at_post'] , form_radio('allow_eval','with_scan_at_post'));?><br />
16
-<?php echo wrap_label($_lang['allow_eval_everytime_eval']    , form_radio('allow_eval','everytime_eval'));?><br />
17
-<?php echo wrap_label($_lang['allow_eval_dont_eval']         , form_radio('allow_eval','dont_eval'));?>
14
+<?php echo wrap_label($_lang['allow_eval_with_scan'], form_radio('allow_eval', 'with_scan')); ?><br />
15
+<?php echo wrap_label($_lang['allow_eval_with_scan_at_post'], form_radio('allow_eval', 'with_scan_at_post')); ?><br />
16
+<?php echo wrap_label($_lang['allow_eval_everytime_eval'], form_radio('allow_eval', 'everytime_eval')); ?><br />
17
+<?php echo wrap_label($_lang['allow_eval_dont_eval'], form_radio('allow_eval', 'dont_eval')); ?>
18 18
     <div class="comment">
19 19
         <?php echo $_lang['allow_eval_msg'] ?>
20 20
     </div>
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 <tr>
40 40
     <th><?php echo $_lang['check_files_onlogin_title'] ?><br><small>[(check_files_onlogin)]</small></th>
41 41
     <td>
42
-      <textarea name="check_files_onlogin"><?php echo $check_files_onlogin;?></textarea><br />
42
+      <textarea name="check_files_onlogin"><?php echo $check_files_onlogin; ?></textarea><br />
43 43
         
44 44
 </td>
45 45
 </tr>
@@ -49,8 +49,8 @@  discard block
 block discarded – undo
49 49
     <tr>
50 50
       <td nowrap class="warning"><?php echo $_lang['validate_referer_title'] ?><br><small>[(validate_referer)]</small></td>
51 51
       <td>
52
-        <?php echo wrap_label($_lang['yes'],form_radio('validate_referer', 1));?><br />
53
-        <?php echo wrap_label($_lang['no'], form_radio('validate_referer', 0));?>
52
+        <?php echo wrap_label($_lang['yes'], form_radio('validate_referer', 1)); ?><br />
53
+        <?php echo wrap_label($_lang['no'], form_radio('validate_referer', 0)); ?>
54 54
       </td>
55 55
     </tr>
56 56
     <tr>
@@ -85,25 +85,25 @@  discard block
 block discarded – undo
85 85
   <tr>
86 86
 <th><?php echo $_lang['a17_error_reporting_title']; ?><br><small>[(error_reporting)]</small></th>
87 87
 <td>
88
-<?php echo wrap_label($_lang['a17_error_reporting_opt0'], form_radio('error_reporting','0'));?><br />
89
-<?php echo wrap_label($_lang['a17_error_reporting_opt1'], form_radio('error_reporting','1'));?><br />
90
-<?php echo wrap_label($_lang['a17_error_reporting_opt2'], form_radio('error_reporting','2'));?><br />
91
-<?php echo wrap_label($_lang['a17_error_reporting_opt99'],form_radio('error_reporting','99'));?>
88
+<?php echo wrap_label($_lang['a17_error_reporting_opt0'], form_radio('error_reporting', '0')); ?><br />
89
+<?php echo wrap_label($_lang['a17_error_reporting_opt1'], form_radio('error_reporting', '1')); ?><br />
90
+<?php echo wrap_label($_lang['a17_error_reporting_opt2'], form_radio('error_reporting', '2')); ?><br />
91
+<?php echo wrap_label($_lang['a17_error_reporting_opt99'], form_radio('error_reporting', '99')); ?>
92 92
 </td>
93 93
 </tr>
94 94
 <tr>
95 95
     <td width="200">&nbsp;</td>
96
-    <td class="comment"> <?php echo $_lang['a17_error_reporting_msg'];?></td>
96
+    <td class="comment"> <?php echo $_lang['a17_error_reporting_msg']; ?></td>
97 97
 </tr>
98 98
 <tr><td colspan="2"><div class="split"></div></td></tr>
99 99
 <tr>
100 100
 <th><?php echo $_lang['mutate_settings.dynamic.php6']; ?><br><small>[(send_errormail)]</small></th>
101 101
 <td>
102
-<?php echo wrap_label($_lang['mutate_settings.dynamic.php7'],form_radio('send_errormail','0'));?><br />
103
-<?php echo wrap_label('error',form_radio('send_errormail','3'));?><br />
104
-<?php echo wrap_label('error + warning',form_radio('send_errormail','2'));?><br />
105
-<?php echo wrap_label('error + warning + information',form_radio('send_errormail','1'));?><br />
106
-<?php echo parseText($_lang['mutate_settings.dynamic.php8'],array('emailsender'=>$modx->config['emailsender']));?></td>
102
+<?php echo wrap_label($_lang['mutate_settings.dynamic.php7'], form_radio('send_errormail', '0')); ?><br />
103
+<?php echo wrap_label('error', form_radio('send_errormail', '3')); ?><br />
104
+<?php echo wrap_label('error + warning', form_radio('send_errormail', '2')); ?><br />
105
+<?php echo wrap_label('error + warning + information', form_radio('send_errormail', '1')); ?><br />
106
+<?php echo parseText($_lang['mutate_settings.dynamic.php8'], array('emailsender'=>$modx->config['emailsender'])); ?></td>
107 107
 </tr>
108 108
    <tr>
109 109
     <td colspan="2"><div class="split"></div></td>
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
 <tr>
112 112
 <th><?php echo $_lang['enable_bindings_title'] ?><br><small>[(enable_bindings)]</small></th>
113 113
 <td>
114
-<?php echo wrap_label($_lang['yes'],form_radio('enable_bindings','1'));?><br />
115
-<?php echo wrap_label($_lang['no'], form_radio('enable_bindings','0'));?>
114
+<?php echo wrap_label($_lang['yes'], form_radio('enable_bindings', '1')); ?><br />
115
+<?php echo wrap_label($_lang['no'], form_radio('enable_bindings', '0')); ?>
116 116
 
117 117
 </td>
118 118
 </tr>
@@ -153,20 +153,20 @@  discard block
 block discarded – undo
153 153
 <th><?php echo $_lang['pwd_hash_algo_title'] ?><br><small>[(pwd_hash_algo)]</small></th>
154 154
 <td>
155 155
 <?php
156
-if(empty($pwd_hash_algo)) $phm['sel']['UNCRYPT'] = 1;
157
-$phm['e']['BLOWFISH_Y'] = $modx->manager->checkHashAlgorithm('BLOWFISH_Y') ? 0:1;
158
-$phm['e']['BLOWFISH_A'] = $modx->manager->checkHashAlgorithm('BLOWFISH_A') ? 0:1;
159
-$phm['e']['SHA512']     = $modx->manager->checkHashAlgorithm('SHA512') ? 0:1;
160
-$phm['e']['SHA256']     = $modx->manager->checkHashAlgorithm('SHA256') ? 0:1;
161
-$phm['e']['MD5']        = $modx->manager->checkHashAlgorithm('MD5') ? 0:1;
162
-$phm['e']['UNCRYPT']    = $modx->manager->checkHashAlgorithm('UNCRYPT') ? 0:1;
156
+if (empty($pwd_hash_algo)) $phm['sel']['UNCRYPT'] = 1;
157
+$phm['e']['BLOWFISH_Y'] = $modx->manager->checkHashAlgorithm('BLOWFISH_Y') ? 0 : 1;
158
+$phm['e']['BLOWFISH_A'] = $modx->manager->checkHashAlgorithm('BLOWFISH_A') ? 0 : 1;
159
+$phm['e']['SHA512']     = $modx->manager->checkHashAlgorithm('SHA512') ? 0 : 1;
160
+$phm['e']['SHA256']     = $modx->manager->checkHashAlgorithm('SHA256') ? 0 : 1;
161
+$phm['e']['MD5']        = $modx->manager->checkHashAlgorithm('MD5') ? 0 : 1;
162
+$phm['e']['UNCRYPT']    = $modx->manager->checkHashAlgorithm('UNCRYPT') ? 0 : 1;
163 163
 ?>
164
-<?php echo wrap_label('CRYPT_BLOWFISH_Y (salt &amp; stretch)',form_radio('pwd_hash_algo','BLOWFISH_Y', '', $phm['e']['BLOWFISH_Y']));?><br />
165
-<?php echo wrap_label('CRYPT_BLOWFISH_A (salt &amp; stretch)',form_radio('pwd_hash_algo','BLOWFISH_A', '', $phm['e']['BLOWFISH_A']));?><br />
166
-<?php echo wrap_label('CRYPT_SHA512 (salt &amp; stretch)'    ,form_radio('pwd_hash_algo','SHA512'    , '', $phm['e']['SHA512']));?><br />
167
-<?php echo wrap_label('CRYPT_SHA256 (salt &amp; stretch)'    ,form_radio('pwd_hash_algo','SHA256'    , '', $phm['e']['SHA256']));?><br />
168
-<?php echo wrap_label('CRYPT_MD5 (salt &amp; stretch)'       ,form_radio('pwd_hash_algo','MD5'       , '', $phm['e']['MD5']));?><br />
169
-<?php echo wrap_label('UNCRYPT(32 chars salt + SHA-1 hash)'  ,form_radio('pwd_hash_algo','UNCRYPT'  , '', $phm['e']['UNCRYPT']));?>
164
+<?php echo wrap_label('CRYPT_BLOWFISH_Y (salt &amp; stretch)', form_radio('pwd_hash_algo', 'BLOWFISH_Y', '', $phm['e']['BLOWFISH_Y'])); ?><br />
165
+<?php echo wrap_label('CRYPT_BLOWFISH_A (salt &amp; stretch)', form_radio('pwd_hash_algo', 'BLOWFISH_A', '', $phm['e']['BLOWFISH_A'])); ?><br />
166
+<?php echo wrap_label('CRYPT_SHA512 (salt &amp; stretch)', form_radio('pwd_hash_algo', 'SHA512', '', $phm['e']['SHA512'])); ?><br />
167
+<?php echo wrap_label('CRYPT_SHA256 (salt &amp; stretch)', form_radio('pwd_hash_algo', 'SHA256', '', $phm['e']['SHA256'])); ?><br />
168
+<?php echo wrap_label('CRYPT_MD5 (salt &amp; stretch)', form_radio('pwd_hash_algo', 'MD5', '', $phm['e']['MD5'])); ?><br />
169
+<?php echo wrap_label('UNCRYPT(32 chars salt + SHA-1 hash)', form_radio('pwd_hash_algo', 'UNCRYPT', '', $phm['e']['UNCRYPT'])); ?>
170 170
 </td>
171 171
 </tr>
172 172
 <tr>
@@ -182,13 +182,13 @@  discard block
 block discarded – undo
182 182
   ?>
183 183
 <?php
184 184
 $gdAvailable = extension_loaded('gd');
185
-if(!$gdAvailable) $use_captcha = 0;
185
+if (!$gdAvailable) $use_captcha = 0;
186 186
 ?>
187 187
   <tr>
188 188
     <td nowrap class="warning"><?php echo $_lang['captcha_title'] ?><br><small>[(use_captcha)]</small></td>
189
-    <td> <label><input type="radio" id="captchaOn" name="use_captcha" value="1" <?php echo ($use_captcha==1) ? 'checked="checked"' : "" ; echo (!$gdAvailable)? ' readonly="readonly"' : ''; ?> />
189
+    <td> <label><input type="radio" id="captchaOn" name="use_captcha" value="1" <?php echo ($use_captcha == 1) ? 'checked="checked"' : ""; echo (!$gdAvailable) ? ' readonly="readonly"' : ''; ?> />
190 190
       <?php echo $_lang['yes']?></label><br />
191
-      <label><input type="radio" id="captchaOff" name="use_captcha" value="0" <?php echo ($use_captcha==0) ? 'checked="checked"' : "" ; echo (!$gdAvailable)? ' readonly="readonly"' : '';?> />
191
+      <label><input type="radio" id="captchaOff" name="use_captcha" value="0" <?php echo ($use_captcha == 0) ? 'checked="checked"' : ""; echo (!$gdAvailable) ? ' readonly="readonly"' : ''; ?> />
192 192
       <?php echo $_lang['no']?></label> </td>
193 193
   </tr>
194 194
   <tr>
@@ -198,23 +198,23 @@  discard block
 block discarded – undo
198 198
   <tr>
199 199
     <td colspan="2"><div class="split"></div></td>
200 200
   </tr>
201
-  <tr class="captchaRow" <?php echo showHide($use_captcha==1);?>>
201
+  <tr class="captchaRow" <?php echo showHide($use_captcha == 1); ?>>
202 202
     <td nowrap class="warning"><?php echo $_lang['captcha_words_title'] ?><br><small>[(captcha_words)]</small>
203 203
       <br />
204 204
       <p><?php echo $_lang['update_settings_from_language']; ?></p>
205 205
       <select name="reload_captcha_words" id="reload_captcha_words_select" onchange="confirmLangChange(this, 'captcha_words_default', 'captcha_words_input');">
206
-<?php echo get_lang_options('captcha_words_default');?>
206
+<?php echo get_lang_options('captcha_words_default'); ?>
207 207
       </select>
208 208
     </td>
209 209
     <td><input type="text" id="captcha_words_input" name="captcha_words" style="width:250px" value="<?php echo $captcha_words; ?>" />
210
-        <input type="hidden" name="captcha_words_default" id="captcha_words_default_hidden" value="<?php echo addslashes($_lang['captcha_words_default']);?>" />
210
+        <input type="hidden" name="captcha_words_default" id="captcha_words_default_hidden" value="<?php echo addslashes($_lang['captcha_words_default']); ?>" />
211 211
     </td>
212 212
   </tr>
213
-  <tr class="captchaRow" <?php echo showHide($use_captcha==1);?>>
213
+  <tr class="captchaRow" <?php echo showHide($use_captcha == 1); ?>>
214 214
     <td width="200">&nbsp;</td>
215 215
     <td class="comment"><?php echo $_lang['captcha_words_message'] ?></td>
216 216
   </tr>
217
-  <tr class="captchaRow" <?php echo showHide($use_captcha==1);?>>
217
+  <tr class="captchaRow" <?php echo showHide($use_captcha == 1); ?>>
218 218
     <td colspan="2"><div class="split"></div></td>
219 219
   </tr>
220 220
 </table>
Please login to merge, or discard this patch.
manager/actions/mutate_settings/tab3_user_settings.inc.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -6,8 +6,8 @@  discard block
 block discarded – undo
6 6
   <tr>
7 7
     <td nowrap class="warning"><?php echo $_lang['udperms_title'] ?><br><small>[(use_udperms)]</small></td>
8 8
     <td>
9
-        <?php echo wrap_label($_lang['yes'],form_radio('use_udperms', 1, 'id="udPermsOn"'));?><br />
10
-        <?php echo wrap_label($_lang['no'], form_radio('use_udperms', 0, 'id="udPermsOff"'));?>
9
+        <?php echo wrap_label($_lang['yes'], form_radio('use_udperms', 1, 'id="udPermsOn"')); ?><br />
10
+        <?php echo wrap_label($_lang['no'], form_radio('use_udperms', 0, 'id="udPermsOff"')); ?>
11 11
     </td>
12 12
   </tr>
13 13
   <tr>
@@ -17,16 +17,16 @@  discard block
 block discarded – undo
17 17
   <tr>
18 18
     <td colspan="2"><div class="split"></div></td>
19 19
   </tr>
20
-  <tr class="udPerms" <?php echo showHide($use_udperms==1);?>>
20
+  <tr class="udPerms" <?php echo showHide($use_udperms == 1); ?>>
21 21
     <td nowrap class="warning"><?php echo $_lang['udperms_allowroot_title'] ?><br><small>[(udperms_allowroot)]</small></td>
22 22
     <td>
23
-      <label><input type="radio" name="udperms_allowroot" value="1" <?php echo $udperms_allowroot=='1' ? 'checked="checked"' : "" ; ?> />
23
+      <label><input type="radio" name="udperms_allowroot" value="1" <?php echo $udperms_allowroot == '1' ? 'checked="checked"' : ""; ?> />
24 24
       <?php echo $_lang['yes']?></label><br />
25
-      <label><input type="radio" name="udperms_allowroot" value="0" <?php echo $udperms_allowroot=='0' ? 'checked="checked"' : "" ; ?> />
25
+      <label><input type="radio" name="udperms_allowroot" value="0" <?php echo $udperms_allowroot == '0' ? 'checked="checked"' : ""; ?> />
26 26
       <?php echo $_lang['no']?></label>
27 27
     </td>
28 28
   </tr>
29
-  <tr class="udPerms" <?php echo showHide($use_udperms==1);?>>
29
+  <tr class="udPerms" <?php echo showHide($use_udperms == 1); ?>>
30 30
     <td width="200">&nbsp;</td>
31 31
     <td class="comment"><?php echo $_lang['udperms_allowroot_message'] ?></td>
32 32
   </tr>
@@ -39,10 +39,10 @@  discard block
 block discarded – undo
39 39
   <tr>
40 40
     <td nowrap class="warning"><?php echo $_lang['email_method_title'] ?><br><small>[(email_method)]</small></td>
41 41
     <td>
42
-        <?php echo wrap_label($_lang['email_method_mail'],form_radio('email_method','mail','id="useMail"'));?><br />
43
-        <?php echo wrap_label($_lang['email_method_smtp'],form_radio('email_method','smtp','id="useSmtp"'));?>
44
-        <div class="smtpRow" <?php echo showHide($email_method=='smtp');?>>
45
-            <?php include_once(MODX_MANAGER_PATH . 'actions/mutate_settings/snippet_smtp.inc.php'); ?>
42
+        <?php echo wrap_label($_lang['email_method_mail'], form_radio('email_method', 'mail', 'id="useMail"')); ?><br />
43
+        <?php echo wrap_label($_lang['email_method_smtp'], form_radio('email_method', 'smtp', 'id="useSmtp"')); ?>
44
+        <div class="smtpRow" <?php echo showHide($email_method == 'smtp'); ?>>
45
+            <?php include_once(MODX_MANAGER_PATH.'actions/mutate_settings/snippet_smtp.inc.php'); ?>
46 46
         </div>
47 47
     </td>
48 48
   </tr>
@@ -54,11 +54,11 @@  discard block
 block discarded – undo
54 54
       <br />
55 55
       <p><?php echo $_lang['update_settings_from_language']; ?></p>
56 56
       <select name="reload_emailsubject" id="reload_emailsubject_select" onchange="confirmLangChange(this, 'emailsubject_default', 'emailsubject_field');">
57
-<?php echo get_lang_options('emailsubject_default');?>
57
+<?php echo get_lang_options('emailsubject_default'); ?>
58 58
       </select>
59 59
     </td>
60 60
     <td ><input id="emailsubject_field" name="emailsubject" onchange="documentDirty=true;" type="text" maxlength="255" style="width: 250px;" value="<?php echo $emailsubject; ?>" />
61
-        <input type="hidden" name="emailsubject_default" id="emailsubject_default_hidden" value="<?php echo addslashes($_lang['emailsubject_default']);?>" />
61
+        <input type="hidden" name="emailsubject_default" id="emailsubject_default_hidden" value="<?php echo addslashes($_lang['emailsubject_default']); ?>" />
62 62
     </td>
63 63
   </tr>
64 64
   <tr>
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
       <br />
74 74
       <p><?php echo $_lang['update_settings_from_language']; ?></p>
75 75
       <select name="reload_signupemail_message" id="reload_signupemail_message_select" onchange="confirmLangChange(this, 'system_email_signup', 'signupemail_message_textarea');">
76
-<?php echo get_lang_options('system_email_signup');?>
76
+<?php echo get_lang_options('system_email_signup'); ?>
77 77
       </select>
78 78
     </td>
79 79
     <td> <textarea id="signupemail_message_textarea" name="signupemail_message" style="width:100%; height: 120px;"><?php echo $signupemail_message; ?></textarea>
80
-        <input type="hidden" name="system_email_signup_default" id="system_email_signup_hidden" value="<?php echo addslashes($_lang['system_email_signup']);?>" />
80
+        <input type="hidden" name="system_email_signup_default" id="system_email_signup_hidden" value="<?php echo addslashes($_lang['system_email_signup']); ?>" />
81 81
     </td>
82 82
   </tr>
83 83
   <tr>
@@ -92,11 +92,11 @@  discard block
 block discarded – undo
92 92
       <br />
93 93
       <p><?php echo $_lang['update_settings_from_language']; ?></p>
94 94
       <select name="reload_websignupemail_message" id="reload_websignupemail_message_select" onchange="confirmLangChange(this, 'system_email_websignup', 'websignupemail_message_textarea');">
95
-<?php echo get_lang_options('system_email_websignup');?>
95
+<?php echo get_lang_options('system_email_websignup'); ?>
96 96
       </select>
97 97
     </td>
98 98
     <td> <textarea id="websignupemail_message_textarea" name="websignupemail_message" style="width:100%; height: 120px;"><?php echo $websignupemail_message; ?></textarea>
99
-        <input type="hidden" name="system_email_websignup_default" id="system_email_websignup_hidden" value="<?php echo addslashes($_lang['system_email_websignup']);?>" />
99
+        <input type="hidden" name="system_email_websignup_default" id="system_email_websignup_hidden" value="<?php echo addslashes($_lang['system_email_websignup']); ?>" />
100 100
     </td>
101 101
   </tr>
102 102
   <tr>
@@ -111,11 +111,11 @@  discard block
 block discarded – undo
111 111
       <br />
112 112
       <p><?php echo $_lang['update_settings_from_language']; ?></p>
113 113
       <select name="reload_system_email_webreminder_message" id="reload_system_email_webreminder_select" onchange="confirmLangChange(this, 'system_email_webreminder', 'system_email_webreminder_textarea');">
114
-<?php echo get_lang_options('system_email_webreminder');?>
114
+<?php echo get_lang_options('system_email_webreminder'); ?>
115 115
       </select>
116 116
     </td>
117 117
     <td> <textarea id="system_email_webreminder_textarea" name="webpwdreminder_message" style="width:100%; height: 120px;"><?php echo $webpwdreminder_message; ?></textarea>
118
-        <input type="hidden" name="system_email_webreminder_default" id="system_email_webreminder_hidden" value="<?php echo addslashes($_lang['system_email_webreminder']);?>" />
118
+        <input type="hidden" name="system_email_webreminder_default" id="system_email_webreminder_hidden" value="<?php echo addslashes($_lang['system_email_webreminder']); ?>" />
119 119
     </td>
120 120
   </tr>
121 121
   <tr>
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         <?php
128 128
             // invoke OnUserSettingsRender event
129 129
             $evtOut = $modx->invokeEvent('OnUserSettingsRender');
130
-            if(is_array($evtOut)) echo implode("",$evtOut);
130
+            if (is_array($evtOut)) echo implode("", $evtOut);
131 131
         ?>
132 132
     </td>
133 133
   </tr>
Please login to merge, or discard this patch.