Completed
Pull Request — develop (#522)
by Agel_Nash
07:16
created
manager/actions/bkmanager.static.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -515,6 +515,9 @@  discard block
 block discarded – undo
515 515
         $this->setDroptables(false);
516 516
     }
517 517
 
518
+    /**
519
+     * @param boolean $state
520
+     */
518 521
     public function setDroptables($state)
519 522
     {
520 523
         $this->_isDroptables = $state;
@@ -722,6 +725,9 @@  discard block
 block discarded – undo
722 725
     $_SESSION['result_msg'] = $result_code;
723 726
 }
724 727
 
728
+/**
729
+ * @param string $dumpstring
730
+ */
725 731
 function dumpSql(&$dumpstring)
726 732
 {
727 733
     global $modx;
@@ -741,6 +747,9 @@  discard block
 block discarded – undo
741 747
     return true;
742 748
 }
743 749
 
750
+/**
751
+ * @param string $dumpstring
752
+ */
744 753
 function snapshot(&$dumpstring)
745 754
 {
746 755
     global $path;
Please login to merge, or discard this patch.
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 if (!$modx->hasPermission('bk_manager')) {
@@ -9,10 +9,10 @@  discard block
 block discarded – undo
9 9
 $dbase = trim($dbase, '`');
10 10
 
11 11
 if (!isset($modx->config['snapshot_path'])) {
12
-    if (is_dir(MODX_BASE_PATH . 'temp/backup/')) {
13
-        $modx->config['snapshot_path'] = MODX_BASE_PATH . 'temp/backup/';
12
+    if (is_dir(MODX_BASE_PATH.'temp/backup/')) {
13
+        $modx->config['snapshot_path'] = MODX_BASE_PATH.'temp/backup/';
14 14
     } else {
15
-        $modx->config['snapshot_path'] = MODX_BASE_PATH . 'assets/backup/';
15
+        $modx->config['snapshot_path'] = MODX_BASE_PATH.'assets/backup/';
16 16
     }
17 17
 }
18 18
 
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 if ($mode == 'restore1') {
24 24
     if (isset($_POST['textarea']) && !empty($_POST['textarea'])) {
25 25
         $source = trim($_POST['textarea']);
26
-        $_SESSION['textarea'] = $source . "\n";
26
+        $_SESSION['textarea'] = $source."\n";
27 27
     } else {
28 28
         $source = file_get_contents($_FILES['sqlfile']['tmp_name']);
29 29
     }
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
     header('Location: index.php?r=9&a=93');
32 32
     exit;
33 33
 } elseif ($mode == 'restore2') {
34
-    $path = $modx->config['snapshot_path'] . $_POST['filename'];
34
+    $path = $modx->config['snapshot_path'].$_POST['filename'];
35 35
     if (file_exists($path)) {
36 36
         $source = file_get_contents($path);
37 37
         import_sql($source);
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     if (!is_writable(rtrim($modx->config['snapshot_path'], '/'))) {
78 78
         $modx->webAlertAndQuit(parsePlaceholder($_lang["bkmgr_alert_mkdir"], array('snapshot_path' => $modx->config['snapshot_path'])));
79 79
     }
80
-    $sql = "SHOW TABLE STATUS FROM `{$dbase}` LIKE '" . $modx->db->escape($modx->db->config['table_prefix']) . "%'";
80
+    $sql = "SHOW TABLE STATUS FROM `{$dbase}` LIKE '".$modx->db->escape($modx->db->config['table_prefix'])."%'";
81 81
     $rs = $modx->db->query($sql);
82 82
     $tables = $modx->db->getColumn('Name', $rs);
83 83
     $today = date('Y-m-d_H-i-s');
@@ -109,18 +109,18 @@  discard block
 block discarded – undo
109 109
         $modx->webAlertAndQuit('Unable to Backup Database');
110 110
     }
111 111
 } else {
112
-    include_once MODX_MANAGER_PATH . "includes/header.inc.php";  // start normal header
112
+    include_once MODX_MANAGER_PATH."includes/header.inc.php"; // start normal header
113 113
 }
114 114
 
115 115
 if (isset($_SESSION['result_msg']) && $_SESSION['result_msg'] != '') {
116 116
     switch ($_SESSION['result_msg']) {
117 117
         case 'import_ok':
118
-            $ph['result_msg_import'] = '<div class="alert alert-success">' . $_lang["bkmgr_import_ok"] . '</div>';
119
-            $ph['result_msg_snapshot'] = '<div class="alert alert-success">' . $_lang["bkmgr_import_ok"] . '</div>';
118
+            $ph['result_msg_import'] = '<div class="alert alert-success">'.$_lang["bkmgr_import_ok"].'</div>';
119
+            $ph['result_msg_snapshot'] = '<div class="alert alert-success">'.$_lang["bkmgr_import_ok"].'</div>';
120 120
             break;
121 121
         case 'snapshot_ok':
122 122
             $ph['result_msg_import'] = '';
123
-            $ph['result_msg_snapshot'] = '<div class="alert alert-success">' . $_lang["bkmgr_snapshot_ok"] . '</div>';
123
+            $ph['result_msg_snapshot'] = '<div class="alert alert-success">'.$_lang["bkmgr_snapshot_ok"].'</div>';
124 124
             break;
125 125
     }
126 126
     $_SESSION['result_msg'] = '';
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
                 f.style.display = 'none';
180 180
             }
181 181
         }
182
-        <?= (isset($_REQUEST['r']) ? " doRefresh(" . $_REQUEST['r'] . ");" : "") ?>
182
+        <?= (isset($_REQUEST['r']) ? " doRefresh(".$_REQUEST['r'].");" : "") ?>
183 183
 
184 184
     </script>
185 185
 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                                 </thead>
224 224
                                 <tbody>
225 225
                                 <?php
226
-                                $sql = "SHOW TABLE STATUS FROM `{$dbase}` LIKE '" . $modx->db->escape($modx->db->config['table_prefix']) . "%'";
226
+                                $sql = "SHOW TABLE STATUS FROM `{$dbase}` LIKE '".$modx->db->escape($modx->db->config['table_prefix'])."%'";
227 227
                                 $rs = $modx->db->query($sql);
228 228
                                 $i = 0;
229 229
                                 while ($db_status = $modx->db->getRow($rs)) {
@@ -233,29 +233,29 @@  discard block
 block discarded – undo
233 233
                                         $table_string = '';
234 234
                                     }
235 235
 
236
-                                    echo '<tr>' . "\n" . '<td><label class="form-check form-check-label"><input type="checkbox" name="chk[]" class="form-check-input" value="' . $db_status['Name'] . '"' . (strstr($table_string, $db_status['Name']) === false ? '' : ' checked="checked"') . ' /><b class="text-primary">' . $db_status['Name'] . '</b></label></td>' . "\n";
237
-                                    echo '<td class="text-xs-center">' . (!empty($db_status['Comment']) ? '<i class="' . $_style['actions_help'] . '" data-tooltip="' . $db_status['Comment'] . '"></i>' : '') . '</td>' . "\n";
238
-                                    echo '<td class="text-xs-right">' . $db_status['Rows'] . '</td>' . "\n";
239
-                                    echo '<td class="text-xs-right">' . $db_status['Collation'] . '</td>' . "\n";
236
+                                    echo '<tr>'."\n".'<td><label class="form-check form-check-label"><input type="checkbox" name="chk[]" class="form-check-input" value="'.$db_status['Name'].'"'.(strstr($table_string, $db_status['Name']) === false ? '' : ' checked="checked"').' /><b class="text-primary">'.$db_status['Name'].'</b></label></td>'."\n";
237
+                                    echo '<td class="text-xs-center">'.(!empty($db_status['Comment']) ? '<i class="'.$_style['actions_help'].'" data-tooltip="'.$db_status['Comment'].'"></i>' : '').'</td>'."\n";
238
+                                    echo '<td class="text-xs-right">'.$db_status['Rows'].'</td>'."\n";
239
+                                    echo '<td class="text-xs-right">'.$db_status['Collation'].'</td>'."\n";
240 240
 
241 241
                                     // Enable record deletion for certain tables (TRUNCATE TABLE) if they're not already empty
242 242
                                     $truncateable = array(
243
-                                        $modx->db->config['table_prefix'] . 'event_log',
244
-                                        $modx->db->config['table_prefix'] . 'manager_log',
243
+                                        $modx->db->config['table_prefix'].'event_log',
244
+                                        $modx->db->config['table_prefix'].'manager_log',
245 245
                                     );
246 246
                                     if ($modx->hasPermission('settings') && in_array($db_status['Name'], $truncateable) && $db_status['Rows'] > 0) {
247
-                                        echo '<td class="text-xs-right"><a class="text-danger" href="index.php?a=54&mode=' . $action . '&u=' . $db_status['Name'] . '" title="' . $_lang['truncate_table'] . '">' . $modx->nicesize($db_status['Data_length'] + $db_status['Data_free']) . '</a>' . '</td>' . "\n";
247
+                                        echo '<td class="text-xs-right"><a class="text-danger" href="index.php?a=54&mode='.$action.'&u='.$db_status['Name'].'" title="'.$_lang['truncate_table'].'">'.$modx->nicesize($db_status['Data_length'] + $db_status['Data_free']).'</a>'.'</td>'."\n";
248 248
                                     } else {
249
-                                        echo '<td class="text-xs-right">' . $modx->nicesize($db_status['Data_length'] + $db_status['Data_free']) . '</td>' . "\n";
249
+                                        echo '<td class="text-xs-right">'.$modx->nicesize($db_status['Data_length'] + $db_status['Data_free']).'</td>'."\n";
250 250
                                     }
251 251
 
252 252
                                     if ($modx->hasPermission('settings')) {
253
-                                        echo '<td class="text-xs-right">' . ($db_status['Data_free'] > 0 ? '<a class="text-danger" href="index.php?a=54&mode=' . $action . '&t=' . $db_status['Name'] . '" title="' . $_lang['optimize_table'] . '">' . $modx->nicesize($db_status['Data_free']) . '</a>' : '-') . '</td>' . "\n";
253
+                                        echo '<td class="text-xs-right">'.($db_status['Data_free'] > 0 ? '<a class="text-danger" href="index.php?a=54&mode='.$action.'&t='.$db_status['Name'].'" title="'.$_lang['optimize_table'].'">'.$modx->nicesize($db_status['Data_free']).'</a>' : '-').'</td>'."\n";
254 254
                                     } else {
255
-                                        echo '<td class="text-xs-right">' . ($db_status['Data_free'] > 0 ? $modx->nicesize($db_status['Data_free']) : '-') . '</td>' . "\n";
255
+                                        echo '<td class="text-xs-right">'.($db_status['Data_free'] > 0 ? $modx->nicesize($db_status['Data_free']) : '-').'</td>'."\n";
256 256
                                     }
257 257
 
258
-                                    echo '<td class="text-xs-right">' . $modx->nicesize($db_status['Data_length'] - $db_status['Data_free']) . '</td>' . "\n" . '<td class="text-xs-right">' . $modx->nicesize($db_status['Index_length']) . '</td>' . "\n" . '<td class="text-xs-right">' . $modx->nicesize($db_status['Index_length'] + $db_status['Data_length'] + $db_status['Data_free']) . '</td>' . "\n" . "</tr>";
258
+                                    echo '<td class="text-xs-right">'.$modx->nicesize($db_status['Data_length'] - $db_status['Data_free']).'</td>'."\n".'<td class="text-xs-right">'.$modx->nicesize($db_status['Index_length']).'</td>'."\n".'<td class="text-xs-right">'.$modx->nicesize($db_status['Index_length'] + $db_status['Data_length'] + $db_status['Data_free']).'</td>'."\n"."</tr>";
259 259
 
260 260
                                     $total = $total + $db_status['Index_length'] + $db_status['Data_length'];
261 261
                                     $totaloverhead = $totaloverhead + $db_status['Data_free'];
@@ -266,9 +266,9 @@  discard block
 block discarded – undo
266 266
                                 <tr>
267 267
                                     <td class="text-xs-right"><?= $_lang['database_table_totals'] ?></td>
268 268
                                     <td colspan="4">&nbsp;</td>
269
-                                    <td class="text-xs-right"><?= $totaloverhead > 0 ? '<b class="text-danger">' . $modx->nicesize($totaloverhead) . '</b><br />(' . number_format($totaloverhead) . ' B)' : '-' ?></td>
269
+                                    <td class="text-xs-right"><?= $totaloverhead > 0 ? '<b class="text-danger">'.$modx->nicesize($totaloverhead).'</b><br />('.number_format($totaloverhead).' B)' : '-' ?></td>
270 270
                                     <td colspan="2">&nbsp;</td>
271
-                                    <td class="text-xs-right"><?= "<b>" . $modx->nicesize($total) . "</b><br />(" . number_format($total) . " B)" ?></td>
271
+                                    <td class="text-xs-right"><?= "<b>".$modx->nicesize($total)."</b><br />(".number_format($total)." B)" ?></td>
272 272
                                 </tr>
273 273
                                 </tfoot>
274 274
                             </table>
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
                             foreach ($last_result['0'] as $k => $v) {
320 320
                                 $title[] = $k;
321 321
                             }
322
-                            $result = '<thead><tr><th>' . implode('</th><th>', $title) . '</th></tr></thead>';
322
+                            $result = '<thead><tr><th>'.implode('</th><th>', $title).'</th></tr></thead>';
323 323
                             $result .= '<tbody>';
324 324
                             foreach ($last_result as $row) {
325 325
                                 $result_value = array();
@@ -327,11 +327,11 @@  discard block
 block discarded – undo
327 327
                                     foreach ($row as $k => $v) {
328 328
                                         $result_value[] = $v;
329 329
                                     }
330
-                                    $result .= '<tr><td>' . implode('</td><td>', $result_value) . '</td></tr>';
330
+                                    $result .= '<tr><td>'.implode('</td><td>', $result_value).'</td></tr>';
331 331
                                 }
332 332
                             }
333 333
                             $result .= '</tbody>';
334
-                            $result = '<table class="table data">' . $result . '</table>';
334
+                            $result = '<table class="table data">'.$result.'</table>';
335 335
                         }
336 336
                     }
337 337
 
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
                                         while ($count < 11) {
434 434
                                             $line = fgets($file);
435 435
                                             foreach ($detailFields as $label) {
436
-                                                $fileLabel = '# ' . $label;
436
+                                                $fileLabel = '# '.$label;
437 437
                                                 if (strpos($line, $fileLabel) !== false) {
438 438
                                                     $details[$label] = htmlentities(trim(str_replace(array(
439 439
                                                         $fileLabel,
@@ -446,10 +446,10 @@  discard block
 block discarded – undo
446 446
                                         };
447 447
                                         fclose($file);
448 448
 
449
-                                        $tooltip = "Generation Time: " . $details["Generation Time"] . "\n";
450
-                                        $tooltip .= "Server version: " . $details["Server version"] . "\n";
451
-                                        $tooltip .= "PHP Version: " . $details["PHP Version"] . "\n";
452
-                                        $tooltip .= "Host: " . $details["Host"] . "\n";
449
+                                        $tooltip = "Generation Time: ".$details["Generation Time"]."\n";
450
+                                        $tooltip .= "Server version: ".$details["Server version"]."\n";
451
+                                        $tooltip .= "PHP Version: ".$details["PHP Version"]."\n";
452
+                                        $tooltip .= "Host: ".$details["Host"]."\n";
453 453
                                         ?>
454 454
                                         <tr>
455 455
                                             <td><?= $filename ?></td>
@@ -481,7 +481,7 @@  discard block
 block discarded – undo
481 481
 <?php
482 482
 
483 483
 if (is_numeric($_GET['tab'])) {
484
-    echo '<script type="text/javascript">tpDBM.setSelectedIndex( ' . $_GET['tab'] . ' );</script>';
484
+    echo '<script type="text/javascript">tpDBM.setSelectedIndex( '.$_GET['tab'].' );</script>';
485 485
 }
486 486
 
487 487
 include_once "footer.inc.php"; // send footer
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
         // Set line feed
535 535
         $lf = "\n";
536
-        $tempfile_path = $modx->config['base_path'] . 'assets/backup/temp.php';
536
+        $tempfile_path = $modx->config['base_path'].'assets/backup/temp.php';
537 537
 
538 538
         $result = $modx->db->query('SHOW TABLES');
539 539
         $tables = $this->result2Array(0, $result);
@@ -546,15 +546,15 @@  discard block
 block discarded – undo
546 546
 
547 547
         // Set header
548 548
         $output = "#{$lf}";
549
-        $output .= "# " . addslashes($modx->config['site_name']) . " Database Dump{$lf}";
549
+        $output .= "# ".addslashes($modx->config['site_name'])." Database Dump{$lf}";
550 550
         $output .= "# MODX Version:{$version['version']}{$lf}";
551 551
         $output .= "# {$lf}";
552 552
         $output .= "# Host: {$this->database_server}{$lf}";
553
-        $output .= "# Generation Time: " . $modx->toDateFormat(time()) . $lf;
554
-        $output .= "# Server version: " . $modx->db->getVersion() . $lf;
555
-        $output .= "# PHP Version: " . phpversion() . $lf;
553
+        $output .= "# Generation Time: ".$modx->toDateFormat(time()).$lf;
554
+        $output .= "# Server version: ".$modx->db->getVersion().$lf;
555
+        $output .= "# PHP Version: ".phpversion().$lf;
556 556
         $output .= "# Database: `{$this->dbname}`{$lf}";
557
-        $output .= "# Description: " . trim($_REQUEST['backup_title']) . "{$lf}";
557
+        $output .= "# Description: ".trim($_REQUEST['backup_title'])."{$lf}";
558 558
         $output .= "#";
559 559
         file_put_contents($tempfile_path, $output, FILE_APPEND | LOCK_EX);
560 560
         $output = '';
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
                 }
574 574
             }
575 575
             if ($callBack === 'snapshot') {
576
-                if (!preg_match('@^' . $modx->db->config['table_prefix'] . '@', $tblval)) {
576
+                if (!preg_match('@^'.$modx->db->config['table_prefix'].'@', $tblval)) {
577 577
                     continue;
578 578
                 }
579 579
             }
@@ -607,9 +607,9 @@  discard block
 block discarded – undo
607 607
                         ), '\\n', $value);
608 608
                         $value = "'{$value}'";
609 609
                     }
610
-                    $insertdump .= $value . ',';
610
+                    $insertdump .= $value.',';
611 611
                 }
612
-                $output .= rtrim($insertdump, ',') . ");\n";
612
+                $output .= rtrim($insertdump, ',').");\n";
613 613
                 if (1048576 < strlen($output)) {
614 614
                     file_put_contents($tempfile_path, $output, FILE_APPEND | LOCK_EX);
615 615
                     $output = '';
Please login to merge, or discard this patch.
manager/media/rss/rss_parse.inc 4 patches
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -447,6 +447,10 @@  discard block
 block discarded – undo
447 447
     /**
448 448
     * return XML parser, and possibly re-encoded source
449 449
     *
450
+    * @param string $source
451
+    * @param string $out_enc
452
+    * @param string|null $in_enc
453
+    * @param boolean $detect
450 454
     */
451 455
     function create_parser($source, $out_enc, $in_enc, $detect) {
452 456
         if ( substr(phpversion(),0,1) == 5) {
@@ -556,6 +560,9 @@  discard block
 block discarded – undo
556 560
         }
557 561
     }
558 562
 
563
+    /**
564
+     * @param integer $lvl
565
+     */
559 566
     function error ($errormsg, $lvl=E_USER_WARNING) {
560 567
         // append PHP's error message if track_errors enabled
561 568
         if ( isset($php_errormsg) ) {
@@ -591,6 +598,9 @@  discard block
 block discarded – undo
591 598
 	define('CASE_LOWER', 0);
592 599
 
593 600
 
601
+	/**
602
+	 * @param integer $case
603
+	 */
594 604
 	function array_change_key_case($array, $case=CASE_LOWER) {
595 605
         $output = array();
596 606
         switch($case){
Please login to merge, or discard this patch.
Indentation   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
         #
99 99
         if (!function_exists('xml_parser_create')) {
100 100
             $this->error( "Failed to load PHP's XML Extension. " .
101
-                          "http://www.php.net/manual/en/ref.xml.php",
102
-                           E_USER_ERROR );
101
+                            "http://www.php.net/manual/en/ref.xml.php",
102
+                            E_USER_ERROR );
103 103
         }
104 104
 
105 105
         list($parser, $source) = $this->create_parser($source,
@@ -108,8 +108,8 @@  discard block
 block discarded – undo
108 108
 
109 109
         if (!is_resource($parser)) {
110 110
             $this->error( "Failed to create an instance of PHP's XML parser. " .
111
-                          "http://www.php.net/manual/en/ref.xml.php",
112
-                          E_USER_ERROR );
111
+                            "http://www.php.net/manual/en/ref.xml.php",
112
+                            E_USER_ERROR );
113 113
         }
114 114
 
115 115
 
@@ -445,9 +445,9 @@  discard block
 block discarded – undo
445 445
     }
446 446
 
447 447
     /**
448
-    * return XML parser, and possibly re-encoded source
449
-    *
450
-    */
448
+     * return XML parser, and possibly re-encoded source
449
+     *
450
+     */
451 451
     function create_parser($source, $out_enc, $in_enc, $detect) {
452 452
         if ( substr(phpversion(),0,1) == 5) {
453 453
             $parser = $this->php5_create_parser($in_enc, $detect);
@@ -464,14 +464,14 @@  discard block
 block discarded – undo
464 464
     }
465 465
 
466 466
     /**
467
-    * Instantiate an XML parser under PHP5
468
-    *
469
-    * PHP5 will do a fine job of detecting input encoding
470
-    * if passed an empty string as the encoding.
471
-    *
472
-    * All hail libxml2!
473
-    *
474
-    */
467
+     * Instantiate an XML parser under PHP5
468
+     *
469
+     * PHP5 will do a fine job of detecting input encoding
470
+     * if passed an empty string as the encoding.
471
+     *
472
+     * All hail libxml2!
473
+     *
474
+     */
475 475
     function php5_create_parser($in_enc, $detect) {
476 476
         // by default php5 does a fine job of detecting input encodings
477 477
         if(!$detect && $in_enc) {
@@ -483,20 +483,20 @@  discard block
 block discarded – undo
483 483
     }
484 484
 
485 485
     /**
486
-    * Instaniate an XML parser under PHP4
487
-    *
488
-    * Unfortunately PHP4's support for character encodings
489
-    * and especially XML and character encodings sucks.  As
490
-    * long as the documents you parse only contain characters
491
-    * from the ISO-8859-1 character set (a superset of ASCII,
492
-    * and a subset of UTF-8) you're fine.  However once you
493
-    * step out of that comfy little world things get mad, bad,
494
-    * and dangerous to know.
495
-    *
496
-    * The following code is based on SJM's work with FoF
497
-    * @see http://minutillo.com/steve/weblog/2004/6/17/php-xml-and-character-encodings-a-tale-of-sadness-rage-and-data-loss
498
-    *
499
-    */
486
+     * Instaniate an XML parser under PHP4
487
+     *
488
+     * Unfortunately PHP4's support for character encodings
489
+     * and especially XML and character encodings sucks.  As
490
+     * long as the documents you parse only contain characters
491
+     * from the ISO-8859-1 character set (a superset of ASCII,
492
+     * and a subset of UTF-8) you're fine.  However once you
493
+     * step out of that comfy little world things get mad, bad,
494
+     * and dangerous to know.
495
+     *
496
+     * The following code is based on SJM's work with FoF
497
+     * @see http://minutillo.com/steve/weblog/2004/6/17/php-xml-and-character-encodings-a-tale-of-sadness-rage-and-data-loss
498
+     *
499
+     */
500 500
     function php4_create_parser($source, $in_enc, $detect) {
501 501
         if ( !$detect ) {
502 502
             return array(xml_parser_create($in_enc), $source);
@@ -540,8 +540,8 @@  discard block
 block discarded – undo
540 540
 
541 541
         // else
542 542
         $this->error("Feed is in an unsupported character encoding. ($in_enc) " .
543
-                     "You may see strange artifacts, and mangled characters.",
544
-                     E_USER_NOTICE);
543
+                        "You may see strange artifacts, and mangled characters.",
544
+                        E_USER_NOTICE);
545 545
 
546 546
         return array(xml_parser_create(), $source);
547 547
     }
@@ -587,26 +587,26 @@  discard block
 block discarded – undo
587 587
 // courtesy, Ryan Currie, [email protected]
588 588
 
589 589
 if (!function_exists('array_change_key_case')) {
590
-	define('CASE_UPPER', 1);
591
-	define('CASE_LOWER', 0);
590
+    define('CASE_UPPER', 1);
591
+    define('CASE_LOWER', 0);
592 592
 
593 593
 
594
-	function array_change_key_case($array, $case=CASE_LOWER) {
594
+    function array_change_key_case($array, $case=CASE_LOWER) {
595 595
         $output = array();
596 596
         switch($case){
597
-           case CASE_LOWER:
597
+            case CASE_LOWER:
598 598
                $cmd='strtolower';
599
-               break;
600
-           case CASE_UPPER:
599
+                break;
600
+            case CASE_UPPER:
601 601
                $cmd='strtoupper';
602
-               break;
603
-           default:
602
+                break;
603
+            default:
604 604
                $cmd = '';
605 605
         }
606 606
         foreach($array as $key=>$value) {
607 607
             $output[empty($cmd) ? $key : $cmd($key)] = $value;
608 608
         }
609 609
         return $output;
610
-	}
610
+    }
611 611
 
612 612
 }
Please login to merge, or discard this patch.
Spacing   +118 added lines, -118 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 define('RSS', 'RSS');
24 24
 define('ATOM', 'Atom');
25 25
 
26
-require_once (MAGPIE_DIR . 'rss_utils.inc');
26
+require_once (MAGPIE_DIR.'rss_utils.inc');
27 27
 
28 28
 /**
29 29
 * Hybrid parser, and object, takes RSS as a string and returns a simple object.
@@ -31,19 +31,19 @@  discard block
 block discarded – undo
31 31
 * see: rss_fetch.inc for a simpler interface with integrated caching support
32 32
 *
33 33
 */
34
-class MagpieRSS {
34
+class MagpieRSS{
35 35
     var $parser;
36 36
 
37
-    var $current_item   = array();  // item currently being parsed
38
-    var $items          = array();  // collection of parsed items
39
-    var $channel        = array();  // hash of channel fields
37
+    var $current_item   = array(); // item currently being parsed
38
+    var $items          = array(); // collection of parsed items
39
+    var $channel        = array(); // hash of channel fields
40 40
     var $textinput      = array();
41 41
     var $image          = array();
42 42
     var $feed_type;
43 43
     var $feed_version;
44
-    var $encoding       = '';       // output encoding of parsed rss
44
+    var $encoding       = ''; // output encoding of parsed rss
45 45
 
46
-    var $_source_encoding = '';     // only set if we have to parse xml prolog
46
+    var $_source_encoding = ''; // only set if we have to parse xml prolog
47 47
 
48 48
     var $ERROR = "";
49 49
     var $WARNING = "";
@@ -91,15 +91,15 @@  discard block
 block discarded – undo
91 91
      *                                  source encoding. (caveat emptor)
92 92
      *
93 93
      */
94
-    function __construct($source, $output_encoding='ISO-8859-1',
95
-                        $input_encoding=null, $detect_encoding=true)
94
+    function __construct($source, $output_encoding = 'ISO-8859-1',
95
+                        $input_encoding = null, $detect_encoding = true)
96 96
     {
97 97
         # if PHP xml isn't compiled in, die
98 98
         #
99 99
         if (!function_exists('xml_parser_create')) {
100
-            $this->error( "Failed to load PHP's XML Extension. " .
100
+            $this->error("Failed to load PHP's XML Extension. ".
101 101
                           "http://www.php.net/manual/en/ref.xml.php",
102
-                           E_USER_ERROR );
102
+                           E_USER_ERROR);
103 103
         }
104 104
 
105 105
         list($parser, $source) = $this->create_parser($source,
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
107 107
 
108 108
 
109 109
         if (!is_resource($parser)) {
110
-            $this->error( "Failed to create an instance of PHP's XML parser. " .
110
+            $this->error("Failed to create an instance of PHP's XML parser. ".
111 111
                           "http://www.php.net/manual/en/ref.xml.php",
112
-                          E_USER_ERROR );
112
+                          E_USER_ERROR);
113 113
         }
114 114
 
115 115
 
@@ -118,57 +118,57 @@  discard block
 block discarded – undo
118 118
         # pass in parser, and a reference to this object
119 119
         # setup handlers
120 120
         #
121
-        xml_set_object( $this->parser, $this );
121
+        xml_set_object($this->parser, $this);
122 122
         xml_set_element_handler($this->parser,
123
-                'feed_start_element', 'feed_end_element' );
123
+                'feed_start_element', 'feed_end_element');
124 124
 
125
-        xml_set_character_data_handler( $this->parser, 'feed_cdata' );
125
+        xml_set_character_data_handler($this->parser, 'feed_cdata');
126 126
 
127
-        $status = xml_parse( $this->parser, $source );
127
+        $status = xml_parse($this->parser, $source);
128 128
 
129
-        if (! $status ) {
130
-            $errorcode = xml_get_error_code( $this->parser );
131
-            if ( $errorcode != XML_ERROR_NONE ) {
132
-                $xml_error = xml_error_string( $errorcode );
129
+        if (!$status) {
130
+            $errorcode = xml_get_error_code($this->parser);
131
+            if ($errorcode != XML_ERROR_NONE) {
132
+                $xml_error = xml_error_string($errorcode);
133 133
                 $error_line = xml_get_current_line_number($this->parser);
134 134
                 $error_col = xml_get_current_column_number($this->parser);
135 135
                 $errormsg = "$xml_error at line $error_line, column $error_col";
136 136
 
137
-                $this->error( $errormsg );
137
+                $this->error($errormsg);
138 138
             }
139 139
         }
140 140
 
141
-        xml_parser_free( $this->parser );
141
+        xml_parser_free($this->parser);
142 142
 
143 143
         $this->normalize();
144 144
     }
145 145
 
146
-    function feed_start_element($p, $element, &$attrs) {
146
+    function feed_start_element($p, $element, &$attrs){
147 147
         $el = $element = strtolower($element);
148 148
         $attrs = array_change_key_case($attrs, CASE_LOWER);
149 149
 
150 150
         // check for a namespace, and split if found
151 151
         $ns = false;
152
-        if ( strpos( $element, ':' ) ) {
153
-            list($ns, $el) = explode( ':', $element, 2);
152
+        if (strpos($element, ':')) {
153
+            list($ns, $el) = explode(':', $element, 2);
154 154
         }
155
-        if ( $ns and $ns != 'rdf' ) {
155
+        if ($ns and $ns != 'rdf') {
156 156
             $this->current_namespace = $ns;
157 157
         }
158 158
 
159 159
         # if feed type isn't set, then this is first element of feed
160 160
         # identify feed from root element
161 161
         #
162
-        if (!isset($this->feed_type) ) {
163
-            if ( $el == 'rdf' ) {
162
+        if (!isset($this->feed_type)) {
163
+            if ($el == 'rdf') {
164 164
                 $this->feed_type = RSS;
165 165
                 $this->feed_version = '1.0';
166 166
             }
167
-            elseif ( $el == 'rss' ) {
167
+            elseif ($el == 'rss') {
168 168
                 $this->feed_type = RSS;
169 169
                 $this->feed_version = $attrs['version'];
170 170
             }
171
-            elseif ( $el == 'feed' ) {
171
+            elseif ($el == 'feed') {
172 172
                 $this->feed_type = ATOM;
173 173
                 $this->feed_version = $attrs['version'];
174 174
                 $this->inchannel = true;
@@ -176,14 +176,14 @@  discard block
 block discarded – undo
176 176
             return;
177 177
         }
178 178
 
179
-        if ( $el == 'channel' )
179
+        if ($el == 'channel')
180 180
         {
181 181
             $this->inchannel = true;
182 182
         }
183
-        elseif ($el == 'item' or $el == 'entry' )
183
+        elseif ($el == 'item' or $el == 'entry')
184 184
         {
185 185
             $this->initem = true;
186
-            if ( isset($attrs['rdf:about']) ) {
186
+            if (isset($attrs['rdf:about'])) {
187 187
                 $this->current_item['about'] = $attrs['rdf:about'];
188 188
             }
189 189
         }
@@ -207,10 +207,10 @@  discard block
 block discarded – undo
207 207
         }
208 208
 
209 209
         # handle atom content constructs
210
-        elseif ( $this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) )
210
+        elseif ($this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS))
211 211
         {
212 212
             // avoid clashing w/ RSS mod_content
213
-            if ($el == 'content' ) {
213
+            if ($el == 'content') {
214 214
                 $el = 'atom_content';
215 215
             }
216 216
 
@@ -220,31 +220,31 @@  discard block
 block discarded – undo
220 220
         }
221 221
 
222 222
         // if inside an Atom content construct (e.g. content or summary) field treat tags as text
223
-        elseif ($this->feed_type == ATOM and $this->incontent )
223
+        elseif ($this->feed_type == ATOM and $this->incontent)
224 224
         {
225 225
             // if tags are inlined, then flatten
226 226
             $attrs_str = join(' ',
227 227
                     array_map('map_attrs',
228 228
                     array_keys($attrs),
229
-                    array_values($attrs) ) );
229
+                    array_values($attrs)));
230 230
 
231
-            $this->append_content( "<$element $attrs_str>"  );
231
+            $this->append_content("<$element $attrs_str>");
232 232
 
233
-            array_unshift( $this->stack, $el );
233
+            array_unshift($this->stack, $el);
234 234
         }
235 235
 
236 236
         // Atom support many links per containging element.
237 237
         // Magpie treats link elements of type rel='alternate'
238 238
         // as being equivalent to RSS's simple link element.
239 239
         //
240
-        elseif ($this->feed_type == ATOM and $el == 'link' )
240
+        elseif ($this->feed_type == ATOM and $el == 'link')
241 241
         {
242
-            if ( isset($attrs['rel']) and $attrs['rel'] == 'alternate' )
242
+            if (isset($attrs['rel']) and $attrs['rel'] == 'alternate')
243 243
             {
244 244
                 $link_el = 'link';
245 245
             }
246 246
             else {
247
-                $link_el = 'link_' . $attrs['rel'];
247
+                $link_el = 'link_'.$attrs['rel'];
248 248
             }
249 249
 
250 250
             $this->append($link_el, $attrs['href']);
@@ -257,10 +257,10 @@  discard block
 block discarded – undo
257 257
 
258 258
 
259 259
 
260
-    function feed_cdata ($p, $text) {
260
+    function feed_cdata($p, $text){
261 261
         if ($this->feed_type == ATOM and $this->incontent)
262 262
         {
263
-            $this->append_content( $text );
263
+            $this->append_content($text);
264 264
         }
265 265
         else {
266 266
             $current_el = join('_', array_reverse($this->stack));
@@ -268,35 +268,35 @@  discard block
 block discarded – undo
268 268
         }
269 269
     }
270 270
 
271
-    function feed_end_element ($p, $el) {
271
+    function feed_end_element($p, $el){
272 272
         $el = strtolower($el);
273 273
 
274
-        if ( $el == 'item' or $el == 'entry' )
274
+        if ($el == 'item' or $el == 'entry')
275 275
         {
276 276
             $this->items[] = $this->current_item;
277 277
             $this->current_item = array();
278 278
             $this->initem = false;
279 279
         }
280
-        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'textinput' )
280
+        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'textinput')
281 281
         {
282 282
             $this->intextinput = false;
283 283
         }
284
-        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'image' )
284
+        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'image')
285 285
         {
286 286
             $this->inimage = false;
287 287
         }
288
-        elseif ($this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) )
288
+        elseif ($this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS))
289 289
         {
290 290
             $this->incontent = false;
291 291
         }
292
-        elseif ($el == 'channel' or $el == 'feed' )
292
+        elseif ($el == 'channel' or $el == 'feed')
293 293
         {
294 294
             $this->inchannel = false;
295 295
         }
296
-        elseif ($this->feed_type == ATOM and $this->incontent  ) {
296
+        elseif ($this->feed_type == ATOM and $this->incontent) {
297 297
             // balance tags properly
298 298
             // note:  i don't think this is actually neccessary
299
-            if ( $this->stack[0] == $el )
299
+            if ($this->stack[0] == $el)
300 300
             {
301 301
                 $this->append_content("</$el>");
302 302
             }
@@ -304,91 +304,91 @@  discard block
 block discarded – undo
304 304
                 $this->append_content("<$el />");
305 305
             }
306 306
 
307
-            array_shift( $this->stack );
307
+            array_shift($this->stack);
308 308
         }
309 309
         else {
310
-            array_shift( $this->stack );
310
+            array_shift($this->stack);
311 311
         }
312 312
 
313 313
         $this->current_namespace = false;
314 314
     }
315 315
 
316
-    function concat (&$str1, $str2="") {
317
-        if (!isset($str1) ) {
318
-            $str1="";
316
+    function concat(&$str1, $str2 = ""){
317
+        if (!isset($str1)) {
318
+            $str1 = "";
319 319
         }
320 320
         $str1 .= $str2;
321 321
     }
322 322
 
323 323
 
324 324
 
325
-    function append_content($text) {
326
-        if ( $this->initem ) {
327
-            $this->concat( $this->current_item[ $this->incontent ], $text );
325
+    function append_content($text){
326
+        if ($this->initem) {
327
+            $this->concat($this->current_item[$this->incontent], $text);
328 328
         }
329
-        elseif ( $this->inchannel ) {
330
-            $this->concat( $this->channel[ $this->incontent ], $text );
329
+        elseif ($this->inchannel) {
330
+            $this->concat($this->channel[$this->incontent], $text);
331 331
         }
332 332
     }
333 333
 
334 334
     // smart append - field and namespace aware
335
-    function append($el, $text) {
335
+    function append($el, $text){
336 336
         if (!$el) {
337 337
             return;
338 338
         }
339
-        if ( $this->current_namespace )
339
+        if ($this->current_namespace)
340 340
         {
341
-            if ( $this->initem ) {
341
+            if ($this->initem) {
342 342
                 $this->concat(
343
-                    $this->current_item[ $this->current_namespace ][ $el ], $text);
343
+                    $this->current_item[$this->current_namespace][$el], $text);
344 344
             }
345 345
             elseif ($this->inchannel) {
346 346
                 $this->concat(
347
-                    $this->channel[ $this->current_namespace][ $el ], $text );
347
+                    $this->channel[$this->current_namespace][$el], $text );
348 348
             }
349 349
             elseif ($this->intextinput) {
350 350
                 $this->concat(
351
-                    $this->textinput[ $this->current_namespace][ $el ], $text );
351
+                    $this->textinput[$this->current_namespace][$el], $text );
352 352
             }
353 353
             elseif ($this->inimage) {
354 354
                 $this->concat(
355
-                    $this->image[ $this->current_namespace ][ $el ], $text );
355
+                    $this->image[$this->current_namespace][$el], $text );
356 356
             }
357 357
         }
358 358
         else {
359
-            if ( $this->initem ) {
359
+            if ($this->initem) {
360 360
                 $this->concat(
361
-                    $this->current_item[ $el ], $text);
361
+                    $this->current_item[$el], $text);
362 362
             }
363 363
             elseif ($this->intextinput) {
364 364
                 $this->concat(
365
-                    $this->textinput[ $el ], $text );
365
+                    $this->textinput[$el], $text );
366 366
             }
367 367
             elseif ($this->inimage) {
368 368
                 $this->concat(
369
-                    $this->image[ $el ], $text );
369
+                    $this->image[$el], $text );
370 370
             }
371 371
             elseif ($this->inchannel) {
372 372
                 $this->concat(
373
-                    $this->channel[ $el ], $text );
373
+                    $this->channel[$el], $text );
374 374
             }
375 375
 
376 376
         }
377 377
     }
378 378
 
379
-    function normalize () {
379
+    function normalize(){
380 380
         // if atom populate rss fields
381
-        if ( $this->is_atom() ) {
381
+        if ($this->is_atom()) {
382 382
             $this->channel['description'] = $this->channel['tagline'];
383
-            for ( $i = 0; $i < count($this->items); $i++) {
383
+            for ($i = 0; $i < count($this->items); $i++) {
384 384
                 $item = $this->items[$i];
385
-                if ( isset($item['summary']) )
385
+                if (isset($item['summary']))
386 386
                     $item['description'] = $item['summary'];
387
-                if ( isset($item['atom_content']))
387
+                if (isset($item['atom_content']))
388 388
                     $item['content']['encoded'] = $item['atom_content'];
389 389
 
390
-                $atom_date = (isset($item['issued']) ) ? $item['issued'] : $item['modified'];
391
-                if ( $atom_date ) {
390
+                $atom_date = (isset($item['issued'])) ? $item['issued'] : $item['modified'];
391
+                if ($atom_date) {
392 392
                     $epoch = @parse_w3cdtf($atom_date);
393 393
                     if ($epoch and $epoch > 0) {
394 394
                         $item['date_timestamp'] = $epoch;
@@ -398,22 +398,22 @@  discard block
 block discarded – undo
398 398
                 $this->items[$i] = $item;
399 399
             }
400 400
         }
401
-        elseif ( $this->is_rss() ) {
401
+        elseif ($this->is_rss()) {
402 402
             $this->channel['tagline'] = $this->channel['description'];
403
-            for ( $i = 0; $i < count($this->items); $i++) {
403
+            for ($i = 0; $i < count($this->items); $i++) {
404 404
                 $item = $this->items[$i];
405
-                if ( isset($item['description']))
405
+                if (isset($item['description']))
406 406
                     $item['summary'] = $item['description'];
407
-                if ( isset($item['content']['encoded'] ) )
407
+                if (isset($item['content']['encoded']))
408 408
                     $item['atom_content'] = $item['content']['encoded'];
409 409
 
410
-                if ( $this->is_rss() == '1.0' and isset($item['dc']['date']) ) {
410
+                if ($this->is_rss() == '1.0' and isset($item['dc']['date'])) {
411 411
                     $epoch = @parse_w3cdtf($item['dc']['date']);
412 412
                     if ($epoch and $epoch > 0) {
413 413
                         $item['date_timestamp'] = $epoch;
414 414
                     }
415 415
                 }
416
-                elseif ( isset($item['pubdate']) ) {
416
+                elseif (isset($item['pubdate'])) {
417 417
                     $epoch = @strtotime($item['pubdate']);
418 418
                     if ($epoch > 0) {
419 419
                         $item['date_timestamp'] = $epoch;
@@ -426,8 +426,8 @@  discard block
 block discarded – undo
426 426
     }
427 427
 
428 428
 
429
-    function is_rss () {
430
-        if ( $this->feed_type == RSS ) {
429
+    function is_rss(){
430
+        if ($this->feed_type == RSS) {
431 431
             return $this->feed_version;
432 432
         }
433 433
         else {
@@ -435,8 +435,8 @@  discard block
 block discarded – undo
435 435
         }
436 436
     }
437 437
 
438
-    function is_atom() {
439
-        if ( $this->feed_type == ATOM ) {
438
+    function is_atom(){
439
+        if ($this->feed_type == ATOM) {
440 440
             return $this->feed_version;
441 441
         }
442 442
         else {
@@ -448,8 +448,8 @@  discard block
 block discarded – undo
448 448
     * return XML parser, and possibly re-encoded source
449 449
     *
450 450
     */
451
-    function create_parser($source, $out_enc, $in_enc, $detect) {
452
-        if ( substr(phpversion(),0,1) == 5) {
451
+    function create_parser($source, $out_enc, $in_enc, $detect){
452
+        if (substr(phpversion(), 0, 1) == 5) {
453 453
             $parser = $this->php5_create_parser($in_enc, $detect);
454 454
         }
455 455
         else {
@@ -472,9 +472,9 @@  discard block
 block discarded – undo
472 472
     * All hail libxml2!
473 473
     *
474 474
     */
475
-    function php5_create_parser($in_enc, $detect) {
475
+    function php5_create_parser($in_enc, $detect){
476 476
         // by default php5 does a fine job of detecting input encodings
477
-        if(!$detect && $in_enc) {
477
+        if (!$detect && $in_enc) {
478 478
             return xml_parser_create($in_enc);
479 479
         }
480 480
         else {
@@ -497,8 +497,8 @@  discard block
 block discarded – undo
497 497
     * @see http://minutillo.com/steve/weblog/2004/6/17/php-xml-and-character-encodings-a-tale-of-sadness-rage-and-data-loss
498 498
     *
499 499
     */
500
-    function php4_create_parser($source, $in_enc, $detect) {
501
-        if ( !$detect ) {
500
+    function php4_create_parser($source, $in_enc, $detect){
501
+        if (!$detect) {
502 502
             return array(xml_parser_create($in_enc), $source);
503 503
         }
504 504
 
@@ -522,8 +522,8 @@  discard block
 block discarded – undo
522 522
         // cast the XML to a known encoding
523 523
         // @see http://php.net/iconv
524 524
 
525
-        if (function_exists('iconv'))  {
526
-            $encoded_source = iconv($in_enc,'UTF-8', $source);
525
+        if (function_exists('iconv')) {
526
+            $encoded_source = iconv($in_enc, 'UTF-8', $source);
527 527
             if ($encoded_source) {
528 528
                 return array(xml_parser_create('UTF-8'), $encoded_source);
529 529
             }
@@ -531,24 +531,24 @@  discard block
 block discarded – undo
531 531
 
532 532
         // iconv didn't work, try mb_convert_encoding
533 533
         // @see http://php.net/mbstring
534
-        if(function_exists('mb_convert_encoding')) {
535
-            $encoded_source = mb_convert_encoding($source, 'UTF-8', $in_enc );
534
+        if (function_exists('mb_convert_encoding')) {
535
+            $encoded_source = mb_convert_encoding($source, 'UTF-8', $in_enc);
536 536
             if ($encoded_source) {
537 537
                 return array(xml_parser_create('UTF-8'), $encoded_source);
538 538
             }
539 539
         }
540 540
 
541 541
         // else
542
-        $this->error("Feed is in an unsupported character encoding. ($in_enc) " .
542
+        $this->error("Feed is in an unsupported character encoding. ($in_enc) ".
543 543
                      "You may see strange artifacts, and mangled characters.",
544 544
                      E_USER_NOTICE);
545 545
 
546 546
         return array(xml_parser_create(), $source);
547 547
     }
548 548
 
549
-    function known_encoding($enc) {
549
+    function known_encoding($enc){
550 550
         $enc = strtoupper($enc);
551
-        if ( in_array($enc, $this->_KNOWN_ENCODINGS) ) {
551
+        if (in_array($enc, $this->_KNOWN_ENCODINGS)) {
552 552
             return $enc;
553 553
         }
554 554
         else {
@@ -556,20 +556,20 @@  discard block
 block discarded – undo
556 556
         }
557 557
     }
558 558
 
559
-    function error ($errormsg, $lvl=E_USER_WARNING) {
559
+    function error($errormsg, $lvl = E_USER_WARNING){
560 560
         // append PHP's error message if track_errors enabled
561
-        if ( isset($php_errormsg) ) {
561
+        if (isset($php_errormsg)) {
562 562
             $errormsg .= " ($php_errormsg)";
563 563
         }
564
-        if ( MAGPIE_DEBUG ) {
565
-            trigger_error( $errormsg, $lvl);
564
+        if (MAGPIE_DEBUG) {
565
+            trigger_error($errormsg, $lvl);
566 566
         }
567 567
         else {
568
-            error_log( $errormsg, 0);
568
+            error_log($errormsg, 0);
569 569
         }
570 570
 
571
-        $notices = E_USER_NOTICE|E_NOTICE;
572
-        if ( $lvl&$notices ) {
571
+        $notices = E_USER_NOTICE | E_NOTICE;
572
+        if ($lvl & $notices) {
573 573
             $this->WARNING = $errormsg;
574 574
         } else {
575 575
             $this->ERROR = $errormsg;
@@ -579,7 +579,7 @@  discard block
 block discarded – undo
579 579
 
580 580
 } // end class RSS
581 581
 
582
-function map_attrs($k, $v) {
582
+function map_attrs($k, $v){
583 583
     return "$k=\"$v\"";
584 584
 }
585 585
 
@@ -591,19 +591,19 @@  discard block
 block discarded – undo
591 591
 	define('CASE_LOWER', 0);
592 592
 
593 593
 
594
-	function array_change_key_case($array, $case=CASE_LOWER) {
594
+	function array_change_key_case($array, $case = CASE_LOWER){
595 595
         $output = array();
596
-        switch($case){
596
+        switch ($case) {
597 597
            case CASE_LOWER:
598
-               $cmd='strtolower';
598
+               $cmd = 'strtolower';
599 599
                break;
600 600
            case CASE_UPPER:
601
-               $cmd='strtoupper';
601
+               $cmd = 'strtoupper';
602 602
                break;
603 603
            default:
604 604
                $cmd = '';
605 605
         }
606
-        foreach($array as $key=>$value) {
606
+        foreach ($array as $key=>$value) {
607 607
             $output[empty($cmd) ? $key : $cmd($key)] = $value;
608 608
         }
609 609
         return $output;
Please login to merge, or discard this patch.
Braces   +89 added lines, -115 removed lines patch added patch discarded remove patch
@@ -31,7 +31,8 @@  discard block
 block discarded – undo
31 31
 * see: rss_fetch.inc for a simpler interface with integrated caching support
32 32
 *
33 33
 */
34
-class MagpieRSS {
34
+class MagpieRSS
35
+{
35 36
     var $parser;
36 37
 
37 38
     var $current_item   = array();  // item currently being parsed
@@ -143,7 +144,8 @@  discard block
 block discarded – undo
143 144
         $this->normalize();
144 145
     }
145 146
 
146
-    function feed_start_element($p, $element, &$attrs) {
147
+    function feed_start_element($p, $element, &$attrs)
148
+    {
147 149
         $el = $element = strtolower($element);
148 150
         $attrs = array_change_key_case($attrs, CASE_LOWER);
149 151
 
@@ -163,12 +165,10 @@  discard block
 block discarded – undo
163 165
             if ( $el == 'rdf' ) {
164 166
                 $this->feed_type = RSS;
165 167
                 $this->feed_version = '1.0';
166
-            }
167
-            elseif ( $el == 'rss' ) {
168
+            } elseif ( $el == 'rss' ) {
168 169
                 $this->feed_type = RSS;
169 170
                 $this->feed_version = $attrs['version'];
170
-            }
171
-            elseif ( $el == 'feed' ) {
171
+            } elseif ( $el == 'feed' ) {
172 172
                 $this->feed_type = ATOM;
173 173
                 $this->feed_version = $attrs['version'];
174 174
                 $this->inchannel = true;
@@ -176,12 +176,9 @@  discard block
 block discarded – undo
176 176
             return;
177 177
         }
178 178
 
179
-        if ( $el == 'channel' )
180
-        {
179
+        if ( $el == 'channel' ) {
181 180
             $this->inchannel = true;
182
-        }
183
-        elseif ($el == 'item' or $el == 'entry' )
184
-        {
181
+        } elseif ($el == 'item' or $el == 'entry' ) {
185 182
             $this->initem = true;
186 183
             if ( isset($attrs['rdf:about']) ) {
187 184
                 $this->current_item['about'] = $attrs['rdf:about'];
@@ -193,22 +190,17 @@  discard block
 block discarded – undo
193 190
         elseif (
194 191
             $this->feed_type == RSS and
195 192
             $this->current_namespace == '' and
196
-            $el == 'textinput' )
197
-        {
193
+            $el == 'textinput' ) {
198 194
             $this->intextinput = true;
199
-        }
200
-
201
-        elseif (
195
+        } elseif (
202 196
             $this->feed_type == RSS and
203 197
             $this->current_namespace == '' and
204
-            $el == 'image' )
205
-        {
198
+            $el == 'image' ) {
206 199
             $this->inimage = true;
207 200
         }
208 201
 
209 202
         # handle atom content constructs
210
-        elseif ( $this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) )
211
-        {
203
+        elseif ( $this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) ) {
212 204
             // avoid clashing w/ RSS mod_content
213 205
             if ($el == 'content' ) {
214 206
                 $el = 'atom_content';
@@ -220,8 +212,7 @@  discard block
 block discarded – undo
220 212
         }
221 213
 
222 214
         // if inside an Atom content construct (e.g. content or summary) field treat tags as text
223
-        elseif ($this->feed_type == ATOM and $this->incontent )
224
-        {
215
+        elseif ($this->feed_type == ATOM and $this->incontent ) {
225 216
             // if tags are inlined, then flatten
226 217
             $attrs_str = join(' ',
227 218
                     array_map('map_attrs',
@@ -237,13 +228,10 @@  discard block
 block discarded – undo
237 228
         // Magpie treats link elements of type rel='alternate'
238 229
         // as being equivalent to RSS's simple link element.
239 230
         //
240
-        elseif ($this->feed_type == ATOM and $el == 'link' )
241
-        {
242
-            if ( isset($attrs['rel']) and $attrs['rel'] == 'alternate' )
243
-            {
231
+        elseif ($this->feed_type == ATOM and $el == 'link' ) {
232
+            if ( isset($attrs['rel']) and $attrs['rel'] == 'alternate' ) {
244 233
                 $link_el = 'link';
245
-            }
246
-            else {
234
+            } else {
247 235
                 $link_el = 'link_' . $attrs['rel'];
248 236
             }
249 237
 
@@ -257,63 +245,51 @@  discard block
 block discarded – undo
257 245
 
258 246
 
259 247
 
260
-    function feed_cdata ($p, $text) {
261
-        if ($this->feed_type == ATOM and $this->incontent)
262
-        {
248
+    function feed_cdata ($p, $text)
249
+    {
250
+        if ($this->feed_type == ATOM and $this->incontent) {
263 251
             $this->append_content( $text );
264
-        }
265
-        else {
252
+        } else {
266 253
             $current_el = join('_', array_reverse($this->stack));
267 254
             $this->append($current_el, $text);
268 255
         }
269 256
     }
270 257
 
271
-    function feed_end_element ($p, $el) {
258
+    function feed_end_element ($p, $el)
259
+    {
272 260
         $el = strtolower($el);
273 261
 
274
-        if ( $el == 'item' or $el == 'entry' )
275
-        {
262
+        if ( $el == 'item' or $el == 'entry' ) {
276 263
             $this->items[] = $this->current_item;
277 264
             $this->current_item = array();
278 265
             $this->initem = false;
279
-        }
280
-        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'textinput' )
281
-        {
266
+        } elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'textinput' ) {
282 267
             $this->intextinput = false;
283
-        }
284
-        elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'image' )
285
-        {
268
+        } elseif ($this->feed_type == RSS and $this->current_namespace == '' and $el == 'image' ) {
286 269
             $this->inimage = false;
287
-        }
288
-        elseif ($this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) )
289
-        {
270
+        } elseif ($this->feed_type == ATOM and in_array($el, $this->_CONTENT_CONSTRUCTS) ) {
290 271
             $this->incontent = false;
291
-        }
292
-        elseif ($el == 'channel' or $el == 'feed' )
293
-        {
272
+        } elseif ($el == 'channel' or $el == 'feed' ) {
294 273
             $this->inchannel = false;
295
-        }
296
-        elseif ($this->feed_type == ATOM and $this->incontent  ) {
274
+        } elseif ($this->feed_type == ATOM and $this->incontent  ) {
297 275
             // balance tags properly
298 276
             // note:  i don't think this is actually neccessary
299
-            if ( $this->stack[0] == $el )
300
-            {
277
+            if ( $this->stack[0] == $el ) {
301 278
                 $this->append_content("</$el>");
302
-            }
303
-            else {
279
+            } else {
304 280
                 $this->append_content("<$el />");
305 281
             }
306 282
 
307 283
             array_shift( $this->stack );
308
-        }
309
-        else {
284
+        } else {
310 285
             array_shift( $this->stack );
311 286
         }
312 287
 
313 288
         $this->current_namespace = false;
314 289
     }
315 290
 
316
-    function concat (&$str1, $str2="") {
291
+    function concat (&$str1, $str2="")
292
+    {
317 293
         if (!isset($str1) ) {
318 294
             $str1="";
319 295
         }
@@ -322,53 +298,46 @@  discard block
 block discarded – undo
322 298
 
323 299
 
324 300
 
325
-    function append_content($text) {
301
+    function append_content($text)
302
+    {
326 303
         if ( $this->initem ) {
327 304
             $this->concat( $this->current_item[ $this->incontent ], $text );
328
-        }
329
-        elseif ( $this->inchannel ) {
305
+        } elseif ( $this->inchannel ) {
330 306
             $this->concat( $this->channel[ $this->incontent ], $text );
331 307
         }
332 308
     }
333 309
 
334 310
     // smart append - field and namespace aware
335
-    function append($el, $text) {
311
+    function append($el, $text)
312
+    {
336 313
         if (!$el) {
337 314
             return;
338 315
         }
339
-        if ( $this->current_namespace )
340
-        {
316
+        if ( $this->current_namespace ) {
341 317
             if ( $this->initem ) {
342 318
                 $this->concat(
343 319
                     $this->current_item[ $this->current_namespace ][ $el ], $text);
344
-            }
345
-            elseif ($this->inchannel) {
320
+            } elseif ($this->inchannel) {
346 321
                 $this->concat(
347 322
                     $this->channel[ $this->current_namespace][ $el ], $text );
348
-            }
349
-            elseif ($this->intextinput) {
323
+            } elseif ($this->intextinput) {
350 324
                 $this->concat(
351 325
                     $this->textinput[ $this->current_namespace][ $el ], $text );
352
-            }
353
-            elseif ($this->inimage) {
326
+            } elseif ($this->inimage) {
354 327
                 $this->concat(
355 328
                     $this->image[ $this->current_namespace ][ $el ], $text );
356 329
             }
357
-        }
358
-        else {
330
+        } else {
359 331
             if ( $this->initem ) {
360 332
                 $this->concat(
361 333
                     $this->current_item[ $el ], $text);
362
-            }
363
-            elseif ($this->intextinput) {
334
+            } elseif ($this->intextinput) {
364 335
                 $this->concat(
365 336
                     $this->textinput[ $el ], $text );
366
-            }
367
-            elseif ($this->inimage) {
337
+            } elseif ($this->inimage) {
368 338
                 $this->concat(
369 339
                     $this->image[ $el ], $text );
370
-            }
371
-            elseif ($this->inchannel) {
340
+            } elseif ($this->inchannel) {
372 341
                 $this->concat(
373 342
                     $this->channel[ $el ], $text );
374 343
             }
@@ -376,16 +345,19 @@  discard block
 block discarded – undo
376 345
         }
377 346
     }
378 347
 
379
-    function normalize () {
348
+    function normalize ()
349
+    {
380 350
         // if atom populate rss fields
381 351
         if ( $this->is_atom() ) {
382 352
             $this->channel['description'] = $this->channel['tagline'];
383 353
             for ( $i = 0; $i < count($this->items); $i++) {
384 354
                 $item = $this->items[$i];
385
-                if ( isset($item['summary']) )
386
-                    $item['description'] = $item['summary'];
387
-                if ( isset($item['atom_content']))
388
-                    $item['content']['encoded'] = $item['atom_content'];
355
+                if ( isset($item['summary']) ) {
356
+                                    $item['description'] = $item['summary'];
357
+                }
358
+                if ( isset($item['atom_content'])) {
359
+                                    $item['content']['encoded'] = $item['atom_content'];
360
+                }
389 361
 
390 362
                 $atom_date = (isset($item['issued']) ) ? $item['issued'] : $item['modified'];
391 363
                 if ( $atom_date ) {
@@ -397,23 +369,23 @@  discard block
 block discarded – undo
397 369
 
398 370
                 $this->items[$i] = $item;
399 371
             }
400
-        }
401
-        elseif ( $this->is_rss() ) {
372
+        } elseif ( $this->is_rss() ) {
402 373
             $this->channel['tagline'] = $this->channel['description'];
403 374
             for ( $i = 0; $i < count($this->items); $i++) {
404 375
                 $item = $this->items[$i];
405
-                if ( isset($item['description']))
406
-                    $item['summary'] = $item['description'];
407
-                if ( isset($item['content']['encoded'] ) )
408
-                    $item['atom_content'] = $item['content']['encoded'];
376
+                if ( isset($item['description'])) {
377
+                                    $item['summary'] = $item['description'];
378
+                }
379
+                if ( isset($item['content']['encoded'] ) ) {
380
+                                    $item['atom_content'] = $item['content']['encoded'];
381
+                }
409 382
 
410 383
                 if ( $this->is_rss() == '1.0' and isset($item['dc']['date']) ) {
411 384
                     $epoch = @parse_w3cdtf($item['dc']['date']);
412 385
                     if ($epoch and $epoch > 0) {
413 386
                         $item['date_timestamp'] = $epoch;
414 387
                     }
415
-                }
416
-                elseif ( isset($item['pubdate']) ) {
388
+                } elseif ( isset($item['pubdate']) ) {
417 389
                     $epoch = @strtotime($item['pubdate']);
418 390
                     if ($epoch > 0) {
419 391
                         $item['date_timestamp'] = $epoch;
@@ -426,20 +398,20 @@  discard block
 block discarded – undo
426 398
     }
427 399
 
428 400
 
429
-    function is_rss () {
401
+    function is_rss ()
402
+    {
430 403
         if ( $this->feed_type == RSS ) {
431 404
             return $this->feed_version;
432
-        }
433
-        else {
405
+        } else {
434 406
             return false;
435 407
         }
436 408
     }
437 409
 
438
-    function is_atom() {
410
+    function is_atom()
411
+    {
439 412
         if ( $this->feed_type == ATOM ) {
440 413
             return $this->feed_version;
441
-        }
442
-        else {
414
+        } else {
443 415
             return false;
444 416
         }
445 417
     }
@@ -448,11 +420,11 @@  discard block
 block discarded – undo
448 420
     * return XML parser, and possibly re-encoded source
449 421
     *
450 422
     */
451
-    function create_parser($source, $out_enc, $in_enc, $detect) {
423
+    function create_parser($source, $out_enc, $in_enc, $detect)
424
+    {
452 425
         if ( substr(phpversion(),0,1) == 5) {
453 426
             $parser = $this->php5_create_parser($in_enc, $detect);
454
-        }
455
-        else {
427
+        } else {
456 428
             list($parser, $source) = $this->php4_create_parser($source, $in_enc, $detect);
457 429
         }
458 430
         if ($out_enc) {
@@ -472,12 +444,12 @@  discard block
 block discarded – undo
472 444
     * All hail libxml2!
473 445
     *
474 446
     */
475
-    function php5_create_parser($in_enc, $detect) {
447
+    function php5_create_parser($in_enc, $detect)
448
+    {
476 449
         // by default php5 does a fine job of detecting input encodings
477 450
         if(!$detect && $in_enc) {
478 451
             return xml_parser_create($in_enc);
479
-        }
480
-        else {
452
+        } else {
481 453
             return xml_parser_create('');
482 454
         }
483 455
     }
@@ -497,7 +469,8 @@  discard block
 block discarded – undo
497 469
     * @see http://minutillo.com/steve/weblog/2004/6/17/php-xml-and-character-encodings-a-tale-of-sadness-rage-and-data-loss
498 470
     *
499 471
     */
500
-    function php4_create_parser($source, $in_enc, $detect) {
472
+    function php4_create_parser($source, $in_enc, $detect)
473
+    {
501 474
         if ( !$detect ) {
502 475
             return array(xml_parser_create($in_enc), $source);
503 476
         }
@@ -506,8 +479,7 @@  discard block
 block discarded – undo
506 479
             if (preg_match('/<?xml.*encoding=[\'"](.*?)[\'"].*?>/m', $source, $m)) {
507 480
                 $in_enc = strtoupper($m[1]);
508 481
                 $this->source_encoding = $in_enc;
509
-            }
510
-            else {
482
+            } else {
511 483
                 $in_enc = 'UTF-8';
512 484
             }
513 485
         }
@@ -522,7 +494,7 @@  discard block
 block discarded – undo
522 494
         // cast the XML to a known encoding
523 495
         // @see http://php.net/iconv
524 496
 
525
-        if (function_exists('iconv'))  {
497
+        if (function_exists('iconv')) {
526 498
             $encoded_source = iconv($in_enc,'UTF-8', $source);
527 499
             if ($encoded_source) {
528 500
                 return array(xml_parser_create('UTF-8'), $encoded_source);
@@ -546,25 +518,25 @@  discard block
 block discarded – undo
546 518
         return array(xml_parser_create(), $source);
547 519
     }
548 520
 
549
-    function known_encoding($enc) {
521
+    function known_encoding($enc)
522
+    {
550 523
         $enc = strtoupper($enc);
551 524
         if ( in_array($enc, $this->_KNOWN_ENCODINGS) ) {
552 525
             return $enc;
553
-        }
554
-        else {
526
+        } else {
555 527
             return false;
556 528
         }
557 529
     }
558 530
 
559
-    function error ($errormsg, $lvl=E_USER_WARNING) {
531
+    function error ($errormsg, $lvl=E_USER_WARNING)
532
+    {
560 533
         // append PHP's error message if track_errors enabled
561 534
         if ( isset($php_errormsg) ) {
562 535
             $errormsg .= " ($php_errormsg)";
563 536
         }
564 537
         if ( MAGPIE_DEBUG ) {
565 538
             trigger_error( $errormsg, $lvl);
566
-        }
567
-        else {
539
+        } else {
568 540
             error_log( $errormsg, 0);
569 541
         }
570 542
 
@@ -579,7 +551,8 @@  discard block
 block discarded – undo
579 551
 
580 552
 } // end class RSS
581 553
 
582
-function map_attrs($k, $v) {
554
+function map_attrs($k, $v)
555
+{
583 556
     return "$k=\"$v\"";
584 557
 }
585 558
 
@@ -591,9 +564,10 @@  discard block
 block discarded – undo
591 564
 	define('CASE_LOWER', 0);
592 565
 
593 566
 
594
-	function array_change_key_case($array, $case=CASE_LOWER) {
567
+	function array_change_key_case($array, $case=CASE_LOWER)
568
+	{
595 569
         $output = array();
596
-        switch($case){
570
+        switch($case) {
597 571
            case CASE_LOWER:
598 572
                $cmd='strtolower';
599 573
                break;
Please login to merge, or discard this patch.
index.php 3 patches
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
 $autoloader = __DIR__.'/vendor/autoload.php';
49 49
 if (file_exists($autoloader) && is_readable($autoloader)) {
50
-	include_once($autoloader);
50
+    include_once($autoloader);
51 51
 }
52 52
 
53 53
 if(!isset($_SERVER['REQUEST_TIME_FLOAT'])) $_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
@@ -56,11 +56,11 @@  discard block
 block discarded – undo
56 56
 if(is_file($base_path . 'assets/cache/siteManager.php'))
57 57
     include_once($base_path . 'assets/cache/siteManager.php');
58 58
 if(!defined('MGR_DIR') && is_dir("{$base_path}manager"))
59
-	define('MGR_DIR', 'manager');
59
+    define('MGR_DIR', 'manager');
60 60
 if(is_file($base_path . 'assets/cache/siteHostnames.php'))
61 61
     include_once($base_path . 'assets/cache/siteHostnames.php');
62 62
 if(!defined('MODX_SITE_HOSTNAMES'))
63
-	define('MODX_SITE_HOSTNAMES', '');
63
+    define('MODX_SITE_HOSTNAMES', '');
64 64
 
65 65
 // get start time
66 66
 $mstart = memory_get_usage();
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 define('IN_PARSER_MODE', true);
86 86
 if ( ! defined('IN_MANAGER_MODE')) {
87
-	define('IN_MANAGER_MODE', false);
87
+    define('IN_MANAGER_MODE', false);
88 88
 }
89 89
 if (!defined('MODX_API_MODE')) {
90 90
     define('MODX_API_MODE', false);
@@ -92,12 +92,12 @@  discard block
 block discarded – undo
92 92
 
93 93
 // get the required includes
94 94
 if(!isset($database_user) || $database_user=="") {
95
-	$rt = @include_once(dirname(__FILE__).'/'.MGR_DIR.'/includes/config.inc.php');
96
-	// Be sure config.inc.php is there and that it contains some important values
97
-	if(!$rt || !$database_type || !$database_server || !$database_user || !$dbase) {
98
-		readfile('install/not_installed.tpl');
99
-		exit;
100
-	}
95
+    $rt = @include_once(dirname(__FILE__).'/'.MGR_DIR.'/includes/config.inc.php');
96
+    // Be sure config.inc.php is there and that it contains some important values
97
+    if(!$rt || !$database_type || !$database_server || !$database_user || !$dbase) {
98
+        readfile('install/not_installed.tpl');
99
+        exit;
100
+    }
101 101
 }
102 102
 
103 103
 // start session
@@ -105,11 +105,11 @@  discard block
 block discarded – undo
105 105
 
106 106
 // initiate a new document parser
107 107
 if (isset($coreClass) && class_exists($coreClass)) {
108
-	$modx = new $coreClass;
108
+    $modx = new $coreClass;
109 109
 }
110 110
 if (!isset($modx) || !($modx instanceof \DocumentParser)) {
111
-	include_once(MODX_MANAGER_PATH.'includes/document.parser.class.inc.php');
112
-	$modx = new \DocumentParser;
111
+    include_once(MODX_MANAGER_PATH.'includes/document.parser.class.inc.php');
112
+    $modx = new \DocumentParser;
113 113
 }
114 114
 
115 115
 // set some parser options
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -50,16 +50,16 @@  discard block
 block discarded – undo
50 50
 	include_once($autoloader);
51 51
 }
52 52
 
53
-if(!isset($_SERVER['REQUEST_TIME_FLOAT'])) $_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
53
+if (!isset($_SERVER['REQUEST_TIME_FLOAT'])) $_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
54 54
 
55
-$base_path = str_replace('\\','/',dirname(__FILE__)) . '/';
56
-if(is_file($base_path . 'assets/cache/siteManager.php'))
57
-    include_once($base_path . 'assets/cache/siteManager.php');
58
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager"))
55
+$base_path = str_replace('\\', '/', dirname(__FILE__)).'/';
56
+if (is_file($base_path.'assets/cache/siteManager.php'))
57
+    include_once($base_path.'assets/cache/siteManager.php');
58
+if (!defined('MGR_DIR') && is_dir("{$base_path}manager"))
59 59
 	define('MGR_DIR', 'manager');
60
-if(is_file($base_path . 'assets/cache/siteHostnames.php'))
61
-    include_once($base_path . 'assets/cache/siteHostnames.php');
62
-if(!defined('MODX_SITE_HOSTNAMES'))
60
+if (is_file($base_path.'assets/cache/siteHostnames.php'))
61
+    include_once($base_path.'assets/cache/siteHostnames.php');
62
+if (!defined('MODX_SITE_HOSTNAMES'))
63 63
 	define('MODX_SITE_HOSTNAMES', '');
64 64
 
65 65
 // get start time
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 // set some settings, and address some IE issues
72 72
 @ini_set('url_rewriter.tags', '');
73 73
 @ini_set('session.use_trans_sid', 0);
74
-@ini_set('session.use_only_cookies',1);
74
+@ini_set('session.use_only_cookies', 1);
75 75
 session_cache_limiter('');
76 76
 header('P3P: CP="NOI NID ADMa OUR IND UNI COM NAV"'); // header for weird cookie stuff. Blame IE.
77 77
 header('Cache-Control: private, must-revalidate');
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
  */
84 84
 
85 85
 define('IN_PARSER_MODE', true);
86
-if ( ! defined('IN_MANAGER_MODE')) {
86
+if (!defined('IN_MANAGER_MODE')) {
87 87
 	define('IN_MANAGER_MODE', false);
88 88
 }
89 89
 if (!defined('MODX_API_MODE')) {
@@ -91,10 +91,10 @@  discard block
 block discarded – undo
91 91
 }
92 92
 
93 93
 // get the required includes
94
-if(!isset($database_user) || $database_user=="") {
94
+if (!isset($database_user) || $database_user == "") {
95 95
 	$rt = @include_once(dirname(__FILE__).'/'.MGR_DIR.'/includes/config.inc.php');
96 96
 	// Be sure config.inc.php is there and that it contains some important values
97
-	if(!$rt || !$database_type || !$database_server || !$database_user || !$dbase) {
97
+	if (!$rt || !$database_type || !$database_server || !$database_user || !$dbase) {
98 98
 		readfile('install/not_installed.tpl');
99 99
 		exit;
100 100
 	}
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 $modx->stopOnNotice = false;
126 126
 
127 127
 // Don't show PHP errors to the public
128
-if(!isset($_SESSION['mgrValidated']) || !$_SESSION['mgrValidated']) {
129
-    @ini_set("display_errors","0");
128
+if (!isset($_SESSION['mgrValidated']) || !$_SESSION['mgrValidated']) {
129
+    @ini_set("display_errors", "0");
130 130
 }
131 131
 
132 132
 // execute the parser if index.php was not included
Please login to merge, or discard this patch.
Braces   +11 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,17 +50,23 @@
 block discarded – undo
50 50
 	include_once($autoloader);
51 51
 }
52 52
 
53
-if(!isset($_SERVER['REQUEST_TIME_FLOAT'])) $_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
53
+if(!isset($_SERVER['REQUEST_TIME_FLOAT'])) {
54
+    $_SERVER['REQUEST_TIME_FLOAT'] = microtime(true);
55
+}
54 56
 
55 57
 $base_path = str_replace('\\','/',dirname(__FILE__)) . '/';
56
-if(is_file($base_path . 'assets/cache/siteManager.php'))
58
+if(is_file($base_path . 'assets/cache/siteManager.php')) {
57 59
     include_once($base_path . 'assets/cache/siteManager.php');
58
-if(!defined('MGR_DIR') && is_dir("{$base_path}manager"))
60
+}
61
+if(!defined('MGR_DIR') && is_dir("{$base_path}manager")) {
59 62
 	define('MGR_DIR', 'manager');
60
-if(is_file($base_path . 'assets/cache/siteHostnames.php'))
63
+}
64
+if(is_file($base_path . 'assets/cache/siteHostnames.php')) {
61 65
     include_once($base_path . 'assets/cache/siteHostnames.php');
62
-if(!defined('MODX_SITE_HOSTNAMES'))
66
+}
67
+if(!defined('MODX_SITE_HOSTNAMES')) {
63 68
 	define('MODX_SITE_HOSTNAMES', '');
69
+}
64 70
 
65 71
 // get start time
66 72
 $mstart = memory_get_usage();
Please login to merge, or discard this patch.
install/instprocessor.php 3 patches
Indentation   +64 added lines, -64 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     echo "<span class=\"notok\" style='color:#707070'>".$_lang['setup_database_selection_failed']."</span>".$_lang['setup_database_selection_failed_note']."</p>";
86 86
     $create = true;
87 87
 } else {
88
-	if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_charset);
88
+    if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_charset);
89 89
     mysqli_query($conn, "{$database_connection_method} {$database_connection_charset}");
90 90
     echo '<span class="ok">'.$_lang['ok']."</span></p>";
91 91
 }
@@ -280,23 +280,23 @@  discard block
 block discarded – undo
280 280
 
281 281
 // Reset database for installation of demo-site
282 282
 if ($installData && $moduleSQLDataFile && $moduleSQLResetFile) {
283
-	echo "<p>" . $_lang['resetting_database'];
284
-	$sqlParser->process($moduleSQLResetFile);
285
-	// display database results
286
-	if ($sqlParser->installFailed == true) {
287
-		$errors += 1;
288
-		echo "<span class=\"notok\"><b>" . $_lang['database_alerts'] . "</span></p>";
289
-		echo "<p>" . $_lang['setup_couldnt_install'] . "</p>";
290
-		echo "<p>" . $_lang['installation_error_occured'] . "<br /><br />";
291
-		for ($i = 0; $i < count($sqlParser->mysqlErrors); $i++) {
292
-			echo "<em>" . $sqlParser->mysqlErrors[$i]["error"] . "</em>" . $_lang['during_execution_of_sql'] . "<span class='mono'>" . strip_tags($sqlParser->mysqlErrors[$i]["sql"]) . "</span>.<hr />";
293
-		}
294
-		echo "</p>";
295
-		echo "<p>" . $_lang['some_tables_not_updated'] . "</p>";
296
-		return;
297
-	} else {
298
-		echo '<span class="ok">'.$_lang['ok']."</span></p>";
299
-	}
283
+    echo "<p>" . $_lang['resetting_database'];
284
+    $sqlParser->process($moduleSQLResetFile);
285
+    // display database results
286
+    if ($sqlParser->installFailed == true) {
287
+        $errors += 1;
288
+        echo "<span class=\"notok\"><b>" . $_lang['database_alerts'] . "</span></p>";
289
+        echo "<p>" . $_lang['setup_couldnt_install'] . "</p>";
290
+        echo "<p>" . $_lang['installation_error_occured'] . "<br /><br />";
291
+        for ($i = 0; $i < count($sqlParser->mysqlErrors); $i++) {
292
+            echo "<em>" . $sqlParser->mysqlErrors[$i]["error"] . "</em>" . $_lang['during_execution_of_sql'] . "<span class='mono'>" . strip_tags($sqlParser->mysqlErrors[$i]["sql"]) . "</span>.<hr />";
293
+        }
294
+        echo "</p>";
295
+        echo "<p>" . $_lang['some_tables_not_updated'] . "</p>";
296
+        return;
297
+    } else {
298
+        echo '<span class="ok">'.$_lang['ok']."</span></p>";
299
+    }
300 300
 }
301 301
 
302 302
 // Install Templates
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
                         $tRow = mysqli_fetch_assoc($ts);
419 419
                         $templateId = $tRow['id'];
420 420
                         mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_tmplvar_templates` (tmplvarid, templateid) VALUES($id, $templateId)");
421
-                   }
421
+                    }
422 422
                 }
423 423
             }
424 424
         }
@@ -687,51 +687,51 @@  discard block
 block discarded – undo
687 687
 
688 688
 // Install Dependencies
689 689
 foreach ($moduleDependencies as $dependency) {
690
-	$ds = mysqli_query($sqlParser->conn, 'SELECT id, guid FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_modules` WHERE name="' . $dependency['module'] . '"');
691
-	if (!$ds) {
692
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
693
-		return;
694
-	} else {
695
-		$row = mysqli_fetch_assoc($ds);
696
-		$moduleId = $row["id"];
697
-		$moduleGuid = $row["guid"];
698
-	}
699
-	// get extra id
700
-	$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE ' . $dependency['column'] . '="' . $dependency['name'] . '"');
701
-	if (!$ds) {
702
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
703
-		return;
704
-	} else {
705
-		$row = mysqli_fetch_assoc($ds);
706
-		$extraId = $row["id"];
707
-	}
708
-	// setup extra as module dependency
709
-	$ds = mysqli_query($sqlParser->conn, 'SELECT module FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type'] . ' LIMIT 1');
710
-	if (!$ds) {
711
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
712
-		return;
713
-	} else {
714
-		if (mysqli_num_rows($ds) === 0) {
715
-			mysqli_query($sqlParser->conn, 'INSERT INTO ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` (module, resource, type) VALUES(' . $moduleId . ',' . $extraId . ',' . $dependency['type'] . ')');
716
-			echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_create'] . '</span></p>';
717
-		} else {
718
-			mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` SET module = ' . $moduleId . ', resource = ' . $extraId . ', type = ' . $dependency['type'] . ' WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type']);
719
-			echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_update'] . '</span></p>';
720
-		}
721
-		if ($dependency['type'] == 30 || $dependency['type'] == 40) {
722
-			// set extra guid for plugins and snippets
723
-			$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE id=' . $extraId . ' LIMIT 1');
724
-			if (!$ds) {
725
-				echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
726
-				return;
727
-			} else {
728
-				if (mysqli_num_rows($ds) != 0) {
729
-					mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` SET moduleguid = ' . $moduleGuid . ' WHERE id=' . $extraId);
730
-					echo '<p>&nbsp;&nbsp;' . $dependency['name'] . ': <span class="ok">' . $_lang['guid_set'] . '</span></p>';
731
-				}
732
-			}
733
-		}
734
-	}
690
+    $ds = mysqli_query($sqlParser->conn, 'SELECT id, guid FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_modules` WHERE name="' . $dependency['module'] . '"');
691
+    if (!$ds) {
692
+        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
693
+        return;
694
+    } else {
695
+        $row = mysqli_fetch_assoc($ds);
696
+        $moduleId = $row["id"];
697
+        $moduleGuid = $row["guid"];
698
+    }
699
+    // get extra id
700
+    $ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE ' . $dependency['column'] . '="' . $dependency['name'] . '"');
701
+    if (!$ds) {
702
+        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
703
+        return;
704
+    } else {
705
+        $row = mysqli_fetch_assoc($ds);
706
+        $extraId = $row["id"];
707
+    }
708
+    // setup extra as module dependency
709
+    $ds = mysqli_query($sqlParser->conn, 'SELECT module FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type'] . ' LIMIT 1');
710
+    if (!$ds) {
711
+        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
712
+        return;
713
+    } else {
714
+        if (mysqli_num_rows($ds) === 0) {
715
+            mysqli_query($sqlParser->conn, 'INSERT INTO ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` (module, resource, type) VALUES(' . $moduleId . ',' . $extraId . ',' . $dependency['type'] . ')');
716
+            echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_create'] . '</span></p>';
717
+        } else {
718
+            mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` SET module = ' . $moduleId . ', resource = ' . $extraId . ', type = ' . $dependency['type'] . ' WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type']);
719
+            echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_update'] . '</span></p>';
720
+        }
721
+        if ($dependency['type'] == 30 || $dependency['type'] == 40) {
722
+            // set extra guid for plugins and snippets
723
+            $ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE id=' . $extraId . ' LIMIT 1');
724
+            if (!$ds) {
725
+                echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
726
+                return;
727
+            } else {
728
+                if (mysqli_num_rows($ds) != 0) {
729
+                    mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` SET moduleguid = ' . $moduleGuid . ' WHERE id=' . $extraId);
730
+                    echo '<p>&nbsp;&nbsp;' . $dependency['name'] . ': <span class="ok">' . $_lang['guid_set'] . '</span></p>';
731
+                }
732
+            }
733
+        }
734
+    }
735 735
 }
736 736
 
737 737
 // call back function
Please login to merge, or discard this patch.
Spacing   +183 added lines, -183 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if (file_exists(dirname(__FILE__)."/../assets/cache/siteManager.php")) {
3 3
     include_once(dirname(__FILE__)."/../assets/cache/siteManager.php");
4
-}else{
4
+} else {
5 5
     define('MGR_DIR', 'manager');
6 6
 }
7 7
 
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
 echo "<p>{$_lang['setup_database']}</p>\n";
30 30
 
31
-$installMode= intval($_POST['installmode']);
31
+$installMode = intval($_POST['installmode']);
32 32
 $installData = $_POST['installdata'] == "1" ? 1 : 0;
33 33
 
34 34
 //if ($installMode == 1) {
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
43 43
 $database_connection_charset = $_POST['database_connection_charset'];
44 44
 $database_connection_method = $_POST['database_connection_method'];
45
-$dbase = "`" . $_POST['database_name'] . "`";
45
+$dbase = "`".$_POST['database_name']."`";
46 46
 $table_prefix = $_POST['tableprefix'];
47 47
 $adminname = $_POST['cmsadmin'];
48 48
 $adminemail = $_POST['cmsadminemail'];
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
 // set session name variable
55 55
 if (!isset ($site_sessionname)) {
56
-    $site_sessionname = 'SN' . uniqid('');
56
+    $site_sessionname = 'SN'.uniqid('');
57 57
 }
58 58
 
59 59
 // get base path and url
@@ -67,11 +67,11 @@  discard block
 block discarded – undo
67 67
     array_pop($a);
68 68
 $pth = implode("install", $a);
69 69
 unset ($a);
70
-$base_url = $url . (substr($url, -1) != "/" ? "/" : "");
71
-$base_path = $pth . (substr($pth, -1) != "/" ? "/" : "");
70
+$base_url = $url.(substr($url, -1) != "/" ? "/" : "");
71
+$base_path = $pth.(substr($pth, -1) != "/" ? "/" : "");
72 72
 
73 73
 // connect to the database
74
-echo "<p>". $_lang['setup_database_create_connection'];
74
+echo "<p>".$_lang['setup_database_create_connection'];
75 75
 if (!$conn = mysqli_connect($database_server, $database_user, $database_password)) {
76 76
     echo '<span class="notok">'.$_lang["setup_database_create_connection_failed"]."</span></p><p>".$_lang['setup_database_create_connection_failed_note']."</p>";
77 77
     return;
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 }
81 81
 
82 82
 // select database
83
-echo "<p>".$_lang['setup_database_selection']. str_replace("`", "", $dbase) . "`: ";
83
+echo "<p>".$_lang['setup_database_selection'].str_replace("`", "", $dbase)."`: ";
84 84
 if (!mysqli_select_db($conn, str_replace("`", "", $dbase))) {
85 85
     echo "<span class=\"notok\" style='color:#707070'>".$_lang['setup_database_selection_failed']."</span>".$_lang['setup_database_selection_failed_note']."</p>";
86 86
     $create = true;
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
 
93 93
 // try to create the database
94 94
 if ($create) {
95
-    echo "<p>".$_lang['setup_database_creation']. str_replace("`", "", $dbase) . "`: ";
95
+    echo "<p>".$_lang['setup_database_creation'].str_replace("`", "", $dbase)."`: ";
96 96
     //	if(!@mysqli_create_db(str_replace("`","",$dbase), $conn)) {
97
-    if (! mysqli_query($conn, "CREATE DATABASE $dbase DEFAULT CHARACTER SET $database_charset COLLATE $database_collation")) {
97
+    if (!mysqli_query($conn, "CREATE DATABASE $dbase DEFAULT CHARACTER SET $database_charset COLLATE $database_collation")) {
98 98
         echo '<span class="notok">'.$_lang['setup_database_creation_failed']."</span>".$_lang['setup_database_creation_failed_note']."</p>";
99 99
         $errors += 1;
100 100
 ?>
@@ -113,33 +113,33 @@  discard block
 block discarded – undo
113 113
 
114 114
 // check table prefix
115 115
 if ($installMode == 0) {
116
-    echo "<p>" . $_lang['checking_table_prefix'] . $table_prefix . "`: ";
117
-    if (@ $rs = mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`" . $table_prefix . "site_content`")) {
118
-        echo '<span class="notok">' . $_lang['failed'] . "</span>" . $_lang['table_prefix_already_inuse'] . "</p>";
116
+    echo "<p>".$_lang['checking_table_prefix'].$table_prefix."`: ";
117
+    if (@ $rs = mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`".$table_prefix."site_content`")) {
118
+        echo '<span class="notok">'.$_lang['failed']."</span>".$_lang['table_prefix_already_inuse']."</p>";
119 119
         $errors += 1;
120
-        echo "<p>" . $_lang['table_prefix_already_inuse_note'] . "</p>";
120
+        echo "<p>".$_lang['table_prefix_already_inuse_note']."</p>";
121 121
         return;
122 122
     } else {
123 123
         echo '<span class="ok">'.$_lang['ok']."</span></p>";
124 124
     }
125 125
 }
126 126
 
127
-if(!function_exists('parseProperties')) {
127
+if (!function_exists('parseProperties')) {
128 128
     // parses a resource property string and returns the result as an array
129 129
     // duplicate of method in documentParser class
130
-    function parseProperties($propertyString) {
131
-        $parameter= array ();
130
+    function parseProperties($propertyString){
131
+        $parameter = array();
132 132
         if (!empty ($propertyString)) {
133
-            $tmpParams= explode("&", $propertyString);
134
-            for ($x= 0; $x < count($tmpParams); $x++) {
133
+            $tmpParams = explode("&", $propertyString);
134
+            for ($x = 0; $x < count($tmpParams); $x++) {
135 135
                 if (strpos($tmpParams[$x], '=', 0)) {
136
-                    $pTmp= explode("=", $tmpParams[$x]);
137
-                    $pvTmp= explode(";", trim($pTmp[1]));
136
+                    $pTmp = explode("=", $tmpParams[$x]);
137
+                    $pvTmp = explode(";", trim($pTmp[1]));
138 138
                     if ($pvTmp[1] == 'list' && $pvTmp[3] != "")
139
-                        $parameter[trim($pTmp[0])]= $pvTmp[3]; //list default
139
+                        $parameter[trim($pTmp[0])] = $pvTmp[3]; //list default
140 140
                     else
141 141
                         if ($pvTmp[1] != 'list' && $pvTmp[2] != "")
142
-                            $parameter[trim($pTmp[0])]= $pvTmp[2];
142
+                            $parameter[trim($pTmp[0])] = $pvTmp[2];
143 143
                 }
144 144
             }
145 145
         }
@@ -150,20 +150,20 @@  discard block
 block discarded – undo
150 150
 // check status of Inherit Parent Template plugin
151 151
 $auto_template_logic = 'parent';
152 152
 if ($installMode != 0) {
153
-    $rs = mysqli_query($conn, "SELECT properties, disabled FROM $dbase.`" . $table_prefix . "site_plugins` WHERE name='Inherit Parent Template'");
153
+    $rs = mysqli_query($conn, "SELECT properties, disabled FROM $dbase.`".$table_prefix."site_plugins` WHERE name='Inherit Parent Template'");
154 154
     $row = mysqli_fetch_row($rs);
155
-    if(!$row) {
155
+    if (!$row) {
156 156
         // not installed
157 157
         $auto_template_logic = 'system';
158 158
     } else {
159
-        if($row[1] == 1) {
159
+        if ($row[1] == 1) {
160 160
             // installed but disabled
161 161
             $auto_template_logic = 'system';
162 162
         } else {
163 163
             // installed, enabled .. see how it's configured
164 164
             $properties = parseProperties($row[0]);
165
-            if(isset($properties['inheritTemplate'])) {
166
-                if($properties['inheritTemplate'] == 'From First Sibling') {
165
+            if (isset($properties['inheritTemplate'])) {
166
+                if ($properties['inheritTemplate'] == 'From First Sibling') {
167 167
                     $auto_template_logic = 'sibling';
168 168
                 }
169 169
             }
@@ -187,20 +187,20 @@  discard block
 block discarded – undo
187 187
 $sqlParser->connect();
188 188
 
189 189
 // install/update database
190
-echo "<p>" . $_lang['setup_database_creating_tables'];
190
+echo "<p>".$_lang['setup_database_creating_tables'];
191 191
 if ($moduleSQLBaseFile) {
192 192
     $sqlParser->process($moduleSQLBaseFile);
193 193
     // display database results
194 194
     if ($sqlParser->installFailed == true) {
195 195
         $errors += 1;
196
-        echo "<span class=\"notok\"><b>" . $_lang['database_alerts'] . "</span></p>";
197
-        echo "<p>" . $_lang['setup_couldnt_install'] . "</p>";
198
-        echo "<p>" . $_lang['installation_error_occured'] . "<br /><br />";
196
+        echo "<span class=\"notok\"><b>".$_lang['database_alerts']."</span></p>";
197
+        echo "<p>".$_lang['setup_couldnt_install']."</p>";
198
+        echo "<p>".$_lang['installation_error_occured']."<br /><br />";
199 199
         for ($i = 0; $i < count($sqlParser->mysqlErrors); $i++) {
200
-            echo "<em>" . $sqlParser->mysqlErrors[$i]["error"] . "</em>" . $_lang['during_execution_of_sql'] . "<span class='mono'>" . strip_tags($sqlParser->mysqlErrors[$i]["sql"]) . "</span>.<hr />";
200
+            echo "<em>".$sqlParser->mysqlErrors[$i]["error"]."</em>".$_lang['during_execution_of_sql']."<span class='mono'>".strip_tags($sqlParser->mysqlErrors[$i]["sql"])."</span>.<hr />";
201 201
         }
202 202
         echo "</p>";
203
-        echo "<p>" . $_lang['some_tables_not_updated'] . "</p>";
203
+        echo "<p>".$_lang['some_tables_not_updated']."</p>";
204 204
         return;
205 205
     } else {
206 206
         echo '<span class="ok">'.$_lang['ok']."</span></p>";
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
 // custom or not
211 211
 if (file_exists(dirname(__FILE__)."/../../assets/cache/siteManager.php")) {
212 212
     $mgrdir = 'include_once(dirname(__FILE__)."/../../assets/cache/siteManager.php");';
213
-}else{
213
+} else {
214 214
     $mgrdir = 'define(\'MGR_DIR\', \'manager\');';
215 215
 }
216 216
 
217 217
 // write the config.inc.php file if new installation
218
-echo "<p>" . $_lang['writing_config_file'];
218
+echo "<p>".$_lang['writing_config_file'];
219 219
 
220 220
 $confph = array();
221 221
 $confph['database_server']    = $database_server;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 $chmodSuccess = @chmod($filename, 0404);
248 248
 
249 249
 if ($configFileFailed == true) {
250
-    echo '<span class="notok">' . $_lang['failed'] . "</span></p>";
250
+    echo '<span class="notok">'.$_lang['failed']."</span></p>";
251 251
     $errors += 1;
252 252
 ?>
253 253
     <p><?php echo $_lang['cant_write_config_file']?><span class="mono"><?php echo MGR_DIR; ?>/includes/config.inc.php</span></p>
@@ -264,35 +264,35 @@  discard block
 block discarded – undo
264 264
 // generate new site_id and set manager theme to default
265 265
 if ($installMode == 0) {
266 266
     $siteid = uniqid('');
267
-    mysqli_query($sqlParser->conn, "REPLACE INTO $dbase.`" . $table_prefix . "system_settings` (setting_name,setting_value) VALUES('site_id','$siteid'),('manager_theme','default')");
267
+    mysqli_query($sqlParser->conn, "REPLACE INTO $dbase.`".$table_prefix."system_settings` (setting_name,setting_value) VALUES('site_id','$siteid'),('manager_theme','default')");
268 268
 } else {
269 269
     // update site_id if missing
270
-    $ds = mysqli_query($sqlParser->conn, "SELECT setting_name,setting_value FROM $dbase.`" . $table_prefix . "system_settings` WHERE setting_name='site_id'");
270
+    $ds = mysqli_query($sqlParser->conn, "SELECT setting_name,setting_value FROM $dbase.`".$table_prefix."system_settings` WHERE setting_name='site_id'");
271 271
     if ($ds) {
272 272
         $r = mysqli_fetch_assoc($ds);
273 273
         $siteid = $r['setting_value'];
274 274
         if ($siteid == '' || $siteid = 'MzGeQ2faT4Dw06+U49x3') {
275 275
             $siteid = uniqid('');
276
-            mysqli_query($sqlParser->conn, "REPLACE INTO $dbase.`" . $table_prefix . "system_settings` (setting_name,setting_value) VALUES('site_id','$siteid')");
276
+            mysqli_query($sqlParser->conn, "REPLACE INTO $dbase.`".$table_prefix."system_settings` (setting_name,setting_value) VALUES('site_id','$siteid')");
277 277
         }
278 278
     }
279 279
 }
280 280
 
281 281
 // Reset database for installation of demo-site
282 282
 if ($installData && $moduleSQLDataFile && $moduleSQLResetFile) {
283
-	echo "<p>" . $_lang['resetting_database'];
283
+	echo "<p>".$_lang['resetting_database'];
284 284
 	$sqlParser->process($moduleSQLResetFile);
285 285
 	// display database results
286 286
 	if ($sqlParser->installFailed == true) {
287 287
 		$errors += 1;
288
-		echo "<span class=\"notok\"><b>" . $_lang['database_alerts'] . "</span></p>";
289
-		echo "<p>" . $_lang['setup_couldnt_install'] . "</p>";
290
-		echo "<p>" . $_lang['installation_error_occured'] . "<br /><br />";
288
+		echo "<span class=\"notok\"><b>".$_lang['database_alerts']."</span></p>";
289
+		echo "<p>".$_lang['setup_couldnt_install']."</p>";
290
+		echo "<p>".$_lang['installation_error_occured']."<br /><br />";
291 291
 		for ($i = 0; $i < count($sqlParser->mysqlErrors); $i++) {
292
-			echo "<em>" . $sqlParser->mysqlErrors[$i]["error"] . "</em>" . $_lang['during_execution_of_sql'] . "<span class='mono'>" . strip_tags($sqlParser->mysqlErrors[$i]["sql"]) . "</span>.<hr />";
292
+			echo "<em>".$sqlParser->mysqlErrors[$i]["error"]."</em>".$_lang['during_execution_of_sql']."<span class='mono'>".strip_tags($sqlParser->mysqlErrors[$i]["sql"])."</span>.<hr />";
293 293
 		}
294 294
 		echo "</p>";
295
-		echo "<p>" . $_lang['some_tables_not_updated'] . "</p>";
295
+		echo "<p>".$_lang['some_tables_not_updated']."</p>";
296 296
 		return;
297 297
 	} else {
298 298
 		echo '<span class="ok">'.$_lang['ok']."</span></p>";
@@ -301,11 +301,11 @@  discard block
 block discarded – undo
301 301
 
302 302
 // Install Templates
303 303
 if (isset ($_POST['template']) || $installData) {
304
-    echo "<h3>" . $_lang['templates'] . ":</h3> ";
304
+    echo "<h3>".$_lang['templates'].":</h3> ";
305 305
     $selTemplates = $_POST['template'];
306 306
     foreach ($moduleTemplates as $k=>$moduleTemplate) {
307 307
         $installSample = in_array('sample', $moduleTemplate[6]) && $installData == 1;
308
-        if($installSample || in_array($k, $selTemplates)) {
308
+        if ($installSample || in_array($k, $selTemplates)) {
309 309
             $name = mysqli_real_escape_string($conn, $moduleTemplate[0]);
310 310
             $desc = mysqli_real_escape_string($conn, $moduleTemplate[1]);
311 311
             $category = mysqli_real_escape_string($conn, $moduleTemplate[4]);
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
             $filecontent = $moduleTemplate[3];
314 314
             $save_sql_id_as = $moduleTemplate[7]; // Nessecary for demo-site
315 315
             if (!file_exists($filecontent)) {
316
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_template'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
316
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">".$_lang['unable_install_template']." '$filecontent' ".$_lang['not_found'].".</span></p>";
317 317
             } else {
318 318
                 // Create the category if it does not already exist
319 319
                 $category_id = getCreateDbCategory($category, $sqlParser);
@@ -323,31 +323,31 @@  discard block
 block discarded – undo
323 323
                 $template = mysqli_real_escape_string($conn, $template);
324 324
 
325 325
                 // See if the template already exists
326
-                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_templates` WHERE templatename='$name'");
326
+                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_templates` WHERE templatename='$name'");
327 327
 
328 328
                 if (mysqli_num_rows($rs)) {
329
-                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_templates` SET content='$template', description='$desc', category=$category_id, locked='$locked'  WHERE templatename='$name' LIMIT 1;")) {
329
+                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_templates` SET content='$template', description='$desc', category=$category_id, locked='$locked'  WHERE templatename='$name' LIMIT 1;")) {
330 330
                         $errors += 1;
331
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
331
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
332 332
                         return;
333 333
                     }
334
-                    if(!is_null($save_sql_id_as)) {
334
+                    if (!is_null($save_sql_id_as)) {
335 335
                         $sql_id = @mysqli_insert_id($sqlParser->conn);
336
-                        if(!$sql_id) {
337
-                            $idQuery = mysqli_fetch_assoc(mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`" . $table_prefix . "site_templates` WHERE templatename='$name' LIMIT 1;"));
336
+                        if (!$sql_id) {
337
+                            $idQuery = mysqli_fetch_assoc(mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."site_templates` WHERE templatename='$name' LIMIT 1;"));
338 338
                             $sql_id = $idQuery['id'];
339 339
                         }
340 340
                         $custom_placeholders[$save_sql_id_as] = $sql_id;
341 341
                     }
342
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
342
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
343 343
                 } else {
344
-                    if (!@ mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_templates` (templatename,description,content,category,locked) VALUES('$name','$desc','$template',$category_id,'$locked');")) {
344
+                    if (!@ mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_templates` (templatename,description,content,category,locked) VALUES('$name','$desc','$template',$category_id,'$locked');")) {
345 345
                         $errors += 1;
346
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
346
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
347 347
                         return;
348 348
                     }
349
-                    if(!is_null($save_sql_id_as)) $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
350
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
349
+                    if (!is_null($save_sql_id_as)) $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
350
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
351 351
                 }
352 352
             }
353 353
         }
@@ -356,11 +356,11 @@  discard block
 block discarded – undo
356 356
 
357 357
 // Install Template Variables
358 358
 if (isset ($_POST['tv']) || $installData) {
359
-    echo "<h3>" . $_lang['tvs'] . ":</h3> ";
359
+    echo "<h3>".$_lang['tvs'].":</h3> ";
360 360
     $selTVs = $_POST['tv'];
361 361
     foreach ($moduleTVs as $k=>$moduleTV) {
362 362
         $installSample = in_array('sample', $moduleTV[12]) && $installData == 1;
363
-        if($installSample || in_array($k, $selTVs)) {
363
+        if ($installSample || in_array($k, $selTVs)) {
364 364
             $name = mysqli_real_escape_string($conn, $moduleTV[0]);
365 365
             $caption = mysqli_real_escape_string($conn, $moduleTV[1]);
366 366
             $desc = mysqli_real_escape_string($conn, $moduleTV[2]);
@@ -378,25 +378,25 @@  discard block
 block discarded – undo
378 378
             // Create the category if it does not already exist
379 379
             $category = getCreateDbCategory($category, $sqlParser);
380 380
 
381
-            $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_tmplvars` WHERE name='$name'");
381
+            $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_tmplvars` WHERE name='$name'");
382 382
             if (mysqli_num_rows($rs)) {
383 383
                 $insert = true;
384
-                while($row = mysqli_fetch_assoc($rs)) {
385
-                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_tmplvars` SET type='$input_type', caption='$caption', description='$desc', category=$category, locked=$locked, elements='$input_options', display='$output_widget', display_params='$output_widget_params', default_text='$input_default' WHERE id={$row['id']};")) {
386
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
384
+                while ($row = mysqli_fetch_assoc($rs)) {
385
+                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_tmplvars` SET type='$input_type', caption='$caption', description='$desc', category=$category, locked=$locked, elements='$input_options', display='$output_widget', display_params='$output_widget_params', default_text='$input_default' WHERE id={$row['id']};")) {
386
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
387 387
                         return;
388 388
                     }
389 389
                     $insert = false;
390 390
                 }
391
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
391
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
392 392
             } else {
393 393
                 //$q = "INSERT INTO $dbase.`" . $table_prefix . "site_tmplvars` (type,name,caption,description,category,locked,elements,display,display_params,default_text) VALUES('$input_type','$name','$caption','$desc',(SELECT (CASE COUNT(*) WHEN 0 THEN 0 ELSE `id` END) `id` FROM $dbase.`" . $table_prefix . "categories` WHERE `category` = '$category'),$locked,'$input_options','$output_widget','$output_widget_params','$input_default');";
394
-                $q = "INSERT INTO $dbase.`" . $table_prefix . "site_tmplvars` (type,name,caption,description,category,locked,elements,display,display_params,default_text) VALUES('$input_type','$name','$caption','$desc',$category,$locked,'$input_options','$output_widget','$output_widget_params','$input_default');";
394
+                $q = "INSERT INTO $dbase.`".$table_prefix."site_tmplvars` (type,name,caption,description,category,locked,elements,display,display_params,default_text) VALUES('$input_type','$name','$caption','$desc',$category,$locked,'$input_options','$output_widget','$output_widget_params','$input_default');";
395 395
                 if (!mysqli_query($sqlParser->conn, $q)) {
396
-                    echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
396
+                    echo "<p>".mysqli_error($sqlParser->conn)."</p>";
397 397
                     return;
398 398
                 }
399
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
399
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
400 400
             }
401 401
 
402 402
             // add template assignments
@@ -405,10 +405,10 @@  discard block
 block discarded – undo
405 405
             if (count($assignments) > 0) {
406 406
 
407 407
                 // remove existing tv -> template assignments
408
-                $ds=mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."site_tmplvars` WHERE name='$name' AND description='$desc';");
408
+                $ds = mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."site_tmplvars` WHERE name='$name' AND description='$desc';");
409 409
                 $row = mysqli_fetch_assoc($ds);
410 410
                 $id = $row["id"];
411
-                mysqli_query($sqlParser->conn, 'DELETE FROM ' . $dbase . '.`' . $table_prefix . 'site_tmplvar_templates` WHERE tmplvarid = \'' . $id . '\'');
411
+                mysqli_query($sqlParser->conn, 'DELETE FROM '.$dbase.'.`'.$table_prefix.'site_tmplvar_templates` WHERE tmplvarid = \''.$id.'\'');
412 412
 
413 413
                 // add tv -> template assignments
414 414
                 foreach ($assignments as $assignment) {
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
                     if ($ds && $ts) {
418 418
                         $tRow = mysqli_fetch_assoc($ts);
419 419
                         $templateId = $tRow['id'];
420
-                        mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_tmplvar_templates` (tmplvarid, templateid) VALUES($id, $templateId)");
420
+                        mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_tmplvar_templates` (tmplvarid, templateid) VALUES($id, $templateId)");
421 421
                    }
422 422
                 }
423 423
             }
@@ -427,12 +427,12 @@  discard block
 block discarded – undo
427 427
 
428 428
 // Install Chunks
429 429
 if (isset ($_POST['chunk']) || $installData) {
430
-    echo "<h3>" . $_lang['chunks'] . ":</h3> ";
430
+    echo "<h3>".$_lang['chunks'].":</h3> ";
431 431
     $selChunks = $_POST['chunk'];
432 432
     foreach ($moduleChunks as $k=>$moduleChunk) {
433 433
         $installSample = in_array('sample', $moduleChunk[5]) && $installData == 1;
434 434
         $count_new_name = 0;
435
-        if($installSample || in_array($k, $selChunks)) {
435
+        if ($installSample || in_array($k, $selChunks)) {
436 436
 
437 437
             $name = mysqli_real_escape_string($conn, $moduleChunk[0]);
438 438
             $desc = mysqli_real_escape_string($conn, $moduleChunk[1]);
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
             $filecontent = $moduleChunk[2];
442 442
 
443 443
             if (!file_exists($filecontent))
444
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_chunk'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
444
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">".$_lang['unable_install_chunk']." '$filecontent' ".$_lang['not_found'].".</span></p>";
445 445
             else {
446 446
 
447 447
                 // Create the category if it does not already exist
@@ -449,31 +449,31 @@  discard block
 block discarded – undo
449 449
 
450 450
                 $chunk = preg_replace("/^.*?\/\*\*.*?\*\/\s+/s", '', file_get_contents($filecontent), 1);
451 451
                 $chunk = mysqli_real_escape_string($conn, $chunk);
452
-                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_htmlsnippets` WHERE name='$name'");
452
+                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_htmlsnippets` WHERE name='$name'");
453 453
                 $count_original_name = mysqli_num_rows($rs);
454
-                if($overwrite == 'false') {
455
-                    $newname = $name . '-' . str_replace('.', '_', $modx_version);
456
-                    $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_htmlsnippets` WHERE name='$newname'");
454
+                if ($overwrite == 'false') {
455
+                    $newname = $name.'-'.str_replace('.', '_', $modx_version);
456
+                    $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_htmlsnippets` WHERE name='$newname'");
457 457
                     $count_new_name = mysqli_num_rows($rs);
458 458
                 }
459 459
                 $update = $count_original_name > 0 && $overwrite == 'true';
460 460
                 if ($update) {
461
-                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_htmlsnippets` SET snippet='$chunk', description='$desc', category=$category_id WHERE name='$name';")) {
461
+                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_htmlsnippets` SET snippet='$chunk', description='$desc', category=$category_id WHERE name='$name';")) {
462 462
                         $errors += 1;
463
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
463
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
464 464
                         return;
465 465
                     }
466
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
467
-                } elseif($count_new_name == 0) {
468
-                    if($count_original_name > 0 && $overwrite == 'false') {
466
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
467
+                } elseif ($count_new_name == 0) {
468
+                    if ($count_original_name > 0 && $overwrite == 'false') {
469 469
                         $name = $newname;
470 470
                     }
471
-                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_htmlsnippets` (name,description,snippet,category) VALUES('$name','$desc','$chunk',$category_id);")) {
471
+                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_htmlsnippets` (name,description,snippet,category) VALUES('$name','$desc','$chunk',$category_id);")) {
472 472
                         $errors += 1;
473
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
473
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
474 474
                         return;
475 475
                     }
476
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
476
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
477 477
                 }
478 478
             }
479 479
         }
@@ -482,11 +482,11 @@  discard block
 block discarded – undo
482 482
 
483 483
 // Install Modules
484 484
 if (isset ($_POST['module']) || $installData) {
485
-    echo "<h3>" . $_lang['modules'] . ":</h3> ";
485
+    echo "<h3>".$_lang['modules'].":</h3> ";
486 486
     $selModules = $_POST['module'];
487 487
     foreach ($moduleModules as $k=>$moduleModule) {
488 488
         $installSample = in_array('sample', $moduleModule[7]) && $installData == 1;
489
-        if($installSample || in_array($k, $selModules)) {
489
+        if ($installSample || in_array($k, $selModules)) {
490 490
             $name = mysqli_real_escape_string($conn, $moduleModule[0]);
491 491
             $desc = mysqli_real_escape_string($conn, $moduleModule[1]);
492 492
             $filecontent = $moduleModule[2];
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
             $shared = mysqli_real_escape_string($conn, $moduleModule[5]);
496 496
             $category = mysqli_real_escape_string($conn, $moduleModule[6]);
497 497
             if (!file_exists($filecontent))
498
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_module'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
498
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">".$_lang['unable_install_module']." '$filecontent' ".$_lang['not_found'].".</span></p>";
499 499
             else {
500 500
 
501 501
                 // Create the category if it does not already exist
@@ -504,22 +504,22 @@  discard block
 block discarded – undo
504 504
                 $module = end(preg_split("/(\/\/)?\s*\<\?php/", file_get_contents($filecontent), 2));
505 505
                 // $module = removeDocblock($module, 'module'); // Modules have no fileBinding, keep docblock for info-tab
506 506
                 $module = mysqli_real_escape_string($conn, $module);
507
-                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_modules` WHERE name='$name'");
507
+                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_modules` WHERE name='$name'");
508 508
                 if (mysqli_num_rows($rs)) {
509 509
                     $row = mysqli_fetch_assoc($rs);
510
-                    $props = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
511
-                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_modules` SET modulecode='$module', description='$desc', properties='$props', enable_sharedparams='$shared' WHERE name='$name';")) {
512
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
510
+                    $props = mysqli_real_escape_string($conn, propUpdate($properties, $row['properties']));
511
+                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_modules` SET modulecode='$module', description='$desc', properties='$props', enable_sharedparams='$shared' WHERE name='$name';")) {
512
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
513 513
                         return;
514 514
                     }
515
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
515
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
516 516
                 } else {
517 517
                     $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
518
-                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_modules` (name,description,modulecode,properties,guid,enable_sharedparams,category) VALUES('$name','$desc','$module','$properties','$guid','$shared', $category);")) {
519
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
518
+                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_modules` (name,description,modulecode,properties,guid,enable_sharedparams,category) VALUES('$name','$desc','$module','$properties','$guid','$shared', $category);")) {
519
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
520 520
                         return;
521 521
                     }
522
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
522
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
523 523
                 }
524 524
             }
525 525
         }
@@ -528,11 +528,11 @@  discard block
 block discarded – undo
528 528
 
529 529
 // Install Plugins
530 530
 if (isset ($_POST['plugin']) || $installData) {
531
-    echo "<h3>" . $_lang['plugins'] . ":</h3> ";
531
+    echo "<h3>".$_lang['plugins'].":</h3> ";
532 532
     $selPlugs = $_POST['plugin'];
533 533
     foreach ($modulePlugins as $k=>$modulePlugin) {
534 534
         $installSample = in_array('sample', $modulePlugin[8]) && $installData == 1;
535
-        if($installSample || in_array($k, $selPlugs)) {
535
+        if ($installSample || in_array($k, $selPlugs)) {
536 536
             $name = mysqli_real_escape_string($conn, $modulePlugin[0]);
537 537
             $desc = mysqli_real_escape_string($conn, $modulePlugin[1]);
538 538
             $filecontent = $modulePlugin[2];
@@ -542,17 +542,17 @@  discard block
 block discarded – undo
542 542
             $category = mysqli_real_escape_string($conn, $modulePlugin[6]);
543 543
             $leg_names = '';
544 544
             $disabled = $modulePlugin[9];
545
-            if(array_key_exists(7, $modulePlugin)) {
545
+            if (array_key_exists(7, $modulePlugin)) {
546 546
                 // parse comma-separated legacy names and prepare them for sql IN clause
547
-                $leg_names = "'" . implode("','", preg_split('/\s*,\s*/', mysqli_real_escape_string($conn, $modulePlugin[7]))) . "'";
547
+                $leg_names = "'".implode("','", preg_split('/\s*,\s*/', mysqli_real_escape_string($conn, $modulePlugin[7])))."'";
548 548
             }
549 549
             if (!file_exists($filecontent))
550
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_plugin'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
550
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">".$_lang['unable_install_plugin']." '$filecontent' ".$_lang['not_found'].".</span></p>";
551 551
             else {
552 552
 
553 553
                 // disable legacy versions based on legacy_names provided
554
-                if(!empty($leg_names)) {
555
-                    $update_query = "UPDATE $dbase.`" . $table_prefix . "site_plugins` SET disabled='1' WHERE name IN ($leg_names);";
554
+                if (!empty($leg_names)) {
555
+                    $update_query = "UPDATE $dbase.`".$table_prefix."site_plugins` SET disabled='1' WHERE name IN ($leg_names);";
556 556
                     $rs = mysqli_query($sqlParser->conn, $update_query);
557 557
                 }
558 558
 
@@ -562,50 +562,50 @@  discard block
 block discarded – undo
562 562
                 $plugin = end(preg_split("/(\/\/)?\s*\<\?php/", file_get_contents($filecontent), 2));
563 563
                 $plugin = removeDocblock($plugin, 'plugin');
564 564
                 $plugin = mysqli_real_escape_string($conn, $plugin);
565
-                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_plugins` WHERE name='$name'");
565
+                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_plugins` WHERE name='$name'");
566 566
                 if (mysqli_num_rows($rs)) {
567 567
                     $insert = true;
568
-                    while($row = mysqli_fetch_assoc($rs)) {
569
-                        $props = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
570
-                        if($row['description'] == $desc){
571
-                            if (! mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_plugins` SET plugincode='$plugin', description='$desc', properties='$props' WHERE id={$row['id']};")) {
572
-                                echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
568
+                    while ($row = mysqli_fetch_assoc($rs)) {
569
+                        $props = mysqli_real_escape_string($conn, propUpdate($properties, $row['properties']));
570
+                        if ($row['description'] == $desc) {
571
+                            if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_plugins` SET plugincode='$plugin', description='$desc', properties='$props' WHERE id={$row['id']};")) {
572
+                                echo "<p>".mysqli_error($sqlParser->conn)."</p>";
573 573
                                 return;
574 574
                             }
575 575
                             $insert = false;
576 576
                         } else {
577
-                            if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_plugins` SET disabled='1' WHERE id={$row['id']};")) {
577
+                            if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_plugins` SET disabled='1' WHERE id={$row['id']};")) {
578 578
                                 echo "<p>".mysqli_error($sqlParser->conn)."</p>";
579 579
                                 return;
580 580
                             }
581 581
                         }
582 582
                     }
583
-                    if($insert === true) {
584
-                        $properties = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
585
-                        if(!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_plugins` (name,description,plugincode,properties,moduleguid,disabled,category) VALUES('$name','$desc','$plugin','$properties','$guid','0',$category);")) {
583
+                    if ($insert === true) {
584
+                        $properties = mysqli_real_escape_string($conn, propUpdate($properties, $row['properties']));
585
+                        if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_plugins` (name,description,plugincode,properties,moduleguid,disabled,category) VALUES('$name','$desc','$plugin','$properties','$guid','0',$category);")) {
586 586
                             echo "<p>".mysqli_error($sqlParser->conn)."</p>";
587 587
                             return;
588 588
                         }
589 589
                     }
590
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
590
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
591 591
                 } else {
592 592
                     $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
593
-                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_plugins` (name,description,plugincode,properties,moduleguid,category,disabled) VALUES('$name','$desc','$plugin','$properties','$guid',$category,$disabled);")) {
594
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
593
+                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_plugins` (name,description,plugincode,properties,moduleguid,category,disabled) VALUES('$name','$desc','$plugin','$properties','$guid',$category,$disabled);")) {
594
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
595 595
                         return;
596 596
                     }
597
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
597
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
598 598
                 }
599 599
                 // add system events
600 600
                 if (count($events) > 0) {
601
-                    $ds=mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."site_plugins` WHERE name='$name' AND description='$desc';");
601
+                    $ds = mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."site_plugins` WHERE name='$name' AND description='$desc';");
602 602
                     if ($ds) {
603 603
                         $row = mysqli_fetch_assoc($ds);
604 604
                         $id = $row["id"];
605 605
                         // remove existing events
606
-                        mysqli_query($sqlParser->conn, 'DELETE FROM ' . $dbase . '.`' . $table_prefix . 'site_plugin_events` WHERE pluginid = \'' . $id . '\'');
606
+                        mysqli_query($sqlParser->conn, 'DELETE FROM '.$dbase.'.`'.$table_prefix.'site_plugin_events` WHERE pluginid = \''.$id.'\'');
607 607
                         // add new events
608
-                        mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_plugin_events` (pluginid, evtid) SELECT '$id' as 'pluginid',se.id as 'evtid' FROM $dbase.`" . $table_prefix . "system_eventnames` se WHERE name IN ('" . implode("','", $events) . "')");
608
+                        mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_plugin_events` (pluginid, evtid) SELECT '$id' as 'pluginid',se.id as 'evtid' FROM $dbase.`".$table_prefix."system_eventnames` se WHERE name IN ('".implode("','", $events)."')");
609 609
                     }
610 610
                 }
611 611
             }
@@ -615,18 +615,18 @@  discard block
 block discarded – undo
615 615
 
616 616
 // Install Snippets
617 617
 if (isset ($_POST['snippet']) || $installData) {
618
-    echo "<h3>" . $_lang['snippets'] . ":</h3> ";
618
+    echo "<h3>".$_lang['snippets'].":</h3> ";
619 619
     $selSnips = $_POST['snippet'];
620 620
     foreach ($moduleSnippets as $k=>$moduleSnippet) {
621 621
         $installSample = in_array('sample', $moduleSnippet[5]) && $installData == 1;
622
-        if($installSample || in_array($k, $selSnips)) {
622
+        if ($installSample || in_array($k, $selSnips)) {
623 623
             $name = mysqli_real_escape_string($conn, $moduleSnippet[0]);
624 624
             $desc = mysqli_real_escape_string($conn, $moduleSnippet[1]);
625 625
             $filecontent = $moduleSnippet[2];
626 626
             $properties = $moduleSnippet[3];
627 627
             $category = mysqli_real_escape_string($conn, $moduleSnippet[4]);
628 628
             if (!file_exists($filecontent))
629
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_snippet'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
629
+                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">".$_lang['unable_install_snippet']." '$filecontent' ".$_lang['not_found'].".</span></p>";
630 630
             else {
631 631
 
632 632
                 // Create the category if it does not already exist
@@ -635,22 +635,22 @@  discard block
 block discarded – undo
635 635
                 $snippet = end(preg_split("/(\/\/)?\s*\<\?php/", file_get_contents($filecontent)));
636 636
                 $snippet = removeDocblock($snippet, 'snippet');
637 637
                 $snippet = mysqli_real_escape_string($conn, $snippet);
638
-                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`" . $table_prefix . "site_snippets` WHERE name='$name'");
638
+                $rs = mysqli_query($sqlParser->conn, "SELECT * FROM $dbase.`".$table_prefix."site_snippets` WHERE name='$name'");
639 639
                 if (mysqli_num_rows($rs)) {
640 640
                     $row = mysqli_fetch_assoc($rs);
641
-                    $props = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
642
-                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_snippets` SET snippet='$snippet', description='$desc', properties='$props' WHERE name='$name';")) {
643
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
641
+                    $props = mysqli_real_escape_string($conn, propUpdate($properties, $row['properties']));
642
+                    if (!mysqli_query($sqlParser->conn, "UPDATE $dbase.`".$table_prefix."site_snippets` SET snippet='$snippet', description='$desc', properties='$props' WHERE name='$name';")) {
643
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
644 644
                         return;
645 645
                     }
646
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['upgraded'] . "</span></p>";
646
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['upgraded']."</span></p>";
647 647
                 } else {
648 648
                     $properties = mysqli_real_escape_string($conn, parseProperties($properties, true));
649
-                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`" . $table_prefix . "site_snippets` (name,description,snippet,properties,category) VALUES('$name','$desc','$snippet','$properties',$category);")) {
650
-                        echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
649
+                    if (!mysqli_query($sqlParser->conn, "INSERT INTO $dbase.`".$table_prefix."site_snippets` (name,description,snippet,properties,category) VALUES('$name','$desc','$snippet','$properties',$category);")) {
650
+                        echo "<p>".mysqli_error($sqlParser->conn)."</p>";
651 651
                         return;
652 652
                     }
653
-                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
653
+                    echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">".$_lang['installed']."</span></p>";
654 654
                 }
655 655
             }
656 656
         }
@@ -659,24 +659,24 @@  discard block
 block discarded – undo
659 659
 
660 660
 // Install demo-site
661 661
 if ($installData && $moduleSQLDataFile) {
662
-    echo "<p>" . $_lang['installing_demo_site'];
662
+    echo "<p>".$_lang['installing_demo_site'];
663 663
     $sqlParser->process($moduleSQLDataFile);
664 664
     // display database results
665 665
     if ($sqlParser->installFailed == true) {
666 666
         $errors += 1;
667
-        echo "<span class=\"notok\"><b>" . $_lang['database_alerts'] . "</span></p>";
668
-        echo "<p>" . $_lang['setup_couldnt_install'] . "</p>";
669
-        echo "<p>" . $_lang['installation_error_occured'] . "<br /><br />";
667
+        echo "<span class=\"notok\"><b>".$_lang['database_alerts']."</span></p>";
668
+        echo "<p>".$_lang['setup_couldnt_install']."</p>";
669
+        echo "<p>".$_lang['installation_error_occured']."<br /><br />";
670 670
         for ($i = 0; $i < count($sqlParser->mysqlErrors); $i++) {
671
-            echo "<em>" . $sqlParser->mysqlErrors[$i]["error"] . "</em>" . $_lang['during_execution_of_sql'] . "<span class='mono'>" . strip_tags($sqlParser->mysqlErrors[$i]["sql"]) . "</span>.<hr />";
671
+            echo "<em>".$sqlParser->mysqlErrors[$i]["error"]."</em>".$_lang['during_execution_of_sql']."<span class='mono'>".strip_tags($sqlParser->mysqlErrors[$i]["sql"])."</span>.<hr />";
672 672
         }
673 673
         echo "</p>";
674
-        echo "<p>" . $_lang['some_tables_not_updated'] . "</p>";
674
+        echo "<p>".$_lang['some_tables_not_updated']."</p>";
675 675
         return;
676 676
     } else {
677 677
         $sql = sprintf("SELECT id FROM `%ssite_templates` WHERE templatename='EVO startup - Bootstrap'", $sqlParser->prefix);
678 678
         $rs = mysqli_query($sqlParser->conn, $sql);
679
-        if(mysqli_num_rows($rs)) {
679
+        if (mysqli_num_rows($rs)) {
680 680
             $row = mysqli_fetch_assoc($rs);
681 681
             $sql = sprintf('UPDATE `%ssite_content` SET template=%s WHERE template=4', $sqlParser->prefix, $row['id']);
682 682
             mysqli_query($sqlParser->conn, $sql);
@@ -687,9 +687,9 @@  discard block
 block discarded – undo
687 687
 
688 688
 // Install Dependencies
689 689
 foreach ($moduleDependencies as $dependency) {
690
-	$ds = mysqli_query($sqlParser->conn, 'SELECT id, guid FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_modules` WHERE name="' . $dependency['module'] . '"');
690
+	$ds = mysqli_query($sqlParser->conn, 'SELECT id, guid FROM '.$dbase.'`'.$sqlParser->prefix.'site_modules` WHERE name="'.$dependency['module'].'"');
691 691
 	if (!$ds) {
692
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
692
+		echo "<p>".mysqli_error($sqlParser->conn)."</p>";
693 693
 		return;
694 694
 	} else {
695 695
 		$row = mysqli_fetch_assoc($ds);
@@ -697,37 +697,37 @@  discard block
 block discarded – undo
697 697
 		$moduleGuid = $row["guid"];
698 698
 	}
699 699
 	// get extra id
700
-	$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE ' . $dependency['column'] . '="' . $dependency['name'] . '"');
700
+	$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM '.$dbase.'`'.$sqlParser->prefix.'site_'.$dependency['table'].'` WHERE '.$dependency['column'].'="'.$dependency['name'].'"');
701 701
 	if (!$ds) {
702
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
702
+		echo "<p>".mysqli_error($sqlParser->conn)."</p>";
703 703
 		return;
704 704
 	} else {
705 705
 		$row = mysqli_fetch_assoc($ds);
706 706
 		$extraId = $row["id"];
707 707
 	}
708 708
 	// setup extra as module dependency
709
-	$ds = mysqli_query($sqlParser->conn, 'SELECT module FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type'] . ' LIMIT 1');
709
+	$ds = mysqli_query($sqlParser->conn, 'SELECT module FROM '.$dbase.'`'.$sqlParser->prefix.'site_module_depobj` WHERE module='.$moduleId.' AND resource='.$extraId.' AND type='.$dependency['type'].' LIMIT 1');
710 710
 	if (!$ds) {
711
-		echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
711
+		echo "<p>".mysqli_error($sqlParser->conn)."</p>";
712 712
 		return;
713 713
 	} else {
714 714
 		if (mysqli_num_rows($ds) === 0) {
715
-			mysqli_query($sqlParser->conn, 'INSERT INTO ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` (module, resource, type) VALUES(' . $moduleId . ',' . $extraId . ',' . $dependency['type'] . ')');
716
-			echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_create'] . '</span></p>';
715
+			mysqli_query($sqlParser->conn, 'INSERT INTO '.$dbase.'`'.$sqlParser->prefix.'site_module_depobj` (module, resource, type) VALUES('.$moduleId.','.$extraId.','.$dependency['type'].')');
716
+			echo '<p>&nbsp;&nbsp;'.$dependency['module'].' Module: <span class="ok">'.$_lang['depedency_create'].'</span></p>';
717 717
 		} else {
718
-			mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_module_depobj` SET module = ' . $moduleId . ', resource = ' . $extraId . ', type = ' . $dependency['type'] . ' WHERE module=' . $moduleId . ' AND resource=' . $extraId . ' AND type=' . $dependency['type']);
719
-			echo '<p>&nbsp;&nbsp;' . $dependency['module'] . ' Module: <span class="ok">' . $_lang['depedency_update'] . '</span></p>';
718
+			mysqli_query($sqlParser->conn, 'UPDATE '.$dbase.'`'.$sqlParser->prefix.'site_module_depobj` SET module = '.$moduleId.', resource = '.$extraId.', type = '.$dependency['type'].' WHERE module='.$moduleId.' AND resource='.$extraId.' AND type='.$dependency['type']);
719
+			echo '<p>&nbsp;&nbsp;'.$dependency['module'].' Module: <span class="ok">'.$_lang['depedency_update'].'</span></p>';
720 720
 		}
721 721
 		if ($dependency['type'] == 30 || $dependency['type'] == 40) {
722 722
 			// set extra guid for plugins and snippets
723
-			$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` WHERE id=' . $extraId . ' LIMIT 1');
723
+			$ds = mysqli_query($sqlParser->conn, 'SELECT id FROM '.$dbase.'`'.$sqlParser->prefix.'site_'.$dependency['table'].'` WHERE id='.$extraId.' LIMIT 1');
724 724
 			if (!$ds) {
725
-				echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
725
+				echo "<p>".mysqli_error($sqlParser->conn)."</p>";
726 726
 				return;
727 727
 			} else {
728 728
 				if (mysqli_num_rows($ds) != 0) {
729
-					mysqli_query($sqlParser->conn, 'UPDATE ' . $dbase . '`' . $sqlParser->prefix . 'site_' . $dependency['table'] . '` SET moduleguid = ' . $moduleGuid . ' WHERE id=' . $extraId);
730
-					echo '<p>&nbsp;&nbsp;' . $dependency['name'] . ': <span class="ok">' . $_lang['guid_set'] . '</span></p>';
729
+					mysqli_query($sqlParser->conn, 'UPDATE '.$dbase.'`'.$sqlParser->prefix.'site_'.$dependency['table'].'` SET moduleguid = '.$moduleGuid.' WHERE id='.$extraId);
730
+					echo '<p>&nbsp;&nbsp;'.$dependency['name'].': <span class="ok">'.$_lang['guid_set'].'</span></p>';
731 731
 				}
732 732
 			}
733 733
 		}
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
 
737 737
 // call back function
738 738
 if ($callBackFnc != "")
739
-    $callBackFnc ($sqlParser);
739
+    $callBackFnc($sqlParser);
740 740
 
741 741
 // Setup the MODX API -- needed for the cache processor
742 742
 define('MODX_API_MODE', true);
@@ -771,20 +771,20 @@  discard block
 block discarded – undo
771 771
 }
772 772
 
773 773
 // setup completed!
774
-echo "<p><b>" . $_lang['installation_successful'] . "</b></p>";
775
-echo "<p>" . $_lang['to_log_into_content_manager'] . "</p>";
774
+echo "<p><b>".$_lang['installation_successful']."</b></p>";
775
+echo "<p>".$_lang['to_log_into_content_manager']."</p>";
776 776
 if ($installMode == 0) {
777
-    echo "<p><img src=\"img/ico_info.png\" width=\"40\" height=\"42\" align=\"left\" style=\"margin-right:10px;\" />" . $_lang['installation_note'] . "</p>";
777
+    echo "<p><img src=\"img/ico_info.png\" width=\"40\" height=\"42\" align=\"left\" style=\"margin-right:10px;\" />".$_lang['installation_note']."</p>";
778 778
 } else {
779
-    echo "<p><img src=\"img/ico_info.png\" width=\"40\" height=\"42\" align=\"left\" style=\"margin-right:10px;\" />" . $_lang['upgrade_note'] . "</p>";
779
+    echo "<p><img src=\"img/ico_info.png\" width=\"40\" height=\"42\" align=\"left\" style=\"margin-right:10px;\" />".$_lang['upgrade_note']."</p>";
780 780
 }
781 781
 
782 782
 // Property Update function
783
-function propUpdate($new,$old){
783
+function propUpdate($new, $old){
784 784
     $newArr = parseProperties($new);
785 785
     $oldArr = parseProperties($old);
786
-    foreach ($oldArr as $k => $v){
787
-        if (isset($v['0']['options'])){
786
+    foreach ($oldArr as $k => $v) {
787
+        if (isset($v['0']['options'])) {
788 788
             $oldArr[$k]['0']['options'] = $newArr[$k]['0']['options'];
789 789
         }
790 790
     }
@@ -794,30 +794,30 @@  discard block
 block discarded – undo
794 794
     return $return;
795 795
 }
796 796
 
797
-function parseProperties($propertyString, $json=false) {
798
-    $propertyString = str_replace('{}', '', $propertyString );
799
-    $propertyString = str_replace('} {', ',', $propertyString );
797
+function parseProperties($propertyString, $json = false){
798
+    $propertyString = str_replace('{}', '', $propertyString);
799
+    $propertyString = str_replace('} {', ',', $propertyString);
800 800
 
801
-    if(empty($propertyString)) return array();
802
-    if($propertyString=='{}' || $propertyString=='[]') return array();
801
+    if (empty($propertyString)) return array();
802
+    if ($propertyString == '{}' || $propertyString == '[]') return array();
803 803
 
804 804
     $jsonFormat = isJson($propertyString, true);
805 805
     $property = array();
806 806
     // old format
807
-    if ( $jsonFormat === false) {
808
-        $props= explode('&', $propertyString);
807
+    if ($jsonFormat === false) {
808
+        $props = explode('&', $propertyString);
809 809
         foreach ($props as $prop) {
810 810
             $prop = trim($prop);
811
-            if($prop === '') {
811
+            if ($prop === '') {
812 812
                 continue;
813 813
             }
814 814
 
815 815
             $arr = explode(';', $prop);
816
-            if( ! is_array($arr)) {
816
+            if (!is_array($arr)) {
817 817
                 $arr = array();
818 818
             }
819 819
             $key = explode('=', isset($arr[0]) ? $arr[0] : '');
820
-            if( ! is_array($key) || empty($key[0])) {
820
+            if (!is_array($key) || empty($key[0])) {
821 821
                 continue;
822 822
             }
823 823
 
@@ -841,7 +841,7 @@  discard block
 block discarded – undo
841 841
 
842 842
         }
843 843
     // new json-format
844
-    } else if(!empty($jsonFormat)){
844
+    } else if (!empty($jsonFormat)) {
845 845
         $property = $jsonFormat;
846 846
     }
847 847
     if ($json) {
@@ -851,25 +851,25 @@  discard block
 block discarded – undo
851 851
     return $property;
852 852
 }
853 853
 
854
-function isJson($string, $returnData=false) {
854
+function isJson($string, $returnData = false){
855 855
     $data = json_decode($string, true);
856 856
     return (json_last_error() == JSON_ERROR_NONE) ? ($returnData ? $data : true) : false;
857 857
 }
858 858
 
859
-function getCreateDbCategory($category, $sqlParser) {
859
+function getCreateDbCategory($category, $sqlParser){
860 860
     $dbase = $sqlParser->dbname;
861
-    $dbase = '`' . trim($dbase,'`') . '`';
861
+    $dbase = '`'.trim($dbase, '`').'`';
862 862
     $table_prefix = $sqlParser->prefix;
863 863
     $category_id = 0;
864
-    if(!empty($category)) {
864
+    if (!empty($category)) {
865 865
         $category = mysqli_real_escape_string($sqlParser->conn, $category);
866 866
         $rs = mysqli_query($sqlParser->conn, "SELECT id FROM $dbase.`".$table_prefix."categories` WHERE category = '".$category."'");
867
-        if(mysqli_num_rows($rs) && ($row = mysqli_fetch_assoc($rs))) {
867
+        if (mysqli_num_rows($rs) && ($row = mysqli_fetch_assoc($rs))) {
868 868
             $category_id = $row['id'];
869 869
         } else {
870 870
             $q = "INSERT INTO $dbase.`".$table_prefix."categories` (`category`) VALUES ('{$category}');";
871 871
             $rs = mysqli_query($sqlParser->conn, $q);
872
-            if($rs) {
872
+            if ($rs) {
873 873
                 $category_id = mysqli_insert_id($sqlParser->conn);
874 874
             }
875 875
         }
@@ -878,12 +878,12 @@  discard block
 block discarded – undo
878 878
 }
879 879
 
880 880
 // Remove installer Docblock only from components using plugin FileSource / fileBinding
881
-function removeDocblock($code, $type) {
881
+function removeDocblock($code, $type){
882 882
 
883 883
     $cleaned = preg_replace("/^.*?\/\*\*.*?\*\/\s+/s", '', $code, 1);
884 884
 
885 885
     // Procedure taken from plugin.filesource.php
886
-    switch($type) {
886
+    switch ($type) {
887 887
         case 'snippet':
888 888
             $elm_name = 'snippets';
889 889
             $include = 'return require';
@@ -899,7 +899,7 @@  discard block
 block discarded – undo
899 899
         default:
900 900
             return $cleaned;
901 901
     };
902
-    if(substr(trim($cleaned),0,$count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/')
902
+    if (substr(trim($cleaned), 0, $count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/')
903 903
         return $cleaned;
904 904
 
905 905
     // fileBinding not found - return code incl docblock
Please login to merge, or discard this patch.
Braces   +61 added lines, -38 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if (file_exists(dirname(__FILE__)."/../assets/cache/siteManager.php")) {
3 3
     include_once(dirname(__FILE__)."/../assets/cache/siteManager.php");
4
-}else{
4
+} else {
5 5
     define('MGR_DIR', 'manager');
6 6
 }
7 7
 
@@ -58,13 +58,15 @@  discard block
 block discarded – undo
58 58
 
59 59
 // get base path and url
60 60
 $a = explode("install", str_replace("\\", "/", dirname($_SERVER["PHP_SELF"])));
61
-if (count($a) > 1)
61
+if (count($a) > 1) {
62 62
     array_pop($a);
63
+}
63 64
 $url = implode("install", $a);
64 65
 reset($a);
65 66
 $a = explode("install", str_replace("\\", "/", realpath(dirname(__FILE__))));
66
-if (count($a) > 1)
67
+if (count($a) > 1) {
67 68
     array_pop($a);
69
+}
68 70
 $pth = implode("install", $a);
69 71
 unset ($a);
70 72
 $base_url = $url . (substr($url, -1) != "/" ? "/" : "");
@@ -85,7 +87,9 @@  discard block
 block discarded – undo
85 87
     echo "<span class=\"notok\" style='color:#707070'>".$_lang['setup_database_selection_failed']."</span>".$_lang['setup_database_selection_failed_note']."</p>";
86 88
     $create = true;
87 89
 } else {
88
-	if (function_exists('mysqli_set_charset')) mysqli_set_charset($conn, $database_charset);
90
+	if (function_exists('mysqli_set_charset')) {
91
+	    mysqli_set_charset($conn, $database_charset);
92
+	}
89 93
     mysqli_query($conn, "{$database_connection_method} {$database_connection_charset}");
90 94
     echo '<span class="ok">'.$_lang['ok']."</span></p>";
91 95
 }
@@ -127,7 +131,8 @@  discard block
 block discarded – undo
127 131
 if(!function_exists('parseProperties')) {
128 132
     // parses a resource property string and returns the result as an array
129 133
     // duplicate of method in documentParser class
130
-    function parseProperties($propertyString) {
134
+    function parseProperties($propertyString)
135
+    {
131 136
         $parameter= array ();
132 137
         if (!empty ($propertyString)) {
133 138
             $tmpParams= explode("&", $propertyString);
@@ -135,11 +140,14 @@  discard block
 block discarded – undo
135 140
                 if (strpos($tmpParams[$x], '=', 0)) {
136 141
                     $pTmp= explode("=", $tmpParams[$x]);
137 142
                     $pvTmp= explode(";", trim($pTmp[1]));
138
-                    if ($pvTmp[1] == 'list' && $pvTmp[3] != "")
139
-                        $parameter[trim($pTmp[0])]= $pvTmp[3]; //list default
143
+                    if ($pvTmp[1] == 'list' && $pvTmp[3] != "") {
144
+                                            $parameter[trim($pTmp[0])]= $pvTmp[3];
145
+                    }
146
+                    //list default
140 147
                     else
141
-                        if ($pvTmp[1] != 'list' && $pvTmp[2] != "")
142
-                            $parameter[trim($pTmp[0])]= $pvTmp[2];
148
+                        if ($pvTmp[1] != 'list' && $pvTmp[2] != "") {
149
+                                                    $parameter[trim($pTmp[0])]= $pvTmp[2];
150
+                        }
143 151
                 }
144 152
             }
145 153
         }
@@ -210,7 +218,7 @@  discard block
 block discarded – undo
210 218
 // custom or not
211 219
 if (file_exists(dirname(__FILE__)."/../../assets/cache/siteManager.php")) {
212 220
     $mgrdir = 'include_once(dirname(__FILE__)."/../../assets/cache/siteManager.php");';
213
-}else{
221
+} else {
214 222
     $mgrdir = 'define(\'MGR_DIR\', \'manager\');';
215 223
 }
216 224
 
@@ -346,7 +354,9 @@  discard block
 block discarded – undo
346 354
                         echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
347 355
                         return;
348 356
                     }
349
-                    if(!is_null($save_sql_id_as)) $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
357
+                    if(!is_null($save_sql_id_as)) {
358
+                        $custom_placeholders[$save_sql_id_as] = @mysqli_insert_id($sqlParser->conn);
359
+                    }
350 360
                     echo "<p>&nbsp;&nbsp;$name: <span class=\"ok\">" . $_lang['installed'] . "</span></p>";
351 361
                 }
352 362
             }
@@ -440,9 +450,9 @@  discard block
 block discarded – undo
440 450
             $overwrite = mysqli_real_escape_string($conn, $moduleChunk[4]);
441 451
             $filecontent = $moduleChunk[2];
442 452
 
443
-            if (!file_exists($filecontent))
444
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_chunk'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
445
-            else {
453
+            if (!file_exists($filecontent)) {
454
+                            echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_chunk'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
455
+            } else {
446 456
 
447 457
                 // Create the category if it does not already exist
448 458
                 $category_id = getCreateDbCategory($category, $sqlParser);
@@ -494,9 +504,9 @@  discard block
 block discarded – undo
494 504
             $guid = mysqli_real_escape_string($conn, $moduleModule[4]);
495 505
             $shared = mysqli_real_escape_string($conn, $moduleModule[5]);
496 506
             $category = mysqli_real_escape_string($conn, $moduleModule[6]);
497
-            if (!file_exists($filecontent))
498
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_module'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
499
-            else {
507
+            if (!file_exists($filecontent)) {
508
+                            echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_module'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
509
+            } else {
500 510
 
501 511
                 // Create the category if it does not already exist
502 512
                 $category = getCreateDbCategory($category, $sqlParser);
@@ -546,9 +556,9 @@  discard block
 block discarded – undo
546 556
                 // parse comma-separated legacy names and prepare them for sql IN clause
547 557
                 $leg_names = "'" . implode("','", preg_split('/\s*,\s*/', mysqli_real_escape_string($conn, $modulePlugin[7]))) . "'";
548 558
             }
549
-            if (!file_exists($filecontent))
550
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_plugin'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
551
-            else {
559
+            if (!file_exists($filecontent)) {
560
+                            echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_plugin'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
561
+            } else {
552 562
 
553 563
                 // disable legacy versions based on legacy_names provided
554 564
                 if(!empty($leg_names)) {
@@ -567,7 +577,7 @@  discard block
 block discarded – undo
567 577
                     $insert = true;
568 578
                     while($row = mysqli_fetch_assoc($rs)) {
569 579
                         $props = mysqli_real_escape_string($conn, propUpdate($properties,$row['properties']));
570
-                        if($row['description'] == $desc){
580
+                        if($row['description'] == $desc) {
571 581
                             if (! mysqli_query($sqlParser->conn, "UPDATE $dbase.`" . $table_prefix . "site_plugins` SET plugincode='$plugin', description='$desc', properties='$props' WHERE id={$row['id']};")) {
572 582
                                 echo "<p>" . mysqli_error($sqlParser->conn) . "</p>";
573 583
                                 return;
@@ -625,9 +635,9 @@  discard block
 block discarded – undo
625 635
             $filecontent = $moduleSnippet[2];
626 636
             $properties = $moduleSnippet[3];
627 637
             $category = mysqli_real_escape_string($conn, $moduleSnippet[4]);
628
-            if (!file_exists($filecontent))
629
-                echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_snippet'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
630
-            else {
638
+            if (!file_exists($filecontent)) {
639
+                            echo "<p>&nbsp;&nbsp;$name: <span class=\"notok\">" . $_lang['unable_install_snippet'] . " '$filecontent' " . $_lang['not_found'] . ".</span></p>";
640
+            } else {
631 641
 
632 642
                 // Create the category if it does not already exist
633 643
                 $category = getCreateDbCategory($category, $sqlParser);
@@ -735,13 +745,16 @@  discard block
 block discarded – undo
735 745
 }
736 746
 
737 747
 // call back function
738
-if ($callBackFnc != "")
748
+if ($callBackFnc != "") {
739 749
     $callBackFnc ($sqlParser);
750
+}
740 751
 
741 752
 // Setup the MODX API -- needed for the cache processor
742 753
 define('MODX_API_MODE', true);
743 754
 define('MODX_BASE_PATH', $base_path);
744
-if (!defined('MODX_MANAGER_PATH')) define('MODX_MANAGER_PATH', $base_path.MGR_DIR.'/');
755
+if (!defined('MODX_MANAGER_PATH')) {
756
+    define('MODX_MANAGER_PATH', $base_path.MGR_DIR.'/');
757
+}
745 758
 $database_type = 'mysqli';
746 759
 // initiate a new document parser
747 760
 include_once('../'.MGR_DIR.'/includes/document.parser.class.inc.php');
@@ -780,11 +793,12 @@  discard block
 block discarded – undo
780 793
 }
781 794
 
782 795
 // Property Update function
783
-function propUpdate($new,$old){
796
+function propUpdate($new,$old)
797
+{
784 798
     $newArr = parseProperties($new);
785 799
     $oldArr = parseProperties($old);
786
-    foreach ($oldArr as $k => $v){
787
-        if (isset($v['0']['options'])){
800
+    foreach ($oldArr as $k => $v) {
801
+        if (isset($v['0']['options'])) {
788 802
             $oldArr[$k]['0']['options'] = $newArr[$k]['0']['options'];
789 803
         }
790 804
     }
@@ -794,12 +808,17 @@  discard block
 block discarded – undo
794 808
     return $return;
795 809
 }
796 810
 
797
-function parseProperties($propertyString, $json=false) {
811
+function parseProperties($propertyString, $json=false)
812
+{
798 813
     $propertyString = str_replace('{}', '', $propertyString );
799 814
     $propertyString = str_replace('} {', ',', $propertyString );
800 815
 
801
-    if(empty($propertyString)) return array();
802
-    if($propertyString=='{}' || $propertyString=='[]') return array();
816
+    if(empty($propertyString)) {
817
+        return array();
818
+    }
819
+    if($propertyString=='{}' || $propertyString=='[]') {
820
+        return array();
821
+    }
803 822
 
804 823
     $jsonFormat = isJson($propertyString, true);
805 824
     $property = array();
@@ -841,7 +860,7 @@  discard block
 block discarded – undo
841 860
 
842 861
         }
843 862
     // new json-format
844
-    } else if(!empty($jsonFormat)){
863
+    } else if(!empty($jsonFormat)) {
845 864
         $property = $jsonFormat;
846 865
     }
847 866
     if ($json) {
@@ -851,12 +870,14 @@  discard block
 block discarded – undo
851 870
     return $property;
852 871
 }
853 872
 
854
-function isJson($string, $returnData=false) {
873
+function isJson($string, $returnData=false)
874
+{
855 875
     $data = json_decode($string, true);
856 876
     return (json_last_error() == JSON_ERROR_NONE) ? ($returnData ? $data : true) : false;
857 877
 }
858 878
 
859
-function getCreateDbCategory($category, $sqlParser) {
879
+function getCreateDbCategory($category, $sqlParser)
880
+{
860 881
     $dbase = $sqlParser->dbname;
861 882
     $dbase = '`' . trim($dbase,'`') . '`';
862 883
     $table_prefix = $sqlParser->prefix;
@@ -878,7 +899,8 @@  discard block
 block discarded – undo
878 899
 }
879 900
 
880 901
 // Remove installer Docblock only from components using plugin FileSource / fileBinding
881
-function removeDocblock($code, $type) {
902
+function removeDocblock($code, $type)
903
+{
882 904
 
883 905
     $cleaned = preg_replace("/^.*?\/\*\*.*?\*\/\s+/s", '', $code, 1);
884 906
 
@@ -899,8 +921,9 @@  discard block
 block discarded – undo
899 921
         default:
900 922
             return $cleaned;
901 923
     };
902
-    if(substr(trim($cleaned),0,$count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/')
903
-        return $cleaned;
924
+    if(substr(trim($cleaned),0,$count) == $include.' MODX_BASE_PATH.\'assets/'.$elm_name.'/') {
925
+            return $cleaned;
926
+    }
904 927
 
905 928
     // fileBinding not found - return code incl docblock
906 929
     return $code;
Please login to merge, or discard this patch.
install/setup.info.php 2 patches
Spacing   +62 added lines, -63 removed lines patch added patch discarded remove patch
@@ -1,33 +1,32 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 //:: EVO Installer Setup file
3 3
 //:::::::::::::::::::::::::::::::::::::::::
4
-if (is_file($base_path . 'assets/cache/siteManager.php')) {
5
-    include_once($base_path . 'assets/cache/siteManager.php');
4
+if (is_file($base_path.'assets/cache/siteManager.php')) {
5
+    include_once($base_path.'assets/cache/siteManager.php');
6 6
 }
7
-if(!defined('MGR_DIR')) define('MGR_DIR', 'manager');
7
+if (!defined('MGR_DIR')) define('MGR_DIR', 'manager');
8 8
 
9 9
 require_once('../'.MGR_DIR.'/includes/version.inc.php');
10 10
 
11
-$chunkPath    = $base_path .'install/assets/chunks';
12
-$snippetPath  = $base_path .'install/assets/snippets';
13
-$pluginPath   = $base_path .'install/assets/plugins';
14
-$modulePath   = $base_path .'install/assets/modules';
15
-$templatePath = $base_path .'install/assets/templates';
16
-$tvPath = $base_path .'install/assets/tvs';
11
+$chunkPath    = $base_path.'install/assets/chunks';
12
+$snippetPath  = $base_path.'install/assets/snippets';
13
+$pluginPath   = $base_path.'install/assets/plugins';
14
+$modulePath   = $base_path.'install/assets/modules';
15
+$templatePath = $base_path.'install/assets/templates';
16
+$tvPath = $base_path.'install/assets/tvs';
17 17
 
18 18
 // setup Template template files - array : name, description, type - 0:file or 1:content, parameters, category
19 19
 $mt = &$moduleTemplates;
20
-if(is_dir($templatePath) && is_readable($templatePath)) {
20
+if (is_dir($templatePath) && is_readable($templatePath)) {
21 21
     $d = dir($templatePath);
22 22
     while (false !== ($tplfile = $d->read()))
23 23
     {
24
-        if(substr($tplfile, -4) != '.tpl') continue;
24
+        if (substr($tplfile, -4) != '.tpl') continue;
25 25
         $params = parse_docblock($templatePath, $tplfile);
26
-        if(is_array($params) && (count($params)>0))
26
+        if (is_array($params) && (count($params) > 0))
27 27
         {
28 28
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
29
-            $mt[] = array
30
-            (
29
+            $mt[] = array(
31 30
                 $params['name'],
32 31
                 $description,
33 32
                 // Don't think this is gonna be used ... but adding it just in case 'type'
@@ -45,12 +44,12 @@  discard block
 block discarded – undo
45 44
 
46 45
 // setup Template Variable template files
47 46
 $mtv = &$moduleTVs;
48
-if(is_dir($tvPath) && is_readable($tvPath)) {
47
+if (is_dir($tvPath) && is_readable($tvPath)) {
49 48
     $d = dir($tvPath);
50 49
     while (false !== ($tplfile = $d->read())) {
51
-        if(substr($tplfile, -4) != '.tpl') continue;
50
+        if (substr($tplfile, -4) != '.tpl') continue;
52 51
         $params = parse_docblock($tvPath, $tplfile);
53
-        if(is_array($params) && (count($params)>0)) {
52
+        if (is_array($params) && (count($params) > 0)) {
54 53
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
55 54
             $mtv[] = array(
56 55
                 $params['name'],
@@ -62,9 +61,9 @@  discard block
 block discarded – undo
62 61
                 $params['output_widget'],
63 62
                 $params['output_widget_params'],
64 63
                 "$templatePath/{$params['filename']}", /* not currently used */
65
-                $params['template_assignments']!="*"?$params['template_assignments']:implode(",",array_map(create_function('$v','return $v[0];'),$mt)), /* comma-separated list of template names */
64
+                $params['template_assignments'] != "*" ? $params['template_assignments'] : implode(",", array_map(create_function('$v', 'return $v[0];'), $mt)), /* comma-separated list of template names */
66 65
                 $params['modx_category'],
67
-                $params['lock_tv'],  /* value should be 1 or 0 */
66
+                $params['lock_tv'], /* value should be 1 or 0 */
68 67
                 array_key_exists('installset', $params) ? preg_split("/\s*,\s*/", $params['installset']) : false
69 68
             );
70 69
         }
@@ -74,14 +73,14 @@  discard block
 block discarded – undo
74 73
 
75 74
 // setup chunks template files - array : name, description, type - 0:file or 1:content, file or content
76 75
 $mc = &$moduleChunks;
77
-if(is_dir($chunkPath) && is_readable($chunkPath)) {
76
+if (is_dir($chunkPath) && is_readable($chunkPath)) {
78 77
     $d = dir($chunkPath);
79 78
     while (false !== ($tplfile = $d->read())) {
80
-        if(substr($tplfile, -4) != '.tpl') {
79
+        if (substr($tplfile, -4) != '.tpl') {
81 80
             continue;
82 81
         }
83 82
         $params = parse_docblock($chunkPath, $tplfile);
84
-        if(is_array($params) && count($params) > 0) {
83
+        if (is_array($params) && count($params) > 0) {
85 84
             $mc[] = array(
86 85
                 $params['name'],
87 86
                 $params['description'],
@@ -97,14 +96,14 @@  discard block
 block discarded – undo
97 96
 
98 97
 // setup snippets template files - array : name, description, type - 0:file or 1:content, file or content,properties
99 98
 $ms = &$moduleSnippets;
100
-if(is_dir($snippetPath) && is_readable($snippetPath)) {
99
+if (is_dir($snippetPath) && is_readable($snippetPath)) {
101 100
     $d = dir($snippetPath);
102 101
     while (false !== ($tplfile = $d->read())) {
103
-        if(substr($tplfile, -4) != '.tpl') {
102
+        if (substr($tplfile, -4) != '.tpl') {
104 103
             continue;
105 104
         }
106 105
         $params = parse_docblock($snippetPath, $tplfile);
107
-        if(is_array($params) && count($params) > 0) {
106
+        if (is_array($params) && count($params) > 0) {
108 107
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
109 108
             $ms[] = array(
110 109
                 $params['name'],
@@ -121,14 +120,14 @@  discard block
 block discarded – undo
121 120
 
122 121
 // setup plugins template files - array : name, description, type - 0:file or 1:content, file or content,properties
123 122
 $mp = &$modulePlugins;
124
-if(is_dir($pluginPath) && is_readable($pluginPath)) {
123
+if (is_dir($pluginPath) && is_readable($pluginPath)) {
125 124
     $d = dir($pluginPath);
126 125
     while (false !== ($tplfile = $d->read())) {
127
-        if(substr($tplfile, -4) != '.tpl') {
126
+        if (substr($tplfile, -4) != '.tpl') {
128 127
             continue;
129 128
         }
130 129
         $params = parse_docblock($pluginPath, $tplfile);
131
-        if(is_array($params) && count($params) > 0) {
130
+        if (is_array($params) && count($params) > 0) {
132 131
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
133 132
             $mp[] = array(
134 133
                 $params['name'],
@@ -150,14 +149,14 @@  discard block
 block discarded – undo
150 149
 // setup modules - array : name, description, type - 0:file or 1:content, file or content,properties, guid,enable_sharedparams
151 150
 $mm = &$moduleModules;
152 151
 $mdp = &$moduleDependencies;
153
-if(is_dir($modulePath) && is_readable($modulePath)) {
152
+if (is_dir($modulePath) && is_readable($modulePath)) {
154 153
     $d = dir($modulePath);
155 154
     while (false !== ($tplfile = $d->read())) {
156
-        if(substr($tplfile, -4) != '.tpl') {
155
+        if (substr($tplfile, -4) != '.tpl') {
157 156
             continue;
158 157
         }
159 158
         $params = parse_docblock($modulePath, $tplfile);
160
-        if(is_array($params) && count($params) > 0) {
159
+        if (is_array($params) && count($params) > 0) {
161 160
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
162 161
             $mm[] = array(
163 162
                 $params['name'],
@@ -241,103 +240,103 @@  discard block
 block discarded – undo
241 240
 // setup callback function
242 241
 $callBackFnc = "clean_up";
243 242
 
244
-function clean_up($sqlParser) {
243
+function clean_up($sqlParser){
245 244
     $ids = array();
246 245
 
247 246
     // secure web documents - privateweb
248
-    mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 0 WHERE privateweb = 1");
249
-    $sql =  "SELECT DISTINCT sc.id
247
+    mysqli_query($sqlParser->conn, "UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 0 WHERE privateweb = 1");
248
+    $sql = "SELECT DISTINCT sc.id
250 249
              FROM `".$sqlParser->prefix."site_content` sc
251 250
              LEFT JOIN `".$sqlParser->prefix."document_groups` dg ON dg.document = sc.id
252 251
              LEFT JOIN `".$sqlParser->prefix."webgroup_access` wga ON wga.documentgroup = dg.document_group
253 252
              WHERE wga.id>0";
254
-    $ds = mysqli_query($sqlParser->conn,$sql);
255
-    if(!$ds) {
253
+    $ds = mysqli_query($sqlParser->conn, $sql);
254
+    if (!$ds) {
256 255
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
257 256
     }
258 257
     else {
259
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
260
-        if(count($ids)>0) {
261
-            mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 1 WHERE id IN (".implode(", ",$ids).")");
258
+        while ($r = mysqli_fetch_assoc($ds)) $ids[] = $r["id"];
259
+        if (count($ids) > 0) {
260
+            mysqli_query($sqlParser->conn, "UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 1 WHERE id IN (".implode(", ", $ids).")");
262 261
             unset($ids);
263 262
         }
264 263
     }
265 264
 
266 265
     // secure manager documents privatemgr
267
-    mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 0 WHERE privatemgr = 1");
268
-    $sql =  "SELECT DISTINCT sc.id
266
+    mysqli_query($sqlParser->conn, "UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 0 WHERE privatemgr = 1");
267
+    $sql = "SELECT DISTINCT sc.id
269 268
              FROM `".$sqlParser->prefix."site_content` sc
270 269
              LEFT JOIN `".$sqlParser->prefix."document_groups` dg ON dg.document = sc.id
271 270
              LEFT JOIN `".$sqlParser->prefix."membergroup_access` mga ON mga.documentgroup = dg.document_group
272 271
              WHERE mga.id>0";
273
-    $ds = mysqli_query($sqlParser->conn,$sql);
274
-    if(!$ds) {
272
+    $ds = mysqli_query($sqlParser->conn, $sql);
273
+    if (!$ds) {
275 274
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
276 275
     }
277 276
     else {
278
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
279
-        if(count($ids)>0) {
280
-            mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 1 WHERE id IN (".implode(", ",$ids).")");
277
+        while ($r = mysqli_fetch_assoc($ds)) $ids[] = $r["id"];
278
+        if (count($ids) > 0) {
279
+            mysqli_query($sqlParser->conn, "UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 1 WHERE id IN (".implode(", ", $ids).")");
281 280
             unset($ids);
282 281
         }
283 282
     }
284 283
 }
285 284
 
286
-function parse_docblock($element_dir, $filename) {
285
+function parse_docblock($element_dir, $filename){
287 286
     $params = array();
288
-    $fullpath = $element_dir . '/' . $filename;
289
-    if(is_readable($fullpath)) {
287
+    $fullpath = $element_dir.'/'.$filename;
288
+    if (is_readable($fullpath)) {
290 289
         $tpl = @fopen($fullpath, "r");
291
-        if($tpl) {
290
+        if ($tpl) {
292 291
             $params['filename'] = $filename;
293 292
             $docblock_start_found = false;
294 293
             $name_found = false;
295 294
             $description_found = false;
296 295
 
297
-            while(!feof($tpl)) {
296
+            while (!feof($tpl)) {
298 297
                 $line = fgets($tpl);
299
-                if(!$docblock_start_found) {
298
+                if (!$docblock_start_found) {
300 299
                     // find docblock start
301
-                    if(strpos($line, '/**') !== false) {
300
+                    if (strpos($line, '/**') !== false) {
302 301
                         $docblock_start_found = true;
303 302
                     }
304 303
                     continue;
305
-                } elseif(!$name_found) {
304
+                } elseif (!$name_found) {
306 305
                     // find name
307 306
                     $ma = null;
308
-                    if(preg_match("/^\s+\*\s+(.+)/", $line, $ma)) {
307
+                    if (preg_match("/^\s+\*\s+(.+)/", $line, $ma)) {
309 308
                         $params['name'] = trim($ma[1]);
310 309
                         $name_found = !empty($params['name']);
311 310
                     }
312 311
                     continue;
313
-                } elseif(!$description_found) {
312
+                } elseif (!$description_found) {
314 313
                     // find description
315 314
                     $ma = null;
316
-                    if(preg_match("/^\s+\*\s+(.+)/", $line, $ma)) {
315
+                    if (preg_match("/^\s+\*\s+(.+)/", $line, $ma)) {
317 316
                         $params['description'] = trim($ma[1]);
318 317
                         $description_found = !empty($params['description']);
319 318
                     }
320 319
                     continue;
321 320
                 } else {
322 321
                     $ma = null;
323
-                    if(preg_match("/^\s+\*\s+\@([^\s]+)\s+(.+)/", $line, $ma)) {
322
+                    if (preg_match("/^\s+\*\s+\@([^\s]+)\s+(.+)/", $line, $ma)) {
324 323
                         $param = trim($ma[1]);
325 324
                         $val = trim($ma[2]);
326
-                        if(!empty($param) && !empty($val)) {
327
-                            if($param == 'internal') {
325
+                        if (!empty($param) && !empty($val)) {
326
+                            if ($param == 'internal') {
328 327
                                 $ma = null;
329
-                                if(preg_match("/\@([^\s]+)\s+(.+)/", $val, $ma)) {
328
+                                if (preg_match("/\@([^\s]+)\s+(.+)/", $val, $ma)) {
330 329
                                     $param = trim($ma[1]);
331 330
                                     $val = trim($ma[2]);
332 331
                                 }
333 332
                                 //if($val !== '0' && (empty($param) || empty($val))) {
334
-                                if(empty($param)) {
333
+                                if (empty($param)) {
335 334
                                     continue;
336 335
                                 }
337 336
                             }
338 337
                             $params[$param] = $val;
339 338
                         }
340
-                    } elseif(preg_match("/^\s*\*\/\s*$/", $line)) {
339
+                    } elseif (preg_match("/^\s*\*\/\s*$/", $line)) {
341 340
                         break;
342 341
                     }
343 342
                 }
Please login to merge, or discard this patch.
Braces   +23 added lines, -15 removed lines patch added patch discarded remove patch
@@ -4,7 +4,9 @@  discard block
 block discarded – undo
4 4
 if (is_file($base_path . 'assets/cache/siteManager.php')) {
5 5
     include_once($base_path . 'assets/cache/siteManager.php');
6 6
 }
7
-if(!defined('MGR_DIR')) define('MGR_DIR', 'manager');
7
+if(!defined('MGR_DIR')) {
8
+    define('MGR_DIR', 'manager');
9
+}
8 10
 
9 11
 require_once('../'.MGR_DIR.'/includes/version.inc.php');
10 12
 
@@ -19,12 +21,12 @@  discard block
 block discarded – undo
19 21
 $mt = &$moduleTemplates;
20 22
 if(is_dir($templatePath) && is_readable($templatePath)) {
21 23
     $d = dir($templatePath);
22
-    while (false !== ($tplfile = $d->read()))
23
-    {
24
-        if(substr($tplfile, -4) != '.tpl') continue;
24
+    while (false !== ($tplfile = $d->read())) {
25
+        if(substr($tplfile, -4) != '.tpl') {
26
+            continue;
27
+        }
25 28
         $params = parse_docblock($templatePath, $tplfile);
26
-        if(is_array($params) && (count($params)>0))
27
-        {
29
+        if(is_array($params) && (count($params)>0)) {
28 30
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
29 31
             $mt[] = array
30 32
             (
@@ -48,7 +50,9 @@  discard block
 block discarded – undo
48 50
 if(is_dir($tvPath) && is_readable($tvPath)) {
49 51
     $d = dir($tvPath);
50 52
     while (false !== ($tplfile = $d->read())) {
51
-        if(substr($tplfile, -4) != '.tpl') continue;
53
+        if(substr($tplfile, -4) != '.tpl') {
54
+            continue;
55
+        }
52 56
         $params = parse_docblock($tvPath, $tplfile);
53 57
         if(is_array($params) && (count($params)>0)) {
54 58
             $description = empty($params['version']) ? $params['description'] : "<strong>{$params['version']}</strong> {$params['description']}";
@@ -241,7 +245,8 @@  discard block
 block discarded – undo
241 245
 // setup callback function
242 246
 $callBackFnc = "clean_up";
243 247
 
244
-function clean_up($sqlParser) {
248
+function clean_up($sqlParser)
249
+{
245 250
     $ids = array();
246 251
 
247 252
     // secure web documents - privateweb
@@ -254,9 +259,10 @@  discard block
 block discarded – undo
254 259
     $ds = mysqli_query($sqlParser->conn,$sql);
255 260
     if(!$ds) {
256 261
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
257
-    }
258
-    else {
259
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
262
+    } else {
263
+        while($r = mysqli_fetch_assoc($ds)) {
264
+            $ids[]=$r["id"];
265
+        }
260 266
         if(count($ids)>0) {
261 267
             mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privateweb = 1 WHERE id IN (".implode(", ",$ids).")");
262 268
             unset($ids);
@@ -273,9 +279,10 @@  discard block
 block discarded – undo
273 279
     $ds = mysqli_query($sqlParser->conn,$sql);
274 280
     if(!$ds) {
275 281
         echo "An error occurred while executing a query: ".mysqli_error($sqlParser->conn);
276
-    }
277
-    else {
278
-        while($r = mysqli_fetch_assoc($ds)) $ids[]=$r["id"];
282
+    } else {
283
+        while($r = mysqli_fetch_assoc($ds)) {
284
+            $ids[]=$r["id"];
285
+        }
279 286
         if(count($ids)>0) {
280 287
             mysqli_query($sqlParser->conn,"UPDATE `".$sqlParser->prefix."site_content` SET privatemgr = 1 WHERE id IN (".implode(", ",$ids).")");
281 288
             unset($ids);
@@ -283,7 +290,8 @@  discard block
 block discarded – undo
283 290
     }
284 291
 }
285 292
 
286
-function parse_docblock($element_dir, $filename) {
293
+function parse_docblock($element_dir, $filename)
294
+{
287 295
     $params = array();
288 296
     $fullpath = $element_dir . '/' . $filename;
289 297
     if(is_readable($fullpath)) {
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lib/class_image_imagick.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
   *      @link http://kcfinder.sunhater.com
13 13
   */
14 14
 
15
-class image_imagick extends image {
15
+class image_imagick extends image{
16 16
 
17 17
     static $MIMES = array(
18 18
         //'tif' => "image/tiff"
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
     // ABSTRACT PUBLIC METHODS
23 23
 
24
-    public function resize($width, $height) {//
24
+    public function resize($width, $height){//
25 25
         if (!$width) $width = 1;
26 26
         if (!$height) $height = 1;
27 27
         try {
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         return true;
35 35
     }
36 36
 
37
-    public function resizeFit($width, $height, $background=false) {//
37
+    public function resizeFit($width, $height, $background = false){//
38 38
         if (!$width) $width = 1;
39 39
         if (!$height) $height = 1;
40 40
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
     }
67 67
 
68
-    public function resizeCrop($width, $height, $offset=false) {
68
+    public function resizeCrop($width, $height, $offset = false){
69 69
         if (!$width) $width = 1;
70 70
         if (!$height) $height = 1;
71 71
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         return true;
116 116
     }
117 117
 
118
-    public function rotate($angle, $background="#000000") {
118
+    public function rotate($angle, $background = "#000000"){
119 119
         try {
120 120
             $this->image->rotateImage(new ImagickPixel($background), $angle);
121 121
             $size = $this->image->getImageGeometry();
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         return true;
128 128
     }
129 129
 
130
-    public function flipHorizontal() {
130
+    public function flipHorizontal(){
131 131
         try {
132 132
             $this->image->flopImage();
133 133
         } catch (Exception $e) {
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
         return true;
137 137
     }
138 138
 
139
-    public function flipVertical() {
139
+    public function flipVertical(){
140 140
         try {
141 141
             $this->image->flipImage();
142 142
         } catch (Exception $e) {
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         return true;
146 146
     }
147 147
 
148
-    public function watermark($file, $left=false, $top=false) {
148
+    public function watermark($file, $left = false, $top = false){
149 149
         try {
150 150
             $wm = new Imagick($file);
151 151
             $size = $wm->getImageGeometry();
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 
182 182
     // ABSTRACT PROTECTED METHODS
183 183
 
184
-    protected function getBlankImage($width, $height) {
184
+    protected function getBlankImage($width, $height){
185 185
         try {
186 186
             $img = new Imagick();
187 187
             $img->newImage($width, $height, "none");
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
         return $img;
193 193
     }
194 194
 
195
-    protected function getImage($image, &$width, &$height) {
195
+    protected function getImage($image, &$width, &$height){
196 196
 
197 197
         if (is_object($image) && ($image instanceof image_imagick)) {
198 198
             try {
@@ -234,11 +234,11 @@  discard block
 block discarded – undo
234 234
 
235 235
     // PSEUDO-ABSTRACT STATIC METHODS
236 236
 
237
-    static function available() {
237
+    static function available(){
238 238
         return class_exists("Imagick");
239 239
     }
240 240
 
241
-    static function checkImage($file) {
241
+    static function checkImage($file){
242 242
         try {
243 243
             new Imagick($file);
244 244
         } catch (Exception $e) {
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 
251 251
     // INHERIT METHODS
252 252
 
253
-    public function output($type="jpeg", array $options=array()) {
253
+    public function output($type = "jpeg", array $options = array()){
254 254
         $type = strtolower($type);
255 255
         try {
256 256
             $this->image->setImageFormat($type);
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             echo $this->image;
270 270
 
271 271
         } else {
272
-            $file = $options['file'] . ".$type";
272
+            $file = $options['file'].".$type";
273 273
             try {
274 274
                 $this->image->writeImage($file);
275 275
             } catch (Exception $e) {
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
 
290 290
     // OWN METHODS
291 291
 
292
-    protected function optimize_jpeg(array $options=array()) {
292
+    protected function optimize_jpeg(array $options = array()){
293 293
         $quality = isset($options['quality']) ? $options['quality'] : self::DEFAULT_JPEG_QUALITY;
294 294
         try {
295 295
             $this->image->setImageCompression(Imagick::COMPRESSION_JPEG);
Please login to merge, or discard this patch.
Braces   +81 added lines, -40 removed lines patch added patch discarded remove patch
@@ -12,7 +12,8 @@  discard block
 block discarded – undo
12 12
   *      @link http://kcfinder.sunhater.com
13 13
   */
14 14
 
15
-class image_imagick extends image {
15
+class image_imagick extends image
16
+{
16 17
 
17 18
     static $MIMES = array(
18 19
         //'tif' => "image/tiff"
@@ -21,9 +22,15 @@  discard block
 block discarded – undo
21 22
 
22 23
     // ABSTRACT PUBLIC METHODS
23 24
 
24
-    public function resize($width, $height) {//
25
-        if (!$width) $width = 1;
26
-        if (!$height) $height = 1;
25
+    public function resize($width, $height)
26
+    {
27
+//
28
+        if (!$width) {
29
+            $width = 1;
30
+        }
31
+        if (!$height) {
32
+            $height = 1;
33
+        }
27 34
         try {
28 35
             $this->image->scaleImage($width, $height);
29 36
         } catch (Exception $e) {
@@ -34,9 +41,15 @@  discard block
 block discarded – undo
34 41
         return true;
35 42
     }
36 43
 
37
-    public function resizeFit($width, $height, $background=false) {//
38
-        if (!$width) $width = 1;
39
-        if (!$height) $height = 1;
44
+    public function resizeFit($width, $height, $background=false)
45
+    {
46
+//
47
+        if (!$width) {
48
+            $width = 1;
49
+        }
50
+        if (!$height) {
51
+            $height = 1;
52
+        }
40 53
 
41 54
         try {
42 55
             $this->image->scaleImage($width, $height, true);
@@ -65,43 +78,58 @@  discard block
 block discarded – undo
65 78
         }
66 79
     }
67 80
 
68
-    public function resizeCrop($width, $height, $offset=false) {
69
-        if (!$width) $width = 1;
70
-        if (!$height) $height = 1;
81
+    public function resizeCrop($width, $height, $offset=false)
82
+    {
83
+        if (!$width) {
84
+            $width = 1;
85
+        }
86
+        if (!$height) {
87
+            $height = 1;
88
+        }
71 89
 
72 90
         if (($this->width / $this->height) > ($width / $height)) {
73 91
             $h = $height;
74 92
             $w = ($this->width * $h) / $this->height;
75 93
             $y = 0;
76 94
             if ($offset !== false) {
77
-                if ($offset > 0)
78
-                    $offset = -$offset;
79
-                if (($w + $offset) <= $width)
80
-                    $offset = $width - $w;
95
+                if ($offset > 0) {
96
+                                    $offset = -$offset;
97
+                }
98
+                if (($w + $offset) <= $width) {
99
+                                    $offset = $width - $w;
100
+                }
81 101
                 $x = $offset;
82
-            } else
83
-                $x = ($width - $w) / 2;
102
+            } else {
103
+                            $x = ($width - $w) / 2;
104
+            }
84 105
 
85 106
         } else {
86 107
             $w = $width;
87 108
             $h = ($this->height * $w) / $this->width;
88 109
             $x = 0;
89 110
             if ($offset !== false) {
90
-                if ($offset > 0)
91
-                    $offset = -$offset;
92
-                if (($h + $offset) <= $height)
93
-                    $offset = $height - $h;
111
+                if ($offset > 0) {
112
+                                    $offset = -$offset;
113
+                }
114
+                if (($h + $offset) <= $height) {
115
+                                    $offset = $height - $h;
116
+                }
94 117
                 $y = $offset;
95
-            } else
96
-                $y = ($height - $h) / 2;
118
+            } else {
119
+                            $y = ($height - $h) / 2;
120
+            }
97 121
         }
98 122
 
99 123
         $x = round($x);
100 124
         $y = round($y);
101 125
         $w = round($w);
102 126
         $h = round($h);
103
-        if (!$w) $w = 1;
104
-        if (!$h) $h = 1;
127
+        if (!$w) {
128
+            $w = 1;
129
+        }
130
+        if (!$h) {
131
+            $h = 1;
132
+        }
105 133
 
106 134
         try {
107 135
             $this->image->scaleImage($w, $h);
@@ -115,7 +143,8 @@  discard block
 block discarded – undo
115 143
         return true;
116 144
     }
117 145
 
118
-    public function rotate($angle, $background="#000000") {
146
+    public function rotate($angle, $background="#000000")
147
+    {
119 148
         try {
120 149
             $this->image->rotateImage(new ImagickPixel($background), $angle);
121 150
             $size = $this->image->getImageGeometry();
@@ -127,7 +156,8 @@  discard block
 block discarded – undo
127 156
         return true;
128 157
     }
129 158
 
130
-    public function flipHorizontal() {
159
+    public function flipHorizontal()
160
+    {
131 161
         try {
132 162
             $this->image->flopImage();
133 163
         } catch (Exception $e) {
@@ -136,7 +166,8 @@  discard block
 block discarded – undo
136 166
         return true;
137 167
     }
138 168
 
139
-    public function flipVertical() {
169
+    public function flipVertical()
170
+    {
140 171
         try {
141 172
             $this->image->flipImage();
142 173
         } catch (Exception $e) {
@@ -145,7 +176,8 @@  discard block
 block discarded – undo
145 176
         return true;
146 177
     }
147 178
 
148
-    public function watermark($file, $left=false, $top=false) {
179
+    public function watermark($file, $left=false, $top=false)
180
+    {
149 181
         try {
150 182
             $wm = new Imagick($file);
151 183
             $size = $wm->getImageGeometry();
@@ -167,8 +199,9 @@  discard block
 block discarded – undo
167 199
         if ((($x + $w) > $this->width) ||
168 200
             (($y + $h) > $this->height) ||
169 201
             ($x < 0) || ($y < 0)
170
-        )
171
-            return false;
202
+        ) {
203
+                    return false;
204
+        }
172 205
 
173 206
         try {
174 207
             $this->image->compositeImage($wm, Imagick::COMPOSITE_DEFAULT, $x, $y);
@@ -181,7 +214,8 @@  discard block
 block discarded – undo
181 214
 
182 215
     // ABSTRACT PROTECTED METHODS
183 216
 
184
-    protected function getBlankImage($width, $height) {
217
+    protected function getBlankImage($width, $height)
218
+    {
185 219
         try {
186 220
             $img = new Imagick();
187 221
             $img->newImage($width, $height, "none");
@@ -192,7 +226,8 @@  discard block
 block discarded – undo
192 226
         return $img;
193 227
     }
194 228
 
195
-    protected function getImage($image, &$width, &$height) {
229
+    protected function getImage($image, &$width, &$height)
230
+    {
196 231
 
197 232
         if (is_object($image) && ($image instanceof image_imagick)) {
198 233
             try {
@@ -227,18 +262,21 @@  discard block
 block discarded – undo
227 262
             $height = $size['height'];
228 263
             return $image;
229 264
 
230
-        } else
231
-            return false;
265
+        } else {
266
+                    return false;
267
+        }
232 268
     }
233 269
 
234 270
 
235 271
     // PSEUDO-ABSTRACT STATIC METHODS
236 272
 
237
-    static function available() {
273
+    static function available()
274
+    {
238 275
         return class_exists("Imagick");
239 276
     }
240 277
 
241
-    static function checkImage($file) {
278
+    static function checkImage($file)
279
+    {
242 280
         try {
243 281
             new Imagick($file);
244 282
         } catch (Exception $e) {
@@ -250,7 +288,8 @@  discard block
 block discarded – undo
250 288
 
251 289
     // INHERIT METHODS
252 290
 
253
-    public function output($type="jpeg", array $options=array()) {
291
+    public function output($type="jpeg", array $options=array())
292
+    {
254 293
         $type = strtolower($type);
255 294
         try {
256 295
             $this->image->setImageFormat($type);
@@ -258,8 +297,9 @@  discard block
 block discarded – undo
258 297
             return false;
259 298
         }
260 299
         $method = "optimize_$type";
261
-        if (method_exists($this, $method) && !$this->$method($options))
262
-            return false;
300
+        if (method_exists($this, $method) && !$this->$method($options)) {
301
+                    return false;
302
+        }
263 303
 
264 304
         if (!isset($options['file'])) {
265 305
             if (!headers_sent()) {
@@ -289,7 +329,8 @@  discard block
 block discarded – undo
289 329
 
290 330
     // OWN METHODS
291 331
 
292
-    protected function optimize_jpeg(array $options=array()) {
332
+    protected function optimize_jpeg(array $options=array())
333
+    {
293 334
         $quality = isset($options['quality']) ? $options['quality'] : self::DEFAULT_JPEG_QUALITY;
294 335
         try {
295 336
             $this->image->setImageCompression(Imagick::COMPRESSION_JPEG);
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lib/class_image_gmagick.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
   *      @link http://kcfinder.sunhater.com
13 13
   */
14 14
 
15
-class image_gmagick extends image {
15
+class image_gmagick extends image{
16 16
 
17 17
     static $MIMES = array(
18 18
         //'tif' => "image/tiff"
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
     // ABSTRACT PUBLIC METHODS
23 23
 
24
-    public function resize($width, $height) {//
24
+    public function resize($width, $height){//
25 25
         if (!$width) $width = 1;
26 26
         if (!$height) $height = 1;
27 27
         try {
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         return true;
35 35
     }
36 36
 
37
-    public function resizeFit($width, $height, $background=false) {//
37
+    public function resizeFit($width, $height, $background = false){//
38 38
         if (!$width) $width = 1;
39 39
         if (!$height) $height = 1;
40 40
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         }
70 70
     }
71 71
 
72
-    public function resizeCrop($width, $height, $offset=false) {
72
+    public function resizeCrop($width, $height, $offset = false){
73 73
         if (!$width) $width = 1;
74 74
         if (!$height) $height = 1;
75 75
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         return true;
120 120
     }
121 121
 
122
-    public function rotate($angle, $background="#000000") {
122
+    public function rotate($angle, $background = "#000000"){
123 123
         try {
124 124
             $this->image->rotateImage($background, $angle);
125 125
             $w = $this->image->getImageWidth();
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         return true;
133 133
     }
134 134
 
135
-    public function flipHorizontal() {
135
+    public function flipHorizontal(){
136 136
         try {
137 137
             $this->image->flopImage();
138 138
         } catch (Exception $e) {
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         return true;
142 142
     }
143 143
 
144
-    public function flipVertical() {
144
+    public function flipVertical(){
145 145
         try {
146 146
             $this->image->flipImage();
147 147
         } catch (Exception $e) {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         return true;
151 151
     }
152 152
 
153
-    public function watermark($file, $left=false, $top=false) {
153
+    public function watermark($file, $left = false, $top = false){
154 154
         try {
155 155
             $wm = new Gmagick($file);
156 156
             $w = $wm->getImageWidth();
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
     // ABSTRACT PROTECTED METHODS
187 187
 
188
-    protected function getBlankImage($width, $height) {
188
+    protected function getBlankImage($width, $height){
189 189
         try {
190 190
             $img = new Gmagick();
191 191
             $img->newImage($width, $height, "none");
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
         return $img;
196 196
     }
197 197
 
198
-    protected function getImage($image, &$width, &$height) {
198
+    protected function getImage($image, &$width, &$height){
199 199
 
200 200
         if (is_object($image) && ($image instanceof image_gmagick)) {
201 201
             $width = $image->width;
@@ -232,11 +232,11 @@  discard block
 block discarded – undo
232 232
 
233 233
     // PSEUDO-ABSTRACT STATIC METHODS
234 234
 
235
-    static function available() {
235
+    static function available(){
236 236
         return class_exists("Gmagick");
237 237
     }
238 238
 
239
-    static function checkImage($file) {
239
+    static function checkImage($file){
240 240
         try {
241 241
             new Gmagick($file);
242 242
         } catch (Exception $e) {
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 
249 249
     // INHERIT METHODS
250 250
 
251
-    public function output($type="jpeg", array $options=array()) {
251
+    public function output($type = "jpeg", array $options = array()){
252 252
         $type = strtolower($type);
253 253
         try {
254 254
             $this->image->setImageFormat($type);
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
             echo $this->image;
268 268
 
269 269
         } else {
270
-            $file = $options['file'] . ".$type";
270
+            $file = $options['file'].".$type";
271 271
             try {
272 272
                 $this->image->writeImage($file);
273 273
             } catch (Exception $e) {
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 
288 288
     // OWN METHODS
289 289
 
290
-    protected function optimize_jpeg(array $options=array()) {
290
+    protected function optimize_jpeg(array $options = array()){
291 291
         $quality = isset($options['quality']) ? $options['quality'] : self::DEFAULT_JPEG_QUALITY;
292 292
         try {
293 293
             $this->image->setCompressionQuality($quality);
Please login to merge, or discard this patch.
Braces   +81 added lines, -40 removed lines patch added patch discarded remove patch
@@ -12,7 +12,8 @@  discard block
 block discarded – undo
12 12
   *      @link http://kcfinder.sunhater.com
13 13
   */
14 14
 
15
-class image_gmagick extends image {
15
+class image_gmagick extends image
16
+{
16 17
 
17 18
     static $MIMES = array(
18 19
         //'tif' => "image/tiff"
@@ -21,9 +22,15 @@  discard block
 block discarded – undo
21 22
 
22 23
     // ABSTRACT PUBLIC METHODS
23 24
 
24
-    public function resize($width, $height) {//
25
-        if (!$width) $width = 1;
26
-        if (!$height) $height = 1;
25
+    public function resize($width, $height)
26
+    {
27
+//
28
+        if (!$width) {
29
+            $width = 1;
30
+        }
31
+        if (!$height) {
32
+            $height = 1;
33
+        }
27 34
         try {
28 35
             $this->image->scaleImage($width, $height);
29 36
         } catch (Exception $e) {
@@ -34,9 +41,15 @@  discard block
 block discarded – undo
34 41
         return true;
35 42
     }
36 43
 
37
-    public function resizeFit($width, $height, $background=false) {//
38
-        if (!$width) $width = 1;
39
-        if (!$height) $height = 1;
44
+    public function resizeFit($width, $height, $background=false)
45
+    {
46
+//
47
+        if (!$width) {
48
+            $width = 1;
49
+        }
50
+        if (!$height) {
51
+            $height = 1;
52
+        }
40 53
 
41 54
         try {
42 55
             $this->image->scaleImage($width, $height, true);
@@ -69,43 +82,58 @@  discard block
 block discarded – undo
69 82
         }
70 83
     }
71 84
 
72
-    public function resizeCrop($width, $height, $offset=false) {
73
-        if (!$width) $width = 1;
74
-        if (!$height) $height = 1;
85
+    public function resizeCrop($width, $height, $offset=false)
86
+    {
87
+        if (!$width) {
88
+            $width = 1;
89
+        }
90
+        if (!$height) {
91
+            $height = 1;
92
+        }
75 93
 
76 94
         if (($this->width / $this->height) > ($width / $height)) {
77 95
             $h = $height;
78 96
             $w = ($this->width * $h) / $this->height;
79 97
             $y = 0;
80 98
             if ($offset !== false) {
81
-                if ($offset > 0)
82
-                    $offset = -$offset;
83
-                if (($w + $offset) <= $width)
84
-                    $offset = $width - $w;
99
+                if ($offset > 0) {
100
+                                    $offset = -$offset;
101
+                }
102
+                if (($w + $offset) <= $width) {
103
+                                    $offset = $width - $w;
104
+                }
85 105
                 $x = $offset;
86
-            } else
87
-                $x = ($width - $w) / 2;
106
+            } else {
107
+                            $x = ($width - $w) / 2;
108
+            }
88 109
 
89 110
         } else {
90 111
             $w = $width;
91 112
             $h = ($this->height * $w) / $this->width;
92 113
             $x = 0;
93 114
             if ($offset !== false) {
94
-                if ($offset > 0)
95
-                    $offset = -$offset;
96
-                if (($h + $offset) <= $height)
97
-                    $offset = $height - $h;
115
+                if ($offset > 0) {
116
+                                    $offset = -$offset;
117
+                }
118
+                if (($h + $offset) <= $height) {
119
+                                    $offset = $height - $h;
120
+                }
98 121
                 $y = $offset;
99
-            } else
100
-                $y = ($height - $h) / 2;
122
+            } else {
123
+                            $y = ($height - $h) / 2;
124
+            }
101 125
         }
102 126
 
103 127
         $x = round($x);
104 128
         $y = round($y);
105 129
         $w = round($w);
106 130
         $h = round($h);
107
-        if (!$w) $w = 1;
108
-        if (!$h) $h = 1;
131
+        if (!$w) {
132
+            $w = 1;
133
+        }
134
+        if (!$h) {
135
+            $h = 1;
136
+        }
109 137
 
110 138
         try {
111 139
             $this->image->scaleImage($w, $h);
@@ -119,7 +147,8 @@  discard block
 block discarded – undo
119 147
         return true;
120 148
     }
121 149
 
122
-    public function rotate($angle, $background="#000000") {
150
+    public function rotate($angle, $background="#000000")
151
+    {
123 152
         try {
124 153
             $this->image->rotateImage($background, $angle);
125 154
             $w = $this->image->getImageWidth();
@@ -132,7 +161,8 @@  discard block
 block discarded – undo
132 161
         return true;
133 162
     }
134 163
 
135
-    public function flipHorizontal() {
164
+    public function flipHorizontal()
165
+    {
136 166
         try {
137 167
             $this->image->flopImage();
138 168
         } catch (Exception $e) {
@@ -141,7 +171,8 @@  discard block
 block discarded – undo
141 171
         return true;
142 172
     }
143 173
 
144
-    public function flipVertical() {
174
+    public function flipVertical()
175
+    {
145 176
         try {
146 177
             $this->image->flipImage();
147 178
         } catch (Exception $e) {
@@ -150,7 +181,8 @@  discard block
 block discarded – undo
150 181
         return true;
151 182
     }
152 183
 
153
-    public function watermark($file, $left=false, $top=false) {
184
+    public function watermark($file, $left=false, $top=false)
185
+    {
154 186
         try {
155 187
             $wm = new Gmagick($file);
156 188
             $w = $wm->getImageWidth();
@@ -171,8 +203,9 @@  discard block
 block discarded – undo
171 203
         if ((($x + $w) > $this->width) ||
172 204
             (($y + $h) > $this->height) ||
173 205
             ($x < 0) || ($y < 0)
174
-        )
175
-            return false;
206
+        ) {
207
+                    return false;
208
+        }
176 209
 
177 210
         try {
178 211
             $this->image->compositeImage($wm, 1, $x, $y);
@@ -185,7 +218,8 @@  discard block
 block discarded – undo
185 218
 
186 219
     // ABSTRACT PROTECTED METHODS
187 220
 
188
-    protected function getBlankImage($width, $height) {
221
+    protected function getBlankImage($width, $height)
222
+    {
189 223
         try {
190 224
             $img = new Gmagick();
191 225
             $img->newImage($width, $height, "none");
@@ -195,7 +229,8 @@  discard block
 block discarded – undo
195 229
         return $img;
196 230
     }
197 231
 
198
-    protected function getImage($image, &$width, &$height) {
232
+    protected function getImage($image, &$width, &$height)
233
+    {
199 234
 
200 235
         if (is_object($image) && ($image instanceof image_gmagick)) {
201 236
             $width = $image->width;
@@ -225,18 +260,21 @@  discard block
 block discarded – undo
225 260
             $height = $h;
226 261
             return $image;
227 262
 
228
-        } else
229
-            return false;
263
+        } else {
264
+                    return false;
265
+        }
230 266
     }
231 267
 
232 268
 
233 269
     // PSEUDO-ABSTRACT STATIC METHODS
234 270
 
235
-    static function available() {
271
+    static function available()
272
+    {
236 273
         return class_exists("Gmagick");
237 274
     }
238 275
 
239
-    static function checkImage($file) {
276
+    static function checkImage($file)
277
+    {
240 278
         try {
241 279
             new Gmagick($file);
242 280
         } catch (Exception $e) {
@@ -248,7 +286,8 @@  discard block
 block discarded – undo
248 286
 
249 287
     // INHERIT METHODS
250 288
 
251
-    public function output($type="jpeg", array $options=array()) {
289
+    public function output($type="jpeg", array $options=array())
290
+    {
252 291
         $type = strtolower($type);
253 292
         try {
254 293
             $this->image->setImageFormat($type);
@@ -256,8 +295,9 @@  discard block
 block discarded – undo
256 295
             return false;
257 296
         }
258 297
         $method = "optimize_$type";
259
-        if (method_exists($this, $method) && !$this->$method($options))
260
-            return false;
298
+        if (method_exists($this, $method) && !$this->$method($options)) {
299
+                    return false;
300
+        }
261 301
 
262 302
         if (!isset($options['file'])) {
263 303
             if (!headers_sent()) {
@@ -287,7 +327,8 @@  discard block
 block discarded – undo
287 327
 
288 328
     // OWN METHODS
289 329
 
290
-    protected function optimize_jpeg(array $options=array()) {
330
+    protected function optimize_jpeg(array $options=array())
331
+    {
291 332
         $quality = isset($options['quality']) ? $options['quality'] : self::DEFAULT_JPEG_QUALITY;
292 333
         try {
293 334
             $this->image->setCompressionQuality($quality);
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/lib/class_fastImage.php 2 patches
Indentation   +218 added lines, -218 removed lines patch added patch discarded remove patch
@@ -13,227 +13,227 @@
 block discarded – undo
13 13
 
14 14
 class fastImage
15 15
 {
16
-	private $strpos = 0;
17
-	private $str;
18
-	private $uri;
19
-	private $type;
20
-	private $handle;
16
+    private $strpos = 0;
17
+    private $str;
18
+    private $uri;
19
+    private $type;
20
+    private $handle;
21 21
 
22
-	public function __construct($uri = null)
23
-	{
24
-		if ($uri) $this->load($uri);
25
-	}
22
+    public function __construct($uri = null)
23
+    {
24
+        if ($uri) $this->load($uri);
25
+    }
26 26
 
27 27
 
28
-	public function load($uri)
29
-	{
30
-		if ($this->handle) $this->close();
31
-
32
-		$this->uri = $uri;
33
-		$this->handle = fopen($uri, 'r');
34
-	}
35
-
36
-
37
-	public function close()
38
-	{
39
-		if (is_resource($this->handle)) fclose($this->handle);
40
-	}
28
+    public function load($uri)
29
+    {
30
+        if ($this->handle) $this->close();
31
+
32
+        $this->uri = $uri;
33
+        $this->handle = fopen($uri, 'r');
34
+    }
35
+
36
+
37
+    public function close()
38
+    {
39
+        if (is_resource($this->handle)) fclose($this->handle);
40
+    }
41 41
 
42 42
 
43
-	public function getSize()
44
-	{
45
-		$this->strpos = 0;
46
-		if ($this->getType())
47
-		{
48
-			return array_values($this->parseSize());
49
-		}
50
-
51
-		return false;
52
-	}
53
-
54
-
55
-	public function getType()
56
-	{
57
-		$this->strpos = 0;
58
-
59
-		if (!$this->type)
60
-		{
61
-			switch ($this->getChars(2))
62
-			{
63
-				case "BM":
64
-					return $this->type = 'bmp';
65
-				case "GI":
66
-					return $this->type = 'gif';
67
-				case chr(0xFF).chr(0xd8):
68
-					return $this->type = 'jpeg';
69
-				case chr(0x89).'P':
70
-					return $this->type = 'png';
71
-				default:
72
-					return false;
73
-			}
74
-		}
75
-
76
-		return $this->type;
77
-	}
78
-
79
-
80
-	private function parseSize()
81
-	{
82
-		$this->strpos = 0;
83
-
84
-		switch ($this->type)
85
-		{
86
-			case 'png':
87
-				return $this->parseSizeForPNG();
88
-			case 'gif':
89
-				return $this->parseSizeForGIF();
90
-			case 'bmp':
91
-				return $this->parseSizeForBMP();
92
-			case 'jpeg':
93
-				return $this->parseSizeForJPEG();
94
-		}
95
-
96
-		return null;
97
-	}
98
-
99
-
100
-	private function parseSizeForPNG()
101
-	{
102
-		$chars = $this->getChars(25);
103
-
104
-		return unpack("N*", substr($chars, 16, 8));
105
-	}
106
-
107
-
108
-	private function parseSizeForGIF()
109
-	{
110
-		$chars = $this->getChars(11);
111
-
112
-		return unpack("S*", substr($chars, 6, 4));
113
-	}
114
-
115
-
116
-	private function parseSizeForBMP()
117
-	{
118
-		$chars = $this->getChars(29);
119
-	 	$chars = substr($chars, 14, 14);
120
-		$type = unpack('C', $chars);
121
-
122
-		return (reset($type) == 40) ? unpack('L*', substr($chars, 4)) : unpack('L*', substr($chars, 4, 8));
123
-	}
124
-
125
-
126
-	private function parseSizeForJPEG()
127
-	{
128
-		$state = null;
129
-
130
-		while (true)
131
-		{
132
-			switch ($state)
133
-			{
134
-				default:
135
-					$this->getChars(2);
136
-					$state = 'started';
137
-					break;
138
-
139
-				case 'started':
140
-					$b = $this->getByte();
141
-					if ($b === false) return false;
142
-
143
-					$state = $b == 0xFF ? 'sof' : 'started';
144
-					break;
145
-
146
-				case 'sof':
147
-					$b = $this->getByte();
148
-					if (in_array($b, range(0xe0, 0xef)))
149
-					{
150
-						$state = 'skipframe';
151
-					}
152
-					elseif (in_array($b, array_merge(range(0xC0,0xC3), range(0xC5,0xC7), range(0xC9,0xCB), range(0xCD,0xCF))))
153
-					{
154
-						$state = 'readsize';
155
-					}
156
-					elseif ($b == 0xFF)
157
-					{
158
-						$state = 'sof';
159
-					}
160
-					else
161
-					{
162
-						$state = 'skipframe';
163
-					}
164
-					break;
165
-
166
-				case 'skipframe':
167
-					$skip = $this->readInt($this->getChars(2)) - 2;
168
-					$state = 'doskip';
169
-					break;
170
-
171
-				case 'doskip':
172
-					$this->getChars($skip);
173
-					$state = 'started';
174
-					break;
175
-
176
-				case 'readsize':
177
-					$c = $this->getChars(7);
178
-
179
-					return array($this->readInt(substr($c, 5, 2)), $this->readInt(substr($c, 3, 2)));
180
-			}
181
-		}
182
-	}
183
-
184
-
185
-	private function getChars($n)
186
-	{
187
-		$response = null;
188
-
189
-		// do we need more data?
190
-		if ($this->strpos + $n -1 >= strlen($this->str))
191
-		{
192
-			$end = ($this->strpos + $n);
193
-
194
-			while (strlen($this->str) < $end && $response !== false)
195
-			{
196
-				// read more from the file handle
197
-				$need = $end - ftell($this->handle);
198
-
199
-				if ($response = fread($this->handle, $need))
200
-				{
201
-					$this->str .= $response;
202
-				}
203
-				else
204
-				{
205
-					return false;
206
-				}
207
-			}
208
-		}
209
-
210
-		$result = substr($this->str, $this->strpos, $n);
211
-		$this->strpos += $n;
212
-
213
-		// we are dealing with bytes here, so force the encoding
214
-		return mb_convert_encoding($result, "8BIT");
215
-	}
216
-
217
-
218
-	private function getByte()
219
-	{
220
-		$c = $this->getChars(1);
221
-		$b = unpack("C", $c);
222
-
223
-		return reset($b);
224
-	}
225
-
226
-
227
-	private function readInt($str)
228
-	{
229
-		$size = unpack("C*", $str);
230
-
231
-	    	return ($size[1] << 8) + $size[2];
232
-	}
233
-
234
-
235
-	public function __destruct()
236
-	{
237
-		$this->close();
238
-	}
43
+    public function getSize()
44
+    {
45
+        $this->strpos = 0;
46
+        if ($this->getType())
47
+        {
48
+            return array_values($this->parseSize());
49
+        }
50
+
51
+        return false;
52
+    }
53
+
54
+
55
+    public function getType()
56
+    {
57
+        $this->strpos = 0;
58
+
59
+        if (!$this->type)
60
+        {
61
+            switch ($this->getChars(2))
62
+            {
63
+                case "BM":
64
+                    return $this->type = 'bmp';
65
+                case "GI":
66
+                    return $this->type = 'gif';
67
+                case chr(0xFF).chr(0xd8):
68
+                    return $this->type = 'jpeg';
69
+                case chr(0x89).'P':
70
+                    return $this->type = 'png';
71
+                default:
72
+                    return false;
73
+            }
74
+        }
75
+
76
+        return $this->type;
77
+    }
78
+
79
+
80
+    private function parseSize()
81
+    {
82
+        $this->strpos = 0;
83
+
84
+        switch ($this->type)
85
+        {
86
+            case 'png':
87
+                return $this->parseSizeForPNG();
88
+            case 'gif':
89
+                return $this->parseSizeForGIF();
90
+            case 'bmp':
91
+                return $this->parseSizeForBMP();
92
+            case 'jpeg':
93
+                return $this->parseSizeForJPEG();
94
+        }
95
+
96
+        return null;
97
+    }
98
+
99
+
100
+    private function parseSizeForPNG()
101
+    {
102
+        $chars = $this->getChars(25);
103
+
104
+        return unpack("N*", substr($chars, 16, 8));
105
+    }
106
+
107
+
108
+    private function parseSizeForGIF()
109
+    {
110
+        $chars = $this->getChars(11);
111
+
112
+        return unpack("S*", substr($chars, 6, 4));
113
+    }
114
+
115
+
116
+    private function parseSizeForBMP()
117
+    {
118
+        $chars = $this->getChars(29);
119
+            $chars = substr($chars, 14, 14);
120
+        $type = unpack('C', $chars);
121
+
122
+        return (reset($type) == 40) ? unpack('L*', substr($chars, 4)) : unpack('L*', substr($chars, 4, 8));
123
+    }
124
+
125
+
126
+    private function parseSizeForJPEG()
127
+    {
128
+        $state = null;
129
+
130
+        while (true)
131
+        {
132
+            switch ($state)
133
+            {
134
+                default:
135
+                    $this->getChars(2);
136
+                    $state = 'started';
137
+                    break;
138
+
139
+                case 'started':
140
+                    $b = $this->getByte();
141
+                    if ($b === false) return false;
142
+
143
+                    $state = $b == 0xFF ? 'sof' : 'started';
144
+                    break;
145
+
146
+                case 'sof':
147
+                    $b = $this->getByte();
148
+                    if (in_array($b, range(0xe0, 0xef)))
149
+                    {
150
+                        $state = 'skipframe';
151
+                    }
152
+                    elseif (in_array($b, array_merge(range(0xC0,0xC3), range(0xC5,0xC7), range(0xC9,0xCB), range(0xCD,0xCF))))
153
+                    {
154
+                        $state = 'readsize';
155
+                    }
156
+                    elseif ($b == 0xFF)
157
+                    {
158
+                        $state = 'sof';
159
+                    }
160
+                    else
161
+                    {
162
+                        $state = 'skipframe';
163
+                    }
164
+                    break;
165
+
166
+                case 'skipframe':
167
+                    $skip = $this->readInt($this->getChars(2)) - 2;
168
+                    $state = 'doskip';
169
+                    break;
170
+
171
+                case 'doskip':
172
+                    $this->getChars($skip);
173
+                    $state = 'started';
174
+                    break;
175
+
176
+                case 'readsize':
177
+                    $c = $this->getChars(7);
178
+
179
+                    return array($this->readInt(substr($c, 5, 2)), $this->readInt(substr($c, 3, 2)));
180
+            }
181
+        }
182
+    }
183
+
184
+
185
+    private function getChars($n)
186
+    {
187
+        $response = null;
188
+
189
+        // do we need more data?
190
+        if ($this->strpos + $n -1 >= strlen($this->str))
191
+        {
192
+            $end = ($this->strpos + $n);
193
+
194
+            while (strlen($this->str) < $end && $response !== false)
195
+            {
196
+                // read more from the file handle
197
+                $need = $end - ftell($this->handle);
198
+
199
+                if ($response = fread($this->handle, $need))
200
+                {
201
+                    $this->str .= $response;
202
+                }
203
+                else
204
+                {
205
+                    return false;
206
+                }
207
+            }
208
+        }
209
+
210
+        $result = substr($this->str, $this->strpos, $n);
211
+        $this->strpos += $n;
212
+
213
+        // we are dealing with bytes here, so force the encoding
214
+        return mb_convert_encoding($result, "8BIT");
215
+    }
216
+
217
+
218
+    private function getByte()
219
+    {
220
+        $c = $this->getChars(1);
221
+        $b = unpack("C", $c);
222
+
223
+        return reset($b);
224
+    }
225
+
226
+
227
+    private function readInt($str)
228
+    {
229
+        $size = unpack("C*", $str);
230
+
231
+            return ($size[1] << 8) + $size[2];
232
+    }
233
+
234
+
235
+    public function __destruct()
236
+    {
237
+        $this->close();
238
+    }
239 239
 }
Please login to merge, or discard this patch.
Braces   +26 added lines, -36 removed lines patch added patch discarded remove patch
@@ -21,13 +21,17 @@  discard block
 block discarded – undo
21 21
 
22 22
 	public function __construct($uri = null)
23 23
 	{
24
-		if ($uri) $this->load($uri);
24
+		if ($uri) {
25
+		    $this->load($uri);
26
+		}
25 27
 	}
26 28
 
27 29
 
28 30
 	public function load($uri)
29 31
 	{
30
-		if ($this->handle) $this->close();
32
+		if ($this->handle) {
33
+		    $this->close();
34
+		}
31 35
 
32 36
 		$this->uri = $uri;
33 37
 		$this->handle = fopen($uri, 'r');
@@ -36,15 +40,16 @@  discard block
 block discarded – undo
36 40
 
37 41
 	public function close()
38 42
 	{
39
-		if (is_resource($this->handle)) fclose($this->handle);
43
+		if (is_resource($this->handle)) {
44
+		    fclose($this->handle);
45
+		}
40 46
 	}
41 47
 
42 48
 
43 49
 	public function getSize()
44 50
 	{
45 51
 		$this->strpos = 0;
46
-		if ($this->getType())
47
-		{
52
+		if ($this->getType()) {
48 53
 			return array_values($this->parseSize());
49 54
 		}
50 55
 
@@ -56,10 +61,8 @@  discard block
 block discarded – undo
56 61
 	{
57 62
 		$this->strpos = 0;
58 63
 
59
-		if (!$this->type)
60
-		{
61
-			switch ($this->getChars(2))
62
-			{
64
+		if (!$this->type) {
65
+			switch ($this->getChars(2)) {
63 66
 				case "BM":
64 67
 					return $this->type = 'bmp';
65 68
 				case "GI":
@@ -81,8 +84,7 @@  discard block
 block discarded – undo
81 84
 	{
82 85
 		$this->strpos = 0;
83 86
 
84
-		switch ($this->type)
85
-		{
87
+		switch ($this->type) {
86 88
 			case 'png':
87 89
 				return $this->parseSizeForPNG();
88 90
 			case 'gif':
@@ -127,10 +129,8 @@  discard block
 block discarded – undo
127 129
 	{
128 130
 		$state = null;
129 131
 
130
-		while (true)
131
-		{
132
-			switch ($state)
133
-			{
132
+		while (true) {
133
+			switch ($state) {
134 134
 				default:
135 135
 					$this->getChars(2);
136 136
 					$state = 'started';
@@ -138,27 +138,22 @@  discard block
 block discarded – undo
138 138
 
139 139
 				case 'started':
140 140
 					$b = $this->getByte();
141
-					if ($b === false) return false;
141
+					if ($b === false) {
142
+					    return false;
143
+					}
142 144
 
143 145
 					$state = $b == 0xFF ? 'sof' : 'started';
144 146
 					break;
145 147
 
146 148
 				case 'sof':
147 149
 					$b = $this->getByte();
148
-					if (in_array($b, range(0xe0, 0xef)))
149
-					{
150
+					if (in_array($b, range(0xe0, 0xef))) {
150 151
 						$state = 'skipframe';
151
-					}
152
-					elseif (in_array($b, array_merge(range(0xC0,0xC3), range(0xC5,0xC7), range(0xC9,0xCB), range(0xCD,0xCF))))
153
-					{
152
+					} elseif (in_array($b, array_merge(range(0xC0,0xC3), range(0xC5,0xC7), range(0xC9,0xCB), range(0xCD,0xCF)))) {
154 153
 						$state = 'readsize';
155
-					}
156
-					elseif ($b == 0xFF)
157
-					{
154
+					} elseif ($b == 0xFF) {
158 155
 						$state = 'sof';
159
-					}
160
-					else
161
-					{
156
+					} else {
162 157
 						$state = 'skipframe';
163 158
 					}
164 159
 					break;
@@ -187,21 +182,16 @@  discard block
 block discarded – undo
187 182
 		$response = null;
188 183
 
189 184
 		// do we need more data?
190
-		if ($this->strpos + $n -1 >= strlen($this->str))
191
-		{
185
+		if ($this->strpos + $n -1 >= strlen($this->str)) {
192 186
 			$end = ($this->strpos + $n);
193 187
 
194
-			while (strlen($this->str) < $end && $response !== false)
195
-			{
188
+			while (strlen($this->str) < $end && $response !== false) {
196 189
 				// read more from the file handle
197 190
 				$need = $end - ftell($this->handle);
198 191
 
199
-				if ($response = fread($this->handle, $need))
200
-				{
192
+				if ($response = fread($this->handle, $need)) {
201 193
 					$this->str .= $response;
202
-				}
203
-				else
204
-				{
194
+				} else {
205 195
 					return false;
206 196
 				}
207 197
 			}
Please login to merge, or discard this patch.
manager/media/browser/mcpuk/core/autoload.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 $modx = new DocumentParser;
27 27
 $modx->db->connect();
28 28
 startCMSSession();
29
-if(!isset($_SESSION['mgrValidated'])) {
29
+if (!isset($_SESSION['mgrValidated'])) {
30 30
         die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
31 31
 }
32 32
 define('IN_MANAGER_MODE', true);
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
 $manager_language = $modx->config['manager_language'];
36 36
 // Pass language code from MODX to KCFinder
37
-if(!file_exists("../../../includes/lang/".$manager_language.".inc.php")) {
37
+if (!file_exists("../../../includes/lang/".$manager_language.".inc.php")) {
38 38
     $manager_language = "english"; // if not set, get the english language file.
39 39
 }
40 40
 include_once "../../../includes/lang/".$manager_language.".inc.php";
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
 // PHP VERSION CHECK
44 44
 if (substr(PHP_VERSION, 0, strpos(PHP_VERSION, '.')) < 5)
45
-    die("You are using PHP " . PHP_VERSION . " when KCFinder require at least version 5! Some systems has an option to change the active PHP version. Please refer to your hosting provider or upgrade your PHP distribution.");
45
+    die("You are using PHP ".PHP_VERSION." when KCFinder require at least version 5! Some systems has an option to change the active PHP version. Please refer to your hosting provider or upgrade your PHP distribution.");
46 46
 
47 47
 
48 48
 // SAFE MODE CHECK
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
 
53 53
 // MAGIC AUTOLOAD CLASSES FUNCTION
54
-function autoloadda9d06472ccb71b84928677ce2a6ca89($class) {
54
+function autoloadda9d06472ccb71b84928677ce2a6ca89($class){
55 55
     static $classes = null;
56 56
     if ($classes === null) {
57 57
         $classes = array(
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         );
76 76
     }
77 77
     if (isset($classes[$class])) {
78
-        require dirname(__FILE__) . $classes[$class];
78
+        require dirname(__FILE__).$classes[$class];
79 79
     }
80 80
 }
81 81
 spl_autoload_register('autoloadda9d06472ccb71b84928677ce2a6ca89', true);
@@ -84,18 +84,18 @@  discard block
 block discarded – undo
84 84
 // json_encode() IMPLEMENTATION IF JSON EXTENSION IS MISSING
85 85
 if (!function_exists("json_encode")) {
86 86
 
87
-    function kcfinder_json_string_encode($string) {
88
-        return '"' .
87
+    function kcfinder_json_string_encode($string){
88
+        return '"'.
89 89
             str_replace('/', "\\/",
90 90
             str_replace("\t", "\\t",
91 91
             str_replace("\r", "\\r",
92 92
             str_replace("\n", "\\n",
93 93
             str_replace('"', "\\\"",
94 94
             str_replace("\\", "\\\\",
95
-        $string)))))) . '"';
95
+        $string)))))).'"';
96 96
     }
97 97
 
98
-    function json_encode($data) {
98
+    function json_encode($data){
99 99
 
100 100
         if (is_array($data)) {
101 101
             $ret = array();
@@ -103,14 +103,14 @@  discard block
 block discarded – undo
103 103
             // OBJECT
104 104
             if (array_keys($data) !== range(0, count($data) - 1)) {
105 105
                 foreach ($data as $key => $val)
106
-                    $ret[] = kcfinder_json_string_encode($key) . ':' . json_encode($val);
107
-                return "{" . implode(",", $ret) . "}";
106
+                    $ret[] = kcfinder_json_string_encode($key).':'.json_encode($val);
107
+                return "{".implode(",", $ret)."}";
108 108
 
109 109
             // ARRAY
110 110
             } else {
111 111
                 foreach ($data as $val)
112 112
                     $ret[] = json_encode($val);
113
-                return "[" . implode(",", $ret) . "]";
113
+                return "[".implode(",", $ret)."]";
114 114
             }
115 115
 
116 116
         // BOOLEAN OR NULL
Please login to merge, or discard this patch.