Menu::drawSub() - Code Metrics - Inspection of "Refactoring" - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#716)

by Agel_Nash

created 2018-06-07 21:32 UTC

Menu::drawSub() C

↳ Parent: Menu

Complexity

Conditions	14
Paths	6

Size

Total Lines	73
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	14
eloc	50
nc	6
nop	2
dl	0
loc	73
rs	5.4367
c	0
b	0
f	0

How to fix Long Method Complexity

<?php namespace EvolutionCMS\Support;

/**
 * menu->Build('id','parent','name','link','alt','onclick','permission','target','divider 1/0','menuindex')
 */

use EvolutionCMS\Interfaces\MenuInterface;

class Menu implements MenuInterface
{
    /**
     * @var array
     */
    public $defaults = array();
    /**
     * @var
     */
    public $menu;
    /**
     * @var
     */
    public $output;

    /**
     * @param $menu
     * @param array $setting
     */
    public function build($menu, $setting = array())
    {
        $this->defaults['outerClass'] = 'nav';
        $this->defaults['parentClass'] = 'dropdown';
        $this->defaults['parentLinkClass'] = 'dropdown-toggle';
        $this->defaults['parentLinkAttr'] = 'data-toggle="dropdown"';
        $this->defaults['parentLinkIn'] = '<b class="caret"></b>';
        $this->defaults['innerClass'] = 'subnav';

        $this->defaults = $setting + $this->defaults;
        $this->structurise($menu);
        $this->output = $this->drawSub('main', 0);
        echo $this->output;
    }

    /**
     * @param array $menu
     */
    public function structurise($menu)
    {
        $new = array();
        foreach ($menu as $key => $row) {
            $data[$key] = $row[9];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        array_multisort($data, SORT_ASC, $menu);

        foreach ($menu as $key => $value) {
            $new[$value[1]][] = $value;
        }

        $this->menu = $new;
    }

    /**
     * @param int $parentid
     * @param int $level
     * @return string
     */
    public function drawSub($parentid, $level)
    {
        $modx = evolutionCMS();

        $output = '';

        if (isset($this->menu[$parentid])) {

            $ph = array();

            $countChild = 0;
            $itemTpl = '
			<li id="[+id+]" class="[+li_class+]"><a href="[+href+]" alt="[+alt+]" target="[+target+]" onclick="[+onclick+]"[+a_class+] [+LinkAttr+]>[+itemName+]</a>[+DrawSub+]</li>';
            $outerTpl = '<ul id="[+id+]" class="[+class+]">[+output+]</ul>';
            foreach ($this->menu[$parentid] as $key => $value) {
                if ($value[6] !== '') {
                    $permissions = explode(',', $value[6]);
                    foreach ($permissions as $val) {
                        if (!$modx->hasPermission($val)) {
                            continue;
                        }
                    }
                }

                $countChild++;
                $id = $value[0];
                $ph['id'] = $id;
                $ph['li_class'] = $this->getItemClass($id) . $value[10];
                $ph['href'] = $value[3];
                $ph['alt'] = $value[4];
                $ph['target'] = $value[7];
                $ph['onclick'] = $value[5];
                $ph['a_class'] = $this->getLinkClass($id);
                $ph['LinkAttr'] = $this->getLinkAttr($id);
                $ph['itemName'] = $value[2] . $this->getItemName($id);

                $ph['DrawSub'] = '';

                if (isset($this->menu[$id])) {
                    $level++;
                    $ph['DrawSub'] = $this->drawSub($id, $level);
                    $level--;
                    // Optional buttons
                } else {
                    if (isset($value[11]) && !empty($value[11])) {
                        $optionalButton = '';
                        if (is_array($value[11])) {
                            foreach ($value[11] as $opt) {
                                $optionalButton .= sprintf('<%s href="%s" class="%s" onclick="%s" title="%s">%s</%s>',
                                    $opt[0], $opt[1], $opt[2], $opt[3], $opt[4], $opt[5], $opt[0]);
                            }
                        } else {
                            $opt = $value[11];
                            $optionalButton = sprintf('<%s href="%s" class="%s" onclick="%s" title="%s">%s</%s>',
                                $opt[0], $opt[1], $opt[2], $opt[3], $opt[4], $opt[5], $opt[0]);
                        }
                        $ph['DrawSub'] = $optionalButton;
                    }
                }

                $output .= $modx->parseText($itemTpl, $ph);
            }

            $ph = array();
            if ($countChild > 0) {
                $ph['id'] = $level == 0 ? $this->defaults['outerClass'] : '';
                $ph['class'] = $level == 0 ? $this->defaults['outerClass'] : $this->defaults['innerClass'];
                $ph['output'] = $output;
                $output = $modx->parseText($outerTpl, $ph);
            }
        }

        return $output;
    }

    /**
     * @param int $id
     * @return string
     */
    public function getLinkClass($id)
    {
        if (isset($this->menu[$id])) {
            return ' class="' . $this->defaults['parentLinkClass'] . '"';
        } else {
            return '';
        }
    }

    /**
     * @param int $id
     * @return string
     */
    public function getLinkAttr($id)
    {
        if (isset($this->menu[$id])) {
            return $this->defaults['parentLinkAttr'];
        } else {
            return '';
        }
    }

    /**
     * @param int $id
     * @return string
     */
    public function getItemClass($id)
    {
        if (isset($this->menu[$id])) {
            return $this->defaults['parentClass'] . ' ';
        } else {
            return '';
        }
    }

    /**
     * @param int $id
     * @return string
     */
    public function getItemName($id)
    {
        if (isset($this->menu[$id])) {
            return $this->defaults['parentLinkIn'];
        } else {
            return '';
        }
    }
}


1			<?php namespace EvolutionCMS\Support;
2
3			/**
4			* menu->Build('id','parent','name','link','alt','onclick','permission','target','divider 1/0','menuindex')
5			*/
6
7			use EvolutionCMS\Interfaces\MenuInterface;
8
9			class Menu implements MenuInterface
10			{
11			/**
12			* @var array
13			*/
14			public $defaults = array();
15			/**
16			* @var
17			*/
18			public $menu;
19			/**
20			* @var
21			*/
22			public $output;
23
24			/**
25			* @param $menu
26			* @param array $setting
27			*/
28			public function build($menu, $setting = array())
29			{
30			$this->defaults['outerClass'] = 'nav';
31			$this->defaults['parentClass'] = 'dropdown';
32			$this->defaults['parentLinkClass'] = 'dropdown-toggle';
33			$this->defaults['parentLinkAttr'] = 'data-toggle="dropdown"';
34			$this->defaults['parentLinkIn'] = '<b class="caret"></b>';
35			$this->defaults['innerClass'] = 'subnav';
36
37			$this->defaults = $setting + $this->defaults;
38			$this->structurise($menu);
39			$this->output = $this->drawSub('main', 0);
40			echo $this->output;
41			}
42
43			/**
44			* @param array $menu
45			*/
46			public function structurise($menu)
47			{
48			$new = array();
49			foreach ($menu as $key => $row) {
50			$data[$key] = $row[9];
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-21 15:53 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
51			}
52
53			array_multisort($data, SORT_ASC, $menu);
54
55			foreach ($menu as $key => $value) {
56			$new[$value[1]][] = $value;
57			}
58
59			$this->menu = $new;
60			}
61
62			/**
63			* @param int $parentid
64			* @param int $level
65			* @return string
66			*/
67			public function drawSub($parentid, $level)
68			{
69			$modx = evolutionCMS();
70
71			$output = '';
72
73			if (isset($this->menu[$parentid])) {
74
75			$ph = array();
			0 ignored issues – show Comprehensibility introduced 2018-02-25 12:32 UTC by Report Bug Copy Issue Report Avoid variables with short names like $ph. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
76			$countChild = 0;
77			$itemTpl = '
78			<li id="[+id+]" class="[+li_class+]"><a href="[+href+]" alt="[+alt+]" target="[+target+]" onclick="[+onclick+]"[+a_class+] [+LinkAttr+]>[+itemName+]</a>[+DrawSub+]</li>';
79			$outerTpl = '<ul id="[+id+]" class="[+class+]">[+output+]</ul>';
80			foreach ($this->menu[$parentid] as $key => $value) {
81			if ($value[6] !== '') {
82			$permissions = explode(',', $value[6]);
83			foreach ($permissions as $val) {
84			if (!$modx->hasPermission($val)) {
85			continue;
86			}
87			}
88			}
89
90			$countChild++;
91			$id = $value[0];
92			$ph['id'] = $id;
93			$ph['li_class'] = $this->getItemClass($id) . $value[10];
94			$ph['href'] = $value[3];
95			$ph['alt'] = $value[4];
96			$ph['target'] = $value[7];
97			$ph['onclick'] = $value[5];
98			$ph['a_class'] = $this->getLinkClass($id);
99			$ph['LinkAttr'] = $this->getLinkAttr($id);
100			$ph['itemName'] = $value[2] . $this->getItemName($id);
101
102			$ph['DrawSub'] = '';
103
104			if (isset($this->menu[$id])) {
105			$level++;
106			$ph['DrawSub'] = $this->drawSub($id, $level);
107			$level--;
108			// Optional buttons
109			} else {
110			if (isset($value[11]) && !empty($value[11])) {
111			$optionalButton = '';
112			if (is_array($value[11])) {
113			foreach ($value[11] as $opt) {
114			$optionalButton .= sprintf('<%s href="%s" class="%s" onclick="%s" title="%s">%s</%s>',
115			$opt[0], $opt[1], $opt[2], $opt[3], $opt[4], $opt[5], $opt[0]);
116			}
117			} else {
118			$opt = $value[11];
119			$optionalButton = sprintf('<%s href="%s" class="%s" onclick="%s" title="%s">%s</%s>',
120			$opt[0], $opt[1], $opt[2], $opt[3], $opt[4], $opt[5], $opt[0]);
121			}
122			$ph['DrawSub'] = $optionalButton;
123			}
124			}
125
126			$output .= $modx->parseText($itemTpl, $ph);
127			}
128
129			$ph = array();
130			if ($countChild > 0) {
131			$ph['id'] = $level == 0 ? $this->defaults['outerClass'] : '';
132			$ph['class'] = $level == 0 ? $this->defaults['outerClass'] : $this->defaults['innerClass'];
133			$ph['output'] = $output;
134			$output = $modx->parseText($outerTpl, $ph);
135			}
136			}
137
138			return $output;
139			}
140
141			/**
142			* @param int $id
143			* @return string
144			*/
145			public function getLinkClass($id)
146			{
147			if (isset($this->menu[$id])) {
148			return ' class="' . $this->defaults['parentLinkClass'] . '"';
149			} else {
150			return '';
151			}
152			}
153
154			/**
155			* @param int $id
156			* @return string
157			*/
158			public function getLinkAttr($id)
159			{
160			if (isset($this->menu[$id])) {
161			return $this->defaults['parentLinkAttr'];
162			} else {
163			return '';
164			}
165			}
166
167			/**
168			* @param int $id
169			* @return string
170			*/
171			public function getItemClass($id)
172			{
173			if (isset($this->menu[$id])) {
174			return $this->defaults['parentClass'] . ' ';
175			} else {
176			return '';
177			}
178			}
179
180			/**
181			* @param int $id
182			* @return string
183			*/
184			public function getItemName($id)
185			{
186			if (isset($this->menu[$id])) {
187			return $this->defaults['parentLinkIn'];
188			} else {
189			return '';
190			}
191			}
192			}
193

evolution-cms / evolution

Pull Request — develop (#716)

Menu::drawSub() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like