Event::__construct() - Code Metrics - Inspection of "Refactoring" - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#716)

by Agel_Nash

created 2018-06-07 23:49 UTC

Event::__construct() A

↳ Parent: Event

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php namespace EvolutionCMS;

class Event implements Interfaces\EventInterface

{
    public $name = '';
    public $_propagate = true;
    /**
     * @deprecated use setOutput(), getOutput()
     * @var string
     */
    public $_output;
    public $activated = false;
    public $activePlugin = '';
    public $params = array();

    /**
     * @param string $name Name of the event
     */
    public function __construct($name = "")
    {
        $this->_resetEventObject();
        $this->name = $name;
    }

    /**
     * Display a message to the user
     *
     * @global array $SystemAlertMsgQueque
     * @param string $msg The message
     */
    public function alert($msg)
    {
        global $SystemAlertMsgQueque;
function myFunction($a, $b) {
    // Do something
}
        if ($msg == "") {
            return;
        }
        if (is_array($SystemAlertMsgQueque)) {
            $title = '';
            if ($this->name && $this->activePlugin) {
                $title = "<div><b>" . $this->activePlugin . "</b> - <span style='color:maroon;'>" . $this->name . "</span></div>";
            }
            $SystemAlertMsgQueque[] = "$title<div style='margin-left:10px;margin-top:3px;'>$msg</div>";
        }
    }

    /**
     * Output
     *
     * @param string $msg
     * @deprecated see addOutput
     */
    public function output($msg)
    {
        $this->_output .= $msg;

    }

    /**
     * @param mixed $data
     */
    public function setOutput($data)
    {
        $this->_output = $data;

    }

    /**
     * @return mixed

     */
    public function getOutput()
    {
        return $this->_output;

    }

    /**
     * Stop event propogation
     */
    public function stopPropagation()
    {
        $this->_propagate = false;
    }

    public function _resetEventObject()
    {
        unset ($this->returnedValues);
        $this->name = "";
        $this->setOutput(null);
        $this->_propagate = true;
        $this->activated = false;
    }
}


1			<?php namespace EvolutionCMS;
2
3			class Event implements Interfaces\EventInterface
			0 ignored issues – show Coding Style introduced 2018-06-07 17:11 UTC by Report Bug Copy Issue Report The property $_propagate is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style introduced 2018-06-07 17:11 UTC by Report Bug Copy Issue Report The property $_output is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
4			{
5			public $name = '';
6			public $_propagate = true;
7			/**
8			* @deprecated use setOutput(), getOutput()
9			* @var string
10			*/
11			public $_output;
12			public $activated = false;
13			public $activePlugin = '';
14			public $params = array();
15
16			/**
17			* @param string $name Name of the event
18			*/
19			public function __construct($name = "")
20			{
21			$this->_resetEventObject();
22			$this->name = $name;
23			}
24
25			/**
26			* Display a message to the user
27			*
28			* @global array $SystemAlertMsgQueque
29			* @param string $msg The message
30			*/
31			public function alert($msg)
32			{
33			global $SystemAlertMsgQueque;
			0 ignored issues – show Compatibility Best Practice introduced 2018-02-21 15:53 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
34			if ($msg == "") {
35			return;
36			}
37			if (is_array($SystemAlertMsgQueque)) {
38			$title = '';
39			if ($this->name && $this->activePlugin) {
40			$title = "<div><b>" . $this->activePlugin . "</b> - <span style='color:maroon;'>" . $this->name . "</span></div>";
41			}
42			$SystemAlertMsgQueque[] = "$title<div style='margin-left:10px;margin-top:3px;'>$msg</div>";
43			}
44			}
45
46			/**
47			* Output
48			*
49			* @param string $msg
50			* @deprecated see addOutput
51			*/
52			public function output($msg)
53			{
54			$this->_output .= $msg;
			0 ignored issues – show Deprecated Code introduced 2018-06-07 17:11 UTC by Report Bug Copy Issue Report The property `EvolutionCMS\Event::$_output` has been deprecated with message: use setOutput(), getOutput() This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
55			}
56
57			/**
58			* @param mixed $data
59			*/
60			public function setOutput($data)
61			{
62			$this->_output = $data;
			0 ignored issues – show Deprecated Code introduced 2018-06-07 17:11 UTC by Report Bug Copy Issue Report The property `EvolutionCMS\Event::$_output` has been deprecated with message: use setOutput(), getOutput() This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
63			}
64
65			/**
66			* @return mixed
			0 ignored issues – show Documentation introduced 2018-06-05 22:21 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
67			*/
68			public function getOutput()
69			{
70			return $this->_output;
			0 ignored issues – show Deprecated Code introduced 2018-06-07 17:11 UTC by Report Bug Copy Issue Report The property `EvolutionCMS\Event::$_output` has been deprecated with message: use setOutput(), getOutput() This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
71			}
72
73			/**
74			* Stop event propogation
75			*/
76			public function stopPropagation()
77			{
78			$this->_propagate = false;
79			}
80
81			public function _resetEventObject()
82			{
83			unset ($this->returnedValues);
84			$this->name = "";
85			$this->setOutput(null);
86			$this->_propagate = true;
87			$this->activated = false;
88			}
89			}
90

evolution-cms / evolution

Pull Request — develop (#716)

Event::__construct() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like