Completed
Push — develop ( 923a1c...1e9876 )
by Maxim
47s queued 29s
created
install/actions/action_summary.php 1 patch
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! function_exists('f_owc')){
2
+if (!function_exists('f_owc')) {
3 3
     /**
4 4
      * @param $path
5 5
      * @param $data
@@ -12,30 +12,30 @@  discard block
 block discarded – undo
12 12
             fwrite($hnd, $data);
13 13
             fclose($hnd);
14 14
 
15
-            if(null !== $mode) chmod($path, $mode);
16
-        }catch(Exception $e){
15
+            if (null !== $mode) chmod($path, $mode);
16
+        } catch (Exception $e) {
17 17
             // Nothing, this is NOT normal
18 18
             unset($e);
19 19
         }
20 20
     }
21 21
 }
22 22
 
23
-$installMode = isset($_POST['installmode']) ? (int)$_POST['installmode'] : 0;
24
-if( ! isset($_lang)) $_lang = array();
23
+$installMode = isset($_POST['installmode']) ? (int) $_POST['installmode'] : 0;
24
+if (!isset($_lang)) $_lang = array();
25 25
 
26 26
 echo '<div class="stepcontainer">
27 27
       <ul class="progressbar">
28
-          <li class="visited">' . $_lang['choose_language'] . '</li>
29
-          <li class="visited">' . $_lang['installation_mode'] . '</li>
30
-          <li class="visited">' . $_lang['optional_items'] . '</li>
31
-          <li class="active">' . $_lang['preinstall_validation'] . '</li>
32
-          <li>' . $_lang['install_results'] . '</li>
28
+          <li class="visited">' . $_lang['choose_language'].'</li>
29
+          <li class="visited">' . $_lang['installation_mode'].'</li>
30
+          <li class="visited">' . $_lang['optional_items'].'</li>
31
+          <li class="active">' . $_lang['preinstall_validation'].'</li>
32
+          <li>' . $_lang['install_results'].'</li>
33 33
   </ul>
34 34
   <div class="clearleft"></div>
35 35
 </div>';
36 36
 
37
-echo '<h2>' . $_lang['preinstall_validation'] . '</h2>';
38
-echo '<h3>' . $_lang['summary_setup_check'] . '</h3>';
37
+echo '<h2>'.$_lang['preinstall_validation'].'</h2>';
38
+echo '<h3>'.$_lang['summary_setup_check'].'</h3>';
39 39
 
40 40
 $errors = 0;
41 41
 
@@ -43,73 +43,73 @@  discard block
 block discarded – undo
43 43
 // check PHP version
44 44
 define('PHP_MIN_VERSION', '5.4.0');
45 45
 $phpMinVersion = PHP_MIN_VERSION; // Maybe not necessary. For backward compatibility
46
-echo '<p>' . $_lang['checking_php_version'];
46
+echo '<p>'.$_lang['checking_php_version'];
47 47
 // -1 if left is less, 0 if equal, +1 if left is higher
48 48
 if (version_compare(phpversion(), PHP_MIN_VERSION) < 0) {
49 49
     $errors++;
50
-    $tmp = $_lang['you_running_php'] . phpversion() . str_replace('[+min_version+]', PHP_MIN_VERSION, $_lang["modx_requires_php"]);
51
-    echo '<span class="notok">' . $_lang['failed'] . '</span>' . $tmp . '</p>';
50
+    $tmp = $_lang['you_running_php'].phpversion().str_replace('[+min_version+]', PHP_MIN_VERSION, $_lang["modx_requires_php"]);
51
+    echo '<span class="notok">'.$_lang['failed'].'</span>'.$tmp.'</p>';
52 52
 } else {
53
-    echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
53
+    echo '<span class="ok">'.$_lang['ok'].'</span></p>';
54 54
 }
55 55
 
56 56
 
57 57
 // check if iconv is available
58
-echo '<p>' . $_lang['checking_iconv'];
58
+echo '<p>'.$_lang['checking_iconv'];
59 59
 $iconv = (int) function_exists('iconv');
60
-if ($iconv == '0'){
61
-    echo '<span class="notok">' . $_lang['failed'].'</span></p><p><strong>'.$_lang['checking_iconv_note'].'</strong></p>';
60
+if ($iconv == '0') {
61
+    echo '<span class="notok">'.$_lang['failed'].'</span></p><p><strong>'.$_lang['checking_iconv_note'].'</strong></p>';
62 62
     $errors++;
63 63
 } else {
64
-    echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
64
+    echo '<span class="ok">'.$_lang['ok'].'</span></p>';
65 65
 }
66 66
 // check sessions
67
-echo '<p>' . $_lang['checking_sessions'];
67
+echo '<p>'.$_lang['checking_sessions'];
68 68
 if ($_SESSION['test'] != 1) {
69
-    echo '<span class="notok">' . $_lang['failed'].  '</span></p>';
69
+    echo '<span class="notok">'.$_lang['failed'].'</span></p>';
70 70
     $errors++;
71 71
 } else {
72
-    echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
72
+    echo '<span class="ok">'.$_lang['ok'].'</span></p>';
73 73
 }
74 74
 
75 75
 
76 76
 // check directories
77 77
 // cache exists?
78
-echo '<p>' . $_lang['checking_if_cache_exist'];
78
+echo '<p>'.$_lang['checking_if_cache_exist'];
79 79
 if (!file_exists("../assets/cache") || !file_exists("../assets/cache/rss")) {
80
-    echo '<span class="notok">' . $_lang['failed'] . '</span></p>';
80
+    echo '<span class="notok">'.$_lang['failed'].'</span></p>';
81 81
     $errors++;
82 82
 } else {
83
-    echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
83
+    echo '<span class="ok">'.$_lang['ok'].'</span></p>';
84 84
 }
85 85
 
86 86
 
87 87
 // cache writable?
88
-echo '<p>' . $_lang['checking_if_cache_writable'];
88
+echo '<p>'.$_lang['checking_if_cache_writable'];
89 89
 if (!is_writable("../assets/cache")) {
90 90
     $errors++;
91
-    echo '<span class="notok">' . $_lang['failed'] . '</span></p>';
91
+    echo '<span class="notok">'.$_lang['failed'].'</span></p>';
92 92
 } else {
93
-    echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
93
+    echo '<span class="ok">'.$_lang['ok'].'</span></p>';
94 94
 }
95 95
 
96 96
 
97 97
 // cache files writable?
98
-echo '<p>' . $_lang['checking_if_cache_file_writable'];
98
+echo '<p>'.$_lang['checking_if_cache_file_writable'];
99 99
 $tmp = "../assets/cache/siteCache.idx.php";
100
-if ( ! file_exists($tmp)) {
100
+if (!file_exists($tmp)) {
101 101
     f_owc($tmp, "<?php //EVO site cache file ?>");
102 102
 }
103
-if ( ! is_writable($tmp)) {
103
+if (!is_writable($tmp)) {
104 104
     $errors++;
105
-    echo '<span class="notok">' . $_lang['failed'] . '</span></p>';
105
+    echo '<span class="notok">'.$_lang['failed'].'</span></p>';
106 106
 } else {
107 107
     echo '<span class="ok">'.$_lang['ok'].'</span></p>';
108 108
 }
109 109
 
110 110
 
111 111
 echo '<p>'.$_lang['checking_if_cache_file2_writable'];
112
-if ( ! is_writable("../assets/cache/sitePublishing.idx.php")) {
112
+if (!is_writable("../assets/cache/sitePublishing.idx.php")) {
113 113
     $errors++;
114 114
     echo '<span class="notok">'.$_lang['failed'].'</span></p>';
115 115
 } else {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
 // File Browser directories exists?
121 121
 echo '<p>'.$_lang['checking_if_images_exist'];
122
-switch(true){
122
+switch (true) {
123 123
     case !file_exists("../assets/images"):
124 124
     case !file_exists("../assets/files"):
125 125
     case !file_exists("../assets/backup"):
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 
135 135
 // File Browser directories writable?
136 136
 echo '<p>'.$_lang['checking_if_images_writable'];
137
-switch(true){
137
+switch (true) {
138 138
     case !is_writable("../assets/images"):
139 139
     case !is_writable("../assets/files"):
140 140
     case !is_writable("../assets/backup"):
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
     $database_charset = substr($database_collation, 0, strpos($database_collation, '_') - 1);
195 195
     $database_connection_charset = $_POST['database_connection_charset'];
196 196
     $database_connection_method = $_POST['database_connection_method'];
197
-    $dbase = '`' . $_POST['database_name'] . '`';
197
+    $dbase = '`'.$_POST['database_name'].'`';
198 198
     $table_prefix = $_POST['tableprefix'];
199 199
 }
200 200
 echo '<p>'.$_lang['creating_database_connection'];
@@ -234,54 +234,54 @@  discard block
 block discarded – undo
234 234
 
235 235
 // check table prefix
236 236
 if ($conn && $installMode == 0) {
237
-    echo '<p>' . $_lang['checking_table_prefix'] . $table_prefix . '`: ';
238
-    if ($rs= mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`" . $table_prefix . "site_content`")) {
239
-        echo '<span class="notok">' . $_lang['failed'] . '</span></b>' . $_lang['table_prefix_already_inuse'] . '</p>';
237
+    echo '<p>'.$_lang['checking_table_prefix'].$table_prefix.'`: ';
238
+    if ($rs = mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`".$table_prefix."site_content`")) {
239
+        echo '<span class="notok">'.$_lang['failed'].'</span></b>'.$_lang['table_prefix_already_inuse'].'</p>';
240 240
         $errors++;
241
-        echo "<p>" . $_lang['table_prefix_already_inuse_note'] . '</p>';
241
+        echo "<p>".$_lang['table_prefix_already_inuse_note'].'</p>';
242 242
     } else {
243
-        echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
243
+        echo '<span class="ok">'.$_lang['ok'].'</span></p>';
244 244
     }
245 245
 } elseif ($conn && $installMode == 2) {
246
-    echo '<p>' . $_lang['checking_table_prefix'] . $table_prefix . '`: ';
247
-    if (!$rs = mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`" . $table_prefix . "site_content`")) {
248
-        echo '<span class="notok">' . $_lang['failed'] . '</span></b>' . $_lang['table_prefix_not_exist'] . '</p>';
246
+    echo '<p>'.$_lang['checking_table_prefix'].$table_prefix.'`: ';
247
+    if (!$rs = mysqli_query($conn, "SELECT COUNT(*) FROM $dbase.`".$table_prefix."site_content`")) {
248
+        echo '<span class="notok">'.$_lang['failed'].'</span></b>'.$_lang['table_prefix_not_exist'].'</p>';
249 249
         $errors++;
250
-        echo '<p>' . $_lang['table_prefix_not_exist_note'] . '</p>';
250
+        echo '<p>'.$_lang['table_prefix_not_exist_note'].'</p>';
251 251
   } else {
252
-        echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
252
+        echo '<span class="ok">'.$_lang['ok'].'</span></p>';
253 253
   }
254 254
 }
255 255
 
256 256
 // check mysql version
257 257
 if ($conn) {
258
-    echo '<p>' . $_lang['checking_mysql_version'];
259
-    if ( version_compare(mysqli_get_server_info($conn), '5.0.51', '=') ) {
260
-        echo '<span class="notok">'  . $_lang['warning'] . '</span></b>&nbsp;&nbsp;<strong>' . $_lang['mysql_5051'] . '</strong></p>';
261
-        echo '<p><span class="notok">' . $_lang['mysql_5051_warning'] . '</span></p>';
258
+    echo '<p>'.$_lang['checking_mysql_version'];
259
+    if (version_compare(mysqli_get_server_info($conn), '5.0.51', '=')) {
260
+        echo '<span class="notok">'.$_lang['warning'].'</span></b>&nbsp;&nbsp;<strong>'.$_lang['mysql_5051'].'</strong></p>';
261
+        echo '<p><span class="notok">'.$_lang['mysql_5051_warning'].'</span></p>';
262 262
     } else {
263
-        echo '<span class="ok">' . $_lang['ok'] . '</span>&nbsp;&nbsp;<strong>' . $_lang['mysql_version_is'] . mysqli_get_server_info($conn) . '</strong></p>';
263
+        echo '<span class="ok">'.$_lang['ok'].'</span>&nbsp;&nbsp;<strong>'.$_lang['mysql_version_is'].mysqli_get_server_info($conn).'</strong></p>';
264 264
     }
265 265
 }
266 266
 
267 267
 // check for strict mode
268 268
 if ($conn) {
269
-    echo '<p>'. $_lang['checking_mysql_strict_mode'];
269
+    echo '<p>'.$_lang['checking_mysql_strict_mode'];
270 270
     $mysqlmode = mysqli_query($conn, "SELECT @@global.sql_mode");
271
-    if (mysqli_num_rows($mysqlmode) > 0){
271
+    if (mysqli_num_rows($mysqlmode) > 0) {
272 272
         $modes = mysqli_fetch_array($mysqlmode, MYSQLI_NUM);
273 273
         //$modes = array("STRICT_TRANS_TABLES"); // for testing
274 274
         // print_r($modes);
275 275
         foreach ($modes as $mode) {
276 276
             if (stristr($mode, "STRICT_TRANS_TABLES") !== false || stristr($mode, "STRICT_ALL_TABLES") !== false) {
277
-                echo '<span class="notok">' . $_lang['warning'] . '</span></b> <strong>&nbsp;&nbsp;' . $_lang['strict_mode'] . '</strong></p>';
278
-                echo '<p><span class="notok">' . $_lang['strict_mode_error'] . '</span></p>';
277
+                echo '<span class="notok">'.$_lang['warning'].'</span></b> <strong>&nbsp;&nbsp;'.$_lang['strict_mode'].'</strong></p>';
278
+                echo '<p><span class="notok">'.$_lang['strict_mode_error'].'</span></p>';
279 279
             } else {
280
-                echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
280
+                echo '<span class="ok">'.$_lang['ok'].'</span></p>';
281 281
             }
282 282
         }
283 283
     } else {
284
-        echo '<span class="ok">' . $_lang['ok'] . '</span></p>';
284
+        echo '<span class="ok">'.$_lang['ok'].'</span></p>';
285 285
     }
286 286
 }
287 287
 // Version and strict mode check end
@@ -297,18 +297,18 @@  discard block
 block discarded – undo
297 297
     f_owc("../assets/cache/installProc.inc.php", '<?php $installStartTime = '.time().'; ?>');
298 298
 }
299 299
 
300
-if($installMode > 0 && $_POST['installdata'] == "1") {
301
-    echo '<p class="notes"><strong>' . $_lang['sample_web_site'] . ':</strong> ' . $_lang['sample_web_site_note'] . '</p>';
300
+if ($installMode > 0 && $_POST['installdata'] == "1") {
301
+    echo '<p class="notes"><strong>'.$_lang['sample_web_site'].':</strong> '.$_lang['sample_web_site_note'].'</p>';
302 302
 }
303 303
 
304 304
 if ($errors > 0) {
305 305
     echo '<p>';
306
-    echo $_lang['setup_cannot_continue'] . ' ';
306
+    echo $_lang['setup_cannot_continue'].' ';
307 307
 
308
-    if($errors > 1){
309
-        echo $errors . " " . $_lang['errors'] . $_lang['please_correct_errors'] . $_lang['and_try_again_plural'];
310
-    }else{
311
-        echo $_lang['error'] . $_lang['please_correct_error'] . $_lang['and_try_again'];
308
+    if ($errors > 1) {
309
+        echo $errors." ".$_lang['errors'].$_lang['please_correct_errors'].$_lang['and_try_again_plural'];
310
+    } else {
311
+        echo $_lang['error'].$_lang['please_correct_error'].$_lang['and_try_again'];
312 312
     }
313 313
 
314 314
     echo $_lang['visit_forum'];
@@ -317,10 +317,10 @@  discard block
 block discarded – undo
317 317
 
318 318
 echo '<p>&nbsp;</p>';
319 319
 
320
-$nextAction= $errors > 0 ? 'summary' : 'install';
321
-$nextButton= $errors > 0 ? $_lang['retry'] : $_lang['install'];
322
-$nextVisibility= $errors > 0 || isset($_POST['chkagree']) ? 'visible' : 'hidden';
323
-$agreeToggle= $errors > 0 ? '' : ' onclick="if(document.getElementById(\'chkagree\').checked){document.getElementById(\'nextbutton\').style.visibility=\'visible\';}else{document.getElementById(\'nextbutton\').style.visibility=\'hidden\';}"';
320
+$nextAction = $errors > 0 ? 'summary' : 'install';
321
+$nextButton = $errors > 0 ? $_lang['retry'] : $_lang['install'];
322
+$nextVisibility = $errors > 0 || isset($_POST['chkagree']) ? 'visible' : 'hidden';
323
+$agreeToggle = $errors > 0 ? '' : ' onclick="if(document.getElementById(\'chkagree\').checked){document.getElementById(\'nextbutton\').style.visibility=\'visible\';}else{document.getElementById(\'nextbutton\').style.visibility=\'hidden\';}"';
324 324
 ?>
325 325
 <form name="install" id="install_form" action="index.php?action=<?php echo $nextAction ?>" method="post">
326 326
   <div>
@@ -342,32 +342,32 @@  discard block
 block discarded – undo
342 342
 
343 343
     <input type="hidden" value="<?php echo $_POST['installdata'] ?>" name="installdata" />
344 344
 <?php
345
-    $templates = isset ($_POST['template']) ? $_POST['template'] : array ();
345
+    $templates = isset ($_POST['template']) ? $_POST['template'] : array();
346 346
     foreach ($templates as $i => $template) echo '<input type="hidden" name="template[]" value="'.$template.'" />';
347 347
 
348
-    $tvs = isset ($_POST['tv']) ? $_POST['tv'] : array ();
348
+    $tvs = isset ($_POST['tv']) ? $_POST['tv'] : array();
349 349
     foreach ($tvs as $i => $tv) echo '<input type="hidden" name="tv[]" value="'.$tv.'" />';
350 350
 
351
-    $chunks = isset ($_POST['chunk']) ? $_POST['chunk'] : array ();
351
+    $chunks = isset ($_POST['chunk']) ? $_POST['chunk'] : array();
352 352
     foreach ($chunks as $i => $chunk) echo '<input type="hidden" name="chunk[]" value="'.$chunk.'" />';
353 353
 
354
-    $snippets = isset ($_POST['snippet']) ? $_POST['snippet'] : array ();
354
+    $snippets = isset ($_POST['snippet']) ? $_POST['snippet'] : array();
355 355
     foreach ($snippets as $i => $snippet) echo '<input type="hidden" name="snippet[]" value="'.$snippet.'" />';
356 356
 
357
-    $plugins = isset ($_POST['plugin']) ? $_POST['plugin'] : array ();
357
+    $plugins = isset ($_POST['plugin']) ? $_POST['plugin'] : array();
358 358
     foreach ($plugins as $i => $plugin) echo '<input type="hidden" name="plugin[]" value="'.$plugin.'" />';
359 359
 
360
-    $modules = isset ($_POST['module']) ? $_POST['module'] : array ();
360
+    $modules = isset ($_POST['module']) ? $_POST['module'] : array();
361 361
     foreach ($modules as $i => $module) echo '<input type="hidden" name="module[]" value="'.$module.'" />';
362 362
 ?>
363 363
 </div>
364 364
 
365
-<h2><?php echo $_lang['agree_to_terms'];?></h2>
365
+<h2><?php echo $_lang['agree_to_terms']; ?></h2>
366 366
 <p>
367
-<input type="checkbox" value="1" id="chkagree" name="chkagree" style="line-height:18px" <?php echo isset($_POST['chkagree']) ? 'checked="checked" ':""; ?><?php echo $agreeToggle;?>/><label for="chkagree" style="display:inline;float:none;line-height:18px;"> <?php echo $_lang['iagree_box']?> </label>
367
+<input type="checkbox" value="1" id="chkagree" name="chkagree" style="line-height:18px" <?php echo isset($_POST['chkagree']) ? 'checked="checked" ' : ""; ?><?php echo $agreeToggle; ?>/><label for="chkagree" style="display:inline;float:none;line-height:18px;"> <?php echo $_lang['iagree_box']?> </label>
368 368
 </p>
369 369
     <p class="buttonlinks">
370 370
         <a href="javascript:document.getElementById('install_form').action='index.php?action=options&language=<?php echo $install_language?>';document.getElementById('install_form').submit();" class="prev" title="<?php echo $_lang['btnback_value']?>"><span><?php echo $_lang['btnback_value']?></span></a>
371
-        <a id="nextbutton" href="javascript:document.getElementById('install_form').submit();" title="<?php echo $nextButton ?>" style="visibility:<?php echo $nextVisibility;?>"><span><?php echo $nextButton ?></span></a>
371
+        <a id="nextbutton" href="javascript:document.getElementById('install_form').submit();" title="<?php echo $nextButton ?>" style="visibility:<?php echo $nextVisibility; ?>"><span><?php echo $nextButton ?></span></a>
372 372
     </p>
373 373
 </form>
Please login to merge, or discard this patch.
install/actions/action_language.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 $content = parse($content, array(
4 4
     'langOptions' => getLangOptions($install_language))
5 5
 );
6
-$content = parse($content, $_lang,'[%','%]');
6
+$content = parse($content, $_lang, '[%', '%]');
7 7
 
8 8
 echo $content;
9 9
 
10
-if( ! function_exists('getLangOptions')) {
10
+if (!function_exists('getLangOptions')) {
11 11
     /**
12 12
      * @param string $install_language
13 13
      * @return string
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             $abrv_language = explode('-', $language);
30 30
             $selected = ($language === $install_language) ? 'selected' : '';
31 31
             $_[] = sprintf('<option value="%s" %s>%s</option>', $language, $selected,
32
-                    ucwords($abrv_language[0])) . "\n";
32
+                    ucwords($abrv_language[0]))."\n";
33 33
         }
34 34
 
35 35
         return implode("\n", $_);
Please login to merge, or discard this patch.
install/actions/action_mode.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 // Determine upgradeability
3 3
 $upgradeable = 0;
4
-if (is_file($base_path . MGR_DIR . '/includes/config.inc.php')) { // Include the file so we can test its validity
5
-    include $base_path . MGR_DIR . '/includes/config.inc.php';
4
+if (is_file($base_path.MGR_DIR.'/includes/config.inc.php')) { // Include the file so we can test its validity
5
+    include $base_path.MGR_DIR.'/includes/config.inc.php';
6 6
     // We need to have all connection settings - tho prefix may be empty so we have to ignore it
7 7
     if (isset($dbase)) {
8 8
         if (!$conn = @mysqli_connect($database_server, $database_user, $database_password))
@@ -17,16 +17,16 @@  discard block
 block discarded – undo
17 17
 }
18 18
 
19 19
 $ph['moduleName']       = $moduleName;
20
-$ph['displayNew']       = ($upgradeable!=0) ? 'display:none;' : '';
21
-$ph['displayUpg']       = ($upgradeable==0) ? 'display:none;' : '';
20
+$ph['displayNew']       = ($upgradeable != 0) ? 'display:none;' : '';
21
+$ph['displayUpg']       = ($upgradeable == 0) ? 'display:none;' : '';
22 22
 $ph['displayAdvUpg']    = $ph['displayUpg'];
23
-$ph['checkedNew']       = !$upgradeable     ? 'checked' : '';
24
-$ph['checkedUpg']       = ($_POST['installmode']==1 || $upgradeable==1) ? 'checked' : '';
25
-$ph['checkedAdvUpg']    = ($_POST['installmode']==2 || $upgradeable==2) ? 'checked' : '';
23
+$ph['checkedNew']       = !$upgradeable ? 'checked' : '';
24
+$ph['checkedUpg']       = ($_POST['installmode'] == 1 || $upgradeable == 1) ? 'checked' : '';
25
+$ph['checkedAdvUpg']    = ($_POST['installmode'] == 2 || $upgradeable == 2) ? 'checked' : '';
26 26
 $ph['install_language'] = $install_language;
27
-$ph['disabledUpg']      = ($upgradeable!=1) ? 'disabled' : '';
28
-$ph['disabledAdvUpg']   = ($upgradeable==0) ? 'disabled' : '';
27
+$ph['disabledUpg']      = ($upgradeable != 1) ? 'disabled' : '';
28
+$ph['disabledAdvUpg']   = ($upgradeable == 0) ? 'disabled' : '';
29 29
 
30
-$tpl = file_get_contents($base_path . 'install/actions/tpl_mode.html');
30
+$tpl = file_get_contents($base_path.'install/actions/tpl_mode.html');
31 31
 $content = parse($tpl, $ph);
32
-echo parse($content, $_lang,'[%','%]');
32
+echo parse($content, $_lang, '[%', '%]');
Please login to merge, or discard this patch.
install/actions/action_options.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -1,19 +1,19 @@  discard block
 block discarded – undo
1 1
 <?php
2
-$installMode = isset($_POST['installmode']) ? (int)$_POST['installmode'] : 0;
2
+$installMode = isset($_POST['installmode']) ? (int) $_POST['installmode'] : 0;
3 3
 
4
-switch($installMode){
4
+switch ($installMode) {
5 5
     case 0:
6 6
     case 2:
7 7
         $database_collation = isset($_POST['database_collation']) ? $_POST['database_collation'] : 'utf8_general_ci';
8 8
         $database_charset = substr($database_collation, 0, strpos($database_collation, '_'));
9 9
         $_POST['database_connection_charset'] = $database_charset;
10
-        if(empty($_SESSION['databaseloginpassword']))
10
+        if (empty($_SESSION['databaseloginpassword']))
11 11
             $_SESSION['databaseloginpassword'] = $_POST['databaseloginpassword'];
12
-        if(empty($_SESSION['databaseloginname']))
12
+        if (empty($_SESSION['databaseloginname']))
13 13
             $_SESSION['databaseloginname'] = $_POST['databaseloginname'];
14 14
         break;
15 15
     case 1:
16
-        include $base_path . MGR_DIR . '/includes/config.inc.php';
16
+        include $base_path.MGR_DIR.'/includes/config.inc.php';
17 17
         if (@ $conn = mysqli_connect($database_server, $database_user, $database_password)) {
18 18
             if (@ mysqli_query($conn, "USE {$dbase}")) {
19 19
                 if (!$rs = mysqli_query($conn, "show session variables like 'collation_database'")) {
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 $ph['checked'] = isset ($_POST['installdata']) && $_POST['installdata'] == "1" ? 'checked' : '';
69 69
 
70 70
 # load setup information file
71
-include($base_path . 'install/setup.info.php');
71
+include($base_path.'install/setup.info.php');
72 72
 $ph['templates'] = getTemplates($moduleTemplates);
73 73
 $ph['tvs']       = getTVs($moduleTVs);
74 74
 $ph['chunks']    = getChunks($moduleChunks);
@@ -78,12 +78,12 @@  discard block
 block discarded – undo
78 78
 
79 79
 $ph['action'] = ($installMode == 1) ? 'mode' : 'connection';
80 80
 
81
-$tpl = file_get_contents($base_path . 'install/actions/tpl_options.html');
82
-$content = parse($tpl,$ph);
83
-echo parse($content,$_lang,'[%','%]');
81
+$tpl = file_get_contents($base_path.'install/actions/tpl_options.html');
82
+$content = parse($tpl, $ph);
83
+echo parse($content, $_lang, '[%', '%]');
84 84
 
85 85
 
86
-if( ! function_exists('getTemplates')) {
86
+if (!function_exists('getTemplates')) {
87 87
     /**
88 88
      * @param array $presets
89 89
      * @return string
@@ -108,12 +108,12 @@  discard block
 block discarded – undo
108 108
             $i++;
109 109
         }
110 110
         if (0 < count($_)) {
111
-            return '<h3>[%templates%]</h3>' . join("\n", $_);
111
+            return '<h3>[%templates%]</h3>'.join("\n", $_);
112 112
         }
113 113
     }
114 114
 }
115 115
 
116
-if( ! function_exists('getTVs')) {
116
+if (!function_exists('getTVs')) {
117 117
     /**
118 118
      * @param array $presets
119 119
      * @return string
@@ -138,12 +138,12 @@  discard block
 block discarded – undo
138 138
             $i++;
139 139
         }
140 140
         if (0 < count($_)) {
141
-            return '<h3>[%tvs%]</h3>' . join("\n", $_);
141
+            return '<h3>[%tvs%]</h3>'.join("\n", $_);
142 142
         }
143 143
     }
144 144
 }
145 145
 
146
-if( ! function_exists('getChunks')) {
146
+if (!function_exists('getChunks')) {
147 147
     /**
148 148
      * display chunks
149 149
      *
@@ -169,12 +169,12 @@  discard block
 block discarded – undo
169 169
             $i++;
170 170
         }
171 171
         if (0 < count($_)) {
172
-            return '<h3>[%chunks%]</h3>' . join("\n", $_);
172
+            return '<h3>[%chunks%]</h3>'.join("\n", $_);
173 173
         }
174 174
     }
175 175
 }
176 176
 
177
-if( ! function_exists('getModules')) {
177
+if (!function_exists('getModules')) {
178 178
     /**
179 179
      * display modules
180 180
      *
@@ -200,12 +200,12 @@  discard block
 block discarded – undo
200 200
             $i++;
201 201
         }
202 202
         if (0 < count($_)) {
203
-            return '<h3>[%modules%]</h3>' . join("\n", $_);
203
+            return '<h3>[%modules%]</h3>'.join("\n", $_);
204 204
         }
205 205
     }
206 206
 }
207 207
 
208
-if( ! function_exists('getPlugins')) {
208
+if (!function_exists('getPlugins')) {
209 209
     /**
210 210
      * display plugins
211 211
      *
@@ -235,12 +235,12 @@  discard block
 block discarded – undo
235 235
             $i++;
236 236
         }
237 237
         if (0 < count($_)) {
238
-            return '<h3>[%plugins%]</h3>' . join("\n", $_);
238
+            return '<h3>[%plugins%]</h3>'.join("\n", $_);
239 239
         }
240 240
     }
241 241
 }
242 242
 
243
-if( ! function_exists('getSnippets')) {
243
+if (!function_exists('getSnippets')) {
244 244
     /**
245 245
      * display snippets
246 246
      *
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
             $i++;
267 267
         }
268 268
         if (0 < count($_)) {
269
-            return '<h3>[%snippets%]</h3>' . join("\n", $_);
269
+            return '<h3>[%snippets%]</h3>'.join("\n", $_);
270 270
         }
271 271
     }
272 272
 }
Please login to merge, or discard this patch.
install/actions/action_connection.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@  discard block
 block discarded – undo
1 1
 <?php
2
-$installMode = isset($_POST['installmode']) ? (int)$_POST['installmode'] : 0;
2
+$installMode = isset($_POST['installmode']) ? (int) $_POST['installmode'] : 0;
3 3
 
4 4
 // Determine upgradeability
5
-$upgradeable= 0;
5
+$upgradeable = 0;
6 6
 if ($installMode === 0) {
7
-    $database_name= '';
8
-    $database_server= 'localhost';
9
-    $table_prefix= substr(md5(time()), rand(0, 27), rand(3, 5))."_";
7
+    $database_name = '';
8
+    $database_server = 'localhost';
9
+    $table_prefix = substr(md5(time()), rand(0, 27), rand(3, 5))."_";
10 10
 } else {
11 11
     $database_name = '';
12 12
     if (!is_file($base_path.MGR_DIR.'/includes/config.inc.php')) $upgradeable = 0;
@@ -17,13 +17,13 @@  discard block
 block discarded – undo
17 17
         if ($dbase) {
18 18
           $database_name = trim($dbase, '`');
19 19
           if (!$conn = mysqli_connect($database_server, $database_user, $database_password))
20
-              $upgradeable = (isset($_POST['installmode']) && $_POST['installmode']=='new') ? 0 : 2;
21
-          elseif (! mysqli_select_db($conn, trim($dbase, '`')))
22
-              $upgradeable = (isset($_POST['installmode']) && $_POST['installmode']=='new') ? 0 : 2;
20
+              $upgradeable = (isset($_POST['installmode']) && $_POST['installmode'] == 'new') ? 0 : 2;
21
+          elseif (!mysqli_select_db($conn, trim($dbase, '`')))
22
+              $upgradeable = (isset($_POST['installmode']) && $_POST['installmode'] == 'new') ? 0 : 2;
23 23
           else
24 24
               $upgradeable = 1;
25 25
         }
26
-        else $upgradable= 2;
26
+        else $upgradable = 2;
27 27
     }
28 28
 }
29 29
 
@@ -49,33 +49,33 @@  discard block
 block discarded – undo
49 49
     $database_connection_method = 'SET CHARACTER SET';
50 50
 }
51 51
 
52
-$ph['database_name'] = isset($_POST['database_name']) ? $_POST['database_name']: $database_name;
53
-$ph['tableprefix'] = isset($_POST['tableprefix']) ? $_POST['tableprefix']: $table_prefix;
52
+$ph['database_name'] = isset($_POST['database_name']) ? $_POST['database_name'] : $database_name;
53
+$ph['tableprefix'] = isset($_POST['tableprefix']) ? $_POST['tableprefix'] : $table_prefix;
54 54
 $ph['selected_set_character_set'] = isset($database_connection_method) && $database_connection_method == 'SET CHARACTER SET' ? 'selected' : '';
55 55
 $ph['selected_set_names'] = isset($database_connection_method) && $database_connection_method == 'SET NAMES' ? 'selected' : '';
56 56
 $ph['show#connection_method'] = (($installMode == 0) || ($installMode == 2)) ? 'block' : 'none';
57
-$ph['database_collation'] = isset($_POST['database_collation']) ? $_POST['database_collation']: $database_collation;
58
-$ph['show#AUH'] = ($installMode == 0) ? 'block':'none';
59
-$ph['cmsadmin'] = isset($_POST['cmsadmin']) ? $_POST['cmsadmin']:'admin';
60
-$ph['cmsadminemail'] = isset($_POST['cmsadminemail']) ? $_POST['cmsadminemail']:"";
61
-$ph['cmspassword'] = isset($_POST['cmspassword']) ? $_POST['cmspassword']:"";
62
-$ph['cmspasswordconfirm'] = isset($_POST['cmspasswordconfirm']) ? $_POST['cmspasswordconfirm']:"";
57
+$ph['database_collation'] = isset($_POST['database_collation']) ? $_POST['database_collation'] : $database_collation;
58
+$ph['show#AUH'] = ($installMode == 0) ? 'block' : 'none';
59
+$ph['cmsadmin'] = isset($_POST['cmsadmin']) ? $_POST['cmsadmin'] : 'admin';
60
+$ph['cmsadminemail'] = isset($_POST['cmsadminemail']) ? $_POST['cmsadminemail'] : "";
61
+$ph['cmspassword'] = isset($_POST['cmspassword']) ? $_POST['cmspassword'] : "";
62
+$ph['cmspasswordconfirm'] = isset($_POST['cmspasswordconfirm']) ? $_POST['cmspasswordconfirm'] : "";
63 63
 $ph['managerLangs'] = getLangs($install_language);
64 64
 $ph['install_language'] = $install_language;
65 65
 $ph['installMode'] = $installMode;
66
-$ph['checkedChkagree']  = isset($_POST['chkagree']) ? 'checked':"";
66
+$ph['checkedChkagree']  = isset($_POST['chkagree']) ? 'checked' : "";
67 67
 $ph['database_connection_method'] = isset($database_connection_method) ? $database_connection_method : '';
68
-$ph['databasehost'] = isset($_POST['databasehost']) ? $_POST['databasehost']: $database_server;
69
-$ph['databaseloginname'] = isset($_SESSION['databaseloginname']) ? $_SESSION['databaseloginname']: '';
70
-$ph['databaseloginpassword'] = isset($_SESSION['databaseloginpassword']) ? $_SESSION['databaseloginpassword']: "";
68
+$ph['databasehost'] = isset($_POST['databasehost']) ? $_POST['databasehost'] : $database_server;
69
+$ph['databaseloginname'] = isset($_SESSION['databaseloginname']) ? $_SESSION['databaseloginname'] : '';
70
+$ph['databaseloginpassword'] = isset($_SESSION['databaseloginpassword']) ? $_SESSION['databaseloginpassword'] : "";
71 71
 $ph['MGR_DIR'] = MGR_DIR;
72 72
 
73 73
 $content = file_get_contents('./actions/tpl_connection.html');
74
-$content = parse($content, $_lang, '[%','%]');
74
+$content = parse($content, $_lang, '[%', '%]');
75 75
 $content = parse($content, $ph);
76 76
 echo $content;
77 77
 
78
-if( ! function_exists('getLangs')) {
78
+if (!function_exists('getLangs')) {
79 79
     /**
80 80
      * @param $install_language
81 81
      * @return string
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         }
90 90
 
91 91
         $langs = array();
92
-        if ($handle = opendir("../" . MGR_DIR . "/includes/lang")) {
92
+        if ($handle = opendir("../".MGR_DIR."/includes/lang")) {
93 93
             while (false !== ($file = readdir($handle))) {
94 94
                 if (strpos($file, '.inc.') !== false) {
95 95
                     $langs[] = $file;
Please login to merge, or discard this patch.
manager/includes/veriword.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 $modx->db->connect();
8 8
 $modx->getSettings();
9 9
 
10
-$vword = new VeriWord(148,60);
10
+$vword = new VeriWord(148, 60);
11 11
 $vword->output_image();
12 12
 $vword->destroy_image();
13 13
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 ## see sample.php for test and usage
44 44
 ## sample URL: http://www.program-ruti.org/veriword/
45 45
 ####
46
-class VeriWord {
46
+class VeriWord{
47 47
 
48 48
     /* path to font directory*/
49 49
     var $dir_font   = "ttf/";
@@ -53,45 +53,45 @@  discard block
 block discarded – undo
53 53
     var $im_width   = 0;
54 54
     var $im_height  = 0;
55 55
 
56
-    function __construct($w=200, $h=80) {
56
+    function __construct($w = 200, $h = 80){
57 57
         /* create session to set word for verification */
58 58
         startCMSSession();
59 59
         $this->set_veriword();
60
-        $this->dir_font = dirname(__FILE__) . '/' . $this->dir_font;
60
+        $this->dir_font = dirname(__FILE__).'/'.$this->dir_font;
61 61
         $this->im_width         = $w;
62 62
         $this->im_height        = $h;
63 63
     }
64 64
 
65
-    function set_veriword() {
65
+    function set_veriword(){
66 66
         /* create session variable for verification,
67 67
            you may change the session variable name */
68 68
         $this->word             = $this->pick_word();
69 69
         $_SESSION['veriword']   = $this->word;
70 70
     }
71 71
 
72
-    function output_image() {
72
+    function output_image(){
73 73
         /* output the image as jpeg */
74 74
         $this->draw_image();
75 75
         header("Content-type: image/jpeg");
76 76
         imagejpeg($this->im);
77 77
     }
78 78
 
79
-    function pick_word() {
79
+    function pick_word(){
80 80
         global $modx;
81 81
         // set default words
82
-        $words="MODX,Access,Better,BitCode,Chunk,Cache,Desc,Design,Excell,Enjoy,URLs,TechView,Gerald,Griff,Humphrey,Holiday,Intel,Integration,Joystick,Join(),Oscope,Genetic,Light,Likeness,Marit,Maaike,Niche,Netherlands,Ordinance,Oscillo,Parser,Phusion,Query,Question,Regalia,Righteous,Snippet,Sentinel,Template,Thespian,Unity,Enterprise,Verily,Veri,Website,WideWeb,Yap,Yellow,Zebra,Zygote";
82
+        $words = "MODX,Access,Better,BitCode,Chunk,Cache,Desc,Design,Excell,Enjoy,URLs,TechView,Gerald,Griff,Humphrey,Holiday,Intel,Integration,Joystick,Join(),Oscope,Genetic,Light,Likeness,Marit,Maaike,Niche,Netherlands,Ordinance,Oscillo,Parser,Phusion,Query,Question,Regalia,Righteous,Snippet,Sentinel,Template,Thespian,Unity,Enterprise,Verily,Veri,Website,WideWeb,Yap,Yellow,Zebra,Zygote";
83 83
         $words = $modx->config['captcha_words'] ? $modx->config['captcha_words'] : $words;
84 84
         $arr_words = array_filter(array_map('trim', explode(',', $words)));
85 85
 
86 86
         /* pick one randomly for text verification */
87
-        return (string) $arr_words[array_rand($arr_words)].rand(10,999);
87
+        return (string) $arr_words[array_rand($arr_words)].rand(10, 999);
88 88
     }
89 89
 
90
-    function draw_text() {
90
+    function draw_text(){
91 91
         $dir = dir($this->dir_font);
92 92
         $fontstmp = array();
93 93
         while (false !== ($file = $dir->read())) {
94
-            if(substr($file, -4) == '.ttf') {
94
+            if (substr($file, -4) == '.ttf') {
95 95
                 $fontstmp[] = $this->dir_font.$file;
96 96
             }
97 97
         }
@@ -99,35 +99,35 @@  discard block
 block discarded – undo
99 99
         $text_font = (string) $fontstmp[array_rand($fontstmp)];
100 100
 
101 101
         /* angle for text inclination */
102
-        $text_angle = rand(-9,9);
102
+        $text_angle = rand(-9, 9);
103 103
         /* initial text size */
104 104
         $text_size  = 30;
105 105
         /* calculate text width and height */
106
-        $box        = imagettfbbox ( $text_size, $text_angle, $text_font, $this->word);
107
-        $text_width = $box[2]-$box[0]; //text width
108
-        $text_height= $box[5]-$box[3]; //text height
106
+        $box        = imagettfbbox($text_size, $text_angle, $text_font, $this->word);
107
+        $text_width = $box[2] - $box[0]; //text width
108
+        $text_height = $box[5] - $box[3]; //text height
109 109
 
110 110
         /* adjust text size */
111
-        $text_size  = round((20 * $this->im_width)/$text_width);
111
+        $text_size  = round((20 * $this->im_width) / $text_width);
112 112
 
113 113
         /* recalculate text width and height */
114
-        $box        = imagettfbbox ( $text_size, $text_angle, $text_font, $this->word);
115
-        $text_width = $box[2]-$box[0]; //text width
116
-        $text_height= $box[5]-$box[3]; //text height
114
+        $box        = imagettfbbox($text_size, $text_angle, $text_font, $this->word);
115
+        $text_width = $box[2] - $box[0]; //text width
116
+        $text_height = $box[5] - $box[3]; //text height
117 117
 
118 118
         /* calculate center position of text */
119
-        $text_x         = ($this->im_width - $text_width)/2;
120
-        $text_y         = ($this->im_height - $text_height)/2;
119
+        $text_x         = ($this->im_width - $text_width) / 2;
120
+        $text_y         = ($this->im_height - $text_height) / 2;
121 121
 
122 122
         /* create canvas for text drawing */
123
-        $im_text        = imagecreate ($this->im_width, $this->im_height);
124
-        $bg_color       = imagecolorallocate ($im_text, 255, 255, 255);
123
+        $im_text        = imagecreate($this->im_width, $this->im_height);
124
+        $bg_color       = imagecolorallocate($im_text, 255, 255, 255);
125 125
 
126 126
         /* pick color for text */
127
-        $text_color     = imagecolorallocate ($im_text, 0, 51, 153);
127
+        $text_color     = imagecolorallocate($im_text, 0, 51, 153);
128 128
 
129 129
         /* draw text into canvas */
130
-        imagettftext    (   $im_text,
130
+        imagettftext($im_text,
131 131
                             $text_size,
132 132
                             $text_angle,
133 133
                             $text_x,
@@ -143,19 +143,19 @@  discard block
 block discarded – undo
143 143
     }
144 144
 
145 145
 
146
-    function draw_image() {
146
+    function draw_image(){
147 147
 
148 148
         /* pick one background image randomly from image directory */
149
-        $img_file       = $this->dir_noise."noise".rand(1,4).".jpg";
149
+        $img_file       = $this->dir_noise."noise".rand(1, 4).".jpg";
150 150
 
151 151
         /* create "noise" background image from your image stock*/
152
-        $noise_img      = @imagecreatefromjpeg ($img_file);
152
+        $noise_img      = @imagecreatefromjpeg($img_file);
153 153
         $noise_width    = imagesx($noise_img);
154 154
         $noise_height   = imagesy($noise_img);
155 155
 
156 156
         /* resize the background image to fit the size of image output */
157
-        $this->im       = imagecreatetruecolor($this->im_width,$this->im_height);
158
-        imagecopyresampled ($this->im,
157
+        $this->im       = imagecreatetruecolor($this->im_width, $this->im_height);
158
+        imagecopyresampled($this->im,
159 159
                             $noise_img,
160 160
                             0, 0, 0, 0,
161 161
                             $this->im_width,
@@ -164,17 +164,17 @@  discard block
 block discarded – undo
164 164
                             $noise_height);
165 165
 
166 166
         /* put text image into background image */
167
-        imagecopymerge (    $this->im,
167
+        imagecopymerge($this->im,
168 168
                             $this->draw_text(),
169 169
                             0, 0, 0, 0,
170 170
                             $this->im_width,
171 171
                             $this->im_height,
172
-                            70 );
172
+                            70);
173 173
 
174 174
         return $this->im;
175 175
     }
176 176
 
177
-    function destroy_image() {
177
+    function destroy_image(){
178 178
 
179 179
         imagedestroy($this->im);
180 180
 
Please login to merge, or discard this patch.
manager/includes/extenders/maketable.class.php 1 patch
Spacing   +124 added lines, -124 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  *
9 9
  * @author Jason Coward <[email protected]> (MODX)
10 10
  */
11
-class MakeTable {
11
+class MakeTable{
12 12
 	var $actionField;
13 13
 	var $cellAction;
14 14
 	var $linkAction;
@@ -31,26 +31,26 @@  discard block
 block discarded – undo
31 31
 	var $columnWidths;
32 32
 	var $selectedValues;
33 33
 
34
-	function __construct() {
35
-		$this->fieldHeaders= array();
36
-		$this->excludeFields= array();
37
-		$this->actionField= '';
38
-		$this->cellAction= '';
39
-		$this->linkAction= '';
40
-		$this->tableWidth= '';
41
-		$this->tableClass= '';
42
-		$this->rowHeaderClass= '';
43
-		$this->columnHeaderClass= '';
44
-		$this->rowRegularClass= '';
45
-		$this->rowAlternateClass= 'alt';
46
-		$this->formName= 'tableForm';
47
-		$this->formAction= '[~[*id*]~]';
48
-		$this->formElementName= '';
49
-		$this->formElementType= '';
50
-		$this->rowAlternatingScheme= 'EVEN';
51
-		$this->allOption= 0;
52
-		$this->selectedValues= array();
53
-		$this->extra= '';
34
+	function __construct(){
35
+		$this->fieldHeaders = array();
36
+		$this->excludeFields = array();
37
+		$this->actionField = '';
38
+		$this->cellAction = '';
39
+		$this->linkAction = '';
40
+		$this->tableWidth = '';
41
+		$this->tableClass = '';
42
+		$this->rowHeaderClass = '';
43
+		$this->columnHeaderClass = '';
44
+		$this->rowRegularClass = '';
45
+		$this->rowAlternateClass = 'alt';
46
+		$this->formName = 'tableForm';
47
+		$this->formAction = '[~[*id*]~]';
48
+		$this->formElementName = '';
49
+		$this->formElementType = '';
50
+		$this->rowAlternatingScheme = 'EVEN';
51
+		$this->allOption = 0;
52
+		$this->selectedValues = array();
53
+		$this->extra = '';
54 54
 	}
55 55
 
56 56
 	/**
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
 	 *
59 59
 	 * @param $value A URL to execute when table cells are clicked.
60 60
 	 */
61
-	function setCellAction($value) {
62
-		$this->cellAction= $this->prepareLink($value);
61
+	function setCellAction($value){
62
+		$this->cellAction = $this->prepareLink($value);
63 63
 	}
64 64
 
65 65
 	/**
@@ -67,8 +67,8 @@  discard block
 block discarded – undo
67 67
 	 *
68 68
 	 * @param $value A URL to execute when text within table cells are clicked.
69 69
 	 */
70
-	function setLinkAction($value) {
71
-		$this->linkAction= $this->prepareLink($value);
70
+	function setLinkAction($value){
71
+		$this->linkAction = $this->prepareLink($value);
72 72
 	}
73 73
 
74 74
 	/**
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @param $value A valid width attribute for the HTML TABLE tag
78 78
 	 */
79
-	function setTableWidth($value) {
80
-		$this->tableWidth= $value;
79
+	function setTableWidth($value){
80
+		$this->tableWidth = $value;
81 81
 	}
82 82
 
83 83
 	/**
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @param $value A class for the main HTML TABLE.
87 87
 	 */
88
-	function setTableClass($value) {
89
-		$this->tableClass= $value;
88
+	function setTableClass($value){
89
+		$this->tableClass = $value;
90 90
 	}
91 91
 
92 92
 	/**
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
94 94
 	 *
95 95
 	 * @param $value A class for the main HTML TABLE.
96 96
 	 */
97
-	function setTableID($value) {
98
-		$this->tableID= $value;
97
+	function setTableID($value){
98
+		$this->tableID = $value;
99 99
 	}
100 100
 
101 101
 	/**
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
 	 *
104 104
 	 * @param $value A class for the table header row.
105 105
 	 */
106
-	function setRowHeaderClass($value) {
107
-		$this->rowHeaderClass= $value;
106
+	function setRowHeaderClass($value){
107
+		$this->rowHeaderClass = $value;
108 108
 	}
109 109
 
110 110
 		/**
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	 *
113 113
 	 * @param $value A class for the table header row.
114 114
 	 */
115
-	function setThHeaderClass($value) {
116
-		$this->thClass= $value;
115
+	function setThHeaderClass($value){
116
+		$this->thClass = $value;
117 117
 	}
118 118
 
119 119
 	/**
@@ -121,8 +121,8 @@  discard block
 block discarded – undo
121 121
 	 *
122 122
 	 * @param $value A class for the column header row.
123 123
 	 */
124
-	function setColumnHeaderClass($value) {
125
-		$this->columnHeaderClass= $value;
124
+	function setColumnHeaderClass($value){
125
+		$this->columnHeaderClass = $value;
126 126
 	}
127 127
 
128 128
 	/**
@@ -130,8 +130,8 @@  discard block
 block discarded – undo
130 130
 	 *
131 131
 	 * @param $value A class for regular table rows.
132 132
 	 */
133
-	function setRowRegularClass($value) {
134
-		$this->rowRegularClass= $value;
133
+	function setRowRegularClass($value){
134
+		$this->rowRegularClass = $value;
135 135
 	}
136 136
 
137 137
 	/**
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
 	 *
140 140
 	 * @param $value A class for alternate table rows.
141 141
 	 */
142
-	function setRowAlternateClass($value) {
143
-		$this->rowAlternateClass= $value;
142
+	function setRowAlternateClass($value){
143
+		$this->rowAlternateClass = $value;
144 144
 	}
145 145
 
146 146
 	/**
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
 	 *
149 149
 	 * @param $value Indicates the INPUT form element type attribute.
150 150
 	 */
151
-	function setFormElementType($value) {
152
-		$this->formElementType= $value;
151
+	function setFormElementType($value){
152
+		$this->formElementType = $value;
153 153
 	}
154 154
 
155 155
 	/**
@@ -157,8 +157,8 @@  discard block
 block discarded – undo
157 157
 	 *
158 158
 	 * @param $value Indicates the INPUT form element name attribute.
159 159
 	 */
160
-	function setFormElementName($value) {
161
-		$this->formElementName= $value;
160
+	function setFormElementName($value){
161
+		$this->formElementName = $value;
162 162
 	}
163 163
 
164 164
 	/**
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
167 167
 	 *
168 168
 	 * @param $value Indicates the FORM name attribute.
169 169
 	 */
170
-	function setFormName($value) {
171
-		$this->formName= $value;
170
+	function setFormName($value){
171
+		$this->formName = $value;
172 172
 	}
173 173
 
174 174
 	/**
@@ -176,8 +176,8 @@  discard block
 block discarded – undo
176 176
 	 *
177 177
 	 * @param $value Indicates the FORM action attribute.
178 178
 	 */
179
-	function setFormAction($value) {
180
-		$this->formAction= $value;
179
+	function setFormAction($value){
180
+		$this->formAction = $value;
181 181
 	}
182 182
 
183 183
 	/**
@@ -185,8 +185,8 @@  discard block
 block discarded – undo
185 185
 	 *
186 186
 	 * @param $value An Array of field keys to exclude from the table.
187 187
 	 */
188
-	function setExcludeFields($value) {
189
-		$this->excludeFields= $value;
188
+	function setExcludeFields($value){
189
+		$this->excludeFields = $value;
190 190
 	}
191 191
 
192 192
 	/**
@@ -194,8 +194,8 @@  discard block
 block discarded – undo
194 194
 	 *
195 195
 	 * @param $value 'ODD' or 'EVEN' to indicate the alternate row scheme.
196 196
 	 */
197
-	function setRowAlternatingScheme($value) {
198
-		$this->rowAlternatingScheme= $value;
197
+	function setRowAlternatingScheme($value){
198
+		$this->rowAlternatingScheme = $value;
199 199
 	}
200 200
 
201 201
 	/**
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
 	 *
205 205
 	 * @param $value The key of the field to add as a query string parameter.
206 206
 	 */
207
-	function setActionFieldName($value) {
208
-		$this->actionField= $value;
207
+	function setActionFieldName($value){
208
+		$this->actionField = $value;
209 209
 	}
210 210
 
211 211
 	/**
@@ -214,8 +214,8 @@  discard block
 block discarded – undo
214 214
 	 * @param $value An Array of column widths in the order of the keys in the
215 215
 	 * 			source table array.
216 216
 	 */
217
-	function setColumnWidths($widthArray) {
218
-		$this->columnWidths= $widthArray;
217
+	function setColumnWidths($widthArray){
218
+		$this->columnWidths = $widthArray;
219 219
 	}
220 220
 
221 221
 	/**
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 	 *
224 224
 	 * @param $value Indicates the INPUT form element type attribute.
225 225
 	 */
226
-	function setSelectedValues($valueArray) {
227
-		$this->selectedValues= $valueArray;
226
+	function setSelectedValues($valueArray){
227
+		$this->selectedValues = $valueArray;
228 228
 	}
229 229
 
230 230
 	/**
@@ -233,8 +233,8 @@  discard block
 block discarded – undo
233 233
 	 *
234 234
 	 * @param $value A string of additional content.
235 235
 	 */
236
-	function setExtra($value) {
237
-		$this->extra= $value;
236
+	function setExtra($value){
237
+		$this->extra = $value;
238 238
 	}
239 239
 
240 240
 	/**
@@ -242,10 +242,10 @@  discard block
 block discarded – undo
242 242
 	 *
243 243
 	 * @param $columnPosition The index of the column to get the width for.
244 244
 	 */
245
-	function getColumnWidth($columnPosition) {
246
-		$currentWidth= '';
245
+	function getColumnWidth($columnPosition){
246
+		$currentWidth = '';
247 247
 		if (is_array($this->columnWidths)) {
248
-			$currentWidth= $this->columnWidths[$columnPosition] ? ' width="'.$this->columnWidths[$columnPosition].'" ' : '';
248
+			$currentWidth = $this->columnWidths[$columnPosition] ? ' width="'.$this->columnWidths[$columnPosition].'" ' : '';
249 249
 		}
250 250
 		return $currentWidth;
251 251
 	}
@@ -255,19 +255,19 @@  discard block
 block discarded – undo
255 255
 	 *
256 256
 	 * @param $value The position of the current row being rendered.
257 257
 	 */
258
-	function determineRowClass($position) {
258
+	function determineRowClass($position){
259 259
 		switch ($this->rowAlternatingScheme) {
260 260
 			case 'ODD' :
261
-				$modRemainder= 1;
261
+				$modRemainder = 1;
262 262
 				break;
263 263
 			case 'EVEN' :
264
-				$modRemainder= 0;
264
+				$modRemainder = 0;
265 265
 				break;
266 266
 		}
267 267
 		if ($position % 2 == $modRemainder) {
268
-			$currentClass= $this->rowRegularClass;
268
+			$currentClass = $this->rowRegularClass;
269 269
 		} else {
270
-			$currentClass= $this->rowAlternateClass;
270
+			$currentClass = $this->rowAlternateClass;
271 271
 		}
272 272
 		return ' class="'.$currentClass.'"';
273 273
 	}
@@ -278,9 +278,9 @@  discard block
 block discarded – undo
278 278
 	 *
279 279
 	 * @param $value Indicates the INPUT form element type attribute.
280 280
 	 */
281
-	function getCellAction($currentActionFieldValue) {
281
+	function getCellAction($currentActionFieldValue){
282 282
 		if ($this->cellAction) {
283
-			$cellAction= ' onClick="javascript:window.location=\''.$this->cellAction.$this->actionField.'='.urlencode($currentActionFieldValue).'\'" ';
283
+			$cellAction = ' onClick="javascript:window.location=\''.$this->cellAction.$this->actionField.'='.urlencode($currentActionFieldValue).'\'" ';
284 284
 		}
285 285
 		return $cellAction;
286 286
 	}
@@ -291,10 +291,10 @@  discard block
 block discarded – undo
291 291
 	 * @param $currentActionFieldValue The value to be applied to the link action.
292 292
 	 * @param $value The value of the cell.
293 293
 	 */
294
-	function createCellText($currentActionFieldValue, $value) {
294
+	function createCellText($currentActionFieldValue, $value){
295 295
 		$cell .= $value;
296 296
 		if ($this->linkAction) {
297
-			$cell= '<a href="'.$this->linkAction.$this->actionField.'='.urlencode($currentActionFieldValue).'">'.$cell.'</a>';
297
+			$cell = '<a href="'.$this->linkAction.$this->actionField.'='.urlencode($currentActionFieldValue).'">'.$cell.'</a>';
298 298
 		}
299 299
 		return $cell;
300 300
 	}
@@ -303,8 +303,8 @@  discard block
 block discarded – undo
303 303
 	 * Sets an option to generate a check all link when checkbox is indicated
304 304
 	 * as the table formElementType.
305 305
 	 */
306
-	function setAllOption() {
307
-		$this->allOption= 1;
306
+	function setAllOption(){
307
+		$this->allOption = 1;
308 308
 	}
309 309
 
310 310
 	/**
@@ -312,11 +312,11 @@  discard block
 block discarded – undo
312 312
 	 *
313 313
 	 * @param $value Indicates the INPUT form element type attribute.
314 314
 	 */
315
-	function prepareLink($link) {
315
+	function prepareLink($link){
316 316
 		if (strstr($link, '?')) {
317
-			$end= '&';
317
+			$end = '&';
318 318
 		} else {
319
-			$end= '?';
319
+			$end = '?';
320 320
 		}
321 321
 		return $link.$end;
322 322
 	}
@@ -331,20 +331,20 @@  discard block
 block discarded – undo
331 331
 	 * the $fieldsArray where the values represent the alt heading content
332 332
 	 * for each column.
333 333
 	 */
334
-	function create($fieldsArray, $fieldHeadersArray=array(),$linkpage="") {
334
+	function create($fieldsArray, $fieldHeadersArray = array(), $linkpage = ""){
335 335
 	global $_lang;
336 336
 		if (is_array($fieldsArray)) {
337
-			$i= 0;
337
+			$i = 0;
338 338
 			foreach ($fieldsArray as $fieldName => $fieldValue) {
339 339
 				$table .= "\t<tr".$this->determineRowClass($i).">\n";
340
-				$currentActionFieldValue= $fieldValue[$this->actionField];
340
+				$currentActionFieldValue = $fieldValue[$this->actionField];
341 341
 				if (is_array($this->selectedValues)) {
342
-					$isChecked= array_search($currentActionFieldValue, $this->selectedValues)===false? 0 : 1;
342
+					$isChecked = array_search($currentActionFieldValue, $this->selectedValues) === false ? 0 : 1;
343 343
 				} else {
344
-					$isChecked= false;
344
+					$isChecked = false;
345 345
 				}
346 346
 				$table .= $this->addFormField($currentActionFieldValue, $isChecked);
347
-				$colPosition= 0;
347
+				$colPosition = 0;
348 348
 				foreach ($fieldValue as $key => $value) {
349 349
 					if (!in_array($key, $this->excludeFields)) {
350 350
 						$table .= "\t\t<td".$this->getCellAction($currentActionFieldValue).">";
@@ -352,20 +352,20 @@  discard block
 block discarded – undo
352 352
 						$table .= "</td>\n";
353 353
 						if ($i == 0) {
354 354
 							if (empty ($header) && $this->formElementType) {
355
-								$header .= "\t\t<th style=\"width:32px\" ".($this->thClass ? 'class="'.$this->thClass.'"' : '').">". ($this->allOption ? '<a href="javascript:clickAll()">all</a>' : '')."</th>\n";
355
+								$header .= "\t\t<th style=\"width:32px\" ".($this->thClass ? 'class="'.$this->thClass.'"' : '').">".($this->allOption ? '<a href="javascript:clickAll()">all</a>' : '')."</th>\n";
356 356
 							}
357
-							$headerText= array_key_exists($key, $fieldHeadersArray)? $fieldHeadersArray[$key]: $key;
357
+							$headerText = array_key_exists($key, $fieldHeadersArray) ? $fieldHeadersArray[$key] : $key;
358 358
 							$header .= "\t\t<th".$this->getColumnWidth($colPosition).($this->thClass ? ' class="'.$this->thClass.'" ' : '').">".$headerText."</th>\n";
359 359
 						}
360
-						$colPosition ++;
360
+						$colPosition++;
361 361
 					}
362 362
 				}
363
-				$i ++;
363
+				$i++;
364 364
 				$table .= "\t</tr>\n";
365 365
 			}
366
-			$table= "\n".'<table'. ($this->tableWidth ? ' width="'.$this->tableWidth.'"' : ''). ($this->tableClass ? ' class="'.$this->tableClass.'"' : ''). ($this->tableID ? ' id="'.$this->tableID.'"' : '').">\n". ($header ? "\t<thead>\n\t<tr class=\"".$this->rowHeaderClass."\">\n".$header."\t</tr>\n\t</thead>\n" : '').$table."</table>\n";
366
+			$table = "\n".'<table'.($this->tableWidth ? ' width="'.$this->tableWidth.'"' : '').($this->tableClass ? ' class="'.$this->tableClass.'"' : '').($this->tableID ? ' id="'.$this->tableID.'"' : '').">\n".($header ? "\t<thead>\n\t<tr class=\"".$this->rowHeaderClass."\">\n".$header."\t</tr>\n\t</thead>\n" : '').$table."</table>\n";
367 367
 			if ($this->formElementType) {
368
-				$table= "\n".'<form id="'.$this->formName.'" name="'.$this->formName.'" action="'.$this->formAction.'" method="POST">'.$table;
368
+				$table = "\n".'<form id="'.$this->formName.'" name="'.$this->formName.'" action="'.$this->formAction.'" method="POST">'.$table;
369 369
 			}
370 370
 			if (strlen($this->pageNav) > 1) {//changed to display the pagination if exists.
371 371
 				/* commented this part because of cookie
@@ -400,9 +400,9 @@  discard block
 block discarded – undo
400 400
 			}
401 401
 			if ($this->formElementType) {
402 402
 				if ($this->extra) {
403
-					$table.= "\n".$this->extra."\n";
403
+					$table .= "\n".$this->extra."\n";
404 404
 				}
405
-				$table.= "\n".'</form>'."\n";
405
+				$table .= "\n".'</form>'."\n";
406 406
 			}
407 407
 			return $table;
408 408
 		}
@@ -414,36 +414,36 @@  discard block
 block discarded – undo
414 414
 	 * @param $numRecords The number of records to show per page.
415 415
 	 * @param $qs An optional query string to be appended to the paging links
416 416
 	 */
417
-	function createPagingNavigation($numRecords, $qs='') {
417
+	function createPagingNavigation($numRecords, $qs = ''){
418 418
 		global $_lang;
419
-		$currentPage= (is_numeric($_GET['page']) ? $_GET['page'] : 1);
420
-		$numPages= ceil($numRecords / MAX_DISPLAY_RECORDS_NUM);
419
+		$currentPage = (is_numeric($_GET['page']) ? $_GET['page'] : 1);
420
+		$numPages = ceil($numRecords / MAX_DISPLAY_RECORDS_NUM);
421 421
 		if ($numPages > 1) {
422
-			$currentURL= empty($qs)? '': '?'.$qs;
422
+			$currentURL = empty($qs) ? '' : '?'.$qs;
423 423
 			if ($currentPage > 6) {
424 424
 				$nav .= $this->createPageLink($currentURL, 1, $_lang["pagination_table_first"]);
425 425
 			}
426 426
 			if ($currentPage != 1) {
427
-				$nav .= $this->createPageLink($currentURL, $currentPage -1, '&lt;&lt;');
427
+				$nav .= $this->createPageLink($currentURL, $currentPage - 1, '&lt;&lt;');
428 428
 			}
429
-			$offset= -4 + ($currentPage < 5 ? (5 - $currentPage) : 0);
430
-			$i= 1;
429
+			$offset = -4 + ($currentPage < 5 ? (5 - $currentPage) : 0);
430
+			$i = 1;
431 431
 			while ($i < 10 && ($currentPage + $offset <= $numPages)) {
432 432
 				if ($currentPage == $currentPage + $offset)
433 433
 					$nav .= $this->createPageLink($currentURL, $currentPage + $offset, $currentPage + $offset, true);
434 434
 				else
435 435
 					$nav .= $this->createPageLink($currentURL, $currentPage + $offset, $currentPage + $offset);
436
-				$i ++;
437
-				$offset ++;
436
+				$i++;
437
+				$offset++;
438 438
 			}
439 439
 			if ($currentPage < $numPages) {
440
-				$nav .= $this->createPageLink($currentURL, $currentPage +1, '&gt;&gt;');
440
+				$nav .= $this->createPageLink($currentURL, $currentPage + 1, '&gt;&gt;');
441 441
 			}
442 442
 			if ($currentPage != $numPages) {
443 443
 				$nav .= $this->createPageLink($currentURL, $numPages, $_lang["pagination_table_last"]);
444 444
 			}
445 445
 		}
446
-		$this->pageNav= ' '.$nav;
446
+		$this->pageNav = ' '.$nav;
447 447
 	}
448 448
 
449 449
 	/**
@@ -455,13 +455,13 @@  discard block
 block discarded – undo
455 455
 	 * @param $currentPage Indicates if the link is to the current page.
456 456
 	 * @param $qs And optional query string to be appended to the link.
457 457
 	 */
458
-	function createPageLink($link='', $pageNum, $displayText, $currentPage=false, $qs='') {
458
+	function createPageLink($link = '', $pageNum, $displayText, $currentPage = false, $qs = ''){
459 459
 		global $modx;
460
-		$orderBy= !empty($_GET['orderby'])? '&orderby=' . $_GET['orderby']: '';
461
-		$orderDir= !empty($_GET['orderdir'])? '&orderdir=' . $_GET['orderdir']: '';
462
-		if (!empty($qs)) $qs= "?$qs";
463
-		$link= empty($link)? $modx->makeUrl($modx->documentIdentifier, $modx->documentObject['alias'], $qs . "page=$pageNum$orderBy$orderDir"): $this->prepareLink($link) . "page=$pageNum";
464
-		$nav .= '<li'.($currentPage? ' class="currentPage"': '').'><a'.($currentPage? ' class="currentPage"': '').' href="'.$link.'">'.$displayText.'</a></li>'."\n";
460
+		$orderBy = !empty($_GET['orderby']) ? '&orderby='.$_GET['orderby'] : '';
461
+		$orderDir = !empty($_GET['orderdir']) ? '&orderdir='.$_GET['orderdir'] : '';
462
+		if (!empty($qs)) $qs = "?$qs";
463
+		$link = empty($link) ? $modx->makeUrl($modx->documentIdentifier, $modx->documentObject['alias'], $qs."page=$pageNum$orderBy$orderDir") : $this->prepareLink($link)."page=$pageNum";
464
+		$nav .= '<li'.($currentPage ? ' class="currentPage"' : '').'><a'.($currentPage ? ' class="currentPage"' : '').' href="'.$link.'">'.$displayText.'</a></li>'."\n";
465 465
 		return $nav;
466 466
 	}
467 467
 
@@ -472,10 +472,10 @@  discard block
 block discarded – undo
472 472
 	 * @param $isChecked Indicates if the checked attribute should apply to the
473 473
 	 * element.
474 474
 	 */
475
-	function addFormField($value, $isChecked) {
475
+	function addFormField($value, $isChecked){
476 476
 		if ($this->formElementType) {
477
-			$checked= $isChecked? "checked ": "";
478
-			$field= "\t\t".'<td><input type="'.$this->formElementType.'" name="'. ($this->formElementName ? $this->formElementName : $value).'"  value="'.$value.'" '.$checked.'/></td>'."\n";
477
+			$checked = $isChecked ? "checked " : "";
478
+			$field = "\t\t".'<td><input type="'.$this->formElementType.'" name="'.($this->formElementName ? $this->formElementName : $value).'"  value="'.$value.'" '.$checked.'/></td>'."\n";
479 479
 		}
480 480
 		return $field;
481 481
 	}
@@ -484,9 +484,9 @@  discard block
 block discarded – undo
484 484
 	 * Generates the proper LIMIT clause for queries to retrieve paged results in
485 485
 	 * a MakeTable $fieldsArray.
486 486
 	 */
487
-	function handlePaging() {
488
-		$offset= (is_numeric($_GET['page']) && $_GET['page'] > 0) ? $_GET['page'] - 1 : 0;
489
-		$limitClause= ' LIMIT '. ($offset * MAX_DISPLAY_RECORDS_NUM).', '.MAX_DISPLAY_RECORDS_NUM;
487
+	function handlePaging(){
488
+		$offset = (is_numeric($_GET['page']) && $_GET['page'] > 0) ? $_GET['page'] - 1 : 0;
489
+		$limitClause = ' LIMIT '.($offset * MAX_DISPLAY_RECORDS_NUM).', '.MAX_DISPLAY_RECORDS_NUM;
490 490
 		return $limitClause;
491 491
 	}
492 492
 
@@ -496,12 +496,12 @@  discard block
 block discarded – undo
496 496
 	 *
497 497
 	 * @param $natural_order If true, the results are returned in natural order.
498 498
 	 */
499
-	function handleSorting($natural_order=false) {
500
-		$orderByClause= '';
499
+	function handleSorting($natural_order = false){
500
+		$orderByClause = '';
501 501
 		if (!$natural_order) {
502
-			$orderby= !empty($_GET['orderby'])? $_GET['orderby']: "id";
503
-			$orderdir= !empty($_GET['orderdir'])? $_GET['orderdir']: "DESC";
504
-			$orderbyClause= !empty($orderby)? ' ORDER BY ' . $orderby . ' ' . $orderdir . ' ': "";
502
+			$orderby = !empty($_GET['orderby']) ? $_GET['orderby'] : "id";
503
+			$orderdir = !empty($_GET['orderdir']) ? $_GET['orderdir'] : "DESC";
504
+			$orderbyClause = !empty($orderby) ? ' ORDER BY '.$orderby.' '.$orderdir.' ' : "";
505 505
 		}
506 506
 		return $orderbyClause;
507 507
 	}
@@ -514,15 +514,15 @@  discard block
 block discarded – undo
514 514
 	 * @param $text The text for the link (e.g. table column header).
515 515
 	 * @param $qs An optional query string to append to the order by link.
516 516
 	 */
517
-	function prepareOrderByLink($key, $text, $qs='') {
517
+	function prepareOrderByLink($key, $text, $qs = ''){
518 518
 		global $modx;
519 519
 		if (!empty($_GET['orderdir'])) {
520
-			$orderDir= strtolower($_GET['orderdir'])=='desc'? '&orderdir=asc': '&orderdir=desc';
520
+			$orderDir = strtolower($_GET['orderdir']) == 'desc' ? '&orderdir=asc' : '&orderdir=desc';
521 521
 		} else {
522
-			$orderDir= '&orderdir=asc';
522
+			$orderDir = '&orderdir=asc';
523 523
 		}
524 524
 		if (!empty($qs)) {
525
-			if (!strrpos($qs, '&')==strlen($qs)-1) $qs.= '&';
525
+			if (!strrpos($qs, '&') == strlen($qs) - 1) $qs .= '&';
526 526
 		}
527 527
 		return '<a href="[~'.$modx->documentIdentifier.'~]?'.$qs.'orderby='.$key.$orderDir.'">'.$text.'</a>';
528 528
 	}
Please login to merge, or discard this patch.
manager/includes/extenders/message.quit.inc.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * Message Quit Template
4 4
  *
5 5
  */
6
-if(IN_MANAGER_MODE!="true" && IN_PARSER_MODE!="true") die("<b>INCLUDE ACCESS ERROR</b><br /><br />Direct access to this file prohibited.");
6
+if (IN_MANAGER_MODE != "true" && IN_PARSER_MODE != "true") die("<b>INCLUDE ACCESS ERROR</b><br /><br />Direct access to this file prohibited.");
7 7
 
8 8
 $parsedMessageString = "
9 9
 <html><head><title>EVO Content Manager $version &raquo; $release_date</title>
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 </script>
19 19
 </head><body>
20 20
 ";
21
-if($is_error) {
21
+if ($is_error) {
22 22
 	$parsedMessageString .= "<h3 style='color:red;background:#e0e0e0;padding:2px;'>&nbsp;MODX Parse Error </h3>
23 23
 	<table border='0' cellpadding='1' cellspacing='0'>
24 24
 	<tr><td colspan='3'>MODX encountered the following error while attempting to parse the requested resource:</td></tr>
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
 	<tr><td colspan='3'><b style='color:#003399;'>&laquo; $msg &raquo;</b></td></tr>";
31 31
 }
32 32
 
33
-if(!empty($query)) {
33
+if (!empty($query)) {
34 34
 	$parsedMessageString .= "<tr><td colspan='3'><hr size='1' width='98%' style='color:#e0e0e0'/><b style='color:#999;font-size: 9px;border-left:1px solid #c0c0c0; margin-left:10px;'>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;SQL:&nbsp;<span id='sqlHolder'>$query</span></b><hr size='1' width='98%' style='color:#e0e0e0'/>
35 35
 	&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href='javascript:copyToClip();' style='color:#821517;font-size: 9px; text-decoration: none'>[Copy SQL to ClipBoard]</a><textarea id='holdtext' style='display:none;'></textarea></td></tr>";
36 36
 }
37 37
 
38
-if($text!='') {
38
+if ($text != '') {
39 39
 
40
-	$errortype = array (
40
+	$errortype = array(
41 41
 		E_ERROR          => "Error",
42 42
 		E_WARNING        => "Warning",
43 43
 		E_PARSE          => "Parsing Error",
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	$parsedMessageString .= "<tr><td>&nbsp;&nbsp;Line: </td>";
69 69
 	$parsedMessageString .= "<td colspan='2'>$line</td><td>&nbsp;</td>";
70 70
 	$parsedMessageString .= "</tr>";
71
-	if($source!='') {
71
+	if ($source != '') {
72 72
 		$parsedMessageString .= "<tr><td valign='top'>&nbsp;&nbsp;Line $line source: </td>";
73 73
 		$parsedMessageString .= "<td colspan='2'>$source</td><td>&nbsp;</td>";
74 74
 		$parsedMessageString .= "</tr>";
Please login to merge, or discard this patch.
manager/includes/secure_web_documents.inc.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
2
+if (IN_MANAGER_MODE != "true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 
4 4
 /**
5 5
  *	Secure Web Documents
@@ -10,19 +10,19 @@  discard block
 block discarded – undo
10 10
  *
11 11
  */
12 12
 
13
-function secureWebDocument($docid='') {
13
+function secureWebDocument($docid = ''){
14 14
 	global $modx;
15 15
 
16
-	$modx->db->update('privateweb = 0', $modx->getFullTableName("site_content"), ($docid>0 ? "id='$docid'":"privateweb = 1"));
16
+	$modx->db->update('privateweb = 0', $modx->getFullTableName("site_content"), ($docid > 0 ? "id='$docid'" : "privateweb = 1"));
17 17
 	$rs = $modx->db->select(
18 18
 		'DISTINCT sc.id',
19 19
 		$modx->getFullTableName("site_content")." sc
20 20
 			LEFT JOIN ".$modx->getFullTableName("document_groups")." dg ON dg.document = sc.id
21 21
 			LEFT JOIN ".$modx->getFullTableName("webgroup_access")." wga ON wga.documentgroup = dg.document_group",
22
-		($docid>0 ? " sc.id='{$docid}' AND ":"")."wga.id>0"
22
+		($docid > 0 ? " sc.id='{$docid}' AND " : "")."wga.id>0"
23 23
 		);
24
-	$ids = $modx->db->getColumn("id",$rs);
25
-	if(count($ids)>0) {
26
-		$modx->db->update('privateweb = 1', $modx->getFullTableName("site_content"), "id IN (".implode(", ",$ids).")");
24
+	$ids = $modx->db->getColumn("id", $rs);
25
+	if (count($ids) > 0) {
26
+		$modx->db->update('privateweb = 1', $modx->getFullTableName("site_content"), "id IN (".implode(", ", $ids).")");
27 27
 	}
28 28
 }
Please login to merge, or discard this patch.