Completed
Push — develop ( 923a1c...1e9876 )
by Maxim
47s queued 29s
created
manager/processors/save_settings.processor.php 1 patch
Indentation   +106 added lines, -106 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('settings')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 $data = $_POST;
7 7
 // lose the POST now, gets rid of quirky issue with Safari 3 - see FS#972
@@ -9,41 +9,41 @@  discard block
 block discarded – undo
9 9
 
10 10
 if($data['friendly_urls']==='1' && strpos($_SERVER['SERVER_SOFTWARE'],'IIS')===false)
11 11
 {
12
-	$htaccess        = $modx->config['base_path'] . '.htaccess';
13
-	$sample_htaccess = $modx->config['base_path'] . 'ht.access';
14
-	$dir = '/' . trim($modx->config['base_url'],'/');
15
-	if(is_file($htaccess))
16
-	{
17
-		$_ = file_get_contents($htaccess);
18
-		if(strpos($_,'RewriteBase')===false)
19
-		{
20
-			$warnings[] = $_lang["settings_friendlyurls_alert2"];
21
-		}
22
-		elseif(is_writable($htaccess))
23
-		{
24
-			$_ = preg_replace('@RewriteBase.+@',"RewriteBase {$dir}", $_);
25
-			if(!@file_put_contents($htaccess,$_))
26
-			{
27
-				$warnings[] = $_lang["settings_friendlyurls_alert2"];
28
-			}
29
-		}
30
-	}
31
-	elseif(is_file($sample_htaccess))
32
-	{
33
-		if(!@rename($sample_htaccess,$htaccess))
12
+    $htaccess        = $modx->config['base_path'] . '.htaccess';
13
+    $sample_htaccess = $modx->config['base_path'] . 'ht.access';
14
+    $dir = '/' . trim($modx->config['base_url'],'/');
15
+    if(is_file($htaccess))
16
+    {
17
+        $_ = file_get_contents($htaccess);
18
+        if(strpos($_,'RewriteBase')===false)
34 19
         {
35
-        	$warnings[] = $_lang["settings_friendlyurls_alert"];
36
-		}
37
-		elseif($modx->config['base_url']!=='/')
38
-		{
39
-			$_ = file_get_contents($htaccess);
40
-			$_ = preg_replace('@RewriteBase.+@',"RewriteBase {$dir}", $_);
41
-			if(!@file_put_contents($htaccess,$_))
42
-			{
43
-				$warnings[] = $_lang["settings_friendlyurls_alert2"];
44
-			}
45
-		}
46
-	}
20
+            $warnings[] = $_lang["settings_friendlyurls_alert2"];
21
+        }
22
+        elseif(is_writable($htaccess))
23
+        {
24
+            $_ = preg_replace('@RewriteBase.+@',"RewriteBase {$dir}", $_);
25
+            if(!@file_put_contents($htaccess,$_))
26
+            {
27
+                $warnings[] = $_lang["settings_friendlyurls_alert2"];
28
+            }
29
+        }
30
+    }
31
+    elseif(is_file($sample_htaccess))
32
+    {
33
+        if(!@rename($sample_htaccess,$htaccess))
34
+        {
35
+            $warnings[] = $_lang["settings_friendlyurls_alert"];
36
+        }
37
+        elseif($modx->config['base_url']!=='/')
38
+        {
39
+            $_ = file_get_contents($htaccess);
40
+            $_ = preg_replace('@RewriteBase.+@',"RewriteBase {$dir}", $_);
41
+            if(!@file_put_contents($htaccess,$_))
42
+            {
43
+                $warnings[] = $_lang["settings_friendlyurls_alert2"];
44
+            }
45
+        }
46
+    }
47 47
 }
48 48
 
49 49
 if (file_exists(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/css/styles.min.css')) {
@@ -54,19 +54,19 @@  discard block
 block discarded – undo
54 54
 $data['rb_base_dir']      = str_replace('[(base_path)]',MODX_BASE_PATH,$data['rb_base_dir']); 
55 55
 
56 56
 if (isset($data) && count($data) > 0) {
57
-	if(isset($data['manager_language'])) {
58
-		$lang_path = MODX_MANAGER_PATH . 'includes/lang/' . $data['manager_language'] . '.inc.php';
59
-		if(is_file($lang_path)) {
60
-			include($lang_path);
57
+    if(isset($data['manager_language'])) {
58
+        $lang_path = MODX_MANAGER_PATH . 'includes/lang/' . $data['manager_language'] . '.inc.php';
59
+        if(is_file($lang_path)) {
60
+            include($lang_path);
61 61
             global $modx_lang_attribute;
62 62
             $data['lang_code'] = !$modx_lang_attribute ? 'en' : $modx_lang_attribute;
63
-		}
64
-	}
65
-	$savethese = array();
66
-	$data['sys_files_checksum'] = $modx->manager->getSystemChecksum($data['check_files_onlogin']);
67
-	$data['mail_check_timeperiod'] = intval($data['mail_check_timeperiod']) < 60 ? 60 : $data['mail_check_timeperiod']; // updateMail() in mainMenu no faster than every minute
68
-	foreach ($data as $k => $v) {
69
-		switch ($k) {
63
+        }
64
+    }
65
+    $savethese = array();
66
+    $data['sys_files_checksum'] = $modx->manager->getSystemChecksum($data['check_files_onlogin']);
67
+    $data['mail_check_timeperiod'] = intval($data['mail_check_timeperiod']) < 60 ? 60 : $data['mail_check_timeperiod']; // updateMail() in mainMenu no faster than every minute
68
+    foreach ($data as $k => $v) {
69
+        switch ($k) {
70 70
             case 'settings_version':{
71 71
                 if($modx->getVersionData('version')!=$data['settings_version']){
72 72
                     $modx->logEvent(17,2,'<pre>'.var_export($data['settings_version'],true).'</pre>','fake settings_version');
@@ -74,24 +74,24 @@  discard block
 block discarded – undo
74 74
                 }
75 75
                 break;
76 76
             }
77
-			case 'error_page':
78
-			case 'unauthorized_page':
79
-			if (trim($v) == '' || !is_numeric($v)) {
80
-				$v = $data['site_start'];
81
-			}
82
-			break;
77
+            case 'error_page':
78
+            case 'unauthorized_page':
79
+            if (trim($v) == '' || !is_numeric($v)) {
80
+                $v = $data['site_start'];
81
+            }
82
+            break;
83 83
 	
84
-			case 'lst_custom_contenttype':
85
-			case 'txt_custom_contenttype':
86
-				// Skip these
87
-				$k = '';
88
-				break;
89
-			case 'rb_base_dir':
90
-			case 'rb_base_url':
91
-			case 'filemanager_path':
92
-				$v = trim($v);
93
-				$v = rtrim($v,'/') . '/';
94
-				break;
84
+            case 'lst_custom_contenttype':
85
+            case 'txt_custom_contenttype':
86
+                // Skip these
87
+                $k = '';
88
+                break;
89
+            case 'rb_base_dir':
90
+            case 'rb_base_url':
91
+            case 'filemanager_path':
92
+                $v = trim($v);
93
+                $v = rtrim($v,'/') . '/';
94
+                break;
95 95
             case 'manager_language':
96 96
                 $langDir = realpath(MODX_MANAGER_PATH . 'includes/lang');
97 97
                 $langFile = realpath(MODX_MANAGER_PATH . 'includes/lang/' . $v . '.inc.php');
@@ -99,56 +99,56 @@  discard block
 block discarded – undo
99 99
                 if($langDir !== $langFileDir || !file_exists($langFile)) {
100 100
                     $v = 'english';
101 101
                 }
102
-				break;
103
-			case 'smtppw':
104
-				if ($v !== '********************' && $v !== '') {
105
-					$v = trim($v);
106
-					$v = base64_encode($v) . substr(str_shuffle('abcdefghjkmnpqrstuvxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789'), 0, 7);
107
-					$v = str_replace('=','%',$v);
108
-				} elseif ($v === '********************') {
109
-					$k = '';
110
-				}
111
-				break;
102
+                break;
103
+            case 'smtppw':
104
+                if ($v !== '********************' && $v !== '') {
105
+                    $v = trim($v);
106
+                    $v = base64_encode($v) . substr(str_shuffle('abcdefghjkmnpqrstuvxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789'), 0, 7);
107
+                    $v = str_replace('=','%',$v);
108
+                } elseif ($v === '********************') {
109
+                    $k = '';
110
+                }
111
+                break;
112 112
             case 'valid_hostnames':
113
-				$v = str_replace(array(' ,', ', '), ',', $v);
114
-				if ($v !== ',') {
115
-					$v = ($v != 'MODX_SITE_HOSTNAMES') ? $v : '';
116
-					$configString = '<?php' . "\n" . 'define(\'MODX_SITE_HOSTNAMES\', \'' . $v . '\');' . "\n";
117
-					@file_put_contents(MODX_BASE_PATH . 'assets/cache/siteHostnames.php', $configString);
118
-				}
119
-				$k = '';
120
-				break;
121
-			case 'session_timeout':
122
-				$mail_check_timeperiod = $data['mail_check_timeperiod'];
123
-				$v = intval($v) < ($data['mail_check_timeperiod']/60+1) ? ($data['mail_check_timeperiod']/60+1) : $v; // updateMail() in mainMenu pings as per mail_check_timeperiod, so +1min is minimum
124
-				break;
125
-			default:
126
-			break;
127
-		}
128
-		$v = is_array($v) ? implode(",", $v) : $v;
113
+                $v = str_replace(array(' ,', ', '), ',', $v);
114
+                if ($v !== ',') {
115
+                    $v = ($v != 'MODX_SITE_HOSTNAMES') ? $v : '';
116
+                    $configString = '<?php' . "\n" . 'define(\'MODX_SITE_HOSTNAMES\', \'' . $v . '\');' . "\n";
117
+                    @file_put_contents(MODX_BASE_PATH . 'assets/cache/siteHostnames.php', $configString);
118
+                }
119
+                $k = '';
120
+                break;
121
+            case 'session_timeout':
122
+                $mail_check_timeperiod = $data['mail_check_timeperiod'];
123
+                $v = intval($v) < ($data['mail_check_timeperiod']/60+1) ? ($data['mail_check_timeperiod']/60+1) : $v; // updateMail() in mainMenu pings as per mail_check_timeperiod, so +1min is minimum
124
+                break;
125
+            default:
126
+            break;
127
+        }
128
+        $v = is_array($v) ? implode(",", $v) : $v;
129 129
 		
130
-		$modx->config[$k] = $v;
130
+        $modx->config[$k] = $v;
131 131
 		
132
-		if(!empty($k)) $savethese[] = '(\''.$modx->db->escape($k).'\', \''.$modx->db->escape($v).'\')';
133
-	}
132
+        if(!empty($k)) $savethese[] = '(\''.$modx->db->escape($k).'\', \''.$modx->db->escape($v).'\')';
133
+    }
134 134
 	
135
-	// Run a single query to save all the values
136
-	$sql = "REPLACE INTO ".$modx->getFullTableName("system_settings")." (setting_name, setting_value)
135
+    // Run a single query to save all the values
136
+    $sql = "REPLACE INTO ".$modx->getFullTableName("system_settings")." (setting_name, setting_value)
137 137
 		VALUES ".implode(', ', $savethese);
138
-	$modx->db->query($sql);
138
+    $modx->db->query($sql);
139 139
 	
140
-	// Reset Template Pages
141
-	if (isset($data['reset_template'])) {
142
-		$newtemplate = intval($data['default_template']);
143
-		$oldtemplate = intval($data['old_template']);
144
-		$tbl = $modx->getFullTableName('site_content');
145
-		$reset = $data['reset_template'];
146
-		if($reset==1) $modx->db->update(array('template' => $newtemplate), $tbl, "type='document'");
147
-		else if($reset==2) $modx->db->update(array('template' => $newtemplate), $tbl, "template='{$oldtemplate}'");
148
-	}
140
+    // Reset Template Pages
141
+    if (isset($data['reset_template'])) {
142
+        $newtemplate = intval($data['default_template']);
143
+        $oldtemplate = intval($data['old_template']);
144
+        $tbl = $modx->getFullTableName('site_content');
145
+        $reset = $data['reset_template'];
146
+        if($reset==1) $modx->db->update(array('template' => $newtemplate), $tbl, "type='document'");
147
+        else if($reset==2) $modx->db->update(array('template' => $newtemplate), $tbl, "template='{$oldtemplate}'");
148
+    }
149 149
 	
150
-	// empty cache
151
-	$modx->clearCache('full');
150
+    // empty cache
151
+    $modx->clearCache('full');
152 152
 }
153 153
 $header="Location: index.php?a=7&r=10";
154 154
 header($header);
Please login to merge, or discard this patch.
manager/processors/remove_installer.processor.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -16,24 +16,24 @@
 block discarded – undo
16 16
 $pth = dirname(dirname(dirname(__FILE__)))."/install/";
17 17
 $pth = str_replace("\\","/",$pth);
18 18
 if(isset($_GET["rminstall"])) {
19
-	if(is_dir($pth)) {
20
-		if(!rmdirRecursive($pth)) $msg="An error occured while attempting to remove the install folder";
21
-	}
19
+    if(is_dir($pth)) {
20
+        if(!rmdirRecursive($pth)) $msg="An error occured while attempting to remove the install folder";
21
+    }
22 22
 }
23 23
 if($msg) echo "<script>alert('".addslashes($msg)."');</script>";
24 24
 echo "<script>window.location='../index.php?a=2';</script>";
25 25
 
26 26
 // rmdirRecursive - detects symbollic links on unix
27 27
 function rmdirRecursive($path,$followLinks=false) {   
28
-   $dir = opendir($path) ;
29
-   while ($entry = readdir($dir)) {       
30
-	   if (is_file("$path/$entry") || ((!$followLinks) && is_link("$path/$entry"))) {
31
-		   @unlink( "$path/$entry" );
32
-	   }
33
-	   elseif (is_dir("$path/$entry") && $entry!='.' && $entry!='..') {
34
-		   rmdirRecursive("$path/$entry"); // recursive
35
-	   }
36
-   }
37
-   closedir($dir);
38
-   return @rmdir($path);
28
+    $dir = opendir($path) ;
29
+    while ($entry = readdir($dir)) {       
30
+        if (is_file("$path/$entry") || ((!$followLinks) && is_link("$path/$entry"))) {
31
+            @unlink( "$path/$entry" );
32
+        }
33
+        elseif (is_dir("$path/$entry") && $entry!='.' && $entry!='..') {
34
+            rmdirRecursive("$path/$entry"); // recursive
35
+        }
36
+    }
37
+    closedir($dir);
38
+    return @rmdir($path);
39 39
 }
Please login to merge, or discard this patch.
manager/processors/save_content.processor.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -491,7 +491,7 @@
 block discarded – undo
491 491
             }elseif ((!empty($pub_date)&& $pub_date<=$currentdate && $published)) {
492 492
             $publishedon = $pub_date;
493 493
             $publishedby = $modx->getLoginUserID();
494
-               }elseif ($was_published && !$published) {
494
+                }elseif ($was_published && !$published) {
495 495
             $publishedon = 0;
496 496
             $publishedby = 0;
497 497
         } else {
Please login to merge, or discard this patch.
manager/processors/empty_table.processor.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('settings')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 
7 7
 $modx->db->truncate($modx->getFullTableName('manager_log'));
Please login to merge, or discard this patch.
manager/processors/delete_module.processor.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('delete_module')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 
7 7
 $id = isset($_GET['id'])? intval($_GET['id']) : 0;
8 8
 if($id==0) {
9
-	$modx->webAlertAndQuit($_lang["error_no_id"]);
9
+    $modx->webAlertAndQuit($_lang["error_no_id"]);
10 10
 }
11 11
 
12 12
 // Set the item name for logger
@@ -15,9 +15,9 @@  discard block
 block discarded – undo
15 15
 
16 16
 // invoke OnBeforeModFormDelete event
17 17
 $modx->invokeEvent("OnBeforeModFormDelete",
18
-	array(
19
-		"id"	=> $id
20
-	));
18
+    array(
19
+        "id"	=> $id
20
+    ));
21 21
 
22 22
 // delete the module.
23 23
 $modx->db->delete($modx->getFullTableName('site_modules'), "id='{$id}'");
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 
31 31
 // invoke OnModFormDelete event
32 32
 $modx->invokeEvent("OnModFormDelete",
33
-	array(
34
-		"id"	=> $id
35
-	));
33
+    array(
34
+        "id"	=> $id
35
+    ));
36 36
 
37 37
 // empty cache
38 38
 $modx->clearCache('full');
Please login to merge, or discard this patch.
manager/processors/save_password.processor.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('save_password')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 
7 7
 $id = $_POST['id'];
@@ -9,26 +9,26 @@  discard block
 block discarded – undo
9 9
 $pass2 = $_POST['pass2'];
10 10
 
11 11
 if($pass1!=$pass2){
12
-	$modx->webAlertAndQuit("Passwords don't match!");
12
+    $modx->webAlertAndQuit("Passwords don't match!");
13 13
 }
14 14
 
15 15
 if(strlen($pass1)<6){
16
-	$modx->webAlertAndQuit("Password is too short. Please specify a password of at least 6 characters.");
16
+    $modx->webAlertAndQuit("Password is too short. Please specify a password of at least 6 characters.");
17 17
 }
18 18
 
19 19
     $pass1 = $modx->htmlspecialchars($pass1, ENT_NOQUOTES);
20
-	$tbl_manager_users = $modx->getFullTableName('manager_users');
21
-	$uid = $modx->getLoginUserID();
22
-	$modx->loadExtension('phpass');
23
-	$f['password'] = $modx->phpass->HashPassword($pass1);
24
-	$modx->db->update($f,$tbl_manager_users,"id='{$uid}'");
20
+    $tbl_manager_users = $modx->getFullTableName('manager_users');
21
+    $uid = $modx->getLoginUserID();
22
+    $modx->loadExtension('phpass');
23
+    $f['password'] = $modx->phpass->HashPassword($pass1);
24
+    $modx->db->update($f,$tbl_manager_users,"id='{$uid}'");
25 25
 
26
-	// invoke OnManagerChangePassword event
27
-	$modx->invokeEvent('OnManagerChangePassword', array (
28
-		'userid' => $uid,
29
-		'username' => $_SESSION['mgrShortname'],
30
-		'userpassword' => $pass1
31
-	));
26
+    // invoke OnManagerChangePassword event
27
+    $modx->invokeEvent('OnManagerChangePassword', array (
28
+        'userid' => $uid,
29
+        'username' => $_SESSION['mgrShortname'],
30
+        'userpassword' => $pass1
31
+    ));
32 32
 
33 33
 $header="Location: index.php?a=2";
34 34
 header($header);
Please login to merge, or discard this patch.
manager/processors/delete_htmlsnippet.processor.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('delete_snippet')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 
7 7
 $id = isset($_GET['id'])? intval($_GET['id']) : 0;
8 8
 if($id==0) {
9
-	$modx->webAlertAndQuit($_lang["error_no_id"]);
9
+    $modx->webAlertAndQuit($_lang["error_no_id"]);
10 10
 }
11 11
 
12 12
 // Set the item name for logger
@@ -15,18 +15,18 @@  discard block
 block discarded – undo
15 15
 
16 16
 // invoke OnBeforeChunkFormDelete event
17 17
 $modx->invokeEvent("OnBeforeChunkFormDelete",
18
-	array(
19
-		"id"	=> $id
20
-	));
18
+    array(
19
+        "id"	=> $id
20
+    ));
21 21
 
22 22
 // delete the chunk.
23 23
 $modx->db->delete($modx->getFullTableName('site_htmlsnippets'), "id='{$id}'");
24 24
 
25 25
 // invoke OnChunkFormDelete event
26 26
 $modx->invokeEvent("OnChunkFormDelete",
27
-	array(
28
-		"id"	=> $id
29
-	));
27
+    array(
28
+        "id"	=> $id
29
+    ));
30 30
 
31 31
 // empty cache
32 32
 $modx->clearCache('full');
Please login to merge, or discard this patch.
manager/processors/access_groups.processor.php 1 patch
Indentation   +95 added lines, -95 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE!="true") die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3 3
 if(!$modx->hasPermission('access_permissions')) {
4
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
4
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
5 5
 }
6 6
 
7 7
 // access group processor.
@@ -18,113 +18,113 @@  discard block
 block discarded – undo
18 18
 $operation = $_REQUEST['operation'];
19 19
 
20 20
 switch ($operation) {
21
-	case "add_user_group" :
22
-		$newgroup = $_REQUEST['newusergroup'];
23
-		if(empty($newgroup)) {
24
-			$modx->webAlertAndQuit("No group name specified.");
25
-		} else {
26
-			$id = $modx->db->insert(array('name' => $modx->db->escape($newgroup)), $tbl_membergroup_names);
21
+    case "add_user_group" :
22
+        $newgroup = $_REQUEST['newusergroup'];
23
+        if(empty($newgroup)) {
24
+            $modx->webAlertAndQuit("No group name specified.");
25
+        } else {
26
+            $id = $modx->db->insert(array('name' => $modx->db->escape($newgroup)), $tbl_membergroup_names);
27 27
 
28
-			// invoke OnManagerCreateGroup event
29
-			$modx->invokeEvent('OnManagerCreateGroup', array(
30
-				'groupid'   => $id,
31
-				'groupname' => $newgroup,
32
-			));
33
-		}
34
-	break;
35
-	case "add_document_group" :
36
-		$newgroup = $_REQUEST['newdocgroup'];
37
-		if(empty($newgroup)) {
38
-			$modx->webAlertAndQuit("No group name specified.");
39
-		} else {
40
-			$id = $modx->db->insert(array('name' => $modx->db->escape($newgroup)), $tbl_documentgroup_names);
28
+            // invoke OnManagerCreateGroup event
29
+            $modx->invokeEvent('OnManagerCreateGroup', array(
30
+                'groupid'   => $id,
31
+                'groupname' => $newgroup,
32
+            ));
33
+        }
34
+    break;
35
+    case "add_document_group" :
36
+        $newgroup = $_REQUEST['newdocgroup'];
37
+        if(empty($newgroup)) {
38
+            $modx->webAlertAndQuit("No group name specified.");
39
+        } else {
40
+            $id = $modx->db->insert(array('name' => $modx->db->escape($newgroup)), $tbl_documentgroup_names);
41 41
 
42
-			// invoke OnCreateDocGroup event
43
-			$modx->invokeEvent('OnCreateDocGroup', array(
44
-				'groupid'   => $id,
45
-				'groupname' => $newgroup,
46
-			));
47
-		}
48
-	break;
49
-	case "delete_user_group" :
50
-		$updategroupaccess = true;
51
-		$usergroup = intval($_REQUEST['usergroup']);
52
-		if(empty($usergroup)) {
53
-			$modx->webAlertAndQuit("No user group id specified for deletion.");
54
-		} else {
55
-			$modx->db->delete($tbl_membergroup_names, "id='{$usergroup}'");
42
+            // invoke OnCreateDocGroup event
43
+            $modx->invokeEvent('OnCreateDocGroup', array(
44
+                'groupid'   => $id,
45
+                'groupname' => $newgroup,
46
+            ));
47
+        }
48
+    break;
49
+    case "delete_user_group" :
50
+        $updategroupaccess = true;
51
+        $usergroup = intval($_REQUEST['usergroup']);
52
+        if(empty($usergroup)) {
53
+            $modx->webAlertAndQuit("No user group id specified for deletion.");
54
+        } else {
55
+            $modx->db->delete($tbl_membergroup_names, "id='{$usergroup}'");
56 56
 			
57
-			$modx->db->delete($tbl_membergroup_access, "membergroup='{$usergroup}'");
57
+            $modx->db->delete($tbl_membergroup_access, "membergroup='{$usergroup}'");
58 58
 			
59
-			$modx->db->delete($tbl_member_groups, "user_group='{$usergroup}'");
60
-		}
61
-	break;
62
-	case "delete_document_group" :
63
-		$group = intval($_REQUEST['documentgroup']);
64
-		if(empty($group)) {
65
-			$modx->webAlertAndQuit("No document group id specified for deletion.");
66
-		} else {
67
-			$modx->db->delete($tbl_documentgroup_names, "id='{$group}'");
59
+            $modx->db->delete($tbl_member_groups, "user_group='{$usergroup}'");
60
+        }
61
+    break;
62
+    case "delete_document_group" :
63
+        $group = intval($_REQUEST['documentgroup']);
64
+        if(empty($group)) {
65
+            $modx->webAlertAndQuit("No document group id specified for deletion.");
66
+        } else {
67
+            $modx->db->delete($tbl_documentgroup_names, "id='{$group}'");
68 68
 			
69
-			$modx->db->delete($tbl_membergroup_access, "documentgroup='{$group}'");
69
+            $modx->db->delete($tbl_membergroup_access, "documentgroup='{$group}'");
70 70
 			
71
-			$modx->db->delete($tbl_document_groups, "document_group='{$group}'");
72
-		}
73
-	break;
74
-	case "rename_user_group" :
75
-		$newgroupname = $_REQUEST['newgroupname'];
76
-		if(empty($newgroupname)) {
77
-			$modx->webAlertAndQuit("No group name specified.");
78
-		}
79
-		$groupid = intval($_REQUEST['groupid']);
80
-		if(empty($groupid)) {
81
-			$modx->webAlertAndQuit("No group id specified for rename.");
82
-		}
71
+            $modx->db->delete($tbl_document_groups, "document_group='{$group}'");
72
+        }
73
+    break;
74
+    case "rename_user_group" :
75
+        $newgroupname = $_REQUEST['newgroupname'];
76
+        if(empty($newgroupname)) {
77
+            $modx->webAlertAndQuit("No group name specified.");
78
+        }
79
+        $groupid = intval($_REQUEST['groupid']);
80
+        if(empty($groupid)) {
81
+            $modx->webAlertAndQuit("No group id specified for rename.");
82
+        }
83 83
 
84
-		$modx->db->update(array('name' => $modx->db->escape($newgroupname)), $tbl_membergroup_names, "id='{$groupid}'");
85
-	break;
86
-	case "rename_document_group" :
87
-		$newgroupname = $_REQUEST['newgroupname'];
88
-		if(empty($newgroupname)) {
89
-			$modx->webAlertAndQuit("No group name specified.");
90
-		}
91
-		$groupid = intval($_REQUEST['groupid']);
92
-		if(empty($groupid)) {
93
-			$modx->webAlertAndQuit("No group id specified for rename.");
94
-		}
84
+        $modx->db->update(array('name' => $modx->db->escape($newgroupname)), $tbl_membergroup_names, "id='{$groupid}'");
85
+    break;
86
+    case "rename_document_group" :
87
+        $newgroupname = $_REQUEST['newgroupname'];
88
+        if(empty($newgroupname)) {
89
+            $modx->webAlertAndQuit("No group name specified.");
90
+        }
91
+        $groupid = intval($_REQUEST['groupid']);
92
+        if(empty($groupid)) {
93
+            $modx->webAlertAndQuit("No group id specified for rename.");
94
+        }
95 95
 
96
-		$modx->db->update(array('name' => $modx->db->escape($newgroupname)), $tbl_documentgroup_names, "id='{$groupid}'");
97
-	break;
98
-	case "add_document_group_to_user_group" :
99
-		$updategroupaccess = true;
100
-		$usergroup = intval($_REQUEST['usergroup']);
101
-		$docgroup = intval($_REQUEST['docgroup']);
102
-		$rs = $modx->db->select('COUNT(*)', $tbl_membergroup_access, "membergroup='{$usergroup}' AND documentgroup='{$docgroup}'");
103
-		$limit = $modx->db->getValue($rs);
104
-		if($limit<=0) {
105
-			$modx->db->insert(array('membergroup' => $usergroup, 'documentgroup' => $docgroup), $tbl_membergroup_access);
106
-		} else {
107
-			//alert user that coupling already exists?
108
-		}
109
-	break;
110
-	case "remove_document_group_from_user_group" :
111
-		$updategroupaccess = true;
112
-		$coupling = intval($_REQUEST['coupling']);
113
-		$modx->db->delete($tbl_membergroup_access, "id='{$coupling}'");
114
-	break;
115
-	default :
116
-		$modx->webAlertAndQuit("No operation set in request.");
96
+        $modx->db->update(array('name' => $modx->db->escape($newgroupname)), $tbl_documentgroup_names, "id='{$groupid}'");
97
+    break;
98
+    case "add_document_group_to_user_group" :
99
+        $updategroupaccess = true;
100
+        $usergroup = intval($_REQUEST['usergroup']);
101
+        $docgroup = intval($_REQUEST['docgroup']);
102
+        $rs = $modx->db->select('COUNT(*)', $tbl_membergroup_access, "membergroup='{$usergroup}' AND documentgroup='{$docgroup}'");
103
+        $limit = $modx->db->getValue($rs);
104
+        if($limit<=0) {
105
+            $modx->db->insert(array('membergroup' => $usergroup, 'documentgroup' => $docgroup), $tbl_membergroup_access);
106
+        } else {
107
+            //alert user that coupling already exists?
108
+        }
109
+    break;
110
+    case "remove_document_group_from_user_group" :
111
+        $updategroupaccess = true;
112
+        $coupling = intval($_REQUEST['coupling']);
113
+        $modx->db->delete($tbl_membergroup_access, "id='{$coupling}'");
114
+    break;
115
+    default :
116
+        $modx->webAlertAndQuit("No operation set in request.");
117 117
 }
118 118
 
119 119
 // secure manager documents - flag as private
120 120
 if($updategroupaccess==true){
121
-	include MODX_MANAGER_PATH."includes/secure_mgr_documents.inc.php";
122
-	secureMgrDocument();
121
+    include MODX_MANAGER_PATH."includes/secure_mgr_documents.inc.php";
122
+    secureMgrDocument();
123 123
 
124
-	// Update the private group column
125
-	$modx->db->update(
126
-		'dgn.private_memgroup = (mga.membergroup IS NOT NULL)',
127
-		"{$tbl_documentgroup_names} AS dgn LEFT JOIN {$tbl_membergroup_access} AS mga ON mga.documentgroup = dgn.id");
124
+    // Update the private group column
125
+    $modx->db->update(
126
+        'dgn.private_memgroup = (mga.membergroup IS NOT NULL)',
127
+        "{$tbl_documentgroup_names} AS dgn LEFT JOIN {$tbl_membergroup_access} AS mga ON mga.documentgroup = dgn.id");
128 128
 }
129 129
 
130 130
 $header = "Location: index.php?a=40";
Please login to merge, or discard this patch.
manager/processors/save_web_user.processor.php 1 patch
Indentation   +277 added lines, -277 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if(IN_MANAGER_MODE != "true") {
3
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 if(!$modx->hasPermission('save_web_user')) {
6
-	$modx->webAlertAndQuit($_lang["error_no_privileges"]);
6
+    $modx->webAlertAndQuit($_lang["error_no_privileges"]);
7 7
 }
8 8
 
9 9
 $tbl_web_users = $modx->getFullTableName('web_users');
@@ -12,10 +12,10 @@  discard block
 block discarded – undo
12 12
 
13 13
 $input = $_POST;
14 14
 foreach($input as $k => $v) {
15
-	if($k !== 'comment') {
16
-		$v = sanitize($v);
17
-	}
18
-	$input[$k] = $v;
15
+    if($k !== 'comment') {
16
+        $v = sanitize($v);
17
+    }
18
+    $input[$k] = $v;
19 19
 }
20 20
 
21 21
 $id = intval($input['id']);
@@ -51,80 +51,80 @@  discard block
 block discarded – undo
51 51
 
52 52
 // verify password
53 53
 if($passwordgenmethod == "spec" && $input['specifiedpassword'] != $input['confirmpassword']) {
54
-	webAlertAndQuit("Password typed is mismatched");
54
+    webAlertAndQuit("Password typed is mismatched");
55 55
 }
56 56
 
57 57
 // verify email
58 58
 if($email == '' || !preg_match("/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,24}$/i", $email)) {
59
-	webAlertAndQuit("E-mail address doesn't seem to be valid!");
59
+    webAlertAndQuit("E-mail address doesn't seem to be valid!");
60 60
 }
61 61
 
62 62
 switch($input['mode']) {
63
-	case '87' : // new user
64
-		// check if this user name already exist
65
-		$rs = $modx->db->select('count(id)', $tbl_web_users, "username='{$esc_newusername}'");
66
-		$limit = $modx->db->getValue($rs);
67
-		if($limit > 0) {
68
-			webAlertAndQuit("User name is already in use!");
69
-		}
70
-
71
-		// check if the email address already exist
72
-		$rs = $modx->db->select('count(id)', $tbl_web_user_attributes, "email='{$esc_email}' AND id!='{$id}'");
73
-		$limit = $modx->db->getValue($rs);
74
-		if($limit > 0) {
75
-			webAlertAndQuit("Email is already in use!");
76
-		}
77
-
78
-		// generate a new password for this user
79
-		if($specifiedpassword != "" && $passwordgenmethod == "spec") {
80
-			if(strlen($specifiedpassword) < 6) {
81
-				webAlertAndQuit("Password is too short!");
82
-			} else {
83
-				$newpassword = $specifiedpassword;
84
-			}
85
-		} elseif($specifiedpassword == "" && $passwordgenmethod == "spec") {
86
-			webAlertAndQuit("You didn't specify a password for this user!");
87
-		} elseif($passwordgenmethod == 'g') {
88
-			$newpassword = generate_password(8);
89
-		} else {
90
-			webAlertAndQuit("No password generation method specified!");
91
-		}
92
-
93
-		// invoke OnBeforeWUsrFormSave event
94
-		$modx->invokeEvent("OnBeforeWUsrFormSave", array(
95
-			"mode" => "new",
96
-		));
97
-
98
-		// create the user account
99
-		$field = array();
100
-		$field['username'] = $esc_newusername;
101
-		$field['password'] = md5($newpassword);
102
-		$internalKey = $modx->db->insert($field, $tbl_web_users);
103
-
104
-		$field = compact('internalKey', 'fullname', 'role', 'email', 'phone', 'mobilephone', 'fax', 'zip', 'street', 'city', 'state', 'country', 'gender', 'dob', 'photo', 'comment', 'blocked', 'blockeduntil', 'blockedafter');
105
-		$field = $modx->db->escape($field);
106
-		$modx->db->insert($field, $tbl_web_user_attributes);
107
-
108
-		// Save User Settings
109
-		saveUserSettings($internalKey);
110
-
111
-		// Set the item name for logger
112
-		$_SESSION['itemname'] = $newusername;
113
-
114
-		/*******************************************************************************/
115
-		// put the user in the user_groups he/ she should be in
116
-		// first, check that up_perms are switched on!
117
-		if($use_udperms == 1) {
118
-			if(!empty($user_groups)) {
119
-				for($i = 0; $i < count($user_groups); $i++) {
120
-					$f = array();
121
-					$f['webgroup'] = intval($user_groups[$i]);
122
-					$f['webuser'] = $internalKey;
123
-					$modx->db->insert($f, $tbl_web_groups);
124
-				}
125
-			}
126
-		}
127
-		// end of user_groups stuff!
63
+    case '87' : // new user
64
+        // check if this user name already exist
65
+        $rs = $modx->db->select('count(id)', $tbl_web_users, "username='{$esc_newusername}'");
66
+        $limit = $modx->db->getValue($rs);
67
+        if($limit > 0) {
68
+            webAlertAndQuit("User name is already in use!");
69
+        }
70
+
71
+        // check if the email address already exist
72
+        $rs = $modx->db->select('count(id)', $tbl_web_user_attributes, "email='{$esc_email}' AND id!='{$id}'");
73
+        $limit = $modx->db->getValue($rs);
74
+        if($limit > 0) {
75
+            webAlertAndQuit("Email is already in use!");
76
+        }
77
+
78
+        // generate a new password for this user
79
+        if($specifiedpassword != "" && $passwordgenmethod == "spec") {
80
+            if(strlen($specifiedpassword) < 6) {
81
+                webAlertAndQuit("Password is too short!");
82
+            } else {
83
+                $newpassword = $specifiedpassword;
84
+            }
85
+        } elseif($specifiedpassword == "" && $passwordgenmethod == "spec") {
86
+            webAlertAndQuit("You didn't specify a password for this user!");
87
+        } elseif($passwordgenmethod == 'g') {
88
+            $newpassword = generate_password(8);
89
+        } else {
90
+            webAlertAndQuit("No password generation method specified!");
91
+        }
92
+
93
+        // invoke OnBeforeWUsrFormSave event
94
+        $modx->invokeEvent("OnBeforeWUsrFormSave", array(
95
+            "mode" => "new",
96
+        ));
97
+
98
+        // create the user account
99
+        $field = array();
100
+        $field['username'] = $esc_newusername;
101
+        $field['password'] = md5($newpassword);
102
+        $internalKey = $modx->db->insert($field, $tbl_web_users);
103
+
104
+        $field = compact('internalKey', 'fullname', 'role', 'email', 'phone', 'mobilephone', 'fax', 'zip', 'street', 'city', 'state', 'country', 'gender', 'dob', 'photo', 'comment', 'blocked', 'blockeduntil', 'blockedafter');
105
+        $field = $modx->db->escape($field);
106
+        $modx->db->insert($field, $tbl_web_user_attributes);
107
+
108
+        // Save User Settings
109
+        saveUserSettings($internalKey);
110
+
111
+        // Set the item name for logger
112
+        $_SESSION['itemname'] = $newusername;
113
+
114
+        /*******************************************************************************/
115
+        // put the user in the user_groups he/ she should be in
116
+        // first, check that up_perms are switched on!
117
+        if($use_udperms == 1) {
118
+            if(!empty($user_groups)) {
119
+                for($i = 0; $i < count($user_groups); $i++) {
120
+                    $f = array();
121
+                    $f['webgroup'] = intval($user_groups[$i]);
122
+                    $f['webuser'] = $internalKey;
123
+                    $modx->db->insert($f, $tbl_web_groups);
124
+                }
125
+            }
126
+        }
127
+        // end of user_groups stuff!
128 128
 
129 129
         // invoke OnWebSaveUser event
130 130
         $modx->invokeEvent("OnWebSaveUser", array(
@@ -142,26 +142,26 @@  discard block
 block discarded – undo
142 142
             "id" => $internalKey
143 143
         ));
144 144
 
145
-		if($passwordnotifymethod == 'e') {
146
-			sendMailMessage($email, $newusername, $newpassword, $fullname);
147
-			if($input['stay'] != '') {
148
-				$a = ($input['stay'] == '2') ? "88&id={$internalKey}" : "87";
149
-				$header = "Location: index.php?a={$a}&r=2&stay=" . $input['stay'];
150
-				header($header);
151
-			} else {
152
-				$header = "Location: index.php?a=99&r=2";
153
-				header($header);
154
-			}
155
-		} else {
156
-			if($input['stay'] != '') {
157
-				$a = ($input['stay'] == '2') ? "88&id={$internalKey}" : "87";
158
-				$stayUrl = "index.php?a={$a}&r=2&stay=" . $input['stay'];
159
-			} else {
160
-				$stayUrl = "index.php?a=99&r=2";
161
-			}
162
-
163
-			include_once "header.inc.php";
164
-			?>
145
+        if($passwordnotifymethod == 'e') {
146
+            sendMailMessage($email, $newusername, $newpassword, $fullname);
147
+            if($input['stay'] != '') {
148
+                $a = ($input['stay'] == '2') ? "88&id={$internalKey}" : "87";
149
+                $header = "Location: index.php?a={$a}&r=2&stay=" . $input['stay'];
150
+                header($header);
151
+            } else {
152
+                $header = "Location: index.php?a=99&r=2";
153
+                header($header);
154
+            }
155
+        } else {
156
+            if($input['stay'] != '') {
157
+                $a = ($input['stay'] == '2') ? "88&id={$internalKey}" : "87";
158
+                $stayUrl = "index.php?a={$a}&r=2&stay=" . $input['stay'];
159
+            } else {
160
+                $stayUrl = "index.php?a=99&r=2";
161
+            }
162
+
163
+            include_once "header.inc.php";
164
+            ?>
165 165
 
166 166
 			<h1><?php echo $_lang['web_user_title']; ?></h1>
167 167
 
@@ -183,84 +183,84 @@  discard block
 block discarded – undo
183 183
 			</div>
184 184
 			<?php
185 185
 
186
-			include_once "footer.inc.php";
187
-		}
188
-		break;
189
-	case '88' : // edit user
190
-		// generate a new password for this user
191
-		if($genpassword == 1) {
192
-			if($specifiedpassword != "" && $passwordgenmethod == "spec") {
193
-				if(strlen($specifiedpassword) < 6) {
194
-					webAlertAndQuit("Password is too short!");
195
-				} else {
196
-					$newpassword = $specifiedpassword;
197
-				}
198
-			} elseif($specifiedpassword == "" && $passwordgenmethod == "spec") {
199
-				webAlertAndQuit("You didn't specify a password for this user!");
200
-			} elseif($passwordgenmethod == 'g') {
201
-				$newpassword = generate_password(8);
202
-			} else {
203
-				webAlertAndQuit("No password generation method specified!");
204
-			}
205
-		}
206
-		if($passwordnotifymethod == 'e') {
207
-			sendMailMessage($email, $newusername, $newpassword, $fullname);
208
-		}
209
-
210
-		// check if the username already exist
211
-		$rs = $modx->db->select('count(id)', $tbl_web_users, "username='{$esc_newusername}' AND id!='{$id}'");
212
-		$limit = $modx->db->getValue($rs);
213
-		if($limit > 0) {
214
-			webAlertAndQuit("User name is already in use!");
215
-		}
216
-
217
-		// check if the email address already exists
218
-		$rs = $modx->db->select('count(internalKey)', $tbl_web_user_attributes, "email='{$esc_email}' AND internalKey!='{$id}'");
219
-		$limit = $modx->db->getValue($rs);
220
-		if($limit > 0) {
221
-			webAlertAndQuit("Email is already in use!");
222
-		}
223
-
224
-		// invoke OnBeforeWUsrFormSave event
225
-		$modx->invokeEvent("OnBeforeWUsrFormSave", array(
226
-			"mode" => "upd",
227
-			"id" => $id
228
-		));
229
-
230
-		// update user name and password
231
-		$field = array();
232
-		$field['username'] = $esc_newusername;
233
-		if($genpassword == 1) {
234
-			$field['password'] = md5($newpassword);
235
-		}
236
-		$modx->db->update($field, $tbl_web_users, "id='{$id}'");
237
-		$field = compact('fullname', 'role', 'email', 'phone', 'mobilephone', 'fax', 'zip', 'street', 'city', 'state', 'country', 'gender', 'dob', 'photo', 'comment', 'failedlogincount', 'blocked', 'blockeduntil', 'blockedafter');
238
-		$field = $modx->db->escape($field);
239
-		$modx->db->update($field, $tbl_web_user_attributes, "internalKey='{$id}'");
240
-
241
-		// Save User Settings
242
-		saveUserSettings($id);
243
-
244
-		// Set the item name for logger
245
-		$_SESSION['itemname'] = $newusername;
246
-
247
-		/*******************************************************************************/
248
-		// put the user in the user_groups he/ she should be in
249
-		// first, check that up_perms are switched on!
250
-		if($use_udperms == 1) {
251
-			// as this is an existing user, delete his/ her entries in the groups before saving the new groups
252
-			$modx->db->delete($tbl_web_groups, "webuser='{$id}'");
253
-			if(!empty($user_groups)) {
254
-				for($i = 0; $i < count($user_groups); $i++) {
255
-					$field = array();
256
-					$field['webgroup'] = intval($user_groups[$i]);
257
-					$field['webuser'] = $id;
258
-					$modx->db->insert($field, $tbl_web_groups);
259
-				}
260
-			}
261
-		}
262
-		// end of user_groups stuff!
263
-		/*******************************************************************************/
186
+            include_once "footer.inc.php";
187
+        }
188
+        break;
189
+    case '88' : // edit user
190
+        // generate a new password for this user
191
+        if($genpassword == 1) {
192
+            if($specifiedpassword != "" && $passwordgenmethod == "spec") {
193
+                if(strlen($specifiedpassword) < 6) {
194
+                    webAlertAndQuit("Password is too short!");
195
+                } else {
196
+                    $newpassword = $specifiedpassword;
197
+                }
198
+            } elseif($specifiedpassword == "" && $passwordgenmethod == "spec") {
199
+                webAlertAndQuit("You didn't specify a password for this user!");
200
+            } elseif($passwordgenmethod == 'g') {
201
+                $newpassword = generate_password(8);
202
+            } else {
203
+                webAlertAndQuit("No password generation method specified!");
204
+            }
205
+        }
206
+        if($passwordnotifymethod == 'e') {
207
+            sendMailMessage($email, $newusername, $newpassword, $fullname);
208
+        }
209
+
210
+        // check if the username already exist
211
+        $rs = $modx->db->select('count(id)', $tbl_web_users, "username='{$esc_newusername}' AND id!='{$id}'");
212
+        $limit = $modx->db->getValue($rs);
213
+        if($limit > 0) {
214
+            webAlertAndQuit("User name is already in use!");
215
+        }
216
+
217
+        // check if the email address already exists
218
+        $rs = $modx->db->select('count(internalKey)', $tbl_web_user_attributes, "email='{$esc_email}' AND internalKey!='{$id}'");
219
+        $limit = $modx->db->getValue($rs);
220
+        if($limit > 0) {
221
+            webAlertAndQuit("Email is already in use!");
222
+        }
223
+
224
+        // invoke OnBeforeWUsrFormSave event
225
+        $modx->invokeEvent("OnBeforeWUsrFormSave", array(
226
+            "mode" => "upd",
227
+            "id" => $id
228
+        ));
229
+
230
+        // update user name and password
231
+        $field = array();
232
+        $field['username'] = $esc_newusername;
233
+        if($genpassword == 1) {
234
+            $field['password'] = md5($newpassword);
235
+        }
236
+        $modx->db->update($field, $tbl_web_users, "id='{$id}'");
237
+        $field = compact('fullname', 'role', 'email', 'phone', 'mobilephone', 'fax', 'zip', 'street', 'city', 'state', 'country', 'gender', 'dob', 'photo', 'comment', 'failedlogincount', 'blocked', 'blockeduntil', 'blockedafter');
238
+        $field = $modx->db->escape($field);
239
+        $modx->db->update($field, $tbl_web_user_attributes, "internalKey='{$id}'");
240
+
241
+        // Save User Settings
242
+        saveUserSettings($id);
243
+
244
+        // Set the item name for logger
245
+        $_SESSION['itemname'] = $newusername;
246
+
247
+        /*******************************************************************************/
248
+        // put the user in the user_groups he/ she should be in
249
+        // first, check that up_perms are switched on!
250
+        if($use_udperms == 1) {
251
+            // as this is an existing user, delete his/ her entries in the groups before saving the new groups
252
+            $modx->db->delete($tbl_web_groups, "webuser='{$id}'");
253
+            if(!empty($user_groups)) {
254
+                for($i = 0; $i < count($user_groups); $i++) {
255
+                    $field = array();
256
+                    $field['webgroup'] = intval($user_groups[$i]);
257
+                    $field['webuser'] = $id;
258
+                    $modx->db->insert($field, $tbl_web_groups);
259
+                }
260
+            }
261
+        }
262
+        // end of user_groups stuff!
263
+        /*******************************************************************************/
264 264
 
265 265
         // invoke OnWebSaveUser event
266 266
         $modx->invokeEvent("OnWebSaveUser", array(
@@ -289,16 +289,16 @@  discard block
 block discarded – undo
289 289
             "id" => $id
290 290
         ));
291 291
 
292
-		if($genpassword == 1 && $passwordnotifymethod == 's') {
293
-			if($input['stay'] != '') {
294
-				$a = ($input['stay'] == '2') ? "88&id={$id}" : "87";
295
-				$stayUrl = "index.php?a={$a}&r=2&stay=" . $input['stay'];
296
-			} else {
297
-				$stayUrl = "index.php?a=99&r=2";
298
-			}
292
+        if($genpassword == 1 && $passwordnotifymethod == 's') {
293
+            if($input['stay'] != '') {
294
+                $a = ($input['stay'] == '2') ? "88&id={$id}" : "87";
295
+                $stayUrl = "index.php?a={$a}&r=2&stay=" . $input['stay'];
296
+            } else {
297
+                $stayUrl = "index.php?a=99&r=2";
298
+            }
299 299
 
300
-			include_once "header.inc.php";
301
-			?>
300
+            include_once "header.inc.php";
301
+            ?>
302 302
 
303 303
 			<h1><?php echo $_lang['web_user_title']; ?></h1>
304 304
 
@@ -318,124 +318,124 @@  discard block
 block discarded – undo
318 318
 			</div>
319 319
 			<?php
320 320
 
321
-			include_once "footer.inc.php";
322
-		} else {
323
-			if($input['stay'] != '') {
324
-				$a = ($input['stay'] == '2') ? "88&id={$id}" : "87";
325
-				$header = "Location: index.php?a={$a}&r=2&stay=" . $input['stay'];
326
-				header($header);
327
-			} else {
328
-				$header = "Location: index.php?a=99&r=2";
329
-				header($header);
330
-			}
331
-		}
332
-		break;
333
-	default :
334
-		webAlertAndQuit("No operation set in request.");
321
+            include_once "footer.inc.php";
322
+        } else {
323
+            if($input['stay'] != '') {
324
+                $a = ($input['stay'] == '2') ? "88&id={$id}" : "87";
325
+                $header = "Location: index.php?a={$a}&r=2&stay=" . $input['stay'];
326
+                header($header);
327
+            } else {
328
+                $header = "Location: index.php?a=99&r=2";
329
+                header($header);
330
+            }
331
+        }
332
+        break;
333
+    default :
334
+        webAlertAndQuit("No operation set in request.");
335 335
 }
336 336
 
337 337
 // in case any plugins include a quoted_printable function
338 338
 function save_user_quoted_printable($string) {
339
-	$crlf = "\n";
340
-	$string = preg_replace('!(\r\n|\r|\n)!', $crlf, $string) . $crlf;
341
-	$f[] = '/([\000-\010\013\014\016-\037\075\177-\377])/e';
342
-	$r[] = "'=' . sprintf('%02X', ord('\\1'))";
343
-	$f[] = '/([\011\040])' . $crlf . '/e';
344
-	$r[] = "'=' . sprintf('%02X', ord('\\1')) . '" . $crlf . "'";
345
-	$string = preg_replace($f, $r, $string);
346
-	return trim(wordwrap($string, 70, ' =' . $crlf));
339
+    $crlf = "\n";
340
+    $string = preg_replace('!(\r\n|\r|\n)!', $crlf, $string) . $crlf;
341
+    $f[] = '/([\000-\010\013\014\016-\037\075\177-\377])/e';
342
+    $r[] = "'=' . sprintf('%02X', ord('\\1'))";
343
+    $f[] = '/([\011\040])' . $crlf . '/e';
344
+    $r[] = "'=' . sprintf('%02X', ord('\\1')) . '" . $crlf . "'";
345
+    $string = preg_replace($f, $r, $string);
346
+    return trim(wordwrap($string, 70, ' =' . $crlf));
347 347
 }
348 348
 
349 349
 // Send an email to the user
350 350
 function sendMailMessage($email, $uid, $pwd, $ufn) {
351
-	global $modx, $_lang, $websignupemail_message;
352
-	global $emailsubject, $emailsender;
353
-	global $site_name, $site_url;
354
-	$message = sprintf($websignupemail_message, $uid, $pwd); // use old method
355
-	// replace placeholders
356
-	$message = str_replace("[+uid+]", $uid, $message);
357
-	$message = str_replace("[+pwd+]", $pwd, $message);
358
-	$message = str_replace("[+ufn+]", $ufn, $message);
359
-	$message = str_replace("[+sname+]", $site_name, $message);
360
-	$message = str_replace("[+saddr+]", $emailsender, $message);
361
-	$message = str_replace("[+semail+]", $emailsender, $message);
362
-	$message = str_replace("[+surl+]", $site_url, $message);
363
-
364
-	$param = array();
365
-	$param['from'] = "{$site_name}<{$emailsender}>";
366
-	$param['subject'] = $emailsubject;
367
-	$param['body'] = $message;
368
-	$param['to'] = $email;
369
-	$param['type'] = 'text';
370
-	$rs = $modx->sendmail($param);
371
-	if(!$rs) {
372
-		$modx->manager->saveFormValues();
373
-		$modx->messageQuit("{$email} - {$_lang['error_sending_email']}");
374
-	}
351
+    global $modx, $_lang, $websignupemail_message;
352
+    global $emailsubject, $emailsender;
353
+    global $site_name, $site_url;
354
+    $message = sprintf($websignupemail_message, $uid, $pwd); // use old method
355
+    // replace placeholders
356
+    $message = str_replace("[+uid+]", $uid, $message);
357
+    $message = str_replace("[+pwd+]", $pwd, $message);
358
+    $message = str_replace("[+ufn+]", $ufn, $message);
359
+    $message = str_replace("[+sname+]", $site_name, $message);
360
+    $message = str_replace("[+saddr+]", $emailsender, $message);
361
+    $message = str_replace("[+semail+]", $emailsender, $message);
362
+    $message = str_replace("[+surl+]", $site_url, $message);
363
+
364
+    $param = array();
365
+    $param['from'] = "{$site_name}<{$emailsender}>";
366
+    $param['subject'] = $emailsubject;
367
+    $param['body'] = $message;
368
+    $param['to'] = $email;
369
+    $param['type'] = 'text';
370
+    $rs = $modx->sendmail($param);
371
+    if(!$rs) {
372
+        $modx->manager->saveFormValues();
373
+        $modx->messageQuit("{$email} - {$_lang['error_sending_email']}");
374
+    }
375 375
 }
376 376
 
377 377
 // Save User Settings
378 378
 function saveUserSettings($id) {
379
-	global $modx;
380
-	$tbl_web_user_settings = $modx->getFullTableName('web_user_settings');
381
-
382
-	$settings = array(
383
-		"login_home",
384
-		"allowed_ip",
385
-		"allowed_days"
386
-	);
387
-
388
-	$modx->db->delete($tbl_web_user_settings, "webuser='{$id}'");
389
-
390
-	foreach($settings as $n) {
391
-		$vl = $_POST[$n];
392
-		if(is_array($vl)) {
393
-			$vl = implode(",", $vl);
394
-		}
395
-		if($vl != '') {
396
-			$f = array();
397
-			$f['webuser'] = $id;
398
-			$f['setting_name'] = $n;
399
-			$f['setting_value'] = $vl;
400
-			$f = $modx->db->escape($f);
401
-			$modx->db->insert($f, $tbl_web_user_settings);
402
-		}
403
-	}
379
+    global $modx;
380
+    $tbl_web_user_settings = $modx->getFullTableName('web_user_settings');
381
+
382
+    $settings = array(
383
+        "login_home",
384
+        "allowed_ip",
385
+        "allowed_days"
386
+    );
387
+
388
+    $modx->db->delete($tbl_web_user_settings, "webuser='{$id}'");
389
+
390
+    foreach($settings as $n) {
391
+        $vl = $_POST[$n];
392
+        if(is_array($vl)) {
393
+            $vl = implode(",", $vl);
394
+        }
395
+        if($vl != '') {
396
+            $f = array();
397
+            $f['webuser'] = $id;
398
+            $f['setting_name'] = $n;
399
+            $f['setting_value'] = $vl;
400
+            $f = $modx->db->escape($f);
401
+            $modx->db->insert($f, $tbl_web_user_settings);
402
+        }
403
+    }
404 404
 }
405 405
 
406 406
 // Web alert -  sends an alert to web browser
407 407
 function webAlertAndQuit($msg) {
408
-	global $id, $modx;
409
-	$mode = $_POST['mode'];
410
-	$modx->manager->saveFormValues($mode);
411
-	$modx->webAlertAndQuit($msg, "index.php?a={$mode}" . ($mode == '88' ? "&id={$id}" : ''));
408
+    global $id, $modx;
409
+    $mode = $_POST['mode'];
410
+    $modx->manager->saveFormValues($mode);
411
+    $modx->webAlertAndQuit($msg, "index.php?a={$mode}" . ($mode == '88' ? "&id={$id}" : ''));
412 412
 }
413 413
 
414 414
 // Generate password
415 415
 function generate_password($length = 10) {
416
-	$allowable_characters = "abcdefghjkmnpqrstuvxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789";
417
-	$ps_len = strlen($allowable_characters);
418
-	mt_srand((double) microtime() * 1000000);
419
-	$pass = "";
420
-	for($i = 0; $i < $length; $i++) {
421
-		$pass .= $allowable_characters[mt_rand(0, $ps_len - 1)];
422
-	}
423
-	return $pass;
416
+    $allowable_characters = "abcdefghjkmnpqrstuvxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789";
417
+    $ps_len = strlen($allowable_characters);
418
+    mt_srand((double) microtime() * 1000000);
419
+    $pass = "";
420
+    for($i = 0; $i < $length; $i++) {
421
+        $pass .= $allowable_characters[mt_rand(0, $ps_len - 1)];
422
+    }
423
+    return $pass;
424 424
 }
425 425
 
426 426
 function sanitize($str = '', $safecount = 0) {
427
-	global $modx;
428
-	$safecount++;
429
-	if(1000 < $safecount) {
430
-		exit("error too many loops '{$safecount}'");
431
-	}
432
-	if(is_array($str)) {
433
-		foreach($str as $i => $v) {
434
-			$str[$i] = sanitize($v, $safecount);
435
-		}
436
-	} else {
437
-		// $str = strip_tags($str); // LEAVE < and > intact
438
-		$str = htmlspecialchars($str, ENT_NOQUOTES, $modx->config['modx_charset']);
439
-	}
440
-	return $str;
427
+    global $modx;
428
+    $safecount++;
429
+    if(1000 < $safecount) {
430
+        exit("error too many loops '{$safecount}'");
431
+    }
432
+    if(is_array($str)) {
433
+        foreach($str as $i => $v) {
434
+            $str[$i] = sanitize($v, $safecount);
435
+        }
436
+    } else {
437
+        // $str = strip_tags($str); // LEAVE < and > intact
438
+        $str = htmlspecialchars($str, ENT_NOQUOTES, $modx->config['modx_charset']);
439
+    }
440
+    return $str;
441 441
 }
Please login to merge, or discard this patch.