Inspection of "Merge pull request #546 from evolution-cms/revert-..." - evolution-cms/evolution - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 5613ed...d17f77 )

by Maxim

created 2018-02-26 23:34 UTC

Status

Upper-Lower-Casing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -4,12 +4,12 @@  discard block
 block discarded – undo
 <script src="js/helper.js" type="text/javascript"></script>
 <script src="js/browser/joiner.php" type="text/javascript"></script>
 <script src="js_localize.php?lng=<?php echo $this->lang ?>" type="text/javascript"></script>
-<?php IF (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
+<?php if (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
 <script src="<?php echo $this->config['_tinyMCEPath'] ?>/tiny_mce_popup.js" type="text/javascript"></script>
-<?php ENDIF ?>
-<?php IF (file_exists("themes/{$this->config['theme']}/init.js")): ?>
+<?php endif ?>
+<?php if (file_exists("themes/{$this->config['theme']}/init.js")): ?>
 <script src="themes/<?php echo $this->config['theme'] ?>/init.js" type="text/javascript"></script>
-<?php ENDIF ?>
+<?php endif ?>
 <script type="text/javascript">
 browser.version = "<?php echo self::VERSION ?>";
 browser.support.chromeFrame = <?php echo (strpos(strtolower($_SERVER['HTTP_USER_AGENT']), " chromeframe") !== false) ? "true" : "false" ?>;
@@ -23,19 +23,19 @@  discard block
 block discarded – undo
 browser.siteURL = "<?php echo text::jsValue($this->config['siteURL']) ?>";
 browser.assetsURL = "<?php echo text::jsValue($this->config['assetsURL']) ?>";
 browser.thumbsURL = browser.assetsURL + "/<?php echo text::jsValue($this->config['thumbsDir']) ?>";
-<?php IF (isset($this->get['opener']) && strlen($this->get['opener'])): ?>
+<?php if (isset($this->get['opener']) && strlen($this->get['opener'])): ?>
 browser.opener.name = "<?php echo text::jsValue($this->get['opener']) ?>";
-<?php ENDIF ?>
-<?php IF (isset($this->opener['CKEditor']['funcNum']) && preg_match('/^\d+$/', $this->opener['CKEditor']['funcNum'])): ?>
+<?php endif ?>
+<?php if (isset($this->opener['CKEditor']['funcNum']) && preg_match('/^\d+$/', $this->opener['CKEditor']['funcNum'])): ?>
 browser.opener.CKEditor = {};
 browser.opener.CKEditor.funcNum = <?php echo $this->opener['CKEditor']['funcNum'] ?>;
-<?php ENDIF ?>
-<?php IF (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
+<?php endif ?>
+<?php if (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
 browser.opener.TinyMCE = true;
-<?php ENDIF ?>
-<?php IF (isset($this->get['opener']) && ($this->get['opener'] == "tinymce4") && isset($this->get['field'])): ?>
+<?php endif ?>
+<?php if (isset($this->get['opener']) && ($this->get['opener'] == "tinymce4") && isset($this->get['field'])): ?>
 browser.opener.TinyMCE4 = "<?= text::jsValue($this->get['field']) ?>";
-<?php ENDIF ?>
+<?php endif ?>
 browser.cms = "<?php echo text::jsValue($this->cms) ?>";
 _.kuki.domain = "<?php echo text::jsValue($this->config['cookieDomain']) ?>";
 _.kuki.path = "<?php echo text::jsValue($this->config['cookiePath']) ?>";

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/tpl/tpl_browser.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,8 +4,8 @@
 block discarded – undo
 <head>
     <title>KCFinder: /
         <?php echo $this->session['dir'] ?></title>
-    <?php INCLUDE "tpl/tpl_css.php" ?>
-    <?php INCLUDE "tpl/tpl_javascript.php" ?>
+    <?php include "tpl/tpl_css.php" ?>
+    <?php include "tpl/tpl_javascript.php" ?>
 </head>
 
 <body>

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/pt-br.php 2 patches

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 
 /** Portugues Brasil localization file for KCFinder
-  * author: Alexandre Benegas Ferreira
-  * country: Brasil
-  * company website: www.hostcataratas.com.br
-  * e-mail: [email protected]
-  */
+ * author: Alexandre Benegas Ferreira
+ * country: Brasil
+ * company website: www.hostcataratas.com.br
+ * e-mail: [email protected]
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -9,8 +9,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "pt_BR.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "pt_BR.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%A, %e %B, %Y %H:%M",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/de.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,8 +1,8 @@
 block discarded – undo
 <?php
 
 /** German localization file for KCFinder
-  * author: Tim Wahrendorff <[email protected]>
-  */
+ * author: Tim Wahrendorff <[email protected]>
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -6,8 +6,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "de_DE.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "de_DE.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%A, %e.%B.%Y %I:%M %p",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/uk.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@
 block discarded – undo
 <?php
 
 /** Ukrainian localization file for KCFinder
-	* author: Myroslav Dobra
-	* E-mail: [email protected]
-  */
+ * author: Myroslav Dobra
+ * E-mail: [email protected]
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -7,8 +7,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "uk_UA.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "uk_UA.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%A, %e %B, %Y %H:%M",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/ja.php 2 patches

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 
 /** This file is part of KCFinder project
-  *
-  * @desc Japanese localization
-  * @package KCFinder
-  * @author yama [email protected]
-  * @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
-  * @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
-  */
+ *
+ * @desc Japanese localization
+ * @package KCFinder
+ * @author yama [email protected]
+ * @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
+ * @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -11,8 +11,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "ja_JP.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "ja_JP.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%Y/%m/%d %H:%M",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/fr.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@
 block discarded – undo
 <?php
 
 /** French localization file for KCFinder
-  * author: Damien Barrère
-  * update: Samuel Jobard
-  */
+ * author: Damien Barrère
+ * update: Samuel Jobard
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -7,8 +7,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "fr_FR.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "fr_FR.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%A %e %B %Y %H:%M",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/he.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,8 +1,8 @@
 block discarded – undo
 <?php
 
 /** Hebrew localization file for KCFinder
-  * Sig: 1f4f9aee887c97f618c19a82040a4dad
-  */
+ * Sig: 1f4f9aee887c97f618c19a82040a4dad
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -6,8 +6,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "he_IL.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "he_IL.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%H:%M %Y %B %e %A",

Please login to merge, or discard this patch.

manager/media/browser/mcpuk/lang/ro.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 
 /** Romanian localization file for KCFinder
-  */
+ */
 
 $lang = array(
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -5,8 +5,8 @@
 block discarded – undo
 
 $lang = array(
 
-    '_locale' => "ro_RO.UTF-8",  // UNIX localization code
-    '_charset' => "utf-8",       // Browser charset
+    '_locale' => "ro_RO.UTF-8", // UNIX localization code
+    '_charset' => "utf-8", // Browser charset
 
     // Date time formats. See http://www.php.net/manual/en/function.strftime.php
     '_dateTimeFull' => "%A, %e %B, %Y %H:%M",

Please login to merge, or discard this patch.

		@@ -4,12 +4,12 @@ discard block
		block discarded – undo
4	4	<script src="js/helper.js" type="text/javascript"></script>
5	5	<script src="js/browser/joiner.php" type="text/javascript"></script>
6	6	<script src="js_localize.php?lng=<?php echo $this->lang ?>" type="text/javascript"></script>
7		-<?php IF (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
	7	+<?php if (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
8	8	<script src="<?php echo $this->config['_tinyMCEPath'] ?>/tiny_mce_popup.js" type="text/javascript"></script>
9		-<?php ENDIF ?>
10		-<?php IF (file_exists("themes/{$this->config['theme']}/init.js")): ?>
	9	+<?php endif ?>
	10	+<?php if (file_exists("themes/{$this->config['theme']}/init.js")): ?>
11	11	<script src="themes/<?php echo $this->config['theme'] ?>/init.js" type="text/javascript"></script>
12		-<?php ENDIF ?>
	12	+<?php endif ?>
13	13	<script type="text/javascript">
14	14	browser.version = "<?php echo self::VERSION ?>";
15	15	browser.support.chromeFrame = <?php echo (strpos(strtolower($_SERVER['HTTP_USER_AGENT']), " chromeframe") !== false) ? "true" : "false" ?>;
		@@ -23,19 +23,19 @@ discard block
		block discarded – undo
23	23	browser.siteURL = "<?php echo text::jsValue($this->config['siteURL']) ?>";
24	24	browser.assetsURL = "<?php echo text::jsValue($this->config['assetsURL']) ?>";
25	25	browser.thumbsURL = browser.assetsURL + "/<?php echo text::jsValue($this->config['thumbsDir']) ?>";
26		-<?php IF (isset($this->get['opener']) && strlen($this->get['opener'])): ?>
	26	+<?php if (isset($this->get['opener']) && strlen($this->get['opener'])): ?>
27	27	browser.opener.name = "<?php echo text::jsValue($this->get['opener']) ?>";
28		-<?php ENDIF ?>
29		-<?php IF (isset($this->opener['CKEditor']['funcNum']) && preg_match('/^\d+$/', $this->opener['CKEditor']['funcNum'])): ?>
	28	+<?php endif ?>
	29	+<?php if (isset($this->opener['CKEditor']['funcNum']) && preg_match('/^\d+$/', $this->opener['CKEditor']['funcNum'])): ?>
30	30	browser.opener.CKEditor = {};
31	31	browser.opener.CKEditor.funcNum = <?php echo $this->opener['CKEditor']['funcNum'] ?>;
32		-<?php ENDIF ?>
33		-<?php IF (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
	32	+<?php endif ?>
	33	+<?php if (isset($this->opener['TinyMCE']) && $this->opener['TinyMCE']): ?>
34	34	browser.opener.TinyMCE = true;
35		-<?php ENDIF ?>
36		-<?php IF (isset($this->get['opener']) && ($this->get['opener'] == "tinymce4") && isset($this->get['field'])): ?>
	35	+<?php endif ?>
	36	+<?php if (isset($this->get['opener']) && ($this->get['opener'] == "tinymce4") && isset($this->get['field'])): ?>
37	37	browser.opener.TinyMCE4 = "<?= text::jsValue($this->get['field']) ?>";
38		-<?php ENDIF ?>
	38	+<?php endif ?>
39	39	browser.cms = "<?php echo text::jsValue($this->cms) ?>";
40	40	_.kuki.domain = "<?php echo text::jsValue($this->config['cookieDomain']) ?>";
41	41	_.kuki.path = "<?php echo text::jsValue($this->config['cookiePath']) ?>";

		@@ -4,8 +4,8 @@
		block discarded – undo
4	4	<head>
5	5	<title>KCFinder: /
6	6	<?php echo $this->session['dir'] ?></title>
7		- <?php INCLUDE "tpl/tpl_css.php" ?>
8		- <?php INCLUDE "tpl/tpl_javascript.php" ?>
	7	+ <?php include "tpl/tpl_css.php" ?>
	8	+ <?php include "tpl/tpl_javascript.php" ?>
9	9	</head>
10	10
11	11	<body>

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** Portugues Brasil localization file for KCFinder
4		- * author: Alexandre Benegas Ferreira
5		- * country: Brasil
6		- * company website: www.hostcataratas.com.br
7		- * e-mail: [email protected]
8		- */
	4	+ * author: Alexandre Benegas Ferreira
	5	+ * country: Brasil
	6	+ * company website: www.hostcataratas.com.br
	7	+ * e-mail: [email protected]
	8	+ */
9	9
10	10	$lang = array(
11	11

		@@ -9,8 +9,8 @@
		block discarded – undo
9	9
10	10	$lang = array(
11	11
12		- '_locale' => "pt_BR.UTF-8", // UNIX localization code
13		- '_charset' => "utf-8", // Browser charset
	12	+ '_locale' => "pt_BR.UTF-8", // UNIX localization code
	13	+ '_charset' => "utf-8", // Browser charset
14	14
15	15	// Date time formats. See http://www.php.net/manual/en/function.strftime.php
16	16	'_dateTimeFull' => "%A, %e %B, %Y %H:%M",

		@@ -1,8 +1,8 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** German localization file for KCFinder
4		- * author: Tim Wahrendorff <[email protected]>
5		- */
	4	+ * author: Tim Wahrendorff <[email protected]>
	5	+ */
6	6
7	7	$lang = array(
8	8

		@@ -6,8 +6,8 @@
		block discarded – undo
6	6
7	7	$lang = array(
8	8
9		- '_locale' => "de_DE.UTF-8", // UNIX localization code
10		- '_charset' => "utf-8", // Browser charset
	9	+ '_locale' => "de_DE.UTF-8", // UNIX localization code
	10	+ '_charset' => "utf-8", // Browser charset
11	11
12	12	// Date time formats. See http://www.php.net/manual/en/function.strftime.php
13	13	'_dateTimeFull' => "%A, %e.%B.%Y %I:%M %p",

		@@ -1,9 +1,9 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** Ukrainian localization file for KCFinder
4		- * author: Myroslav Dobra
5		- * E-mail: [email protected]
6		- */
	4	+ * author: Myroslav Dobra
	5	+ * E-mail: [email protected]
	6	+ */
7	7
8	8	$lang = array(
9	9

		@@ -7,8 +7,8 @@
		block discarded – undo
7	7
8	8	$lang = array(
9	9
10		- '_locale' => "uk_UA.UTF-8", // UNIX localization code
11		- '_charset' => "utf-8", // Browser charset
	10	+ '_locale' => "uk_UA.UTF-8", // UNIX localization code
	11	+ '_charset' => "utf-8", // Browser charset
12	12
13	13	// Date time formats. See http://www.php.net/manual/en/function.strftime.php
14	14	'_dateTimeFull' => "%A, %e %B, %Y %H:%M",

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** This file is part of KCFinder project
4		- *
5		- * @desc Japanese localization
6		- * @package KCFinder
7		- * @author yama [email protected]
8		- * @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
9		- * @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
10		- */
	4	+ *
	5	+ * @desc Japanese localization
	6	+ * @package KCFinder
	7	+ * @author yama [email protected]
	8	+ * @license http://www.opensource.org/licenses/gpl-2.0.php GPLv2
	9	+ * @license http://www.opensource.org/licenses/lgpl-2.1.php LGPLv2
	10	+ */
11	11
12	12	$lang = array(
13	13

		@@ -11,8 +11,8 @@
		block discarded – undo
11	11
12	12	$lang = array(
13	13
14		- '_locale' => "ja_JP.UTF-8", // UNIX localization code
15		- '_charset' => "utf-8", // Browser charset
	14	+ '_locale' => "ja_JP.UTF-8", // UNIX localization code
	15	+ '_charset' => "utf-8", // Browser charset
16	16
17	17	// Date time formats. See http://www.php.net/manual/en/function.strftime.php
18	18	'_dateTimeFull' => "%Y/%m/%d %H:%M",

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** Romanian localization file for KCFinder
4		- */
	4	+ */
5	5
6	6	$lang = array(
7	7

		@@ -5,8 +5,8 @@
		block discarded – undo
5	5
6	6	$lang = array(
7	7
8		- '_locale' => "ro_RO.UTF-8", // UNIX localization code
9		- '_charset' => "utf-8", // Browser charset
	8	+ '_locale' => "ro_RO.UTF-8", // UNIX localization code
	9	+ '_charset' => "utf-8", // Browser charset
10	10
11	11	// Date time formats. See http://www.php.net/manual/en/function.strftime.php
12	12	'_dateTimeFull' => "%A, %e %B, %Y %H:%M",

evolution-cms / evolution

Push — develop ( 5613ed...d17f77 )

Status

Category

Upper-Lower-Casing +12 added lines, -12 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch