Completed
Push — develop ( 5613ed...d17f77 )
by Maxim
11:03 queued 05:33
created
manager/includes/extenders/dbapi.mysql.class.inc.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -554,6 +554,7 @@  discard block
 block discarded – undo
554 554
      * @name:  getColumn
555 555
      * @desc:  returns an array of the values found on colun $name
556 556
      * @param: $dsq - dataset or query string
557
+     * @param string $name
557 558
      */
558 559
     public function getColumn($name, $dsq)
559 560
     {
@@ -720,6 +721,9 @@  discard block
 block discarded – undo
720 721
         return $result;
721 722
     }
722 723
 
724
+    /**
725
+     * @param string $table_name
726
+     */
723 727
     public function optimize($table_name)
724 728
     {
725 729
         $rs = $this->query("OPTIMIZE TABLE {$table_name}");
Please login to merge, or discard this patch.
manager/actions/welcome.static.php 3 patches
Indentation   +226 added lines, -226 removed lines patch added patch discarded remove patch
@@ -1,13 +1,13 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3
-	die('<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.');
3
+    die('<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.');
4 4
 }
5 5
 
6 6
 unset($_SESSION['itemname']); // clear this, because it's only set for logging purposes
7 7
 
8 8
 if($modx->hasPermission('settings') && (!isset($settings_version) || $settings_version != $modx->getVersionData('version'))) {
9
-	// seems to be a new install - send the user to the configuration page
10
-	exit('<script type="text/javascript">document.location.href="index.php?a=17";</script>');
9
+    // seems to be a new install - send the user to the configuration page
10
+    exit('<script type="text/javascript">document.location.href="index.php?a=17";</script>');
11 11
 }
12 12
 
13 13
 // set placeholders
@@ -17,70 +17,70 @@  discard block
 block discarded – undo
17 17
 
18 18
 // setup message info
19 19
 if($modx->hasPermission('messages')) {
20
-	include_once(MODX_MANAGER_PATH . 'includes/messageCount.inc.php');
21
-	$_SESSION['nrtotalmessages'] = $nrtotalmessages;
22
-	$_SESSION['nrnewmessages'] = $nrnewmessages;
23
-
24
-	$msg = array();
25
-	$msg[] = sprintf('<a href="index.php?a=10" target="main"><img src="%s" /></a>', $_style['icons_mail_large']);
26
-	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? ' (<span style="color:red">' . $_SESSION['nrnewmessages'] . '</span>)' : '';
27
-	$msg[] = sprintf('<span style="color:#909090;font-size:15px;font-weight:bold">&nbsp;<a class="wm_messages_inbox_link" href="index.php?a=10" target="main">[%%inbox%%]</a>%s</span><br />', $nrnewmessages);
28
-	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? '<span style="color:red;">' . $_SESSION['nrnewmessages'] . '</span>' : '0';
29
-	$welcome_messages = sprintf($_lang['welcome_messages'], $_SESSION['nrtotalmessages'], $nrnewmessages);
30
-	$msg[] = sprintf('<span class="comment">%s</span>', $welcome_messages);
31
-	$ph['MessageInfo'] = implode("\n", $msg);
20
+    include_once(MODX_MANAGER_PATH . 'includes/messageCount.inc.php');
21
+    $_SESSION['nrtotalmessages'] = $nrtotalmessages;
22
+    $_SESSION['nrnewmessages'] = $nrnewmessages;
23
+
24
+    $msg = array();
25
+    $msg[] = sprintf('<a href="index.php?a=10" target="main"><img src="%s" /></a>', $_style['icons_mail_large']);
26
+    $nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? ' (<span style="color:red">' . $_SESSION['nrnewmessages'] . '</span>)' : '';
27
+    $msg[] = sprintf('<span style="color:#909090;font-size:15px;font-weight:bold">&nbsp;<a class="wm_messages_inbox_link" href="index.php?a=10" target="main">[%%inbox%%]</a>%s</span><br />', $nrnewmessages);
28
+    $nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? '<span style="color:red;">' . $_SESSION['nrnewmessages'] . '</span>' : '0';
29
+    $welcome_messages = sprintf($_lang['welcome_messages'], $_SESSION['nrtotalmessages'], $nrnewmessages);
30
+    $msg[] = sprintf('<span class="comment">%s</span>', $welcome_messages);
31
+    $ph['MessageInfo'] = implode("\n", $msg);
32 32
 }
33 33
 
34 34
 // setup icons
35 35
 if($modx->hasPermission('new_user') || $modx->hasPermission('edit_user')) {
36
-	$icon = '<i class="[&icons_security_large&]" alt="[%user_management_title%]"> </i>[%user_management_title%]';
37
-	$ph['SecurityIcon'] = wrapIcon($icon, 75);
36
+    $icon = '<i class="[&icons_security_large&]" alt="[%user_management_title%]"> </i>[%user_management_title%]';
37
+    $ph['SecurityIcon'] = wrapIcon($icon, 75);
38 38
 }
39 39
 if($modx->hasPermission('new_web_user') || $modx->hasPermission('edit_web_user')) {
40
-	$icon = '<i class="[&icons_webusers_large&]" alt="[%web_user_management_title%]"> </i>[%web_user_management_title%]';
41
-	$ph['WebUserIcon'] = wrapIcon($icon, 99);
40
+    $icon = '<i class="[&icons_webusers_large&]" alt="[%web_user_management_title%]"> </i>[%web_user_management_title%]';
41
+    $ph['WebUserIcon'] = wrapIcon($icon, 99);
42 42
 }
43 43
 if($modx->hasPermission('new_module') || $modx->hasPermission('edit_module')) {
44
-	$icon = '<i class="[&icons_modules_large&]" alt="[%manage_modules%]"> </i>[%modules%]';
45
-	$ph['ModulesIcon'] = wrapIcon($icon, 106);
44
+    $icon = '<i class="[&icons_modules_large&]" alt="[%manage_modules%]"> </i>[%modules%]';
45
+    $ph['ModulesIcon'] = wrapIcon($icon, 106);
46 46
 }
47 47
 if($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
48
-	$icon = '<i class="[&icons_resources_large&]" alt="[%element_management%]"> </i>[%elements%]';
49
-	$ph['ResourcesIcon'] = wrapIcon($icon, 76);
48
+    $icon = '<i class="[&icons_resources_large&]" alt="[%element_management%]"> </i>[%elements%]';
49
+    $ph['ResourcesIcon'] = wrapIcon($icon, 76);
50 50
 }
51 51
 if($modx->hasPermission('bk_manager')) {
52
-	$icon = '<i class="[&icons_backup_large&]" alt="[%bk_manager%]"> </i>[%backup%]';
53
-	$ph['BackupIcon'] = wrapIcon($icon, 93);
52
+    $icon = '<i class="[&icons_backup_large&]" alt="[%bk_manager%]"> </i>[%backup%]';
53
+    $ph['BackupIcon'] = wrapIcon($icon, 93);
54 54
 }
55 55
 if($modx->hasPermission('help')) {
56
-	$icon = '<i class="[&icons_help_large&]" alt="[%help%]" /> </i>[%help%]';
57
-	$ph['HelpIcon'] = wrapIcon($icon, 9);
56
+    $icon = '<i class="[&icons_help_large&]" alt="[%help%]" /> </i>[%help%]';
57
+    $ph['HelpIcon'] = wrapIcon($icon, 9);
58 58
 }
59 59
 // do some config checks
60 60
 if(($modx->config['warning_visibility'] == 0 && $_SESSION['mgrRole'] == 1) || $modx->config['warning_visibility'] == 1) {
61
-	include_once(MODX_MANAGER_PATH . 'includes/config_check.inc.php');
62
-	if($config_check_results != $_lang['configcheck_ok']) {
63
-		$ph['config_check_results'] = $config_check_results;
64
-		$ph['config_display'] = 'block';
65
-	} else {
66
-		$ph['config_display'] = 'none';
67
-	}
61
+    include_once(MODX_MANAGER_PATH . 'includes/config_check.inc.php');
62
+    if($config_check_results != $_lang['configcheck_ok']) {
63
+        $ph['config_check_results'] = $config_check_results;
64
+        $ph['config_display'] = 'block';
65
+    } else {
66
+        $ph['config_display'] = 'none';
67
+    }
68 68
 } else {
69
-	$ph['config_display'] = 'none';
69
+    $ph['config_display'] = 'none';
70 70
 }
71 71
 
72 72
 // Check logout-reminder
73 73
 if(isset($_SESSION['show_logout_reminder'])) {
74
-	switch($_SESSION['show_logout_reminder']['type']) {
75
-		case 'logout_reminder':
76
-			$date = $modx->toDateFormat($_SESSION['show_logout_reminder']['lastHit'], 'dateOnly');
77
-			$ph['logout_reminder_msg'] = str_replace('[+date+]', $date, $_lang['logout_reminder_msg']);
78
-			break;
79
-	}
80
-	$ph['show_logout_reminder'] = 'block';
81
-	unset($_SESSION['show_logout_reminder']);
74
+    switch($_SESSION['show_logout_reminder']['type']) {
75
+        case 'logout_reminder':
76
+            $date = $modx->toDateFormat($_SESSION['show_logout_reminder']['lastHit'], 'dateOnly');
77
+            $ph['logout_reminder_msg'] = str_replace('[+date+]', $date, $_lang['logout_reminder_msg']);
78
+            break;
79
+    }
80
+    $ph['show_logout_reminder'] = 'block';
81
+    unset($_SESSION['show_logout_reminder']);
82 82
 } else {
83
-	$ph['show_logout_reminder'] = 'none';
83
+    $ph['show_logout_reminder'] = 'none';
84 84
 }
85 85
 
86 86
 // Check multiple sessions
@@ -128,11 +128,11 @@  discard block
 block discarded – undo
128 128
 $nrnewmessages = '<span class="text-danger">' . $_SESSION['nrnewmessages'] . '</span>';
129 129
 
130 130
 $ph['UserInfo'] = $modx->parseText($tpl, array(
131
-	'username' => $modx->getLoginUserName(),
132
-	'role' => $_SESSION['mgrPermissions']['name'],
133
-	'lastlogin' => $modx->toDateFormat($_SESSION['mgrLastlogin'] + $server_offset_time),
134
-	'logincount' => $_SESSION['mgrLogincount'] + 1,
135
-	'msginfo' => sprintf($_lang['welcome_messages'], $_SESSION['nrtotalmessages'], $nrnewmessages)
131
+    'username' => $modx->getLoginUserName(),
132
+    'role' => $_SESSION['mgrPermissions']['name'],
133
+    'lastlogin' => $modx->toDateFormat($_SESSION['mgrLastlogin'] + $server_offset_time),
134
+    'logincount' => $_SESSION['mgrLogincount'] + 1,
135
+    'msginfo' => sprintf($_lang['welcome_messages'], $_SESSION['nrtotalmessages'], $nrnewmessages)
136 136
 ));
137 137
 
138 138
 $from = array();
@@ -141,13 +141,13 @@  discard block
 block discarded – undo
141 141
 $rs = $modx->db->select('*', $from, '', 'username ASC, au.sid ASC');
142 142
 
143 143
 if($modx->db->getRecordCount($rs) < 1) {
144
-	$html = '<p>[%no_active_users_found%]</p>';
144
+    $html = '<p>[%no_active_users_found%]</p>';
145 145
 } else {
146
-	include_once(MODX_MANAGER_PATH . 'includes/actionlist.inc.php');
147
-	$now = $_SERVER['REQUEST_TIME'] + $server_offset_time;
148
-	$ph['now'] = strftime('%H:%M:%S', $now);
149
-	$timetocheck = ($now - (60 * 20)); //+$server_offset_time;
150
-	$html = '
146
+    include_once(MODX_MANAGER_PATH . 'includes/actionlist.inc.php');
147
+    $now = $_SERVER['REQUEST_TIME'] + $server_offset_time;
148
+    $ph['now'] = strftime('%H:%M:%S', $now);
149
+    $timetocheck = ($now - (60 * 20)); //+$server_offset_time;
150
+    $html = '
151 151
 	<div class="card-body">
152 152
 		[%onlineusers_message%] 
153 153
 		<b>[+now+]</b>):
@@ -165,33 +165,33 @@  discard block
 block discarded – undo
165 165
 	</thead>
166 166
 	<tbody>';
167 167
 
168
-	$userList = array();
169
-	$userCount = array();
170
-	// Create userlist with session-count first before output
171
-	while($activeusers = $modx->db->getRow($rs)) {
172
-		$userCount[$activeusers['internalKey']] = isset($userCount[$activeusers['internalKey']]) ? $userCount[$activeusers['internalKey']] + 1 : 1;
173
-
174
-		$idle = $activeusers['lasthit'] < $timetocheck ? ' class="userIdle"' : '';
175
-		$webicon = $activeusers['internalKey'] < 0 ? '<img src="[&tree_globe&]" alt="Web user" />&nbsp;' : '';
176
-		$ip = $activeusers['ip'] === '::1' ? '127.0.0.1' : $activeusers['ip'];
177
-		$currentaction = getAction($activeusers['action'], $activeusers['id']);
178
-		$userList[] = array(
179
-			$idle,
180
-			'',
181
-			$activeusers['username'],
182
-			$webicon,
183
-			abs($activeusers['internalKey']),
184
-			$ip,
185
-			strftime('%H:%M:%S', $activeusers['lasthit'] + $server_offset_time),
186
-			$currentaction
187
-		);
188
-	}
189
-	foreach($userList as $params) {
190
-		$params[1] = $userCount[$params[4]] > 1 ? ' class="userMultipleSessions"' : '';
191
-		$html .= "\n\t\t" . vsprintf('<tr%s><td><strong%s>%s</strong></td><td>%s%s</td><td>%s</td><td>%s</td><td>%s</td></tr>', $params);
192
-	}
193
-
194
-	$html .= '
168
+    $userList = array();
169
+    $userCount = array();
170
+    // Create userlist with session-count first before output
171
+    while($activeusers = $modx->db->getRow($rs)) {
172
+        $userCount[$activeusers['internalKey']] = isset($userCount[$activeusers['internalKey']]) ? $userCount[$activeusers['internalKey']] + 1 : 1;
173
+
174
+        $idle = $activeusers['lasthit'] < $timetocheck ? ' class="userIdle"' : '';
175
+        $webicon = $activeusers['internalKey'] < 0 ? '<img src="[&tree_globe&]" alt="Web user" />&nbsp;' : '';
176
+        $ip = $activeusers['ip'] === '::1' ? '127.0.0.1' : $activeusers['ip'];
177
+        $currentaction = getAction($activeusers['action'], $activeusers['id']);
178
+        $userList[] = array(
179
+            $idle,
180
+            '',
181
+            $activeusers['username'],
182
+            $webicon,
183
+            abs($activeusers['internalKey']),
184
+            $ip,
185
+            strftime('%H:%M:%S', $activeusers['lasthit'] + $server_offset_time),
186
+            $currentaction
187
+        );
188
+    }
189
+    foreach($userList as $params) {
190
+        $params[1] = $userCount[$params[4]] > 1 ? ' class="userMultipleSessions"' : '';
191
+        $html .= "\n\t\t" . vsprintf('<tr%s><td><strong%s>%s</strong></td><td>%s%s</td><td>%s</td><td>%s</td><td>%s</td></tr>', $params);
192
+    }
193
+
194
+    $html .= '
195 195
 	</tbody>
196 196
 	</table>
197 197
 </div>
@@ -232,17 +232,17 @@  discard block
 block discarded – undo
232 232
 // invoke event OnManagerWelcomePrerender
233 233
 $evtOut = $modx->invokeEvent('OnManagerWelcomePrerender');
234 234
 if(is_array($evtOut)) {
235
-	$output = implode('', $evtOut);
236
-	$ph['OnManagerWelcomePrerender'] = $output;
235
+    $output = implode('', $evtOut);
236
+    $ph['OnManagerWelcomePrerender'] = $output;
237 237
 }
238 238
 
239 239
 $widgets['welcome'] = array(
240
-	'menuindex' => '10',
241
-	'id' => 'welcome',
242
-	'cols' => 'col-sm-6',
243
-	'icon' => 'fa-home',
244
-	'title' => '[%welcome_title%]',
245
-	'body' => '
240
+    'menuindex' => '10',
241
+    'id' => 'welcome',
242
+    'cols' => 'col-sm-6',
243
+    'icon' => 'fa-home',
244
+    'title' => '[%welcome_title%]',
245
+    'body' => '
246 246
 				<div class="wm_buttons card-body"> 
247 247
 					<!--@IF:[[#hasPermission?key=new_user]] OR [[#hasPermission?key=edit_user]]--> 
248 248
 					<span class="wm_button">
@@ -320,25 +320,25 @@  discard block
 block discarded – undo
320 320
 					</table>
321 321
 				</div>
322 322
 		',
323
-	'hide'=>'0'
323
+    'hide'=>'0'
324 324
 );
325 325
 $widgets['onlineinfo'] = array(
326
-	'menuindex' => '20',
327
-	'id' => 'onlineinfo',
328
-	'cols' => 'col-sm-6',
329
-	'icon' => 'fa-user',
330
-	'title' => '[%onlineusers_title%]',
331
-	'body' => '<div class="userstable">[+OnlineInfo+]</div>',
332
-	'hide'=>'0'
326
+    'menuindex' => '20',
327
+    'id' => 'onlineinfo',
328
+    'cols' => 'col-sm-6',
329
+    'icon' => 'fa-user',
330
+    'title' => '[%onlineusers_title%]',
331
+    'body' => '<div class="userstable">[+OnlineInfo+]</div>',
332
+    'hide'=>'0'
333 333
 );
334 334
 $widgets['recentinfo'] = array(
335
-	'menuindex' => '30',
336
-	'id' => 'modxrecent_widget',
337
-	'cols' => 'col-sm-12',
338
-	'icon' => 'fa-pencil-square-o',
339
-	'title' => '[%activity_title%]',
340
-	'body' => '<div class="widget-stage">[+RecentInfo+]</div>',
341
-	'hide'=>'0'
335
+    'menuindex' => '30',
336
+    'id' => 'modxrecent_widget',
337
+    'cols' => 'col-sm-12',
338
+    'icon' => 'fa-pencil-square-o',
339
+    'title' => '[%activity_title%]',
340
+    'body' => '<div class="widget-stage">[+RecentInfo+]</div>',
341
+    'hide'=>'0'
342 342
 );
343 343
 if ($modx->config['rss_url_news']) {
344 344
     $widgets['news'] = array(
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
 // invoke OnManagerWelcomeHome event
367 367
 $sitewidgets = $modx->invokeEvent("OnManagerWelcomeHome", array('widgets' => $widgets));
368 368
 if(is_array($sitewidgets)) {
369
-	$newwidgets = array();
369
+    $newwidgets = array();
370 370
     foreach($sitewidgets as $widget){
371 371
         $newwidgets = array_merge($newwidgets, unserialize($widget));
372 372
     }
@@ -374,21 +374,21 @@  discard block
 block discarded – undo
374 374
 }
375 375
 
376 376
 usort($widgets, function ($a, $b) {
377
-	return $a['menuindex'] - $b['menuindex'];
377
+    return $a['menuindex'] - $b['menuindex'];
378 378
 });
379 379
 
380 380
 $tpl = getTplWidget();
381 381
 $output = '';
382 382
 foreach($widgets as $widget) {
383
-	if ($widget['hide'] != '1'){
384
-		$output .= $modx->parseText($tpl, $widget);
385
-	}
383
+    if ($widget['hide'] != '1'){
384
+        $output .= $modx->parseText($tpl, $widget);
385
+    }
386 386
 }
387 387
 $ph['widgets'] = $output;
388 388
 
389 389
 // load template
390 390
 if(!isset($modx->config['manager_welcome_tpl']) || empty($modx->config['manager_welcome_tpl'])) {
391
-	$modx->config['manager_welcome_tpl'] = MODX_MANAGER_PATH . 'media/style/common/welcome.tpl';
391
+    $modx->config['manager_welcome_tpl'] = MODX_MANAGER_PATH . 'media/style/common/welcome.tpl';
392 392
 }
393 393
 
394 394
 $target = $modx->config['manager_welcome_tpl'];
@@ -396,27 +396,27 @@  discard block
 block discarded – undo
396 396
 $target = $modx->mergeSettingsContent($target);
397 397
 
398 398
 if(substr($target, 0, 1) === '@') {
399
-	if(substr($target, 0, 6) === '@CHUNK') {
400
-		$content = $modx->getChunk(trim(substr($target, 7)));
401
-	} elseif(substr($target, 0, 5) === '@FILE') {
402
-		$content = file_get_contents(trim(substr($target, 6)));
403
-	} else {
404
-		$content = '';
405
-	}
399
+    if(substr($target, 0, 6) === '@CHUNK') {
400
+        $content = $modx->getChunk(trim(substr($target, 7)));
401
+    } elseif(substr($target, 0, 5) === '@FILE') {
402
+        $content = file_get_contents(trim(substr($target, 6)));
403
+    } else {
404
+        $content = '';
405
+    }
406 406
 } else {
407
-	$chunk = $modx->getChunk($target);
408
-	if($chunk !== false && !empty($chunk)) {
409
-		$content = $chunk;
410
-	} elseif(is_file(MODX_BASE_PATH . $target)) {
411
-		$content = file_get_contents(MODX_BASE_PATH . $target);
412
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl')) {
413
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl');
414
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html')) // ClipperCMS compatible
415
-	{
416
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html');
417
-	} else {
418
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/common/welcome.tpl');
419
-	}
407
+    $chunk = $modx->getChunk($target);
408
+    if($chunk !== false && !empty($chunk)) {
409
+        $content = $chunk;
410
+    } elseif(is_file(MODX_BASE_PATH . $target)) {
411
+        $content = file_get_contents(MODX_BASE_PATH . $target);
412
+    } elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl')) {
413
+        $content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl');
414
+    } elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html')) // ClipperCMS compatible
415
+    {
416
+        $content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html');
417
+    } else {
418
+        $content = file_get_contents(MODX_MANAGER_PATH . 'media/style/common/welcome.tpl');
419
+    }
420 420
 }
421 421
 
422 422
 // merge placeholders
@@ -424,8 +424,8 @@  discard block
 block discarded – undo
424 424
 $content = $modx->mergeSettingsContent($content);
425 425
 $content = $modx->parseText($content, $ph);
426 426
 if(strpos($content, '[+') !== false) {
427
-	$modx->toPlaceholders($ph);
428
-	$content = $modx->mergePlaceholderContent($content);
427
+    $modx->toPlaceholders($ph);
428
+    $content = $modx->mergePlaceholderContent($content);
429 429
 }
430 430
 $content = $modx->parseDocumentSource($content);
431 431
 $content = $modx->parseText($content, $_lang, '[%', '%]');
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
 $content = $modx->cleanUpMODXTags($content); //cleanup
434 434
 
435 435
 if($js = $modx->getRegisteredClientScripts()) {
436
-	$content .= $js;
436
+    $content .= $js;
437 437
 }
438 438
 
439 439
 echo $content;
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
 //  <a href="javascript:;" class="closed"><i class="fa fa-close"></i></a>
444 444
 //</span>
445 445
 function getTplWidget() { // recent document info
446
-	return '
446
+    return '
447 447
 		<div class="[+cols+]" id="[+id+]">
448 448
 			<div class="card"[+cardAttr+]>
449 449
 				<div class="card-header"[+headAttr+]> <i class="fa [+icon+]"></i> [+title+] </div>
@@ -454,11 +454,11 @@  discard block
 block discarded – undo
454 454
 }
455 455
 
456 456
 function getRecentInfo() { // recent document info
457
-	global $modx;
457
+    global $modx;
458 458
 
459
-	$modx->addSnippet('recentInfoList', 'getRecentInfoList');
459
+    $modx->addSnippet('recentInfoList', 'getRecentInfoList');
460 460
 
461
-	$html = '
461
+    $html = '
462 462
 			<div class="table-responsive">
463 463
 				<table class="table data">
464 464
 					<thead>
@@ -476,96 +476,96 @@  discard block
 block discarded – undo
476 476
 				</table>
477 477
 			</div>
478 478
 ';
479
-	return $html;
479
+    return $html;
480 480
 }
481 481
 
482 482
 function getRecentInfoList() {
483
-	global $modx;
484
-
485
-	$rs = $modx->db->select('*', '[+prefix+]site_content', '', 'editedon DESC', 10);
486
-
487
-	if($modx->db->getRecordCount($rs) < 1) {
488
-		return '<tr><td>[%no_activity_message%]</td></tr>';
489
-	}
490
-
491
-	$tpl = getRecentInfoRowTpl();
492
-
493
-	$btntpl['edit'] = '<a title="[%edit_resource%]" href="index.php?a=27&amp;id=[+id+]" target="main"><i class="fa fa-edit fa-fw"></i></a> ';
494
-	$btntpl['preview_btn'] = '<a [+preview_disabled+]" title="[%preview_resource%]" target="_blank" href="../index.php?&amp;id=[+id+]"><i class="fa fa-eye fa-fw"></i></a> ';
495
-
496
-	$output = array();
497
-	while($ph = $modx->db->getRow($rs)) {
498
-		$docid = $ph['id'];
499
-		$_ = $modx->getUserInfo($ph['editedby']);
500
-		$ph['username'] = $_['username'];
501
-
502
-		if($ph['deleted'] == 1) {
503
-			$ph['status'] = 'deleted text-danger';
504
-		} elseif($ph['published'] == 0) {
505
-			$ph['status'] = 'unpublished font-italic text-muted';
506
-		} else {
507
-			$ph['status'] = 'published';
508
-		}
509
-
510
-		if($modx->hasPermission('edit_document')) {
511
-			$ph['edit_btn'] = str_replace('[+id+]', $docid, $btntpl['edit']);
512
-		} else {
513
-			$ph['edit_btn'] = '';
514
-		}
515
-
516
-		$preview_disabled = ($ph['deleted'] == 1) ? 'disabled' : '';
517
-		$ph['preview_btn'] = str_replace(array(
518
-			'[+id+]',
519
-			'[+preview_disabled+]'
520
-		), array(
521
-			$docid,
522
-			$preview_disabled
523
-		), $btntpl['preview_btn']);
524
-
525
-		if($modx->hasPermission('delete_document')) {
526
-			if($ph['deleted'] == 0) {
527
-				$delete_btn = '<a onclick="return confirm(\'[%confirm_delete_record%]\')" title="[%delete_resource%]" href="index.php?a=6&amp;id=[+id+]" target="main"><i class="fa fa-trash fa-fw"></i></a> ';
528
-			} else {
529
-				$delete_btn = '<a onclick="return confirm(\'[%confirm_undelete%]\')" title="[%undelete_resource%]" href="index.php?a=63&amp;id=[+id+]" target="main"><i class="fa fa-arrow-circle-o-up fa-fw"></i></a> ';
530
-			}
531
-			$ph['delete_btn'] = str_replace('[+id+]', $docid, $delete_btn);
532
-		} else {
533
-			$ph['delete_btn'] = '';
534
-		}
535
-
536
-		if($ph['deleted'] == 1 && $ph['published'] == 0) {
537
-			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
538
-		} elseif($ph['deleted'] == 1 && $ph['published'] == 1) {
539
-			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
540
-		} elseif($ph['deleted'] == 0 && $ph['published'] == 0) {
541
-			$publish_btn = '<a title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
542
-		} else {
543
-			$publish_btn = '<a title="[%unpublish_resource%]" href="index.php?a=62&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
544
-		}
545
-		$ph['publish_btn'] = str_replace('[+id+]', $docid, $publish_btn);
546
-
547
-		$ph['info_btn'] = str_replace('[+id+]', $docid, '<a title="[%resource_overview%]" data-toggle="collapse" data-target=".collapse[+id+]"><i class="fa fa-info fa-fw"></i></a>');
548
-
549
-		if($ph['longtitle'] == '') {
550
-			$ph['longtitle'] = '(<i>[%not_set%]</i>)';
551
-		}
552
-		if($ph['description'] == '') {
553
-			$ph['description'] = '(<i>[%not_set%]</i>)';
554
-		}
555
-		if($ph['introtext'] == '') {
556
-			$ph['introtext'] = '(<i>[%not_set%]</i>)';
557
-		}
558
-		if($ph['alias'] == '') {
559
-			$ph['alias'] = '(<i>[%not_set%]</i>)';
560
-		}
561
-
562
-		$output[] = $modx->parseText($tpl, $ph);
563
-	}
564
-	return implode("\n", $output);
483
+    global $modx;
484
+
485
+    $rs = $modx->db->select('*', '[+prefix+]site_content', '', 'editedon DESC', 10);
486
+
487
+    if($modx->db->getRecordCount($rs) < 1) {
488
+        return '<tr><td>[%no_activity_message%]</td></tr>';
489
+    }
490
+
491
+    $tpl = getRecentInfoRowTpl();
492
+
493
+    $btntpl['edit'] = '<a title="[%edit_resource%]" href="index.php?a=27&amp;id=[+id+]" target="main"><i class="fa fa-edit fa-fw"></i></a> ';
494
+    $btntpl['preview_btn'] = '<a [+preview_disabled+]" title="[%preview_resource%]" target="_blank" href="../index.php?&amp;id=[+id+]"><i class="fa fa-eye fa-fw"></i></a> ';
495
+
496
+    $output = array();
497
+    while($ph = $modx->db->getRow($rs)) {
498
+        $docid = $ph['id'];
499
+        $_ = $modx->getUserInfo($ph['editedby']);
500
+        $ph['username'] = $_['username'];
501
+
502
+        if($ph['deleted'] == 1) {
503
+            $ph['status'] = 'deleted text-danger';
504
+        } elseif($ph['published'] == 0) {
505
+            $ph['status'] = 'unpublished font-italic text-muted';
506
+        } else {
507
+            $ph['status'] = 'published';
508
+        }
509
+
510
+        if($modx->hasPermission('edit_document')) {
511
+            $ph['edit_btn'] = str_replace('[+id+]', $docid, $btntpl['edit']);
512
+        } else {
513
+            $ph['edit_btn'] = '';
514
+        }
515
+
516
+        $preview_disabled = ($ph['deleted'] == 1) ? 'disabled' : '';
517
+        $ph['preview_btn'] = str_replace(array(
518
+            '[+id+]',
519
+            '[+preview_disabled+]'
520
+        ), array(
521
+            $docid,
522
+            $preview_disabled
523
+        ), $btntpl['preview_btn']);
524
+
525
+        if($modx->hasPermission('delete_document')) {
526
+            if($ph['deleted'] == 0) {
527
+                $delete_btn = '<a onclick="return confirm(\'[%confirm_delete_record%]\')" title="[%delete_resource%]" href="index.php?a=6&amp;id=[+id+]" target="main"><i class="fa fa-trash fa-fw"></i></a> ';
528
+            } else {
529
+                $delete_btn = '<a onclick="return confirm(\'[%confirm_undelete%]\')" title="[%undelete_resource%]" href="index.php?a=63&amp;id=[+id+]" target="main"><i class="fa fa-arrow-circle-o-up fa-fw"></i></a> ';
530
+            }
531
+            $ph['delete_btn'] = str_replace('[+id+]', $docid, $delete_btn);
532
+        } else {
533
+            $ph['delete_btn'] = '';
534
+        }
535
+
536
+        if($ph['deleted'] == 1 && $ph['published'] == 0) {
537
+            $publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
538
+        } elseif($ph['deleted'] == 1 && $ph['published'] == 1) {
539
+            $publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
540
+        } elseif($ph['deleted'] == 0 && $ph['published'] == 0) {
541
+            $publish_btn = '<a title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
542
+        } else {
543
+            $publish_btn = '<a title="[%unpublish_resource%]" href="index.php?a=62&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
544
+        }
545
+        $ph['publish_btn'] = str_replace('[+id+]', $docid, $publish_btn);
546
+
547
+        $ph['info_btn'] = str_replace('[+id+]', $docid, '<a title="[%resource_overview%]" data-toggle="collapse" data-target=".collapse[+id+]"><i class="fa fa-info fa-fw"></i></a>');
548
+
549
+        if($ph['longtitle'] == '') {
550
+            $ph['longtitle'] = '(<i>[%not_set%]</i>)';
551
+        }
552
+        if($ph['description'] == '') {
553
+            $ph['description'] = '(<i>[%not_set%]</i>)';
554
+        }
555
+        if($ph['introtext'] == '') {
556
+            $ph['introtext'] = '(<i>[%not_set%]</i>)';
557
+        }
558
+        if($ph['alias'] == '') {
559
+            $ph['alias'] = '(<i>[%not_set%]</i>)';
560
+        }
561
+
562
+        $output[] = $modx->parseText($tpl, $ph);
563
+    }
564
+    return implode("\n", $output);
565 565
 }
566 566
 
567 567
 function getRecentInfoRowTpl() {
568
-	$tpl = '
568
+    $tpl = '
569 569
 						<tr>
570 570
 							<td data-toggle="collapse" data-target=".collapse[+id+]" class="text-right"><span class="label label-info">[+id+]</span></td>
571 571
 							<td data-toggle="collapse" data-target=".collapse[+id+]"><a class="[+status+]" title="[%edit_resource%]" href="index.php?a=3&amp;id=[+id+]" target="main">[+pagetitle+]</a></td>
@@ -589,16 +589,16 @@  discard block
 block discarded – undo
589 589
 								</div>
590 590
 							</td>
591 591
 						</tr>';
592
-	return $tpl;
592
+    return $tpl;
593 593
 }
594 594
 
595 595
 // setup icons
596 596
 function wrapIcon($i, $action) {
597
-	return sprintf('<a href="index.php?a=%s" target="main"><span class="wm_button" style="border:0">%s</span></a>', $action, $i);
597
+    return sprintf('<a href="index.php?a=%s" target="main"><span class="wm_button" style="border:0">%s</span></a>', $action, $i);
598 598
 }
599 599
 
600 600
 function getStartUpScript() {
601
-	$script = '
601
+    $script = '
602 602
         <script type="text/javascript">
603 603
         function hideConfigCheckWarning(key) {
604 604
         	var xhr = new XMLHttpRequest();
@@ -622,5 +622,5 @@  discard block
 block discarded – undo
622 622
 		})(jQuery);        
623 623
         </script>
624 624
 ';
625
-	return $script;
625
+    return $script;
626 626
 }
Please login to merge, or discard this patch.
Spacing   +65 added lines, -65 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
 	die('<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.');
4 4
 }
5 5
 
6 6
 unset($_SESSION['itemname']); // clear this, because it's only set for logging purposes
7 7
 
8
-if($modx->hasPermission('settings') && (!isset($settings_version) || $settings_version != $modx->getVersionData('version'))) {
8
+if ($modx->hasPermission('settings') && (!isset($settings_version) || $settings_version != $modx->getVersionData('version'))) {
9 9
 	// seems to be a new install - send the user to the configuration page
10 10
 	exit('<script type="text/javascript">document.location.href="index.php?a=17";</script>');
11 11
 }
@@ -16,50 +16,50 @@  discard block
 block discarded – undo
16 16
 $_SESSION['nrnewmessages'] = 0;
17 17
 
18 18
 // setup message info
19
-if($modx->hasPermission('messages')) {
20
-	include_once(MODX_MANAGER_PATH . 'includes/messageCount.inc.php');
19
+if ($modx->hasPermission('messages')) {
20
+	include_once(MODX_MANAGER_PATH.'includes/messageCount.inc.php');
21 21
 	$_SESSION['nrtotalmessages'] = $nrtotalmessages;
22 22
 	$_SESSION['nrnewmessages'] = $nrnewmessages;
23 23
 
24 24
 	$msg = array();
25 25
 	$msg[] = sprintf('<a href="index.php?a=10" target="main"><img src="%s" /></a>', $_style['icons_mail_large']);
26
-	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? ' (<span style="color:red">' . $_SESSION['nrnewmessages'] . '</span>)' : '';
26
+	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? ' (<span style="color:red">'.$_SESSION['nrnewmessages'].'</span>)' : '';
27 27
 	$msg[] = sprintf('<span style="color:#909090;font-size:15px;font-weight:bold">&nbsp;<a class="wm_messages_inbox_link" href="index.php?a=10" target="main">[%%inbox%%]</a>%s</span><br />', $nrnewmessages);
28
-	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? '<span style="color:red;">' . $_SESSION['nrnewmessages'] . '</span>' : '0';
28
+	$nrnewmessages = $_SESSION['nrnewmessages'] > 0 ? '<span style="color:red;">'.$_SESSION['nrnewmessages'].'</span>' : '0';
29 29
 	$welcome_messages = sprintf($_lang['welcome_messages'], $_SESSION['nrtotalmessages'], $nrnewmessages);
30 30
 	$msg[] = sprintf('<span class="comment">%s</span>', $welcome_messages);
31 31
 	$ph['MessageInfo'] = implode("\n", $msg);
32 32
 }
33 33
 
34 34
 // setup icons
35
-if($modx->hasPermission('new_user') || $modx->hasPermission('edit_user')) {
35
+if ($modx->hasPermission('new_user') || $modx->hasPermission('edit_user')) {
36 36
 	$icon = '<i class="[&icons_security_large&]" alt="[%user_management_title%]"> </i>[%user_management_title%]';
37 37
 	$ph['SecurityIcon'] = wrapIcon($icon, 75);
38 38
 }
39
-if($modx->hasPermission('new_web_user') || $modx->hasPermission('edit_web_user')) {
39
+if ($modx->hasPermission('new_web_user') || $modx->hasPermission('edit_web_user')) {
40 40
 	$icon = '<i class="[&icons_webusers_large&]" alt="[%web_user_management_title%]"> </i>[%web_user_management_title%]';
41 41
 	$ph['WebUserIcon'] = wrapIcon($icon, 99);
42 42
 }
43
-if($modx->hasPermission('new_module') || $modx->hasPermission('edit_module')) {
43
+if ($modx->hasPermission('new_module') || $modx->hasPermission('edit_module')) {
44 44
 	$icon = '<i class="[&icons_modules_large&]" alt="[%manage_modules%]"> </i>[%modules%]';
45 45
 	$ph['ModulesIcon'] = wrapIcon($icon, 106);
46 46
 }
47
-if($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
47
+if ($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
48 48
 	$icon = '<i class="[&icons_resources_large&]" alt="[%element_management%]"> </i>[%elements%]';
49 49
 	$ph['ResourcesIcon'] = wrapIcon($icon, 76);
50 50
 }
51
-if($modx->hasPermission('bk_manager')) {
51
+if ($modx->hasPermission('bk_manager')) {
52 52
 	$icon = '<i class="[&icons_backup_large&]" alt="[%bk_manager%]"> </i>[%backup%]';
53 53
 	$ph['BackupIcon'] = wrapIcon($icon, 93);
54 54
 }
55
-if($modx->hasPermission('help')) {
55
+if ($modx->hasPermission('help')) {
56 56
 	$icon = '<i class="[&icons_help_large&]" alt="[%help%]" /> </i>[%help%]';
57 57
 	$ph['HelpIcon'] = wrapIcon($icon, 9);
58 58
 }
59 59
 // do some config checks
60
-if(($modx->config['warning_visibility'] == 0 && $_SESSION['mgrRole'] == 1) || $modx->config['warning_visibility'] == 1) {
61
-	include_once(MODX_MANAGER_PATH . 'includes/config_check.inc.php');
62
-	if($config_check_results != $_lang['configcheck_ok']) {
60
+if (($modx->config['warning_visibility'] == 0 && $_SESSION['mgrRole'] == 1) || $modx->config['warning_visibility'] == 1) {
61
+	include_once(MODX_MANAGER_PATH.'includes/config_check.inc.php');
62
+	if ($config_check_results != $_lang['configcheck_ok']) {
63 63
 		$ph['config_check_results'] = $config_check_results;
64 64
 		$ph['config_display'] = 'block';
65 65
 	} else {
@@ -70,8 +70,8 @@  discard block
 block discarded – undo
70 70
 }
71 71
 
72 72
 // Check logout-reminder
73
-if(isset($_SESSION['show_logout_reminder'])) {
74
-	switch($_SESSION['show_logout_reminder']['type']) {
73
+if (isset($_SESSION['show_logout_reminder'])) {
74
+	switch ($_SESSION['show_logout_reminder']['type']) {
75 75
 		case 'logout_reminder':
76 76
 			$date = $modx->toDateFormat($_SESSION['show_logout_reminder']['lastHit'], 'dateOnly');
77 77
 			$ph['logout_reminder_msg'] = str_replace('[+date+]', $date, $_lang['logout_reminder_msg']);
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 	</tr>
126 126
 </table>';
127 127
 
128
-$nrnewmessages = '<span class="text-danger">' . $_SESSION['nrnewmessages'] . '</span>';
128
+$nrnewmessages = '<span class="text-danger">'.$_SESSION['nrnewmessages'].'</span>';
129 129
 
130 130
 $ph['UserInfo'] = $modx->parseText($tpl, array(
131 131
 	'username' => $modx->getLoginUserName(),
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
 $from[] = " us LEFT JOIN [+prefix+]active_users au ON au.sid=us.sid WHERE au.action <> '8'";
141 141
 $rs = $modx->db->select('*', $from, '', 'username ASC, au.sid ASC');
142 142
 
143
-if($modx->db->getRecordCount($rs) < 1) {
143
+if ($modx->db->getRecordCount($rs) < 1) {
144 144
 	$html = '<p>[%no_active_users_found%]</p>';
145 145
 } else {
146
-	include_once(MODX_MANAGER_PATH . 'includes/actionlist.inc.php');
146
+	include_once(MODX_MANAGER_PATH.'includes/actionlist.inc.php');
147 147
 	$now = $_SERVER['REQUEST_TIME'] + $server_offset_time;
148 148
 	$ph['now'] = strftime('%H:%M:%S', $now);
149 149
 	$timetocheck = ($now - (60 * 20)); //+$server_offset_time;
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 	$userList = array();
169 169
 	$userCount = array();
170 170
 	// Create userlist with session-count first before output
171
-	while($activeusers = $modx->db->getRow($rs)) {
171
+	while ($activeusers = $modx->db->getRow($rs)) {
172 172
 		$userCount[$activeusers['internalKey']] = isset($userCount[$activeusers['internalKey']]) ? $userCount[$activeusers['internalKey']] + 1 : 1;
173 173
 
174 174
 		$idle = $activeusers['lasthit'] < $timetocheck ? ' class="userIdle"' : '';
@@ -186,9 +186,9 @@  discard block
 block discarded – undo
186 186
 			$currentaction
187 187
 		);
188 188
 	}
189
-	foreach($userList as $params) {
189
+	foreach ($userList as $params) {
190 190
 		$params[1] = $userCount[$params[4]] > 1 ? ' class="userMultipleSessions"' : '';
191
-		$html .= "\n\t\t" . vsprintf('<tr%s><td><strong%s>%s</strong></td><td>%s%s</td><td>%s</td><td>%s</td><td>%s</td></tr>', $params);
191
+		$html .= "\n\t\t".vsprintf('<tr%s><td><strong%s>%s</strong></td><td>%s%s</td><td>%s</td><td>%s</td><td>%s</td></tr>', $params);
192 192
 	}
193 193
 
194 194
 	$html .= '
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 $ph['OnlineInfo'] = $html;
201 201
 
202 202
 // include rss feeds for important forum topics
203
-include_once(MODX_MANAGER_PATH . 'includes/rss.inc.php');
203
+include_once(MODX_MANAGER_PATH.'includes/rss.inc.php');
204 204
 $ph['modx_security_notices_content'] = $feedData['modx_security_notices_content'];
205 205
 $ph['modx_news_content'] = $feedData['modx_news_content'];
206 206
 
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
 // invoke event OnManagerWelcomePrerender
233 233
 $evtOut = $modx->invokeEvent('OnManagerWelcomePrerender');
234
-if(is_array($evtOut)) {
234
+if (is_array($evtOut)) {
235 235
 	$output = implode('', $evtOut);
236 236
 	$ph['OnManagerWelcomePrerender'] = $output;
237 237
 }
@@ -365,57 +365,57 @@  discard block
 block discarded – undo
365 365
 
366 366
 // invoke OnManagerWelcomeHome event
367 367
 $sitewidgets = $modx->invokeEvent("OnManagerWelcomeHome", array('widgets' => $widgets));
368
-if(is_array($sitewidgets)) {
368
+if (is_array($sitewidgets)) {
369 369
 	$newwidgets = array();
370
-    foreach($sitewidgets as $widget){
370
+    foreach ($sitewidgets as $widget) {
371 371
         $newwidgets = array_merge($newwidgets, unserialize($widget));
372 372
     }
373 373
     $widgets = (count($newwidgets) > 0) ? $newwidgets : $widgets;
374 374
 }
375 375
 
376
-usort($widgets, function ($a, $b) {
376
+usort($widgets, function($a, $b){
377 377
 	return $a['menuindex'] - $b['menuindex'];
378 378
 });
379 379
 
380 380
 $tpl = getTplWidget();
381 381
 $output = '';
382
-foreach($widgets as $widget) {
383
-	if ($widget['hide'] != '1'){
382
+foreach ($widgets as $widget) {
383
+	if ($widget['hide'] != '1') {
384 384
 		$output .= $modx->parseText($tpl, $widget);
385 385
 	}
386 386
 }
387 387
 $ph['widgets'] = $output;
388 388
 
389 389
 // load template
390
-if(!isset($modx->config['manager_welcome_tpl']) || empty($modx->config['manager_welcome_tpl'])) {
391
-	$modx->config['manager_welcome_tpl'] = MODX_MANAGER_PATH . 'media/style/common/welcome.tpl';
390
+if (!isset($modx->config['manager_welcome_tpl']) || empty($modx->config['manager_welcome_tpl'])) {
391
+	$modx->config['manager_welcome_tpl'] = MODX_MANAGER_PATH.'media/style/common/welcome.tpl';
392 392
 }
393 393
 
394 394
 $target = $modx->config['manager_welcome_tpl'];
395 395
 $target = str_replace('[+base_path+]', MODX_BASE_PATH, $target);
396 396
 $target = $modx->mergeSettingsContent($target);
397 397
 
398
-if(substr($target, 0, 1) === '@') {
399
-	if(substr($target, 0, 6) === '@CHUNK') {
398
+if (substr($target, 0, 1) === '@') {
399
+	if (substr($target, 0, 6) === '@CHUNK') {
400 400
 		$content = $modx->getChunk(trim(substr($target, 7)));
401
-	} elseif(substr($target, 0, 5) === '@FILE') {
401
+	} elseif (substr($target, 0, 5) === '@FILE') {
402 402
 		$content = file_get_contents(trim(substr($target, 6)));
403 403
 	} else {
404 404
 		$content = '';
405 405
 	}
406 406
 } else {
407 407
 	$chunk = $modx->getChunk($target);
408
-	if($chunk !== false && !empty($chunk)) {
408
+	if ($chunk !== false && !empty($chunk)) {
409 409
 		$content = $chunk;
410
-	} elseif(is_file(MODX_BASE_PATH . $target)) {
411
-		$content = file_get_contents(MODX_BASE_PATH . $target);
412
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl')) {
413
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl');
414
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html')) // ClipperCMS compatible
410
+	} elseif (is_file(MODX_BASE_PATH.$target)) {
411
+		$content = file_get_contents(MODX_BASE_PATH.$target);
412
+	} elseif (is_file(MODX_MANAGER_PATH.'media/style/'.$modx->config['manager_theme'].'/welcome.tpl')) {
413
+		$content = file_get_contents(MODX_MANAGER_PATH.'media/style/'.$modx->config['manager_theme'].'/welcome.tpl');
414
+	} elseif (is_file(MODX_MANAGER_PATH.'media/style/'.$modx->config['manager_theme'].'/html/welcome.html')) // ClipperCMS compatible
415 415
 	{
416
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html');
416
+		$content = file_get_contents(MODX_MANAGER_PATH.'media/style/'.$modx->config['manager_theme'].'/html/welcome.html');
417 417
 	} else {
418
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/common/welcome.tpl');
418
+		$content = file_get_contents(MODX_MANAGER_PATH.'media/style/common/welcome.tpl');
419 419
 	}
420 420
 }
421 421
 
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
 $content = $modx->mergeConditionalTagsContent($content);
424 424
 $content = $modx->mergeSettingsContent($content);
425 425
 $content = $modx->parseText($content, $ph);
426
-if(strpos($content, '[+') !== false) {
426
+if (strpos($content, '[+') !== false) {
427 427
 	$modx->toPlaceholders($ph);
428 428
 	$content = $modx->mergePlaceholderContent($content);
429 429
 }
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
 $content = $modx->parseText($content, $_style, '[&', '&]');
433 433
 $content = $modx->cleanUpMODXTags($content); //cleanup
434 434
 
435
-if($js = $modx->getRegisteredClientScripts()) {
435
+if ($js = $modx->getRegisteredClientScripts()) {
436 436
 	$content .= $js;
437 437
 }
438 438
 
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
 //	<a href="javascript:;" class="setting"><i class="fa fa-cog"></i></a>
443 443
 //  <a href="javascript:;" class="closed"><i class="fa fa-close"></i></a>
444 444
 //</span>
445
-function getTplWidget() { // recent document info
445
+function getTplWidget(){ // recent document info
446 446
 	return '
447 447
 		<div class="[+cols+]" id="[+id+]">
448 448
 			<div class="card"[+cardAttr+]>
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 ';
454 454
 }
455 455
 
456
-function getRecentInfo() { // recent document info
456
+function getRecentInfo(){ // recent document info
457 457
 	global $modx;
458 458
 
459 459
 	$modx->addSnippet('recentInfoList', 'getRecentInfoList');
@@ -479,12 +479,12 @@  discard block
 block discarded – undo
479 479
 	return $html;
480 480
 }
481 481
 
482
-function getRecentInfoList() {
482
+function getRecentInfoList(){
483 483
 	global $modx;
484 484
 
485 485
 	$rs = $modx->db->select('*', '[+prefix+]site_content', '', 'editedon DESC', 10);
486 486
 
487
-	if($modx->db->getRecordCount($rs) < 1) {
487
+	if ($modx->db->getRecordCount($rs) < 1) {
488 488
 		return '<tr><td>[%no_activity_message%]</td></tr>';
489 489
 	}
490 490
 
@@ -494,20 +494,20 @@  discard block
 block discarded – undo
494 494
 	$btntpl['preview_btn'] = '<a [+preview_disabled+]" title="[%preview_resource%]" target="_blank" href="../index.php?&amp;id=[+id+]"><i class="fa fa-eye fa-fw"></i></a> ';
495 495
 
496 496
 	$output = array();
497
-	while($ph = $modx->db->getRow($rs)) {
497
+	while ($ph = $modx->db->getRow($rs)) {
498 498
 		$docid = $ph['id'];
499 499
 		$_ = $modx->getUserInfo($ph['editedby']);
500 500
 		$ph['username'] = $_['username'];
501 501
 
502
-		if($ph['deleted'] == 1) {
502
+		if ($ph['deleted'] == 1) {
503 503
 			$ph['status'] = 'deleted text-danger';
504
-		} elseif($ph['published'] == 0) {
504
+		} elseif ($ph['published'] == 0) {
505 505
 			$ph['status'] = 'unpublished font-italic text-muted';
506 506
 		} else {
507 507
 			$ph['status'] = 'published';
508 508
 		}
509 509
 
510
-		if($modx->hasPermission('edit_document')) {
510
+		if ($modx->hasPermission('edit_document')) {
511 511
 			$ph['edit_btn'] = str_replace('[+id+]', $docid, $btntpl['edit']);
512 512
 		} else {
513 513
 			$ph['edit_btn'] = '';
@@ -522,8 +522,8 @@  discard block
 block discarded – undo
522 522
 			$preview_disabled
523 523
 		), $btntpl['preview_btn']);
524 524
 
525
-		if($modx->hasPermission('delete_document')) {
526
-			if($ph['deleted'] == 0) {
525
+		if ($modx->hasPermission('delete_document')) {
526
+			if ($ph['deleted'] == 0) {
527 527
 				$delete_btn = '<a onclick="return confirm(\'[%confirm_delete_record%]\')" title="[%delete_resource%]" href="index.php?a=6&amp;id=[+id+]" target="main"><i class="fa fa-trash fa-fw"></i></a> ';
528 528
 			} else {
529 529
 				$delete_btn = '<a onclick="return confirm(\'[%confirm_undelete%]\')" title="[%undelete_resource%]" href="index.php?a=63&amp;id=[+id+]" target="main"><i class="fa fa-arrow-circle-o-up fa-fw"></i></a> ';
@@ -533,11 +533,11 @@  discard block
 block discarded – undo
533 533
 			$ph['delete_btn'] = '';
534 534
 		}
535 535
 
536
-		if($ph['deleted'] == 1 && $ph['published'] == 0) {
536
+		if ($ph['deleted'] == 1 && $ph['published'] == 0) {
537 537
 			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
538
-		} elseif($ph['deleted'] == 1 && $ph['published'] == 1) {
538
+		} elseif ($ph['deleted'] == 1 && $ph['published'] == 1) {
539 539
 			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
540
-		} elseif($ph['deleted'] == 0 && $ph['published'] == 0) {
540
+		} elseif ($ph['deleted'] == 0 && $ph['published'] == 0) {
541 541
 			$publish_btn = '<a title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
542 542
 		} else {
543 543
 			$publish_btn = '<a title="[%unpublish_resource%]" href="index.php?a=62&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
@@ -546,16 +546,16 @@  discard block
 block discarded – undo
546 546
 
547 547
 		$ph['info_btn'] = str_replace('[+id+]', $docid, '<a title="[%resource_overview%]" data-toggle="collapse" data-target=".collapse[+id+]"><i class="fa fa-info fa-fw"></i></a>');
548 548
 
549
-		if($ph['longtitle'] == '') {
549
+		if ($ph['longtitle'] == '') {
550 550
 			$ph['longtitle'] = '(<i>[%not_set%]</i>)';
551 551
 		}
552
-		if($ph['description'] == '') {
552
+		if ($ph['description'] == '') {
553 553
 			$ph['description'] = '(<i>[%not_set%]</i>)';
554 554
 		}
555
-		if($ph['introtext'] == '') {
555
+		if ($ph['introtext'] == '') {
556 556
 			$ph['introtext'] = '(<i>[%not_set%]</i>)';
557 557
 		}
558
-		if($ph['alias'] == '') {
558
+		if ($ph['alias'] == '') {
559 559
 			$ph['alias'] = '(<i>[%not_set%]</i>)';
560 560
 		}
561 561
 
@@ -564,7 +564,7 @@  discard block
 block discarded – undo
564 564
 	return implode("\n", $output);
565 565
 }
566 566
 
567
-function getRecentInfoRowTpl() {
567
+function getRecentInfoRowTpl(){
568 568
 	$tpl = '
569 569
 						<tr>
570 570
 							<td data-toggle="collapse" data-target=".collapse[+id+]" class="text-right"><span class="label label-info">[+id+]</span></td>
@@ -593,11 +593,11 @@  discard block
 block discarded – undo
593 593
 }
594 594
 
595 595
 // setup icons
596
-function wrapIcon($i, $action) {
596
+function wrapIcon($i, $action){
597 597
 	return sprintf('<a href="index.php?a=%s" target="main"><span class="wm_button" style="border:0">%s</span></a>', $action, $i);
598 598
 }
599 599
 
600
-function getStartUpScript() {
600
+function getStartUpScript(){
601 601
 	$script = '
602 602
         <script type="text/javascript">
603 603
         function hideConfigCheckWarning(key) {
Please login to merge, or discard this patch.
Braces   +77 added lines, -67 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
 	die('<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.');
4 4
 }
5 5
 
6 6
 unset($_SESSION['itemname']); // clear this, because it's only set for logging purposes
7 7
 
8
-if($modx->hasPermission('settings') && (!isset($settings_version) || $settings_version != $modx->getVersionData('version'))) {
8
+if($modx->hasPermission('settings') && (!isset($settings_version) || $settings_version != $modx->getVersionData('version'))) {
9 9
 	// seems to be a new install - send the user to the configuration page
10 10
 	exit('<script type="text/javascript">document.location.href="index.php?a=17";</script>');
11 11
 }
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 $_SESSION['nrnewmessages'] = 0;
17 17
 
18 18
 // setup message info
19
-if($modx->hasPermission('messages')) {
19
+if($modx->hasPermission('messages')) {
20 20
 	include_once(MODX_MANAGER_PATH . 'includes/messageCount.inc.php');
21 21
 	$_SESSION['nrtotalmessages'] = $nrtotalmessages;
22 22
 	$_SESSION['nrnewmessages'] = $nrnewmessages;
@@ -32,46 +32,46 @@  discard block
 block discarded – undo
32 32
 }
33 33
 
34 34
 // setup icons
35
-if($modx->hasPermission('new_user') || $modx->hasPermission('edit_user')) {
35
+if($modx->hasPermission('new_user') || $modx->hasPermission('edit_user')) {
36 36
 	$icon = '<i class="[&icons_security_large&]" alt="[%user_management_title%]"> </i>[%user_management_title%]';
37 37
 	$ph['SecurityIcon'] = wrapIcon($icon, 75);
38 38
 }
39
-if($modx->hasPermission('new_web_user') || $modx->hasPermission('edit_web_user')) {
39
+if($modx->hasPermission('new_web_user') || $modx->hasPermission('edit_web_user')) {
40 40
 	$icon = '<i class="[&icons_webusers_large&]" alt="[%web_user_management_title%]"> </i>[%web_user_management_title%]';
41 41
 	$ph['WebUserIcon'] = wrapIcon($icon, 99);
42 42
 }
43
-if($modx->hasPermission('new_module') || $modx->hasPermission('edit_module')) {
43
+if($modx->hasPermission('new_module') || $modx->hasPermission('edit_module')) {
44 44
 	$icon = '<i class="[&icons_modules_large&]" alt="[%manage_modules%]"> </i>[%modules%]';
45 45
 	$ph['ModulesIcon'] = wrapIcon($icon, 106);
46 46
 }
47
-if($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
47
+if($modx->hasPermission('new_template') || $modx->hasPermission('edit_template') || $modx->hasPermission('new_snippet') || $modx->hasPermission('edit_snippet') || $modx->hasPermission('new_plugin') || $modx->hasPermission('edit_plugin') || $modx->hasPermission('manage_metatags')) {
48 48
 	$icon = '<i class="[&icons_resources_large&]" alt="[%element_management%]"> </i>[%elements%]';
49 49
 	$ph['ResourcesIcon'] = wrapIcon($icon, 76);
50 50
 }
51
-if($modx->hasPermission('bk_manager')) {
51
+if($modx->hasPermission('bk_manager')) {
52 52
 	$icon = '<i class="[&icons_backup_large&]" alt="[%bk_manager%]"> </i>[%backup%]';
53 53
 	$ph['BackupIcon'] = wrapIcon($icon, 93);
54 54
 }
55
-if($modx->hasPermission('help')) {
55
+if($modx->hasPermission('help')) {
56 56
 	$icon = '<i class="[&icons_help_large&]" alt="[%help%]" /> </i>[%help%]';
57 57
 	$ph['HelpIcon'] = wrapIcon($icon, 9);
58 58
 }
59 59
 // do some config checks
60
-if(($modx->config['warning_visibility'] == 0 && $_SESSION['mgrRole'] == 1) || $modx->config['warning_visibility'] == 1) {
60
+if(($modx->config['warning_visibility'] == 0 && $_SESSION['mgrRole'] == 1) || $modx->config['warning_visibility'] == 1) {
61 61
 	include_once(MODX_MANAGER_PATH . 'includes/config_check.inc.php');
62
-	if($config_check_results != $_lang['configcheck_ok']) {
62
+	if($config_check_results != $_lang['configcheck_ok']) {
63 63
 		$ph['config_check_results'] = $config_check_results;
64 64
 		$ph['config_display'] = 'block';
65
-	} else {
65
+	} else {
66 66
 		$ph['config_display'] = 'none';
67 67
 	}
68
-} else {
68
+} else {
69 69
 	$ph['config_display'] = 'none';
70 70
 }
71 71
 
72 72
 // Check logout-reminder
73
-if(isset($_SESSION['show_logout_reminder'])) {
74
-	switch($_SESSION['show_logout_reminder']['type']) {
73
+if(isset($_SESSION['show_logout_reminder'])) {
74
+	switch($_SESSION['show_logout_reminder']['type']) {
75 75
 		case 'logout_reminder':
76 76
 			$date = $modx->toDateFormat($_SESSION['show_logout_reminder']['lastHit'], 'dateOnly');
77 77
 			$ph['logout_reminder_msg'] = str_replace('[+date+]', $date, $_lang['logout_reminder_msg']);
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	}
80 80
 	$ph['show_logout_reminder'] = 'block';
81 81
 	unset($_SESSION['show_logout_reminder']);
82
-} else {
82
+} else {
83 83
 	$ph['show_logout_reminder'] = 'none';
84 84
 }
85 85
 
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
 $from[] = " us LEFT JOIN [+prefix+]active_users au ON au.sid=us.sid WHERE au.action <> '8'";
141 141
 $rs = $modx->db->select('*', $from, '', 'username ASC, au.sid ASC');
142 142
 
143
-if($modx->db->getRecordCount($rs) < 1) {
143
+if($modx->db->getRecordCount($rs) < 1) {
144 144
 	$html = '<p>[%no_active_users_found%]</p>';
145
-} else {
145
+} else {
146 146
 	include_once(MODX_MANAGER_PATH . 'includes/actionlist.inc.php');
147 147
 	$now = $_SERVER['REQUEST_TIME'] + $server_offset_time;
148 148
 	$ph['now'] = strftime('%H:%M:%S', $now);
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 	$userList = array();
169 169
 	$userCount = array();
170 170
 	// Create userlist with session-count first before output
171
-	while($activeusers = $modx->db->getRow($rs)) {
171
+	while($activeusers = $modx->db->getRow($rs)) {
172 172
 		$userCount[$activeusers['internalKey']] = isset($userCount[$activeusers['internalKey']]) ? $userCount[$activeusers['internalKey']] + 1 : 1;
173 173
 
174 174
 		$idle = $activeusers['lasthit'] < $timetocheck ? ' class="userIdle"' : '';
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 			$currentaction
187 187
 		);
188 188
 	}
189
-	foreach($userList as $params) {
189
+	foreach($userList as $params) {
190 190
 		$params[1] = $userCount[$params[4]] > 1 ? ' class="userMultipleSessions"' : '';
191 191
 		$html .= "\n\t\t" . vsprintf('<tr%s><td><strong%s>%s</strong></td><td>%s%s</td><td>%s</td><td>%s</td><td>%s</td></tr>', $params);
192 192
 	}
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
 // invoke event OnManagerWelcomePrerender
233 233
 $evtOut = $modx->invokeEvent('OnManagerWelcomePrerender');
234
-if(is_array($evtOut)) {
234
+if(is_array($evtOut)) {
235 235
 	$output = implode('', $evtOut);
236 236
 	$ph['OnManagerWelcomePrerender'] = $output;
237 237
 }
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 	'body' => '<div class="widget-stage">[+RecentInfo+]</div>',
341 341
 	'hide'=>'0'
342 342
 );
343
-if ($modx->config['rss_url_news']) {
343
+if ($modx->config['rss_url_news']) {
344 344
     $widgets['news'] = array(
345 345
         'menuindex' => '40',
346 346
         'id' => 'news',
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
         'hide'=>'0'
352 352
     );
353 353
 }
354
-if ($modx->config['rss_url_security']) {
354
+if ($modx->config['rss_url_security']) {
355 355
     $widgets['security'] = array(
356 356
         'menuindex' => '50',
357 357
         'id' => 'security',
@@ -365,29 +365,29 @@  discard block
 block discarded – undo
365 365
 
366 366
 // invoke OnManagerWelcomeHome event
367 367
 $sitewidgets = $modx->invokeEvent("OnManagerWelcomeHome", array('widgets' => $widgets));
368
-if(is_array($sitewidgets)) {
368
+if(is_array($sitewidgets)) {
369 369
 	$newwidgets = array();
370
-    foreach($sitewidgets as $widget){
370
+    foreach($sitewidgets as $widget) {
371 371
         $newwidgets = array_merge($newwidgets, unserialize($widget));
372 372
     }
373 373
     $widgets = (count($newwidgets) > 0) ? $newwidgets : $widgets;
374 374
 }
375 375
 
376
-usort($widgets, function ($a, $b) {
376
+usort($widgets, function ($a, $b){
377 377
 	return $a['menuindex'] - $b['menuindex'];
378 378
 });
379 379
 
380 380
 $tpl = getTplWidget();
381 381
 $output = '';
382
-foreach($widgets as $widget) {
383
-	if ($widget['hide'] != '1'){
382
+foreach($widgets as $widget) {
383
+	if ($widget['hide'] != '1') {
384 384
 		$output .= $modx->parseText($tpl, $widget);
385 385
 	}
386 386
 }
387 387
 $ph['widgets'] = $output;
388 388
 
389 389
 // load template
390
-if(!isset($modx->config['manager_welcome_tpl']) || empty($modx->config['manager_welcome_tpl'])) {
390
+if(!isset($modx->config['manager_welcome_tpl']) || empty($modx->config['manager_welcome_tpl'])) {
391 391
 	$modx->config['manager_welcome_tpl'] = MODX_MANAGER_PATH . 'media/style/common/welcome.tpl';
392 392
 }
393 393
 
@@ -395,26 +395,28 @@  discard block
 block discarded – undo
395 395
 $target = str_replace('[+base_path+]', MODX_BASE_PATH, $target);
396 396
 $target = $modx->mergeSettingsContent($target);
397 397
 
398
-if(substr($target, 0, 1) === '@') {
399
-	if(substr($target, 0, 6) === '@CHUNK') {
398
+if(substr($target, 0, 1) === '@') {
399
+	if(substr($target, 0, 6) === '@CHUNK') {
400 400
 		$content = $modx->getChunk(trim(substr($target, 7)));
401
-	} elseif(substr($target, 0, 5) === '@FILE') {
401
+	} elseif(substr($target, 0, 5) === '@FILE') {
402 402
 		$content = file_get_contents(trim(substr($target, 6)));
403
-	} else {
403
+	} else {
404 404
 		$content = '';
405 405
 	}
406
-} else {
406
+} else {
407 407
 	$chunk = $modx->getChunk($target);
408
-	if($chunk !== false && !empty($chunk)) {
408
+	if($chunk !== false && !empty($chunk)) {
409 409
 		$content = $chunk;
410
-	} elseif(is_file(MODX_BASE_PATH . $target)) {
410
+	} elseif(is_file(MODX_BASE_PATH . $target)) {
411 411
 		$content = file_get_contents(MODX_BASE_PATH . $target);
412
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl')) {
412
+	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl')) {
413 413
 		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/welcome.tpl');
414
-	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html')) // ClipperCMS compatible
414
+	} elseif(is_file(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html')) {
415
+	    // ClipperCMS compatible
415 416
 	{
416
-		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html');
417
-	} else {
417
+		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/' . $modx->config['manager_theme'] . '/html/welcome.html');
418
+	}
419
+	} else {
418 420
 		$content = file_get_contents(MODX_MANAGER_PATH . 'media/style/common/welcome.tpl');
419 421
 	}
420 422
 }
@@ -423,7 +425,7 @@  discard block
 block discarded – undo
423 425
 $content = $modx->mergeConditionalTagsContent($content);
424 426
 $content = $modx->mergeSettingsContent($content);
425 427
 $content = $modx->parseText($content, $ph);
426
-if(strpos($content, '[+') !== false) {
428
+if(strpos($content, '[+') !== false) {
427 429
 	$modx->toPlaceholders($ph);
428 430
 	$content = $modx->mergePlaceholderContent($content);
429 431
 }
@@ -432,7 +434,7 @@  discard block
 block discarded – undo
432 434
 $content = $modx->parseText($content, $_style, '[&', '&]');
433 435
 $content = $modx->cleanUpMODXTags($content); //cleanup
434 436
 
435
-if($js = $modx->getRegisteredClientScripts()) {
437
+if($js = $modx->getRegisteredClientScripts()) {
436 438
 	$content .= $js;
437 439
 }
438 440
 
@@ -442,7 +444,9 @@  discard block
 block discarded – undo
442 444
 //	<a href="javascript:;" class="setting"><i class="fa fa-cog"></i></a>
443 445
 //  <a href="javascript:;" class="closed"><i class="fa fa-close"></i></a>
444 446
 //</span>
445
-function getTplWidget() { // recent document info
447
+function getTplWidget()
448
+{
449
+// recent document info
446 450
 	return '
447 451
 		<div class="[+cols+]" id="[+id+]">
448 452
 			<div class="card"[+cardAttr+]>
@@ -453,7 +457,9 @@  discard block
 block discarded – undo
453 457
 ';
454 458
 }
455 459
 
456
-function getRecentInfo() { // recent document info
460
+function getRecentInfo()
461
+{
462
+// recent document info
457 463
 	global $modx;
458 464
 
459 465
 	$modx->addSnippet('recentInfoList', 'getRecentInfoList');
@@ -479,12 +485,13 @@  discard block
 block discarded – undo
479 485
 	return $html;
480 486
 }
481 487
 
482
-function getRecentInfoList() {
488
+function getRecentInfoList()
489
+{
483 490
 	global $modx;
484 491
 
485 492
 	$rs = $modx->db->select('*', '[+prefix+]site_content', '', 'editedon DESC', 10);
486 493
 
487
-	if($modx->db->getRecordCount($rs) < 1) {
494
+	if($modx->db->getRecordCount($rs) < 1) {
488 495
 		return '<tr><td>[%no_activity_message%]</td></tr>';
489 496
 	}
490 497
 
@@ -494,22 +501,22 @@  discard block
 block discarded – undo
494 501
 	$btntpl['preview_btn'] = '<a [+preview_disabled+]" title="[%preview_resource%]" target="_blank" href="../index.php?&amp;id=[+id+]"><i class="fa fa-eye fa-fw"></i></a> ';
495 502
 
496 503
 	$output = array();
497
-	while($ph = $modx->db->getRow($rs)) {
504
+	while($ph = $modx->db->getRow($rs)) {
498 505
 		$docid = $ph['id'];
499 506
 		$_ = $modx->getUserInfo($ph['editedby']);
500 507
 		$ph['username'] = $_['username'];
501 508
 
502
-		if($ph['deleted'] == 1) {
509
+		if($ph['deleted'] == 1) {
503 510
 			$ph['status'] = 'deleted text-danger';
504
-		} elseif($ph['published'] == 0) {
511
+		} elseif($ph['published'] == 0) {
505 512
 			$ph['status'] = 'unpublished font-italic text-muted';
506
-		} else {
513
+		} else {
507 514
 			$ph['status'] = 'published';
508 515
 		}
509 516
 
510
-		if($modx->hasPermission('edit_document')) {
517
+		if($modx->hasPermission('edit_document')) {
511 518
 			$ph['edit_btn'] = str_replace('[+id+]', $docid, $btntpl['edit']);
512
-		} else {
519
+		} else {
513 520
 			$ph['edit_btn'] = '';
514 521
 		}
515 522
 
@@ -522,40 +529,40 @@  discard block
 block discarded – undo
522 529
 			$preview_disabled
523 530
 		), $btntpl['preview_btn']);
524 531
 
525
-		if($modx->hasPermission('delete_document')) {
526
-			if($ph['deleted'] == 0) {
532
+		if($modx->hasPermission('delete_document')) {
533
+			if($ph['deleted'] == 0) {
527 534
 				$delete_btn = '<a onclick="return confirm(\'[%confirm_delete_record%]\')" title="[%delete_resource%]" href="index.php?a=6&amp;id=[+id+]" target="main"><i class="fa fa-trash fa-fw"></i></a> ';
528
-			} else {
535
+			} else {
529 536
 				$delete_btn = '<a onclick="return confirm(\'[%confirm_undelete%]\')" title="[%undelete_resource%]" href="index.php?a=63&amp;id=[+id+]" target="main"><i class="fa fa-arrow-circle-o-up fa-fw"></i></a> ';
530 537
 			}
531 538
 			$ph['delete_btn'] = str_replace('[+id+]', $docid, $delete_btn);
532
-		} else {
539
+		} else {
533 540
 			$ph['delete_btn'] = '';
534 541
 		}
535 542
 
536
-		if($ph['deleted'] == 1 && $ph['published'] == 0) {
543
+		if($ph['deleted'] == 1 && $ph['published'] == 0) {
537 544
 			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
538
-		} elseif($ph['deleted'] == 1 && $ph['published'] == 1) {
545
+		} elseif($ph['deleted'] == 1 && $ph['published'] == 1) {
539 546
 			$publish_btn = '<a class="disabled" title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
540
-		} elseif($ph['deleted'] == 0 && $ph['published'] == 0) {
547
+		} elseif($ph['deleted'] == 0 && $ph['published'] == 0) {
541 548
 			$publish_btn = '<a title="[%publish_resource%]" href="index.php?a=61&amp;id=[+id+]" target="main"><i class="fa fa-arrow-up fa-fw"></i></a> ';
542
-		} else {
549
+		} else {
543 550
 			$publish_btn = '<a title="[%unpublish_resource%]" href="index.php?a=62&amp;id=[+id+]" target="main"><i class="fa fa-arrow-down fa-fw"></i></a> ';
544 551
 		}
545 552
 		$ph['publish_btn'] = str_replace('[+id+]', $docid, $publish_btn);
546 553
 
547 554
 		$ph['info_btn'] = str_replace('[+id+]', $docid, '<a title="[%resource_overview%]" data-toggle="collapse" data-target=".collapse[+id+]"><i class="fa fa-info fa-fw"></i></a>');
548 555
 
549
-		if($ph['longtitle'] == '') {
556
+		if($ph['longtitle'] == '') {
550 557
 			$ph['longtitle'] = '(<i>[%not_set%]</i>)';
551 558
 		}
552
-		if($ph['description'] == '') {
559
+		if($ph['description'] == '') {
553 560
 			$ph['description'] = '(<i>[%not_set%]</i>)';
554 561
 		}
555
-		if($ph['introtext'] == '') {
562
+		if($ph['introtext'] == '') {
556 563
 			$ph['introtext'] = '(<i>[%not_set%]</i>)';
557 564
 		}
558
-		if($ph['alias'] == '') {
565
+		if($ph['alias'] == '') {
559 566
 			$ph['alias'] = '(<i>[%not_set%]</i>)';
560 567
 		}
561 568
 
@@ -564,7 +571,8 @@  discard block
 block discarded – undo
564 571
 	return implode("\n", $output);
565 572
 }
566 573
 
567
-function getRecentInfoRowTpl() {
574
+function getRecentInfoRowTpl()
575
+{
568 576
 	$tpl = '
569 577
 						<tr>
570 578
 							<td data-toggle="collapse" data-target=".collapse[+id+]" class="text-right"><span class="label label-info">[+id+]</span></td>
@@ -593,11 +601,13 @@  discard block
 block discarded – undo
593 601
 }
594 602
 
595 603
 // setup icons
596
-function wrapIcon($i, $action) {
604
+function wrapIcon($i, $action)
605
+{
597 606
 	return sprintf('<a href="index.php?a=%s" target="main"><span class="wm_button" style="border:0">%s</span></a>', $action, $i);
598 607
 }
599 608
 
600
-function getStartUpScript() {
609
+function getStartUpScript()
610
+{
601 611
 	$script = '
602 612
         <script type="text/javascript">
603 613
         function hideConfigCheckWarning(key) {
Please login to merge, or discard this patch.
manager/includes/veriword.php 2 patches
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 $modx->getSettings();
6 6
 $modx->invokeEvent('OnWebPageInit');
7 7
 
8
-$vword = new VeriWord(148,60);
8
+$vword = new VeriWord(148, 60);
9 9
 $vword->output_image();
10 10
 $vword->destroy_image();
11 11
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 ## see sample.php for test and usage
42 42
 ## sample URL: http://www.program-ruti.org/veriword/
43 43
 ####
44
-class VeriWord {
44
+class VeriWord{
45 45
 
46 46
     /* path to font directory*/
47 47
     public $dir_font   = "ttf/";
@@ -52,44 +52,44 @@  discard block
 block discarded – undo
52 52
     public $im_height  = 0;
53 53
     public $im;
54 54
 
55
-    public function __construct($w=200, $h=80) {
55
+    public function __construct($w = 200, $h = 80){
56 56
         /* create session to set word for verification */
57 57
         $this->set_veriword();
58
-        $this->dir_font = dirname(__FILE__) . '/' . $this->dir_font;
58
+        $this->dir_font = dirname(__FILE__).'/'.$this->dir_font;
59 59
         $this->im_width         = $w;
60 60
         $this->im_height        = $h;
61 61
     }
62 62
 
63
-    public function set_veriword() {
63
+    public function set_veriword(){
64 64
         /* create session variable for verification,
65 65
            you may change the session variable name */
66 66
         $this->word             = $this->pick_word();
67 67
         $_SESSION['veriword']   = $this->word;
68 68
     }
69 69
 
70
-    public function output_image() {
70
+    public function output_image(){
71 71
         /* output the image as jpeg */
72 72
         $this->draw_image();
73 73
         header("Content-type: image/jpeg");
74 74
         imagejpeg($this->im);
75 75
     }
76 76
 
77
-    public function pick_word() {
77
+    public function pick_word(){
78 78
         global $modx;
79 79
         // set default words
80
-        $words="MODX,Access,Better,BitCode,Chunk,Cache,Desc,Design,Excell,Enjoy,URLs,TechView,Gerald,Griff,Humphrey,Holiday,Intel,Integration,Joystick,Join(),Oscope,Genetic,Light,Likeness,Marit,Maaike,Niche,Netherlands,Ordinance,Oscillo,Parser,Phusion,Query,Question,Regalia,Righteous,Snippet,Sentinel,Template,Thespian,Unity,Enterprise,Verily,Veri,Website,WideWeb,Yap,Yellow,Zebra,Zygote";
80
+        $words = "MODX,Access,Better,BitCode,Chunk,Cache,Desc,Design,Excell,Enjoy,URLs,TechView,Gerald,Griff,Humphrey,Holiday,Intel,Integration,Joystick,Join(),Oscope,Genetic,Light,Likeness,Marit,Maaike,Niche,Netherlands,Ordinance,Oscillo,Parser,Phusion,Query,Question,Regalia,Righteous,Snippet,Sentinel,Template,Thespian,Unity,Enterprise,Verily,Veri,Website,WideWeb,Yap,Yellow,Zebra,Zygote";
81 81
         $words = $modx->config['captcha_words'] ? $modx->config['captcha_words'] : $words;
82 82
         $arr_words = array_filter(array_map('trim', explode(',', $words)));
83 83
 
84 84
         /* pick one randomly for text verification */
85
-        return (string) $arr_words[array_rand($arr_words)].rand(10,999);
85
+        return (string) $arr_words[array_rand($arr_words)].rand(10, 999);
86 86
     }
87 87
 
88
-    public function draw_text() {
88
+    public function draw_text(){
89 89
         $dir = dir($this->dir_font);
90 90
         $fontstmp = array();
91 91
         while (false !== ($file = $dir->read())) {
92
-            if(substr($file, -4) == '.ttf') {
92
+            if (substr($file, -4) == '.ttf') {
93 93
                 $fontstmp[] = $this->dir_font.$file;
94 94
             }
95 95
         }
@@ -97,35 +97,35 @@  discard block
 block discarded – undo
97 97
         $text_font = (string) $fontstmp[array_rand($fontstmp)];
98 98
 
99 99
         /* angle for text inclination */
100
-        $text_angle = rand(-9,9);
100
+        $text_angle = rand(-9, 9);
101 101
         /* initial text size */
102 102
         $text_size  = 30;
103 103
         /* calculate text width and height */
104
-        $box        = imagettfbbox ( $text_size, $text_angle, $text_font, $this->word);
105
-        $text_width = $box[2]-$box[0]; //text width
106
-        $text_height= $box[5]-$box[3]; //text height
104
+        $box        = imagettfbbox($text_size, $text_angle, $text_font, $this->word);
105
+        $text_width = $box[2] - $box[0]; //text width
106
+        $text_height = $box[5] - $box[3]; //text height
107 107
 
108 108
         /* adjust text size */
109
-        $text_size  = round((20 * $this->im_width)/$text_width);
109
+        $text_size  = round((20 * $this->im_width) / $text_width);
110 110
 
111 111
         /* recalculate text width and height */
112
-        $box        = imagettfbbox ( $text_size, $text_angle, $text_font, $this->word);
113
-        $text_width = $box[2]-$box[0]; //text width
114
-        $text_height= $box[5]-$box[3]; //text height
112
+        $box        = imagettfbbox($text_size, $text_angle, $text_font, $this->word);
113
+        $text_width = $box[2] - $box[0]; //text width
114
+        $text_height = $box[5] - $box[3]; //text height
115 115
 
116 116
         /* calculate center position of text */
117
-        $text_x         = ($this->im_width - $text_width)/2;
118
-        $text_y         = ($this->im_height - $text_height)/2;
117
+        $text_x         = ($this->im_width - $text_width) / 2;
118
+        $text_y         = ($this->im_height - $text_height) / 2;
119 119
 
120 120
         /* create canvas for text drawing */
121
-        $im_text        = imagecreate ($this->im_width, $this->im_height);
122
-        $bg_color       = imagecolorallocate ($im_text, 255, 255, 255);
121
+        $im_text        = imagecreate($this->im_width, $this->im_height);
122
+        $bg_color       = imagecolorallocate($im_text, 255, 255, 255);
123 123
 
124 124
         /* pick color for text */
125
-        $text_color     = imagecolorallocate ($im_text, 0, 51, 153);
125
+        $text_color     = imagecolorallocate($im_text, 0, 51, 153);
126 126
 
127 127
         /* draw text into canvas */
128
-        imagettftext    (   $im_text,
128
+        imagettftext($im_text,
129 129
             $text_size,
130 130
             $text_angle,
131 131
             $text_x,
@@ -140,19 +140,19 @@  discard block
 block discarded – undo
140 140
     }
141 141
 
142 142
 
143
-    public function draw_image() {
143
+    public function draw_image(){
144 144
 
145 145
         /* pick one background image randomly from image directory */
146
-        $img_file       = $this->dir_noise."noise".rand(1,4).".jpg";
146
+        $img_file       = $this->dir_noise."noise".rand(1, 4).".jpg";
147 147
 
148 148
         /* create "noise" background image from your image stock*/
149
-        $noise_img      = @imagecreatefromjpeg ($img_file);
149
+        $noise_img      = @imagecreatefromjpeg($img_file);
150 150
         $noise_width    = imagesx($noise_img);
151 151
         $noise_height   = imagesy($noise_img);
152 152
 
153 153
         /* resize the background image to fit the size of image output */
154
-        $this->im       = imagecreatetruecolor($this->im_width,$this->im_height);
155
-        imagecopyresampled ($this->im,
154
+        $this->im       = imagecreatetruecolor($this->im_width, $this->im_height);
155
+        imagecopyresampled($this->im,
156 156
             $noise_img,
157 157
             0, 0, 0, 0,
158 158
             $this->im_width,
@@ -161,17 +161,17 @@  discard block
 block discarded – undo
161 161
             $noise_height);
162 162
 
163 163
         /* put text image into background image */
164
-        imagecopymerge (    $this->im,
164
+        imagecopymerge($this->im,
165 165
             $this->draw_text(),
166 166
             0, 0, 0, 0,
167 167
             $this->im_width,
168 168
             $this->im_height,
169
-            70 );
169
+            70);
170 170
 
171 171
         return $this->im;
172 172
     }
173 173
 
174
-    public function destroy_image() {
174
+    public function destroy_image(){
175 175
 
176 176
         imagedestroy($this->im);
177 177
 
Please login to merge, or discard this patch.
Braces   +16 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,7 +41,8 @@  discard block
 block discarded – undo
41 41
 ## see sample.php for test and usage
42 42
 ## sample URL: http://www.program-ruti.org/veriword/
43 43
 ####
44
-class VeriWord {
44
+class VeriWord
45
+{
45 46
 
46 47
     /* path to font directory*/
47 48
     public $dir_font   = "ttf/";
@@ -52,7 +53,8 @@  discard block
 block discarded – undo
52 53
     public $im_height  = 0;
53 54
     public $im;
54 55
 
55
-    public function __construct($w=200, $h=80) {
56
+    public function __construct($w=200, $h=80)
57
+    {
56 58
         /* create session to set word for verification */
57 59
         $this->set_veriword();
58 60
         $this->dir_font = dirname(__FILE__) . '/' . $this->dir_font;
@@ -60,21 +62,24 @@  discard block
 block discarded – undo
60 62
         $this->im_height        = $h;
61 63
     }
62 64
 
63
-    public function set_veriword() {
65
+    public function set_veriword()
66
+    {
64 67
         /* create session variable for verification,
65 68
            you may change the session variable name */
66 69
         $this->word             = $this->pick_word();
67 70
         $_SESSION['veriword']   = $this->word;
68 71
     }
69 72
 
70
-    public function output_image() {
73
+    public function output_image()
74
+    {
71 75
         /* output the image as jpeg */
72 76
         $this->draw_image();
73 77
         header("Content-type: image/jpeg");
74 78
         imagejpeg($this->im);
75 79
     }
76 80
 
77
-    public function pick_word() {
81
+    public function pick_word()
82
+    {
78 83
         global $modx;
79 84
         // set default words
80 85
         $words="MODX,Access,Better,BitCode,Chunk,Cache,Desc,Design,Excell,Enjoy,URLs,TechView,Gerald,Griff,Humphrey,Holiday,Intel,Integration,Joystick,Join(),Oscope,Genetic,Light,Likeness,Marit,Maaike,Niche,Netherlands,Ordinance,Oscillo,Parser,Phusion,Query,Question,Regalia,Righteous,Snippet,Sentinel,Template,Thespian,Unity,Enterprise,Verily,Veri,Website,WideWeb,Yap,Yellow,Zebra,Zygote";
@@ -85,7 +90,8 @@  discard block
 block discarded – undo
85 90
         return (string) $arr_words[array_rand($arr_words)].rand(10,999);
86 91
     }
87 92
 
88
-    public function draw_text() {
93
+    public function draw_text()
94
+    {
89 95
         $dir = dir($this->dir_font);
90 96
         $fontstmp = array();
91 97
         while (false !== ($file = $dir->read())) {
@@ -140,7 +146,8 @@  discard block
 block discarded – undo
140 146
     }
141 147
 
142 148
 
143
-    public function draw_image() {
149
+    public function draw_image()
150
+    {
144 151
 
145 152
         /* pick one background image randomly from image directory */
146 153
         $img_file       = $this->dir_noise."noise".rand(1,4).".jpg";
@@ -171,7 +178,8 @@  discard block
 block discarded – undo
171 178
         return $this->im;
172 179
     }
173 180
 
174
-    public function destroy_image() {
181
+    public function destroy_image()
182
+    {
175 183
 
176 184
         imagedestroy($this->im);
177 185
 
Please login to merge, or discard this patch.
manager/includes/extenders/dbapi.mysqli.class.inc.php 2 patches
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -240,9 +240,9 @@  discard block
 block discarded – undo
240 240
     }
241 241
 
242 242
     /**
243
-     * @param string|array $fields
244
-     * @param string|array $from
245
-     * @param string|array $where
243
+     * @param string $fields
244
+     * @param string $from
245
+     * @param string $where
246 246
      * @param string $orderBy
247 247
      * @param string $limit
248 248
      * @return bool|mysqli_result
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
      * @param string $fromtable
327 327
      * @param string $where
328 328
      * @param string $limit
329
-     * @return mixed
329
+     * @return null|integer
330 330
      */
331 331
     public function insert($fields, $intotable, $fromfields = "*", $fromtable = "", $where = "", $limit = "")
332 332
     {
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
 
436 436
     /**
437 437
      * @param null|mysqli $conn
438
-     * @return mixed
438
+     * @return integer
439 439
      */
440 440
     public function getInsertId($conn = null)
441 441
     {
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
     }
514 514
 
515 515
     /**
516
-     * @param $name
516
+     * @param string $name
517 517
      * @param mysqli_result|string $dsq
518 518
      * @return array
519 519
      */
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 
573 573
     /**
574 574
      * @param string $table
575
-     * @return array
575
+     * @return boolean
576 576
      */
577 577
     public function getTableMetaData($table)
578 578
     {
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
     }
620 620
 
621 621
     /**
622
-     * @param string|mysqli_result $rs
622
+     * @param string $rs
623 623
      * @param bool $index
624 624
      * @return array
625 625
      */
Please login to merge, or discard this patch.
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         $pre = null,
31 31
         $charset = '',
32 32
         $connection_method = 'SET CHARACTER SET'
33
-    ) {
33
+    ){
34 34
         $this->config['host'] = $host ? $host : $GLOBALS['database_server'];
35 35
         $this->config['dbase'] = $dbase ? $dbase : $GLOBALS['dbase'];
36 36
         $this->config['user'] = $uid ? $uid : $GLOBALS['database_user'];
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
                         $ua = $modx->htmlspecialchars($_SERVER['HTTP_USER_AGENT']);
71 71
                         $referer = $modx->htmlspecialchars($_SERVER['HTTP_REFERER']);
72 72
                         $modx->sendmail(array(
73
-                            'subject' => 'Missing to create the database connection! from ' . $modx->config['site_name'],
73
+                            'subject' => 'Missing to create the database connection! from '.$modx->config['site_name'],
74 74
                             'body'    => "{$logtitle}\n{$request_uri}\n{$ua}\n{$referer}",
75 75
                             'type'    => 'text'
76 76
                         ));
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
85 85
             $tend = $modx->getMicroTime();
86 86
             $totaltime = $tend - $tstart;
87 87
             if ($modx->dumpSQL) {
88
-                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Database connection</legend>" . sprintf("Database connection was created in %2.4f s",
89
-                        $totaltime) . "</fieldset><br />";
88
+                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Database connection</legend>".sprintf("Database connection was created in %2.4f s",
89
+                        $totaltime)."</fieldset><br />";
90 90
             }
91 91
             $this->conn->set_charset($this->config['charset']);
92 92
             $this->isConnected = true;
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         if (1000 < $safeCount) {
120 120
             exit("Too many loops '{$safeCount}'");
121 121
         }
122
-        if ( ! ($this->conn instanceof mysqli)) {
122
+        if (!($this->conn instanceof mysqli)) {
123 123
             $this->connect();
124 124
         }
125 125
         if (is_array($s)) {
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     public function query($sql, $watchError = true)
146 146
     {
147 147
         global $modx;
148
-        if ( ! ($this->conn instanceof mysqli)) {
148
+        if (!($this->conn instanceof mysqli)) {
149 149
             $this->connect();
150 150
         }
151 151
         $tStart = $modx->getMicroTime();
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
                 case 1091:
166 166
                     break;
167 167
                 default:
168
-                    $modx->messageQuit('Execution of a query to the database failed - ' . $this->getLastError(), $sql);
168
+                    $modx->messageQuit('Execution of a query to the database failed - '.$this->getLastError(), $sql);
169 169
             }
170 170
         } else {
171 171
             $tend = $modx->getMicroTime();
@@ -179,24 +179,24 @@  discard block
 block discarded – undo
179 179
                     $debug_path[] = $line['function'];
180 180
                 }
181 181
                 $debug_path = implode(' > ', array_reverse($debug_path));
182
-                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Query " . ($modx->executedQueries + 1) . " - " . sprintf("%2.2f ms",
183
-                        $totalTime * 1000) . "</legend>";
184
-                $modx->queryCode .= $sql . '<br><br>';
182
+                $modx->queryCode .= "<fieldset style='text-align:left'><legend>Query ".($modx->executedQueries + 1)." - ".sprintf("%2.2f ms",
183
+                        $totalTime * 1000)."</legend>";
184
+                $modx->queryCode .= $sql.'<br><br>';
185 185
                 if ($modx->event->name) {
186
-                    $modx->queryCode .= 'Current Event  => ' . $modx->event->name . '<br>';
186
+                    $modx->queryCode .= 'Current Event  => '.$modx->event->name.'<br>';
187 187
                 }
188 188
                 if ($modx->event->activePlugin) {
189
-                    $modx->queryCode .= 'Current Plugin => ' . $modx->event->activePlugin . '<br>';
189
+                    $modx->queryCode .= 'Current Plugin => '.$modx->event->activePlugin.'<br>';
190 190
                 }
191 191
                 if ($modx->currentSnippet) {
192
-                    $modx->queryCode .= 'Current Snippet => ' . $modx->currentSnippet . '<br>';
192
+                    $modx->queryCode .= 'Current Snippet => '.$modx->currentSnippet.'<br>';
193 193
                 }
194 194
                 if (stripos($sql, 'select') === 0) {
195
-                    $modx->queryCode .= 'Record Count => ' . $this->getRecordCount($result) . '<br>';
195
+                    $modx->queryCode .= 'Record Count => '.$this->getRecordCount($result).'<br>';
196 196
                 } else {
197
-                    $modx->queryCode .= 'Affected Rows => ' . $this->getAffectedRows() . '<br>';
197
+                    $modx->queryCode .= 'Affected Rows => '.$this->getAffectedRows().'<br>';
198 198
                 }
199
-                $modx->queryCode .= 'Functions Path => ' . $debug_path . '<br>';
199
+                $modx->queryCode .= 'Functions Path => '.$debug_path.'<br>';
200 200
                 $modx->queryCode .= "</fieldset><br />";
201 201
             }
202 202
             $modx->executedQueries++;
@@ -303,9 +303,9 @@  discard block
 block discarded – undo
303 303
                     if ($value === null || strtolower($value) === 'null') {
304 304
                         $f = 'NULL';
305 305
                     } else {
306
-                        $f = "'" . $value . "'";
306
+                        $f = "'".$value."'";
307 307
                     }
308
-                    $fields[$key] = "`{$key}` = " . $f;
308
+                    $fields[$key] = "`{$key}` = ".$f;
309 309
                 }
310 310
                 $fields = implode(',', $fields);
311 311
             }
@@ -340,12 +340,12 @@  discard block
 block discarded – undo
340 340
                 $this->query("INSERT INTO {$intotable} {$fields}");
341 341
             } else {
342 342
                 if (empty($fromtable)) {
343
-                    $fields = "(`" . implode("`, `", array_keys($fields)) . "`) VALUES('" . implode("', '",
344
-                            array_values($fields)) . "')";
343
+                    $fields = "(`".implode("`, `", array_keys($fields))."`) VALUES('".implode("', '",
344
+                            array_values($fields))."')";
345 345
                     $this->query("INSERT INTO {$intotable} {$fields}");
346 346
                 } else {
347 347
                     $fromtable = $this->replaceFullTableName($fromtable);
348
-                    $fields = "(" . implode(",", array_keys($fields)) . ")";
348
+                    $fields = "(".implode(",", array_keys($fields)).")";
349 349
                     $where = trim($where);
350 350
                     $limit = trim($limit);
351 351
                     if ($where !== '' && stripos($where, 'WHERE') !== 0) {
@@ -439,8 +439,8 @@  discard block
 block discarded – undo
439 439
      */
440 440
     public function getInsertId($conn = null)
441 441
     {
442
-        if (! ($conn instanceof mysqli)) {
443
-            $conn =& $this->conn;
442
+        if (!($conn instanceof mysqli)) {
443
+            $conn = & $this->conn;
444 444
         }
445 445
 
446 446
         return $conn->insert_id;
@@ -452,8 +452,8 @@  discard block
 block discarded – undo
452 452
      */
453 453
     public function getAffectedRows($conn = null)
454 454
     {
455
-        if (! ($conn instanceof mysqli)) {
456
-            $conn =& $this->conn;
455
+        if (!($conn instanceof mysqli)) {
456
+            $conn = & $this->conn;
457 457
         }
458 458
 
459 459
         return $conn->affected_rows;
@@ -465,8 +465,8 @@  discard block
 block discarded – undo
465 465
      */
466 466
     public function getLastError($conn = null)
467 467
     {
468
-        if (! ($conn instanceof mysqli)) {
469
-            $conn =& $this->conn;
468
+        if (!($conn instanceof mysqli)) {
469
+            $conn = & $this->conn;
470 470
         }
471 471
 
472 472
         return $conn->error;
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
     {
491 491
         $out = false;
492 492
         if ($ds instanceof mysqli_result) {
493
-            switch($mode){
493
+            switch ($mode) {
494 494
                 case 'assoc':
495 495
                     $out = $ds->fetch_assoc();
496 496
                     break;
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
     public function getColumn($name, $dsq)
521 521
     {
522 522
         $col = array();
523
-        if ( ! ($dsq instanceof mysqli_result)) {
523
+        if (!($dsq instanceof mysqli_result)) {
524 524
             $dsq = $this->query($dsq);
525 525
         }
526 526
         if ($dsq) {
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
     public function getColumnNames($dsq)
540 540
     {
541 541
         $names = array();
542
-        if ( ! ($dsq instanceof mysqli_result)) {
542
+        if (!($dsq instanceof mysqli_result)) {
543 543
             $dsq = $this->query($dsq);
544 544
         }
545 545
         if ($dsq) {
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
     public function getValue($dsq)
560 560
     {
561 561
         $out = false;
562
-        if ( ! ($dsq instanceof mysqli_result)) {
562
+        if (!($dsq instanceof mysqli_result)) {
563 563
             $dsq = $this->query($dsq);
564 564
         }
565 565
         if ($dsq) {
@@ -657,7 +657,7 @@  discard block
 block discarded – undo
657 657
         $tableName = trim($tableName);
658 658
         $dbase = trim($this->config['dbase'], '`');
659 659
         $prefix = $this->config['table_prefix'];
660
-        if ((bool)$force === true) {
660
+        if ((bool) $force === true) {
661 661
             $result = "`{$dbase}`.`{$prefix}{$tableName}`";
662 662
         } elseif (strpos($tableName, '[+prefix+]') !== false) {
663 663
             $result = preg_replace('@\[\+prefix\+\]([0-9a-zA-Z_]+)@', "`{$dbase}`.`{$prefix}$1`", $tableName);
Please login to merge, or discard this patch.
manager/includes/extenders/modifiers.class.inc.php 3 patches
Doc Comments   +25 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     /**
96 96
      * @param string $mode
97 97
      * @param string $modifiers
98
-     * @return bool|string
98
+     * @return false|string
99 99
      */
100 100
     public function _getDelim($mode,$modifiers) {
101 101
         $c = substr($modifiers,0,1);
@@ -132,6 +132,14 @@  discard block
 block discarded – undo
132 132
             return $opt;
133 133
         }
134 134
     }
135
+
136
+    /**
137
+     * @param string $mode
138
+     * @param false|string $delim
139
+     * @param string $modifiers
140
+     *
141
+     * @return string
142
+     */
135 143
     public function _getRemainModifiers($mode,$delim,$modifiers) {
136 144
         if($delim) {
137 145
             if($mode=='(')
@@ -159,6 +167,9 @@  discard block
 block discarded – undo
159 167
         return substr($string,strpos($string, $delim)+$len);
160 168
     }
161 169
 
170
+    /**
171
+     * @param string $modifiers
172
+     */
162 173
     public function splitEachModifiers($modifiers) {
163 174
         global $modx;
164 175
 
@@ -228,6 +239,9 @@  discard block
 block discarded – undo
228 239
         return $result;
229 240
     }
230 241
 
242
+    /**
243
+     * @param string $key
244
+     */
231 245
     public function parsePhx($key,$value,$modifiers)
232 246
     {
233 247
         global $modx;
@@ -294,6 +308,9 @@  discard block
 block discarded – undo
294 308
         else                  return true;
295 309
     }
296 310
 
311
+    /**
312
+     * @param string $cmd
313
+     */
297 314
     public function getValueFromPreset($key, $value, $cmd, $opt)
298 315
     {
299 316
         global $modx;
@@ -979,6 +996,9 @@  discard block
 block discarded – undo
979 996
         return $value;
980 997
     }
981 998
 
999
+    /**
1000
+     * @param string $cmd
1001
+     */
982 1002
     public function includeMdfFile($cmd) {
983 1003
         global $modx;
984 1004
         $key = $this->key;
@@ -1134,6 +1154,10 @@  discard block
 block discarded – undo
1134 1154
     }
1135 1155
 
1136 1156
     // Sets a placeholder variable which can only be access by Modifiers
1157
+
1158
+    /**
1159
+     * @param string $value
1160
+     */
1137 1161
     public function setModifiersVariable($key, $value) {
1138 1162
         if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1139 1163
     }
Please login to merge, or discard this patch.
Spacing   +350 added lines, -350 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('MODX_CORE_PATH')) define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
3
+if (!defined('MODX_CORE_PATH')) define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
4 4
 
5
-class MODIFIERS {
5
+class MODIFIERS{
6 6
     /**
7 7
      * @var array
8 8
      */
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
      * @param string $modifiers
72 72
      * @return bool|mixed|string
73 73
      */
74
-    public function phxFilter($key,$value,$modifiers)
74
+    public function phxFilter($key, $value, $modifiers)
75 75
     {
76 76
         global $modx;
77
-        if(substr($modifiers,0,3)!=='id(') $value = $this->parseDocumentSource($value);
77
+        if (substr($modifiers, 0, 3) !== 'id(') $value = $this->parseDocumentSource($value);
78 78
         $this->srcValue = $value;
79 79
         $modifiers = trim($modifiers);
80
-        $modifiers = ':'.trim($modifiers,':');
81
-        $modifiers = str_replace(array("\r\n","\r"), "\n", $modifiers);
80
+        $modifiers = ':'.trim($modifiers, ':');
81
+        $modifiers = str_replace(array("\r\n", "\r"), "\n", $modifiers);
82 82
         $modifiers = $this->splitEachModifiers($modifiers);
83 83
 
84 84
         $this->placeholders = array();
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
         $this->placeholders['dummy'] = '';
87 87
         $this->condition = array();
88 88
         $this->vars = array();
89
-        $this->vars['name']    = & $key;
90
-        $value = $this->parsePhx($key,$value,$modifiers);
89
+        $this->vars['name'] = & $key;
90
+        $value = $this->parsePhx($key, $value, $modifiers);
91 91
         $this->vars = array();
92 92
         return $value;
93 93
     }
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
      * @param string $modifiers
98 98
      * @return bool|string
99 99
      */
100
-    public function _getDelim($mode,$modifiers) {
101
-        $c = substr($modifiers,0,1);
102
-        if(!in_array($c, array('"', "'", '`')) ) return false;
100
+    public function _getDelim($mode, $modifiers){
101
+        $c = substr($modifiers, 0, 1);
102
+        if (!in_array($c, array('"', "'", '`'))) return false;
103 103
 
104
-        $modifiers = substr($modifiers,1);
105
-        $closure = $mode=='(' ? "{$c})" : $c;
106
-        if(strpos($modifiers, $closure)===false) return false;
104
+        $modifiers = substr($modifiers, 1);
105
+        $closure = $mode == '(' ? "{$c})" : $c;
106
+        if (strpos($modifiers, $closure) === false) return false;
107 107
 
108 108
         return  $c;
109 109
     }
@@ -114,101 +114,101 @@  discard block
 block discarded – undo
114 114
      * @param string $modifiers
115 115
      * @return bool|string
116 116
      */
117
-    public function _getOpt($mode,$delim,$modifiers) {
118
-        if($delim) {
119
-            if($mode=='(') return substr($modifiers,1,strpos($modifiers, $delim . ')' )-1);
117
+    public function _getOpt($mode, $delim, $modifiers){
118
+        if ($delim) {
119
+            if ($mode == '(') return substr($modifiers, 1, strpos($modifiers, $delim.')') - 1);
120 120
 
121
-            return substr($modifiers,1,strpos($modifiers,$delim,1)-1);
121
+            return substr($modifiers, 1, strpos($modifiers, $delim, 1) - 1);
122 122
         }
123 123
         else {
124
-            if($mode=='(') return substr($modifiers,0,strpos($modifiers, ')') );
124
+            if ($mode == '(') return substr($modifiers, 0, strpos($modifiers, ')'));
125 125
 
126 126
             $chars = str_split($modifiers);
127
-            $opt='';
128
-            foreach($chars as $c) {
129
-                if($c==':' || $c==')') break;
130
-                $opt .=$c;
127
+            $opt = '';
128
+            foreach ($chars as $c) {
129
+                if ($c == ':' || $c == ')') break;
130
+                $opt .= $c;
131 131
             }
132 132
             return $opt;
133 133
         }
134 134
     }
135
-    public function _getRemainModifiers($mode,$delim,$modifiers) {
136
-        if($delim) {
137
-            if($mode=='(')
138
-                return $this->_fetchContent($modifiers, $delim . ')');
135
+    public function _getRemainModifiers($mode, $delim, $modifiers){
136
+        if ($delim) {
137
+            if ($mode == '(')
138
+                return $this->_fetchContent($modifiers, $delim.')');
139 139
             else {
140 140
                 $modifiers = trim($modifiers);
141
-                $modifiers = substr($modifiers,1);
141
+                $modifiers = substr($modifiers, 1);
142 142
                 return $this->_fetchContent($modifiers, $delim);
143 143
             }
144 144
         }
145 145
         else {
146
-            if($mode=='(') return $this->_fetchContent($modifiers, ')');
146
+            if ($mode == '(') return $this->_fetchContent($modifiers, ')');
147 147
             $chars = str_split($modifiers);
148
-            foreach($chars as $c) {
149
-                if($c==':') return $modifiers;
150
-                else $modifiers = substr($modifiers,1);
148
+            foreach ($chars as $c) {
149
+                if ($c == ':') return $modifiers;
150
+                else $modifiers = substr($modifiers, 1);
151 151
             }
152 152
             return $modifiers;
153 153
         }
154 154
     }
155 155
 
156
-    public function _fetchContent($string,$delim) {
156
+    public function _fetchContent($string, $delim){
157 157
         $len = strlen($delim);
158 158
         $string = $this->parseDocumentSource($string);
159
-        return substr($string,strpos($string, $delim)+$len);
159
+        return substr($string, strpos($string, $delim) + $len);
160 160
     }
161 161
 
162
-    public function splitEachModifiers($modifiers) {
162
+    public function splitEachModifiers($modifiers){
163 163
         global $modx;
164 164
 
165 165
         $cmd = '';
166 166
         $bt = '';
167 167
         $result = array();
168
-        while($bt!==$modifiers) {
168
+        while ($bt !== $modifiers) {
169 169
             $bt = $modifiers;
170
-            $c = substr($modifiers,0,1);
171
-            $modifiers = substr($modifiers,1);
170
+            $c = substr($modifiers, 0, 1);
171
+            $modifiers = substr($modifiers, 1);
172 172
 
173
-            if($c===':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) { // :=, :!=, :<=, :>=, :!<=, :!>=
174
-                $c = substr($modifiers,strlen($match[1]),1);
173
+            if ($c === ':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) { // :=, :!=, :<=, :>=, :!<=, :!>=
174
+                $c = substr($modifiers, strlen($match[1]), 1);
175 175
                 $debuginfo = "#i=0 #c=[{$c}] #m=[{$modifiers}]";
176
-                if($c==='(') $modifiers = substr($modifiers,strlen($match[1])+1);
177
-                else         $modifiers = substr($modifiers,strlen($match[1]));
176
+                if ($c === '(') $modifiers = substr($modifiers, strlen($match[1]) + 1);
177
+                else         $modifiers = substr($modifiers, strlen($match[1]));
178 178
 
179
-                $delim     = $this->_getDelim($c,$modifiers);
180
-                $opt       = $this->_getOpt($c,$delim,$modifiers);
181
-                $modifiers = trim($this->_getRemainModifiers($c,$delim,$modifiers));
179
+                $delim     = $this->_getDelim($c, $modifiers);
180
+                $opt       = $this->_getOpt($c, $delim, $modifiers);
181
+                $modifiers = trim($this->_getRemainModifiers($c, $delim, $modifiers));
182 182
 
183
-                $result[]=array('cmd'=>trim($match[1]),'opt'=>$opt,'debuginfo'=>$debuginfo);
183
+                $result[] = array('cmd'=>trim($match[1]), 'opt'=>$opt, 'debuginfo'=>$debuginfo);
184 184
                 $cmd = '';
185 185
             }
186
-            elseif(in_array($c,array('+','-','*','/')) && preg_match('@^[0-9]+@', $modifiers, $match)) { // :+3, :-3, :*3 ...
187
-                $modifiers = substr($modifiers,strlen($match[0]));
188
-                $result[]=array('cmd'=>'math','opt'=>'%s'.$c.$match[0]);
186
+            elseif (in_array($c, array('+', '-', '*', '/')) && preg_match('@^[0-9]+@', $modifiers, $match)) { // :+3, :-3, :*3 ...
187
+                $modifiers = substr($modifiers, strlen($match[0]));
188
+                $result[] = array('cmd'=>'math', 'opt'=>'%s'.$c.$match[0]);
189 189
                 $cmd = '';
190 190
             }
191
-            elseif($c==='(' || $c==='=') {
191
+            elseif ($c === '(' || $c === '=') {
192 192
                 $modifiers = $m1 = trim($modifiers);
193
-                $delim     = $this->_getDelim($c,$modifiers);
194
-                $opt       = $this->_getOpt($c,$delim,$modifiers);
195
-                $modifiers = trim($this->_getRemainModifiers($c,$delim,$modifiers));
193
+                $delim     = $this->_getDelim($c, $modifiers);
194
+                $opt       = $this->_getOpt($c, $delim, $modifiers);
195
+                $modifiers = trim($this->_getRemainModifiers($c, $delim, $modifiers));
196 196
                 $debuginfo = "#i=1 #c=[{$c}] #delim=[{$delim}] #m1=[{$m1}] remainMdf=[{$modifiers}]";
197 197
 
198
-                $result[]=array('cmd'=>trim($cmd),'opt'=>$opt,'debuginfo'=>$debuginfo);
198
+                $result[] = array('cmd'=>trim($cmd), 'opt'=>$opt, 'debuginfo'=>$debuginfo);
199 199
 
200 200
                 $cmd = '';
201 201
             }
202
-            elseif($c==':') {
202
+            elseif ($c == ':') {
203 203
                 $debuginfo = "#i=2 #c=[{$c}] #m=[{$modifiers}]";
204
-                if($cmd!=='') $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
204
+                if ($cmd !== '') $result[] = array('cmd'=>trim($cmd), 'opt'=>'', 'debuginfo'=>$debuginfo);
205 205
 
206 206
                 $cmd = '';
207 207
             }
208
-            elseif(trim($modifiers)=='' && trim($cmd)!=='') {
208
+            elseif (trim($modifiers) == '' && trim($cmd) !== '') {
209 209
                 $debuginfo = "#i=3 #c=[{$c}] #m=[{$modifiers}]";
210 210
                 $cmd .= $c;
211
-                $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
211
+                $result[] = array('cmd'=>trim($cmd), 'opt'=>'', 'debuginfo'=>$debuginfo);
212 212
 
213 213
                 break;
214 214
             }
@@ -217,65 +217,65 @@  discard block
 block discarded – undo
217 217
             }
218 218
         }
219 219
 
220
-        if(empty($result)) return array();
220
+        if (empty($result)) return array();
221 221
 
222
-        foreach($result as $i=>$a)
222
+        foreach ($result as $i=>$a)
223 223
         {
224 224
             $a['opt'] = $this->parseDocumentSource($a['opt']);
225
-            $result[$i]['opt'] = $modx->mergePlaceholderContent($a['opt'],$this->placeholders);
225
+            $result[$i]['opt'] = $modx->mergePlaceholderContent($a['opt'], $this->placeholders);
226 226
         }
227 227
 
228 228
         return $result;
229 229
     }
230 230
 
231
-    public function parsePhx($key,$value,$modifiers)
231
+    public function parsePhx($key, $value, $modifiers)
232 232
     {
233 233
         global $modx;
234 234
         $lastKey = '';
235
-        $cacheKey = md5(sprintf('parsePhx#%s#%s#%s',$key,$value,print_r($modifiers,true)));
236
-        if(isset($this->tmpCache[$cacheKey])) return $this->tmpCache[$cacheKey];
237
-        if(empty($modifiers)) return '';
235
+        $cacheKey = md5(sprintf('parsePhx#%s#%s#%s', $key, $value, print_r($modifiers, true)));
236
+        if (isset($this->tmpCache[$cacheKey])) return $this->tmpCache[$cacheKey];
237
+        if (empty($modifiers)) return '';
238 238
 
239
-        foreach($modifiers as $m)
239
+        foreach ($modifiers as $m)
240 240
         {
241 241
             $lastKey = strtolower($m['cmd']);
242 242
         }
243
-        $_ = explode(',',$this->condModifiers);
244
-        if(in_array($lastKey,$_))
243
+        $_ = explode(',', $this->condModifiers);
244
+        if (in_array($lastKey, $_))
245 245
         {
246
-            $modifiers[] = array('cmd'=>'then','opt'=>'1');
247
-            $modifiers[] = array('cmd'=>'else','opt'=>'0');
246
+            $modifiers[] = array('cmd'=>'then', 'opt'=>'1');
247
+            $modifiers[] = array('cmd'=>'else', 'opt'=>'0');
248 248
         }
249 249
 
250
-        foreach($modifiers as $i=>$a)
250
+        foreach ($modifiers as $i=>$a)
251 251
         {
252
-            $value = $this->Filter($key,$value, $a['cmd'], $a['opt']);
252
+            $value = $this->Filter($key, $value, $a['cmd'], $a['opt']);
253 253
         }
254 254
         $this->tmpCache[$cacheKey] = $value;
255 255
         return $value;
256 256
     }
257 257
 
258 258
     // Parser: modifier detection and eXtended processing if needed
259
-    public function Filter($key, $value, $cmd, $opt='')
259
+    public function Filter($key, $value, $cmd, $opt = '')
260 260
     {
261 261
         global $modx;
262 262
 
263
-        if($key==='documentObject') $value = $modx->documentIdentifier;
263
+        if ($key === 'documentObject') $value = $modx->documentIdentifier;
264 264
         $cmd = $this->parseDocumentSource($cmd);
265
-        if(preg_match('@^[1-9][/0-9]*$@',$cmd))
265
+        if (preg_match('@^[1-9][/0-9]*$@', $cmd))
266 266
         {
267
-            if(strpos($cmd,'/')!==false)
268
-                $cmd = $this->substr($cmd,strrpos($cmd,'/')+1);
267
+            if (strpos($cmd, '/') !== false)
268
+                $cmd = $this->substr($cmd, strrpos($cmd, '/') + 1);
269 269
             $opt = $cmd;
270 270
             $cmd = 'id';
271 271
         }
272 272
 
273
-        if(isset($modx->snippetCache["phx:{$cmd}"]))   $this->elmName = "phx:{$cmd}";
274
-        elseif(isset($modx->chunkCache["phx:{$cmd}"])) $this->elmName = "phx:{$cmd}";
273
+        if (isset($modx->snippetCache["phx:{$cmd}"]))   $this->elmName = "phx:{$cmd}";
274
+        elseif (isset($modx->chunkCache["phx:{$cmd}"])) $this->elmName = "phx:{$cmd}";
275 275
         else                                           $this->elmName = '';
276 276
 
277 277
         $cmd = strtolower($cmd);
278
-        if($this->elmName!=='')
278
+        if ($this->elmName !== '')
279 279
             $value = $this->getValueFromElement($key, $value, $cmd, $opt);
280 280
         else
281 281
             $value = $this->getValueFromPreset($key, $value, $cmd, $opt);
@@ -285,12 +285,12 @@  discard block
 block discarded – undo
285 285
         return $value;
286 286
     }
287 287
 
288
-    public function isEmpty($cmd,$value)
288
+    public function isEmpty($cmd, $value)
289 289
     {
290
-        if($value!=='') return false;
290
+        if ($value !== '') return false;
291 291
 
292
-        $_ = explode(',', $this->condModifiers . ',_default,default,if,input,or,and,show,this,select,switch,then,else,id,ifempty,smart_desc,smart_description,summary');
293
-        if(in_array($cmd,$_)) return false;
292
+        $_ = explode(',', $this->condModifiers.',_default,default,if,input,or,and,show,this,select,switch,then,else,id,ifempty,smart_desc,smart_description,summary');
293
+        if (in_array($cmd, $_)) return false;
294 294
         else                  return true;
295 295
     }
296 296
 
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
     {
299 299
         global $modx;
300 300
 
301
-        if($this->isEmpty($cmd,$value)) return '';
301
+        if ($this->isEmpty($cmd, $value)) return '';
302 302
 
303 303
         $this->key = $key;
304 304
         $this->value  = $value;
@@ -309,83 +309,83 @@  discard block
 block discarded – undo
309 309
             #####  Conditional Modifiers
310 310
             case 'input':
311 311
             case 'if':
312
-                if(!$opt) return $value;
312
+                if (!$opt) return $value;
313 313
                 return $opt;
314 314
             case '=':
315 315
             case 'eq':
316 316
             case 'is':
317 317
             case 'equals':
318
-                $this->condition[] = (int)($value == $opt); break;
318
+                $this->condition[] = (int) ($value == $opt); break;
319 319
             case 'neq':
320 320
             case 'ne':
321 321
             case 'notequals':
322 322
             case 'isnot':
323 323
             case 'isnt':
324 324
             case 'not':
325
-                $this->condition[] = (int)($value != $opt);break;
325
+                $this->condition[] = (int) ($value != $opt); break;
326 326
             case '%':
327
-                $this->condition[] = (int)($value%$opt==0);break;
327
+                $this->condition[] = (int) ($value % $opt == 0); break;
328 328
             case 'isempty':
329
-                $this->condition[] = (int)(empty($value)); break;
329
+                $this->condition[] = (int) (empty($value)); break;
330 330
             case 'isntempty':
331 331
             case 'isnotempty':
332
-                $this->condition[] = (int)(!empty($value)); break;
332
+                $this->condition[] = (int) (!empty($value)); break;
333 333
             case '>=':
334 334
             case 'gte':
335 335
             case 'eg':
336 336
             case 'isgte':
337
-                $this->condition[] = (int)($value >= $opt);break;
337
+                $this->condition[] = (int) ($value >= $opt); break;
338 338
             case '<=':
339 339
             case 'lte':
340 340
             case 'el':
341 341
             case 'islte':
342
-                $this->condition[] = (int)($value <= $opt);break;
342
+                $this->condition[] = (int) ($value <= $opt); break;
343 343
             case '>':
344 344
             case 'gt':
345 345
             case 'greaterthan':
346 346
             case 'isgreaterthan':
347 347
             case 'isgt':
348
-                $this->condition[] = (int)($value > $opt);break;
348
+                $this->condition[] = (int) ($value > $opt); break;
349 349
             case '<':
350 350
             case 'lt':
351 351
             case 'lowerthan':
352 352
             case 'islowerthan':
353 353
             case 'islt':
354
-                $this->condition[] = (int)($value < $opt);break;
354
+                $this->condition[] = (int) ($value < $opt); break;
355 355
             case 'find':
356
-                $this->condition[] = (int)(strpos($value, $opt)!==false);break;
356
+                $this->condition[] = (int) (strpos($value, $opt) !== false); break;
357 357
             case 'inarray':
358 358
             case 'in_array':
359 359
             case 'in':
360 360
                 $opt = explode(',', $opt);
361
-                $this->condition[] = (int)(in_array($value, $opt)!==false);break;
361
+                $this->condition[] = (int) (in_array($value, $opt) !== false); break;
362 362
             case 'wildcard_match':
363 363
             case 'wcard_match':
364 364
             case 'wildcard':
365 365
             case 'wcard':
366 366
             case 'fnmatch':
367
-                $this->condition[] = (int)(fnmatch($opt, $value)!==false);break;
367
+                $this->condition[] = (int) (fnmatch($opt, $value) !== false); break;
368 368
             case 'is_file':
369 369
             case 'is_dir':
370 370
             case 'file_exists':
371 371
             case 'is_readable':
372 372
             case 'is_writable':
373
-                if(!$opt) $path = $value;
373
+                if (!$opt) $path = $value;
374 374
                 else      $path = $opt;
375
-                if(strpos($path,MODX_MANAGER_PATH)!==false) exit('Can not read core path');
376
-                if(strpos($path,$modx->config['base_path'])===false) $path = ltrim($path,'/');
377
-                $this->condition[] = (int)($cmd($path)!==false);break;
375
+                if (strpos($path, MODX_MANAGER_PATH) !== false) exit('Can not read core path');
376
+                if (strpos($path, $modx->config['base_path']) === false) $path = ltrim($path, '/');
377
+                $this->condition[] = (int) ($cmd($path) !== false); break;
378 378
             case 'is_image':
379
-                if(!$opt) $path = $value;
379
+                if (!$opt) $path = $value;
380 380
                 else      $path = $opt;
381
-                if(!is_file($path)) {$this->condition[]='0';break;}
381
+                if (!is_file($path)) {$this->condition[] = '0'; break; }
382 382
                 $_ = getimagesize($path);
383
-                $this->condition[] = (int)($_[0]);break;
383
+                $this->condition[] = (int) ($_[0]); break;
384 384
             case 'regex':
385 385
             case 'preg':
386 386
             case 'preg_match':
387 387
             case 'isinrole':
388
-            $this->condition[] = (int)(preg_match($opt,$value));break;
388
+            $this->condition[] = (int) (preg_match($opt, $value)); break;
389 389
             case 'ir':
390 390
             case 'memberof':
391 391
             case 'mo':
@@ -393,50 +393,50 @@  discard block
 block discarded – undo
393 393
                 $this->condition[] = $this->includeMdfFile('memberof');
394 394
                 break;
395 395
             case 'or':
396
-                $this->condition[] = '||';break;
396
+                $this->condition[] = '||'; break;
397 397
             case 'and':
398
-                $this->condition[] = '&&';break;
398
+                $this->condition[] = '&&'; break;
399 399
             case 'show':
400 400
             case 'this':
401
-                $conditional = implode(' ',$this->condition);
402
-                $isvalid = (int)(eval("return ({$conditional});"));
401
+                $conditional = implode(' ', $this->condition);
402
+                $isvalid = (int) (eval("return ({$conditional});"));
403 403
                 if ($isvalid) return $this->srcValue;
404 404
                 return NULL;
405 405
             case 'then':
406
-                $conditional = implode(' ',$this->condition);
407
-                $isvalid = (int)eval("return ({$conditional});");
406
+                $conditional = implode(' ', $this->condition);
407
+                $isvalid = (int) eval("return ({$conditional});");
408 408
                 if ($isvalid)  return $opt;
409 409
                 return null;
410 410
             case 'else':
411
-                $conditional = implode(' ',$this->condition);
412
-                $isvalid = (int)eval("return ({$conditional});");
411
+                $conditional = implode(' ', $this->condition);
412
+                $isvalid = (int) eval("return ({$conditional});");
413 413
                 if (!$isvalid) return $opt;
414 414
                 break;
415 415
             case 'select':
416 416
             case 'switch':
417
-                $raw = explode('&',$opt);
417
+                $raw = explode('&', $opt);
418 418
                 $map = array();
419 419
                 $c = count($raw);
420
-                for($m=0; $m<$c; $m++) {
421
-                    $mi = explode('=',$raw[$m],2);
420
+                for ($m = 0; $m < $c; $m++) {
421
+                    $mi = explode('=', $raw[$m], 2);
422 422
                     $map[$mi[0]] = $mi[1];
423 423
                 }
424
-                if(isset($map[$value])) return $map[$value];
424
+                if (isset($map[$value])) return $map[$value];
425 425
                 else                    return '';
426 426
             ##### End of Conditional Modifiers
427 427
 
428 428
             #####  Encode / Decode / Hash / Escape
429 429
             case 'htmlent':
430 430
             case 'htmlentities':
431
-                return htmlentities($value,ENT_QUOTES,$modx->config['modx_charset']);
431
+                return htmlentities($value, ENT_QUOTES, $modx->config['modx_charset']);
432 432
             case 'html_entity_decode':
433 433
             case 'decode_html':
434 434
             case 'html_decode':
435
-                return html_entity_decode($value,ENT_QUOTES,$modx->config['modx_charset']);
435
+                return html_entity_decode($value, ENT_QUOTES, $modx->config['modx_charset']);
436 436
             case 'esc':
437 437
             case 'escape':
438 438
                 $value = preg_replace('/&amp;(#[0-9]+|[a-z]+);/i', '&$1;', htmlspecialchars($value, ENT_QUOTES, $modx->config['modx_charset']));
439
-                return str_replace(array('[', ']', '`'),array('&#91;', '&#93;', '&#96;'),$value);
439
+                return str_replace(array('[', ']', '`'), array('&#91;', '&#93;', '&#96;'), $value);
440 440
             case 'sql_escape':
441 441
             case 'encode_js':
442 442
                 return $modx->db->escape($value);
@@ -446,39 +446,39 @@  discard block
 block discarded – undo
446 446
             case 'html_encode':
447 447
                 return preg_replace('/&amp;(#[0-9]+|[a-z]+);/i', '&$1;', htmlspecialchars($value, ENT_QUOTES, $modx->config['modx_charset']));
448 448
             case 'spam_protect':
449
-                return str_replace(array('@','.'),array('&#64;','&#46;'),$value);
449
+                return str_replace(array('@', '.'), array('&#64;', '&#46;'), $value);
450 450
             case 'strip':
451
-                if($opt==='') $opt = ' ';
451
+                if ($opt === '') $opt = ' ';
452 452
                 return preg_replace('/[\n\r\t\s]+/', $opt, $value);
453 453
             case 'strip_linefeeds':
454
-                return str_replace(array("\n","\r"), '', $value);
454
+                return str_replace(array("\n", "\r"), '', $value);
455 455
             case 'notags':
456 456
             case 'strip_tags':
457 457
             case 'remove_html':
458
-                if($opt!=='')
458
+                if ($opt !== '')
459 459
                 {
460 460
                     $param = array();
461
-                    foreach(explode(',',$opt) as $v)
461
+                    foreach (explode(',', $opt) as $v)
462 462
                     {
463
-                        $v = trim($v,'</> ');
463
+                        $v = trim($v, '</> ');
464 464
                         $param[] = "<{$v}>";
465 465
                     }
466
-                    $params = implode(',',$param);
466
+                    $params = implode(',', $param);
467 467
                 }
468 468
                 else $params = '';
469
-                if(!strpos($params,'<br>')===false) {
470
-                    $value = preg_replace('@(<br[ /]*>)\n@','$1',$value);
471
-                    $value = preg_replace('@<br[ /]*>@',"\n",$value);
469
+                if (!strpos($params, '<br>') === false) {
470
+                    $value = preg_replace('@(<br[ /]*>)\n@', '$1', $value);
471
+                    $value = preg_replace('@<br[ /]*>@', "\n", $value);
472 472
                 }
473
-                return $this->strip_tags($value,$params);
473
+                return $this->strip_tags($value, $params);
474 474
             case 'urlencode':
475 475
             case 'url_encode':
476 476
             case 'encode_url':
477 477
                 return urlencode($value);
478 478
             case 'base64_decode':
479
-                if($opt!=='false') $opt = true;
479
+                if ($opt !== 'false') $opt = true;
480 480
                 else               $opt = false;
481
-                return base64_decode($value,$opt);
481
+                return base64_decode($value, $opt);
482 482
             case 'encode_sha1': $cmd = 'sha1';
483 483
             case 'addslashes':
484 484
             case 'urldecode':
@@ -502,18 +502,18 @@  discard block
 block discarded – undo
502 502
             case 'upper_case':
503 503
                 return $this->strtoupper($value);
504 504
             case 'capitalize':
505
-                $_ = explode(' ',$value);
506
-                foreach($_ as $i=>$v)
505
+                $_ = explode(' ', $value);
506
+                foreach ($_ as $i=>$v)
507 507
                 {
508 508
                     $_[$i] = ucfirst($v);
509 509
                 }
510
-                return implode(' ',$_);
510
+                return implode(' ', $_);
511 511
             case 'zenhan':
512
-                if(empty($opt)) $opt='VKas';
513
-                return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
512
+                if (empty($opt)) $opt = 'VKas';
513
+                return mb_convert_kana($value, $opt, $modx->config['modx_charset']);
514 514
             case 'hanzen':
515
-                if(empty($opt)) $opt='VKAS';
516
-                return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
515
+                if (empty($opt)) $opt = 'VKAS';
516
+                return mb_convert_kana($value, $opt, $modx->config['modx_charset']);
517 517
             case 'str_shuffle':
518 518
             case 'shuffle':
519 519
                 return $this->str_shuffle($value);
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
                 return $this->strlen($value);
528 528
             case 'count_words':
529 529
                 $value = trim($value);
530
-                return count(preg_split('/\s+/',$value));
530
+                return count(preg_split('/\s+/', $value));
531 531
             case 'str_word_count':
532 532
             case 'word_count':
533 533
             case 'wordcount':
@@ -535,55 +535,55 @@  discard block
 block discarded – undo
535 535
             case 'count_paragraphs':
536 536
                 $value = trim($value);
537 537
                 $value = preg_replace('/\r/', '', $value);
538
-                return count(preg_split('/\n+/',$value));
538
+                return count(preg_split('/\n+/', $value));
539 539
             case 'strpos':
540
-                if($opt!=0&&empty($opt)) return $value;
541
-                return $this->strpos($value,$opt);
540
+                if ($opt != 0 && empty($opt)) return $value;
541
+                return $this->strpos($value, $opt);
542 542
             case 'wordwrap':
543 543
                 // default: 70
544
-                  $wrapat = (int)$opt > 0 ? (int)$opt : 70;
544
+                  $wrapat = (int) $opt > 0 ? (int) $opt : 70;
545 545
                 if (version_compare(PHP_VERSION, '5.3.0') >= 0) return $this->includeMdfFile('wordwrap');
546
-                else return preg_replace("@(\b\w+\b)@e","wordwrap('\\1',\$wrapat,' ',1)",$value);
546
+                else return preg_replace("@(\b\w+\b)@e", "wordwrap('\\1',\$wrapat,' ',1)", $value);
547 547
             case 'wrap_text':
548
-                $width = preg_match('/^[1-9][0-9]*$/',$opt) ? $opt : 70;
549
-                if($modx->config['manager_language']==='japanese-utf8') {
548
+                $width = preg_match('/^[1-9][0-9]*$/', $opt) ? $opt : 70;
549
+                if ($modx->config['manager_language'] === 'japanese-utf8') {
550 550
                     $chunk = array();
551
-                    $bt='';
552
-                    while($bt!=$value) {
551
+                    $bt = '';
552
+                    while ($bt != $value) {
553 553
                         $bt = $value;
554
-                        if($this->strlen($value)<$width) {
554
+                        if ($this->strlen($value) < $width) {
555 555
                             $chunk[] = $value;
556 556
                             break;
557 557
                         }
558
-                        $chunk[] = $this->substr($value,0,$width);
559
-                        $value = $this->substr($value,$width);
558
+                        $chunk[] = $this->substr($value, 0, $width);
559
+                        $value = $this->substr($value, $width);
560 560
                     }
561
-                    return implode("\n",$chunk);
561
+                    return implode("\n", $chunk);
562 562
                 }
563 563
                 else
564
-                    return wordwrap($value,$width,"\n",true);
564
+                    return wordwrap($value, $width, "\n", true);
565 565
             case 'substr':
566
-                if(empty($opt)) break;
567
-                if(strpos($opt,',')!==false) {
568
-                    list($b,$e) = explode(',',$opt,2);
569
-                    return $this->substr($value,$b,(int)$e);
566
+                if (empty($opt)) break;
567
+                if (strpos($opt, ',') !== false) {
568
+                    list($b, $e) = explode(',', $opt, 2);
569
+                    return $this->substr($value, $b, (int) $e);
570 570
                 }
571
-                else return $this->substr($value,$opt);
571
+                else return $this->substr($value, $opt);
572 572
             case 'limit':
573 573
             case 'trim_to': // http://www.movabletype.jp/documentation/appendices/modifiers/trim_to.html
574
-                if(strpos($opt,'+')!==false)
575
-                    list($len,$str) = explode('+',$opt,2);
574
+                if (strpos($opt, '+') !== false)
575
+                    list($len, $str) = explode('+', $opt, 2);
576 576
                 else {
577 577
                     $len = $opt;
578 578
                     $str = '';
579 579
                 }
580
-                if($len==='') $len = 100;
581
-                if(abs($len) > $this->strlen($value)) $str ='';
582
-                if(preg_match('/^[1-9][0-9]*$/',$len)) {
583
-                    return $this->substr($value,0,$len) . $str;
580
+                if ($len === '') $len = 100;
581
+                if (abs($len) > $this->strlen($value)) $str = '';
582
+                if (preg_match('/^[1-9][0-9]*$/', $len)) {
583
+                    return $this->substr($value, 0, $len).$str;
584 584
                 }
585
-                elseif(preg_match('/^\-[1-9][0-9]*$/',$len)) {
586
-                    return $str . $this->substr($value,$len);
585
+                elseif (preg_match('/^\-[1-9][0-9]*$/', $len)) {
586
+                    return $str.$this->substr($value, $len);
587 587
                 }
588 588
                 break;
589 589
             case 'summary':
@@ -592,81 +592,81 @@  discard block
 block discarded – undo
592 592
                 return $this->includeMdfFile('summary');
593 593
             case 'replace':
594 594
             case 'str_replace':
595
-                if(empty($opt) || strpos($opt,',')===false) break;
596
-                if    (substr_count($opt, ',') ==1) $delim = ',';
597
-                elseif(substr_count($opt, '|') ==1) $delim = '|';
598
-                elseif(substr_count($opt, '=>')==1) $delim = '=>';
599
-                elseif(substr_count($opt, '/') ==1) $delim = '/';
595
+                if (empty($opt) || strpos($opt, ',') === false) break;
596
+                if (substr_count($opt, ',') == 1) $delim = ',';
597
+                elseif (substr_count($opt, '|') == 1) $delim = '|';
598
+                elseif (substr_count($opt, '=>') == 1) $delim = '=>';
599
+                elseif (substr_count($opt, '/') == 1) $delim = '/';
600 600
                 else break;
601
-                list($s,$r) = explode($delim,$opt);
602
-                if($value!=='') return str_replace($s,$r,$value);
601
+                list($s, $r) = explode($delim, $opt);
602
+                if ($value !== '') return str_replace($s, $r, $value);
603 603
                 break;
604 604
             case 'replace_to':
605 605
             case 'tpl':
606
-                if($value!=='') return str_replace(array('[+value+]','[+output+]','{value}','%s'),$value,$opt);
606
+                if ($value !== '') return str_replace(array('[+value+]', '[+output+]', '{value}', '%s'), $value, $opt);
607 607
                 break;
608 608
             case 'eachtpl':
609
-                $value = explode('||',$value);
609
+                $value = explode('||', $value);
610 610
                 $_ = array();
611
-                foreach($value as $v) {
612
-                    $_[] = str_replace(array('[+value+]','[+output+]','{value}','%s'),$v,$opt);
611
+                foreach ($value as $v) {
612
+                    $_[] = str_replace(array('[+value+]', '[+output+]', '{value}', '%s'), $v, $opt);
613 613
                 }
614 614
                 return implode("\n", $_);
615 615
             case 'array_pop':
616 616
             case 'array_shift':
617
-                if(strpos($value,'||')!==false) $delim = '||';
617
+                if (strpos($value, '||') !== false) $delim = '||';
618 618
                 else                            $delim = ',';
619
-                return $cmd(explode($delim,$value));
619
+                return $cmd(explode($delim, $value));
620 620
             case 'preg_replace':
621 621
             case 'regex_replace':
622
-                if(empty($opt) || strpos($opt,',')===false) break;
623
-                list($s,$r) = explode(',',$opt,2);
624
-                if($value!=='') return preg_replace($s,$r,$value);
622
+                if (empty($opt) || strpos($opt, ',') === false) break;
623
+                list($s, $r) = explode(',', $opt, 2);
624
+                if ($value !== '') return preg_replace($s, $r, $value);
625 625
                 break;
626 626
             case 'cat':
627 627
             case 'concatenate':
628 628
             case '.':
629
-                if($value!=='') return $value . $opt;
629
+                if ($value !== '') return $value.$opt;
630 630
                 break;
631 631
             case 'sprintf':
632 632
             case 'string_format':
633
-                if($value!=='') return sprintf($opt,$value);
633
+                if ($value !== '') return sprintf($opt, $value);
634 634
                 break;
635 635
             case 'number_format':
636
-                    if($opt=='') $opt = 0;
637
-                    return number_format($value,$opt);
636
+                    if ($opt == '') $opt = 0;
637
+                    return number_format($value, $opt);
638 638
             case 'money_format':
639
-                    setlocale(LC_MONETARY,setlocale(LC_TIME,0));
640
-                    if($value!=='') return money_format($opt,(double)$value);
639
+                    setlocale(LC_MONETARY, setlocale(LC_TIME, 0));
640
+                    if ($value !== '') return money_format($opt, (double) $value);
641 641
                     break;
642 642
             case 'tobool':
643 643
                 return boolval($value);
644 644
             case 'nl2lf':
645
-                if($value!=='') return str_replace(array("\r\n","\n", "\r"), '\n', $value);
645
+                if ($value !== '') return str_replace(array("\r\n", "\n", "\r"), '\n', $value);
646 646
                 break;
647 647
             case 'br2nl':
648 648
                 return preg_replace('@<br[\s/]*>@i', "\n", $value);
649 649
             case 'nl2br':
650 650
                 if (version_compare(PHP_VERSION, '5.3.0', '<'))
651 651
                     return nl2br($value);
652
-                if($opt!=='')
652
+                if ($opt !== '')
653 653
                 {
654 654
                     $opt = trim($opt);
655 655
                     $opt = strtolower($opt);
656
-                    if($opt==='false') $opt = false;
657
-                    elseif($opt==='0') $opt = false;
656
+                    if ($opt === 'false') $opt = false;
657
+                    elseif ($opt === '0') $opt = false;
658 658
                     else               $opt = true;
659 659
                 }
660
-                elseif(isset($modx->config['mce_element_format'])&&$modx->config['mce_element_format']==='html')
660
+                elseif (isset($modx->config['mce_element_format']) && $modx->config['mce_element_format'] === 'html')
661 661
                                        $opt = false;
662 662
                 else                   $opt = true;
663
-                return nl2br($value,$opt);
663
+                return nl2br($value, $opt);
664 664
             case 'ltrim':
665 665
             case 'rtrim':
666 666
             case 'trim': // ref http://mblo.info/modifiers/custom-modifiers/rtrim_opt.html
667
-                if($opt==='')
667
+                if ($opt === '')
668 668
                     return $cmd($value);
669
-                else return $cmd($value,$opt);
669
+                else return $cmd($value, $opt);
670 670
             // These are all straight wrappers for PHP functions
671 671
             case 'ucfirst':
672 672
             case 'lcfirst':
@@ -677,58 +677,58 @@  discard block
 block discarded – undo
677 677
             case 'strftime':
678 678
             case 'date':
679 679
             case 'dateformat':
680
-                if(empty($opt)) $opt = $modx->toDateFormat(null, 'formatOnly');
681
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
682
-                if(strpos($opt,'%')!==false)
683
-                    return strftime($opt,0+$value);
680
+                if (empty($opt)) $opt = $modx->toDateFormat(null, 'formatOnly');
681
+                if (!preg_match('@^[0-9]+$@', $value)) $value = strtotime($value);
682
+                if (strpos($opt, '%') !== false)
683
+                    return strftime($opt, 0 + $value);
684 684
                 else
685
-                    return date($opt,0+$value);
685
+                    return date($opt, 0 + $value);
686 686
             case 'time':
687
-                if(empty($opt)) $opt = '%H:%M';
688
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
689
-                return strftime($opt,0+$value);
687
+                if (empty($opt)) $opt = '%H:%M';
688
+                if (!preg_match('@^[0-9]+$@', $value)) $value = strtotime($value);
689
+                return strftime($opt, 0 + $value);
690 690
             case 'strtotime':
691 691
                 return strtotime($value);
692 692
             #####  mathematical function
693 693
             case 'toint':
694
-                return (int)$value;
694
+                return (int) $value;
695 695
             case 'tofloat':
696 696
                 return floatval($value);
697 697
             case 'round':
698
-                if(!$opt) $opt = 0;
699
-                return $cmd($value,$opt);
698
+                if (!$opt) $opt = 0;
699
+                return $cmd($value, $opt);
700 700
             case 'max':
701 701
             case 'min':
702
-                return $cmd(explode(',',$value));
702
+                return $cmd(explode(',', $value));
703 703
             case 'floor':
704 704
             case 'ceil':
705 705
             case 'abs':
706 706
                 return $cmd($value);
707 707
             case 'math':
708 708
             case 'calc':
709
-                $value = (int)$value;
710
-                if(empty($value)) $value = '0';
711
-                $filter = str_replace(array('[+value+]','[+output+]','{value}','%s'),'?',$opt);
712
-                $filter = preg_replace('@([a-zA-Z\n\r\t\s])@','',$filter);
713
-                if(strpos($filter,'?')===false) $filter = "?{$filter}";
714
-                $filter = str_replace('?',$value,$filter);
709
+                $value = (int) $value;
710
+                if (empty($value)) $value = '0';
711
+                $filter = str_replace(array('[+value+]', '[+output+]', '{value}', '%s'), '?', $opt);
712
+                $filter = preg_replace('@([a-zA-Z\n\r\t\s])@', '', $filter);
713
+                if (strpos($filter, '?') === false) $filter = "?{$filter}";
714
+                $filter = str_replace('?', $value, $filter);
715 715
                 return eval("return {$filter};");
716 716
             case 'count':
717
-                if($value=='') return 0;
718
-                $value = explode(',',$value);
717
+                if ($value == '') return 0;
718
+                $value = explode(',', $value);
719 719
                 return count($value);
720 720
             case 'sort':
721 721
             case 'rsort':
722
-                if(strpos($value,"\n")!==false) $delim="\n";
722
+                if (strpos($value, "\n") !== false) $delim = "\n";
723 723
                 else $delim = ',';
724
-                $swap = explode($delim,$value);
725
-                if(!$opt) $opt = SORT_REGULAR;
724
+                $swap = explode($delim, $value);
725
+                if (!$opt) $opt = SORT_REGULAR;
726 726
                 else      $opt = constant($opt);
727
-                $cmd($swap,$opt);
728
-                return implode($delim,$swap);
727
+                $cmd($swap, $opt);
728
+                return implode($delim, $swap);
729 729
             #####  Resource fields
730 730
             case 'id':
731
-                if($opt) return $this->getDocumentObject($opt,$key);
731
+                if ($opt) return $this->getDocumentObject($opt, $key);
732 732
                 break;
733 733
             case 'type':
734 734
             case 'contenttype':
@@ -765,36 +765,36 @@  discard block
 block discarded – undo
765 765
             case 'privatemgr':
766 766
             case 'content_dispo':
767 767
             case 'hidemenu':
768
-                if($cmd==='contenttype') $cmd = 'contentType';
769
-                return $this->getDocumentObject($value,$cmd);
768
+                if ($cmd === 'contenttype') $cmd = 'contentType';
769
+                return $this->getDocumentObject($value, $cmd);
770 770
             case 'title':
771
-                $pagetitle = $this->getDocumentObject($value,'pagetitle');
772
-                $longtitle = $this->getDocumentObject($value,'longtitle');
771
+                $pagetitle = $this->getDocumentObject($value, 'pagetitle');
772
+                $longtitle = $this->getDocumentObject($value, 'longtitle');
773 773
                 return $longtitle ? $longtitle : $pagetitle;
774 774
             case 'shorttitle':
775
-                $pagetitle = $this->getDocumentObject($value,'pagetitle');
776
-                $menutitle = $this->getDocumentObject($value,'menutitle');
775
+                $pagetitle = $this->getDocumentObject($value, 'pagetitle');
776
+                $menutitle = $this->getDocumentObject($value, 'menutitle');
777 777
                 return $menutitle ? $menutitle : $pagetitle;
778 778
             case 'templatename':
779
-                $rs = $modx->db->select('templatename','[+prefix+]site_templates',"id='{$value}'");
779
+                $rs = $modx->db->select('templatename', '[+prefix+]site_templates', "id='{$value}'");
780 780
                 $templateName = $modx->db->getValue($rs);
781 781
                 return !$templateName ? '(blank)' : $templateName;
782 782
             case 'getfield':
783
-                if(!$opt) $opt = 'content';
784
-                return $modx->getField($opt,$value);
783
+                if (!$opt) $opt = 'content';
784
+                return $modx->getField($opt, $value);
785 785
             case 'children':
786 786
             case 'childids':
787
-                if($value=='') $value = 0; // 値がない場合はルートと見なす
787
+                if ($value == '') $value = 0; // 値がない場合はルートと見なす
788 788
                 $published = 1;
789
-                if($opt=='') $opt = 'page';
790
-                $_ = explode(',',$opt);
789
+                if ($opt == '') $opt = 'page';
790
+                $_ = explode(',', $opt);
791 791
                 $where = array();
792
-                foreach($_ as $opt) {
793
-                    switch(trim($opt)) {
792
+                foreach ($_ as $opt) {
793
+                    switch (trim($opt)) {
794 794
                         case 'page'; case '!folder'; case '!isfolder': $where[] = 'sc.isfolder=0'; break;
795 795
                         case 'folder'; case 'isfolder':                $where[] = 'sc.isfolder=1'; break;
796
-                        case  'menu';  case  'show_menu':              $where[] = 'sc.hidemenu=0'; break;
797
-                        case '!menu';  case '!show_menu':              $where[] = 'sc.hidemenu=1'; break;
796
+                        case  'menu'; case  'show_menu':              $where[] = 'sc.hidemenu=0'; break;
797
+                        case '!menu'; case '!show_menu':              $where[] = 'sc.hidemenu=1'; break;
798 798
                         case  'published':                             $published = 1; break;
799 799
                         case '!published':                             $published = 0; break;
800 800
                     }
@@ -802,69 +802,69 @@  discard block
 block discarded – undo
802 802
                 $where = implode(' AND ', $where);
803 803
                 $children = $modx->getDocumentChildren($value, $published, '0', 'id', $where);
804 804
                 $result = array();
805
-                foreach((array)$children as $child){
805
+                foreach ((array) $children as $child) {
806 806
                     $result[] = $child['id'];
807 807
                 }
808 808
                 return implode(',', $result);
809 809
             case 'fullurl':
810
-                if(!is_numeric($value)) return $value;
810
+                if (!is_numeric($value)) return $value;
811 811
                 return $modx->makeUrl($value);
812 812
             case 'makeurl':
813
-                if(!is_numeric($value)) return $value;
814
-                if(!$opt) $opt = 'full';
815
-                return $modx->makeUrl($value,'','',$opt);
813
+                if (!is_numeric($value)) return $value;
814
+                if (!$opt) $opt = 'full';
815
+                return $modx->makeUrl($value, '', '', $opt);
816 816
 
817 817
             #####  File system
818 818
             case 'getimageinfo':
819 819
             case 'imageinfo':
820
-                if(!is_file($value)) return '';
820
+                if (!is_file($value)) return '';
821 821
                 $_ = getimagesize($value);
822
-                if(!$_[0]) return '';
822
+                if (!$_[0]) return '';
823 823
                 $info['width']  = $_[0];
824 824
                 $info['height'] = $_[1];
825
-                if    ($_[0] > $_[1]) $info['aspect'] = 'landscape';
826
-                elseif($_[0] < $_[1]) $info['aspect'] = 'portrait';
825
+                if ($_[0] > $_[1]) $info['aspect'] = 'landscape';
826
+                elseif ($_[0] < $_[1]) $info['aspect'] = 'portrait';
827 827
                 else                  $info['aspect'] = 'square';
828
-                switch($_[2]) {
828
+                switch ($_[2]) {
829 829
                     case IMAGETYPE_GIF  : $info['type'] = 'gif'; break;
830 830
                     case IMAGETYPE_JPEG : $info['type'] = 'jpg'; break;
831 831
                     case IMAGETYPE_PNG  : $info['type'] = 'png'; break;
832 832
                     default             : $info['type'] = 'unknown';
833 833
                 }
834 834
                 $info['attrib'] = $_[3];
835
-                switch($opt) {
835
+                switch ($opt) {
836 836
                     case 'width' : return $info['width'];
837 837
                     case 'height': return $info['height'];
838 838
                     case 'aspect': return $info['aspect'];
839 839
                     case 'type'  : return $info['type'];
840 840
                     case 'attrib': return $info['attrib'];
841
-                    default      : return print_r($info,true);
841
+                    default      : return print_r($info, true);
842 842
                 }
843 843
 
844 844
             case 'file_get_contents':
845 845
             case 'readfile':
846
-                if(!is_file($value)) return $value;
846
+                if (!is_file($value)) return $value;
847 847
                 $value = realpath($value);
848
-                if(strpos($value,MODX_MANAGER_PATH)!==false) exit('Can not read core file');
849
-                $ext = strtolower(substr($value,-4));
850
-                if($ext==='.php') exit('Can not read php file');
851
-                if($ext==='.cgi') exit('Can not read cgi file');
848
+                if (strpos($value, MODX_MANAGER_PATH) !== false) exit('Can not read core file');
849
+                $ext = strtolower(substr($value, -4));
850
+                if ($ext === '.php') exit('Can not read php file');
851
+                if ($ext === '.cgi') exit('Can not read cgi file');
852 852
                 return file_get_contents($value);
853 853
             case 'filesize':
854
-                if($value == '') return '';
854
+                if ($value == '') return '';
855 855
                 $filename = $value;
856 856
 
857 857
                 $site_url = $modx->config['site_url'];
858
-                if(strpos($filename,$site_url) === 0)
859
-                    $filename = substr($filename,0,strlen($site_url));
860
-                $filename = trim($filename,'/');
858
+                if (strpos($filename, $site_url) === 0)
859
+                    $filename = substr($filename, 0, strlen($site_url));
860
+                $filename = trim($filename, '/');
861 861
 
862
-                $opt = trim($opt,'/');
863
-                if($opt!=='') $opt .= '/';
862
+                $opt = trim($opt, '/');
863
+                if ($opt !== '') $opt .= '/';
864 864
 
865 865
                 $filename = MODX_BASE_PATH.$opt.$filename;
866 866
 
867
-                if(is_file($filename)){
867
+                if (is_file($filename)) {
868 868
                     clearstatcache();
869 869
                     $size = filesize($filename);
870 870
                     return $size;
@@ -897,10 +897,10 @@  discard block
 block discarded – undo
897 897
                 $this->opt = $cmd;
898 898
                 return $this->includeMdfFile('moduser');
899 899
             case 'userinfo':
900
-                if(empty($opt)) $this->opt = 'username';
900
+                if (empty($opt)) $this->opt = 'username';
901 901
                 return $this->includeMdfFile('moduser');
902 902
             case 'webuserinfo':
903
-                if(empty($opt)) $this->opt = 'username';
903
+                if (empty($opt)) $this->opt = 'username';
904 904
                 $this->value = -$value;
905 905
                 return $this->includeMdfFile('moduser');
906 906
             #####  Special functions
@@ -911,27 +911,27 @@  discard block
 block discarded – undo
911 911
             case 'ifnotempty':
912 912
                 if (!empty($value)) return $opt; break;
913 913
             case 'datagrid':
914
-                include_once(MODX_CORE_PATH . 'controls/datagrid.class.php');
914
+                include_once(MODX_CORE_PATH.'controls/datagrid.class.php');
915 915
                 $grd = new DataGrid(null, trim($value));
916 916
                 $grd->itemStyle = '';
917 917
                 $grd->altItemStyle = '';
918
-                $pos = strpos($value,"\n");
919
-                if($pos) $_ = substr($value,0,$pos);
918
+                $pos = strpos($value, "\n");
919
+                if ($pos) $_ = substr($value, 0, $pos);
920 920
                 else $_ = $pos;
921
-                $grd->cdelim = strpos($_,"\t")!==false ? 'tab' : ',';
921
+                $grd->cdelim = strpos($_, "\t") !== false ? 'tab' : ',';
922 922
                 return $grd->render();
923 923
             case 'rotate':
924 924
             case 'evenodd':
925
-                if(strpos($opt,',')===false) $opt = 'odd,even';
925
+                if (strpos($opt, ',') === false) $opt = 'odd,even';
926 926
                 $_ = explode(',', $opt);
927 927
                 $c = count($_);
928 928
                 $i = $value + $c;
929 929
                 $i = $i % $c;
930 930
                 return $_[$i];
931 931
             case 'takeval':
932
-                $arr = explode(",",$opt);
932
+                $arr = explode(",", $opt);
933 933
                 $idx = $value;
934
-                if(!is_numeric($idx)) return $value;
934
+                if (!is_numeric($idx)) return $value;
935 935
                 return $arr[$idx];
936 936
             case 'getimage':
937 937
                 return $this->includeMdfFile('getimage');
@@ -939,17 +939,17 @@  discard block
 block discarded – undo
939 939
                     return $modx->nicesize($value);
940 940
             case 'googlemap':
941 941
             case 'googlemaps':
942
-                if(empty($opt)) $opt = 'border:none;width:500px;height:350px;';
942
+                if (empty($opt)) $opt = 'border:none;width:500px;height:350px;';
943 943
                 $tpl = '<iframe style="[+style+]" src="https://maps.google.co.jp/maps?ll=[+value+]&output=embed&z=15"></iframe>';
944 944
                 $ph['style'] = $opt;
945 945
                 $ph['value'] = $value;
946
-                return $modx->parseText($tpl,$ph);
946
+                return $modx->parseText($tpl, $ph);
947 947
             case 'youtube':
948 948
             case 'youtube16x9':
949
-                if(empty($opt)) $opt = 560;
950
-                $h = round($opt*0.5625);
949
+                if (empty($opt)) $opt = 560;
950
+                $h = round($opt * 0.5625);
951 951
                 $tpl = '<iframe width="%s" height="%s" src="https://www.youtube.com/embed/%s" frameborder="0" allowfullscreen></iframe>';
952
-                return sprintf($tpl,$opt,$h,$value);
952
+                return sprintf($tpl, $opt, $h, $value);
953 953
             //case 'youtube4x3':%s*0.75+25
954 954
             case 'setvar':
955 955
                 $modx->placeholders[$opt] = $value;
@@ -979,7 +979,7 @@  discard block
 block discarded – undo
979 979
         return $value;
980 980
     }
981 981
 
982
-    public function includeMdfFile($cmd) {
982
+    public function includeMdfFile($cmd){
983 983
         global $modx;
984 984
         $key = $this->key;
985 985
         $value  = $this->value;
@@ -990,54 +990,54 @@  discard block
 block discarded – undo
990 990
     public function getValueFromElement($key, $value, $cmd, $opt)
991 991
     {
992 992
         global $modx;
993
-        if( isset($modx->snippetCache[$this->elmName]) )
993
+        if (isset($modx->snippetCache[$this->elmName]))
994 994
         {
995 995
             $php = $modx->snippetCache[$this->elmName];
996 996
         }
997 997
         else
998 998
         {
999 999
             $esc_elmName = $modx->db->escape($this->elmName);
1000
-            $result = $modx->db->select('snippet','[+prefix+]site_snippets',"name='{$esc_elmName}'");
1000
+            $result = $modx->db->select('snippet', '[+prefix+]site_snippets', "name='{$esc_elmName}'");
1001 1001
             $total = $modx->db->getRecordCount($result);
1002
-            if($total == 1)
1002
+            if ($total == 1)
1003 1003
             {
1004 1004
                 $row = $modx->db->getRow($result);
1005 1005
                 $php = $row['snippet'];
1006 1006
             }
1007
-            elseif($total == 0)
1007
+            elseif ($total == 0)
1008 1008
             {
1009 1009
                 $assets_path = MODX_BASE_PATH.'assets/';
1010
-                if(is_file($assets_path."modifiers/mdf_{$cmd}.inc.php"))
1010
+                if (is_file($assets_path."modifiers/mdf_{$cmd}.inc.php"))
1011 1011
                     $modifiers_path = $assets_path."modifiers/mdf_{$cmd}.inc.php";
1012
-                elseif(is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php"))
1012
+                elseif (is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php"))
1013 1013
                     $modifiers_path = $assets_path."plugins/phx/modifiers/{$cmd}.phx.php";
1014
-                elseif(is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php"))
1014
+                elseif (is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php"))
1015 1015
                     $modifiers_path = MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php";
1016 1016
                 else $modifiers_path = false;
1017 1017
 
1018
-                if($modifiers_path !== false) {
1018
+                if ($modifiers_path !== false) {
1019 1019
                     $php = @file_get_contents($modifiers_path);
1020 1020
                     $php = trim($php);
1021
-                    if(substr($php,0,5)==='<?php') $php = substr($php,6);
1022
-                    if(substr($php,0,2)==='<?')    $php = substr($php,3);
1023
-                    if(substr($php,-2)==='?>')     $php = substr($php,0,-2);
1024
-                    if($this->elmName!=='')
1021
+                    if (substr($php, 0, 5) === '<?php') $php = substr($php, 6);
1022
+                    if (substr($php, 0, 2) === '<?')    $php = substr($php, 3);
1023
+                    if (substr($php, -2) === '?>')     $php = substr($php, 0, -2);
1024
+                    if ($this->elmName !== '')
1025 1025
                         $modx->snippetCache[$this->elmName.'Props'] = '';
1026 1026
                 }
1027 1027
                 else
1028 1028
                     $php = false;
1029 1029
             }
1030 1030
             else $php = false;
1031
-            if($this->elmName!=='') $modx->snippetCache[$this->elmName]= $php;
1031
+            if ($this->elmName !== '') $modx->snippetCache[$this->elmName] = $php;
1032 1032
         }
1033
-        if($php==='') $php=false;
1033
+        if ($php === '') $php = false;
1034 1034
 
1035
-        if($php===false) $html = $modx->getChunk($this->elmName);
1035
+        if ($php === false) $html = $modx->getChunk($this->elmName);
1036 1036
         else             $html = false;
1037 1037
 
1038 1038
         $self = '[+output+]';
1039 1039
 
1040
-        if($php !== false)
1040
+        if ($php !== false)
1041 1041
         {
1042 1042
             ob_start();
1043 1043
             $options = $opt;
@@ -1050,71 +1050,71 @@  discard block
 block discarded – undo
1050 1050
             $this->vars['options'] = & $opt;
1051 1051
             $custom = eval($php);
1052 1052
             $msg = ob_get_contents();
1053
-            if($value===$this->bt) $value = $msg . $custom;
1053
+            if ($value === $this->bt) $value = $msg.$custom;
1054 1054
             ob_end_clean();
1055 1055
         }
1056
-        elseif($html!==false && isset($value) && $value!=='')
1056
+        elseif ($html !== false && isset($value) && $value !== '')
1057 1057
         {
1058
-            $html = str_replace(array($self,'[+value+]'), $value, $html);
1059
-            $value = str_replace(array('[+options+]','[+param+]'), $opt, $html);
1058
+            $html = str_replace(array($self, '[+value+]'), $value, $html);
1059
+            $value = str_replace(array('[+options+]', '[+param+]'), $opt, $html);
1060 1060
         }
1061 1061
         else return false;
1062 1062
 
1063
-        if($php===false && $html===false && $value!==''
1064
-           && (strpos($cmd,'[+value+]')!==false || strpos($cmd,$self)!==false))
1063
+        if ($php === false && $html === false && $value !== ''
1064
+           && (strpos($cmd, '[+value+]') !== false || strpos($cmd, $self) !== false))
1065 1065
         {
1066
-            $value = str_replace(array('[+value+]',$self),$value,$cmd);
1066
+            $value = str_replace(array('[+value+]', $self), $value, $cmd);
1067 1067
         }
1068 1068
         return $value;
1069 1069
     }
1070 1070
 
1071
-    public function parseDocumentSource($content='')
1071
+    public function parseDocumentSource($content = '')
1072 1072
     {
1073 1073
         global $modx;
1074 1074
 
1075
-        if(strpos($content,'[')===false && strpos($content,'{')===false) return $content;
1075
+        if (strpos($content, '[') === false && strpos($content, '{') === false) return $content;
1076 1076
 
1077
-        if(!$modx->maxParserPasses) $modx->maxParserPasses = 10;
1078
-        $bt='';
1079
-        $i=0;
1080
-        while($bt!==$content)
1077
+        if (!$modx->maxParserPasses) $modx->maxParserPasses = 10;
1078
+        $bt = '';
1079
+        $i = 0;
1080
+        while ($bt !== $content)
1081 1081
         {
1082 1082
             $bt = $content;
1083
-            if(strpos($content,'[*')!==false && $modx->documentIdentifier)
1083
+            if (strpos($content, '[*') !== false && $modx->documentIdentifier)
1084 1084
                                               $content = $modx->mergeDocumentContent($content);
1085
-            if(strpos($content,'[(')!==false) $content = $modx->mergeSettingsContent($content);
1086
-            if(strpos($content,'{{')!==false) $content = $modx->mergeChunkContent($content);
1087
-            if(strpos($content,'[!')!==false) $content = str_replace(array('[!','!]'),array('[[',']]'),$content);
1088
-            if(strpos($content,'[[')!==false) $content = $modx->evalSnippets($content);
1085
+            if (strpos($content, '[(') !== false) $content = $modx->mergeSettingsContent($content);
1086
+            if (strpos($content, '{{') !== false) $content = $modx->mergeChunkContent($content);
1087
+            if (strpos($content, '[!') !== false) $content = str_replace(array('[!', '!]'), array('[[', ']]'), $content);
1088
+            if (strpos($content, '[[') !== false) $content = $modx->evalSnippets($content);
1089 1089
 
1090
-            if($content===$bt)              break;
1091
-            if($modx->maxParserPasses < $i) break;
1090
+            if ($content === $bt)              break;
1091
+            if ($modx->maxParserPasses < $i) break;
1092 1092
             $i++;
1093 1093
         }
1094 1094
         return $content;
1095 1095
     }
1096 1096
 
1097
-    public function getDocumentObject($target='',$field='pagetitle')
1097
+    public function getDocumentObject($target = '', $field = 'pagetitle')
1098 1098
     {
1099 1099
         global $modx;
1100 1100
 
1101 1101
         $target = trim($target);
1102
-        if(empty($target)) $target = $modx->config['site_start'];
1103
-        if(preg_match('@^[1-9][0-9]*$@',$target)) $method='id';
1102
+        if (empty($target)) $target = $modx->config['site_start'];
1103
+        if (preg_match('@^[1-9][0-9]*$@', $target)) $method = 'id';
1104 1104
         else $method = 'alias';
1105 1105
 
1106
-        if(!isset($this->documentObject[$target]))
1106
+        if (!isset($this->documentObject[$target]))
1107 1107
         {
1108
-            $this->documentObject[$target] = $modx->getDocumentObject($method,$target,'direct');
1108
+            $this->documentObject[$target] = $modx->getDocumentObject($method, $target, 'direct');
1109 1109
         }
1110 1110
 
1111
-        if($this->documentObject[$target]['publishedon']==='0')
1111
+        if ($this->documentObject[$target]['publishedon'] === '0')
1112 1112
             return '';
1113
-        elseif(isset($this->documentObject[$target][$field]))
1113
+        elseif (isset($this->documentObject[$target][$field]))
1114 1114
         {
1115
-            if(is_array($this->documentObject[$target][$field]))
1115
+            if (is_array($this->documentObject[$target][$field]))
1116 1116
             {
1117
-                $a = $modx->getTemplateVarOutput($field,$target);
1117
+                $a = $modx->getTemplateVarOutput($field, $target);
1118 1118
                 $this->documentObject[$target][$field] = $a[$field];
1119 1119
             }
1120 1120
         }
@@ -1123,8 +1123,8 @@  discard block
 block discarded – undo
1123 1123
         return $this->documentObject[$target][$field];
1124 1124
     }
1125 1125
 
1126
-    public function setPlaceholders($value = '', $key = '', $path = '') {
1127
-        if($path!=='') $key = "{$path}.{$key}";
1126
+    public function setPlaceholders($value = '', $key = '', $path = ''){
1127
+        if ($path !== '') $key = "{$path}.{$key}";
1128 1128
         if (is_array($value)) {
1129 1129
             foreach ($value as $subkey => $subval) {
1130 1130
                 $this->setPlaceholders($subval, $subkey, $key);
@@ -1134,77 +1134,77 @@  discard block
 block discarded – undo
1134 1134
     }
1135 1135
 
1136 1136
     // Sets a placeholder variable which can only be access by Modifiers
1137
-    public function setModifiersVariable($key, $value) {
1137
+    public function setModifiersVariable($key, $value){
1138 1138
         if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1139 1139
     }
1140 1140
 
1141 1141
     //mbstring
1142
-    public function substr($str, $s, $l = null) {
1142
+    public function substr($str, $s, $l = null){
1143 1143
         global $modx;
1144
-        if(is_null($l)) $l = $this->strlen($str);
1144
+        if (is_null($l)) $l = $this->strlen($str);
1145 1145
         if (function_exists('mb_substr'))
1146 1146
         {
1147
-            if(strpos($str,"\r")!==false)
1148
-                $str = str_replace(array("\r\n","\r"), "\n", $str);
1147
+            if (strpos($str, "\r") !== false)
1148
+                $str = str_replace(array("\r\n", "\r"), "\n", $str);
1149 1149
             return mb_substr($str, $s, $l, $modx->config['modx_charset']);
1150 1150
         }
1151 1151
         return substr($str, $s, $l);
1152 1152
     }
1153
-    public function strpos($haystack,$needle,$offset=0) {
1153
+    public function strpos($haystack, $needle, $offset = 0){
1154 1154
         global $modx;
1155
-        if (function_exists('mb_strpos')) return mb_strpos($haystack,$needle,$offset,$modx->config['modx_charset']);
1156
-        return strpos($haystack,$needle,$offset);
1155
+        if (function_exists('mb_strpos')) return mb_strpos($haystack, $needle, $offset, $modx->config['modx_charset']);
1156
+        return strpos($haystack, $needle, $offset);
1157 1157
     }
1158
-    public function strlen($str) {
1158
+    public function strlen($str){
1159 1159
         global $modx;
1160
-        if (function_exists('mb_strlen')) return mb_strlen(str_replace("\r\n", "\n", $str),$modx->config['modx_charset']);
1160
+        if (function_exists('mb_strlen')) return mb_strlen(str_replace("\r\n", "\n", $str), $modx->config['modx_charset']);
1161 1161
         return strlen($str);
1162 1162
     }
1163
-    public function strtolower($str) {
1163
+    public function strtolower($str){
1164 1164
         if (function_exists('mb_strtolower')) return mb_strtolower($str);
1165 1165
         return strtolower($str);
1166 1166
     }
1167
-    public function strtoupper($str) {
1167
+    public function strtoupper($str){
1168 1168
         if (function_exists('mb_strtoupper')) return mb_strtoupper($str);
1169 1169
         return strtoupper($str);
1170 1170
     }
1171
-    public function ucfirst($str) {
1171
+    public function ucfirst($str){
1172 1172
         if (function_exists('mb_strtoupper'))
1173 1173
             return mb_strtoupper($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1174 1174
         return ucfirst($str);
1175 1175
     }
1176
-    public function lcfirst($str) {
1176
+    public function lcfirst($str){
1177 1177
         if (function_exists('mb_strtolower'))
1178 1178
             return mb_strtolower($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1179 1179
         return lcfirst($str);
1180 1180
     }
1181
-    public function ucwords($str) {
1181
+    public function ucwords($str){
1182 1182
         if (function_exists('mb_convert_case'))
1183 1183
             return mb_convert_case($str, MB_CASE_TITLE);
1184 1184
         return ucwords($str);
1185 1185
     }
1186
-    public function strrev($str) {
1186
+    public function strrev($str){
1187 1187
         preg_match_all('/./us', $str, $ar);
1188 1188
         return implode(array_reverse($ar[0]));
1189 1189
     }
1190
-    public function str_shuffle($str) {
1190
+    public function str_shuffle($str){
1191 1191
         preg_match_all('/./us', $str, $ar);
1192 1192
         shuffle($ar[0]);
1193 1193
         return implode($ar[0]);
1194 1194
     }
1195
-    public function str_word_count($str) {
1196
-        return count(preg_split('~[^\p{L}\p{N}\']+~u',$str));
1195
+    public function str_word_count($str){
1196
+        return count(preg_split('~[^\p{L}\p{N}\']+~u', $str));
1197 1197
     }
1198
-    public function strip_tags($value,$params='') {
1198
+    public function strip_tags($value, $params = ''){
1199 1199
         global $modx;
1200 1200
 
1201
-        if(stripos($params,'style')===false && stripos($value,'</style>')!==false) {
1201
+        if (stripos($params, 'style') === false && stripos($value, '</style>') !== false) {
1202 1202
             $value = preg_replace('@<style.*?>.*?</style>@is', '', $value);
1203 1203
         }
1204
-        if(stripos($params,'script')===false && stripos($value,'</script>')!==false) {
1204
+        if (stripos($params, 'script') === false && stripos($value, '</script>') !== false) {
1205 1205
             $value = preg_replace('@<script.*?>.*?</script>@is', '', $value);
1206 1206
         }
1207 1207
 
1208
-        return trim(strip_tags($value,$params));
1208
+        return trim(strip_tags($value, $params));
1209 1209
     }
1210 1210
 }
Please login to merge, or discard this patch.
Braces   +544 added lines, -282 removed lines patch added patch discarded remove patch
@@ -1,8 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('MODX_CORE_PATH')) define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
3
+if(!defined('MODX_CORE_PATH')) {
4
+    define('MODX_CORE_PATH', MODX_MANAGER_PATH.'includes/');
5
+}
4 6
 
5
-class MODIFIERS {
7
+class MODIFIERS
8
+{
6 9
     /**
7 10
      * @var array
8 11
      */
@@ -61,7 +64,9 @@  discard block
 block discarded – undo
61 64
     {
62 65
         global $modx;
63 66
 
64
-        if (function_exists('mb_internal_encoding')) mb_internal_encoding($modx->config['modx_charset']);
67
+        if (function_exists('mb_internal_encoding')) {
68
+            mb_internal_encoding($modx->config['modx_charset']);
69
+        }
65 70
         $this->condModifiers = '=,is,eq,equals,ne,neq,notequals,isnot,isnt,not,%,isempty,isnotempty,isntempty,>=,gte,eg,gte,greaterthan,>,gt,isgreaterthan,isgt,lowerthan,<,lt,<=,lte,islte,islowerthan,islt,el,find,in,inarray,in_array,fnmatch,wcard,wcard_match,wildcard,wildcard_match,is_file,is_dir,file_exists,is_readable,is_writable,is_image,regex,preg,preg_match,memberof,mo,isinrole,ir';
66 71
     }
67 72
 
@@ -74,7 +79,9 @@  discard block
 block discarded – undo
74 79
     public function phxFilter($key,$value,$modifiers)
75 80
     {
76 81
         global $modx;
77
-        if(substr($modifiers,0,3)!=='id(') $value = $this->parseDocumentSource($value);
82
+        if(substr($modifiers,0,3)!=='id(') {
83
+            $value = $this->parseDocumentSource($value);
84
+        }
78 85
         $this->srcValue = $value;
79 86
         $modifiers = trim($modifiers);
80 87
         $modifiers = ':'.trim($modifiers,':');
@@ -97,13 +104,18 @@  discard block
 block discarded – undo
97 104
      * @param string $modifiers
98 105
      * @return bool|string
99 106
      */
100
-    public function _getDelim($mode,$modifiers) {
107
+    public function _getDelim($mode,$modifiers)
108
+    {
101 109
         $c = substr($modifiers,0,1);
102
-        if(!in_array($c, array('"', "'", '`')) ) return false;
110
+        if(!in_array($c, array('"', "'", '`')) ) {
111
+            return false;
112
+        }
103 113
 
104 114
         $modifiers = substr($modifiers,1);
105 115
         $closure = $mode=='(' ? "{$c})" : $c;
106
-        if(strpos($modifiers, $closure)===false) return false;
116
+        if(strpos($modifiers, $closure)===false) {
117
+            return false;
118
+        }
107 119
 
108 120
         return  $c;
109 121
     }
@@ -114,52 +126,65 @@  discard block
 block discarded – undo
114 126
      * @param string $modifiers
115 127
      * @return bool|string
116 128
      */
117
-    public function _getOpt($mode,$delim,$modifiers) {
129
+    public function _getOpt($mode,$delim,$modifiers)
130
+    {
118 131
         if($delim) {
119
-            if($mode=='(') return substr($modifiers,1,strpos($modifiers, $delim . ')' )-1);
132
+            if($mode=='(') {
133
+                return substr($modifiers,1,strpos($modifiers, $delim . ')' )-1);
134
+            }
120 135
 
121 136
             return substr($modifiers,1,strpos($modifiers,$delim,1)-1);
122
-        }
123
-        else {
124
-            if($mode=='(') return substr($modifiers,0,strpos($modifiers, ')') );
137
+        } else {
138
+            if($mode=='(') {
139
+                return substr($modifiers,0,strpos($modifiers, ')') );
140
+            }
125 141
 
126 142
             $chars = str_split($modifiers);
127 143
             $opt='';
128 144
             foreach($chars as $c) {
129
-                if($c==':' || $c==')') break;
145
+                if($c==':' || $c==')') {
146
+                    break;
147
+                }
130 148
                 $opt .=$c;
131 149
             }
132 150
             return $opt;
133 151
         }
134 152
     }
135
-    public function _getRemainModifiers($mode,$delim,$modifiers) {
153
+    public function _getRemainModifiers($mode,$delim,$modifiers)
154
+    {
136 155
         if($delim) {
137
-            if($mode=='(')
138
-                return $this->_fetchContent($modifiers, $delim . ')');
139
-            else {
156
+            if($mode=='(') {
157
+                            return $this->_fetchContent($modifiers, $delim . ')');
158
+            } else {
140 159
                 $modifiers = trim($modifiers);
141 160
                 $modifiers = substr($modifiers,1);
142 161
                 return $this->_fetchContent($modifiers, $delim);
143 162
             }
144
-        }
145
-        else {
146
-            if($mode=='(') return $this->_fetchContent($modifiers, ')');
163
+        } else {
164
+            if($mode=='(') {
165
+                return $this->_fetchContent($modifiers, ')');
166
+            }
147 167
             $chars = str_split($modifiers);
148 168
             foreach($chars as $c) {
149
-                if($c==':') return $modifiers;
150
-                else $modifiers = substr($modifiers,1);
169
+                if($c==':') {
170
+                    return $modifiers;
171
+                } else {
172
+                    $modifiers = substr($modifiers,1);
173
+                }
151 174
             }
152 175
             return $modifiers;
153 176
         }
154 177
     }
155 178
 
156
-    public function _fetchContent($string,$delim) {
179
+    public function _fetchContent($string,$delim)
180
+    {
157 181
         $len = strlen($delim);
158 182
         $string = $this->parseDocumentSource($string);
159 183
         return substr($string,strpos($string, $delim)+$len);
160 184
     }
161 185
 
162
-    public function splitEachModifiers($modifiers) {
186
+    public function splitEachModifiers($modifiers)
187
+    {
163 188
         global $modx;
164 189
 
165 190
         $cmd = '';
@@ -170,11 +195,15 @@  discard block
 block discarded – undo
170 195
             $c = substr($modifiers,0,1);
171 196
             $modifiers = substr($modifiers,1);
172 197
 
173
-            if($c===':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) { // :=, :!=, :<=, :>=, :!<=, :!>=
198
+            if($c===':' && preg_match('@^(!?[<>=]{1,2})@', $modifiers, $match)) {
199
+// :=, :!=, :<=, :>=, :!<=, :!>=
174 200
                 $c = substr($modifiers,strlen($match[1]),1);
175 201
                 $debuginfo = "#i=0 #c=[{$c}] #m=[{$modifiers}]";
176
-                if($c==='(') $modifiers = substr($modifiers,strlen($match[1])+1);
177
-                else         $modifiers = substr($modifiers,strlen($match[1]));
202
+                if($c==='(') {
203
+                    $modifiers = substr($modifiers,strlen($match[1])+1);
204
+                } else {
205
+                    $modifiers = substr($modifiers,strlen($match[1]));
206
+                }
178 207
 
179 208
                 $delim     = $this->_getDelim($c,$modifiers);
180 209
                 $opt       = $this->_getOpt($c,$delim,$modifiers);
@@ -182,13 +211,12 @@  discard block
 block discarded – undo
182 211
 
183 212
                 $result[]=array('cmd'=>trim($match[1]),'opt'=>$opt,'debuginfo'=>$debuginfo);
184 213
                 $cmd = '';
185
-            }
186
-            elseif(in_array($c,array('+','-','*','/')) && preg_match('@^[0-9]+@', $modifiers, $match)) { // :+3, :-3, :*3 ...
214
+            } elseif(in_array($c,array('+','-','*','/')) && preg_match('@^[0-9]+@', $modifiers, $match)) {
215
+// :+3, :-3, :*3 ...
187 216
                 $modifiers = substr($modifiers,strlen($match[0]));
188 217
                 $result[]=array('cmd'=>'math','opt'=>'%s'.$c.$match[0]);
189 218
                 $cmd = '';
190
-            }
191
-            elseif($c==='(' || $c==='=') {
219
+            } elseif($c==='(' || $c==='=') {
192 220
                 $modifiers = $m1 = trim($modifiers);
193 221
                 $delim     = $this->_getDelim($c,$modifiers);
194 222
                 $opt       = $this->_getOpt($c,$delim,$modifiers);
@@ -198,29 +226,29 @@  discard block
 block discarded – undo
198 226
                 $result[]=array('cmd'=>trim($cmd),'opt'=>$opt,'debuginfo'=>$debuginfo);
199 227
 
200 228
                 $cmd = '';
201
-            }
202
-            elseif($c==':') {
229
+            } elseif($c==':') {
203 230
                 $debuginfo = "#i=2 #c=[{$c}] #m=[{$modifiers}]";
204
-                if($cmd!=='') $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
231
+                if($cmd!=='') {
232
+                    $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
233
+                }
205 234
 
206 235
                 $cmd = '';
207
-            }
208
-            elseif(trim($modifiers)=='' && trim($cmd)!=='') {
236
+            } elseif(trim($modifiers)=='' && trim($cmd)!=='') {
209 237
                 $debuginfo = "#i=3 #c=[{$c}] #m=[{$modifiers}]";
210 238
                 $cmd .= $c;
211 239
                 $result[]=array('cmd'=>trim($cmd),'opt'=>'','debuginfo'=>$debuginfo);
212 240
 
213 241
                 break;
214
-            }
215
-            else {
242
+            } else {
216 243
                 $cmd .= $c;
217 244
             }
218 245
         }
219 246
 
220
-        if(empty($result)) return array();
247
+        if(empty($result)) {
248
+            return array();
249
+        }
221 250
 
222
-        foreach($result as $i=>$a)
223
-        {
251
+        foreach($result as $i=>$a) {
224 252
             $a['opt'] = $this->parseDocumentSource($a['opt']);
225 253
             $result[$i]['opt'] = $modx->mergePlaceholderContent($a['opt'],$this->placeholders);
226 254
         }
@@ -233,22 +261,23 @@  discard block
 block discarded – undo
233 261
         global $modx;
234 262
         $lastKey = '';
235 263
         $cacheKey = md5(sprintf('parsePhx#%s#%s#%s',$key,$value,print_r($modifiers,true)));
236
-        if(isset($this->tmpCache[$cacheKey])) return $this->tmpCache[$cacheKey];
237
-        if(empty($modifiers)) return '';
264
+        if(isset($this->tmpCache[$cacheKey])) {
265
+            return $this->tmpCache[$cacheKey];
266
+        }
267
+        if(empty($modifiers)) {
268
+            return '';
269
+        }
238 270
 
239
-        foreach($modifiers as $m)
240
-        {
271
+        foreach($modifiers as $m) {
241 272
             $lastKey = strtolower($m['cmd']);
242 273
         }
243 274
         $_ = explode(',',$this->condModifiers);
244
-        if(in_array($lastKey,$_))
245
-        {
275
+        if(in_array($lastKey,$_)) {
246 276
             $modifiers[] = array('cmd'=>'then','opt'=>'1');
247 277
             $modifiers[] = array('cmd'=>'else','opt'=>'0');
248 278
         }
249 279
 
250
-        foreach($modifiers as $i=>$a)
251
-        {
280
+        foreach($modifiers as $i=>$a) {
252 281
             $value = $this->Filter($key,$value, $a['cmd'], $a['opt']);
253 282
         }
254 283
         $this->tmpCache[$cacheKey] = $value;
@@ -260,25 +289,32 @@  discard block
 block discarded – undo
260 289
     {
261 290
         global $modx;
262 291
 
263
-        if($key==='documentObject') $value = $modx->documentIdentifier;
292
+        if($key==='documentObject') {
293
+            $value = $modx->documentIdentifier;
294
+        }
264 295
         $cmd = $this->parseDocumentSource($cmd);
265
-        if(preg_match('@^[1-9][/0-9]*$@',$cmd))
266
-        {
267
-            if(strpos($cmd,'/')!==false)
268
-                $cmd = $this->substr($cmd,strrpos($cmd,'/')+1);
296
+        if(preg_match('@^[1-9][/0-9]*$@',$cmd)) {
297
+            if(strpos($cmd,'/')!==false) {
298
+                            $cmd = $this->substr($cmd,strrpos($cmd,'/')+1);
299
+            }
269 300
             $opt = $cmd;
270 301
             $cmd = 'id';
271 302
         }
272 303
 
273
-        if(isset($modx->snippetCache["phx:{$cmd}"]))   $this->elmName = "phx:{$cmd}";
274
-        elseif(isset($modx->chunkCache["phx:{$cmd}"])) $this->elmName = "phx:{$cmd}";
275
-        else                                           $this->elmName = '';
304
+        if(isset($modx->snippetCache["phx:{$cmd}"])) {
305
+            $this->elmName = "phx:{$cmd}";
306
+        } elseif(isset($modx->chunkCache["phx:{$cmd}"])) {
307
+            $this->elmName = "phx:{$cmd}";
308
+        } else {
309
+            $this->elmName = '';
310
+        }
276 311
 
277 312
         $cmd = strtolower($cmd);
278
-        if($this->elmName!=='')
279
-            $value = $this->getValueFromElement($key, $value, $cmd, $opt);
280
-        else
281
-            $value = $this->getValueFromPreset($key, $value, $cmd, $opt);
313
+        if($this->elmName!=='') {
314
+                    $value = $this->getValueFromElement($key, $value, $cmd, $opt);
315
+        } else {
316
+                    $value = $this->getValueFromPreset($key, $value, $cmd, $opt);
317
+        }
282 318
 
283 319
         $value = str_replace('[+key+]', $key, $value);
284 320
 
@@ -287,29 +323,37 @@  discard block
 block discarded – undo
287 323
 
288 324
     public function isEmpty($cmd,$value)
289 325
     {
290
-        if($value!=='') return false;
326
+        if($value!=='') {
327
+            return false;
328
+        }
291 329
 
292 330
         $_ = explode(',', $this->condModifiers . ',_default,default,if,input,or,and,show,this,select,switch,then,else,id,ifempty,smart_desc,smart_description,summary');
293
-        if(in_array($cmd,$_)) return false;
294
-        else                  return true;
331
+        if(in_array($cmd,$_)) {
332
+            return false;
333
+        } else {
334
+            return true;
335
+        }
295 336
     }
296 337
 
297 338
     public function getValueFromPreset($key, $value, $cmd, $opt)
298 339
     {
299 340
         global $modx;
300 341
 
301
-        if($this->isEmpty($cmd,$value)) return '';
342
+        if($this->isEmpty($cmd,$value)) {
343
+            return '';
344
+        }
302 345
 
303 346
         $this->key = $key;
304 347
         $this->value  = $value;
305 348
         $this->opt    = $opt;
306 349
 
307
-        switch ($cmd)
308
-        {
350
+        switch ($cmd) {
309 351
             #####  Conditional Modifiers
310 352
             case 'input':
311 353
             case 'if':
312
-                if(!$opt) return $value;
354
+                if(!$opt) {
355
+                    return $value;
356
+                }
313 357
                 return $opt;
314 358
             case '=':
315 359
             case 'eq':
@@ -370,14 +414,24 @@  discard block
 block discarded – undo
370 414
             case 'file_exists':
371 415
             case 'is_readable':
372 416
             case 'is_writable':
373
-                if(!$opt) $path = $value;
374
-                else      $path = $opt;
375
-                if(strpos($path,MODX_MANAGER_PATH)!==false) exit('Can not read core path');
376
-                if(strpos($path,$modx->config['base_path'])===false) $path = ltrim($path,'/');
417
+                if(!$opt) {
418
+                    $path = $value;
419
+                } else {
420
+                    $path = $opt;
421
+                }
422
+                if(strpos($path,MODX_MANAGER_PATH)!==false) {
423
+                    exit('Can not read core path');
424
+                }
425
+                if(strpos($path,$modx->config['base_path'])===false) {
426
+                    $path = ltrim($path,'/');
427
+                }
377 428
                 $this->condition[] = (int)($cmd($path)!==false);break;
378 429
             case 'is_image':
379
-                if(!$opt) $path = $value;
380
-                else      $path = $opt;
430
+                if(!$opt) {
431
+                    $path = $value;
432
+                } else {
433
+                    $path = $opt;
434
+                }
381 435
                 if(!is_file($path)) {$this->condition[]='0';break;}
382 436
                 $_ = getimagesize($path);
383 437
                 $this->condition[] = (int)($_[0]);break;
@@ -400,17 +454,23 @@  discard block
 block discarded – undo
400 454
             case 'this':
401 455
                 $conditional = implode(' ',$this->condition);
402 456
                 $isvalid = (int)(eval("return ({$conditional});"));
403
-                if ($isvalid) return $this->srcValue;
457
+                if ($isvalid) {
458
+                    return $this->srcValue;
459
+                }
404 460
                 return NULL;
405 461
             case 'then':
406 462
                 $conditional = implode(' ',$this->condition);
407 463
                 $isvalid = (int)eval("return ({$conditional});");
408
-                if ($isvalid)  return $opt;
464
+                if ($isvalid) {
465
+                    return $opt;
466
+                }
409 467
                 return null;
410 468
             case 'else':
411 469
                 $conditional = implode(' ',$this->condition);
412 470
                 $isvalid = (int)eval("return ({$conditional});");
413
-                if (!$isvalid) return $opt;
471
+                if (!$isvalid) {
472
+                    return $opt;
473
+                }
414 474
                 break;
415 475
             case 'select':
416 476
             case 'switch':
@@ -421,8 +481,11 @@  discard block
 block discarded – undo
421 481
                     $mi = explode('=',$raw[$m],2);
422 482
                     $map[$mi[0]] = $mi[1];
423 483
                 }
424
-                if(isset($map[$value])) return $map[$value];
425
-                else                    return '';
484
+                if(isset($map[$value])) {
485
+                    return $map[$value];
486
+                } else {
487
+                    return '';
488
+                }
426 489
             ##### End of Conditional Modifiers
427 490
 
428 491
             #####  Encode / Decode / Hash / Escape
@@ -448,24 +511,25 @@  discard block
 block discarded – undo
448 511
             case 'spam_protect':
449 512
                 return str_replace(array('@','.'),array('&#64;','&#46;'),$value);
450 513
             case 'strip':
451
-                if($opt==='') $opt = ' ';
514
+                if($opt==='') {
515
+                    $opt = ' ';
516
+                }
452 517
                 return preg_replace('/[\n\r\t\s]+/', $opt, $value);
453 518
             case 'strip_linefeeds':
454 519
                 return str_replace(array("\n","\r"), '', $value);
455 520
             case 'notags':
456 521
             case 'strip_tags':
457 522
             case 'remove_html':
458
-                if($opt!=='')
459
-                {
523
+                if($opt!=='') {
460 524
                     $param = array();
461
-                    foreach(explode(',',$opt) as $v)
462
-                    {
525
+                    foreach(explode(',',$opt) as $v) {
463 526
                         $v = trim($v,'</> ');
464 527
                         $param[] = "<{$v}>";
465 528
                     }
466 529
                     $params = implode(',',$param);
530
+                } else {
531
+                    $params = '';
467 532
                 }
468
-                else $params = '';
469 533
                 if(!strpos($params,'<br>')===false) {
470 534
                     $value = preg_replace('@(<br[ /]*>)\n@','$1',$value);
471 535
                     $value = preg_replace('@<br[ /]*>@',"\n",$value);
@@ -476,8 +540,11 @@  discard block
 block discarded – undo
476 540
             case 'encode_url':
477 541
                 return urlencode($value);
478 542
             case 'base64_decode':
479
-                if($opt!=='false') $opt = true;
480
-                else               $opt = false;
543
+                if($opt!=='false') {
544
+                    $opt = true;
545
+                } else {
546
+                    $opt = false;
547
+                }
481 548
                 return base64_decode($value,$opt);
482 549
             case 'encode_sha1': $cmd = 'sha1';
483 550
             case 'addslashes':
@@ -503,16 +570,19 @@  discard block
 block discarded – undo
503 570
                 return $this->strtoupper($value);
504 571
             case 'capitalize':
505 572
                 $_ = explode(' ',$value);
506
-                foreach($_ as $i=>$v)
507
-                {
573
+                foreach($_ as $i=>$v) {
508 574
                     $_[$i] = ucfirst($v);
509 575
                 }
510 576
                 return implode(' ',$_);
511 577
             case 'zenhan':
512
-                if(empty($opt)) $opt='VKas';
578
+                if(empty($opt)) {
579
+                    $opt='VKas';
580
+                }
513 581
                 return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
514 582
             case 'hanzen':
515
-                if(empty($opt)) $opt='VKAS';
583
+                if(empty($opt)) {
584
+                    $opt='VKAS';
585
+                }
516 586
                 return mb_convert_kana($value,$opt,$modx->config['modx_charset']);
517 587
             case 'str_shuffle':
518 588
             case 'shuffle':
@@ -537,13 +607,18 @@  discard block
 block discarded – undo
537 607
                 $value = preg_replace('/\r/', '', $value);
538 608
                 return count(preg_split('/\n+/',$value));
539 609
             case 'strpos':
540
-                if($opt!=0&&empty($opt)) return $value;
610
+                if($opt!=0&&empty($opt)) {
611
+                    return $value;
612
+                }
541 613
                 return $this->strpos($value,$opt);
542 614
             case 'wordwrap':
543 615
                 // default: 70
544 616
                   $wrapat = (int)$opt > 0 ? (int)$opt : 70;
545
-                if (version_compare(PHP_VERSION, '5.3.0') >= 0) return $this->includeMdfFile('wordwrap');
546
-                else return preg_replace("@(\b\w+\b)@e","wordwrap('\\1',\$wrapat,' ',1)",$value);
617
+                if (version_compare(PHP_VERSION, '5.3.0') >= 0) {
618
+                    return $this->includeMdfFile('wordwrap');
619
+                } else {
620
+                    return preg_replace("@(\b\w+\b)@e","wordwrap('\\1',\$wrapat,' ',1)",$value);
621
+                }
547 622
             case 'wrap_text':
548 623
                 $width = preg_match('/^[1-9][0-9]*$/',$opt) ? $opt : 70;
549 624
                 if($modx->config['manager_language']==='japanese-utf8') {
@@ -559,30 +634,36 @@  discard block
 block discarded – undo
559 634
                         $value = $this->substr($value,$width);
560 635
                     }
561 636
                     return implode("\n",$chunk);
637
+                } else {
638
+                                    return wordwrap($value,$width,"\n",true);
562 639
                 }
563
-                else
564
-                    return wordwrap($value,$width,"\n",true);
565 640
             case 'substr':
566
-                if(empty($opt)) break;
641
+                if(empty($opt)) {
642
+                    break;
643
+                }
567 644
                 if(strpos($opt,',')!==false) {
568 645
                     list($b,$e) = explode(',',$opt,2);
569 646
                     return $this->substr($value,$b,(int)$e);
647
+                } else {
648
+                    return $this->substr($value,$opt);
570 649
                 }
571
-                else return $this->substr($value,$opt);
572 650
             case 'limit':
573 651
             case 'trim_to': // http://www.movabletype.jp/documentation/appendices/modifiers/trim_to.html
574
-                if(strpos($opt,'+')!==false)
575
-                    list($len,$str) = explode('+',$opt,2);
576
-                else {
652
+                if(strpos($opt,'+')!==false) {
653
+                                    list($len,$str) = explode('+',$opt,2);
654
+                } else {
577 655
                     $len = $opt;
578 656
                     $str = '';
579 657
                 }
580
-                if($len==='') $len = 100;
581
-                if(abs($len) > $this->strlen($value)) $str ='';
658
+                if($len==='') {
659
+                    $len = 100;
660
+                }
661
+                if(abs($len) > $this->strlen($value)) {
662
+                    $str ='';
663
+                }
582 664
                 if(preg_match('/^[1-9][0-9]*$/',$len)) {
583 665
                     return $this->substr($value,0,$len) . $str;
584
-                }
585
-                elseif(preg_match('/^\-[1-9][0-9]*$/',$len)) {
666
+                } elseif(preg_match('/^\-[1-9][0-9]*$/',$len)) {
586 667
                     return $str . $this->substr($value,$len);
587 668
                 }
588 669
                 break;
@@ -592,18 +673,30 @@  discard block
 block discarded – undo
592 673
                 return $this->includeMdfFile('summary');
593 674
             case 'replace':
594 675
             case 'str_replace':
595
-                if(empty($opt) || strpos($opt,',')===false) break;
596
-                if    (substr_count($opt, ',') ==1) $delim = ',';
597
-                elseif(substr_count($opt, '|') ==1) $delim = '|';
598
-                elseif(substr_count($opt, '=>')==1) $delim = '=>';
599
-                elseif(substr_count($opt, '/') ==1) $delim = '/';
600
-                else break;
676
+                if(empty($opt) || strpos($opt,',')===false) {
677
+                    break;
678
+                }
679
+                if    (substr_count($opt, ',') ==1) {
680
+                    $delim = ',';
681
+                } elseif(substr_count($opt, '|') ==1) {
682
+                    $delim = '|';
683
+                } elseif(substr_count($opt, '=>')==1) {
684
+                    $delim = '=>';
685
+                } elseif(substr_count($opt, '/') ==1) {
686
+                    $delim = '/';
687
+                } else {
688
+                    break;
689
+                }
601 690
                 list($s,$r) = explode($delim,$opt);
602
-                if($value!=='') return str_replace($s,$r,$value);
691
+                if($value!=='') {
692
+                    return str_replace($s,$r,$value);
693
+                }
603 694
                 break;
604 695
             case 'replace_to':
605 696
             case 'tpl':
606
-                if($value!=='') return str_replace(array('[+value+]','[+output+]','{value}','%s'),$value,$opt);
697
+                if($value!=='') {
698
+                    return str_replace(array('[+value+]','[+output+]','{value}','%s'),$value,$opt);
699
+                }
607 700
                 break;
608 701
             case 'eachtpl':
609 702
                 $value = explode('||',$value);
@@ -614,59 +707,83 @@  discard block
 block discarded – undo
614 707
                 return implode("\n", $_);
615 708
             case 'array_pop':
616 709
             case 'array_shift':
617
-                if(strpos($value,'||')!==false) $delim = '||';
618
-                else                            $delim = ',';
710
+                if(strpos($value,'||')!==false) {
711
+                    $delim = '||';
712
+                } else {
713
+                    $delim = ',';
714
+                }
619 715
                 return $cmd(explode($delim,$value));
620 716
             case 'preg_replace':
621 717
             case 'regex_replace':
622
-                if(empty($opt) || strpos($opt,',')===false) break;
718
+                if(empty($opt) || strpos($opt,',')===false) {
719
+                    break;
720
+                }
623 721
                 list($s,$r) = explode(',',$opt,2);
624
-                if($value!=='') return preg_replace($s,$r,$value);
722
+                if($value!=='') {
723
+                    return preg_replace($s,$r,$value);
724
+                }
625 725
                 break;
626 726
             case 'cat':
627 727
             case 'concatenate':
628 728
             case '.':
629
-                if($value!=='') return $value . $opt;
729
+                if($value!=='') {
730
+                    return $value . $opt;
731
+                }
630 732
                 break;
631 733
             case 'sprintf':
632 734
             case 'string_format':
633
-                if($value!=='') return sprintf($opt,$value);
735
+                if($value!=='') {
736
+                    return sprintf($opt,$value);
737
+                }
634 738
                 break;
635 739
             case 'number_format':
636
-                    if($opt=='') $opt = 0;
740
+                    if($opt=='') {
741
+                        $opt = 0;
742
+                    }
637 743
                     return number_format($value,$opt);
638 744
             case 'money_format':
639 745
                     setlocale(LC_MONETARY,setlocale(LC_TIME,0));
640
-                    if($value!=='') return money_format($opt,(double)$value);
746
+                    if($value!=='') {
747
+                        return money_format($opt,(double)$value);
748
+                    }
641 749
                     break;
642 750
             case 'tobool':
643 751
                 return boolval($value);
644 752
             case 'nl2lf':
645
-                if($value!=='') return str_replace(array("\r\n","\n", "\r"), '\n', $value);
753
+                if($value!=='') {
754
+                    return str_replace(array("\r\n","\n", "\r"), '\n', $value);
755
+                }
646 756
                 break;
647 757
             case 'br2nl':
648 758
                 return preg_replace('@<br[\s/]*>@i', "\n", $value);
649 759
             case 'nl2br':
650
-                if (version_compare(PHP_VERSION, '5.3.0', '<'))
651
-                    return nl2br($value);
652
-                if($opt!=='')
653
-                {
760
+                if (version_compare(PHP_VERSION, '5.3.0', '<')) {
761
+                                    return nl2br($value);
762
+                }
763
+                if($opt!=='') {
654 764
                     $opt = trim($opt);
655 765
                     $opt = strtolower($opt);
656
-                    if($opt==='false') $opt = false;
657
-                    elseif($opt==='0') $opt = false;
658
-                    else               $opt = true;
766
+                    if($opt==='false') {
767
+                        $opt = false;
768
+                    } elseif($opt==='0') {
769
+                        $opt = false;
770
+                    } else {
771
+                        $opt = true;
772
+                    }
773
+                } elseif(isset($modx->config['mce_element_format'])&&$modx->config['mce_element_format']==='html') {
774
+                                                       $opt = false;
775
+                } else {
776
+                    $opt = true;
659 777
                 }
660
-                elseif(isset($modx->config['mce_element_format'])&&$modx->config['mce_element_format']==='html')
661
-                                       $opt = false;
662
-                else                   $opt = true;
663 778
                 return nl2br($value,$opt);
664 779
             case 'ltrim':
665 780
             case 'rtrim':
666 781
             case 'trim': // ref http://mblo.info/modifiers/custom-modifiers/rtrim_opt.html
667
-                if($opt==='')
668
-                    return $cmd($value);
669
-                else return $cmd($value,$opt);
782
+                if($opt==='') {
783
+                                    return $cmd($value);
784
+                } else {
785
+                    return $cmd($value,$opt);
786
+                }
670 787
             // These are all straight wrappers for PHP functions
671 788
             case 'ucfirst':
672 789
             case 'lcfirst':
@@ -677,15 +794,24 @@  discard block
 block discarded – undo
677 794
             case 'strftime':
678 795
             case 'date':
679 796
             case 'dateformat':
680
-                if(empty($opt)) $opt = $modx->toDateFormat(null, 'formatOnly');
681
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
682
-                if(strpos($opt,'%')!==false)
683
-                    return strftime($opt,0+$value);
684
-                else
685
-                    return date($opt,0+$value);
797
+                if(empty($opt)) {
798
+                    $opt = $modx->toDateFormat(null, 'formatOnly');
799
+                }
800
+                if(!preg_match('@^[0-9]+$@',$value)) {
801
+                    $value = strtotime($value);
802
+                }
803
+                if(strpos($opt,'%')!==false) {
804
+                                    return strftime($opt,0+$value);
805
+                } else {
806
+                                    return date($opt,0+$value);
807
+                }
686 808
             case 'time':
687
-                if(empty($opt)) $opt = '%H:%M';
688
-                if(!preg_match('@^[0-9]+$@',$value)) $value = strtotime($value);
809
+                if(empty($opt)) {
810
+                    $opt = '%H:%M';
811
+                }
812
+                if(!preg_match('@^[0-9]+$@',$value)) {
813
+                    $value = strtotime($value);
814
+                }
689 815
                 return strftime($opt,0+$value);
690 816
             case 'strtotime':
691 817
                 return strtotime($value);
@@ -695,7 +821,9 @@  discard block
 block discarded – undo
695 821
             case 'tofloat':
696 822
                 return floatval($value);
697 823
             case 'round':
698
-                if(!$opt) $opt = 0;
824
+                if(!$opt) {
825
+                    $opt = 0;
826
+                }
699 827
                 return $cmd($value,$opt);
700 828
             case 'max':
701 829
             case 'min':
@@ -707,28 +835,42 @@  discard block
 block discarded – undo
707 835
             case 'math':
708 836
             case 'calc':
709 837
                 $value = (int)$value;
710
-                if(empty($value)) $value = '0';
838
+                if(empty($value)) {
839
+                    $value = '0';
840
+                }
711 841
                 $filter = str_replace(array('[+value+]','[+output+]','{value}','%s'),'?',$opt);
712 842
                 $filter = preg_replace('@([a-zA-Z\n\r\t\s])@','',$filter);
713
-                if(strpos($filter,'?')===false) $filter = "?{$filter}";
843
+                if(strpos($filter,'?')===false) {
844
+                    $filter = "?{$filter}";
845
+                }
714 846
                 $filter = str_replace('?',$value,$filter);
715 847
                 return eval("return {$filter};");
716 848
             case 'count':
717
-                if($value=='') return 0;
849
+                if($value=='') {
850
+                    return 0;
851
+                }
718 852
                 $value = explode(',',$value);
719 853
                 return count($value);
720 854
             case 'sort':
721 855
             case 'rsort':
722
-                if(strpos($value,"\n")!==false) $delim="\n";
723
-                else $delim = ',';
856
+                if(strpos($value,"\n")!==false) {
857
+                    $delim="\n";
858
+                } else {
859
+                    $delim = ',';
860
+                }
724 861
                 $swap = explode($delim,$value);
725
-                if(!$opt) $opt = SORT_REGULAR;
726
-                else      $opt = constant($opt);
862
+                if(!$opt) {
863
+                    $opt = SORT_REGULAR;
864
+                } else {
865
+                    $opt = constant($opt);
866
+                }
727 867
                 $cmd($swap,$opt);
728 868
                 return implode($delim,$swap);
729 869
             #####  Resource fields
730 870
             case 'id':
731
-                if($opt) return $this->getDocumentObject($opt,$key);
871
+                if($opt) {
872
+                    return $this->getDocumentObject($opt,$key);
873
+                }
732 874
                 break;
733 875
             case 'type':
734 876
             case 'contenttype':
@@ -765,7 +907,9 @@  discard block
 block discarded – undo
765 907
             case 'privatemgr':
766 908
             case 'content_dispo':
767 909
             case 'hidemenu':
768
-                if($cmd==='contenttype') $cmd = 'contentType';
910
+                if($cmd==='contenttype') {
911
+                    $cmd = 'contentType';
912
+                }
769 913
                 return $this->getDocumentObject($value,$cmd);
770 914
             case 'title':
771 915
                 $pagetitle = $this->getDocumentObject($value,'pagetitle');
@@ -780,13 +924,20 @@  discard block
 block discarded – undo
780 924
                 $templateName = $modx->db->getValue($rs);
781 925
                 return !$templateName ? '(blank)' : $templateName;
782 926
             case 'getfield':
783
-                if(!$opt) $opt = 'content';
927
+                if(!$opt) {
928
+                    $opt = 'content';
929
+                }
784 930
                 return $modx->getField($opt,$value);
785 931
             case 'children':
786 932
             case 'childids':
787
-                if($value=='') $value = 0; // 値がない場合はルートと見なす
933
+                if($value=='') {
934
+                    $value = 0;
935
+                }
936
+                // 値がない場合はルートと見なす
788 937
                 $published = 1;
789
-                if($opt=='') $opt = 'page';
938
+                if($opt=='') {
939
+                    $opt = 'page';
940
+                }
790 941
                 $_ = explode(',',$opt);
791 942
                 $where = array();
792 943
                 foreach($_ as $opt) {
@@ -802,29 +953,43 @@  discard block
 block discarded – undo
802 953
                 $where = implode(' AND ', $where);
803 954
                 $children = $modx->getDocumentChildren($value, $published, '0', 'id', $where);
804 955
                 $result = array();
805
-                foreach((array)$children as $child){
956
+                foreach((array)$children as $child) {
806 957
                     $result[] = $child['id'];
807 958
                 }
808 959
                 return implode(',', $result);
809 960
             case 'fullurl':
810
-                if(!is_numeric($value)) return $value;
961
+                if(!is_numeric($value)) {
962
+                    return $value;
963
+                }
811 964
                 return $modx->makeUrl($value);
812 965
             case 'makeurl':
813
-                if(!is_numeric($value)) return $value;
814
-                if(!$opt) $opt = 'full';
966
+                if(!is_numeric($value)) {
967
+                    return $value;
968
+                }
969
+                if(!$opt) {
970
+                    $opt = 'full';
971
+                }
815 972
                 return $modx->makeUrl($value,'','',$opt);
816 973
 
817 974
             #####  File system
818 975
             case 'getimageinfo':
819 976
             case 'imageinfo':
820
-                if(!is_file($value)) return '';
977
+                if(!is_file($value)) {
978
+                    return '';
979
+                }
821 980
                 $_ = getimagesize($value);
822
-                if(!$_[0]) return '';
981
+                if(!$_[0]) {
982
+                    return '';
983
+                }
823 984
                 $info['width']  = $_[0];
824 985
                 $info['height'] = $_[1];
825
-                if    ($_[0] > $_[1]) $info['aspect'] = 'landscape';
826
-                elseif($_[0] < $_[1]) $info['aspect'] = 'portrait';
827
-                else                  $info['aspect'] = 'square';
986
+                if    ($_[0] > $_[1]) {
987
+                    $info['aspect'] = 'landscape';
988
+                } elseif($_[0] < $_[1]) {
989
+                    $info['aspect'] = 'portrait';
990
+                } else {
991
+                    $info['aspect'] = 'square';
992
+                }
828 993
                 switch($_[2]) {
829 994
                     case IMAGETYPE_GIF  : $info['type'] = 'gif'; break;
830 995
                     case IMAGETYPE_JPEG : $info['type'] = 'jpg'; break;
@@ -843,33 +1008,47 @@  discard block
 block discarded – undo
843 1008
 
844 1009
             case 'file_get_contents':
845 1010
             case 'readfile':
846
-                if(!is_file($value)) return $value;
1011
+                if(!is_file($value)) {
1012
+                    return $value;
1013
+                }
847 1014
                 $value = realpath($value);
848
-                if(strpos($value,MODX_MANAGER_PATH)!==false) exit('Can not read core file');
1015
+                if(strpos($value,MODX_MANAGER_PATH)!==false) {
1016
+                    exit('Can not read core file');
1017
+                }
849 1018
                 $ext = strtolower(substr($value,-4));
850
-                if($ext==='.php') exit('Can not read php file');
851
-                if($ext==='.cgi') exit('Can not read cgi file');
1019
+                if($ext==='.php') {
1020
+                    exit('Can not read php file');
1021
+                }
1022
+                if($ext==='.cgi') {
1023
+                    exit('Can not read cgi file');
1024
+                }
852 1025
                 return file_get_contents($value);
853 1026
             case 'filesize':
854
-                if($value == '') return '';
1027
+                if($value == '') {
1028
+                    return '';
1029
+                }
855 1030
                 $filename = $value;
856 1031
 
857 1032
                 $site_url = $modx->config['site_url'];
858
-                if(strpos($filename,$site_url) === 0)
859
-                    $filename = substr($filename,0,strlen($site_url));
1033
+                if(strpos($filename,$site_url) === 0) {
1034
+                                    $filename = substr($filename,0,strlen($site_url));
1035
+                }
860 1036
                 $filename = trim($filename,'/');
861 1037
 
862 1038
                 $opt = trim($opt,'/');
863
-                if($opt!=='') $opt .= '/';
1039
+                if($opt!=='') {
1040
+                    $opt .= '/';
1041
+                }
864 1042
 
865 1043
                 $filename = MODX_BASE_PATH.$opt.$filename;
866 1044
 
867
-                if(is_file($filename)){
1045
+                if(is_file($filename)) {
868 1046
                     clearstatcache();
869 1047
                     $size = filesize($filename);
870 1048
                     return $size;
1049
+                } else {
1050
+                    return '';
871 1051
                 }
872
-                else return '';
873 1052
             #####  User info
874 1053
             case 'username':
875 1054
             case 'fullname':
@@ -897,32 +1076,47 @@  discard block
 block discarded – undo
897 1076
                 $this->opt = $cmd;
898 1077
                 return $this->includeMdfFile('moduser');
899 1078
             case 'userinfo':
900
-                if(empty($opt)) $this->opt = 'username';
1079
+                if(empty($opt)) {
1080
+                    $this->opt = 'username';
1081
+                }
901 1082
                 return $this->includeMdfFile('moduser');
902 1083
             case 'webuserinfo':
903
-                if(empty($opt)) $this->opt = 'username';
1084
+                if(empty($opt)) {
1085
+                    $this->opt = 'username';
1086
+                }
904 1087
                 $this->value = -$value;
905 1088
                 return $this->includeMdfFile('moduser');
906 1089
             #####  Special functions
907 1090
             case 'ifempty':
908 1091
             case '_default':
909 1092
             case 'default':
910
-                if (empty($value)) return $opt; break;
1093
+                if (empty($value)) {
1094
+                    return $opt;
1095
+                }
1096
+                break;
911 1097
             case 'ifnotempty':
912
-                if (!empty($value)) return $opt; break;
1098
+                if (!empty($value)) {
1099
+                    return $opt;
1100
+                }
1101
+                break;
913 1102
             case 'datagrid':
914 1103
                 include_once(MODX_CORE_PATH . 'controls/datagrid.class.php');
915 1104
                 $grd = new DataGrid(null, trim($value));
916 1105
                 $grd->itemStyle = '';
917 1106
                 $grd->altItemStyle = '';
918 1107
                 $pos = strpos($value,"\n");
919
-                if($pos) $_ = substr($value,0,$pos);
920
-                else $_ = $pos;
1108
+                if($pos) {
1109
+                    $_ = substr($value,0,$pos);
1110
+                } else {
1111
+                    $_ = $pos;
1112
+                }
921 1113
                 $grd->cdelim = strpos($_,"\t")!==false ? 'tab' : ',';
922 1114
                 return $grd->render();
923 1115
             case 'rotate':
924 1116
             case 'evenodd':
925
-                if(strpos($opt,',')===false) $opt = 'odd,even';
1117
+                if(strpos($opt,',')===false) {
1118
+                    $opt = 'odd,even';
1119
+                }
926 1120
                 $_ = explode(',', $opt);
927 1121
                 $c = count($_);
928 1122
                 $i = $value + $c;
@@ -931,7 +1125,9 @@  discard block
 block discarded – undo
931 1125
             case 'takeval':
932 1126
                 $arr = explode(",",$opt);
933 1127
                 $idx = $value;
934
-                if(!is_numeric($idx)) return $value;
1128
+                if(!is_numeric($idx)) {
1129
+                    return $value;
1130
+                }
935 1131
                 return $arr[$idx];
936 1132
             case 'getimage':
937 1133
                 return $this->includeMdfFile('getimage');
@@ -939,14 +1135,18 @@  discard block
 block discarded – undo
939 1135
                     return $modx->nicesize($value);
940 1136
             case 'googlemap':
941 1137
             case 'googlemaps':
942
-                if(empty($opt)) $opt = 'border:none;width:500px;height:350px;';
1138
+                if(empty($opt)) {
1139
+                    $opt = 'border:none;width:500px;height:350px;';
1140
+                }
943 1141
                 $tpl = '<iframe style="[+style+]" src="https://maps.google.co.jp/maps?ll=[+value+]&output=embed&z=15"></iframe>';
944 1142
                 $ph['style'] = $opt;
945 1143
                 $ph['value'] = $value;
946 1144
                 return $modx->parseText($tpl,$ph);
947 1145
             case 'youtube':
948 1146
             case 'youtube16x9':
949
-                if(empty($opt)) $opt = 560;
1147
+                if(empty($opt)) {
1148
+                    $opt = 560;
1149
+                }
950 1150
                 $h = round($opt*0.5625);
951 1151
                 $tpl = '<iframe width="%s" height="%s" src="https://www.youtube.com/embed/%s" frameborder="0" allowfullscreen></iframe>';
952 1152
                 return sprintf($tpl,$opt,$h,$value);
@@ -979,7 +1179,8 @@  discard block
 block discarded – undo
979 1179
         return $value;
980 1180
     }
981 1181
 
982
-    public function includeMdfFile($cmd) {
1182
+    public function includeMdfFile($cmd)
1183
+    {
983 1184
         global $modx;
984 1185
         $key = $this->key;
985 1186
         $value  = $this->value;
@@ -990,55 +1191,65 @@  discard block
 block discarded – undo
990 1191
     public function getValueFromElement($key, $value, $cmd, $opt)
991 1192
     {
992 1193
         global $modx;
993
-        if( isset($modx->snippetCache[$this->elmName]) )
994
-        {
1194
+        if( isset($modx->snippetCache[$this->elmName]) ) {
995 1195
             $php = $modx->snippetCache[$this->elmName];
996
-        }
997
-        else
998
-        {
1196
+        } else {
999 1197
             $esc_elmName = $modx->db->escape($this->elmName);
1000 1198
             $result = $modx->db->select('snippet','[+prefix+]site_snippets',"name='{$esc_elmName}'");
1001 1199
             $total = $modx->db->getRecordCount($result);
1002
-            if($total == 1)
1003
-            {
1200
+            if($total == 1) {
1004 1201
                 $row = $modx->db->getRow($result);
1005 1202
                 $php = $row['snippet'];
1006
-            }
1007
-            elseif($total == 0)
1008
-            {
1203
+            } elseif($total == 0) {
1009 1204
                 $assets_path = MODX_BASE_PATH.'assets/';
1010
-                if(is_file($assets_path."modifiers/mdf_{$cmd}.inc.php"))
1011
-                    $modifiers_path = $assets_path."modifiers/mdf_{$cmd}.inc.php";
1012
-                elseif(is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php"))
1013
-                    $modifiers_path = $assets_path."plugins/phx/modifiers/{$cmd}.phx.php";
1014
-                elseif(is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php"))
1015
-                    $modifiers_path = MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php";
1016
-                else $modifiers_path = false;
1205
+                if(is_file($assets_path."modifiers/mdf_{$cmd}.inc.php")) {
1206
+                                    $modifiers_path = $assets_path."modifiers/mdf_{$cmd}.inc.php";
1207
+                } elseif(is_file($assets_path."plugins/phx/modifiers/{$cmd}.phx.php")) {
1208
+                                    $modifiers_path = $assets_path."plugins/phx/modifiers/{$cmd}.phx.php";
1209
+                } elseif(is_file(MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php")) {
1210
+                                    $modifiers_path = MODX_CORE_PATH."extenders/modifiers/mdf_{$cmd}.inc.php";
1211
+                } else {
1212
+                    $modifiers_path = false;
1213
+                }
1017 1214
 
1018 1215
                 if($modifiers_path !== false) {
1019 1216
                     $php = @file_get_contents($modifiers_path);
1020 1217
                     $php = trim($php);
1021
-                    if(substr($php,0,5)==='<?php') $php = substr($php,6);
1022
-                    if(substr($php,0,2)==='<?')    $php = substr($php,3);
1023
-                    if(substr($php,-2)==='?>')     $php = substr($php,0,-2);
1024
-                    if($this->elmName!=='')
1025
-                        $modx->snippetCache[$this->elmName.'Props'] = '';
1026
-                }
1027
-                else
1028
-                    $php = false;
1218
+                    if(substr($php,0,5)==='<?php') {
1219
+                        $php = substr($php,6);
1220
+                    }
1221
+                    if(substr($php,0,2)==='<?') {
1222
+                        $php = substr($php,3);
1223
+                    }
1224
+                    if(substr($php,-2)==='?>') {
1225
+                        $php = substr($php,0,-2);
1226
+                    }
1227
+                    if($this->elmName!=='') {
1228
+                                            $modx->snippetCache[$this->elmName.'Props'] = '';
1229
+                    }
1230
+                } else {
1231
+                                    $php = false;
1232
+                }
1233
+            } else {
1234
+                $php = false;
1235
+            }
1236
+            if($this->elmName!=='') {
1237
+                $modx->snippetCache[$this->elmName]= $php;
1029 1238
             }
1030
-            else $php = false;
1031
-            if($this->elmName!=='') $modx->snippetCache[$this->elmName]= $php;
1032 1239
         }
1033
-        if($php==='') $php=false;
1240
+        if($php==='') {
1241
+            $php=false;
1242
+        }
1034 1243
 
1035
-        if($php===false) $html = $modx->getChunk($this->elmName);
1036
-        else             $html = false;
1244
+        if($php===false) {
1245
+            $html = $modx->getChunk($this->elmName);
1246
+        } else {
1247
+            $html = false;
1248
+        }
1037 1249
 
1038 1250
         $self = '[+output+]';
1039 1251
 
1040
-        if($php !== false)
1041
-        {
1252
+        if($php !== false) {
1042 1253
             ob_start();
1043 1254
             $options = $opt;
1044 1255
             $output = $value;
@@ -1050,19 +1261,19 @@  discard block
 block discarded – undo
1050 1261
             $this->vars['options'] = & $opt;
1051 1262
             $custom = eval($php);
1052 1263
             $msg = ob_get_contents();
1053
-            if($value===$this->bt) $value = $msg . $custom;
1264
+            if($value===$this->bt) {
1265
+                $value = $msg . $custom;
1266
+            }
1054 1267
             ob_end_clean();
1055
-        }
1056
-        elseif($html!==false && isset($value) && $value!=='')
1057
-        {
1268
+        } elseif($html!==false && isset($value) && $value!=='') {
1058 1269
             $html = str_replace(array($self,'[+value+]'), $value, $html);
1059 1270
             $value = str_replace(array('[+options+]','[+param+]'), $opt, $html);
1271
+        } else {
1272
+            return false;
1060 1273
         }
1061
-        else return false;
1062 1274
 
1063 1275
         if($php===false && $html===false && $value!==''
1064
-           && (strpos($cmd,'[+value+]')!==false || strpos($cmd,$self)!==false))
1065
-        {
1276
+           && (strpos($cmd,'[+value+]')!==false || strpos($cmd,$self)!==false)) {
1066 1277
             $value = str_replace(array('[+value+]',$self),$value,$cmd);
1067 1278
         }
1068 1279
         return $value;
@@ -1072,23 +1283,39 @@  discard block
 block discarded – undo
1072 1283
     {
1073 1284
         global $modx;
1074 1285
 
1075
-        if(strpos($content,'[')===false && strpos($content,'{')===false) return $content;
1286
+        if(strpos($content,'[')===false && strpos($content,'{')===false) {
1287
+            return $content;
1288
+        }
1076 1289
 
1077
-        if(!$modx->maxParserPasses) $modx->maxParserPasses = 10;
1290
+        if(!$modx->maxParserPasses) {
1291
+            $modx->maxParserPasses = 10;
1292
+        }
1078 1293
         $bt='';
1079 1294
         $i=0;
1080
-        while($bt!==$content)
1081
-        {
1295
+        while($bt!==$content) {
1082 1296
             $bt = $content;
1083
-            if(strpos($content,'[*')!==false && $modx->documentIdentifier)
1084
-                                              $content = $modx->mergeDocumentContent($content);
1085
-            if(strpos($content,'[(')!==false) $content = $modx->mergeSettingsContent($content);
1086
-            if(strpos($content,'{{')!==false) $content = $modx->mergeChunkContent($content);
1087
-            if(strpos($content,'[!')!==false) $content = str_replace(array('[!','!]'),array('[[',']]'),$content);
1088
-            if(strpos($content,'[[')!==false) $content = $modx->evalSnippets($content);
1089
-
1090
-            if($content===$bt)              break;
1091
-            if($modx->maxParserPasses < $i) break;
1297
+            if(strpos($content,'[*')!==false && $modx->documentIdentifier) {
1298
+                                                          $content = $modx->mergeDocumentContent($content);
1299
+            }
1300
+            if(strpos($content,'[(')!==false) {
1301
+                $content = $modx->mergeSettingsContent($content);
1302
+            }
1303
+            if(strpos($content,'{{')!==false) {
1304
+                $content = $modx->mergeChunkContent($content);
1305
+            }
1306
+            if(strpos($content,'[!')!==false) {
1307
+                $content = str_replace(array('[!','!]'),array('[[',']]'),$content);
1308
+            }
1309
+            if(strpos($content,'[[')!==false) {
1310
+                $content = $modx->evalSnippets($content);
1311
+            }
1312
+
1313
+            if($content===$bt) {
1314
+                break;
1315
+            }
1316
+            if($modx->maxParserPasses < $i) {
1317
+                break;
1318
+            }
1092 1319
             $i++;
1093 1320
         }
1094 1321
         return $content;
@@ -1099,103 +1326,138 @@  discard block
 block discarded – undo
1099 1326
         global $modx;
1100 1327
 
1101 1328
         $target = trim($target);
1102
-        if(empty($target)) $target = $modx->config['site_start'];
1103
-        if(preg_match('@^[1-9][0-9]*$@',$target)) $method='id';
1104
-        else $method = 'alias';
1329
+        if(empty($target)) {
1330
+            $target = $modx->config['site_start'];
1331
+        }
1332
+        if(preg_match('@^[1-9][0-9]*$@',$target)) {
1333
+            $method='id';
1334
+        } else {
1335
+            $method = 'alias';
1336
+        }
1105 1337
 
1106
-        if(!isset($this->documentObject[$target]))
1107
-        {
1338
+        if(!isset($this->documentObject[$target])) {
1108 1339
             $this->documentObject[$target] = $modx->getDocumentObject($method,$target,'direct');
1109 1340
         }
1110 1341
 
1111
-        if($this->documentObject[$target]['publishedon']==='0')
1112
-            return '';
1113
-        elseif(isset($this->documentObject[$target][$field]))
1114
-        {
1115
-            if(is_array($this->documentObject[$target][$field]))
1116
-            {
1342
+        if($this->documentObject[$target]['publishedon']==='0') {
1343
+                    return '';
1344
+        } elseif(isset($this->documentObject[$target][$field])) {
1345
+            if(is_array($this->documentObject[$target][$field])) {
1117 1346
                 $a = $modx->getTemplateVarOutput($field,$target);
1118 1347
                 $this->documentObject[$target][$field] = $a[$field];
1119 1348
             }
1349
+        } else {
1350
+            $this->documentObject[$target][$field] = false;
1120 1351
         }
1121
-        else $this->documentObject[$target][$field] = false;
1122 1352
 
1123 1353
         return $this->documentObject[$target][$field];
1124 1354
     }
1125 1355
 
1126
-    public function setPlaceholders($value = '', $key = '', $path = '') {
1127
-        if($path!=='') $key = "{$path}.{$key}";
1356
+    public function setPlaceholders($value = '', $key = '', $path = '')
1357
+    {
1358
+        if($path!=='') {
1359
+            $key = "{$path}.{$key}";
1360
+        }
1128 1361
         if (is_array($value)) {
1129 1362
             foreach ($value as $subkey => $subval) {
1130 1363
                 $this->setPlaceholders($subval, $subkey, $key);
1131 1364
             }
1365
+        } else {
1366
+            $this->setModifiersVariable($key, $value);
1132 1367
         }
1133
-        else $this->setModifiersVariable($key, $value);
1134 1368
     }
1135 1369
 
1136 1370
     // Sets a placeholder variable which can only be access by Modifiers
1137
-    public function setModifiersVariable($key, $value) {
1138
-        if ($key != 'phx' && $key != 'dummy') $this->placeholders[$key] = $value;
1371
+    public function setModifiersVariable($key, $value)
1372
+    {
1373
+        if ($key != 'phx' && $key != 'dummy') {
1374
+            $this->placeholders[$key] = $value;
1375
+        }
1139 1376
     }
1140 1377
 
1141 1378
     //mbstring
1142
-    public function substr($str, $s, $l = null) {
1379
+    public function substr($str, $s, $l = null)
1380
+    {
1143 1381
         global $modx;
1144
-        if(is_null($l)) $l = $this->strlen($str);
1145
-        if (function_exists('mb_substr'))
1146
-        {
1147
-            if(strpos($str,"\r")!==false)
1148
-                $str = str_replace(array("\r\n","\r"), "\n", $str);
1382
+        if(is_null($l)) {
1383
+            $l = $this->strlen($str);
1384
+        }
1385
+        if (function_exists('mb_substr')) {
1386
+            if(strpos($str,"\r")!==false) {
1387
+                            $str = str_replace(array("\r\n","\r"), "\n", $str);
1388
+            }
1149 1389
             return mb_substr($str, $s, $l, $modx->config['modx_charset']);
1150 1390
         }
1151 1391
         return substr($str, $s, $l);
1152 1392
     }
1153
-    public function strpos($haystack,$needle,$offset=0) {
1393
+    public function strpos($haystack,$needle,$offset=0)
1394
+    {
1154 1395
         global $modx;
1155
-        if (function_exists('mb_strpos')) return mb_strpos($haystack,$needle,$offset,$modx->config['modx_charset']);
1396
+        if (function_exists('mb_strpos')) {
1397
+            return mb_strpos($haystack,$needle,$offset,$modx->config['modx_charset']);
1398
+        }
1156 1399
         return strpos($haystack,$needle,$offset);
1157 1400
     }
1158
-    public function strlen($str) {
1401
+    public function strlen($str)
1402
+    {
1159 1403
         global $modx;
1160
-        if (function_exists('mb_strlen')) return mb_strlen(str_replace("\r\n", "\n", $str),$modx->config['modx_charset']);
1404
+        if (function_exists('mb_strlen')) {
1405
+            return mb_strlen(str_replace("\r\n", "\n", $str),$modx->config['modx_charset']);
1406
+        }
1161 1407
         return strlen($str);
1162 1408
     }
1163
-    public function strtolower($str) {
1164
-        if (function_exists('mb_strtolower')) return mb_strtolower($str);
1409
+    public function strtolower($str)
1410
+    {
1411
+        if (function_exists('mb_strtolower')) {
1412
+            return mb_strtolower($str);
1413
+        }
1165 1414
         return strtolower($str);
1166 1415
     }
1167
-    public function strtoupper($str) {
1168
-        if (function_exists('mb_strtoupper')) return mb_strtoupper($str);
1416
+    public function strtoupper($str)
1417
+    {
1418
+        if (function_exists('mb_strtoupper')) {
1419
+            return mb_strtoupper($str);
1420
+        }
1169 1421
         return strtoupper($str);
1170 1422
     }
1171
-    public function ucfirst($str) {
1172
-        if (function_exists('mb_strtoupper'))
1173
-            return mb_strtoupper($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1423
+    public function ucfirst($str)
1424
+    {
1425
+        if (function_exists('mb_strtoupper')) {
1426
+                    return mb_strtoupper($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1427
+        }
1174 1428
         return ucfirst($str);
1175 1429
     }
1176
-    public function lcfirst($str) {
1177
-        if (function_exists('mb_strtolower'))
1178
-            return mb_strtolower($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1430
+    public function lcfirst($str)
1431
+    {
1432
+        if (function_exists('mb_strtolower')) {
1433
+                    return mb_strtolower($this->substr($str, 0, 1)).$this->substr($str, 1, $this->strlen($str));
1434
+        }
1179 1435
         return lcfirst($str);
1180 1436
     }
1181
-    public function ucwords($str) {
1182
-        if (function_exists('mb_convert_case'))
1183
-            return mb_convert_case($str, MB_CASE_TITLE);
1437
+    public function ucwords($str)
1438
+    {
1439
+        if (function_exists('mb_convert_case')) {
1440
+                    return mb_convert_case($str, MB_CASE_TITLE);
1441
+        }
1184 1442
         return ucwords($str);
1185 1443
     }
1186
-    public function strrev($str) {
1444
+    public function strrev($str)
1445
+    {
1187 1446
         preg_match_all('/./us', $str, $ar);
1188 1447
         return implode(array_reverse($ar[0]));
1189 1448
     }
1190
-    public function str_shuffle($str) {
1449
+    public function str_shuffle($str)
1450
+    {
1191 1451
         preg_match_all('/./us', $str, $ar);
1192 1452
         shuffle($ar[0]);
1193 1453
         return implode($ar[0]);
1194 1454
     }
1195
-    public function str_word_count($str) {
1455
+    public function str_word_count($str)
1456
+    {
1196 1457
         return count(preg_split('~[^\p{L}\p{N}\']+~u',$str));
1197 1458
     }
1198
-    public function strip_tags($value,$params='') {
1459
+    public function strip_tags($value,$params='')
1460
+    {
1199 1461
         global $modx;
1200 1462
 
1201 1463
         if(stripos($params,'style')===false && stripos($value,'</style>')!==false) {
Please login to merge, or discard this patch.
manager/actions/resources/functions.inc.php 3 patches
Indentation   +165 added lines, -165 removed lines patch added patch discarded remove patch
@@ -1,14 +1,14 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6 6
 $tpl = array(
7
-	'viewForm' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_viewForm.tpl'),
8
-	'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
9
-	'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
10
-	'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
11
-	'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl')
7
+    'viewForm' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_viewForm.tpl'),
8
+    'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
9
+    'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
10
+    'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
11
+    'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl')
12 12
 );
13 13
 
14 14
 /**
@@ -17,9 +17,9 @@  discard block
 block discarded – undo
17 17
  * @return string
18 18
  */
19 19
 function parsePh($tpl, $ph) {
20
-	global $modx, $_lang;
21
-	$tpl = $modx->parseText($tpl, $_lang, '[%', '%]');
22
-	return $modx->parseText($tpl, $ph);
20
+    global $modx, $_lang;
21
+    $tpl = $modx->parseText($tpl, $_lang, '[%', '%]');
22
+    return $modx->parseText($tpl, $ph);
23 23
 }
24 24
 
25 25
 /**
@@ -27,11 +27,11 @@  discard block
 block discarded – undo
27 27
  * @return string
28 28
  */
29 29
 function renderViewSwitchButtons($cssId) {
30
-	global $modx, $_lang, $tpl;
30
+    global $modx, $_lang, $tpl;
31 31
 
32
-	return parsePh($tpl['viewForm'], array(
33
-		'cssId' => $cssId
34
-	));
32
+    return parsePh($tpl['viewForm'], array(
33
+        'cssId' => $cssId
34
+    ));
35 35
 }
36 36
 
37 37
 /**
@@ -40,52 +40,52 @@  discard block
 block discarded – undo
40 40
  * @return string
41 41
  */
42 42
 function createResourceList($resourceTable, $resources) {
43
-	global $modx, $_lang, $_style, $modx_textdir, $tpl;
43
+    global $modx, $_lang, $_style, $modx_textdir, $tpl;
44 44
 
45
-	$items = isset($resources->items[$resourceTable]) ? $resources->items[$resourceTable] : false;
45
+    $items = isset($resources->items[$resourceTable]) ? $resources->items[$resourceTable] : false;
46 46
 
47
-	if( ! is_array($items) || empty($items)) {
48
-		return $_lang['no_results'];
49
-	}
47
+    if( ! is_array($items) || empty($items)) {
48
+        return $_lang['no_results'];
49
+    }
50 50
 
51
-	// Prepare elements- and categories-list
52
-	$elements = array();
53
-	$categories = array();
54
-	foreach($items as $row) {
55
-		$catid = $row['catid'] ? $row['catid'] : 0;
56
-		$categories[$catid] = array('name' => stripslashes($row['category']));
57
-		$elements[$catid][] = prepareElementRowPh($row, $resourceTable, $resources);
58
-	}
51
+    // Prepare elements- and categories-list
52
+    $elements = array();
53
+    $categories = array();
54
+    foreach($items as $row) {
55
+        $catid = $row['catid'] ? $row['catid'] : 0;
56
+        $categories[$catid] = array('name' => stripslashes($row['category']));
57
+        $elements[$catid][] = prepareElementRowPh($row, $resourceTable, $resources);
58
+    }
59 59
 
60
-	// Now render categories / panel-collapse
61
-	$panelGroup = '';
62
-	foreach($elements as $catid => $elList) {
63
-		// Add panel-heading / category-collapse to output
64
-		$panelGroup .= parsePh($tpl['panelHeading'], array(
65
-			'tab' => $resourceTable,
66
-			'category' => $categories[$catid]['name'],
67
-			'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
68
-			'catid' => $catid,
69
-		));
60
+    // Now render categories / panel-collapse
61
+    $panelGroup = '';
62
+    foreach($elements as $catid => $elList) {
63
+        // Add panel-heading / category-collapse to output
64
+        $panelGroup .= parsePh($tpl['panelHeading'], array(
65
+            'tab' => $resourceTable,
66
+            'category' => $categories[$catid]['name'],
67
+            'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
68
+            'catid' => $catid,
69
+        ));
70 70
 
71
-		// Prepare content for panel-collapse
72
-		$panelCollapse = '';
73
-		foreach($elList as $el) {
74
-			$panelCollapse .= parsePh($tpl['elementsRow'], $el);
75
-		}
71
+        // Prepare content for panel-collapse
72
+        $panelCollapse = '';
73
+        foreach($elList as $el) {
74
+            $panelCollapse .= parsePh($tpl['elementsRow'], $el);
75
+        }
76 76
 
77
-		// Add panel-collapse with elements to output
78
-		$panelGroup .= parsePh($tpl['panelCollapse'], array(
79
-			'tab' => $resourceTable,
80
-			'catid' => $catid,
81
-			'wrapper' => $panelCollapse,
82
-		));
83
-	}
77
+        // Add panel-collapse with elements to output
78
+        $panelGroup .= parsePh($tpl['panelCollapse'], array(
79
+            'tab' => $resourceTable,
80
+            'catid' => $catid,
81
+            'wrapper' => $panelCollapse,
82
+        ));
83
+    }
84 84
 
85
-	return parsePh($tpl['panelGroup'], array(
86
-		'resourceTable' => $resourceTable,
87
-		'wrapper' => $panelGroup
88
-	));
85
+    return parsePh($tpl['panelGroup'], array(
86
+        'resourceTable' => $resourceTable,
87
+        'wrapper' => $panelGroup
88
+    ));
89 89
 }
90 90
 
91 91
 /**
@@ -93,54 +93,54 @@  discard block
 block discarded – undo
93 93
  * @return string
94 94
  */
95 95
 function createCombinedView($resources) {
96
-	global $modx, $_lang, $_style, $modx_textdir;
96
+    global $modx, $_lang, $_style, $modx_textdir;
97 97
 
98
-	$itemsPerCategory = isset($resources->itemsPerCategory) ? $resources->itemsPerCategory : false;
99
-	$types = isset($resources->types) ? $resources->types : false;
100
-	$categories = isset($resources->categories) ? $resources->categories : false;
98
+    $itemsPerCategory = isset($resources->itemsPerCategory) ? $resources->itemsPerCategory : false;
99
+    $types = isset($resources->types) ? $resources->types : false;
100
+    $categories = isset($resources->categories) ? $resources->categories : false;
101 101
 
102
-	if(!$itemsPerCategory) {
103
-		return $_lang['no_results'];
104
-	}
102
+    if(!$itemsPerCategory) {
103
+        return $_lang['no_results'];
104
+    }
105 105
 
106
-	$tpl = array(
107
-		'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
108
-		'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
109
-		'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
110
-		'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl'),
111
-	);
106
+    $tpl = array(
107
+        'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
108
+        'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
109
+        'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
110
+        'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl'),
111
+    );
112 112
 
113
-	// Easily loop through $itemsPerCategory-Array
114
-	$panelGroup = '';
115
-	foreach($categories as $catid => $category) {
116
-		// Prepare collapse content / elements-list
117
-		$panelCollapse = '';
118
-		foreach($itemsPerCategory[$catid] as $el) {
119
-			$resourceTable = $el['type'];
120
-			$ph = prepareElementRowPh($el, $resourceTable, $resources);
121
-			$panelCollapse .= parsePh($tpl['elementsRow'], $ph);
122
-		}
113
+    // Easily loop through $itemsPerCategory-Array
114
+    $panelGroup = '';
115
+    foreach($categories as $catid => $category) {
116
+        // Prepare collapse content / elements-list
117
+        $panelCollapse = '';
118
+        foreach($itemsPerCategory[$catid] as $el) {
119
+            $resourceTable = $el['type'];
120
+            $ph = prepareElementRowPh($el, $resourceTable, $resources);
121
+            $panelCollapse .= parsePh($tpl['elementsRow'], $ph);
122
+        }
123 123
 
124
-		// Add panel-heading / button
125
-		$panelGroup .= parsePh($tpl['panelHeading'], array(
126
-			'tab' => 'categories_list',
127
-			'category' => $categories[$catid],
128
-			'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
129
-			'catid' => $catid,
130
-		));
124
+        // Add panel-heading / button
125
+        $panelGroup .= parsePh($tpl['panelHeading'], array(
126
+            'tab' => 'categories_list',
127
+            'category' => $categories[$catid],
128
+            'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
129
+            'catid' => $catid,
130
+        ));
131 131
 
132
-		// Add panel
133
-		$panelGroup .= parsePh($tpl['panelCollapse'], array(
134
-			'tab' => 'categories_list',
135
-			'catid' => $catid,
136
-			'wrapper' => $panelCollapse,
137
-		));
138
-	}
132
+        // Add panel
133
+        $panelGroup .= parsePh($tpl['panelCollapse'], array(
134
+            'tab' => 'categories_list',
135
+            'catid' => $catid,
136
+            'wrapper' => $panelCollapse,
137
+        ));
138
+    }
139 139
 
140
-	return parsePh($tpl['panelGroup'], array(
141
-		'resourceTable' => 'categories_list',
142
-		'wrapper' => $panelGroup
143
-	));
140
+    return parsePh($tpl['panelGroup'], array(
141
+        'resourceTable' => 'categories_list',
142
+        'wrapper' => $panelGroup
143
+    ));
144 144
 }
145 145
 
146 146
 /**
@@ -150,13 +150,13 @@  discard block
 block discarded – undo
150 150
  * @return array
151 151
  */
152 152
 function prepareElementRowPh($row, $resourceTable, $resources) {
153
-	global $modx, $modx_textdir, $_style, $_lang;
153
+    global $modx, $modx_textdir, $_style, $_lang;
154 154
 
155
-	$types = isset($resources->types[$resourceTable]) ? $resources->types[$resourceTable] : false;
155
+    $types = isset($resources->types[$resourceTable]) ? $resources->types[$resourceTable] : false;
156 156
 
157
-	$_lang["confirm_delete"] = $_lang["delete"];
157
+    $_lang["confirm_delete"] = $_lang["delete"];
158 158
 
159
-	switch($resourceTable){
159
+    switch($resourceTable){
160 160
         case 'site_templates':
161 161
             $class = $row['selectable'] ? '' : 'disabledPlugin';
162 162
             $lockElementType = 1;
@@ -190,77 +190,77 @@  discard block
 block discarded – undo
190 190
             return array();
191 191
     }
192 192
 
193
-	// Prepare displaying user-locks
194
-	$lockedByUser = '';
195
-	$rowLock = $modx->elementIsLocked($lockElementType, $row['id'], true);
196
-	if($rowLock && $modx->hasPermission('display_locks')) {
197
-		if($rowLock['sid'] == $modx->sid) {
198
-			$title = $modx->parseText($_lang["lock_element_editing"], array(
199
-				'element_type' => $_lang["lock_element_type_" . $lockElementType],
200
-				'lasthit_df' => $rowLock['lasthit_df']
201
-			));
202
-			$lockedByUser = '<span title="' . $title . '" class="editResource" style="cursor:context-menu;">' . $_style['tree_preview_resource'] . '</span>&nbsp;';
203
-		} else {
204
-			$title = $modx->parseText($_lang["lock_element_locked_by"], array(
205
-				'element_type' => $_lang["lock_element_type_" . $lockElementType],
206
-				'username' => $rowLock['username'],
207
-				'lasthit_df' => $rowLock['lasthit_df']
208
-			));
209
-			if($modx->hasPermission('remove_locks')) {
210
-				$lockedByUser = '<a href="javascript:;" onclick="unlockElement(' . $lockElementType . ', ' . $row['id'] . ', this);return false;" title="' . $title . '" class="lockedResource"><i class="' . $_style['icons_secured'] . '"></i></a>';
211
-			} else {
212
-				$lockedByUser = '<span title="' . $title . '" class="lockedResource" style="cursor:context-menu;"><i class="' . $_style['icons_secured'] . '"></i></span>';
213
-			}
214
-		}
215
-	}
216
-	if($lockedByUser) {
217
-		$lockedByUser = '<div class="lockCell">' . $lockedByUser . '</div>';
218
-	}
193
+    // Prepare displaying user-locks
194
+    $lockedByUser = '';
195
+    $rowLock = $modx->elementIsLocked($lockElementType, $row['id'], true);
196
+    if($rowLock && $modx->hasPermission('display_locks')) {
197
+        if($rowLock['sid'] == $modx->sid) {
198
+            $title = $modx->parseText($_lang["lock_element_editing"], array(
199
+                'element_type' => $_lang["lock_element_type_" . $lockElementType],
200
+                'lasthit_df' => $rowLock['lasthit_df']
201
+            ));
202
+            $lockedByUser = '<span title="' . $title . '" class="editResource" style="cursor:context-menu;">' . $_style['tree_preview_resource'] . '</span>&nbsp;';
203
+        } else {
204
+            $title = $modx->parseText($_lang["lock_element_locked_by"], array(
205
+                'element_type' => $_lang["lock_element_type_" . $lockElementType],
206
+                'username' => $rowLock['username'],
207
+                'lasthit_df' => $rowLock['lasthit_df']
208
+            ));
209
+            if($modx->hasPermission('remove_locks')) {
210
+                $lockedByUser = '<a href="javascript:;" onclick="unlockElement(' . $lockElementType . ', ' . $row['id'] . ', this);return false;" title="' . $title . '" class="lockedResource"><i class="' . $_style['icons_secured'] . '"></i></a>';
211
+            } else {
212
+                $lockedByUser = '<span title="' . $title . '" class="lockedResource" style="cursor:context-menu;"><i class="' . $_style['icons_secured'] . '"></i></span>';
213
+            }
214
+        }
215
+    }
216
+    if($lockedByUser) {
217
+        $lockedByUser = '<div class="lockCell">' . $lockedByUser . '</div>';
218
+    }
219 219
 
220
-	// Caption
221
-	if($resourceTable == 'site_tmplvars') {
222
-		$caption = !empty($row['description']) ? ' ' . $row['caption'] . ' &nbsp; <small>(' . $row['description'] . ')</small>' : ' ' . $row['caption'];
223
-	} else {
224
-		$caption = !empty($row['description']) ? ' ' . $row['description'] : '';
225
-	}
220
+    // Caption
221
+    if($resourceTable == 'site_tmplvars') {
222
+        $caption = !empty($row['description']) ? ' ' . $row['caption'] . ' &nbsp; <small>(' . $row['description'] . ')</small>' : ' ' . $row['caption'];
223
+    } else {
224
+        $caption = !empty($row['description']) ? ' ' . $row['description'] : '';
225
+    }
226 226
 
227
-	// Special marks
228
-	$tplInfo = array();
229
-	if($row['locked']) {
230
-		$tplInfo[] = $_lang['locked'];
231
-	}
232
-	if($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
233
-		$tplInfo[] = $_lang['defaulttemplate_title'];
234
-	}
235
-	$marks = !empty($tplInfo) ? ' <em>(' . implode(', ', $tplInfo) . ')</em>' : '';
227
+    // Special marks
228
+    $tplInfo = array();
229
+    if($row['locked']) {
230
+        $tplInfo[] = $_lang['locked'];
231
+    }
232
+    if($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
233
+        $tplInfo[] = $_lang['defaulttemplate_title'];
234
+    }
235
+    $marks = !empty($tplInfo) ? ' <em>(' . implode(', ', $tplInfo) . ')</em>' : '';
236 236
 
237
-	/* row buttons */
238
-	$buttons = '';
239
-	if($modx->hasPermission($types['actions']['edit'][1])) {
240
-		$buttons .= '<li><a title="' . $_lang["edit_resource"] . '" href="index.php?a=' . $types['actions']['edit'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-edit fa-fw"></i></a></li>';
241
-	}
242
-	if($modx->hasPermission($types['actions']['duplicate'][1])) {
243
-		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_duplicate_record"] . '\')" title="' . $_lang["resource_duplicate"] . '" href="index.php?a=' . $types['actions']['duplicate'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-clone fa-fw"></i></a></li>';
244
-	}
245
-	if($modx->hasPermission($types['actions']['remove'][1])) {
246
-		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_delete"] . '\')" title="' . $_lang["delete"] . '" href="index.php?a=' . $types['actions']['remove'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-trash fa-fw"></i></a></li>';
247
-	}
248
-	$buttons = $buttons ? '<div class="btnCell"><ul class="elements_buttonbar">' . $buttons . '</ul></div>' : '';
237
+    /* row buttons */
238
+    $buttons = '';
239
+    if($modx->hasPermission($types['actions']['edit'][1])) {
240
+        $buttons .= '<li><a title="' . $_lang["edit_resource"] . '" href="index.php?a=' . $types['actions']['edit'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-edit fa-fw"></i></a></li>';
241
+    }
242
+    if($modx->hasPermission($types['actions']['duplicate'][1])) {
243
+        $buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_duplicate_record"] . '\')" title="' . $_lang["resource_duplicate"] . '" href="index.php?a=' . $types['actions']['duplicate'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-clone fa-fw"></i></a></li>';
244
+    }
245
+    if($modx->hasPermission($types['actions']['remove'][1])) {
246
+        $buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_delete"] . '\')" title="' . $_lang["delete"] . '" href="index.php?a=' . $types['actions']['remove'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-trash fa-fw"></i></a></li>';
247
+    }
248
+    $buttons = $buttons ? '<div class="btnCell"><ul class="elements_buttonbar">' . $buttons . '</ul></div>' : '';
249 249
 
250
-	$catid = $row['catid'] ? $row['catid'] : 0;
250
+    $catid = $row['catid'] ? $row['catid'] : 0;
251 251
 
252
-	// Placeholders for elements-row
253
-	return array(
254
-		'class' => $class ? ' class="' . $class . '"' : '',
255
-		'lockedByUser' => $lockedByUser,
256
-		'name' => $row['name'],
257
-		'caption' => $caption,
258
-		'buttons' => $buttons,
259
-		'marks' => $marks,
260
-		'id' => $row['id'],
261
-		'resourceTable' => $resourceTable,
262
-		'actionEdit' => $types['actions']['edit'][0],
263
-		'catid' => $catid,
264
-		'textdir' => $modx_textdir ? '&rlm;' : '',
265
-	);
252
+    // Placeholders for elements-row
253
+    return array(
254
+        'class' => $class ? ' class="' . $class . '"' : '',
255
+        'lockedByUser' => $lockedByUser,
256
+        'name' => $row['name'],
257
+        'caption' => $caption,
258
+        'buttons' => $buttons,
259
+        'marks' => $marks,
260
+        'id' => $row['id'],
261
+        'resourceTable' => $resourceTable,
262
+        'actionEdit' => $types['actions']['edit'][0],
263
+        'catid' => $catid,
264
+        'textdir' => $modx_textdir ? '&rlm;' : '',
265
+    );
266 266
 }
Please login to merge, or discard this patch.
Spacing   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -1,14 +1,14 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6 6
 $tpl = array(
7
-	'viewForm' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_viewForm.tpl'),
8
-	'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
9
-	'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
10
-	'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
11
-	'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl')
7
+	'viewForm' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_viewForm.tpl'),
8
+	'panelGroup' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelGroup.tpl'),
9
+	'panelHeading' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelHeading.tpl'),
10
+	'panelCollapse' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelCollapse.tpl'),
11
+	'elementsRow' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_elementsRow.tpl')
12 12
 );
13 13
 
14 14
 /**
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
  * @param array $ph
17 17
  * @return string
18 18
  */
19
-function parsePh($tpl, $ph) {
19
+function parsePh($tpl, $ph){
20 20
 	global $modx, $_lang;
21 21
 	$tpl = $modx->parseText($tpl, $_lang, '[%', '%]');
22 22
 	return $modx->parseText($tpl, $ph);
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  * @param string|int $cssId
27 27
  * @return string
28 28
  */
29
-function renderViewSwitchButtons($cssId) {
29
+function renderViewSwitchButtons($cssId){
30 30
 	global $modx, $_lang, $tpl;
31 31
 
32 32
 	return parsePh($tpl['viewForm'], array(
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
  * @param mgrResources $resources
40 40
  * @return string
41 41
  */
42
-function createResourceList($resourceTable, $resources) {
42
+function createResourceList($resourceTable, $resources){
43 43
 	global $modx, $_lang, $_style, $modx_textdir, $tpl;
44 44
 
45 45
 	$items = isset($resources->items[$resourceTable]) ? $resources->items[$resourceTable] : false;
46 46
 
47
-	if( ! is_array($items) || empty($items)) {
47
+	if (!is_array($items) || empty($items)) {
48 48
 		return $_lang['no_results'];
49 49
 	}
50 50
 
51 51
 	// Prepare elements- and categories-list
52 52
 	$elements = array();
53 53
 	$categories = array();
54
-	foreach($items as $row) {
54
+	foreach ($items as $row) {
55 55
 		$catid = $row['catid'] ? $row['catid'] : 0;
56 56
 		$categories[$catid] = array('name' => stripslashes($row['category']));
57 57
 		$elements[$catid][] = prepareElementRowPh($row, $resourceTable, $resources);
@@ -59,18 +59,18 @@  discard block
 block discarded – undo
59 59
 
60 60
 	// Now render categories / panel-collapse
61 61
 	$panelGroup = '';
62
-	foreach($elements as $catid => $elList) {
62
+	foreach ($elements as $catid => $elList) {
63 63
 		// Add panel-heading / category-collapse to output
64 64
 		$panelGroup .= parsePh($tpl['panelHeading'], array(
65 65
 			'tab' => $resourceTable,
66 66
 			'category' => $categories[$catid]['name'],
67
-			'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
67
+			'categoryid' => $catid != '' ? ' <small>('.$catid.')</small>' : '',
68 68
 			'catid' => $catid,
69 69
 		));
70 70
 
71 71
 		// Prepare content for panel-collapse
72 72
 		$panelCollapse = '';
73
-		foreach($elList as $el) {
73
+		foreach ($elList as $el) {
74 74
 			$panelCollapse .= parsePh($tpl['elementsRow'], $el);
75 75
 		}
76 76
 
@@ -92,30 +92,30 @@  discard block
 block discarded – undo
92 92
  * @param mgrResources $resources
93 93
  * @return string
94 94
  */
95
-function createCombinedView($resources) {
95
+function createCombinedView($resources){
96 96
 	global $modx, $_lang, $_style, $modx_textdir;
97 97
 
98 98
 	$itemsPerCategory = isset($resources->itemsPerCategory) ? $resources->itemsPerCategory : false;
99 99
 	$types = isset($resources->types) ? $resources->types : false;
100 100
 	$categories = isset($resources->categories) ? $resources->categories : false;
101 101
 
102
-	if(!$itemsPerCategory) {
102
+	if (!$itemsPerCategory) {
103 103
 		return $_lang['no_results'];
104 104
 	}
105 105
 
106 106
 	$tpl = array(
107
-		'panelGroup' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelGroup.tpl'),
108
-		'panelHeading' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelHeading.tpl'),
109
-		'panelCollapse' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_panelCollapse.tpl'),
110
-		'elementsRow' => file_get_contents(MODX_MANAGER_PATH . 'actions/resources/tpl_elementsRow.tpl'),
107
+		'panelGroup' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelGroup.tpl'),
108
+		'panelHeading' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelHeading.tpl'),
109
+		'panelCollapse' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_panelCollapse.tpl'),
110
+		'elementsRow' => file_get_contents(MODX_MANAGER_PATH.'actions/resources/tpl_elementsRow.tpl'),
111 111
 	);
112 112
 
113 113
 	// Easily loop through $itemsPerCategory-Array
114 114
 	$panelGroup = '';
115
-	foreach($categories as $catid => $category) {
115
+	foreach ($categories as $catid => $category) {
116 116
 		// Prepare collapse content / elements-list
117 117
 		$panelCollapse = '';
118
-		foreach($itemsPerCategory[$catid] as $el) {
118
+		foreach ($itemsPerCategory[$catid] as $el) {
119 119
 			$resourceTable = $el['type'];
120 120
 			$ph = prepareElementRowPh($el, $resourceTable, $resources);
121 121
 			$panelCollapse .= parsePh($tpl['elementsRow'], $ph);
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$panelGroup .= parsePh($tpl['panelHeading'], array(
126 126
 			'tab' => 'categories_list',
127 127
 			'category' => $categories[$catid],
128
-			'categoryid' => $catid != '' ? ' <small>(' . $catid . ')</small>' : '',
128
+			'categoryid' => $catid != '' ? ' <small>('.$catid.')</small>' : '',
129 129
 			'catid' => $catid,
130 130
 		));
131 131
 
@@ -149,14 +149,14 @@  discard block
 block discarded – undo
149 149
  * @param mgrResources $resources
150 150
  * @return array
151 151
  */
152
-function prepareElementRowPh($row, $resourceTable, $resources) {
152
+function prepareElementRowPh($row, $resourceTable, $resources){
153 153
 	global $modx, $modx_textdir, $_style, $_lang;
154 154
 
155 155
 	$types = isset($resources->types[$resourceTable]) ? $resources->types[$resourceTable] : false;
156 156
 
157 157
 	$_lang["confirm_delete"] = $_lang["delete"];
158 158
 
159
-	switch($resourceTable){
159
+	switch ($resourceTable) {
160 160
         case 'site_templates':
161 161
             $class = $row['selectable'] ? '' : 'disabledPlugin';
162 162
             $lockElementType = 1;
@@ -193,65 +193,65 @@  discard block
 block discarded – undo
193 193
 	// Prepare displaying user-locks
194 194
 	$lockedByUser = '';
195 195
 	$rowLock = $modx->elementIsLocked($lockElementType, $row['id'], true);
196
-	if($rowLock && $modx->hasPermission('display_locks')) {
197
-		if($rowLock['sid'] == $modx->sid) {
196
+	if ($rowLock && $modx->hasPermission('display_locks')) {
197
+		if ($rowLock['sid'] == $modx->sid) {
198 198
 			$title = $modx->parseText($_lang["lock_element_editing"], array(
199
-				'element_type' => $_lang["lock_element_type_" . $lockElementType],
199
+				'element_type' => $_lang["lock_element_type_".$lockElementType],
200 200
 				'lasthit_df' => $rowLock['lasthit_df']
201 201
 			));
202
-			$lockedByUser = '<span title="' . $title . '" class="editResource" style="cursor:context-menu;">' . $_style['tree_preview_resource'] . '</span>&nbsp;';
202
+			$lockedByUser = '<span title="'.$title.'" class="editResource" style="cursor:context-menu;">'.$_style['tree_preview_resource'].'</span>&nbsp;';
203 203
 		} else {
204 204
 			$title = $modx->parseText($_lang["lock_element_locked_by"], array(
205
-				'element_type' => $_lang["lock_element_type_" . $lockElementType],
205
+				'element_type' => $_lang["lock_element_type_".$lockElementType],
206 206
 				'username' => $rowLock['username'],
207 207
 				'lasthit_df' => $rowLock['lasthit_df']
208 208
 			));
209
-			if($modx->hasPermission('remove_locks')) {
210
-				$lockedByUser = '<a href="javascript:;" onclick="unlockElement(' . $lockElementType . ', ' . $row['id'] . ', this);return false;" title="' . $title . '" class="lockedResource"><i class="' . $_style['icons_secured'] . '"></i></a>';
209
+			if ($modx->hasPermission('remove_locks')) {
210
+				$lockedByUser = '<a href="javascript:;" onclick="unlockElement('.$lockElementType.', '.$row['id'].', this);return false;" title="'.$title.'" class="lockedResource"><i class="'.$_style['icons_secured'].'"></i></a>';
211 211
 			} else {
212
-				$lockedByUser = '<span title="' . $title . '" class="lockedResource" style="cursor:context-menu;"><i class="' . $_style['icons_secured'] . '"></i></span>';
212
+				$lockedByUser = '<span title="'.$title.'" class="lockedResource" style="cursor:context-menu;"><i class="'.$_style['icons_secured'].'"></i></span>';
213 213
 			}
214 214
 		}
215 215
 	}
216
-	if($lockedByUser) {
217
-		$lockedByUser = '<div class="lockCell">' . $lockedByUser . '</div>';
216
+	if ($lockedByUser) {
217
+		$lockedByUser = '<div class="lockCell">'.$lockedByUser.'</div>';
218 218
 	}
219 219
 
220 220
 	// Caption
221
-	if($resourceTable == 'site_tmplvars') {
222
-		$caption = !empty($row['description']) ? ' ' . $row['caption'] . ' &nbsp; <small>(' . $row['description'] . ')</small>' : ' ' . $row['caption'];
221
+	if ($resourceTable == 'site_tmplvars') {
222
+		$caption = !empty($row['description']) ? ' '.$row['caption'].' &nbsp; <small>('.$row['description'].')</small>' : ' '.$row['caption'];
223 223
 	} else {
224
-		$caption = !empty($row['description']) ? ' ' . $row['description'] : '';
224
+		$caption = !empty($row['description']) ? ' '.$row['description'] : '';
225 225
 	}
226 226
 
227 227
 	// Special marks
228 228
 	$tplInfo = array();
229
-	if($row['locked']) {
229
+	if ($row['locked']) {
230 230
 		$tplInfo[] = $_lang['locked'];
231 231
 	}
232
-	if($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
232
+	if ($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
233 233
 		$tplInfo[] = $_lang['defaulttemplate_title'];
234 234
 	}
235
-	$marks = !empty($tplInfo) ? ' <em>(' . implode(', ', $tplInfo) . ')</em>' : '';
235
+	$marks = !empty($tplInfo) ? ' <em>('.implode(', ', $tplInfo).')</em>' : '';
236 236
 
237 237
 	/* row buttons */
238 238
 	$buttons = '';
239
-	if($modx->hasPermission($types['actions']['edit'][1])) {
240
-		$buttons .= '<li><a title="' . $_lang["edit_resource"] . '" href="index.php?a=' . $types['actions']['edit'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-edit fa-fw"></i></a></li>';
239
+	if ($modx->hasPermission($types['actions']['edit'][1])) {
240
+		$buttons .= '<li><a title="'.$_lang["edit_resource"].'" href="index.php?a='.$types['actions']['edit'][0].'&amp;id='.$row['id'].'"><i class="fa fa-edit fa-fw"></i></a></li>';
241 241
 	}
242
-	if($modx->hasPermission($types['actions']['duplicate'][1])) {
243
-		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_duplicate_record"] . '\')" title="' . $_lang["resource_duplicate"] . '" href="index.php?a=' . $types['actions']['duplicate'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-clone fa-fw"></i></a></li>';
242
+	if ($modx->hasPermission($types['actions']['duplicate'][1])) {
243
+		$buttons .= '<li><a onclick="return confirm(\''.$_lang["confirm_duplicate_record"].'\')" title="'.$_lang["resource_duplicate"].'" href="index.php?a='.$types['actions']['duplicate'][0].'&amp;id='.$row['id'].'"><i class="fa fa-clone fa-fw"></i></a></li>';
244 244
 	}
245
-	if($modx->hasPermission($types['actions']['remove'][1])) {
246
-		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_delete"] . '\')" title="' . $_lang["delete"] . '" href="index.php?a=' . $types['actions']['remove'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-trash fa-fw"></i></a></li>';
245
+	if ($modx->hasPermission($types['actions']['remove'][1])) {
246
+		$buttons .= '<li><a onclick="return confirm(\''.$_lang["confirm_delete"].'\')" title="'.$_lang["delete"].'" href="index.php?a='.$types['actions']['remove'][0].'&amp;id='.$row['id'].'"><i class="fa fa-trash fa-fw"></i></a></li>';
247 247
 	}
248
-	$buttons = $buttons ? '<div class="btnCell"><ul class="elements_buttonbar">' . $buttons . '</ul></div>' : '';
248
+	$buttons = $buttons ? '<div class="btnCell"><ul class="elements_buttonbar">'.$buttons.'</ul></div>' : '';
249 249
 
250 250
 	$catid = $row['catid'] ? $row['catid'] : 0;
251 251
 
252 252
 	// Placeholders for elements-row
253 253
 	return array(
254
-		'class' => $class ? ' class="' . $class . '"' : '',
254
+		'class' => $class ? ' class="'.$class.'"' : '',
255 255
 		'lockedByUser' => $lockedByUser,
256 256
 		'name' => $row['name'],
257 257
 		'caption' => $caption,
Please login to merge, or discard this patch.
Braces   +32 added lines, -27 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
@@ -16,7 +16,8 @@  discard block
 block discarded – undo
16 16
  * @param array $ph
17 17
  * @return string
18 18
  */
19
-function parsePh($tpl, $ph) {
19
+function parsePh($tpl, $ph)
20
+{
20 21
 	global $modx, $_lang;
21 22
 	$tpl = $modx->parseText($tpl, $_lang, '[%', '%]');
22 23
 	return $modx->parseText($tpl, $ph);
@@ -26,7 +27,8 @@  discard block
 block discarded – undo
26 27
  * @param string|int $cssId
27 28
  * @return string
28 29
  */
29
-function renderViewSwitchButtons($cssId) {
30
+function renderViewSwitchButtons($cssId)
31
+{
30 32
 	global $modx, $_lang, $tpl;
31 33
 
32 34
 	return parsePh($tpl['viewForm'], array(
@@ -39,19 +41,20 @@  discard block
 block discarded – undo
39 41
  * @param mgrResources $resources
40 42
  * @return string
41 43
  */
42
-function createResourceList($resourceTable, $resources) {
44
+function createResourceList($resourceTable, $resources)
45
+{
43 46
 	global $modx, $_lang, $_style, $modx_textdir, $tpl;
44 47
 
45 48
 	$items = isset($resources->items[$resourceTable]) ? $resources->items[$resourceTable] : false;
46 49
 
47
-	if( ! is_array($items) || empty($items)) {
50
+	if( ! is_array($items) || empty($items)) {
48 51
 		return $_lang['no_results'];
49 52
 	}
50 53
 
51 54
 	// Prepare elements- and categories-list
52 55
 	$elements = array();
53 56
 	$categories = array();
54
-	foreach($items as $row) {
57
+	foreach($items as $row) {
55 58
 		$catid = $row['catid'] ? $row['catid'] : 0;
56 59
 		$categories[$catid] = array('name' => stripslashes($row['category']));
57 60
 		$elements[$catid][] = prepareElementRowPh($row, $resourceTable, $resources);
@@ -59,7 +62,7 @@  discard block
 block discarded – undo
59 62
 
60 63
 	// Now render categories / panel-collapse
61 64
 	$panelGroup = '';
62
-	foreach($elements as $catid => $elList) {
65
+	foreach($elements as $catid => $elList) {
63 66
 		// Add panel-heading / category-collapse to output
64 67
 		$panelGroup .= parsePh($tpl['panelHeading'], array(
65 68
 			'tab' => $resourceTable,
@@ -70,7 +73,7 @@  discard block
 block discarded – undo
70 73
 
71 74
 		// Prepare content for panel-collapse
72 75
 		$panelCollapse = '';
73
-		foreach($elList as $el) {
76
+		foreach($elList as $el) {
74 77
 			$panelCollapse .= parsePh($tpl['elementsRow'], $el);
75 78
 		}
76 79
 
@@ -92,14 +95,15 @@  discard block
 block discarded – undo
92 95
  * @param mgrResources $resources
93 96
  * @return string
94 97
  */
95
-function createCombinedView($resources) {
98
+function createCombinedView($resources)
99
+{
96 100
 	global $modx, $_lang, $_style, $modx_textdir;
97 101
 
98 102
 	$itemsPerCategory = isset($resources->itemsPerCategory) ? $resources->itemsPerCategory : false;
99 103
 	$types = isset($resources->types) ? $resources->types : false;
100 104
 	$categories = isset($resources->categories) ? $resources->categories : false;
101 105
 
102
-	if(!$itemsPerCategory) {
106
+	if(!$itemsPerCategory) {
103 107
 		return $_lang['no_results'];
104 108
 	}
105 109
 
@@ -112,10 +116,10 @@  discard block
 block discarded – undo
112 116
 
113 117
 	// Easily loop through $itemsPerCategory-Array
114 118
 	$panelGroup = '';
115
-	foreach($categories as $catid => $category) {
119
+	foreach($categories as $catid => $category) {
116 120
 		// Prepare collapse content / elements-list
117 121
 		$panelCollapse = '';
118
-		foreach($itemsPerCategory[$catid] as $el) {
122
+		foreach($itemsPerCategory[$catid] as $el) {
119 123
 			$resourceTable = $el['type'];
120 124
 			$ph = prepareElementRowPh($el, $resourceTable, $resources);
121 125
 			$panelCollapse .= parsePh($tpl['elementsRow'], $ph);
@@ -149,14 +153,15 @@  discard block
 block discarded – undo
149 153
  * @param mgrResources $resources
150 154
  * @return array
151 155
  */
152
-function prepareElementRowPh($row, $resourceTable, $resources) {
156
+function prepareElementRowPh($row, $resourceTable, $resources)
157
+{
153 158
 	global $modx, $modx_textdir, $_style, $_lang;
154 159
 
155 160
 	$types = isset($resources->types[$resourceTable]) ? $resources->types[$resourceTable] : false;
156 161
 
157 162
 	$_lang["confirm_delete"] = $_lang["delete"];
158 163
 
159
-	switch($resourceTable){
164
+	switch($resourceTable) {
160 165
         case 'site_templates':
161 166
             $class = $row['selectable'] ? '' : 'disabledPlugin';
162 167
             $lockElementType = 1;
@@ -193,56 +198,56 @@  discard block
 block discarded – undo
193 198
 	// Prepare displaying user-locks
194 199
 	$lockedByUser = '';
195 200
 	$rowLock = $modx->elementIsLocked($lockElementType, $row['id'], true);
196
-	if($rowLock && $modx->hasPermission('display_locks')) {
197
-		if($rowLock['sid'] == $modx->sid) {
201
+	if($rowLock && $modx->hasPermission('display_locks')) {
202
+		if($rowLock['sid'] == $modx->sid) {
198 203
 			$title = $modx->parseText($_lang["lock_element_editing"], array(
199 204
 				'element_type' => $_lang["lock_element_type_" . $lockElementType],
200 205
 				'lasthit_df' => $rowLock['lasthit_df']
201 206
 			));
202 207
 			$lockedByUser = '<span title="' . $title . '" class="editResource" style="cursor:context-menu;">' . $_style['tree_preview_resource'] . '</span>&nbsp;';
203
-		} else {
208
+		} else {
204 209
 			$title = $modx->parseText($_lang["lock_element_locked_by"], array(
205 210
 				'element_type' => $_lang["lock_element_type_" . $lockElementType],
206 211
 				'username' => $rowLock['username'],
207 212
 				'lasthit_df' => $rowLock['lasthit_df']
208 213
 			));
209
-			if($modx->hasPermission('remove_locks')) {
214
+			if($modx->hasPermission('remove_locks')) {
210 215
 				$lockedByUser = '<a href="javascript:;" onclick="unlockElement(' . $lockElementType . ', ' . $row['id'] . ', this);return false;" title="' . $title . '" class="lockedResource"><i class="' . $_style['icons_secured'] . '"></i></a>';
211
-			} else {
216
+			} else {
212 217
 				$lockedByUser = '<span title="' . $title . '" class="lockedResource" style="cursor:context-menu;"><i class="' . $_style['icons_secured'] . '"></i></span>';
213 218
 			}
214 219
 		}
215 220
 	}
216
-	if($lockedByUser) {
221
+	if($lockedByUser) {
217 222
 		$lockedByUser = '<div class="lockCell">' . $lockedByUser . '</div>';
218 223
 	}
219 224
 
220 225
 	// Caption
221
-	if($resourceTable == 'site_tmplvars') {
226
+	if($resourceTable == 'site_tmplvars') {
222 227
 		$caption = !empty($row['description']) ? ' ' . $row['caption'] . ' &nbsp; <small>(' . $row['description'] . ')</small>' : ' ' . $row['caption'];
223
-	} else {
228
+	} else {
224 229
 		$caption = !empty($row['description']) ? ' ' . $row['description'] : '';
225 230
 	}
226 231
 
227 232
 	// Special marks
228 233
 	$tplInfo = array();
229
-	if($row['locked']) {
234
+	if($row['locked']) {
230 235
 		$tplInfo[] = $_lang['locked'];
231 236
 	}
232
-	if($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
237
+	if($row['id'] == $modx->config['default_template'] && $resourceTable == 'site_templates') {
233 238
 		$tplInfo[] = $_lang['defaulttemplate_title'];
234 239
 	}
235 240
 	$marks = !empty($tplInfo) ? ' <em>(' . implode(', ', $tplInfo) . ')</em>' : '';
236 241
 
237 242
 	/* row buttons */
238 243
 	$buttons = '';
239
-	if($modx->hasPermission($types['actions']['edit'][1])) {
244
+	if($modx->hasPermission($types['actions']['edit'][1])) {
240 245
 		$buttons .= '<li><a title="' . $_lang["edit_resource"] . '" href="index.php?a=' . $types['actions']['edit'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-edit fa-fw"></i></a></li>';
241 246
 	}
242
-	if($modx->hasPermission($types['actions']['duplicate'][1])) {
247
+	if($modx->hasPermission($types['actions']['duplicate'][1])) {
243 248
 		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_duplicate_record"] . '\')" title="' . $_lang["resource_duplicate"] . '" href="index.php?a=' . $types['actions']['duplicate'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-clone fa-fw"></i></a></li>';
244 249
 	}
245
-	if($modx->hasPermission($types['actions']['remove'][1])) {
250
+	if($modx->hasPermission($types['actions']['remove'][1])) {
246 251
 		$buttons .= '<li><a onclick="return confirm(\'' . $_lang["confirm_delete"] . '\')" title="' . $_lang["delete"] . '" href="index.php?a=' . $types['actions']['remove'][0] . '&amp;id=' . $row['id'] . '"><i class="fa fa-trash fa-fw"></i></a></li>';
247 252
 	}
248 253
 	$buttons = $buttons ? '<div class="btnCell"><ul class="elements_buttonbar">' . $buttons . '</ul></div>' : '';
Please login to merge, or discard this patch.
manager/actions/resources/mgrResources.class.php 3 patches
Indentation   +98 added lines, -98 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
     /**
8 8
      * @var array
9 9
      */
10
-	public $types = array();
10
+    public $types = array();
11 11
     /**
12 12
      * @var array
13 13
      */
@@ -25,73 +25,73 @@  discard block
 block discarded – undo
25 25
      * mgrResources constructor.
26 26
      */
27 27
     public function __construct() {
28
-		$this->setTypes();
29
-		$this->queryItemsFromDB();
30
-		$this->prepareCategoryArrays();
31
-	}
28
+        $this->setTypes();
29
+        $this->queryItemsFromDB();
30
+        $this->prepareCategoryArrays();
31
+    }
32 32
 
33 33
     /**
34 34
      * @return void
35 35
      */
36 36
     public function setTypes() {
37
-		global $_lang;
38
-		$this->types['site_templates']    = array(
39
-			'title'=>$_lang["manage_templates"],
40
-			'actions'=>array( 'edit'=>array(16,'edit_template'), 'duplicate'=>array(96,'new_template'), 'remove'=>array(21,'delete_template') ),
41
-			'permissions'=>array('new_template','edit_template'),
42
-			'name'=>'templatename'
43
-		);
44
-		$this->types['site_tmplvars']     = array(
45
-			'title'=>$_lang["tmplvars"],
46
-			'actions'=>array('edit'=>array(301,'edit_template'), 'duplicate'=>array(304,'edit_template'), 'remove'=>array(303,'edit_template')),
47
-			'permissions'=>array('new_template','edit_template'),
48
-		);
49
-		$this->types['site_htmlsnippets'] = array(
50
-			'title'=>$_lang["manage_htmlsnippets"],
51
-			'actions'=>array('edit'=>array(78,'edit_chunk'), 'duplicate'=>array(97,'new_chunk'), 'remove'=>array(80,'delete_chunk')),
52
-			'permissions'=>array('new_chunk','edit_chunk'),
53
-		);
54
-		$this->types['site_snippets']     = array(
55
-			'title'=>$_lang["manage_snippets"],
56
-			'actions'=>array('edit'=>array(22,'edit_snippet'), 'duplicate'=>array(98,'new_snippet'), 'remove'=>array(25,'delete_snippet')),
57
-			'permissions'=>array('new_snippet','edit_snippet'),
58
-		);
59
-		$this->types['site_plugins']      = array(
60
-			'title'=>$_lang["manage_plugins"],
61
-			'actions'=>array('edit'=>array(102,'edit_plugin'), 'duplicate'=>array(105,'new_plugin'), 'remove'=>array(104,'delete_plugin')),
62
-			'permissions'=>array('new_plugin','edit_plugin'),
63
-		);
64
-		$this->types['site_modules']      = array(
65
-			'title'=>$_lang["manage_modules"],
66
-			'actions'=>array('edit'=>array(108,'edit_module'), 'duplicate'=>array(111,'new_module'), 'remove'=>array(110,'delete_module')),
67
-			'permissions'=>array('new_module','edit_module'),
68
-		);
69
-	}
37
+        global $_lang;
38
+        $this->types['site_templates']    = array(
39
+            'title'=>$_lang["manage_templates"],
40
+            'actions'=>array( 'edit'=>array(16,'edit_template'), 'duplicate'=>array(96,'new_template'), 'remove'=>array(21,'delete_template') ),
41
+            'permissions'=>array('new_template','edit_template'),
42
+            'name'=>'templatename'
43
+        );
44
+        $this->types['site_tmplvars']     = array(
45
+            'title'=>$_lang["tmplvars"],
46
+            'actions'=>array('edit'=>array(301,'edit_template'), 'duplicate'=>array(304,'edit_template'), 'remove'=>array(303,'edit_template')),
47
+            'permissions'=>array('new_template','edit_template'),
48
+        );
49
+        $this->types['site_htmlsnippets'] = array(
50
+            'title'=>$_lang["manage_htmlsnippets"],
51
+            'actions'=>array('edit'=>array(78,'edit_chunk'), 'duplicate'=>array(97,'new_chunk'), 'remove'=>array(80,'delete_chunk')),
52
+            'permissions'=>array('new_chunk','edit_chunk'),
53
+        );
54
+        $this->types['site_snippets']     = array(
55
+            'title'=>$_lang["manage_snippets"],
56
+            'actions'=>array('edit'=>array(22,'edit_snippet'), 'duplicate'=>array(98,'new_snippet'), 'remove'=>array(25,'delete_snippet')),
57
+            'permissions'=>array('new_snippet','edit_snippet'),
58
+        );
59
+        $this->types['site_plugins']      = array(
60
+            'title'=>$_lang["manage_plugins"],
61
+            'actions'=>array('edit'=>array(102,'edit_plugin'), 'duplicate'=>array(105,'new_plugin'), 'remove'=>array(104,'delete_plugin')),
62
+            'permissions'=>array('new_plugin','edit_plugin'),
63
+        );
64
+        $this->types['site_modules']      = array(
65
+            'title'=>$_lang["manage_modules"],
66
+            'actions'=>array('edit'=>array(108,'edit_module'), 'duplicate'=>array(111,'new_module'), 'remove'=>array(110,'delete_module')),
67
+            'permissions'=>array('new_module','edit_module'),
68
+        );
69
+    }
70 70
 
71 71
     /**
72 72
      * @return void
73 73
      */
74 74
     public function queryItemsFromDB() {
75
-		foreach($this->types as $resourceTable=>$type) {
76
-			if($this->hasAnyPermissions($type['permissions'])) {
77
-				$nameField = isset($type['name']) ? $type['name'] : 'name';
78
-				$this->items[$resourceTable] = $this->queryResources($resourceTable, $nameField);
79
-		   }
80
-		 }
81
-	}
75
+        foreach($this->types as $resourceTable=>$type) {
76
+            if($this->hasAnyPermissions($type['permissions'])) {
77
+                $nameField = isset($type['name']) ? $type['name'] : 'name';
78
+                $this->items[$resourceTable] = $this->queryResources($resourceTable, $nameField);
79
+            }
80
+            }
81
+    }
82 82
 
83 83
     /**
84 84
      * @param array $permissions
85 85
      * @return bool
86 86
      */
87 87
     public function hasAnyPermissions($permissions) {
88
-		global $modx;
88
+        global $modx;
89 89
 
90
-		foreach($permissions as $p)
91
-			if($modx->hasPermission($p)) return true;
90
+        foreach($permissions as $p)
91
+            if($modx->hasPermission($p)) return true;
92 92
 
93
-		return false;
94
-	}
93
+        return false;
94
+    }
95 95
 
96 96
     /**
97 97
      * @param string $resourceTable
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      * @return array|bool
100 100
      */
101 101
     public function queryResources($resourceTable, $nameField = 'name') {
102
-		global $modx, $_lang;
102
+        global $modx, $_lang;
103 103
 
104 104
         $allowed = array(
105 105
             'site_htmlsnippets',
@@ -107,59 +107,59 @@  discard block
 block discarded – undo
107 107
             'site_plugins',
108 108
             'site_modules'
109 109
         );
110
-		$pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable . '.disabled, ' : '';
111
-
112
-		$tvsql  = '';
113
-		$tvjoin = '';
114
-		if ($resourceTable === 'site_tmplvars') {
115
-			$tvsql    = 'site_tmplvars.caption, ';
116
-			$tvjoin   = sprintf('LEFT JOIN %s AS stt ON site_tmplvars.id=stt.tmplvarid GROUP BY site_tmplvars.id,reltpl', $modx->getFullTableName('site_tmplvar_templates'));
117
-			$sttfield = 'IF(stt.templateid,1,0) AS reltpl,';
118
-		}
119
-		else $sttfield = '';
120
-
121
-		$selectableTemplates = $resourceTable === 'site_templates' ? "{$resourceTable}.selectable, " : "";
122
-
123
-		$rs = $modx->db->select(
124
-			"{$sttfield} {$pluginsql} {$tvsql} {$resourceTable}.{$nameField} as name, {$resourceTable}.id, {$resourceTable}.description, {$resourceTable}.locked, {$selectableTemplates}IF(isnull(categories.category),'{$_lang['no_category']}',categories.category) as category, categories.id as catid",
125
-			$modx->getFullTableName($resourceTable) . " AS {$resourceTable}
110
+        $pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable . '.disabled, ' : '';
111
+
112
+        $tvsql  = '';
113
+        $tvjoin = '';
114
+        if ($resourceTable === 'site_tmplvars') {
115
+            $tvsql    = 'site_tmplvars.caption, ';
116
+            $tvjoin   = sprintf('LEFT JOIN %s AS stt ON site_tmplvars.id=stt.tmplvarid GROUP BY site_tmplvars.id,reltpl', $modx->getFullTableName('site_tmplvar_templates'));
117
+            $sttfield = 'IF(stt.templateid,1,0) AS reltpl,';
118
+        }
119
+        else $sttfield = '';
120
+
121
+        $selectableTemplates = $resourceTable === 'site_templates' ? "{$resourceTable}.selectable, " : "";
122
+
123
+        $rs = $modx->db->select(
124
+            "{$sttfield} {$pluginsql} {$tvsql} {$resourceTable}.{$nameField} as name, {$resourceTable}.id, {$resourceTable}.description, {$resourceTable}.locked, {$selectableTemplates}IF(isnull(categories.category),'{$_lang['no_category']}',categories.category) as category, categories.id as catid",
125
+            $modx->getFullTableName($resourceTable) . " AS {$resourceTable}
126 126
 	            LEFT JOIN " . $modx->getFullTableName('categories') . " AS categories ON {$resourceTable}.category = categories.id {$tvjoin}",
127
-			"",
128
-			"category,name"
129
-		);
130
-		$limit = $modx->db->getRecordCount($rs);
127
+            "",
128
+            "category,name"
129
+        );
130
+        $limit = $modx->db->getRecordCount($rs);
131 131
 
132
-		if($limit < 1) return false;
132
+        if($limit < 1) return false;
133 133
 
134
-		$result = array();
135
-		while ($row = $modx->db->getRow($rs)) {
136
-			$result[] = $row;
137
-		}
138
-		return $result;
139
-	}
134
+        $result = array();
135
+        while ($row = $modx->db->getRow($rs)) {
136
+            $result[] = $row;
137
+        }
138
+        return $result;
139
+    }
140 140
 
141 141
     /**
142 142
      * @return void
143 143
      */
144 144
     public function prepareCategoryArrays() {
145
-		foreach($this->items as $type=>$items) {
146
-			foreach((array)$items as $item) {
147
-				$catid = $item['catid'] ? $item['catid'] : 0;
148
-				$this->categories[$catid] = $item['category'];
149
-
150
-				$item['type'] = $type;
151
-				$this->itemsPerCategory[$catid][] = $item;
152
-			}
153
-		}
154
-
155
-		// Sort categories by name
156
-		natcasesort($this->categories);
157
-
158
-		// Now sort by name
159
-		foreach($this->itemsPerCategory as $catid=>$items) {
160
-			usort($this->itemsPerCategory[$catid], function ($a, $b) {
161
-				return strcasecmp($a['name'], $b['name']);
162
-			});
163
-		}
164
-	}
145
+        foreach($this->items as $type=>$items) {
146
+            foreach((array)$items as $item) {
147
+                $catid = $item['catid'] ? $item['catid'] : 0;
148
+                $this->categories[$catid] = $item['category'];
149
+
150
+                $item['type'] = $type;
151
+                $this->itemsPerCategory[$catid][] = $item;
152
+            }
153
+        }
154
+
155
+        // Sort categories by name
156
+        natcasesort($this->categories);
157
+
158
+        // Now sort by name
159
+        foreach($this->itemsPerCategory as $catid=>$items) {
160
+            usort($this->itemsPerCategory[$catid], function ($a, $b) {
161
+                return strcasecmp($a['name'], $b['name']);
162
+            });
163
+        }
164
+    }
165 165
 }
Please login to merge, or discard this patch.
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6
-class mgrResources {
6
+class mgrResources{
7 7
     /**
8 8
      * @var array
9 9
      */
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     /**
25 25
      * mgrResources constructor.
26 26
      */
27
-    public function __construct() {
27
+    public function __construct(){
28 28
 		$this->setTypes();
29 29
 		$this->queryItemsFromDB();
30 30
 		$this->prepareCategoryArrays();
@@ -33,47 +33,47 @@  discard block
 block discarded – undo
33 33
     /**
34 34
      * @return void
35 35
      */
36
-    public function setTypes() {
36
+    public function setTypes(){
37 37
 		global $_lang;
38
-		$this->types['site_templates']    = array(
38
+		$this->types['site_templates'] = array(
39 39
 			'title'=>$_lang["manage_templates"],
40
-			'actions'=>array( 'edit'=>array(16,'edit_template'), 'duplicate'=>array(96,'new_template'), 'remove'=>array(21,'delete_template') ),
41
-			'permissions'=>array('new_template','edit_template'),
40
+			'actions'=>array('edit'=>array(16, 'edit_template'), 'duplicate'=>array(96, 'new_template'), 'remove'=>array(21, 'delete_template')),
41
+			'permissions'=>array('new_template', 'edit_template'),
42 42
 			'name'=>'templatename'
43 43
 		);
44
-		$this->types['site_tmplvars']     = array(
44
+		$this->types['site_tmplvars'] = array(
45 45
 			'title'=>$_lang["tmplvars"],
46
-			'actions'=>array('edit'=>array(301,'edit_template'), 'duplicate'=>array(304,'edit_template'), 'remove'=>array(303,'edit_template')),
47
-			'permissions'=>array('new_template','edit_template'),
46
+			'actions'=>array('edit'=>array(301, 'edit_template'), 'duplicate'=>array(304, 'edit_template'), 'remove'=>array(303, 'edit_template')),
47
+			'permissions'=>array('new_template', 'edit_template'),
48 48
 		);
49 49
 		$this->types['site_htmlsnippets'] = array(
50 50
 			'title'=>$_lang["manage_htmlsnippets"],
51
-			'actions'=>array('edit'=>array(78,'edit_chunk'), 'duplicate'=>array(97,'new_chunk'), 'remove'=>array(80,'delete_chunk')),
52
-			'permissions'=>array('new_chunk','edit_chunk'),
51
+			'actions'=>array('edit'=>array(78, 'edit_chunk'), 'duplicate'=>array(97, 'new_chunk'), 'remove'=>array(80, 'delete_chunk')),
52
+			'permissions'=>array('new_chunk', 'edit_chunk'),
53 53
 		);
54
-		$this->types['site_snippets']     = array(
54
+		$this->types['site_snippets'] = array(
55 55
 			'title'=>$_lang["manage_snippets"],
56
-			'actions'=>array('edit'=>array(22,'edit_snippet'), 'duplicate'=>array(98,'new_snippet'), 'remove'=>array(25,'delete_snippet')),
57
-			'permissions'=>array('new_snippet','edit_snippet'),
56
+			'actions'=>array('edit'=>array(22, 'edit_snippet'), 'duplicate'=>array(98, 'new_snippet'), 'remove'=>array(25, 'delete_snippet')),
57
+			'permissions'=>array('new_snippet', 'edit_snippet'),
58 58
 		);
59
-		$this->types['site_plugins']      = array(
59
+		$this->types['site_plugins'] = array(
60 60
 			'title'=>$_lang["manage_plugins"],
61
-			'actions'=>array('edit'=>array(102,'edit_plugin'), 'duplicate'=>array(105,'new_plugin'), 'remove'=>array(104,'delete_plugin')),
62
-			'permissions'=>array('new_plugin','edit_plugin'),
61
+			'actions'=>array('edit'=>array(102, 'edit_plugin'), 'duplicate'=>array(105, 'new_plugin'), 'remove'=>array(104, 'delete_plugin')),
62
+			'permissions'=>array('new_plugin', 'edit_plugin'),
63 63
 		);
64
-		$this->types['site_modules']      = array(
64
+		$this->types['site_modules'] = array(
65 65
 			'title'=>$_lang["manage_modules"],
66
-			'actions'=>array('edit'=>array(108,'edit_module'), 'duplicate'=>array(111,'new_module'), 'remove'=>array(110,'delete_module')),
67
-			'permissions'=>array('new_module','edit_module'),
66
+			'actions'=>array('edit'=>array(108, 'edit_module'), 'duplicate'=>array(111, 'new_module'), 'remove'=>array(110, 'delete_module')),
67
+			'permissions'=>array('new_module', 'edit_module'),
68 68
 		);
69 69
 	}
70 70
 
71 71
     /**
72 72
      * @return void
73 73
      */
74
-    public function queryItemsFromDB() {
75
-		foreach($this->types as $resourceTable=>$type) {
76
-			if($this->hasAnyPermissions($type['permissions'])) {
74
+    public function queryItemsFromDB(){
75
+		foreach ($this->types as $resourceTable=>$type) {
76
+			if ($this->hasAnyPermissions($type['permissions'])) {
77 77
 				$nameField = isset($type['name']) ? $type['name'] : 'name';
78 78
 				$this->items[$resourceTable] = $this->queryResources($resourceTable, $nameField);
79 79
 		   }
@@ -84,11 +84,11 @@  discard block
 block discarded – undo
84 84
      * @param array $permissions
85 85
      * @return bool
86 86
      */
87
-    public function hasAnyPermissions($permissions) {
87
+    public function hasAnyPermissions($permissions){
88 88
 		global $modx;
89 89
 
90
-		foreach($permissions as $p)
91
-			if($modx->hasPermission($p)) return true;
90
+		foreach ($permissions as $p)
91
+			if ($modx->hasPermission($p)) return true;
92 92
 
93 93
 		return false;
94 94
 	}
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
      * @param string $nameField
99 99
      * @return array|bool
100 100
      */
101
-    public function queryResources($resourceTable, $nameField = 'name') {
101
+    public function queryResources($resourceTable, $nameField = 'name'){
102 102
 		global $modx, $_lang;
103 103
 
104 104
         $allowed = array(
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
             'site_plugins',
108 108
             'site_modules'
109 109
         );
110
-		$pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable . '.disabled, ' : '';
110
+		$pluginsql = !empty($resourceTable) && in_array($resourceTable, $allowed) ? $resourceTable.'.disabled, ' : '';
111 111
 
112 112
 		$tvsql  = '';
113 113
 		$tvjoin = '';
@@ -122,14 +122,14 @@  discard block
 block discarded – undo
122 122
 
123 123
 		$rs = $modx->db->select(
124 124
 			"{$sttfield} {$pluginsql} {$tvsql} {$resourceTable}.{$nameField} as name, {$resourceTable}.id, {$resourceTable}.description, {$resourceTable}.locked, {$selectableTemplates}IF(isnull(categories.category),'{$_lang['no_category']}',categories.category) as category, categories.id as catid",
125
-			$modx->getFullTableName($resourceTable) . " AS {$resourceTable}
126
-	            LEFT JOIN " . $modx->getFullTableName('categories') . " AS categories ON {$resourceTable}.category = categories.id {$tvjoin}",
125
+			$modx->getFullTableName($resourceTable)." AS {$resourceTable}
126
+	            LEFT JOIN ".$modx->getFullTableName('categories')." AS categories ON {$resourceTable}.category = categories.id {$tvjoin}",
127 127
 			"",
128 128
 			"category,name"
129 129
 		);
130 130
 		$limit = $modx->db->getRecordCount($rs);
131 131
 
132
-		if($limit < 1) return false;
132
+		if ($limit < 1) return false;
133 133
 
134 134
 		$result = array();
135 135
 		while ($row = $modx->db->getRow($rs)) {
@@ -141,9 +141,9 @@  discard block
 block discarded – undo
141 141
     /**
142 142
      * @return void
143 143
      */
144
-    public function prepareCategoryArrays() {
145
-		foreach($this->items as $type=>$items) {
146
-			foreach((array)$items as $item) {
144
+    public function prepareCategoryArrays(){
145
+		foreach ($this->items as $type=>$items) {
146
+			foreach ((array) $items as $item) {
147 147
 				$catid = $item['catid'] ? $item['catid'] : 0;
148 148
 				$this->categories[$catid] = $item['category'];
149 149
 
@@ -156,8 +156,8 @@  discard block
 block discarded – undo
156 156
 		natcasesort($this->categories);
157 157
 
158 158
 		// Now sort by name
159
-		foreach($this->itemsPerCategory as $catid=>$items) {
160
-			usort($this->itemsPerCategory[$catid], function ($a, $b) {
159
+		foreach ($this->itemsPerCategory as $catid=>$items) {
160
+			usort($this->itemsPerCategory[$catid], function($a, $b){
161 161
 				return strcasecmp($a['name'], $b['name']);
162 162
 			});
163 163
 		}
Please login to merge, or discard this patch.
Braces   +23 added lines, -12 removed lines patch added patch discarded remove patch
@@ -3,7 +3,8 @@  discard block
 block discarded – undo
3 3
     die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6
-class mgrResources {
6
+class mgrResources
7
+{
7 8
     /**
8 9
      * @var array
9 10
      */
@@ -24,7 +25,8 @@  discard block
 block discarded – undo
24 25
     /**
25 26
      * mgrResources constructor.
26 27
      */
27
-    public function __construct() {
28
+    public function __construct()
29
+    {
28 30
 		$this->setTypes();
29 31
 		$this->queryItemsFromDB();
30 32
 		$this->prepareCategoryArrays();
@@ -33,7 +35,8 @@  discard block
 block discarded – undo
33 35
     /**
34 36
      * @return void
35 37
      */
36
-    public function setTypes() {
38
+    public function setTypes()
39
+    {
37 40
 		global $_lang;
38 41
 		$this->types['site_templates']    = array(
39 42
 			'title'=>$_lang["manage_templates"],
@@ -71,7 +74,8 @@  discard block
 block discarded – undo
71 74
     /**
72 75
      * @return void
73 76
      */
74
-    public function queryItemsFromDB() {
77
+    public function queryItemsFromDB()
78
+    {
75 79
 		foreach($this->types as $resourceTable=>$type) {
76 80
 			if($this->hasAnyPermissions($type['permissions'])) {
77 81
 				$nameField = isset($type['name']) ? $type['name'] : 'name';
@@ -84,11 +88,13 @@  discard block
 block discarded – undo
84 88
      * @param array $permissions
85 89
      * @return bool
86 90
      */
87
-    public function hasAnyPermissions($permissions) {
91
+    public function hasAnyPermissions($permissions)
92
+    {
88 93
 		global $modx;
89 94
 
90
-		foreach($permissions as $p)
91
-			if($modx->hasPermission($p)) return true;
95
+		foreach($permissions as $p) {
96
+					if($modx->hasPermission($p)) return true;
97
+		}
92 98
 
93 99
 		return false;
94 100
 	}
@@ -98,7 +104,8 @@  discard block
 block discarded – undo
98 104
      * @param string $nameField
99 105
      * @return array|bool
100 106
      */
101
-    public function queryResources($resourceTable, $nameField = 'name') {
107
+    public function queryResources($resourceTable, $nameField = 'name')
108
+    {
102 109
 		global $modx, $_lang;
103 110
 
104 111
         $allowed = array(
@@ -115,8 +122,9 @@  discard block
 block discarded – undo
115 122
 			$tvsql    = 'site_tmplvars.caption, ';
116 123
 			$tvjoin   = sprintf('LEFT JOIN %s AS stt ON site_tmplvars.id=stt.tmplvarid GROUP BY site_tmplvars.id,reltpl', $modx->getFullTableName('site_tmplvar_templates'));
117 124
 			$sttfield = 'IF(stt.templateid,1,0) AS reltpl,';
125
+		} else {
126
+		    $sttfield = '';
118 127
 		}
119
-		else $sttfield = '';
120 128
 
121 129
 		$selectableTemplates = $resourceTable === 'site_templates' ? "{$resourceTable}.selectable, " : "";
122 130
 
@@ -129,7 +137,9 @@  discard block
 block discarded – undo
129 137
 		);
130 138
 		$limit = $modx->db->getRecordCount($rs);
131 139
 
132
-		if($limit < 1) return false;
140
+		if($limit < 1) {
141
+		    return false;
142
+		}
133 143
 
134 144
 		$result = array();
135 145
 		while ($row = $modx->db->getRow($rs)) {
@@ -141,7 +151,8 @@  discard block
 block discarded – undo
141 151
     /**
142 152
      * @return void
143 153
      */
144
-    public function prepareCategoryArrays() {
154
+    public function prepareCategoryArrays()
155
+    {
145 156
 		foreach($this->items as $type=>$items) {
146 157
 			foreach((array)$items as $item) {
147 158
 				$catid = $item['catid'] ? $item['catid'] : 0;
@@ -157,7 +168,7 @@  discard block
 block discarded – undo
157 168
 
158 169
 		// Now sort by name
159 170
 		foreach($this->itemsPerCategory as $catid=>$items) {
160
-			usort($this->itemsPerCategory[$catid], function ($a, $b) {
171
+			usort($this->itemsPerCategory[$catid], function ($a, $b){
161 172
 				return strcasecmp($a['name'], $b['name']);
162 173
 			});
163 174
 		}
Please login to merge, or discard this patch.
manager/actions/files.dynamic.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -893,7 +893,9 @@
 block discarded – undo
893 893
     global $modx, $_lang, $startpath, $filemanager_path, $uploadablefiles, $new_file_permissions;
894 894
     $msg = '';
895 895
     foreach ($_FILES['userfile']['name'] as $i => $name) {
896
-        if (empty($_FILES['userfile']['tmp_name'][$i])) continue;
896
+        if (empty($_FILES['userfile']['tmp_name'][$i])) {
897
+            continue;
898
+        }
897 899
         $userfile= array();
898 900
 
899 901
         $userfile['tmp_name'] = $_FILES['userfile']['tmp_name'][$i];
Please login to merge, or discard this patch.
manager/actions/mutate_content.dynamic.php 3 patches
Indentation   +411 added lines, -411 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3
-	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
3
+    die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6 6
 /********************/
@@ -12,30 +12,30 @@  discard block
 block discarded – undo
12 12
 
13 13
 // check permissions
14 14
 switch($modx->manager->action) {
15
-	case 27:
16
-		if(!$modx->hasPermission('edit_document')) {
17
-			$modx->webAlertAndQuit($_lang["error_no_privileges"]);
18
-		}
19
-		break;
20
-	case 85:
21
-	case 72:
22
-	case 4:
23
-		if(!$modx->hasPermission('new_document')) {
24
-			$modx->webAlertAndQuit($_lang["error_no_privileges"]);
25
-		} elseif(isset($_REQUEST['pid']) && $_REQUEST['pid'] != '0') {
26
-			// check user has permissions for parent
27
-			include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
28
-			$udperms = new udperms();
29
-			$udperms->user = $modx->getLoginUserID();
30
-			$udperms->document = empty($_REQUEST['pid']) ? 0 : $_REQUEST['pid'];
31
-			$udperms->role = $_SESSION['mgrRole'];
32
-			if(!$udperms->checkPermissions()) {
33
-				$modx->webAlertAndQuit($_lang["access_permission_denied"]);
34
-			}
35
-		}
36
-		break;
37
-	default:
38
-		$modx->webAlertAndQuit($_lang["error_no_privileges"]);
15
+    case 27:
16
+        if(!$modx->hasPermission('edit_document')) {
17
+            $modx->webAlertAndQuit($_lang["error_no_privileges"]);
18
+        }
19
+        break;
20
+    case 85:
21
+    case 72:
22
+    case 4:
23
+        if(!$modx->hasPermission('new_document')) {
24
+            $modx->webAlertAndQuit($_lang["error_no_privileges"]);
25
+        } elseif(isset($_REQUEST['pid']) && $_REQUEST['pid'] != '0') {
26
+            // check user has permissions for parent
27
+            include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
28
+            $udperms = new udperms();
29
+            $udperms->user = $modx->getLoginUserID();
30
+            $udperms->document = empty($_REQUEST['pid']) ? 0 : $_REQUEST['pid'];
31
+            $udperms->role = $_SESSION['mgrRole'];
32
+            if(!$udperms->checkPermissions()) {
33
+                $modx->webAlertAndQuit($_lang["access_permission_denied"]);
34
+            }
35
+        }
36
+        break;
37
+    default:
38
+        $modx->webAlertAndQuit($_lang["error_no_privileges"]);
39 39
 }
40 40
 
41 41
 $id = isset($_REQUEST['id']) ? (int)$_REQUEST['id'] : 0;
@@ -54,22 +54,22 @@  discard block
 block discarded – undo
54 54
 $tbl_site_tmplvars = $modx->getFullTableName('site_tmplvars');
55 55
 
56 56
 if($modx->manager->action == 27) {
57
-	//editing an existing document
58
-	// check permissions on the document
59
-	include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
60
-	$udperms = new udperms();
61
-	$udperms->user = $modx->getLoginUserID();
62
-	$udperms->document = $id;
63
-	$udperms->role = $_SESSION['mgrRole'];
64
-
65
-	if(!$udperms->checkPermissions()) {
66
-		$modx->webAlertAndQuit($_lang["access_permission_denied"]);
67
-	}
57
+    //editing an existing document
58
+    // check permissions on the document
59
+    include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
60
+    $udperms = new udperms();
61
+    $udperms->user = $modx->getLoginUserID();
62
+    $udperms->document = $id;
63
+    $udperms->role = $_SESSION['mgrRole'];
64
+
65
+    if(!$udperms->checkPermissions()) {
66
+        $modx->webAlertAndQuit($_lang["access_permission_denied"]);
67
+    }
68 68
 }
69 69
 
70 70
 // check to see if resource isn't locked
71 71
 if($lockedEl = $modx->elementIsLocked(7, $id)) {
72
-	$modx->webAlertAndQuit(sprintf($_lang['lock_msg'], $lockedEl['username'], $_lang['resource']));
72
+    $modx->webAlertAndQuit(sprintf($_lang['lock_msg'], $lockedEl['username'], $_lang['resource']));
73 73
 }
74 74
 // end check for lock
75 75
 
@@ -78,74 +78,74 @@  discard block
 block discarded – undo
78 78
 
79 79
 // get document groups for current user
80 80
 if($_SESSION['mgrDocgroups']) {
81
-	$docgrp = implode(',', $_SESSION['mgrDocgroups']);
81
+    $docgrp = implode(',', $_SESSION['mgrDocgroups']);
82 82
 }
83 83
 
84 84
 if(!empty ($id)) {
85
-	$access = sprintf("1='%s' OR sc.privatemgr=0", $_SESSION['mgrRole']);
86
-	if($docgrp) {
87
-		$access .= " OR dg.document_group IN ({$docgrp})";
88
-	}
89
-	$rs = $modx->db->select('sc.*', "{$tbl_site_content} AS sc LEFT JOIN {$tbl_document_groups} AS dg ON dg.document=sc.id", "sc.id='{$id}' AND ({$access})");
90
-	$content = array();
91
-	$content = $modx->db->getRow($rs);
92
-	$modx->documentObject = &$content;
93
-	if(!$content) {
94
-		$modx->webAlertAndQuit($_lang["access_permission_denied"]);
95
-	}
96
-	$_SESSION['itemname'] = $content['pagetitle'];
85
+    $access = sprintf("1='%s' OR sc.privatemgr=0", $_SESSION['mgrRole']);
86
+    if($docgrp) {
87
+        $access .= " OR dg.document_group IN ({$docgrp})";
88
+    }
89
+    $rs = $modx->db->select('sc.*', "{$tbl_site_content} AS sc LEFT JOIN {$tbl_document_groups} AS dg ON dg.document=sc.id", "sc.id='{$id}' AND ({$access})");
90
+    $content = array();
91
+    $content = $modx->db->getRow($rs);
92
+    $modx->documentObject = &$content;
93
+    if(!$content) {
94
+        $modx->webAlertAndQuit($_lang["access_permission_denied"]);
95
+    }
96
+    $_SESSION['itemname'] = $content['pagetitle'];
97 97
 } else {
98
-	$content = array();
98
+    $content = array();
99 99
 
100
-	if(isset($_REQUEST['newtemplate'])) {
101
-		$content['template'] = $_REQUEST['newtemplate'];
102
-	} else {
103
-		$content['template'] = getDefaultTemplate();
104
-	}
100
+    if(isset($_REQUEST['newtemplate'])) {
101
+        $content['template'] = $_REQUEST['newtemplate'];
102
+    } else {
103
+        $content['template'] = getDefaultTemplate();
104
+    }
105 105
 
106
-	$_SESSION['itemname'] = $_lang["new_resource"];
106
+    $_SESSION['itemname'] = $_lang["new_resource"];
107 107
 }
108 108
 
109 109
 // restore saved form
110 110
 $formRestored = $modx->manager->loadFormValues();
111 111
 if(isset($_REQUEST['newtemplate'])) {
112
-	$formRestored = true;
112
+    $formRestored = true;
113 113
 }
114 114
 
115 115
 // retain form values if template was changed
116 116
 // edited to convert pub_date and unpub_date
117 117
 // sottwell 02-09-2006
118 118
 if($formRestored == true) {
119
-	$content = array_merge($content, $_POST);
120
-	$content['content'] = $_POST['ta'];
121
-	if(empty ($content['pub_date'])) {
122
-		unset ($content['pub_date']);
123
-	} else {
124
-		$content['pub_date'] = $modx->toTimeStamp($content['pub_date']);
125
-	}
126
-	if(empty ($content['unpub_date'])) {
127
-		unset ($content['unpub_date']);
128
-	} else {
129
-		$content['unpub_date'] = $modx->toTimeStamp($content['unpub_date']);
130
-	}
119
+    $content = array_merge($content, $_POST);
120
+    $content['content'] = $_POST['ta'];
121
+    if(empty ($content['pub_date'])) {
122
+        unset ($content['pub_date']);
123
+    } else {
124
+        $content['pub_date'] = $modx->toTimeStamp($content['pub_date']);
125
+    }
126
+    if(empty ($content['unpub_date'])) {
127
+        unset ($content['unpub_date']);
128
+    } else {
129
+        $content['unpub_date'] = $modx->toTimeStamp($content['unpub_date']);
130
+    }
131 131
 }
132 132
 
133 133
 // increase menu index if this is a new document
134 134
 if(!isset ($_REQUEST['id'])) {
135
-	if(!isset ($modx->config['auto_menuindex'])) {
136
-		$modx->config['auto_menuindex'] = 1;
137
-	}
138
-	if($modx->config['auto_menuindex']) {
139
-		$pid = (int)$_REQUEST['pid'];
140
-		$rs = $modx->db->select('count(*)', $tbl_site_content, "parent='{$pid}'");
141
-		$content['menuindex'] = $modx->db->getValue($rs);
142
-	} else {
143
-		$content['menuindex'] = 0;
144
-	}
135
+    if(!isset ($modx->config['auto_menuindex'])) {
136
+        $modx->config['auto_menuindex'] = 1;
137
+    }
138
+    if($modx->config['auto_menuindex']) {
139
+        $pid = (int)$_REQUEST['pid'];
140
+        $rs = $modx->db->select('count(*)', $tbl_site_content, "parent='{$pid}'");
141
+        $content['menuindex'] = $modx->db->getValue($rs);
142
+    } else {
143
+        $content['menuindex'] = 0;
144
+    }
145 145
 }
146 146
 
147 147
 if(isset ($_POST['which_editor'])) {
148
-	$modx->config['which_editor'] = $_POST['which_editor'];
148
+    $modx->config['which_editor'] = $_POST['which_editor'];
149 149
 }
150 150
 
151 151
 // Add lock-element JS-Script
@@ -545,23 +545,23 @@  discard block
 block discarded – undo
545 545
 
546 546
 	<form name="mutate" id="mutate" class="content" method="post" enctype="multipart/form-data" action="index.php" onsubmit="documentDirty=false;">
547 547
 		<?php
548
-		// invoke OnDocFormPrerender event
549
-		$evtOut = $modx->invokeEvent('OnDocFormPrerender', array(
550
-			'id' => $id,
551
-			'template' => $content['template']
552
-		));
553
-
554
-		if(is_array($evtOut)) {
555
-			echo implode('', $evtOut);
556
-		}
557
-
558
-		/*************************/
559
-		$dir = isset($_REQUEST['dir']) ? $_REQUEST['dir'] : '';
560
-		$sort = isset($_REQUEST['sort']) ? $_REQUEST['sort'] : 'createdon';
561
-		$page = isset($_REQUEST['page']) ? (int) $_REQUEST['page'] : '';
562
-		/*************************/
563
-
564
-		?>
548
+        // invoke OnDocFormPrerender event
549
+        $evtOut = $modx->invokeEvent('OnDocFormPrerender', array(
550
+            'id' => $id,
551
+            'template' => $content['template']
552
+        ));
553
+
554
+        if(is_array($evtOut)) {
555
+            echo implode('', $evtOut);
556
+        }
557
+
558
+        /*************************/
559
+        $dir = isset($_REQUEST['dir']) ? $_REQUEST['dir'] : '';
560
+        $sort = isset($_REQUEST['sort']) ? $_REQUEST['sort'] : 'createdon';
561
+        $page = isset($_REQUEST['page']) ? (int) $_REQUEST['page'] : '';
562
+        /*************************/
563
+
564
+        ?>
565 565
 		<input type="hidden" name="a" value="5" />
566 566
 		<input type="hidden" name="id" value="<?= $content['id'] ?>" />
567 567
 		<input type="hidden" name="mode" value="<?= $modx->manager->action ?>" />
@@ -576,54 +576,54 @@  discard block
 block discarded – undo
576 576
 
577 577
 			<h1>
578 578
 				<i class="fa fa-pencil-square-o"></i><?php if(isset($_REQUEST['id'])) {
579
-					echo iconv_substr($content['pagetitle'], 0, 50, $modx->config['modx_charset']) . (iconv_strlen($content['pagetitle'], $modx->config['modx_charset']) > 50 ? '...' : '') . '<small>(' . $_REQUEST['id'] . ')</small>';
580
-				} else {
581
-				    if ($modx->manager->action == '4') {
579
+                    echo iconv_substr($content['pagetitle'], 0, 50, $modx->config['modx_charset']) . (iconv_strlen($content['pagetitle'], $modx->config['modx_charset']) > 50 ? '...' : '') . '<small>(' . $_REQUEST['id'] . ')</small>';
580
+                } else {
581
+                    if ($modx->manager->action == '4') {
582 582
                         echo $_lang['add_resource'];
583 583
                     } else if ($modx->manager->action == '72') {
584 584
                         echo $_lang['add_weblink'];
585 585
                     } else {
586 586
                         echo $_lang['create_resource_title'];
587 587
                     }
588
-				} ?>
588
+                } ?>
589 589
 			</h1>
590 590
 
591 591
 			<?= $_style['actionbuttons']['dynamic']['document'] ?>
592 592
 
593 593
 			<?php
594
-			// breadcrumbs
595
-			if($modx->config['use_breadcrumbs']) {
596
-				$temp = array();
597
-				$title = isset($content['pagetitle']) ? $content['pagetitle'] : $_lang['create_resource_title'];
598
-
599
-				if(isset($_REQUEST['id']) && $content['parent'] != 0) {
600
-					$bID = (int) $_REQUEST['id'];
601
-					$temp = $modx->getParentIds($bID);
602
-				} else if(isset($_REQUEST['pid'])) {
603
-					$bID = (int) $_REQUEST['pid'];
604
-					$temp = $modx->getParentIds($bID);
605
-					array_unshift($temp, $bID);
606
-				}
607
-
608
-				if($temp) {
609
-					$parents = implode(',', $temp);
610
-
611
-					if(!empty($parents)) {
612
-						$where = "FIND_IN_SET(id,'{$parents}') DESC";
613
-						$rs = $modx->db->select('id, pagetitle', $tbl_site_content, "id IN ({$parents})", $where);
614
-						while($row = $modx->db->getRow($rs)) {
615
-							$out .= '<li class="breadcrumbs__li">
594
+            // breadcrumbs
595
+            if($modx->config['use_breadcrumbs']) {
596
+                $temp = array();
597
+                $title = isset($content['pagetitle']) ? $content['pagetitle'] : $_lang['create_resource_title'];
598
+
599
+                if(isset($_REQUEST['id']) && $content['parent'] != 0) {
600
+                    $bID = (int) $_REQUEST['id'];
601
+                    $temp = $modx->getParentIds($bID);
602
+                } else if(isset($_REQUEST['pid'])) {
603
+                    $bID = (int) $_REQUEST['pid'];
604
+                    $temp = $modx->getParentIds($bID);
605
+                    array_unshift($temp, $bID);
606
+                }
607
+
608
+                if($temp) {
609
+                    $parents = implode(',', $temp);
610
+
611
+                    if(!empty($parents)) {
612
+                        $where = "FIND_IN_SET(id,'{$parents}') DESC";
613
+                        $rs = $modx->db->select('id, pagetitle', $tbl_site_content, "id IN ({$parents})", $where);
614
+                        while($row = $modx->db->getRow($rs)) {
615
+                            $out .= '<li class="breadcrumbs__li">
616 616
                                 <a href="index.php?a=27&id=' . $row['id'] . '" class="breadcrumbs__a">' . htmlspecialchars($row['pagetitle'], ENT_QUOTES, $modx->config['modx_charset']) . '</a>
617 617
                                 <span class="breadcrumbs__sep">&gt;</span>
618 618
                             </li>';
619
-						}
620
-					}
621
-				}
619
+                        }
620
+                    }
621
+                }
622 622
 
623
-				$out .= '<li class="breadcrumbs__li breadcrumbs__li_current">' . $title . '</li>';
624
-				echo '<ul class="breadcrumbs">' . $out . '</ul>';
625
-			}
626
-			?>
623
+                $out .= '<li class="breadcrumbs__li breadcrumbs__li_current">' . $title . '</li>';
624
+                echo '<ul class="breadcrumbs">' . $out . '</ul>';
625
+            }
626
+            ?>
627 627
 
628 628
 			<!-- start main wrapper -->
629 629
 			<div class="sectionBody">
@@ -635,13 +635,13 @@  discard block
 block discarded – undo
635 635
 
636 636
 					<!-- General -->
637 637
 					<?php
638
-					$evtOut = $modx->invokeEvent('OnDocFormTemplateRender', array(
639
-						'id' => $id
640
-					));
641
-					if(is_array($evtOut)) {
642
-						echo implode('', $evtOut);
643
-					} else {
644
-						?>
638
+                    $evtOut = $modx->invokeEvent('OnDocFormTemplateRender', array(
639
+                        'id' => $id
640
+                    ));
641
+                    if(is_array($evtOut)) {
642
+                        echo implode('', $evtOut);
643
+                    } else {
644
+                        ?>
645 645
 						<div class="tab-page" id="tabGeneral">
646 646
 							<h2 class="tab"><?= $_lang['settings_general'] ?></h2>
647 647
 							<script type="text/javascript">tpSettings.addTabPage(document.getElementById("tabGeneral"));</script>
@@ -726,36 +726,36 @@  discard block
 block discarded – undo
726 726
 										<select id="template" name="template" class="inputBox" onchange="templateWarning();">
727 727
 											<option value="0">(blank)</option>
728 728
 											<?php
729
-											$field = "t.templatename, t.selectable, t.id, c.category";
730
-											$from = "{$tbl_site_templates} AS t LEFT JOIN {$tbl_categories} AS c ON t.category = c.id";
731
-											$rs = $modx->db->select($field, $from, '', 'c.category, t.templatename ASC');
732
-											$currentCategory = '';
733
-											while($row = $modx->db->getRow($rs)) {
734
-												if($row['selectable'] != 1 && $row['id'] != $content['template']) {
735
-													continue;
736
-												};
737
-												// Skip if not selectable but show if selected!
738
-												$thisCategory = $row['category'];
739
-												if($thisCategory == null) {
740
-													$thisCategory = $_lang["no_category"];
741
-												}
742
-												if($thisCategory != $currentCategory) {
743
-													if($closeOptGroup) {
744
-														echo "\t\t\t\t\t</optgroup>\n";
745
-													}
746
-													echo "\t\t\t\t\t<optgroup label=\"$thisCategory\">\n";
747
-													$closeOptGroup = true;
748
-												}
729
+                                            $field = "t.templatename, t.selectable, t.id, c.category";
730
+                                            $from = "{$tbl_site_templates} AS t LEFT JOIN {$tbl_categories} AS c ON t.category = c.id";
731
+                                            $rs = $modx->db->select($field, $from, '', 'c.category, t.templatename ASC');
732
+                                            $currentCategory = '';
733
+                                            while($row = $modx->db->getRow($rs)) {
734
+                                                if($row['selectable'] != 1 && $row['id'] != $content['template']) {
735
+                                                    continue;
736
+                                                };
737
+                                                // Skip if not selectable but show if selected!
738
+                                                $thisCategory = $row['category'];
739
+                                                if($thisCategory == null) {
740
+                                                    $thisCategory = $_lang["no_category"];
741
+                                                }
742
+                                                if($thisCategory != $currentCategory) {
743
+                                                    if($closeOptGroup) {
744
+                                                        echo "\t\t\t\t\t</optgroup>\n";
745
+                                                    }
746
+                                                    echo "\t\t\t\t\t<optgroup label=\"$thisCategory\">\n";
747
+                                                    $closeOptGroup = true;
748
+                                                }
749 749
 
750
-												$selectedtext = ($row['id'] == $content['template']) ? ' selected="selected"' : '';
750
+                                                $selectedtext = ($row['id'] == $content['template']) ? ' selected="selected"' : '';
751 751
 
752
-												echo "\t\t\t\t\t" . '<option value="' . $row['id'] . '"' . $selectedtext . '>' . $row['templatename'] . "</option>\n";
753
-												$currentCategory = $thisCategory;
754
-											}
755
-											if($thisCategory != '') {
756
-												echo "\t\t\t\t\t</optgroup>\n";
757
-											}
758
-											?>
752
+                                                echo "\t\t\t\t\t" . '<option value="' . $row['id'] . '"' . $selectedtext . '>' . $row['templatename'] . "</option>\n";
753
+                                                $currentCategory = $thisCategory;
754
+                                            }
755
+                                            if($thisCategory != '') {
756
+                                                echo "\t\t\t\t\t</optgroup>\n";
757
+                                            }
758
+                                            ?>
759 759
 										</select>
760 760
 									</td>
761 761
 								</tr>
@@ -795,37 +795,37 @@  discard block
 block discarded – undo
795 795
 									</td>
796 796
 									<td valign="top">
797 797
 										<?php
798
-										$parentlookup = false;
799
-										if(isset ($_REQUEST['id'])) {
800
-											if($content['parent'] == 0) {
801
-												$parentname = $site_name;
802
-											} else {
803
-												$parentlookup = $content['parent'];
804
-											}
805
-										} elseif(isset ($_REQUEST['pid'])) {
806
-											if($_REQUEST['pid'] == 0) {
807
-												$parentname = $site_name;
808
-											} else {
809
-												$parentlookup = $_REQUEST['pid'];
810
-											}
811
-										} elseif(isset($_POST['parent'])) {
812
-											if($_POST['parent'] == 0) {
813
-												$parentname = $site_name;
814
-											} else {
815
-												$parentlookup = $_POST['parent'];
816
-											}
817
-										} else {
818
-											$parentname = $site_name;
819
-											$content['parent'] = 0;
820
-										}
821
-										if($parentlookup !== false && is_numeric($parentlookup)) {
822
-											$rs = $modx->db->select('pagetitle', $tbl_site_content, "id='{$parentlookup}'");
823
-											$parentname = $modx->db->getValue($rs);
824
-											if(!$parentname) {
825
-												$modx->webAlertAndQuit($_lang["error_no_parent"]);
826
-											}
827
-										}
828
-										?>
798
+                                        $parentlookup = false;
799
+                                        if(isset ($_REQUEST['id'])) {
800
+                                            if($content['parent'] == 0) {
801
+                                                $parentname = $site_name;
802
+                                            } else {
803
+                                                $parentlookup = $content['parent'];
804
+                                            }
805
+                                        } elseif(isset ($_REQUEST['pid'])) {
806
+                                            if($_REQUEST['pid'] == 0) {
807
+                                                $parentname = $site_name;
808
+                                            } else {
809
+                                                $parentlookup = $_REQUEST['pid'];
810
+                                            }
811
+                                        } elseif(isset($_POST['parent'])) {
812
+                                            if($_POST['parent'] == 0) {
813
+                                                $parentname = $site_name;
814
+                                            } else {
815
+                                                $parentlookup = $_POST['parent'];
816
+                                            }
817
+                                        } else {
818
+                                            $parentname = $site_name;
819
+                                            $content['parent'] = 0;
820
+                                        }
821
+                                        if($parentlookup !== false && is_numeric($parentlookup)) {
822
+                                            $rs = $modx->db->select('pagetitle', $tbl_site_content, "id='{$parentlookup}'");
823
+                                            $parentname = $modx->db->getValue($rs);
824
+                                            if(!$parentname) {
825
+                                                $modx->webAlertAndQuit($_lang["error_no_parent"]);
826
+                                            }
827
+                                        }
828
+                                        ?>
829 829
 										<i id="plock" class="<?= $_style["actions_folder"] ?>" onclick="enableParentSelection(!allowParentSelection);"></i>
830 830
 										<b><span id="parentName"><?= (isset($_REQUEST['pid']) ? $_REQUEST['pid'] : $content['parent']) ?> (<?= $parentname ?>)</span></b>
831 831
 										<input type="hidden" name="parent" value="<?= (isset($_REQUEST['pid']) ? $_REQUEST['pid'] : $content['parent']) ?>" onchange="documentDirty=true;" />
@@ -833,7 +833,7 @@  discard block
 block discarded – undo
833 833
 								</tr>
834 834
 								<tr></tr>
835 835
 								<?php
836
-								/*
836
+                                /*
837 837
 								if($content['type'] == 'reference' || $modx->manager->action == '72') {
838 838
 									?>
839 839
 									<tr>
@@ -861,7 +861,7 @@  discard block
 block discarded – undo
861 861
 									</tr>
862 862
 									<?php
863 863
 								}*/
864
-								?>
864
+                                ?>
865 865
 
866 866
 								<?php if($content['type'] == 'document' || $modx->manager->action == '4') { ?>
867 867
 									<tr>
@@ -874,36 +874,36 @@  discard block
 block discarded – undo
874 874
 													<select id="which_editor" class="form-control form-control-sm" size="1" name="which_editor" onchange="changeRTE();">
875 875
 													<option value="none"><?= $_lang['none'] ?></option>
876 876
 														<?php
877
-														// invoke OnRichTextEditorRegister event
878
-														$evtOut = $modx->invokeEvent("OnRichTextEditorRegister");
879
-														if(is_array($evtOut)) {
880
-															for($i = 0; $i < count($evtOut); $i++) {
881
-																$editor = $evtOut[$i];
882
-																echo "\t\t\t", '<option value="', $editor, '"', ($modx->config['which_editor'] == $editor ? ' selected="selected"' : ''), '>', $editor, "</option>\n";
883
-															}
884
-														}
885
-														?>
877
+                                                        // invoke OnRichTextEditorRegister event
878
+                                                        $evtOut = $modx->invokeEvent("OnRichTextEditorRegister");
879
+                                                        if(is_array($evtOut)) {
880
+                                                            for($i = 0; $i < count($evtOut); $i++) {
881
+                                                                $editor = $evtOut[$i];
882
+                                                                echo "\t\t\t", '<option value="', $editor, '"', ($modx->config['which_editor'] == $editor ? ' selected="selected"' : ''), '>', $editor, "</option>\n";
883
+                                                            }
884
+                                                        }
885
+                                                        ?>
886 886
 													</select>
887 887
 												</label>
888 888
 											</div>
889 889
 											<div id="content_body">
890 890
 												<?php
891
-												if(($content['richtext'] == 1 || $modx->manager->action == '4') && $use_editor == 1) {
892
-													$htmlContent = $content['content'];
893
-													?>
891
+                                                if(($content['richtext'] == 1 || $modx->manager->action == '4') && $use_editor == 1) {
892
+                                                    $htmlContent = $content['content'];
893
+                                                    ?>
894 894
 													<div class="section-editor clearfix">
895 895
 														<textarea id="ta" name="ta" onchange="documentDirty=true;"><?= $modx->htmlspecialchars($htmlContent) ?></textarea>
896 896
 													</div>
897 897
 													<?php
898
-													// Richtext-[*content*]
899
-													$richtexteditorIds = array();
900
-													$richtexteditorOptions = array();
901
-													$richtexteditorIds[$modx->config['which_editor']][] = 'ta';
902
-													$richtexteditorOptions[$modx->config['which_editor']]['ta'] = '';
903
-												} else {
904
-													echo "\t" . '<div><textarea class="phptextarea" id="ta" name="ta" rows="20" wrap="soft" onchange="documentDirty=true;">', $modx->htmlspecialchars($content['content']), '</textarea></div>' . "\n";
905
-												}
906
-												?>
898
+                                                    // Richtext-[*content*]
899
+                                                    $richtexteditorIds = array();
900
+                                                    $richtexteditorOptions = array();
901
+                                                    $richtexteditorIds[$modx->config['which_editor']][] = 'ta';
902
+                                                    $richtexteditorOptions[$modx->config['which_editor']]['ta'] = '';
903
+                                                } else {
904
+                                                    echo "\t" . '<div><textarea class="phptextarea" id="ta" name="ta" rows="20" wrap="soft" onchange="documentDirty=true;">', $modx->htmlspecialchars($content['content']), '</textarea></div>' . "\n";
905
+                                                }
906
+                                                ?>
907 907
 											</div>
908 908
 										</td>
909 909
 									</tr>
@@ -1190,8 +1190,8 @@  discard block
 block discarded – undo
1190 1190
 
1191 1191
 								<?php
1192 1192
 
1193
-								if($_SESSION['mgrRole'] == 1 || $modx->manager->action != '27' || $_SESSION['mgrInternalKey'] == $content['createdby'] || $modx->hasPermission('change_resourcetype')) {
1194
-									?>
1193
+                                if($_SESSION['mgrRole'] == 1 || $modx->manager->action != '27' || $_SESSION['mgrInternalKey'] == $content['createdby'] || $modx->hasPermission('change_resourcetype')) {
1194
+                                    ?>
1195 1195
 									<tr>
1196 1196
 										<td>
1197 1197
 											<span class="warning"><?= $_lang['resource_type'] ?></span>
@@ -1213,15 +1213,15 @@  discard block
 block discarded – undo
1213 1213
 										<td>
1214 1214
 											<select name="contentType" class="inputBox" onchange="documentDirty=true;">
1215 1215
 												<?php
1216
-												if(!$content['contentType']) {
1217
-													$content['contentType'] = 'text/html';
1218
-												}
1219
-												$custom_contenttype = (isset ($custom_contenttype) ? $custom_contenttype : "text/html,text/plain,text/xml");
1220
-												$ct = explode(",", $custom_contenttype);
1221
-												for($i = 0; $i < count($ct); $i++) {
1222
-													echo "\t\t\t\t\t" . '<option value="' . $ct[$i] . '"' . ($content['contentType'] == $ct[$i] ? ' selected="selected"' : '') . '>' . $ct[$i] . "</option>\n";
1223
-												}
1224
-												?>
1216
+                                                if(!$content['contentType']) {
1217
+                                                    $content['contentType'] = 'text/html';
1218
+                                                }
1219
+                                                $custom_contenttype = (isset ($custom_contenttype) ? $custom_contenttype : "text/html,text/plain,text/xml");
1220
+                                                $ct = explode(",", $custom_contenttype);
1221
+                                                for($i = 0; $i < count($ct); $i++) {
1222
+                                                    echo "\t\t\t\t\t" . '<option value="' . $ct[$i] . '"' . ($content['contentType'] == $ct[$i] ? ' selected="selected"' : '') . '>' . $ct[$i] . "</option>\n";
1223
+                                                }
1224
+                                                ?>
1225 1225
 											</select>
1226 1226
 										</td>
1227 1227
 									</tr>
@@ -1244,23 +1244,23 @@  discard block
 block discarded – undo
1244 1244
 										</td>
1245 1245
 									</tr>
1246 1246
 									<?php
1247
-								} else {
1248
-									if($content['type'] != 'reference' && $modx->manager->action != '72') {
1249
-										// non-admin managers creating or editing a document resource
1250
-										?>
1247
+                                } else {
1248
+                                    if($content['type'] != 'reference' && $modx->manager->action != '72') {
1249
+                                        // non-admin managers creating or editing a document resource
1250
+                                        ?>
1251 1251
 										<input type="hidden" name="contentType" value="<?= (isset($content['contentType']) ? $content['contentType'] : "text/html") ?>" />
1252 1252
 										<input type="hidden" name="type" value="document" />
1253 1253
 										<input type="hidden" name="content_dispo" value="<?= (isset($content['content_dispo']) ? $content['content_dispo'] : '0') ?>" />
1254 1254
 										<?php
1255
-									} else {
1256
-										// non-admin managers creating or editing a reference (weblink) resource
1257
-										?>
1255
+                                    } else {
1256
+                                        // non-admin managers creating or editing a reference (weblink) resource
1257
+                                        ?>
1258 1258
 										<input type="hidden" name="type" value="reference" />
1259 1259
 										<input type="hidden" name="contentType" value="text/html" />
1260 1260
 										<?php
1261
-									}
1262
-								}//if mgrRole
1263
-								?>
1261
+                                    }
1262
+                                }//if mgrRole
1263
+                                ?>
1264 1264
 
1265 1265
 								<tr>
1266 1266
 									<td>
@@ -1343,112 +1343,112 @@  discard block
 block discarded – undo
1343 1343
                     ?>
1344 1344
 
1345 1345
 						<?php
1346
-					/*******************************
1346
+                    /*******************************
1347 1347
 					 * Document Access Permissions */
1348
-					if($use_udperms == 1) {
1349
-						$groupsarray = array();
1350
-						$sql = '';
1351
-
1352
-						$documentId = ($modx->manager->action == '27' ? $id : (!empty($_REQUEST['pid']) ? $_REQUEST['pid'] : $content['parent']));
1353
-						if($documentId > 0) {
1354
-							// Load up, the permissions from the parent (if new document) or existing document
1355
-							$rs = $modx->db->select('id, document_group', $tbl_document_groups, "document='{$documentId}'");
1356
-							while($currentgroup = $modx->db->getRow($rs)) $groupsarray[] = $currentgroup['document_group'] . ',' . $currentgroup['id'];
1357
-
1358
-							// Load up the current permissions and names
1359
-							$vs = array(
1360
-								$tbl_document_group_names,
1361
-								$tbl_document_groups,
1362
-								$documentId
1363
-							);
1364
-							$from = vsprintf("%s AS dgn LEFT JOIN %s AS groups ON groups.document_group=dgn.id AND groups.document='%s'", $vs);
1365
-							$rs = $modx->db->select('dgn.*, groups.id AS link_id', $from, '', 'name');
1366
-						} else {
1367
-							// Just load up the names, we're starting clean
1368
-							$rs = $modx->db->select('*, NULL AS link_id', $tbl_document_group_names, '', 'name');
1369
-						}
1370
-
1371
-						// retain selected doc groups between post
1372
-						if(isset($_POST['docgroups'])) {
1373
-							$groupsarray = array_merge($groupsarray, $_POST['docgroups']);
1374
-						}
1348
+                    if($use_udperms == 1) {
1349
+                        $groupsarray = array();
1350
+                        $sql = '';
1351
+
1352
+                        $documentId = ($modx->manager->action == '27' ? $id : (!empty($_REQUEST['pid']) ? $_REQUEST['pid'] : $content['parent']));
1353
+                        if($documentId > 0) {
1354
+                            // Load up, the permissions from the parent (if new document) or existing document
1355
+                            $rs = $modx->db->select('id, document_group', $tbl_document_groups, "document='{$documentId}'");
1356
+                            while($currentgroup = $modx->db->getRow($rs)) $groupsarray[] = $currentgroup['document_group'] . ',' . $currentgroup['id'];
1357
+
1358
+                            // Load up the current permissions and names
1359
+                            $vs = array(
1360
+                                $tbl_document_group_names,
1361
+                                $tbl_document_groups,
1362
+                                $documentId
1363
+                            );
1364
+                            $from = vsprintf("%s AS dgn LEFT JOIN %s AS groups ON groups.document_group=dgn.id AND groups.document='%s'", $vs);
1365
+                            $rs = $modx->db->select('dgn.*, groups.id AS link_id', $from, '', 'name');
1366
+                        } else {
1367
+                            // Just load up the names, we're starting clean
1368
+                            $rs = $modx->db->select('*, NULL AS link_id', $tbl_document_group_names, '', 'name');
1369
+                        }
1370
+
1371
+                        // retain selected doc groups between post
1372
+                        if(isset($_POST['docgroups'])) {
1373
+                            $groupsarray = array_merge($groupsarray, $_POST['docgroups']);
1374
+                        }
1375
+
1376
+                        $isManager = $modx->hasPermission('access_permissions');
1377
+                        $isWeb = $modx->hasPermission('web_access_permissions');
1378
+
1379
+                        // Setup Basic attributes for each Input box
1380
+                        $inputAttributes = array(
1381
+                            'type' => 'checkbox',
1382
+                            'class' => 'checkbox',
1383
+                            'name' => 'docgroups[]',
1384
+                            'onclick' => 'makePublic(false);',
1385
+                        );
1386
+                        $permissions = array(); // New Permissions array list (this contains the HTML)
1387
+                        $permissions_yes = 0; // count permissions the current mgr user has
1388
+                        $permissions_no = 0; // count permissions the current mgr user doesn't have
1389
+
1390
+                        // Loop through the permissions list
1391
+                        while($row = $modx->db->getRow($rs)) {
1392
+
1393
+                            // Create an inputValue pair (group ID and group link (if it exists))
1394
+                            $inputValue = $row['id'] . ',' . ($row['link_id'] ? $row['link_id'] : 'new');
1395
+                            $inputId = 'group-' . $row['id'];
1396
+
1397
+                            $checked = in_array($inputValue, $groupsarray);
1398
+                            if($checked) {
1399
+                                $notPublic = true;
1400
+                            } // Mark as private access (either web or manager)
1401
+
1402
+                            // Skip the access permission if the user doesn't have access...
1403
+                            if((!$isManager && $row['private_memgroup'] == '1') || (!$isWeb && $row['private_webgroup'] == '1')) {
1404
+                                continue;
1405
+                            }
1375 1406
 
1376
-						$isManager = $modx->hasPermission('access_permissions');
1377
-						$isWeb = $modx->hasPermission('web_access_permissions');
1378
-
1379
-						// Setup Basic attributes for each Input box
1380
-						$inputAttributes = array(
1381
-							'type' => 'checkbox',
1382
-							'class' => 'checkbox',
1383
-							'name' => 'docgroups[]',
1384
-							'onclick' => 'makePublic(false);',
1385
-						);
1386
-						$permissions = array(); // New Permissions array list (this contains the HTML)
1387
-						$permissions_yes = 0; // count permissions the current mgr user has
1388
-						$permissions_no = 0; // count permissions the current mgr user doesn't have
1389
-
1390
-						// Loop through the permissions list
1391
-						while($row = $modx->db->getRow($rs)) {
1392
-
1393
-							// Create an inputValue pair (group ID and group link (if it exists))
1394
-							$inputValue = $row['id'] . ',' . ($row['link_id'] ? $row['link_id'] : 'new');
1395
-							$inputId = 'group-' . $row['id'];
1396
-
1397
-							$checked = in_array($inputValue, $groupsarray);
1398
-							if($checked) {
1399
-								$notPublic = true;
1400
-							} // Mark as private access (either web or manager)
1401
-
1402
-							// Skip the access permission if the user doesn't have access...
1403
-							if((!$isManager && $row['private_memgroup'] == '1') || (!$isWeb && $row['private_webgroup'] == '1')) {
1404
-								continue;
1405
-							}
1406
-
1407
-							// Setup attributes for this Input box
1408
-							$inputAttributes['id'] = $inputId;
1409
-							$inputAttributes['value'] = $inputValue;
1410
-							if($checked) {
1411
-								$inputAttributes['checked'] = 'checked';
1412
-							} else {
1413
-								unset($inputAttributes['checked']);
1414
-							}
1415
-
1416
-							// Create attribute string list
1417
-							$inputString = array();
1418
-							foreach($inputAttributes as $k => $v) $inputString[] = $k . '="' . $v . '"';
1419
-
1420
-							// Make the <input> HTML
1421
-							$inputHTML = '<input ' . implode(' ', $inputString) . ' />';
1422
-
1423
-							// does user have this permission?
1424
-							$from = "{$tbl_membergroup_access} AS mga, {$tbl_member_groups} AS mg";
1425
-							$vs = array(
1426
-								$row['id'],
1427
-								$_SESSION['mgrInternalKey']
1428
-							);
1429
-							$where = vsprintf("mga.membergroup=mg.user_group AND mga.documentgroup=%s AND mg.member=%s", $vs);
1430
-							$rsp = $modx->db->select('COUNT(mg.id)', $from, $where);
1431
-							$count = $modx->db->getValue($rsp);
1432
-							if($count > 0) {
1433
-								++$permissions_yes;
1434
-							} else {
1435
-								++$permissions_no;
1436
-							}
1437
-							$permissions[] = "\t\t" . '<li>' . $inputHTML . '<label for="' . $inputId . '">' . $row['name'] . '</label></li>';
1438
-						}
1439
-						// if mgr user doesn't have access to any of the displayable permissions, forget about them and make doc public
1440
-						if($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0)) {
1441
-							$permissions = array();
1442
-						}
1407
+                            // Setup attributes for this Input box
1408
+                            $inputAttributes['id'] = $inputId;
1409
+                            $inputAttributes['value'] = $inputValue;
1410
+                            if($checked) {
1411
+                                $inputAttributes['checked'] = 'checked';
1412
+                            } else {
1413
+                                unset($inputAttributes['checked']);
1414
+                            }
1443 1415
 
1444
-						// See if the Access Permissions section is worth displaying...
1445
-						if(!empty($permissions)) {
1446
-							// Add the "All Document Groups" item if we have rights in both contexts
1447
-							if($isManager && $isWeb) {
1448
-								array_unshift($permissions, "\t\t" . '<li><input type="checkbox" class="checkbox" name="chkalldocs" id="groupall"' . (!$notPublic ? ' checked="checked"' : '') . ' onclick="makePublic(true);" /><label for="groupall" class="warning">' . $_lang['all_doc_groups'] . '</label></li>');
1449
-							}
1450
-							// Output the permissions list...
1451
-							?>
1416
+                            // Create attribute string list
1417
+                            $inputString = array();
1418
+                            foreach($inputAttributes as $k => $v) $inputString[] = $k . '="' . $v . '"';
1419
+
1420
+                            // Make the <input> HTML
1421
+                            $inputHTML = '<input ' . implode(' ', $inputString) . ' />';
1422
+
1423
+                            // does user have this permission?
1424
+                            $from = "{$tbl_membergroup_access} AS mga, {$tbl_member_groups} AS mg";
1425
+                            $vs = array(
1426
+                                $row['id'],
1427
+                                $_SESSION['mgrInternalKey']
1428
+                            );
1429
+                            $where = vsprintf("mga.membergroup=mg.user_group AND mga.documentgroup=%s AND mg.member=%s", $vs);
1430
+                            $rsp = $modx->db->select('COUNT(mg.id)', $from, $where);
1431
+                            $count = $modx->db->getValue($rsp);
1432
+                            if($count > 0) {
1433
+                                ++$permissions_yes;
1434
+                            } else {
1435
+                                ++$permissions_no;
1436
+                            }
1437
+                            $permissions[] = "\t\t" . '<li>' . $inputHTML . '<label for="' . $inputId . '">' . $row['name'] . '</label></li>';
1438
+                        }
1439
+                        // if mgr user doesn't have access to any of the displayable permissions, forget about them and make doc public
1440
+                        if($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0)) {
1441
+                            $permissions = array();
1442
+                        }
1443
+
1444
+                        // See if the Access Permissions section is worth displaying...
1445
+                        if(!empty($permissions)) {
1446
+                            // Add the "All Document Groups" item if we have rights in both contexts
1447
+                            if($isManager && $isWeb) {
1448
+                                array_unshift($permissions, "\t\t" . '<li><input type="checkbox" class="checkbox" name="chkalldocs" id="groupall"' . (!$notPublic ? ' checked="checked"' : '') . ' onclick="makePublic(true);" /><label for="groupall" class="warning">' . $_lang['all_doc_groups'] . '</label></li>');
1449
+                            }
1450
+                            // Output the permissions list...
1451
+                            ?>
1452 1452
 							<!-- Access Permissions -->
1453 1453
 							<div class="tab-page" id="tabAccess">
1454 1454
 								<h2 class="tab" id="tab_access_header"><?= $_lang['access_permissions'] ?></h2>
@@ -1482,31 +1482,31 @@  discard block
 block discarded – undo
1482 1482
 								</ul>
1483 1483
 							</div><!--div class="tab-page" id="tabAccess"-->
1484 1484
 							<?php
1485
-						} // !empty($permissions)
1486
-						elseif($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0) && ($_SESSION['mgrPermissions']['access_permissions'] == 1 || $_SESSION['mgrPermissions']['web_access_permissions'] == 1)) {
1487
-							?>
1485
+                        } // !empty($permissions)
1486
+                        elseif($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0) && ($_SESSION['mgrPermissions']['access_permissions'] == 1 || $_SESSION['mgrPermissions']['web_access_permissions'] == 1)) {
1487
+                            ?>
1488 1488
 							<p><?= $_lang["access_permissions_docs_collision"] ?></p>
1489 1489
 							<?php
1490 1490
 
1491
-						}
1492
-					}
1493
-					/* End Document Access Permissions *
1491
+                        }
1492
+                    }
1493
+                    /* End Document Access Permissions *
1494 1494
 					 ***********************************/
1495
-					?>
1495
+                    ?>
1496 1496
 
1497 1497
 					<input type="submit" name="save" style="display:none" />
1498 1498
 					<?php
1499 1499
 
1500
-					// invoke OnDocFormRender event
1501
-					$evtOut = $modx->invokeEvent('OnDocFormRender', array(
1502
-						'id' => $id,
1503
-						'template' => $content['template']
1504
-					));
1500
+                    // invoke OnDocFormRender event
1501
+                    $evtOut = $modx->invokeEvent('OnDocFormRender', array(
1502
+                        'id' => $id,
1503
+                        'template' => $content['template']
1504
+                    ));
1505 1505
 
1506
-					if(is_array($evtOut)) {
1507
-						echo implode('', $evtOut);
1508
-					}
1509
-					?>
1506
+                    if(is_array($evtOut)) {
1507
+                        echo implode('', $evtOut);
1508
+                    }
1509
+                    ?>
1510 1510
 				</div><!--div class="tab-pane" id="documentPane"-->
1511 1511
 			</div><!--div class="sectionBody"-->
1512 1512
 		</fieldset>
@@ -1517,63 +1517,63 @@  discard block
 block discarded – undo
1517 1517
 	</script>
1518 1518
 <?php
1519 1519
 if(($content['richtext'] == 1 || $modx->manager->action == '4' || $modx->manager->action == '72') && $use_editor == 1) {
1520
-	if(is_array($richtexteditorIds)) {
1521
-		foreach($richtexteditorIds as $editor => $elements) {
1522
-			// invoke OnRichTextEditorInit event
1523
-			$evtOut = $modx->invokeEvent('OnRichTextEditorInit', array(
1524
-				'editor' => $editor,
1525
-				'elements' => $elements,
1526
-				'options' => $richtexteditorOptions[$editor]
1527
-			));
1528
-			if(is_array($evtOut)) {
1529
-				echo implode('', $evtOut);
1530
-			}
1531
-		}
1532
-	}
1520
+    if(is_array($richtexteditorIds)) {
1521
+        foreach($richtexteditorIds as $editor => $elements) {
1522
+            // invoke OnRichTextEditorInit event
1523
+            $evtOut = $modx->invokeEvent('OnRichTextEditorInit', array(
1524
+                'editor' => $editor,
1525
+                'elements' => $elements,
1526
+                'options' => $richtexteditorOptions[$editor]
1527
+            ));
1528
+            if(is_array($evtOut)) {
1529
+                echo implode('', $evtOut);
1530
+            }
1531
+        }
1532
+    }
1533 1533
 }
1534 1534
 
1535 1535
 /**
1536 1536
  * @return string
1537 1537
  */
1538 1538
 function getDefaultTemplate() {
1539
-	global $modx;
1539
+    global $modx;
1540 1540
 
1541 1541
     $default_template = '';
1542
-	switch($modx->config['auto_template_logic']) {
1543
-		case 'sibling':
1544
-			if(!isset($_GET['pid']) || empty($_GET['pid'])) {
1545
-				$site_start = $modx->config['site_start'];
1546
-				$where = "sc.isfolder=0 AND sc.id!='{$site_start}'";
1547
-				$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', $where, 'menuindex', 'ASC', 1);
1548
-				if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1549
-					$default_template = $sibl[0]['template'];
1550
-				}
1551
-			} else {
1552
-				$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1553
-				if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1554
-					$default_template = $sibl[0]['template'];
1555
-				} else {
1556
-					$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 0, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1557
-					if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1558
-						$default_template = $sibl[0]['template'];
1559
-					}
1560
-				}
1561
-			}
1562
-			if(isset($default_template)) {
1563
-				break;
1564
-			} // If $default_template could not be determined, fall back / through to "parent"-mode
1565
-		case 'parent':
1566
-			if(isset($_REQUEST['pid']) && !empty($_REQUEST['pid'])) {
1567
-				$parent = $modx->getPageInfo($_REQUEST['pid'], 0, 'template');
1568
-				if(isset($parent['template'])) {
1569
-					$default_template = $parent['template'];
1570
-				}
1571
-			}
1572
-			break;
1573
-		case 'system':
1574
-		default: // default_template is already set
1575
-			$default_template = $modx->config['default_template'];
1576
-	}
1577
-
1578
-	return empty($default_template) ? $modx->config['default_template'] : $default_template;
1542
+    switch($modx->config['auto_template_logic']) {
1543
+        case 'sibling':
1544
+            if(!isset($_GET['pid']) || empty($_GET['pid'])) {
1545
+                $site_start = $modx->config['site_start'];
1546
+                $where = "sc.isfolder=0 AND sc.id!='{$site_start}'";
1547
+                $sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', $where, 'menuindex', 'ASC', 1);
1548
+                if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1549
+                    $default_template = $sibl[0]['template'];
1550
+                }
1551
+            } else {
1552
+                $sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1553
+                if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1554
+                    $default_template = $sibl[0]['template'];
1555
+                } else {
1556
+                    $sibl = $modx->getDocumentChildren($_REQUEST['pid'], 0, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1557
+                    if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1558
+                        $default_template = $sibl[0]['template'];
1559
+                    }
1560
+                }
1561
+            }
1562
+            if(isset($default_template)) {
1563
+                break;
1564
+            } // If $default_template could not be determined, fall back / through to "parent"-mode
1565
+        case 'parent':
1566
+            if(isset($_REQUEST['pid']) && !empty($_REQUEST['pid'])) {
1567
+                $parent = $modx->getPageInfo($_REQUEST['pid'], 0, 'template');
1568
+                if(isset($parent['template'])) {
1569
+                    $default_template = $parent['template'];
1570
+                }
1571
+            }
1572
+            break;
1573
+        case 'system':
1574
+        default: // default_template is already set
1575
+            $default_template = $modx->config['default_template'];
1576
+    }
1577
+
1578
+    return empty($default_template) ? $modx->config['default_template'] : $default_template;
1579 1579
 }
Please login to merge, or discard this patch.
Spacing   +145 added lines, -145 removed lines patch added patch discarded remove patch
@@ -1,35 +1,35 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if( ! defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
2
+if (!defined('IN_MANAGER_MODE') || IN_MANAGER_MODE !== true) {
3 3
 	die("<b>INCLUDE_ORDERING_ERROR</b><br /><br />Please use the EVO Content Manager instead of accessing this file directly.");
4 4
 }
5 5
 
6 6
 /********************/
7
-$sd = isset($_REQUEST['dir']) ? '&dir=' . $_REQUEST['dir'] : '&dir=DESC';
8
-$sb = isset($_REQUEST['sort']) ? '&sort=' . $_REQUEST['sort'] : '&sort=createdon';
9
-$pg = isset($_REQUEST['page']) ? '&page=' . (int) $_REQUEST['page'] : '';
10
-$add_path = $sd . $sb . $pg;
7
+$sd = isset($_REQUEST['dir']) ? '&dir='.$_REQUEST['dir'] : '&dir=DESC';
8
+$sb = isset($_REQUEST['sort']) ? '&sort='.$_REQUEST['sort'] : '&sort=createdon';
9
+$pg = isset($_REQUEST['page']) ? '&page='.(int) $_REQUEST['page'] : '';
10
+$add_path = $sd.$sb.$pg;
11 11
 /*******************/
12 12
 
13 13
 // check permissions
14
-switch($modx->manager->action) {
14
+switch ($modx->manager->action) {
15 15
 	case 27:
16
-		if(!$modx->hasPermission('edit_document')) {
16
+		if (!$modx->hasPermission('edit_document')) {
17 17
 			$modx->webAlertAndQuit($_lang["error_no_privileges"]);
18 18
 		}
19 19
 		break;
20 20
 	case 85:
21 21
 	case 72:
22 22
 	case 4:
23
-		if(!$modx->hasPermission('new_document')) {
23
+		if (!$modx->hasPermission('new_document')) {
24 24
 			$modx->webAlertAndQuit($_lang["error_no_privileges"]);
25
-		} elseif(isset($_REQUEST['pid']) && $_REQUEST['pid'] != '0') {
25
+		} elseif (isset($_REQUEST['pid']) && $_REQUEST['pid'] != '0') {
26 26
 			// check user has permissions for parent
27
-			include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
27
+			include_once(MODX_MANAGER_PATH.'processors/user_documents_permissions.class.php');
28 28
 			$udperms = new udperms();
29 29
 			$udperms->user = $modx->getLoginUserID();
30 30
 			$udperms->document = empty($_REQUEST['pid']) ? 0 : $_REQUEST['pid'];
31 31
 			$udperms->role = $_SESSION['mgrRole'];
32
-			if(!$udperms->checkPermissions()) {
32
+			if (!$udperms->checkPermissions()) {
33 33
 				$modx->webAlertAndQuit($_lang["access_permission_denied"]);
34 34
 			}
35 35
 		}
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 		$modx->webAlertAndQuit($_lang["error_no_privileges"]);
39 39
 }
40 40
 
41
-$id = isset($_REQUEST['id']) ? (int)$_REQUEST['id'] : 0;
41
+$id = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : 0;
42 42
 
43 43
 // Get table names (alphabetical)
44 44
 $tbl_categories = $modx->getFullTableName('categories');
@@ -53,22 +53,22 @@  discard block
 block discarded – undo
53 53
 $tbl_site_tmplvar_templates = $modx->getFullTableName('site_tmplvar_templates');
54 54
 $tbl_site_tmplvars = $modx->getFullTableName('site_tmplvars');
55 55
 
56
-if($modx->manager->action == 27) {
56
+if ($modx->manager->action == 27) {
57 57
 	//editing an existing document
58 58
 	// check permissions on the document
59
-	include_once(MODX_MANAGER_PATH . 'processors/user_documents_permissions.class.php');
59
+	include_once(MODX_MANAGER_PATH.'processors/user_documents_permissions.class.php');
60 60
 	$udperms = new udperms();
61 61
 	$udperms->user = $modx->getLoginUserID();
62 62
 	$udperms->document = $id;
63 63
 	$udperms->role = $_SESSION['mgrRole'];
64 64
 
65
-	if(!$udperms->checkPermissions()) {
65
+	if (!$udperms->checkPermissions()) {
66 66
 		$modx->webAlertAndQuit($_lang["access_permission_denied"]);
67 67
 	}
68 68
 }
69 69
 
70 70
 // check to see if resource isn't locked
71
-if($lockedEl = $modx->elementIsLocked(7, $id)) {
71
+if ($lockedEl = $modx->elementIsLocked(7, $id)) {
72 72
 	$modx->webAlertAndQuit(sprintf($_lang['lock_msg'], $lockedEl['username'], $_lang['resource']));
73 73
 }
74 74
 // end check for lock
@@ -77,27 +77,27 @@  discard block
 block discarded – undo
77 77
 $modx->lockElement(7, $id);
78 78
 
79 79
 // get document groups for current user
80
-if($_SESSION['mgrDocgroups']) {
80
+if ($_SESSION['mgrDocgroups']) {
81 81
 	$docgrp = implode(',', $_SESSION['mgrDocgroups']);
82 82
 }
83 83
 
84
-if(!empty ($id)) {
84
+if (!empty ($id)) {
85 85
 	$access = sprintf("1='%s' OR sc.privatemgr=0", $_SESSION['mgrRole']);
86
-	if($docgrp) {
86
+	if ($docgrp) {
87 87
 		$access .= " OR dg.document_group IN ({$docgrp})";
88 88
 	}
89 89
 	$rs = $modx->db->select('sc.*', "{$tbl_site_content} AS sc LEFT JOIN {$tbl_document_groups} AS dg ON dg.document=sc.id", "sc.id='{$id}' AND ({$access})");
90 90
 	$content = array();
91 91
 	$content = $modx->db->getRow($rs);
92 92
 	$modx->documentObject = &$content;
93
-	if(!$content) {
93
+	if (!$content) {
94 94
 		$modx->webAlertAndQuit($_lang["access_permission_denied"]);
95 95
 	}
96 96
 	$_SESSION['itemname'] = $content['pagetitle'];
97 97
 } else {
98 98
 	$content = array();
99 99
 
100
-	if(isset($_REQUEST['newtemplate'])) {
100
+	if (isset($_REQUEST['newtemplate'])) {
101 101
 		$content['template'] = $_REQUEST['newtemplate'];
102 102
 	} else {
103 103
 		$content['template'] = getDefaultTemplate();
@@ -108,22 +108,22 @@  discard block
 block discarded – undo
108 108
 
109 109
 // restore saved form
110 110
 $formRestored = $modx->manager->loadFormValues();
111
-if(isset($_REQUEST['newtemplate'])) {
111
+if (isset($_REQUEST['newtemplate'])) {
112 112
 	$formRestored = true;
113 113
 }
114 114
 
115 115
 // retain form values if template was changed
116 116
 // edited to convert pub_date and unpub_date
117 117
 // sottwell 02-09-2006
118
-if($formRestored == true) {
118
+if ($formRestored == true) {
119 119
 	$content = array_merge($content, $_POST);
120 120
 	$content['content'] = $_POST['ta'];
121
-	if(empty ($content['pub_date'])) {
121
+	if (empty ($content['pub_date'])) {
122 122
 		unset ($content['pub_date']);
123 123
 	} else {
124 124
 		$content['pub_date'] = $modx->toTimeStamp($content['pub_date']);
125 125
 	}
126
-	if(empty ($content['unpub_date'])) {
126
+	if (empty ($content['unpub_date'])) {
127 127
 		unset ($content['unpub_date']);
128 128
 	} else {
129 129
 		$content['unpub_date'] = $modx->toTimeStamp($content['unpub_date']);
@@ -131,12 +131,12 @@  discard block
 block discarded – undo
131 131
 }
132 132
 
133 133
 // increase menu index if this is a new document
134
-if(!isset ($_REQUEST['id'])) {
135
-	if(!isset ($modx->config['auto_menuindex'])) {
134
+if (!isset ($_REQUEST['id'])) {
135
+	if (!isset ($modx->config['auto_menuindex'])) {
136 136
 		$modx->config['auto_menuindex'] = 1;
137 137
 	}
138
-	if($modx->config['auto_menuindex']) {
139
-		$pid = (int)$_REQUEST['pid'];
138
+	if ($modx->config['auto_menuindex']) {
139
+		$pid = (int) $_REQUEST['pid'];
140 140
 		$rs = $modx->db->select('count(*)', $tbl_site_content, "parent='{$pid}'");
141 141
 		$content['menuindex'] = $modx->db->getValue($rs);
142 142
 	} else {
@@ -144,14 +144,14 @@  discard block
 block discarded – undo
144 144
 	}
145 145
 }
146 146
 
147
-if(isset ($_POST['which_editor'])) {
147
+if (isset ($_POST['which_editor'])) {
148 148
 	$modx->config['which_editor'] = $_POST['which_editor'];
149 149
 }
150 150
 
151 151
 // Add lock-element JS-Script
152 152
 $lockElementId = $id;
153 153
 $lockElementType = 7;
154
-require_once(MODX_MANAGER_PATH . 'includes/active_user_locks.inc.php');
154
+require_once(MODX_MANAGER_PATH.'includes/active_user_locks.inc.php');
155 155
 ?>
156 156
 	<script type="text/javascript">
157 157
 		/* <![CDATA[ */
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 			},
182 182
 			cancel: function() {
183 183
 				documentDirty = false;
184
-				document.location.href = 'index.php?<?=($id == 0 ? 'a=2' : 'a=3&r=1&id=' . $id . $add_path) ?>';
184
+				document.location.href = 'index.php?<?=($id == 0 ? 'a=2' : 'a=3&r=1&id='.$id.$add_path) ?>';
185 185
 			},
186 186
 			duplicate: function() {
187 187
 				if(confirm("<?= $_lang['confirm_resource_duplicate']?>") === true) {
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 				}
190 190
 			},
191 191
 			view: function() {
192
-				window.open('<?= ($modx->config['friendly_urls'] == '1') ? $modx->makeUrl($id) : $modx->config['site_url'] . 'index.php?id=' . $id ?>', 'previeWin');
192
+				window.open('<?= ($modx->config['friendly_urls'] == '1') ? $modx->makeUrl($id) : $modx->config['site_url'].'index.php?id='.$id ?>', 'previeWin');
193 193
 			}
194 194
 		};
195 195
 
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
 			'template' => $content['template']
552 552
 		));
553 553
 
554
-		if(is_array($evtOut)) {
554
+		if (is_array($evtOut)) {
555 555
 			echo implode('', $evtOut);
556 556
 		}
557 557
 
@@ -575,8 +575,8 @@  discard block
 block discarded – undo
575 575
 		<fieldset id="create_edit">
576 576
 
577 577
 			<h1>
578
-				<i class="fa fa-pencil-square-o"></i><?php if(isset($_REQUEST['id'])) {
579
-					echo iconv_substr($content['pagetitle'], 0, 50, $modx->config['modx_charset']) . (iconv_strlen($content['pagetitle'], $modx->config['modx_charset']) > 50 ? '...' : '') . '<small>(' . $_REQUEST['id'] . ')</small>';
578
+				<i class="fa fa-pencil-square-o"></i><?php if (isset($_REQUEST['id'])) {
579
+					echo iconv_substr($content['pagetitle'], 0, 50, $modx->config['modx_charset']).(iconv_strlen($content['pagetitle'], $modx->config['modx_charset']) > 50 ? '...' : '').'<small>('.$_REQUEST['id'].')</small>';
580 580
 				} else {
581 581
 				    if ($modx->manager->action == '4') {
582 582
                         echo $_lang['add_resource'];
@@ -592,36 +592,36 @@  discard block
 block discarded – undo
592 592
 
593 593
 			<?php
594 594
 			// breadcrumbs
595
-			if($modx->config['use_breadcrumbs']) {
595
+			if ($modx->config['use_breadcrumbs']) {
596 596
 				$temp = array();
597 597
 				$title = isset($content['pagetitle']) ? $content['pagetitle'] : $_lang['create_resource_title'];
598 598
 
599
-				if(isset($_REQUEST['id']) && $content['parent'] != 0) {
599
+				if (isset($_REQUEST['id']) && $content['parent'] != 0) {
600 600
 					$bID = (int) $_REQUEST['id'];
601 601
 					$temp = $modx->getParentIds($bID);
602
-				} else if(isset($_REQUEST['pid'])) {
602
+				} else if (isset($_REQUEST['pid'])) {
603 603
 					$bID = (int) $_REQUEST['pid'];
604 604
 					$temp = $modx->getParentIds($bID);
605 605
 					array_unshift($temp, $bID);
606 606
 				}
607 607
 
608
-				if($temp) {
608
+				if ($temp) {
609 609
 					$parents = implode(',', $temp);
610 610
 
611
-					if(!empty($parents)) {
611
+					if (!empty($parents)) {
612 612
 						$where = "FIND_IN_SET(id,'{$parents}') DESC";
613 613
 						$rs = $modx->db->select('id, pagetitle', $tbl_site_content, "id IN ({$parents})", $where);
614
-						while($row = $modx->db->getRow($rs)) {
614
+						while ($row = $modx->db->getRow($rs)) {
615 615
 							$out .= '<li class="breadcrumbs__li">
616
-                                <a href="index.php?a=27&id=' . $row['id'] . '" class="breadcrumbs__a">' . htmlspecialchars($row['pagetitle'], ENT_QUOTES, $modx->config['modx_charset']) . '</a>
616
+                                <a href="index.php?a=27&id=' . $row['id'].'" class="breadcrumbs__a">'.htmlspecialchars($row['pagetitle'], ENT_QUOTES, $modx->config['modx_charset']).'</a>
617 617
                                 <span class="breadcrumbs__sep">&gt;</span>
618 618
                             </li>';
619 619
 						}
620 620
 					}
621 621
 				}
622 622
 
623
-				$out .= '<li class="breadcrumbs__li breadcrumbs__li_current">' . $title . '</li>';
624
-				echo '<ul class="breadcrumbs">' . $out . '</ul>';
623
+				$out .= '<li class="breadcrumbs__li breadcrumbs__li_current">'.$title.'</li>';
624
+				echo '<ul class="breadcrumbs">'.$out.'</ul>';
625 625
 			}
626 626
 			?>
627 627
 
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 					$evtOut = $modx->invokeEvent('OnDocFormTemplateRender', array(
639 639
 						'id' => $id
640 640
 					));
641
-					if(is_array($evtOut)) {
641
+					if (is_array($evtOut)) {
642 642
 						echo implode('', $evtOut);
643 643
 					} else {
644 644
 						?>
@@ -694,7 +694,7 @@  discard block
 block discarded – undo
694 694
 									</td>
695 695
 								</tr>
696 696
 
697
-								<?php if($content['type'] == 'reference' || $modx->manager->action == '72') { // Web Link specific ?>
697
+								<?php if ($content['type'] == 'reference' || $modx->manager->action == '72') { // Web Link specific ?>
698 698
 
699 699
 									<tr>
700 700
 										<td><span class="warning"><?= $_lang['weblink'] ?></span>
@@ -730,17 +730,17 @@  discard block
 block discarded – undo
730 730
 											$from = "{$tbl_site_templates} AS t LEFT JOIN {$tbl_categories} AS c ON t.category = c.id";
731 731
 											$rs = $modx->db->select($field, $from, '', 'c.category, t.templatename ASC');
732 732
 											$currentCategory = '';
733
-											while($row = $modx->db->getRow($rs)) {
734
-												if($row['selectable'] != 1 && $row['id'] != $content['template']) {
733
+											while ($row = $modx->db->getRow($rs)) {
734
+												if ($row['selectable'] != 1 && $row['id'] != $content['template']) {
735 735
 													continue;
736 736
 												};
737 737
 												// Skip if not selectable but show if selected!
738 738
 												$thisCategory = $row['category'];
739
-												if($thisCategory == null) {
739
+												if ($thisCategory == null) {
740 740
 													$thisCategory = $_lang["no_category"];
741 741
 												}
742
-												if($thisCategory != $currentCategory) {
743
-													if($closeOptGroup) {
742
+												if ($thisCategory != $currentCategory) {
743
+													if ($closeOptGroup) {
744 744
 														echo "\t\t\t\t\t</optgroup>\n";
745 745
 													}
746 746
 													echo "\t\t\t\t\t<optgroup label=\"$thisCategory\">\n";
@@ -749,10 +749,10 @@  discard block
 block discarded – undo
749 749
 
750 750
 												$selectedtext = ($row['id'] == $content['template']) ? ' selected="selected"' : '';
751 751
 
752
-												echo "\t\t\t\t\t" . '<option value="' . $row['id'] . '"' . $selectedtext . '>' . $row['templatename'] . "</option>\n";
752
+												echo "\t\t\t\t\t".'<option value="'.$row['id'].'"'.$selectedtext.'>'.$row['templatename']."</option>\n";
753 753
 												$currentCategory = $thisCategory;
754 754
 											}
755
-											if($thisCategory != '') {
755
+											if ($thisCategory != '') {
756 756
 												echo "\t\t\t\t\t</optgroup>\n";
757 757
 											}
758 758
 											?>
@@ -796,20 +796,20 @@  discard block
 block discarded – undo
796 796
 									<td valign="top">
797 797
 										<?php
798 798
 										$parentlookup = false;
799
-										if(isset ($_REQUEST['id'])) {
800
-											if($content['parent'] == 0) {
799
+										if (isset ($_REQUEST['id'])) {
800
+											if ($content['parent'] == 0) {
801 801
 												$parentname = $site_name;
802 802
 											} else {
803 803
 												$parentlookup = $content['parent'];
804 804
 											}
805
-										} elseif(isset ($_REQUEST['pid'])) {
806
-											if($_REQUEST['pid'] == 0) {
805
+										} elseif (isset ($_REQUEST['pid'])) {
806
+											if ($_REQUEST['pid'] == 0) {
807 807
 												$parentname = $site_name;
808 808
 											} else {
809 809
 												$parentlookup = $_REQUEST['pid'];
810 810
 											}
811
-										} elseif(isset($_POST['parent'])) {
812
-											if($_POST['parent'] == 0) {
811
+										} elseif (isset($_POST['parent'])) {
812
+											if ($_POST['parent'] == 0) {
813 813
 												$parentname = $site_name;
814 814
 											} else {
815 815
 												$parentlookup = $_POST['parent'];
@@ -818,10 +818,10 @@  discard block
 block discarded – undo
818 818
 											$parentname = $site_name;
819 819
 											$content['parent'] = 0;
820 820
 										}
821
-										if($parentlookup !== false && is_numeric($parentlookup)) {
821
+										if ($parentlookup !== false && is_numeric($parentlookup)) {
822 822
 											$rs = $modx->db->select('pagetitle', $tbl_site_content, "id='{$parentlookup}'");
823 823
 											$parentname = $modx->db->getValue($rs);
824
-											if(!$parentname) {
824
+											if (!$parentname) {
825 825
 												$modx->webAlertAndQuit($_lang["error_no_parent"]);
826 826
 											}
827 827
 										}
@@ -863,7 +863,7 @@  discard block
 block discarded – undo
863 863
 								}*/
864 864
 								?>
865 865
 
866
-								<?php if($content['type'] == 'document' || $modx->manager->action == '4') { ?>
866
+								<?php if ($content['type'] == 'document' || $modx->manager->action == '4') { ?>
867 867
 									<tr>
868 868
 										<td colspan="2">
869 869
 											<hr>
@@ -876,8 +876,8 @@  discard block
 block discarded – undo
876 876
 														<?php
877 877
 														// invoke OnRichTextEditorRegister event
878 878
 														$evtOut = $modx->invokeEvent("OnRichTextEditorRegister");
879
-														if(is_array($evtOut)) {
880
-															for($i = 0; $i < count($evtOut); $i++) {
879
+														if (is_array($evtOut)) {
880
+															for ($i = 0; $i < count($evtOut); $i++) {
881 881
 																$editor = $evtOut[$i];
882 882
 																echo "\t\t\t", '<option value="', $editor, '"', ($modx->config['which_editor'] == $editor ? ' selected="selected"' : ''), '>', $editor, "</option>\n";
883 883
 															}
@@ -888,7 +888,7 @@  discard block
 block discarded – undo
888 888
 											</div>
889 889
 											<div id="content_body">
890 890
 												<?php
891
-												if(($content['richtext'] == 1 || $modx->manager->action == '4') && $use_editor == 1) {
891
+												if (($content['richtext'] == 1 || $modx->manager->action == '4') && $use_editor == 1) {
892 892
 													$htmlContent = $content['content'];
893 893
 													?>
894 894
 													<div class="section-editor clearfix">
@@ -901,7 +901,7 @@  discard block
 block discarded – undo
901 901
 													$richtexteditorIds[$modx->config['which_editor']][] = 'ta';
902 902
 													$richtexteditorOptions[$modx->config['which_editor']]['ta'] = '';
903 903
 												} else {
904
-													echo "\t" . '<div><textarea class="phptextarea" id="ta" name="ta" rows="20" wrap="soft" onchange="documentDirty=true;">', $modx->htmlspecialchars($content['content']), '</textarea></div>' . "\n";
904
+													echo "\t".'<div><textarea class="phptextarea" id="ta" name="ta" rows="20" wrap="soft" onchange="documentDirty=true;">', $modx->htmlspecialchars($content['content']), '</textarea></div>'."\n";
905 905
 												}
906 906
 												?>
907 907
 											</div>
@@ -917,7 +917,7 @@  discard block
 block discarded – undo
917 917
 
918 918
                             if (($content['type'] == 'document' || $modx->manager->action == '4') || ($content['type'] == 'reference' || $modx->manager->action == 72)) {
919 919
                                 $template = $default_template;
920
-                                $group_tvs = empty($modx->config['group_tvs']) ? 0 : (int)$modx->config['group_tvs'];
920
+                                $group_tvs = empty($modx->config['group_tvs']) ? 0 : (int) $modx->config['group_tvs'];
921 921
                                 if (isset ($_REQUEST['newtemplate'])) {
922 922
                                     $template = $_REQUEST['newtemplate'];
923 923
                                 } else {
@@ -945,10 +945,10 @@  discard block
 block discarded – undo
945 945
                                 );
946 946
                                 $sort = 'tvtpl.rank,tv.rank, tv.id';
947 947
                                 if ($group_tvs) {
948
-                                    $field .= ', IFNULL(tv.category,0) as category_id, IFNULL(cat.category,"' . $_lang['no_category'] . '") AS category, IFNULL(cat.rank,0) AS category_rank';
948
+                                    $field .= ', IFNULL(tv.category,0) as category_id, IFNULL(cat.category,"'.$_lang['no_category'].'") AS category, IFNULL(cat.rank,0) AS category_rank';
949 949
                                     $from .= '
950
-                                    LEFT JOIN ' . $tbl_categories . ' AS cat ON cat.id=tv.category';
951
-                                    $sort = 'cat.rank,cat.id,' . $sort;
950
+                                    LEFT JOIN ' . $tbl_categories.' AS cat ON cat.id=tv.category';
951
+                                    $sort = 'cat.rank,cat.id,'.$sort;
952 952
                                 }
953 953
                                 $where = vsprintf("tvtpl.templateid='%s' AND (1='%s' OR ISNULL(tva.documentgroup) %s)", $vs);
954 954
                                 $rs = $modx->db->select($field, $from, $where, $sort);
@@ -957,37 +957,37 @@  discard block
 block discarded – undo
957 957
                         <!-- Template Variables -->' . "\n";
958 958
                                     if (!$group_tvs) {
959 959
                                         $templateVariables .= '
960
-                                    <div class="sectionHeader" id="tv_header">' . $_lang['settings_templvars'] . '</div>
960
+                                    <div class="sectionHeader" id="tv_header">' . $_lang['settings_templvars'].'</div>
961 961
                                         <div class="sectionBody tmplvars">
962 962
                                             <table>';
963 963
                                     } else if ($group_tvs == 2) {
964 964
                                         $templateVariables .= '
965 965
                     <div class="tab-section">
966
-                        <div class="tab-header" id="tv_header">' . $_lang['settings_templvars'] . '</div>
966
+                        <div class="tab-header" id="tv_header">' . $_lang['settings_templvars'].'</div>
967 967
                         <div class="tab-pane" id="paneTemplateVariables">
968 968
                             <script type="text/javascript">
969
-                                tpTemplateVariables = new WebFXTabPane(document.getElementById(\'paneTemplateVariables\'), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false') . ');
969
+                                tpTemplateVariables = new WebFXTabPane(document.getElementById(\'paneTemplateVariables\'), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false').');
970 970
                             </script>';
971 971
                                     } else if ($group_tvs == 3) {
972 972
                                         $templateVariables .= '
973 973
                         <div id="templateVariables" class="tab-page tmplvars">
974
-                            <h2 class="tab">' . $_lang['settings_templvars'] . '</h2>
974
+                            <h2 class="tab">' . $_lang['settings_templvars'].'</h2>
975 975
                             <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'templateVariables\'));</script>';
976 976
                                     } else if ($group_tvs == 4) {
977 977
                                         $templateVariables .= '
978 978
                     <div id="templateVariables" class="tab-page tmplvars">
979
-                        <h2 class="tab">' . $_lang['settings_templvars'] . '</h2>
979
+                        <h2 class="tab">' . $_lang['settings_templvars'].'</h2>
980 980
                         <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'templateVariables\'));</script>
981 981
                         
982 982
                         <div class="tab-pane" id="paneTemplateVariables">
983 983
                             <script type="text/javascript">
984
-                                tpTemplateVariables = new WebFXTabPane(document.getElementById(\'paneTemplateVariables\'), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false') . ');
984
+                                tpTemplateVariables = new WebFXTabPane(document.getElementById(\'paneTemplateVariables\'), ' . ($modx->config['remember_last_tab'] == 1 ? 'true' : 'false').');
985 985
                             </script>';
986 986
                                     }
987 987
 
988 988
                                     $tvsArray = $modx->db->makeArray($rs, 'name');
989
-                                    require_once(MODX_MANAGER_PATH . 'includes/tmplvars.inc.php');
990
-                                    require_once(MODX_MANAGER_PATH . 'includes/tmplvars.commands.inc.php');
989
+                                    require_once(MODX_MANAGER_PATH.'includes/tmplvars.inc.php');
990
+                                    require_once(MODX_MANAGER_PATH.'includes/tmplvars.commands.inc.php');
991 991
                                     $i = 0;
992 992
                                     $tab = '';
993 993
                                     foreach ($tvsArray as $row) {
@@ -995,8 +995,8 @@  discard block
 block discarded – undo
995 995
                                             if ($group_tvs == 1 || $group_tvs == 3) {
996 996
                                                 if ($i === 0) {
997 997
                                                     $templateVariables .= '
998
-                            <div class="tab-section" id="tabTV_' . $row['category_id'] . '">
999
-                                <div class="tab-header">' . $row['category'] . '</div>
998
+                            <div class="tab-section" id="tabTV_' . $row['category_id'].'">
999
+                                <div class="tab-header">' . $row['category'].'</div>
1000 1000
                                 <div class="tab-body tmplvars">
1001 1001
                                     <table>' . "\n";
1002 1002
                                                 } else {
@@ -1005,17 +1005,17 @@  discard block
 block discarded – undo
1005 1005
                                 </div>
1006 1006
                             </div>
1007 1007
                             
1008
-                            <div class="tab-section" id="tabTV_' . $row['category_id'] . '">
1009
-                                <div class="tab-header">' . $row['category'] . '</div>
1008
+                            <div class="tab-section" id="tabTV_' . $row['category_id'].'">
1009
+                                <div class="tab-header">' . $row['category'].'</div>
1010 1010
                                 <div class="tab-body tmplvars">
1011 1011
                                     <table>';
1012 1012
                                                 }
1013 1013
                                             } else if ($group_tvs == 2 || $group_tvs == 4) {
1014 1014
                                                 if ($i === 0) {
1015 1015
                                                     $templateVariables .= '
1016
-                            <div id="tabTV_' . $row['category_id'] . '" class="tab-page tmplvars">
1017
-                                <h2 class="tab">' . $row['category'] . '</h2>
1018
-                                <script type="text/javascript">tpTemplateVariables.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'] . '\'));</script>
1016
+                            <div id="tabTV_' . $row['category_id'].'" class="tab-page tmplvars">
1017
+                                <h2 class="tab">' . $row['category'].'</h2>
1018
+                                <script type="text/javascript">tpTemplateVariables.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'].'\'));</script>
1019 1019
                                 
1020 1020
                                 <div class="tab-body tmplvars">
1021 1021
                                     <table>';
@@ -1025,9 +1025,9 @@  discard block
 block discarded – undo
1025 1025
                                 </div>
1026 1026
                             </div>
1027 1027
                             
1028
-                            <div id="tabTV_' . $row['category_id'] . '" class="tab-page tmplvars">
1029
-                                <h2 class="tab">' . $row['category'] . '</h2>
1030
-                                <script type="text/javascript">tpTemplateVariables.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'] . '\'));</script>
1028
+                            <div id="tabTV_' . $row['category_id'].'" class="tab-page tmplvars">
1029
+                                <h2 class="tab">' . $row['category'].'</h2>
1030
+                                <script type="text/javascript">tpTemplateVariables.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'].'\'));</script>
1031 1031
                                 
1032 1032
                                 <div class="tab-body tmplvars">
1033 1033
                                     <table>';
@@ -1035,18 +1035,18 @@  discard block
 block discarded – undo
1035 1035
                                             } else if ($group_tvs == 5) {
1036 1036
                                                 if ($i === 0) {
1037 1037
                                                     $templateVariables .= '
1038
-                                <div id="tabTV_' . $row['category_id'] . '" class="tab-page tmplvars">
1039
-                                    <h2 class="tab">' . $row['category'] . '</h2>
1040
-                                    <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'] . '\'));</script>
1038
+                                <div id="tabTV_' . $row['category_id'].'" class="tab-page tmplvars">
1039
+                                    <h2 class="tab">' . $row['category'].'</h2>
1040
+                                    <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'].'\'));</script>
1041 1041
                                     <table>';
1042 1042
                                                 } else {
1043 1043
                                                     $templateVariables .= '
1044 1044
                                     </table>
1045 1045
                                 </div>
1046 1046
                                 
1047
-                                <div id="tabTV_' . $row['category_id'] . '" class="tab-page tmplvars">
1048
-                                    <h2 class="tab">' . $row['category'] . '</h2>
1049
-                                    <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'] . '\'));</script>
1047
+                                <div id="tabTV_' . $row['category_id'].'" class="tab-page tmplvars">
1048
+                                    <h2 class="tab">' . $row['category'].'</h2>
1049
+                                    <script type="text/javascript">tpSettings.addTabPage(document.getElementById(\'tabTV_' . $row['category_id'].'\'));</script>
1050 1050
                                     
1051 1051
                                     <table>';
1052 1052
                                                 }
@@ -1064,8 +1064,8 @@  discard block
 block discarded – undo
1064 1064
                                                 $editor = isset($tvOptions['editor']) ? $tvOptions['editor'] : $modx->config['which_editor'];
1065 1065
                                             };
1066 1066
                                             // Add richtext editor to the list
1067
-                                            $richtexteditorIds[$editor][] = "tv" . $row['id'];
1068
-                                            $richtexteditorOptions[$editor]["tv" . $row['id']] = $tvOptions;
1067
+                                            $richtexteditorIds[$editor][] = "tv".$row['id'];
1068
+                                            $richtexteditorOptions[$editor]["tv".$row['id']] = $tvOptions;
1069 1069
                                         }
1070 1070
                                         // splitter
1071 1071
                                         if ($group_tvs) {
@@ -1079,24 +1079,24 @@  discard block
 block discarded – undo
1079 1079
                                         }
1080 1080
 
1081 1081
                                         // post back value
1082
-                                        if (array_key_exists('tv' . $row['id'], $_POST)) {
1083
-                                            if (is_array($_POST['tv' . $row['id']])) {
1084
-                                                $tvPBV = implode('||', $_POST['tv' . $row['id']]);
1082
+                                        if (array_key_exists('tv'.$row['id'], $_POST)) {
1083
+                                            if (is_array($_POST['tv'.$row['id']])) {
1084
+                                                $tvPBV = implode('||', $_POST['tv'.$row['id']]);
1085 1085
                                             } else {
1086
-                                                $tvPBV = $_POST['tv' . $row['id']];
1086
+                                                $tvPBV = $_POST['tv'.$row['id']];
1087 1087
                                             }
1088 1088
                                         } else {
1089 1089
                                             $tvPBV = $row['value'];
1090 1090
                                         }
1091 1091
 
1092
-                                        $tvDescription = (!empty($row['description'])) ? '<br /><span class="comment">' . $row['description'] . '</span>' : '';
1093
-                                        $tvInherited = (substr($tvPBV, 0, 8) == '@INHERIT') ? '<br /><span class="comment inherited">(' . $_lang['tmplvars_inherited'] . ')</span>' : '';
1094
-                                        $tvName = $modx->hasPermission('edit_template') ? '<br/><small class="protectedNode">[*' . $row['name'] . '*]</small>' : '';
1092
+                                        $tvDescription = (!empty($row['description'])) ? '<br /><span class="comment">'.$row['description'].'</span>' : '';
1093
+                                        $tvInherited = (substr($tvPBV, 0, 8) == '@INHERIT') ? '<br /><span class="comment inherited">('.$_lang['tmplvars_inherited'].')</span>' : '';
1094
+                                        $tvName = $modx->hasPermission('edit_template') ? '<br/><small class="protectedNode">[*'.$row['name'].'*]</small>' : '';
1095 1095
 
1096 1096
                                         $templateVariables .= '
1097 1097
                                         <tr>
1098
-                                            <td><span class="warning">' . $row['caption'] . $tvName . '</span>' . $tvDescription . $tvInherited . '</td>
1099
-                                            <td><div style="position:relative;' . ($row['type'] == 'date' ? '' : '') . '">' . renderFormElement($row['type'], $row['id'], $row['default_text'], $row['elements'], $tvPBV, '', $row, $tvsArray) . '</div></td>
1098
+                                            <td><span class="warning">' . $row['caption'].$tvName.'</span>'.$tvDescription.$tvInherited.'</td>
1099
+                                            <td><div style="position:relative;' . ($row['type'] == 'date' ? '' : '').'">'.renderFormElement($row['type'], $row['id'], $row['default_text'], $row['elements'], $tvPBV, '', $row, $tvsArray).'</div></td>
1100 1100
                                         </tr>';
1101 1101
 
1102 1102
                                         $tab = $row['category_id'];
@@ -1190,7 +1190,7 @@  discard block
 block discarded – undo
1190 1190
 
1191 1191
 								<?php
1192 1192
 
1193
-								if($_SESSION['mgrRole'] == 1 || $modx->manager->action != '27' || $_SESSION['mgrInternalKey'] == $content['createdby'] || $modx->hasPermission('change_resourcetype')) {
1193
+								if ($_SESSION['mgrRole'] == 1 || $modx->manager->action != '27' || $_SESSION['mgrInternalKey'] == $content['createdby'] || $modx->hasPermission('change_resourcetype')) {
1194 1194
 									?>
1195 1195
 									<tr>
1196 1196
 										<td>
@@ -1213,13 +1213,13 @@  discard block
 block discarded – undo
1213 1213
 										<td>
1214 1214
 											<select name="contentType" class="inputBox" onchange="documentDirty=true;">
1215 1215
 												<?php
1216
-												if(!$content['contentType']) {
1216
+												if (!$content['contentType']) {
1217 1217
 													$content['contentType'] = 'text/html';
1218 1218
 												}
1219 1219
 												$custom_contenttype = (isset ($custom_contenttype) ? $custom_contenttype : "text/html,text/plain,text/xml");
1220 1220
 												$ct = explode(",", $custom_contenttype);
1221
-												for($i = 0; $i < count($ct); $i++) {
1222
-													echo "\t\t\t\t\t" . '<option value="' . $ct[$i] . '"' . ($content['contentType'] == $ct[$i] ? ' selected="selected"' : '') . '>' . $ct[$i] . "</option>\n";
1221
+												for ($i = 0; $i < count($ct); $i++) {
1222
+													echo "\t\t\t\t\t".'<option value="'.$ct[$i].'"'.($content['contentType'] == $ct[$i] ? ' selected="selected"' : '').'>'.$ct[$i]."</option>\n";
1223 1223
 												}
1224 1224
 												?>
1225 1225
 											</select>
@@ -1245,7 +1245,7 @@  discard block
 block discarded – undo
1245 1245
 									</tr>
1246 1246
 									<?php
1247 1247
 								} else {
1248
-									if($content['type'] != 'reference' && $modx->manager->action != '72') {
1248
+									if ($content['type'] != 'reference' && $modx->manager->action != '72') {
1249 1249
 										// non-admin managers creating or editing a document resource
1250 1250
 										?>
1251 1251
 										<input type="hidden" name="contentType" value="<?= (isset($content['contentType']) ? $content['contentType'] : "text/html") ?>" />
@@ -1345,15 +1345,15 @@  discard block
 block discarded – undo
1345 1345
 						<?php
1346 1346
 					/*******************************
1347 1347
 					 * Document Access Permissions */
1348
-					if($use_udperms == 1) {
1348
+					if ($use_udperms == 1) {
1349 1349
 						$groupsarray = array();
1350 1350
 						$sql = '';
1351 1351
 
1352 1352
 						$documentId = ($modx->manager->action == '27' ? $id : (!empty($_REQUEST['pid']) ? $_REQUEST['pid'] : $content['parent']));
1353
-						if($documentId > 0) {
1353
+						if ($documentId > 0) {
1354 1354
 							// Load up, the permissions from the parent (if new document) or existing document
1355 1355
 							$rs = $modx->db->select('id, document_group', $tbl_document_groups, "document='{$documentId}'");
1356
-							while($currentgroup = $modx->db->getRow($rs)) $groupsarray[] = $currentgroup['document_group'] . ',' . $currentgroup['id'];
1356
+							while ($currentgroup = $modx->db->getRow($rs)) $groupsarray[] = $currentgroup['document_group'].','.$currentgroup['id'];
1357 1357
 
1358 1358
 							// Load up the current permissions and names
1359 1359
 							$vs = array(
@@ -1369,7 +1369,7 @@  discard block
 block discarded – undo
1369 1369
 						}
1370 1370
 
1371 1371
 						// retain selected doc groups between post
1372
-						if(isset($_POST['docgroups'])) {
1372
+						if (isset($_POST['docgroups'])) {
1373 1373
 							$groupsarray = array_merge($groupsarray, $_POST['docgroups']);
1374 1374
 						}
1375 1375
 
@@ -1388,26 +1388,26 @@  discard block
 block discarded – undo
1388 1388
 						$permissions_no = 0; // count permissions the current mgr user doesn't have
1389 1389
 
1390 1390
 						// Loop through the permissions list
1391
-						while($row = $modx->db->getRow($rs)) {
1391
+						while ($row = $modx->db->getRow($rs)) {
1392 1392
 
1393 1393
 							// Create an inputValue pair (group ID and group link (if it exists))
1394
-							$inputValue = $row['id'] . ',' . ($row['link_id'] ? $row['link_id'] : 'new');
1395
-							$inputId = 'group-' . $row['id'];
1394
+							$inputValue = $row['id'].','.($row['link_id'] ? $row['link_id'] : 'new');
1395
+							$inputId = 'group-'.$row['id'];
1396 1396
 
1397 1397
 							$checked = in_array($inputValue, $groupsarray);
1398
-							if($checked) {
1398
+							if ($checked) {
1399 1399
 								$notPublic = true;
1400 1400
 							} // Mark as private access (either web or manager)
1401 1401
 
1402 1402
 							// Skip the access permission if the user doesn't have access...
1403
-							if((!$isManager && $row['private_memgroup'] == '1') || (!$isWeb && $row['private_webgroup'] == '1')) {
1403
+							if ((!$isManager && $row['private_memgroup'] == '1') || (!$isWeb && $row['private_webgroup'] == '1')) {
1404 1404
 								continue;
1405 1405
 							}
1406 1406
 
1407 1407
 							// Setup attributes for this Input box
1408 1408
 							$inputAttributes['id'] = $inputId;
1409 1409
 							$inputAttributes['value'] = $inputValue;
1410
-							if($checked) {
1410
+							if ($checked) {
1411 1411
 								$inputAttributes['checked'] = 'checked';
1412 1412
 							} else {
1413 1413
 								unset($inputAttributes['checked']);
@@ -1415,10 +1415,10 @@  discard block
 block discarded – undo
1415 1415
 
1416 1416
 							// Create attribute string list
1417 1417
 							$inputString = array();
1418
-							foreach($inputAttributes as $k => $v) $inputString[] = $k . '="' . $v . '"';
1418
+							foreach ($inputAttributes as $k => $v) $inputString[] = $k.'="'.$v.'"';
1419 1419
 
1420 1420
 							// Make the <input> HTML
1421
-							$inputHTML = '<input ' . implode(' ', $inputString) . ' />';
1421
+							$inputHTML = '<input '.implode(' ', $inputString).' />';
1422 1422
 
1423 1423
 							// does user have this permission?
1424 1424
 							$from = "{$tbl_membergroup_access} AS mga, {$tbl_member_groups} AS mg";
@@ -1429,23 +1429,23 @@  discard block
 block discarded – undo
1429 1429
 							$where = vsprintf("mga.membergroup=mg.user_group AND mga.documentgroup=%s AND mg.member=%s", $vs);
1430 1430
 							$rsp = $modx->db->select('COUNT(mg.id)', $from, $where);
1431 1431
 							$count = $modx->db->getValue($rsp);
1432
-							if($count > 0) {
1432
+							if ($count > 0) {
1433 1433
 								++$permissions_yes;
1434 1434
 							} else {
1435 1435
 								++$permissions_no;
1436 1436
 							}
1437
-							$permissions[] = "\t\t" . '<li>' . $inputHTML . '<label for="' . $inputId . '">' . $row['name'] . '</label></li>';
1437
+							$permissions[] = "\t\t".'<li>'.$inputHTML.'<label for="'.$inputId.'">'.$row['name'].'</label></li>';
1438 1438
 						}
1439 1439
 						// if mgr user doesn't have access to any of the displayable permissions, forget about them and make doc public
1440
-						if($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0)) {
1440
+						if ($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0)) {
1441 1441
 							$permissions = array();
1442 1442
 						}
1443 1443
 
1444 1444
 						// See if the Access Permissions section is worth displaying...
1445
-						if(!empty($permissions)) {
1445
+						if (!empty($permissions)) {
1446 1446
 							// Add the "All Document Groups" item if we have rights in both contexts
1447
-							if($isManager && $isWeb) {
1448
-								array_unshift($permissions, "\t\t" . '<li><input type="checkbox" class="checkbox" name="chkalldocs" id="groupall"' . (!$notPublic ? ' checked="checked"' : '') . ' onclick="makePublic(true);" /><label for="groupall" class="warning">' . $_lang['all_doc_groups'] . '</label></li>');
1447
+							if ($isManager && $isWeb) {
1448
+								array_unshift($permissions, "\t\t".'<li><input type="checkbox" class="checkbox" name="chkalldocs" id="groupall"'.(!$notPublic ? ' checked="checked"' : '').' onclick="makePublic(true);" /><label for="groupall" class="warning">'.$_lang['all_doc_groups'].'</label></li>');
1449 1449
 							}
1450 1450
 							// Output the permissions list...
1451 1451
 							?>
@@ -1478,12 +1478,12 @@  discard block
 block discarded – undo
1478 1478
 								</script>
1479 1479
 								<p><?= $_lang['access_permissions_docs_message'] ?></p>
1480 1480
 								<ul>
1481
-									<?= implode("\n", $permissions) . "\n" ?>
1481
+									<?= implode("\n", $permissions)."\n" ?>
1482 1482
 								</ul>
1483 1483
 							</div><!--div class="tab-page" id="tabAccess"-->
1484 1484
 							<?php
1485 1485
 						} // !empty($permissions)
1486
-						elseif($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0) && ($_SESSION['mgrPermissions']['access_permissions'] == 1 || $_SESSION['mgrPermissions']['web_access_permissions'] == 1)) {
1486
+						elseif ($_SESSION['mgrRole'] != 1 && ($permissions_yes == 0 && $permissions_no > 0) && ($_SESSION['mgrPermissions']['access_permissions'] == 1 || $_SESSION['mgrPermissions']['web_access_permissions'] == 1)) {
1487 1487
 							?>
1488 1488
 							<p><?= $_lang["access_permissions_docs_collision"] ?></p>
1489 1489
 							<?php
@@ -1503,7 +1503,7 @@  discard block
 block discarded – undo
1503 1503
 						'template' => $content['template']
1504 1504
 					));
1505 1505
 
1506
-					if(is_array($evtOut)) {
1506
+					if (is_array($evtOut)) {
1507 1507
 						echo implode('', $evtOut);
1508 1508
 					}
1509 1509
 					?>
@@ -1516,16 +1516,16 @@  discard block
 block discarded – undo
1516 1516
 		storeCurTemplate();
1517 1517
 	</script>
1518 1518
 <?php
1519
-if(($content['richtext'] == 1 || $modx->manager->action == '4' || $modx->manager->action == '72') && $use_editor == 1) {
1520
-	if(is_array($richtexteditorIds)) {
1521
-		foreach($richtexteditorIds as $editor => $elements) {
1519
+if (($content['richtext'] == 1 || $modx->manager->action == '4' || $modx->manager->action == '72') && $use_editor == 1) {
1520
+	if (is_array($richtexteditorIds)) {
1521
+		foreach ($richtexteditorIds as $editor => $elements) {
1522 1522
 			// invoke OnRichTextEditorInit event
1523 1523
 			$evtOut = $modx->invokeEvent('OnRichTextEditorInit', array(
1524 1524
 				'editor' => $editor,
1525 1525
 				'elements' => $elements,
1526 1526
 				'options' => $richtexteditorOptions[$editor]
1527 1527
 			));
1528
-			if(is_array($evtOut)) {
1528
+			if (is_array($evtOut)) {
1529 1529
 				echo implode('', $evtOut);
1530 1530
 			}
1531 1531
 		}
@@ -1535,37 +1535,37 @@  discard block
 block discarded – undo
1535 1535
 /**
1536 1536
  * @return string
1537 1537
  */
1538
-function getDefaultTemplate() {
1538
+function getDefaultTemplate(){
1539 1539
 	global $modx;
1540 1540
 
1541 1541
     $default_template = '';
1542
-	switch($modx->config['auto_template_logic']) {
1542
+	switch ($modx->config['auto_template_logic']) {
1543 1543
 		case 'sibling':
1544
-			if(!isset($_GET['pid']) || empty($_GET['pid'])) {
1544
+			if (!isset($_GET['pid']) || empty($_GET['pid'])) {
1545 1545
 				$site_start = $modx->config['site_start'];
1546 1546
 				$where = "sc.isfolder=0 AND sc.id!='{$site_start}'";
1547 1547
 				$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', $where, 'menuindex', 'ASC', 1);
1548
-				if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1548
+				if (isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1549 1549
 					$default_template = $sibl[0]['template'];
1550 1550
 				}
1551 1551
 			} else {
1552 1552
 				$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 1, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1553
-				if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1553
+				if (isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1554 1554
 					$default_template = $sibl[0]['template'];
1555 1555
 				} else {
1556 1556
 					$sibl = $modx->getDocumentChildren($_REQUEST['pid'], 0, 0, 'template', 'isfolder=0', 'menuindex', 'ASC', 1);
1557
-					if(isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1557
+					if (isset($sibl[0]['template']) && $sibl[0]['template'] !== '') {
1558 1558
 						$default_template = $sibl[0]['template'];
1559 1559
 					}
1560 1560
 				}
1561 1561
 			}
1562
-			if(isset($default_template)) {
1562
+			if (isset($default_template)) {
1563 1563
 				break;
1564 1564
 			} // If $default_template could not be determined, fall back / through to "parent"-mode
1565 1565
 		case 'parent':
1566
-			if(isset($_REQUEST['pid']) && !empty($_REQUEST['pid'])) {
1566
+			if (isset($_REQUEST['pid']) && !empty($_REQUEST['pid'])) {
1567 1567
 				$parent = $modx->getPageInfo($_REQUEST['pid'], 0, 'template');
1568
-				if(isset($parent['template'])) {
1568
+				if (isset($parent['template'])) {
1569 1569
 					$default_template = $parent['template'];
1570 1570
 				}
1571 1571
 			}
Please login to merge, or discard this patch.
Braces   +12 added lines, -5 removed lines patch added patch discarded remove patch
@@ -478,7 +478,8 @@  discard block
 block discarded – undo
478 478
 			return s;
479 479
 		}
480 480
 
481
-		<?php if ($content['type'] == 'reference' || $modx->manager->action == '72') { // Web Link specific ?>
481
+		<?php if ($content['type'] == 'reference' || $modx->manager->action == '72') {
482
+// Web Link specific ?>
482 483
 		var lastImageCtrl;
483 484
 		var lastFileCtrl;
484 485
 
@@ -694,7 +695,8 @@  discard block
 block discarded – undo
694 695
 									</td>
695 696
 								</tr>
696 697
 
697
-								<?php if($content['type'] == 'reference' || $modx->manager->action == '72') { // Web Link specific ?>
698
+								<?php if($content['type'] == 'reference' || $modx->manager->action == '72') {
699
+// Web Link specific ?>
698 700
 
699 701
 									<tr>
700 702
 										<td><span class="warning"><?= $_lang['weblink'] ?></span>
@@ -1353,7 +1355,9 @@  discard block
 block discarded – undo
1353 1355
 						if($documentId > 0) {
1354 1356
 							// Load up, the permissions from the parent (if new document) or existing document
1355 1357
 							$rs = $modx->db->select('id, document_group', $tbl_document_groups, "document='{$documentId}'");
1356
-							while($currentgroup = $modx->db->getRow($rs)) $groupsarray[] = $currentgroup['document_group'] . ',' . $currentgroup['id'];
1358
+							while($currentgroup = $modx->db->getRow($rs)) {
1359
+							    $groupsarray[] = $currentgroup['document_group'] . ',' . $currentgroup['id'];
1360
+							}
1357 1361
 
1358 1362
 							// Load up the current permissions and names
1359 1363
 							$vs = array(
@@ -1415,7 +1419,9 @@  discard block
 block discarded – undo
1415 1419
 
1416 1420
 							// Create attribute string list
1417 1421
 							$inputString = array();
1418
-							foreach($inputAttributes as $k => $v) $inputString[] = $k . '="' . $v . '"';
1422
+							foreach($inputAttributes as $k => $v) {
1423
+							    $inputString[] = $k . '="' . $v . '"';
1424
+							}
1419 1425
 
1420 1426
 							// Make the <input> HTML
1421 1427
 							$inputHTML = '<input ' . implode(' ', $inputString) . ' />';
@@ -1535,7 +1541,8 @@  discard block
 block discarded – undo
1535 1541
 /**
1536 1542
  * @return string
1537 1543
  */
1538
-function getDefaultTemplate() {
1544
+function getDefaultTemplate()
1545
+{
1539 1546
 	global $modx;
1540 1547
 
1541 1548
     $default_template = '';
Please login to merge, or discard this patch.