View GitHub Repository evolution

Schedule Inspection
Subscribe

Code Duplication    Length = 4-5 lines in 2 locations

manager/processors/save_tmplvars.processor.php 2 locations

@@ 60-64 (lines=5) @@
57 
            $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['tv'], $name), "index.php?a=300");
58 
        }
59 
        // disallow reserved names
60 
        if (in_array($name, array('id', 'type', 'contentType', 'pagetitle', 'longtitle', 'description', 'alias', 'link_attributes', 'published', 'pub_date', 'unpub_date', 'parent', 'isfolder', 'introtext', 'content', 'richtext', 'template', 'menuindex', 'searchable', 'cacheable', 'createdby', 'createdon', 'editedby', 'editedon', 'deleted', 'deletedon', 'deletedby', 'publishedon', 'publishedby', 'menutitle', 'donthit', 'privateweb', 'privatemgr', 'content_dispo', 'hidemenu', 'alias_visible'))) {
61 
            $_POST['name'] = '';
62 
            $modx->manager->saveFormValues(300);
63 
            $modx->webAlertAndQuit(sprintf($_lang['reserved_name_warning'], $_lang['tv'], $name), "index.php?a=300");
64 
        }
65 

                                

                                                            

                                    66
                                    
                                    
        // Add new TV

                                

                                                            

                                    67
                                    
                                    
        $newid = $modx->db->insert(array(

                                

                                                                                

                                
                                
                                    @@ 123-126 (lines=4) @@
                                
                            


                                                            

                                    120
                                    
                                    
            $modx->webAlertAndQuit(sprintf($_lang['duplicate_name_found_general'], $_lang['tv'], $name), "index.php?a=301&id={$id}");

                                

                                                            

                                    121
                                    
                                    
        }

                                

                                                            

                                    122
                                    
                                    
        // disallow reserved names

                                

                                                            

                                    123
                                    
                                    
        if (in_array($name, array('id', 'type', 'contentType', 'pagetitle', 'longtitle', 'description', 'alias', 'link_attributes', 'published', 'pub_date', 'unpub_date', 'parent', 'isfolder', 'introtext', 'content', 'richtext', 'template', 'menuindex', 'searchable', 'cacheable', 'createdby', 'createdon', 'editedby', 'editedon', 'deleted', 'deletedon', 'deletedby', 'publishedon', 'publishedby', 'menutitle', 'donthit', 'privateweb', 'privatemgr', 'content_dispo', 'hidemenu', 'alias_visible'))) {

                                

                                                            

                                    124
                                    
                                    
            $modx->manager->saveFormValues(300);

                                

                                                            

                                    125
                                    
                                    
            $modx->webAlertAndQuit(sprintf($_lang['reserved_name_warning'], $_lang['tv'], $name), "index.php?a=301&id={$id}");

                                

                                                            

                                    126
                                    
                                    
        }

                                

                                                            

                                    127
                                    
                                    

                                

                                                            

                                    128
                                    
                                    
        // update TV

                                

                                                            

                                    129
                                    
                                    
        $modx->db->update(array(