Url::__construct() - Code Metrics - Inspection of "navigation factory refactoring" - everlutionsk/navigation - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3eb0e4...9196b6 )

by Ivan

created 2016-12-28 22:30 UTC

Url::__construct() A

↳ Parent: Url

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	4

<?php

declare(strict_types = 1);

namespace Everlution\Navigation\Item;

use Everlution\Navigation\Item;
use Everlution\Navigation\NavigationItem;
use Everlution\Navigation\Uri\SimpleUri;
use Everlution\Navigation\Uri\Uri;
use Everlution\Navigation\Voter\Exact\ExactMatch;

/**
 * Class Url.
 * @author Ivan Barlog <[email protected]>
 */
class Url extends NavigationItem

{
    /** @var SimpleUri */
    private $uri;

    public function __construct(string $label, string $url, Item $parent = null, array $children = [])
    {
        parent::__construct($label, $parent, $children);

        $this->uri = new SimpleUri($url);
        $this->addMatch(new ExactMatch($url));
    }

    /**
     * @return SimpleUri|Uri
     */
    public function getUri(): Uri
    {
        return $this->uri;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->uri->getUri();
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Everlution\Navigation\Item;
6
7		use Everlution\Navigation\Item;
8		use Everlution\Navigation\NavigationItem;
9		use Everlution\Navigation\Uri\SimpleUri;
10		use Everlution\Navigation\Uri\Uri;
11		use Everlution\Navigation\Voter\Exact\ExactMatch;
12
13		/**
14		* Class Url.
15		* @author Ivan Barlog <[email protected]>
16		*/
17	View Code Duplication	class Url extends NavigationItem
		0 ignored issues – show Duplication introduced 2016-12-28 22:32 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		/** @var SimpleUri */
20		private $uri;
21
22		public function __construct(string $label, string $url, Item $parent = null, array $children = [])
23		{
24		parent::__construct($label, $parent, $children);
25
26		$this->uri = new SimpleUri($url);
27		$this->addMatch(new ExactMatch($url));
28		}
29
30		/**
31		* @return SimpleUri\|Uri
32		*/
33		public function getUri(): Uri
34		{
35		return $this->uri;
36		}
37
38		/**
39		* @return string
40		*/
41		public function getUrl(): string
42		{
43		return $this->uri->getUri();
44		}
45		}
46

everlutionsk / navigation

Push — master ( 3eb0e4...9196b6 )

Url::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like