Everlution\Navigation\NavigationItem

Complexity

Total Complexity

9

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	getLabel()	0	4	1
A	setParent()	0	6	1
A	getParent()	0	4	1
A	addChild()	0	6	1
A	getChildren()	0	4	1
A	addMatch()	0	6	1
A	getMatches()	0	4	1
	getUri()	0	1	?

<?php

declare(strict_types = 1);

namespace Everlution\Navigation;

use Everlution\Navigation\Uri\Uri;
use Everlution\Navigation\Voter\Match;

/**
 * Class NavigationItem.
 * @author Ivan Barlog <ivan.barlog@everlution.sk>
 */
abstract class NavigationItem implements Item, MatchableItem
{
    /** @var Match[] */
    private $matches = [];
    /** @var string */
    private $label;
    /** @var NavigationItem */
    private $parent;
    /** @var array */
    private $children = [];

    public function __construct(string $label, Item $parent = null, array $children = [])
    {
        $this->label = $label;
        $this->parent = $parent;

It seems like $parent can also be of type object<Everlution\Navigation\Item>. However, the property $parent is declared as type object<Everlution\Navigation\NavigationItem>. Maybe add an additional type check?

        foreach ($children as $child) {
            $this->addChild($child);
        }
    }

    /**
     * @return string
     */
    public function getLabel(): string
    {
        return $this->label;
    }

    /**
     * @param Item $parent
     * @return NavigationItem
     */
    public function setParent(Item $parent): NavigationItem
    {
        $this->parent = $parent;

$parent is of type object<Everlution\Navigation\Item>, but the property $parent was declared to be of type object<Everlution\Navigation\NavigationItem>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    /**
     * @return NavigationItem
     */
    public function getParent(): NavigationItem
    {
        return $this->parent;
    }

    /**
     * @param Item $item
     * @return Item
     */
    public function addChild(Item $item): Item
    {
        $this->children[] = $item->setParent($this);

        return $this;
    }

    /**
     * @return Item[]
     */
    public function getChildren(): array
    {
        return $this->children;
    }

    /**
     * @param Match $match
     * @return Item
     */
    public function addMatch(Match $match): Item
    {
        $this->matches[] = $match;

        return $this;
    }

    /**
     * @return Match[]
     */
    public function getMatches(): array
    {
        return $this->matches;
    }

    /**
     * @return Uri
     */
    abstract public function getUri(): Uri;
}