UrlConfig - Code Metrics - Inspection of "navigation factory refactoring" - everlutionsk/navigation - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3eb0e4...9196b6 )

by Ivan

created 2016-12-28 22:30 UTC

UrlConfig A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	3
dl	0
loc	37
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getObject()	7	1
A	getArray()	8	1
A	config()	6	1

<?php

declare(strict_types = 1);

namespace Everlution\Navigation\Factory\Build\Hydrator\Item;

use Everlution\Navigation\Factory\Build\ItemConfig;
use Everlution\Navigation\Item;
use Everlution\Navigation\Item\Url;
use Everlution\Navigation\Factory\Build\Hydrator\Item as HydratorItem;

/**
 * Class UrlConfig.
 * @author Ivan Barlog <[email protected]>
 */
class UrlConfig extends HydratorItem implements ItemConfig
{
    const OPTION_URL = 'url';

    /**
     * @param string $className
     * @param array $arguments
     * @return mixed
     */
    protected function getObject(string $className, array $arguments)
    {
        return new $className(
            $arguments[self::OPTION_LABEL],
            $arguments[self::OPTION_URL]
        );
    }

    /**
     * @param Url|Item $object
     * @return array
     */
    protected function getArray($object): array
    {
        return [
            self::OPTION_CLASS => get_class($object),
            self::OPTION_LABEL => $object->getLabel(),
            self::OPTION_URL => $object->getUrl(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ];
    }

    protected function config()
    {
        $this->resolver->setRequired([self::OPTION_URL]);
        $this->resolver->setAllowedTypes(self::OPTION_URL, 'string');
        $this->supportedClasses[] = Url::class;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace Everlution\Navigation\Factory\Build\Hydrator\Item;
6
7			use Everlution\Navigation\Factory\Build\ItemConfig;
8			use Everlution\Navigation\Item;
9			use Everlution\Navigation\Item\Url;
10			use Everlution\Navigation\Factory\Build\Hydrator\Item as HydratorItem;
11
12			/**
13			* Class UrlConfig.
14			* @author Ivan Barlog <[email protected]>
15			*/
16			class UrlConfig extends HydratorItem implements ItemConfig
17			{
18			const OPTION_URL = 'url';
19
20			/**
21			* @param string $className
22			* @param array $arguments
23			* @return mixed
24			*/
25			protected function getObject(string $className, array $arguments)
26			{
27			return new $className(
28			$arguments[self::OPTION_LABEL],
29			$arguments[self::OPTION_URL]
30			);
31			}
32
33			/**
34			* @param Url\|Item $object
35			* @return array
36			*/
37			protected function getArray($object): array
38			{
39			return [
40			self::OPTION_CLASS => get_class($object),
41			self::OPTION_LABEL => $object->getLabel(),
42			self::OPTION_URL => $object->getUrl(),
			0 ignored issues – show Bug introduced 2016-12-28 22:32 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Everlution\Navigation\Item` as the method `getUrl()` does only exist in the following implementations of said interface: `Everlution\Navigation\Item\Url`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43			];
44			}
45
46			protected function config()
47			{
48			$this->resolver->setRequired([self::OPTION_URL]);
49			$this->resolver->setAllowedTypes(self::OPTION_URL, 'string');
50			$this->supportedClasses[] = Url::class;
51			}
52			}
53

everlutionsk / navigation

Push — master ( 3eb0e4...9196b6 )

UrlConfig A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like