Everlution\Navigation\OrderedContainer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getItems()	0	19	4
A	get()	0	4	1
A	ascending()	0	4	1

<?php

declare(strict_types=1);

namespace Everlution\Navigation;

use Everlution\Navigation\Item\ItemInterface;
use Everlution\Navigation\Item\SortableInterface;

/**
 * Class FilteredContainer.
 *
 * @author Ivan Barlog <ivan.barlog@everlution.sk>
 */
class OrderedContainer implements ContainerInterface
{
    /** @var FilteredContainerInterface */
    private $container;
    /** @var ItemInterface[] */
    private $items;

    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;

$container is of type object<Everlution\Navigation\ContainerInterface>, but the property $container was declared to be of type object<Everlution\Navigation\FilteredContainerInterface>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @return ItemInterface[]
     */
    public function getItems(): array
    {
        if (!$this->items) {

The expression $this->items of type Everlution\Navigation\Item\ItemInterface[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $items = $this->container->getItems();

            $sortable = [];
            foreach ($items as $key => $item) {
                if ($item instanceof SortableInterface) {
                    $sortable[$key] = $item;
                    unset($items[$key]);
                }
            }

            uasort($sortable, [$this, 'ascending']);
            $this->items = array_merge($sortable, $items);

It seems like array_merge($sortable, $items) of type array is incompatible with the declared type array<integer,object<Everlution\Navigation\Item\ItemInterface>> of property $items.

        }

        return $this->items;
    }

    public function get(string $name): ItemInterface
    {
        return $this->items[$name];
    }

    private function ascending(SortableInterface $first, SortableInterface $second)
    {
        return $first->getOrder() <=> $second->getOrder();
    }
}