Inspection of "Daily Inspection: BAH! missed these" - eventespresso/event-espresso-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — FET/extract-admin-menu (26a1ca)

unknown

created 2022-05-27 21:15 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='FileCommentUnitTest.inc')
+    public function getErrorList($testFile = 'FileCommentUnitTest.inc')
     {
         switch ($testFile) {
         case 'FileCommentUnitTest.1.inc':

Please login to merge, or discard this patch.

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -15,61 +15,61 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='FileCommentUnitTest.inc')
-    {
-        switch ($testFile) {
-        case 'FileCommentUnitTest.1.inc':
-        case 'FileCommentUnitTest.1.js':
-            return [
-                1  => 1,
-                22 => 2,
-                23 => 1,
-                24 => 2,
-                25 => 2,
-                26 => 1,
-                27 => 2,
-                28 => 2,
-                32 => 2,
-            ];
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='FileCommentUnitTest.inc')
+	{
+		switch ($testFile) {
+		case 'FileCommentUnitTest.1.inc':
+		case 'FileCommentUnitTest.1.js':
+			return [
+				1  => 1,
+				22 => 2,
+				23 => 1,
+				24 => 2,
+				25 => 2,
+				26 => 1,
+				27 => 2,
+				28 => 2,
+				32 => 2,
+			];
 
-        case 'FileCommentUnitTest.4.inc':
-        case 'FileCommentUnitTest.6.inc':
-        case 'FileCommentUnitTest.7.inc':
-            return [1 => 1];
+		case 'FileCommentUnitTest.4.inc':
+		case 'FileCommentUnitTest.6.inc':
+		case 'FileCommentUnitTest.7.inc':
+			return [1 => 1];
 
-        case 'FileCommentUnitTest.5.inc':
-            return [2 => 1];
+		case 'FileCommentUnitTest.5.inc':
+			return [2 => 1];
 
-        default:
-            return [];
-        }//end switch
+		default:
+			return [];
+		}//end switch
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -28,30 +28,30 @@
 block discarded – undo
     public function getErrorList($testFile='FileCommentUnitTest.inc')
     {
         switch ($testFile) {
-        case 'FileCommentUnitTest.1.inc':
-        case 'FileCommentUnitTest.1.js':
-            return [
-                1  => 1,
-                22 => 2,
-                23 => 1,
-                24 => 2,
-                25 => 2,
-                26 => 1,
-                27 => 2,
-                28 => 2,
-                32 => 2,
-            ];
+        	case 'FileCommentUnitTest.1.inc':
+        	case 'FileCommentUnitTest.1.js':
+            	return [
+                	1  => 1,
+                	22 => 2,
+                	23 => 1,
+                	24 => 2,
+                	25 => 2,
+                	26 => 1,
+                	27 => 2,
+                	28 => 2,
+                	32 => 2,
+            	];
 
-        case 'FileCommentUnitTest.4.inc':
-        case 'FileCommentUnitTest.6.inc':
-        case 'FileCommentUnitTest.7.inc':
-            return [1 => 1];
+        	case 'FileCommentUnitTest.4.inc':
+        	case 'FileCommentUnitTest.6.inc':
+        	case 'FileCommentUnitTest.7.inc':
+            	return [1 => 1];
 
-        case 'FileCommentUnitTest.5.inc':
-            return [2 => 1];
+        	case 'FileCommentUnitTest.5.inc':
+            	return [2 => 1];
 
-        default:
-            return [];
+        	default:
+            	return [];
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Commenting/FunctionCommentThrowTagUnitTest.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -15,46 +15,46 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            9   => 1,
-            21  => 1,
-            35  => 1,
-            47  => 1,
-            61  => 2,
-            106 => 1,
-            123 => 1,
-            200 => 1,
-            219 => 1,
-            287 => 1,
-            397 => 1,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			9   => 1,
+			21  => 1,
+			35  => 1,
+			47  => 1,
+			61  => 2,
+			106 => 1,
+			123 => 1,
+			200 => 1,
+			219 => 1,
+			287 => 1,
+			397 => 1,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.php 1 patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -15,43 +15,43 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            13 => 1,
-            17 => 1,
-            31 => 1,
-            41 => 1,
-            59 => 1,
-            63 => 1,
-            67 => 1,
-            79 => 1,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [71 => 1];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			13 => 1,
+			17 => 1,
+			31 => 1,
+			41 => 1,
+			59 => 1,
+			63 => 1,
+			67 => 1,
+			79 => 1,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [71 => 1];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Classes/DuplicatePropertyUnitTest.php 1 patch

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch

@@ -15,38 +15,38 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            4  => 1,
-            8  => 1,
-            28 => 1,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			4  => 1,
+			8  => 1,
+			28 => 1,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Classes/ClassDeclarationUnitTest.inc 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 {
 }//end class
 
-class ClassOne implements ClassFour   ,ClassFive,  ClassSix
+class ClassOne implements ClassFour, ClassFive, ClassSix
 {
 }//end class
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
 
 } // phpcs:enable Standard.Category.Sniff
 
-class File implements \Zend_Auth_Storage_Interface,\Zend_Auth_Storage,  \Zend_Foo
+class File implements \Zend_Auth_Storage_Interface, \Zend_Auth_Storage, \Zend_Foo
 {
 }
 
@@ -107,4 +107,4 @@  discard block
 block discarded – undo
 class IncorrectCodeBeforeClosingBrace
 {
 
-echo phpinfo();}
+echo phpinfo(); }

Please login to merge, or discard this patch.

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -24,10 +24,10 @@  discard block
 block discarded – undo
 class IncorrectBracePlacementWithImplements implements correctClassDeclaration {}
 
 
-    class IncorrectIndentedClass
-    {
+	class IncorrectIndentedClass
+	{
 
-    }//end class
+	}//end class
 
 
 // Incorrect code placement for opening/closing brace.
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
 
 echo phpinfo(); }
 
-    class IncorrectIndentedClass
+	class IncorrectIndentedClass
 {
 
 }
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
 
 class MyClass2
 {
-    var $x;
+	var $x;
 }
 
 

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
     public function SelfMemberReferenceUnitTestExample()
     {
-        $testResults =& $this->testResults;
+        $testResults = & $this->testResults;
 
 
         // Correct call to self.
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
                         MyClass::test($value);
                     };
 
-        $array = array(1,2,3);
+        $array = array(1, 2, 3);
         array_walk($array, $callback);
     }
 }

Please login to merge, or discard this patch.

Indentation +92 added lines, -92 removed lines patch added patch discarded remove patch

@@ -5,54 +5,54 @@  discard block
 block discarded – undo
 {
 
 
-    private $testCount = 0;
+	private $testCount = 0;
 
 
-    private $testResults = array();
+	private $testResults = array();
 
 
-    public function SelfMemberReferenceUnitTestExample()
-    {
-        $testResults =& $this->testResults;
+	public function SelfMemberReferenceUnitTestExample()
+	{
+		$testResults =& $this->testResults;
 
 
-        // Correct call to self.
-        $testResults[] = self::selfMemberReferenceUnitTestFunction();
-        $testResults[] = parent::selfMemberReferenceUnitTestFunction();
+		// Correct call to self.
+		$testResults[] = self::selfMemberReferenceUnitTestFunction();
+		$testResults[] = parent::selfMemberReferenceUnitTestFunction();
 
-        // Incorrect case.
-        $testResults[] = Self::selfMemberReferenceUnitTestFunction();
-        $testResults[] = SELF::selfMemberReferenceUnitTestFunction();
-        $testResults[] = SelfMemberReferenceUnitTestExample::selfMemberReferenceUnitTestFunction();
+		// Incorrect case.
+		$testResults[] = Self::selfMemberReferenceUnitTestFunction();
+		$testResults[] = SELF::selfMemberReferenceUnitTestFunction();
+		$testResults[] = SelfMemberReferenceUnitTestExample::selfMemberReferenceUnitTestFunction();
 
 
-        // Incorrect spacing.
-        $testResults[] = self ::selfMemberReferenceUnitTestFunction();
-        $testResults[] = self::  selfMemberReferenceUnitTestFunction();
-        $testResults[] = self  :: selfMemberReferenceUnitTestFunction();
+		// Incorrect spacing.
+		$testResults[] = self ::selfMemberReferenceUnitTestFunction();
+		$testResults[] = self::  selfMemberReferenceUnitTestFunction();
+		$testResults[] = self  :: selfMemberReferenceUnitTestFunction();
 
-        // Remove ALL the newlines
-        $testResults[] = self
+		// Remove ALL the newlines
+		$testResults[] = self
 
 
 
 
-            ::
+			::
 
 
 
 
-            selfMemberReferenceUnitTestFunction();
+			selfMemberReferenceUnitTestFunction();
 
-    }
+	}
 
 
-    function selfMemberReferenceUnitTestFunction()
-    {
-        $this->testCount = $this->testCount + 1;
-        return $this->testCount;
+	function selfMemberReferenceUnitTestFunction()
+	{
+		$this->testCount = $this->testCount + 1;
+		return $this->testCount;
 
-    }
+	}
 
 
 }
@@ -60,115 +60,115 @@  discard block
 block discarded – undo
 
 class MyClass {
 
-    public static function test($value) {
-        echo "$value\n";
-    }
+	public static function test($value) {
+		echo "$value\n";
+	}
 
-    public static function walk() {
-        $callback = function($value, $key) {
-                        // This is valid because you can't use self:: in a closure.
-                        MyClass::test($value);
-                    };
+	public static function walk() {
+		$callback = function($value, $key) {
+						// This is valid because you can't use self:: in a closure.
+						MyClass::test($value);
+					};
 
-        $array = array(1,2,3);
-        array_walk($array, $callback);
-    }
+		$array = array(1,2,3);
+		array_walk($array, $callback);
+	}
 }
 
 MyClass::walk();
 
 class Controller
 {
-    public function Action()
-    {
-        Doctrine\Common\Util\Debug::dump();
-    }
+	public function Action()
+	{
+		Doctrine\Common\Util\Debug::dump();
+	}
 }
 
 class Foo
 {
-    public static function bar()
-    {
-        \Foo::baz();
-    }
+	public static function bar()
+	{
+		\Foo::baz();
+	}
 }
 
 namespace TYPO3\CMS\Reports;
 
 class Status {
-    const NOTICE = -2;
-    const INFO = -1;
-    const OK = 0;
-    const WARNING = 1;
-    const ERROR = 2;
+	const NOTICE = -2;
+	const INFO = -1;
+	const OK = 0;
+	const WARNING = 1;
+	const ERROR = 2;
 }
 
 namespace TYPO3\CMS\Reports\Report\Status;
 
 class Status implements \TYPO3\CMS\Reports\ReportInterface {
-    public function getHighestSeverity(array $statusCollection) {
-        $highestSeverity = \TYPO3\CMS\Reports\Status::NOTICE;
-    }
+	public function getHighestSeverity(array $statusCollection) {
+		$highestSeverity = \TYPO3\CMS\Reports\Status::NOTICE;
+	}
 }
 
 namespace Foo;
 
 class Bar {
 
-    function myFunction()
-    {
-        \Foo\Whatever::something();
-        \Foo\Bar::something();
-    }
+	function myFunction()
+	{
+		\Foo\Whatever::something();
+		\Foo\Bar::something();
+	}
 }
 
 namespace Foo\Bar;
 
 class Baz {
 
-    function myFunction()
-    {
-        \Foo\Bar\Whatever::something();
-        \Foo\Bar\Baz::something();
-    }
+	function myFunction()
+	{
+		\Foo\Bar\Whatever::something();
+		\Foo\Bar\Baz::something();
+	}
 }
 
 class Nested_Anon_Class {
-    public function getAnonymousClass() {
-        // Spacing/comments should not cause false negatives for the NotUsed error.
-        Nested_Anon_Class      ::       $prop;
-        Nested_Anon_Class
-        /* some comment */
-
-        ::
-
-        // phpcs:ignore Standard.Category.SniffName -- for reasons.
-        Bar();
-
-        // Anonymous class is a different scope.
-        return new class() {
-            public function nested_function() {
-                Nested_Anon_Class::$prop;
-                Nested_Anon_Class::BAR;
-            }
-        };
-    }
+	public function getAnonymousClass() {
+		// Spacing/comments should not cause false negatives for the NotUsed error.
+		Nested_Anon_Class      ::       $prop;
+		Nested_Anon_Class
+		/* some comment */
+
+		::
+
+		// phpcs:ignore Standard.Category.SniffName -- for reasons.
+		Bar();
+
+		// Anonymous class is a different scope.
+		return new class() {
+			public function nested_function() {
+				Nested_Anon_Class::$prop;
+				Nested_Anon_Class::BAR;
+			}
+		};
+	}
 }
 
 // Test dealing with scoped namespaces.
 namespace Foo\Baz {
-    class BarFoo {
-        public function foo() {
-            echo Foo\Baz\BarFoo::$prop;
-        }
-    }
+	class BarFoo {
+		public function foo() {
+			echo Foo\Baz\BarFoo::$prop;
+		}
+	}
 }
 
 // Prevent false negative when namespace has whitespace/comments.
 namespace Foo /*comment*/ \ Bah {
-    class BarFoo {
-        public function foo() {
-            echo Foo \ /*comment*/ Bah\BarFoo::$prop;
-        }
-    }
+	class BarFoo {
+		public function foo() {
+			echo Foo \ /*comment*/ Bah\BarFoo::$prop;
+		}
+	}
 }

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Classes/ValidClassNameUnitTest.php 1 patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -15,56 +15,56 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            9   => 1,
-            10  => 1,
-            14  => 1,
-            15  => 1,
-            20  => 1,
-            30  => 1,
-            32  => 1,
-            57  => 1,
-            58  => 1,
-            62  => 1,
-            63  => 1,
-            68  => 1,
-            78  => 1,
-            80  => 1,
-            97  => 1,
-            98  => 1,
-            102 => 1,
-            103 => 1,
-            108 => 1,
-            118 => 1,
-            120 => 1,
-        ];
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			9   => 1,
+			10  => 1,
+			14  => 1,
+			15  => 1,
+			20  => 1,
+			30  => 1,
+			32  => 1,
+			57  => 1,
+			58  => 1,
+			62  => 1,
+			63  => 1,
+			68  => 1,
+			78  => 1,
+			80  => 1,
+			97  => 1,
+			98  => 1,
+			102 => 1,
+			103 => 1,
+			108 => 1,
+			118 => 1,
+			120 => 1,
+		];
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.php 3 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
+    public function getErrorList($testFile = 'ComparisonOperatorUsageUnitTest.inc')
     {
         switch ($testFile) {
         case 'ComparisonOperatorUsageUnitTest.inc':

Please login to merge, or discard this patch.

Indentation +77 added lines, -77 removed lines patch added patch discarded remove patch

@@ -15,87 +15,87 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
-    {
-        switch ($testFile) {
-        case 'ComparisonOperatorUsageUnitTest.inc':
-            return [
-                6   => 1,
-                7   => 1,
-                10  => 1,
-                11  => 1,
-                18  => 1,
-                19  => 1,
-                22  => 1,
-                23  => 1,
-                29  => 2,
-                32  => 2,
-                38  => 4,
-                47  => 2,
-                69  => 1,
-                72  => 1,
-                75  => 1,
-                78  => 1,
-                80  => 1,
-                82  => 1,
-                83  => 1,
-                89  => 1,
-                92  => 1,
-                100 => 1,
-                106 => 1,
-                112 => 1,
-                123 => 1,
-                127 => 1,
-                131 => 1,
-                135 => 1,
-            ];
-            break;
-        case 'ComparisonOperatorUsageUnitTest.js':
-            return [
-                5  => 1,
-                6  => 1,
-                17 => 1,
-                18 => 1,
-                28 => 2,
-                40 => 1,
-                47 => 1,
-                52 => 1,
-                63 => 1,
-                67 => 1,
-                71 => 1,
-            ];
-            break;
-        default:
-            return [];
-            break;
-        }//end switch
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
+	{
+		switch ($testFile) {
+		case 'ComparisonOperatorUsageUnitTest.inc':
+			return [
+				6   => 1,
+				7   => 1,
+				10  => 1,
+				11  => 1,
+				18  => 1,
+				19  => 1,
+				22  => 1,
+				23  => 1,
+				29  => 2,
+				32  => 2,
+				38  => 4,
+				47  => 2,
+				69  => 1,
+				72  => 1,
+				75  => 1,
+				78  => 1,
+				80  => 1,
+				82  => 1,
+				83  => 1,
+				89  => 1,
+				92  => 1,
+				100 => 1,
+				106 => 1,
+				112 => 1,
+				123 => 1,
+				127 => 1,
+				131 => 1,
+				135 => 1,
+			];
+			break;
+		case 'ComparisonOperatorUsageUnitTest.js':
+			return [
+				5  => 1,
+				6  => 1,
+				17 => 1,
+				18 => 1,
+				28 => 2,
+				40 => 1,
+				47 => 1,
+				52 => 1,
+				63 => 1,
+				67 => 1,
+				71 => 1,
+			];
+			break;
+		default:
+			return [];
+			break;
+		}//end switch
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

Switch Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

		@@ -28,56 +28,56 @@
		block discarded – undo
28	28	public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
29	29	{
30	30	switch ($testFile) {
31		- case 'ComparisonOperatorUsageUnitTest.inc':
32		- return [
33		- 6 => 1,
34		- 7 => 1,
35		- 10 => 1,
36		- 11 => 1,
37		- 18 => 1,
38		- 19 => 1,
39		- 22 => 1,
40		- 23 => 1,
41		- 29 => 2,
42		- 32 => 2,
43		- 38 => 4,
44		- 47 => 2,
45		- 69 => 1,
46		- 72 => 1,
47		- 75 => 1,
48		- 78 => 1,
49		- 80 => 1,
50		- 82 => 1,
51		- 83 => 1,
52		- 89 => 1,
53		- 92 => 1,
54		- 100 => 1,
55		- 106 => 1,
56		- 112 => 1,
57		- 123 => 1,
58		- 127 => 1,
59		- 131 => 1,
60		- 135 => 1,
61		- ];
62		- break;
63		- case 'ComparisonOperatorUsageUnitTest.js':
64		- return [
65		- 5 => 1,
66		- 6 => 1,
67		- 17 => 1,
68		- 18 => 1,
69		- 28 => 2,
70		- 40 => 1,
71		- 47 => 1,
72		- 52 => 1,
73		- 63 => 1,
74		- 67 => 1,
75		- 71 => 1,
76		- ];
77		- break;
78		- default:
79		- return [];
80		- break;
	31	+ case 'ComparisonOperatorUsageUnitTest.inc':
	32	+ return [
	33	+ 6 => 1,
	34	+ 7 => 1,
	35	+ 10 => 1,
	36	+ 11 => 1,
	37	+ 18 => 1,
	38	+ 19 => 1,
	39	+ 22 => 1,
	40	+ 23 => 1,
	41	+ 29 => 2,
	42	+ 32 => 2,
	43	+ 38 => 4,
	44	+ 47 => 2,
	45	+ 69 => 1,
	46	+ 72 => 1,
	47	+ 75 => 1,
	48	+ 78 => 1,
	49	+ 80 => 1,
	50	+ 82 => 1,
	51	+ 83 => 1,
	52	+ 89 => 1,
	53	+ 92 => 1,
	54	+ 100 => 1,
	55	+ 106 => 1,
	56	+ 112 => 1,
	57	+ 123 => 1,
	58	+ 127 => 1,
	59	+ 131 => 1,
	60	+ 135 => 1,
	61	+ ];
	62	+ break;
	63	+ case 'ComparisonOperatorUsageUnitTest.js':
	64	+ return [
	65	+ 5 => 1,
	66	+ 6 => 1,
	67	+ 17 => 1,
	68	+ 18 => 1,
	69	+ 28 => 2,
	70	+ 40 => 1,
	71	+ 47 => 1,
	72	+ 52 => 1,
	73	+ 63 => 1,
	74	+ 67 => 1,
	75	+ 71 => 1,
	76	+ ];
	77	+ break;
	78	+ default:
	79	+ return [];
	80	+ break;
81	81	}//end switch
82	82
83	83	}//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Operators/ValidLogicalOperatorsUnitTest.php 1 patch

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch

@@ -15,38 +15,38 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            5  => 1,
-            11 => 1,
-            17 => 2,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			5  => 1,
+			11 => 1,
+			17 => 2,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25	*
26	26	* @return array<int, int>
27	27	*/
28		- public function getErrorList($testFile='FileCommentUnitTest.inc')
	28	+ public function getErrorList($testFile = 'FileCommentUnitTest.inc')
29	29	{
30	30	switch ($testFile) {
31	31	case 'FileCommentUnitTest.1.inc':

		@@ -15,61 +15,61 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @param string $testFile The name of the file being tested.
25		- *
26		- * @return array<int, int>
27		- */
28		- public function getErrorList($testFile='FileCommentUnitTest.inc')
29		- {
30		- switch ($testFile) {
31		- case 'FileCommentUnitTest.1.inc':
32		- case 'FileCommentUnitTest.1.js':
33		- return [
34		- 1 => 1,
35		- 22 => 2,
36		- 23 => 1,
37		- 24 => 2,
38		- 25 => 2,
39		- 26 => 1,
40		- 27 => 2,
41		- 28 => 2,
42		- 32 => 2,
43		- ];
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @param string $testFile The name of the file being tested.
	25	+ *
	26	+ * @return array<int, int>
	27	+ */
	28	+ public function getErrorList($testFile='FileCommentUnitTest.inc')
	29	+ {
	30	+ switch ($testFile) {
	31	+ case 'FileCommentUnitTest.1.inc':
	32	+ case 'FileCommentUnitTest.1.js':
	33	+ return [
	34	+ 1 => 1,
	35	+ 22 => 2,
	36	+ 23 => 1,
	37	+ 24 => 2,
	38	+ 25 => 2,
	39	+ 26 => 1,
	40	+ 27 => 2,
	41	+ 28 => 2,
	42	+ 32 => 2,
	43	+ ];
44	44
45		- case 'FileCommentUnitTest.4.inc':
46		- case 'FileCommentUnitTest.6.inc':
47		- case 'FileCommentUnitTest.7.inc':
48		- return [1 => 1];
	45	+ case 'FileCommentUnitTest.4.inc':
	46	+ case 'FileCommentUnitTest.6.inc':
	47	+ case 'FileCommentUnitTest.7.inc':
	48	+ return [1 => 1];
49	49
50		- case 'FileCommentUnitTest.5.inc':
51		- return [2 => 1];
	50	+ case 'FileCommentUnitTest.5.inc':
	51	+ return [2 => 1];
52	52
53		- default:
54		- return [];
55		- }//end switch
	53	+ default:
	54	+ return [];
	55	+ }//end switch
56	56
57		- }//end getErrorList()
	57	+ }//end getErrorList()
58	58
59	59
60		- /**
61		- * Returns the lines where warnings should occur.
62		- *
63		- * The key of the array should represent the line number and the value
64		- * should represent the number of warnings that should occur on that line.
65		- *
66		- * @return array<int, int>
67		- */
68		- public function getWarningList()
69		- {
70		- return [];
	60	+ /**
	61	+ * Returns the lines where warnings should occur.
	62	+ *
	63	+ * The key of the array should represent the line number and the value
	64	+ * should represent the number of warnings that should occur on that line.
	65	+ *
	66	+ * @return array<int, int>
	67	+ */
	68	+ public function getWarningList()
	69	+ {
	70	+ return [];
71	71
72		- }//end getWarningList()
	72	+ }//end getWarningList()
73	73
74	74
75	75	}//end class

		@@ -28,30 +28,30 @@
		block discarded – undo
28	28	public function getErrorList($testFile='FileCommentUnitTest.inc')
29	29	{
30	30	switch ($testFile) {
31		- case 'FileCommentUnitTest.1.inc':
32		- case 'FileCommentUnitTest.1.js':
33		- return [
34		- 1 => 1,
35		- 22 => 2,
36		- 23 => 1,
37		- 24 => 2,
38		- 25 => 2,
39		- 26 => 1,
40		- 27 => 2,
41		- 28 => 2,
42		- 32 => 2,
43		- ];
	31	+ case 'FileCommentUnitTest.1.inc':
	32	+ case 'FileCommentUnitTest.1.js':
	33	+ return [
	34	+ 1 => 1,
	35	+ 22 => 2,
	36	+ 23 => 1,
	37	+ 24 => 2,
	38	+ 25 => 2,
	39	+ 26 => 1,
	40	+ 27 => 2,
	41	+ 28 => 2,
	42	+ 32 => 2,
	43	+ ];
44	44
45		- case 'FileCommentUnitTest.4.inc':
46		- case 'FileCommentUnitTest.6.inc':
47		- case 'FileCommentUnitTest.7.inc':
48		- return [1 => 1];
	45	+ case 'FileCommentUnitTest.4.inc':
	46	+ case 'FileCommentUnitTest.6.inc':
	47	+ case 'FileCommentUnitTest.7.inc':
	48	+ return [1 => 1];
49	49
50		- case 'FileCommentUnitTest.5.inc':
51		- return [2 => 1];
	50	+ case 'FileCommentUnitTest.5.inc':
	51	+ return [2 => 1];
52	52
53		- default:
54		- return [];
	53	+ default:
	54	+ return [];
55	55	}//end switch
56	56
57	57	}//end getErrorList()

		@@ -15,46 +15,46 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array<int, int>
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 9 => 1,
30		- 21 => 1,
31		- 35 => 1,
32		- 47 => 1,
33		- 61 => 2,
34		- 106 => 1,
35		- 123 => 1,
36		- 200 => 1,
37		- 219 => 1,
38		- 287 => 1,
39		- 397 => 1,
40		- ];
41		-
42		- }//end getErrorList()
43		-
44		-
45		- /**
46		- * Returns the lines where warnings should occur.
47		- *
48		- * The key of the array should represent the line number and the value
49		- * should represent the number of warnings that should occur on that line.
50		- *
51		- * @return array<int, int>
52		- */
53		- public function getWarningList()
54		- {
55		- return [];
56		-
57		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array<int, int>
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 9 => 1,
	30	+ 21 => 1,
	31	+ 35 => 1,
	32	+ 47 => 1,
	33	+ 61 => 2,
	34	+ 106 => 1,
	35	+ 123 => 1,
	36	+ 200 => 1,
	37	+ 219 => 1,
	38	+ 287 => 1,
	39	+ 397 => 1,
	40	+ ];
	41	+
	42	+ }//end getErrorList()
	43	+
	44	+
	45	+ /**
	46	+ * Returns the lines where warnings should occur.
	47	+ *
	48	+ * The key of the array should represent the line number and the value
	49	+ * should represent the number of warnings that should occur on that line.
	50	+ *
	51	+ * @return array<int, int>
	52	+ */
	53	+ public function getWarningList()
	54	+ {
	55	+ return [];
	56	+
	57	+ }//end getWarningList()
58	58
59	59
60	60	}//end class

		@@ -15,43 +15,43 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array<int, int>
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 13 => 1,
30		- 17 => 1,
31		- 31 => 1,
32		- 41 => 1,
33		- 59 => 1,
34		- 63 => 1,
35		- 67 => 1,
36		- 79 => 1,
37		- ];
38		-
39		- }//end getErrorList()
40		-
41		-
42		- /**
43		- * Returns the lines where warnings should occur.
44		- *
45		- * The key of the array should represent the line number and the value
46		- * should represent the number of warnings that should occur on that line.
47		- *
48		- * @return array<int, int>
49		- */
50		- public function getWarningList()
51		- {
52		- return [71 => 1];
53		-
54		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array<int, int>
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 13 => 1,
	30	+ 17 => 1,
	31	+ 31 => 1,
	32	+ 41 => 1,
	33	+ 59 => 1,
	34	+ 63 => 1,
	35	+ 67 => 1,
	36	+ 79 => 1,
	37	+ ];
	38	+
	39	+ }//end getErrorList()
	40	+
	41	+
	42	+ /**
	43	+ * Returns the lines where warnings should occur.
	44	+ *
	45	+ * The key of the array should represent the line number and the value
	46	+ * should represent the number of warnings that should occur on that line.
	47	+ *
	48	+ * @return array<int, int>
	49	+ */
	50	+ public function getWarningList()
	51	+ {
	52	+ return [71 => 1];
	53	+
	54	+ }//end getWarningList()
55	55
56	56
57	57	}//end class

		@@ -15,38 +15,38 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array<int, int>
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 4 => 1,
30		- 8 => 1,
31		- 28 => 1,
32		- ];
33		-
34		- }//end getErrorList()
35		-
36		-
37		- /**
38		- * Returns the lines where warnings should occur.
39		- *
40		- * The key of the array should represent the line number and the value
41		- * should represent the number of warnings that should occur on that line.
42		- *
43		- * @return array<int, int>
44		- */
45		- public function getWarningList()
46		- {
47		- return [];
48		-
49		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array<int, int>
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 4 => 1,
	30	+ 8 => 1,
	31	+ 28 => 1,
	32	+ ];
	33	+
	34	+ }//end getErrorList()
	35	+
	36	+
	37	+ /**
	38	+ * Returns the lines where warnings should occur.
	39	+ *
	40	+ * The key of the array should represent the line number and the value
	41	+ * should represent the number of warnings that should occur on that line.
	42	+ *
	43	+ * @return array<int, int>
	44	+ */
	45	+ public function getWarningList()
	46	+ {
	47	+ return [];
	48	+
	49	+ }//end getWarningList()
50	50
51	51
52	52	}//end class

		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	{
57	57	}//end class
58	58
59		-class ClassOne implements ClassFour ,ClassFive, ClassSix
	59	+class ClassOne implements ClassFour, ClassFive, ClassSix
60	60	{
61	61	}//end class
62	62
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82
83	83	} // phpcs:enable Standard.Category.Sniff
84	84
85		-class File implements \Zend_Auth_Storage_Interface,\Zend_Auth_Storage, \Zend_Foo
	85	+class File implements \Zend_Auth_Storage_Interface, \Zend_Auth_Storage, \Zend_Foo
86	86	{
87	87	}
88	88
		@@ -107,4 +107,4 @@ discard block
		block discarded – undo
107	107	class IncorrectCodeBeforeClosingBrace
108	108	{
109	109
110		-echo phpinfo();}
	110	+echo phpinfo(); }

		@@ -24,10 +24,10 @@ discard block
		block discarded – undo
24	24	class IncorrectBracePlacementWithImplements implements correctClassDeclaration {}
25	25
26	26
27		- class IncorrectIndentedClass
28		- {
	27	+ class IncorrectIndentedClass
	28	+ {
29	29
30		- }//end class
	30	+ }//end class
31	31
32	32
33	33	// Incorrect code placement for opening/closing brace.
		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47
48	48	echo phpinfo(); }
49	49
50		- class IncorrectIndentedClass
	50	+ class IncorrectIndentedClass
51	51	{
52	52
53	53	}
		@@ -96,7 +96,7 @@ discard block
		block discarded – undo
96	96
97	97	class MyClass2
98	98	{
99		- var $x;
	99	+ var $x;
100	100	}
101	101
102	102

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	public function SelfMemberReferenceUnitTestExample()
15	15	{
16		- $testResults =& $this->testResults;
	16	+ $testResults = & $this->testResults;
17	17
18	18
19	19	// Correct call to self.
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	MyClass::test($value);
58	58	};
59	59
60		- $array = array(1,2,3);
	60	+ $array = array(1, 2, 3);
61	61	array_walk($array, $callback);
62	62	}
63	63	}

		@@ -5,54 +5,54 @@ discard block
		block discarded – undo
5	5	{
6	6
7	7
8		- private $testCount = 0;
	8	+ private $testCount = 0;
9	9
10	10
11		- private $testResults = array();
	11	+ private $testResults = array();
12	12
13	13
14		- public function SelfMemberReferenceUnitTestExample()
15		- {
16		- $testResults =& $this->testResults;
	14	+ public function SelfMemberReferenceUnitTestExample()
	15	+ {
	16	+ $testResults =& $this->testResults;
17	17
18	18
19		- // Correct call to self.
20		- $testResults[] = self::selfMemberReferenceUnitTestFunction();
21		- $testResults[] = parent::selfMemberReferenceUnitTestFunction();
	19	+ // Correct call to self.
	20	+ $testResults[] = self::selfMemberReferenceUnitTestFunction();
	21	+ $testResults[] = parent::selfMemberReferenceUnitTestFunction();
22	22
23		- // Incorrect case.
24		- $testResults[] = Self::selfMemberReferenceUnitTestFunction();
25		- $testResults[] = SELF::selfMemberReferenceUnitTestFunction();
26		- $testResults[] = SelfMemberReferenceUnitTestExample::selfMemberReferenceUnitTestFunction();
	23	+ // Incorrect case.
	24	+ $testResults[] = Self::selfMemberReferenceUnitTestFunction();
	25	+ $testResults[] = SELF::selfMemberReferenceUnitTestFunction();
	26	+ $testResults[] = SelfMemberReferenceUnitTestExample::selfMemberReferenceUnitTestFunction();
27	27
28	28
29		- // Incorrect spacing.
30		- $testResults[] = self ::selfMemberReferenceUnitTestFunction();
31		- $testResults[] = self:: selfMemberReferenceUnitTestFunction();
32		- $testResults[] = self :: selfMemberReferenceUnitTestFunction();
	29	+ // Incorrect spacing.
	30	+ $testResults[] = self ::selfMemberReferenceUnitTestFunction();
	31	+ $testResults[] = self:: selfMemberReferenceUnitTestFunction();
	32	+ $testResults[] = self :: selfMemberReferenceUnitTestFunction();
33	33
34		- // Remove ALL the newlines
35		- $testResults[] = self
	34	+ // Remove ALL the newlines
	35	+ $testResults[] = self
36	36
37	37
38	38
39	39
40		- ::
	40	+ ::
41	41
42	42
43	43
44	44
45		- selfMemberReferenceUnitTestFunction();
	45	+ selfMemberReferenceUnitTestFunction();
46	46
47		- }
	47	+ }
48	48
49	49
50		- function selfMemberReferenceUnitTestFunction()
51		- {
52		- $this->testCount = $this->testCount + 1;
53		- return $this->testCount;
	50	+ function selfMemberReferenceUnitTestFunction()
	51	+ {
	52	+ $this->testCount = $this->testCount + 1;
	53	+ return $this->testCount;
54	54
55		- }
	55	+ }
56	56
57	57
58	58	}
		@@ -60,115 +60,115 @@ discard block
		block discarded – undo
60	60
61	61	class MyClass {
62	62
63		- public static function test($value) {
64		- echo "$value\n";
65		- }
	63	+ public static function test($value) {
	64	+ echo "$value\n";
	65	+ }
66	66
67		- public static function walk() {
68		- $callback = function($value, $key) {
69		- // This is valid because you can't use self:: in a closure.
70		- MyClass::test($value);
71		- };
	67	+ public static function walk() {
	68	+ $callback = function($value, $key) {
	69	+ // This is valid because you can't use self:: in a closure.
	70	+ MyClass::test($value);
	71	+ };
72	72
73		- $array = array(1,2,3);
74		- array_walk($array, $callback);
75		- }
	73	+ $array = array(1,2,3);
	74	+ array_walk($array, $callback);
	75	+ }
76	76	}
77	77
78	78	MyClass::walk();
79	79
80	80	class Controller
81	81	{
82		- public function Action()
83		- {
84		- Doctrine\Common\Util\Debug::dump();
85		- }
	82	+ public function Action()
	83	+ {
	84	+ Doctrine\Common\Util\Debug::dump();
	85	+ }
86	86	}
87	87
88	88	class Foo
89	89	{
90		- public static function bar()
91		- {
92		- \Foo::baz();
93		- }
	90	+ public static function bar()
	91	+ {
	92	+ \Foo::baz();
	93	+ }
94	94	}
95	95
96	96	namespace TYPO3\CMS\Reports;
97	97
98	98	class Status {
99		- const NOTICE = -2;
100		- const INFO = -1;
101		- const OK = 0;
102		- const WARNING = 1;
103		- const ERROR = 2;
	99	+ const NOTICE = -2;
	100	+ const INFO = -1;
	101	+ const OK = 0;
	102	+ const WARNING = 1;
	103	+ const ERROR = 2;
104	104	}
105	105
106	106	namespace TYPO3\CMS\Reports\Report\Status;
107	107
108	108	class Status implements \TYPO3\CMS\Reports\ReportInterface {
109		- public function getHighestSeverity(array $statusCollection) {
110		- $highestSeverity = \TYPO3\CMS\Reports\Status::NOTICE;
111		- }
	109	+ public function getHighestSeverity(array $statusCollection) {
	110	+ $highestSeverity = \TYPO3\CMS\Reports\Status::NOTICE;
	111	+ }
112	112	}
113	113
114	114	namespace Foo;
115	115
116	116	class Bar {
117	117
118		- function myFunction()
119		- {
120		- \Foo\Whatever::something();
121		- \Foo\Bar::something();
122		- }
	118	+ function myFunction()
	119	+ {
	120	+ \Foo\Whatever::something();
	121	+ \Foo\Bar::something();
	122	+ }
123	123	}
124	124
125	125	namespace Foo\Bar;
126	126
127	127	class Baz {
128	128
129		- function myFunction()
130		- {
131		- \Foo\Bar\Whatever::something();
132		- \Foo\Bar\Baz::something();
133		- }
	129	+ function myFunction()
	130	+ {
	131	+ \Foo\Bar\Whatever::something();
	132	+ \Foo\Bar\Baz::something();
	133	+ }
134	134	}
135	135
136	136	class Nested_Anon_Class {
137		- public function getAnonymousClass() {
138		- // Spacing/comments should not cause false negatives for the NotUsed error.
139		- Nested_Anon_Class :: $prop;
140		- Nested_Anon_Class
141		- /* some comment */
142		-
143		- ::
144		-
145		- // phpcs:ignore Standard.Category.SniffName -- for reasons.
146		- Bar();
147		-
148		- // Anonymous class is a different scope.
149		- return new class() {
150		- public function nested_function() {
151		- Nested_Anon_Class::$prop;
152		- Nested_Anon_Class::BAR;
153		- }
154		- };
155		- }
	137	+ public function getAnonymousClass() {
	138	+ // Spacing/comments should not cause false negatives for the NotUsed error.
	139	+ Nested_Anon_Class :: $prop;
	140	+ Nested_Anon_Class
	141	+ /* some comment */
	142	+
	143	+ ::
	144	+
	145	+ // phpcs:ignore Standard.Category.SniffName -- for reasons.
	146	+ Bar();
	147	+
	148	+ // Anonymous class is a different scope.
	149	+ return new class() {
	150	+ public function nested_function() {
	151	+ Nested_Anon_Class::$prop;
	152	+ Nested_Anon_Class::BAR;
	153	+ }
	154	+ };
	155	+ }
156	156	}
157	157
158	158	// Test dealing with scoped namespaces.
159	159	namespace Foo\Baz {
160		- class BarFoo {
161		- public function foo() {
162		- echo Foo\Baz\BarFoo::$prop;
163		- }
164		- }
	160	+ class BarFoo {
	161	+ public function foo() {
	162	+ echo Foo\Baz\BarFoo::$prop;
	163	+ }
	164	+ }
165	165	}
166	166
167	167	// Prevent false negative when namespace has whitespace/comments.
168	168	namespace Foo /comment/ \ Bah {
169		- class BarFoo {
170		- public function foo() {
171		- echo Foo \ /comment/ Bah\BarFoo::$prop;
172		- }
173		- }
	169	+ class BarFoo {
	170	+ public function foo() {
	171	+ echo Foo \ /comment/ Bah\BarFoo::$prop;
	172	+ }
	173	+ }
174	174	}

		@@ -15,56 +15,56 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array<int, int>
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 9 => 1,
30		- 10 => 1,
31		- 14 => 1,
32		- 15 => 1,
33		- 20 => 1,
34		- 30 => 1,
35		- 32 => 1,
36		- 57 => 1,
37		- 58 => 1,
38		- 62 => 1,
39		- 63 => 1,
40		- 68 => 1,
41		- 78 => 1,
42		- 80 => 1,
43		- 97 => 1,
44		- 98 => 1,
45		- 102 => 1,
46		- 103 => 1,
47		- 108 => 1,
48		- 118 => 1,
49		- 120 => 1,
50		- ];
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array<int, int>
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 9 => 1,
	30	+ 10 => 1,
	31	+ 14 => 1,
	32	+ 15 => 1,
	33	+ 20 => 1,
	34	+ 30 => 1,
	35	+ 32 => 1,
	36	+ 57 => 1,
	37	+ 58 => 1,
	38	+ 62 => 1,
	39	+ 63 => 1,
	40	+ 68 => 1,
	41	+ 78 => 1,
	42	+ 80 => 1,
	43	+ 97 => 1,
	44	+ 98 => 1,
	45	+ 102 => 1,
	46	+ 103 => 1,
	47	+ 108 => 1,
	48	+ 118 => 1,
	49	+ 120 => 1,
	50	+ ];
51	51
52		- }//end getErrorList()
	52	+ }//end getErrorList()
53	53
54	54
55		- /**
56		- * Returns the lines where warnings should occur.
57		- *
58		- * The key of the array should represent the line number and the value
59		- * should represent the number of warnings that should occur on that line.
60		- *
61		- * @return array<int, int>
62		- */
63		- public function getWarningList()
64		- {
65		- return [];
	55	+ /**
	56	+ * Returns the lines where warnings should occur.
	57	+ *
	58	+ * The key of the array should represent the line number and the value
	59	+ * should represent the number of warnings that should occur on that line.
	60	+ *
	61	+ * @return array<int, int>
	62	+ */
	63	+ public function getWarningList()
	64	+ {
	65	+ return [];
66	66
67		- }//end getWarningList()
	67	+ }//end getWarningList()
68	68
69	69
70	70	}//end class

		@@ -15,87 +15,87 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @param string $testFile The name of the file being tested.
25		- *
26		- * @return array<int, int>
27		- */
28		- public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
29		- {
30		- switch ($testFile) {
31		- case 'ComparisonOperatorUsageUnitTest.inc':
32		- return [
33		- 6 => 1,
34		- 7 => 1,
35		- 10 => 1,
36		- 11 => 1,
37		- 18 => 1,
38		- 19 => 1,
39		- 22 => 1,
40		- 23 => 1,
41		- 29 => 2,
42		- 32 => 2,
43		- 38 => 4,
44		- 47 => 2,
45		- 69 => 1,
46		- 72 => 1,
47		- 75 => 1,
48		- 78 => 1,
49		- 80 => 1,
50		- 82 => 1,
51		- 83 => 1,
52		- 89 => 1,
53		- 92 => 1,
54		- 100 => 1,
55		- 106 => 1,
56		- 112 => 1,
57		- 123 => 1,
58		- 127 => 1,
59		- 131 => 1,
60		- 135 => 1,
61		- ];
62		- break;
63		- case 'ComparisonOperatorUsageUnitTest.js':
64		- return [
65		- 5 => 1,
66		- 6 => 1,
67		- 17 => 1,
68		- 18 => 1,
69		- 28 => 2,
70		- 40 => 1,
71		- 47 => 1,
72		- 52 => 1,
73		- 63 => 1,
74		- 67 => 1,
75		- 71 => 1,
76		- ];
77		- break;
78		- default:
79		- return [];
80		- break;
81		- }//end switch
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @param string $testFile The name of the file being tested.
	25	+ *
	26	+ * @return array<int, int>
	27	+ */
	28	+ public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
	29	+ {
	30	+ switch ($testFile) {
	31	+ case 'ComparisonOperatorUsageUnitTest.inc':
	32	+ return [
	33	+ 6 => 1,
	34	+ 7 => 1,
	35	+ 10 => 1,
	36	+ 11 => 1,
	37	+ 18 => 1,
	38	+ 19 => 1,
	39	+ 22 => 1,
	40	+ 23 => 1,
	41	+ 29 => 2,
	42	+ 32 => 2,
	43	+ 38 => 4,
	44	+ 47 => 2,
	45	+ 69 => 1,
	46	+ 72 => 1,
	47	+ 75 => 1,
	48	+ 78 => 1,
	49	+ 80 => 1,
	50	+ 82 => 1,
	51	+ 83 => 1,
	52	+ 89 => 1,
	53	+ 92 => 1,
	54	+ 100 => 1,
	55	+ 106 => 1,
	56	+ 112 => 1,
	57	+ 123 => 1,
	58	+ 127 => 1,
	59	+ 131 => 1,
	60	+ 135 => 1,
	61	+ ];
	62	+ break;
	63	+ case 'ComparisonOperatorUsageUnitTest.js':
	64	+ return [
	65	+ 5 => 1,
	66	+ 6 => 1,
	67	+ 17 => 1,
	68	+ 18 => 1,
	69	+ 28 => 2,
	70	+ 40 => 1,
	71	+ 47 => 1,
	72	+ 52 => 1,
	73	+ 63 => 1,
	74	+ 67 => 1,
	75	+ 71 => 1,
	76	+ ];
	77	+ break;
	78	+ default:
	79	+ return [];
	80	+ break;
	81	+ }//end switch
82	82
83		- }//end getErrorList()
	83	+ }//end getErrorList()
84	84
85	85
86		- /**
87		- * Returns the lines where warnings should occur.
88		- *
89		- * The key of the array should represent the line number and the value
90		- * should represent the number of warnings that should occur on that line.
91		- *
92		- * @return array<int, int>
93		- */
94		- public function getWarningList()
95		- {
96		- return [];
	86	+ /**
	87	+ * Returns the lines where warnings should occur.
	88	+ *
	89	+ * The key of the array should represent the line number and the value
	90	+ * should represent the number of warnings that should occur on that line.
	91	+ *
	92	+ * @return array<int, int>
	93	+ */
	94	+ public function getWarningList()
	95	+ {
	96	+ return [];
97	97
98		- }//end getWarningList()
	98	+ }//end getWarningList()
99	99
100	100
101	101	}//end class

eventespresso / event-espresso-core

Branch — FET/extract-admin-menu (26a1ca)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +92 added lines, -92 removed lines patch added patch discarded remove patch

Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +77 added lines, -77 removed lines patch added patch discarded remove patch

Switch Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

Indentation +32 added lines, -32 removed lines patch added patch discarded remove patch