Completed
Branch BUG-10738-inconsistency-in-ses... (4fb977)
by
unknown
104:46 queued 94:10
created
core/db_classes/EE_Extra_Meta.class.php 2 patches
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 	 * @param array $props_n_values
31 31
 	 * @return EE_Extra_Meta|mixed
32 32
 	 */
33
-	public static function new_instance( $props_n_values = array() ) {
34
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
35
-		return $has_object ? $has_object : new self( $props_n_values );
33
+	public static function new_instance($props_n_values = array()) {
34
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
35
+		return $has_object ? $has_object : new self($props_n_values);
36 36
 	}
37 37
 
38 38
 
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 	 * @param array $props_n_values
42 42
 	 * @return EE_Extra_Meta
43 43
 	 */
44
-	public static function new_instance_from_db( $props_n_values = array() ) {
45
-		return new self( $props_n_values, TRUE );
44
+	public static function new_instance_from_db($props_n_values = array()) {
45
+		return new self($props_n_values, TRUE);
46 46
 	}
47 47
 
48 48
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @return int
53 53
 	 */
54 54
 	function FK_ID() {
55
-		return $this->get( 'FK_ID' );
55
+		return $this->get('FK_ID');
56 56
 	}
57 57
 
58 58
 
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
 	 * @param int $FK_ID
63 63
 	 * @return boolean
64 64
 	 */
65
-	function set_FK_ID( $FK_ID ) {
66
-		$this->set( 'FK_ID', $FK_ID );
65
+	function set_FK_ID($FK_ID) {
66
+		$this->set('FK_ID', $FK_ID);
67 67
 	}
68 68
 
69 69
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 * @return string
74 74
 	 */
75 75
 	function model() {
76
-		return $this->get( 'EXM_model' );
76
+		return $this->get('EXM_model');
77 77
 	}
78 78
 
79 79
 
@@ -83,8 +83,8 @@  discard block
 block discarded – undo
83 83
 	 * @param string $model
84 84
 	 * @return boolean
85 85
 	 */
86
-	function set_model( $model ) {
87
-		$this->set( 'EXM_model', $model );
86
+	function set_model($model) {
87
+		$this->set('EXM_model', $model);
88 88
 	}
89 89
 
90 90
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 * @return string
95 95
 	 */
96 96
 	function key() {
97
-		return $this->get( 'EXM_key' );
97
+		return $this->get('EXM_key');
98 98
 	}
99 99
 
100 100
 
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
104 104
 	 * @param string $key
105 105
 	 * @return boolean
106 106
 	 */
107
-	function set_key( $key ) {
108
-		$this->set( 'EXM_key', $key );
107
+	function set_key($key) {
108
+		$this->set('EXM_key', $key);
109 109
 	}
110 110
 
111 111
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	 * @return string
116 116
 	 */
117 117
 	function value() {
118
-		return $this->get( 'EXM_value' );
118
+		return $this->get('EXM_value');
119 119
 	}
120 120
 
121 121
 
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 	 * @param string $value
126 126
 	 * @return boolean
127 127
 	 */
128
-	function set_value( $value ) {
129
-		$this->set( 'EXM_value', $value );
128
+	function set_value($value) {
129
+		$this->set('EXM_value', $value);
130 130
 	}
131 131
 
132 132
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	/**
61 61
 	 * Sets FK_ID
62 62
 	 * @param int $FK_ID
63
-	 * @return boolean
63
+	 * @return boolean|null
64 64
 	 */
65 65
 	function set_FK_ID( $FK_ID ) {
66 66
 		$this->set( 'FK_ID', $FK_ID );
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 	/**
82 82
 	 * Sets model
83 83
 	 * @param string $model
84
-	 * @return boolean
84
+	 * @return boolean|null
85 85
 	 */
86 86
 	function set_model( $model ) {
87 87
 		$this->set( 'EXM_model', $model );
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	/**
103 103
 	 * Sets key
104 104
 	 * @param string $key
105
-	 * @return boolean
105
+	 * @return boolean|null
106 106
 	 */
107 107
 	function set_key( $key ) {
108 108
 		$this->set( 'EXM_key', $key );
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	/**
124 124
 	 * Sets value
125 125
 	 * @param string $value
126
-	 * @return boolean
126
+	 * @return boolean|null
127 127
 	 */
128 128
 	function set_value( $value ) {
129 129
 		$this->set( 'EXM_value', $value );
Please login to merge, or discard this patch.
core/db_classes/EE_Import.class.php 4 patches
Braces   +27 added lines, -25 removed lines patch added patch discarded remove patch
@@ -1,4 +1,6 @@  discard block
 block discarded – undo
1
-<?php if (!defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
1
+<?php if (!defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3
+}
2 4
 do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
3 5
 /**
4 6
  * EE_Import class
@@ -295,7 +297,7 @@  discard block
 block discarded – undo
295 297
 			if(isset($csv_metadata['site_url']) && $csv_metadata['site_url'] == site_url()){
296 298
 				EE_Error::add_attention(sprintf(__("CSV Data appears to be from the same database, so attempting to update data", "event_espresso")));
297 299
 				$export_from_site_a_to_b = false;
298
-			}else{
300
+			} else{
299 301
 				$old_site_url = isset( $csv_metadata['site_url']) ? $csv_metadata['site_url'] : $old_site_url;
300 302
 				EE_Error::add_attention(sprintf(__("CSV Data appears to be from a different database (%s instead of %s), so we assume IDs in the CSV data DO NOT correspond to IDs in this database", "event_espresso"),$old_site_url,site_url()));
301 303
 			};
@@ -376,7 +378,7 @@  discard block
 block discarded – undo
376 378
 			//now check that assumption was correct. If
377 379
 			if ( EE_Registry::instance()->is_model_name($model_name_in_csv_data)) {
378 380
 				$model_name = $model_name_in_csv_data;
379
-			}else {
381
+			} else {
380 382
 				// no table info in the array and no table name passed to the function?? FAIL
381 383
 				EE_Error::add_error( __('No table information was specified and/or found, therefore the import could not be completed','event_espresso'), __FILE__, __FUNCTION__, __LINE__ );
382 384
 				return FALSE;
@@ -400,7 +402,7 @@  discard block
 block discarded – undo
400 402
 				//there is no primary key)
401 403
 				if($model->has_primary_key_field()){
402 404
 					$id_in_csv =  $model_object_data[$model->primary_key_name()];
403
-				}else{
405
+				} else{
404 406
 					$id_in_csv = $model->get_index_primary_key_string($model_object_data);
405 407
 				}
406 408
 
@@ -410,7 +412,7 @@  discard block
 block discarded – undo
410 412
 				//or just update.
411 413
 				if($export_from_site_a_to_b){
412 414
 					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_other_db( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
413
-				}else{//this is just a re-import
415
+				} else{//this is just a re-import
414 416
 					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_same_db( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
415 417
 				}
416 418
 				if( $what_to_do == self::do_nothing ) {
@@ -430,7 +432,7 @@  discard block
 block discarded – undo
430 432
 						if($model->has_primary_key_field()){
431 433
 							$old_db_to_new_db_mapping[$model_name][$id_in_csv] = $conflicting->ID();
432 434
 							$model_object_data[$model->primary_key_name()] = $conflicting->ID();
433
-						}else{
435
+						} else{
434 436
 							//we want to update this conflicting item, instead of inserting a conflicting item
435 437
 							//so we need to make sure they match entirely (its possible that they only conflicted on one field, but we need them to match on other fields
436 438
 							//for the WHERE conditions in the update). At the time of this comment, there were no models like this
@@ -442,9 +444,9 @@  discard block
 block discarded – undo
442 444
 				}
443 445
 				if( $what_to_do == self::do_insert ) {
444 446
 					$old_db_to_new_db_mapping = $this->_insert_from_data_array( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
445
-				}elseif( $what_to_do == self::do_update ) {
447
+				} elseif( $what_to_do == self::do_update ) {
446 448
 					$old_db_to_new_db_mapping = $this->_update_from_data_array( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
447
-				}else{
449
+				} else{
448 450
 					throw new EE_Error( sprintf( __( 'Programming error. We shoudl be inserting or updating, but instead we are being told to "%s", whifh is invalid', 'event_espresso' ), $what_to_do ) );
449 451
 				}
450 452
 			}
@@ -472,7 +474,7 @@  discard block
 block discarded – undo
472 474
 		//in the old data that we know of
473 475
 		if( isset($old_db_to_new_db_mapping[$model_name][$id_in_csv]) ){
474 476
 			return self::do_update;
475
-		}else{
477
+		} else{
476 478
 			return self::do_insert;
477 479
 		}
478 480
 	}
@@ -491,7 +493,7 @@  discard block
 block discarded – undo
491 493
 		//in this case, check if this thing ACTUALLY exists in the database
492 494
 		if( $model->get_one_conflicting( $model_object_data ) ){
493 495
 			return self::do_update;
494
-		}else{
496
+		} else{
495 497
 			return self::do_insert;
496 498
 		}
497 499
 	}
@@ -522,7 +524,7 @@  discard block
 block discarded – undo
522 524
 		try{
523 525
 			$model_name_field = $model->get_field_containing_related_model_name();
524 526
 			$models_pointed_to_by_model_name_field = $model_name_field->get_model_names_pointed_to();
525
-		}catch( EE_Error $e ){
527
+		} catch( EE_Error $e ){
526 528
 			$model_name_field = NULL;
527 529
 			$models_pointed_to_by_model_name_field = array();
528 530
 		}
@@ -543,7 +545,7 @@  discard block
 block discarded – undo
543 545
 								$found_a_mapping = true;
544 546
 								break;
545 547
 						}
546
-					}else{
548
+					} else{
547 549
 						$model_object_data[ $field_obj->get_name() ] = $this->_find_mapping_in(
548 550
 								$model_object_data[ $field_obj->get_name() ],
549 551
 								$model_pointed_to_by_fk,
@@ -558,7 +560,7 @@  discard block
 block discarded – undo
558 560
 
559 561
 
560 562
 				}
561
-			}else{
563
+			} else{
562 564
 				//it's a string foreign key (which we leave alone, because those are things
563 565
 				//like country names, which we'd really rather not make 2 USAs etc (we'd actually
564 566
 				//prefer to just update one)
@@ -601,14 +603,14 @@  discard block
 block discarded – undo
601 603
 		if(	isset( $old_db_to_new_db_mapping[ $model_name ][ $object_id ] ) ){
602 604
 
603 605
 				return $old_db_to_new_db_mapping[ $model_name ][ $object_id ];
604
-			}elseif( $object_id == '0' || $object_id == '' ) {
606
+			} elseif( $object_id == '0' || $object_id == '' ) {
605 607
 				//leave as-is
606 608
 				return $object_id;
607
-			}elseif( $export_from_site_a_to_b ){
609
+			} elseif( $export_from_site_a_to_b ){
608 610
 				//we couldn't find a mapping for this, and it's from a different site,
609 611
 				//so blank it out
610 612
 				return NULL;
611
-			}elseif( ! $export_from_site_a_to_b ) {
613
+			} elseif( ! $export_from_site_a_to_b ) {
612 614
 				//we coudln't find a mapping for this, but it's from thsi DB anyway
613 615
 				//so let's just leave it as-is
614 616
 				return $object_id;
@@ -629,7 +631,7 @@  discard block
 block discarded – undo
629 631
 		if($model->has_primary_key_field() && $model->get_primary_key_field()->is_auto_increment()){
630 632
 			$effective_id = $model_object_data[$model->primary_key_name()];
631 633
 			unset($model_object_data[$model->primary_key_name()]);
632
-		}else{
634
+		} else{
633 635
 			$effective_id = $model->get_index_primary_key_string( $model_object_data );
634 636
 		}
635 637
 		//the model takes care of validating the CSV's input
@@ -639,7 +641,7 @@  discard block
 block discarded – undo
639 641
 				$old_db_to_new_db_mapping[$model->get_this_model_name()][$id_in_csv] = $new_id;
640 642
 				$this->_total_inserts++;
641 643
 				EE_Error::add_success( sprintf(__("Successfully added new %s (with id %s) with csv data %s", "event_espresso"),$model->get_this_model_name(),$new_id, implode(",",$model_object_data)));
642
-			}else{
644
+			} else{
643 645
 				$this->_total_insert_errors++;
644 646
 				//put the ID used back in there for the error message
645 647
 				if($model->has_primary_key_field()){
@@ -647,7 +649,7 @@  discard block
 block discarded – undo
647 649
 				}
648 650
 				EE_Error::add_error( sprintf(__("Could not insert new %s with the csv data: %s", "event_espresso"),$model->get_this_model_name(),http_build_query($model_object_data)), __FILE__, __FUNCTION__, __LINE__ );
649 651
 			}
650
-		}catch(EE_Error $e){
652
+		} catch(EE_Error $e){
651 653
 			$this->_total_insert_errors++;
652 654
 			if($model->has_primary_key_field()){
653 655
 				$model_object_data[$model->primary_key_name()] = $effective_id;
@@ -674,12 +676,12 @@  discard block
 block discarded – undo
674 676
 				$conditions = array($model->primary_key_name() => $model_object_data[$model->primary_key_name()]);
675 677
 				//remove the primary key because we shouldn't use it for updating
676 678
 				unset($model_object_data_for_update[$model->primary_key_name()]);
677
-			}elseif($model->get_combined_primary_key_fields() > 1 ){
679
+			} elseif($model->get_combined_primary_key_fields() > 1 ){
678 680
 				$conditions = array();
679 681
 				foreach($model->get_combined_primary_key_fields() as $key_field){
680 682
 					$conditions[$key_field->get_name()] = $model_object_data[$key_field->get_name()];
681 683
 				}
682
-			}else{
684
+			} else{
683 685
 				$model->primary_key_name();//this shoudl just throw an exception, explaining that we dont have a primary key (or a combine dkey)
684 686
 			}
685 687
 
@@ -693,23 +695,23 @@  discard block
 block discarded – undo
693 695
 				//and so we record what record ended up being updated using the mapping
694 696
 				if( $model->has_primary_key_field() ){
695 697
 					$new_key_for_mapping = $model_object_data[ $model->primary_key_name() ];
696
-				}else{
698
+				} else{
697 699
 					//no primary key just a combined key
698 700
 					$new_key_for_mapping = $model->get_index_primary_key_string( $model_object_data );
699 701
 				}
700 702
 				$old_db_to_new_db_mapping[ $model->get_this_model_name() ][ $id_in_csv ] = $new_key_for_mapping;
701
-			}else{
703
+			} else{
702 704
 				$matched_items = $model->get_all(array($conditions));
703 705
 				if( ! $matched_items){
704 706
 					//no items were matched (so we shouldn't have updated)... but then we should have inserted? what the heck?
705 707
 					$this->_total_update_errors++;
706 708
 					EE_Error::add_error( sprintf(__("Could not update %s with the csv data: '%s' for an unknown reason (using WHERE conditions %s)", "event_espresso"),$model->get_this_model_name(),http_build_query($model_object_data),http_build_query($conditions)), __FILE__, __FUNCTION__, __LINE__ );
707
-				}else{
709
+				} else{
708 710
 					$this->_total_updates++;
709 711
 					EE_Error::add_success( sprintf(__("%s with csv data '%s' was found in the database and didn't need updating because all the data is identical.", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data)));
710 712
 				}
711 713
 			}
712
-		}catch(EE_Error $e){
714
+		} catch(EE_Error $e){
713 715
 			$this->_total_update_errors++;
714 716
 			$basic_message = sprintf(__("Could not update %s with the csv data: %s because %s", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data),$e->getMessage());
715 717
 			$debug_message = $basic_message . ' Stack trace: ' . $e->getTraceAsString();
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -10 removed lines patch added patch discarded remove patch
@@ -79,10 +79,6 @@  discard block
 block discarded – undo
79 79
 	 *	@ access 	public
80 80
 	 * 	@param 	string 		$title - heading for the form
81 81
 	 * 	@param 	string 		$intro - additional text explaing what to do
82
-	 * 	@param 	string 		$page - EE Admin page to direct form to - in the form "espresso_{pageslug}"
83
-	 * 	@param 	string 		$action - EE Admin page route array "action" that form will direct to
84
-	 * 	@param 	string 		$type - type of file to import
85
-	 *	@ return 	string
86 82
 	 */
87 83
 	public function upload_form ( $title, $intro, $form_url, $action, $type  ) {
88 84
 
@@ -121,7 +117,7 @@  discard block
 block discarded – undo
121 117
 	/**
122 118
 	 *	@Import Event Espresso data - some code "borrowed" from event espresso csv_import.php
123 119
 	 *	@access public
124
-	 *	@return boolean success
120
+	 *	@return boolean|null success
125 121
 	 */
126 122
 	public function import() {
127 123
 
@@ -272,8 +268,7 @@  discard block
 block discarded – undo
272 268
       *
273 269
       * @access public
274 270
       * @param array $csv_data_array - the array containing the csv data produced from EE_CSV::import_csv_to_model_data_array()
275
-      * @param array $fields_to_save - an array containing the csv column names as keys with the corresponding db table fields they will be saved to
276
-      * @return TRUE on success, FALSE on fail
271
+      * @return boolean on success, FALSE on fail
277 272
       * @throws \EE_Error
278 273
       */
279 274
 	public function save_csv_data_array_to_db( $csv_data_array, $model_name = FALSE ) {
@@ -370,7 +365,7 @@  discard block
 block discarded – undo
370 365
 	 * we need to insert a new row for that ID, and then map from the non-existent ID
371 366
 	 * to the newly-inserted real ID.
372 367
 	 * @param type $csv_data_array
373
-	 * @param type $export_from_site_a_to_b
368
+	 * @param boolean $export_from_site_a_to_b
374 369
 	 * @param type $old_db_to_new_db_mapping
375 370
 	 * @return array updated $old_db_to_new_db_mapping
376 371
 	 */
@@ -487,7 +482,6 @@  discard block
 block discarded – undo
487 482
 	 * @param type $id_in_csv
488 483
 	 * @param type $model_object_data
489 484
 	 * @param EEM_Base $model
490
-	 * @param type $old_db_to_new_db_mapping
491 485
 	 * @return
492 486
 	 */
493 487
 	protected function _decide_whether_to_insert_or_update_given_data_from_same_db( $id_in_csv, $model_object_data, $model ) {
@@ -597,7 +591,7 @@  discard block
 block discarded – undo
597 591
 	 * @param type $object_id
598 592
 	 * @param string $model_name
599 593
 	 * @param array $old_db_to_new_db_mapping
600
-	 * @param type $export_from_site_a_to_b
594
+	 * @param boolean $export_from_site_a_to_b
601 595
 	 * @return int
602 596
 	 */
603 597
 	protected function _find_mapping_in( $object_id, $model_name, $old_db_to_new_db_mapping, $export_from_site_a_to_b) {
Please login to merge, or discard this patch.
Indentation   +71 added lines, -71 removed lines patch added patch discarded remove patch
@@ -131,43 +131,43 @@  discard block
 block discarded – undo
131 131
 		if ( isset( $_REQUEST['import'] )) {
132 132
 			if( isset( $_POST['csv_submitted'] )) {
133 133
 
134
-			    switch ( $_FILES['file']['error'][0] ) {
135
-			        case UPLOAD_ERR_OK:
136
-			            $error_msg = FALSE;
137
-			            break;
138
-			        case UPLOAD_ERR_INI_SIZE:
139
-			            $error_msg = __("'The uploaded file exceeds the upload_max_filesize directive in php.ini.'", "event_espresso");
140
-			            break;
141
-			        case UPLOAD_ERR_FORM_SIZE:
142
-			            $error_msg = __('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.', "event_espresso");
143
-			            break;
144
-			        case UPLOAD_ERR_PARTIAL:
145
-			            $error_msg = __('The uploaded file was only partially uploaded.', "event_espresso");
146
-			            break;
147
-			        case UPLOAD_ERR_NO_FILE:
148
-			            $error_msg = __('No file was uploaded.', "event_espresso");
149
-			            break;
150
-			        case UPLOAD_ERR_NO_TMP_DIR:
151
-			            $error_msg = __('Missing a temporary folder.', "event_espresso");
152
-			            break;
153
-			        case UPLOAD_ERR_CANT_WRITE:
154
-			            $error_msg = __('Failed to write file to disk.', "event_espresso");
155
-			            break;
156
-			        case UPLOAD_ERR_EXTENSION:
157
-			            $error_msg = __('File upload stopped by extension.', "event_espresso");
158
-			            break;
159
-			        default:
160
-			            $error_msg = __('An unknown error occurred and the file could not be uploaded', "event_espresso");
161
-			            break;
162
-			    }
134
+				switch ( $_FILES['file']['error'][0] ) {
135
+					case UPLOAD_ERR_OK:
136
+						$error_msg = FALSE;
137
+						break;
138
+					case UPLOAD_ERR_INI_SIZE:
139
+						$error_msg = __("'The uploaded file exceeds the upload_max_filesize directive in php.ini.'", "event_espresso");
140
+						break;
141
+					case UPLOAD_ERR_FORM_SIZE:
142
+						$error_msg = __('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.', "event_espresso");
143
+						break;
144
+					case UPLOAD_ERR_PARTIAL:
145
+						$error_msg = __('The uploaded file was only partially uploaded.', "event_espresso");
146
+						break;
147
+					case UPLOAD_ERR_NO_FILE:
148
+						$error_msg = __('No file was uploaded.', "event_espresso");
149
+						break;
150
+					case UPLOAD_ERR_NO_TMP_DIR:
151
+						$error_msg = __('Missing a temporary folder.', "event_espresso");
152
+						break;
153
+					case UPLOAD_ERR_CANT_WRITE:
154
+						$error_msg = __('Failed to write file to disk.', "event_espresso");
155
+						break;
156
+					case UPLOAD_ERR_EXTENSION:
157
+						$error_msg = __('File upload stopped by extension.', "event_espresso");
158
+						break;
159
+					default:
160
+						$error_msg = __('An unknown error occurred and the file could not be uploaded', "event_espresso");
161
+						break;
162
+				}
163 163
 
164 164
 				if ( ! $error_msg ) {
165 165
 
166
-				    $filename	= $_FILES['file']['name'][0];
166
+					$filename	= $_FILES['file']['name'][0];
167 167
 					$file_ext 		= substr( strrchr( $filename, '.' ), 1 );
168
-				    $file_type 	= $_FILES['file']['type'][0];
169
-				    $temp_file	= $_FILES['file']['tmp_name'][0];
170
-				    $filesize    	= $_FILES['file']['size'][0] / 1024;//convert from bytes to KB
168
+					$file_type 	= $_FILES['file']['type'][0];
169
+					$temp_file	= $_FILES['file']['tmp_name'][0];
170
+					$filesize    	= $_FILES['file']['size'][0] / 1024;//convert from bytes to KB
171 171
 
172 172
 					if ( $file_ext=='csv' ) {
173 173
 
@@ -242,40 +242,40 @@  discard block
 block discarded – undo
242 242
 
243 243
 
244 244
 
245
-     /**
246
-      *    Given an array of data (usually from a CSV import) attempts to save that data to the db.
247
-      *    If $model_name ISN'T provided, assumes that this is a 3d array, with toplevel keys being model names,
248
-      *    next level being numeric indexes adn each value representing a model object, and the last layer down
249
-      *    being keys of model fields and their proposed values.
250
-      *    If $model_name IS provided, assumes a 2d array of the bottom two layers previously mentioned.
251
-      *    If the CSV data says (in the metadata row) that it's from the SAME database,
252
-      *    we treat the IDs in the CSV as the normal IDs, and try to update those records. However, if those
253
-      *    IDs DON'T exist in the database, they're treated as temporary IDs,
254
-      *    which can used elsewhere to refer to the same object. Once an item
255
-      *    with a temporary ID gets inserted, we record its mapping from temporary
256
-      *    ID to real ID, and use the real ID in place of the temporary ID
257
-      *    when that temporary ID was used as a foreign key.
258
-      *    If the CSV data says (in the metadata again) that it's from a DIFFERENT database,
259
-      *    we treat all the IDs in the CSV as temporary ID- eg, if the CSV specifies an event with
260
-      *    ID 1, and the database already has an event with ID 1, we assume that's just a coincidence,
261
-      *    and insert a new event, and map it's temporary ID of 1 over to its new real ID.
262
-      *    An important exception are non-auto-increment primary keys. If one entry in the
263
-      *    CSV file has the same ID as one in the DB, we assume they are meant to be
264
-      *    the same item, and instead update the item in the DB with that same ID.
265
-      *    Also note, we remember the mappings permanently. So the 2nd, 3rd, and 10000th
266
-      *    time you import a CSV from a different site, we remember their mappings, and
267
-      * will try to update the item in the DB instead of inserting another item (eg
268
-      * if we previously imported an event with temporary ID 1, and then it got a
269
-      * real ID of 123, we remember that. So the next time we import an event with
270
-      * temporary ID, from the same site, we know that it's real ID is 123, and will
271
-      * update that event, instead of adding a new event).
272
-      *
273
-      * @access public
274
-      * @param array $csv_data_array - the array containing the csv data produced from EE_CSV::import_csv_to_model_data_array()
275
-      * @param array $fields_to_save - an array containing the csv column names as keys with the corresponding db table fields they will be saved to
276
-      * @return TRUE on success, FALSE on fail
277
-      * @throws \EE_Error
278
-      */
245
+	 /**
246
+	  *    Given an array of data (usually from a CSV import) attempts to save that data to the db.
247
+	  *    If $model_name ISN'T provided, assumes that this is a 3d array, with toplevel keys being model names,
248
+	  *    next level being numeric indexes adn each value representing a model object, and the last layer down
249
+	  *    being keys of model fields and their proposed values.
250
+	  *    If $model_name IS provided, assumes a 2d array of the bottom two layers previously mentioned.
251
+	  *    If the CSV data says (in the metadata row) that it's from the SAME database,
252
+	  *    we treat the IDs in the CSV as the normal IDs, and try to update those records. However, if those
253
+	  *    IDs DON'T exist in the database, they're treated as temporary IDs,
254
+	  *    which can used elsewhere to refer to the same object. Once an item
255
+	  *    with a temporary ID gets inserted, we record its mapping from temporary
256
+	  *    ID to real ID, and use the real ID in place of the temporary ID
257
+	  *    when that temporary ID was used as a foreign key.
258
+	  *    If the CSV data says (in the metadata again) that it's from a DIFFERENT database,
259
+	  *    we treat all the IDs in the CSV as temporary ID- eg, if the CSV specifies an event with
260
+	  *    ID 1, and the database already has an event with ID 1, we assume that's just a coincidence,
261
+	  *    and insert a new event, and map it's temporary ID of 1 over to its new real ID.
262
+	  *    An important exception are non-auto-increment primary keys. If one entry in the
263
+	  *    CSV file has the same ID as one in the DB, we assume they are meant to be
264
+	  *    the same item, and instead update the item in the DB with that same ID.
265
+	  *    Also note, we remember the mappings permanently. So the 2nd, 3rd, and 10000th
266
+	  *    time you import a CSV from a different site, we remember their mappings, and
267
+	  * will try to update the item in the DB instead of inserting another item (eg
268
+	  * if we previously imported an event with temporary ID 1, and then it got a
269
+	  * real ID of 123, we remember that. So the next time we import an event with
270
+	  * temporary ID, from the same site, we know that it's real ID is 123, and will
271
+	  * update that event, instead of adding a new event).
272
+	  *
273
+	  * @access public
274
+	  * @param array $csv_data_array - the array containing the csv data produced from EE_CSV::import_csv_to_model_data_array()
275
+	  * @param array $fields_to_save - an array containing the csv column names as keys with the corresponding db table fields they will be saved to
276
+	  * @return TRUE on success, FALSE on fail
277
+	  * @throws \EE_Error
278
+	  */
279 279
 	public function save_csv_data_array_to_db( $csv_data_array, $model_name = FALSE ) {
280 280
 
281 281
 
@@ -306,10 +306,10 @@  discard block
 block discarded – undo
306 306
 			unset($csv_data_array[EE_CSV::metadata_header]);
307 307
 		}
308 308
 		/**
309
-		* @var $old_db_to_new_db_mapping 2d array: toplevel keys being model names, bottom-level keys being the original key, and
310
-		* the value will be the newly-inserted ID.
311
-		* If we have already imported data from the same website via CSV, it shoudl be kept in this wp option
312
-		*/
309
+		 * @var $old_db_to_new_db_mapping 2d array: toplevel keys being model names, bottom-level keys being the original key, and
310
+		 * the value will be the newly-inserted ID.
311
+		 * If we have already imported data from the same website via CSV, it shoudl be kept in this wp option
312
+		 */
313 313
 	   $old_db_to_new_db_mapping = get_option('ee_id_mapping_from'.sanitize_title($old_site_url),array());
314 314
 	   if( $old_db_to_new_db_mapping){
315 315
 		   EE_Error::add_attention(sprintf(__("We noticed you have imported data via CSV from %s before. Because of this, IDs in your CSV have been mapped to their new IDs in %s", "event_espresso"),$old_site_url,site_url()));
Please login to merge, or discard this patch.
Spacing   +170 added lines, -170 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if (!defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
2
-do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
2
+do_action('AHEE_log', __FILE__, __FUNCTION__, '');
3 3
 /**
4 4
  * EE_Import class
5 5
  *
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	 */
57 57
 	public static function instance() {
58 58
 		// check if class object is instantiated
59
-		if ( self::$_instance === NULL  or ! is_object( self::$_instance ) or ! ( self::$_instance instanceof EE_Import )) {
59
+		if (self::$_instance === NULL or ! is_object(self::$_instance) or ! (self::$_instance instanceof EE_Import)) {
60 60
 			self::$_instance = new self();
61 61
 		}
62 62
 		return self::$_instance;
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * Resets the importer
67 67
 	 * @return EE_Import
68 68
 	 */
69
-	public static function reset(){
69
+	public static function reset() {
70 70
 		self::$_instance = null;
71 71
 		return self::instance();
72 72
 	}
@@ -84,27 +84,27 @@  discard block
 block discarded – undo
84 84
 	 * 	@param 	string 		$type - type of file to import
85 85
 	 *	@ return 	string
86 86
 	 */
87
-	public function upload_form ( $title, $intro, $form_url, $action, $type  ) {
87
+	public function upload_form($title, $intro, $form_url, $action, $type) {
88 88
 
89
-		$form_url = EE_Admin_Page::add_query_args_and_nonce( array( 'action' => $action ), $form_url );
89
+		$form_url = EE_Admin_Page::add_query_args_and_nonce(array('action' => $action), $form_url);
90 90
 
91 91
 		ob_start();
92 92
 ?>
93 93
 	<div class="ee-upload-form-dv">
94
-		<h3><?php echo $title;?></h3>
95
-		<p><?php echo $intro;?></p>
94
+		<h3><?php echo $title; ?></h3>
95
+		<p><?php echo $intro; ?></p>
96 96
 
97 97
 		<form action="<?php echo $form_url?>" method="post" enctype="multipart/form-data">
98
-			<input type="hidden" name="csv_submitted" value="TRUE" id="<?php echo time();?>">
99
-			<input name="import" type="hidden" value="<?php echo $type;?>" />
98
+			<input type="hidden" name="csv_submitted" value="TRUE" id="<?php echo time(); ?>">
99
+			<input name="import" type="hidden" value="<?php echo $type; ?>" />
100 100
 			<input type="file" name="file[]" size="90" >
101
-			<input class="button-primary" type="submit" value="<?php _e( 'Upload File', 'event_espresso' );?>">
101
+			<input class="button-primary" type="submit" value="<?php _e('Upload File', 'event_espresso'); ?>">
102 102
 		</form>
103 103
 
104 104
 		<p class="ee-attention">
105
-			<b><?php _e( 'Attention', 'event_espresso' );?></b><br/>
106
-			<?php echo sprintf( __( 'Accepts .%s file types only.', 'event_espresso' ), $type ) ;?>
107
-			<?php echo __( 'Please only import CSV files exported from Event Espresso, or compatible 3rd-party software.', 'event_espresso' );?>
105
+			<b><?php _e('Attention', 'event_espresso'); ?></b><br/>
106
+			<?php echo sprintf(__('Accepts .%s file types only.', 'event_espresso'), $type); ?>
107
+			<?php echo __('Please only import CSV files exported from Event Espresso, or compatible 3rd-party software.', 'event_espresso'); ?>
108 108
 		</p>
109 109
 
110 110
 	</div>
@@ -125,13 +125,13 @@  discard block
 block discarded – undo
125 125
 	 */
126 126
 	public function import() {
127 127
 
128
-		require_once( EE_CLASSES . 'EE_CSV.class.php' );
128
+		require_once(EE_CLASSES.'EE_CSV.class.php');
129 129
 		$this->EE_CSV = EE_CSV::instance();
130 130
 
131
-		if ( isset( $_REQUEST['import'] )) {
132
-			if( isset( $_POST['csv_submitted'] )) {
131
+		if (isset($_REQUEST['import'])) {
132
+			if (isset($_POST['csv_submitted'])) {
133 133
 
134
-			    switch ( $_FILES['file']['error'][0] ) {
134
+			    switch ($_FILES['file']['error'][0]) {
135 135
 			        case UPLOAD_ERR_OK:
136 136
 			            $error_msg = FALSE;
137 137
 			            break;
@@ -161,32 +161,32 @@  discard block
 block discarded – undo
161 161
 			            break;
162 162
 			    }
163 163
 
164
-				if ( ! $error_msg ) {
164
+				if ( ! $error_msg) {
165 165
 
166
-				    $filename	= $_FILES['file']['name'][0];
167
-					$file_ext 		= substr( strrchr( $filename, '.' ), 1 );
168
-				    $file_type 	= $_FILES['file']['type'][0];
169
-				    $temp_file	= $_FILES['file']['tmp_name'][0];
170
-				    $filesize    	= $_FILES['file']['size'][0] / 1024;//convert from bytes to KB
166
+				    $filename = $_FILES['file']['name'][0];
167
+					$file_ext = substr(strrchr($filename, '.'), 1);
168
+				    $file_type = $_FILES['file']['type'][0];
169
+				    $temp_file = $_FILES['file']['tmp_name'][0];
170
+				    $filesize = $_FILES['file']['size'][0] / 1024; //convert from bytes to KB
171 171
 
172
-					if ( $file_ext=='csv' ) {
172
+					if ($file_ext == 'csv') {
173 173
 
174
-						$max_upload = $this->EE_CSV->get_max_upload_size();//max upload size in KB
175
-						if ( $filesize < $max_upload || true) {
174
+						$max_upload = $this->EE_CSV->get_max_upload_size(); //max upload size in KB
175
+						if ($filesize < $max_upload || true) {
176 176
 
177
-							$wp_upload_dir = str_replace( array( '\\', '/' ), DS, wp_upload_dir());
178
-							$path_to_file = $wp_upload_dir['basedir'] . DS . 'espresso' . DS . $filename;
177
+							$wp_upload_dir = str_replace(array('\\', '/'), DS, wp_upload_dir());
178
+							$path_to_file = $wp_upload_dir['basedir'].DS.'espresso'.DS.$filename;
179 179
 
180
-							if( move_uploaded_file( $temp_file, $path_to_file )) {
180
+							if (move_uploaded_file($temp_file, $path_to_file)) {
181 181
 
182 182
 								// convert csv to array
183
-								$this->csv_array = $this->EE_CSV->import_csv_to_model_data_array( $path_to_file );
183
+								$this->csv_array = $this->EE_CSV->import_csv_to_model_data_array($path_to_file);
184 184
 
185 185
 								// was data successfully stored in an array?
186
-								if ( is_array( $this->csv_array ) ) {
186
+								if (is_array($this->csv_array)) {
187 187
 
188
-									$import_what = str_replace( 'csv_import_', '', $_REQUEST['action'] );
189
-									$import_what = str_replace( '_', ' ', ucwords( $import_what ));
188
+									$import_what = str_replace('csv_import_', '', $_REQUEST['action']);
189
+									$import_what = str_replace('_', ' ', ucwords($import_what));
190 190
 									$processed_data = $this->csv_array;
191 191
 									$this->columns_to_save = FALSE;
192 192
 
@@ -205,33 +205,33 @@  discard block
 block discarded – undo
205 205
 
206 206
 									}
207 207
 									// save processed codes to db
208
-									if ( $this->save_csv_data_array_to_db( $processed_data, $this->columns_to_save ) ) {
208
+									if ($this->save_csv_data_array_to_db($processed_data, $this->columns_to_save)) {
209 209
 										return TRUE;
210 210
 
211 211
 									}
212 212
 								} else {
213 213
 									// no array? must be an error
214
-									EE_Error::add_error(sprintf(__("No file seems to have been uploaded", "event_espresso")), __FILE__, __FUNCTION__, __LINE__ );
214
+									EE_Error::add_error(sprintf(__("No file seems to have been uploaded", "event_espresso")), __FILE__, __FUNCTION__, __LINE__);
215 215
 									return FALSE;
216 216
 								}
217 217
 
218 218
 							} else {
219
-								EE_Error::add_error(sprintf(__("%s was not successfully uploaded", "event_espresso"),$filename), __FILE__, __FUNCTION__, __LINE__ );
219
+								EE_Error::add_error(sprintf(__("%s was not successfully uploaded", "event_espresso"), $filename), __FILE__, __FUNCTION__, __LINE__);
220 220
 								return FALSE;
221 221
 							}
222 222
 
223 223
 						} else {
224
-							EE_Error::add_error( sprintf(__("%s was too large of a file and could not be uploaded. The max filesize is %s' KB.", "event_espresso"),$filename,$max_upload), __FILE__, __FUNCTION__, __LINE__ );
224
+							EE_Error::add_error(sprintf(__("%s was too large of a file and could not be uploaded. The max filesize is %s' KB.", "event_espresso"), $filename, $max_upload), __FILE__, __FUNCTION__, __LINE__);
225 225
 							return FALSE;
226 226
 						}
227 227
 
228 228
 					} else {
229
-						EE_Error::add_error( sprintf(__("%s  had an invalid file extension, not uploaded", "event_espresso"),$filename), __FILE__, __FUNCTION__, __LINE__ );
229
+						EE_Error::add_error(sprintf(__("%s  had an invalid file extension, not uploaded", "event_espresso"), $filename), __FILE__, __FUNCTION__, __LINE__);
230 230
 						return FALSE;
231 231
 					}
232 232
 
233 233
 				} else {
234
-					EE_Error::add_error( $error_msg, __FILE__, __FUNCTION__, __LINE__ );
234
+					EE_Error::add_error($error_msg, __FILE__, __FUNCTION__, __LINE__);
235 235
 					return FALSE;
236 236
 				}
237 237
 
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
       * @return TRUE on success, FALSE on fail
277 277
       * @throws \EE_Error
278 278
       */
279
-	public function save_csv_data_array_to_db( $csv_data_array, $model_name = FALSE ) {
279
+	public function save_csv_data_array_to_db($csv_data_array, $model_name = FALSE) {
280 280
 
281 281
 
282 282
 		$success = FALSE;
@@ -286,22 +286,22 @@  discard block
 block discarded – undo
286 286
 		$export_from_site_a_to_b = true;
287 287
 		// first level of array is not table information but a table name was passed to the function
288 288
 		// array is only two levels deep, so let's fix that by adding a level, else the next steps will fail
289
-		if($model_name){
289
+		if ($model_name) {
290 290
 			$csv_data_array = array($csv_data_array);
291 291
 		}
292 292
 		// begin looking through the $csv_data_array, expecting the toplevel key to be the model's name...
293 293
 		$old_site_url = 'none-specified';
294 294
 
295 295
 		//hanlde metadata
296
-		if(isset($csv_data_array[EE_CSV::metadata_header]) ){
296
+		if (isset($csv_data_array[EE_CSV::metadata_header])) {
297 297
 			$csv_metadata = array_shift($csv_data_array[EE_CSV::metadata_header]);
298 298
 			//ok so its metadata, dont try to save it to ehte db obviously...
299
-			if(isset($csv_metadata['site_url']) && $csv_metadata['site_url'] == site_url()){
299
+			if (isset($csv_metadata['site_url']) && $csv_metadata['site_url'] == site_url()) {
300 300
 				EE_Error::add_attention(sprintf(__("CSV Data appears to be from the same database, so attempting to update data", "event_espresso")));
301 301
 				$export_from_site_a_to_b = false;
302
-			}else{
303
-				$old_site_url = isset( $csv_metadata['site_url']) ? $csv_metadata['site_url'] : $old_site_url;
304
-				EE_Error::add_attention(sprintf(__("CSV Data appears to be from a different database (%s instead of %s), so we assume IDs in the CSV data DO NOT correspond to IDs in this database", "event_espresso"),$old_site_url,site_url()));
302
+			} else {
303
+				$old_site_url = isset($csv_metadata['site_url']) ? $csv_metadata['site_url'] : $old_site_url;
304
+				EE_Error::add_attention(sprintf(__("CSV Data appears to be from a different database (%s instead of %s), so we assume IDs in the CSV data DO NOT correspond to IDs in this database", "event_espresso"), $old_site_url, site_url()));
305 305
 			};
306 306
 			unset($csv_data_array[EE_CSV::metadata_header]);
307 307
 		}
@@ -310,30 +310,30 @@  discard block
 block discarded – undo
310 310
 		* the value will be the newly-inserted ID.
311 311
 		* If we have already imported data from the same website via CSV, it shoudl be kept in this wp option
312 312
 		*/
313
-	   $old_db_to_new_db_mapping = get_option('ee_id_mapping_from'.sanitize_title($old_site_url),array());
314
-	   if( $old_db_to_new_db_mapping){
315
-		   EE_Error::add_attention(sprintf(__("We noticed you have imported data via CSV from %s before. Because of this, IDs in your CSV have been mapped to their new IDs in %s", "event_espresso"),$old_site_url,site_url()));
313
+	   $old_db_to_new_db_mapping = get_option('ee_id_mapping_from'.sanitize_title($old_site_url), array());
314
+	   if ($old_db_to_new_db_mapping) {
315
+		   EE_Error::add_attention(sprintf(__("We noticed you have imported data via CSV from %s before. Because of this, IDs in your CSV have been mapped to their new IDs in %s", "event_espresso"), $old_site_url, site_url()));
316 316
 	   }
317 317
 	   $old_db_to_new_db_mapping = $this->save_data_rows_to_db($csv_data_array, $export_from_site_a_to_b, $old_db_to_new_db_mapping);
318 318
 
319 319
 		//save the mapping from old db to new db in case they try re-importing the same data from the same website again
320
-		update_option('ee_id_mapping_from'.sanitize_title($old_site_url),$old_db_to_new_db_mapping);
320
+		update_option('ee_id_mapping_from'.sanitize_title($old_site_url), $old_db_to_new_db_mapping);
321 321
 
322
-		if ( $this->_total_updates > 0 ) {
323
-			EE_Error::add_success( sprintf(__("%s existing records in the database were updated.", "event_espresso"),$this->_total_updates));
322
+		if ($this->_total_updates > 0) {
323
+			EE_Error::add_success(sprintf(__("%s existing records in the database were updated.", "event_espresso"), $this->_total_updates));
324 324
 			$success = true;
325 325
 		}
326
-		if ( $this->_total_inserts > 0 ) {
327
-			EE_Error::add_success(sprintf(__("%s new records were added to the database.", "event_espresso"),$this->_total_inserts));
326
+		if ($this->_total_inserts > 0) {
327
+			EE_Error::add_success(sprintf(__("%s new records were added to the database.", "event_espresso"), $this->_total_inserts));
328 328
 			$success = true;
329 329
 		}
330 330
 
331
-		if ( $this->_total_update_errors > 0 ) {
332
-			EE_Error::add_error(sprintf(__("'One or more errors occurred, and a total of %s existing records in the database were <strong>not</strong> updated.'", "event_espresso"),$this->_total_update_errors), __FILE__, __FUNCTION__, __LINE__ );
331
+		if ($this->_total_update_errors > 0) {
332
+			EE_Error::add_error(sprintf(__("'One or more errors occurred, and a total of %s existing records in the database were <strong>not</strong> updated.'", "event_espresso"), $this->_total_update_errors), __FILE__, __FUNCTION__, __LINE__);
333 333
 			$error = true;
334 334
 		}
335
-		if ( $this->_total_insert_errors > 0 ) {
336
-			EE_Error::add_error(sprintf(__("One or more errors occurred, and a total of %s new records were <strong>not</strong> added to the database.'", "event_espresso"),$this->_total_insert_errors), __FILE__, __FUNCTION__, __LINE__ );
335
+		if ($this->_total_insert_errors > 0) {
336
+			EE_Error::add_error(sprintf(__("One or more errors occurred, and a total of %s new records were <strong>not</strong> added to the database.'", "event_espresso"), $this->_total_insert_errors), __FILE__, __FUNCTION__, __LINE__);
337 337
 			$error = true;
338 338
 		}
339 339
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 		EEM_Ticket::instance()->update_tickets_sold(EEM_Ticket::instance()->get_all());
343 343
 
344 344
 		// if there was at least one success and absolutely no errors
345
-		if ( $success && ! $error ) {
345
+		if ($success && ! $error) {
346 346
 			return TRUE;
347 347
 		} else {
348 348
 			return FALSE;
@@ -374,81 +374,81 @@  discard block
 block discarded – undo
374 374
 	 * @param type $old_db_to_new_db_mapping
375 375
 	 * @return array updated $old_db_to_new_db_mapping
376 376
 	 */
377
-	public function save_data_rows_to_db( $csv_data_array, $export_from_site_a_to_b, $old_db_to_new_db_mapping ) {
378
-		foreach ( $csv_data_array as $model_name_in_csv_data => $model_data_from_import ) {
377
+	public function save_data_rows_to_db($csv_data_array, $export_from_site_a_to_b, $old_db_to_new_db_mapping) {
378
+		foreach ($csv_data_array as $model_name_in_csv_data => $model_data_from_import) {
379 379
 			//now check that assumption was correct. If
380
-			if ( EE_Registry::instance()->is_model_name($model_name_in_csv_data)) {
380
+			if (EE_Registry::instance()->is_model_name($model_name_in_csv_data)) {
381 381
 				$model_name = $model_name_in_csv_data;
382
-			}else {
382
+			} else {
383 383
 				// no table info in the array and no table name passed to the function?? FAIL
384
-				EE_Error::add_error( __('No table information was specified and/or found, therefore the import could not be completed','event_espresso'), __FILE__, __FUNCTION__, __LINE__ );
384
+				EE_Error::add_error(__('No table information was specified and/or found, therefore the import could not be completed', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__);
385 385
 				return FALSE;
386 386
 			}
387 387
 			/* @var $model EEM_Base */
388 388
 			$model = EE_Registry::instance()->load_model($model_name);
389 389
 
390 390
 			//so without further ado, scanning all the data provided for primary keys and their inital values
391
-			foreach ( $model_data_from_import as $model_object_data ) {
391
+			foreach ($model_data_from_import as $model_object_data) {
392 392
 				//before we do ANYTHING, make sure the csv row wasn't just completely blank
393 393
 				$row_is_completely_empty = true;
394
-				foreach($model_object_data as $field){
395
-					if($field){
394
+				foreach ($model_object_data as $field) {
395
+					if ($field) {
396 396
 						$row_is_completely_empty = false;
397 397
 					}
398 398
 				}
399
-				if($row_is_completely_empty){
399
+				if ($row_is_completely_empty) {
400 400
 					continue;
401 401
 				}
402 402
 				//find the PK in the row of data (or a combined key if
403 403
 				//there is no primary key)
404
-				if($model->has_primary_key_field()){
405
-					$id_in_csv =  $model_object_data[$model->primary_key_name()];
406
-				}else{
404
+				if ($model->has_primary_key_field()) {
405
+					$id_in_csv = $model_object_data[$model->primary_key_name()];
406
+				} else {
407 407
 					$id_in_csv = $model->get_index_primary_key_string($model_object_data);
408 408
 				}
409 409
 
410 410
 
411
-				$model_object_data = $this->_replace_temp_ids_with_mappings( $model_object_data, $model, $old_db_to_new_db_mapping, $export_from_site_a_to_b );
411
+				$model_object_data = $this->_replace_temp_ids_with_mappings($model_object_data, $model, $old_db_to_new_db_mapping, $export_from_site_a_to_b);
412 412
 				//now we need to decide if we're going to add a new model object given the $model_object_data,
413 413
 				//or just update.
414
-				if($export_from_site_a_to_b){
415
-					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_other_db( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
416
-				}else{//this is just a re-import
417
-					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_same_db( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
414
+				if ($export_from_site_a_to_b) {
415
+					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_other_db($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping);
416
+				} else {//this is just a re-import
417
+					$what_to_do = $this->_decide_whether_to_insert_or_update_given_data_from_same_db($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping);
418 418
 				}
419
-				if( $what_to_do == self::do_nothing ) {
419
+				if ($what_to_do == self::do_nothing) {
420 420
 					continue;
421 421
 				}
422 422
 
423 423
 				//double-check we actually want to insert, if that's what we're planning
424 424
 				//based on whether this item would be unique in the DB or not
425
-				if( $what_to_do == self::do_insert ) {
425
+				if ($what_to_do == self::do_insert) {
426 426
 					//we're supposed to be inserting. But wait, will this thing
427 427
 					//be acceptable if inserted?
428
-					$conflicting = $model->get_one_conflicting( $model_object_data, false );
429
-					if($conflicting){
428
+					$conflicting = $model->get_one_conflicting($model_object_data, false);
429
+					if ($conflicting) {
430 430
 						//ok, this item would conflict if inserted. Just update the item that it conflicts with.
431 431
 						$what_to_do = self::do_update;
432 432
 						//and if this model has a primary key, remember its mapping
433
-						if($model->has_primary_key_field()){
433
+						if ($model->has_primary_key_field()) {
434 434
 							$old_db_to_new_db_mapping[$model_name][$id_in_csv] = $conflicting->ID();
435 435
 							$model_object_data[$model->primary_key_name()] = $conflicting->ID();
436
-						}else{
436
+						} else {
437 437
 							//we want to update this conflicting item, instead of inserting a conflicting item
438 438
 							//so we need to make sure they match entirely (its possible that they only conflicted on one field, but we need them to match on other fields
439 439
 							//for the WHERE conditions in the update). At the time of this comment, there were no models like this
440
-							foreach($model->get_combined_primary_key_fields() as $key_field){
440
+							foreach ($model->get_combined_primary_key_fields() as $key_field) {
441 441
 								$model_object_data[$key_field->get_name()] = $conflicting->get($key_field->get_name());
442 442
 							}
443 443
 						}
444 444
 					}
445 445
 				}
446
-				if( $what_to_do == self::do_insert ) {
447
-					$old_db_to_new_db_mapping = $this->_insert_from_data_array( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
448
-				}elseif( $what_to_do == self::do_update ) {
449
-					$old_db_to_new_db_mapping = $this->_update_from_data_array( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping );
450
-				}else{
451
-					throw new EE_Error( sprintf( __( 'Programming error. We shoudl be inserting or updating, but instead we are being told to "%s", whifh is invalid', 'event_espresso' ), $what_to_do ) );
446
+				if ($what_to_do == self::do_insert) {
447
+					$old_db_to_new_db_mapping = $this->_insert_from_data_array($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping);
448
+				}elseif ($what_to_do == self::do_update) {
449
+					$old_db_to_new_db_mapping = $this->_update_from_data_array($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping);
450
+				} else {
451
+					throw new EE_Error(sprintf(__('Programming error. We shoudl be inserting or updating, but instead we are being told to "%s", whifh is invalid', 'event_espresso'), $what_to_do));
452 452
 				}
453 453
 			}
454 454
 		}
@@ -469,13 +469,13 @@  discard block
 block discarded – undo
469 469
 	 * @param array $old_db_to_new_db_mapping by reference so it can be modified
470 470
 	 * @return string one of the consts on this class that starts with do_*
471 471
 	 */
472
-	protected function _decide_whether_to_insert_or_update_given_data_from_other_db( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping ) {
472
+	protected function _decide_whether_to_insert_or_update_given_data_from_other_db($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping) {
473 473
 		$model_name = $model->get_this_model_name();
474 474
 		//if it's a site-to-site export-and-import, see if this modelobject's id
475 475
 		//in the old data that we know of
476
-		if( isset($old_db_to_new_db_mapping[$model_name][$id_in_csv]) ){
476
+		if (isset($old_db_to_new_db_mapping[$model_name][$id_in_csv])) {
477 477
 			return self::do_update;
478
-		}else{
478
+		} else {
479 479
 			return self::do_insert;
480 480
 		}
481 481
 	}
@@ -490,11 +490,11 @@  discard block
 block discarded – undo
490 490
 	 * @param type $old_db_to_new_db_mapping
491 491
 	 * @return
492 492
 	 */
493
-	protected function _decide_whether_to_insert_or_update_given_data_from_same_db( $id_in_csv, $model_object_data, $model ) {
493
+	protected function _decide_whether_to_insert_or_update_given_data_from_same_db($id_in_csv, $model_object_data, $model) {
494 494
 		//in this case, check if this thing ACTUALLY exists in the database
495
-		if( $model->get_one_conflicting( $model_object_data ) ){
495
+		if ($model->get_one_conflicting($model_object_data)) {
496 496
 			return self::do_update;
497
-		}else{
497
+		} else {
498 498
 			return self::do_insert;
499 499
 		}
500 500
 	}
@@ -513,55 +513,55 @@  discard block
 block discarded – undo
513 513
 	 * @param boolean $export_from_site_a_to_b
514 514
 	 * @return array updated model object data with temp IDs removed
515 515
 	 */
516
-	protected function _replace_temp_ids_with_mappings( $model_object_data, $model, $old_db_to_new_db_mapping, $export_from_site_a_to_b ) {
516
+	protected function _replace_temp_ids_with_mappings($model_object_data, $model, $old_db_to_new_db_mapping, $export_from_site_a_to_b) {
517 517
 		//if this model object's primary key is in the mapping, replace it
518
-		if( $model->has_primary_key_field() &&
518
+		if ($model->has_primary_key_field() &&
519 519
 				$model->get_primary_key_field()->is_auto_increment() &&
520
-				isset( $old_db_to_new_db_mapping[ $model->get_this_model_name() ] ) &&
521
-				isset( $old_db_to_new_db_mapping[ $model->get_this_model_name() ][ $model_object_data[ $model->primary_key_name() ] ] ) ) {
522
-			$model_object_data[ $model->primary_key_name() ] = $old_db_to_new_db_mapping[ $model->get_this_model_name() ][ $model_object_data[ $model->primary_key_name() ] ];
520
+				isset($old_db_to_new_db_mapping[$model->get_this_model_name()]) &&
521
+				isset($old_db_to_new_db_mapping[$model->get_this_model_name()][$model_object_data[$model->primary_key_name()]])) {
522
+			$model_object_data[$model->primary_key_name()] = $old_db_to_new_db_mapping[$model->get_this_model_name()][$model_object_data[$model->primary_key_name()]];
523 523
 		}
524 524
 
525
-		try{
525
+		try {
526 526
 			$model_name_field = $model->get_field_containing_related_model_name();
527 527
 			$models_pointed_to_by_model_name_field = $model_name_field->get_model_names_pointed_to();
528
-		}catch( EE_Error $e ){
528
+		} catch (EE_Error $e) {
529 529
 			$model_name_field = NULL;
530 530
 			$models_pointed_to_by_model_name_field = array();
531 531
 		}
532
-		foreach( $model->field_settings( true )  as $field_obj ){
533
-			if( $field_obj instanceof EE_Foreign_Key_Int_Field ) {
532
+		foreach ($model->field_settings(true)  as $field_obj) {
533
+			if ($field_obj instanceof EE_Foreign_Key_Int_Field) {
534 534
 				$models_pointed_to = $field_obj->get_model_names_pointed_to();
535 535
 				$found_a_mapping = false;
536
-				foreach( $models_pointed_to as $model_pointed_to_by_fk ) {
536
+				foreach ($models_pointed_to as $model_pointed_to_by_fk) {
537 537
 
538
-					if( $model_name_field ){
539
-						$value_of_model_name_field = $model_object_data[ $model_name_field->get_name() ];
540
-						if( $value_of_model_name_field == $model_pointed_to_by_fk ) {
541
-							$model_object_data[ $field_obj->get_name() ] = $this->_find_mapping_in(
542
-									$model_object_data[ $field_obj->get_name() ],
538
+					if ($model_name_field) {
539
+						$value_of_model_name_field = $model_object_data[$model_name_field->get_name()];
540
+						if ($value_of_model_name_field == $model_pointed_to_by_fk) {
541
+							$model_object_data[$field_obj->get_name()] = $this->_find_mapping_in(
542
+									$model_object_data[$field_obj->get_name()],
543 543
 									$model_pointed_to_by_fk,
544 544
 									$old_db_to_new_db_mapping,
545 545
 									$export_from_site_a_to_b );
546 546
 								$found_a_mapping = true;
547 547
 								break;
548 548
 						}
549
-					}else{
550
-						$model_object_data[ $field_obj->get_name() ] = $this->_find_mapping_in(
551
-								$model_object_data[ $field_obj->get_name() ],
549
+					} else {
550
+						$model_object_data[$field_obj->get_name()] = $this->_find_mapping_in(
551
+								$model_object_data[$field_obj->get_name()],
552 552
 								$model_pointed_to_by_fk,
553 553
 								$old_db_to_new_db_mapping,
554 554
 								$export_from_site_a_to_b );
555 555
 						$found_a_mapping = true;
556 556
 					}
557 557
 					//once we've found a mapping for this field no need to continue
558
-					if( $found_a_mapping ) {
558
+					if ($found_a_mapping) {
559 559
 						break;
560 560
 					}
561 561
 
562 562
 
563 563
 				}
564
-			}else{
564
+			} else {
565 565
 				//it's a string foreign key (which we leave alone, because those are things
566 566
 				//like country names, which we'd really rather not make 2 USAs etc (we'd actually
567 567
 				//prefer to just update one)
@@ -569,8 +569,8 @@  discard block
 block discarded – undo
569 569
 			}
570 570
 		}
571 571
 		//
572
-		if( $model instanceof EEM_Term_Taxonomy ){
573
-			$model_object_data = $this->_handle_split_term_ids( $model_object_data );
572
+		if ($model instanceof EEM_Term_Taxonomy) {
573
+			$model_object_data = $this->_handle_split_term_ids($model_object_data);
574 574
 		}
575 575
 		return $model_object_data;
576 576
 	}
@@ -582,11 +582,11 @@  discard block
 block discarded – undo
582 582
 	 * @param type $model_object_data
583 583
 	 * @return array new model object data
584 584
 	 */
585
-	protected function _handle_split_term_ids( $model_object_data ){
586
-		if( isset( $model_object_data['term_id'] ) && isset( $model_object_data[ 'taxonomy' ]) && apply_filters( 'FHEE__EE_Import__handle_split_term_ids__function_exists', function_exists( 'wp_get_split_term' ), $model_object_data ) ) {
587
-			$new_term_id = wp_get_split_term( $model_object_data[ 'term_id' ], $model_object_data[ 'taxonomy' ] );
588
-			if( $new_term_id ){
589
-				$model_object_data[ 'term_id' ] = $new_term_id;
585
+	protected function _handle_split_term_ids($model_object_data) {
586
+		if (isset($model_object_data['term_id']) && isset($model_object_data['taxonomy']) && apply_filters('FHEE__EE_Import__handle_split_term_ids__function_exists', function_exists('wp_get_split_term'), $model_object_data)) {
587
+			$new_term_id = wp_get_split_term($model_object_data['term_id'], $model_object_data['taxonomy']);
588
+			if ($new_term_id) {
589
+				$model_object_data['term_id'] = $new_term_id;
590 590
 			}
591 591
 		}
592 592
 		return $model_object_data;
@@ -600,18 +600,18 @@  discard block
 block discarded – undo
600 600
 	 * @param type $export_from_site_a_to_b
601 601
 	 * @return int
602 602
 	 */
603
-	protected function _find_mapping_in( $object_id, $model_name, $old_db_to_new_db_mapping, $export_from_site_a_to_b) {
604
-		if(	isset( $old_db_to_new_db_mapping[ $model_name ][ $object_id ] ) ){
603
+	protected function _find_mapping_in($object_id, $model_name, $old_db_to_new_db_mapping, $export_from_site_a_to_b) {
604
+		if (isset($old_db_to_new_db_mapping[$model_name][$object_id])) {
605 605
 
606
-				return $old_db_to_new_db_mapping[ $model_name ][ $object_id ];
607
-			}elseif( $object_id == '0' || $object_id == '' ) {
606
+				return $old_db_to_new_db_mapping[$model_name][$object_id];
607
+			}elseif ($object_id == '0' || $object_id == '') {
608 608
 				//leave as-is
609 609
 				return $object_id;
610
-			}elseif( $export_from_site_a_to_b ){
610
+			}elseif ($export_from_site_a_to_b) {
611 611
 				//we couldn't find a mapping for this, and it's from a different site,
612 612
 				//so blank it out
613 613
 				return NULL;
614
-			}elseif( ! $export_from_site_a_to_b ) {
614
+			}elseif ( ! $export_from_site_a_to_b) {
615 615
 				//we coudln't find a mapping for this, but it's from thsi DB anyway
616 616
 				//so let's just leave it as-is
617 617
 				return $object_id;
@@ -626,36 +626,36 @@  discard block
 block discarded – undo
626 626
 	 * @param type $old_db_to_new_db_mapping
627 627
 	 * @return array updated $old_db_to_new_db_mapping
628 628
 	 */
629
-	protected function _insert_from_data_array( $id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping ) {
629
+	protected function _insert_from_data_array($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping) {
630 630
 		//remove the primary key, if there is one (we don't want it for inserts OR updates)
631 631
 		//we'll put it back in if we need it
632
-		if($model->has_primary_key_field() && $model->get_primary_key_field()->is_auto_increment()){
632
+		if ($model->has_primary_key_field() && $model->get_primary_key_field()->is_auto_increment()) {
633 633
 			$effective_id = $model_object_data[$model->primary_key_name()];
634 634
 			unset($model_object_data[$model->primary_key_name()]);
635
-		}else{
636
-			$effective_id = $model->get_index_primary_key_string( $model_object_data );
635
+		} else {
636
+			$effective_id = $model->get_index_primary_key_string($model_object_data);
637 637
 		}
638 638
 		//the model takes care of validating the CSV's input
639
-		try{
639
+		try {
640 640
 			$new_id = $model->insert($model_object_data);
641
-			if( $new_id ){
641
+			if ($new_id) {
642 642
 				$old_db_to_new_db_mapping[$model->get_this_model_name()][$id_in_csv] = $new_id;
643 643
 				$this->_total_inserts++;
644
-				EE_Error::add_success( sprintf(__("Successfully added new %s (with id %s) with csv data %s", "event_espresso"),$model->get_this_model_name(),$new_id, implode(",",$model_object_data)));
645
-			}else{
644
+				EE_Error::add_success(sprintf(__("Successfully added new %s (with id %s) with csv data %s", "event_espresso"), $model->get_this_model_name(), $new_id, implode(",", $model_object_data)));
645
+			} else {
646 646
 				$this->_total_insert_errors++;
647 647
 				//put the ID used back in there for the error message
648
-				if($model->has_primary_key_field()){
648
+				if ($model->has_primary_key_field()) {
649 649
 					$model_object_data[$model->primary_key_name()] = $effective_id;
650 650
 				}
651
-				EE_Error::add_error( sprintf(__("Could not insert new %s with the csv data: %s", "event_espresso"),$model->get_this_model_name(),http_build_query($model_object_data)), __FILE__, __FUNCTION__, __LINE__ );
651
+				EE_Error::add_error(sprintf(__("Could not insert new %s with the csv data: %s", "event_espresso"), $model->get_this_model_name(), http_build_query($model_object_data)), __FILE__, __FUNCTION__, __LINE__);
652 652
 			}
653
-		}catch(EE_Error $e){
653
+		} catch (EE_Error $e) {
654 654
 			$this->_total_insert_errors++;
655
-			if($model->has_primary_key_field()){
655
+			if ($model->has_primary_key_field()) {
656 656
 				$model_object_data[$model->primary_key_name()] = $effective_id;
657 657
 			}
658
-			EE_Error::add_error( sprintf(__("Could not insert new %s with the csv data: %s because %s", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data),$e->getMessage()), __FILE__, __FUNCTION__, __LINE__ );
658
+			EE_Error::add_error(sprintf(__("Could not insert new %s with the csv data: %s because %s", "event_espresso"), $model->get_this_model_name(), implode(",", $model_object_data), $e->getMessage()), __FILE__, __FUNCTION__, __LINE__);
659 659
 		}
660 660
 		return $old_db_to_new_db_mapping;
661 661
 	}
@@ -668,55 +668,55 @@  discard block
 block discarded – undo
668 668
 	 * @param array $old_db_to_new_db_mapping
669 669
 	 * @return array updated $old_db_to_new_db_mapping
670 670
 	 */
671
-	protected function _update_from_data_array( $id_in_csv,  $model_object_data, $model, $old_db_to_new_db_mapping ) {
672
-		try{
671
+	protected function _update_from_data_array($id_in_csv, $model_object_data, $model, $old_db_to_new_db_mapping) {
672
+		try {
673 673
 			//let's keep two copies of the model object data:
674 674
 			//one for performing an update, one for everthing else
675 675
 			$model_object_data_for_update = $model_object_data;
676
-			if($model->has_primary_key_field()){
676
+			if ($model->has_primary_key_field()) {
677 677
 				$conditions = array($model->primary_key_name() => $model_object_data[$model->primary_key_name()]);
678 678
 				//remove the primary key because we shouldn't use it for updating
679 679
 				unset($model_object_data_for_update[$model->primary_key_name()]);
680
-			}elseif($model->get_combined_primary_key_fields() > 1 ){
680
+			}elseif ($model->get_combined_primary_key_fields() > 1) {
681 681
 				$conditions = array();
682
-				foreach($model->get_combined_primary_key_fields() as $key_field){
682
+				foreach ($model->get_combined_primary_key_fields() as $key_field) {
683 683
 					$conditions[$key_field->get_name()] = $model_object_data[$key_field->get_name()];
684 684
 				}
685
-			}else{
686
-				$model->primary_key_name();//this shoudl just throw an exception, explaining that we dont have a primary key (or a combine dkey)
685
+			} else {
686
+				$model->primary_key_name(); //this shoudl just throw an exception, explaining that we dont have a primary key (or a combine dkey)
687 687
 			}
688 688
 
689
-			$success = $model->update($model_object_data_for_update,array($conditions));
690
-			if($success){
689
+			$success = $model->update($model_object_data_for_update, array($conditions));
690
+			if ($success) {
691 691
 				$this->_total_updates++;
692
-				EE_Error::add_success( sprintf(__("Successfully updated %s with csv data %s", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data_for_update)));
692
+				EE_Error::add_success(sprintf(__("Successfully updated %s with csv data %s", "event_espresso"), $model->get_this_model_name(), implode(",", $model_object_data_for_update)));
693 693
 				//we should still record the mapping even though it was an update
694 694
 				//because if we were going to insert somethign but it was going to conflict
695 695
 				//we would have last-minute decided to update. So we'd like to know what we updated
696 696
 				//and so we record what record ended up being updated using the mapping
697
-				if( $model->has_primary_key_field() ){
698
-					$new_key_for_mapping = $model_object_data[ $model->primary_key_name() ];
699
-				}else{
697
+				if ($model->has_primary_key_field()) {
698
+					$new_key_for_mapping = $model_object_data[$model->primary_key_name()];
699
+				} else {
700 700
 					//no primary key just a combined key
701
-					$new_key_for_mapping = $model->get_index_primary_key_string( $model_object_data );
701
+					$new_key_for_mapping = $model->get_index_primary_key_string($model_object_data);
702 702
 				}
703
-				$old_db_to_new_db_mapping[ $model->get_this_model_name() ][ $id_in_csv ] = $new_key_for_mapping;
704
-			}else{
703
+				$old_db_to_new_db_mapping[$model->get_this_model_name()][$id_in_csv] = $new_key_for_mapping;
704
+			} else {
705 705
 				$matched_items = $model->get_all(array($conditions));
706
-				if( ! $matched_items){
706
+				if ( ! $matched_items) {
707 707
 					//no items were matched (so we shouldn't have updated)... but then we should have inserted? what the heck?
708 708
 					$this->_total_update_errors++;
709
-					EE_Error::add_error( sprintf(__("Could not update %s with the csv data: '%s' for an unknown reason (using WHERE conditions %s)", "event_espresso"),$model->get_this_model_name(),http_build_query($model_object_data),http_build_query($conditions)), __FILE__, __FUNCTION__, __LINE__ );
710
-				}else{
709
+					EE_Error::add_error(sprintf(__("Could not update %s with the csv data: '%s' for an unknown reason (using WHERE conditions %s)", "event_espresso"), $model->get_this_model_name(), http_build_query($model_object_data), http_build_query($conditions)), __FILE__, __FUNCTION__, __LINE__);
710
+				} else {
711 711
 					$this->_total_updates++;
712
-					EE_Error::add_success( sprintf(__("%s with csv data '%s' was found in the database and didn't need updating because all the data is identical.", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data)));
712
+					EE_Error::add_success(sprintf(__("%s with csv data '%s' was found in the database and didn't need updating because all the data is identical.", "event_espresso"), $model->get_this_model_name(), implode(",", $model_object_data)));
713 713
 				}
714 714
 			}
715
-		}catch(EE_Error $e){
715
+		} catch (EE_Error $e) {
716 716
 			$this->_total_update_errors++;
717
-			$basic_message = sprintf(__("Could not update %s with the csv data: %s because %s", "event_espresso"),$model->get_this_model_name(),implode(",",$model_object_data),$e->getMessage());
718
-			$debug_message = $basic_message . ' Stack trace: ' . $e->getTraceAsString();
719
-			EE_Error::add_error( "$basic_message | $debug_message", __FILE__, __FUNCTION__, __LINE__ );
717
+			$basic_message = sprintf(__("Could not update %s with the csv data: %s because %s", "event_espresso"), $model->get_this_model_name(), implode(",", $model_object_data), $e->getMessage());
718
+			$debug_message = $basic_message.' Stack trace: '.$e->getTraceAsString();
719
+			EE_Error::add_error("$basic_message | $debug_message", __FILE__, __FUNCTION__, __LINE__);
720 720
 		}
721 721
 		return $old_db_to_new_db_mapping;
722 722
 	}
@@ -725,28 +725,28 @@  discard block
 block discarded – undo
725 725
 	 * Gets the number of inserts performed since importer was instantiated or reset
726 726
 	 * @return int
727 727
 	 */
728
-	public function get_total_inserts(){
728
+	public function get_total_inserts() {
729 729
 		return $this->_total_inserts;
730 730
 	}
731 731
 	/**
732 732
 	 *  Gets the number of insert errors since importer was instantiated or reset
733 733
 	 * @return int
734 734
 	 */
735
-	public function get_total_insert_errors(){
735
+	public function get_total_insert_errors() {
736 736
 		return $this->_total_insert_errors;
737 737
 	}
738 738
 	/**
739 739
 	 *  Gets the number of updates performed since importer was instantiated or reset
740 740
 	 * @return int
741 741
 	 */
742
-	public function get_total_updates(){
742
+	public function get_total_updates() {
743 743
 		return $this->_total_updates;
744 744
 	}
745 745
 	/**
746 746
 	 *  Gets the number of update errors since importer was instantiated or reset
747 747
 	 * @return int
748 748
 	 */
749
-	public function get_total_update_errors(){
749
+	public function get_total_update_errors() {
750 750
 		return $this->_total_update_errors;
751 751
 	}
752 752
 
Please login to merge, or discard this patch.
core/db_classes/EE_Message_Template.class.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -34,9 +34,9 @@  discard block
 block discarded – undo
34 34
 	 * @param string $timezone
35 35
 	 * @return EE_Message_Template|mixed
36 36
 	 */
37
-	public static function new_instance( $props_n_values = array(), $timezone = '' ) {
38
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__, $timezone );
39
-		return $has_object ? $has_object : new self( $props_n_values, FALSE, $timezone );
37
+	public static function new_instance($props_n_values = array(), $timezone = '') {
38
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__, $timezone);
39
+		return $has_object ? $has_object : new self($props_n_values, FALSE, $timezone);
40 40
 	}
41 41
 
42 42
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	 * @param string $timezone
47 47
 	 * @return EE_Message_Template
48 48
 	 */
49
-	public static function new_instance_from_db( $props_n_values = array(), $timezone = '' ) {
50
-		return new self( $props_n_values, TRUE, $timezone );
49
+	public static function new_instance_from_db($props_n_values = array(), $timezone = '') {
50
+		return new self($props_n_values, TRUE, $timezone);
51 51
 	}
52 52
 
53 53
 
@@ -56,11 +56,11 @@  discard block
 block discarded – undo
56 56
 	 * @param bool $GRP_ID
57 57
 	 * @throws EE_Error
58 58
 	 */
59
-	public function set_group_template_id( $GRP_ID = FALSE ) {
60
-		if ( ! $GRP_ID ) {
61
-			throw new EE_Error( __( 'Missing required value for the message template group id', 'event_espresso' ) );
59
+	public function set_group_template_id($GRP_ID = FALSE) {
60
+		if ( ! $GRP_ID) {
61
+			throw new EE_Error(__('Missing required value for the message template group id', 'event_espresso'));
62 62
 		}
63
-		$this->set( 'GRP_ID', $GRP_ID );
63
+		$this->set('GRP_ID', $GRP_ID);
64 64
 	}
65 65
 
66 66
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @return int
72 72
 	 */
73 73
 	public function GRP_ID() {
74
-		return $this->get( 'GRP_ID' );
74
+		return $this->get('GRP_ID');
75 75
 	}
76 76
 
77 77
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	 * @return int
83 83
 	 */
84 84
 	public function user() {
85
-		return $this->get_first_related( 'Message_Template_Group' )->get( 'MTP_user_id' );
85
+		return $this->get_first_related('Message_Template_Group')->get('MTP_user_id');
86 86
 	}
87 87
 
88 88
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 	 * @return string
94 94
 	 */
95 95
 	public function messenger() {
96
-		return $this->get_first_related( 'Message_Template_Group' )->messenger();
96
+		return $this->get_first_related('Message_Template_Group')->messenger();
97 97
 	}
98 98
 
99 99
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @return object Messenger Object for the given messenger
106 106
 	 */
107 107
 	public function messenger_obj() {
108
-		return $this->get_first_related( 'Message_Template_Group' )->messenger_obj();
108
+		return $this->get_first_related('Message_Template_Group')->messenger_obj();
109 109
 	}
110 110
 
111 111
 
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 	 * @return string
118 118
 	 */
119 119
 	public function message_type() {
120
-		return $this->get_first_related( 'Message_Template_Group' )->message_type();
120
+		return $this->get_first_related('Message_Template_Group')->message_type();
121 121
 	}
122 122
 
123 123
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	 * @return object  Message Type object for the given message type
130 130
 	 */
131 131
 	public function message_type_obj() {
132
-		return $this->get_first_related( 'Message_Template_Group' )->message_type_obj();
132
+		return $this->get_first_related('Message_Template_Group')->message_type_obj();
133 133
 	}
134 134
 
135 135
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 	 * @return array array of contexts and their configuration.
142 142
 	 */
143 143
 	public function contexts_config() {
144
-		return $this->get_first_related( 'Message_Template_Group' )->contexts_config();
144
+		return $this->get_first_related('Message_Template_Group')->contexts_config();
145 145
 	}
146 146
 
147 147
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 * @return string label for "context"
154 154
 	 */
155 155
 	public function context_label() {
156
-		return $this->get_first_related( 'Message_Template_Group' )->context_label();
156
+		return $this->get_first_related('Message_Template_Group')->context_label();
157 157
 	}
158 158
 
159 159
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 * @return boolean true if it is, false if it isn't
164 164
 	 */
165 165
 	public function is_global() {
166
-		return $this->get_first_related( 'Message_Template_Group' )->is_global();
166
+		return $this->get_first_related('Message_Template_Group')->is_global();
167 167
 	}
168 168
 
169 169
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 	 * @return boolean true if it is, false if it isn't
174 174
 	 */
175 175
 	public function is_active() {
176
-		return $this->get_first_related( 'Message_Template_Group' )->is_active();
176
+		return $this->get_first_related('Message_Template_Group')->is_active();
177 177
 	}
178 178
 
179 179
 
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 	 * @param array  $fields  what fields we're returning valid shortcodes for.  If empty then we assume all fields are to be merged and returned.
187 187
 	 * @return mixed (array|bool) an array of shortcodes in the format array( '[shortcode] => 'label') OR FALSE if no shortcodes found.
188 188
 	 */
189
-	public function get_shortcodes( $context, $fields = array() ) {
190
-		return $this->get_first_related( 'Message_Template_Group' )->get_shortcodes( $context, $fields );
189
+	public function get_shortcodes($context, $fields = array()) {
190
+		return $this->get_first_related('Message_Template_Group')->get_shortcodes($context, $fields);
191 191
 	}
192 192
 }
Please login to merge, or discard this patch.
core/db_classes/EE_Price_Type.class.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	 * @param array $props_n_values
33 33
 	 * @return EE_Price_Type
34 34
 	 */
35
-	public static function new_instance( $props_n_values = array() ) {
36
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
37
-		return $has_object ? $has_object : new self( $props_n_values );
35
+	public static function new_instance($props_n_values = array()) {
36
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
37
+		return $has_object ? $has_object : new self($props_n_values);
38 38
 	}
39 39
 
40 40
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 	 * @param array $props_n_values
44 44
 	 * @return EE_Price_Type
45 45
 	 */
46
-	public static function new_instance_from_db( $props_n_values = array() ) {
47
-		return new self( $props_n_values, TRUE );
46
+	public static function new_instance_from_db($props_n_values = array()) {
47
+		return new self($props_n_values, TRUE);
48 48
 	}
49 49
 
50 50
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 	 * @access        public
56 56
 	 * @param        string $PRT_name
57 57
 	 */
58
-	public function set_name( $PRT_name = '' ) {
59
-		$this->set( 'PRT_name', $PRT_name );
58
+	public function set_name($PRT_name = '') {
59
+		$this->set('PRT_name', $PRT_name);
60 60
 	}
61 61
 
62 62
 
@@ -67,8 +67,8 @@  discard block
 block discarded – undo
67 67
 	 * @access        public
68 68
 	 * @param        bool $PRT_is_percent
69 69
 	 */
70
-	public function set_is_percent( $PRT_is_percent = FALSE ) {
71
-		$this->set( 'PRT_is_percent', $PRT_is_percent );
70
+	public function set_is_percent($PRT_is_percent = FALSE) {
71
+		$this->set('PRT_is_percent', $PRT_is_percent);
72 72
 	}
73 73
 
74 74
 
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 * @access        public
80 80
 	 * @param        int $PRT_order
81 81
 	 */
82
-	public function set_order( $PRT_order = 0 ) {
83
-		$this->set( 'PRT_order', $PRT_order );
82
+	public function set_order($PRT_order = 0) {
83
+		$this->set('PRT_order', $PRT_order);
84 84
 	}
85 85
 
86 86
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 *
90 90
 	 */
91 91
 	public function move_to_trash() {
92
-		$this->set( 'PRT_deleted', TRUE );
92
+		$this->set('PRT_deleted', TRUE);
93 93
 	}
94 94
 
95 95
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 *
99 99
 	 */
100 100
 	public function restore_from_trash() {
101
-		$this->set( 'PRT_deleted', FALSE );
101
+		$this->set('PRT_deleted', FALSE);
102 102
 	}
103 103
 
104 104
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * @access        public
109 109
 	 */
110 110
 	public function name() {
111
-		return $this->get( 'PRT_name' );
111
+		return $this->get('PRT_name');
112 112
 	}
113 113
 
114 114
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	 * @access        public
119 119
 	 */
120 120
 	public function base_type() {
121
-		return $this->get( 'PBT_ID' );
121
+		return $this->get('PBT_ID');
122 122
 	}
123 123
 
124 124
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 	 * @return mixed
128 128
 	 */
129 129
 	public function base_type_name() {
130
-		return $this->get_pretty( 'PBT_ID' );
130
+		return $this->get_pretty('PBT_ID');
131 131
 	}
132 132
 
133 133
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 	 * @access        public
138 138
 	 */
139 139
 	public function is_percent() {
140
-		return $this->get( 'PRT_is_percent' );
140
+		return $this->get('PRT_is_percent');
141 141
 	}
142 142
 
143 143
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 	 * @return bool
147 147
 	 */
148 148
 	public function is_discount() {
149
-		return $this->get( 'PBT_ID' ) == 2 ? TRUE : FALSE;
149
+		return $this->get('PBT_ID') == 2 ? TRUE : FALSE;
150 150
 	}
151 151
 
152 152
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * @access        public
170 170
 	 */
171 171
 	public function order() {
172
-		return $this->get( 'PRT_order' );
172
+		return $this->get('PRT_order');
173 173
 	}
174 174
 
175 175
 
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 	 * @access        public
180 180
 	 */
181 181
 	public function deleted() {
182
-		return $this->get( 'PRT_deleted' );
182
+		return $this->get('PRT_deleted');
183 183
 	}
184 184
 }
185 185
 
Please login to merge, or discard this patch.
core/db_classes/EE_Question_Group.class.php 3 patches
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	 * @param array $props_n_values
33 33
 	 * @return EE_Question_Group|mixed
34 34
 	 */
35
-	public static function new_instance( $props_n_values = array() ) {
36
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
37
-		return $has_object ? $has_object : new self( $props_n_values );
35
+	public static function new_instance($props_n_values = array()) {
36
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
37
+		return $has_object ? $has_object : new self($props_n_values);
38 38
 	}
39 39
 
40 40
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 	 * @param array $props_n_values
44 44
 	 * @return EE_Question_Group
45 45
 	 */
46
-	public static function new_instance_from_db( $props_n_values = array() ) {
47
-		return new self( $props_n_values, TRUE );
46
+	public static function new_instance_from_db($props_n_values = array()) {
47
+		return new self($props_n_values, TRUE);
48 48
 	}
49 49
 
50 50
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 	 * @param bool $pretty
56 56
 	 * @return string
57 57
 	 */
58
-	public function name( $pretty = FALSE ) {
59
-		return $pretty ? $this->get_pretty( 'QSG_name' ) : $this->get( 'QSG_name' );
58
+	public function name($pretty = FALSE) {
59
+		return $pretty ? $this->get_pretty('QSG_name') : $this->get('QSG_name');
60 60
 	}
61 61
 
62 62
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	 * @return string
69 69
 	 */
70 70
 	public function identifier() {
71
-		return $this->get( 'QSG_identifier' );
71
+		return $this->get('QSG_identifier');
72 72
 	}
73 73
 
74 74
 
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 * @param bool $pretty
80 80
 	 * @return string
81 81
 	 */
82
-	public function desc( $pretty = FALSE ) {
83
-		return $pretty ? $this->get_pretty( 'QSG_desc' ) : $this->get( 'QSG_desc' );
82
+	public function desc($pretty = FALSE) {
83
+		return $pretty ? $this->get_pretty('QSG_desc') : $this->get('QSG_desc');
84 84
 	}
85 85
 
86 86
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	 * @return int
93 93
 	 */
94 94
 	public function order() {
95
-		return $this->get( 'QSG_order' );
95
+		return $this->get('QSG_order');
96 96
 	}
97 97
 
98 98
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 * @return boolean
104 104
 	 */
105 105
 	public function show_group_name() {
106
-		return $this->get( 'QSG_show_group_name' );
106
+		return $this->get('QSG_show_group_name');
107 107
 	}
108 108
 
109 109
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	 * @return boolean
116 116
 	 */
117 117
 	public function show_group_desc() {
118
-		return $this->get( 'QSG_show_group_desc' );
118
+		return $this->get('QSG_show_group_desc');
119 119
 	}
120 120
 
121 121
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 * @return boolean
129 129
 	 */
130 130
 	public function system_group() {
131
-		return $this->get( 'QSG_system' );
131
+		return $this->get('QSG_system');
132 132
 	}
133 133
 
134 134
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 * @return boolean
154 154
 	 */
155 155
 	public function deleted() {
156
-		return $this->get( 'QST_deleted' );
156
+		return $this->get('QST_deleted');
157 157
 	}
158 158
 
159 159
 
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
 	 */
165 165
 	public function questions_in_and_not_in_group() {
166 166
 		$questions_in_group = $this->questions();
167
-		$exclude_question_ids = ! empty( $questions_in_group ) ? array_keys( $questions_in_group ) : array();
168
-		$questions_not_in_group = $this->questions_not_in_group( $exclude_question_ids );
167
+		$exclude_question_ids = ! empty($questions_in_group) ? array_keys($questions_in_group) : array();
168
+		$questions_not_in_group = $this->questions_not_in_group($exclude_question_ids);
169 169
 		return $questions_in_group + $questions_not_in_group;
170 170
 	}
171 171
 
@@ -176,9 +176,9 @@  discard block
 block discarded – undo
176 176
 	 * @param array $query_params
177 177
 	 * @return EE_Question[]
178 178
 	 */
179
-	public function questions( $query_params = array() ) {
180
-		$query_params = ! empty( $query_params ) ? $query_params : array( 'order_by' => array( 'Question_Group_Question.QGQ_order' => 'ASC' ) );
181
-		return $this->ID() ? $this->get_many_related( 'Question', $query_params ) : array();
179
+	public function questions($query_params = array()) {
180
+		$query_params = ! empty($query_params) ? $query_params : array('order_by' => array('Question_Group_Question.QGQ_order' => 'ASC'));
181
+		return $this->ID() ? $this->get_many_related('Question', $query_params) : array();
182 182
 	}
183 183
 
184 184
 
@@ -188,14 +188,14 @@  discard block
 block discarded – undo
188 188
 	 * @param  mixed $question_IDS_in_group if empty array then all questions returned.  if FALSE then we first get questions in this group and exclude them from questions get all. IF empty array then we just return all questions.
189 189
 	 * @return EE_Question[]
190 190
 	 */
191
-	public function questions_not_in_group( $question_IDS_in_group = FALSE ) {
192
-		if ( $question_IDS_in_group === FALSE ) {
191
+	public function questions_not_in_group($question_IDS_in_group = FALSE) {
192
+		if ($question_IDS_in_group === FALSE) {
193 193
 			$questions = $this->questions();
194
-			$question_IDS_in_group = ! empty( $questions ) ? array_keys( $questions ) : array();
194
+			$question_IDS_in_group = ! empty($questions) ? array_keys($questions) : array();
195 195
 		}
196
-		$_where = ! empty( $question_IDS_in_group ) ? array( 'QST_ID' => array( 'not_in', $question_IDS_in_group ) ) : array();
196
+		$_where = ! empty($question_IDS_in_group) ? array('QST_ID' => array('not_in', $question_IDS_in_group)) : array();
197 197
 
198
-		return EEM_Question::instance()->get_all( array( $_where, 'order_by' => array( 'QST_ID' => 'ASC' ) ) );
198
+		return EEM_Question::instance()->get_all(array($_where, 'order_by' => array('QST_ID' => 'ASC')));
199 199
 	}
200 200
 
201 201
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 	 * @return EE_Event[]
206 206
 	 */
207 207
 	public function events() {
208
-		return $this->get_many_related( 'Event' );
208
+		return $this->get_many_related('Event');
209 209
 	}
210 210
 
211 211
 
@@ -215,8 +215,8 @@  discard block
 block discarded – undo
215 215
 	 * @param EE_Question || int $question object or ID
216 216
 	 * @return boolean if successful
217 217
 	 */
218
-	public function add_question( $questionObjectOrID ) {
219
-		return $this->_add_relation_to( $questionObjectOrID, 'Question' );
218
+	public function add_question($questionObjectOrID) {
219
+		return $this->_add_relation_to($questionObjectOrID, 'Question');
220 220
 	}
221 221
 
222 222
 
@@ -226,8 +226,8 @@  discard block
 block discarded – undo
226 226
 	 * @param EE_Question || int $question object or ID
227 227
 	 * @return boolean of success
228 228
 	 */
229
-	public function remove_question( $questionObjectOrID ) {
230
-		return $this->_remove_relation_to( $questionObjectOrID, 'Question' );
229
+	public function remove_question($questionObjectOrID) {
230
+		return $this->_remove_relation_to($questionObjectOrID, 'Question');
231 231
 	}
232 232
 
233 233
 
@@ -237,9 +237,9 @@  discard block
 block discarded – undo
237 237
 	 * @param $qst_order
238 238
 	 * @return int
239 239
 	 */
240
-	public function update_question_order( $questionObjectOrID, $qst_order ) {
241
-		$qst_ID = $questionObjectOrID instanceof EE_Question ? $questionObjectOrID->ID() : (int)$questionObjectOrID;
242
-		return EEM_Question_Group_Question::instance()->update( array( 'QGQ_order' => $qst_order ), array( array( 'QST_ID' => $qst_ID, 'QSG_ID' => $this->ID() ) ) );
240
+	public function update_question_order($questionObjectOrID, $qst_order) {
241
+		$qst_ID = $questionObjectOrID instanceof EE_Question ? $questionObjectOrID->ID() : (int) $questionObjectOrID;
242
+		return EEM_Question_Group_Question::instance()->update(array('QGQ_order' => $qst_order), array(array('QST_ID' => $qst_ID, 'QSG_ID' => $this->ID())));
243 243
 	}
244 244
 
245 245
 
@@ -250,9 +250,9 @@  discard block
 block discarded – undo
250 250
 	 */
251 251
 	public function has_questions_with_answers() {
252 252
 		$has_answers = FALSE;
253
-		$questions = $this->get_many_related( 'Question' );
254
-		foreach ( $questions as $question ) {
255
-			if ( $question->count_related( 'Answer' ) > 0 )
253
+		$questions = $this->get_many_related('Question');
254
+		foreach ($questions as $question) {
255
+			if ($question->count_related('Answer') > 0)
256 256
 				$has_answers = TRUE;
257 257
 		}
258 258
 		return $has_answers;
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	 */
269 269
 	public function set_order_to_latest() {
270 270
 		$latest_order = $this->get_model()->get_latest_question_group_order();
271
-		$latest_order ++;
272
-		$this->set( 'QSG_order', $latest_order );
271
+		$latest_order++;
272
+		$this->set('QSG_order', $latest_order);
273 273
 	}
274 274
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -252,8 +252,9 @@
 block discarded – undo
252 252
 		$has_answers = FALSE;
253 253
 		$questions = $this->get_many_related( 'Question' );
254 254
 		foreach ( $questions as $question ) {
255
-			if ( $question->count_related( 'Answer' ) > 0 )
256
-				$has_answers = TRUE;
255
+			if ( $question->count_related( 'Answer' ) > 0 ) {
256
+							$has_answers = TRUE;
257
+			}
257 258
 		}
258 259
 		return $has_answers;
259 260
 	}
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 	/**
214 214
 	 * Adds the question to this question group
215 215
 	 * @param EE_Question || int $question object or ID
216
-	 * @return boolean if successful
216
+	 * @return EE_Base_Class if successful
217 217
 	 */
218 218
 	public function add_question( $questionObjectOrID ) {
219 219
 		return $this->_add_relation_to( $questionObjectOrID, 'Question' );
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	/**
225 225
 	 * Removes the question from this question group
226 226
 	 * @param EE_Question || int $question object or ID
227
-	 * @return boolean of success
227
+	 * @return EE_Base_Class of success
228 228
 	 */
229 229
 	public function remove_question( $questionObjectOrID ) {
230 230
 		return $this->_remove_relation_to( $questionObjectOrID, 'Question' );
Please login to merge, or discard this patch.
core/db_classes/EE_Question_Group_Question.class.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,15 +2,15 @@  discard block
 block discarded – undo
2 2
 /**
3 3
  * Required  by EEM_Question_Group_Question in case someone queries for all its model objects
4 4
  */
5
-class EE_Question_Group_Question extends EE_Base_Class{
5
+class EE_Question_Group_Question extends EE_Base_Class {
6 6
 
7 7
 	/**
8 8
 	 * @param array $props_n_values
9 9
 	 * @return EE_Question_Group_Question|mixed
10 10
 	 */
11
-	public static function new_instance( $props_n_values = array() ) {
12
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
13
-		return $has_object ? $has_object : new self( $props_n_values );
11
+	public static function new_instance($props_n_values = array()) {
12
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
13
+		return $has_object ? $has_object : new self($props_n_values);
14 14
 	}
15 15
 
16 16
 
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 	 * @param array $props_n_values
20 20
 	 * @return EE_Question_Group_Question
21 21
 	 */
22
-	public static function new_instance_from_db ( $props_n_values = array() ) {
23
-		return new self( $props_n_values, TRUE );
22
+	public static function new_instance_from_db($props_n_values = array()) {
23
+		return new self($props_n_values, TRUE);
24 24
 	}
25 25
 }
26 26
\ No newline at end of file
Please login to merge, or discard this patch.
core/db_classes/EE_State.class.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	 * @param array $props_n_values
33 33
 	 * @return EE_State|mixed
34 34
 	 */
35
-	public static function new_instance( $props_n_values = array() ) {
36
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
37
-		return $has_object ? $has_object : new self( $props_n_values );
35
+	public static function new_instance($props_n_values = array()) {
36
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
37
+		return $has_object ? $has_object : new self($props_n_values);
38 38
 	}
39 39
 
40 40
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 	 * @param array $props_n_values
44 44
 	 * @return EE_State
45 45
 	 */
46
-	public static function new_instance_from_db( $props_n_values = array() ) {
47
-		return new self( $props_n_values, TRUE );
46
+	public static function new_instance_from_db($props_n_values = array()) {
47
+		return new self($props_n_values, TRUE);
48 48
 	}
49 49
 
50 50
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 * @return string
54 54
 	 */
55 55
 	public function country_iso() {
56
-		return $this->get( 'CNT_ISO' );
56
+		return $this->get('CNT_ISO');
57 57
 	}
58 58
 
59 59
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 * @return string
63 63
 	 */
64 64
 	public function abbrev() {
65
-		return $this->get( 'STA_abbrev' );
65
+		return $this->get('STA_abbrev');
66 66
 	}
67 67
 
68 68
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @return bool
72 72
 	 */
73 73
 	public function active() {
74
-		return $this->get( 'STA_active' );
74
+		return $this->get('STA_active');
75 75
 	}
76 76
 
77 77
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * @return string
81 81
 	 */
82 82
 	public function name() {
83
-		return $this->get( 'STA_name' );
83
+		return $this->get('STA_name');
84 84
 	}
85 85
 
86 86
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 * @return EE_Country
90 90
 	 */
91 91
 	public function country() {
92
-		return $this->get_first_related( 'Country' );
92
+		return $this->get_first_related('Country');
93 93
 	}
94 94
 
95 95
 
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 	/**
98 98
 	 * @param $iso
99 99
 	 */
100
-	public function set_country_iso( $iso ) {
101
-		$this->set( 'CNT_ISO', $iso );
100
+	public function set_country_iso($iso) {
101
+		$this->set('CNT_ISO', $iso);
102 102
 	}
103 103
 
104 104
 
@@ -106,8 +106,8 @@  discard block
 block discarded – undo
106 106
 	/**
107 107
 	 * @param $abbrev
108 108
 	 */
109
-	public function set_abbrev( $abbrev ) {
110
-		$this->set( 'STA_abbrev', $abbrev );
109
+	public function set_abbrev($abbrev) {
110
+		$this->set('STA_abbrev', $abbrev);
111 111
 	}
112 112
 
113 113
 
@@ -115,8 +115,8 @@  discard block
 block discarded – undo
115 115
 	/**
116 116
 	 * @param $active
117 117
 	 */
118
-	public function set_active( $active ) {
119
-		$this->set( 'STA_active', $active );
118
+	public function set_active($active) {
119
+		$this->set('STA_active', $active);
120 120
 	}
121 121
 
122 122
 
@@ -124,8 +124,8 @@  discard block
 block discarded – undo
124 124
 	/**
125 125
 	 * @param $name
126 126
 	 */
127
-	public function set_name( $name ) {
128
-		$this->set( 'STA_name', $name );
127
+	public function set_name($name) {
128
+		$this->set('STA_name', $name);
129 129
 	}
130 130
 }
131 131
 
Please login to merge, or discard this patch.
core/db_classes/EE_Status.class.php 2 patches
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	 * @param array $props_n_values
33 33
 	 * @return EE_Status
34 34
 	 */
35
-	public static function new_instance( $props_n_values = array() ) {
36
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
37
-		return $has_object ? $has_object : new self( $props_n_values );
35
+	public static function new_instance($props_n_values = array()) {
36
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
37
+		return $has_object ? $has_object : new self($props_n_values);
38 38
 	}
39 39
 
40 40
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 	 * @param array $props_n_values
44 44
 	 * @return EE_Status
45 45
 	 */
46
-	public static function new_instance_from_db( $props_n_values = array() ) {
47
-		return new self( $props_n_values, TRUE );
46
+	public static function new_instance_from_db($props_n_values = array()) {
47
+		return new self($props_n_values, TRUE);
48 48
 	}
49 49
 
50 50
 
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 	 * @param string $schema
56 56
 	 * @return string
57 57
 	 */
58
-	function code( $plural = FALSE, $schema = 'upper' ) {
59
-		$id = $this->get( 'STS_ID' );
60
-		$code = EEM_Status::instance()->localized_status( array( $id => $this->get( 'STS_code' ) ), $plural, $schema );
61
-		return $code[ $id ];
58
+	function code($plural = FALSE, $schema = 'upper') {
59
+		$id = $this->get('STS_ID');
60
+		$code = EEM_Status::instance()->localized_status(array($id => $this->get('STS_code')), $plural, $schema);
61
+		return $code[$id];
62 62
 	}
63 63
 
64 64
 
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
68 68
 	 * @param string $code
69 69
 	 * @return boolean
70 70
 	 */
71
-	function set_code( $code ) {
72
-		$this->set( 'STS_code', $code );
71
+	function set_code($code) {
72
+		$this->set('STS_code', $code);
73 73
 	}
74 74
 
75 75
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 * @return string
80 80
 	 */
81 81
 	function desc() {
82
-		return $this->get( 'STS_desc' );
82
+		return $this->get('STS_desc');
83 83
 	}
84 84
 
85 85
 
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
 	 * @param string $desc
90 90
 	 * @return boolean
91 91
 	 */
92
-	function set_desc( $desc ) {
93
-		$this->set( 'STS_desc', $desc );
92
+	function set_desc($desc) {
93
+		$this->set('STS_desc', $desc);
94 94
 	}
95 95
 
96 96
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	 * @return string
101 101
 	 */
102 102
 	function type() {
103
-		return $this->get( 'STS_type' );
103
+		return $this->get('STS_type');
104 104
 	}
105 105
 
106 106
 
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
 	 * @param string $type
111 111
 	 * @return boolean
112 112
 	 */
113
-	function set_type( $type ) {
114
-		$this->set( 'STS_type', $type );
113
+	function set_type($type) {
114
+		$this->set('STS_type', $type);
115 115
 	}
116 116
 
117 117
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * @return boolean
122 122
 	 */
123 123
 	function can_edit() {
124
-		return $this->get( 'STS_can_edit' );
124
+		return $this->get('STS_can_edit');
125 125
 	}
126 126
 
127 127
 
@@ -131,8 +131,8 @@  discard block
 block discarded – undo
131 131
 	 * @param boolean $can_edit
132 132
 	 * @return boolean
133 133
 	 */
134
-	function set_can_edit( $can_edit ) {
135
-		$this->set( 'STS_can_edit', $can_edit );
134
+	function set_can_edit($can_edit) {
135
+		$this->set('STS_can_edit', $can_edit);
136 136
 	}
137 137
 
138 138
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	 * @return boolean
143 143
 	 */
144 144
 	function open() {
145
-		return $this->get( 'STS_open' );
145
+		return $this->get('STS_open');
146 146
 	}
147 147
 
148 148
 
@@ -152,8 +152,8 @@  discard block
 block discarded – undo
152 152
 	 * @param boolean $open
153 153
 	 * @return boolean
154 154
 	 */
155
-	function set_open( $open ) {
156
-		$this->set( 'STS_open', $open );
155
+	function set_open($open) {
156
+		$this->set('STS_open', $open);
157 157
 	}
158 158
 }
159 159
 
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	/**
67 67
 	 * Sets code
68 68
 	 * @param string $code
69
-	 * @return boolean
69
+	 * @return boolean|null
70 70
 	 */
71 71
 	function set_code( $code ) {
72 72
 		$this->set( 'STS_code', $code );
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	/**
88 88
 	 * Sets desc
89 89
 	 * @param string $desc
90
-	 * @return boolean
90
+	 * @return boolean|null
91 91
 	 */
92 92
 	function set_desc( $desc ) {
93 93
 		$this->set( 'STS_desc', $desc );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	/**
109 109
 	 * Sets type
110 110
 	 * @param string $type
111
-	 * @return boolean
111
+	 * @return boolean|null
112 112
 	 */
113 113
 	function set_type( $type ) {
114 114
 		$this->set( 'STS_type', $type );
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * Sets can_edit
131 131
 	 * @param boolean $can_edit
132
-	 * @return boolean
132
+	 * @return boolean|null
133 133
 	 */
134 134
 	function set_can_edit( $can_edit ) {
135 135
 		$this->set( 'STS_can_edit', $can_edit );
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 	/**
151 151
 	 * Sets open
152 152
 	 * @param boolean $open
153
-	 * @return boolean
153
+	 * @return boolean|null
154 154
 	 */
155 155
 	function set_open( $open ) {
156 156
 		$this->set( 'STS_open', $open );
Please login to merge, or discard this patch.
core/db_classes/EE_Term.class.php 2 patches
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -34,11 +34,11 @@  discard block
 block discarded – undo
34 34
 	 * @param bool $bydb
35 35
 	 * @param string $timezone
36 36
 	 */
37
-	protected function __construct( $fieldValues = array(), $bydb = FALSE, $timezone = '' ) {
38
-		if ( ! isset( $fieldValues[ 'slug' ] ) ) {
39
-			$fieldValues[ 'slug' ] = $fieldValues[ 'name' ];
37
+	protected function __construct($fieldValues = array(), $bydb = FALSE, $timezone = '') {
38
+		if ( ! isset($fieldValues['slug'])) {
39
+			$fieldValues['slug'] = $fieldValues['name'];
40 40
 		}
41
-		parent::__construct( $fieldValues, $bydb, $timezone );
41
+		parent::__construct($fieldValues, $bydb, $timezone);
42 42
 	}
43 43
 
44 44
 
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
 	 * @param array $props_n_values
48 48
 	 * @return EE_Term|mixed
49 49
 	 */
50
-	public static function new_instance( $props_n_values = array() ) {
51
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
52
-		return $has_object ? $has_object : new self( $props_n_values );
50
+	public static function new_instance($props_n_values = array()) {
51
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
52
+		return $has_object ? $has_object : new self($props_n_values);
53 53
 	}
54 54
 
55 55
 
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
 	 * @param array $props_n_values
59 59
 	 * @return EE_Term
60 60
 	 */
61
-	public static function new_instance_from_db( $props_n_values = array() ) {
62
-		return new self( $props_n_values, TRUE );
61
+	public static function new_instance_from_db($props_n_values = array()) {
62
+		return new self($props_n_values, TRUE);
63 63
 	}
64 64
 
65 65
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 * @return string
70 70
 	 */
71 71
 	function name() {
72
-		return $this->get( 'name' );
72
+		return $this->get('name');
73 73
 	}
74 74
 
75 75
 
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 * @param string $name
80 80
 	 * @return boolean
81 81
 	 */
82
-	function set_name( $name ) {
83
-		$this->set( 'name', $name );
82
+	function set_name($name) {
83
+		$this->set('name', $name);
84 84
 	}
85 85
 
86 86
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	 * @return string
91 91
 	 */
92 92
 	function slug() {
93
-		return $this->get( 'slug' );
93
+		return $this->get('slug');
94 94
 	}
95 95
 
96 96
 
@@ -100,8 +100,8 @@  discard block
 block discarded – undo
100 100
 	 * @param string $slug
101 101
 	 * @return boolean
102 102
 	 */
103
-	function set_slug( $slug ) {
104
-		$this->set( 'slug', $slug );
103
+	function set_slug($slug) {
104
+		$this->set('slug', $slug);
105 105
 	}
106 106
 }
107 107
 
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	/**
80 80
 	 * Sets name
81 81
 	 * @param string $name
82
-	 * @return boolean
82
+	 * @return boolean|null
83 83
 	 */
84 84
 	function set_name( $name ) {
85 85
 		$this->set( 'name', $name );
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	/**
101 101
 	 * Sets slug
102 102
 	 * @param string $slug
103
-	 * @return boolean
103
+	 * @return boolean|null
104 104
 	 */
105 105
 	function set_slug( $slug ) {
106 106
 		$this->set( 'slug', $slug );
Please login to merge, or discard this patch.