Messages_Admin_Page

Complexity

Total Complexity

411

Size/Duplication

Total Lines	3463
Duplicated Lines	3.35 %

Coupling/Cohesion

Components	4
Dependencies	21

Importance

Changes	2
Bugs	0	Features	1

91 Methods

Rating	Name	Duplication	Size	Complexity
A	get_messengers_for_list_table()	14	14	3
A	get_message_types_for_list_table()	13	13	3
B	get_contexts_for_message_types_for_list_table()	0	16	5
A	__construct()	0	5	1
A	_init_page_props()	0	11	3
A	_load_message_resource_manager()	0	3	1
A	_ajax_hooks()	0	7	1
A	_define_page_props()	0	11	1
C	_set_page_routes()	0	136	7
B	_set_page_config()	0	143	1
A	_add_screen_options()	0	3	1
A	_add_screen_options_global_mtps()	6	10	1
A	_add_screen_options_default()	0	4	1
A	_add_feature_pointers()	0	1	1
A	admin_init()	0	2	1
A	admin_notices()	0	1	1
A	admin_footer_scripts()	0	1	1
A	messages_help_tab()	0	3	1
A	messengers_help_tab()	0	3	1
A	message_types_help_tab()	0	3	1
A	messages_overview_help_tab()	0	3	1
A	message_templates_help_tab()	0	3	1
A	edit_message_template_help_tab()	0	8	1
A	message_template_shortcodes_help_tab()	0	5	1
A	preview_message_help_tab()	0	3	1
A	settings_help_tab()	0	7	1
A	load_scripts_styles()	7	7	1
A	load_scripts_styles_default()	0	3	1
A	wp_editor_css()	0	12	3
A	load_scripts_styles_edit_message_template()	0	19	1
A	load_scripts_styles_display_preview_message()	0	13	3
A	load_scripts_styles_settings()	0	7	1
A	_set_list_table_views_global_mtps()	12	12	1
C	_set_list_table_views_default()	0	64	15
A	_ee_default_messages_overview_list_table()	0	4	1
A	_message_queue_list_table()	0	7	1
B	_message_legend_items()	0	50	5
A	_custom_mtps_preview()	6	6	1
F	get_message_templates()	0	30	10
A	get_installed_message_types()	0	10	2
F	_add_message_template()	0	27	13
A	add_message_template()	0	3	1
F	_edit_message_template()	0	480	47
A	filter_tinymce_init()	0	3	1
A	add_context_switcher()	0	3	1
A	_add_form_element_before()	0	3	1
A	_add_form_element_after()	0	3	1
B	switch_template_pack()	0	51	6
A	_display_preview_message()	0	3	1
A	_register_edit_meta_boxes()	0	5	1
B	template_pack_meta_box()	0	69	6
C	extra_actions_meta_box()	0	61	14
A	_get_shortcode_selector()	0	8	1
A	shortcode_meta_box()	0	16	2
A	_set_shortcodes()	0	7	2
B	_get_shortcodes()	0	9	5
B	_set_message_template_group()	0	20	6
C	_set_context_switcher()	0	39	8
B	_set_message_template_column_values()	0	32	5
B	_do_test_send()	0	24	5
A	_generate_new_templates()	0	9	2
D	_trash_or_restore_message_template()	0	47	16
B	_delete_message_template()	0	21	5
A	_delete_mtp_permanently()	0	18	4
A	_learn_more_about_message_templates_link()	0	3	1
A	_settings()	0	15	2
C	_set_m_mt_settings()	0	57	10
B	_message_type_settings_content()	0	56	9
D	_messages_settings_metaboxes()	10	91	16
A	_get_mt_tabs()	0	11	2
D	_get_messenger_box_content()	0	84	12
C	activate_messenger_toggle()	4	64	8
C	activate_mt_toggle()	4	61	9
B	_activate_messenger()	8	26	6
A	_deactivate_messenger()	0	6	1
A	_activate_message_type_for_messenger()	6	18	3
A	_deactivate_message_type_for_messenger()	0	8	1
A	_prep_default_response_for_messenger_or_message_type_toggle()	0	4	1
C	_setup_response_message_for_activating_messenger_with_message_types()	0	80	8
C	_setup_response_message_for_deactivating_messenger_with_message_types()	0	49	7
A	update_mt_form()	0	16	3
A	_generate_now()	0	5	1
A	_generate_and_send_now()	0	5	1
A	_queue_for_resending()	0	5	1
A	_send_now()	0	5	1
A	_get_msg_ids_from_request()	0	6	3
F	_reset_to_default_template()	0	76	14
B	_preview_message()	0	51	4
F	_insert_or_update_message_template()	0	189	30
C	save_settings()	26	62	11
B	_delete_ee_messages()	0	22	4

<?php if (!defined('EVENT_ESPRESSO_VERSION') )
	{exit('NO direct script access allowed');}

/**
 *
 * EE_Message_Admin_Page class
 *
 * for Admin setup of the message pages
 *
 * @package		Event Espresso
 * @subpackage	includes/core/message/EE_Message_Admin_Page.core.php
 * @author		Darren Ethier
 *
 * ------------------------------------------------------------------------
 */
class Messages_Admin_Page extends EE_Admin_Page {

	/**
	 * @type EE_Message_Resource_Manager $_message_resource_manager
	 */
	 protected $_message_resource_manager;

	/**
	 * @type string $_active_message_type_name
	 */
	protected  $_active_message_type_name = '';

	/**
	 * @type EE_messenger $_active_messenger
	 */
	protected  $_active_messenger;
	protected  $_activate_state;
	protected  $_activate_meta_box_type;
	protected  $_current_message_meta_box;
	protected  $_current_message_meta_box_object;
	protected  $_context_switcher;
	protected  $_shortcodes = array();

	/**
	 * @type EE_Message_Template_Group $_message_template_group
	 */
	protected  $_message_template_group;
	protected  $_m_mt_settings = array();


	/**
	 * This is set via the _set_message_template_group method and holds whatever the template pack for the group is.
	 * IF there is no group then it gets automatically set to the Default template pack.
	 *
	 * @since 4.5.0
	 *
	 * @var EE_Messages_Template_Pack
	 */
	protected $_template_pack;




	/**
	 * This is set via the _set_message_template_group method and holds whatever the template pack variation for the
	 * group is.  If there is no group then it automatically gets set to default.
	 *
	 * @since 4.5.0
	 *
	 * @var string
	 */
	protected $_variation;




	/**
	 * @param bool $routing
	 */
	public function __construct( $routing = true ) {
		//make sure messages autoloader is running
		EED_Messages::set_autoloaders();
		parent::__construct( $routing );
	}




	protected function _init_page_props() {
		$this->page_slug = EE_MSG_PG_SLUG;
		$this->page_label = __('Messages Settings', 'event_espresso');
		$this->_admin_base_url = EE_MSG_ADMIN_URL;
		$this->_admin_base_path = EE_MSG_ADMIN;

		$this->_activate_state = isset($this->_req_data['activate_state']) ? (array) $this->_req_data['activate_state'] : array();

		$this->_active_messenger = isset( $this->_req_data['messenger'] ) ? $this->_req_data['messenger'] : null;

It seems like isset($this->_req_data['messenger']) ? $this->_req_data['messenger'] : null can also be of type string. However, the property $_active_messenger is declared as type object<EE_messenger>. Maybe add an additional type check?

		$this->_load_message_resource_manager();
	}




	/**
	 * loads messenger objects into the $_active_messengers property (so we can access the needed methods)
	 *
	 *
	 * @throws EE_Error
	*/
	protected function _load_message_resource_manager() {
		$this->_message_resource_manager = EE_Registry::instance()->load_lib( 'Message_Resource_Manager' );

It seems like \EE_Registry::instance()->load_lib('Message_Resource_Manager') can also be of type boolean. However, the property $_message_resource_manager is declared as type object<EE_Message_Resource_Manager>. Maybe add an additional type check?

	}



	/**
	 * get_messengers_for_list_table
	 *
	 * @return array
	 * @throws \EE_Error
	 */
	public function get_messengers_for_list_table() {

This method seems to be duplicated in your project.

		$m_values = array();
		$active_messengers = EEM_Message::instance()->get_all( array( 'group_by' => 'MSG_messenger' ) );
		//setup messengers for selects
		$i = 1;
		foreach ( $active_messengers as $active_messenger ) {
			if ( $active_messenger instanceof EE_Message ) {
				$m_values[ $i ]['id'] = $active_messenger->messenger();
				$m_values[ $i ]['text'] = ucwords( $active_messenger->messenger_label() );
				$i++;
			}
		}
		return $m_values;
	}



	/**
	 * get_message_types_for_list_table
	 *
	 * @return array
	 * @throws \EE_Error
	 */
	public function get_message_types_for_list_table() {

This method seems to be duplicated in your project.

		$mt_values = array();
		$active_messages = EEM_Message::instance()->get_all( array( 'group_by' => 'MSG_message_type' ) );
		$i = 1;
		foreach ( $active_messages as $active_message ) {
			if ( $active_message instanceof EE_Message ) {
				$mt_values[ $i ]['id'] = $active_message->message_type();
				$mt_values[ $i ]['text'] = ucwords( $active_message->message_type_label() );
				$i++;
			}
		}
		return $mt_values;
	}



	/**
	 * get_contexts_for_message_types_for_list_table
	 *
	 * @return array
	 * @throws \EE_Error
	 */
	public function get_contexts_for_message_types_for_list_table() {
		$contexts = array();
		$active_message_contexts = EEM_Message::instance()->get_all( array( 'group_by' => 'MSG_context' ) );
		foreach ( $active_message_contexts as $active_message ) {
			if ( $active_message instanceof EE_Message ) {
				$message_type = $active_message->message_type_object();
				if ( $message_type instanceof EE_message_type ) {
					$message_type_contexts = $message_type->get_contexts();
					foreach ( $message_type_contexts as $context => $context_details ) {
						$contexts[ $context ] = $context_details['label'];
					}
				}
			}
		}
		return $contexts;
	}



	protected function _ajax_hooks() {
		add_action('wp_ajax_activate_messenger', array($this, 'activate_messenger_toggle' ) );
		add_action('wp_ajax_activate_mt', array( $this, 'activate_mt_toggle') );
		add_action('wp_ajax_ee_msgs_save_settings', array( $this, 'save_settings') );
		add_action('wp_ajax_ee_msgs_update_mt_form', array( $this, 'update_mt_form' ) );
		add_action('wp_ajax_switch_template_pack', array( $this, 'switch_template_pack' ) );
	}






	protected function _define_page_props() {
		$this->_admin_page_title = $this->page_label;
		$this->_labels = array(
			'buttons' => array(
				'add' => __('Add New Message Template', 'event_espresso'),
				'edit' => __('Edit Message Template', 'event_espresso'),
				'delete' => __('Delete Message Template', 'event_espresso')
			),
			'publishbox' => __('Update Actions', 'event_espresso')
		);
	}







	/**
	 * 		an array for storing key => value pairs of request actions and their corresponding methods
	*		@access protected
	*		@return void
	*/
	protected function _set_page_routes() {
		$grp_id = ! empty( $this->_req_data['GRP_ID'] ) && ! is_array( $this->_req_data['GRP_ID'] )
			? $this->_req_data['GRP_ID']
			: 0;
		$grp_id = empty( $grp_id ) && !empty( $this->_req_data['id'] )
			? $this->_req_data['id']
			: $grp_id;
		$msg_id = ! empty( $this->_req_data['MSG_ID'] ) && ! is_array( $this->_req_data['MSG_ID'] )
			? $this->_req_data['MSG_ID']
			: 0;

		$this->_page_routes = array(
			'default' => array(
				'func' => '_message_queue_list_table',
				'capability' => 'ee_read_messages'
			),
			'global_mtps'=> array(
				'func' => '_ee_default_messages_overview_list_table',
				'capability' => 'ee_read_global_messages'
			),
			'custom_mtps' => array(
				'func' => '_custom_mtps_preview',
				'capability' => 'ee_read_messages'
			),
			'add_new_message_template'	=>array(
				 'func' => '_add_message_template',
				 'capability' => 'ee_edit_messages',
				 'noheader' => true
			),
			'edit_message_template' => array(
				'func' => '_edit_message_template',
				'capability' => 'ee_edit_message',
				'obj_id' => $grp_id
			),
			'preview_message' => array(
				'func' => '_preview_message',
				'capability' => 'ee_read_message',
				'obj_id' => $grp_id,
				'noheader' => true,
				'headers_sent_route' => 'display_preview_message'
			),
			'display_preview_message' => array(
				'func' => '_display_preview_message',
				'capability' => 'ee_read_message',
				'obj_id' => $grp_id
			),
			'insert_message_template' => array(
				'func' => '_insert_or_update_message_template',
				'capability' => 'ee_edit_messages',
				'args' => array( 'new_template' => true ),
				'noheader' => true
			 ),
			'update_message_template' => array(
				'func' => '_insert_or_update_message_template',
				'capability' => 'ee_edit_message',
				'obj_id' => $grp_id,
				'args' => array( 'new_template' => false ),
				'noheader' => true
			),
			'trash_message_template' => array(
				'func' => '_trash_or_restore_message_template',
				'capability' => 'ee_delete_message',
				'obj_id' => $grp_id,
				'args' => array( 'trash' => true, 'all' => true ),
				'noheader' => true
			),
			'trash_message_template_context' => array(
				'func' => '_trash_or_restore_message_template',
				'capability' => 'ee_delete_message',
				'obj_id' => $grp_id,
				'args' => array( 'trash' => true ),
				'noheader' => true
			),
			'restore_message_template' => array(
				'func' => '_trash_or_restore_message_template',
				'capability' => 'ee_delete_message',
				'obj_id' => $grp_id,
				'args' => array( 'trash' => false, 'all' => true ),
				'noheader' => true
			),
			'restore_message_template_context' => array(
				'func' => '_trash_or_restore_message_template',
				'capability' => 'ee_delete_message',
				'obj_id' => $grp_id,
				'args' => array('trash' => false),
				'noheader' => true
			),
			'delete_message_template' => array(
				'func' => '_delete_message_template',
				'capability' => 'ee_delete_message',
				'obj_id' => $grp_id,
				'noheader' => true
			),
			'reset_to_default' => array(
				'func' => '_reset_to_default_template',
				'capability' => 'ee_edit_message',
				'obj_id' => $grp_id,
				'noheader' => true
			),
			'settings' => array(
				'func' => '_settings',
				'capability' => 'manage_options'
			),
			'generate_now' => array(
				'func' => '_generate_now',
				'capability' => 'ee_send_message',
				'noheader' => true
			),
			'generate_and_send_now' => array(
				'func' => '_generate_and_send_now',
				'capability' => 'ee_send_message',
				'noheader' => true
			),
			'queue_for_resending' => array(
				'func' => '_queue_for_resending',
				'capability' => 'ee_send_message',
				'noheader' => true
			),
			'send_now' => array(
				'func' => '_send_now',
				'capability' => 'ee_send_message',
				'noheader' => true
			),
			'delete_ee_message' => array(
				'func' => '_delete_ee_messages',
				'capability' => 'ee_delete_message',
				'noheader' => true
			),
			'delete_ee_messages' => array(
				'func' => '_delete_ee_messages',
				'capability' => 'ee_delete_messages',
				'noheader' => true,
				'obj_id' => $msg_id
			)
		);
	}








	protected function _set_page_config() {
		$this->_page_config = array(
			'default' => array(
				'nav' => array(
					'label' => __('Message Activity', 'event_espresso'),
					'order' => 10
				),
				'list_table' => 'EE_Message_List_Table',
				// 'qtips' => array( 'EE_Message_List_Table_Tips' ),
				'require_nonce' => false
			),
			'global_mtps' => array(
				'nav' => array(
					'label' => __('Default Message Templates', 'event_espresso'),
					'order' => 20
				),
				'list_table' => 'Messages_Template_List_Table',
				'help_tabs' => array(
					'messages_overview_help_tab' => array(
						'title' => __('Messages Overview', 'event_espresso'),
						'filename' => 'messages_overview'
					),
					'messages_overview_messages_table_column_headings_help_tab' => array(
						'title' => __('Messages Table Column Headings', 'event_espresso'),
						'filename' => 'messages_overview_table_column_headings'
					),
					'messages_overview_messages_filters_help_tab' => array(
						'title' => __('Message Filters', 'event_espresso'),
						'filename' => 'messages_overview_filters'
					),
					'messages_overview_messages_views_help_tab' => array(
						'title' => __('Message Views', 'event_espresso'),
						'filename' => 'messages_overview_views'
					),
					'message_overview_message_types_help_tab' => array(
						'title' => __('Message Types', 'event_espresso'),
						'filename' => 'messages_overview_types'
					),
					'messages_overview_messengers_help_tab' => array(
						'title' => __('Messengers', 'event_espresso'),
						'filename' => 'messages_overview_messengers',
					),
					'messages_overview_other_help_tab' => array(
						'title' => __('Messages Other', 'event_espresso'),
						'filename' => 'messages_overview_other',
					),
				),
				'help_tour' => array( 'Messages_Overview_Help_Tour' ),
				'require_nonce' => false
			),
			'custom_mtps' => array(
				'nav' => array(
					'label' => __('Custom Message Templates', 'event_espresso'),
					'order' => 30
				),
				'help_tabs' => array(),
				'help_tour' => array(),
				'require_nonce' => false
			),
			'add_new_message_template' => array(
				'nav' => array(
					'label' => __('Add New Message Templates', 'event_espresso'),
					'order' => 5,
					'persistent' => false
				),
				'require_nonce' => false
			),
			'edit_message_template' => array(
				'labels' => array(
					'buttons' => array(
						'reset' => __('Reset Templates'),
					),
					'publishbox' => __('Update Actions', 'event_espresso')
				),
				'nav' => array(
					'label' => __('Edit Message Templates', 'event_espresso'),
					'order' => 5,
					'persistent' => false,
					'url' => ''
				),
				'metaboxes' => array('_publish_post_box', '_register_edit_meta_boxes'),
				'has_metaboxes' => true,
				'help_tour' => array( 'Message_Templates_Edit_Help_Tour' ),
				'help_tabs' => array(
					'edit_message_template' => array(
						'title' => __('Message Template Editor', 'event_espresso'),
						'callback' => 'edit_message_template_help_tab'
					),
					'message_templates_help_tab' => array(
						'title' => __('Message Templates', 'event_espresso'),
						'filename' => 'messages_templates'
					),
					'message_template_shortcodes' => array(
						'title' => __('Message Shortcodes', 'event_espresso'),
						'callback' => 'message_template_shortcodes_help_tab'
					),
					'message_preview_help_tab' => array(
						'title' => __('Message Preview', 'event_espresso'),
						'filename' => 'messages_preview'
					),
				),
				'require_nonce' => false
			),
			'display_preview_message' => array(
				'nav' => array(
					'label' => __('Message Preview', 'event_espresso'),
					'order' => 5,
					'url' => '',
					'persistent' => false
				),
				'help_tabs' => array(
					'preview_message' => array(
						'title' => __('About Previews', 'event_espresso'),
						'callback' => 'preview_message_help_tab'
					)
				),
				'require_nonce' => false
			),
			'settings' => array(
				'nav' => array(
					'label' => __('Settings', 'event_espresso'),
					'order' => 40
				),
				'metaboxes' => array('_messages_settings_metaboxes'),
				'help_tabs' => array(
					'messages_settings_help_tab' => array(
						'title' => __('Messages Settings', 'event_espresso'),
						'filename' => 'messages_settings'
					),
					'messages_settings_message_types_help_tab' => array(
						'title' => __('Activating / Deactivating Message Types', 'event_espresso'),
						'filename' => 'messages_settings_message_types'
					),
					'messages_settings_messengers_help_tab' => array(
						'title' => __('Activating / Deactivating Messengers', 'event_espresso'),
						'filename' => 'messages_settings_messengers'
					),
				),
				'help_tour' => array( 'Messages_Settings_Help_Tour' ),
				'require_nonce' => false
			)
		);
	}





	protected function _add_screen_options() {
		//todo
	}





	protected function _add_screen_options_global_mtps() {

This method seems to be duplicated in your project.

		/**
		 * Note: the reason for the value swap here on $this->_admin_page_title is because $this->_per_page_screen_options
         * uses the $_admin_page_title property and we want different outputs in the different spots.
         */
		$page_title = $this->_admin_page_title;
		$this->_admin_page_title = __('Global Message Templates', 'event_espresso');
		$this->_per_page_screen_option();
		$this->_admin_page_title = $page_title;
	}




	protected function _add_screen_options_default() {
		$this->_admin_page_title = __( 'Message Activity', 'event_espresso' );
		$this->_per_page_screen_option();
	}






	//none of the below group are currently used for Messages
	protected function _add_feature_pointers() {}
	public function admin_init() {
	}
	public function admin_notices() {}
	public function admin_footer_scripts() {}






	public function messages_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_messages_help_tab.template.php' );
	}


	public function messengers_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_messenger_help_tab.template.php' );
	}


	public function message_types_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_message_type_help_tab.template.php' );
	}


	public function messages_overview_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_overview_help_tab.template.php' );
	}


	public function message_templates_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_message_templates_help_tab.template.php' );
	}


	public function edit_message_template_help_tab() {
		$args['img1'] = '<img src="' . EE_MSG_ASSETS_URL . 'images/editor.png' . '" alt="' . esc_attr__('Editor Title', 'event_espresso') . '" />';

$args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $args = array(); before regardless.

		$args['img2'] = '<img src="' . EE_MSG_ASSETS_URL . 'images/switch-context.png' . '" alt="' . esc_attr__('Context Switcher and Preview', 'event_espresso') . '" />';
		$args['img3'] = '<img class="left" src="' . EE_MSG_ASSETS_URL . 'images/form-fields.png' . '" alt="' . esc_attr__('Message Template Form Fields', 'event_espresso') . '" />';
		$args['img4'] = '<img class="right" src="' . EE_MSG_ASSETS_URL . 'images/shortcodes-metabox.png' . '" alt="' . esc_attr__('Shortcodes Metabox', 'event_espresso') . '" />';
		$args['img5'] = '<img class="right" src="' . EE_MSG_ASSETS_URL . 'images/publish-meta-box.png' . '" alt="' . esc_attr__('Publish Metabox', 'event_espresso') . '" />';
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_messages_templates_editor_help_tab.template.php', $args);
	}



	public function message_template_shortcodes_help_tab() {
		$this->_set_shortcodes();
		$args['shortcodes'] = $this->_shortcodes;

$args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $args = array(); before regardless.

		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_messages_shortcodes_help_tab.template.php', $args );
	}



	public function preview_message_help_tab() {
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_preview_help_tab.template.php' );
	}


	public function settings_help_tab() {
		$args['img1'] = '<img class="inline-text" src="' . EE_MSG_ASSETS_URL . 'images/email-tab-active.png' . '" alt="' . esc_attr__('Active Email Tab', 'event_espresso') . '" />';

$args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $args = array(); before regardless.

		$args['img2'] = '<img class="inline-text" src="' . EE_MSG_ASSETS_URL . 'images/email-tab-inactive.png' . '" alt="' . esc_attr__('Inactive Email Tab', 'event_espresso') . '" />';
		$args['img3'] = '<div class="switch"><input id="ee-on-off-toggle-on" class="ee-on-off-toggle ee-toggle-round-flat" type="checkbox" checked="checked"><label for="ee-on-off-toggle-on"></label>';
		$args['img4'] = '<div class="switch"><input id="ee-on-off-toggle-on" class="ee-on-off-toggle ee-toggle-round-flat" type="checkbox"><label for="ee-on-off-toggle-on"></label>';
		EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'ee_msg_messages_settings_help_tab.template.php', $args);
	}





	public function load_scripts_styles() {

This method seems to be duplicated in your project.

		wp_register_style('espresso_ee_msg', EE_MSG_ASSETS_URL . 'ee_message_admin.css', EVENT_ESPRESSO_VERSION );
		wp_enqueue_style('espresso_ee_msg');

		wp_register_script('ee-messages-settings', EE_MSG_ASSETS_URL . 'ee-messages-settings.js', array('jquery-ui-droppable', 'ee-serialize-full-array'), EVENT_ESPRESSO_VERSION, true );
		wp_register_script( 'ee-msg-list-table-js', EE_MSG_ASSETS_URL. 'ee_message_admin_list_table.js', array( 'ee-dialog' ), EVENT_ESPRESSO_VERSION );
	}



	public function load_scripts_styles_default() {
		wp_enqueue_script( 'ee-msg-list-table-js' );
	}





	public function wp_editor_css( $mce_css ) {
		//if we're on the edit_message_template route
		if ( $this->_req_action == 'edit_message_template' && $this->_active_messenger instanceof EE_messenger  ) {
			$message_type_name = $this->_active_message_type_name;

			//we're going to REPLACE the existing mce css
			//we need to get the css file location from the active messenger
			$mce_css = $this->_active_messenger->get_variation($this->_template_pack, $message_type_name, true, 'wpeditor', $this->_variation );
		}

		return $mce_css;
	}




	public function load_scripts_styles_edit_message_template() {

		$this->_set_shortcodes();

		EE_Registry::$i18n_js_strings['confirm_default_reset'] = sprintf(
			__('Are you sure you want to reset the %s %s message templates?  Remember continuing will reset the templates for all contexts in this messenger and message type group.', 'event_espresso'),
			$this->_message_template_group->messenger_obj()->label['singular'],
			$this->_message_template_group->message_type_obj()->label['singular']
		);
		EE_Registry::$i18n_js_strings['confirm_switch_template_pack'] = __('Switching the template pack for a messages template will reset the content for the template so the new layout is loaded.  Any custom content in the existing template will be lost. Are you sure you wish to do this?', 'event_espresso' );

		wp_register_script('ee_msgs_edit_js', EE_MSG_ASSETS_URL . 'ee_message_editor.js', array('jquery'), EVENT_ESPRESSO_VERSION );

		wp_enqueue_script('ee_admin_js');
		wp_enqueue_script('ee_msgs_edit_js');

		//add in special css for tiny_mce
		add_filter( 'mce_css', array( $this, 'wp_editor_css' ) );
	}



	public function load_scripts_styles_display_preview_message() {

		$this->_set_message_template_group();

		if ( isset( $this->_req_data['messenger'] ) ) {
			$this->_active_messenger = $this->_message_resource_manager->get_active_messenger( $this->_req_data['messenger'] );
		}

		$message_type_name = isset( $this->_req_data['message_type'] ) ? $this->_req_data['message_type'] : '';


		wp_enqueue_style('espresso_preview_css', $this->_active_messenger->get_variation( $this->_template_pack, $message_type_name, true, 'preview', $this->_variation ) );
	}



	public function load_scripts_styles_settings() {
		wp_register_style( 'ee-message-settings', EE_MSG_ASSETS_URL . 'ee_message_settings.css', array(), EVENT_ESPRESSO_VERSION );
		wp_enqueue_style( 'ee-text-links' );
		wp_enqueue_style( 'ee-message-settings' );

		wp_enqueue_script('ee-messages-settings');
	}



	/**
	 * set views array for List Table
	 */
	public function _set_list_table_views_global_mtps() {

This method seems to be duplicated in your project.

		$this->_views = array(
			'in_use' => array(
				'slug' => 'in_use',
				'label' => __('In Use', 'event_espresso'),
				'count' => 0,
				'bulk_action' => array(
					'trash_message_template' => __('Move to Trash', 'event_espresso')
				)
			)
		);
	}




	/**
	 * set views array for message queue list table
	 */
	public function _set_list_table_views_default() {
		EE_Registry::instance()->load_helper( 'Template' );

		$common_bulk_actions = EE_Registry::instance()->CAP->current_user_can( 'ee_send_message', 'message_list_table_bulk_actions' )
			? array(
				'generate_now' => __( 'Generate Now', 'event_espresso' ),
		        'generate_and_send_now' => __( 'Generate and Send Now', 'event_espresso' ),
		        'queue_for_resending' => __( 'Queue for Resending', 'event_espresso' ),
		        'send_now' => __( 'Send Now', 'event_espresso' )
				)
			: array();

		$delete_bulk_action = EE_Registry::instance()->CAP->current_user_can( 'ee_delete_messages', 'message_list_table_bulk_actions' )
			? array( 'delete_ee_messages' => __( 'Delete Messages', 'event_espresso' ) )
			: array();


		$this->_views = array(
			 'all' => array(
			    'slug' => 'all',
			    'label' => __( 'All', 'event_espresso' ),
			    'count' => 0,
			    'bulk_action' => array_merge( $common_bulk_actions, $delete_bulk_action )
			 )
		);


		foreach ( EEM_Message::instance()->all_statuses() as $status ) {
			if ( $status === EEM_Message::status_debug_only && ( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) ) {
				continue;
			}
			$status_bulk_actions = $common_bulk_actions;
			//unset bulk actions not applying to status
			if ( ! empty( $status_bulk_actions ) ) {
				switch ( $status ) {
					case EEM_Message::status_idle :
					case EEM_Message::status_resend :
						$status_bulk_actions['send_now'] = $common_bulk_actions['send_now'];
						break;

					case EEM_Message::status_failed :
					case EEM_Message::status_debug_only :
						$status_bulk_actions = array();
						break;

					case EEM_Message::status_incomplete :
						unset( $status_bulk_actions['queue_for_resending'], $status_bulk_actions['send_now'] );
						break;

					case EEM_Message::status_retry :
					case EEM_Message::status_sent :
						unset( $status_bulk_actions['generate_now'], $status_bulk_actions['generate_and_send_now'] );
						break;
				}
			}

			$this->_views[ strtolower( $status ) ] = array(
				'slug' => strtolower( $status ),
				'label' => EEH_Template::pretty_status( $status, false, 'sentence' ),
				'count' => 0,
				'bulk_action' => array_merge( $status_bulk_actions, $delete_bulk_action )
			);
		}
	}



	protected function _ee_default_messages_overview_list_table() {
		$this->_admin_page_title = __('Default Message Templates', 'event_espresso');
		$this->display_admin_list_table_page_with_no_sidebar();
	}





	protected function _message_queue_list_table() {
		$this->_search_btn_label = __('Message Activity', 'event_espresso');
		$this->_template_args['per_column'] = 6;
		$this->_template_args['after_list_table'] = $this->_display_legend( $this->_message_legend_items() );
		$this->_template_args['before_list_table'] = '<h3>' . EEM_Message::instance()->get_pretty_label_for_results() . '</h3>';
		$this->display_admin_list_table_page_with_no_sidebar();
	}





	protected function _message_legend_items() {

		$action_css_classes = EEH_MSG_Template::get_message_action_icons();
		$action_items = array();

		foreach( $action_css_classes as $action_item => $action_details ) {
			if ( $action_item === 'see_notifications_for' ) {
				continue;
			}
			$action_items[$action_item] = array(
				'class' => $action_details['css_class'],
				'desc' => $action_details['label']
			);
		}

		/** @type array $status_items status legend setup*/
		$status_items = array(
			'sent_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_sent,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_sent, false, 'sentence' )
				),
			'idle_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_idle,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_idle, false, 'sentence' )
				),
			'failed_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_failed,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_failed, false, 'sentence' )
			),
			'resend_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_resend,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_resend, false, 'sentence' )
				),
			'incomplete_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_incomplete,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_incomplete, false, 'sentence' )
				),
			'retry_status' => array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_retry,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_retry, false, 'sentence' )
				)
		);
		if ( defined( 'WP_DEBUG' ) && WP_DEBUG ) {
			$status_items['debug_only_status'] = array(
				'class' => 'ee-status-legend ee-status-legend-' . EEM_Message::status_debug_only,
				'desc' => EEH_Template::pretty_status( EEM_Message::status_debug_only, false, 'sentence' )
			);
		}
		return array_merge( $action_items, $status_items );
	}






	protected function _custom_mtps_preview() {

This method seems to be duplicated in your project.

		$this->_admin_page_title = __('Custom Message Templates (Preview)', 'event_espresso');
		$this->_template_args['preview_img'] = '<img src="' . EE_MSG_ASSETS_URL . 'images/custom_mtps_preview.png" alt="' . esc_attr__('Preview Custom Message Templates screenshot', 'event_espresso' ) . '" />';
		$this->_template_args['preview_text'] = '<strong>'.__('Custom Message Templates is a feature that is only available in the caffeinated version of Event Espresso.  With the Custom Message Templates feature, you are able to create custom templates and set them per event.', 'event_espresso').'</strong>';
		$this->display_admin_caf_preview_page( 'custom_message_types', false );
	}








	/**
	 * get_message_templates
	 * This gets all the message templates for listing on the overview list.
	 *
	 * @access public
	 *
	 * @param int $perpage the amount of templates groups to show per page
	 * @param string $type the current _view we're getting templates for
	 * @param bool $count return count?
	 * @param bool $all disregard any paging info (get all data);
	 * @param bool $global whether to return just global (true) or custom templates (false)
	 *
	 * @return array
	 */
	public function get_message_templates( $perpage = 10, $type = 'in_use', $count = false, $all = false, $global = true ) {

		$MTP = EEM_Message_Template_Group::instance();

		$this->_req_data['orderby'] = empty($this->_req_data['orderby']) ? 'GRP_ID' : $this->_req_data['orderby'];
		$orderby = $this->_req_data['orderby'];

		$order = ( isset( $this->_req_data['order'] ) && ! empty( $this->_req_data['order'] ) ) ? $this->_req_data['order'] : 'ASC';

		$current_page = isset( $this->_req_data['paged'] ) && !empty( $this->_req_data['paged'] ) ? $this->_req_data['paged'] : 1;
		$per_page = isset( $this->_req_data['perpage'] ) && !empty( $this->_req_data['perpage'] ) ? $this->_req_data['perpage'] : $perpage;

		$offset = ($current_page-1)*$per_page;
		$limit = $all ? null : array( $offset, $per_page );


		//options will match what is in the _views array property
		switch( $type ) {

			case 'in_use':
				$templates = $MTP->get_all_active_message_templates($orderby, $order, $limit, $count, $global, true );
				break;

			default:
				$templates = $MTP->get_all_trashed_grouped_message_templates($orderby, $order, $limit, $count, $global );

		}

		return $templates;
	}





	/**
	 * filters etc might need a list of installed message_types
	 * @return array an array of message type objects
	 */
	public function get_installed_message_types() {
		$installed_message_types = $this->_message_resource_manager->installed_message_types();
		$installed = array();

		foreach ( $installed_message_types as $message_type ) {
			$installed[ $message_type->name ] = $message_type;
		}

		return $installed;
	}



	/**
	 * _add_message_template
	 *
	 * This is used when creating a custom template. All Custom Templates start based off another template.
	 *
	 * @param string $message_type
	 * @param string $messenger
	 * @param string $GRP_ID
	 *
	 * @throws EE_error
	 */
	protected function _add_message_template(  $message_type = '', $messenger='', $GRP_ID = '' ) {
		//set values override any request data
		$message_type = !empty( $message_type ) ? $message_type : '';
		$message_type = empty( $message_type ) && !empty( $this->_req_data['message_type'] ) ? $this->_req_data['message_type'] : $message_type;

		$messenger = !empty( $messenger ) ? $messenger : '';
		$messenger = empty( $messenger ) && !empty( $this->_req_data['messenger'] ) ? $this->_req_data['messenger'] : $messenger;

		$GRP_ID = !empty( $GRP_ID ) ? $GRP_ID : '';
		$GRP_ID = empty( $GRP_ID ) && !empty( $this->_req_data['GRP_ID'] ) ? $this->_req_data['GRP_ID'] : $GRP_ID;

		//we need messenger and message type.  They should be coming from the event editor. If not here then return error
		if ( empty( $message_type ) || empty( $messenger )  )
			{throw new EE_error(__('Sorry, but we can\'t create new templates because we\'re missing the messenger or message type', 'event_espresso'));}

		//we need the GRP_ID for the template being used as the base for the new template
		if ( empty( $GRP_ID ) )
			{throw new EE_Error( __('In order to create a custom message template the GRP_ID of the template being used as a base is needed', 'event_espresso' ) );}

		//let's just make sure the template gets generated!

		//we need to reassign some variables for what the insert is expecting
		$this->_req_data['MTP_messenger'] = $messenger;
		$this->_req_data['MTP_message_type'] = $message_type;
		$this->_req_data['GRP_ID'] = $GRP_ID;
		$this->_insert_or_update_message_template(true);
	}



	/**
	 * public wrapper for the _add_message_template method
	 *
	 * @param string $message_type message type slug
	 * @param string $messenger    messenger slug
	 * @param int      $GRP_ID         GRP_ID for the related message template group this new template will be based
	 *                                 off of.
	 */
	public function add_message_template( $message_type, $messenger, $GRP_ID ) {
		$this->_add_message_template( $message_type, $messenger, $GRP_ID );
	}


	/**
	 * _edit_message_template
	 *
	 * @access protected
	 * @return void
	 */
	protected function _edit_message_template() {
		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '');
		$template_fields = '';
		$sidebar_fields = '';
		//we filter the tinyMCE settings to remove the validation since message templates by their nature will not have valid html in the templates.
		add_filter( 'tiny_mce_before_init', array( $this, 'filter_tinymce_init'), 10, 2 );

		$GRP_ID = isset( $this->_req_data['id'] ) && !empty( $this->_req_data['id'] )
			? absint( $this->_req_data['id'] )
			: false;

		$this->_set_shortcodes(); //this also sets the _message_template property.
		$message_template_group = $this->_message_template_group;
		$c_label = $message_template_group->context_label();
		$c_config = $message_template_group->contexts_config();

		reset( $c_config );
		$context = isset( $this->_req_data['context']) && !empty($this->_req_data['context'] )
			? strtolower($this->_req_data['context'])
			: key($c_config);


		if ( empty($GRP_ID) ) {
			$action = 'insert_message_template';
			//$button_both = false;
			//$button_text = array( __( 'Save','event_espresso') );
			//$button_actions = array('something_different');
			//$referrer = false;
			$edit_message_template_form_url = add_query_arg(
				array( 'action' => $action, 'noheader' => true ),
				EE_MSG_ADMIN_URL
			);
		} else {
			$action = 'update_message_template';
			//$button_both = true;
			//$button_text = array();
			//$button_actions = array();
			//$referrer = $this->_admin_base_url;
			$edit_message_template_form_url = add_query_arg(
				array( 'action' => $action, 'noheader' => true ),
				EE_MSG_ADMIN_URL
			);
		}

		//set active messenger for this view
		$this->_active_messenger = $this->_message_resource_manager->get_active_messenger(
			$message_template_group->messenger()
		);
		$this->_active_message_type_name = $message_template_group->message_type();


		//Do we have any validation errors?
		$validators = $this->_get_transient();
		$v_fields = !empty($validators) ? array_keys($validators) : array();


		//we need to assemble the title from Various details
		$context_label = sprintf(
			__('(%s %s)', 'event_espresso'),
			$c_config[$context]['label'],
			ucwords($c_label['label'] )
		);

		$title = sprintf(
			__(' %s %s Template %s', 'event_espresso'),
			ucwords($message_template_group->messenger_obj()->label['singular']),
			ucwords($message_template_group->message_type_obj()->label['singular']),
			$context_label
		);

		$this->_template_args['GRP_ID'] = $GRP_ID;
		$this->_template_args['message_template'] = $message_template_group;
		$this->_template_args['is_extra_fields'] = false;


		//let's get EEH_MSG_Template so we can get template form fields
		$template_field_structure = EEH_MSG_Template::get_fields(
			$message_template_group->messenger(),
			$message_template_group->message_type()
		);

		if ( !$template_field_structure ) {

The expression $template_field_structure of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			$template_field_structure = false;
			$template_fields = __('There was an error in assembling the fields for this display (you should see an error message)', 'event_espresso');
		}


		$message_templates = $message_template_group->context_templates();


		//if we have the extra key.. then we need to remove the content index from the template_field_structure as it will get handled in the "extra" array.
		if ( is_array($template_field_structure[$context]) && isset( $template_field_structure[$context]['extra']) ) {
			foreach ( $template_field_structure[$context]['extra'] as $reference_field => $new_fields ) {
				unset( $template_field_structure[$context][$reference_field] );
			}
		}

		//let's loop through the template_field_structure and actually assemble the input fields!
		if ( !empty($template_field_structure) ) {
			foreach ( $template_field_structure[$context] as $template_field => $field_setup_array ) {
				//if this is an 'extra' template field then we need to remove any existing fields that are keyed up in the extra array and reset them.
				if ( $template_field == 'extra' ) {
					$this->_template_args['is_extra_fields'] = true;
					foreach ( $field_setup_array as $reference_field => $new_fields_array ) {
						$message_template = $message_templates[ $context ][ $reference_field ];
						$content = $message_template instanceof EE_Message_Template
							? $message_template->get( 'MTP_content' )
							: '';
						foreach ( $new_fields_array as $extra_field =>  $extra_array ) {
							//let's verify if we need this extra field via the shortcodes parameter.
							$continue = false;
							if ( isset( $extra_array['shortcodes_required'] ) ) {
								foreach ( (array) $extra_array['shortcodes_required'] as $shortcode ) {
									if ( !array_key_exists( $shortcode, $this->_shortcodes ) )
										{$continue = true;}
								}
								if ( $continue ) {continue;}
							}

							$field_id = $reference_field . '-' . $extra_field . '-content';
							$template_form_fields[$field_id] = $extra_array;

$template_form_fields was never initialized. Although not strictly required by PHP, it is generally a good practice to add $template_form_fields = array(); before regardless.

							$template_form_fields[$field_id]['name'] = 'MTP_template_fields[' . $reference_field . '][content][' . $extra_field . ']';

The variable $template_form_fields does not seem to be defined for all execution paths leading up to this point.

							$css_class = isset( $extra_array['css_class'] ) ? $extra_array['css_class'] : '';

							$template_form_fields[$field_id]['css_class'] = ! empty( $v_fields )
																			&& in_array($extra_field, $v_fields)
																			&&
																			(
								                                                is_array($validators[$extra_field] )
																				&& isset( $validators[$extra_field]['msg'] )
							                                                )
								? 'validate-error ' . $css_class
								: $css_class;

							$template_form_fields[$field_id]['value'] = !empty($message_templates) && isset($content[$extra_field])
								? stripslashes( html_entity_decode( $content[$extra_field], ENT_QUOTES, "UTF-8") )
								: '';

							//do we have a validation error?  if we do then let's use that value instead
							$template_form_fields[$field_id]['value'] = isset($validators[$extra_field]) ? $validators[$extra_field]['value'] : $template_form_fields[$field_id]['value'];


							$template_form_fields[$field_id]['db-col'] = 'MTP_content';

							//shortcode selector
							$field_name_to_use = $extra_field == 'main' ? 'content' : $extra_field;
							$template_form_fields[$field_id]['append_content'] = $this->_get_shortcode_selector(
								$field_name_to_use,
								$field_id
							);

							if ( isset( $extra_array['input'] ) && $extra_array['input'] == 'wp_editor' ) {
								//we want to decode the entities
								$template_form_fields[$field_id]['value'] = stripslashes(
									html_entity_decode( $template_form_fields[$field_id]['value'], ENT_QUOTES, "UTF-8")
								);

							}/**/
						}
						$templatefield_MTP_id = $reference_field . '-MTP_ID';
						$templatefield_templatename_id = $reference_field . '-name';

						$template_form_fields[$templatefield_MTP_id] = array(
							'name' => 'MTP_template_fields[' . $reference_field . '][MTP_ID]',
							'label' => null,
							'input' => 'hidden',
							'type' => 'int',
							'required' => false,
							'validation' => false,
							'value' => !empty($message_templates) ? $message_template->ID() : '',
							'css_class' => '',
							'format' => '%d',
							'db-col' => 'MTP_ID'
						);

						$template_form_fields[$templatefield_templatename_id] = array(
							'name' => 'MTP_template_fields[' . $reference_field . '][name]',
							'label' => null,
							'input' => 'hidden',
							'type' => 'string',
							'required' => false,
							'validation' => true,
							'value' => $reference_field,
							'css_class' => '',
							'format' => '%s',
							'db-col' => 'MTP_template_field'
						);
					}
					continue; //skip the next stuff, we got the necessary fields here for this dataset.
				} else {
					$field_id = $template_field . '-content';
					$template_form_fields[$field_id] = $field_setup_array;
					$template_form_fields[$field_id]['name'] = 'MTP_template_fields[' . $template_field . '][content]';
					$message_template = isset( $message_templates[ $context ][ $template_field ] )
						? $message_templates[ $context ][ $template_field ]
						: null;
					$template_form_fields[$field_id]['value'] = ! empty( $message_templates )
																&& is_array( $message_templates[$context] )
																&& $message_template instanceof EE_Message_Template
						? $message_template->get('MTP_content')
						: '';

					//do we have a validator error for this field?  if we do then we'll use that value instead
					$template_form_fields[$field_id]['value'] = isset($validators[$template_field])
						? $validators[$template_field]['value']
						: $template_form_fields[$field_id]['value'];


					$template_form_fields[$field_id]['db-col'] = 'MTP_content';
					$css_class = isset($field_setup_array['css_class']) ? $field_setup_array['css_class'] : '';
					$template_form_fields[$field_id]['css_class'] =  ! empty( $v_fields )
																	 && in_array( $template_field, $v_fields )
																	 && isset( $validators[$template_field]['msg'] )
						? 'validate-error ' . $css_class
						: $css_class;

					//shortcode selector
					$template_form_fields[$field_id]['append_content'] = $this->_get_shortcode_selector(
						$template_field, $field_id
					);
				}

				//k took care of content field(s) now let's take care of others.

				$templatefield_MTP_id = $template_field . '-MTP_ID';
				$templatefield_field_templatename_id = $template_field . '-name';

				//foreach template field there are actually two form fields created
				$template_form_fields[$templatefield_MTP_id] = array(
					'name' => 'MTP_template_fields[' . $template_field . '][MTP_ID]',
					'label' => null,
					'input' => 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $message_template instanceof EE_Message_Template ? $message_template->ID() : '',
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'MTP_ID'
				);

				$template_form_fields[$templatefield_field_templatename_id] = array(
					'name' => 'MTP_template_fields[' . $template_field . '][name]',
					'label' => null,
					'input' => 'hidden',
					'type' => 'string',
					'required' => false,
					'validation' => true,
					'value' => $template_field,
					'css_class' => '',
					'format' => '%s',
					'db-col' => 'MTP_template_field'
				);

			}

			//add other fields
			$template_form_fields['ee-msg-current-context'] = array(
					'name' => 'MTP_context',
					'label' => null,
					'input' => 'hidden',
					'type' => 'string',
					'required' => false,
					'validation' => true,
					'value' => $context,
					'css_class' => '',
					'format' => '%s',
					'db-col' => 'MTP_context'
				);

			$template_form_fields['ee-msg-grp-id'] = array(
					'name' => 'GRP_ID',
					'label' => null,
					'input' => 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $GRP_ID,
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'GRP_ID'
				);

			$template_form_fields['ee-msg-messenger'] = array(
					'name' => 'MTP_messenger',
					'label' => null,
					'input' => 'hidden',
					'type' => 'string',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->messenger(),
					'css_class' => '',
					'format' => '%s',
					'db-col' => 'MTP_messenger'
				);

			$template_form_fields['ee-msg-message-type'] = array(
					'name' => 'MTP_message_type',
					'label' => null,
					'input' => 'hidden',
					'type' => 'string',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->message_type(),
					'css_class' => '',
					'format' => '%s',
					'db-col' => 'MTP_message_type'
				);

			$sidebar_form_fields['ee-msg-is-global'] = array(

$sidebar_form_fields was never initialized. Although not strictly required by PHP, it is generally a good practice to add $sidebar_form_fields = array(); before regardless.

					'name' => 'MTP_is_global',
					'label' => __('Global Template', 'event_espresso'),
					'input' => 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->get('MTP_is_global'),
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'MTP_is_global'
				);

			$sidebar_form_fields['ee-msg-is-override'] = array(
					'name' => 'MTP_is_override',
					'label' => __('Override all custom', 'event_espresso'),
					'input' => $message_template_group->is_global() ? 'checkbox' : 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->get('MTP_is_override'),
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'MTP_is_override'
				);

			$sidebar_form_fields['ee-msg-is-active'] = array(
					'name' => 'MTP_is_active',
					'label' => __('Active Template', 'event_espresso'),
					'input' => 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->is_active(),
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'MTP_is_active'
				);

			$sidebar_form_fields['ee-msg-deleted'] = array(
					'name' => 'MTP_deleted',
					'label' => null,
					'input' => 'hidden',
					'type' => 'int',
					'required' => false,
					'validation' => true,
					'value' => $message_template_group->get('MTP_deleted'),
					'css_class' => '',
					'format' => '%d',
					'db-col' => 'MTP_deleted'
				);
			$sidebar_form_fields['ee-msg-author'] = array(
				'name' => 'MTP_user_id',
				'label' => __('Author', 'event_espresso'),
				'input' => 'hidden',
				'type'=> 'int',
				'required' => false,
				'validation' => false,
				'value' => $message_template_group->user(),
				'format' => '%d',
				'db-col' => 'MTP_user_id'
			);

			$sidebar_form_fields['ee-msg-route'] = array(
				'name' => 'action',
				'input' => 'hidden',
				'type' => 'string',
				'value' => $action
				);

			$sidebar_form_fields['ee-msg-id'] = array(
				'name' => 'id',
				'input' => 'hidden',
				'type' => 'int',
				'value' => $GRP_ID
				);
			$sidebar_form_fields['ee-msg-evt-nonce'] = array(
				'name' => $action . '_nonce',
				'input' => 'hidden',
				'type' => 'string',
				'value' => wp_create_nonce( $action . '_nonce')
				);

			if ( isset($this->_req_data['template_switch']) && $this->_req_data['template_switch'] ) {
				$sidebar_form_fields['ee-msg-template-switch'] = array(
					'name' => 'template_switch',
					'input' => 'hidden',
					'type' => 'int',
					'value' => 1
					);
			}


			$template_fields = $this->_generate_admin_form_fields( $template_form_fields );
			$sidebar_fields = $this->_generate_admin_form_fields( $sidebar_form_fields );


		} //end if ( !empty($template_field_structure) )

		//set extra content for publish box
		$this->_template_args['publish_box_extra_content'] = $sidebar_fields;
		$this->_set_publish_post_box_vars(
			'id',
			 $GRP_ID,
			 false,
			 add_query_arg(
			    array( 'action' => 'global_mtps' ),
			    $this->_admin_base_url
			 )
		);

		//add preview button
		$preview_url = parent::add_query_args_and_nonce(

It seems like you call parent on a different method (add_query_args_and_nonce() instead of _edit_message_template()). Are you sure this is correct? If so, you might want to change this to $this->add_query_args_and_nonce().

			array(
				'message_type' => $message_template_group->message_type(),
				'messenger'    => $message_template_group->messenger(),
				'context'      => $context,
				'GRP_ID'       => $GRP_ID,
				'action'       => 'preview_message'
			),
			$this->_admin_base_url
		);
		$preview_button = '<a href="' . $preview_url . '" class="button-secondary messages-preview-button">' . __('Preview', 'event_espresso') . '</a>';


		//setup context switcher
		$context_switcher_args = array(
			'page'    => 'espresso_messages',
			'action'  => 'edit_message_template',
			'id'      => $GRP_ID,
			'context' => $context,
			'extra'   => $preview_button
		);
		$this->_set_context_switcher($message_template_group, $context_switcher_args);


		//main box
		$this->_template_args['template_fields'] = $template_fields;
		$this->_template_args['sidebar_box_id'] = 'details';
		$this->_template_args['action'] = $action;
		$this->_template_args['context'] = $context;
		$this->_template_args['edit_message_template_form_url'] = $edit_message_template_form_url;
		$this->_template_args['learn_more_about_message_templates_link'] = $this->_learn_more_about_message_templates_link();


		$this->_template_args['before_admin_page_content'] = $this->add_context_switcher();
		$this->_template_args['before_admin_page_content'] .= $this->_add_form_element_before();
		$this->_template_args['after_admin_page_content'] = $this->_add_form_element_after();

		$this->_template_path = $this->_template_args['GRP_ID']
			? EE_MSG_TEMPLATE_PATH . 'ee_msg_details_main_edit_meta_box.template.php'
			: EE_MSG_TEMPLATE_PATH . 'ee_msg_details_main_add_meta_box.template.php';

		//send along EE_Message_Template_Group object for further template use.
		$this->_template_args['MTP'] = $message_template_group;

		$this->_template_args['admin_page_content'] = EEH_Template::display_template( $this->_template_path, $this->_template_args, true );


		//finally, let's set the admin_page title
		$this->_admin_page_title = sprintf( __('Editing %s', 'event_espresso'), $title );


		//we need to take care of setting the shortcodes property for use elsewhere.
		$this->_set_shortcodes();



		//final template wrapper
		$this->display_admin_page_with_sidebar();
	}


	public function filter_tinymce_init( $mceInit, $editor_id ) {

The parameter $editor_id is not used and could be removed.

		return $mceInit;
	}



	public function add_context_switcher() {
		return $this->_context_switcher;
	}

	public function _add_form_element_before() {
		return '<form method="post" action="' . $this->_template_args["edit_message_template_form_url"] . '" id="ee-msg-edit-frm">';
	}

	public function _add_form_element_after() {
		return '</form>';
	}




	/**
	 * This executes switching the template pack for a message template.
	 *
	 * @since 4.5.0
	 *
	 */
	public function switch_template_pack() {
		$GRP_ID = ! empty( $this->_req_data['GRP_ID'] ) ? $this->_req_data['GRP_ID'] : 0;
		$template_pack = ! empty( $this->_req_data['template_pack'] ) ? $this->_req_data['template_pack'] : '';

		//verify we have needed values.
		if ( empty( $GRP_ID ) || empty( $template_pack ) ) {
			$this->_template_args['error'] = true;
			EE_Error::add_error( __('The required date for switching templates is not available.', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__  );
		} else {
			//get template, set the new template_pack and then reset to default
			/** @type EE_Message_Template_Group $message_template_group */
			$message_template_group = EEM_Message_Template_Group::instance()->get_one_by_ID( $GRP_ID );

			$message_template_group->set_template_pack_name( $template_pack );
			$this->_req_data['msgr'] = $message_template_group->messenger();
			$this->_req_data['mt'] = $message_template_group->message_type();

			$query_args = $this->_reset_to_default_template();

			if ( empty( $query_args['id'] ) ) {
				EE_Error::add_error(
					__(
						'Something went wrong with switching the template pack. Please try again or contact EE support',
						'event_espresso'
					),
					__FILE__, __FUNCTION__, __LINE__
				);
				$this->_template_args['error'] = true;
			} else {
				$template_label =$message_template_group->get_template_pack()->label;
				$template_pack_labels = $message_template_group->messenger_obj()->get_supports_labels();
				EE_Error::add_success(
					sprintf(
						__(
							'This message template has been successfully switched to use the %1$s %2$s.  Please wait while the page reloads with your new template.',
							'event_espresso'
						),
						$template_label,
						$template_pack_labels->template_pack
					)
				);
				//generate the redirect url for js.
				$url = self::add_query_args_and_nonce( $query_args, $this->_admin_base_url );
				$this->_template_args['data']['redirect_url'] = $url;
				$this->_template_args['success'] = true;
			}

			$this->_return_json();

		}
	}



	/**
	 * This handles resetting the template for the given messenger/message_type so that users can start from scratch if
	 * they want.
	 *
	 * @access protected
	 * @return array|null
	 */
	protected function _reset_to_default_template() {

		$templates = array();
		$GRP_ID = !empty( $this->_req_data['GRP_ID'] ) ? $this->_req_data['GRP_ID'] : 0;
		//we need to make sure we've got the info we need.
		if ( ! isset( $this->_req_data['msgr'], $this->_req_data['mt'], $this->_req_data['GRP_ID'] ) ) {
			EE_Error::add_error(
				__(
					'In order to reset the template to its default we require the messenger, message type, and message template GRP_ID to know what is being reset.  At least one of these is missing.',
					'event_espresso'
				),
				__FILE__, __FUNCTION__, __LINE__
			);
		}

		// all templates will be reset to whatever the defaults are
		// for the global template matching the messenger and message type.
		$success = !empty( $GRP_ID ) ? true : false;

		if ( $success ) {

			//let's first determine if the incoming template is a global template,
			// if it isn't then we need to get the global template matching messenger and message type.
			//$MTPG = EEM_Message_Template_Group::instance()->get_one_by_ID( $GRP_ID );


			//note this is ONLY deleting the template fields (Message Template rows) NOT the message template group.
			$success = $this->_delete_mtp_permanently( $GRP_ID, false );

			if ( $success ) {
				// if successfully deleted, lets generate the new ones.
				// Note. We set GLOBAL to true, because resets on ANY template
				// will use the related global template defaults for regeneration.
				// This means that if a custom template is reset it resets to whatever the related global template is.
				// HOWEVER, we DO keep the template pack and template variation set
				// for the current custom template when resetting.
				$templates = $this->_generate_new_templates(
					$this->_req_data['msgr'],
					$this->_req_data['mt'],
					$GRP_ID,
					true
				);
			}

		}

		//any error messages?
		if ( !$success ) {
			EE_Error::add_error(
				__( 'Something went wrong with deleting existing templates. Unable to reset to default', 'event_espresso' ),
				__FILE__, __FUNCTION__, __LINE__
			);
		}

		//all good, let's add a success message!
		if ( $success && ! empty( $templates ) ) {
			$templates = $templates[0]; //the info for the template we generated is the first element in the returned array.
			EE_Error::overwrite_success();
			EE_Error::add_success( __('Templates have been reset to defaults.', 'event_espresso') );
		}


		$query_args = array(
			'id' => isset( $templates['GRP_ID'] ) ? $templates['GRP_ID'] : null,
			'context' => isset( $templates['MTP_context'] ) ? $templates['MTP_context'] : null,
			'action' => isset( $templates['GRP_ID'] ) ? 'edit_message_template' : 'global_mtps'
			);

		//if called via ajax then we return query args otherwise redirect
		if ( defined('DOING_AJAX') && DOING_AJAX ) {
			return $query_args;
		} else {
			$this->_redirect_after_action( false, '', '', $query_args, true );

false is of type boolean, but the function expects a integer.

			return null;
		}
	}



	/**
	 * Retrieve and set the message preview for display.
	 *
	 * @param bool $send if TRUE then we are doing an actual TEST send with the results of the preview.
	 * @return string
	 */
	public function _preview_message( $send = false ) {
		//first make sure we've got the necessary parameters
		if (
			! isset(
				$this->_req_data['message_type'],
				$this->_req_data['messenger'],
				$this->_req_data['messenger'],
				$this->_req_data['GRP_ID']
			)
		) {
			EE_Error::add_error(
				__('Missing necessary parameters for displaying preview', 'event_espresso'),
				__FILE__, __FUNCTION__, __LINE__
			);
		}

		EE_Registry::instance()->REQ->set( 'GRP_ID', $this->_req_data['GRP_ID'] );


		//get the preview!
		$preview = EED_Messages::preview_message( $this->_req_data['message_type'], $this->_req_data['context'], $this->_req_data['messenger'], $send );

		if ( $send ) {
			return $preview;
		}

		//let's add a button to go back to the edit view
		$query_args = array(
			'id' => $this->_req_data['GRP_ID'],
			'context' => $this->_req_data['context'],
			'action' => 'edit_message_template'
			);
		$go_back_url = parent::add_query_args_and_nonce( $query_args, $this->_admin_base_url );

It seems like you call parent on a different method (add_query_args_and_nonce() instead of _preview_message()). Are you sure this is correct? If so, you might want to change this to $this->add_query_args_and_nonce().

		$preview_button = '<a href="' . $go_back_url . '" class="button-secondary messages-preview-go-back-button">' . __('Go Back to Edit', 'event_espresso') . '</a>';
		$message_types = $this->get_installed_message_types();
		$active_messenger = $this->_message_resource_manager->get_active_messenger( $this->_req_data['messenger'] );
		$active_messenger_label = $active_messenger instanceof EE_messenger
			? ucwords( $active_messenger->label['singular'] )
			: esc_html__( 'Unknown Messenger', 'event_espresso' );
		//let's provide a helpful title for context
		$preview_title = sprintf(
			__( 'Viewing Preview for %s %s Message Template', 'event_espresso' ),
			$active_messenger_label,
			ucwords( $message_types[ $this->_req_data[ 'message_type' ] ]->label[ 'singular' ] )
		);
		//setup display of preview.
		$this->_admin_page_title = $preview_title;
		$this->_template_args['admin_page_content'] = $preview_button . '<br />' .stripslashes($preview);
		$this->_template_args['data']['force_json'] = true;
		return '';
	}




	/**
	 * The initial _preview_message is on a no headers route.  It will optionally call this if necessary otherwise it
	 * gets called automatically.
	 *
	 * @since 4.5.0
	 *
	 * @return string
	 */
	protected function _display_preview_message() {
		$this->display_admin_page_with_no_sidebar();
	}




	/**
	 * registers metaboxes that should show up on the "edit_message_template" page
	 *
	 * @access protected
	 * @return void
	 */
	protected function _register_edit_meta_boxes() {
		add_meta_box( 'mtp_valid_shortcodes', __('Valid Shortcodes', 'event_espresso'), array( $this, 'shortcode_meta_box' ), $this->_current_screen->id, 'side', 'default' );
		add_meta_box( 'mtp_extra_actions', __('Extra Actions', 'event_espresso'), array( $this, 'extra_actions_meta_box' ), $this->_current_screen->id, 'side', 'high' );
		add_meta_box( 'mtp_templates', __('Template Styles', 'event_espresso'), array( $this, 'template_pack_meta_box' ), $this->_current_screen->id, 'side', 'high' );
	}



	/**
	 * metabox content for all template pack and variation selection.
	 *
	 * @since 4.5.0
	 *
	 * @return string
	 */
	public function template_pack_meta_box() {
		$this->_set_message_template_group();

		$tp_collection = EEH_MSG_Template::get_template_pack_collection();

		$tp_select_values = array();

		foreach ( $tp_collection as $tp ) {
			//only include template packs that support this messenger and message type!
			$supports = $tp->get_supports();
			if (
				! isset( $supports[ $this->_message_template_group->messenger() ] )
				|| ! in_array(
					$this->_message_template_group->message_type(),
					$supports[ $this->_message_template_group->messenger() ]
				)
			) {
				//not supported
				continue;
			}

			$tp_select_values[] = array(
				'text' => $tp->label,
				'id' => $tp->dbref
				);
		}

		//if empty $tp_select_values then we make sure default is set because EVERY message type should be supported by the default template pack.  This still allows for the odd template pack to override.
		if ( empty( $tp_select_values ) ) {
			$tp_select_values[] = array(
				'text' => __('Default', 'event_espresso'),
				'id' => 'default'
			);
		}

		//setup variation select values for the currently selected template.
		$variations = $this->_message_template_group->get_template_pack()->get_variations(
			$this->_message_template_group->messenger(),
			$this->_message_template_group->message_type()
		);
		$variations_select_values = array();
		foreach ( $variations as $variation => $label ) {
			$variations_select_values[] = array(
				'text' => $label,
				'id' => $variation
			);
		}

		$template_pack_labels= $this->_message_template_group->messenger_obj()->get_supports_labels();

		$template_args['template_packs_selector'] = EEH_Form_Fields::select_input(

$template_args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $template_args = array(); before regardless.

			'MTP_template_pack',
			$tp_select_values,
			$this->_message_template_group->get_template_pack_name()
		);
		$template_args['variations_selector'] = EEH_Form_Fields::select_input(
			'MTP_template_variation',
			$variations_select_values,
			$this->_message_template_group->get_template_pack_variation()
		);
		$template_args['template_pack_label'] = $template_pack_labels->template_pack;
		$template_args['template_variation_label'] = $template_pack_labels->template_variation;
		$template_args['template_pack_description'] = $template_pack_labels->template_pack_description;
		$template_args['template_variation_description'] = $template_pack_labels->template_variation_description;

		$template = EE_MSG_TEMPLATE_PATH . 'template_pack_and_variations_metabox.template.php';

		EEH_Template::display_template( $template, $template_args );
	}



	/**
	 * This meta box holds any extra actions related to Message Templates
	 * For now, this includes Resetting templates to defaults and sending a test email.
	 *
	 * @access  public
	 * @return void
	 */
	public function extra_actions_meta_box() {
		$template_form_fields = array();

		$extra_args = array(
			'msgr' => $this->_message_template_group->messenger(),
			'mt' => $this->_message_template_group->message_type(),
			'GRP_ID' => $this->_message_template_group->GRP_ID()
			);

		$button = $this->get_action_link_or_button(
			'reset_to_default',
			'reset',
			$extra_args,
			'button-primary reset-default-button'
		);
		//test button
		//first we need to see if there are any fields
		$fields = $this->_message_template_group->messenger_obj()->get_test_settings_fields();

		if ( !empty( $fields ) ) {
			//yup there be fields
			foreach ( $fields as $field => $config ) {
				$field_id = $this->_message_template_group->messenger() . '_' . $field;
				$existing = $this->_message_template_group->messenger_obj()->get_existing_test_settings();
				$default = isset( $config['default'] ) ? $config['default'] : '';
				$default = isset( $config['value'] ) ? $config['value'] : $default;

				//if type is hidden and the value is empty something may have gone wrong so let's correct with the defaults
				$fix = $config['input'] == 'hidden' && isset($existing[$field]) && empty($existing[$field]) ? $default : '';
				$existing[$field] = isset( $existing[$field] ) && empty( $fix ) ? $existing[$field] : $fix;

				$template_form_fields[$field_id] = array(
					'name' => 'test_settings_fld[' . $field . ']',
					'label' => $config['label'],
					'input' => $config['input'],
					'type' => $config['type'],
					'required' => $config['required'],
					'validation' => $config['validation'],
					'value' => isset( $existing[$field] ) ? $existing[$field] : $default,
					'css_class' => $config['css_class'],
					'options' => isset( $config['options'] ) ? $config['options'] : array(),
					'default' => $default,
					'format' => $config['format']
					);
			}
		}

		$test_settings_fields = !empty( $template_form_fields)
			? $this->_generate_admin_form_fields( $template_form_fields, 'string', 'ee_tst_settings_flds' )

'ee_tst_settings_flds' is of type string, but the function expects a false|array.

			: '';

		$test_settings_html = '';
		//print out $test_settings_fields
		if ( !empty( $test_settings_fields ) ) {
			echo $test_settings_fields;
			$test_settings_html = '<input type="submit" class="button-primary mtp-test-button alignright" name="test_button" value="' . __('Test Send', 'event_espresso') . '" /><div style="clear:both"></div>';
		}

		//and button
		echo $test_settings_html . '<p>' . __('Need to reset this message type and start over?', 'event_espresso') . '</p>' . '<div class="publishing-action alignright resetbutton">' . $button . '</div><div style="clear:both"></div>';
	}




	/**
     * This returns the shortcode selector skeleton for a given context and field.
     *
     * @since 4.9.rc.000
     *
	 * @param string $field  The name of the field retrieving shortcodes for.
     * @param string $linked_input_id The css id of the input that the shortcodes get added to.
     * @return string
    */
	protected function _get_shortcode_selector( $field, $linked_input_id ) {
		$template_args = array(
			'shortcodes' => $this->_get_shortcodes( array( $field ), true ),
			'fieldname' => $field,
			'linked_input_id' => $linked_input_id
		);
		return EEH_Template::display_template( EE_MSG_TEMPLATE_PATH . 'shortcode_selector_skeleton.template.php', $template_args, true );
	}


	/**
	 * This just takes care of returning the meta box content for shortcodes (only used on the edit message template
	 * page)
	 *
	 * @access public
	 * @return void
	 */
	public function shortcode_meta_box() {
		$shortcodes = $this->_get_shortcodes(array(), false); //just make sure shortcodes property is set
		//$messenger = $this->_message_template_group->messenger_obj();
		//now let's set the content depending on the status of the shortcodes array
		if ( empty( $shortcodes ) ) {
			$content = '<p>' . __('There are no valid shortcodes available', 'event_espresso') . '</p>';
			echo $content;
		} else {
			//$alt = 0;
			?>
			<div style="float:right; margin-top:10px"><?php echo $this->_get_help_tab_link('message_template_shortcodes'); ?></div><p class="small-text"><?php printf( __('You can view the shortcodes usable in your template by clicking the %s icon next to each field.', 'event_espresso' ), '<span class="dashicons dashicons-menu"></span>' ); ?></p>
			<?php
		}


	}


	/**
	 * used to set the $_shortcodes property for when its needed elsewhere.
	 *
	 * @access protected
	 * @return void
	 */
	protected function _set_shortcodes() {

		//no need to run this if the property is already set
		if ( !empty($this->_shortcodes ) ) {return;}

		$this->_shortcodes = $this->_get_shortcodes();
	}





	/**
	 * get's all shortcodes for a given template group. (typically used by _set_shortcodes to set the $_shortcodes
	 * property)
	 *
	 * @access  protected
	 *
	 * @param  array   $fields include an array of specific field names that you want to be used to get the shortcodes for.
	 *                        Defaults to all (for the given context)
	 * @param  boolean $merged Whether to merge all the shortcodes into one list of unique shortcodes
	 *
	 * @return array          Shortcodes indexed by fieldname and the an array of shortcode/label pairs OR if merged is true
	 *                       just an array of shortcode/label pairs.
	 */
	protected function _get_shortcodes( $fields = array(), $merged = true ) {
		$this->_set_message_template_group();

		//we need the messenger and message template to retrieve the valid shortcodes array.
		$GRP_ID = isset( $this->_req_data['id'] ) && !empty( $this->_req_data['id'] ) ? absint( $this->_req_data['id'] ) : false;
		$context = isset( $this->_req_data['context'] ) ? $this->_req_data['context'] : key( $this->_message_template_group->contexts_config() );

		return !empty($GRP_ID) ? $this->_message_template_group->get_shortcodes( $context, $fields, $merged ) : array();
	}



	/**
	 * This sets the _message_template property (containing the called message_template object)
	 *
	 * @access protected
	 * @return  void
	 */
	protected function _set_message_template_group() {

		if ( !empty( $this->_message_template_group ) )
			{return;} //get out if this is already set.

		$GRP_ID =  ! empty( $this->_req_data['GRP_ID'] ) ? absint( $this->_req_data['GRP_ID'] ) : false;
		$GRP_ID = empty( $GRP_ID ) && ! empty( $this->_req_data['id'] ) ? $this->_req_data['id'] : $GRP_ID;

		//let's get the message templates
		$MTP = EEM_Message_Template_Group::instance();

		if ( empty($GRP_ID) )
			{$this->_message_template_group = $MTP->create_default_object();}

It seems like $MTP->create_default_object() can also be of type object<EE_Base_Class>. However, the property $_message_template_group is declared as type object<EE_Message_Template_Group>. Maybe add an additional type check?

		else
			{$this->_message_template_group = $MTP->get_one_by_ID( $GRP_ID );}

It seems like $MTP->get_one_by_ID($GRP_ID) can also be of type object<EE_Base_Class>. However, the property $_message_template_group is declared as type object<EE_Message_Template_Group>. Maybe add an additional type check?

		$this->_template_pack = $this->_message_template_group->get_template_pack();

The method get_template_pack does not exist on object<EE_Base_Class>? Since you implemented __call, maybe consider adding a @method annotation.

		$this->_variation = $this->_message_template_group->get_template_pack_variation();

The method get_template_pack_variation does not exist on object<EE_Base_Class>? Since you implemented __call, maybe consider adding a @method annotation.

	}




	/**
	 * sets up a context switcher for edit forms
	 *
	 * @access  protected
	 *
	 * @param  EE_Message_Template_Group $template_group_object the template group object being displayed on the form
	 * @param array $args various things the context switcher needs.
	 *
	 */
	protected function _set_context_switcher( EE_Message_Template_Group $template_group_object, $args) {
		$context_details = $template_group_object->contexts_config();
		$context_label = $template_group_object->context_label();
		ob_start();
		?>
		<div class="ee-msg-switcher-container">
			<form method="get" action="<?php echo EE_MSG_ADMIN_URL; ?>" id="ee-msg-context-switcher-frm">
				<?php
					foreach ( $args as $name => $value ) {
						if ( $name == 'context' || empty($value) || $name == 'extra' ) {continue;}
						?>
						<input type="hidden" name="<?php echo $name; ?>" value = "<?php echo $value; ?>" />
						<?php
					}
					//setup nonce_url
					wp_nonce_field($args['action'] . '_nonce', $args['action'] . '_nonce', false);
				?>
				<select name="context">
					<?php
					$context_templates = $template_group_object->context_templates();
					if ( is_array($context_templates) ) :
							foreach ( $context_templates as $context => $template_fields ) :
								$checked = ($context == $args['context']) ? 'selected="selected"' : '';
					?>
					<option value="<?php echo $context; ?>" <?php echo $checked; ?>>
						<?php echo $context_details[$context]['label']; ?>
					</option>
					<?php endforeach; endif; ?>
				</select>
				<?php $button_text = sprintf( __('Switch %s', 'event_espresso'), ucwords($context_label['label']) ); ?>
				<input id="submit-msg-context-switcher-sbmt" class="button-secondary" type="submit" value="<?php echo $button_text; ?>">
			</form>
			<?php echo $args['extra']; ?>
		</div> <!-- end .ee-msg-switcher-container -->
		<?php
		$output = ob_get_contents();
		ob_clean();
		$this->_context_switcher = $output;
	}






	/**
	 * utility for sanitizing new values coming in.
	 * Note: this is only used when updating a context.
	 *
	 * @access protected
	 *
	 * @param int $index This helps us know which template field to select from the request array.
	 *
	 * @return array
	 */
	protected function _set_message_template_column_values($index) {
		if ( is_array($this->_req_data['MTP_template_fields'][$index]['content'] ) ) {
			foreach ( $this->_req_data['MTP_template_fields'][$index]['content'] as $field => $value ) {

The expression $this->_req_data['MTP_template_fields'][$index]['content'] of type string is not traversable.

				$this->_req_data['MTP_template_fields'][$index]['content'][$field] = $value;
			}
		} /*else {
			$this->_req_data['MTP_template_fields'][$index]['content'] = $this->_req_data['MTP_template_fields'][$index]['content'];
		}*/


		$set_column_values = array(
			'MTP_ID'             => absint( $this->_req_data[ 'MTP_template_fields' ][ $index ][ 'MTP_ID' ] ),
			'GRP_ID'             => absint( $this->_req_data[ 'GRP_ID' ] ),
			'MTP_user_id'        => absint( $this->_req_data[ 'MTP_user_id' ] ),
			'MTP_messenger'      => strtolower( $this->_req_data[ 'MTP_messenger' ] ),
			'MTP_message_type'   => strtolower( $this->_req_data[ 'MTP_message_type' ] ),
			'MTP_template_field' => strtolower( $this->_req_data[ 'MTP_template_fields' ][ $index ][ 'name' ] ),
			'MTP_context'        => strtolower( $this->_req_data[ 'MTP_context' ] ),
			'MTP_content'        => $this->_req_data[ 'MTP_template_fields' ][ $index ][ 'content' ],
			'MTP_is_global'      => isset( $this->_req_data[ 'MTP_is_global' ] )
				? absint( $this->_req_data[ 'MTP_is_global' ] )
				: 0,
			'MTP_is_override'    => isset( $this->_req_data[ 'MTP_is_override' ] )
				? absint( $this->_req_data[ 'MTP_is_override' ] )
				: 0,
			'MTP_deleted'        => absint( $this->_req_data[ 'MTP_deleted' ] ),
			'MTP_is_active'      => absint( $this->_req_data[ 'MTP_is_active' ] )
		);


		return $set_column_values;
	}






	protected function _insert_or_update_message_template($new = false ) {

		do_action ( 'AHEE_log', __FILE__, __FUNCTION__, '');
		$success = 0;
		$override = false;

		//setup notices description
		$messenger = ! empty( $this->_req_data['MTP_messenger'] )
			? ucwords( str_replace( '_', ' ', $this->_req_data['MTP_messenger'] ) )
			: false;

		$message_type = ! empty( $this->_req_data['MTP_message_type'] )
			? ucwords( str_replace( '_', ' ', $this->_req_data['MTP_message_type'] ) )
			: false;

		$context = ! empty( $this->_req_data['MTP_context'] )
			? ucwords( str_replace( '_', ' ', $this->_req_data['MTP_context'] ) )
			: false;

		$item_desc = $messenger ? $messenger . ' ' . $message_type . ' ' . $context . ' ' : '';
		$item_desc .= 'Message Template';
		$query_args = array();
		$edit_array = array();
		$action_desc = '';

		//if this is "new" then we need to generate the default contexts for the selected messenger/message_type for user to edit.
		if ( $new ) {
			$GRP_ID = !empty( $this->_req_data['GRP_ID'] ) ? $this->_req_data['GRP_ID'] : 0;
			if ( $edit_array = $this->_generate_new_templates($messenger, $message_type, $GRP_ID ) ) {

It seems like $messenger defined by !empty($this->_req_data['MTP_messenger']) ? ucwords(str_replace('_', ' ', $this->_req_data['MTP_messenger'])) : false on line 2118 can also be of type false; however, Messages_Admin_Page::_generate_new_templates() does only seem to accept string, did you maybe forget to handle an error condition?

$message_type is of type string|false, but the function expects a array.

				if ( empty($edit_array) ) {
					$success = 0;
				} else {
					$success = 1;
					$edit_array = $edit_array[0];
					$query_args = array(
						'id' => $edit_array['GRP_ID'],
						'context' => $edit_array['MTP_context'],
						'action' => 'edit_message_template'
						);
				}
			}
			$action_desc = 'created';
		} else {
			$MTPG = EEM_Message_Template_Group::instance();
			$MTP = EEM_Message_Template::instance();


			//run update for each template field in displayed context
			if ( !isset($this->_req_data['MTP_template_fields']) && empty($this->_req_data['MTP_template_fields'] ) ) {
				EE_Error::add_error(
					__('There was a problem saving the template fields from the form because I didn\'t receive any actual template field data.', 'event_espresso'),
					__FILE__, __FUNCTION__, __LINE__
				);
				$success = 0;

			} else {
				//first validate all fields!
				$validates = $MTPG->validate($this->_req_data['MTP_template_fields'], $this->_req_data['MTP_context'],  $this->_req_data['MTP_messenger'], $this->_req_data['MTP_message_type']);

$this->_req_data['MTP_template_fields'] is of type string, but the function expects a array.

				//if $validate returned error messages (i.e. is_array()) then we need to process them and setup an appropriate response. HMM, dang this isn't correct, $validates will ALWAYS be an array.  WE need to make sure there is no actual error messages in validates.
				if ( is_array($validates) && !empty($validates) ) {
					//add the transient so when the form loads we know which fields to highlight
					$this->_add_transient( 'edit_message_template', $validates );

					$success = 0;

					//setup notices
					foreach ( $validates as $field => $error ) {
						if ( isset($error['msg'] ) ) {
							EE_Error::add_error( $error['msg'], __FILE__, __FUNCTION__, __LINE__ );
						}
					}

				} else {
					$set_column_values = array();
					foreach ( $this->_req_data['MTP_template_fields'] as $template_field => $content ) {

The expression $this->_req_data['MTP_template_fields'] of type string is not traversable.

						$set_column_values = $this->_set_message_template_column_values($template_field);

						$where_cols_n_values = array(
							'MTP_ID' => $this->_req_data['MTP_template_fields'][$template_field]['MTP_ID']
						);

						$message_template_fields = array(
							'GRP_ID' => $set_column_values['GRP_ID'],
							'MTP_template_field' => $set_column_values['MTP_template_field'],
							'MTP_context' => $set_column_values['MTP_context'],
							'MTP_content' => $set_column_values['MTP_content']
						);
						if ( $updated = $MTP->update( $message_template_fields, array( $where_cols_n_values ) ) ) {
							if ( $updated === false ) {
								EE_Error::add_error(
									sprintf(
										__( '%s field was NOT updated for some reason', 'event_espresso' ),
										$template_field
									),
									__FILE__, __FUNCTION__, __LINE__
								);
							} else {
								$success = 1;
							}
						}
						$action_desc = 'updated';
					}

					//we can use the last set_column_values for the MTPG update (because its the same for all of these specific MTPs)
					$mtpg_fields = array(
						'MTP_user_id'      => $set_column_values[ 'MTP_user_id' ],
						'MTP_messenger'    => $set_column_values[ 'MTP_messenger' ],
						'MTP_message_type' => $set_column_values[ 'MTP_message_type' ],
						'MTP_is_global'    => $set_column_values[ 'MTP_is_global' ],
						'MTP_is_override'  => $set_column_values[ 'MTP_is_override' ],
						'MTP_deleted'      => $set_column_values[ 'MTP_deleted' ],
						'MTP_is_active'    => $set_column_values[ 'MTP_is_active' ],
						'MTP_name'         => ! empty( $this->_req_data[ 'ee_msg_non_global_fields' ][ 'MTP_name' ] )
							? $this->_req_data[ 'ee_msg_non_global_fields' ][ 'MTP_name' ]
							: '',
						'MTP_description'  => ! empty( $this->_req_data[ 'ee_msg_non_global_fields' ][ 'MTP_description' ] )
							? $this->_req_data[ 'ee_msg_non_global_fields' ][ 'MTP_description' ]
							: ''
					);

					$mtpg_where = array('GRP_ID' => $set_column_values['GRP_ID'] );
					$updated = $MTPG->update( $mtpg_fields, array($mtpg_where) );

					if ( $updated === false ) {
						EE_Error::add_error(
							sprintf(
								__( 'The Message Template Group (%d) was NOT updated for some reason', 'event_espresso' ),
								$set_column_values[ 'GRP_ID' ]
							),
							__FILE__, __FUNCTION__, __LINE__
						);
					} else {
						//k now we need to ensure the template_pack and template_variation fields are set.
						$template_pack = ! empty( $this->_req_data['MTP_template_pack' ] )
							? $this->_req_data['MTP_template_pack']
							: 'default';

						$template_variation = ! empty( $this->_req_data['MTP_template_variation'] )
							? $this->_req_data['MTP_template_variation']
							: 'default';

						$mtpg_obj = $MTPG->get_one_by_ID( $set_column_values['GRP_ID'] );
						if ( $mtpg_obj instanceof EE_Message_Template_Group ) {
							$mtpg_obj->set_template_pack_name( $template_pack );
							$mtpg_obj->set_template_pack_variation( $template_variation );
						}
						$success = 1;
					}
				}
			}

		}

		//we return things differently if doing ajax
		if ( defined('DOING_AJAX') && DOING_AJAX ) {
			$this->_template_args['success'] = $success;
			$this->_template_args['error'] = ! $success ? true : false;
			$this->_template_args['content'] = '';
			$this->_template_args['data'] = array(
				'grpID' => $edit_array['GRP_ID'],
				'templateName' => $edit_array['template_name']
				);
			if ( $success ) {
				EE_Error::overwrite_success();
				EE_Error::add_success( __('The new template has been created and automatically selected for this event.  You can edit the new template by clicking the edit button.  Note before this template is assigned to this event, the event must be saved.', 'event_espresso') );
			}

			$this->_return_json();
		}


		//was a test send triggered?
		if ( isset( $this->_req_data['test_button'] ) ) {
			EE_Error::overwrite_success();
			$this->_do_test_send( $this->_req_data['MTP_context'],  $this->_req_data['MTP_messenger'], $this->_req_data['MTP_message_type'] );
			$override = true;
		}

		if ( empty( $query_args ) ) {
			$query_args = array(
				'id' => $this->_req_data['GRP_ID'],
				'context' => $this->_req_data['MTP_context'],
				'action' => 'edit_message_template'
				);
		}

		$this->_redirect_after_action( $success, $item_desc, $action_desc, $query_args, $override );
	}




	/**
	 * processes a test send request to do an actual messenger delivery test for the given message template being tested
	 *
	 * @param  string $context      what context being tested
	 * @param  string $messenger  	messenger being tested
	 * @param  string $message_type message type being tested
	 *
	 */
	protected function _do_test_send( $context, $messenger, $message_type ) {
		//set things up for preview
		$this->_req_data['messenger'] = $messenger;
		$this->_req_data['message_type'] = $message_type;
		$this->_req_data['context'] = $context;
		$this->_req_data['GRP_ID'] = isset($this->_req_data['GRP_ID'] ) ? $this->_req_data['GRP_ID'] : '';
		$active_messenger = $this->_message_resource_manager->get_active_messenger( $messenger );

		//let's save any existing fields that might be required by the messenger
		if (
			isset( $this->_req_data['test_settings_fld'] )
			&& $active_messenger instanceof EE_messenger
		) {
			$active_messenger->set_existing_test_settings( $this->_req_data['test_settings_fld'] );
		}

		$success = $this->_preview_message(true);

		if ( $success ) {
			EE_Error::add_success( __('Test message sent', 'event_espresso') );
		} else {
			EE_Error::add_error( __('The test message was not sent', 'event_espresso' ), __FILE__, __FUNCTION__, __LINE__ );
		}
	}



	/**
	 * _generate_new_templates
	 * This will handle the messenger, message_type selection when "adding a new custom template" for an event and will
	 * automatically create the defaults for the event.  The user would then be redirected to edit the default context
	 * for the event.
	 *
	 *
	 * @param  string $messenger     the messenger we are generating templates for
	 * @param array   $message_types array of message types that the templates are generated for.
	 * @param int     $GRP_ID        If this is a custom template being generated then a GRP_ID needs to be included to indicate
	 *                               the message_template_group being used as the base.
	 *
	 * @param bool    $global
	 * @return array|bool array of data required for the redirect to the correct edit page or bool if
	 *                               encountering problems.
	 * @throws \EE_Error
	 */
	protected function _generate_new_templates($messenger, $message_types, $GRP_ID = 0, $global = false) {

		//if no $message_types are given then that's okay... this may be a messenger that just adds shortcodes, so we just don't generate any templates.
		if ( empty( $message_types ) ) {
			return true;
		}

		return EEH_MSG_Template::generate_new_templates( $messenger, $message_types, $GRP_ID, $global );
	}





	/**
	 * [_trash_or_restore_message_template]
	 *
	 * @param  boolean $trash whether to move an item to trash/restore (TRUE) or restore it (FALSE)
	 * @param boolean $all whether this is going to trash/restore all contexts within a template group (TRUE) OR just
	 *                     an individual context (FALSE).
	 *
	 * @return void
	 */
	protected function _trash_or_restore_message_template($trash = true, $all = false ) {
		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
		$MTP = EEM_Message_Template_Group::instance();

		$success = 1;

		//incoming GRP_IDs
		if ( $all ) {
			//Checkboxes
			if ( !empty( $this->_req_data['checkbox'] ) && is_array($this->_req_data['checkbox'] ) ) {
				//if array has more than one element then success message should be plural.
				//todo: what about nonce?
				$success = count( $this->_req_data['checkbox'] ) > 1 ? 2 : 1;

				//cycle through checkboxes
				while ( list( $GRP_ID, $value ) = each ($this->_req_data['checkbox']) ) {

The assignment to $value is unused. Consider omitting it like so list($first,,$third).

					$trashed_or_restored = $trash ? $MTP->delete_by_ID( $GRP_ID ) : $MTP->restore_by_ID( $GRP_ID );
					if ( ! $trashed_or_restored ) {
						$success = 0;
					}
				}
			} else {
				//grab single GRP_ID and handle
				$GRP_ID = isset( $this->_req_data['id'] ) ? absint($this->_req_data['id']) : 0;
				if ( ! empty( $GRP_ID ) ) {
					$trashed_or_restored = $trash ? $MTP->delete_by_ID( $GRP_ID ) : $MTP->restore_by_ID( $GRP_ID );
					if ( ! $trashed_or_restored ) {
						$success = 0;
					}
				} else {
					$success = 0;
				}
			}

		}

		$action_desc = $trash ? __('moved to the trash', 'event_espresso') : __('restored', 'event_espresso');

		$action_desc = !empty( $this->_req_data['template_switch'] ) ? __('switched') : $action_desc;

		$item_desc = $all ? _n('Message Template Group', 'Message Template Groups', $success, 'event_espresso') : _n('Message Template Context', 'Message Template Contexts', $success, 'event_espresso');

		$item_desc = !empty( $this->_req_data['template_switch'] ) ? _n('template', 'templates', $success, 'event_espresso') : $item_desc;

		$this->_redirect_after_action( $success, $item_desc, $action_desc, array() );

	}







	/**
	 * [_delete_message_template]
	 * NOTE: this handles not only the deletion of the groups but also all the templates belonging to that group.
	 * @return void
	 */
	protected function _delete_message_template() {
		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );

		//checkboxes
		if ( !empty($this->_req_data['checkbox']) && is_array($this->_req_data['checkbox'] ) ) {
			//if array has more than one element then success message should be plural
			$success = count( $this->_req_data['checkbox'] ) > 1 ? 2 : 1;

			//cycle through bulk action checkboxes
			while ( list( $GRP_ID, $value ) = each($this->_req_data['checkbox'] ) ) {

The assignment to $value is unused. Consider omitting it like so list($first,,$third).

				$success = $this->_delete_mtp_permanently( $GRP_ID );
			}
		} else {
			//grab single grp_id and delete
			$GRP_ID = absint($this->_req_data['id'] );
			$success = $this->_delete_mtp_permanently( $GRP_ID );
		}

		$this->_redirect_after_action( $success, 'Message Templates', 'deleted', array() );

	}




	/**
	 * helper for permanently deleting a mtP group and all related message_templates
	 *
	 * @param  int    $GRP_ID The group being deleted
	 * @param  bool $include_group whether to delete the Message Template Group as well.
	 *
	 * @return bool        boolean to indicate the success of the deletes or not.
	 */
	private function _delete_mtp_permanently( $GRP_ID, $include_group = true ) {
		$success = 1;
		$MTPG = EEM_Message_Template_Group::instance();
		//first let's GET this group
		$MTG = $MTPG->get_one_by_ID( $GRP_ID );
		//then delete permanently all the related Message Templates
		$deleted = $MTG->delete_related_permanently( 'Message_Template' );

		if ( $deleted === 0 )
			{$success = 0;}

		//now delete permanently this particular group

		if ( $include_group && ! $MTG->delete_permanently() ) {
			$success = 0;
		}
		return $success;
	}







	/**
	 * 	_learn_more_about_message_templates_link
	*	@access protected
	*	@return string
	*/
	protected function _learn_more_about_message_templates_link() {
		return '<a class="hidden" style="margin:0 20px; cursor:pointer; font-size:12px;" >' . __('learn more about how message templates works', 'event_espresso') . '</a>';
	}






	/**
	 * Used for setting up messenger/message type activation.  This loads up the initial view.  The rest is handled by
	 * ajax and other routes.
	 * @return void
	 */
	protected function _settings() {


		$this->_set_m_mt_settings();

		$selected_messenger = isset( $this->_req_data['selected_messenger'] ) ? $this->_req_data['selected_messenger'] : 'email';

		//let's setup the messenger tabs
		$this->_template_args['admin_page_header'] = EEH_Tabbed_Content::tab_text_links( $this->_m_mt_settings['messenger_tabs'], 'messenger_links', '|', $selected_messenger );
		$this->_template_args['before_admin_page_content'] = '<div class="ui-widget ui-helper-clearfix">';
		$this->_template_args['after_admin_page_content'] = '</div><!-- end .ui-widget -->';

		$this->display_admin_page_with_sidebar();

	}




	/**
	 * This sets the $_m_mt_settings property for when needed (used on the Messages settings page)
	 *
	 * @access protected
	 * @return void
	 */
	protected function _set_m_mt_settings() {
		//first if this is already set then lets get out no need to regenerate data.
		if ( !empty($this->_m_mt_settings) ) {
			return;
		}

		//$selected_messenger = isset( $this->_req_data['selected_messenger'] ) ? $this->_req_data['selected_messenger'] : 'email';

		//get all installed messengers and message_types
		/** @type EE_messenger[] $messengers */
		$messengers = $this->_message_resource_manager->installed_messengers();
		/** @type EE_message_type[] $message_types */
		$message_types = $this->_message_resource_manager->installed_message_types();


		//assemble the array for the _tab_text_links helper

		foreach ( $messengers as $messenger ) {
			$this->_m_mt_settings['messenger_tabs'][$messenger->name] = array(
				'label' => ucwords($messenger->label['singular']),
				'class' => $this->_message_resource_manager->is_messenger_active( $messenger->name ) ? 'messenger-active' : '',
				'href' => $messenger->name,
				'title' => __('Modify this Messenger', 'event_espresso'),
				'slug' => $messenger->name,
				'obj' => $messenger
			);


			$message_types_for_messenger = $messenger->get_valid_message_types();

			foreach ( $message_types as $message_type ) {
				//first we need to verify that this message type is valid with this messenger. Cause if it isn't then it shouldn't show in either the inactive OR active metabox.
				if ( ! in_array( $message_type->name, $message_types_for_messenger ) ) {
					continue;
				}

				$a_or_i = $this->_message_resource_manager->is_message_type_active_for_messenger( $messenger->name, $message_type->name ) ? 'active' : 'inactive';

				$this->_m_mt_settings['message_type_tabs'][$messenger->name][$a_or_i][$message_type->name] = array(
					'label'    => ucwords( $message_type->label[ 'singular' ] ),
					'class'    => 'message-type-' . $a_or_i,
					'slug_id'  => $message_type->name . '-messagetype-' . $messenger->name,
					'mt_nonce' => wp_create_nonce( $message_type->name . '_nonce' ),
					'href'     => 'espresso_' . $message_type->name . '_message_type_settings',
					'title'    => $a_or_i == 'active'
						? __( 'Drag this message type to the Inactive window to deactivate', 'event_espresso' )
						: __( 'Drag this message type to the messenger to activate', 'event_espresso' ),
					'content'  => $a_or_i == 'active'
						? $this->_message_type_settings_content( $message_type, $messenger, true )
						: $this->_message_type_settings_content( $message_type, $messenger ),
					'slug'     => $message_type->name,
					'active'   => $a_or_i == 'active' ? true : false,
					'obj'      => $message_type
				);
			}
		}
	}


	/**
	 * This just prepares the content for the message type settings
	 *
	 * @param  object  $message_type The message type object
	 * @param  object  $messenger    The messenger object
	 * @param  boolean $active       Whether the message type is active or not
	 *
	 * @return string                html output for the content
	 */
	protected function _message_type_settings_content( $message_type, $messenger, $active = false ) {
		//get message type fields
		$fields = $message_type->get_admin_settings_fields();
		$settings_template_args['template_form_fields']= '';

$settings_template_args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $settings_template_args = array(); before regardless.

		if ( !empty( $fields ) && $active ) {

			$existing_settings = $message_type->get_existing_admin_settings( $messenger->name );

			foreach( $fields as $fldname => $fldprops ) {
				$field_id = $messenger->name . '-' . $message_type->name . '-' . $fldname;
				$template_form_field[$field_id] = array(

$template_form_field was never initialized. Although not strictly required by PHP, it is generally a good practice to add $template_form_field = array(); before regardless.

					'name' => 'message_type_settings[' . $fldname . ']',
					'label' => $fldprops['label'],
					'input' => $fldprops['field_type'],
					'type' => $fldprops['value_type'],
					'required' => $fldprops['required'],
					'validation' => $fldprops['validation'],
					'value' => isset( $existing_settings[$fldname]) ? $existing_settings[$fldname] : $fldprops['default'],
					'options' => isset( $fldprops['options'] ) ? $fldprops['options'] : array(),
					'default' => isset( $existing_settings[$fldname] ) ? $existing_settings[$fldname] : $fldprops['default'],
					'css_class' => 'no-drag',
					'format' => $fldprops['format']
				);
			}


			$settings_template_args['template_form_fields'] = !empty($template_form_field) ? $this->_generate_admin_form_fields( $template_form_field, 'string', 'ee_mt_activate_form' ) : '';

'ee_mt_activate_form' is of type string, but the function expects a false|array.

		}

		$settings_template_args['description'] = $message_type->description;
		//we also need some hidden fields
			$settings_template_args['hidden_fields'] = array(
				'message_type_settings[messenger]' => array(
					'type' => 'hidden',
					'value' => $messenger->name
					),
				'message_type_settings[message_type]' => array(
					'type' => 'hidden',
					'value' => $message_type->name
					),
				'type' => array(
					'type' => 'hidden',
					'value' => 'message_type'
					)
				);

		$settings_template_args['hidden_fields'] = $this->_generate_admin_form_fields( $settings_template_args['hidden_fields'], 'array' );
		$settings_template_args['show_form'] = empty( $settings_template_args['template_form_fields'] ) ? ' hidden' : '';



		$template = EE_MSG_TEMPLATE_PATH . 'ee_msg_mt_settings_content.template.php';
		$content = EEH_Template::display_template( $template, $settings_template_args, true );
		return $content;
	}



	/**
	 * Generate all the metaboxes for the message types and register them for the messages settings page.
	 *
	 * @access protected
	 * @return void
	 */
	protected function _messages_settings_metaboxes() {
		$this->_set_m_mt_settings();
		$m_boxes = $mt_boxes = array();
		$m_template_args = $mt_template_args = array();

		$selected_messenger = isset( $this->_req_data['selected_messenger'] ) ? $this->_req_data['selected_messenger'] : 'email';

		if ( isset( $this->_m_mt_settings[ 'messenger_tabs' ] ) ) {
			foreach ( $this->_m_mt_settings[ 'messenger_tabs' ] as $messenger => $tab_array ) {
				$hide_on_message = $this->_message_resource_manager->is_messenger_active( $messenger ) ? '' : 'hidden';
				$hide_off_message = $this->_message_resource_manager->is_messenger_active( $messenger ) ? 'hidden' : '';
				//messenger meta boxes
				$active = $selected_messenger == $messenger ? true : false;
				$active_mt_tabs = isset( $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'active' ] )
				? $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'active' ]
				: '';
				$m_boxes[ $messenger . '_a_box' ] = sprintf(
				__( '%s Settings', 'event_espresso' ),
				$tab_array[ 'label' ]
				);
				$m_template_args[ $messenger . '_a_box' ] = array(
				'active_message_types'   => ! empty( $active_mt_tabs ) ? $this->_get_mt_tabs( $active_mt_tabs ) : '',
				'inactive_message_types' => isset( $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'inactive' ] )
				? $this->_get_mt_tabs( $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'inactive' ] )
				: '',
				'content'                => $this->_get_messenger_box_content( $tab_array[ 'obj' ] ),
				'hidden'                 => $active ? '' : ' hidden',
				'hide_on_message'        => $hide_on_message,
				'messenger'              => $messenger,
				'active'                 => $active
				);
				// message type meta boxes
				// (which is really just the inactive container for each messenger
				// showing inactive message types for that messenger)
				$mt_boxes[ $messenger . '_i_box' ] = __( 'Inactive Message Types', 'event_espresso' );
				$mt_template_args[ $messenger . '_i_box' ] = array(
				'active_message_types'   => ! empty( $active_mt_tabs ) ? $this->_get_mt_tabs( $active_mt_tabs ) : '',
				'inactive_message_types' => isset( $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'inactive' ] )
				? $this->_get_mt_tabs( $this->_m_mt_settings[ 'message_type_tabs' ][ $messenger ][ 'inactive' ] )
				: '',
				'hidden'                 => $active ? '' : ' hidden',
				'hide_on_message'        => $hide_on_message,
				'hide_off_message'       => $hide_off_message,
				'messenger'              => $messenger,
				'active'                 => $active
				);
			}
		}


		//register messenger metaboxes
		$m_template_path = EE_MSG_TEMPLATE_PATH . 'ee_msg_details_messenger_mt_meta_box.template.php';
		foreach ( $m_boxes as $box => $label ) {
			$callback_args = array( 'template_path' => $m_template_path, 'template_args' => $m_template_args[$box] );
			$msgr = str_replace( '_a_box', '', $box );
			add_meta_box(
				'espresso_' . $msgr . '_settings',
				$label,
				create_function(

The use of create_function is highly discouraged, better use a closure.

					'$post, $metabox',
					'echo EEH_Template::display_template( $metabox["args"]["template_path"], $metabox["args"]["template_args"], TRUE );'
				),
				$this->_current_screen_id,

The property _current_screen_id does not seem to exist. Did you mean _current_screen?

				'normal',
				'high',
				$callback_args
			);
		}

		//register message type metaboxes
		$mt_template_path = EE_MSG_TEMPLATE_PATH . 'ee_msg_details_messenger_meta_box.template.php';
		foreach ( $mt_boxes as $box => $label ) {
			$callback_args = array(
				'template_path' => $mt_template_path, 'template_args' => $mt_template_args[ $box ]
			);
			$mt = str_replace( '_i_box', '', $box );
			add_meta_box(
				'espresso_' . $mt . '_inactive_mts',
				$label,
				create_function(

The use of create_function is highly discouraged, better use a closure.

					'$post, $metabox',
					'echo EEH_Template::display_template( $metabox["args"]["template_path"], $metabox["args"]["template_args"], TRUE );'
				),
				$this->_current_screen_id,

The property _current_screen_id does not seem to exist. Did you mean _current_screen?

				'side',
				'high',
				$callback_args
			);
		}

	}


	/**
	 * this prepares the messenger tabs that can be dragged in and out of messenger boxes to activate/deactivate
	 *
	 * @param  array $tab_array  This is an array of message type tab details used to generate the tabs
	 *
	 * @return string            html formatted tabs
	 */
	protected function _get_mt_tabs( $tab_array ) {
		$tab_array = (array) $tab_array;
		$template = EE_MSG_TEMPLATE_PATH . 'ee_msg_details_mt_settings_tab_item.template.php';
		$tabs = '';

		foreach ( $tab_array as $tab ) {
			$tabs .=  EEH_Template::display_template( $template, $tab, true );
		}

		return $tabs;
	}




	/**
	 * This prepares the content of the messenger meta box admin settings
	 *
	 * @param  EE_messenger $messenger The messenger we're setting up content for
	 *
	 * @return string            html formatted content
	 */
	protected function _get_messenger_box_content( EE_messenger $messenger ) {

		$fields = $messenger->get_admin_settings_fields();
		$settings_template_args['template_form_fields'] = '';

$settings_template_args was never initialized. Although not strictly required by PHP, it is generally a good practice to add $settings_template_args = array(); before regardless.

		//is $messenger active?
		$settings_template_args['active'] = $this->_message_resource_manager->is_messenger_active( $messenger->name );


		if ( ! empty( $fields ) ) {

			$existing_settings = $messenger->get_existing_admin_settings();

			foreach( $fields as $fldname => $fldprops ) {
				$field_id = $messenger->name . '-' . $fldname;
				$template_form_field[$field_id] = array(

$template_form_field was never initialized. Although not strictly required by PHP, it is generally a good practice to add $template_form_field = array(); before regardless.

					'name' => 'messenger_settings[' . $field_id . ']',
					'label' => $fldprops['label'],
					'input' => $fldprops['field_type'],
					'type' => $fldprops['value_type'],
					'required' => $fldprops['required'],
					'validation' => $fldprops['validation'],
					'value' => isset( $existing_settings[$field_id])
						? $existing_settings[$field_id]
						: $fldprops['default'],
					'css_class' => '',
					'format' => $fldprops['format']
					);
			}


			$settings_template_args['template_form_fields'] = !empty($template_form_field)
				? $this->_generate_admin_form_fields( $template_form_field, 'string', 'ee_m_activate_form' )

'ee_m_activate_form' is of type string, but the function expects a false|array.

				: '';
		}

		//we also need some hidden fields
		$settings_template_args['hidden_fields'] = array(
			'messenger_settings[messenger]' => array(
				'type' => 'hidden',
				'value' => $messenger->name
				),
			'type' => array(
				'type' => 'hidden',
				'value' => 'messenger'
				)
			);

		//make sure any active message types that are existing are included in the hidden fields
		if ( isset( $this->_m_mt_settings['message_type_tabs'][$messenger->name]['active'] ) ) {
			foreach ( $this->_m_mt_settings['message_type_tabs'][$messenger->name]['active'] as $mt => $values ) {
				$settings_template_args['hidden_fields']['messenger_settings[message_types]['.$mt.']'] = array(
						'type' => 'hidden',
						'value' => $mt
					);
			}
		}
		$settings_template_args[ 'hidden_fields' ] = $this->_generate_admin_form_fields(
			$settings_template_args[ 'hidden_fields' ],
			'array'
		);
		$active = $this->_message_resource_manager->is_messenger_active( $messenger->name );

		$settings_template_args['messenger'] = $messenger->name;
		$settings_template_args['description'] = $messenger->description;
		$settings_template_args['show_hide_edit_form'] = $active ? '' : ' hidden';


		$settings_template_args['show_hide_edit_form'] = $this->_message_resource_manager->is_messenger_active( $messenger->name )
			? $settings_template_args['show_hide_edit_form']
			: ' hidden';

		$settings_template_args['show_hide_edit_form'] = empty( $settings_template_args['template_form_fields'] )
			? ' hidden'
			: $settings_template_args['show_hide_edit_form'];


		$settings_template_args['on_off_action'] = $active ? 'messenger-off' : 'messenger-on';
		$settings_template_args['nonce'] = wp_create_nonce('activate_' . $messenger->name . '_toggle_nonce');
		$settings_template_args['on_off_status'] = $active ? true : false;
		$template = EE_MSG_TEMPLATE_PATH . 'ee_msg_m_settings_content.template.php';
		$content = EEH_Template::display_template( $template, $settings_template_args, true);
		return $content;
	}




	/**
	 * used by ajax on the messages settings page to activate|deactivate the messenger
	 */
	public function activate_messenger_toggle() {
		$success = true;
		$this->_prep_default_response_for_messenger_or_message_type_toggle();
		//let's check that we have required data
		if ( !isset( $this->_req_data[ 'messenger' ] ) ) {
			EE_Error::add_error(
				__( 'Messenger name needed to toggle activation. None given', 'event_espresso' ),
				__FILE__,
				__FUNCTION__,
				__LINE__
			);
			$success = false;
		}

		//do a nonce check here since we're not arriving via a normal route
		$nonce = isset($this->_req_data[ 'activate_nonce' ]) ? sanitize_text_field( $this->_req_data[ 'activate_nonce'] ) : '';
		$nonce_ref = 'activate_' . $this->_req_data['messenger'] . '_toggle_nonce';

		$this->_verify_nonce( $nonce, $nonce_ref );



		if ( !isset( $this->_req_data[ 'status' ])) {
			EE_Error::add_error(
				__(
					'Messenger status needed to know whether activation or deactivation is happening. No status is given',
					'event_espresso'
				),
				__FILE__,
				__FUNCTION__,
				__LINE__
			);
			$success = false;
		}

		//do check to verify we have a valid status.
		$status = $this->_req_data['status'];

		if ( $status != 'off' && $status != 'on' ) {
			EE_Error::add_error(
				sprintf(
					__( 'The given status (%s) is not valid. Must be "off" or "on"', 'event_espresso' ),
					$this->_req_data[ 'status' ]
				),
				__FILE__,
				__FUNCTION__,
				__LINE__
			);
			$success = false;
		}

		if ( $success ) {
			//made it here?  Stop dawdling then!!
			$success = $status == 'off'
				? $this->_deactivate_messenger( $this->_req_data['messenger'] )
				: $this->_activate_messenger( $this->_req_data['messenger'] );
		}

		$this->_template_args['success'] = $success;

		//no special instructions so let's just do the json return (which should automatically do all the special stuff).
		$this->_return_json();

	}





	/**
	 * used by ajax from the messages settings page to activate|deactivate a message type
	 *
	 */
	public function activate_mt_toggle() {
		$success = true;
		$this->_prep_default_response_for_messenger_or_message_type_toggle();

		//let's make sure we have the necessary data
		if ( ! isset( $this->_req_data[ 'message_type' ] ) ) {
			EE_Error::add_error(
				__('Message Type name needed to toggle activation. None given', 'event_espresso'),
				__FILE__, __FUNCTION__, __LINE__
			);
			$success = false;
		}

		if ( ! isset( $this->_req_data[ 'messenger' ] ) ) {
			EE_Error::add_error(
				__('Messenger name needed to toggle activation. None given', 'event_espresso'),
				__FILE__, __FUNCTION__, __LINE__
			);
			$success = false;
		}

		if ( ! isset( $this->_req_data[ 'status' ])) {
			EE_Error::add_error(
				__('Messenger status needed to know whether activation or deactivation is happening. No status is given', 'event_espresso'),
				__FILE__, __FUNCTION__, __LINE__
			);
			$success = false;
		}


		//do check to verify we have a valid status.
		$status = $this->_req_data['status'];

		if ( $status != 'activate' && $status != 'deactivate' ) {
			EE_Error::add_error(
				sprintf(
					__('The given status (%s) is not valid. Must be "active" or "inactive"', 'event_espresso'),
					$this->_req_data['status']
				),
				__FILE__, __FUNCTION__, __LINE__
			);
			$success = false;
		}


		//do a nonce check here since we're not arriving via a normal route
		$nonce = isset( $this->_req_data['mt_nonce'] ) ? sanitize_text_field( $this->_req_data['mt_nonce'] ) : '';
		$nonce_ref = $this->_req_data['message_type'] . '_nonce';

		$this->_verify_nonce( $nonce, $nonce_ref );

		if ( $success ) {
			//made it here? um, what are you waiting for then?
			$success = $status == 'deactivate'
				? $this->_deactivate_message_type_for_messenger( $this->_req_data['messenger'], $this->_req_data['message_type'] )
				: $this->_activate_message_type_for_messenger( $this->_req_data['messenger'], $this->_req_data['message_type'] );
		}

		$this->_template_args['success'] = $success;
		$this->_return_json();
	}


	/**
	 * Takes care of processing activating a messenger and preparing the appropriate response.
	 *
	 * @param string $messenger_name The name of the messenger being activated
	 * @return bool
	 */
	protected function _activate_messenger( $messenger_name ) {
		/** @var EE_messenger $active_messenger  This will be present because it can't be toggled if it isn't*/
		$active_messenger = $this->_message_resource_manager->get_messenger( $messenger_name );
		$message_types_to_activate = $active_messenger instanceof EE_Messenger ? $active_messenger->get_default_message_types() : array();

		//ensure is active
		$this->_message_resource_manager->activate_messenger( $messenger_name, $message_types_to_activate );

		//set response_data for reload
		foreach( $message_types_to_activate as $message_type_name ) {
			/** @var EE_message_type $message_type */
			$message_type = $this->_message_resource_manager->get_message_type( $message_type_name );
			if ( $this->_message_resource_manager->is_message_type_active_for_messenger( $messenger_name, $message_type_name )
			     && $message_type instanceof EE_message_type
			) {
				$this->_template_args['data']['active_mts'][] = $message_type_name;
				if ( $message_type->get_admin_settings_fields() ) {
					$this->_template_args['data']['mt_reload'][] = $message_type_name;
				}
			}
		}

		//add success message for activating messenger
		return $this->_setup_response_message_for_activating_messenger_with_message_types( $active_messenger );

	}


	/**
	 * Takes care of processing deactivating a messenger and preparing the appropriate response.
	 *
	 * @param string $messenger_name The name of the messenger being activated
	 * @return bool
	 */
	protected function _deactivate_messenger( $messenger_name ) {
		/** @var EE_messenger $active_messenger  This will be present because it can't be toggled if it isn't*/
		$active_messenger = $this->_message_resource_manager->get_messenger( $messenger_name );
		$this->_message_resource_manager->deactivate_messenger( $messenger_name );
		return $this->_setup_response_message_for_deactivating_messenger_with_message_types( $active_messenger );
	}


	/**
	 * Takes care of processing activating a message type for a messenger and preparing the appropriate response.
	 *
	 * @param string $messenger_name  The name of the messenger the message type is being activated for.
	 * @param string $message_type_name  The name of the message type being activated for the messenger
	 * @return bool
	 */
	protected function _activate_message_type_for_messenger( $messenger_name, $message_type_name ) {
		/** @var EE_messenger $active_messenger  This will be present because it can't be toggled if it isn't*/
		$active_messenger = $this->_message_resource_manager->get_messenger( $messenger_name );
		/** @var EE_message_type $message_type_to_activate This will be present because it can't be toggled if it isn't*/
		$message_type_to_activate = $this->_message_resource_manager->get_message_type( $message_type_name );

		//ensure is active
		$this->_message_resource_manager->activate_messenger( $messenger_name, $message_type_name );

$message_type_name is of type string, but the function expects a array.

		//set response for load
		if ( $this->_message_resource_manager->is_message_type_active_for_messenger( $messenger_name, $message_type_name ) ) {
			$this->_template_args['data']['active_mts'][] = $message_type_name;
			if ( $message_type_to_activate->get_admin_settings_fields() ) {
				$this->_template_args['data']['mt_reload'][] = $message_type_name;
			}
		}
		return $this->_setup_response_message_for_activating_messenger_with_message_types( $active_messenger, $message_type_to_activate );
	}



	/**
	 * Takes care of processing deactivating a message type for a messenger and preparing the appropriate response.
	 *
	 * @param string $messenger_name  The name of the messenger the message type is being deactivated for.
	 * @param string $message_type_name  The name of the message type being deactivated for the messenger
	 * @return bool
	 */
	protected function _deactivate_message_type_for_messenger( $messenger_name, $message_type_name ) {
		/** @var EE_messenger $active_messenger  This will be present because it can't be toggled if it isn't*/
		$active_messenger = $this->_message_resource_manager->get_messenger( $messenger_name );
		/** @var EE_message_type $message_type_to_activate This will be present because it can't be toggled if it isn't*/
		$message_type_to_deactivate = $this->_message_resource_manager->get_message_type( $message_type_name );
		$this->_message_resource_manager->deactivate_message_type_for_messenger( $message_type_name, $messenger_name );
		return $this->_setup_response_message_for_deactivating_messenger_with_message_types( $active_messenger, $message_type_to_deactivate );
	}





	/**
	 * This just initializes the defaults for activating messenger and message type responses.
	 */
	protected function _prep_default_response_for_messenger_or_message_type_toggle() {
		$this->_template_args['data']['active_mts'] = array();
		$this->_template_args['data']['mt_reload'] = array();
	}



	/**
	 * Setup appropriate response for activating a messenger and/or message types
	 *
	 * @param EE_messenger         $messenger
	 * @param EE_message_type|null $message_type
	 *
	 * @return bool
	 * @throws EE_Error
	 */
	protected function _setup_response_message_for_activating_messenger_with_message_types(
		$messenger,
		EE_Message_Type $message_type = null
	) {
		//if $messenger isn't a valid messenger object then get out.
		if ( ! $messenger instanceof EE_Messenger ) {
			EE_Error::add_error(
				__( 'The messenger being activated is not a valid messenger', 'event_espresso' ),
				__FILE__,
				__FUNCTION__,
				__LINE__
			);
			return false;
		}
		//activated
		if ( $this->_template_args['data']['active_mts'] ) {
			EE_Error::overwrite_success();
			//activated a message type with the messenger
			if ( $message_type instanceof EE_message_type ) {
				EE_Error::add_success(
					sprintf(
						__('%s message type has been successfully activated with the %s messenger', 'event_espresso'),
						ucwords( $message_type->label['singular'] ),
						ucwords( $messenger->label['singular'] )
					)
				);

				//if message type was invoice then let's make sure we activate the invoice payment method.
				if ( $message_type->name == 'invoice' ) {
					EE_Registry::instance()->load_lib( 'Payment_Method_Manager' );
					$pm = EE_Payment_Method_Manager::instance()->activate_a_payment_method_of_type( 'Invoice' );
					if ( $pm instanceof EE_Payment_Method ) {
						EE_Error::add_attention( __('Activating the invoice message type also automatically activates the invoice payment method.  If you do not wish the invoice payment method to be active, or to change its settings, visit the payment method admin page.', 'event_espresso' ) );
					}
				}
			//just toggles the entire messenger
			} else {
				EE_Error::add_success(
					sprintf(
						__( '%s messenger has been successfully activated', 'event_espresso' ),
						ucwords( $messenger->label[ 'singular' ] )
					)
				);
			}
			return true;

		//possible error condition. This will happen when our active_mts data is empty because it is validated for actual active
		//message types after the activation process.  However its possible some messengers don't HAVE any default_message_types
		//in which case we just give a success message for the messenger being successfully activated.
		} else {
			if ( ! $messenger->get_default_message_types() ) {
				//messenger doesn't have any default message types so still a success.
				EE_Error::add_success(
					sprintf(
						__('%s messenger was successfully activated.', 'event_espresso' ),
						ucwords( $messenger->label['singular'] )
						)
				);
				return true;
			} else {
				EE_Error::add_error(
					$message_type instanceof EE_message_type
						? sprintf(
						__( '%s message type was not successfully activated with the %s messenger', 'event_espresso' ),
						ucwords( $message_type->label['singular'] ),
						ucwords( $messenger->label['singular'] )
					)
						: sprintf(
						__( '%s messenger was not successfully activated', 'event_espresso' ),
						ucwords( $messenger->label['singular'] )
					),
					__FILE__,
					__FUNCTION__,
					__LINE__
				);

				return false;
			}
		}
	}


	/**
	 * This sets up the appropriate response for deactivating a messenger and/or message type.
	 *
	 * @param EE_messenger         $messenger
	 * @param EE_message_type|null $message_type
	 *
	 * @return bool
	 */
	protected function _setup_response_message_for_deactivating_messenger_with_message_types(
		$messenger,
		EE_message_type $message_type = null
	) {
		EE_Error::overwrite_success();

		//if $messenger isn't a valid messenger object then get out.
		if ( ! $messenger instanceof EE_Messenger ) {
			EE_Error::add_error(
				__( 'The messenger being deactivated is not a valid messenger', 'event_espresso' ),
				__FILE__,
				__FUNCTION__,
				__LINE__
			);
			return false;
		}

		if ( $message_type instanceof EE_message_type ) {
			$message_type_name = $message_type->name;
			EE_Error::add_success(
				sprintf(
					__('%s message type has been successfully deactivated for the %s messenger.', 'event_espresso'),
					ucwords( $message_type->label['singular'] ),
					ucwords ( $messenger->label['singular'] )
				)
			);
		} else {
			$message_type_name = '';
			EE_Error::add_success(
				sprintf(
					__('%s messenger has been successfully deactivated.', 'event_espresso'),
					ucwords( $messenger->label['singular'] )
				)
			);
		}

		//if messenger was html or message type was invoice then let's make sure we deactivate invoice payment method.
		if ( $messenger->name == 'html'  || $message_type_name == 'invoice') {
			EE_Registry::instance()->load_lib( 'Payment_Method_Manager' );
			$count_updated = EE_Payment_Method_Manager::instance()->deactivate_payment_method( 'invoice' );
			if ( $count_updated > 0 ) {
				$msg = $message_type_name == 'invoice'
					? __('Deactivating the invoice message type also automatically deactivates the invoice payment method. In order for invoices to be generated the invoice message type must be active. If you completed this action by mistake, simply reactivate the invoice message type and then visit the payment methods admin page to reactivate the invoice payment method.', 'event_espresso' )
					: __('Deactivating the html messenger also automatically deactivates the invoice payment method.  In order for invoices to be generated the html messenger must be be active.  If you completed this action by mistake, simply reactivate the html messenger, then visit the payment methods admin page to reactivate the invoice payment method.', 'event_espresso' );
				EE_Error::add_attention( $msg );
			}
		}
		return true;
	}


	/**
	 * handles updating a message type form on messenger activation IF the message type has settings fields. (via ajax)
	 */
	public function update_mt_form() {
		if ( !isset( $this->_req_data['messenger'] ) || !isset( $this->_req_data['message_type'] ) ) {
			EE_Error::add_error( __('Require message type or messenger to send an updated form'), __FILE__, __FUNCTION__, __LINE__ );
			$this->_return_json();
		}

		$message_types = $this->get_installed_message_types();

		$message_type = $message_types[ $this->_req_data['message_type'] ];
		$messenger = $this->_message_resource_manager->get_active_messenger( $this->_req_data['messenger'] );

		$content = $this->_message_type_settings_content ( $message_type, $messenger, true );

It seems like $messenger defined by $this->_message_resource_manager->get_active_messenger($this->_req_data['messenger']) on line 3290 can be null; however, Messages_Admin_Page::_message_type_settings_content() does not accept null, maybe add an additional type check?

		$this->_template_args['success'] = true;
		$this->_template_args['content'] = $content;
		$this->_return_json();
	}




	/**
	 * this handles saving the settings for a messenger or message type
	 *
	 */
	public function save_settings() {
		if ( !isset( $this->_req_data['type'] ) ) {
			EE_Error::add_error(__('Cannot save settings because type is unknown (messenger settings or messsage type settings?)', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__ );
			$this->_template_args['error'] = true;
			$this->_return_json();
		}


		if ( $this->_req_data['type'] == 'messenger' ) {
			$settings = $this->_req_data['messenger_settings']; //this should be an array.
			$messenger = $settings['messenger'];
			//let's setup the settings data
			foreach ( $settings as $key => $value ) {
				switch ( $key ) {
					case 'messenger' :
						unset( $settings['messenger'] );
						break;
					case 'message_types' :
						unset( $settings['message_types'] );
						break;
					default :
						$settings[$key] = $value;
						break;
				}
			}
			$this->_message_resource_manager->add_settings_for_messenger( $messenger, $settings );
		}

		else if ( $this->_req_data['type'] == 'message_type' ) {
			$settings = $this->_req_data['message_type_settings'];
			$messenger = $settings['messenger'];
			$message_type = $settings['message_type'];

			foreach ( $settings as $key => $value ) {
				switch ( $key ) {
					case 'messenger' :
						unset( $settings['messenger'] );
						break;
					case 'message_type' :
						unset( $settings['message_type'] );
						break;
					default :
						$settings[$key] = $value;
						break;
				}
			}

			$this->_message_resource_manager->add_settings_for_message_type( $messenger, $message_type, $settings );
		}

		//okay we should have the data all setup.  Now we just update!
		$success = $this->_message_resource_manager->update_active_messengers_option();

		if ( $success ) {
			EE_Error::add_success( __('Settings updated', 'event_espresso') );
		} else {
			EE_Error::add_error( __('Settings did not get updated', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__ );
		}

		$this->_template_args['success'] = $success;
		$this->_return_json();
	}




	/**  EE MESSAGE PROCESSING ACTIONS **/



	/**
	 * This immediately generates any EE_Message ID's that are selected that are EEM_Message::status_incomplete
     * However, this does not send immediately, it just queues for sending.
     *
     * @since 4.9.0
     */
	protected function _generate_now() {
		$msg_ids = $this->_get_msg_ids_from_request();
		EED_Messages::generate_now( $msg_ids );
		$this->_redirect_after_action( false, '', '', array(), true );

false is of type boolean, but the function expects a integer.

	}



	/**
	 * This immediately generates AND sends any EE_Message's selected that are EEM_Message::status_incomplete or that are
     * EEM_Message::status_resend or EEM_Message::status_idle
     *
     * @since 4.9.0
     *
     */
	protected function _generate_and_send_now() {
		$this->_generate_now();
		$this->_send_now();
		$this->_redirect_after_action( false, '', '', array(), true );

false is of type boolean, but the function expects a integer.

	}





	/**
	 * This queues any EEM_Message::status_sent EE_Message ids in the request for resending.
     *
     * @since 4.9.0
     */
	protected function _queue_for_resending() {
		$msg_ids = $this->_get_msg_ids_from_request();
		EED_Messages::queue_for_resending( $msg_ids );
		$this->_redirect_after_action( false, '', '', array(), true );

false is of type boolean, but the function expects a integer.

	}




	/**
	 *  This sends immediately any EEM_Message::status_idle or EEM_Message::status_resend messages in the queue
     *
     *  @since 4.9.0
     */
	protected function _send_now() {
		$msg_ids = $this->_get_msg_ids_from_request();
		EED_Messages::send_now( $msg_ids );
		$this->_redirect_after_action( false, '', '', array(), true );

false is of type boolean, but the function expects a integer.

	}




	/**
	 * Deletes EE_messages for IDs in the request.
     *
     * @since 4.9.0
     */
	protected function _delete_ee_messages() {
		$msg_ids = $this->_get_msg_ids_from_request();
		$deleted_count = 0;
		foreach ( $msg_ids as $msg_id ) {
			if ( EEM_Message::instance()->delete_by_ID( $msg_id ) ) {
				$deleted_count++;
			}
		}
		if ( $deleted_count ) {
			$this->_redirect_after_action(
				true,

true is of type boolean, but the function expects a integer.

				_n( 'message', 'messages', $deleted_count, 'event_espresso' ),
				__('deleted', 'event_espresso')
			);
		} else {
			EE_Error::add_error(
				_n( 'The message was not deleted.', 'The messages were not deleted', count( $msg_ids ), 'event_espresso' ),
				__FILE__, __FUNCTION__, __LINE__
			);
			$this->_redirect_after_action( false, '', '', array(), true );

false is of type boolean, but the function expects a integer.

		}
	}




	/**
	 *  This looks for 'MSG_ID' key in the request and returns an array of MSG_ID's if present.
     *  @since 4.9.0
     *  @return array
     */
	protected function _get_msg_ids_from_request() {
		if ( ! isset( $this->_req_data['MSG_ID'] ) ) {
			return array();
		}
		return is_array( $this->_req_data['MSG_ID'] ) ? array_keys( $this->_req_data['MSG_ID'] ) : array( $this->_req_data['MSG_ID'] );
	}


}