EE_Extra_Join - Code Metrics - Inspection of "Daily Inspection: Merge branch 'refs/heads/master'..." - eventespresso/event-espresso-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — FET-8896-previous-event-status (7c2952)

unknown

created 2015-12-15 21:40 UTC

EE_Extra_Join A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	24
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	new_instance()	0	4	2
A	new_instance_from_db()	0	3	1

<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
/**
 * Contains definition for EE_Extra_Join model object
 * @package 		Event Espresso
 * @subpackage 	models
 * @since 			$VID$
 */

/**
 * EE_Extra_Join
 * This is the model object for EEM_Event_Message_Template
 *
 * @package 		Event Espresso
 * @subpackage 	models
 * @author 			Darren Ethier
 * @since 			4.3.0
 */
class EE_Extra_Join extends EE_Base_Class {

	/**
	 * @param array $props_n_values
	 * @param null  $timezone
	 * @return EE_Extra_Join|mixed
	 */
	public static function new_instance( $props_n_values = array(), $timezone = NULL ) {
		$has_object = parent::_check_for_object( $props_n_values, __CLASS__, $timezone );
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
		return $has_object ? $has_object : new self( $props_n_values, FALSE, $timezone );
	}



	/**
	 * @param array $props_n_values
	 * @param null  $timezone
	 * @return EE_Extra_Join
	 */
	public static function new_instance_from_db ( $props_n_values = array(), $timezone = NULL ) {
		return new self( $props_n_values, TRUE, $timezone );
	}

}
//end class EE_Extra_Join


1			<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
2			/**
3			* Contains definition for EE_Extra_Join model object
4			* @package Event Espresso
5			* @subpackage models
6			* @since $VID$
7			*/
8
9			/**
10			* EE_Extra_Join
11			* This is the model object for EEM_Event_Message_Template
12			*
13			* @package Event Espresso
14			* @subpackage models
15			* @author Darren Ethier
16			* @since 4.3.0
17			*/
18			class EE_Extra_Join extends EE_Base_Class {
19
20			/**
21			* @param array $props_n_values
22			* @param null $timezone
23			* @return EE_Extra_Join\|mixed
24			*/
25			public static function new_instance( $props_n_values = array(), $timezone = NULL ) {
26			$has_object = parent::_check_for_object( $props_n_values, __CLASS__, $timezone );
			0 ignored issues – show Comprehensibility Bug introduced 2015-12-03 08:07 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`_check_for_object()` instead of `new_instance()`). Are you sure this is correct? If so, you might want to change this to `$this->_check_for_object()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
27			return $has_object ? $has_object : new self( $props_n_values, FALSE, $timezone );
28			}
29
30
31
32			/**
33			* @param array $props_n_values
34			* @param null $timezone
35			* @return EE_Extra_Join
36			*/
37			public static function new_instance_from_db ( $props_n_values = array(), $timezone = NULL ) {
38			return new self( $props_n_values, TRUE, $timezone );
39			}
40
41			}
42			//end class EE_Extra_Join
43

eventespresso / event-espresso-core

Branch — FET-8896-previous-event-status (7c2952)

EE_Extra_Join A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like