Conditions | 8 |
Paths | 1 |
Total Lines | 53 |
Lines | 53 |
Ratio | 100 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
27 | public static function mutateAndGetPayload(EEM_Datetime $model, Datetime $type) |
||
28 | { |
||
29 | /** |
||
30 | * Deletes an entity. |
||
31 | * |
||
32 | * @param array $input The input for the mutation |
||
33 | * @param AppContext $context The AppContext passed down to all resolvers |
||
34 | * @param ResolveInfo $info The ResolveInfo passed down to all resolvers |
||
35 | * |
||
36 | * @throws UserError |
||
37 | * @throws ReflectionException |
||
38 | * @throws InvalidArgumentException |
||
39 | * @throws InvalidInterfaceException |
||
40 | * @throws InvalidDataTypeException |
||
41 | * @throws EE_Error |
||
42 | */ |
||
43 | return static function ($input, AppContext $context, ResolveInfo $info) use ($model, $type) |
||
44 | { |
||
45 | /** |
||
46 | * Stop now if a user isn't allowed to create a datetime. |
||
47 | */ |
||
48 | if (! current_user_can('ee_edit_events')) { |
||
49 | // translators: the %1$s is the name of the object being mutated |
||
50 | throw new UserError(sprintf(__('Sorry, you are not allowed to edit %1$s', 'event_espresso' ), $type->name())); |
||
51 | } |
||
52 | |||
53 | $id = ! empty($input['id']) ? absint($input['id']) : 0; |
||
54 | $entity = null; |
||
55 | |||
56 | if ($id) { |
||
57 | $entity = $model->get_one_by_ID($id); |
||
58 | } |
||
59 | |||
60 | /** |
||
61 | * If there's no existing datetime, throw an exception |
||
62 | */ |
||
63 | if (! $id || ! ($entity instanceof EE_Datetime)) { |
||
64 | // translators: the placeholder is the name of the type being updated |
||
65 | throw new UserError(sprintf(__( 'No %1$s could be found to delete', 'event_espresso' ), $type->name())); |
||
66 | } |
||
67 | |||
68 | // Delete the entity |
||
69 | $result = ! empty($input['deletePermanently']) ? $entity->delete_permanently() : $entity->delete(); |
||
70 | |||
71 | if (empty($result)) { |
||
72 | throw new UserError(__( 'The object failed to delete but no error was provided', 'event_espresso')); |
||
73 | } |
||
74 | |||
75 | return [ |
||
76 | 'deleted' => $entity, |
||
77 | ]; |
||
78 | }; |
||
79 | } |
||
80 | } |
||
81 |