eventespresso / event-espresso-core

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/ForLoopWithTestFunctionCallSniff.php

Indentation +62 added lines, -62 removed lines

@@ -34,68 +34,68 @@
 {
 
 
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        return [T_FOR];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Skip invalid statement.
-        if (isset($token['parenthesis_opener']) === false) {
-            return;
-        }
-
-        $next = ++$token['parenthesis_opener'];
-        $end  = --$token['parenthesis_closer'];
-
-        $position = 0;
-
-        for (; $next <= $end; ++$next) {
-            $code = $tokens[$next]['code'];
-            if ($code === T_SEMICOLON) {
-                ++$position;
-            }
-
-            if ($position < 1) {
-                continue;
-            } else if ($position > 1) {
-                break;
-            } else if ($code !== T_VARIABLE && $code !== T_STRING) {
-                continue;
-            }
-
-            // Find next non empty token, if it is a open curly brace we have a
-            // function call.
-            $index = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-
-            if ($tokens[$index]['code'] === T_OPEN_PARENTHESIS) {
-                $error = 'Avoid function calls in a FOR loop test part';
-                $phpcsFile->addWarning($error, $stackPtr, 'NotAllowed');
-                break;
-            }
-        }//end for
-
-    }//end process()
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		return [T_FOR];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Skip invalid statement.
+		if (isset($token['parenthesis_opener']) === false) {
+			return;
+		}
+
+		$next = ++$token['parenthesis_opener'];
+		$end  = --$token['parenthesis_closer'];
+
+		$position = 0;
+
+		for (; $next <= $end; ++$next) {
+			$code = $tokens[$next]['code'];
+			if ($code === T_SEMICOLON) {
+				++$position;
+			}
+
+			if ($position < 1) {
+				continue;
+			} else if ($position > 1) {
+				break;
+			} else if ($code !== T_VARIABLE && $code !== T_STRING) {
+				continue;
+			}
+
+			// Find next non empty token, if it is a open curly brace we have a
+			// function call.
+			$index = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
+
+			if ($tokens[$index]['code'] === T_OPEN_PARENTHESIS) {
+				$error = 'Avoid function calls in a FOR loop test part';
+				$phpcsFile->addWarning($error, $stackPtr, 'NotAllowed');
+				break;
+			}
+		}//end for
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php

Indentation +50 added lines, -50 removed lines

@@ -30,56 +30,56 @@
 {
 
 
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        return [T_CLASS];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Skip for-statements without body.
-        if (isset($token['scope_opener']) === false) {
-            return;
-        }
-
-        // Fetch previous token.
-        $prev = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);
-
-        // Skip for non final class.
-        if ($prev === false || $tokens[$prev]['code'] !== T_FINAL) {
-            return;
-        }
-
-        $next = ++$token['scope_opener'];
-        $end  = --$token['scope_closer'];
-
-        for (; $next <= $end; ++$next) {
-            if ($tokens[$next]['code'] === T_FINAL) {
-                $error = 'Unnecessary FINAL modifier in FINAL class';
-                $phpcsFile->addWarning($error, $next, 'Found');
-            }
-        }
-
-    }//end process()
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		return [T_CLASS];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Skip for-statements without body.
+		if (isset($token['scope_opener']) === false) {
+			return;
+		}
+
+		// Fetch previous token.
+		$prev = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);
+
+		// Skip for non final class.
+		if ($prev === false || $tokens[$prev]['code'] !== T_FINAL) {
+			return;
+		}
+
+		$next = ++$token['scope_opener'];
+		$end  = --$token['scope_closer'];
+
+		for (; $next <= $end; ++$next) {
+			if ($tokens[$next]['code'] === T_FINAL) {
+				$error = 'Unnecessary FINAL modifier in FINAL class';
+				$phpcsFile->addWarning($error, $next, 'Found');
+			}
+		}
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/JumbledIncrementerSniff.php

Indentation +93 added lines, -93 removed lines

@@ -36,99 +36,99 @@
 {
 
 
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        return [T_FOR];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Skip for-loop without body.
-        if (isset($token['scope_opener']) === false) {
-            return;
-        }
-
-        // Find incrementors for outer loop.
-        $outer = $this->findIncrementers($tokens, $token);
-
-        // Skip if empty.
-        if (count($outer) === 0) {
-            return;
-        }
-
-        // Find nested for loops.
-        $start = ++$token['scope_opener'];
-        $end   = --$token['scope_closer'];
-
-        for (; $start <= $end; ++$start) {
-            if ($tokens[$start]['code'] !== T_FOR) {
-                continue;
-            }
-
-            $inner = $this->findIncrementers($tokens, $tokens[$start]);
-            $diff  = array_intersect($outer, $inner);
-
-            if (count($diff) !== 0) {
-                $error = 'Loop incrementor (%s) jumbling with inner loop';
-                $data  = [join(', ', $diff)];
-                $phpcsFile->addWarning($error, $stackPtr, 'Found', $data);
-            }
-        }
-
-    }//end process()
-
-
-    /**
-     * Get all used variables in the incrementer part of a for statement.
-     *
-     * @param array(integer=>array) $tokens Array with all code sniffer tokens.
-     * @param array(string=>mixed)  $token  Current for loop token
-     *
-     * @return string[] List of all found incrementer variables.
-     */
-    protected function findIncrementers(array $tokens, array $token)
-    {
-        // Skip invalid statement.
-        if (isset($token['parenthesis_opener']) === false) {
-            return [];
-        }
-
-        $start = ++$token['parenthesis_opener'];
-        $end   = --$token['parenthesis_closer'];
-
-        $incrementers = [];
-        $semicolons   = 0;
-        for ($next = $start; $next <= $end; ++$next) {
-            $code = $tokens[$next]['code'];
-            if ($code === T_SEMICOLON) {
-                ++$semicolons;
-            } else if ($semicolons === 2 && $code === T_VARIABLE) {
-                $incrementers[] = $tokens[$next]['content'];
-            }
-        }
-
-        return $incrementers;
-
-    }//end findIncrementers()
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		return [T_FOR];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Skip for-loop without body.
+		if (isset($token['scope_opener']) === false) {
+			return;
+		}
+
+		// Find incrementors for outer loop.
+		$outer = $this->findIncrementers($tokens, $token);
+
+		// Skip if empty.
+		if (count($outer) === 0) {
+			return;
+		}
+
+		// Find nested for loops.
+		$start = ++$token['scope_opener'];
+		$end   = --$token['scope_closer'];
+
+		for (; $start <= $end; ++$start) {
+			if ($tokens[$start]['code'] !== T_FOR) {
+				continue;
+			}
+
+			$inner = $this->findIncrementers($tokens, $tokens[$start]);
+			$diff  = array_intersect($outer, $inner);
+
+			if (count($diff) !== 0) {
+				$error = 'Loop incrementor (%s) jumbling with inner loop';
+				$data  = [join(', ', $diff)];
+				$phpcsFile->addWarning($error, $stackPtr, 'Found', $data);
+			}
+		}
+
+	}//end process()
+
+
+	/**
+	 * Get all used variables in the incrementer part of a for statement.
+	 *
+	 * @param array(integer=>array) $tokens Array with all code sniffer tokens.
+	 * @param array(string=>mixed)  $token  Current for loop token
+	 *
+	 * @return string[] List of all found incrementer variables.
+	 */
+	protected function findIncrementers(array $tokens, array $token)
+	{
+		// Skip invalid statement.
+		if (isset($token['parenthesis_opener']) === false) {
+			return [];
+		}
+
+		$start = ++$token['parenthesis_opener'];
+		$end   = --$token['parenthesis_closer'];
+
+		$incrementers = [];
+		$semicolons   = 0;
+		for ($next = $start; $next <= $end; ++$next) {
+			$code = $tokens[$next]['code'];
+			if ($code === T_SEMICOLON) {
+				++$semicolons;
+			} else if ($semicolons === 2 && $code === T_VARIABLE) {
+				$incrementers[] = $tokens[$next]['content'];
+			}
+		}
+
+		return $incrementers;
+
+	}//end findIncrementers()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/UselessOverridingMethodSniff.php

Indentation +127 added lines, -127 removed lines

@@ -29,133 +29,133 @@
 {
 
 
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        return [T_FUNCTION];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Skip function without body.
-        if (isset($token['scope_opener']) === false) {
-            return;
-        }
-
-        // Get function name.
-        $methodName = $phpcsFile->getDeclarationName($stackPtr);
-
-        // Get all parameters from method signature.
-        $signature = [];
-        foreach ($phpcsFile->getMethodParameters($stackPtr) as $param) {
-            $signature[] = $param['name'];
-        }
-
-        $next = ++$token['scope_opener'];
-        $end  = --$token['scope_closer'];
-
-        for (; $next <= $end; ++$next) {
-            $code = $tokens[$next]['code'];
-
-            if (isset(Tokens::$emptyTokens[$code]) === true) {
-                continue;
-            } else if ($code === T_RETURN) {
-                continue;
-            }
-
-            break;
-        }
-
-        // Any token except 'parent' indicates correct code.
-        if ($tokens[$next]['code'] !== T_PARENT) {
-            return;
-        }
-
-        // Find next non empty token index, should be double colon.
-        $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-
-        // Skip for invalid code.
-        if ($next === false || $tokens[$next]['code'] !== T_DOUBLE_COLON) {
-            return;
-        }
-
-        // Find next non empty token index, should be the function name.
-        $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-
-        // Skip for invalid code or other method.
-        if ($next === false || $tokens[$next]['content'] !== $methodName) {
-            return;
-        }
-
-        // Find next non empty token index, should be the open parenthesis.
-        $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-
-        // Skip for invalid code.
-        if ($next === false || $tokens[$next]['code'] !== T_OPEN_PARENTHESIS) {
-            return;
-        }
-
-        $parameters       = [''];
-        $parenthesisCount = 1;
-        $count            = count($tokens);
-        for (++$next; $next < $count; ++$next) {
-            $code = $tokens[$next]['code'];
-
-            if ($code === T_OPEN_PARENTHESIS) {
-                ++$parenthesisCount;
-            } else if ($code === T_CLOSE_PARENTHESIS) {
-                --$parenthesisCount;
-            } else if ($parenthesisCount === 1 && $code === T_COMMA) {
-                $parameters[] = '';
-            } else if (isset(Tokens::$emptyTokens[$code]) === false) {
-                $parameters[(count($parameters) - 1)] .= $tokens[$next]['content'];
-            }
-
-            if ($parenthesisCount === 0) {
-                break;
-            }
-        }//end for
-
-        $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-        if ($next === false || $tokens[$next]['code'] !== T_SEMICOLON) {
-            return;
-        }
-
-        // Check rest of the scope.
-        for (++$next; $next <= $end; ++$next) {
-            $code = $tokens[$next]['code'];
-            // Skip for any other content.
-            if (isset(Tokens::$emptyTokens[$code]) === false) {
-                return;
-            }
-        }
-
-        $parameters = array_map('trim', $parameters);
-        $parameters = array_filter($parameters);
-
-        if (count($parameters) === count($signature) && $parameters === $signature) {
-            $phpcsFile->addWarning('Possible useless method overriding detected', $stackPtr, 'Found');
-        }
-
-    }//end process()
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		return [T_FUNCTION];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Skip function without body.
+		if (isset($token['scope_opener']) === false) {
+			return;
+		}
+
+		// Get function name.
+		$methodName = $phpcsFile->getDeclarationName($stackPtr);
+
+		// Get all parameters from method signature.
+		$signature = [];
+		foreach ($phpcsFile->getMethodParameters($stackPtr) as $param) {
+			$signature[] = $param['name'];
+		}
+
+		$next = ++$token['scope_opener'];
+		$end  = --$token['scope_closer'];
+
+		for (; $next <= $end; ++$next) {
+			$code = $tokens[$next]['code'];
+
+			if (isset(Tokens::$emptyTokens[$code]) === true) {
+				continue;
+			} else if ($code === T_RETURN) {
+				continue;
+			}
+
+			break;
+		}
+
+		// Any token except 'parent' indicates correct code.
+		if ($tokens[$next]['code'] !== T_PARENT) {
+			return;
+		}
+
+		// Find next non empty token index, should be double colon.
+		$next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
+
+		// Skip for invalid code.
+		if ($next === false || $tokens[$next]['code'] !== T_DOUBLE_COLON) {
+			return;
+		}
+
+		// Find next non empty token index, should be the function name.
+		$next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
+
+		// Skip for invalid code or other method.
+		if ($next === false || $tokens[$next]['content'] !== $methodName) {
+			return;
+		}
+
+		// Find next non empty token index, should be the open parenthesis.
+		$next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
+
+		// Skip for invalid code.
+		if ($next === false || $tokens[$next]['code'] !== T_OPEN_PARENTHESIS) {
+			return;
+		}
+
+		$parameters       = [''];
+		$parenthesisCount = 1;
+		$count            = count($tokens);
+		for (++$next; $next < $count; ++$next) {
+			$code = $tokens[$next]['code'];
+
+			if ($code === T_OPEN_PARENTHESIS) {
+				++$parenthesisCount;
+			} else if ($code === T_CLOSE_PARENTHESIS) {
+				--$parenthesisCount;
+			} else if ($parenthesisCount === 1 && $code === T_COMMA) {
+				$parameters[] = '';
+			} else if (isset(Tokens::$emptyTokens[$code]) === false) {
+				$parameters[(count($parameters) - 1)] .= $tokens[$next]['content'];
+			}
+
+			if ($parenthesisCount === 0) {
+				break;
+			}
+		}//end for
+
+		$next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
+		if ($next === false || $tokens[$next]['code'] !== T_SEMICOLON) {
+			return;
+		}
+
+		// Check rest of the scope.
+		for (++$next; $next <= $end; ++$next) {
+			$code = $tokens[$next]['code'];
+			// Skip for any other content.
+			if (isset(Tokens::$emptyTokens[$code]) === false) {
+				return;
+			}
+		}
+
+		$parameters = array_map('trim', $parameters);
+		$parameters = array_filter($parameters);
+
+		if (count($parameters) === count($signature) && $parameters === $signature) {
+			$phpcsFile->addWarning('Possible useless method overriding detected', $stackPtr, 'Found');
+		}
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/AssignmentInConditionSniff.php

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
             }
 
             $startPos = $hasAssignment;
-        } while ($startPos < $closer);
+        }while ($startPos < $closer);
 
     }//end process()
 

Indentation +146 added lines, -146 removed lines

@@ -20,152 +20,152 @@
 class AssignmentInConditionSniff implements Sniff
 {
 
-    /**
-     * Assignment tokens to trigger on.
-     *
-     * Set in the register() method.
-     *
-     * @var array
-     */
-    protected $assignmentTokens = [];
-
-    /**
-     * The tokens that indicate the start of a condition.
-     *
-     * @var array
-     */
-    protected $conditionStartTokens = [];
-
-
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        $this->assignmentTokens = Tokens::$assignmentTokens;
-        unset($this->assignmentTokens[T_DOUBLE_ARROW]);
-
-        $starters = Tokens::$booleanOperators;
-        $starters[T_SEMICOLON]        = T_SEMICOLON;
-        $starters[T_OPEN_PARENTHESIS] = T_OPEN_PARENTHESIS;
-
-        $this->conditionStartTokens = $starters;
-
-        return [
-            T_IF,
-            T_ELSEIF,
-            T_FOR,
-            T_SWITCH,
-            T_CASE,
-            T_WHILE,
-            T_MATCH,
-        ];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Find the condition opener/closer.
-        if ($token['code'] === T_FOR) {
-            if (isset($token['parenthesis_opener'], $token['parenthesis_closer']) === false) {
-                return;
-            }
-
-            $semicolon = $phpcsFile->findNext(T_SEMICOLON, ($token['parenthesis_opener'] + 1), ($token['parenthesis_closer']));
-            if ($semicolon === false) {
-                return;
-            }
-
-            $opener = $semicolon;
-
-            $semicolon = $phpcsFile->findNext(T_SEMICOLON, ($opener + 1), ($token['parenthesis_closer']));
-            if ($semicolon === false) {
-                return;
-            }
-
-            $closer = $semicolon;
-            unset($semicolon);
-        } else if ($token['code'] === T_CASE) {
-            if (isset($token['scope_opener']) === false) {
-                return;
-            }
-
-            $opener = $stackPtr;
-            $closer = $token['scope_opener'];
-        } else {
-            if (isset($token['parenthesis_opener'], $token['parenthesis_closer']) === false) {
-                return;
-            }
-
-            $opener = $token['parenthesis_opener'];
-            $closer = $token['parenthesis_closer'];
-        }//end if
-
-        $startPos = $opener;
-
-        do {
-            $hasAssignment = $phpcsFile->findNext($this->assignmentTokens, ($startPos + 1), $closer);
-            if ($hasAssignment === false) {
-                return;
-            }
-
-            // Examine whether the left side is a variable.
-            $hasVariable       = false;
-            $conditionStart    = $startPos;
-            $altConditionStart = $phpcsFile->findPrevious($this->conditionStartTokens, ($hasAssignment - 1), $startPos);
-            if ($altConditionStart !== false) {
-                $conditionStart = $altConditionStart;
-            }
-
-            for ($i = $hasAssignment; $i > $conditionStart; $i--) {
-                if (isset(Tokens::$emptyTokens[$tokens[$i]['code']]) === true) {
-                    continue;
-                }
-
-                // If this is a variable or array, we've seen all we need to see.
-                if ($tokens[$i]['code'] === T_VARIABLE || $tokens[$i]['code'] === T_CLOSE_SQUARE_BRACKET) {
-                    $hasVariable = true;
-                    break;
-                }
-
-                // If this is a function call or something, we are OK.
-                if ($tokens[$i]['code'] === T_CLOSE_PARENTHESIS) {
-                    break;
-                }
-            }
-
-            if ($hasVariable === true) {
-                $errorCode = 'Found';
-                if ($token['code'] === T_WHILE) {
-                    $errorCode = 'FoundInWhileCondition';
-                }
-
-                $phpcsFile->addWarning(
-                    'Variable assignment found within a condition. Did you mean to do a comparison ?',
-                    $hasAssignment,
-                    $errorCode
-                );
-            }
-
-            $startPos = $hasAssignment;
-        } while ($startPos < $closer);
-
-    }//end process()
+	/**
+	 * Assignment tokens to trigger on.
+	 *
+	 * Set in the register() method.
+	 *
+	 * @var array
+	 */
+	protected $assignmentTokens = [];
+
+	/**
+	 * The tokens that indicate the start of a condition.
+	 *
+	 * @var array
+	 */
+	protected $conditionStartTokens = [];
+
+
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		$this->assignmentTokens = Tokens::$assignmentTokens;
+		unset($this->assignmentTokens[T_DOUBLE_ARROW]);
+
+		$starters = Tokens::$booleanOperators;
+		$starters[T_SEMICOLON]        = T_SEMICOLON;
+		$starters[T_OPEN_PARENTHESIS] = T_OPEN_PARENTHESIS;
+
+		$this->conditionStartTokens = $starters;
+
+		return [
+			T_IF,
+			T_ELSEIF,
+			T_FOR,
+			T_SWITCH,
+			T_CASE,
+			T_WHILE,
+			T_MATCH,
+		];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Find the condition opener/closer.
+		if ($token['code'] === T_FOR) {
+			if (isset($token['parenthesis_opener'], $token['parenthesis_closer']) === false) {
+				return;
+			}
+
+			$semicolon = $phpcsFile->findNext(T_SEMICOLON, ($token['parenthesis_opener'] + 1), ($token['parenthesis_closer']));
+			if ($semicolon === false) {
+				return;
+			}
+
+			$opener = $semicolon;
+
+			$semicolon = $phpcsFile->findNext(T_SEMICOLON, ($opener + 1), ($token['parenthesis_closer']));
+			if ($semicolon === false) {
+				return;
+			}
+
+			$closer = $semicolon;
+			unset($semicolon);
+		} else if ($token['code'] === T_CASE) {
+			if (isset($token['scope_opener']) === false) {
+				return;
+			}
+
+			$opener = $stackPtr;
+			$closer = $token['scope_opener'];
+		} else {
+			if (isset($token['parenthesis_opener'], $token['parenthesis_closer']) === false) {
+				return;
+			}
+
+			$opener = $token['parenthesis_opener'];
+			$closer = $token['parenthesis_closer'];
+		}//end if
+
+		$startPos = $opener;
+
+		do {
+			$hasAssignment = $phpcsFile->findNext($this->assignmentTokens, ($startPos + 1), $closer);
+			if ($hasAssignment === false) {
+				return;
+			}
+
+			// Examine whether the left side is a variable.
+			$hasVariable       = false;
+			$conditionStart    = $startPos;
+			$altConditionStart = $phpcsFile->findPrevious($this->conditionStartTokens, ($hasAssignment - 1), $startPos);
+			if ($altConditionStart !== false) {
+				$conditionStart = $altConditionStart;
+			}
+
+			for ($i = $hasAssignment; $i > $conditionStart; $i--) {
+				if (isset(Tokens::$emptyTokens[$tokens[$i]['code']]) === true) {
+					continue;
+				}
+
+				// If this is a variable or array, we've seen all we need to see.
+				if ($tokens[$i]['code'] === T_VARIABLE || $tokens[$i]['code'] === T_CLOSE_SQUARE_BRACKET) {
+					$hasVariable = true;
+					break;
+				}
+
+				// If this is a function call or something, we are OK.
+				if ($tokens[$i]['code'] === T_CLOSE_PARENTHESIS) {
+					break;
+				}
+			}
+
+			if ($hasVariable === true) {
+				$errorCode = 'Found';
+				if ($token['code'] === T_WHILE) {
+					$errorCode = 'FoundInWhileCondition';
+				}
+
+				$phpcsFile->addWarning(
+					'Variable assignment found within a condition. Did you mean to do a comparison ?',
+					$hasAssignment,
+					$errorCode
+				);
+			}
+
+			$startPos = $hasAssignment;
+		} while ($startPos < $closer);
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/CodeAnalysis/ForLoopShouldBeWhileLoopSniff.php

Indentation +56 added lines, -56 removed lines

@@ -30,62 +30,62 @@
 {
 
 
-    /**
-     * Registers the tokens that this sniff wants to listen for.
-     *
-     * @return int[]
-     */
-    public function register()
-    {
-        return [T_FOR];
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token
-     *                                               in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $token  = $tokens[$stackPtr];
-
-        // Skip invalid statement.
-        if (isset($token['parenthesis_opener']) === false) {
-            return;
-        }
-
-        $next = ++$token['parenthesis_opener'];
-        $end  = --$token['parenthesis_closer'];
-
-        $parts = [
-            0,
-            0,
-            0,
-        ];
-        $index = 0;
-
-        for (; $next <= $end; ++$next) {
-            $code = $tokens[$next]['code'];
-            if ($code === T_SEMICOLON) {
-                ++$index;
-            } else if (isset(Tokens::$emptyTokens[$code]) === false) {
-                ++$parts[$index];
-            }
-        }
-
-        if ($parts[0] === 0 && $parts[2] === 0 && $parts[1] > 0) {
-            $error = 'This FOR loop can be simplified to a WHILE loop';
-            $phpcsFile->addWarning($error, $stackPtr, 'CanSimplify');
-        }
-
-    }//end process()
+	/**
+	 * Registers the tokens that this sniff wants to listen for.
+	 *
+	 * @return int[]
+	 */
+	public function register()
+	{
+		return [T_FOR];
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token
+	 *                                               in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		$token  = $tokens[$stackPtr];
+
+		// Skip invalid statement.
+		if (isset($token['parenthesis_opener']) === false) {
+			return;
+		}
+
+		$next = ++$token['parenthesis_opener'];
+		$end  = --$token['parenthesis_closer'];
+
+		$parts = [
+			0,
+			0,
+			0,
+		];
+		$index = 0;
+
+		for (; $next <= $end; ++$next) {
+			$code = $tokens[$next]['code'];
+			if ($code === T_SEMICOLON) {
+				++$index;
+			} else if (isset(Tokens::$emptyTokens[$code]) === false) {
+				++$parts[$index];
+			}
+		}
+
+		if ($parts[0] === 0 && $parts[2] === 0 && $parts[1] > 0) {
+			$error = 'This FOR loop can be simplified to a WHILE loop';
+			$phpcsFile->addWarning($error, $stackPtr, 'CanSimplify');
+		}
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/PHP/DeprecatedFunctionsSniff.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      *
      * @return void
      */
-    protected function addError($phpcsFile, $stackPtr, $function, $pattern=null)
+    protected function addError($phpcsFile, $stackPtr, $function, $pattern = null)
     {
         $data  = [$function];
         $error = 'Function %s() has been deprecated';

Indentation +46 added lines, -46 removed lines

@@ -13,61 +13,61 @@
 class DeprecatedFunctionsSniff extends ForbiddenFunctionsSniff
 {
 
-    /**
-     * A list of forbidden functions with their alternatives.
-     *
-     * The value is NULL if no alternative exists. IE, the
-     * function should just not be used.
-     *
-     * @var array<string, string|null>
-     */
-    public $forbiddenFunctions = [];
+	/**
+	 * A list of forbidden functions with their alternatives.
+	 *
+	 * The value is NULL if no alternative exists. IE, the
+	 * function should just not be used.
+	 *
+	 * @var array<string, string|null>
+	 */
+	public $forbiddenFunctions = [];
 
 
-    /**
-     * Constructor.
-     *
-     * Uses the Reflection API to get a list of deprecated functions.
-     */
-    public function __construct()
-    {
-        $functions = get_defined_functions();
+	/**
+	 * Constructor.
+	 *
+	 * Uses the Reflection API to get a list of deprecated functions.
+	 */
+	public function __construct()
+	{
+		$functions = get_defined_functions();
 
-        foreach ($functions['internal'] as $functionName) {
-            $function = new \ReflectionFunction($functionName);
+		foreach ($functions['internal'] as $functionName) {
+			$function = new \ReflectionFunction($functionName);
 
-            if ($function->isDeprecated() === true) {
-                $this->forbiddenFunctions[$functionName] = null;
-            }
-        }
+			if ($function->isDeprecated() === true) {
+				$this->forbiddenFunctions[$functionName] = null;
+			}
+		}
 
-    }//end __construct()
+	}//end __construct()
 
 
-    /**
-     * Generates the error or warning for this sniff.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the forbidden function
-     *                                               in the token array.
-     * @param string                      $function  The name of the forbidden function.
-     * @param string                      $pattern   The pattern used for the match.
-     *
-     * @return void
-     */
-    protected function addError($phpcsFile, $stackPtr, $function, $pattern=null)
-    {
-        $data  = [$function];
-        $error = 'Function %s() has been deprecated';
-        $type  = 'Deprecated';
+	/**
+	 * Generates the error or warning for this sniff.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the forbidden function
+	 *                                               in the token array.
+	 * @param string                      $function  The name of the forbidden function.
+	 * @param string                      $pattern   The pattern used for the match.
+	 *
+	 * @return void
+	 */
+	protected function addError($phpcsFile, $stackPtr, $function, $pattern=null)
+	{
+		$data  = [$function];
+		$error = 'Function %s() has been deprecated';
+		$type  = 'Deprecated';
 
-        if ($this->error === true) {
-            $phpcsFile->addError($error, $stackPtr, $type, $data);
-        } else {
-            $phpcsFile->addWarning($error, $stackPtr, $type, $data);
-        }
+		if ($this->error === true) {
+			$phpcsFile->addError($error, $stackPtr, $type, $data);
+		} else {
+			$phpcsFile->addWarning($error, $stackPtr, $type, $data);
+		}
 
-    }//end addError()
+	}//end addError()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/PHP/BacktickOperatorSniff.php

Indentation +27 added lines, -27 removed lines

@@ -16,33 +16,33 @@
 {
 
 
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return [T_BACKTICK];
-
-    }//end register()
-
-
-    /**
-     * Processes this sniff, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token in
-     *                                               the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $error = 'Use of the backtick operator is forbidden';
-        $phpcsFile->addError($error, $stackPtr, 'Found');
-
-    }//end process()
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return [T_BACKTICK];
+
+	}//end register()
+
+
+	/**
+	 * Processes this sniff, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token in
+	 *                                               the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$error = 'Use of the backtick operator is forbidden';
+		$phpcsFile->addError($error, $stackPtr, 'Found');
+
+	}//end process()
 
 
 }//end class

vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/PHP/DiscourageGotoSniff.php

Indentation +29 added lines, -29 removed lines

@@ -16,35 +16,35 @@
 {
 
 
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return [
-            T_GOTO,
-            T_GOTO_LABEL,
-        ];
-
-    }//end register()
-
-
-    /**
-     * Processes this sniff, when one of its tokens is encountered.
-     *
-     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
-     * @param int                         $stackPtr  The position of the current token in
-     *                                               the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $phpcsFile->addWarning('Use of the GOTO language construct is discouraged', $stackPtr, 'Found');
-
-    }//end process()
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return [
+			T_GOTO,
+			T_GOTO_LABEL,
+		];
+
+	}//end register()
+
+
+	/**
+	 * Processes this sniff, when one of its tokens is encountered.
+	 *
+	 * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
+	 * @param int                         $stackPtr  The position of the current token in
+	 *                                               the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$phpcsFile->addWarning('Use of the GOTO language construct is discouraged', $stackPtr, 'Found');
+
+	}//end process()
 
 
 }//end class