Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 20 | class EventEditorGraphQLData |
||
| 21 | { |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var Datetimes $datetimes |
||
| 25 | */ |
||
| 26 | protected $datetimes; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var Prices $prices |
||
| 30 | */ |
||
| 31 | protected $prices; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var PriceTypes $price_types |
||
| 35 | */ |
||
| 36 | protected $price_types; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var Tickets $tickets |
||
| 40 | */ |
||
| 41 | protected $tickets; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var EventEntityRelations $relations |
||
| 45 | */ |
||
| 46 | protected $relations; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var NewEventDefaultEntities $default_entities |
||
| 50 | */ |
||
| 51 | protected $default_entities; |
||
| 52 | |||
| 53 | |||
| 54 | /** |
||
| 55 | * EventEditorGraphQLData constructor. |
||
| 56 | * |
||
| 57 | * @param Datetimes $datetimes |
||
| 58 | * @param Prices $prices |
||
| 59 | * @param PriceTypes $price_types |
||
| 60 | * @param Tickets $tickets |
||
| 61 | * @param EventEntityRelations $relations |
||
| 62 | * @param NewEventDefaultEntities $default_entities |
||
| 63 | */ |
||
| 64 | public function __construct( |
||
| 79 | |||
| 80 | |||
| 81 | /** |
||
| 82 | * @param int $eventId |
||
| 83 | * @return array |
||
| 84 | * @throws EE_Error |
||
| 85 | * @throws ReflectionException |
||
| 86 | * @since $VID:$ |
||
| 87 | */ |
||
| 88 | public function getData($eventId) |
||
| 124 | } |
||
| 125 |