Completed
Branch FET-8365-add-indexes (4b9253)
by
unknown
527:08 queued 512:28
created
core/db_models/relations/EE_HABTM_Relation.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,6 +17,7 @@  discard block
 block discarded – undo
17 17
 	 * get related models across the relation, and add-and-remove the relationships.
18 18
 	 * @param boolean $block_deletes for this type of relation, we block by default for now. if there are related models across this relation, block (prevent and add an error) the deletion of this model
19 19
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
20
+	 * @param string $joining_model_name
20 21
 	 */
21 22
 	function __construct($joining_model_name,$block_deletes = true, $blocking_delete_error_message =''){
22 23
 		$this->_joining_model_name = $joining_model_name;
@@ -24,7 +25,7 @@  discard block
 block discarded – undo
24 25
 	}
25 26
 	/**
26 27
 	 * Gets the joining model's object
27
-	 * @return EEM_Base
28
+	 * @return boolean
28 29
 	 */
29 30
 	function get_join_model(){
30 31
 		return $this->_get_model($this->_joining_model_name);
Please login to merge, or discard this patch.
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-require_once( EE_MODELS . 'relations/EE_Model_Relation_Base.php');
4
-class EE_HABTM_Relation extends EE_Model_Relation_Base{
3
+require_once(EE_MODELS.'relations/EE_Model_Relation_Base.php');
4
+class EE_HABTM_Relation extends EE_Model_Relation_Base {
5 5
 	/**
6 6
 	 * Model whicih defines the relation between two other models. Eg, the EE_Event_Question_Group model,
7 7
 	 * which joins EE_Event and EE_Question_Group
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 	 * @param boolean $block_deletes for this type of relation, we block by default for now. if there are related models across this relation, block (prevent and add an error) the deletion of this model
19 19
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
20 20
 	 */
21
-	function __construct($joining_model_name,$block_deletes = true, $blocking_delete_error_message =''){
21
+	function __construct($joining_model_name, $block_deletes = true, $blocking_delete_error_message = '') {
22 22
 		$this->_joining_model_name = $joining_model_name;
23 23
 		parent::__construct($block_deletes, $blocking_delete_error_message);
24 24
 	}
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	 * Gets the joining model's object
27 27
 	 * @return EEM_Base
28 28
 	 */
29
-	function get_join_model(){
29
+	function get_join_model() {
30 30
 		return $this->_get_model($this->_joining_model_name);
31 31
 	}
32 32
 	/**
@@ -34,21 +34,21 @@  discard block
 block discarded – undo
34 34
 	 * @param string $model_relation_chain like 'Event.Event_Venue.Venue'
35 35
 	 * @return string of SQL
36 36
 	 */
37
-	function get_join_to_intermediate_model_statement($model_relation_chain){
37
+	function get_join_to_intermediate_model_statement($model_relation_chain) {
38 38
 		//create sql like
39 39
 		//LEFT JOIN join_table AS join_table_alias ON this_table_alias.this_table_pk = join_table_alias.join_table_fk_to_this
40 40
 		//LEFT JOIN other_table AS other_table_alias ON join_table_alias.join_table_fk_to_other = other_table_alias.other_table_pk
41 41
 		//remember the model relation chain to the JOIN model, because we'll
42 42
 		//need it for get_join_statement()
43 43
 		$this->_model_relation_chain_to_join_model = $model_relation_chain;
44
-		$this_table_pk_field = $this->get_this_model()->get_primary_key_field();//get_foreign_key_to($this->get_other_model()->get_this_model_name());
44
+		$this_table_pk_field = $this->get_this_model()->get_primary_key_field(); //get_foreign_key_to($this->get_other_model()->get_this_model_name());
45 45
 		$join_table_fk_field_to_this_table = $this->get_join_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
46
-		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()) . $this_table_pk_field->get_table_alias();
46
+		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_pk_field->get_table_alias();
47 47
 
48
-		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_join_model()->get_this_model_name()) . $join_table_fk_field_to_this_table->get_table_alias();
48
+		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_join_model()->get_this_model_name()).$join_table_fk_field_to_this_table->get_table_alias();
49 49
 		$join_table = $this->get_join_model()->get_table_for_alias($join_table_alias);
50 50
 		//phew! ok, we have all the info we need, now we can create the SQL join string
51
-		$SQL = $this->_left_join($join_table, $join_table_alias, $join_table_fk_field_to_this_table->get_table_column(), $this_table_alias, $this_table_pk_field->get_table_column()) . $this->get_join_model()->_construct_internal_join_to_table_with_alias($join_table_alias);
51
+		$SQL = $this->_left_join($join_table, $join_table_alias, $join_table_fk_field_to_this_table->get_table_column(), $this_table_alias, $this_table_pk_field->get_table_column()).$this->get_join_model()->_construct_internal_join_to_table_with_alias($join_table_alias);
52 52
 
53 53
 		return $SQL;
54 54
 	}
@@ -60,18 +60,18 @@  discard block
 block discarded – undo
60 60
 	 * @param string $model_relation_chain like 'Event.Event_Venue.Venue'
61 61
 	 * @return string of SQL
62 62
 	 */
63
-	function get_join_statement($model_relation_chain){
64
-		if( $this->_model_relation_chain_to_join_model === NULL ){
65
-			throw new EE_Error( sprintf( __( 'When using EE_HABTM_Relation to create a join, you must call get_join_to_intermediate_model_statement BEFORE get_join_statement', 'event_espresso' )));
63
+	function get_join_statement($model_relation_chain) {
64
+		if ($this->_model_relation_chain_to_join_model === NULL) {
65
+			throw new EE_Error(sprintf(__('When using EE_HABTM_Relation to create a join, you must call get_join_to_intermediate_model_statement BEFORE get_join_statement', 'event_espresso')));
66 66
 		}
67 67
 		$join_table_fk_field_to_this_table = $this->get_join_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
68
-		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($this->_model_relation_chain_to_join_model, $this->get_join_model()->get_this_model_name()) . $join_table_fk_field_to_this_table->get_table_alias();
68
+		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($this->_model_relation_chain_to_join_model, $this->get_join_model()->get_this_model_name()).$join_table_fk_field_to_this_table->get_table_alias();
69 69
 		$other_table_pk_field = $this->get_other_model()->get_primary_key_field();
70 70
 		$join_table_fk_field_to_other_table = $this->get_join_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
71
-		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_pk_field->get_table_alias();
71
+		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_pk_field->get_table_alias();
72 72
 		$other_table = $this->get_other_model()->get_table_for_alias($other_table_alias);
73 73
 
74
-		$SQL = $this->_left_join($other_table, $other_table_alias, $other_table_pk_field->get_table_column(), $join_table_alias, $join_table_fk_field_to_other_table->get_table_column()) . $this->get_other_model()->_construct_internal_join_to_table_with_alias($other_table_alias);
74
+		$SQL = $this->_left_join($other_table, $other_table_alias, $other_table_pk_field->get_table_column(), $join_table_alias, $join_table_fk_field_to_other_table->get_table_column()).$this->get_other_model()->_construct_internal_join_to_table_with_alias($other_table_alias);
75 75
 		return $SQL;
76 76
 	}
77 77
 
@@ -84,36 +84,36 @@  discard block
 block discarded – undo
84 84
 	 * @param array             $where_query col=>val pairs that are used as extra conditions for checking existing values and for setting new rows if no exact matches.
85 85
 	 * @return EE_Base_Class
86 86
 	 */
87
-	 function add_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array() ){
87
+	 function add_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array()) {
88 88
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
89 89
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
90 90
 		//check if such a relationship already exists
91 91
 		 $join_model_fk_to_this_model = $this->get_join_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
92 92
 		 $join_model_fk_to_other_model = $this->get_join_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
93 93
 
94
-		 $cols_n_values =  array(
94
+		 $cols_n_values = array(
95 95
 				 $join_model_fk_to_this_model->get_name() => $this_model_obj->ID(),
96 96
 				 $join_model_fk_to_other_model->get_name() => $other_model_obj->ID());
97 97
 
98 98
 		 //if $where_query exists lets add them to the query_params.
99
-		 if ( !empty( $where_query ) ) {
99
+		 if ( ! empty($where_query)) {
100 100
 		 	//make sure we strip any of the join model names from the $where_query cause we don't need that in here (why? because client code may have used the same conditionals for get_all_related which DOES need the join model name)
101 101
 		 	//make sure we strip THIS models name from the query param
102
-		 	foreach ( $where_query as $query_param => $val ) {
103
-				$query_param = str_replace($this->get_join_model()->get_this_model_name().".","", $query_param);
102
+		 	foreach ($where_query as $query_param => $val) {
103
+				$query_param = str_replace($this->get_join_model()->get_this_model_name().".", "", $query_param);
104 104
 				$parsed_query[$query_param] = $val;
105 105
 			}
106
-		 	$cols_n_values = array_merge( $cols_n_values, $parsed_query );
106
+		 	$cols_n_values = array_merge($cols_n_values, $parsed_query);
107 107
 		 }
108 108
 
109
-		 $query_params = array( $cols_n_values );
109
+		 $query_params = array($cols_n_values);
110 110
 
111 111
 
112 112
 		 $existing_entry_in_join_table = $this->get_join_model()->get_one($query_params);
113 113
 		//if there is already an entry in the join table, indicating a relationship, we're done
114 114
 		 //again, if you want more sophisticated logic or insertions (handling more columns than just 2 foreign keys to
115 115
 		 //the other tables, use the joining model directly!
116
-		 if( ! $existing_entry_in_join_table ){
116
+		 if ( ! $existing_entry_in_join_table) {
117 117
 			$this->get_join_model()->insert($cols_n_values);
118 118
 		}
119 119
 		return $other_model_obj;
@@ -125,29 +125,29 @@  discard block
 block discarded – undo
125 125
 	 * * @param array           $where_query col=>val pairs that are used as extra conditions for checking existing values and for removing existing rows if exact matches exist.
126 126
 	 * @return EE_Base_Class
127 127
 	 */
128
-	 function remove_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array() ){
128
+	 function remove_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array()) {
129 129
 		  $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
130 130
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
131 131
 		//check if such a relationship already exists
132 132
 		 $join_model_fk_to_this_model = $this->get_join_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
133 133
 		 $join_model_fk_to_other_model = $this->get_join_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
134 134
 
135
-		 $cols_n_values =  array(
135
+		 $cols_n_values = array(
136 136
 				 $join_model_fk_to_this_model->get_name() => $this_model_obj->ID(),
137 137
 				 $join_model_fk_to_other_model->get_name() => $other_model_obj->ID());
138 138
 
139 139
 		//if $where_query exists lets add them to the query_params.
140
-		 if ( !empty( $where_query ) ) {
140
+		 if ( ! empty($where_query)) {
141 141
 		 	//make sure we strip any of the join model names from the $where_query cause we don't need that in here (why? because client code may have used the same conditionals for get_all_related which DOES need the join model name)
142 142
 		 	//make sure we strip THIS models name from the query param
143
-		 	foreach ( $where_query as $query_param => $val ) {
144
-				$query_param = str_replace($this->get_join_model()->get_this_model_name().".","", $query_param);
143
+		 	foreach ($where_query as $query_param => $val) {
144
+				$query_param = str_replace($this->get_join_model()->get_this_model_name().".", "", $query_param);
145 145
 				$parsed_query[$query_param] = $val;
146 146
 			}
147
-		 	$cols_n_values = array_merge( $cols_n_values, $parsed_query );
147
+		 	$cols_n_values = array_merge($cols_n_values, $parsed_query);
148 148
 		 }
149 149
 
150
-		 $existing_entry_in_join_table = $this->get_join_model()->delete( array($cols_n_values) );
150
+		 $existing_entry_in_join_table = $this->get_join_model()->delete(array($cols_n_values));
151 151
 		return $other_model_obj;
152 152
 	 }
153 153
 }
Please login to merge, or discard this patch.
core/db_models/relations/EE_Has_Many_Revision_Relation.php 4 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
32 32
 	 * this model. IE, there can be many other model objects related to one of this model's objects (but NOT through a JOIN table,
33 33
 	 * which is the case for EE_HABTM_Relations). This knows how to join the models,
34 34
 	 * get related models across the relation, and add-and-remove the relationships.
35
-	 * @param string $primary_pk_field See property description for details
36
-	 * @param string $parent_cpt_field This is the field that is "connected" to the $primary_cpt_field.  See property desc for details.
35
+	 * @param string $primary_cpt_field See property description for details
36
+	 * @param string $primary_cpt_field This is the field that is "connected" to the $primary_cpt_field.  See property desc for details.
37 37
 	 * @param boolean $block_deletes For this type of relation, we block by default. If there are related models across this relation, block (prevent and add an error) the deletion of this model
38 38
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
39 39
 	 */
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 	 /**
191 191
 	 * Basically this method gets called to verify if the incoming object needs to be manipulated somewhat because it is a revision save.  If so, then we change things before sending back.  We also do verifications when this IS NOT an revision because we always need to make sure that the autosave/revision has parent recorded (which is sometime delayed if the object is created/saved first by the autosave)
192 192
 	 *
193
-	 * @param  EE_Base_Class $this_model_obj
193
+	 * @param  EE_Base_Class $this_obj
194 194
 	 * @param  EE_Base_Class $other_obj
195 195
 	 * @param  boolean       $remove_relation Indicates whether we're doing a remove_relation or add_relation.
196 196
 	 * @return EE_Base_Class. ($other_obj);
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,8 +60,9 @@  discard block
 block discarded – undo
60 60
 		 $other_model_obj = $this->_check_for_revision($this_model_obj, $other_model_obj);
61 61
 
62 62
 		 //if is array, then we've already done the add_relation so let's get out
63
-		if ( is_array( $other_model_obj ) )
64
-			return $other_model_obj[0];
63
+		if ( is_array( $other_model_obj ) ) {
64
+					return $other_model_obj[0];
65
+		}
65 66
 
66 67
 		 //find the field on th eother model which is a foreign key to this model
67 68
 		 $fk_field_on_other_model = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
@@ -88,8 +89,9 @@  discard block
 block discarded – undo
88 89
 
89 90
 
90 91
 		//if is array, then we've already done the add_relation so let's get out
91
-		if ( is_array( $other_model_obj ) )
92
-			return $other_model_obj[0];
92
+		if ( is_array( $other_model_obj ) ) {
93
+					return $other_model_obj[0];
94
+		}
93 95
 
94 96
 
95 97
 		 //find the field on th eother model which is a foreign key to this model
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -185,13 +185,13 @@
 block discarded – undo
185 185
 
186 186
 
187 187
 	 /**
188
-	 * Basically this method gets called to verify if the incoming object needs to be manipulated somewhat because it is a revision save.  If so, then we change things before sending back.  We also do verifications when this IS NOT an revision because we always need to make sure that the autosave/revision has parent recorded (which is sometime delayed if the object is created/saved first by the autosave)
189
-	 *
190
-	 * @param  EE_Base_Class $this_model_obj
191
-	 * @param  EE_Base_Class $other_obj
192
-	 * @param  boolean       $remove_relation Indicates whether we're doing a remove_relation or add_relation.
193
-	 * @return EE_Base_Class. ($other_obj); 
194
-	 */
188
+	  * Basically this method gets called to verify if the incoming object needs to be manipulated somewhat because it is a revision save.  If so, then we change things before sending back.  We also do verifications when this IS NOT an revision because we always need to make sure that the autosave/revision has parent recorded (which is sometime delayed if the object is created/saved first by the autosave)
189
+	  *
190
+	  * @param  EE_Base_Class $this_model_obj
191
+	  * @param  EE_Base_Class $other_obj
192
+	  * @param  boolean       $remove_relation Indicates whether we're doing a remove_relation or add_relation.
193
+	  * @return EE_Base_Class. ($other_obj); 
194
+	  */
195 195
 	protected function _check_for_revision( $this_obj, $other_obj, $remove_relation = FALSE ) {
196 196
 		$pk_on_related_model = $this->get_other_model()->get_primary_key_field()->get_name();
197 197
 		//now we need to determine if we're in a WP revision save cause if we are we need to do some special handling
Please login to merge, or discard this patch.
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@  discard block
 block discarded – undo
4 4
 /**
5 5
  * In this relation, the OTHER model ahs the foreign key pointing to this model
6 6
  */
7
-require_once( EE_MODELS . 'relations/EE_Has_Many_Relation.php');
8
-class EE_Has_Many_Revision_Relation extends EE_Has_Many_Relation{	
7
+require_once(EE_MODELS.'relations/EE_Has_Many_Relation.php');
8
+class EE_Has_Many_Revision_Relation extends EE_Has_Many_Relation {	
9 9
 
10 10
 
11 11
 	/**
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 * @param boolean $block_deletes For this type of relation, we block by default. If there are related models across this relation, block (prevent and add an error) the deletion of this model
38 38
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
39 39
 	 */
40
-	function __construct($primary_cpt_field, $parent_pk_relation_field, $block_deletes = true, $blocking_delete_error_message = null){
40
+	function __construct($primary_cpt_field, $parent_pk_relation_field, $block_deletes = true, $blocking_delete_error_message = null) {
41 41
 		$this->_primary_cpt_field = $primary_cpt_field;
42 42
 		$this->_parent_pk_relation_field = $parent_pk_relation_field;
43 43
 		parent::__construct($block_deletes, $blocking_delete_error_message);
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @param EE_Base_Class/int $other_obj_or_id
53 53
 	 * @return EE_Base_Class
54 54
 	 */
55
-	 function add_relation_to($this_obj_or_id, $other_obj_or_id ){
55
+	 function add_relation_to($this_obj_or_id, $other_obj_or_id) {
56 56
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
57 57
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id);
58 58
 		 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 		 $other_model_obj = $this->_check_for_revision($this_model_obj, $other_model_obj);
61 61
 
62 62
 		 //if is array, then we've already done the add_relation so let's get out
63
-		if ( is_array( $other_model_obj ) )
63
+		if (is_array($other_model_obj))
64 64
 			return $other_model_obj[0];
65 65
 
66 66
 		 //find the field on th eother model which is a foreign key to this model
@@ -80,15 +80,15 @@  discard block
 block discarded – undo
80 80
 	 * @param EE_Base_Class/int $other_obj_or_id
81 81
 	 * @return EE_Base_Class
82 82
 	 */
83
-	 function remove_relation_to($this_obj_or_id, $other_obj_or_id){
83
+	 function remove_relation_to($this_obj_or_id, $other_obj_or_id) {
84 84
 	 	$this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id);
85 85
 		$other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id);
86 86
 		//handle possible revisions
87
-		$other_model_obj = $this->_check_for_revision( $this_model_obj, $other_model_obj, TRUE );
87
+		$other_model_obj = $this->_check_for_revision($this_model_obj, $other_model_obj, TRUE);
88 88
 
89 89
 
90 90
 		//if is array, then we've already done the add_relation so let's get out
91
-		if ( is_array( $other_model_obj ) )
91
+		if (is_array($other_model_obj))
92 92
 			return $other_model_obj[0];
93 93
 
94 94
 
@@ -97,12 +97,12 @@  discard block
 block discarded – undo
97 97
 
98 98
 		
99 99
 		 //set that field on the other model to this model's ID
100
-		 if ( $this->_blocking_delete ) {
101
-		 	$other_model_obj->set($fk_field_on_other_model->get_name(),null,true);
100
+		 if ($this->_blocking_delete) {
101
+		 	$other_model_obj->set($fk_field_on_other_model->get_name(), null, true);
102 102
 		 	$other_model_obj->save();
103 103
 		 } else {
104 104
 		 	$other_model_obj->delete();
105
-		 	$other_model_obj->set($fk_field_on_other_model->get_name(),null,true);
105
+		 	$other_model_obj->set($fk_field_on_other_model->get_name(), null, true);
106 106
 		 	return $other_model_obj;
107 107
 		 }
108 108
 		 return $other_model_obj;
@@ -118,14 +118,14 @@  discard block
 block discarded – undo
118 118
 	  * @param  boolean $values_already_prepared_by_model_object 
119 119
 	  * @return EE_Base_Class[]                                         
120 120
 	  */
121
-	 public function get_all_related( $model_object_or_id, $query_params = array(), $values_already_prepared_by_model_object = false ) {
121
+	 public function get_all_related($model_object_or_id, $query_params = array(), $values_already_prepared_by_model_object = false) {
122 122
 	 	
123 123
 	 	//if this is an autosave then we're going to get things differently
124
-	 	if ( defined('DOING_AUTOSAVE') && DOING_AUTOSAVE ) {
124
+	 	if (defined('DOING_AUTOSAVE') && DOING_AUTOSAVE) {
125 125
 	 		return $this->_do_autosave_get_all($model_object_or_id, $query_params, $values_already_prepared_by_model_object = false);
126 126
 	 	}
127 127
 
128
-	 	return parent::get_all_related( $model_object_or_id, $query_params, $values_already_prepared_by_model_object );
128
+	 	return parent::get_all_related($model_object_or_id, $query_params, $values_already_prepared_by_model_object);
129 129
 	 }
130 130
 
131 131
 
@@ -138,22 +138,22 @@  discard block
 block discarded – undo
138 138
 	  * @access protected
139 139
 	  * @return EE_Base_Class[]        
140 140
 	  */
141
-	 protected function _do_autosave_get_all( $model_object_or_id, $query_params, $values_already_prepared_by_model_object = false ) {
141
+	 protected function _do_autosave_get_all($model_object_or_id, $query_params, $values_already_prepared_by_model_object = false) {
142 142
 
143 143
 	 	//first we check if the post_id for the incoming query is for an autosave.  If it isn't that's what we want!
144
-	 	$model_object_id = $this->_get_model_object_id( $model_object_or_id );
144
+	 	$model_object_id = $this->_get_model_object_id($model_object_or_id);
145 145
 
146
-	 	$autosave = wp_get_post_autosave( $model_object_id );
146
+	 	$autosave = wp_get_post_autosave($model_object_id);
147 147
 	 	$id_to_use = $autosave ? $autosave->ID : $model_object_id;
148 148
 
149
-	 	$autosave_relations =  parent::get_all_related( $id_to_use, $query_params, $values_already_prepared_by_model_object );
149
+	 	$autosave_relations = parent::get_all_related($id_to_use, $query_params, $values_already_prepared_by_model_object);
150 150
 	 	$parent_ids = $parents = array();
151 151
 	 	$return_objs = array();
152 152
 		
153 153
 		//k this is where things differ because NOW what we're going to do is get the PARENTS for the get all related (and we'll also start setting up the return_objs array containing related that DON'T have parent ids, for those that DON'T have parents to merge with our returned objects);
154
-		foreach ( $autosave_relations as $a_r ) {
154
+		foreach ($autosave_relations as $a_r) {
155 155
 			$pid = $a_r->parent();
156
-			if ( !empty( $pid ) ) {
156
+			if ( ! empty($pid)) {
157 157
 				$parent_ids[] = $pid;
158 158
 			} else {
159 159
 				$return_objs[] = $a_r;
@@ -164,14 +164,14 @@  discard block
 block discarded – undo
164 164
 		$originals = parent::get_all_related($model_object_or_id, $query_params, $values_already_prepared_by_model_object);
165 165
 
166 166
 		//merge $originals with $return_objs
167
-		if ( $originals ) {
167
+		if ($originals) {
168 168
 			$return_objs = array_merge($originals, $return_objs);
169 169
 		}
170 170
 
171 171
 		//now we setup the query to get all the parents
172
-		if ( !empty( $parent_ids ) ) {
172
+		if ( ! empty($parent_ids)) {
173 173
 			$query_param_where_this_model_pk = $this->get_this_model()->get_this_model_name().".".$this->get_this_model()->get_primary_key_field()->get_name();
174
-			$query_param[0][$query_param_where_this_model_pk] = array('IN', $parent_ids );
174
+			$query_param[0][$query_param_where_this_model_pk] = array('IN', $parent_ids);
175 175
 			$parents = $this->get_other_model()->get_all($query_param);
176 176
 		}
177 177
 
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
 
181 181
 		//now merge parents with our current $return_objs and send back
182
-		return array_merge( $parents, $return_objs );
182
+		return array_merge($parents, $return_objs);
183 183
 	 }
184 184
 
185 185
 
@@ -192,42 +192,42 @@  discard block
 block discarded – undo
192 192
 	 * @param  boolean       $remove_relation Indicates whether we're doing a remove_relation or add_relation.
193 193
 	 * @return EE_Base_Class. ($other_obj); 
194 194
 	 */
195
-	protected function _check_for_revision( $this_obj, $other_obj, $remove_relation = FALSE ) {
195
+	protected function _check_for_revision($this_obj, $other_obj, $remove_relation = FALSE) {
196 196
 		$pk_on_related_model = $this->get_other_model()->get_primary_key_field()->get_name();
197 197
 		//now we need to determine if we're in a WP revision save cause if we are we need to do some special handling
198
-		if (  $this_obj->post_type() == 'revision' ) {
198
+		if ($this_obj->post_type() == 'revision') {
199 199
 			//first if $other_obj fk = this_obj pk then we know that this is a pk object, let's make sure there is a matching set for the autosave if there is then we save over it, if there isn't then we need to create a new one.
200 200
 			$parent_evt_id = $this_obj->parent();
201 201
 			/*var_dump($parent_evt_id);
202 202
 			var_dump($this_obj);
203 203
 			var_dump($other_obj);/**/
204 204
 
205
-			if ( !empty($parent_evt_id) && $parent_evt_id == $other_obj->get($this->_primary_cpt_field) ) {
205
+			if ( ! empty($parent_evt_id) && $parent_evt_id == $other_obj->get($this->_primary_cpt_field)) {
206 206
 				//let's do query on this objects model to see if the incoming pk value on the obj matches any parents in this objects table.
207
-				$has_parent_obj = $this->get_other_model()->get_one( array( array( $this->_parent_pk_relation_field => $other_obj->ID(), $this->_primary_cpt_field => $this_obj->ID() ) ) );
207
+				$has_parent_obj = $this->get_other_model()->get_one(array(array($this->_parent_pk_relation_field => $other_obj->ID(), $this->_primary_cpt_field => $this_obj->ID())));
208 208
 
209
-				if ( $has_parent_obj ) {
209
+				if ($has_parent_obj) {
210 210
 					//this makes sure the update on the current obj happens to the revision's row NOT the parent row.
211 211
 					
212
-					$other_obj->set( $this->_parent_pk_relation_field, $other_obj->ID());
213
-					$other_obj->set($pk_on_related_model, $has_parent_obj->ID() );
212
+					$other_obj->set($this->_parent_pk_relation_field, $other_obj->ID());
213
+					$other_obj->set($pk_on_related_model, $has_parent_obj->ID());
214 214
 					$other_obj->set($this->_primary_cpt_field, $this_obj->ID());
215 215
 
216
-					if ( !$remove_relation ) {
216
+					if ( ! $remove_relation) {
217 217
 						$other_obj->save();
218
-						return array( $other_obj ); 
219
-					} elseif ( $remove_relation && !$this->_blocking_delete) {
218
+						return array($other_obj); 
219
+					} elseif ($remove_relation && ! $this->_blocking_delete) {
220 220
 						$other_obj->delete();
221 221
 						$other_obj->set($this->_parent_pk_relation_field, NULL, true);
222 222
 						return array($other_obj);
223 223
 					}
224 224
 			
225 225
 				} else {
226
-					$other_obj->set( $this->_parent_pk_relation_field, $other_obj->ID() );
227
-					$other_obj->set( $this->_primary_cpt_field, $this_obj->ID() );
226
+					$other_obj->set($this->_parent_pk_relation_field, $other_obj->ID());
227
+					$other_obj->set($this->_primary_cpt_field, $this_obj->ID());
228 228
 					$other_obj->set($pk_on_related_model, NULL, true); //ensure we create a new row for the autosave with parent id the same as the incoming ID.
229 229
 					$other_obj->save(); //make sure we insert.
230
-					return array( $other_obj );
230
+					return array($other_obj);
231 231
 				}
232 232
 			}
233 233
 
@@ -240,24 +240,24 @@  discard block
 block discarded – undo
240 240
 		} else {
241 241
 			
242 242
 			//we only need to do the below IF this is not a remove relation
243
-			if ( !$remove_relation ) {
243
+			if ( ! $remove_relation) {
244 244
 				//okay this is is a normal update/save/remove so, let's make sure the other object is not a revision of the current object.
245 245
 				//the other object will likely NOT have the correct fk on it (which is the primary_cpt_field_mame) so we must retrieve from the db to get that first.
246 246
 				$existing_other_obj = $this->get_other_model()->get_one_by_ID($other_obj->ID());
247 247
 				$potential_revision_id = is_object($existing_other_obj) ? $existing_other_obj->get($this->_primary_cpt_field) : NULL;
248 248
 
249
-				if ( $parent_this_obj_id = wp_is_post_revision($potential_revision_id) ) {
249
+				if ($parent_this_obj_id = wp_is_post_revision($potential_revision_id)) {
250 250
 					//yes the OTHER object is linked to the revision of the parent, not the parent itself. That means we need to make the other_object an attachment of this_obj and then duplicate other_obj for the revision.
251
-					$other_obj->set($this->_primary_cpt_field, $this_obj->ID() );
251
+					$other_obj->set($this->_primary_cpt_field, $this_obj->ID());
252 252
 					$other_obj->save();
253 253
 
254 254
 					//now create a new other_obj and fill with details from existing object
255 255
 					$new_obj = $other_obj;
256
-					$new_obj->set( $this->_primary_cpt_field, $potential_revision_id );
257
-					$new_obj->set( $this->_parent_pk_relation_field, $other_obj->ID() );
258
-					$new_obj->set( $pk_on_related_model, NULL );
256
+					$new_obj->set($this->_primary_cpt_field, $potential_revision_id);
257
+					$new_obj->set($this->_parent_pk_relation_field, $other_obj->ID());
258
+					$new_obj->set($pk_on_related_model, NULL);
259 259
 					$new_obj->save();
260
-					return array( $new_obj );
260
+					return array($new_obj);
261 261
 				}
262 262
 
263 263
 			}
Please login to merge, or discard this patch.
core/db_models/relations/EE_Model_Relation_Base.php 3 patches
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
 
52 52
 	/**
53
-	 * @param $this_model_name
53
+	 * @param string $this_model_name
54 54
 	 * @param $other_model_name
55 55
 	 * @throws EE_Error
56 56
 	 */
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
 	/**
69 69
 	 * Gets the model where this relation is defined.
70
-	 * @return EEM_Base
70
+	 * @return boolean
71 71
 	 */
72 72
 	function get_this_model(){
73 73
 		return $this->_get_model($this->_this_model_name);
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	/**
79 79
 	 * Gets the model which this relation establishes the relation TO (ie,
80 80
 	 * this relation object was defined on get_this_model(), get_other_model() is the other one)
81
-	 * @return EEM_Base
81
+	 * @return boolean
82 82
 	 */
83 83
 	function get_other_model(){
84 84
 		return $this->_get_model($this->_other_model_name);
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	/**
90 90
 	 * Internally used by get_this_model() and get_other_model()
91 91
 	 * @param string $model_name like Event, Question_Group, etc. omit the EEM_
92
-	 * @return EEM_Base
92
+	 * @return boolean
93 93
 	 */
94 94
 	protected function _get_model($model_name){
95 95
 		$modelInstance = EE_Registry::instance()->load_model( $model_name );
@@ -112,9 +112,9 @@  discard block
 block discarded – undo
112 112
 
113 113
 	/**
114 114
 	 * @param        $other_table
115
-	 * @param        $other_table_alias
115
+	 * @param        string $other_table_alias
116 116
 	 * @param        $other_table_column
117
-	 * @param        $this_table_alias
117
+	 * @param        string $this_table_alias
118 118
 	 * @param        $this_table_join_column
119 119
 	 * @param string $extra_join_sql
120 120
 	 * @return string
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 	 * parameters are specified, then all related model objects will be deleted.
169 169
 	 * Note: If the related model is extends EEM_Soft_Delete_Base, then the related
170 170
 	 * model objects will only be soft-deleted.
171
-	 * @param EE_Base_Class|int|string $model_object_or_id
171
+	 * @param EE_Base_Class $model_object_or_id
172 172
 	 * @param array $query_params
173 173
 	 * @return int of how many related models got deleted
174 174
 	 */
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 	 * parameters are specified, then all related model objects will be deleted.
197 197
 	 * Note: If the related model is extends EEM_Soft_Delete_Base, then the related
198 198
 	 * model objects will only be soft-deleted.
199
-	 * @param EE_Base_Class|int|string $model_object_or_id
199
+	 * @param EE_Base_Class $model_object_or_id
200 200
 	 * @param array $query_params
201 201
 	 * @return int of how many related models got deleted
202 202
 	 */
Please login to merge, or discard this patch.
Braces   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -104,8 +104,9 @@  discard block
 block discarded – undo
104 104
 	 * @param string $timezone timezone to set.
105 105
 	 */
106 106
 	public function set_timezone( $timezone ) {
107
-		if($timezone !== NULL)
108
-			$this->_timezone = $timezone;
107
+		if($timezone !== NULL) {
108
+					$this->_timezone = $timezone;
109
+		}
109 110
 	}
110 111
 
111 112
 
@@ -213,12 +214,12 @@  discard block
 block discarded – undo
213 214
 				$deleted_count++;
214 215
 				if( ! $delete_is_blocked ){
215 216
 					$related_model_object->delete_permanently();
216
-				}else{
217
+				} else{
217 218
 					//delete is blocked
218 219
 					//brent and darren, in this case, wanted to just soft delete it then
219 220
 					$related_model_object->delete();
220 221
 				}
221
-			}else{
222
+			} else{
222 223
 				//its not a soft-deletable thing anyways. do the normal logic.
223 224
 				if( ! $delete_is_blocked ){
224 225
 					$this->remove_relation_to($model_object_or_id, $related_model_object);
@@ -241,7 +242,7 @@  discard block
 block discarded – undo
241 242
 	protected function _get_model_object_id($model_object_or_id) {
242 243
 		if($model_object_or_id instanceof EE_Base_Class){
243 244
 			$model_object_id = $model_object_or_id->ID();
244
-		}else{
245
+		} else{
245 246
 			$model_object_id = $model_object_or_id;
246 247
 		}
247 248
 		if( ! $model_object_id){
@@ -316,7 +317,7 @@  discard block
 block discarded – undo
316 317
 	public function get_deletion_error_message(){
317 318
 		if($this->_blocking_delete_error_message){
318 319
 			return $this->_blocking_delete_error_message;
319
-		}else{
320
+		} else{
320 321
 //			return sprintf(__('Cannot delete %1$s when there are related %2$s', "event_espresso"),$this->get_this_model()->item_name(2),$this->get_other_model()->item_name(2));
321 322
 			return sprintf(
322 323
 				__( 'This %1$s is currently linked to one or more %2$s records. If this %1$s is incorrect, then please remove it from all %3$s before attempting to delete it.', "event_espresso"),
Please login to merge, or discard this patch.
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
  * Once those two models are setup correctly, and the relation object has the names of each, it can
8 8
  * magically figure out what tables must be joined on what fields during querying.
9 9
  */
10
-abstract class EE_Model_Relation_Base{
10
+abstract class EE_Model_Relation_Base {
11 11
 	/**
12 12
 	 * The model name of which this relation is a component (ie, the model that called new EE_Model_Relation_Base)
13 13
 	 * @var string eg Event, Question_Group, Registration
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 	 * @param boolean $block_deletes if there are related models across this relation, block (prevent and add an error) the deletion of this model
43 43
 	 * @param string $blocking_delete_error_message a customized error message on blocking deletes instead of the default
44 44
 	 */
45
-	function __construct($block_deletes, $blocking_delete_error_message){
45
+	function __construct($block_deletes, $blocking_delete_error_message) {
46 46
 		$this->_blocking_delete = $block_deletes;
47
-		$this->_blocking_delete_error_message=$blocking_delete_error_message;
47
+		$this->_blocking_delete_error_message = $blocking_delete_error_message;
48 48
 	}
49 49
 
50 50
 
@@ -54,12 +54,12 @@  discard block
 block discarded – undo
54 54
 	 * @param $other_model_name
55 55
 	 * @throws EE_Error
56 56
 	 */
57
-	function _construct_finalize_set_models($this_model_name, $other_model_name){
57
+	function _construct_finalize_set_models($this_model_name, $other_model_name) {
58 58
 		$this->_this_model_name = $this_model_name;
59 59
 		$this->_other_model_name = $other_model_name;
60
-		if(is_string($this->_blocking_delete)){
60
+		if (is_string($this->_blocking_delete)) {
61 61
 			throw new EE_Error(sprintf(__("When instantiating the relation of type %s from %s to %s, the \$block_deletes argument should be a boolean, not a string (%s)", "event_espresso"),
62
-						get_class($this),$this_model_name,$other_model_name,$this->_blocking_delete));
62
+						get_class($this), $this_model_name, $other_model_name, $this->_blocking_delete));
63 63
 		}
64 64
 	}
65 65
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 * Gets the model where this relation is defined.
70 70
 	 * @return EEM_Base
71 71
 	 */
72
-	function get_this_model(){
72
+	function get_this_model() {
73 73
 		return $this->_get_model($this->_this_model_name);
74 74
 	}
75 75
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * this relation object was defined on get_this_model(), get_other_model() is the other one)
81 81
 	 * @return EEM_Base
82 82
 	 */
83
-	function get_other_model(){
83
+	function get_other_model() {
84 84
 		return $this->_get_model($this->_other_model_name);
85 85
 	}
86 86
 
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
91 91
 	 * @param string $model_name like Event, Question_Group, etc. omit the EEM_
92 92
 	 * @return EEM_Base
93 93
 	 */
94
-	protected function _get_model($model_name){
95
-		$modelInstance = EE_Registry::instance()->load_model( $model_name );
96
-		$modelInstance->set_timezone( $this->_timezone );
94
+	protected function _get_model($model_name) {
95
+		$modelInstance = EE_Registry::instance()->load_model($model_name);
96
+		$modelInstance->set_timezone($this->_timezone);
97 97
 		return $modelInstance;
98 98
 	}
99 99
 
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
 	 * entirely possible that relations may be called from a model and we need to make sure those relations have their timezone set correctly.
104 104
 	 * @param string $timezone timezone to set.
105 105
 	 */
106
-	public function set_timezone( $timezone ) {
107
-		if($timezone !== NULL)
106
+	public function set_timezone($timezone) {
107
+		if ($timezone !== NULL)
108 108
 			$this->_timezone = $timezone;
109 109
 	}
110 110
 
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
 	 * @param string $extra_join_sql
120 120
 	 * @return string
121 121
 	 */
122
-	protected function _left_join($other_table,$other_table_alias,$other_table_column,$this_table_alias,$this_table_join_column, $extra_join_sql = ''){
123
-		return " LEFT JOIN ".$other_table." AS ".$other_table_alias. " ON ".$other_table_alias.".".$other_table_column."=".$this_table_alias.".".$this_table_join_column. ($extra_join_sql ? " AND $extra_join_sql" : '');
122
+	protected function _left_join($other_table, $other_table_alias, $other_table_column, $this_table_alias, $this_table_join_column, $extra_join_sql = '') {
123
+		return " LEFT JOIN ".$other_table." AS ".$other_table_alias." ON ".$other_table_alias.".".$other_table_column."=".$this_table_alias.".".$this_table_join_column.($extra_join_sql ? " AND $extra_join_sql" : '');
124 124
 	}
125 125
 
126 126
 
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
136 136
 	 * @param boolean $values_already_prepared_by_model_object
137 137
 	 * @return EE_Base_Class[]
138 138
 	 */
139
-	public function get_all_related($model_object_or_id, $query_params = array(), $values_already_prepared_by_model_object = false){
139
+	public function get_all_related($model_object_or_id, $query_params = array(), $values_already_prepared_by_model_object = false) {
140 140
 		$query_params = $this->_disable_default_where_conditions_on_query_param($query_params);
141 141
 		$query_param_where_this_model_pk = $this->get_this_model()->get_this_model_name().".".$this->get_this_model()->get_primary_key_field()->get_name();
142
-		$model_object_id = $this->_get_model_object_id( $model_object_or_id );
142
+		$model_object_id = $this->_get_model_object_id($model_object_or_id);
143 143
 		$query_params[0][$query_param_where_this_model_pk] = $model_object_id;
144 144
 		return $this->get_other_model()->get_all($query_params);
145 145
 	}
@@ -151,9 +151,9 @@  discard block
 block discarded – undo
151 151
 	 * @param string $query_params
152 152
 	 * @return string
153 153
 	 */
154
-	protected function _disable_default_where_conditions_on_query_param($query_params){
155
-		if( ! isset($query_params['default_where_conditions'])){
156
-			$query_params['default_where_conditions']='none';
154
+	protected function _disable_default_where_conditions_on_query_param($query_params) {
155
+		if ( ! isset($query_params['default_where_conditions'])) {
156
+			$query_params['default_where_conditions'] = 'none';
157 157
 		}
158 158
 		return $query_params;
159 159
 	}
@@ -169,15 +169,15 @@  discard block
 block discarded – undo
169 169
 	 * @param array $query_params
170 170
 	 * @return int of how many related models got deleted
171 171
 	 */
172
-	public function delete_all_related($model_object_or_id,$query_params = array()){
172
+	public function delete_all_related($model_object_or_id, $query_params = array()) {
173 173
 		//for each thing we would delete,
174
-		$related_model_objects = $this->get_all_related($model_object_or_id,$query_params);
174
+		$related_model_objects = $this->get_all_related($model_object_or_id, $query_params);
175 175
 		//determine if it's blocked by anything else before it can be deletedx
176 176
 		$deleted_count = 0;
177
-		foreach($related_model_objects as $related_model_object){
177
+		foreach ($related_model_objects as $related_model_object) {
178 178
 			$delete_is_blocked = $this->get_other_model()->delete_is_blocked_by_related_models($related_model_object, $model_object_or_id);
179 179
 			/* @var $model_object_or_id EE_Base_Class */
180
-			if( ! $delete_is_blocked ){
180
+			if ( ! $delete_is_blocked) {
181 181
 				$this->remove_relation_to($model_object_or_id, $related_model_object);
182 182
 				$related_model_object->delete();
183 183
 				$deleted_count++;
@@ -197,27 +197,27 @@  discard block
 block discarded – undo
197 197
 	 * @param array $query_params
198 198
 	 * @return int of how many related models got deleted
199 199
 	 */
200
-	public function delete_related_permanently($model_object_or_id,$query_params = array()){
200
+	public function delete_related_permanently($model_object_or_id, $query_params = array()) {
201 201
 		//for each thing we would delete,
202
-		$related_model_objects = $this->get_all_related($model_object_or_id,$query_params);
202
+		$related_model_objects = $this->get_all_related($model_object_or_id, $query_params);
203 203
 		//determine if it's blocked by anything else before it can be deletedx
204 204
 		$deleted_count = 0;
205
-		foreach($related_model_objects as $related_model_object){
205
+		foreach ($related_model_objects as $related_model_object) {
206 206
 			$delete_is_blocked = $this->get_other_model()->delete_is_blocked_by_related_models($related_model_object, $model_object_or_id);
207 207
 			/* @var $model_object_or_id EE_Base_Class */
208
-			if( $related_model_object instanceof EE_Soft_Delete_Base_Class ){
208
+			if ($related_model_object instanceof EE_Soft_Delete_Base_Class) {
209 209
 				$this->remove_relation_to($model_object_or_id, $related_model_object);
210 210
 				$deleted_count++;
211
-				if( ! $delete_is_blocked ){
211
+				if ( ! $delete_is_blocked) {
212 212
 					$related_model_object->delete_permanently();
213
-				}else{
213
+				} else {
214 214
 					//delete is blocked
215 215
 					//brent and darren, in this case, wanted to just soft delete it then
216 216
 					$related_model_object->delete();
217 217
 				}
218
-			}else{
218
+			} else {
219 219
 				//its not a soft-deletable thing anyways. do the normal logic.
220
-				if( ! $delete_is_blocked ){
220
+				if ( ! $delete_is_blocked) {
221 221
 					$this->remove_relation_to($model_object_or_id, $related_model_object);
222 222
 					$related_model_object->delete();
223 223
 					$deleted_count++;
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 	 * @return int
237 237
 	 */
238 238
 	protected function _get_model_object_id($model_object_or_id) {
239
-		if($model_object_or_id instanceof EE_Base_Class){
239
+		if ($model_object_or_id instanceof EE_Base_Class) {
240 240
 			$model_object_id = $model_object_or_id->ID();
241
-		}else{
241
+		} else {
242 242
 			$model_object_id = $model_object_or_id;
243 243
 		}
244
-		if( ! $model_object_id){
245
-			throw new EE_Error(sprintf(__("Sorry, we cant get the related %s model objects to %s model object before it has an ID. You can solve that by just saving it before trying to get its related model objects", "event_espresso"),$this->get_other_model()->get_this_model_name(),$this->get_this_model()->get_this_model_name()));
244
+		if ( ! $model_object_id) {
245
+			throw new EE_Error(sprintf(__("Sorry, we cant get the related %s model objects to %s model object before it has an ID. You can solve that by just saving it before trying to get its related model objects", "event_espresso"), $this->get_other_model()->get_this_model_name(), $this->get_this_model()->get_this_model_name()));
246 246
 		}
247 247
 		return $model_object_id;
248 248
 	}
@@ -285,10 +285,10 @@  discard block
 block discarded – undo
285 285
 	 * @param array $where_query_param  like EEM_Base::get_all's $query_params[0] (where conditions)
286 286
 	 * @return EE_Base_Class[]
287 287
 	 */
288
-	public function remove_relations($this_obj_or_id,$where_query_param = array()){
289
-		$related_things = $this->get_all_related($this_obj_or_id,array($where_query_param));
288
+	public function remove_relations($this_obj_or_id, $where_query_param = array()) {
289
+		$related_things = $this->get_all_related($this_obj_or_id, array($where_query_param));
290 290
 		$objs_removed = array();
291
-		foreach($related_things as $related_thing){
291
+		foreach ($related_things as $related_thing) {
292 292
 			$objs_removed[] = $this->remove_relation_to($this_obj_or_id, $related_thing);
293 293
 		}
294 294
 		return $objs_removed;
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 	 * related objects exist, returns false.
302 302
 	 * @return boolean
303 303
 	 */
304
-	public function block_delete_if_related_models_exist(){
304
+	public function block_delete_if_related_models_exist() {
305 305
 		return $this->_blocking_delete;
306 306
 	}
307 307
 
@@ -310,13 +310,13 @@  discard block
 block discarded – undo
310 310
 	 * Gets the error message to show
311 311
 	 * @return string
312 312
 	 */
313
-	public function get_deletion_error_message(){
314
-		if($this->_blocking_delete_error_message){
313
+	public function get_deletion_error_message() {
314
+		if ($this->_blocking_delete_error_message) {
315 315
 			return $this->_blocking_delete_error_message;
316
-		}else{
316
+		} else {
317 317
 //			return sprintf(__('Cannot delete %1$s when there are related %2$s', "event_espresso"),$this->get_this_model()->item_name(2),$this->get_other_model()->item_name(2));
318 318
 			return sprintf(
319
-				__( 'This %1$s is currently linked to one or more %2$s records. If this %1$s is incorrect, then please remove it from all %3$s before attempting to delete it.', "event_espresso"),
319
+				__('This %1$s is currently linked to one or more %2$s records. If this %1$s is incorrect, then please remove it from all %3$s before attempting to delete it.', "event_espresso"),
320 320
 				$this->get_this_model()->item_name(1),
321 321
 				$this->get_other_model()->item_name(1),
322 322
 				$this->get_other_model()->item_name(2)
Please login to merge, or discard this patch.
core/db_models/strategies/EE_CPT_Where_Conditions.strategy.php 2 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,6 +7,11 @@  discard block
 block discarded – undo
7 7
 
8 8
 	protected $_post_type;
9 9
 	protected $_meta_field;
10
+
11
+	/**
12
+	 * @param string $post_type
13
+	 * @param string $meta_field_to_chk
14
+	 */
10 15
 	function __construct($post_type, $meta_field_to_chk){
11 16
 		$this->_post_type = $post_type;
12 17
 		$this->_meta_field = $meta_field_to_chk;
@@ -27,7 +32,6 @@  discard block
 block discarded – undo
27 32
 	}
28 33
 	/**
29 34
 	 * Gets the where default where conditions for a custom post type model
30
-	 * @param string $model_relation_path. Eg, from Event to Payment, this should be "Registration.Transaction.Payment"
31 35
 	 * @return array like EEM_Base::get_all's $query_params's index [0] (where conditions)
32 36
 	 */
33 37
 	protected function _get_default_where_conditions() {
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 /*
4 4
  * Strategy specifically for adding where conditions specific to CPT models.
5 5
  */
6
-class EE_CPT_Where_Conditions extends EE_Default_Where_Conditions{
6
+class EE_CPT_Where_Conditions extends EE_Default_Where_Conditions {
7 7
 
8 8
 	protected $_post_type;
9 9
 	protected $_meta_field;
10
-	function __construct($post_type, $meta_field_to_chk){
10
+	function __construct($post_type, $meta_field_to_chk) {
11 11
 		$this->_post_type = $post_type;
12 12
 		$this->_meta_field = $meta_field_to_chk;
13 13
 	}
@@ -17,10 +17,10 @@  discard block
 block discarded – undo
17 17
 	 * @param string $column column name
18 18
 	 * @return EE_Model_Field_Base
19 19
 	 */
20
-	protected function _get_field_on_column($column){
20
+	protected function _get_field_on_column($column) {
21 21
 		$all_fields = $this->_model->field_settings(true);
22
-		foreach($all_fields as $field_name => $field_obj){
23
-			if($column == $field_obj->get_table_column()){
22
+		foreach ($all_fields as $field_name => $field_obj) {
23
+			if ($column == $field_obj->get_table_column()) {
24 24
 				return $field_obj;
25 25
 			}
26 26
 		}
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
 		//find post_type field
35 35
 		$post_type_field = $this->_get_field_on_column('post_type');
36 36
 		$status_field = $this->_get_field_on_column('post_status');
37
-		return array( $post_type_field->get_name() => $this->_post_type,
38
-				$status_field->get_name() => array('NOT IN',array('auto-draft','trash'))
37
+		return array($post_type_field->get_name() => $this->_post_type,
38
+				$status_field->get_name() => array('NOT IN', array('auto-draft', 'trash'))
39 39
 		);
40 40
 	}
41 41
 }
Please login to merge, or discard this patch.
core/EE_Addon.core.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
 	/**
111 111
 	 * Sets addon_name
112 112
 	 * @param string $addon_name
113
-	 * @return boolean
113
+	 * @return string
114 114
 	 */
115 115
 	function set_name( $addon_name ) {
116 116
 		return $this->_addon_name = $addon_name;
Please login to merge, or discard this patch.
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -2,19 +2,19 @@
 block discarded – undo
2 2
 	exit( 'No direct script access allowed' );
3 3
 }
4 4
 /**
5
- *
6
- * Event Espresso
7
- *
8
- * Event Registration and Ticketing Management Plugin for WordPress
9
- *
10
- * @ package 		Event Espresso
11
- * @ author 		Event Espresso
12
- * @ copyright 	(c) 2008-2014 Event Espresso  All Rights Reserved.
13
- * @ license 		http://eventespresso.com/support/terms-conditions/   * see Plugin Licensing *
14
- * @ link 				http://www.eventespresso.com
15
- * @ since 			4.3
16
- *
17
- */
5
+	 *
6
+	 * Event Espresso
7
+	 *
8
+	 * Event Registration and Ticketing Management Plugin for WordPress
9
+	 *
10
+	 * @ package 		Event Espresso
11
+	 * @ author 		Event Espresso
12
+	 * @ copyright 	(c) 2008-2014 Event Espresso  All Rights Reserved.
13
+	 * @ license 		http://eventespresso.com/support/terms-conditions/   * see Plugin Licensing *
14
+	 * @ link 				http://www.eventespresso.com
15
+	 * @ since 			4.3
16
+	 *
17
+	 */
18 18
 
19 19
 
20 20
 
Please login to merge, or discard this patch.
Spacing   +63 added lines, -63 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  *
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	/**
74 74
 	 * @param mixed $version
75 75
 	 */
76
-	public function set_version( $version = NULL ) {
76
+	public function set_version($version = NULL) {
77 77
 		$this->_version = $version;
78 78
 	}
79 79
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	/**
92 92
 	 * @param mixed $min_core_version
93 93
 	 */
94
-	public function set_min_core_version( $min_core_version = NULL ) {
94
+	public function set_min_core_version($min_core_version = NULL) {
95 95
 		$this->_min_core_version = $min_core_version;
96 96
 	}
97 97
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 * @param string $addon_name
113 113
 	 * @return boolean
114 114
 	 */
115
-	function set_name( $addon_name ) {
115
+	function set_name($addon_name) {
116 116
 		return $this->_addon_name = $addon_name;
117 117
 	}
118 118
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 		do_action("AHEE__{$classname}__new_install");
139 139
 		do_action("AHEE__EE_Addon__new_install", $this);
140 140
 		EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
141
-		add_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations', array( $this, 'initialize_db_if_no_migrations_required' ) );
141
+		add_action('AHEE__EE_System__perform_activations_upgrades_and_migrations', array($this, 'initialize_db_if_no_migrations_required'));
142 142
 	}
143 143
 
144 144
 
@@ -153,16 +153,16 @@  discard block
 block discarded – undo
153 153
 		do_action("AHEE__{$classname}__reactivation");
154 154
 		do_action("AHEE__EE_Addon__reactivation", $this);
155 155
 		EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
156
-		add_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations', array( $this, 'initialize_db_if_no_migrations_required' ) );
156
+		add_action('AHEE__EE_System__perform_activations_upgrades_and_migrations', array($this, 'initialize_db_if_no_migrations_required'));
157 157
 	}
158 158
 
159
-	public function deactivation(){
159
+	public function deactivation() {
160 160
 		$classname = get_class($this);
161 161
 //		echo "Deactivating $classname";die;
162 162
 		do_action("AHEE__{$classname}__deactivation");
163 163
 		do_action("AHEE__EE_Addon__deactivation", $this);
164 164
 		//check if the site no longer needs to be in maintenance mode
165
-		EE_Register_Addon::deregister( $this->name() );
165
+		EE_Register_Addon::deregister($this->name());
166 166
 		EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
167 167
 	}
168 168
 
@@ -176,16 +176,16 @@  discard block
 block discarded – undo
176 176
 	 * This is a resource-intensive job so we prefer to only do it when necessary
177 177
 	 * @return void
178 178
 	 */
179
-	public function initialize_db_if_no_migrations_required( $verify_schema = true ) {
180
-		if( $verify_schema === '' ) {
179
+	public function initialize_db_if_no_migrations_required($verify_schema = true) {
180
+		if ($verify_schema === '') {
181 181
 			//wp core bug imo: if no args are passed to `do_action('some_hook_name')` besides the hook's name
182 182
 			//(ie, no 2nd or 3rd arguments), instead of calling the registered callbacks with no arguments, it
183 183
 			//calls them with an argument of an empty string (ie ""), which evaluates to false
184 184
 			//so we need to treat the empty string as if nothing had been passed, and should instead use the default
185 185
 			$verify_schema = true;
186 186
 		}
187
-		if ( EE_Maintenance_Mode::instance()->level() != EE_Maintenance_Mode::level_2_complete_maintenance ) {
188
-			if( $verify_schema ) {
187
+		if (EE_Maintenance_Mode::instance()->level() != EE_Maintenance_Mode::level_2_complete_maintenance) {
188
+			if ($verify_schema) {
189 189
 				$this->initialize_db();
190 190
 			}
191 191
 			$this->initialize_default_data();
@@ -199,15 +199,15 @@  discard block
 block discarded – undo
199 199
 			 */
200 200
 			EE_Registry::instance()->load_helper('Activation');
201 201
 			EEH_Activation::initialize_db_content();
202
-			update_option( 'ee_flush_rewrite_rules', TRUE );
202
+			update_option('ee_flush_rewrite_rules', TRUE);
203 203
 			//in case there are lots of addons being activated at once, let's force garbage collection
204 204
 			//to help avoid memory limit errors
205 205
 			//EEH_Debug_Tools::instance()->measure_memory( 'db content initialized for ' . get_class( $this), true );
206 206
 			gc_collect_cycles();
207
-		}else{
207
+		} else {
208 208
 			//ask the data migration manager to init this addon's data
209 209
 			//when migrations are finished because we can't do it now
210
-			EE_Data_Migration_Manager::instance()->enqueue_db_initialization_for( $this->name() );
210
+			EE_Data_Migration_Manager::instance()->enqueue_db_initialization_for($this->name());
211 211
 		}
212 212
 	}
213 213
 
@@ -221,20 +221,20 @@  discard block
 block discarded – undo
221 221
 	 */
222 222
 	public function initialize_db() {
223 223
 		//find the migration script that sets the database to be compatible with the code
224
-		$current_dms_name = EE_Data_Migration_Manager::instance()->get_most_up_to_date_dms( $this->name() );
225
-		if( $current_dms_name ){
226
-			$current_data_migration_script = EE_Registry::instance()->load_dms( $current_dms_name );
227
-			$current_data_migration_script->set_migrating( FALSE );
224
+		$current_dms_name = EE_Data_Migration_Manager::instance()->get_most_up_to_date_dms($this->name());
225
+		if ($current_dms_name) {
226
+			$current_data_migration_script = EE_Registry::instance()->load_dms($current_dms_name);
227
+			$current_data_migration_script->set_migrating(FALSE);
228 228
 			$current_data_migration_script->schema_changes_before_migration();
229 229
 			$current_data_migration_script->schema_changes_after_migration();
230
-			if ( $current_data_migration_script->get_errors() ) {
231
-				foreach( $current_data_migration_script->get_errors() as $error ) {
232
-					EE_Error::add_error( $error, __FILE__, __FUNCTION__, __LINE__ );
230
+			if ($current_data_migration_script->get_errors()) {
231
+				foreach ($current_data_migration_script->get_errors() as $error) {
232
+					EE_Error::add_error($error, __FILE__, __FUNCTION__, __LINE__);
233 233
 				}
234 234
 			}
235 235
 		}
236 236
 		//if not DMS was found that should be ok. This addon just doesn't require any database changes
237
-		EE_Data_Migration_Manager::instance()->update_current_database_state_to( array( 'slug' => $this->name(), 'version' => $this->version() ) );
237
+		EE_Data_Migration_Manager::instance()->update_current_database_state_to(array('slug' => $this->name(), 'version' => $this->version()));
238 238
 	}
239 239
 
240 240
 
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 		 * default data)
257 257
 		 * @param EE_Addon $addon the addon that called this
258 258
 		 */
259
-		do_action( 'AHEE__EE_Addon__initialize_default_data__begin', $this );
259
+		do_action('AHEE__EE_Addon__initialize_default_data__begin', $this);
260 260
 		//override to insert default data. It is safe to use the models here
261 261
 		//because the site should not be in maintenance mode
262 262
 	}
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 		do_action("AHEE__EE_Addon__upgrade", $this);
276 276
 		EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
277 277
 		//also it's possible there is new default data that needs to be added
278
-		add_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations', array( $this, 'initialize_db_if_no_migrations_required' ) );
278
+		add_action('AHEE__EE_System__perform_activations_upgrades_and_migrations', array($this, 'initialize_db_if_no_migrations_required'));
279 279
 	}
280 280
 
281 281
 
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
 		do_action("AHEE__{$classname}__downgrade");
289 289
 		do_action("AHEE__EE_Addon__downgrade", $this);
290 290
 		//it's possible there's old default data that needs to be double-checked
291
-		add_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations', array( $this, 'initialize_db_if_no_migrations_required' ) );
291
+		add_action('AHEE__EE_System__perform_activations_upgrades_and_migrations', array($this, 'initialize_db_if_no_migrations_required'));
292 292
 	}
293 293
 
294 294
 
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 	 * plugin activation only. In the future, we'll want to do it on plugin updates too
300 300
 	 * @return bool
301 301
 	 */
302
-	public function set_db_update_option_name(){
302
+	public function set_db_update_option_name() {
303 303
 		EE_Error::doing_it_wrong(__FUNCTION__, __('EE_Addon::set_db_update_option_name was renamed to EE_Addon::set_activation_indicator_option', 'event_espresso'), '4.3.0.alpha.016');
304 304
 		//let's just handle this on the next request, ok? right now we're just not really ready
305 305
 		return $this->set_activation_indicator_option();
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 	 */
328 328
 	public function set_activation_indicator_option() {
329 329
 		// let's just handle this on the next request, ok? right now we're just not really ready
330
-		return update_option( $this->get_activation_indicator_option_name(), TRUE );
330
+		return update_option($this->get_activation_indicator_option_name(), TRUE);
331 331
 	}
332 332
 
333 333
 
@@ -335,8 +335,8 @@  discard block
 block discarded – undo
335 335
 	 * Gets the name of the wp option which is used to temporarily indicate that this addon was activated
336 336
 	 * @return string
337 337
 	 */
338
-	public function get_activation_indicator_option_name(){
339
-		return 'ee_activation_' . $this->name();
338
+	public function get_activation_indicator_option_name() {
339
+		return 'ee_activation_'.$this->name();
340 340
 	}
341 341
 
342 342
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	 * Used by EE_System to set the request type of this addon. Should not be used by addon developers
347 347
 	 * @param int $req_type
348 348
 	 */
349
-	function set_req_type( $req_type ) {
349
+	function set_req_type($req_type) {
350 350
 		$this->_req_type = $req_type;
351 351
 	}
352 352
 
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
 	 * of addons
358 358
 	 */
359 359
 	function detect_req_type() {
360
-		if( ! $this->_req_type ){
360
+		if ( ! $this->_req_type) {
361 361
 			$this->detect_activation_or_upgrade();
362 362
 		}
363 363
 		return $this->_req_type;
@@ -370,36 +370,36 @@  discard block
 block discarded – undo
370 370
 	 * Should only be called once per request
371 371
 	 * @return void
372 372
 	 */
373
-	function detect_activation_or_upgrade(){
373
+	function detect_activation_or_upgrade() {
374 374
 		$activation_history_for_addon = $this->get_activation_history();
375 375
 //		d($activation_history_for_addon);
376 376
 		$request_type = EE_System::detect_req_type_given_activation_history($activation_history_for_addon, $this->get_activation_indicator_option_name(), $this->version());
377 377
 		$this->set_req_type($request_type);
378 378
 		$classname = get_class($this);
379
-		switch($request_type){
379
+		switch ($request_type) {
380 380
 			case EE_System::req_type_new_activation:
381
-				do_action( "AHEE__{$classname}__detect_activations_or_upgrades__new_activation" );
382
-				do_action( "AHEE__EE_Addon__detect_activations_or_upgrades__new_activation", $this );
381
+				do_action("AHEE__{$classname}__detect_activations_or_upgrades__new_activation");
382
+				do_action("AHEE__EE_Addon__detect_activations_or_upgrades__new_activation", $this);
383 383
 				$this->new_install();
384
-				$this->update_list_of_installed_versions( $activation_history_for_addon );
384
+				$this->update_list_of_installed_versions($activation_history_for_addon);
385 385
 				break;
386 386
 			case EE_System::req_type_reactivation:
387
-				do_action( "AHEE__{$classname}__detect_activations_or_upgrades__reactivation" );
388
-				do_action( "AHEE__EE_Addon__detect_activations_or_upgrades__reactivation", $this );
387
+				do_action("AHEE__{$classname}__detect_activations_or_upgrades__reactivation");
388
+				do_action("AHEE__EE_Addon__detect_activations_or_upgrades__reactivation", $this);
389 389
 				$this->reactivation();
390
-				$this->update_list_of_installed_versions( $activation_history_for_addon );
390
+				$this->update_list_of_installed_versions($activation_history_for_addon);
391 391
 				break;
392 392
 			case EE_System::req_type_upgrade:
393
-				do_action( "AHEE__{$classname}__detect_activations_or_upgrades__upgrade" );
394
-				do_action( "AHEE__EE_Addon__detect_activations_or_upgrades__upgrade", $this );
393
+				do_action("AHEE__{$classname}__detect_activations_or_upgrades__upgrade");
394
+				do_action("AHEE__EE_Addon__detect_activations_or_upgrades__upgrade", $this);
395 395
 				$this->upgrade();
396
-				$this->update_list_of_installed_versions($activation_history_for_addon );
396
+				$this->update_list_of_installed_versions($activation_history_for_addon);
397 397
 				break;
398 398
 			case EE_System::req_type_downgrade:
399
-				do_action( "AHEE__{$classname}__detect_activations_or_upgrades__downgrade" );
400
-				do_action( "AHEE__EE_Addon__detect_activations_or_upgrades__downgrade", $this );
399
+				do_action("AHEE__{$classname}__detect_activations_or_upgrades__downgrade");
400
+				do_action("AHEE__EE_Addon__detect_activations_or_upgrades__downgrade", $this);
401 401
 				$this->downgrade();
402
-				$this->update_list_of_installed_versions($activation_history_for_addon );
402
+				$this->update_list_of_installed_versions($activation_history_for_addon);
403 403
 				break;
404 404
 			case EE_System::req_type_normal:
405 405
 			default:
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
 				break;
408 408
 		}
409 409
 
410
-		do_action( "AHEE__{$classname}__detect_if_activation_or_upgrade__complete" );
410
+		do_action("AHEE__{$classname}__detect_if_activation_or_upgrade__complete");
411 411
 	}
412 412
 
413 413
 	/**
@@ -416,17 +416,17 @@  discard block
 block discarded – undo
416 416
 	 * @param string $current_version_to_add
417 417
 	 * @return boolean success
418 418
 	 */
419
-	public function update_list_of_installed_versions($version_history = NULL,$current_version_to_add = NULL) {
420
-		if( ! $version_history ) {
419
+	public function update_list_of_installed_versions($version_history = NULL, $current_version_to_add = NULL) {
420
+		if ( ! $version_history) {
421 421
 			$version_history = $this->get_activation_history();
422 422
 		}
423
-		if( $current_version_to_add == NULL){
423
+		if ($current_version_to_add == NULL) {
424 424
 			$current_version_to_add = $this->version();
425 425
 		}
426
-		$version_history[ $current_version_to_add ][] = date( 'Y-m-d H:i:s',time() );
426
+		$version_history[$current_version_to_add][] = date('Y-m-d H:i:s', time());
427 427
 		// resave
428 428
 //		echo "updating list of installed versions:".$this->get_activation_history_option_name();d($version_history);
429
-		return update_option( $this->get_activation_history_option_name(), $version_history );
429
+		return update_option($this->get_activation_history_option_name(), $version_history);
430 430
 	}
431 431
 
432 432
 	/**
@@ -434,8 +434,8 @@  discard block
 block discarded – undo
434 434
 	 * of this addon
435 435
 	 * @return string
436 436
 	 */
437
-	function get_activation_history_option_name(){
438
-		return self::ee_addon_version_history_option_prefix . $this->name();
437
+	function get_activation_history_option_name() {
438
+		return self::ee_addon_version_history_option_prefix.$this->name();
439 439
 	}
440 440
 
441 441
 
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
 	 * Gets the wp option which stores the activation history for this addon
445 445
 	 * @return array
446 446
 	 */
447
-	function get_activation_history(){
447
+	function get_activation_history() {
448 448
 		return get_option($this->get_activation_history_option_name(), NULL);
449 449
 	}
450 450
 
@@ -453,8 +453,8 @@  discard block
 block discarded – undo
453 453
 	/**
454 454
 	 * @param string $config_section
455 455
 	 */
456
-	public function set_config_section( $config_section = '' ) {
457
-		$this->_config_section = ! empty( $config_section ) ? $config_section : 'addons';
456
+	public function set_config_section($config_section = '') {
457
+		$this->_config_section = ! empty($config_section) ? $config_section : 'addons';
458 458
 	}
459 459
 	/**
460 460
 	 *	filepath to the main file, which can be used for register_activation_hook, register_deactivation_hook, etc.
@@ -467,14 +467,14 @@  discard block
 block discarded – undo
467 467
 	 * Sets the filepath to the main plugin file
468 468
 	 * @param string $filepath
469 469
 	 */
470
-	public function set_main_plugin_file( $filepath ) {
470
+	public function set_main_plugin_file($filepath) {
471 471
 		$this->_main_plugin_file = $filepath;
472 472
 	}
473 473
 	/**
474 474
 	 * gets the filepath to teh main file
475 475
 	 * @return string
476 476
 	 */
477
-	public function get_main_plugin_file(){
477
+	public function get_main_plugin_file() {
478 478
 		return $this->_main_plugin_file;
479 479
 	}
480 480
 
@@ -484,15 +484,15 @@  discard block
 block discarded – undo
484 484
 	 * @return string
485 485
 	 */
486 486
 	public function get_main_plugin_file_basename() {
487
-		return plugin_basename( $this->get_main_plugin_file() );
487
+		return plugin_basename($this->get_main_plugin_file());
488 488
 	}
489 489
 
490 490
 	/**
491 491
 	 * Gets the folder name which contains the main plugin file
492 492
 	 * @return string
493 493
 	 */
494
-	public function get_main_plugin_file_dirname(){
495
-		return dirname( $this->get_main_plugin_file() );
494
+	public function get_main_plugin_file_dirname() {
495
+		return dirname($this->get_main_plugin_file());
496 496
 	}
497 497
 
498 498
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 		//so in case teh IPN is arriving later, let's try to process an IPN!
91 91
 		if($_SERVER['REQUEST_METHOD'] == 'POST'){
92 92
 			return $this->handle_ipn($_POST, $transaction );
93
-		}else{
93
+		} else{
94 94
 			return parent::finalize_payment_for( $transaction );
95 95
 		}
96 96
 	}
Please login to merge, or discard this patch.
core/EE_Capabilities.core.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -557,7 +557,7 @@  discard block
 block discarded – undo
557 557
 	 * @since    4.5.0
558 558
 	 *
559 559
 	 * @param string $meta_cap     What meta capability is this mapping.
560
-	 * @param array  $map_values   array {
560
+	 * @param string[]  $map_values   array {
561 561
 	 * 		//array of values that MUST match a count of 4.  It's okay to send an empty string for capabilities that don't get mapped to.
562 562
 	 * 		@type $map_values[0] string A string representing the model name. Required.  String's
563 563
 	 * 		      	    	       should always be used when Menu Maps are registered via the
@@ -625,8 +625,8 @@  discard block
 block discarded – undo
625 625
 	 * @see EE_Meta_Capability_Map::_map_meta_caps() for docs on params.
626 626
 	 * @since 4.6.x
627 627
 	 * @param $caps
628
-	 * @param $cap
629
-	 * @param $user_id
628
+	 * @param string $cap
629
+	 * @param integer $user_id
630 630
 	 * @param $args
631 631
 	 *
632 632
 	 * @return array
Please login to merge, or discard this patch.
Indentation   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,6 @@  discard block
 block discarded – undo
111 111
 
112 112
 	/**
113 113
 	 * This sets the meta caps property.
114
-
115 114
 	 * @since 4.5.0
116 115
 	 *
117 116
 	 * @return void
@@ -209,7 +208,7 @@  discard block
 block discarded – undo
209 208
 			 * capability mapping which will be used for accessing payment methods owned by
210 209
 			 * other users.  This is not fully implemented yet in the payment method ui.
211 210
 			 * Currently only the "plural" caps are in active use. (Specific payment method caps are in use as well).
212
-			**/
211
+			 **/
213 212
 				'ee_manage_gateways',
214 213
 				'ee_read_payment_method',
215 214
 				'ee_read_payment_methods',
Please login to merge, or discard this patch.
Spacing   +124 added lines, -124 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@  discard block
 block discarded – undo
7 7
  * @package Event Espresso
8 8
  * @subpackage core, capabilities
9 9
  */
10
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
11
-	exit( 'No direct script access allowed' );
10
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
11
+	exit('No direct script access allowed');
12 12
 }
13 13
 
14 14
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 */
70 70
 	public static function instance() {
71 71
 		//check if instantiated, and if not do so.
72
-		if ( ! self::$_instance instanceof EE_Capabilities ) {
72
+		if ( ! self::$_instance instanceof EE_Capabilities) {
73 73
 			self::$_instance = new self();
74 74
 		}
75 75
 		return self::$_instance;
@@ -98,10 +98,10 @@  discard block
 block discarded – undo
98 98
 	 * @since 4.5.0
99 99
 	 * @return void
100 100
 	 */
101
-	public function init_caps( $reset = false ) {
102
-		if ( EE_Maintenance_Mode::instance()->models_can_query() ){
101
+	public function init_caps($reset = false) {
102
+		if (EE_Maintenance_Mode::instance()->models_can_query()) {
103 103
 			$this->_caps_map = $this->_init_caps_map();
104
-			$this->init_role_caps( $reset );
104
+			$this->init_role_caps($reset);
105 105
 			$this->_set_meta_caps();
106 106
 		}
107 107
 	}
@@ -119,41 +119,41 @@  discard block
 block discarded – undo
119 119
 	private function _set_meta_caps() {
120 120
 		$this->_meta_caps = array(
121 121
 			//edits
122
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_event', array( 'Event', 'ee_edit_published_events', 'ee_edit_others_events', 'ee_edit_private_events' ) ),
123
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_venue', array( 'Venue', 'ee_edit_published_venues', 'ee_edit_others_venues', 'ee_edit_private_venues' ) ),
124
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_registration', array( 'Registration', '', 'ee_edit_others_registrations', '' ) ),
125
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_checkin', array( 'Registration', '', 'ee_edit_others_checkins', '' ) ),
126
-			new EE_Meta_Capability_Map_Messages_Cap( 'ee_edit_message', array( 'Message_Template_Group', '', 'ee_edit_others_messages', 'ee_edit_global_messages' ) ),
127
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_default_ticket', array( 'Ticket', '', 'ee_edit_others_default_tickets', '' ) ),
128
-			new EE_Meta_Capability_Map_Registration_Form_Cap( 'ee_edit_question', array( 'Question', '', '', 'ee_edit_system_questions' ) ),
129
-			new EE_Meta_Capability_Map_Registration_Form_Cap( 'ee_edit_question_group', array( 'Question_Group', '', '', 'ee_edit_system_question_groups' ) ),
130
-			new EE_Meta_Capability_Map_Edit( 'ee_edit_payment_method', array( 'Payment_Method', '', 'ee_edit_others_payment_methods', '' ) ),
122
+			new EE_Meta_Capability_Map_Edit('ee_edit_event', array('Event', 'ee_edit_published_events', 'ee_edit_others_events', 'ee_edit_private_events')),
123
+			new EE_Meta_Capability_Map_Edit('ee_edit_venue', array('Venue', 'ee_edit_published_venues', 'ee_edit_others_venues', 'ee_edit_private_venues')),
124
+			new EE_Meta_Capability_Map_Edit('ee_edit_registration', array('Registration', '', 'ee_edit_others_registrations', '')),
125
+			new EE_Meta_Capability_Map_Edit('ee_edit_checkin', array('Registration', '', 'ee_edit_others_checkins', '')),
126
+			new EE_Meta_Capability_Map_Messages_Cap('ee_edit_message', array('Message_Template_Group', '', 'ee_edit_others_messages', 'ee_edit_global_messages')),
127
+			new EE_Meta_Capability_Map_Edit('ee_edit_default_ticket', array('Ticket', '', 'ee_edit_others_default_tickets', '')),
128
+			new EE_Meta_Capability_Map_Registration_Form_Cap('ee_edit_question', array('Question', '', '', 'ee_edit_system_questions')),
129
+			new EE_Meta_Capability_Map_Registration_Form_Cap('ee_edit_question_group', array('Question_Group', '', '', 'ee_edit_system_question_groups')),
130
+			new EE_Meta_Capability_Map_Edit('ee_edit_payment_method', array('Payment_Method', '', 'ee_edit_others_payment_methods', '')),
131 131
 			//reads
132
-			new EE_Meta_Capability_Map_Read( 'ee_read_event', array( 'Event', '', 'ee_read_others_events', 'ee_read_private_events' ) ),
133
-			new EE_Meta_Capability_Map_Read( 'ee_read_venue', array( 'Venue', '', 'ee_read_others_venues', 'ee_read_private_venues' ) ),
134
-			new EE_Meta_Capability_Map_Read( 'ee_read_registration', array( 'Registration', '', '', 'ee_edit_others_registrations' ) ),
135
-			new EE_Meta_Capability_Map_Read( 'ee_read_checkin', array( 'Registration', '', '', 'ee_read_others_checkins' ) ),
136
-			new EE_Meta_Capability_Map_Messages_Cap( 'ee_read_message', array( 'Message_Template_Group', '', 'ee_read_others_messages', 'ee_read_global_messages' ) ),
137
-			new EE_Meta_Capability_Map_Read( 'ee_read_default_ticket', array( 'Ticket', '', '', 'ee_read_others_default_tickets' ) ),
138
-			new EE_Meta_Capability_Map_Read( 'ee_read_payment_method', array( 'Payment_Method', '', '', 'ee_read_others_payment_methods' ) ),
132
+			new EE_Meta_Capability_Map_Read('ee_read_event', array('Event', '', 'ee_read_others_events', 'ee_read_private_events')),
133
+			new EE_Meta_Capability_Map_Read('ee_read_venue', array('Venue', '', 'ee_read_others_venues', 'ee_read_private_venues')),
134
+			new EE_Meta_Capability_Map_Read('ee_read_registration', array('Registration', '', '', 'ee_edit_others_registrations')),
135
+			new EE_Meta_Capability_Map_Read('ee_read_checkin', array('Registration', '', '', 'ee_read_others_checkins')),
136
+			new EE_Meta_Capability_Map_Messages_Cap('ee_read_message', array('Message_Template_Group', '', 'ee_read_others_messages', 'ee_read_global_messages')),
137
+			new EE_Meta_Capability_Map_Read('ee_read_default_ticket', array('Ticket', '', '', 'ee_read_others_default_tickets')),
138
+			new EE_Meta_Capability_Map_Read('ee_read_payment_method', array('Payment_Method', '', '', 'ee_read_others_payment_methods')),
139 139
 
140 140
 			//deletes
141
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_event', array( 'Event', 'ee_delete_published_events', 'ee_delete_others_events', 'ee_delete_private_events' ) ),
142
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_venue', array( 'Venue', 'ee_delete_published_venues', 'ee_delete_others_venues', 'ee_delete_private_venues' ) ),
143
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_registration', array( 'Registration', '', 'ee_delete_others_registrations', '' ) ),
144
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_checkin', array( 'Registration', '', 'ee_delete_others_checkins', '' ) ),
145
-			new EE_Meta_Capability_Map_Messages_Cap( 'ee_delete_message', array( 'Message_Template_Group', '', 'ee_delete_others_messages', 'ee_delete_global_messages' ) ),
146
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_default_ticket', array( 'Ticket', '', 'ee_delete_others_default_tickets', '' ) ),
147
-			new EE_Meta_Capability_Map_Registration_Form_Cap( 'ee_delete_question', array( 'Question', '', '', 'delete_system_questions' ) ),
148
-			new EE_Meta_Capability_Map_Registration_Form_Cap( 'ee_delete_question_group', array( 'Question_Group', '', '', 'delete_system_question_groups' ) ),
149
-			new EE_Meta_Capability_Map_Delete( 'ee_delete_payment_method', array( 'Payment_Method', '', 'ee_delete_others_payment_methods', '' ) ),
141
+			new EE_Meta_Capability_Map_Delete('ee_delete_event', array('Event', 'ee_delete_published_events', 'ee_delete_others_events', 'ee_delete_private_events')),
142
+			new EE_Meta_Capability_Map_Delete('ee_delete_venue', array('Venue', 'ee_delete_published_venues', 'ee_delete_others_venues', 'ee_delete_private_venues')),
143
+			new EE_Meta_Capability_Map_Delete('ee_delete_registration', array('Registration', '', 'ee_delete_others_registrations', '')),
144
+			new EE_Meta_Capability_Map_Delete('ee_delete_checkin', array('Registration', '', 'ee_delete_others_checkins', '')),
145
+			new EE_Meta_Capability_Map_Messages_Cap('ee_delete_message', array('Message_Template_Group', '', 'ee_delete_others_messages', 'ee_delete_global_messages')),
146
+			new EE_Meta_Capability_Map_Delete('ee_delete_default_ticket', array('Ticket', '', 'ee_delete_others_default_tickets', '')),
147
+			new EE_Meta_Capability_Map_Registration_Form_Cap('ee_delete_question', array('Question', '', '', 'delete_system_questions')),
148
+			new EE_Meta_Capability_Map_Registration_Form_Cap('ee_delete_question_group', array('Question_Group', '', '', 'delete_system_question_groups')),
149
+			new EE_Meta_Capability_Map_Delete('ee_delete_payment_method', array('Payment_Method', '', 'ee_delete_others_payment_methods', '')),
150 150
 		);
151 151
 
152
-		$this->_meta_caps = apply_filters( 'FHEE__EE_Capabilities___set_meta_caps__meta_caps', $this->_meta_caps );
152
+		$this->_meta_caps = apply_filters('FHEE__EE_Capabilities___set_meta_caps__meta_caps', $this->_meta_caps);
153 153
 
154 154
 		//add filter for map_meta_caps but only if models can query.
155
-		if ( EE_Maintenance_Mode::instance()->models_can_query() && ! has_filter( 'map_meta_cap', array( $this, 'map_meta_caps' ) ) ) {
156
-			add_filter( 'map_meta_cap', array( $this, 'map_meta_caps' ), 10, 4 );
155
+		if (EE_Maintenance_Mode::instance()->models_can_query() && ! has_filter('map_meta_cap', array($this, 'map_meta_caps'))) {
156
+			add_filter('map_meta_cap', array($this, 'map_meta_caps'), 10, 4);
157 157
 		}
158 158
 	}
159 159
 
@@ -175,15 +175,15 @@  discard block
 block discarded – undo
175 175
 	 *
176 176
 	 * @return array   actual users capabilities
177 177
 	 */
178
-	public function map_meta_caps( $caps, $cap, $user_id, $args ) {
178
+	public function map_meta_caps($caps, $cap, $user_id, $args) {
179 179
 		//loop through our _meta_caps array
180
-		foreach ( $this->_meta_caps as $meta_map ) {
181
-			if ( ! $meta_map instanceof EE_Meta_Capability_Map ) {
180
+		foreach ($this->_meta_caps as $meta_map) {
181
+			if ( ! $meta_map instanceof EE_Meta_Capability_Map) {
182 182
 				continue;
183 183
 			}
184 184
 			$meta_map->ensure_is_model();
185 185
 
186
-			$caps = $meta_map->map_meta_caps( $caps, $cap, $user_id, $args );
186
+			$caps = $meta_map->map_meta_caps($caps, $cap, $user_id, $args);
187 187
 		}
188 188
 		return $caps;
189 189
 	}
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 				)
349 349
 			);
350 350
 
351
-		$caps = apply_filters( 'FHEE__EE_Capabilities__init_caps_map__caps', $caps );
351
+		$caps = apply_filters('FHEE__EE_Capabilities__init_caps_map__caps', $caps);
352 352
 		return $caps;
353 353
 	}
354 354
 
@@ -365,26 +365,26 @@  discard block
 block discarded – undo
365 365
 	 *
366 366
 	 * @return void
367 367
 	 */
368
-	public function init_role_caps( $reset = false, $custom_map = array() ) {
368
+	public function init_role_caps($reset = false, $custom_map = array()) {
369 369
 
370
-		$caps_map = empty( $custom_map ) ? $this->_caps_map : $custom_map;
370
+		$caps_map = empty($custom_map) ? $this->_caps_map : $custom_map;
371 371
 
372 372
 		//first let's determine if these caps have already been set.
373
-		$caps_set_before = get_option( self::option_name, array() );
373
+		$caps_set_before = get_option(self::option_name, array());
374 374
 		//if not reset, see what caps are new for each role. if they're new, add them.
375
-		foreach ( $caps_map as $role => $caps_for_role ) {
376
-			foreach ( $caps_for_role as $cap ) {
375
+		foreach ($caps_map as $role => $caps_for_role) {
376
+			foreach ($caps_for_role as $cap) {
377 377
 				//first check we haven't already added this cap before, or it's a reset
378
-				if ( $reset || ! isset( $caps_set_before[ $role ] ) || ! in_array( $cap, $caps_set_before[ $role ] ) ) {
379
-					$this->add_cap_to_role( $role, $cap );
380
-					$caps_set_before[ $role ][] = $cap;
378
+				if ($reset || ! isset($caps_set_before[$role]) || ! in_array($cap, $caps_set_before[$role])) {
379
+					$this->add_cap_to_role($role, $cap);
380
+					$caps_set_before[$role][] = $cap;
381 381
 				}
382 382
 			}
383 383
 		}
384 384
 
385 385
 		//now let's just save the cap that has been set.
386
-		update_option( self::option_name, $caps_set_before );
387
-		do_action( 'AHEE__EE_Capabilities__init_role_caps__complete', $caps_set_before );
386
+		update_option(self::option_name, $caps_set_before);
387
+		do_action('AHEE__EE_Capabilities__init_role_caps__complete', $caps_set_before);
388 388
 	}
389 389
 
390 390
 
@@ -403,10 +403,10 @@  discard block
 block discarded – undo
403 403
 	 * @param bool $grant  Whether to grant access to this cap on this role.
404 404
 	 * @return void
405 405
 	 */
406
-	public function add_cap_to_role( $role, $cap, $grant = true ) {
407
-		$role = get_role( $role );
408
-		if ( $role instanceof WP_Role ) {
409
-			$role->add_cap( $cap, $grant );
406
+	public function add_cap_to_role($role, $cap, $grant = true) {
407
+		$role = get_role($role);
408
+		if ($role instanceof WP_Role) {
409
+			$role->add_cap($cap, $grant);
410 410
 		}
411 411
 	}
412 412
 
@@ -426,10 +426,10 @@  discard block
 block discarded – undo
426 426
 	 *
427 427
 	 * @return void
428 428
 	 */
429
-	public function remove_cap_from_role( $role, $cap ) {
430
-		$role = get_role( $role );
431
-		if ( $role instanceof WP_Role ) {
432
-			$role->remove_cap( $cap );
429
+	public function remove_cap_from_role($role, $cap) {
430
+		$role = get_role($role);
431
+		if ($role instanceof WP_Role) {
432
+			$role->remove_cap($cap);
433 433
 		}
434 434
 	}
435 435
 
@@ -450,11 +450,11 @@  discard block
 block discarded – undo
450 450
 	 *
451 451
 	 * @return bool  Whether user can or not.
452 452
 	 */
453
-	public function current_user_can( $cap, $context, $id = 0 ) {
453
+	public function current_user_can($cap, $context, $id = 0) {
454 454
 		//apply filters (both a global on just the cap, and context specific.  Global overrides context specific)
455
-		$filtered_cap = apply_filters( 'FHEE__EE_Capabilities__current_user_can__cap__' . $context,  $cap, $id );
456
-		$filtered_cap = apply_filters( 'FHEE__EE_Capabilities__current_user_can__cap', $filtered_cap, $context, $cap, $id );
457
-		return ! empty( $id ) ? current_user_can( $filtered_cap, $id ) : current_user_can( $filtered_cap );
455
+		$filtered_cap = apply_filters('FHEE__EE_Capabilities__current_user_can__cap__'.$context, $cap, $id);
456
+		$filtered_cap = apply_filters('FHEE__EE_Capabilities__current_user_can__cap', $filtered_cap, $context, $cap, $id);
457
+		return ! empty($id) ? current_user_can($filtered_cap, $id) : current_user_can($filtered_cap);
458 458
 	}
459 459
 
460 460
 
@@ -471,11 +471,11 @@  discard block
 block discarded – undo
471 471
 	 *
472 472
 	 * @return bool Whether user can or not.
473 473
 	 */
474
-	public function user_can( $user, $cap, $context, $id = 0 ) {
474
+	public function user_can($user, $cap, $context, $id = 0) {
475 475
 		//apply filters (both a global on just the cap, and context specific.  Global overrides context specific)
476
-		$filtered_cap = apply_filters( 'FHEE__EE_Capabilities__user_can__cap__' . $context, $cap, $user, $id );
477
-		$filtered_cap = apply_filters( 'FHEE__EE_Capabilities__user_can__cap', $filtered_cap, $context, $cap, $user,  $id );
478
-		return ! empty( $id ) ? user_can( $user, $filtered_cap, $id ) : user_can( $user, $filtered_cap );
476
+		$filtered_cap = apply_filters('FHEE__EE_Capabilities__user_can__cap__'.$context, $cap, $user, $id);
477
+		$filtered_cap = apply_filters('FHEE__EE_Capabilities__user_can__cap', $filtered_cap, $context, $cap, $user, $id);
478
+		return ! empty($id) ? user_can($user, $filtered_cap, $id) : user_can($user, $filtered_cap);
479 479
 	}
480 480
 
481 481
 
@@ -495,12 +495,12 @@  discard block
 block discarded – undo
495 495
 	 *
496 496
 	 * @return bool  Whether user can or not.
497 497
 	 */
498
-	public function current_user_can_for_blog( $blog_id, $cap, $context, $id = 0 ) {
499
-		$user_can = ! empty( $id ) ? current_user_can_for_blog( $blog_id, $cap, $id ) : current_user_can( $blog_id, $cap );
498
+	public function current_user_can_for_blog($blog_id, $cap, $context, $id = 0) {
499
+		$user_can = ! empty($id) ? current_user_can_for_blog($blog_id, $cap, $id) : current_user_can($blog_id, $cap);
500 500
 
501 501
 		//apply filters (both a global on just the cap, and context specific.  Global overrides context specific)
502
-		$user_can = apply_filters( 'FHEE__EE_Capabilities__current_user_can_for_blog__user_can__' . $context, $user_can, $blog_id, $cap, $id );
503
-		$user_can = apply_filters( 'FHEE__EE_Capabilities__current_user_can_for_blog__user_can', $user_can, $context, $blog_id, $cap, $id );
502
+		$user_can = apply_filters('FHEE__EE_Capabilities__current_user_can_for_blog__user_can__'.$context, $user_can, $blog_id, $cap, $id);
503
+		$user_can = apply_filters('FHEE__EE_Capabilities__current_user_can_for_blog__user_can', $user_can, $context, $blog_id, $cap, $id);
504 504
 		return $user_can;
505 505
 	}
506 506
 
@@ -516,12 +516,12 @@  discard block
 block discarded – undo
516 516
 	 *
517 517
 	 * @return array
518 518
 	 */
519
-	public function get_ee_capabilities( $role = 'administrator' ) {
519
+	public function get_ee_capabilities($role = 'administrator') {
520 520
 		$capabilities = $this->_init_caps_map();
521
-		if ( empty( $role ) ) {
521
+		if (empty($role)) {
522 522
 			return $capabilities;
523 523
 		}
524
-		return isset( $capabilities[ $role ] ) ? $capabilities[ $role ] : array();
524
+		return isset($capabilities[$role]) ? $capabilities[$role] : array();
525 525
 	}
526 526
 }
527 527
 
@@ -569,11 +569,11 @@  discard block
 block discarded – undo
569 569
 	 * 	}
570 570
 	 * @throws EE_Error
571 571
 	 */
572
-	public function __construct( $meta_cap, $map_values ) {
572
+	public function __construct($meta_cap, $map_values) {
573 573
 		$this->meta_cap = $meta_cap;
574 574
 		//verify there are four args in the $map_values array;
575
-		if ( count( $map_values ) !== 4 ) {
576
-			throw new EE_Error( sprintf( __( 'Incoming $map_values array should have a count of four values in it.  This is what was given: %s', 'event_espresso' ), '<br>' . print_r( $map_values, true ) ) );
575
+		if (count($map_values) !== 4) {
576
+			throw new EE_Error(sprintf(__('Incoming $map_values array should have a count of four values in it.  This is what was given: %s', 'event_espresso'), '<br>'.print_r($map_values, true)));
577 577
 		}
578 578
 
579 579
 		//set properties
@@ -597,19 +597,19 @@  discard block
 block discarded – undo
597 597
 	 */
598 598
 	public function ensure_is_model() {
599 599
 		//is it already instantiated?
600
-		if ( $this->_model instanceof EEM_Base ) {
600
+		if ($this->_model instanceof EEM_Base) {
601 601
 			return;
602 602
 		}
603 603
 
604 604
 		//ensure model name is string
605 605
 		$this->_model_name = (string) $this->_model_name;
606 606
 		//error proof if the name has EEM in it
607
-		$this->_model_name = str_replace( 'EEM', '', $this->_model_name );
607
+		$this->_model_name = str_replace('EEM', '', $this->_model_name);
608 608
 
609
-		$this->_model = EE_Registry::instance()->load_model( $this->_model_name );
609
+		$this->_model = EE_Registry::instance()->load_model($this->_model_name);
610 610
 
611
-		if ( ! $this->_model instanceof EEM_Base ) {
612
-			throw new EE_Error( sprintf( __( 'This string passed in to %s to represent a EEM_Base model class was not able to be used to instantiate the class.   Please ensure that the string is a match for the EEM_Base model name (not including the EEM_ part). This was given: %s', 'event_espresso' ), get_class( $this ), $this->_model ) );
611
+		if ( ! $this->_model instanceof EEM_Base) {
612
+			throw new EE_Error(sprintf(__('This string passed in to %s to represent a EEM_Base model class was not able to be used to instantiate the class.   Please ensure that the string is a match for the EEM_Base model name (not including the EEM_ part). This was given: %s', 'event_espresso'), get_class($this), $this->_model));
613 613
 		}
614 614
 	}
615 615
 
@@ -625,8 +625,8 @@  discard block
 block discarded – undo
625 625
 	 *
626 626
 	 * @return array
627 627
 	 */
628
-	public function map_meta_caps( $caps, $cap, $user_id, $args ) {
629
-		return $this->_map_meta_caps( $caps, $cap, $user_id, $args );
628
+	public function map_meta_caps($caps, $cap, $user_id, $args) {
629
+		return $this->_map_meta_caps($caps, $cap, $user_id, $args);
630 630
 	}
631 631
 
632 632
 
@@ -644,7 +644,7 @@  discard block
 block discarded – undo
644 644
 	 *
645 645
 	 * @return array   actual users capabilities
646 646
 	 */
647
-	abstract protected function _map_meta_caps( $caps, $cap, $user_id, $args );
647
+	abstract protected function _map_meta_caps($caps, $cap, $user_id, $args);
648 648
 }
649 649
 
650 650
 
@@ -676,28 +676,28 @@  discard block
 block discarded – undo
676 676
 	 *
677 677
 	 * @return array   actual users capabilities
678 678
 	 */
679
-	protected function _map_meta_caps( $caps, $cap, $user_id, $args ) {
679
+	protected function _map_meta_caps($caps, $cap, $user_id, $args) {
680 680
 		//only process if we're checking our mapped_cap
681
-		if ( $cap !== $this->meta_cap ) {
681
+		if ($cap !== $this->meta_cap) {
682 682
 			return $caps;
683 683
 		}
684 684
 
685
-		$obj = ! empty( $args[0] ) ? $this->_model->get_one_by_ID( $args[0] ) : null;
685
+		$obj = ! empty($args[0]) ? $this->_model->get_one_by_ID($args[0]) : null;
686 686
 
687 687
 		//if no obj then let's just do cap
688
-		if ( ! $obj instanceof EE_Base_Class ) {
688
+		if ( ! $obj instanceof EE_Base_Class) {
689 689
 			$caps[] = $cap;
690 690
 			return $caps;
691 691
 		}
692 692
 
693
-		if ( $obj instanceof EE_CPT_Base ) {
693
+		if ($obj instanceof EE_CPT_Base) {
694 694
 			//if the item author is set and the user is the author...
695
-			if ( $obj->wp_user() && $user_id == $obj->wp_user() ) {
696
-				if ( empty( $this->published_cap ) ) {
695
+			if ($obj->wp_user() && $user_id == $obj->wp_user()) {
696
+				if (empty($this->published_cap)) {
697 697
 					$caps[] = $cap;
698 698
 				} else {
699 699
 					//if obj is published...
700
-					if ( $obj->status() == 'publish' ) {
700
+					if ($obj->status() == 'publish') {
701 701
 						$caps[] = $this->published_cap;
702 702
 					} else {
703 703
 						$caps[] = $cap;
@@ -705,21 +705,21 @@  discard block
 block discarded – undo
705 705
 				}
706 706
 			} else {
707 707
 				//the user is trying to edit someone else's obj
708
-				if ( ! empty( $this->others_cap ) ) {
708
+				if ( ! empty($this->others_cap)) {
709 709
 					$caps[] = $this->others_cap;
710 710
 				}
711
-				if ( ! empty( $this->published_cap ) && $obj->status() == 'publish' ) {
711
+				if ( ! empty($this->published_cap) && $obj->status() == 'publish') {
712 712
 					$caps[] = $this->published_cap;
713
-				} elseif ( ! empty( $this->private_cap ) && $obj->status() == 'private' ) {
713
+				} elseif ( ! empty($this->private_cap) && $obj->status() == 'private') {
714 714
 					$caps[] = $this->private_cap;
715 715
 				}
716 716
 			}
717 717
 		} else {
718 718
 			//not a cpt object so handled differently
719
-			if ( method_exists( $obj, 'wp_user' ) && $obj->wp_user() && $user_id == $obj->wp_user() ) {
719
+			if (method_exists($obj, 'wp_user') && $obj->wp_user() && $user_id == $obj->wp_user()) {
720 720
 				$caps[] = $cap;
721 721
 			} else {
722
-				if ( ! empty( $this->others_cap ) ) {
722
+				if ( ! empty($this->others_cap)) {
723 723
 					$caps[] = $this->others_cap;
724 724
 				}
725 725
 			}
@@ -756,8 +756,8 @@  discard block
 block discarded – undo
756 756
 	 *
757 757
 	 * @return array   actual users capabilities
758 758
 	 */
759
-	protected function _map_meta_caps( $caps, $cap, $user_id, $args ) {
760
-		return parent::_map_meta_caps( $caps, $cap, $user_id, $args );
759
+	protected function _map_meta_caps($caps, $cap, $user_id, $args) {
760
+		return parent::_map_meta_caps($caps, $cap, $user_id, $args);
761 761
 	}
762 762
 }
763 763
 
@@ -789,45 +789,45 @@  discard block
 block discarded – undo
789 789
 	 *
790 790
 	 * @return array   actual users capabilities
791 791
 	 */
792
-	protected function _map_meta_caps( $caps, $cap, $user_id, $args ) {
792
+	protected function _map_meta_caps($caps, $cap, $user_id, $args) {
793 793
 		//only process if we're checking our mapped cap;
794
-		if ( $cap !== $this->meta_cap ) {
794
+		if ($cap !== $this->meta_cap) {
795 795
 			return $caps;
796 796
 		}
797 797
 
798
-		$obj = ! empty( $args[0] ) ? $this->_model->get_one_by_ID( $args[0] ) : null;
798
+		$obj = ! empty($args[0]) ? $this->_model->get_one_by_ID($args[0]) : null;
799 799
 
800 800
 		//if no obj then let's just do cap
801
-		if ( ! $obj instanceof EE_Base_Class ) {
801
+		if ( ! $obj instanceof EE_Base_Class) {
802 802
 			$caps[] = $cap;
803 803
 			return $caps;
804 804
 		}
805 805
 
806
-		if ( $obj instanceof EE_CPT_Base ) {
807
-			$status_obj = get_post_status_object( $obj->status() );
808
-			if ( $status_obj->public ) {
806
+		if ($obj instanceof EE_CPT_Base) {
807
+			$status_obj = get_post_status_object($obj->status());
808
+			if ($status_obj->public) {
809 809
 				$caps[] = $cap;
810 810
 				return $caps;
811 811
 			}
812 812
 
813 813
 			//if the item author is set and the user is the author...
814
-			if ( $obj->wp_user() && $user_id == $obj->wp_user() ) {
814
+			if ($obj->wp_user() && $user_id == $obj->wp_user()) {
815 815
 				$caps[] = $cap;
816
-			} elseif ( $status_obj->private && ! empty( $this->private_cap ) ) {
816
+			} elseif ($status_obj->private && ! empty($this->private_cap)) {
817 817
 				//the user is trying to view someone else's obj
818 818
 				$caps[] = $this->private_cap;
819
-			} elseif ( ! empty( $this->others_cap ) ) {
819
+			} elseif ( ! empty($this->others_cap)) {
820 820
 				$caps[] = $this->others_cap;
821 821
 			} else {
822 822
 				$caps[] = $cap;
823 823
 			}
824 824
 		} else {
825 825
 			//not a cpt object so handled differently
826
-			if ( method_exists( $obj, 'wp_user' ) && $obj->wp_user() && $user_id == $obj->wp_user() ) {
826
+			if (method_exists($obj, 'wp_user') && $obj->wp_user() && $user_id == $obj->wp_user()) {
827 827
 				$caps[] = $cap;
828
-			} elseif ( ! empty( $this->private_cap ) ) {
828
+			} elseif ( ! empty($this->private_cap)) {
829 829
 				$caps[] = $this->private_cap;
830
-			} elseif ( ! empty( $this->others_cap ) ) {
830
+			} elseif ( ! empty($this->others_cap)) {
831 831
 				$caps[] = $this->others_cap;
832 832
 			} else {
833 833
 				$caps[] = $cap;
@@ -864,30 +864,30 @@  discard block
 block discarded – undo
864 864
 	 *
865 865
 	 * @return array   actual users capabilities
866 866
 	 */
867
-	protected function _map_meta_caps( $caps, $cap, $user_id, $args ) {
867
+	protected function _map_meta_caps($caps, $cap, $user_id, $args) {
868 868
 		//only process if we're checking our mapped_cap
869
-		if ( $cap !== $this->meta_cap ) {
869
+		if ($cap !== $this->meta_cap) {
870 870
 			return $caps;
871 871
 		}
872 872
 
873
-		$obj = ! empty( $args[0] ) ? $this->_model->get_one_by_ID( $args[0] ) : null;
873
+		$obj = ! empty($args[0]) ? $this->_model->get_one_by_ID($args[0]) : null;
874 874
 
875 875
 		//if no obj then let's just do cap
876
-		if ( ! $obj instanceof EE_Message_Template_Group ) {
876
+		if ( ! $obj instanceof EE_Message_Template_Group) {
877 877
 			$caps[] = $cap;
878 878
 			return $caps;
879 879
 		}
880 880
 
881 881
 		$is_global = $obj->is_global();
882 882
 
883
-		if ( $obj->wp_user() && $user_id == $obj->wp_user() ) {
884
-			if ( $is_global ) {
885
-				$caps[]  = $this->private_cap;
883
+		if ($obj->wp_user() && $user_id == $obj->wp_user()) {
884
+			if ($is_global) {
885
+				$caps[] = $this->private_cap;
886 886
 			} else {
887 887
 				$caps[] = $cap;
888 888
 			}
889 889
 		} else {
890
-			if ( $is_global ) {
890
+			if ($is_global) {
891 891
 				$caps[] = $this->private_cap;
892 892
 			} else {
893 893
 				$caps[] = $this->others_cap;
@@ -925,16 +925,16 @@  discard block
 block discarded – undo
925 925
 	 *
926 926
 	 * @return array   actual users capabilities
927 927
 	 */
928
-	protected function _map_meta_caps( $caps, $cap, $user_id, $args ) {
928
+	protected function _map_meta_caps($caps, $cap, $user_id, $args) {
929 929
 		//only process if we're checking our mapped_cap
930
-		if ( $cap !== $this->meta_cap ) {
930
+		if ($cap !== $this->meta_cap) {
931 931
 			return $caps;
932 932
 		}
933 933
 
934
-		$obj = ! empty( $args[0] ) ? $this->_model->get_one_by_ID( $args[0] ) : null;
934
+		$obj = ! empty($args[0]) ? $this->_model->get_one_by_ID($args[0]) : null;
935 935
 
936 936
 		//if no obj then let's just do cap
937
-		if ( ! $obj instanceof EE_Base_Class ) {
937
+		if ( ! $obj instanceof EE_Base_Class) {
938 938
 			$caps[] = $cap;
939 939
 			return $caps;
940 940
 		}
@@ -942,7 +942,7 @@  discard block
 block discarded – undo
942 942
 		$is_system = $obj instanceof EE_Question_Group ? $obj->system_group() : false;
943 943
 		$is_system = $obj instanceof EE_Question ? $obj->is_system_question() : $is_system;
944 944
 
945
-		if ( $is_system ) {
945
+		if ($is_system) {
946 946
 			$caps[] = $this->private_cap;
947 947
 		} else {
948 948
 			$caps[] = $cap;
Please login to merge, or discard this patch.
core/EE_Deprecated.core.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
 	}
320 320
 
321 321
 	/**
322
-	 * @param $method_name
322
+	 * @param string $method_name
323 323
 	 */
324 324
 	public static function doing_it_wrong_call( $method_name ) {
325 325
 		EE_Error::doing_it_wrong( __CLASS__, sprintf( __('The %s in this class is deprecated as of EE4.5.0.  All functionality formerly in this class is now in the EED_Messages module.', 'event_espresso'), $method_name ), '4.5.0', E_USER_DEPRECATED );
Please login to merge, or discard this patch.
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1,18 +1,18 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file contains all deprecated actions, filters, and functions in EE.
4
- * @package      Event Espresso
5
- * @subpackage helpers
6
- * @since           4.5.0
7
- */
3
+	 * This file contains all deprecated actions, filters, and functions in EE.
4
+	 * @package      Event Espresso
5
+	 * @subpackage helpers
6
+	 * @since           4.5.0
7
+	 */
8 8
 if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
9 9
 /**
10
- * ee_deprecated__registration_checkout__button_text
11
- *
12
- * @param string       $submit_button_text
13
- * @param \EE_Checkout $checkout
14
- * @return string
15
- */
10
+	 * ee_deprecated__registration_checkout__button_text
11
+	 *
12
+	 * @param string       $submit_button_text
13
+	 * @param \EE_Checkout $checkout
14
+	 * @return string
15
+	 */
16 16
 function ee_deprecated__registration_checkout__button_text( $submit_button_text, EE_Checkout $checkout ) {
17 17
 	// list of old filters
18 18
 	$deprecated_filters = array(
@@ -110,10 +110,10 @@  discard block
 block discarded – undo
110 110
 }
111 111
 add_action( 'AHEE__EE_SPCO_Reg_Step_Finalize_Registration__process_reg_step__completed', 'ee_deprecated_finalize_transaction', 10, 2 );
112 112
 /**
113
- * ee_deprecated_finalize_registration
114
- *
115
- * @param EE_Registration $registration
116
- */
113
+	 * ee_deprecated_finalize_registration
114
+	 *
115
+	 * @param EE_Registration $registration
116
+	 */
117 117
 function ee_deprecated_finalize_registration( EE_Registration $registration ) {
118 118
 	$action_ref = has_action( 'AHEE__EE_Registration__finalize__update_and_new_reg' ) ? 'AHEE__EE_Registration__finalize__update_and_new_reg' : NULL;
119 119
 	if ( $action_ref ) {
Please login to merge, or discard this patch.
Spacing   +104 added lines, -104 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
  * @param \EE_Checkout $checkout
14 14
  * @return string
15 15
  */
16
-function ee_deprecated__registration_checkout__button_text( $submit_button_text, EE_Checkout $checkout ) {
16
+function ee_deprecated__registration_checkout__button_text($submit_button_text, EE_Checkout $checkout) {
17 17
 	// list of old filters
18 18
 	$deprecated_filters = array(
19 19
 		'update_registration_details' => true,
@@ -23,16 +23,16 @@  discard block
 block discarded – undo
23 23
 		'proceed_to' => true,
24 24
 	);
25 25
 	// loop thru and call doing_it_wrong() or remove any that aren't being used
26
-	foreach ( $deprecated_filters as $deprecated_filter => $on ) {
26
+	foreach ($deprecated_filters as $deprecated_filter => $on) {
27 27
 		// was this filter called ?
28
-		if ( has_action( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__' . $deprecated_filter )) {
28
+		if (has_action('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__'.$deprecated_filter)) {
29 29
 			// only display doing_it_wrong() notice to Event Admins during non-AJAX requests
30
-			if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_ee', 'hide_doing_it_wrong_for_deprecated_SPCO_filter' ) && ! defined( 'DOING_AJAX' ) ) {
30
+			if (EE_Registry::instance()->CAP->current_user_can('ee_read_ee', 'hide_doing_it_wrong_for_deprecated_SPCO_filter') && ! defined('DOING_AJAX')) {
31 31
 				EE_Error::doing_it_wrong(
32
-					'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__' . $deprecated_filter,
32
+					'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__'.$deprecated_filter,
33 33
 					sprintf(
34
-						__( 'The %1$s filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the following new filter: %2$s"%3$s" found in "%4$s"', 'event_espresso' ),
35
-						'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__' . $deprecated_filter,
34
+						__('The %1$s filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the following new filter: %2$s"%3$s" found in "%4$s"', 'event_espresso'),
35
+						'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__'.$deprecated_filter,
36 36
 						'<br />',
37 37
 						'FHEE__EE_SPCO_Reg_Step__set_submit_button_text___submit_button_text',
38 38
 						'/modules/single_page_checkout/inc/EE_SPCO_Reg_Step.class.php'
@@ -41,24 +41,24 @@  discard block
 block discarded – undo
41 41
 				);
42 42
 			}
43 43
 		} else {
44
-			unset( $deprecated_filters[ $deprecated_filter ] );
44
+			unset($deprecated_filters[$deprecated_filter]);
45 45
 		}
46 46
 	}
47
-	if ( ! empty( $deprecated_filters )) {
48
-
49
-		if ( $checkout->current_step->slug() == 'attendee_information' && $checkout->revisit && isset( $deprecated_filters[ 'update_registration_details' ] )) {
50
-			$submit_button_text = apply_filters( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__update_registration_details', $submit_button_text );
51
-		} else if ( $checkout->current_step->slug() == 'payment_options' && $checkout->revisit && isset( $deprecated_filters[ 'process_payment' ] ) ) {
52
-			$submit_button_text = apply_filters( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__process_payment', $submit_button_text );
53
-		} else if ( $checkout->next_step instanceof EE_SPCO_Reg_Step && $checkout->next_step->slug() == 'finalize_registration' && isset( $deprecated_filters[ 'finalize_registration' ] ) ) {
54
-			$submit_button_text = apply_filters( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__finalize_registration', $submit_button_text );
47
+	if ( ! empty($deprecated_filters)) {
48
+
49
+		if ($checkout->current_step->slug() == 'attendee_information' && $checkout->revisit && isset($deprecated_filters['update_registration_details'])) {
50
+			$submit_button_text = apply_filters('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__update_registration_details', $submit_button_text);
51
+		} else if ($checkout->current_step->slug() == 'payment_options' && $checkout->revisit && isset($deprecated_filters['process_payment'])) {
52
+			$submit_button_text = apply_filters('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__process_payment', $submit_button_text);
53
+		} else if ($checkout->next_step instanceof EE_SPCO_Reg_Step && $checkout->next_step->slug() == 'finalize_registration' && isset($deprecated_filters['finalize_registration'])) {
54
+			$submit_button_text = apply_filters('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__finalize_registration', $submit_button_text);
55 55
 		}
56
-		if ( $checkout->next_step instanceof EE_SPCO_Reg_Step ) {
57
-			if ( $checkout->payment_required() && $checkout->next_step->slug() == 'payment_options' && isset( $deprecated_filters[ 'and_proceed_to_payment' ] ) ) {
58
-				$submit_button_text .= apply_filters( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__and_proceed_to_payment', $submit_button_text );
56
+		if ($checkout->next_step instanceof EE_SPCO_Reg_Step) {
57
+			if ($checkout->payment_required() && $checkout->next_step->slug() == 'payment_options' && isset($deprecated_filters['and_proceed_to_payment'])) {
58
+				$submit_button_text .= apply_filters('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__and_proceed_to_payment', $submit_button_text);
59 59
 			}
60
-			if ( $checkout->next_step->slug() != 'finalize_registration' && ! $checkout->revisit && isset( $deprecated_filters[ 'proceed_to' ] ) ) {
61
-				$submit_button_text = apply_filters( 'FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__proceed_to', $submit_button_text ) . $checkout->next_step->name();
60
+			if ($checkout->next_step->slug() != 'finalize_registration' && ! $checkout->revisit && isset($deprecated_filters['proceed_to'])) {
61
+				$submit_button_text = apply_filters('FHEE__EED_Single_Page_Checkout__registration_checkout__button_text__proceed_to', $submit_button_text).$checkout->next_step->name();
62 62
 			}
63 63
 		}
64 64
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	return $submit_button_text;
67 67
 
68 68
 }
69
-add_filter( 'FHEE__EE_SPCO_Reg_Step__set_submit_button_text___submit_button_text', 'ee_deprecated__registration_checkout__button_text', 10, 2 );
69
+add_filter('FHEE__EE_SPCO_Reg_Step__set_submit_button_text___submit_button_text', 'ee_deprecated__registration_checkout__button_text', 10, 2);
70 70
 
71 71
 
72 72
 
@@ -77,16 +77,16 @@  discard block
 block discarded – undo
77 77
  * @param \EE_Checkout $checkout
78 78
  * @param boolean $status_updates
79 79
  */
80
-function ee_deprecated_finalize_transaction( EE_Checkout $checkout, $status_updates ) {
80
+function ee_deprecated_finalize_transaction(EE_Checkout $checkout, $status_updates) {
81 81
 	$action_ref = NULL;
82
-	$action_ref = has_action( 'AHEE__EE_Transaction__finalize__new_transaction' ) ? 'AHEE__EE_Transaction__finalize__new_transaction' : $action_ref;
83
-	$action_ref = has_action( 'AHEE__EE_Transaction__finalize__all_transaction' ) ? 'AHEE__EE_Transaction__finalize__all_transaction' : $action_ref;
84
-	if ( $action_ref ) {
82
+	$action_ref = has_action('AHEE__EE_Transaction__finalize__new_transaction') ? 'AHEE__EE_Transaction__finalize__new_transaction' : $action_ref;
83
+	$action_ref = has_action('AHEE__EE_Transaction__finalize__all_transaction') ? 'AHEE__EE_Transaction__finalize__all_transaction' : $action_ref;
84
+	if ($action_ref) {
85 85
 
86 86
 		EE_Error::doing_it_wrong(
87 87
 			$action_ref,
88 88
 			sprintf(
89
-				__( 'This action is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use one of the following new actions: %1$s"%3$s" found in "%2$s" %1$s"%4$s" found in "%2$s" %1$s"%5$s" found in "%2$s" %1$s"%6$s" found in "%2$s"', 'event_espresso' ),
89
+				__('This action is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use one of the following new actions: %1$s"%3$s" found in "%2$s" %1$s"%4$s" found in "%2$s" %1$s"%5$s" found in "%2$s" %1$s"%6$s" found in "%2$s"', 'event_espresso'),
90 90
 				'<br />',
91 91
 				'/core/business/EE_Transaction_Processor.class.php',
92 92
 				'AHEE__EE_Transaction_Processor__finalize',
@@ -96,39 +96,39 @@  discard block
 block discarded – undo
96 96
 			),
97 97
 			'4.6.0'
98 98
 		);
99
-		switch ( $action_ref ) {
99
+		switch ($action_ref) {
100 100
 			case 'AHEE__EE_Transaction__finalize__new_transaction' :
101
-				do_action( 'AHEE__EE_Transaction__finalize__new_transaction', $checkout->transaction, $checkout->admin_request );
101
+				do_action('AHEE__EE_Transaction__finalize__new_transaction', $checkout->transaction, $checkout->admin_request);
102 102
 				break;
103 103
 			case 'AHEE__EE_Transaction__finalize__all_transaction' :
104
-				do_action( 'AHEE__EE_Transaction__finalize__new_transaction', $checkout->transaction, array( 'new_reg' => ! $checkout->revisit, 'to_approved' => $status_updates ), $checkout->admin_request );
104
+				do_action('AHEE__EE_Transaction__finalize__new_transaction', $checkout->transaction, array('new_reg' => ! $checkout->revisit, 'to_approved' => $status_updates), $checkout->admin_request);
105 105
 				break;
106 106
 		}
107 107
 	}
108 108
 }
109
-add_action( 'AHEE__EE_SPCO_Reg_Step_Finalize_Registration__process_reg_step__completed', 'ee_deprecated_finalize_transaction', 10, 2 );
109
+add_action('AHEE__EE_SPCO_Reg_Step_Finalize_Registration__process_reg_step__completed', 'ee_deprecated_finalize_transaction', 10, 2);
110 110
 /**
111 111
  * ee_deprecated_finalize_registration
112 112
  *
113 113
  * @param EE_Registration $registration
114 114
  */
115
-function ee_deprecated_finalize_registration( EE_Registration $registration ) {
116
-	$action_ref = has_action( 'AHEE__EE_Registration__finalize__update_and_new_reg' ) ? 'AHEE__EE_Registration__finalize__update_and_new_reg' : NULL;
117
-	if ( $action_ref ) {
115
+function ee_deprecated_finalize_registration(EE_Registration $registration) {
116
+	$action_ref = has_action('AHEE__EE_Registration__finalize__update_and_new_reg') ? 'AHEE__EE_Registration__finalize__update_and_new_reg' : NULL;
117
+	if ($action_ref) {
118 118
 		EE_Error::doing_it_wrong(
119 119
 			$action_ref,
120 120
 			sprintf(
121
-				__( 'This action is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the following new action: %1$s"%3$s" found in "%2$s"', 'event_espresso' ),
121
+				__('This action is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the following new action: %1$s"%3$s" found in "%2$s"', 'event_espresso'),
122 122
 				'<br />',
123 123
 				'/core/business/EE_Registration_Processor.class.php',
124 124
 				'AHEE__EE_Registration_Processor__trigger_registration_status_changed_hook'
125 125
 			),
126 126
 			'4.6.0'
127 127
 		);
128
-		do_action( 'AHEE__EE_Registration__finalize__update_and_new_reg', $registration, ( is_admin() && ! ( defined( 'DOING_AJAX' ) && DOING_AJAX )));
128
+		do_action('AHEE__EE_Registration__finalize__update_and_new_reg', $registration, (is_admin() && ! (defined('DOING_AJAX') && DOING_AJAX)));
129 129
 	}
130 130
 }
131
-add_action( 'AHEE__EE_Registration_Processor__trigger_registration_update_notifications', 'ee_deprecated_finalize_registration', 10, 1 );
131
+add_action('AHEE__EE_Registration_Processor__trigger_registration_update_notifications', 'ee_deprecated_finalize_registration', 10, 1);
132 132
 
133 133
 
134 134
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
  *
150 150
  * @return array
151 151
  */
152
-function ee_deprecated_get_templates( $templates, EE_messenger $messenger, EE_message_type $message_type, EE_Messages_Template_Pack $template_pack ) {
152
+function ee_deprecated_get_templates($templates, EE_messenger $messenger, EE_message_type $message_type, EE_Messages_Template_Pack $template_pack) {
153 153
 	$old_default_classnames = array(
154 154
 		'EE_Messages_Email_Cancelled_Registration_Defaults',
155 155
 		'EE_Messages_Email_Declined_Registration_Defaults',
@@ -165,23 +165,23 @@  discard block
 block discarded – undo
165 165
 
166 166
 	$old_class_instance = new stdClass();
167 167
 
168
-	foreach ( $old_default_classnames as $classname ) {
169
-		$filter_ref = 'FHEE__' . $classname . '___create_new_templates___templates';
170
-		if ( has_filter( $filter_ref ) ) {
171
-			EE_Error::doing_it_wrong( $filter_ref, __('This filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the new filter provided which is "FHEE__EE_Template_Pack___get_templates__templates" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0' );
168
+	foreach ($old_default_classnames as $classname) {
169
+		$filter_ref = 'FHEE__'.$classname.'___create_new_templates___templates';
170
+		if (has_filter($filter_ref)) {
171
+			EE_Error::doing_it_wrong($filter_ref, __('This filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the new filter provided which is "FHEE__EE_Template_Pack___get_templates__templates" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0');
172 172
 		}
173
-		$templates = apply_filters( $filter_ref, $templates, $old_class_instance );
173
+		$templates = apply_filters($filter_ref, $templates, $old_class_instance);
174 174
 	}
175 175
 
176 176
 	return $templates;
177 177
 }
178
-add_filter( 'FHEE__EE_Template_Pack___get_templates__templates', 'ee_deprecated_get_templates', 10, 4 );
178
+add_filter('FHEE__EE_Template_Pack___get_templates__templates', 'ee_deprecated_get_templates', 10, 4);
179 179
 
180 180
 /**
181 181
  * Called after EED_Module::set_hooks() and EED_Module::set_admin_hooks() was called.
182 182
  * Checks if any deprecated hooks were hooked-into and provide doing_it_wrong messages appropriately.
183 183
  */
184
-function ee_deprecated_hooks(){
184
+function ee_deprecated_hooks() {
185 185
 	/**
186 186
 	 * @var $hooks array where keys are hook names, and their values are array{
187 187
 	 *			@type string $version  when deprecated
@@ -192,25 +192,25 @@  discard block
 block discarded – undo
192 192
 	$hooks = array(
193 193
 		'AHEE__EE_System___do_setup_validations' => array(
194 194
 			'version' => '4.6.0',
195
-			'alternative' => __( 'Instead use "AHEE__EEH_Activation__validate_messages_system" which is called after validating messages (done on every new install, upgrade, reactivation, and downgrade)', 'event_espresso' ),
195
+			'alternative' => __('Instead use "AHEE__EEH_Activation__validate_messages_system" which is called after validating messages (done on every new install, upgrade, reactivation, and downgrade)', 'event_espresso'),
196 196
 			'still_works' => FALSE
197 197
 		)
198 198
 	);
199
-	foreach( $hooks as $name => $deprecation_info ){
200
-		if( has_action( $name ) ){
199
+	foreach ($hooks as $name => $deprecation_info) {
200
+		if (has_action($name)) {
201 201
 			EE_Error::doing_it_wrong(
202 202
 				$name,
203 203
 				sprintf(
204
-					__('This filter is deprecated. %1$s%2$s','event_espresso'),
205
-					$deprecation_info[ 'still_works' ] ?  __('It *may* work as an attempt to build in backwards compatibility.', 'event_espresso') : __( 'It has been completely removed.', 'event_espresso' ),
206
-					isset( $deprecation_info[ 'alternative' ] ) ? $deprecation_info[ 'alternative' ] : __( 'Please read the current EE4 documentation further or contact Support.', 'event_espresso' )
204
+					__('This filter is deprecated. %1$s%2$s', 'event_espresso'),
205
+					$deprecation_info['still_works'] ? __('It *may* work as an attempt to build in backwards compatibility.', 'event_espresso') : __('It has been completely removed.', 'event_espresso'),
206
+					isset($deprecation_info['alternative']) ? $deprecation_info['alternative'] : __('Please read the current EE4 documentation further or contact Support.', 'event_espresso')
207 207
 				),
208
-				isset( $deprecation_info[ 'version' ] ) ? $deprecation_info[ 'version' ] : __( 'recently', 'event_espresso' )
208
+				isset($deprecation_info['version']) ? $deprecation_info['version'] : __('recently', 'event_espresso')
209 209
 			);
210 210
 		}
211 211
 	}
212 212
 }
213
-add_action( 'AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons', 'ee_deprecated_hooks' );
213
+add_action('AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons', 'ee_deprecated_hooks');
214 214
 
215 215
 
216 216
 
@@ -233,25 +233,25 @@  discard block
 block discarded – undo
233 233
  *
234 234
  * @return string                    The default contents for the messenger, message type, context and field.
235 235
  */
236
-function ee_deprecated_get_default_field_content( $contents, $actual_path, EE_messenger $messenger, EE_message_type $message_type, $field, $context, EE_Messages_Template_Pack $template_pack ) {
236
+function ee_deprecated_get_default_field_content($contents, $actual_path, EE_messenger $messenger, EE_message_type $message_type, $field, $context, EE_Messages_Template_Pack $template_pack) {
237 237
 
238 238
 	$classnames_to_try = array(
239
-		get_class( $messenger ) => $messenger,
240
-		get_class( $message_type ) => $message_type,
239
+		get_class($messenger) => $messenger,
240
+		get_class($message_type) => $message_type,
241 241
 		'EE_Messages_Base' => $message_type
242 242
 		);
243 243
 
244
-	foreach ( $classnames_to_try as $classname => $obj ) {
245
-		$filter_ref = 'FHEE__' . $classname . '__get_default_field_content';
246
-		if ( has_filter( $filter_ref ) ) {
247
-			EE_Error::doing_it_wrong( $filter_ref, __('This filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the new filter provided which is "FHEE__EE_Messages_Template_Pack__get_specific_template__contents" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0' );
244
+	foreach ($classnames_to_try as $classname => $obj) {
245
+		$filter_ref = 'FHEE__'.$classname.'__get_default_field_content';
246
+		if (has_filter($filter_ref)) {
247
+			EE_Error::doing_it_wrong($filter_ref, __('This filter is deprecated.  It *may* work as an attempt to build in backwards compatibility.  However, it is recommended to use the new filter provided which is "FHEE__EE_Messages_Template_Pack__get_specific_template__contents" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0');
248 248
 		}
249
-		$contents = apply_filters( $filter_ref, $contents, $obj );
249
+		$contents = apply_filters($filter_ref, $contents, $obj);
250 250
 	}
251 251
 
252 252
 	return $contents;
253 253
 }
254
-add_filter( 'FHEE__EE_Messages_Template_Pack__get_specific_template__contents', 'ee_deprecated_get_default_field_content', 10, 7 );
254
+add_filter('FHEE__EE_Messages_Template_Pack__get_specific_template__contents', 'ee_deprecated_get_default_field_content', 10, 7);
255 255
 
256 256
 
257 257
 
@@ -279,23 +279,23 @@  discard block
 block discarded – undo
279 279
  *
280 280
  * @return string                    The path to the file being used.
281 281
  */
282
-function ee_deprecated_get_inline_css_template_filters( $variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url,  EE_Messages_Template_Pack $template_pack ) {
282
+function ee_deprecated_get_inline_css_template_filters($variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url, EE_Messages_Template_Pack $template_pack) {
283 283
 
284
-	if ( $messenger == 'email' ) {
284
+	if ($messenger == 'email') {
285 285
 		$filter_ref = $url ? 'FHEE__EE_Email_Messenger__get_inline_css_template__css_url' : 'FHEE__EE_Email_Messenger__get_inline_css_template__css_path';
286
-	} elseif ( $messenger == 'html' ) {
286
+	} elseif ($messenger == 'html') {
287 287
 		$filter_ref = $url ? 'FHEE__EE_Html_messenger__get_inline_css_template__css_url' : 'FHEE__EE_Html_messenger__get_inline_css_template__css_path';
288 288
 	} else {
289 289
 		return $variation_path;
290 290
 	}
291 291
 
292
-	if ( has_filter( $filter_ref ) ) {
293
-		EE_Error::doing_it_wrong( $filter_ref, __('This filter is deprecated.  It is recommended to use the new filter provided which is "FHEE__EE_Messages_Template_Pack__get_variation" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0' );
292
+	if (has_filter($filter_ref)) {
293
+		EE_Error::doing_it_wrong($filter_ref, __('This filter is deprecated.  It is recommended to use the new filter provided which is "FHEE__EE_Messages_Template_Pack__get_variation" found in the EE_Messages_Template_Pack class.', 'event_espresso'), '4.5.0');
294 294
 	}
295 295
 
296
-	return apply_filters( $filter_ref, $variation_path, $url, $type );
296
+	return apply_filters($filter_ref, $variation_path, $url, $type);
297 297
 }
298
-add_filter( 'FHEE__EE_Messages_Template_Pack__get_variation', 'ee_deprecated_get_inline_css_template_filters', 10, 8 );
298
+add_filter('FHEE__EE_Messages_Template_Pack__get_variation', 'ee_deprecated_get_inline_css_template_filters', 10, 8);
299 299
 
300 300
 
301 301
 
@@ -311,78 +311,78 @@  discard block
 block discarded – undo
311 311
 class EE_Messages_Init extends EE_Base {
312 312
 
313 313
 	public function __construct() {
314
-		self::doing_it_wrong_call( __METHOD__ );
314
+		self::doing_it_wrong_call(__METHOD__);
315 315
 	}
316 316
 
317 317
 	/**
318 318
 	 * @param $method_name
319 319
 	 */
320
-	public static function doing_it_wrong_call( $method_name ) {
321
-		EE_Error::doing_it_wrong( __CLASS__, sprintf( __('The %s in this class is deprecated as of EE4.5.0.  All functionality formerly in this class is now in the EED_Messages module.', 'event_espresso'), $method_name ), '4.5.0' );
320
+	public static function doing_it_wrong_call($method_name) {
321
+		EE_Error::doing_it_wrong(__CLASS__, sprintf(__('The %s in this class is deprecated as of EE4.5.0.  All functionality formerly in this class is now in the EED_Messages module.', 'event_espresso'), $method_name), '4.5.0');
322 322
 	}
323 323
 
324 324
 	/**
325 325
 	 * @deprecated 4.5.0
326 326
 	 */
327 327
 	public static function set_autoloaders() {
328
-		self::doing_it_wrong_call( __METHOD__ );
328
+		self::doing_it_wrong_call(__METHOD__);
329 329
 		EED_Messages::set_autoloaders();
330 330
 	}
331 331
 
332 332
 	/**
333 333
 	 * @deprecated 4.5.0
334 334
 	 */
335
-	public function payment_reminder( $transaction ) {
336
-		self::doing_it_wrong_call( __METHOD__ );
337
-		EED_Messages::payment_reminder( $transaction );
335
+	public function payment_reminder($transaction) {
336
+		self::doing_it_wrong_call(__METHOD__);
337
+		EED_Messages::payment_reminder($transaction);
338 338
 	}
339 339
 
340 340
 	/**
341 341
 	 * @deprecated 4.5.0
342 342
 	 */
343
-	public function payment( $transaction, $payment ) {
344
-		self::doing_it_wrong_call( __METHOD__ );
345
-		EED_Messages::payment( $transaction, $payment );
343
+	public function payment($transaction, $payment) {
344
+		self::doing_it_wrong_call(__METHOD__);
345
+		EED_Messages::payment($transaction, $payment);
346 346
 	}
347 347
 
348 348
 	/**
349 349
 	 * @deprecated 4.5.0
350 350
 	 */
351
-	public function cancelled_registration( $transaction ) {
352
-		self::doing_it_wrong_call( __METHOD__ );
353
-		EED_Messages::cancelled_registration( $transaction );
351
+	public function cancelled_registration($transaction) {
352
+		self::doing_it_wrong_call(__METHOD__);
353
+		EED_Messages::cancelled_registration($transaction);
354 354
 	}
355 355
 
356 356
 	/**
357 357
 	 * @deprecated 4.5.0
358 358
 	 */
359
-	public function maybe_registration( $transaction, $reg_msg, $from_admin ) {
360
-		self::doing_it_wrong_call( __METHOD__ );
361
-		EED_Messages::maybe_registration( $transaction, $reg_msg, $from_admin );
359
+	public function maybe_registration($transaction, $reg_msg, $from_admin) {
360
+		self::doing_it_wrong_call(__METHOD__);
361
+		EED_Messages::maybe_registration($transaction, $reg_msg, $from_admin);
362 362
 	}
363 363
 
364 364
 	/**
365 365
 	 * @deprecated 4.5.0
366 366
 	 */
367
-	public function process_resend( $success, $req_data ) {
368
-		self::doing_it_wrong_call( __METHOD__ );
369
-		EED_Messages::process_resend( $req_data );
367
+	public function process_resend($success, $req_data) {
368
+		self::doing_it_wrong_call(__METHOD__);
369
+		EED_Messages::process_resend($req_data);
370 370
 	}
371 371
 
372 372
 	/**
373 373
 	 * @deprecated 4.5.0
374 374
 	 */
375
-	public function process_admin_payment( $success, $payment ) {
376
-		self::doing_it_wrong_call( __METHOD__ );
377
-		EED_Messages::process_admin_payment( $success, $payment );
375
+	public function process_admin_payment($success, $payment) {
376
+		self::doing_it_wrong_call(__METHOD__);
377
+		EED_Messages::process_admin_payment($success, $payment);
378 378
 	}
379 379
 
380 380
 	/**
381 381
 	 * @deprecated 4.5.0
382 382
 	 */
383
-	public function send_newsletter_message( $contacts, $grp_id ) {
384
-		self::doing_it_wrong_call( __METHOD__ );
385
-		EED_Messages::send_newsletter_message( $contacts, $grp_id );
383
+	public function send_newsletter_message($contacts, $grp_id) {
384
+		self::doing_it_wrong_call(__METHOD__);
385
+		EED_Messages::send_newsletter_message($contacts, $grp_id);
386 386
 	}
387 387
 
388 388
 
@@ -403,13 +403,13 @@  discard block
 block discarded – undo
403 403
  *
404 404
  * @return array additional cpts.
405 405
  */
406
-function ee_deprecated_get_cpts( $cpts ) {
407
-	if ( has_filter( 'FHEE__EE_Register_CPTs__construct__CPTs' ) ) {
408
-		EE_Error::doing_it_wrong( 'FHEE__EE_Register_CPTs__construct__CPTs', __('This filter is deprecated. It will still work for the time being.  However, it is recommended to use the new filter provided which is "FHEE__EE_Register_CPTs__get_CPTs__cpts" found in EE_Register_CPTs::get_CPTs()', 'event_espresso'), '4.5.0' );
406
+function ee_deprecated_get_cpts($cpts) {
407
+	if (has_filter('FHEE__EE_Register_CPTs__construct__CPTs')) {
408
+		EE_Error::doing_it_wrong('FHEE__EE_Register_CPTs__construct__CPTs', __('This filter is deprecated. It will still work for the time being.  However, it is recommended to use the new filter provided which is "FHEE__EE_Register_CPTs__get_CPTs__cpts" found in EE_Register_CPTs::get_CPTs()', 'event_espresso'), '4.5.0');
409 409
 	}
410
-	return apply_filters( 'FHEE__EE_Register_CPTs__construct__CPTs', $cpts );
410
+	return apply_filters('FHEE__EE_Register_CPTs__construct__CPTs', $cpts);
411 411
 }
412
-add_filter( 'FHEE__EE_Register_CPTs__get_CPTs__cpts', 'ee_deprecated_get_cpts', 10 );
412
+add_filter('FHEE__EE_Register_CPTs__get_CPTs__cpts', 'ee_deprecated_get_cpts', 10);
413 413
 
414 414
 
415 415
 
@@ -423,10 +423,10 @@  discard block
 block discarded – undo
423 423
  *
424 424
  * @return array additional custom taxonomies.
425 425
  */
426
-function ee_deprecated_get_taxonomies( $cts ) {
427
-	if ( has_filter( 'FHEE__EE_Register_CPTs__construct__taxonomies' ) ) {
428
-		EE_Error::doing_it_wrong( 'FHEE__EE_Register_CPTs__construct__taxonomies', __('This filter is deprecated. It will still work for the time being.  However, it is recommended to use the new filter provided which is "FHEE__EE_Register_CPTs__get_taxonomies__taxonomies" found in EE_Register_CPTs::get_taxonomies()', 'event_espresso'), '4.5.0' );
426
+function ee_deprecated_get_taxonomies($cts) {
427
+	if (has_filter('FHEE__EE_Register_CPTs__construct__taxonomies')) {
428
+		EE_Error::doing_it_wrong('FHEE__EE_Register_CPTs__construct__taxonomies', __('This filter is deprecated. It will still work for the time being.  However, it is recommended to use the new filter provided which is "FHEE__EE_Register_CPTs__get_taxonomies__taxonomies" found in EE_Register_CPTs::get_taxonomies()', 'event_espresso'), '4.5.0');
429 429
 	}
430
-	return apply_filters( 'FHEE__EE_Register_CPTs__construct__taxonomies', $cts );
430
+	return apply_filters('FHEE__EE_Register_CPTs__construct__taxonomies', $cts);
431 431
 }
432
-add_filter( 'FHEE__EE_Register_CPTs__get_taxonomies__taxonomies', 'ee_deprecated_get_taxonomies', 10 );
432
+add_filter('FHEE__EE_Register_CPTs__get_taxonomies__taxonomies', 'ee_deprecated_get_taxonomies', 10);
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,9 @@
 block discarded – undo
5 5
  * @subpackage plugin api, messages
6 6
  * @since           4.5.0
7 7
  */
8
-if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
8
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
9
+	exit('No direct script access allowed');
10
+}
9 11
 
10 12
 /**
11 13
  * Use this to register or deregister a new message template pack variation for the EE messages system.
Please login to merge, or discard this patch.
core/EE_Error.core.php 4 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	/**
89 89
 	 *    error_handler
90 90
 	 * @access public
91
-	 * @param $code
91
+	 * @param integer $code
92 92
 	 * @param $message
93 93
 	 * @param $file
94 94
 	 * @param $line
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	/**
190 190
 	 *    _format_error
191 191
 	 * @access private
192
-	 * @param $code
192
+	 * @param string $code
193 193
 	 * @param $message
194 194
 	 * @param $file
195 195
 	 * @param $line
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 	 *
937 937
 	 * @access    public
938 938
 	 * @param string $return_url
939
-	 * @return    array
939
+	 * @return    string
940 940
 	 */
941 941
 	public static function get_persistent_admin_notices( $return_url = '' ) {
942 942
 		$notices = '';
@@ -961,7 +961,7 @@  discard block
 block discarded – undo
961 961
 	 *
962 962
 	 * @access 	public
963 963
 	 * @param 	bool $force_print
964
-	 * @return 	void
964
+	 * @return 	null|string
965 965
 	 */
966 966
 	private static function _print_scripts( $force_print = FALSE ) {
967 967
 		if (( did_action( 'admin_enqueue_scripts' ) || did_action( 'wp_enqueue_scripts' )) && ! $force_print ) {
Please login to merge, or discard this patch.
Indentation   +174 added lines, -174 removed lines patch added patch discarded remove patch
@@ -5,65 +5,65 @@  discard block
 block discarded – undo
5 5
 	register_shutdown_function( array( 'EE_Error', 'fatal_error_handler' ));
6 6
 }
7 7
 /**
8
- *
9
- * Error Handling Class
10
- *
11
- * @package			Event Espresso
12
- * @subpackage		includes/classes/EE_Exceptions.class.php
13
- * @author				Brent Christensen
14
- *
15
- * ------------------------------------------------------------------------
16
- */
8
+	 *
9
+	 * Error Handling Class
10
+	 *
11
+	 * @package			Event Espresso
12
+	 * @subpackage		includes/classes/EE_Exceptions.class.php
13
+	 * @author				Brent Christensen
14
+	 *
15
+	 * ------------------------------------------------------------------------
16
+	 */
17 17
 class EE_Error extends Exception {
18 18
 
19 19
 
20 20
 	/**
21
-	* 	name of the file to log exceptions to
22
-	* 	@access	private
23
-    *	@var string
24
-	*/
21
+	 * 	name of the file to log exceptions to
22
+	 * 	@access	private
23
+	 *	@var string
24
+	 */
25 25
 	private static $_exception_log_file = 'espresso_error_log.txt';
26 26
 
27 27
 	/**
28
-	* 	the exception
29
-	* 	@access	private
30
-    *	@var object
31
-	*/
28
+	 * 	the exception
29
+	 * 	@access	private
30
+	 *	@var object
31
+	 */
32 32
 	private $_exception;
33 33
 
34 34
 	/**
35
-	* 	stores details for all exception
36
-	* 	@access	private
37
-    *	@var array
38
-	*/
35
+	 * 	stores details for all exception
36
+	 * 	@access	private
37
+	 *	@var array
38
+	 */
39 39
 	private static $_all_exceptions = array();
40 40
 
41 41
 	/**
42
-	* 	tracks number of errors
43
-	* 	@access	private
44
-    *	@var int
45
-	*/
42
+	 * 	tracks number of errors
43
+	 * 	@access	private
44
+	 *	@var int
45
+	 */
46 46
 	private static $_error_count = 0;
47 47
 
48 48
 	/**
49
-	* 	has JS been loaded ?
50
-	* 	@access	private
51
-    *	@var boolean
52
-	*/
49
+	 * 	has JS been loaded ?
50
+	 * 	@access	private
51
+	 *	@var boolean
52
+	 */
53 53
 	private static $_js_loaded = FALSE;
54 54
 
55 55
 	/**
56
-	* 	has shutdown action been added ?
57
-	* 	@access	private
58
-    *	@var boolean
59
-	*/
56
+	 * 	has shutdown action been added ?
57
+	 * 	@access	private
58
+	 *	@var boolean
59
+	 */
60 60
 	private static $_action_added = FALSE;
61 61
 
62 62
 	/**
63
-	* 	has shutdown action been added ?
64
-	* 	@access	private
65
-    *	@var boolean
66
-	*/
63
+	 * 	has shutdown action been added ?
64
+	 * 	@access	private
65
+	 *	@var boolean
66
+	 */
67 67
 	private static $_espresso_notices = array( 'success' => FALSE, 'errors' => FALSE, 'attention' => FALSE );
68 68
 
69 69
 
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
71 71
 
72 72
 
73 73
 	/**
74
-	*	@override default exception handling
75
-	*	@access public
76
-	*	@echo string
77
-	*/
74
+	 *	@override default exception handling
75
+	 *	@access public
76
+	 *	@echo string
77
+	 */
78 78
 	function __construct( $message, $code = 0, Exception $previous = NULL ) {
79 79
 		if ( version_compare( phpversion(), '5.3.0', '<' )) {
80 80
 			parent::__construct( $message, $code );
@@ -173,10 +173,10 @@  discard block
 block discarded – undo
173 173
 
174 174
 
175 175
 	/**
176
-	*	fatal_error_handler
177
-	*	@access public
178
-	*	@return void
179
-	*/
176
+	 *	fatal_error_handler
177
+	 *	@access public
178
+	 *	@return void
179
+	 */
180 180
 	public static function fatal_error_handler() {
181 181
 		$last_error = error_get_last();
182 182
 		if ( $last_error['type'] === E_ERROR ) {
@@ -221,11 +221,11 @@  discard block
 block discarded – undo
221 221
 
222 222
 
223 223
 	/**
224
-	*	_add_actions
225
-	*	@access public
226
-	*	@return void
227
-	*/
228
-    public function get_error() {
224
+	 *	_add_actions
225
+	 *	@access public
226
+	 *	@return void
227
+	 */
228
+	public function get_error() {
229 229
 
230 230
 		if( apply_filters( 'FHEE__EE_Error__get_error__show_normal_exceptions', FALSE ) ){
231 231
 			throw $this;
@@ -255,22 +255,22 @@  discard block
 block discarded – undo
255 255
 
256 256
 
257 257
 	/**
258
-	*	has_error
259
-	*	@access public
260
-	*	@return boolean
261
-	*/
262
-    public static function has_error(){
258
+	 *	has_error
259
+	 *	@access public
260
+	 *	@return boolean
261
+	 */
262
+	public static function has_error(){
263 263
 		return self::$_error_count ? TRUE : FALSE;
264 264
 	}
265 265
 
266 266
 
267 267
 
268 268
 	/**
269
-	*	display_errors
270
-	*	@access public
271
-	*	@echo string
272
-	*/
273
-    public function display_errors(){
269
+	 *	display_errors
270
+	 *	@access public
271
+	 *	@echo string
272
+	 */
273
+	public function display_errors(){
274 274
 
275 275
 		$trace_details = '';
276 276
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 			// process trace info
343 343
 			if ( empty( $ex['trace'] )) {
344 344
 
345
-	            $trace_details .= __( 'Sorry, but no trace information was available for this exception.', 'event_espresso' );
345
+				$trace_details .= __( 'Sorry, but no trace information was available for this exception.', 'event_espresso' );
346 346
 
347 347
 			} else {
348 348
 
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 					$function_dsply = ! empty( $function ) ? $function : '&nbsp;';
395 395
 					$args_dsply = ! empty( $args ) ? '( ' . $args . ' )' : '';
396 396
 
397
-		              $trace_details .= '
397
+					  $trace_details .= '
398 398
 					<tr>
399 399
 						<td align="right" class="' . $zebra . '">' . $nmbr_dsply . '</td>
400 400
 						<td align="right" class="' . $zebra . '">' . $line_dsply . '</td>
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
 				}
408 408
 
409
-	            $trace_details .= '
409
+				$trace_details .= '
410 410
 			 </table>
411 411
 			</div>';
412 412
 
@@ -486,12 +486,12 @@  discard block
 block discarded – undo
486 486
 
487 487
 
488 488
 	/**
489
-	*	generate string from exception trace args
490
-	*
491
-	*	@access private
492
-	*	@ param array $arguments
493
-	*	@ return string
494
-	*/
489
+	 *	generate string from exception trace args
490
+	 *
491
+	 *	@access private
492
+	 *	@ param array $arguments
493
+	 *	@ return string
494
+	 */
495 495
 	private function _convert_args_to_string ( $arguments = array(), $array = FALSE ) {
496 496
 
497 497
 		$arg_string = '';
@@ -535,15 +535,15 @@  discard block
 block discarded – undo
535 535
 
536 536
 
537 537
 	/**
538
-	* 	add error message
539
-	*
540
-	*	@access public
541
-	* 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
542
-	* 	@param		string		$file		the file that the error occurred in - just use __FILE__
543
-	* 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
544
-	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
545
-	* 	@return 		void
546
-	*/
538
+	 * 	add error message
539
+	 *
540
+	 *	@access public
541
+	 * 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
542
+	 * 	@param		string		$file		the file that the error occurred in - just use __FILE__
543
+	 * 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
544
+	 * 	@param		string		$line	the line number where the error occurred - just use __LINE__
545
+	 * 	@return 		void
546
+	 */
547 547
 	public static function add_error( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
548 548
 		self::_add_notice ( 'errors', $msg, $file, $func, $line );
549 549
 		self::$_error_count++;
@@ -554,15 +554,15 @@  discard block
 block discarded – undo
554 554
 
555 555
 
556 556
 	/**
557
-	* 	add success message
558
-	*
559
-	*	@access public
560
-	* 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
561
-	* 	@param		string		$file		the file that the error occurred in - just use __FILE__
562
-	* 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
563
-	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
564
-	* 	@return 		void
565
-	*/
557
+	 * 	add success message
558
+	 *
559
+	 *	@access public
560
+	 * 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
561
+	 * 	@param		string		$file		the file that the error occurred in - just use __FILE__
562
+	 * 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
563
+	 * 	@param		string		$line	the line number where the error occurred - just use __LINE__
564
+	 * 	@return 		void
565
+	 */
566 566
 	public static function add_success( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
567 567
 		self::_add_notice ( 'success', $msg, $file, $func, $line );
568 568
 	}
@@ -572,15 +572,15 @@  discard block
 block discarded – undo
572 572
 
573 573
 
574 574
 	/**
575
-	* 	add attention message
576
-	*
577
-	*	@access public
578
-	* 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
579
-	* 	@param		string		$file		the file that the error occurred in - just use __FILE__
580
-	* 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
581
-	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
582
-	* 	@return 		void
583
-	*/
575
+	 * 	add attention message
576
+	 *
577
+	 *	@access public
578
+	 * 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
579
+	 * 	@param		string		$file		the file that the error occurred in - just use __FILE__
580
+	 * 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
581
+	 * 	@param		string		$line	the line number where the error occurred - just use __LINE__
582
+	 * 	@return 		void
583
+	 */
584 584
 	public static function add_attention( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
585 585
 		self::_add_notice ( 'attention', $msg, $file, $func, $line );
586 586
 	}
@@ -590,16 +590,16 @@  discard block
 block discarded – undo
590 590
 
591 591
 
592 592
 	/**
593
-	* 	add success message
594
-	*
595
-	*	@access public
596
-	* 	@param		string		$type	whether the message is for a success or error notification
597
-	* 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
598
-	* 	@param		string		$file		the file that the error occurred in - just use __FILE__
599
-	* 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
600
-	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
601
-	* 	@return 		void
602
-	*/
593
+	 * 	add success message
594
+	 *
595
+	 *	@access public
596
+	 * 	@param		string		$type	whether the message is for a success or error notification
597
+	 * 	@param		string		$msg	the message to display to users or developers - adding a double pipe || (OR) creates separate messages for user || dev
598
+	 * 	@param		string		$file		the file that the error occurred in - just use __FILE__
599
+	 * 	@param		string		$func	the function/method that the error occurred in - just use __FUNCTION__
600
+	 * 	@param		string		$line	the line number where the error occurred - just use __LINE__
601
+	 * 	@return 		void
602
+	 */
603 603
 	private static function _add_notice( $type = 'success', $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
604 604
 		if ( empty( $msg )) {
605 605
 			EE_Error::doing_it_wrong(
@@ -643,11 +643,11 @@  discard block
 block discarded – undo
643 643
 
644 644
 
645 645
 	/**
646
-	* 	in some case it may be necessary to overwrite the existing success messages
647
-	*
648
-	*	@access public
649
-	* 	@return 		void
650
-	*/
646
+	 * 	in some case it may be necessary to overwrite the existing success messages
647
+	 *
648
+	 *	@access public
649
+	 * 	@return 		void
650
+	 */
651 651
 	public static function overwrite_success() {
652 652
 		self::$_espresso_notices['success'] = FALSE;
653 653
 	}
@@ -657,11 +657,11 @@  discard block
 block discarded – undo
657 657
 
658 658
 
659 659
 	/**
660
-	* 	in some case it may be necessary to overwrite the existing attention messages
661
-	*
662
-	*	@access public
663
-	* 	@return 		void
664
-	*/
660
+	 * 	in some case it may be necessary to overwrite the existing attention messages
661
+	 *
662
+	 *	@access public
663
+	 * 	@return 		void
664
+	 */
665 665
 	public static function overwrite_attention() {
666 666
 		self::$_espresso_notices['attention'] = FALSE;
667 667
 	}
@@ -671,11 +671,11 @@  discard block
 block discarded – undo
671 671
 
672 672
 
673 673
 	/**
674
-	* 	in some case it may be necessary to overwrite the existing error messages
675
-	*
676
-	*	@access public
677
-	* 	@return 		void
678
-	*/
674
+	 * 	in some case it may be necessary to overwrite the existing error messages
675
+	 *
676
+	 *	@access public
677
+	 * 	@return 		void
678
+	 */
679 679
 	public static function overwrite_errors() {
680 680
 		self::$_espresso_notices['errors'] = FALSE;
681 681
 	}
@@ -683,24 +683,24 @@  discard block
 block discarded – undo
683 683
 
684 684
 
685 685
 	/**
686
-	*	reset_notices
687
-	*	@access private
688
-	*	@return void
689
-	*/
686
+	 *	reset_notices
687
+	 *	@access private
688
+	 *	@return void
689
+	 */
690 690
 	public static function reset_notices(){
691
-    	self::$_espresso_notices['success'] = FALSE;
692
-    	self::$_espresso_notices['attention'] = FALSE;
693
-    	self::$_espresso_notices['errors'] = FALSE;
694
-    }
691
+		self::$_espresso_notices['success'] = FALSE;
692
+		self::$_espresso_notices['attention'] = FALSE;
693
+		self::$_espresso_notices['errors'] = FALSE;
694
+	}
695 695
 
696 696
 
697 697
 
698 698
 	/**
699
-	*	has_errors
700
-	*	@access public
701
-	*	@return int
702
-	*/
703
-    public static function has_notices(){
699
+	 *	has_errors
700
+	 *	@access public
701
+	 *	@return int
702
+	 */
703
+	public static function has_notices(){
704 704
 		$has_notices = 0;
705 705
 		// check for success messages
706 706
 		$has_notices = self::$_espresso_notices['success'] && ! empty(  self::$_espresso_notices['success'] ) ? 3 : $has_notices;
@@ -714,14 +714,14 @@  discard block
 block discarded – undo
714 714
 
715 715
 
716 716
 	/**
717
-	* 	compile all error or success messages into one string
718
-	*
719
-	*	@access public
720
-	* 	@param		boolean		$format_output		whether or not to format the messages for display in the WP admin
721
-	* 	@param		boolean		$save_to_transient	whether or not to save notices to the db for retrieval on next request - ONLY do this just before redirecting
722
-	* 	@param		boolean		$remove_empty		whether or not to unset empty messages
723
-	* 	@return 		array
724
-	*/
717
+	 * 	compile all error or success messages into one string
718
+	 *
719
+	 *	@access public
720
+	 * 	@param		boolean		$format_output		whether or not to format the messages for display in the WP admin
721
+	 * 	@param		boolean		$save_to_transient	whether or not to save notices to the db for retrieval on next request - ONLY do this just before redirecting
722
+	 * 	@param		boolean		$remove_empty		whether or not to unset empty messages
723
+	 * 	@return 		array
724
+	 */
725 725
 	public static function get_notices( $format_output = TRUE, $save_to_transient = FALSE, $remove_empty = TRUE ) {
726 726
 		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
727 727
 
@@ -833,14 +833,14 @@  discard block
 block discarded – undo
833 833
 
834 834
 
835 835
 	/**
836
-	* 	add_persistent_admin_notice
837
-	*
838
-	*	@access 	public
839
-	* 	@param		string	$pan_name	the name, or key of the Persistent Admin Notice to be stored
840
-	* 	@param		string	$pan_message	the message to be stored persistently until dismissed
841
-	* 	@param bool $force_update allows one to enforce the reappearance of a persistent message.
842
-	* 	@return 		void
843
-	*/
836
+	 * 	add_persistent_admin_notice
837
+	 *
838
+	 *	@access 	public
839
+	 * 	@param		string	$pan_name	the name, or key of the Persistent Admin Notice to be stored
840
+	 * 	@param		string	$pan_message	the message to be stored persistently until dismissed
841
+	 * 	@param bool $force_update allows one to enforce the reappearance of a persistent message.
842
+	 * 	@return 		void
843
+	 */
844 844
 	public static function add_persistent_admin_notice( $pan_name = '', $pan_message, $force_update = FALSE ) {
845 845
 		if ( ! empty( $pan_name ) && ! empty( $pan_message )) {
846 846
 			$persistent_admin_notices = get_option( 'ee_pers_admin_notices', array() );
@@ -904,9 +904,9 @@  discard block
 block discarded – undo
904 904
 	 * 	display_persistent_admin_notices
905 905
 	 *
906 906
 	 *  	@access 	public
907
-	* 	@param		string	$pan_name	the name, or key of the Persistent Admin Notice to be stored
908
-	* 	@param		string	$pan_name	the message to be stored persistently until dismissed
909
-	* 	@param		string	$return_url	URL to go back to aftger nag notice is dismissed
907
+	 * 	@param		string	$pan_name	the name, or key of the Persistent Admin Notice to be stored
908
+	 * 	@param		string	$pan_name	the message to be stored persistently until dismissed
909
+	 * 	@param		string	$return_url	URL to go back to aftger nag notice is dismissed
910 910
 	 *  	@return 		string
911 911
 	 */
912 912
 	public static function display_persistent_admin_notices( $pan_name = '', $pan_message = '', $return_url = '' ) {
@@ -995,11 +995,11 @@  discard block
 block discarded – undo
995 995
 
996 996
 
997 997
 	/**
998
-	* 	enqueue_error_scripts
999
-	*
1000
-	*	@access public
1001
-	* 	@return 		void
1002
-	*/
998
+	 * 	enqueue_error_scripts
999
+	 *
1000
+	 *	@access public
1001
+	 * 	@return 		void
1002
+	 */
1003 1003
 	public static function enqueue_error_scripts() {
1004 1004
 		self::_print_scripts();
1005 1005
 	}
@@ -1007,15 +1007,15 @@  discard block
 block discarded – undo
1007 1007
 
1008 1008
 
1009 1009
 	/**
1010
-	*	create error code from filepath, function name,
1011
-	*	and line number where exception or error was thrown
1012
-	*
1013
-	*	@access public
1014
-	*	@ param string $file
1015
-	*	@ param string $func
1016
-	*	@ param string $line
1017
-	*	@ return string
1018
-	*/
1010
+	 *	create error code from filepath, function name,
1011
+	 *	and line number where exception or error was thrown
1012
+	 *
1013
+	 *	@access public
1014
+	 *	@ param string $file
1015
+	 *	@ param string $func
1016
+	 *	@ param string $line
1017
+	 *	@ return string
1018
+	 */
1019 1019
 	public static function generate_error_code ( $file = '', $func = '', $line = '' ) {
1020 1020
 		$file = explode( '.', basename( $file ));
1021 1021
 		$error_code = ! empty( $file[0] ) ? $file[0] : '';
@@ -1029,13 +1029,13 @@  discard block
 block discarded – undo
1029 1029
 
1030 1030
 
1031 1031
 	/**
1032
-	*	write exception details to log file
1033
-	*
1034
-	*	@access public
1035
-	*	@ param timestamp $time
1036
-	*	@ param object $ex
1037
-	*	@ return void
1038
-	*/
1032
+	 *	write exception details to log file
1033
+	 *
1034
+	 *	@access public
1035
+	 *	@ param timestamp $time
1036
+	 *	@ param object $ex
1037
+	 *	@ return void
1038
+	 */
1039 1039
 	public function write_to_error_log ( $time = FALSE, $ex = FALSE, $clear = FALSE ) {
1040 1040
 
1041 1041
 		if ( ! $ex ) {
Please login to merge, or discard this patch.
Spacing   +234 added lines, -234 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
2 2
 // if you're a dev and want to receive all errors via email add this to your wp-config.php: define( 'EE_ERROR_EMAILS', TRUE );
3
-if ( defined( 'WP_DEBUG' ) && WP_DEBUG === TRUE && defined( 'EE_ERROR_EMAILS' ) && EE_ERROR_EMAILS === TRUE ) {
4
-	set_error_handler( array( 'EE_Error', 'error_handler' ));
5
-	register_shutdown_function( array( 'EE_Error', 'fatal_error_handler' ));
3
+if (defined('WP_DEBUG') && WP_DEBUG === TRUE && defined('EE_ERROR_EMAILS') && EE_ERROR_EMAILS === TRUE) {
4
+	set_error_handler(array('EE_Error', 'error_handler'));
5
+	register_shutdown_function(array('EE_Error', 'fatal_error_handler'));
6 6
 }
7 7
 /**
8 8
  *
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 	* 	@access	private
65 65
     *	@var boolean
66 66
 	*/
67
-	private static $_espresso_notices = array( 'success' => FALSE, 'errors' => FALSE, 'attention' => FALSE );
67
+	private static $_espresso_notices = array('success' => FALSE, 'errors' => FALSE, 'attention' => FALSE);
68 68
 
69 69
 
70 70
 
@@ -75,11 +75,11 @@  discard block
 block discarded – undo
75 75
 	*	@access public
76 76
 	*	@echo string
77 77
 	*/
78
-	function __construct( $message, $code = 0, Exception $previous = NULL ) {
79
-		if ( version_compare( phpversion(), '5.3.0', '<' )) {
80
-			parent::__construct( $message, $code );
78
+	function __construct($message, $code = 0, Exception $previous = NULL) {
79
+		if (version_compare(phpversion(), '5.3.0', '<')) {
80
+			parent::__construct($message, $code);
81 81
 		} else {
82
-			parent::__construct( $message, $code, $previous );
82
+			parent::__construct($message, $code, $previous);
83 83
 		}
84 84
 	}
85 85
 
@@ -94,10 +94,10 @@  discard block
 block discarded – undo
94 94
 	 * @param $line
95 95
 	 * @return void
96 96
 	 */
97
-	public static function error_handler( $code, $message, $file, $line ) {
98
-		$type = EE_Error::error_type( $code );
97
+	public static function error_handler($code, $message, $file, $line) {
98
+		$type = EE_Error::error_type($code);
99 99
 		$site = site_url();
100
-		switch ( $site ) {
100
+		switch ($site) {
101 101
 			case 'http://ee4.eventespresso.com/' :
102 102
 			case 'http://ee4decaf.eventespresso.com/' :
103 103
 			case 'http://ee4hf.eventespresso.com/' :
@@ -110,16 +110,16 @@  discard block
 block discarded – undo
110 110
 				$to = '[email protected]';
111 111
 				break;
112 112
 			default :
113
-				$to = get_option( 'admin_email' );
113
+				$to = get_option('admin_email');
114 114
 		}
115
-		$subject = $type . ' ' . $message . ' in ' . EVENT_ESPRESSO_VERSION . ' on ' . site_url();
116
-		$msg = EE_Error::_format_error( $type, $message, $file, $line );
117
-		if ( function_exists( 'wp_mail' )) {
118
-			add_filter( 'wp_mail_content_type', array( 'EE_Error', 'set_content_type' ));
119
-			wp_mail( $to, $subject, $msg );
115
+		$subject = $type.' '.$message.' in '.EVENT_ESPRESSO_VERSION.' on '.site_url();
116
+		$msg = EE_Error::_format_error($type, $message, $file, $line);
117
+		if (function_exists('wp_mail')) {
118
+			add_filter('wp_mail_content_type', array('EE_Error', 'set_content_type'));
119
+			wp_mail($to, $subject, $msg);
120 120
 		}
121 121
 		echo '<div id="message" class="espresso-notices error"><p>';
122
-		echo $type . ': ' . $message . '<br />' . $file . ' line ' . $line;
122
+		echo $type.': '.$message.'<br />'.$file.' line '.$line;
123 123
 		echo '<br /></p></div>';
124 124
 	}
125 125
 
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
 	 * @param $code
133 133
 	 * @return string
134 134
 	 */
135
-	public static function error_type( $code ) {
136
-		switch( $code ) {
135
+	public static function error_type($code) {
136
+		switch ($code) {
137 137
 			case E_ERROR: // 1 //
138 138
 			return 'E_ERROR';
139 139
 			case E_WARNING: // 2 //
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 	*/
180 180
 	public static function fatal_error_handler() {
181 181
 		$last_error = error_get_last();
182
-		if ( $last_error['type'] === E_ERROR ) {
183
-			EE_Error::error_handler( E_ERROR, $last_error['message'], $last_error['file'], $last_error['line'] );
182
+		if ($last_error['type'] === E_ERROR) {
183
+			EE_Error::error_handler(E_ERROR, $last_error['message'], $last_error['file'], $last_error['line']);
184 184
 		}
185 185
 	}
186 186
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * @param $line
196 196
 	 * @return string
197 197
 	 */
198
-	private static function _format_error( $code, $message, $file, $line ) {
198
+	private static function _format_error($code, $message, $file, $line) {
199 199
 		$html  = "<table cellpadding='5'><thead bgcolor='#f8f8f8'><th>Item</th><th align='left'>Details</th></thead><tbody>";
200 200
 		$html .= "<tr valign='top'><td><b>Code</b></td><td>$code</td></tr>";
201 201
 		$html .= "<tr valign='top'><td><b>Error</b></td><td>$message</td></tr>";
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 	 * @param $content_type
214 214
 	 * @return string
215 215
 	 */
216
-	public static function set_content_type( $content_type ) {
216
+	public static function set_content_type($content_type) {
217 217
 		return 'text/html';
218 218
 	}
219 219
 
@@ -227,24 +227,24 @@  discard block
 block discarded – undo
227 227
 	*/
228 228
     public function get_error() {
229 229
 
230
-		if( apply_filters( 'FHEE__EE_Error__get_error__show_normal_exceptions', FALSE ) ){
230
+		if (apply_filters('FHEE__EE_Error__get_error__show_normal_exceptions', FALSE)) {
231 231
 			throw $this;
232 232
 		}
233 233
 		// get separate user and developer messages if they exist
234
-		$msg = explode( '||', $this->getMessage() );
234
+		$msg = explode('||', $this->getMessage());
235 235
 		$user_msg = $msg[0];
236
-		$dev_msg = isset( $msg[1] ) ? $msg[1] : $msg[0];
236
+		$dev_msg = isset($msg[1]) ? $msg[1] : $msg[0];
237 237
 		$msg = WP_DEBUG ? $dev_msg : $user_msg;
238 238
 
239 239
 		// add details to _all_exceptions array
240 240
 		$x_time = time();
241
-		self::$_all_exceptions[ $x_time ]['name'] 	= get_class( $this );
242
-		self::$_all_exceptions[ $x_time ]['file'] 		= $this->getFile();
243
-		self::$_all_exceptions[ $x_time ]['line'] 		= $this->getLine();
244
-		self::$_all_exceptions[ $x_time ]['msg'] 	= $msg;
245
-		self::$_all_exceptions[ $x_time ]['code'] 	= $this->getCode();
246
-		self::$_all_exceptions[ $x_time ]['trace'] 	= $this->getTrace();
247
-		self::$_all_exceptions[ $x_time ]['string'] 	= $this->getTraceAsString();
241
+		self::$_all_exceptions[$x_time]['name'] = get_class($this);
242
+		self::$_all_exceptions[$x_time]['file'] 		= $this->getFile();
243
+		self::$_all_exceptions[$x_time]['line'] 		= $this->getLine();
244
+		self::$_all_exceptions[$x_time]['msg'] = $msg;
245
+		self::$_all_exceptions[$x_time]['code'] = $this->getCode();
246
+		self::$_all_exceptions[$x_time]['trace'] 	= $this->getTrace();
247
+		self::$_all_exceptions[$x_time]['string'] = $this->getTraceAsString();
248 248
 		self::$_error_count++;
249 249
 
250 250
 		//add_action( 'shutdown', array( $this, 'display_errors' ));
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 	*	@access public
260 260
 	*	@return boolean
261 261
 	*/
262
-    public static function has_error(){
262
+    public static function has_error() {
263 263
 		return self::$_error_count ? TRUE : FALSE;
264 264
 	}
265 265
 
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 	*	@access public
271 271
 	*	@echo string
272 272
 	*/
273
-    public function display_errors(){
273
+    public function display_errors() {
274 274
 
275 275
 		$trace_details = '';
276 276
 
@@ -331,18 +331,18 @@  discard block
 block discarded – undo
331 331
 </style>
332 332
 <div id="ee-error-message" class="error">';
333 333
 
334
-		if ( ! WP_DEBUG ) {
334
+		if ( ! WP_DEBUG) {
335 335
 			$output .= '
336 336
 	<p>';
337 337
 		}
338 338
 
339 339
 		// cycle thru errors
340
-		foreach ( self::$_all_exceptions as $time => $ex ) {
340
+		foreach (self::$_all_exceptions as $time => $ex) {
341 341
 
342 342
 			// process trace info
343
-			if ( empty( $ex['trace'] )) {
343
+			if (empty($ex['trace'])) {
344 344
 
345
-	            $trace_details .= __( 'Sorry, but no trace information was available for this exception.', 'event_espresso' );
345
+	            $trace_details .= __('Sorry, but no trace information was available for this exception.', 'event_espresso');
346 346
 
347 347
 			} else {
348 348
 
@@ -357,50 +357,50 @@  discard block
 block discarded – undo
357 357
 					<th scope="col" align="left">Method( arguments )</th>
358 358
 				</tr>';
359 359
 
360
-				$last_on_stack = count( $ex['trace'] ) - 1;
360
+				$last_on_stack = count($ex['trace']) - 1;
361 361
 				// reverse array so that stack is in proper chronological order
362
-				$sorted_trace = array_reverse( $ex['trace'] );
362
+				$sorted_trace = array_reverse($ex['trace']);
363 363
 
364
-				foreach ( $sorted_trace as $nmbr => $trace ) {
364
+				foreach ($sorted_trace as $nmbr => $trace) {
365 365
 
366
-					$file = isset( $trace['file'] ) ? $trace['file'] : '' ;
367
-					$class = isset( $trace['class'] ) ? $trace['class'] : '';
368
-					$type = isset( $trace['type'] ) ? $trace['type'] : '';
369
-					$function = isset( $trace['function'] ) ? $trace['function'] : '';
370
-					$args = isset( $trace['args'] ) ? $this->_convert_args_to_string( $trace['args'] ) : '';
371
-					$line = isset( $trace['line'] ) ? $trace['line'] : '';
366
+					$file = isset($trace['file']) ? $trace['file'] : '';
367
+					$class = isset($trace['class']) ? $trace['class'] : '';
368
+					$type = isset($trace['type']) ? $trace['type'] : '';
369
+					$function = isset($trace['function']) ? $trace['function'] : '';
370
+					$args = isset($trace['args']) ? $this->_convert_args_to_string($trace['args']) : '';
371
+					$line = isset($trace['line']) ? $trace['line'] : '';
372 372
 					$zebra = $nmbr % 2 ? ' odd' : '';
373 373
 
374
-					if ( empty( $file ) && ! empty( $class )) {
375
-						$a = new ReflectionClass( $class );
374
+					if (empty($file) && ! empty($class)) {
375
+						$a = new ReflectionClass($class);
376 376
 						$file = $a->getFileName();
377
-						if ( empty( $line ) && ! empty( $function )) {
378
-							$b = new ReflectionMethod( $class, $function );
377
+						if (empty($line) && ! empty($function)) {
378
+							$b = new ReflectionMethod($class, $function);
379 379
 							$line = $b->getStartLine();
380 380
 						}
381 381
 					}
382 382
 
383
-					if ( $nmbr == $last_on_stack ) {
383
+					if ($nmbr == $last_on_stack) {
384 384
 						$file = $ex['file'] != '' ? $ex['file'] : $file;
385 385
 						$line = $ex['line'] != '' ? $ex['line'] : $line;
386
-						$error_code = self::generate_error_code ( $file, $trace['function'], $line );
386
+						$error_code = self::generate_error_code($file, $trace['function'], $line);
387 387
 					}
388 388
 
389
-					$nmbr_dsply = ! empty( $nmbr ) ? $nmbr : '&nbsp;';
390
-					$line_dsply = ! empty( $line ) ? $line : '&nbsp;';
391
-					$file_dsply = ! empty( $file ) ? $file : '&nbsp;';
392
-					$class_dsply = ! empty( $class ) ? $class : '&nbsp;';
393
-					$type_dsply = ! empty( $type ) ? $type : '&nbsp;';
394
-					$function_dsply = ! empty( $function ) ? $function : '&nbsp;';
395
-					$args_dsply = ! empty( $args ) ? '( ' . $args . ' )' : '';
389
+					$nmbr_dsply = ! empty($nmbr) ? $nmbr : '&nbsp;';
390
+					$line_dsply = ! empty($line) ? $line : '&nbsp;';
391
+					$file_dsply = ! empty($file) ? $file : '&nbsp;';
392
+					$class_dsply = ! empty($class) ? $class : '&nbsp;';
393
+					$type_dsply = ! empty($type) ? $type : '&nbsp;';
394
+					$function_dsply = ! empty($function) ? $function : '&nbsp;';
395
+					$args_dsply = ! empty($args) ? '( '.$args.' )' : '';
396 396
 
397 397
 		              $trace_details .= '
398 398
 					<tr>
399
-						<td align="right" class="' . $zebra . '">' . $nmbr_dsply . '</td>
400
-						<td align="right" class="' . $zebra . '">' . $line_dsply . '</td>
401
-						<td align="left" class="' . $zebra . '">' . $file_dsply . '</td>
402
-						<td align="left" class="' . $zebra . '">' . $class_dsply . '</td>
403
-						<td align="left" class="' . $zebra . '">' . $type_dsply . $function_dsply . $args_dsply . '</td>
399
+						<td align="right" class="' . $zebra.'">'.$nmbr_dsply.'</td>
400
+						<td align="right" class="' . $zebra.'">'.$line_dsply.'</td>
401
+						<td align="left" class="' . $zebra.'">'.$file_dsply.'</td>
402
+						<td align="left" class="' . $zebra.'">'.$class_dsply.'</td>
403
+						<td align="left" class="' . $zebra.'">'.$type_dsply.$function_dsply.$args_dsply.'</td>
404 404
 					</tr>';
405 405
 
406 406
 
@@ -415,9 +415,9 @@  discard block
 block discarded – undo
415 415
 			$ex['code'] = $ex['code'] ? $ex['code'] : $error_code;
416 416
 
417 417
 			// add generic non-identifying messages for non-privileged uesrs
418
-			if ( ! WP_DEBUG ) {
418
+			if ( ! WP_DEBUG) {
419 419
 
420
-				$output .= '<span class="ee-error-user-msg-spn">' . trim( $ex['msg'] )  . '</span> &nbsp; <sup>' . $ex['code'] . '</sup><br />';
420
+				$output .= '<span class="ee-error-user-msg-spn">'.trim($ex['msg']).'</span> &nbsp; <sup>'.$ex['code'].'</sup><br />';
421 421
 
422 422
 			} else {
423 423
 
@@ -425,24 +425,24 @@  discard block
 block discarded – undo
425 425
 				$output .= '
426 426
 		<div class="ee-error-dev-msg-dv">
427 427
 			<p class="ee-error-dev-msg-pg">
428
-				<strong class="ee-error-dev-msg-str">An ' . $ex['name'] . ' exception was thrown!</strong>  &nbsp; <span>code: ' . $ex['code'] . '</span><br />
429
-				<span class="big-text">"' . trim( $ex['msg'] ) . '"</span><br/>
430
-				<a id="display-ee-error-trace-' . self::$_error_count . $time . '" class="display-ee-error-trace-lnk small-text" rel="ee-error-trace-' . self::$_error_count . $time . '">
431
-					' . __( 'click to view backtrace and class/method details', 'event_espresso' ) . '
428
+				<strong class="ee-error-dev-msg-str">An ' . $ex['name'].' exception was thrown!</strong>  &nbsp; <span>code: '.$ex['code'].'</span><br />
429
+				<span class="big-text">"' . trim($ex['msg']).'"</span><br/>
430
+				<a id="display-ee-error-trace-' . self::$_error_count.$time.'" class="display-ee-error-trace-lnk small-text" rel="ee-error-trace-'.self::$_error_count.$time.'">
431
+					' . __('click to view backtrace and class/method details', 'event_espresso').'
432 432
 				</a><br />
433 433
 				<span class="small-text lt-grey-text">'.$ex['file'].' &nbsp; ( line no: '.$ex['line'].' )</span>
434 434
 			</p>
435
-			<div id="ee-error-trace-' . self::$_error_count . $time . '-dv" class="ee-error-trace-dv" style="display: none;">
435
+			<div id="ee-error-trace-' . self::$_error_count.$time.'-dv" class="ee-error-trace-dv" style="display: none;">
436 436
 				' . $trace_details;
437 437
 
438
-				if ( ! empty( $class )) {
438
+				if ( ! empty($class)) {
439 439
 					$output .= '
440 440
 				<div style="padding:3px; margin:0 0 1em; border:1px solid #666; background:#fff; border-radius:3px;">
441 441
 					<div style="padding:1em 2em; border:1px solid #666; background:#f9f9f9;">
442 442
 						<h3>Class Details</h3>';
443
-						$a = new ReflectionClass( $class );
443
+						$a = new ReflectionClass($class);
444 444
 						$output .= '
445
-						<pre>' . $a . '</pre>
445
+						<pre>' . $a.'</pre>
446 446
 					</div>
447 447
 				</div>';
448 448
 				}
@@ -454,14 +454,14 @@  discard block
 block discarded – undo
454 454
 
455 455
 			}
456 456
 
457
-			$this->write_to_error_log( $time, $ex );
457
+			$this->write_to_error_log($time, $ex);
458 458
 
459 459
 		}
460 460
 
461 461
 		// remove last linebreak
462
-		$output = substr( $output, 0, ( count( $output ) - 7 ));
462
+		$output = substr($output, 0, (count($output) - 7));
463 463
 
464
-		if ( ! WP_DEBUG ) {
464
+		if ( ! WP_DEBUG) {
465 465
 			$output .= '
466 466
 	</p>';
467 467
 		}
@@ -469,10 +469,10 @@  discard block
 block discarded – undo
469 469
 		$output .= '
470 470
 </div>';
471 471
 
472
-		$output .= self::_print_scripts( TRUE );
472
+		$output .= self::_print_scripts(TRUE);
473 473
 
474
-		if ( defined( 'DOING_AJAX' )) {
475
-			echo json_encode( array( 'error' => $output ));
474
+		if (defined('DOING_AJAX')) {
475
+			echo json_encode(array('error' => $output));
476 476
 			exit();
477 477
 		}
478 478
 
@@ -492,29 +492,29 @@  discard block
 block discarded – undo
492 492
 	*	@ param array $arguments
493 493
 	*	@ return string
494 494
 	*/
495
-	private function _convert_args_to_string ( $arguments = array(), $array = FALSE ) {
495
+	private function _convert_args_to_string($arguments = array(), $array = FALSE) {
496 496
 
497 497
 		$arg_string = '';
498
-		if ( ! empty( $arguments )) {
498
+		if ( ! empty($arguments)) {
499 499
 
500 500
 			$args = array();
501 501
 
502
-			foreach ( $arguments as $arg ) {
502
+			foreach ($arguments as $arg) {
503 503
 
504
-				if ( ! empty( $arg )) {
504
+				if ( ! empty($arg)) {
505 505
 
506
-					if ( is_string( $arg )) {
507
-						$args[] = " '" . $arg . "'";
508
-					} elseif ( is_array( $arg )) {
509
-						$args[] = 'ARRAY(' . $this->_convert_args_to_string( $arg, TRUE );
510
-					} elseif ( is_null( $arg )) {
506
+					if (is_string($arg)) {
507
+						$args[] = " '".$arg."'";
508
+					} elseif (is_array($arg)) {
509
+						$args[] = 'ARRAY('.$this->_convert_args_to_string($arg, TRUE);
510
+					} elseif (is_null($arg)) {
511 511
 						$args[] = ' NULL';
512
-					} elseif ( is_bool( $arg )) {
513
-						$args[] = ( $arg ) ? ' TRUE' : ' FALSE';
514
-					} elseif ( is_object( $arg )) {
515
-						$args[] = ' OBJECT ' . get_class( $arg );
516
-					} elseif ( is_resource( $arg )) {
517
-						$args[] = get_resource_type( $arg );
512
+					} elseif (is_bool($arg)) {
513
+						$args[] = ($arg) ? ' TRUE' : ' FALSE';
514
+					} elseif (is_object($arg)) {
515
+						$args[] = ' OBJECT '.get_class($arg);
516
+					} elseif (is_resource($arg)) {
517
+						$args[] = get_resource_type($arg);
518 518
 					} else {
519 519
 						$args[] = $arg;
520 520
 					}
@@ -522,9 +522,9 @@  discard block
 block discarded – undo
522 522
 				}
523 523
 
524 524
 			}
525
-			$arg_string = implode( ', ', $args );
525
+			$arg_string = implode(', ', $args);
526 526
 		}
527
-		if ( $array ) {
527
+		if ($array) {
528 528
 			$arg_string .= ' )';
529 529
 		}
530 530
 		return $arg_string;
@@ -544,8 +544,8 @@  discard block
 block discarded – undo
544 544
 	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
545 545
 	* 	@return 		void
546 546
 	*/
547
-	public static function add_error( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
548
-		self::_add_notice ( 'errors', $msg, $file, $func, $line );
547
+	public static function add_error($msg = NULL, $file = NULL, $func = NULL, $line = NULL) {
548
+		self::_add_notice('errors', $msg, $file, $func, $line);
549 549
 	}
550 550
 
551 551
 
@@ -562,8 +562,8 @@  discard block
 block discarded – undo
562 562
 	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
563 563
 	* 	@return 		void
564 564
 	*/
565
-	public static function add_success( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
566
-		self::_add_notice ( 'success', $msg, $file, $func, $line );
565
+	public static function add_success($msg = NULL, $file = NULL, $func = NULL, $line = NULL) {
566
+		self::_add_notice('success', $msg, $file, $func, $line);
567 567
 	}
568 568
 
569 569
 
@@ -580,8 +580,8 @@  discard block
 block discarded – undo
580 580
 	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
581 581
 	* 	@return 		void
582 582
 	*/
583
-	public static function add_attention( $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
584
-		self::_add_notice ( 'attention', $msg, $file, $func, $line );
583
+	public static function add_attention($msg = NULL, $file = NULL, $func = NULL, $line = NULL) {
584
+		self::_add_notice('attention', $msg, $file, $func, $line);
585 585
 	}
586 586
 
587 587
 
@@ -599,12 +599,12 @@  discard block
 block discarded – undo
599 599
 	* 	@param		string		$line	the line number where the error occurred - just use __LINE__
600 600
 	* 	@return 		void
601 601
 	*/
602
-	private static function _add_notice( $type = 'success', $msg = NULL, $file = NULL, $func = NULL, $line = NULL ) {
603
-		if ( empty( $msg )) {
602
+	private static function _add_notice($type = 'success', $msg = NULL, $file = NULL, $func = NULL, $line = NULL) {
603
+		if (empty($msg)) {
604 604
 			EE_Error::doing_it_wrong(
605
-				'EE_Error::add_' . $type . '()',
605
+				'EE_Error::add_'.$type.'()',
606 606
 				sprintf(
607
-					__( 'Notifications are not much use without a message! Please add a message to the EE_Error::add_%s() call made in %s on line %d', 'event_espresso' ),
607
+					__('Notifications are not much use without a message! Please add a message to the EE_Error::add_%s() call made in %s on line %d', 'event_espresso'),
608 608
 					$type,
609 609
 					$file,
610 610
 					$line
@@ -612,26 +612,26 @@  discard block
 block discarded – undo
612 612
 				EVENT_ESPRESSO_VERSION
613 613
 			);
614 614
 		}
615
-		if ( $type == 'errors' && ( empty( $file ) || empty( $func ) || empty( $line ))) {
615
+		if ($type == 'errors' && (empty($file) || empty($func) || empty($line))) {
616 616
 			EE_Error::doing_it_wrong(
617 617
 				'EE_Error::add_error()',
618
-				__('You need to provide the file name, function name, and line number that the error occurred on in order to better assist with debugging.', 'event_espresso' ),
618
+				__('You need to provide the file name, function name, and line number that the error occurred on in order to better assist with debugging.', 'event_espresso'),
619 619
 				EVENT_ESPRESSO_VERSION
620 620
 			);
621 621
 		}
622 622
 		// get separate user and developer messages if they exist
623
-		$msg = explode( '||', $msg );
623
+		$msg = explode('||', $msg);
624 624
 		$user_msg = $msg[0];
625
-		$dev_msg = isset( $msg[1] ) ? $msg[1] : $msg[0];
625
+		$dev_msg = isset($msg[1]) ? $msg[1] : $msg[0];
626 626
 		$msg = WP_DEBUG ? $dev_msg : $user_msg;
627 627
 		// add notice if message exists
628
-		if ( ! empty( $msg )) {
628
+		if ( ! empty($msg)) {
629 629
 			// get error code only on error
630
-			$error_code = $type == 'errors' ? EE_Error::generate_error_code ( $file, $func, $line ) : '';
631
-			$error_code =  ! empty( $error_code ) ? '<br/><span class="tiny-text">' . $error_code . '</span>' : '';
630
+			$error_code = $type == 'errors' ? EE_Error::generate_error_code($file, $func, $line) : '';
631
+			$error_code = ! empty($error_code) ? '<br/><span class="tiny-text">'.$error_code.'</span>' : '';
632 632
 			// add notice
633
-			self::$_espresso_notices[ $type ][] = $msg . $error_code;
634
-			add_action( 'wp_footer', array( 'EE_Error', 'enqueue_error_scripts' ), 1 );
633
+			self::$_espresso_notices[$type][] = $msg.$error_code;
634
+			add_action('wp_footer', array('EE_Error', 'enqueue_error_scripts'), 1);
635 635
 		}
636 636
 
637 637
 	}
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 	*	@access private
686 686
 	*	@return void
687 687
 	*/
688
-	public static function reset_notices(){
688
+	public static function reset_notices() {
689 689
     	self::$_espresso_notices['success'] = FALSE;
690 690
     	self::$_espresso_notices['attention'] = FALSE;
691 691
     	self::$_espresso_notices['errors'] = FALSE;
@@ -698,14 +698,14 @@  discard block
 block discarded – undo
698 698
 	*	@access public
699 699
 	*	@return int
700 700
 	*/
701
-    public static function has_notices(){
701
+    public static function has_notices() {
702 702
 		$has_notices = 0;
703 703
 		// check for success messages
704
-		$has_notices = self::$_espresso_notices['success'] && ! empty(  self::$_espresso_notices['success'] ) ? 3 : $has_notices;
704
+		$has_notices = self::$_espresso_notices['success'] && ! empty(self::$_espresso_notices['success']) ? 3 : $has_notices;
705 705
 		// check for attention messages
706
-		$has_notices = self::$_espresso_notices['attention'] && ! empty(  self::$_espresso_notices['attention'] ) ? 2 : $has_notices;
706
+		$has_notices = self::$_espresso_notices['attention'] && ! empty(self::$_espresso_notices['attention']) ? 2 : $has_notices;
707 707
 		// check for error messages
708
-		$has_notices = self::$_espresso_notices['errors'] && ! empty(  self::$_espresso_notices['errors'] ) ? 1 : $has_notices;
708
+		$has_notices = self::$_espresso_notices['errors'] && ! empty(self::$_espresso_notices['errors']) ? 1 : $has_notices;
709 709
 		return $has_notices;
710 710
 	}
711 711
 
@@ -720,8 +720,8 @@  discard block
 block discarded – undo
720 720
 	* 	@param		boolean		$remove_empty		whether or not to unset empty messages
721 721
 	* 	@return 		array
722 722
 	*/
723
-	public static function get_notices( $format_output = TRUE, $save_to_transient = FALSE, $remove_empty = TRUE ) {
724
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
723
+	public static function get_notices($format_output = TRUE, $save_to_transient = FALSE, $remove_empty = TRUE) {
724
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
725 725
 
726 726
 		$success_messages = '';
727 727
 		$attention_messages = '';
@@ -731,44 +731,44 @@  discard block
 block discarded – undo
731 731
 		// EEH_Debug_Tools::printr( self::$_espresso_notices, 'espresso_notices  <br /><span style="font-size:10px;font-weight:normal;">' . __FILE__ . '<br />line no: ' . __LINE__ . '</span>', 'auto' );
732 732
 
733 733
 		// either save notices to the db
734
-		if ( $save_to_transient ) {
735
-			update_option( 'ee_notices', self::$_espresso_notices );
734
+		if ($save_to_transient) {
735
+			update_option('ee_notices', self::$_espresso_notices);
736 736
 			return;
737 737
 		}
738 738
 		// grab any notices that have been previously saved
739
-		if ( $notices = get_option( 'ee_notices', FALSE )) {
740
-			foreach ( $notices as $type => $notice ) {
741
-				if ( is_array( $notice ) && ! empty( $notice )) {
739
+		if ($notices = get_option('ee_notices', FALSE)) {
740
+			foreach ($notices as $type => $notice) {
741
+				if (is_array($notice) && ! empty($notice)) {
742 742
 					// make sure that existsing notice type is an array
743
-					self::$_espresso_notices[ $type ] =  is_array( self::$_espresso_notices[ $type ] ) && ! empty( self::$_espresso_notices[ $type ] ) ? self::$_espresso_notices[ $type ] : array();
743
+					self::$_espresso_notices[$type] = is_array(self::$_espresso_notices[$type]) && ! empty(self::$_espresso_notices[$type]) ? self::$_espresso_notices[$type] : array();
744 744
 					// merge stored notices with any newly created ones
745
-					self::$_espresso_notices[ $type ] = array_merge( self::$_espresso_notices[ $type ], $notice );
745
+					self::$_espresso_notices[$type] = array_merge(self::$_espresso_notices[$type], $notice);
746 746
 					$print_scripts = TRUE;
747 747
 				}
748 748
 			}
749 749
 			// now clear any stored notices
750
-			update_option( 'ee_notices', FALSE );
750
+			update_option('ee_notices', FALSE);
751 751
 		}
752 752
 
753 753
 		// check for success messages
754
-		if ( self::$_espresso_notices['success'] && ! empty(  self::$_espresso_notices['success'] )) {
754
+		if (self::$_espresso_notices['success'] && ! empty(self::$_espresso_notices['success'])) {
755 755
 			// combine messages
756
-			$success_messages .= implode( self::$_espresso_notices['success'], '<br />' );
756
+			$success_messages .= implode(self::$_espresso_notices['success'], '<br />');
757 757
 			$print_scripts = TRUE;
758 758
 		}
759 759
 
760 760
 		// check for attention messages
761
-		if ( self::$_espresso_notices['attention'] && ! empty(  self::$_espresso_notices['attention'] ) ) {
761
+		if (self::$_espresso_notices['attention'] && ! empty(self::$_espresso_notices['attention'])) {
762 762
 			// combine messages
763
-			$attention_messages .= implode( self::$_espresso_notices['attention'], '<br />' );
763
+			$attention_messages .= implode(self::$_espresso_notices['attention'], '<br />');
764 764
 			$print_scripts = TRUE;
765 765
 		}
766 766
 
767 767
 		// check for error messages
768
-		if ( self::$_espresso_notices['errors'] && ! empty(  self::$_espresso_notices['errors'] ) ) {
769
-			$error_messages .= count( self::$_espresso_notices['errors'] ) > 1 ? __( 'The following errors have occurred:<br />', 'event_espresso' ) : __( 'An error has occurred:<br />', 'event_espresso' );
768
+		if (self::$_espresso_notices['errors'] && ! empty(self::$_espresso_notices['errors'])) {
769
+			$error_messages .= count(self::$_espresso_notices['errors']) > 1 ? __('The following errors have occurred:<br />', 'event_espresso') : __('An error has occurred:<br />', 'event_espresso');
770 770
 			// combine messages
771
-			$error_messages .= implode( self::$_espresso_notices['errors'], '<br />' );
771
+			$error_messages .= implode(self::$_espresso_notices['errors'], '<br />');
772 772
 			$print_scripts = TRUE;
773 773
 		}
774 774
 
@@ -782,21 +782,21 @@  discard block
 block discarded – undo
782 782
 				$css_id = is_admin() ? 'message' : 'espresso-notices-success';
783 783
 				$css_class = is_admin() ? 'updated fade' : 'success fade-away';
784 784
 				//showMessage( $success_messages );
785
-				$notices .= '<div id="' . $css_id . '" class="espresso-notices ' . $css_class . '" style="display:none;"><p>' . $success_messages . '</p>' . $close . '</div>';
785
+				$notices .= '<div id="'.$css_id.'" class="espresso-notices '.$css_class.'" style="display:none;"><p>'.$success_messages.'</p>'.$close.'</div>';
786 786
 			}
787 787
 
788 788
 			if ($attention_messages != '') {
789 789
 				$css_id = is_admin() ? 'message' : 'espresso-notices-attention';
790 790
 				$css_class = is_admin() ? 'updated ee-notices-attention' : 'attention fade-away';
791 791
 				//showMessage( $error_messages, TRUE );
792
-				$notices .= '<div id="' . $css_id . '" class="espresso-notices ' . $css_class . '" style="display:none;"><p>' . $attention_messages . '</p>' . $close . '</div>';
792
+				$notices .= '<div id="'.$css_id.'" class="espresso-notices '.$css_class.'" style="display:none;"><p>'.$attention_messages.'</p>'.$close.'</div>';
793 793
 			}
794 794
 
795 795
 			if ($error_messages != '') {
796 796
 				$css_id = is_admin() ? 'message' : 'espresso-notices-error';
797 797
 				$css_class = is_admin() ? 'error' : 'error fade-away';
798 798
 				//showMessage( $error_messages, TRUE );
799
-				$notices .= '<div id="' . $css_id . '" class="espresso-notices ' . $css_class . '" style="display:none;"><p>' . $error_messages . '</p>' . $close . '</div>';
799
+				$notices .= '<div id="'.$css_id.'" class="espresso-notices '.$css_class.'" style="display:none;"><p>'.$error_messages.'</p>'.$close.'</div>';
800 800
 			}
801 801
 
802 802
 			$notices .= '</div>';
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
 					'errors' => $error_messages
810 810
 			);
811 811
 
812
-			if ( $remove_empty ) {
812
+			if ($remove_empty) {
813 813
 				// remove empty notices
814 814
 				foreach ($notices as $type => $notice) {
815 815
 					if (empty($notice)) {
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 			}
820 820
 		}
821 821
 
822
-		if ( $print_scripts ) {
822
+		if ($print_scripts) {
823 823
 			self::_print_scripts();
824 824
 		}
825 825
 
@@ -839,17 +839,17 @@  discard block
 block discarded – undo
839 839
 	* 	@param bool $force_update allows one to enforce the reappearance of a persistent message.
840 840
 	* 	@return 		void
841 841
 	*/
842
-	public static function add_persistent_admin_notice( $pan_name = '', $pan_message, $force_update = FALSE ) {
843
-		if ( ! empty( $pan_name ) && ! empty( $pan_message )) {
844
-			$persistent_admin_notices = get_option( 'ee_pers_admin_notices', array() );
842
+	public static function add_persistent_admin_notice($pan_name = '', $pan_message, $force_update = FALSE) {
843
+		if ( ! empty($pan_name) && ! empty($pan_message)) {
844
+			$persistent_admin_notices = get_option('ee_pers_admin_notices', array());
845 845
 			//maybe initialize persistent_admin_notices
846
-			if ( empty( $persistent_admin_notices )) {
847
-				add_option( 'ee_pers_admin_notices', array(), '', 'no' );
846
+			if (empty($persistent_admin_notices)) {
847
+				add_option('ee_pers_admin_notices', array(), '', 'no');
848 848
 			}
849
-			$pan_name = sanitize_key( $pan_name );
850
-			if ( ! array_key_exists( $pan_name, $persistent_admin_notices ) || $force_update ) {
851
-				$persistent_admin_notices[ $pan_name ] = $pan_message;
852
-				update_option( 'ee_pers_admin_notices', $persistent_admin_notices );
849
+			$pan_name = sanitize_key($pan_name);
850
+			if ( ! array_key_exists($pan_name, $persistent_admin_notices) || $force_update) {
851
+				$persistent_admin_notices[$pan_name] = $pan_message;
852
+				update_option('ee_pers_admin_notices', $persistent_admin_notices);
853 853
 			}
854 854
 		}
855 855
 	}
@@ -865,34 +865,34 @@  discard block
 block discarded – undo
865 865
 	 * @param bool          $return_immediately
866 866
 	 * @return        void
867 867
 	 */
868
-	public static function dismiss_persistent_admin_notice( $pan_name = '', $purge = FALSE, $return_immediately = FALSE ) {
869
-		$pan_name = EE_Registry::instance()->REQ->is_set( 'ee_nag_notice' ) ? EE_Registry::instance()->REQ->get( 'ee_nag_notice' ) : $pan_name;
870
-		if ( ! empty( $pan_name )) {
871
-			$persistent_admin_notices = get_option( 'ee_pers_admin_notices', array() );
868
+	public static function dismiss_persistent_admin_notice($pan_name = '', $purge = FALSE, $return_immediately = FALSE) {
869
+		$pan_name = EE_Registry::instance()->REQ->is_set('ee_nag_notice') ? EE_Registry::instance()->REQ->get('ee_nag_notice') : $pan_name;
870
+		if ( ! empty($pan_name)) {
871
+			$persistent_admin_notices = get_option('ee_pers_admin_notices', array());
872 872
 			// check if notice we wish to dismiss is actually in the $persistent_admin_notices array
873
-			if ( is_array( $persistent_admin_notices ) && isset( $persistent_admin_notices[ $pan_name ] )) {
873
+			if (is_array($persistent_admin_notices) && isset($persistent_admin_notices[$pan_name])) {
874 874
 				// completely delete nag notice, or just NULL message so that it can NOT be added again ?
875
-				if ( $purge ) {
876
-					unset( $persistent_admin_notices[ $pan_name ] );
875
+				if ($purge) {
876
+					unset($persistent_admin_notices[$pan_name]);
877 877
 				} else {
878
-					$persistent_admin_notices[ $pan_name ] = NULL;
878
+					$persistent_admin_notices[$pan_name] = NULL;
879 879
 				}
880
-				if ( update_option( 'ee_pers_admin_notices', $persistent_admin_notices ) === FALSE ) {
881
-					EE_Error::add_error( sprintf( __( 'The persistent admin notice for "%s" could not be deleted.', 'event_espresso' ), $pan_name ), __FILE__, __FUNCTION__, __LINE__ );
880
+				if (update_option('ee_pers_admin_notices', $persistent_admin_notices) === FALSE) {
881
+					EE_Error::add_error(sprintf(__('The persistent admin notice for "%s" could not be deleted.', 'event_espresso'), $pan_name), __FILE__, __FUNCTION__, __LINE__);
882 882
 				}
883 883
 			}
884 884
 		}
885
-		if ( $return_immediately ) {
885
+		if ($return_immediately) {
886 886
 			return;
887
-		} else if ( EE_Registry::instance()->REQ->ajax ) {
887
+		} else if (EE_Registry::instance()->REQ->ajax) {
888 888
 			// grab any notices and concatenate into string
889
-			echo json_encode( array( 'errors' => implode( '<br />', EE_Error::get_notices( FALSE ))));
889
+			echo json_encode(array('errors' => implode('<br />', EE_Error::get_notices(FALSE))));
890 890
 			exit();
891 891
 		} else {
892 892
 			// save errors to a transient to be displayed on next request (after redirect)
893
-			EE_Error::get_notices( FALSE, TRUE );
894
-			$return_url = EE_Registry::instance()->REQ->is_set( 'return_url' ) ? EE_Registry::instance()->REQ->get( 'return_url' ) : '';
895
-			wp_safe_redirect( urldecode( $return_url ));
893
+			EE_Error::get_notices(FALSE, TRUE);
894
+			$return_url = EE_Registry::instance()->REQ->is_set('return_url') ? EE_Registry::instance()->REQ->get('return_url') : '';
895
+			wp_safe_redirect(urldecode($return_url));
896 896
 		}
897 897
 	}
898 898
 
@@ -907,20 +907,20 @@  discard block
 block discarded – undo
907 907
 	* 	@param		string	$return_url	URL to go back to aftger nag notice is dismissed
908 908
 	 *  	@return 		string
909 909
 	 */
910
-	public static function display_persistent_admin_notices( $pan_name = '', $pan_message = '', $return_url = '' ) {
911
-		if ( ! empty( $pan_name ) && ! empty( $pan_message )) {
910
+	public static function display_persistent_admin_notices($pan_name = '', $pan_message = '', $return_url = '') {
911
+		if ( ! empty($pan_name) && ! empty($pan_message)) {
912 912
 			$args = array(
913 913
 				'nag_notice' => $pan_name,
914
-				'return_url' => urlencode( $return_url ),
914
+				'return_url' => urlencode($return_url),
915 915
 				'ajax_url' => WP_AJAX_URL,
916
-				'unknown_error' => __( 'An unknown error has occurred on the server while attempting to dismiss this notice.', 'event_espresso' )
916
+				'unknown_error' => __('An unknown error has occurred on the server while attempting to dismiss this notice.', 'event_espresso')
917 917
 			);
918
-			wp_localize_script( 'espresso_core', 'ee_dismiss', $args );
918
+			wp_localize_script('espresso_core', 'ee_dismiss', $args);
919 919
 			return '
920
-			<div id="' . $pan_name . '" class="espresso-notices updated ee-nag-notice clearfix" style="border-left: 4px solid #fcb93c;">
921
-				<p>' . $pan_message . '</p>
922
-				<a class="dismiss-ee-nag-notice hide-if-no-js" style="float: right; cursor: pointer; text-decoration:none;" rel="' . $pan_name . '">
923
-					<span class="dashicons dashicons-dismiss" style="position:relative; top:-1px; margin-right:.25em;"></span>'.__( 'Dismiss', 'event_espresso' ) .'
920
+			<div id="' . $pan_name.'" class="espresso-notices updated ee-nag-notice clearfix" style="border-left: 4px solid #fcb93c;">
921
+				<p>' . $pan_message.'</p>
922
+				<a class="dismiss-ee-nag-notice hide-if-no-js" style="float: right; cursor: pointer; text-decoration:none;" rel="' . $pan_name.'">
923
+					<span class="dashicons dashicons-dismiss" style="position:relative; top:-1px; margin-right:.25em;"></span>'.__('Dismiss', 'event_espresso').'
924 924
 				</a>
925 925
 				<div style="clear:both;"></div>
926 926
 			</div>';
@@ -936,17 +936,17 @@  discard block
 block discarded – undo
936 936
 	 * @param string $return_url
937 937
 	 * @return    array
938 938
 	 */
939
-	public static function get_persistent_admin_notices( $return_url = '' ) {
939
+	public static function get_persistent_admin_notices($return_url = '') {
940 940
 		$notices = '';
941 941
 		// check for persistent admin notices
942
-		if ( $persistent_admin_notices = get_option( 'ee_pers_admin_notices', FALSE )) {
942
+		if ($persistent_admin_notices = get_option('ee_pers_admin_notices', FALSE)) {
943 943
 			// load scripts
944
-			wp_register_script( 'espresso_core', EE_GLOBAL_ASSETS_URL . 'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, TRUE );
945
-			wp_register_script( 'ee_error_js', EE_GLOBAL_ASSETS_URL . 'scripts/EE_Error.js', array('espresso_core'), EVENT_ESPRESSO_VERSION, TRUE );
946
-			wp_enqueue_script( 'ee_error_js' );
944
+			wp_register_script('espresso_core', EE_GLOBAL_ASSETS_URL.'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, TRUE);
945
+			wp_register_script('ee_error_js', EE_GLOBAL_ASSETS_URL.'scripts/EE_Error.js', array('espresso_core'), EVENT_ESPRESSO_VERSION, TRUE);
946
+			wp_enqueue_script('ee_error_js');
947 947
 			// and display notices
948
-			foreach( $persistent_admin_notices as $pan_name => $pan_message ) {
949
-				$notices .= self::display_persistent_admin_notices( $pan_name, $pan_message, $return_url );
948
+			foreach ($persistent_admin_notices as $pan_name => $pan_message) {
949
+				$notices .= self::display_persistent_admin_notices($pan_name, $pan_message, $return_url);
950 950
 			}
951 951
 		}
952 952
 		return $notices;
@@ -961,26 +961,26 @@  discard block
 block discarded – undo
961 961
 	 * @param 	bool $force_print
962 962
 	 * @return 	void
963 963
 	 */
964
-	private static function _print_scripts( $force_print = FALSE ) {
965
-		if (( did_action( 'admin_enqueue_scripts' ) || did_action( 'wp_enqueue_scripts' )) && ! $force_print ) {
966
-			if ( wp_script_is( 'ee_error_js', 'enqueued' )) {
964
+	private static function _print_scripts($force_print = FALSE) {
965
+		if ((did_action('admin_enqueue_scripts') || did_action('wp_enqueue_scripts')) && ! $force_print) {
966
+			if (wp_script_is('ee_error_js', 'enqueued')) {
967 967
 				return;
968
-			} else if ( wp_script_is( 'ee_error_js', 'registered' )) {
969
-				add_filter( 'FHEE_load_css', '__return_true' );
970
-				add_filter( 'FHEE_load_js', '__return_true' );
971
-				wp_enqueue_script( 'ee_error_js' );
972
-				wp_localize_script( 'ee_error_js','ee_settings', array( 'wp_debug'=>WP_DEBUG ));
968
+			} else if (wp_script_is('ee_error_js', 'registered')) {
969
+				add_filter('FHEE_load_css', '__return_true');
970
+				add_filter('FHEE_load_js', '__return_true');
971
+				wp_enqueue_script('ee_error_js');
972
+				wp_localize_script('ee_error_js', 'ee_settings', array('wp_debug'=>WP_DEBUG));
973 973
 			}
974 974
 		} else {
975 975
 			return '
976 976
 <script>
977 977
 /* <![CDATA[ */
978
-var ee_settings = {"wp_debug":"' . WP_DEBUG . '"};
978
+var ee_settings = {"wp_debug":"' . WP_DEBUG.'"};
979 979
 /* ]]> */
980 980
 </script>
981
-<script src="' . includes_url() . 'js/jquery/jquery.js" type="text/javascript"></script>
982
-<script src="' . EE_GLOBAL_ASSETS_URL . 'scripts/espresso_core.js' . '?ver=' . espresso_version() . '" type="text/javascript"></script>
983
-<script src="' . EE_GLOBAL_ASSETS_URL . 'scripts/EE_Error.js' . '?ver=' . espresso_version() . '" type="text/javascript"></script>
981
+<script src="' . includes_url().'js/jquery/jquery.js" type="text/javascript"></script>
982
+<script src="' . EE_GLOBAL_ASSETS_URL.'scripts/espresso_core.js'.'?ver='.espresso_version().'" type="text/javascript"></script>
983
+<script src="' . EE_GLOBAL_ASSETS_URL.'scripts/EE_Error.js'.'?ver='.espresso_version().'" type="text/javascript"></script>
984 984
 ';
985 985
 
986 986
 		}
@@ -1014,11 +1014,11 @@  discard block
 block discarded – undo
1014 1014
 	*	@ param string $line
1015 1015
 	*	@ return string
1016 1016
 	*/
1017
-	public static function generate_error_code ( $file = '', $func = '', $line = '' ) {
1018
-		$file = explode( '.', basename( $file ));
1019
-		$error_code = ! empty( $file[0] ) ? $file[0] : '';
1020
-		$error_code .= ! empty( $func ) ? ' - ' . $func : '';
1021
-		$error_code .= ! empty( $line ) ? ' - ' . $line : '';
1017
+	public static function generate_error_code($file = '', $func = '', $line = '') {
1018
+		$file = explode('.', basename($file));
1019
+		$error_code = ! empty($file[0]) ? $file[0] : '';
1020
+		$error_code .= ! empty($func) ? ' - '.$func : '';
1021
+		$error_code .= ! empty($line) ? ' - '.$line : '';
1022 1022
 		return $error_code;
1023 1023
 	}
1024 1024
 
@@ -1034,38 +1034,38 @@  discard block
 block discarded – undo
1034 1034
 	*	@ param object $ex
1035 1035
 	*	@ return void
1036 1036
 	*/
1037
-	public function write_to_error_log ( $time = FALSE, $ex = FALSE, $clear = FALSE ) {
1037
+	public function write_to_error_log($time = FALSE, $ex = FALSE, $clear = FALSE) {
1038 1038
 
1039
-		if ( ! $ex ) {
1039
+		if ( ! $ex) {
1040 1040
 			return;
1041 1041
 		}
1042 1042
 
1043
-		if ( ! $time ) {
1043
+		if ( ! $time) {
1044 1044
 			$time = time();
1045 1045
 		}
1046 1046
 
1047
-		$exception_log = '----------------------------------------------------------------------------------------' . PHP_EOL;
1048
-		$exception_log .= '[' . date( 'Y-m-d H:i:s', $time ) . ']  Exception Details' . PHP_EOL;
1049
-		$exception_log .= 'Message: ' . $ex['msg'] . PHP_EOL;
1050
-		$exception_log .= 'Code: '. $ex['code'] . PHP_EOL;
1051
-		$exception_log .= 'File: '. $ex['file'] . PHP_EOL;
1052
-		$exception_log .= 'Line No: ' . $ex['line'] . PHP_EOL;
1053
-		$exception_log .= 'Stack trace: ' . PHP_EOL;
1054
-		$exception_log .= $ex['string'] . PHP_EOL;
1055
-		$exception_log .= '----------------------------------------------------------------------------------------' . PHP_EOL;
1056
-
1057
-		EE_Registry::instance()->load_helper( 'File' );
1047
+		$exception_log = '----------------------------------------------------------------------------------------'.PHP_EOL;
1048
+		$exception_log .= '['.date('Y-m-d H:i:s', $time).']  Exception Details'.PHP_EOL;
1049
+		$exception_log .= 'Message: '.$ex['msg'].PHP_EOL;
1050
+		$exception_log .= 'Code: '.$ex['code'].PHP_EOL;
1051
+		$exception_log .= 'File: '.$ex['file'].PHP_EOL;
1052
+		$exception_log .= 'Line No: '.$ex['line'].PHP_EOL;
1053
+		$exception_log .= 'Stack trace: '.PHP_EOL;
1054
+		$exception_log .= $ex['string'].PHP_EOL;
1055
+		$exception_log .= '----------------------------------------------------------------------------------------'.PHP_EOL;
1056
+
1057
+		EE_Registry::instance()->load_helper('File');
1058 1058
 		try {
1059
-			EEH_File::ensure_folder_exists_and_is_writable( EVENT_ESPRESSO_UPLOAD_DIR . 'logs' );
1060
-			EEH_File::add_htaccess_deny_from_all( EVENT_ESPRESSO_UPLOAD_DIR . 'logs' );
1061
-			EEH_File::ensure_file_exists_and_is_writable( EVENT_ESPRESSO_UPLOAD_DIR . 'logs' . DS . self::$_exception_log_file );
1062
-			if ( ! $clear ) {
1059
+			EEH_File::ensure_folder_exists_and_is_writable(EVENT_ESPRESSO_UPLOAD_DIR.'logs');
1060
+			EEH_File::add_htaccess_deny_from_all(EVENT_ESPRESSO_UPLOAD_DIR.'logs');
1061
+			EEH_File::ensure_file_exists_and_is_writable(EVENT_ESPRESSO_UPLOAD_DIR.'logs'.DS.self::$_exception_log_file);
1062
+			if ( ! $clear) {
1063 1063
 				//get existing log file and append new log info
1064
-				$exception_log = EEH_File::get_file_contents( EVENT_ESPRESSO_UPLOAD_DIR . 'logs' . DS . self::$_exception_log_file ) . $exception_log;
1064
+				$exception_log = EEH_File::get_file_contents(EVENT_ESPRESSO_UPLOAD_DIR.'logs'.DS.self::$_exception_log_file).$exception_log;
1065 1065
 			}
1066
-			EEH_File::write_to_file( EVENT_ESPRESSO_UPLOAD_DIR . 'logs' . DS . self::$_exception_log_file, $exception_log );
1067
-		} catch( EE_Error $e ){
1068
-			EE_Error::add_error( sprintf( __(  'Event Espresso error logging could not be setup because: %s', 'event_espresso' ), $e->getMessage() ));
1066
+			EEH_File::write_to_file(EVENT_ESPRESSO_UPLOAD_DIR.'logs'.DS.self::$_exception_log_file, $exception_log);
1067
+		} catch (EE_Error $e) {
1068
+			EE_Error::add_error(sprintf(__('Event Espresso error logging could not be setup because: %s', 'event_espresso'), $e->getMessage()));
1069 1069
 			return;
1070 1070
 		}
1071 1071
 
@@ -1088,10 +1088,10 @@  discard block
 block discarded – undo
1088 1088
 	 * @param  string $version  The version of Event Espresso where the error was added
1089 1089
 	 * @return trigger_error()
1090 1090
 	 */
1091
-	public static function doing_it_wrong( $function, $message, $version ) {
1092
-		if ( defined('WP_DEBUG') && WP_DEBUG ) {
1091
+	public static function doing_it_wrong($function, $message, $version) {
1092
+		if (defined('WP_DEBUG') && WP_DEBUG) {
1093 1093
 			EE_Registry::instance()->load_helper('Debug_Tools');
1094
-			EEH_Debug_Tools::instance()->doing_it_wrong( $function, $message, $version );
1094
+			EEH_Debug_Tools::instance()->doing_it_wrong($function, $message, $version);
1095 1095
 		}
1096 1096
 	}
1097 1097
 
@@ -1111,13 +1111,13 @@  discard block
 block discarded – undo
1111 1111
  */
1112 1112
 function espresso_error_enqueue_scripts() {
1113 1113
 	// js for error handling
1114
-	wp_register_script( 'espresso_core', EE_GLOBAL_ASSETS_URL . 'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, FALSE );
1115
-	wp_register_script( 'ee_error_js', EE_GLOBAL_ASSETS_URL . 'scripts/EE_Error.js', array('espresso_core'), EVENT_ESPRESSO_VERSION, FALSE );
1114
+	wp_register_script('espresso_core', EE_GLOBAL_ASSETS_URL.'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, FALSE);
1115
+	wp_register_script('ee_error_js', EE_GLOBAL_ASSETS_URL.'scripts/EE_Error.js', array('espresso_core'), EVENT_ESPRESSO_VERSION, FALSE);
1116 1116
 }
1117
-if ( is_admin() ) {
1118
-	add_action( 'admin_enqueue_scripts', 'espresso_error_enqueue_scripts', 2 );
1117
+if (is_admin()) {
1118
+	add_action('admin_enqueue_scripts', 'espresso_error_enqueue_scripts', 2);
1119 1119
 } else {
1120
-	add_action( 'wp_enqueue_scripts', 'espresso_error_enqueue_scripts', 2 );
1120
+	add_action('wp_enqueue_scripts', 'espresso_error_enqueue_scripts', 2);
1121 1121
 }
1122 1122
 
1123 1123
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,6 @@
 block discarded – undo
1
-<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3
+}
2 4
 /**
3 5
  * Event Espresso
4 6
  *
Please login to merge, or discard this patch.
core/EE_Maintenance_Mode.core.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
 	 *   returns TRUE if M-Mode is engaged and the current request is not for the admin
185 185
 	 *
186 186
 	 * @access    public
187
-	 * @return    string
187
+	 * @return    boolean
188 188
 	 */
189 189
 	public static function disable_frontend_for_maintenance() {
190 190
 		return ! is_admin() && EE_Maintenance_Mode::instance()->level() ? TRUE : FALSE;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,10 +48,10 @@
 block discarded – undo
48 48
 	 */
49 49
 	const option_name_maintenance_mode = 'ee_maintenance_mode';
50 50
    /**
51
-     * 	EE_Maintenance_Mode Object
52
-     * 	@var EE_Maintenance_Mode $_instance
53
-	 * 	@access 	private
54
-     */
51
+    * 	EE_Maintenance_Mode Object
52
+    * 	@var EE_Maintenance_Mode $_instance
53
+    * 	@access 	private
54
+    */
55 55
 	private static $_instance = NULL;
56 56
 
57 57
 	/**
Please login to merge, or discard this patch.
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 */
74 74
 	public static function instance() {
75 75
 		// check if class object is instantiated
76
-		if ( self::$_instance === NULL  or ! is_object( self::$_instance ) or ! ( self::$_instance instanceof EE_Maintenance_Mode )) {
76
+		if (self::$_instance === NULL or ! is_object(self::$_instance) or ! (self::$_instance instanceof EE_Maintenance_Mode)) {
77 77
 			self::$_instance = new self();
78 78
 		}
79 79
 		return self::$_instance;
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	 * Resets maintenance mode (mostly just re-checks whether or not we should be in maintenance mode)
84 84
 	 * @return EE_Maintenance_Mode
85 85
 	 */
86
-	public static function reset(){
86
+	public static function reset() {
87 87
 		self::instance()->set_maintenance_mode_if_db_old();
88 88
 		return self::instance();
89 89
 	}
@@ -98,11 +98,11 @@  discard block
 block discarded – undo
98 98
 	 */
99 99
 	private function __construct() {
100 100
 		// if M-Mode level 2 is engaged, we still need basic assets loaded
101
-		add_action( 'wp_enqueue_scripts', array( $this, 'load_assets_required_for_m_mode' ));
101
+		add_action('wp_enqueue_scripts', array($this, 'load_assets_required_for_m_mode'));
102 102
 		// shut 'er down down for maintenance ?
103
-		add_filter( 'the_content', array( $this, 'the_content' ), 999 );
103
+		add_filter('the_content', array($this, 'the_content'), 999);
104 104
 		// add powered by EE msg
105
-		add_action( 'shutdown', array( $this, 'display_maintenance_mode_notice' ), 10 );
105
+		add_action('shutdown', array($this, 'display_maintenance_mode_notice'), 10);
106 106
 	}
107 107
 
108 108
 
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	 * retrieves the maintenance mode option value from the db
113 113
 	 * @return int
114 114
 	 */
115
-	public function real_level(){
116
-		return get_option( self::option_name_maintenance_mode, EE_Maintenance_Mode::level_0_not_in_maintenance );
115
+	public function real_level() {
116
+		return get_option(self::option_name_maintenance_mode, EE_Maintenance_Mode::level_0_not_in_maintenance);
117 117
 	}
118 118
 
119 119
 	/**
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * thinks their tables are present and up-to-date).
122 122
 	 * @return boolean
123 123
 	 */
124
-	public function models_can_query(){
124
+	public function models_can_query() {
125 125
 		return $this->real_level() != EE_Maintenance_Mode::level_2_complete_maintenance;
126 126
 	}
127 127
 
@@ -134,14 +134,14 @@  discard block
 block discarded – undo
134 134
 	 * EE_Maintenance_Mode::level_2_complete_maintenance => frontend and backend maintenance mode
135 135
 	 * @return int
136 136
 	 */
137
-	public function level(){
137
+	public function level() {
138 138
 		$real_maintenance_mode_level = $this->real_level();
139 139
 		//if this is an admin request, we'll be honest... except if it's ajax, because that might be from the frontend
140
-		if( ( ! is_admin() || (defined('DOING_AJAX') && DOING_AJAX)) && //only on frontend or ajax requests
140
+		if (( ! is_admin() || (defined('DOING_AJAX') && DOING_AJAX)) && //only on frontend or ajax requests
141 141
 			current_user_can('administrator') && //when the user is an admin
142
-			$real_maintenance_mode_level == EE_Maintenance_Mode::level_1_frontend_only_maintenance){//and we're in level 1
142
+			$real_maintenance_mode_level == EE_Maintenance_Mode::level_1_frontend_only_maintenance) {//and we're in level 1
143 143
 			$maintenance_mode_level = EE_Maintenance_Mode::level_0_not_in_maintenance;
144
-		}else{
144
+		} else {
145 145
 			$maintenance_mode_level = $real_maintenance_mode_level;
146 146
 		}
147 147
 		return $maintenance_mode_level;
@@ -151,17 +151,17 @@  discard block
 block discarded – undo
151 151
 	 * Determines if we need to put EE in maintenance mode because the database needs updating
152 152
 	 * @return boolean true if DB is old and maintenance mode was triggered; false otherwise
153 153
 	 */
154
-	public function set_maintenance_mode_if_db_old(){
155
-		EE_Registry::instance()->load_core( 'Data_Migration_Manager' );
156
-		if( EE_Data_Migration_Manager::instance()->check_for_applicable_data_migration_scripts()){
154
+	public function set_maintenance_mode_if_db_old() {
155
+		EE_Registry::instance()->load_core('Data_Migration_Manager');
156
+		if (EE_Data_Migration_Manager::instance()->check_for_applicable_data_migration_scripts()) {
157 157
 			update_option(self::option_name_maintenance_mode, self::level_2_complete_maintenance);
158 158
 			return true;
159
-		}elseif( $this->level() == self::level_2_complete_maintenance ){
159
+		}elseif ($this->level() == self::level_2_complete_maintenance) {
160 160
 			//we also want to handle the opposite: if the site is mm2, but there aren't any migrations to run
161 161
 			//then we shouldn't be in mm2. (Maybe an addon got deactivated?)
162
-			update_option( self::option_name_maintenance_mode, self::level_0_not_in_maintenance );
162
+			update_option(self::option_name_maintenance_mode, self::level_0_not_in_maintenance);
163 163
 			return false;
164
-		}else{
164
+		} else {
165 165
 			return false;
166 166
 		}
167 167
 	}
@@ -171,8 +171,8 @@  discard block
 block discarded – undo
171 171
 	 * @param int $level
172 172
 	 * @return void
173 173
 	 */
174
-	public function set_maintenance_level($level){
175
-		do_action( 'AHEE__EE_Maintenance_Mode__set_maintenance_level', $level );
174
+	public function set_maintenance_level($level) {
175
+		do_action('AHEE__EE_Maintenance_Mode__set_maintenance_level', $level);
176 176
 		update_option(self::option_name_maintenance_mode, intval($level));
177 177
 	}
178 178
 
@@ -199,11 +199,11 @@  discard block
 block discarded – undo
199 199
 	 *  @return 	string
200 200
 	 */
201 201
 	public function load_assets_required_for_m_mode() {
202
-		if ( $this->real_level() == EE_Maintenance_Mode::level_2_complete_maintenance && ! wp_script_is( 'espresso_core', 'enqueued' )) {
203
-			wp_register_style( 'espresso_default', EE_GLOBAL_ASSETS_URL . 'css/espresso_default.css', array( 'dashicons' ), EVENT_ESPRESSO_VERSION );
202
+		if ($this->real_level() == EE_Maintenance_Mode::level_2_complete_maintenance && ! wp_script_is('espresso_core', 'enqueued')) {
203
+			wp_register_style('espresso_default', EE_GLOBAL_ASSETS_URL.'css/espresso_default.css', array('dashicons'), EVENT_ESPRESSO_VERSION);
204 204
 			wp_enqueue_style('espresso_default');
205
-			wp_register_script( 'espresso_core', EE_GLOBAL_ASSETS_URL . 'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, TRUE );
206
-			wp_enqueue_script( 'espresso_core' );
205
+			wp_register_script('espresso_core', EE_GLOBAL_ASSETS_URL.'scripts/espresso_core.js', array('jquery'), EVENT_ESPRESSO_VERSION, TRUE);
206
+			wp_enqueue_script('espresso_core');
207 207
 		}
208 208
 	}
209 209
 
@@ -218,9 +218,9 @@  discard block
 block discarded – undo
218 218
 	 * @param    string $template_path
219 219
 	 * @return    string
220 220
 	 */
221
-	public static function template_include( $template_path ) {
222
-		EE_Registry::instance()->load_helper( 'Template' );
223
-		$template_located = EEH_Template::locate_template( EE_TEMPLATES . 'maintenance_mode.template.php', FALSE, FALSE );
221
+	public static function template_include($template_path) {
222
+		EE_Registry::instance()->load_helper('Template');
223
+		$template_located = EEH_Template::locate_template(EE_TEMPLATES.'maintenance_mode.template.php', FALSE, FALSE);
224 224
 		return $template_located ? $template_located : $template_path;
225 225
 	}
226 226
 
@@ -235,12 +235,12 @@  discard block
 block discarded – undo
235 235
 	 * @param    string $the_content
236 236
 	 * @return    string
237 237
 	 */
238
-	public function the_content( $the_content ) {
238
+	public function the_content($the_content) {
239 239
 		// check if M-mode is engaged and for EE shortcode
240
-		if ( $this->level() && strpos( $the_content, '[ESPRESSO_' )) {
240
+		if ($this->level() && strpos($the_content, '[ESPRESSO_')) {
241 241
 			// this can eventually be moved to a template, or edited via admin. But for now...
242 242
 			$the_content = sprintf(
243
-				__( '%sMaintenance Mode%sEvent Registration has been temporarily closed while system maintenance is being performed. We\'re sorry for any inconveniences this may have caused. Please try back again later.%s', 'event_espresso' ),
243
+				__('%sMaintenance Mode%sEvent Registration has been temporarily closed while system maintenance is being performed. We\'re sorry for any inconveniences this may have caused. Please try back again later.%s', 'event_espresso'),
244 244
 				'<h2>',
245 245
 				'</h2><p>',
246 246
 				'</p>'
@@ -264,17 +264,17 @@  discard block
 block discarded – undo
264 264
 		// check if M-mode is engaged and for EE shortcode
265 265
 		if (
266 266
 			$this->real_level() &&
267
-			current_user_can( 'administrator' ) &&
267
+			current_user_can('administrator') &&
268 268
 			! is_admin() &&
269
-			! ( defined( 'DOING_AJAX' ) && DOING_AJAX )
269
+			! (defined('DOING_AJAX') && DOING_AJAX)
270 270
 			&& EE_Registry::instance()->REQ->is_espresso_page()
271 271
 		) {
272 272
 			$admin_bar_adjustment = is_admin_bar_showing() ? ' style="top:32px;"' : '';
273 273
 			printf(
274
-				__( '%sclose%sEvent Registration is currently disabled because Event Espresso has been placed into Maintenance Mode. To change Maintenance Mode settings, click here %sEE Maintenance Mode Admin Page%s', 'event_espresso' ),
275
-				'<div id="ee-m-mode-admin-notice-dv" class="ee-really-important-notice-dv"' . $admin_bar_adjustment . '><a class="close-espresso-notice" title="',
274
+				__('%sclose%sEvent Registration is currently disabled because Event Espresso has been placed into Maintenance Mode. To change Maintenance Mode settings, click here %sEE Maintenance Mode Admin Page%s', 'event_espresso'),
275
+				'<div id="ee-m-mode-admin-notice-dv" class="ee-really-important-notice-dv"'.$admin_bar_adjustment.'><a class="close-espresso-notice" title="',
276 276
 				'">&times;</a><p>',
277
-				' &raquo; <a href="' . add_query_arg( array( 'page' => 'espresso_maintenance_settings' ), admin_url( 'admin.php' )) . '">',
277
+				' &raquo; <a href="'.add_query_arg(array('page' => 'espresso_maintenance_settings'), admin_url('admin.php')).'">',
278 278
 				'</a></p></div>'
279 279
 			);
280 280
 		}
@@ -292,9 +292,9 @@  discard block
 block discarded – undo
292 292
 	 *		@ return void
293 293
 	 */
294 294
 	final function __destruct() {}
295
-	final function __call($a,$b) {}
295
+	final function __call($a, $b) {}
296 296
 	final function __get($a) {}
297
-	final function __set($a,$b) {}
297
+	final function __set($a, $b) {}
298 298
 	final function __isset($a) {}
299 299
 	final function __unset($a) {}
300 300
 	final function __sleep() {
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
 	final function __invoke() {}
306 306
 	final function __set_state() {}
307 307
 	final function __clone() {}
308
-	final static function __callStatic($a,$b) {}
308
+	final static function __callStatic($a, $b) {}
309 309
 
310 310
 }
311 311
 // End of file EE_Maintenance_Mode.core.php
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 			current_user_can('administrator') && //when the user is an admin
142 142
 			$real_maintenance_mode_level == EE_Maintenance_Mode::level_1_frontend_only_maintenance){//and we're in level 1
143 143
 			$maintenance_mode_level = EE_Maintenance_Mode::level_0_not_in_maintenance;
144
-		}else{
144
+		} else{
145 145
 			$maintenance_mode_level = $real_maintenance_mode_level;
146 146
 		}
147 147
 		return $maintenance_mode_level;
@@ -156,12 +156,12 @@  discard block
 block discarded – undo
156 156
 		if( EE_Data_Migration_Manager::instance()->check_for_applicable_data_migration_scripts()){
157 157
 			update_option(self::option_name_maintenance_mode, self::level_2_complete_maintenance);
158 158
 			return true;
159
-		}elseif( $this->level() == self::level_2_complete_maintenance ){
159
+		} elseif( $this->level() == self::level_2_complete_maintenance ){
160 160
 			//we also want to handle the opposite: if the site is mm2, but there aren't any migrations to run
161 161
 			//then we shouldn't be in mm2. (Maybe an addon got deactivated?)
162 162
 			update_option( self::option_name_maintenance_mode, self::level_0_not_in_maintenance );
163 163
 			return false;
164
-		}else{
164
+		} else{
165 165
 			return false;
166 166
 		}
167 167
 	}
Please login to merge, or discard this patch.