Completed
Branch BUG-9871-email-validation (e62b1a)
by
unknown
350:41 queued 333:27
created
admin/extend/registration_form/Extend_Registration_Form_Admin_Page.core.php 2 patches
Indentation   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -245,13 +245,13 @@  discard block
 block discarded – undo
245 245
 					'persistent' => FALSE
246 246
 					),
247 247
 				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array('_publish_post_box' ) ),
248
-                'help_tabs' => array(
248
+				'help_tabs' => array(
249 249
 					'registration_form_add_question_help_tab' => array(
250 250
 						'title' => esc_html__('Add Question', 'event_espresso'),
251 251
 						'filename' => 'registration_form_add_question'
252 252
 						),
253 253
 					),
254
-                'help_tour' => array( 'Registration_Form_Add_Question_Help_Tour'),
254
+				'help_tour' => array( 'Registration_Form_Add_Question_Help_Tour'),
255 255
 				'require_nonce' => FALSE
256 256
 				),
257 257
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 						'filename' => 'registration_form_add_question_group'
269 269
 						),
270 270
 					),
271
-                'help_tour' => array( 'Registration_Form_Add_Question_Group_Help_Tour'),
271
+				'help_tour' => array( 'Registration_Form_Add_Question_Group_Help_Tour'),
272 272
 				'require_nonce' => FALSE
273 273
 				),
274 274
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 						'filename' => 'registration_form_edit_question_group'
287 287
 						),
288 288
 					),
289
-                'help_tour' => array( 'Registration_Form_Edit_Question_Group_Help_Tour'),
289
+				'help_tour' => array( 'Registration_Form_Edit_Question_Group_Help_Tour'),
290 290
 				'require_nonce' => FALSE
291 291
 				),
292 292
 
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
 						'filename' => 'registration_form_reg_form_settings'
306 306
 						),
307 307
 					),
308
-                'help_tour' => array( 'Registration_Form_Settings_Help_Tour'),
308
+				'help_tour' => array( 'Registration_Form_Settings_Help_Tour'),
309 309
 				'require_nonce' => FALSE
310 310
 				)
311 311
 
@@ -933,7 +933,7 @@  discard block
 block discarded – undo
933 933
 	 * @return EE_Form_Section_Proper
934 934
 	 */
935 935
 	protected function _email_validation_settings_form() {
936
-        return new EE_Form_Section_Proper(
936
+		return new EE_Form_Section_Proper(
937 937
 			array(
938 938
 				'name'            => 'email_validation_settings',
939 939
 				'html_id'         => 'email_validation_settings',
@@ -951,7 +951,7 @@  discard block
 block discarded – undo
951 951
 						),
952 952
 						array(
953 953
 							'html_label_text' => esc_html__( 'Email Validation Level', 'event_espresso' )
954
-							                     . EEH_Template::get_help_tab_link( 'email_validation_info' ),
954
+												 . EEH_Template::get_help_tab_link( 'email_validation_info' ),
955 955
 							'html_help_text'  => esc_html__( 'These levels range from basic validation ( ie: [email protected] ) to more advanced checks against international email addresses (ie: üñîçøðé@example.com ) with additional MX and A record checks to confirm the domain actually exists. More information on on each level can be found within the help section.', 'event_espresso'),
956 956
 							'default' => isset( EE_Registry::instance()->CFG->registration->email_validation_level )
957 957
 								? EE_Registry::instance()->CFG->registration->email_validation_level
@@ -973,8 +973,8 @@  discard block
 block discarded – undo
973 973
 	 * @return \EE_Registration_Config
974 974
 	 */
975 975
 	public function update_email_validation_settings_form( EE_Registration_Config $EE_Registration_Config ) {
976
-        $prev_email_validation_level = $EE_Registration_Config->email_validation_level;
977
-        try {
976
+		$prev_email_validation_level = $EE_Registration_Config->email_validation_level;
977
+		try {
978 978
 			$email_validation_settings_form = $this->_email_validation_settings_form();
979 979
 			// if not displaying a form, then check for form submission
980 980
 			if ( $email_validation_settings_form->was_submitted() ) {
@@ -985,38 +985,38 @@  discard block
 block discarded – undo
985 985
 					// grab validated data from form
986 986
 					$valid_data = $email_validation_settings_form->valid_data();
987 987
 					if ( isset( $valid_data['email_validation_level'] ) ) {
988
-					    $email_validation_level = $valid_data['email_validation_level'];
989
-                        // now if they want to use international email addresses
990
-                        if ( $email_validation_level === 'i18n' || $email_validation_level === 'i18n_dns' ) {
991
-                            // in case we need to reset their email validation level,
992
-                            // make sure that the previous value wasn't already set to one of the i18n options.
993
-                            if ( $prev_email_validation_level === 'i18n' || $prev_email_validation_level === 'i18n_dns' ) {
994
-                                // if so, then reset it back to "basic" since that is the only other option that,
995
-                                // despite offering poor validation, supports i18n email addresses
996
-                                $prev_email_validation_level = 'basic';
997
-                            }
998
-                            // confirm our i18n email validation will work on the server
999
-                            if ( ! $this->_verify_pcre_support($EE_Registration_Config, $email_validation_level)) {
1000
-                                // or reset email validation level to previous value
1001
-                                $email_validation_level = $prev_email_validation_level;
1002
-                            }
1003
-                        }
1004
-                        $EE_Registration_Config->email_validation_level = $email_validation_level;
1005
-                    } else {
988
+						$email_validation_level = $valid_data['email_validation_level'];
989
+						// now if they want to use international email addresses
990
+						if ( $email_validation_level === 'i18n' || $email_validation_level === 'i18n_dns' ) {
991
+							// in case we need to reset their email validation level,
992
+							// make sure that the previous value wasn't already set to one of the i18n options.
993
+							if ( $prev_email_validation_level === 'i18n' || $prev_email_validation_level === 'i18n_dns' ) {
994
+								// if so, then reset it back to "basic" since that is the only other option that,
995
+								// despite offering poor validation, supports i18n email addresses
996
+								$prev_email_validation_level = 'basic';
997
+							}
998
+							// confirm our i18n email validation will work on the server
999
+							if ( ! $this->_verify_pcre_support($EE_Registration_Config, $email_validation_level)) {
1000
+								// or reset email validation level to previous value
1001
+								$email_validation_level = $prev_email_validation_level;
1002
+							}
1003
+						}
1004
+						$EE_Registration_Config->email_validation_level = $email_validation_level;
1005
+					} else {
1006 1006
 						EE_Error::add_error(
1007 1007
 							esc_html__(
1008 1008
 								'Invalid or missing Email Validation settings. Please refresh the form and try again.',
1009 1009
 								'event_espresso'
1010 1010
 							),
1011
-                            __FILE__, __FUNCTION__, __LINE__
1012
-                        );
1011
+							__FILE__, __FUNCTION__, __LINE__
1012
+						);
1013 1013
 					}
1014 1014
 				} else {
1015 1015
 					if ( $email_validation_settings_form->submission_error_message() !== '' ) {
1016 1016
 						EE_Error::add_error(
1017 1017
 							$email_validation_settings_form->submission_error_message(),
1018
-                            __FILE__, __FUNCTION__, __LINE__
1019
-                        );
1018
+							__FILE__, __FUNCTION__, __LINE__
1019
+						);
1020 1020
 					}
1021 1021
 				}
1022 1022
 			}
@@ -1028,61 +1028,61 @@  discard block
 block discarded – undo
1028 1028
 
1029 1029
 
1030 1030
 
1031
-    /**
1032
-     * confirms that the server's PHP version has the PCRE module enabled,
1033
-     * and that the PCRE version works with our i18n email validation
1034
-     *
1035
-     * @param \EE_Registration_Config $EE_Registration_Config
1036
-     * @param string                  $email_validation_level
1037
-     * @return bool
1038
-     */
1039
-    private function _verify_pcre_support(EE_Registration_Config $EE_Registration_Config, $email_validation_level)
1040
-    {
1041
-        // first check that PCRE is enabled
1042
-        if ( ! defined('PREG_BAD_UTF8_ERROR')) {
1043
-            EE_Error::add_error(
1044
-                sprintf(
1045
-                    esc_html__(
1046
-                        'We\'re sorry, but it appears that your server\'s version of PHP was not compiled with PCRE unicode support.%1$sPlease contact your hosting company and ask them whether the PCRE compiled with your version of PHP on your server can be been built with the "--enable-unicode-properties" and "--enable-utf8" configuration switches to enable more complex regex expressions.%1$sIf they are unable, or unwilling to do so, then your server will not support international email addresses using UTF-8 unicode characters. This means you will either have to lower your email validation level to "Basic" or "WordPress Default", or switch to a hosting company that has/can enable PCRE unicode support on the server.',
1047
-                        'event_espresso'
1048
-                    ),
1049
-                    '<br />'
1050
-                ),
1051
-                __FILE__,
1052
-                __FUNCTION__,
1053
-                __LINE__
1054
-            );
1055
-            return false;
1056
-        } else {
1057
-            // PCRE support is enabled, but let's still
1058
-            // perform a test to see if the server will support it.
1059
-            // but first, save the updated validation level to the config,
1060
-            // so that the validation strategy picks it up.
1061
-            // this will get bumped back down if it doesn't work
1062
-            $EE_Registration_Config->email_validation_level = $email_validation_level;
1063
-            try {
1064
-                $email_validator = new EE_Email_Validation_Strategy();
1065
-                $i18n_email_address = apply_filters(
1066
-                    'FHEE__Extend_Registration_Form_Admin_Page__update_email_validation_settings_form__i18n_email_address',
1067
-                    'jägerjü[email protected]'
1068
-                );
1069
-                $email_validator->validate($i18n_email_address);
1070
-            } catch (Exception $e) {
1071
-                EE_Error::add_error(
1072
-                    sprintf(
1073
-                        esc_html__(
1074
-                            'We\'re sorry, but it appears that your server\'s configuration will not support the "International" or "International + DNS Check" email validation levels.%1$sTo correct this issue, please consult with your hosting company regarding your server\'s PCRE settings.%1$sIt is recommended that your PHP version be configured to use PCRE 8.10 or newer.%1$sMore information regarding PCRE versions and installation can be found here: %2$s',
1075
-                            'event_espresso'
1076
-                        ),
1077
-                        '<br />',
1078
-                        '<a href="http://php.net/manual/en/pcre.installation.php" target="_blank">http://php.net/manual/en/pcre.installation.php</a>'
1079
-                    ),
1080
-                    __FILE__, __FUNCTION__, __LINE__
1081
-                );
1082
-                return false;
1083
-            }
1084
-        }
1085
-        return true;
1086
-    }
1031
+	/**
1032
+	 * confirms that the server's PHP version has the PCRE module enabled,
1033
+	 * and that the PCRE version works with our i18n email validation
1034
+	 *
1035
+	 * @param \EE_Registration_Config $EE_Registration_Config
1036
+	 * @param string                  $email_validation_level
1037
+	 * @return bool
1038
+	 */
1039
+	private function _verify_pcre_support(EE_Registration_Config $EE_Registration_Config, $email_validation_level)
1040
+	{
1041
+		// first check that PCRE is enabled
1042
+		if ( ! defined('PREG_BAD_UTF8_ERROR')) {
1043
+			EE_Error::add_error(
1044
+				sprintf(
1045
+					esc_html__(
1046
+						'We\'re sorry, but it appears that your server\'s version of PHP was not compiled with PCRE unicode support.%1$sPlease contact your hosting company and ask them whether the PCRE compiled with your version of PHP on your server can be been built with the "--enable-unicode-properties" and "--enable-utf8" configuration switches to enable more complex regex expressions.%1$sIf they are unable, or unwilling to do so, then your server will not support international email addresses using UTF-8 unicode characters. This means you will either have to lower your email validation level to "Basic" or "WordPress Default", or switch to a hosting company that has/can enable PCRE unicode support on the server.',
1047
+						'event_espresso'
1048
+					),
1049
+					'<br />'
1050
+				),
1051
+				__FILE__,
1052
+				__FUNCTION__,
1053
+				__LINE__
1054
+			);
1055
+			return false;
1056
+		} else {
1057
+			// PCRE support is enabled, but let's still
1058
+			// perform a test to see if the server will support it.
1059
+			// but first, save the updated validation level to the config,
1060
+			// so that the validation strategy picks it up.
1061
+			// this will get bumped back down if it doesn't work
1062
+			$EE_Registration_Config->email_validation_level = $email_validation_level;
1063
+			try {
1064
+				$email_validator = new EE_Email_Validation_Strategy();
1065
+				$i18n_email_address = apply_filters(
1066
+					'FHEE__Extend_Registration_Form_Admin_Page__update_email_validation_settings_form__i18n_email_address',
1067
+					'jägerjü[email protected]'
1068
+				);
1069
+				$email_validator->validate($i18n_email_address);
1070
+			} catch (Exception $e) {
1071
+				EE_Error::add_error(
1072
+					sprintf(
1073
+						esc_html__(
1074
+							'We\'re sorry, but it appears that your server\'s configuration will not support the "International" or "International + DNS Check" email validation levels.%1$sTo correct this issue, please consult with your hosting company regarding your server\'s PCRE settings.%1$sIt is recommended that your PHP version be configured to use PCRE 8.10 or newer.%1$sMore information regarding PCRE versions and installation can be found here: %2$s',
1075
+							'event_espresso'
1076
+						),
1077
+						'<br />',
1078
+						'<a href="http://php.net/manual/en/pcre.installation.php" target="_blank">http://php.net/manual/en/pcre.installation.php</a>'
1079
+					),
1080
+					__FILE__, __FUNCTION__, __LINE__
1081
+				);
1082
+				return false;
1083
+			}
1084
+		}
1085
+		return true;
1086
+	}
1087 1087
 
1088 1088
 }
Please login to merge, or discard this patch.
Spacing   +187 added lines, -187 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if (!defined('EVENT_ESPRESSO_VERSION') ){
2
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
3 3
 	exit('NO direct script access allowed');
4 4
 }
5 5
 /**
@@ -36,13 +36,13 @@  discard block
 block discarded – undo
36 36
 	 * 		@param bool $routing indicate whether we want to just load the object and handle routing or just load the object.
37 37
 	 * 		@access public
38 38
 	 */
39
-	public function __construct( $routing = TRUE ) {
40
-		define( 'REGISTRATION_FORM_CAF_ADMIN', EE_CORE_CAF_ADMIN_EXTEND . 'registration_form' . DS );
41
-		define( 'REGISTRATION_FORM_CAF_ASSETS_PATH', REGISTRATION_FORM_CAF_ADMIN . 'assets' . DS );
42
-		define( 'REGISTRATION_FORM_CAF_ASSETS_URL', EE_CORE_CAF_ADMIN_EXTEND_URL . 'registration_form/assets/' );
43
-		define( 'REGISTRATION_FORM_CAF_TEMPLATE_PATH', REGISTRATION_FORM_CAF_ADMIN . 'templates' . DS );
44
-		define( 'REGISTRATION_FORM_CAF_TEMPLATE_URL', EE_CORE_CAF_ADMIN_EXTEND_URL . 'registration_form/templates/' );
45
-		parent::__construct( $routing );
39
+	public function __construct($routing = TRUE) {
40
+		define('REGISTRATION_FORM_CAF_ADMIN', EE_CORE_CAF_ADMIN_EXTEND.'registration_form'.DS);
41
+		define('REGISTRATION_FORM_CAF_ASSETS_PATH', REGISTRATION_FORM_CAF_ADMIN.'assets'.DS);
42
+		define('REGISTRATION_FORM_CAF_ASSETS_URL', EE_CORE_CAF_ADMIN_EXTEND_URL.'registration_form/assets/');
43
+		define('REGISTRATION_FORM_CAF_TEMPLATE_PATH', REGISTRATION_FORM_CAF_ADMIN.'templates'.DS);
44
+		define('REGISTRATION_FORM_CAF_TEMPLATE_URL', EE_CORE_CAF_ADMIN_EXTEND_URL.'registration_form/templates/');
45
+		parent::__construct($routing);
46 46
 	}
47 47
 
48 48
 
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 
53 53
 	protected function _extend_page_config() {
54 54
 		$this->_admin_base_path = REGISTRATION_FORM_CAF_ADMIN;
55
-		$qst_id = ! empty( $this->_req_data['QST_ID'] ) && ! is_array( $this->_req_data['QST_ID'] ) ? $this->_req_data['QST_ID'] : 0;
56
-		$qsg_id = ! empty( $this->_req_data['QSG_ID'] ) && ! is_array( $this->_req_data['QSG_ID'] ) ? $this->_req_data['QSG_ID'] : 0;
55
+		$qst_id = ! empty($this->_req_data['QST_ID']) && ! is_array($this->_req_data['QST_ID']) ? $this->_req_data['QST_ID'] : 0;
56
+		$qsg_id = ! empty($this->_req_data['QSG_ID']) && ! is_array($this->_req_data['QSG_ID']) ? $this->_req_data['QSG_ID'] : 0;
57 57
 
58 58
 		$new_page_routes = array(
59 59
 			'question_groups' => array(
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 				'func' => '_trash_or_restore_questions',
87 87
 				'capability' => 'ee_delete_question',
88 88
 				'obj_id' => $qst_id,
89
-				'args' => array( 'trash' => FALSE ),
89
+				'args' => array('trash' => FALSE),
90 90
 				'noheader' => TRUE
91 91
 				),
92 92
 
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 
146 146
 			'trash_question_group' => array(
147 147
 				'func' => '_trash_or_restore_question_groups',
148
-				'args' => array( 'trash' => TRUE ),
148
+				'args' => array('trash' => TRUE),
149 149
 				'capability' => 'ee_delete_question_group',
150 150
 				'obj_id' => $qsg_id,
151 151
 				'noheader' => TRUE
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
 			'restore_question_group' => array(
155 155
 				'func' => '_trash_or_restore_question_groups',
156
-				'args' => array( 'trash' => FALSE ),
156
+				'args' => array('trash' => FALSE),
157 157
 				'capability' => 'ee_delete_question_group',
158 158
 				'obj_id' => $qsg_id,
159 159
 				'noheader' => TRUE
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 
169 169
 			'update_question_group' => array(
170 170
 				'func' => '_insert_or_update_question_group',
171
-				'args' => array('new_question_group' => FALSE ),
171
+				'args' => array('new_question_group' => FALSE),
172 172
 				'capability' => 'ee_edit_question_group',
173 173
 				'obj_id' => $qsg_id,
174 174
 				'noheader' => TRUE,
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 					'noheader' => TRUE
207 207
 				),
208 208
 			);
209
-		$this->_page_routes = array_merge( $this->_page_routes, $new_page_routes );
209
+		$this->_page_routes = array_merge($this->_page_routes, $new_page_routes);
210 210
 
211 211
 		$new_page_config = array(
212 212
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 						'filename' => 'registration_form_question_groups_views_bulk_actions_search'
231 231
 						),
232 232
 					),
233
-				'help_tour' => array( 'Registration_Form_Question_Groups_Help_Tour'),
233
+				'help_tour' => array('Registration_Form_Question_Groups_Help_Tour'),
234 234
 				'metaboxes' => $this->_default_espresso_metaboxes,
235 235
 				'require_nonce' => FALSE,
236 236
 				'qtips' => array(
@@ -244,14 +244,14 @@  discard block
 block discarded – undo
244 244
 					'order' => 5,
245 245
 					'persistent' => FALSE
246 246
 					),
247
-				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array('_publish_post_box' ) ),
247
+				'metaboxes' => array_merge($this->_default_espresso_metaboxes, array('_publish_post_box')),
248 248
                 'help_tabs' => array(
249 249
 					'registration_form_add_question_help_tab' => array(
250 250
 						'title' => esc_html__('Add Question', 'event_espresso'),
251 251
 						'filename' => 'registration_form_add_question'
252 252
 						),
253 253
 					),
254
-                'help_tour' => array( 'Registration_Form_Add_Question_Help_Tour'),
254
+                'help_tour' => array('Registration_Form_Add_Question_Help_Tour'),
255 255
 				'require_nonce' => FALSE
256 256
 				),
257 257
 
@@ -261,14 +261,14 @@  discard block
 block discarded – undo
261 261
 					'order' => 5,
262 262
 					'persistent' => FALSE
263 263
 					),
264
-				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array('_publish_post_box' ) ),
264
+				'metaboxes' => array_merge($this->_default_espresso_metaboxes, array('_publish_post_box')),
265 265
 				'help_tabs' => array(
266 266
 					'registration_form_add_question_group_help_tab' => array(
267 267
 						'title' => esc_html__('Add Question Group', 'event_espresso'),
268 268
 						'filename' => 'registration_form_add_question_group'
269 269
 						),
270 270
 					),
271
-                'help_tour' => array( 'Registration_Form_Add_Question_Group_Help_Tour'),
271
+                'help_tour' => array('Registration_Form_Add_Question_Group_Help_Tour'),
272 272
 				'require_nonce' => FALSE
273 273
 				),
274 274
 
@@ -277,16 +277,16 @@  discard block
 block discarded – undo
277 277
 					'label' => esc_html__('Edit Question Group', 'event_espresso'),
278 278
 					'order' => 5,
279 279
 					'persistent' => FALSE,
280
-					'url' => isset($this->_req_data['question_group_id']) ? add_query_arg(array('question_group_id' => $this->_req_data['question_group_id'] ), $this->_current_page_view_url )  : $this->_admin_base_url
280
+					'url' => isset($this->_req_data['question_group_id']) ? add_query_arg(array('question_group_id' => $this->_req_data['question_group_id']), $this->_current_page_view_url) : $this->_admin_base_url
281 281
 					),
282
-				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array('_publish_post_box' ) ),
282
+				'metaboxes' => array_merge($this->_default_espresso_metaboxes, array('_publish_post_box')),
283 283
 				'help_tabs' => array(
284 284
 					'registration_form_edit_question_group_help_tab' => array(
285 285
 						'title' => esc_html__('Edit Question Group', 'event_espresso'),
286 286
 						'filename' => 'registration_form_edit_question_group'
287 287
 						),
288 288
 					),
289
-                'help_tour' => array( 'Registration_Form_Edit_Question_Group_Help_Tour'),
289
+                'help_tour' => array('Registration_Form_Edit_Question_Group_Help_Tour'),
290 290
 				'require_nonce' => FALSE
291 291
 				),
292 292
 
@@ -298,19 +298,19 @@  discard block
 block discarded – undo
298 298
 				'labels' => array(
299 299
 					'publishbox' => esc_html__('Update Settings', 'event_espresso')
300 300
 					),
301
-				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array( '_publish_post_box' ) ),
301
+				'metaboxes' => array_merge($this->_default_espresso_metaboxes, array('_publish_post_box')),
302 302
 				'help_tabs' => array(
303 303
 					'registration_form_reg_form_settings_help_tab' => array(
304 304
 						'title' => esc_html__('Registration Form Settings', 'event_espresso'),
305 305
 						'filename' => 'registration_form_reg_form_settings'
306 306
 						),
307 307
 					),
308
-                'help_tour' => array( 'Registration_Form_Settings_Help_Tour'),
308
+                'help_tour' => array('Registration_Form_Settings_Help_Tour'),
309 309
 				'require_nonce' => FALSE
310 310
 				)
311 311
 
312 312
 			);
313
-		$this->_page_config = array_merge( $this->_page_config, $new_page_config );
313
+		$this->_page_config = array_merge($this->_page_config, $new_page_config);
314 314
 
315 315
 		//change the list table we're going to use so it's the NEW list table!
316 316
 		$this->_page_config['default']['list_table'] = 'Extend_Registration_Form_Questions_Admin_List_Table';
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 			'edit_question_group' => esc_html__('Edit Question Group', 'event_espresso'),
325 325
 			'delete_question_group' => esc_html__('Delete Question Group', 'event_espresso'),
326 326
 			);
327
-		$this->_labels['buttons'] = array_merge( $this->_labels['buttons'], $new_labels );
327
+		$this->_labels['buttons'] = array_merge($this->_labels['buttons'], $new_labels);
328 328
 
329 329
 	}
330 330
 
@@ -333,14 +333,14 @@  discard block
 block discarded – undo
333 333
 
334 334
 
335 335
 	protected function _ajax_hooks() {
336
-		add_action('wp_ajax_espresso_update_question_group_order', array( $this, 'update_question_group_order' ));
336
+		add_action('wp_ajax_espresso_update_question_group_order', array($this, 'update_question_group_order'));
337 337
 	}
338 338
 
339 339
 
340 340
 
341 341
 
342 342
 	public function load_scripts_styles_question_groups() {
343
-		wp_enqueue_script( 'espresso_ajax_table_sorting' );
343
+		wp_enqueue_script('espresso_ajax_table_sorting');
344 344
 	}
345 345
 
346 346
 
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 * @return void
362 362
 	 */
363 363
 	public function load_sortable_question_script() {
364
-		wp_register_script('ee-question-sortable', REGISTRATION_FORM_CAF_ASSETS_URL . 'ee_question_order.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, true);
364
+		wp_register_script('ee-question-sortable', REGISTRATION_FORM_CAF_ASSETS_URL.'ee_question_order.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, true);
365 365
 		wp_enqueue_script('ee-question-sortable');
366 366
 	}
367 367
 
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
 				)
381 381
 		);
382 382
 
383
-		if ( EE_Registry::instance()->CAP->current_user_can('ee_delete_questions', 'espresso_registration_form_trash_questions' ) ) {
383
+		if (EE_Registry::instance()->CAP->current_user_can('ee_delete_questions', 'espresso_registration_form_trash_questions')) {
384 384
 			$this->_views['trash'] = array(
385 385
 				'slug' => 'trash',
386 386
 				'label' => esc_html__('Trash', 'event_espresso'),
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
 				)
411 411
 		);
412 412
 
413
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_delete_question_groups', 'espresso_registration_form_trash_question_groups' ) ) {
413
+		if (EE_Registry::instance()->CAP->current_user_can('ee_delete_question_groups', 'espresso_registration_form_trash_question_groups')) {
414 414
 			$this->_views['trash'] = array(
415 415
 				'slug' => 'trash',
416 416
 				'label' => esc_html__('Trash', 'event_espresso'),
@@ -446,24 +446,24 @@  discard block
 block discarded – undo
446 446
 
447 447
 
448 448
 
449
-	protected function _delete_question(){
450
-		$success = $this->_delete_items( $this->_question_model );
449
+	protected function _delete_question() {
450
+		$success = $this->_delete_items($this->_question_model);
451 451
 		$this->_redirect_after_action(
452 452
 			$success,
453
-			$this->_question_model->item_name( $success ),
453
+			$this->_question_model->item_name($success),
454 454
 			'deleted',
455
-			array( 'action' => 'default', 'status' => 'all' )
455
+			array('action' => 'default', 'status' => 'all')
456 456
 		);
457 457
 	}
458 458
 
459 459
 
460 460
 	protected function _delete_questions() {
461
-		$success = $this->_delete_items( $this->_question_model );
461
+		$success = $this->_delete_items($this->_question_model);
462 462
 		$this->_redirect_after_action(
463 463
 			$success,
464
-			$this->_question_model->item_name( $success ),
464
+			$this->_question_model->item_name($success),
465 465
 			'deleted permanently',
466
-			array( 'action' => 'default', 'status' => 'trash' )
466
+			array('action' => 'default', 'status' => 'trash')
467 467
 		);
468 468
 	}
469 469
 
@@ -474,26 +474,26 @@  discard block
 block discarded – undo
474 474
  * @param EEM_Soft_Delete_Base $model
475 475
  * @return int number of items deleted permanently
476 476
  */
477
-	private function _delete_items(EEM_Soft_Delete_Base $model){
477
+	private function _delete_items(EEM_Soft_Delete_Base $model) {
478 478
 		$success = 0;
479
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
480
-		if (!empty($this->_req_data['checkbox']) && is_array($this->_req_data['checkbox'])) {
479
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
480
+		if ( ! empty($this->_req_data['checkbox']) && is_array($this->_req_data['checkbox'])) {
481 481
 			// if array has more than one element than success message should be plural
482
-			$success = count( $this->_req_data['checkbox'] ) > 1 ? 2 : 1;
482
+			$success = count($this->_req_data['checkbox']) > 1 ? 2 : 1;
483 483
 			// cycle thru bulk action checkboxes
484
-			while (list( $ID, $value ) = each($this->_req_data['checkbox'])) {
485
-				if ( ! $this->_delete_item( $ID, $model ) ) {
484
+			while (list($ID, $value) = each($this->_req_data['checkbox'])) {
485
+				if ( ! $this->_delete_item($ID, $model)) {
486 486
 					$success = 0;
487 487
 				}
488 488
 			}
489 489
 
490
-		}elseif( !empty($this->_req_data['QSG_ID'])){
491
-			$success = $this->_delete_item( $this->_req_data['QSG_ID'], $model );
490
+		}elseif ( ! empty($this->_req_data['QSG_ID'])) {
491
+			$success = $this->_delete_item($this->_req_data['QSG_ID'], $model);
492 492
 
493
-		}elseif( !empty($this->_req_data['QST_ID'])){
494
-			$success = $this->_delete_item( $this->_req_data['QST_ID'], $model );
495
-		}else{
496
-			EE_Error::add_error( sprintf(esc_html__("No Questions or Question Groups were selected for deleting. This error usually shows when you've attempted to delete via bulk action but there were no selections.", "event_espresso")), __FILE__, __FUNCTION__, __LINE__ );
493
+		}elseif ( ! empty($this->_req_data['QST_ID'])) {
494
+			$success = $this->_delete_item($this->_req_data['QST_ID'], $model);
495
+		} else {
496
+			EE_Error::add_error(sprintf(esc_html__("No Questions or Question Groups were selected for deleting. This error usually shows when you've attempted to delete via bulk action but there were no selections.", "event_espresso")), __FILE__, __FUNCTION__, __LINE__);
497 497
 		}
498 498
 		return $success;
499 499
 	}
@@ -504,11 +504,11 @@  discard block
 block discarded – undo
504 504
 	 * @param EEM_Soft_Delete_Base $model
505 505
 	 * @return boolean
506 506
 	 */
507
-	protected function _delete_item( $id, $model ) {
508
-		if( $model instanceof EEM_Question ) {
509
-			EEM_Question_Option::instance()->delete_permanently( array( array( 'QST_ID' => absint( $id ) ) ) );
507
+	protected function _delete_item($id, $model) {
508
+		if ($model instanceof EEM_Question) {
509
+			EEM_Question_Option::instance()->delete_permanently(array(array('QST_ID' => absint($id))));
510 510
 		}
511
-		return $model->delete_permanently_by_ID( absint( $id ) );
511
+		return $model->delete_permanently_by_ID(absint($id));
512 512
 	}
513 513
 
514 514
 
@@ -520,41 +520,41 @@  discard block
 block discarded – undo
520 520
 
521 521
 
522 522
 
523
-	protected function _edit_question_group( $type = 'add' ) {
524
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
525
-		$ID=isset( $this->_req_data['QSG_ID'] ) && ! empty( $this->_req_data['QSG_ID'] ) ? absint( $this->_req_data['QSG_ID'] ) : FALSE;
523
+	protected function _edit_question_group($type = 'add') {
524
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
525
+		$ID = isset($this->_req_data['QSG_ID']) && ! empty($this->_req_data['QSG_ID']) ? absint($this->_req_data['QSG_ID']) : FALSE;
526 526
 
527
-		switch( $this->_req_action ) {
527
+		switch ($this->_req_action) {
528 528
 			case 'add_question_group' :
529
-				$this->_admin_page_title = esc_html__( 'Add Question Group', 'event_espresso' );
529
+				$this->_admin_page_title = esc_html__('Add Question Group', 'event_espresso');
530 530
 				break;
531 531
 			case 'edit_question_group' :
532
-				$this->_admin_page_title = esc_html__( 'Edit Question Group', 'event_espresso' );
532
+				$this->_admin_page_title = esc_html__('Edit Question Group', 'event_espresso');
533 533
 				break;
534 534
 			default :
535
-				$this->_admin_page_title = ucwords( str_replace( '_', ' ', $this->_req_action ));
535
+				$this->_admin_page_title = ucwords(str_replace('_', ' ', $this->_req_action));
536 536
 		}
537 537
 		// add ID to title if editing
538
-		$this->_admin_page_title = $ID ? $this->_admin_page_title . ' # ' . $ID : $this->_admin_page_title;
539
-		if($ID){
538
+		$this->_admin_page_title = $ID ? $this->_admin_page_title.' # '.$ID : $this->_admin_page_title;
539
+		if ($ID) {
540 540
 			/** @var EE_Question_Group $questionGroup */
541
-			$questionGroup=$this->_question_group_model->get_one_by_ID( $ID);
542
-			$additional_hidden_fields=array('QSG_ID'=>array('type'=>'hidden','value'=>$ID));
541
+			$questionGroup = $this->_question_group_model->get_one_by_ID($ID);
542
+			$additional_hidden_fields = array('QSG_ID'=>array('type'=>'hidden', 'value'=>$ID));
543 543
 			$this->_set_add_edit_form_tags('update_question_group', $additional_hidden_fields);
544
-		}else{
544
+		} else {
545 545
 			/** @var EE_Question_Group $questionGroup */
546 546
 			$questionGroup = EEM_Question_Group::instance()->create_default_object();
547 547
 			$questionGroup->set_order_to_latest();
548 548
 			$this->_set_add_edit_form_tags('insert_question_group');
549 549
 		}
550 550
 		$this->_template_args['values'] = $this->_yes_no_values;
551
-		$this->_template_args['all_questions']=$questionGroup->questions_in_and_not_in_group();
552
-		$this->_template_args['QSG_ID']=$ID ? $ID : TRUE;
553
-		$this->_template_args['question_group']=$questionGroup;
551
+		$this->_template_args['all_questions'] = $questionGroup->questions_in_and_not_in_group();
552
+		$this->_template_args['QSG_ID'] = $ID ? $ID : TRUE;
553
+		$this->_template_args['question_group'] = $questionGroup;
554 554
 
555
-		$redirect_URL = add_query_arg( array( 'action' => 'question_groups'), $this->_admin_base_url );
556
-		$this->_set_publish_post_box_vars( 'id', $ID, FALSE, $redirect_URL  );
557
-		$this->_template_args['admin_page_content'] = EEH_Template::display_template( REGISTRATION_FORM_CAF_TEMPLATE_PATH . 'question_groups_main_meta_box.template.php', $this->_template_args, TRUE );
555
+		$redirect_URL = add_query_arg(array('action' => 'question_groups'), $this->_admin_base_url);
556
+		$this->_set_publish_post_box_vars('id', $ID, FALSE, $redirect_URL);
557
+		$this->_template_args['admin_page_content'] = EEH_Template::display_template(REGISTRATION_FORM_CAF_TEMPLATE_PATH.'question_groups_main_meta_box.template.php', $this->_template_args, TRUE);
558 558
 
559 559
 		// the details template wrapper
560 560
 		$this->display_admin_page_with_sidebar();
@@ -565,7 +565,7 @@  discard block
 block discarded – undo
565 565
 
566 566
 	protected function _delete_question_groups() {
567 567
 		$success = $this->_delete_items($this->_question_group_model);
568
-		$this->_redirect_after_action( $success, $this->_question_group_model->item_name($success), 'deleted permanently', array( 'action'=>'question_groups', 'status'=>'trash' ));
568
+		$this->_redirect_after_action($success, $this->_question_group_model->item_name($success), 'deleted permanently', array('action'=>'question_groups', 'status'=>'trash'));
569 569
 	}
570 570
 
571 571
 
@@ -573,71 +573,71 @@  discard block
 block discarded – undo
573 573
 	/**
574 574
 	 * @param bool $new_question_group
575 575
 	 */
576
-	protected function _insert_or_update_question_group( $new_question_group = TRUE) {
577
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
578
-		$set_column_values=$this->_set_column_values_for($this->_question_group_model);
579
-		if ( $new_question_group ){
576
+	protected function _insert_or_update_question_group($new_question_group = TRUE) {
577
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
578
+		$set_column_values = $this->_set_column_values_for($this->_question_group_model);
579
+		if ($new_question_group) {
580 580
 			$QSG_ID = $this->_question_group_model->insert($set_column_values);
581 581
 			$success = $QSG_ID ? 1 : 0;
582 582
 		} else {
583 583
 			$QSG_ID = absint($this->_req_data['QSG_ID']);
584
-			unset( $set_column_values[ 'QSG_ID' ] );
585
-			$success= $this->_question_group_model->update( $set_column_values, array( array( 'QSG_ID' => $QSG_ID )));
584
+			unset($set_column_values['QSG_ID']);
585
+			$success = $this->_question_group_model->update($set_column_values, array(array('QSG_ID' => $QSG_ID)));
586 586
 		}
587
-		$phone_question_id = EEM_Question::instance()->get_Question_ID_from_system_string( EEM_Attendee::system_question_phone );
587
+		$phone_question_id = EEM_Question::instance()->get_Question_ID_from_system_string(EEM_Attendee::system_question_phone);
588 588
 		// update the existing related questions
589 589
 		// BUT FIRST...  delete the phone question from the Question_Group_Question if it is being added to this question group (therefore removed from the existing group)
590
-		if ( isset( $this->_req_data['questions'], $this->_req_data['questions'][ $phone_question_id ] )) {
590
+		if (isset($this->_req_data['questions'], $this->_req_data['questions'][$phone_question_id])) {
591 591
 			// delete where QST ID = system phone question ID and Question Group ID is NOT this group
592
-			EEM_Question_Group_Question::instance()->delete( array( array( 'QST_ID' => $phone_question_id, 'QSG_ID' => array( '!=', $QSG_ID ))));
592
+			EEM_Question_Group_Question::instance()->delete(array(array('QST_ID' => $phone_question_id, 'QSG_ID' => array('!=', $QSG_ID))));
593 593
 		}
594 594
 		/** @type EE_Question_Group $question_group */
595
-		$question_group=$this->_question_group_model->get_one_by_ID( $QSG_ID );
595
+		$question_group = $this->_question_group_model->get_one_by_ID($QSG_ID);
596 596
 		$questions = $question_group->questions();
597 597
 		// make sure system phone question is added to list of questions for this group
598
-		if ( ! isset( $questions[$phone_question_id ] )) {
599
-			$questions[ $phone_question_id ] = EEM_Question::instance()->get_one_by_ID( $phone_question_id );
598
+		if ( ! isset($questions[$phone_question_id])) {
599
+			$questions[$phone_question_id] = EEM_Question::instance()->get_one_by_ID($phone_question_id);
600 600
 		}
601 601
 
602
-		foreach( $questions as $question_ID => $question ){
602
+		foreach ($questions as $question_ID => $question) {
603 603
 			// first we always check for order.
604
-			if ( ! empty( $this->_req_data['question_orders'][ $question_ID ] ) ){
604
+			if ( ! empty($this->_req_data['question_orders'][$question_ID])) {
605 605
 				//update question order
606
-				$question_group->update_question_order( $question_ID, $this->_req_data['question_orders'][ $question_ID ] );
606
+				$question_group->update_question_order($question_ID, $this->_req_data['question_orders'][$question_ID]);
607 607
 			}
608 608
 
609 609
 			// then we always check if adding or removing.
610
-			if ( isset( $this->_req_data['questions'], $this->_req_data['questions'][ $question_ID ] )) {
611
-				$question_group->add_question( $question_ID );
610
+			if (isset($this->_req_data['questions'], $this->_req_data['questions'][$question_ID])) {
611
+				$question_group->add_question($question_ID);
612 612
 			} else {
613 613
 				// not found, remove it (but only if not a system question for the personal group with the exception of lname system question - we allow removal of it)
614 614
 				if (
615 615
 					in_array(
616 616
 						$question->system_ID(),
617
-						EEM_Question::instance()->required_system_questions_in_system_question_group( $question_group->system_group() )
617
+						EEM_Question::instance()->required_system_questions_in_system_question_group($question_group->system_group())
618 618
 					)
619 619
 				) {
620 620
 					continue;
621 621
 				} else {
622
-					$question_group->remove_question( $question_ID );
622
+					$question_group->remove_question($question_ID);
623 623
 				}
624 624
 			}
625 625
 		}
626 626
 		// save new related questions
627
-		if ( isset( $this->_req_data['questions'] )) {
628
-			foreach( $this->_req_data['questions'] as $QST_ID ){
629
-				$question_group->add_question( $QST_ID );
630
-				if ( isset( $this->_req_data['question_orders'][ $QST_ID ] )) {
631
-					$question_group->update_question_order( $QST_ID, $this->_req_data['question_orders'][ $QST_ID ] );
627
+		if (isset($this->_req_data['questions'])) {
628
+			foreach ($this->_req_data['questions'] as $QST_ID) {
629
+				$question_group->add_question($QST_ID);
630
+				if (isset($this->_req_data['question_orders'][$QST_ID])) {
631
+					$question_group->update_question_order($QST_ID, $this->_req_data['question_orders'][$QST_ID]);
632 632
 				}
633 633
 			}
634 634
 		}
635 635
 
636
-		if ( $success !== FALSE ) {
637
-			$msg = $new_question_group ? sprintf( esc_html__('The %s has been created', 'event_espresso'), $this->_question_group_model->item_name() ) : sprintf( esc_html__('The %s has been updated', 'event_espresso' ), $this->_question_group_model->item_name() );
638
-			EE_Error::add_success( $msg );
636
+		if ($success !== FALSE) {
637
+			$msg = $new_question_group ? sprintf(esc_html__('The %s has been created', 'event_espresso'), $this->_question_group_model->item_name()) : sprintf(esc_html__('The %s has been updated', 'event_espresso'), $this->_question_group_model->item_name());
638
+			EE_Error::add_success($msg);
639 639
 		}
640
-		$this->_redirect_after_action(FALSE, '', '', array('action'=>'edit_question_group','QSG_ID'=>$QSG_ID), TRUE);
640
+		$this->_redirect_after_action(FALSE, '', '', array('action'=>'edit_question_group', 'QSG_ID'=>$QSG_ID), TRUE);
641 641
 
642 642
 	}
643 643
 
@@ -645,20 +645,20 @@  discard block
 block discarded – undo
645 645
 	 * duplicates a question and all its question options and redirects to the new question.
646 646
 	 */
647 647
 	public function _duplicate_question() {
648
-		$question_ID = (int)$this->_req_data[ 'QST_ID' ];
649
-		$question = EEM_Question::instance()->get_one_by_ID( $question_ID );
650
-		if( $question instanceof EE_Question ) {
648
+		$question_ID = (int) $this->_req_data['QST_ID'];
649
+		$question = EEM_Question::instance()->get_one_by_ID($question_ID);
650
+		if ($question instanceof EE_Question) {
651 651
 			$new_question = $question->duplicate();
652
-			if( $new_question instanceof EE_Question ) {
653
-				$this->_redirect_after_action( true, esc_html__( 'Question', 'event_espresso' ), esc_html__( 'Duplicated', 'event_espresso' ), array('action'=>'edit_question', 'QST_ID' => $new_question->ID() ), TRUE);
652
+			if ($new_question instanceof EE_Question) {
653
+				$this->_redirect_after_action(true, esc_html__('Question', 'event_espresso'), esc_html__('Duplicated', 'event_espresso'), array('action'=>'edit_question', 'QST_ID' => $new_question->ID()), TRUE);
654 654
 			} else {
655 655
 				global $wpdb;
656
-				EE_Error::add_error( sprintf( esc_html__( 'Could not duplicate question with ID %1$d because: %2$s', 'event_espresso' ), $question_ID, $wpdb->last_error ), __FILE__, __FUNCTION__, __LINE__ );
657
-			$this->_redirect_after_action(false, '', '', array('action'=>'default'), false );
656
+				EE_Error::add_error(sprintf(esc_html__('Could not duplicate question with ID %1$d because: %2$s', 'event_espresso'), $question_ID, $wpdb->last_error), __FILE__, __FUNCTION__, __LINE__);
657
+			$this->_redirect_after_action(false, '', '', array('action'=>'default'), false);
658 658
 			}
659 659
 		} else {
660
-			EE_Error::add_error( sprintf( esc_html__( 'Could not duplicate question with ID %d because it didn\'t exist!', 'event_espresso' ), $question_ID ), __FILE__, __FUNCTION__, __LINE__ );
661
-			$this->_redirect_after_action( false, '', '', array( 'action' => 'default' ), false );
660
+			EE_Error::add_error(sprintf(esc_html__('Could not duplicate question with ID %d because it didn\'t exist!', 'event_espresso'), $question_ID), __FILE__, __FUNCTION__, __LINE__);
661
+			$this->_redirect_after_action(false, '', '', array('action' => 'default'), false);
662 662
 		}
663 663
 	}
664 664
 
@@ -667,8 +667,8 @@  discard block
 block discarded – undo
667 667
 	/**
668 668
 	 * @param bool $trash
669 669
 	 */
670
-	protected function _trash_or_restore_question_groups( $trash = TRUE) {
671
-		$this->_trash_or_restore_items( $this->_question_group_model, $trash );
670
+	protected function _trash_or_restore_question_groups($trash = TRUE) {
671
+		$this->_trash_or_restore_items($this->_question_group_model, $trash);
672 672
 	}
673 673
 
674 674
 
@@ -676,9 +676,9 @@  discard block
 block discarded – undo
676 676
 	/**
677 677
 	 *_trash_question
678 678
 	 */
679
-	protected function _trash_question(){
680
-		$success=$this->_question_model->delete_by_ID( (int)$this->_req_data['QST_ID'] );
681
-		$query_args=array('action'=>'default','status'=>'all');
679
+	protected function _trash_question() {
680
+		$success = $this->_question_model->delete_by_ID((int) $this->_req_data['QST_ID']);
681
+		$query_args = array('action'=>'default', 'status'=>'all');
682 682
 		$this->_redirect_after_action($success, $this->_question_model->item_name($success), 'trashed', $query_args);
683 683
 	}
684 684
 
@@ -687,8 +687,8 @@  discard block
 block discarded – undo
687 687
 	/**
688 688
 	 * @param bool $trash
689 689
 	 */
690
-	protected function _trash_or_restore_questions( $trash=TRUE){
691
-		$this->_trash_or_restore_items( $this->_question_model, $trash );
690
+	protected function _trash_or_restore_questions($trash = TRUE) {
691
+		$this->_trash_or_restore_items($this->_question_model, $trash);
692 692
 	}
693 693
 
694 694
 
@@ -700,21 +700,21 @@  discard block
 block discarded – undo
700 700
 *@param EEM_Soft_Delete_Base $model
701 701
 	 * @param boolean $trash whether to trash or restore
702 702
 	 */
703
-	private function _trash_or_restore_items( EEM_Soft_Delete_Base $model, $trash = TRUE ) {
703
+	private function _trash_or_restore_items(EEM_Soft_Delete_Base $model, $trash = TRUE) {
704 704
 
705
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
705
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
706 706
 
707 707
 		$success = 1;
708 708
 		//Checkboxes
709 709
 		//echo "trash $trash";
710 710
 		//var_dump($this->_req_data['checkbox']);die;
711
-		if ( isset( $this->_req_data['checkbox'] )) {
712
-			if ( ! empty( $this->_req_data['checkbox'] ) && is_array( $this->_req_data['checkbox'] )) {
711
+		if (isset($this->_req_data['checkbox'])) {
712
+			if ( ! empty($this->_req_data['checkbox']) && is_array($this->_req_data['checkbox'])) {
713 713
 				// if array has more than one element than success message should be plural
714
-				$success = count( $this->_req_data['checkbox'] ) > 1 ? 2 : 1;
714
+				$success = count($this->_req_data['checkbox']) > 1 ? 2 : 1;
715 715
 				// cycle thru bulk action checkboxes
716
-				while (list( $ID, $value ) = each($this->_req_data['checkbox'])) {
717
-					if ( ! $model->delete_or_restore_by_ID($trash,absint($ID))) {
716
+				while (list($ID, $value) = each($this->_req_data['checkbox'])) {
717
+					if ( ! $model->delete_or_restore_by_ID($trash, absint($ID))) {
718 718
 						$success = 0;
719 719
 					}
720 720
 				}
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
 			} else {
723 723
 				// grab single id and delete
724 724
 				$ID = absint($this->_req_data['checkbox']);
725
-				if ( ! $model->delete_or_restore_by_ID($trash,$ID)) {
725
+				if ( ! $model->delete_or_restore_by_ID($trash, $ID)) {
726 726
 					$success = 0;
727 727
 				}
728 728
 			}
@@ -730,25 +730,25 @@  discard block
 block discarded – undo
730 730
 		} else {
731 731
 			// delete via trash link
732 732
 			// grab single id and delete
733
-			$ID = absint($this->_req_data[ $model->primary_key_name() ]);
734
-			if ( ! $model->delete_or_restore_by_ID($trash,$ID)) {
733
+			$ID = absint($this->_req_data[$model->primary_key_name()]);
734
+			if ( ! $model->delete_or_restore_by_ID($trash, $ID)) {
735 735
 				$success = 0;
736 736
 			}
737 737
 
738 738
 		}
739 739
 
740 740
 
741
-		$action = $model instanceof EEM_Question ? 'default' : 'question_groups';//strtolower( $model->item_name(2) );
741
+		$action = $model instanceof EEM_Question ? 'default' : 'question_groups'; //strtolower( $model->item_name(2) );
742 742
 		//echo "action :$action";
743 743
 		//$action = 'questions' ? 'default' : $action;
744
-		if($trash){
744
+		if ($trash) {
745 745
 			$action_desc = 'trashed';
746 746
 			$status = 'trash';
747
-		}else{
747
+		} else {
748 748
 			$action_desc = 'restored';
749 749
 			$status = 'all';
750 750
 		}
751
-		$this->_redirect_after_action( $success, $model->item_name($success), $action_desc, array( 'action' => $action, 'status'=>$status ) );
751
+		$this->_redirect_after_action($success, $model->item_name($success), $action_desc, array('action' => $action, 'status'=>$status));
752 752
 	}
753 753
 
754 754
 
@@ -759,16 +759,16 @@  discard block
 block discarded – undo
759 759
 	 * @param bool|false $count
760 760
 	 * @return \EE_Soft_Delete_Base_Class[]|int
761 761
 	 */
762
-	public function get_trashed_questions( $per_page, $current_page = 1, $count = FALSE ) {
762
+	public function get_trashed_questions($per_page, $current_page = 1, $count = FALSE) {
763 763
 		$query_params = $this->get_query_params(EEM_Question::instance(), $per_page, $current_page);
764 764
 
765
-		if( $count ){
765
+		if ($count) {
766 766
 			//note: this a subclass of EEM_Soft_Delete_Base, so this is actually only getting non-trashed items
767
-			$where = isset( $query_params[0] ) ? array( $query_params[0] ) : array();
768
-			$results=$this->_question_model->count_deleted($where);
769
-		}else{
767
+			$where = isset($query_params[0]) ? array($query_params[0]) : array();
768
+			$results = $this->_question_model->count_deleted($where);
769
+		} else {
770 770
 			//note: this a subclass of EEM_Soft_Delete_Base, so this is actually only getting non-trashed items
771
-			$results=$this->_question_model->get_all_deleted($query_params);
771
+			$results = $this->_question_model->get_all_deleted($query_params);
772 772
 		}
773 773
 		return $results;
774 774
 	}
@@ -781,13 +781,13 @@  discard block
 block discarded – undo
781 781
 	 * @param bool|false $count
782 782
 	 * @return \EE_Soft_Delete_Base_Class[]
783 783
 	 */
784
-	public function get_question_groups( $per_page, $current_page = 1, $count = FALSE ) {
785
-		$questionGroupModel=EEM_Question_Group::instance();
786
-		$query_params=$this->get_query_params($questionGroupModel,$per_page,$current_page);
787
-		if ($count){
788
-			$where = isset( $query_params[0] ) ? array( $query_params[0] ) : array();
784
+	public function get_question_groups($per_page, $current_page = 1, $count = FALSE) {
785
+		$questionGroupModel = EEM_Question_Group::instance();
786
+		$query_params = $this->get_query_params($questionGroupModel, $per_page, $current_page);
787
+		if ($count) {
788
+			$where = isset($query_params[0]) ? array($query_params[0]) : array();
789 789
 			$results = $questionGroupModel->count($where);
790
-		}else{
790
+		} else {
791 791
 			$results = $questionGroupModel->get_all($query_params);
792 792
 		}
793 793
 		return $results;
@@ -801,14 +801,14 @@  discard block
 block discarded – undo
801 801
 	 * @param bool $count
802 802
 	 * @return \EE_Soft_Delete_Base_Class[]|int
803 803
 	 */
804
-	public function get_trashed_question_groups( $per_page, $current_page = 1, $count = FALSE ) {
805
-		$questionGroupModel=EEM_Question_Group::instance();
806
-		$query_params=$this->get_query_params($questionGroupModel,$per_page,$current_page);
807
-		if($count){
808
-			$where = isset( $query_params[0] ) ? array($query_params[0]) : array();
804
+	public function get_trashed_question_groups($per_page, $current_page = 1, $count = FALSE) {
805
+		$questionGroupModel = EEM_Question_Group::instance();
806
+		$query_params = $this->get_query_params($questionGroupModel, $per_page, $current_page);
807
+		if ($count) {
808
+			$where = isset($query_params[0]) ? array($query_params[0]) : array();
809 809
 			$query_params['limit'] = NULL;
810 810
 			$results = $questionGroupModel->count_deleted($where);
811
-		}else{
811
+		} else {
812 812
 			$results = $questionGroupModel->get_all_deleted($query_params);
813 813
 		}
814 814
 		return $results;
@@ -821,32 +821,32 @@  discard block
 block discarded – undo
821 821
 	 */
822 822
 	public function update_question_group_order() {
823 823
 
824
-		$success = esc_html__( 'Question group order was updated successfully.', 'event_espresso' );
824
+		$success = esc_html__('Question group order was updated successfully.', 'event_espresso');
825 825
 
826 826
 		// grab our row IDs
827
-		$row_ids = isset( $this->_req_data['row_ids'] ) && ! empty( $this->_req_data['row_ids'] )
828
-			? explode( ',', rtrim( $this->_req_data['row_ids'], ',' ))
827
+		$row_ids = isset($this->_req_data['row_ids']) && ! empty($this->_req_data['row_ids'])
828
+			? explode(',', rtrim($this->_req_data['row_ids'], ','))
829 829
 			: array();
830 830
 
831
-		$perpage = !empty( $this->_req_data['perpage'] )
831
+		$perpage = ! empty($this->_req_data['perpage'])
832 832
 			? (int) $this->_req_data['perpage']
833 833
 			: NULL;
834
-		$curpage = !empty( $this->_req_data['curpage'] )
834
+		$curpage = ! empty($this->_req_data['curpage'])
835 835
 			? (int) $this->_req_data['curpage']
836 836
 			: NULL;
837 837
 
838
-		if ( ! empty( $row_ids ) ) {
838
+		if ( ! empty($row_ids)) {
839 839
 			//figure out where we start the row_id count at for the current page.
840
-			$qsgcount = empty( $curpage ) ? 0 : ($curpage - 1 ) * $perpage;
840
+			$qsgcount = empty($curpage) ? 0 : ($curpage - 1) * $perpage;
841 841
 
842
-			$row_count = count( $row_ids );
843
-			for( $i = 0; $i < $row_count; $i++ ) {
842
+			$row_count = count($row_ids);
843
+			for ($i = 0; $i < $row_count; $i++) {
844 844
 				//Update the questions when re-ordering
845 845
 				$updated = EEM_Question_Group::instance()->update(
846
-					array( 'QSG_order' => $qsgcount ),
847
-					array( array( 'QSG_ID' => $row_ids[ $i ] ) )
846
+					array('QSG_order' => $qsgcount),
847
+					array(array('QSG_ID' => $row_ids[$i]))
848 848
 				);
849
-				if ( $updated === false ) {
849
+				if ($updated === false) {
850 850
 					$success = false;
851 851
 				}
852 852
 				$qsgcount++;
@@ -856,10 +856,10 @@  discard block
 block discarded – undo
856 856
 		}
857 857
 
858 858
 		$errors = ! $success
859
-			? esc_html__( 'An error occurred. The question group order was not updated.', 'event_espresso' )
859
+			? esc_html__('An error occurred. The question group order was not updated.', 'event_espresso')
860 860
 			: false;
861 861
 
862
-		echo json_encode( array( 'return_data' => false, 'success' => $success, 'errors' => $errors ));
862
+		echo json_encode(array('return_data' => false, 'success' => $success, 'errors' => $errors));
863 863
 		die();
864 864
 
865 865
 	}
@@ -878,17 +878,17 @@  discard block
 block discarded – undo
878 878
 		$this->_template_args['values'] = $this->_yes_no_values;
879 879
 		add_action(
880 880
 			'AHEE__Extend_Registration_Form_Admin_Page___reg_form_settings_template',
881
-			array( $this, 'email_validation_settings_form' ),
881
+			array($this, 'email_validation_settings_form'),
882 882
 			2
883 883
 		);
884
-		$this->_template_args = (array)apply_filters(
884
+		$this->_template_args = (array) apply_filters(
885 885
 			'FHEE__Extend_Registration_Form_Admin_Page___reg_form_settings___template_args',
886 886
 			$this->_template_args
887 887
 		);
888
-		$this->_set_add_edit_form_tags( 'update_reg_form_settings' );
889
-		$this->_set_publish_post_box_vars( NULL, FALSE, FALSE, NULL, FALSE );
888
+		$this->_set_add_edit_form_tags('update_reg_form_settings');
889
+		$this->_set_publish_post_box_vars(NULL, FALSE, FALSE, NULL, FALSE);
890 890
 		$this->_template_args['admin_page_content'] = EEH_Template::display_template(
891
-			REGISTRATION_FORM_CAF_TEMPLATE_PATH . 'reg_form_settings.template.php',
891
+			REGISTRATION_FORM_CAF_TEMPLATE_PATH.'reg_form_settings.template.php',
892 892
 			$this->_template_args,
893 893
 			TRUE
894 894
 		);
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
 			EE_Registry::instance()->CFG,
910 910
 			__FILE__, __FUNCTION__, __LINE__
911 911
 		);
912
-		$this->_redirect_after_action( $success, esc_html__('Registration Form Options', 'event_espresso'), 'updated', array( 'action' => 'view_reg_form_settings' ) );
912
+		$this->_redirect_after_action($success, esc_html__('Registration Form Options', 'event_espresso'), 'updated', array('action' => 'view_reg_form_settings'));
913 913
 	}
914 914
 
915 915
 
@@ -940,20 +940,20 @@  discard block
 block discarded – undo
940 940
 				'layout_strategy' => new EE_Admin_Two_Column_Layout(),
941 941
 				'subsections'     => array(
942 942
 					'email_validation_hdr'           => new EE_Form_Section_HTML(
943
-						EEH_HTML::h2( esc_html__( 'Email Validation Settings', 'event_espresso' ) )
943
+						EEH_HTML::h2(esc_html__('Email Validation Settings', 'event_espresso'))
944 944
 					),
945 945
 					'email_validation_level' => new EE_Select_Input(
946 946
 						array(
947
-							'basic'      => esc_html__( 'Basic', 'event_espresso' ),
948
-							'wp_default' => esc_html__( 'WordPress Default', 'event_espresso' ),
949
-							'i18n'       => esc_html__( 'International', 'event_espresso' ),
950
-							'i18n_dns'   => esc_html__( 'International + DNS Check', 'event_espresso' ),
947
+							'basic'      => esc_html__('Basic', 'event_espresso'),
948
+							'wp_default' => esc_html__('WordPress Default', 'event_espresso'),
949
+							'i18n'       => esc_html__('International', 'event_espresso'),
950
+							'i18n_dns'   => esc_html__('International + DNS Check', 'event_espresso'),
951 951
 						),
952 952
 						array(
953
-							'html_label_text' => esc_html__( 'Email Validation Level', 'event_espresso' )
954
-							                     . EEH_Template::get_help_tab_link( 'email_validation_info' ),
955
-							'html_help_text'  => esc_html__( 'These levels range from basic validation ( ie: [email protected] ) to more advanced checks against international email addresses (ie: üñîçøðé@example.com ) with additional MX and A record checks to confirm the domain actually exists. More information on on each level can be found within the help section.', 'event_espresso'),
956
-							'default' => isset( EE_Registry::instance()->CFG->registration->email_validation_level )
953
+							'html_label_text' => esc_html__('Email Validation Level', 'event_espresso')
954
+							                     . EEH_Template::get_help_tab_link('email_validation_info'),
955
+							'html_help_text'  => esc_html__('These levels range from basic validation ( ie: [email protected] ) to more advanced checks against international email addresses (ie: üñîçøðé@example.com ) with additional MX and A record checks to confirm the domain actually exists. More information on on each level can be found within the help section.', 'event_espresso'),
956
+							'default' => isset(EE_Registry::instance()->CFG->registration->email_validation_level)
957 957
 								? EE_Registry::instance()->CFG->registration->email_validation_level
958 958
 								: 'wp_default',
959 959
 							'required'        => false
@@ -972,25 +972,25 @@  discard block
 block discarded – undo
972 972
 	 * @param \EE_Registration_Config $EE_Registration_Config
973 973
 	 * @return \EE_Registration_Config
974 974
 	 */
975
-	public function update_email_validation_settings_form( EE_Registration_Config $EE_Registration_Config ) {
975
+	public function update_email_validation_settings_form(EE_Registration_Config $EE_Registration_Config) {
976 976
         $prev_email_validation_level = $EE_Registration_Config->email_validation_level;
977 977
         try {
978 978
 			$email_validation_settings_form = $this->_email_validation_settings_form();
979 979
 			// if not displaying a form, then check for form submission
980
-			if ( $email_validation_settings_form->was_submitted() ) {
980
+			if ($email_validation_settings_form->was_submitted()) {
981 981
 				// capture form data
982 982
 				$email_validation_settings_form->receive_form_submission();
983 983
 				// validate form data
984
-				if ( $email_validation_settings_form->is_valid() ) {
984
+				if ($email_validation_settings_form->is_valid()) {
985 985
 					// grab validated data from form
986 986
 					$valid_data = $email_validation_settings_form->valid_data();
987
-					if ( isset( $valid_data['email_validation_level'] ) ) {
987
+					if (isset($valid_data['email_validation_level'])) {
988 988
 					    $email_validation_level = $valid_data['email_validation_level'];
989 989
                         // now if they want to use international email addresses
990
-                        if ( $email_validation_level === 'i18n' || $email_validation_level === 'i18n_dns' ) {
990
+                        if ($email_validation_level === 'i18n' || $email_validation_level === 'i18n_dns') {
991 991
                             // in case we need to reset their email validation level,
992 992
                             // make sure that the previous value wasn't already set to one of the i18n options.
993
-                            if ( $prev_email_validation_level === 'i18n' || $prev_email_validation_level === 'i18n_dns' ) {
993
+                            if ($prev_email_validation_level === 'i18n' || $prev_email_validation_level === 'i18n_dns') {
994 994
                                 // if so, then reset it back to "basic" since that is the only other option that,
995 995
                                 // despite offering poor validation, supports i18n email addresses
996 996
                                 $prev_email_validation_level = 'basic';
@@ -1012,7 +1012,7 @@  discard block
 block discarded – undo
1012 1012
                         );
1013 1013
 					}
1014 1014
 				} else {
1015
-					if ( $email_validation_settings_form->submission_error_message() !== '' ) {
1015
+					if ($email_validation_settings_form->submission_error_message() !== '') {
1016 1016
 						EE_Error::add_error(
1017 1017
 							$email_validation_settings_form->submission_error_message(),
1018 1018
                             __FILE__, __FUNCTION__, __LINE__
@@ -1020,7 +1020,7 @@  discard block
 block discarded – undo
1020 1020
 					}
1021 1021
 				}
1022 1022
 			}
1023
-		} catch ( EE_Error $e ) {
1023
+		} catch (EE_Error $e) {
1024 1024
 			$e->get_error();
1025 1025
 		}
1026 1026
 		return $EE_Registration_Config;
Please login to merge, or discard this patch.