Completed
Branch BUG-9804-double-click-spco-sub... (c2cac1)
by
unknown
51:40 queued 26:35
created
core/db_models/fields/EE_WP_Post_Status_Field.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once( EE_MODELS . 'fields/EE_Enum_Text_Field.php' );
3
-class EE_WP_Post_Status_Field extends EE_Enum_Text_Field{
2
+require_once(EE_MODELS.'fields/EE_Enum_Text_Field.php');
3
+class EE_WP_Post_Status_Field extends EE_Enum_Text_Field {
4 4
 
5 5
 	protected $_wp_post_stati;
6 6
 
@@ -28,8 +28,8 @@  discard block
 block discarded – undo
28 28
 	 * @link http://codex.wordpress.org/Function_Reference/register_post_status for more info
29 29
 	 * @param boolean $store_in_db_as_int By default, enums are stored as STRINGS in the DB. However, if this var is set to true, it will be stored as an INT
30 30
 	 */
31
-	function __construct($table_column, $nicename, $nullable, $default_value, $new_stati = array()){
32
-		$this->_register_new_stati( $new_stati );
31
+	function __construct($table_column, $nicename, $nullable, $default_value, $new_stati = array()) {
32
+		$this->_register_new_stati($new_stati);
33 33
 		$this->_set_allowed_enum_values();
34 34
 		parent::__construct($table_column, $nicename, $nullable, $default_value, $this->_allowed_enum_values);
35 35
 	}
@@ -46,18 +46,18 @@  discard block
 block discarded – undo
46 46
 	 * @param  array $new_stati statuses
47 47
 	 * @return void
48 48
 	 */
49
-	protected function _register_new_stati( $new_stati ) {
49
+	protected function _register_new_stati($new_stati) {
50 50
 
51
-		foreach ( (array) $new_stati as $status_key => $status_args ) {
51
+		foreach ((array) $new_stati as $status_key => $status_args) {
52 52
 			$args = array(
53
-				'label' => isset( $status_args['label'] ) ? $status_args['label'] : $status_key,
54
-				'public' => isset( $status_args['public'] ) && is_bool( $status_args['public'] ) ? $status_args['public'] : TRUE,
55
-				'exclude_from_search' => isset( $status_args['exclude_from_search'] ) && is_bool($status_args['exclude_from_search'] ) ? $status_args['exclude_from_search'] : FALSE,
56
-				'show_in_admin_all_list' => isset( $status_args['show_in_admin_all_list'] ) && is_bool( $status_args['show_in_admin_all_list'] ) ? $status_args['show_in_admin_all_list'] : FALSE,
57
-				'show_in_admin_status_list' =>  isset( $status_args['show_in_admin_status_list'] ) && is_bool( $status_args['show_in_admin_status_list'] ) ? $status_args['show_in_admin_status_list'] : TRUE,
58
-				'label_count' => isset( $status_args['label_count'] ) ? $status_args['label_count'] : ''
53
+				'label' => isset($status_args['label']) ? $status_args['label'] : $status_key,
54
+				'public' => isset($status_args['public']) && is_bool($status_args['public']) ? $status_args['public'] : TRUE,
55
+				'exclude_from_search' => isset($status_args['exclude_from_search']) && is_bool($status_args['exclude_from_search']) ? $status_args['exclude_from_search'] : FALSE,
56
+				'show_in_admin_all_list' => isset($status_args['show_in_admin_all_list']) && is_bool($status_args['show_in_admin_all_list']) ? $status_args['show_in_admin_all_list'] : FALSE,
57
+				'show_in_admin_status_list' =>  isset($status_args['show_in_admin_status_list']) && is_bool($status_args['show_in_admin_status_list']) ? $status_args['show_in_admin_status_list'] : TRUE,
58
+				'label_count' => isset($status_args['label_count']) ? $status_args['label_count'] : ''
59 59
 				);
60
-			register_post_status( $status_key, $status_args );
60
+			register_post_status($status_key, $status_args);
61 61
 		}
62 62
 
63 63
 	}
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 		global $wp_post_statuses;
79 79
 		$this->_wp_post_stati = $wp_post_statuses;
80 80
 
81
-		foreach( $this->_wp_post_stati  as $post_status => $args_object ) {
81
+		foreach ($this->_wp_post_stati  as $post_status => $args_object) {
82 82
 			$this->_allowed_enum_values[$post_status] = $args_object->label;
83 83
 		}
84 84
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * @param  string $status What status object you want
109 109
 	 * @return std_object         the status object or FALSE if it doesn't exist.
110 110
 	 */
111
-	public function get_status_object( $status ) {
112
-		return isset( $this->_wp_post_stati[$status] ) ? $this->_wp_post_stati[$status] : FALSE;
111
+	public function get_status_object($status) {
112
+		return isset($this->_wp_post_stati[$status]) ? $this->_wp_post_stati[$status] : FALSE;
113 113
 	}
114 114
 }
115 115
\ No newline at end of file
Please login to merge, or discard this patch.
core/db_models/fields/EE_WP_Post_Type_Field.php.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,13 +2,13 @@
 block discarded – undo
2 2
 /**
3 3
  * For CPT models who have a post type field
4 4
  */
5
-class EE_WP_Post_Type_Field extends EE_DB_Only_Text_Field{
5
+class EE_WP_Post_Type_Field extends EE_DB_Only_Text_Field {
6 6
 	/**
7 7
 	 * 
8 8
 	 * @param string $post_type the exact string to be used for the post type
9 9
 	 * of all these post type model objects/rows
10 10
 	 */
11
-	function __construct($post_type){
11
+	function __construct($post_type) {
12 12
 		parent::__construct('post_type', __("Post Type", 'event_espresso'), false, $post_type);
13 13
 	}
14 14
 }
15 15
\ No newline at end of file
Please login to merge, or discard this patch.
core/db_models/fields/EE_WP_User_Field.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
  *
26 26
  * ------------------------------------------------------------------------
27 27
  */
28
-class EE_WP_User_Field extends EE_Foreign_Key_Int_Field{
28
+class EE_WP_User_Field extends EE_Foreign_Key_Int_Field {
29 29
 	/**
30 30
 	 * No need to provide a default or the model pointed to- the default is
31 31
 	 * always get_current_user_id() and the model pointed to is always WP_User
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
33 33
 	 * @param string $nicename should eb internationalized with __('blah','event_espresso')
34 34
 	 * @param boolean $nullable
35 35
 	 */
36
-	function __construct($table_column, $nicename, $nullable){
37
-		parent::__construct($table_column, $nicename, $nullable, null, 'WP_User' );
36
+	function __construct($table_column, $nicename, $nullable) {
37
+		parent::__construct($table_column, $nicename, $nullable, null, 'WP_User');
38 38
 	}
39 39
 
40 40
 	/**
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
 	 * constructing the model field because that's done before $current_user is set
43 43
 	 * @return mixed
44 44
 	 */
45
-	function get_default_value(){
46
-		if( did_action( 'init' ) ) {
45
+	function get_default_value() {
46
+		if (did_action('init')) {
47 47
 			return get_current_user_id();
48
-		}else{
49
-			EE_Error::doing_it_wrong('EE_WP_User_Field::get_default_value', __( 'You cant get a default value for a wp_User_Field because the "init" action is called, because current_user global hasnt yet been setup. Consider doing your business logic on the "init" hook or later.', 'event_espresso' ), '4.6.20' );
48
+		} else {
49
+			EE_Error::doing_it_wrong('EE_WP_User_Field::get_default_value', __('You cant get a default value for a wp_User_Field because the "init" action is called, because current_user global hasnt yet been setup. Consider doing your business logic on the "init" hook or later.', 'event_espresso'), '4.6.20');
50 50
 			return 1;
51 51
 		}
52 52
 	}
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,6 @@  discard block
 block discarded – undo
1
-<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3
+}
2 4
 /**
3 5
  * Event Espresso
4 6
  *
@@ -45,7 +47,7 @@  discard block
 block discarded – undo
45 47
 	function get_default_value(){
46 48
 		if( did_action( 'init' ) ) {
47 49
 			return get_current_user_id();
48
-		}else{
50
+		} else{
49 51
 			EE_Error::doing_it_wrong('EE_WP_User_Field::get_default_value', __( 'You cant get a default value for a wp_User_Field because the "init" action is called, because current_user global hasnt yet been setup. Consider doing your business logic on the "init" hook or later.', 'event_espresso' ), '4.6.20' );
50 52
 			return 1;
51 53
 		}
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Index.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -4,18 +4,18 @@  discard block
 block discarded – undo
4 4
  * Parent class for indicating indexes on models. As of writing this, it is only used
5 5
  * when deleting model objects that have no primary key, but clearly this can be expanded
6 6
  */
7
-class EE_Index{
7
+class EE_Index {
8 8
 	protected $_name;
9 9
 	protected $_field_names;
10 10
 	protected $_model_name;
11
-	public function __construct($fields){
11
+	public function __construct($fields) {
12 12
 		$this->_field_names = $fields;
13 13
 	}
14
-	public function _construct_finalize($name,$model_name){
14
+	public function _construct_finalize($name, $model_name) {
15 15
 		$this->_name = $name;
16 16
 		$this->_model_name = $model_name;
17 17
 	}
18
-	public function field_names(){
18
+	public function field_names() {
19 19
 		return $this->_field_names;
20 20
 	}
21 21
 	/**
@@ -23,19 +23,19 @@  discard block
 block discarded – undo
23 23
 	 * @param string $model_name like Event, Question_Group, etc. omit the EEM_
24 24
 	 * @return EEM_Base
25 25
 	 */
26
-	protected function _get_model($model_name){
27
-		$modelInstance=call_user_func("EEM_".$model_name."::instance");
26
+	protected function _get_model($model_name) {
27
+		$modelInstance = call_user_func("EEM_".$model_name."::instance");
28 28
 		return $modelInstance;
29 29
 	}
30 30
 	/**
31 31
 	 * Gets all the fields for this index
32 32
 	 * @return EE_Model_Field_Base[]
33 33
 	 */
34
-	public function fields(){
34
+	public function fields() {
35 35
 		$fields = array();
36 36
 		$model = $this->_get_model($this->_model_name);
37
-		foreach($model->field_settings() as $field_name => $field_obj){
38
-			if(in_array($field_name,$this->field_names())){
37
+		foreach ($model->field_settings() as $field_name => $field_obj) {
38
+			if (in_array($field_name, $this->field_names())) {
39 39
 				$fields[$field_name] = $field_obj;
40 40
 			}
41 41
 		}
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Model_Parser.php 3 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php if ( ! defined('EVENT_ESPRESSO_VERSION'))
2 2
 	exit('No direct script access allowed');
3 3
 /**
4
- * EE_Model_Parser
5
- *
6
- * @package			Event Espresso
7
- * @subpackage
8
- * @author				Mike Nelson
9
- */
4
+	 * EE_Model_Parser
5
+	 *
6
+	 * @package			Event Espresso
7
+	 * @subpackage
8
+	 * @author				Mike Nelson
9
+	 */
10 10
 class EE_Model_Parser {
11 11
 	const table_alias_model_relation_chain_separator = '__';
12 12
 	const table_alias_model_relation_chain_prefix_end = '___';
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 * @param string $string_to_pad
21 21
 	 * @return string
22 22
 	 */
23
-	public static function pad_with_periods($string_to_pad){
23
+	public static function pad_with_periods($string_to_pad) {
24 24
 		return ".".$string_to_pad.".";
25 25
 	}
26 26
 	/**
@@ -28,8 +28,8 @@  discard block
 block discarded – undo
28 28
 	 * @param string $string_to_trim
29 29
 	 * @return string
30 30
 	 */
31
-	public static function trim_periods($string_to_trim){
32
-		return trim($string_to_trim,'.');
31
+	public static function trim_periods($string_to_trim) {
32
+		return trim($string_to_trim, '.');
33 33
 	}
34 34
 
35 35
 
@@ -40,22 +40,22 @@  discard block
 block discarded – undo
40 40
 	 * @param        $this_model_name
41 41
 	 * @return string which can be added onto table aliases to make them unique
42 42
 	 */
43
-	public static function extract_table_alias_model_relation_chain_prefix($model_relation_chain,$this_model_name){
43
+	public static function extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this_model_name) {
44 44
 		//eg $model_relation_chain = 'Venue.Event_Venue.Event.Registration", and $this_model_name = 'Event'
45 45
 		$model_relation_chain = self::pad_with_periods($model_relation_chain);
46 46
 		$this_model_name = self::pad_with_periods($this_model_name);
47 47
 		//eg '.Venue.Event_Venue.Event.Registration." and '.Event.'
48 48
 		//remove this model name and everything afterwards
49
-		$pos_of_model_name = strpos($model_relation_chain,$this_model_name);
50
-		$model_relation_chain = substr($model_relation_chain,0,$pos_of_model_name);
49
+		$pos_of_model_name = strpos($model_relation_chain, $this_model_name);
50
+		$model_relation_chain = substr($model_relation_chain, 0, $pos_of_model_name);
51 51
 		//eg '.Venue.Event_Venue.'
52 52
 		//trim periods
53 53
 		$model_relation_chain = self::trim_periods($model_relation_chain);
54 54
 		//eg 'Venue.Event_Venue'
55 55
 		//replace periods with double-underscores
56
-		$model_relation_chain = str_replace(".",self::table_alias_model_relation_chain_separator,$model_relation_chain);
56
+		$model_relation_chain = str_replace(".", self::table_alias_model_relation_chain_separator, $model_relation_chain);
57 57
 		//eg 'Venue__Event_Venue'
58
-		if($model_relation_chain !=''){
58
+		if ($model_relation_chain != '') {
59 59
 			$model_relation_chain = $model_relation_chain.self::table_alias_model_relation_chain_prefix_end;
60 60
 		}
61 61
 		//eg 'Venue_Event_Venue___'
@@ -66,14 +66,14 @@  discard block
 block discarded – undo
66 66
 	 * @param string $table_alias_with_model_relation_chain_prefix which CAN have a table alias model relation chain prefix (or not)
67 67
 	 * @return string
68 68
 	 */
69
-	public static function remove_table_alias_model_relation_chain_prefix($table_alias_with_model_relation_chain_prefix){
69
+	public static function remove_table_alias_model_relation_chain_prefix($table_alias_with_model_relation_chain_prefix) {
70 70
 		//does this actually have a table alias model relation chain prefix?
71
-		$pos = strpos($table_alias_with_model_relation_chain_prefix,self::table_alias_model_relation_chain_prefix_end);
72
-		if(  $pos !== FALSE){
71
+		$pos = strpos($table_alias_with_model_relation_chain_prefix, self::table_alias_model_relation_chain_prefix_end);
72
+		if ($pos !== FALSE) {
73 73
 			//yes
74 74
 			//find that triple underscore and remove it and everything before it
75 75
 			$table_alias = substr($table_alias_with_model_relation_chain_prefix, $pos + strlen(self::table_alias_model_relation_chain_prefix_end));
76
-		}else{
76
+		} else {
77 77
 			$table_alias = $table_alias_with_model_relation_chain_prefix;
78 78
 		}
79 79
 		return $table_alias;
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
 	 * @param string $table_alias_with_model_relation_chain_prefix
84 84
 	 * @return string
85 85
 	 */
86
-	public static function get_prefix_from_table_alias_with_model_relation_chain_prefix($table_alias_with_model_relation_chain_prefix){
86
+	public static function get_prefix_from_table_alias_with_model_relation_chain_prefix($table_alias_with_model_relation_chain_prefix) {
87 87
 		//does this actually have a table alias model relation chain prefix?
88
-		$pos = strpos($table_alias_with_model_relation_chain_prefix,self::table_alias_model_relation_chain_prefix_end);
89
-		if(  $pos !== FALSE){
88
+		$pos = strpos($table_alias_with_model_relation_chain_prefix, self::table_alias_model_relation_chain_prefix_end);
89
+		if ($pos !== FALSE) {
90 90
 			//yes
91 91
 			//find that triple underscore and remove it and everything before it
92 92
 			$prefix = substr($table_alias_with_model_relation_chain_prefix, 0, $pos + strlen(self::table_alias_model_relation_chain_prefix_end));
93
-		}else{
93
+		} else {
94 94
 			$prefix = '';
95 95
 		}
96 96
 		return $prefix;
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @param string $original_query_param
106 106
 	 * @return string
107 107
 	 */
108
-	public static function extract_table_alias_model_relation_chain_from_query_param($model_name, $original_query_param){
108
+	public static function extract_table_alias_model_relation_chain_from_query_param($model_name, $original_query_param) {
109 109
 		$relation_chain = self::extract_model_relation_chain($model_name, $original_query_param);
110 110
 		$table_alias_with_model_relation_chain_prefix = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($relation_chain, $model_name);
111 111
 		return $table_alias_with_model_relation_chain_prefix;
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	 * @param string $original_query_param
120 120
 	 * @return string
121 121
 	 */
122
-	public static function extract_model_relation_chain($model_name,$original_query_param){
122
+	public static function extract_model_relation_chain($model_name, $original_query_param) {
123 123
 		//prefix and postfix both with a period, as this facilitates searching
124 124
 		$model_name = EE_Model_Parser::pad_with_periods($model_name);
125 125
 		$original_query_param = EE_Model_Parser::pad_with_periods($original_query_param);
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 		//eg, if we're looking for the model relation chain from Event to Payment, the original query param is probably something like
128 128
 		//"Registration.Transaction.Payment.PAY_ID", $pos_of_model_string points to the 'P' or Payment. We want the string
129 129
 		//"Registration.Transaction.Payment"
130
-		$model_relation_chain = substr($original_query_param, 0,$pos_of_model_string+strlen($model_name));
130
+		$model_relation_chain = substr($original_query_param, 0, $pos_of_model_string + strlen($model_name));
131 131
 		return EE_Model_Parser::trim_periods($model_relation_chain);
132 132
 	}
133 133
 
@@ -142,11 +142,11 @@  discard block
 block discarded – undo
142 142
 	 * @param string $model_relation_chain
143 143
 	 * @return string
144 144
 	 */
145
-	public static function replace_model_name_with_join_model_name_in_model_relation_chain($model_name,$join_model_name,$model_relation_chain){
145
+	public static function replace_model_name_with_join_model_name_in_model_relation_chain($model_name, $join_model_name, $model_relation_chain) {
146 146
 		$model_name = EE_Model_Parser::pad_with_periods($model_name);
147 147
 		$join_model_name = EE_Model_Parser::pad_with_periods($join_model_name);
148 148
 		$model_relation_chain = EE_Model_Parser::pad_with_periods($model_relation_chain);
149
-		$replaced_with_periods = str_replace($model_name,$join_model_name,$model_relation_chain);
149
+		$replaced_with_periods = str_replace($model_name, $join_model_name, $model_relation_chain);
150 150
 		return EE_Model_Parser::trim_periods($replaced_with_periods);
151 151
 	}
152 152
 }
Please login to merge, or discard this patch.
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,5 +1,6 @@  discard block
 block discarded – undo
1
-<?php if ( ! defined('EVENT_ESPRESSO_VERSION'))
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2 2
 	exit('No direct script access allowed');
3
+}
3 4
 /**
4 5
  * EE_Model_Parser
5 6
  *
@@ -73,7 +74,7 @@  discard block
 block discarded – undo
73 74
 			//yes
74 75
 			//find that triple underscore and remove it and everything before it
75 76
 			$table_alias = substr($table_alias_with_model_relation_chain_prefix, $pos + strlen(self::table_alias_model_relation_chain_prefix_end));
76
-		}else{
77
+		} else{
77 78
 			$table_alias = $table_alias_with_model_relation_chain_prefix;
78 79
 		}
79 80
 		return $table_alias;
@@ -90,7 +91,7 @@  discard block
 block discarded – undo
90 91
 			//yes
91 92
 			//find that triple underscore and remove it and everything before it
92 93
 			$prefix = substr($table_alias_with_model_relation_chain_prefix, 0, $pos + strlen(self::table_alias_model_relation_chain_prefix_end));
93
-		}else{
94
+		} else{
94 95
 			$prefix = '';
95 96
 		}
96 97
 		return $prefix;
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Model_Query_Info_Carrier.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -11,8 +11,8 @@  discard block
 block discarded – undo
11 11
 */
12 12
 class EE_Model_Query_Info_Carrier extends EE_Base{
13 13
    /**
14
-	* @var string SQL for performing joins (Eg, "INNER JOIN blah ON blah=blah INNER JOIN FOO ON foo=foo...")
15
-	*/
14
+    * @var string SQL for performing joins (Eg, "INNER JOIN blah ON blah=blah INNER JOIN FOO ON foo=foo...")
15
+    */
16 16
    private $_join_sql;
17 17
    /**
18 18
     *
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     * @return string
133 133
     */
134 134
   public function get_main_model_join_sql() {
135
-    return $this->_main_join_sql;
135
+	return $this->_main_join_sql;
136 136
   }
137 137
 
138 138
 
Please login to merge, or discard this patch.
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 * We could have returned an array
10 10
 * with two keys 'join_sql' and 'data_types', but this better-defines the data being passed around
11 11
 */
12
-class EE_Model_Query_Info_Carrier extends EE_Base{
12
+class EE_Model_Query_Info_Carrier extends EE_Base {
13 13
    /**
14 14
 	* @var string SQL for performing joins (Eg, "INNER JOIN blah ON blah=blah INNER JOIN FOO ON foo=foo...")
15 15
 	*/
@@ -43,29 +43,29 @@  discard block
 block discarded – undo
43 43
    
44 44
    private $_group_by_sql;
45 45
    
46
-   function set_limit_sql($limit_sql){
46
+   function set_limit_sql($limit_sql) {
47 47
 	   $this->_limit_sql = $limit_sql;
48 48
 	}
49 49
 	
50
-	function set_order_by_sql($order_by_sql){
50
+	function set_order_by_sql($order_by_sql) {
51 51
 		$this->_order_by_sql = $order_by_sql;
52 52
 	}
53
-	function set_group_by_sql($group_by_sql){
53
+	function set_group_by_sql($group_by_sql) {
54 54
 		$this->_group_by_sql = $group_by_sql;
55 55
 	}
56
-	function set_having_sql($having_sql){
56
+	function set_having_sql($having_sql) {
57 57
 		$this->_having_sql = $having_sql;
58 58
 	}
59
-	function get_limit_sql(){
59
+	function get_limit_sql() {
60 60
 		return $this->_limit_sql;
61 61
 	}
62
-	function get_order_by_sql(){
62
+	function get_order_by_sql() {
63 63
 		return $this->_order_by_sql;
64 64
 	}
65
-	function get_group_by_sql(){
65
+	function get_group_by_sql() {
66 66
 		return $this->_group_by_sql;
67 67
 	}
68
-	function get_having_sql(){
68
+	function get_having_sql() {
69 69
 		return $this->_having_sql;
70 70
 	}
71 71
    /**
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     * @param type $join_sql
75 75
     * @param type $data_types
76 76
     */
77
-   public function __construct($model_included_name= array(), $join_sql = ''){
77
+   public function __construct($model_included_name = array(), $join_sql = '') {
78 78
 	   $this->_models_included = $model_included_name;
79 79
 	   $this->_join_sql = $join_sql;
80 80
    }
@@ -83,10 +83,10 @@  discard block
 block discarded – undo
83 83
     * Merges info from the other EEM_Related_Model_Info_Carrier into this one.
84 84
     * @param EE_Model_Query_Info_Carrier $other_model_query_info_carrier
85 85
     */
86
-   public function merge( $other_model_query_info_carrier ){
87
-	   if( $other_model_query_info_carrier && ! $this->_have_already_included_one_of_these_models($other_model_query_info_carrier->get_model_names_included())){
88
-			$model_included_on_other_join_sql_and_data_types_carrier =  $other_model_query_info_carrier->get_model_names_included();
89
-			$this->_models_included = array_merge( $this->_models_included, $model_included_on_other_join_sql_and_data_types_carrier );
86
+   public function merge($other_model_query_info_carrier) {
87
+	   if ($other_model_query_info_carrier && ! $this->_have_already_included_one_of_these_models($other_model_query_info_carrier->get_model_names_included())) {
88
+			$model_included_on_other_join_sql_and_data_types_carrier = $other_model_query_info_carrier->get_model_names_included();
89
+			$this->_models_included = array_merge($this->_models_included, $model_included_on_other_join_sql_and_data_types_carrier);
90 90
 			$this->_join_sql .= $other_model_query_info_carrier->_join_sql;
91 91
 	   }
92 92
 	   //otherwise don't merge our data.
@@ -100,9 +100,9 @@  discard block
 block discarded – undo
100 100
     * @param array $model_names just like EE_MOdel_QUery_Info_Carrier::_models_included: keys are model chain paths, values are the model names only
101 101
     * @return boolean
102 102
     */
103
-   protected function  _have_already_included_one_of_these_models($model_names){
104
-	   foreach($this->_models_included as $model_relation_path=>$model_included){
105
-		   if(array_key_exists($model_relation_path, $model_names)){
103
+   protected function  _have_already_included_one_of_these_models($model_names) {
104
+	   foreach ($this->_models_included as $model_relation_path=>$model_included) {
105
+		   if (array_key_exists($model_relation_path, $model_names)) {
106 106
 			   return true;
107 107
 		   }
108 108
 	   }
@@ -112,17 +112,17 @@  discard block
 block discarded – undo
112 112
     * Array keys are model names, values are "model relation paths". See EE_Model_Query_Info_Carrier::_models_included for details
113 113
     * @return array like EE_Model_Query_Info_Carrier::_models_included
114 114
     */
115
-   public function get_model_names_included(){
115
+   public function get_model_names_included() {
116 116
 	   return $this->_models_included;
117 117
    }
118 118
    /**
119 119
     * sets the $where_sql for later use from client code
120 120
     * @param string $where_sql
121 121
     */
122
-   public function set_where_sql($where_sql){
122
+   public function set_where_sql($where_sql) {
123 123
 	   $this->_where_sql = $where_sql;
124 124
    }
125
-   public function get_where_sql(){
125
+   public function get_where_sql() {
126 126
 	   return $this->_where_sql;
127 127
    }
128 128
 
@@ -143,10 +143,10 @@  discard block
 block discarded – undo
143 143
     * after the FROM and before the WHERE.)
144 144
     * @param string $join_sql
145 145
     */
146
-   public function set_main_model_join_sql($join_sql){
146
+   public function set_main_model_join_sql($join_sql) {
147 147
 	   $this->_main_join_sql = $join_sql;
148 148
    }
149
-   public function get_full_join_sql(){
150
-	   return $this->_main_join_sql . $this->_join_sql;
149
+   public function get_full_join_sql() {
150
+	   return $this->_main_join_sql.$this->_join_sql;
151 151
    }
152 152
 }
153 153
\ No newline at end of file
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Primary_Key_Index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * Used to indicate  a primary key index - ie, a set of fields which, when used in combination,
5 5
  * also uniquely identify a model object in the database (in case there is no primary key field).
6 6
  */
7
-class EE_Primary_Key_Index extends EE_Unique_Index{
7
+class EE_Primary_Key_Index extends EE_Unique_Index {
8 8
 	//yep, actually the same as unique index right now
9 9
 	
10 10
 }
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Primary_Table.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@  discard block
 block discarded – undo
4 4
  * For defining the main table of the model. This is the table with the model's primary key's field. So for CPT models, this will
5 5
  * probably be the wp_posts table (so the table name supplied will be 'posts', as the 'wp_' varies). For models only using one table, this will be that table.
6 6
  */
7
-require_once( EE_MODELS . 'helpers/EE_Table_Base.php');
8
-class EE_Primary_Table extends EE_Table_Base{
7
+require_once(EE_MODELS.'helpers/EE_Table_Base.php');
8
+class EE_Primary_Table extends EE_Table_Base {
9 9
 
10 10
 	/**
11 11
 	 *
@@ -15,14 +15,14 @@  discard block
 block discarded – undo
15 15
 	 * @param boolean $global whether the table is "global" as in there is only 1 table on an entire multisite install,
16 16
 	 *					or whether each site on a multisite install has a copy of this table
17 17
 	 */
18
-	function __construct($table_name, $pk_column = null, $global = false){
19
-		parent::__construct($table_name, $pk_column, $global );
18
+	function __construct($table_name, $pk_column = null, $global = false) {
19
+		parent::__construct($table_name, $pk_column, $global);
20 20
 	}
21 21
 	/**
22 22
 	 * Gets SQL for this table and assigning it an alias. Eg " wp_esp_attendee AS Attendee "
23 23
 	 * @return string
24 24
 	 */
25
-	function get_table_sql(){
25
+	function get_table_sql() {
26 26
 		return " ".$this->get_table_name()." AS ".$this->get_table_alias()." ";
27 27
 	}
28 28
 
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Secondary_Table.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@  discard block
 block discarded – undo
5 5
  * table's rows. Ie, it can't have many rows in the secondary table that point to
6 6
  * a single row in the primary table
7 7
  */
8
-require_once( EE_MODELS . 'helpers/EE_Table_Base.php');
9
-class EE_Secondary_Table extends EE_Table_Base{
8
+require_once(EE_MODELS.'helpers/EE_Table_Base.php');
9
+class EE_Secondary_Table extends EE_Table_Base {
10 10
 	protected $_extra_join_conditions;
11 11
 
12 12
 	/**
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
19 19
 	 * @param boolean $global whether the table is "global" as in there is only 1 table on an entire multisite install,
20 20
 	 *					or whether each site on a multisite install has a copy of this table
21 21
 	 */
22
-	function __construct($table_name, $pk_column,  $fk_column = null, $extra_join_conditions = null, $global = false ){
22
+	function __construct($table_name, $pk_column, $fk_column = null, $extra_join_conditions = null, $global = false) {
23 23
 		$this->_fk_on_table = $fk_column;
24 24
 		$this->_extra_join_conditions = $extra_join_conditions;
25
-		parent::__construct( $table_name, $pk_column, $global );
25
+		parent::__construct($table_name, $pk_column, $global);
26 26
 	}
27
-	function get_fk_on_table(){
27
+	function get_fk_on_table() {
28 28
 		return $this->_fk_on_table;
29 29
 	}
30
-	function _construct_finalize_set_table_to_join_with(EE_Table_Base $table){
30
+	function _construct_finalize_set_table_to_join_with(EE_Table_Base $table) {
31 31
 		$this->_table_to_join_with = $table;
32 32
 	}
33 33
 	/**
@@ -35,14 +35,14 @@  discard block
 block discarded – undo
35 35
 	 * @return string of sql like "Event.post_type = 'event'", which gets added to
36 36
 	 * the end of the join statement with the primary table
37 37
 	 */
38
-	function get_extra_join_conditions(){
38
+	function get_extra_join_conditions() {
39 39
 		return $this->_extra_join_conditions;
40 40
 	}
41 41
 	/**
42 42
 	 *
43 43
 	 * @return EE_Primary_Table
44 44
 	 */
45
-	function get_table_to_join_with(){
45
+	function get_table_to_join_with() {
46 46
 		return $this->_table_to_join_with;
47 47
 	}
48 48
 	/**
@@ -52,15 +52,15 @@  discard block
 block discarded – undo
52 52
 	 * @param string $table allows us to set special conditions on the $table_name portion of the join query (i.e. doing a subquery)
53 53
 	 * @return string of SQL
54 54
 	 */
55
-	function get_join_sql( $primary_table_alias_with_model_chain_prefix  ){
55
+	function get_join_sql($primary_table_alias_with_model_chain_prefix) {
56 56
 
57 57
 		$table_name = $this->get_table_name();
58
-		$secondary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($primary_table_alias_with_model_chain_prefix) . $this->get_table_alias();
58
+		$secondary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($primary_table_alias_with_model_chain_prefix).$this->get_table_alias();
59 59
 		$other_table_pk = $this->get_table_to_join_with()->get_pk_column();
60 60
 		$fk = $this->get_fk_on_table();
61 61
 		$join_sql = " LEFT JOIN $table_name AS $secondary_table_alias ON $primary_table_alias_with_model_chain_prefix.$other_table_pk = $secondary_table_alias.$fk ";
62
-		if($this->get_extra_join_conditions()){
63
-			$join_sql.="AND ".$this->get_extra_join_conditions();
62
+		if ($this->get_extra_join_conditions()) {
63
+			$join_sql .= "AND ".$this->get_extra_join_conditions();
64 64
 		}
65 65
 		return $join_sql;
66 66
 	}
@@ -74,14 +74,14 @@  discard block
 block discarded – undo
74 74
 	 * This is useful if the secondary table is already included in the SQL, but the primary table is not yet.
75 75
 	 * @return string
76 76
 	 */
77
-	function get_inverse_join_sql($secondary_table_alias_with_model_chain_prefix){
78
-		$primary_table_name =$this->get_table_to_join_with()->get_table_name();
79
-		$primary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($secondary_table_alias_with_model_chain_prefix) . $this->get_table_to_join_with()->get_table_alias();
80
-		$primary_table_pk = $this->get_table_to_join_with()->get_pk_column();//$this->get_pk_column();
77
+	function get_inverse_join_sql($secondary_table_alias_with_model_chain_prefix) {
78
+		$primary_table_name = $this->get_table_to_join_with()->get_table_name();
79
+		$primary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($secondary_table_alias_with_model_chain_prefix).$this->get_table_to_join_with()->get_table_alias();
80
+		$primary_table_pk = $this->get_table_to_join_with()->get_pk_column(); //$this->get_pk_column();
81 81
 		$fk = $this->get_fk_on_table();
82 82
 		$join_sql = " LEFT JOIN $primary_table_name AS $primary_table_alias ON $primary_table_alias.$primary_table_pk = $secondary_table_alias_with_model_chain_prefix.$fk ";
83
-		if($this->get_extra_join_conditions()){
84
-			$join_sql.="AND ".$this->get_extra_join_conditions();
83
+		if ($this->get_extra_join_conditions()) {
84
+			$join_sql .= "AND ".$this->get_extra_join_conditions();
85 85
 		}
86 86
 		return $join_sql;
87 87
 	}
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	public function get_select_join_limit_join($limit) {
95 95
 		//first get the select
96 96
 		$select = $this->get_select_join_limit($limit);
97
-		$join_sql = $this->get_join_sql( $select );
97
+		$join_sql = $this->get_join_sql($select);
98 98
 		return $join_sql;
99 99
 	}
100 100
 
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
 	function get_fully_qualified_fk_column() {
104 104
 		$table_alias = $this->get_table_alias();
105 105
 		$fk = $this->get_fk_on_table();
106
-		return $table_alias . '.' . $fk;
106
+		return $table_alias.'.'.$fk;
107 107
 	}
108 108
 
109 109
 	function get_fully_qualified_pk_on_fk_table() {
110 110
 		$table_alias = $this->get_table_to_join_with()->get_table_alias();
111 111
 		$pk = $this->get_table_to_join_with()->get_pk_column();
112
-		return $table_alias . '.' . $pk;
112
+		return $table_alias.'.'.$pk;
113 113
 	}
114 114
 }
115 115
\ No newline at end of file
Please login to merge, or discard this patch.