Completed
Branch BETA-4.9-messages-queue-fixed (941081)
by
unknown
30:24 queued 05:56
created
core/db_models/relations/EE_HABTM_Any_Relation.php 3 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 	/**
33 33
 	 * 
34 34
 	 * @param string $model_name
35
-	 * @param string $comparison_model_name
36 35
 	 * @param string $id_or_name_field should be the string 'ID' or 'name' only
37 36
 	 * @return EE_Model_Field_Base
38 37
 	 */
Please login to merge, or discard this patch.
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * Joins any two models together via a has-and-belongs-to-many relation, using 
4 4
  * the esp_extra_join table.
5 5
  */
6
-class EE_HABTM_Any_Relation extends EE_HABTM_Relation{	
6
+class EE_HABTM_Any_Relation extends EE_HABTM_Relation {	
7 7
 	/**
8 8
 	 *
9 9
 	 * @var string
@@ -17,16 +17,16 @@  discard block
 block discarded – undo
17 17
 	 * @param boolean $block_deletes for this type of relation, we block by default for now. if there are related models across this relation, block (prevent and add an error) the deletion of this model
18 18
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
19 19
 	 */
20
-	function __construct( $block_deletes = true, $blocking_delete_error_message =''){
21
-		parent::__construct( 'Extra_Join', $block_deletes, $blocking_delete_error_message);
20
+	function __construct($block_deletes = true, $blocking_delete_error_message = '') {
21
+		parent::__construct('Extra_Join', $block_deletes, $blocking_delete_error_message);
22 22
 	}
23
-	function _construct_finalize_set_models($this_model_name, $other_model_name){
24
-		if( $this_model_name < $other_model_name ) {
23
+	function _construct_finalize_set_models($this_model_name, $other_model_name) {
24
+		if ($this_model_name < $other_model_name) {
25 25
 			$this->_alphabetically_first_model_name = $this_model_name;
26
-		} else{
26
+		} else {
27 27
 			$this->_alphabetically_first_model_name = $other_model_name;
28 28
 		}
29
-		return parent::_construct_finalize_set_models( $this_model_name, $other_model_name );
29
+		return parent::_construct_finalize_set_models($this_model_name, $other_model_name);
30 30
 	}
31 31
 	
32 32
 	/**
@@ -36,21 +36,21 @@  discard block
 block discarded – undo
36 36
 	 * @param string $id_or_name_field should be the string 'ID' or 'name' only
37 37
 	 * @return EE_Model_Field_Base
38 38
 	 */
39
-	function get_join_table_fk_field_to( $model_name, $id_or_name_field ) {
39
+	function get_join_table_fk_field_to($model_name, $id_or_name_field) {
40 40
 		$order = null;
41
-		if( $model_name === $this->_alphabetically_first_model_name ) {
41
+		if ($model_name === $this->_alphabetically_first_model_name) {
42 42
 			$order = 'first';
43 43
 		} else {
44 44
 			$order = 'second';
45 45
 		}
46
-		return $this->get_join_model()->field_settings_for( 'EXJ_' . $order . '_model_' . $id_or_name_field );
46
+		return $this->get_join_model()->field_settings_for('EXJ_'.$order.'_model_'.$id_or_name_field);
47 47
 	}
48 48
 	/**
49 49
 	 * Gets the SQL string for joining the main model's table containing the pk to the join table. Eg "LEFT JOIN real_join_table AS join_table_alias ON this_table_alias.pk = join_table_alias.fk_to_this_table"
50 50
 	 * @param string $model_relation_chain like 'Event.Event_Venue.Venue'
51 51
 	 * @return string of SQL
52 52
 	 */
53
-	function get_join_to_intermediate_model_statement($model_relation_chain){
53
+	function get_join_to_intermediate_model_statement($model_relation_chain) {
54 54
 		//create sql like
55 55
 		//LEFT JOIN join_table AS join_table_alias ON this_table_alias.this_table_pk = join_table_alias.join_table_fk_to_this
56 56
 		//LEFT JOIN other_table AS other_table_alias ON join_table_alias.join_table_fk_to_other = other_table_alias.other_table_pk
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 		$field_with_model_name = $this->get_join_table_fk_field_to( 
65 65
 				$this->get_this_model()->get_this_model_name(), 
66 66
 				'name' );
67
-		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()) . $this_table_pk_field->get_table_alias();
68
-		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_join_model()->get_this_model_name()) . $join_table_fk_field_to_this_table->get_table_alias();
67
+		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_pk_field->get_table_alias();
68
+		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_join_model()->get_this_model_name()).$join_table_fk_field_to_this_table->get_table_alias();
69 69
 		$join_table = $this->get_join_model()->get_table_for_alias($join_table_alias);
70 70
 		//phew! ok, we have all the info we need, now we can create the SQL join string
71 71
 		$SQL = $this->_left_join(
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 					$join_table_fk_field_to_this_table->get_table_column(), 
75 75
 					$this_table_alias, 
76 76
 					$this_table_pk_field->get_table_column(),
77
-					$field_with_model_name->get_qualified_column()."='".$this->get_this_model()->get_this_model_name()."'" ) .
77
+					$field_with_model_name->get_qualified_column()."='".$this->get_this_model()->get_this_model_name()."'" ).
78 78
 				$this->get_join_model()->_construct_internal_join_to_table_with_alias($join_table_alias);
79 79
 
80 80
 		return $SQL;
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
 	 * @param string $model_relation_chain like 'Event.Event_Venue.Venue'
88 88
 	 * @return string of SQL
89 89
 	 */
90
-	function get_join_statement($model_relation_chain){
91
-		if( $this->_model_relation_chain_to_join_model === NULL ){
92
-			throw new EE_Error( sprintf( __( 'When using EE_HABTM_Relation to create a join, you must call get_join_to_intermediate_model_statement BEFORE get_join_statement', 'event_espresso' )));
90
+	function get_join_statement($model_relation_chain) {
91
+		if ($this->_model_relation_chain_to_join_model === NULL) {
92
+			throw new EE_Error(sprintf(__('When using EE_HABTM_Relation to create a join, you must call get_join_to_intermediate_model_statement BEFORE get_join_statement', 'event_espresso')));
93 93
 		}
94 94
 		$join_table_fk_field_to_this_table = $this->get_join_table_fk_field_to( 
95 95
 				$this->get_this_model()->get_this_model_name(), 
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
 				$this->get_other_model()->get_this_model_name(), 
102 102
 				'name' );
103 103
 		
104
-		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($this->_model_relation_chain_to_join_model, $this->get_join_model()->get_this_model_name()) . $join_table_fk_field_to_this_table->get_table_alias();
104
+		$join_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($this->_model_relation_chain_to_join_model, $this->get_join_model()->get_this_model_name()).$join_table_fk_field_to_this_table->get_table_alias();
105 105
 		
106 106
 		$other_table_pk_field = $this->get_other_model()->get_primary_key_field();
107
-		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_pk_field->get_table_alias();
107
+		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_pk_field->get_table_alias();
108 108
 		$other_table = $this->get_other_model()->get_table_for_alias($other_table_alias);
109 109
 
110 110
 		$SQL = $this->_left_join(
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 					$join_table_alias, 
115 115
 					$join_table_fk_field_to_other_table->get_table_column(),
116 116
 					$field_with_other_model_name->get_qualified_column()."='".$this->get_other_model()->get_this_model_name()."'" 
117
-				) . 
117
+				). 
118 118
 				$this->get_other_model()->_construct_internal_join_to_table_with_alias($other_table_alias);
119 119
 		return $SQL;
120 120
 	}
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 * @param array             $extra_join_model_fields_n_values col=>val pairs that are used as extra conditions for checking existing values and for setting new rows if no exact matches.
127 127
 	 * @return EE_Base_Class
128 128
 	 */
129
-	 function add_relation_to($this_obj_or_id, $other_obj_or_id, $extra_join_model_fields_n_values = array() ){
129
+	 function add_relation_to($this_obj_or_id, $other_obj_or_id, $extra_join_model_fields_n_values = array()) {
130 130
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
131 131
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
132 132
 		//check if such a relationship already exists
@@ -143,31 +143,31 @@  discard block
 block discarded – undo
143 143
 				$this->get_other_model()->get_this_model_name(),
144 144
 				'name' );
145 145
 
146
-		$cols_n_values =  array(
146
+		$cols_n_values = array(
147 147
 				$join_model_fk_to_this_model->get_name() => $this_model_obj->ID(),
148 148
 				$join_model_name_field_to_this_model->get_name() => $this_model_obj->get_model()->get_this_model_name(),
149 149
 				$join_model_fk_to_other_model->get_name() => $other_model_obj->ID(),
150 150
 				$join_model_name_field_to_other_model->get_name() => $other_model_obj->get_model()->get_this_model_name() );
151 151
 
152 152
 		//if $where_query exists lets add them to the query_params.
153
-		if ( !empty( $extra_join_model_fields_n_values ) ) {
153
+		if ( ! empty($extra_join_model_fields_n_values)) {
154 154
 		   //make sure we strip any of the join model names from the $where_query cause we don't need that in here (why? because client code may have used the same conditionals for get_all_related which DOES need the join model name)
155 155
 		   //make sure we strip THIS models name from the query param
156
-		   foreach ( $extra_join_model_fields_n_values as $query_param => $val ) {
157
-			   $query_param = str_replace($this->get_join_model()->get_this_model_name().".","", $query_param);
156
+		   foreach ($extra_join_model_fields_n_values as $query_param => $val) {
157
+			   $query_param = str_replace($this->get_join_model()->get_this_model_name().".", "", $query_param);
158 158
 			   $parsed_query[$query_param] = $val;
159 159
 		   }
160
-		   $cols_n_values = array_merge( $cols_n_values, $parsed_query );
160
+		   $cols_n_values = array_merge($cols_n_values, $parsed_query);
161 161
 		}
162 162
 
163
-		$query_params = array( $cols_n_values );
163
+		$query_params = array($cols_n_values);
164 164
 
165 165
 
166 166
 		$existing_entry_in_join_table = $this->get_join_model()->get_one($query_params);
167 167
 		//if there is already an entry in the join table, indicating a relationship, we're done
168 168
 		 //again, if you want more sophisticated logic or insertions (handling more columns than just 2 foreign keys to
169 169
 		 //the other tables, use the joining model directly!
170
-		if( ! $existing_entry_in_join_table ){
170
+		if ( ! $existing_entry_in_join_table) {
171 171
 			$this->get_join_model()->insert($cols_n_values);
172 172
 		}
173 173
 		return $other_model_obj;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 	 * * @param array           $where_query col=>val pairs that are used as extra conditions for checking existing values and for removing existing rows if exact matches exist.
180 180
 	 * @return EE_Base_Class
181 181
 	 */
182
-	 function remove_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array() ){
182
+	 function remove_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array()) {
183 183
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
184 184
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
185 185
 		//check if such a relationship already exists
@@ -196,24 +196,24 @@  discard block
 block discarded – undo
196 196
 				$this->get_other_model()->get_this_model_name(), 
197 197
 				'name' );
198 198
 
199
-		$cols_n_values =  array(
199
+		$cols_n_values = array(
200 200
 				$join_model_fk_to_this_model->get_name() => $this_model_obj->ID(),
201 201
 				$join_model_name_field_to_this_model->get_name() => $this_model_obj->get_model()->get_this_model_name(),
202 202
 				$join_model_fk_to_other_model->get_name() => $other_model_obj->ID(),
203 203
 				$join_model_name_field_to_other_model->get_name() => $other_model_obj->get_model()->get_this_model_name() );
204 204
 
205 205
 		//if $where_query exists lets add them to the query_params.
206
-		if ( !empty( $where_query ) ) {
206
+		if ( ! empty($where_query)) {
207 207
 		 	//make sure we strip any of the join model names from the $where_query cause we don't need that in here (why? because client code may have used the same conditionals for get_all_related which DOES need the join model name)
208 208
 		 	//make sure we strip THIS models name from the query param
209
-		 	foreach ( $where_query as $query_param => $val ) {
210
-				$query_param = str_replace($this->get_join_model()->get_this_model_name().".","", $query_param);
209
+		 	foreach ($where_query as $query_param => $val) {
210
+				$query_param = str_replace($this->get_join_model()->get_this_model_name().".", "", $query_param);
211 211
 				$parsed_query[$query_param] = $val;
212 212
 			}
213
-		 	$cols_n_values = array_merge( $cols_n_values, $parsed_query );
213
+		 	$cols_n_values = array_merge($cols_n_values, $parsed_query);
214 214
 		}
215 215
 
216
-		$existing_entry_in_join_table = $this->get_join_model()->delete( array($cols_n_values) );
216
+		$existing_entry_in_join_table = $this->get_join_model()->delete(array($cols_n_values));
217 217
 		return $other_model_obj;
218 218
 	 }
219 219
 }
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Joins any two models together via a has-and-belongs-to-many relation, using 
4
- * the esp_extra_join table.
5
- */
3
+	 * Joins any two models together via a has-and-belongs-to-many relation, using 
4
+	 * the esp_extra_join table.
5
+	 */
6 6
 class EE_HABTM_Any_Relation extends EE_HABTM_Relation{	
7 7
 	/**
8 8
 	 *
Please login to merge, or discard this patch.
core/db_models/relations/EE_Model_Relation_Base.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
 	/**
69 69
 	 * Gets the model where this relation is defined.
70
-	 * @return EEM_Base
70
+	 * @return boolean
71 71
 	 */
72 72
 	function get_this_model(){
73 73
 		return $this->_get_model($this->_this_model_name);
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	/**
79 79
 	 * Gets the model which this relation establishes the relation TO (ie,
80 80
 	 * this relation object was defined on get_this_model(), get_other_model() is the other one)
81
-	 * @return EEM_Base
81
+	 * @return boolean
82 82
 	 */
83 83
 	function get_other_model(){
84 84
 		return $this->_get_model($this->_other_model_name);
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	/**
90 90
 	 * Internally used by get_this_model() and get_other_model()
91 91
 	 * @param string $model_name like Event, Question_Group, etc. omit the EEM_
92
-	 * @return EEM_Base
92
+	 * @return boolean
93 93
 	 */
94 94
 	protected function _get_model($model_name){
95 95
 		$modelInstance = EE_Registry::instance()->load_model( $model_name );
@@ -112,9 +112,9 @@  discard block
 block discarded – undo
112 112
 
113 113
 	/**
114 114
 	 * @param        $other_table
115
-	 * @param        $other_table_alias
115
+	 * @param        string $other_table_alias
116 116
 	 * @param        $other_table_column
117
-	 * @param        $this_table_alias
117
+	 * @param        string $this_table_alias
118 118
 	 * @param        $this_table_join_column
119 119
 	 * @param string $extra_join_sql
120 120
 	 * @return string
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 	 * parameters are specified, then all related model objects will be deleted.
169 169
 	 * Note: If the related model is extends EEM_Soft_Delete_Base, then the related
170 170
 	 * model objects will only be soft-deleted.
171
-	 * @param EE_Base_Class|int|string $model_object_or_id
171
+	 * @param EE_Base_Class $model_object_or_id
172 172
 	 * @param array $query_params
173 173
 	 * @return int of how many related models got deleted
174 174
 	 */
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 	 * parameters are specified, then all related model objects will be deleted.
197 197
 	 * Note: If the related model is extends EEM_Soft_Delete_Base, then the related
198 198
 	 * model objects will only be soft-deleted.
199
-	 * @param EE_Base_Class|int|string $model_object_or_id
199
+	 * @param EE_Base_Class $model_object_or_id
200 200
 	 * @param array $query_params
201 201
 	 * @return int of how many related models got deleted
202 202
 	 */
Please login to merge, or discard this patch.
core/db_classes/EE_Extra_Join.class.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
 	 * @param null  $timezone
23 23
 	 * @return EE_Event_Message_Template|mixed
24 24
 	 */
25
-	public static function new_instance( $props_n_values = array(), $timezone = NULL ) {
26
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__, $timezone );
27
-		return $has_object ? $has_object : new self( $props_n_values, FALSE, $timezone );
25
+	public static function new_instance($props_n_values = array(), $timezone = NULL) {
26
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__, $timezone);
27
+		return $has_object ? $has_object : new self($props_n_values, FALSE, $timezone);
28 28
 	}
29 29
 
30 30
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
 	 * @param null  $timezone
35 35
 	 * @return EE_Event_Message_Template
36 36
 	 */
37
-	public static function new_instance_from_db ( $props_n_values = array(), $timezone = NULL ) {
38
-		return new self( $props_n_values, TRUE, $timezone );
37
+	public static function new_instance_from_db($props_n_values = array(), $timezone = NULL) {
38
+		return new self($props_n_values, TRUE, $timezone);
39 39
 	}
40 40
 
41 41
 }
Please login to merge, or discard this patch.
strategies/validation/EE_Max_Length_Validation_Strategy.strategy.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -8,36 +8,36 @@
 block discarded – undo
8 8
  * @subpackage	Expression package is undefined on line 19, column 19 in Templates/Scripting/PHPClass.php.
9 9
  * @author				Mike Nelson
10 10
  */
11
-class EE_Max_Length_Validation_Strategy extends EE_Validation_Strategy_Base{
11
+class EE_Max_Length_Validation_Strategy extends EE_Validation_Strategy_Base {
12 12
 
13 13
 	protected $_max_length;
14 14
 
15
-	public function __construct( $validation_error_message = NULL, $max_length = EE_INF ) {
15
+	public function __construct($validation_error_message = NULL, $max_length = EE_INF) {
16 16
 		$this->_max_length = $max_length;
17
-		if( $validation_error_message === null ) {
18
-			$validation_error_message = sprintf( __( 'Input is too long. Maximum number of characters is %1$s', 'event_espresso' ), $max_length );
17
+		if ($validation_error_message === null) {
18
+			$validation_error_message = sprintf(__('Input is too long. Maximum number of characters is %1$s', 'event_espresso'), $max_length);
19 19
 		}
20
-		parent::__construct( $validation_error_message );
20
+		parent::__construct($validation_error_message);
21 21
 	}
22 22
 
23 23
 	/**
24 24
 	 * @param $normalized_value
25 25
 	 */
26 26
 	public function validate($normalized_value) {
27
-		if( $this->_max_length !== EE_INF &&
27
+		if ($this->_max_length !== EE_INF &&
28 28
 				$normalized_value &&
29
-				is_string( $normalized_value ) &&
30
-				 strlen( $normalized_value ) > $this->_max_length){
31
-			throw new EE_Validation_Error( $this->get_validation_error_message(), 'maxlength' );
29
+				is_string($normalized_value) &&
30
+				 strlen($normalized_value) > $this->_max_length) {
31
+			throw new EE_Validation_Error($this->get_validation_error_message(), 'maxlength');
32 32
 		}
33 33
 	}
34 34
 
35 35
 	/**
36 36
 	 * @return array
37 37
 	 */
38
-	function get_jquery_validation_rule_array(){
39
-		if( $this->_max_length !== EE_INF ) {
40
-			return array( 'maxlength'=> $this->_max_length, 'messages' => array( 'maxlength' => $this->get_validation_error_message() ) );
38
+	function get_jquery_validation_rule_array() {
39
+		if ($this->_max_length !== EE_INF) {
40
+			return array('maxlength'=> $this->_max_length, 'messages' => array('maxlength' => $this->get_validation_error_message()));
41 41
 		} else {
42 42
 			return array();
43 43
 		}
Please login to merge, or discard this patch.
libraries/form_sections/payment_methods/EE_Payment_Method_Form.form.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
  * Specialized form for payment methods, allowing for easy setting and retrieving of meta fields.
5 5
  * Uses EEM_Payment_Method as the model
6 6
  */
7
-class EE_Payment_Method_Form extends EE_Model_Form_Section{
7
+class EE_Payment_Method_Form extends EE_Model_Form_Section {
8 8
 
9 9
 	/**
10 10
 	 * All the subsection inputs that correspond ot extra meta rows
@@ -39,37 +39,37 @@  discard block
 block discarded – undo
39 39
 	 *	@see EE_Model_Form_Section::__construct() for more
40 40
 	 * }
41 41
 	 */
42
-	public function __construct($options_array = array()){
42
+	public function __construct($options_array = array()) {
43 43
 		$this->_model = EEM_Payment_Method::instance();
44 44
 		$this->_options_array = $options_array;
45
-		if(isset($options_array['payment_method_type'])){
45
+		if (isset($options_array['payment_method_type'])) {
46 46
 			$this->_payment_method_type = $options_array['payment_method_type'];
47 47
 		}
48 48
 		$options_array = $this->_options_array;
49
-		if(isset($options_array['extra_meta_inputs'])){
50
-			$this->_extra_meta_inputs = array_merge($this->_extra_meta_inputs,$options_array['extra_meta_inputs']);
49
+		if (isset($options_array['extra_meta_inputs'])) {
50
+			$this->_extra_meta_inputs = array_merge($this->_extra_meta_inputs, $options_array['extra_meta_inputs']);
51 51
 		}
52
-		if($this->_extra_meta_inputs){
53
-			$this->_subsections = array_merge($this->_subsections,$this->_extra_meta_inputs);
52
+		if ($this->_extra_meta_inputs) {
53
+			$this->_subsections = array_merge($this->_subsections, $this->_extra_meta_inputs);
54 54
 		}
55 55
 		$this->_subsections['PMD_button_url'] = new EE_Admin_File_Uploader_Input(
56
-			array( 'html_label_text'=>  __( 'Button URL', 'event_espresso' ))
56
+			array('html_label_text'=>  __('Button URL', 'event_espresso'))
57 57
 		);
58 58
 		$this->_subsections['PMD_scope'] = new EE_Checkbox_Multi_Input(
59 59
 			EEM_Payment_Method::instance()->scopes(),
60
-			array( 'html_label_text' => $this->_model->field_settings_for('PMD_scope')->get_nicename() . EEH_Template::get_help_tab_link( 'payment_methods_overview' ))
60
+			array('html_label_text' => $this->_model->field_settings_for('PMD_scope')->get_nicename().EEH_Template::get_help_tab_link('payment_methods_overview'))
61 61
 		);
62 62
 		//setup the currency options
63 63
 		$this->_subsections['Currency'] = new EE_Select_Multi_Model_Input(
64
-			EEM_Currency::instance()->get_all_currencies_usable_by( $this->_payment_method_type ),
64
+			EEM_Currency::instance()->get_all_currencies_usable_by($this->_payment_method_type),
65 65
 			array(
66
-				'html_label_text'=>  __( 'Currencies Supported', 'event_espresso' ),
66
+				'html_label_text'=>  __('Currencies Supported', 'event_espresso'),
67 67
 				'required'=>TRUE
68 68
 			)
69 69
 		);
70
-		$this->_subsections['PMD_order'] = new EE_Text_Input( array(
71
-			'html_label_text' => __( 'Order', 'event_espresso' ),
72
-			'html_help_text' => __( 'Lowest numbers will be shown first', 'event_espresso' ),
70
+		$this->_subsections['PMD_order'] = new EE_Text_Input(array(
71
+			'html_label_text' => __('Order', 'event_espresso'),
72
+			'html_help_text' => __('Lowest numbers will be shown first', 'event_espresso'),
73 73
 			'normalization_strategy' => new EE_Int_Normalization(),
74 74
 			'validation_strategies' => array(
75 75
 				new EE_Int_Validation_Strategy()
@@ -88,15 +88,15 @@  discard block
 block discarded – undo
88 88
 	 * @param string 	$name
89 89
 	 * @throws EE_Error
90 90
 	 */
91
-	public function _construct_finalize( $parent_form_section, $name ) {
92
-		if( ! $this->_payment_method_type instanceof EE_PMT_Base ){
93
-			throw new EE_Error( sprintf( __( 'Payment Method forms must have set their payment method type BEFORE calling _construct_finalize', 'event_espresso' )));
91
+	public function _construct_finalize($parent_form_section, $name) {
92
+		if ( ! $this->_payment_method_type instanceof EE_PMT_Base) {
93
+			throw new EE_Error(sprintf(__('Payment Method forms must have set their payment method type BEFORE calling _construct_finalize', 'event_espresso')));
94 94
 		}
95 95
 		//set the name of this form based on the payment method type
96
-		if( ! $this->_name && ! $name ){
97
-			$name = str_replace(" ","_",ucwords(str_replace("_"," ",($this->_payment_method_type->system_name()))))."_Settings_Form";
96
+		if ( ! $this->_name && ! $name) {
97
+			$name = str_replace(" ", "_", ucwords(str_replace("_", " ", ($this->_payment_method_type->system_name()))))."_Settings_Form";
98 98
 		}
99
-		parent::_construct_finalize( $parent_form_section, $name );
99
+		parent::_construct_finalize($parent_form_section, $name);
100 100
 	}
101 101
 
102 102
 
@@ -105,8 +105,8 @@  discard block
 block discarded – undo
105 105
 	 * @param $payment_method_type
106 106
 	 * @throws EE_Error
107 107
 	 */
108
-	public function set_payment_method_type( $payment_method_type ){
109
-		if( ! $payment_method_type instanceof EE_PMT_Base){
108
+	public function set_payment_method_type($payment_method_type) {
109
+		if ( ! $payment_method_type instanceof EE_PMT_Base) {
110 110
 			throw new EE_Error(sprintf(__("Payment Method forms MUST set a payment method type by using _set_payment_method_type", "event_espresso")));
111 111
 		}
112 112
 		$this->_payment_method_type = $payment_method_type;
@@ -118,10 +118,10 @@  discard block
 block discarded – undo
118 118
 	 * extends the model form section's save method to also save the extra meta field values
119 119
 	 * @return int ID of the payment method inserted, or true on update
120 120
 	 */
121
-	public function save(){
121
+	public function save() {
122 122
 		$parent_save_val = parent::save();
123
-		if( $this->_model_object && $this->_model_object->ID()){
124
-			foreach($this->_extra_meta_inputs as $input_name => $input){
123
+		if ($this->_model_object && $this->_model_object->ID()) {
124
+			foreach ($this->_extra_meta_inputs as $input_name => $input) {
125 125
 				$this->_model_object->update_extra_meta($input_name, $input->normalized_value());
126 126
 			}
127 127
 		}
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
 		$model_obj = $this->_model->ensure_is_obj($model_obj);
139 139
 		parent::populate_model_obj($model_obj);
140 140
 		$extra_meta = $model_obj->all_extra_meta_array();
141
-		foreach($this->_extra_meta_inputs as $input_name => $extra_meta_input){
142
-			if(isset($extra_meta[$input_name])){
141
+		foreach ($this->_extra_meta_inputs as $input_name => $extra_meta_input) {
142
+			if (isset($extra_meta[$input_name])) {
143 143
 				$extra_meta_input->set_default($extra_meta[$input_name]);
144 144
 			}
145 145
 		}
@@ -151,10 +151,10 @@  discard block
 block discarded – undo
151 151
 	 * gets the default name of this form section if none is specified
152 152
 	 * @return string
153 153
 	 */
154
-	protected function _set_default_name_if_empty(){
155
-		if( ! $this->_name ){
156
-			$default_name = str_replace("EEM_", "", get_class($this->_model)) . "_Model_Form";
157
-			$this->_name =  $default_name;
154
+	protected function _set_default_name_if_empty() {
155
+		if ( ! $this->_name) {
156
+			$default_name = str_replace("EEM_", "", get_class($this->_model))."_Model_Form";
157
+			$this->_name = $default_name;
158 158
 		}
159 159
 	}
160 160
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * Gets all the extra meta inputs in this form
165 165
 	 * @return EE_Form_Input_Base[]
166 166
 	 */
167
-	public function extra_meta_inputs(){
167
+	public function extra_meta_inputs() {
168 168
 		return $this->_extra_meta_inputs;
169 169
 	}
170 170
 }
Please login to merge, or discard this patch.
admin_pages/registration_form/Registration_Form_Admin_Page.core.php 2 patches
Braces   +9 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,6 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if (!defined('EVENT_ESPRESSO_VERSION') )
2
+if (!defined('EVENT_ESPRESSO_VERSION') ) {
3 3
 	exit('NO direct script access allowed');
4
+}
4 5
 
5 6
 /**
6 7
  * Event Espresso
@@ -330,14 +331,9 @@  discard block
 block discarded – undo
330 331
 			else if ( $fieldName == 'QST_admin_label' && ( isset( $this->_req_data['QST_admin_label'] ) && empty( $this->_req_data['QST_admin_label'] )  )) {
331 332
 				$QST_text = isset( $this->_req_data['QST_display_text'] ) ? $this->_req_data['QST_display_text'] : '' ;
332 333
 				$set_column_values[$fieldName] = sanitize_title(wp_trim_words($QST_text,10));
333
-			}
334
-
335
-
336
-			else if ( $fieldName == 'QST_admin_only' && ( !isset( $this->_req_data['QST_admin_only'] ) ) ) {
334
+			} else if ( $fieldName == 'QST_admin_only' && ( !isset( $this->_req_data['QST_admin_only'] ) ) ) {
337 335
 				$set_column_values[$fieldName] = 0;
338
-			}
339
-
340
-			else if ( $fieldName == 'QST_max' ) {
336
+			} else if ( $fieldName == 'QST_max' ) {
341 337
 				$qst_system = EEM_Question::instance()->get_var(
342 338
 					array(
343 339
 						array(
@@ -390,7 +386,7 @@  discard block
 block discarded – undo
390 386
 			$question=$this->_question_model->get_one_by_ID($ID);
391 387
 			$additional_hidden_fields=array('QST_ID'=>array('type'=>'hidden','value'=>$ID));
392 388
 			$this->_set_add_edit_form_tags('update_question', $additional_hidden_fields);
393
-		}else{
389
+		} else{
394 390
 			$question= EE_Question::new_instance();
395 391
 			$question->set_order_to_latest();
396 392
 			$this->_set_add_edit_form_tags('insert_question');
@@ -421,7 +417,7 @@  discard block
 block discarded – undo
421 417
 			$ID=$this->_question_model->insert($set_column_values);
422 418
 			$success = $ID ? true : false;
423 419
 			$action_desc = 'added';
424
-		}else{
420
+		} else{
425 421
 			$ID=absint($this->_req_data['QST_ID']);
426 422
 			$pk=$this->_question_model->primary_key_name();
427 423
 			$wheres=array($pk=>$ID);
@@ -442,7 +438,7 @@  discard block
 block discarded – undo
442 438
 					$option_req_index=$this->_get_option_req_data_index($option_ID);
443 439
 					if($option_req_index!==FALSE){
444 440
 						$option->save($this->_req_data['question_options'][$option_req_index]);
445
-					}else{
441
+					} else{
446 442
 						//not found, remove it
447 443
 						$option->delete();
448 444
 					}
@@ -519,7 +515,7 @@  discard block
 block discarded – undo
519 515
 						'QSG_name'=>array('LIKE',"%$search_string%"),
520 516
 						'QSG_desc'=>array('LIKE',"%$search_string%"))
521 517
 					);
522
-			}else{
518
+			} else{
523 519
 				$query_params[0]=array(
524 520
 					'QST_display_text'=>array('LIKE',"%$search_string%")
525 521
 					);
@@ -575,7 +571,7 @@  discard block
 block discarded – undo
575 571
 		if ($count){
576 572
 			$where = isset( $query_params[0] ) ? array( $query_params[0] ) : array();
577 573
 			$results = $QST->count($where);
578
-		}else{
574
+		} else{
579 575
 			$results = $QST->get_all($query_params);
580 576
 		}
581 577
 		return $results;
Please login to merge, or discard this patch.
Spacing   +145 added lines, -145 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if (!defined('EVENT_ESPRESSO_VERSION') )
2
+if ( ! defined('EVENT_ESPRESSO_VERSION'))
3 3
 	exit('NO direct script access allowed');
4 4
 
5 5
 /**
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
 
59 59
 
60 60
 
61
-	public function __construct( $routing = TRUE ) {
62
-		require_once( EE_MODELS . 'EEM_Question.model.php' );
63
-		require_once( EE_MODELS . 'EEM_Question_Group.model.php' );
64
-		$this->_question_model=  EEM_Question::instance();
65
-		$this->_question_group_model=EEM_Question_Group::instance();
66
-		parent::__construct( $routing );
61
+	public function __construct($routing = TRUE) {
62
+		require_once(EE_MODELS.'EEM_Question.model.php');
63
+		require_once(EE_MODELS.'EEM_Question_Group.model.php');
64
+		$this->_question_model = EEM_Question::instance();
65
+		$this->_question_group_model = EEM_Question_Group::instance();
66
+		parent::__construct($routing);
67 67
 	}
68 68
 
69 69
 
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 
98 98
 
99 99
 	protected function _set_page_routes() {
100
-		$qst_id = ! empty( $this->_req_data['QST_ID'] ) ? $this->_req_data['QST_ID'] : 0;
100
+		$qst_id = ! empty($this->_req_data['QST_ID']) ? $this->_req_data['QST_ID'] : 0;
101 101
 		$this->_page_routes = array(
102 102
 			'default' => array(
103 103
 				'func' => '_questions_overview_list_table',
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 			'update_question' => array(
120 120
 				'func' => '_insert_or_update_question',
121
-				'args' => array('new_question' => FALSE ),
121
+				'args' => array('new_question' => FALSE),
122 122
 				'capability' => 'ee_edit_question',
123 123
 				'obj_id' => $qst_id,
124 124
 				'noheader' => TRUE,
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 						'filename' => 'registration_form_questions_overview_views_bulk_actions_search'
154 154
 						)
155 155
 					),
156
-				'help_tour' => array( 'Registration_Form_Questions_Overview_Help_Tour'),
156
+				'help_tour' => array('Registration_Form_Questions_Overview_Help_Tour'),
157 157
 				'require_nonce' => FALSE,
158 158
 				'qtips' => array(
159 159
 					'EE_Registration_Form_Tips'
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 						'filename' => 'registration_form_question_groups'
173 173
 						),
174 174
 					),
175
-				'help_tour' => array( 'Registration_Form_Question_Groups_Help_Tour'),
175
+				'help_tour' => array('Registration_Form_Question_Groups_Help_Tour'),
176 176
 				'require_nonce' => FALSE
177 177
 				),
178 178
 
@@ -181,16 +181,16 @@  discard block
 block discarded – undo
181 181
 					'label' => __('Edit Question', 'event_espresso'),
182 182
 					'order' => 15,
183 183
 					'persistent' => FALSE,
184
-					'url' => isset($this->_req_data['question_id']) ? add_query_arg(array('question_id' => $this->_req_data['question_id'] ), $this->_current_page_view_url )  : $this->_admin_base_url
184
+					'url' => isset($this->_req_data['question_id']) ? add_query_arg(array('question_id' => $this->_req_data['question_id']), $this->_current_page_view_url) : $this->_admin_base_url
185 185
 					),
186
-				'metaboxes' => array_merge( $this->_default_espresso_metaboxes, array('_publish_post_box' ) ),
186
+				'metaboxes' => array_merge($this->_default_espresso_metaboxes, array('_publish_post_box')),
187 187
 				'help_tabs' => array(
188 188
 					'registration_form_edit_question_group_help_tab' => array(
189 189
 						'title' => __('Edit Question', 'event_espresso'),
190 190
 						'filename' => 'registration_form_edit_question'
191 191
 						),
192 192
 					),
193
-                'help_tour' => array( 'Registration_Form_Edit_Question_Help_Tour'),
193
+                'help_tour' => array('Registration_Form_Edit_Question_Help_Tour'),
194 194
 				'require_nonce' => FALSE
195 195
 				),
196 196
 			);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 	//none of the below group are currently used for Event Categories
219 219
 	protected function _add_feature_pointers() {}
220 220
 	public function load_scripts_styles() {
221
-		wp_register_style( 'espresso_registration', REGISTRATION_FORM_ASSETS_URL . 'espresso_registration_form_admin.css', array(), EVENT_ESPRESSO_VERSION );
221
+		wp_register_style('espresso_registration', REGISTRATION_FORM_ASSETS_URL.'espresso_registration_form_admin.css', array(), EVENT_ESPRESSO_VERSION);
222 222
 		wp_enqueue_style('espresso_registration');
223 223
 	}
224 224
 	public function admin_init() {}
@@ -234,20 +234,20 @@  discard block
 block discarded – undo
234 234
 
235 235
 	public function load_scripts_styles_add_question() {
236 236
 		$this->load_scripts_styles_forms();
237
-		wp_register_script( 'espresso_registration_form_single', REGISTRATION_FORM_ASSETS_URL . 'espresso_registration_form_admin.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, TRUE );
238
-		wp_enqueue_script( 'espresso_registration_form_single' );
237
+		wp_register_script('espresso_registration_form_single', REGISTRATION_FORM_ASSETS_URL.'espresso_registration_form_admin.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, TRUE);
238
+		wp_enqueue_script('espresso_registration_form_single');
239 239
 	}
240 240
 	public function load_scripts_styles_edit_question() {
241 241
 		$this->load_scripts_styles_forms();
242
-		wp_register_script( 'espresso_registration_form_single', REGISTRATION_FORM_ASSETS_URL . 'espresso_registration_form_admin.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, TRUE );
243
-		wp_enqueue_script( 'espresso_registration_form_single' );
242
+		wp_register_script('espresso_registration_form_single', REGISTRATION_FORM_ASSETS_URL.'espresso_registration_form_admin.js', array('jquery-ui-sortable'), EVENT_ESPRESSO_VERSION, TRUE);
243
+		wp_enqueue_script('espresso_registration_form_single');
244 244
 	}
245 245
 
246 246
 
247 247
 
248 248
 
249 249
 	public function recaptcha_info_help_tab() {
250
-		$template = REGISTRATION_FORM_TEMPLATE_PATH . 'recaptcha_info_help_tab.template.php';
250
+		$template = REGISTRATION_FORM_TEMPLATE_PATH.'recaptcha_info_help_tab.template.php';
251 251
 		EEH_Template::display_template($template, array());
252 252
 	}
253 253
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 				)
280 280
 		);
281 281
 
282
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_delete_questions', 'espresso_registration_form_trash_questions' ) ) {
282
+		if (EE_Registry::instance()->CAP->current_user_can('ee_delete_questions', 'espresso_registration_form_trash_questions')) {
283 283
 			$this->_views['trash'] = array(
284 284
 				'slug' => 'trash',
285 285
 				'label' => __('Trash', 'event_espresso'),
@@ -297,9 +297,9 @@  discard block
 block discarded – undo
297 297
 	 */
298 298
 	protected function _questions_groups_preview() {
299 299
 		$this->_admin_page_title = __('Question Groups (Preview)', 'event_espresso');
300
-		$this->_template_args['preview_img'] = '<img src="' . REGISTRATION_FORM_ASSETS_URL . 'caf_reg_form_preview.jpg" alt="' . esc_attr__( 'Preview Question Groups Overview List Table screenshot', 'event_espresso' ) . '" />';
301
-		$this->_template_args['preview_text'] = '<strong>'.__( 'Question Groups is a feature that is only available in the Caffeinated version of Event Espresso.  With the Question Groups feature you are able to: create new question groups, edit existing question groups, and also create and edit new questions and add them to question groups.', 'event_espresso' ).'</strong>';
302
-		$this->display_admin_caf_preview_page( 'question_groups_tab' );
300
+		$this->_template_args['preview_img'] = '<img src="'.REGISTRATION_FORM_ASSETS_URL.'caf_reg_form_preview.jpg" alt="'.esc_attr__('Preview Question Groups Overview List Table screenshot', 'event_espresso').'" />';
301
+		$this->_template_args['preview_text'] = '<strong>'.__('Question Groups is a feature that is only available in the Caffeinated version of Event Espresso.  With the Question Groups feature you are able to: create new question groups, edit existing question groups, and also create and edit new questions and add them to question groups.', 'event_espresso').'</strong>';
302
+		$this->display_admin_caf_preview_page('question_groups_tab');
303 303
 	}
304 304
 
305 305
 
@@ -310,58 +310,58 @@  discard block
 block discarded – undo
310 310
 	 * @param \EEM_Base $model
311 311
 	 * @return array where each key is the name of a model's field/db column, and each value is its value.
312 312
 	 */
313
-	protected function _set_column_values_for(EEM_Base $model){
314
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
315
-		$set_column_values=array();
313
+	protected function _set_column_values_for(EEM_Base $model) {
314
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
315
+		$set_column_values = array();
316 316
 
317 317
 		//some initial checks for proper values.
318 318
 		//if QST_admin_only, then no matter what QST_required is we disable.
319
-		if ( !empty( $this->_req_data['QST_admin_only'] ) ) {
319
+		if ( ! empty($this->_req_data['QST_admin_only'])) {
320 320
 			$this->_req_data['QST_required'] = 0;
321 321
 		}
322
-		foreach($model->field_settings() as $fieldName=>$settings){
322
+		foreach ($model->field_settings() as $fieldName=>$settings) {
323 323
 			// basically if QSG_identifier is empty or not set
324
-			if ( $fieldName == 'QSG_identifier' && ( isset( $this->_req_data['QSG_identifier'] ) && empty( $this->_req_data['QSG_identifier'] ) )) {
325
-				$QSG_name = isset( $this->_req_data['QSG_name'] ) ? $this->_req_data['QSG_name'] : '' ;
326
-				$set_column_values[$fieldName] = sanitize_title($QSG_name ) . '-' . uniqid();
324
+			if ($fieldName == 'QSG_identifier' && (isset($this->_req_data['QSG_identifier']) && empty($this->_req_data['QSG_identifier']))) {
325
+				$QSG_name = isset($this->_req_data['QSG_name']) ? $this->_req_data['QSG_name'] : '';
326
+				$set_column_values[$fieldName] = sanitize_title($QSG_name).'-'.uniqid();
327 327
 //				dd($set_column_values);
328 328
 			}
329 329
 			//if the admin label is blank, use a slug version of the question text
330
-			else if ( $fieldName == 'QST_admin_label' && ( isset( $this->_req_data['QST_admin_label'] ) && empty( $this->_req_data['QST_admin_label'] )  )) {
331
-				$QST_text = isset( $this->_req_data['QST_display_text'] ) ? $this->_req_data['QST_display_text'] : '' ;
332
-				$set_column_values[$fieldName] = sanitize_title(wp_trim_words($QST_text,10));
330
+			else if ($fieldName == 'QST_admin_label' && (isset($this->_req_data['QST_admin_label']) && empty($this->_req_data['QST_admin_label']))) {
331
+				$QST_text = isset($this->_req_data['QST_display_text']) ? $this->_req_data['QST_display_text'] : '';
332
+				$set_column_values[$fieldName] = sanitize_title(wp_trim_words($QST_text, 10));
333 333
 			}
334 334
 
335 335
 
336
-			else if ( $fieldName == 'QST_admin_only' && ( !isset( $this->_req_data['QST_admin_only'] ) ) ) {
336
+			else if ($fieldName == 'QST_admin_only' && ( ! isset($this->_req_data['QST_admin_only']))) {
337 337
 				$set_column_values[$fieldName] = 0;
338 338
 			}
339 339
 
340
-			else if ( $fieldName == 'QST_max' ) {
340
+			else if ($fieldName == 'QST_max') {
341 341
 				$qst_system = EEM_Question::instance()->get_var(
342 342
 					array(
343 343
 						array(
344
-							'QST_ID' => isset( $this->_req_data[ 'QST_ID' ] ) ? $this->_req_data[ 'QST_ID' ] : 0
344
+							'QST_ID' => isset($this->_req_data['QST_ID']) ? $this->_req_data['QST_ID'] : 0
345 345
 						)
346 346
 					),
347 347
 					'QST_system' );
348
-				$max_max = EEM_Question::instance()->absolute_max_for_system_question( $qst_system );
349
-				if( empty( $this->_req_data[ 'QST_max' ] ) ||
350
-					 $this->_req_data[ 'QST_max' ] > $max_max ) {
351
-					$set_column_values[ $fieldName ] = $max_max;
348
+				$max_max = EEM_Question::instance()->absolute_max_for_system_question($qst_system);
349
+				if (empty($this->_req_data['QST_max']) ||
350
+					 $this->_req_data['QST_max'] > $max_max) {
351
+					$set_column_values[$fieldName] = $max_max;
352 352
 				}
353 353
 			}
354 354
 
355 355
 
356 356
 			//only add a property to the array if it's not null (otherwise the model should just use the default value)
357
-			if(
358
-				! isset( $set_column_values[ $fieldName ] ) &&
359
-				isset($this->_req_data[$fieldName] ) ){
360
-				$set_column_values[$fieldName]=$this->_req_data[$fieldName];
357
+			if (
358
+				! isset($set_column_values[$fieldName]) &&
359
+				isset($this->_req_data[$fieldName]) ) {
360
+				$set_column_values[$fieldName] = $this->_req_data[$fieldName];
361 361
 			}
362 362
 
363 363
 		}
364
-		return $set_column_values;//validation fo this data to be performed by the model before insertion.
364
+		return $set_column_values; //validation fo this data to be performed by the model before insertion.
365 365
 	}
366 366
 
367 367
 
@@ -379,30 +379,30 @@  discard block
 block discarded – undo
379 379
 	/**
380 380
 	 * @param string $action
381 381
 	 */
382
-	protected function _edit_question( $action= 'add' ) {
383
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
384
-		$ID=isset( $this->_req_data['QST_ID'] ) && ! empty( $this->_req_data['QST_ID'] ) ? absint( $this->_req_data['QST_ID'] ) : FALSE;
382
+	protected function _edit_question($action = 'add') {
383
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
384
+		$ID = isset($this->_req_data['QST_ID']) && ! empty($this->_req_data['QST_ID']) ? absint($this->_req_data['QST_ID']) : FALSE;
385 385
 
386
-		$this->_admin_page_title = ucwords( str_replace( '_', ' ', $this->_req_action ));
386
+		$this->_admin_page_title = ucwords(str_replace('_', ' ', $this->_req_action));
387 387
 		// add PRC_ID to title if editing
388
-		$this->_admin_page_title = $ID ? $this->_admin_page_title . ' # ' . $ID : $this->_admin_page_title;
389
-		if($ID){
390
-			$question=$this->_question_model->get_one_by_ID($ID);
391
-			$additional_hidden_fields=array('QST_ID'=>array('type'=>'hidden','value'=>$ID));
388
+		$this->_admin_page_title = $ID ? $this->_admin_page_title.' # '.$ID : $this->_admin_page_title;
389
+		if ($ID) {
390
+			$question = $this->_question_model->get_one_by_ID($ID);
391
+			$additional_hidden_fields = array('QST_ID'=>array('type'=>'hidden', 'value'=>$ID));
392 392
 			$this->_set_add_edit_form_tags('update_question', $additional_hidden_fields);
393
-		}else{
394
-			$question= EE_Question::new_instance();
393
+		} else {
394
+			$question = EE_Question::new_instance();
395 395
 			$question->set_order_to_latest();
396 396
 			$this->_set_add_edit_form_tags('insert_question');
397 397
 		}
398
-		$question_types = $question->has_answers() ?  $this->_question_model->question_types_in_same_category( $question->type() ) : $this->_question_model->allowed_question_types();
399
-		$this->_template_args['QST_ID']=$ID;
400
-		$this->_template_args['question']=$question;
401
-		$this->_template_args['question_types']= $question_types;
402
-		$this->_template_args['max_max'] = EEM_Question::instance()->absolute_max_for_system_question( $question->system_ID() );
398
+		$question_types = $question->has_answers() ? $this->_question_model->question_types_in_same_category($question->type()) : $this->_question_model->allowed_question_types();
399
+		$this->_template_args['QST_ID'] = $ID;
400
+		$this->_template_args['question'] = $question;
401
+		$this->_template_args['question_types'] = $question_types;
402
+		$this->_template_args['max_max'] = EEM_Question::instance()->absolute_max_for_system_question($question->system_ID());
403 403
 
404
-		$this->_set_publish_post_box_vars( 'id', $ID );
405
-		$this->_template_args['admin_page_content'] = EEH_Template::display_template( REGISTRATION_FORM_TEMPLATE_PATH . 'questions_main_meta_box.template.php', $this->_template_args, TRUE );
404
+		$this->_set_publish_post_box_vars('id', $ID);
405
+		$this->_template_args['admin_page_content'] = EEH_Template::display_template(REGISTRATION_FORM_TEMPLATE_PATH.'questions_main_meta_box.template.php', $this->_template_args, TRUE);
406 406
 
407 407
 		// the details template wrapper
408 408
 		$this->display_admin_page_with_sidebar();
@@ -414,58 +414,58 @@  discard block
 block discarded – undo
414 414
 	 * @param bool|true $new_question
415 415
 	 * @throws \EE_Error
416 416
 	 */
417
-	protected function _insert_or_update_question( $new_question = TRUE) {
418
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
419
-		$set_column_values=$this->_set_column_values_for($this->_question_model);
420
-		if($new_question){
421
-			$ID=$this->_question_model->insert($set_column_values);
417
+	protected function _insert_or_update_question($new_question = TRUE) {
418
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
419
+		$set_column_values = $this->_set_column_values_for($this->_question_model);
420
+		if ($new_question) {
421
+			$ID = $this->_question_model->insert($set_column_values);
422 422
 			$success = $ID ? true : false;
423 423
 			$action_desc = 'added';
424
-		}else{
425
-			$ID=absint($this->_req_data['QST_ID']);
426
-			$pk=$this->_question_model->primary_key_name();
427
-			$wheres=array($pk=>$ID);
424
+		} else {
425
+			$ID = absint($this->_req_data['QST_ID']);
426
+			$pk = $this->_question_model->primary_key_name();
427
+			$wheres = array($pk=>$ID);
428 428
 			unset($set_column_values[$pk]);
429
-			$success= $this->_question_model->update($set_column_values,array($wheres));
430
-			$action_desc='updated';
429
+			$success = $this->_question_model->update($set_column_values, array($wheres));
430
+			$action_desc = 'updated';
431 431
 		}
432 432
 
433
-		if ($ID){
433
+		if ($ID) {
434 434
 			//save the related options
435 435
 			//trash removed options, save old ones
436 436
 			//get list of all options
437 437
 			/** @type EE_Question $question */
438
-			$question=$this->_question_model->get_one_by_ID($ID);
439
-			$options=$question->options();
440
-			if(! empty($options)){
441
-				foreach($options as $option_ID=>$option){
442
-					$option_req_index=$this->_get_option_req_data_index($option_ID);
443
-					if($option_req_index!==FALSE){
438
+			$question = $this->_question_model->get_one_by_ID($ID);
439
+			$options = $question->options();
440
+			if ( ! empty($options)) {
441
+				foreach ($options as $option_ID=>$option) {
442
+					$option_req_index = $this->_get_option_req_data_index($option_ID);
443
+					if ($option_req_index !== FALSE) {
444 444
 						$option->save($this->_req_data['question_options'][$option_req_index]);
445
-					}else{
445
+					} else {
446 446
 						//not found, remove it
447 447
 						$option->delete();
448 448
 					}
449 449
 				}
450 450
 			}
451 451
 			//save new related options
452
-			foreach($this->_req_data['question_options'] as $index=>$option_req_data){
453
-				if( empty($option_req_data['QSO_ID'] ) && (  ( isset( $option_req_data['QSO_value'] ) && $option_req_data['QSO_value'] !== '' ) || ! empty( $option_req_data['QSO_desc'] ) ) ) {//no ID! save it!
454
-					if( ! isset( $option_req_data['QSO_value'] ) || $option_req_data['QSO_value'] === ''  ){
455
-						$option_req_data['QSO_value']=$option_req_data['QSO_desc'];
452
+			foreach ($this->_req_data['question_options'] as $index=>$option_req_data) {
453
+				if (empty($option_req_data['QSO_ID']) && ((isset($option_req_data['QSO_value']) && $option_req_data['QSO_value'] !== '') || ! empty($option_req_data['QSO_desc']))) {//no ID! save it!
454
+					if ( ! isset($option_req_data['QSO_value']) || $option_req_data['QSO_value'] === '') {
455
+						$option_req_data['QSO_value'] = $option_req_data['QSO_desc'];
456 456
 					}
457
-					$new_option=EE_Question_Option::new_instance( array( 'QSO_value' => $option_req_data['QSO_value'], 'QSO_desc' => $option_req_data['QSO_desc'], 'QSO_order' => $option_req_data['QSO_order'], 'QST_ID' => $question->ID()));
457
+					$new_option = EE_Question_Option::new_instance(array('QSO_value' => $option_req_data['QSO_value'], 'QSO_desc' => $option_req_data['QSO_desc'], 'QSO_order' => $option_req_data['QSO_order'], 'QST_ID' => $question->ID()));
458 458
 					$new_option->save();
459 459
 				}
460 460
 			}
461 461
 		}
462
-		$query_args = array( 'action' => 'edit_question', 'QST_ID' => $ID );
463
-		if ( $success !== FALSE ) {
464
-			$msg = $new_question ? sprintf( __('The %s has been created', 'event_espresso'), $this->_question_model->item_name() ) : sprintf( __('The %s has been updated', 'event_espresso' ), $this->_question_model->item_name() );
465
-			EE_Error::add_success( $msg );
462
+		$query_args = array('action' => 'edit_question', 'QST_ID' => $ID);
463
+		if ($success !== FALSE) {
464
+			$msg = $new_question ? sprintf(__('The %s has been created', 'event_espresso'), $this->_question_model->item_name()) : sprintf(__('The %s has been updated', 'event_espresso'), $this->_question_model->item_name());
465
+			EE_Error::add_success($msg);
466 466
 		}
467 467
 
468
-		$this->_redirect_after_action( FALSE, '', $action_desc, $query_args, TRUE);
468
+		$this->_redirect_after_action(FALSE, '', $action_desc, $query_args, TRUE);
469 469
 	}
470 470
 
471 471
 
@@ -478,10 +478,10 @@  discard block
 block discarded – undo
478 478
 	 * @param int $ID of the question option to find
479 479
 	 * @return int index in question_options array if successful, FALSE if unsuccessful
480 480
 	 */
481
-	protected function _get_option_req_data_index($ID){
482
-		$req_data_for_question_options=$this->_req_data['question_options'];
483
-		foreach($req_data_for_question_options as $num=>$option_data){
484
-			if(array_key_exists('QSO_ID',$option_data) && intval($option_data['QSO_ID'])==$ID){
481
+	protected function _get_option_req_data_index($ID) {
482
+		$req_data_for_question_options = $this->_req_data['question_options'];
483
+		foreach ($req_data_for_question_options as $num=>$option_data) {
484
+			if (array_key_exists('QSO_ID', $option_data) && intval($option_data['QSO_ID']) == $ID) {
485 485
 				return $num;
486 486
 			}
487 487
 		}
@@ -503,25 +503,25 @@  discard block
 block discarded – undo
503 503
 	 * @param int      $current_page
504 504
 	 * @return array lik EEM_Base::get_all's $query_params parameter
505 505
 	 */
506
-	protected function get_query_params($model, $per_page=10,$current_page=10){
506
+	protected function get_query_params($model, $per_page = 10, $current_page = 10) {
507 507
 		$query_params = array();
508
-		$offset=($current_page-1)*$per_page;
509
-		$query_params['limit']=array($offset,$per_page);
510
-		$order = ( isset( $this->_req_data['order'] ) && ! empty( $this->_req_data['order'] )) ? $this->_req_data['order'] : 'ASC';
508
+		$offset = ($current_page - 1) * $per_page;
509
+		$query_params['limit'] = array($offset, $per_page);
510
+		$order = (isset($this->_req_data['order']) && ! empty($this->_req_data['order'])) ? $this->_req_data['order'] : 'ASC';
511 511
 		$orderby_field = $model instanceof EEM_Question ? 'QST_ID' : 'QSG_order';
512 512
 		$field_to_order_by = empty($this->_req_data['orderby']) ? $orderby_field : $this->_req_data['orderby'];
513
-		$query_params['order_by']=array( $field_to_order_by => $order );
514
-		$search_string = array_key_exists('s',$this->_req_data) ? $this->_req_data['s'] : null;
515
-		if(! empty($search_string)){
516
-			if($model instanceof EEM_Question_Group){
517
-				$query_params[0]=array(
513
+		$query_params['order_by'] = array($field_to_order_by => $order);
514
+		$search_string = array_key_exists('s', $this->_req_data) ? $this->_req_data['s'] : null;
515
+		if ( ! empty($search_string)) {
516
+			if ($model instanceof EEM_Question_Group) {
517
+				$query_params[0] = array(
518 518
 					'OR'=>array(
519
-						'QSG_name'=>array('LIKE',"%$search_string%"),
520
-						'QSG_desc'=>array('LIKE',"%$search_string%"))
519
+						'QSG_name'=>array('LIKE', "%$search_string%"),
520
+						'QSG_desc'=>array('LIKE', "%$search_string%"))
521 521
 					);
522
-			}else{
523
-				$query_params[0]=array(
524
-					'QST_display_text'=>array('LIKE',"%$search_string%")
522
+			} else {
523
+				$query_params[0] = array(
524
+					'QST_display_text'=>array('LIKE', "%$search_string%")
525 525
 					);
526 526
 			}
527 527
 		}
@@ -569,13 +569,13 @@  discard block
 block discarded – undo
569 569
 	 * @param bool|false $count
570 570
 	 * @return \EE_Soft_Delete_Base_Class[]|int
571 571
 	 */
572
-	public function get_questions( $per_page=10, $current_page = 1, $count = FALSE ) {
572
+	public function get_questions($per_page = 10, $current_page = 1, $count = FALSE) {
573 573
 		$QST = EEM_Question::instance();
574 574
 		$query_params = $this->get_query_params($QST, $per_page, $current_page);
575
-		if ($count){
576
-			$where = isset( $query_params[0] ) ? array( $query_params[0] ) : array();
575
+		if ($count) {
576
+			$where = isset($query_params[0]) ? array($query_params[0]) : array();
577 577
 			$results = $QST->count($where);
578
-		}else{
578
+		} else {
579 579
 			$results = $QST->get_all($query_params);
580 580
 		}
581 581
 		return $results;
@@ -590,10 +590,10 @@  discard block
 block discarded – undo
590 590
 	 * @param bool|false $count
591 591
 	 * @return \EE_Soft_Delete_Base_Class[]|int
592 592
 	 */
593
-	public function get_trashed_questions( $per_page, $current_page = 1, $count = FALSE ) {
594
-		$query_params =$this->get_query_params( EEM_Question::instance(), $per_page, $current_page);
595
-		$where        = isset( $query_params[0] ) ? array($query_params[0]) : array();
596
-		$questions    =$count ? EEM_Question::instance()->count_deleted($where) : EEM_Question::instance()->get_all_deleted($query_params);
593
+	public function get_trashed_questions($per_page, $current_page = 1, $count = FALSE) {
594
+		$query_params = $this->get_query_params(EEM_Question::instance(), $per_page, $current_page);
595
+		$where        = isset($query_params[0]) ? array($query_params[0]) : array();
596
+		$questions    = $count ? EEM_Question::instance()->count_deleted($where) : EEM_Question::instance()->get_all_deleted($query_params);
597 597
 		return $questions;
598 598
 	}
599 599
 
@@ -605,11 +605,11 @@  discard block
 block discarded – undo
605 605
 	 * @param bool|false $count
606 606
 	 * @return \EE_Soft_Delete_Base_Class[]
607 607
 	 */
608
-	public function get_question_groups( $per_page, $current_page = 1, $count = FALSE ) {
608
+	public function get_question_groups($per_page, $current_page = 1, $count = FALSE) {
609 609
 		/** @type EEM_Question_Group $questionGroupModel */
610
-		$questionGroupModel=EEM_Question_Group::instance();
611
-		$query_params=$this->get_query_params( $questionGroupModel, $per_page, $current_page );
612
-		$questionGroups=$questionGroupModel->get_all($query_params);//note: this a subclass of EEM_Soft_Delete_Base, so this is actually only getting non-trashed items
610
+		$questionGroupModel = EEM_Question_Group::instance();
611
+		$query_params = $this->get_query_params($questionGroupModel, $per_page, $current_page);
612
+		$questionGroups = $questionGroupModel->get_all($query_params); //note: this a subclass of EEM_Soft_Delete_Base, so this is actually only getting non-trashed items
613 613
 		return $questionGroups;
614 614
 	}
615 615
 
@@ -626,36 +626,36 @@  discard block
 block discarded – undo
626 626
 
627 627
 		$this->_template_args['values'] = $this->_yes_no_values;
628 628
 
629
-		$this->_template_args['use_captcha'] = isset( EE_Registry::instance()->CFG->registration->use_captcha ) ? EE_Registry::instance()->CFG->registration->use_captcha : FALSE;
630
-		$this->_template_args['show_captcha_settings'] = $this->_template_args['use_captcha'] ? 'style="display:table-row;"': '';
629
+		$this->_template_args['use_captcha'] = isset(EE_Registry::instance()->CFG->registration->use_captcha) ? EE_Registry::instance()->CFG->registration->use_captcha : FALSE;
630
+		$this->_template_args['show_captcha_settings'] = $this->_template_args['use_captcha'] ? 'style="display:table-row;"' : '';
631 631
 
632
-		$this->_template_args['recaptcha_publickey'] = isset( EE_Registry::instance()->CFG->registration->recaptcha_publickey ) ? stripslashes( EE_Registry::instance()->CFG->registration->recaptcha_publickey ) : '';
633
-		$this->_template_args['recaptcha_privatekey'] = isset( EE_Registry::instance()->CFG->registration->recaptcha_privatekey ) ? stripslashes( EE_Registry::instance()->CFG->registration->recaptcha_privatekey ) : '';
634
-		$this->_template_args['recaptcha_width'] = isset( EE_Registry::instance()->CFG->registration->recaptcha_width ) ? absint( EE_Registry::instance()->CFG->registration->recaptcha_width ) : 500;
632
+		$this->_template_args['recaptcha_publickey'] = isset(EE_Registry::instance()->CFG->registration->recaptcha_publickey) ? stripslashes(EE_Registry::instance()->CFG->registration->recaptcha_publickey) : '';
633
+		$this->_template_args['recaptcha_privatekey'] = isset(EE_Registry::instance()->CFG->registration->recaptcha_privatekey) ? stripslashes(EE_Registry::instance()->CFG->registration->recaptcha_privatekey) : '';
634
+		$this->_template_args['recaptcha_width'] = isset(EE_Registry::instance()->CFG->registration->recaptcha_width) ? absint(EE_Registry::instance()->CFG->registration->recaptcha_width) : 500;
635 635
 
636 636
 		$this->_template_args['recaptcha_theme_options'] = array(
637
-				array('id'  => 'red','text'=> __('Red', 'event_espresso')),
638
-				array('id'  => 'white','text'=> __('White', 'event_espresso')),
639
-				array('id'  => 'blackglass','text'=> __('Blackglass', 'event_espresso')),
640
-				array('id'  => 'clean','text'=> __('Clean', 'event_espresso'))
637
+				array('id'  => 'red', 'text'=> __('Red', 'event_espresso')),
638
+				array('id'  => 'white', 'text'=> __('White', 'event_espresso')),
639
+				array('id'  => 'blackglass', 'text'=> __('Blackglass', 'event_espresso')),
640
+				array('id'  => 'clean', 'text'=> __('Clean', 'event_espresso'))
641 641
 			);
642
-		$this->_template_args['recaptcha_theme'] = isset( EE_Registry::instance()->CFG->registration->recaptcha_theme ) ? EE_Registry::instance()->CFG->registration->get_pretty( 'recaptcha_theme' ) : 'clean';
642
+		$this->_template_args['recaptcha_theme'] = isset(EE_Registry::instance()->CFG->registration->recaptcha_theme) ? EE_Registry::instance()->CFG->registration->get_pretty('recaptcha_theme') : 'clean';
643 643
 
644 644
 		$this->_template_args['recaptcha_language_options'] = array(
645
-				array('id'  => 'en','text'=> __('English', 'event_espresso')),
646
-				array('id'  => 'es','text'=> __('Spanish', 'event_espresso')),
647
-				array('id'  => 'nl','text'=> __('Dutch', 'event_espresso')),
648
-				array('id'  => 'fr','text'=> __('French', 'event_espresso')),
649
-				array('id'  => 'de','text'=> __('German', 'event_espresso')),
650
-				array('id'  => 'pt','text'=> __('Portuguese', 'event_espresso')),
651
-				array('id'  => 'ru','text'=> __('Russian', 'event_espresso')),
652
-				array('id'  => 'tr','text'=> __('Turkish', 'event_espresso'))
645
+				array('id'  => 'en', 'text'=> __('English', 'event_espresso')),
646
+				array('id'  => 'es', 'text'=> __('Spanish', 'event_espresso')),
647
+				array('id'  => 'nl', 'text'=> __('Dutch', 'event_espresso')),
648
+				array('id'  => 'fr', 'text'=> __('French', 'event_espresso')),
649
+				array('id'  => 'de', 'text'=> __('German', 'event_espresso')),
650
+				array('id'  => 'pt', 'text'=> __('Portuguese', 'event_espresso')),
651
+				array('id'  => 'ru', 'text'=> __('Russian', 'event_espresso')),
652
+				array('id'  => 'tr', 'text'=> __('Turkish', 'event_espresso'))
653 653
 			);
654
-		$this->_template_args['recaptcha_language'] = isset( EE_Registry::instance()->CFG->registration->recaptcha_language ) ? EE_Registry::instance()->CFG->registration->recaptcha_language : 'en';
654
+		$this->_template_args['recaptcha_language'] = isset(EE_Registry::instance()->CFG->registration->recaptcha_language) ? EE_Registry::instance()->CFG->registration->recaptcha_language : 'en';
655 655
 
656
-		$this->_set_add_edit_form_tags( 'update_reg_form_settings' );
657
-		$this->_set_publish_post_box_vars( NULL, FALSE, FALSE, NULL, FALSE );
658
-		$this->_template_args['admin_page_content'] = EEH_Template::display_template( REGISTRATION_FORM_TEMPLATE_PATH . 'reg_form_settings.template.php', $this->_template_args, TRUE );
656
+		$this->_set_add_edit_form_tags('update_reg_form_settings');
657
+		$this->_set_publish_post_box_vars(NULL, FALSE, FALSE, NULL, FALSE);
658
+		$this->_template_args['admin_page_content'] = EEH_Template::display_template(REGISTRATION_FORM_TEMPLATE_PATH.'reg_form_settings.template.php', $this->_template_args, TRUE);
659 659
 		$this->display_admin_page_with_sidebar();
660 660
 	}
661 661
 
Please login to merge, or discard this patch.
core/libraries/payment_methods/EE_Payment_Method_Manager.lib.php 1 patch
Spacing   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	public static function instance() {
37 37
 		// check if class object is instantiated, and instantiated properly
38
-		if ( ! self::$_instance instanceof EE_Payment_Method_Manager ) {
38
+		if ( ! self::$_instance instanceof EE_Payment_Method_Manager) {
39 39
 			self::$_instance = new self();
40 40
 		}
41 41
 		EE_Registry::instance()->load_lib('PMT_Base');
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	 * Resets the instance and returns a new one
47 47
 	 * @return EE_Payment_Method_Manager
48 48
 	 */
49
-	public static function reset(){
49
+	public static function reset() {
50 50
 		self::$_instance = NULL;
51 51
 		return self::instance();
52 52
 	}
@@ -57,12 +57,12 @@  discard block
 block discarded – undo
57 57
 	 * or just re-use the PMTs we found last time we checked during this request (if
58 58
 	 * we have not yet checked during this request, then we need to check anyways)
59 59
 	 */
60
-	public function maybe_register_payment_methods( $force_recheck = FALSE ){
61
-		if( ! $this->_payment_method_types || $force_recheck ){
60
+	public function maybe_register_payment_methods($force_recheck = FALSE) {
61
+		if ( ! $this->_payment_method_types || $force_recheck) {
62 62
 			$this->_register_payment_methods();
63 63
 			//if in admin lets ensure caps are set.
64
-			if ( is_admin() ) {
65
-				add_filter( 'FHEE__EE_Capabilities__init_caps_map__caps', array( $this, 'add_payment_method_caps' ) );
64
+			if (is_admin()) {
65
+				add_filter('FHEE__EE_Capabilities__init_caps_map__caps', array($this, 'add_payment_method_caps'));
66 66
 				EE_Registry::instance()->CAP->init_caps();
67 67
 			}
68 68
 		}
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
75 75
 	 */
76 76
 	protected function _register_payment_methods() {
77 77
 		// grab list of installed modules
78
-		$pm_to_register = glob( EE_PAYMENT_METHODS . '*', GLOB_ONLYDIR );
78
+		$pm_to_register = glob(EE_PAYMENT_METHODS.'*', GLOB_ONLYDIR);
79 79
 		// filter list of modules to register
80
-		$pm_to_register = apply_filters( 'FHEE__EE_Payment_Method_Manager__register_payment_methods__payment_methods_to_register', $pm_to_register );
80
+		$pm_to_register = apply_filters('FHEE__EE_Payment_Method_Manager__register_payment_methods__payment_methods_to_register', $pm_to_register);
81 81
 
82 82
 		// loop through folders
83
-		foreach ( $pm_to_register as $pm_path ) {
84
-				$this->register_payment_method( $pm_path );
83
+		foreach ($pm_to_register as $pm_path) {
84
+				$this->register_payment_method($pm_path);
85 85
 		}
86
-		do_action( 'FHEE__EE_Payment_Method_Manager__register_payment_methods__registered_payment_methods' );
86
+		do_action('FHEE__EE_Payment_Method_Manager__register_payment_methods__registered_payment_methods');
87 87
 		// filter list of installed modules
88 88
 		//keep them organized alphabetically by the payment method type's name
89
-		ksort( $this->_payment_method_types );
90
-		return apply_filters( 'FHEE__EE_Payment_Method_Manager__register_payment_methods__installed_payment_methods', $this->_payment_method_types );
89
+		ksort($this->_payment_method_types);
90
+		return apply_filters('FHEE__EE_Payment_Method_Manager__register_payment_methods__installed_payment_methods', $this->_payment_method_types);
91 91
 	}
92 92
 
93 93
 
@@ -99,35 +99,35 @@  discard block
 block discarded – undo
99 99
 	 * @param string $payment_method_path - full path up to and including payment method folder
100 100
 	 * @return boolean
101 101
 	 */
102
-	public function register_payment_method( $payment_method_path = '' ) {
103
-		do_action( 'AHEE__EE_Payment_Method_Manager__register_payment_method__begin',$payment_method_path );
102
+	public function register_payment_method($payment_method_path = '') {
103
+		do_action('AHEE__EE_Payment_Method_Manager__register_payment_method__begin', $payment_method_path);
104 104
 		$module_ext = '.pm.php';
105 105
 		// make all separators match
106
-		$payment_method_path = rtrim( str_replace( '/\\', DS, $payment_method_path ), DS );
106
+		$payment_method_path = rtrim(str_replace('/\\', DS, $payment_method_path), DS);
107 107
 		// grab and sanitize module name
108
-		$module_dir = basename( $payment_method_path );
108
+		$module_dir = basename($payment_method_path);
109 109
 		// create classname from module directory name
110
-		$module = str_replace( ' ', '_', str_replace( '_', ' ', $module_dir ));
110
+		$module = str_replace(' ', '_', str_replace('_', ' ', $module_dir));
111 111
 		// add class prefix
112
-		$module_class = 'EE_PMT_' . $module;
112
+		$module_class = 'EE_PMT_'.$module;
113 113
 		// does the module exist ?
114
-		if ( ! is_readable( $payment_method_path . DS . $module_class . $module_ext )) {
115
-			$msg = sprintf( __( 'The requested %s payment method file could not be found or is not readable due to file permissions.', 'event_espresso' ), $module );
116
-			EE_Error::add_error( $msg . '||' . $msg, __FILE__, __FUNCTION__, __LINE__ );
114
+		if ( ! is_readable($payment_method_path.DS.$module_class.$module_ext)) {
115
+			$msg = sprintf(__('The requested %s payment method file could not be found or is not readable due to file permissions.', 'event_espresso'), $module);
116
+			EE_Error::add_error($msg.'||'.$msg, __FILE__, __FUNCTION__, __LINE__);
117 117
 			return FALSE;
118 118
 		}
119
-		if ( WP_DEBUG === TRUE ) { EEH_Debug_Tools::instance()->start_timer(); }
119
+		if (WP_DEBUG === TRUE) { EEH_Debug_Tools::instance()->start_timer(); }
120 120
 		// load the module class file
121
-		require_once( $payment_method_path . DS . $module_class . $module_ext );
122
-		if ( WP_DEBUG === TRUE ) { EEH_Debug_Tools::instance()->stop_timer("Requiring payment method $module_class"); }
121
+		require_once($payment_method_path.DS.$module_class.$module_ext);
122
+		if (WP_DEBUG === TRUE) { EEH_Debug_Tools::instance()->stop_timer("Requiring payment method $module_class"); }
123 123
 		// verify that class exists
124
-		if ( ! class_exists( $module_class )) {
125
-			$msg = sprintf( __( 'The requested %s module class does not exist.', 'event_espresso' ), $module_class );
126
-			EE_Error::add_error( $msg . '||' . $msg, __FILE__, __FUNCTION__, __LINE__ );
124
+		if ( ! class_exists($module_class)) {
125
+			$msg = sprintf(__('The requested %s module class does not exist.', 'event_espresso'), $module_class);
126
+			EE_Error::add_error($msg.'||'.$msg, __FILE__, __FUNCTION__, __LINE__);
127 127
 			return FALSE;
128 128
 		}
129 129
 		// add to array of registered modules
130
-		$this->_payment_method_types[ $module ] = $payment_method_path . DS . $module_class . $module_ext;
130
+		$this->_payment_method_types[$module] = $payment_method_path.DS.$module_class.$module_ext;
131 131
 		return TRUE;
132 132
 	}
133 133
 	/**
@@ -136,15 +136,15 @@  discard block
 block discarded – undo
136 136
 	 * @param boolean $force_recheck whether to force re-checking for new payment method types
137 137
 	 * @return boolean
138 138
 	 */
139
-	public function payment_method_type_exists($payment_method_name, $force_recheck = FALSE){
140
-		if ( ! is_array( $this->_payment_method_types ) || ! isset( $this->_payment_method_types[$payment_method_name] )
141
-				|| $force_recheck ) {
139
+	public function payment_method_type_exists($payment_method_name, $force_recheck = FALSE) {
140
+		if ( ! is_array($this->_payment_method_types) || ! isset($this->_payment_method_types[$payment_method_name])
141
+				|| $force_recheck) {
142 142
 			$this->maybe_register_payment_methods($force_recheck);
143 143
 		}
144
-		if(isset($this->_payment_method_types[$payment_method_name])){
144
+		if (isset($this->_payment_method_types[$payment_method_name])) {
145 145
 			require_once($this->_payment_method_types[$payment_method_name]);
146 146
 			return true;
147
-		}else{
147
+		} else {
148 148
 			return false;
149 149
 		}
150 150
 	}
@@ -155,16 +155,16 @@  discard block
 block discarded – undo
155 155
 	 * @param boolean $force_recheck whether to force re-checking for new payment method types
156 156
 	 * @return array
157 157
 	 */
158
-	public function payment_method_type_names($with_prefixes = FALSE, $force_recheck = FALSE ){
158
+	public function payment_method_type_names($with_prefixes = FALSE, $force_recheck = FALSE) {
159 159
 		$this->maybe_register_payment_methods($force_recheck);
160
-		if($with_prefixes){
160
+		if ($with_prefixes) {
161 161
 			$classnames = array_keys($this->_payment_method_types);
162 162
 			$payment_methods = array();
163
-			foreach($classnames as $classname){
163
+			foreach ($classnames as $classname) {
164 164
 				$payment_methods[] = $this->payment_method_class_from_type($classname);
165 165
 			}
166 166
 			return $payment_methods;
167
-		}else{
167
+		} else {
168 168
 			return array_keys($this->_payment_method_types);
169 169
 		}
170 170
 	}
@@ -174,10 +174,10 @@  discard block
 block discarded – undo
174 174
 	 * @param boolean $force_recheck whether to force re-checking for new payment method types
175 175
 	 * @return EE_PMT_Base[]
176 176
 	 */
177
-	public function payment_method_types( $force_recheck = FALSE ){
177
+	public function payment_method_types($force_recheck = FALSE) {
178 178
 		$this->maybe_register_payment_methods($force_recheck);
179 179
 		$pmt_objs = array();
180
-		foreach($this->payment_method_type_names(true) as $classname){
180
+		foreach ($this->payment_method_type_names(true) as $classname) {
181 181
 			$pmt_objs[] = new $classname;
182 182
 		}
183 183
 		return $pmt_objs;
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
189 189
 	 * @param string $classname
190 190
 	 * @return string
191 191
 	 */
192
-	public function payment_method_type_sans_class_prefix($classname){
193
-		$pmt_name = str_replace("EE_PMT_","",$classname);
192
+	public function payment_method_type_sans_class_prefix($classname) {
193
+		$pmt_name = str_replace("EE_PMT_", "", $classname);
194 194
 		return $pmt_name;
195 195
 	}
196 196
 
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 	 * @param string $type
200 200
 	 * @return string
201 201
 	 */
202
-	public function payment_method_class_from_type($type){
202
+	public function payment_method_class_from_type($type) {
203 203
 		$this->maybe_register_payment_methods();
204 204
 		return "EE_PMT_".$type;
205 205
 	}
@@ -213,38 +213,38 @@  discard block
 block discarded – undo
213 213
 	 * @return \EE_Payment_Method
214 214
 	 * @throws \EE_Error
215 215
 	 */
216
-	public function activate_a_payment_method_of_type( $payment_method_type ){
216
+	public function activate_a_payment_method_of_type($payment_method_type) {
217 217
 		$payment_method = EEM_Payment_Method::instance()->get_one_of_type($payment_method_type);
218
-		if( ! $payment_method instanceof EE_Payment_Method ){
218
+		if ( ! $payment_method instanceof EE_Payment_Method) {
219 219
 			$pm_type_class = $this->payment_method_class_from_type($payment_method_type);
220
-			if(class_exists($pm_type_class)){
220
+			if (class_exists($pm_type_class)) {
221 221
 				/** @var $pm_type_obj EE_PMT_Base */
222 222
 				$pm_type_obj = new $pm_type_class;
223 223
 				$payment_method = EEM_Payment_Method::instance()->get_one_by_slug($pm_type_obj->system_name());
224
-				if( ! $payment_method){
225
-					$payment_method = $this->create_payment_method_of_type( $pm_type_obj );
224
+				if ( ! $payment_method) {
225
+					$payment_method = $this->create_payment_method_of_type($pm_type_obj);
226 226
 				}
227
-				$payment_method->set_type( $payment_method_type );
228
-				$this->initialize_payment_method( $payment_method );
227
+				$payment_method->set_type($payment_method_type);
228
+				$this->initialize_payment_method($payment_method);
229 229
 			} else {
230 230
 				throw new EE_Error(
231 231
 					sprintf(
232
-						__( 'There is no payment method of type %1$s, so it could not be activated', 'event_espresso'),
232
+						__('There is no payment method of type %1$s, so it could not be activated', 'event_espresso'),
233 233
 						$pm_type_class )
234 234
 				);
235 235
 			}
236 236
 		}
237 237
 		$payment_method->set_active();
238 238
 		$payment_method->save();
239
-		$this->set_usable_currencies_on_payment_method( $payment_method );
240
-		if( $payment_method->type() == 'Invoice' ){
241
-			$messages = EE_Registry::instance()->load_lib( 'messages' );
242
-			$messages->ensure_message_type_is_active( 'invoice', 'html' );
243
-			$messages->ensure_messenger_is_active( 'pdf' );
239
+		$this->set_usable_currencies_on_payment_method($payment_method);
240
+		if ($payment_method->type() == 'Invoice') {
241
+			$messages = EE_Registry::instance()->load_lib('messages');
242
+			$messages->ensure_message_type_is_active('invoice', 'html');
243
+			$messages->ensure_messenger_is_active('pdf');
244 244
 			EE_Error::add_attention(
245 245
 				sprintf(
246
-					__( 'Note, when the invoice payment method is activated, the invoice message type, html messenger, and pdf messenger are activated as well for the %1$smessages system%2$s.', 'event_espresso' ),
247
-					'<a href="' . admin_url( 'admin.php?page=espresso_messages') . '">',
246
+					__('Note, when the invoice payment method is activated, the invoice message type, html messenger, and pdf messenger are activated as well for the %1$smessages system%2$s.', 'event_espresso'),
247
+					'<a href="'.admin_url('admin.php?page=espresso_messages').'">',
248 248
 					'</a>'
249 249
 				)
250 250
 			);
@@ -258,17 +258,17 @@  discard block
 block discarded – undo
258 258
 	 * @param EE_PMT_Base $pm_type_obj
259 259
 	 * @return EE_Payment_Method
260 260
 	 */
261
-	public function create_payment_method_of_type( $pm_type_obj ) {
261
+	public function create_payment_method_of_type($pm_type_obj) {
262 262
 		global $current_user;
263 263
 		$payment_method = EE_Payment_Method::new_instance(
264 264
 			array(
265 265
 				'PMD_type' 		 => $pm_type_obj->system_name(),
266 266
 				'PMD_name' 		 => $pm_type_obj->pretty_name(),
267 267
 				'PMD_admin_name' => $pm_type_obj->pretty_name(),
268
-				'PMD_slug' 		 => $pm_type_obj->system_name(),//automatically converted to slug
268
+				'PMD_slug' 		 => $pm_type_obj->system_name(), //automatically converted to slug
269 269
 				'PMD_wp_user' 	 => $current_user->ID,
270 270
 				'PMD_order' 	 => EEM_Payment_Method::instance()->count(
271
-						array( array( 'PMD_type' => array( '!=', 'Admin_Only' )))
271
+						array(array('PMD_type' => array('!=', 'Admin_Only')))
272 272
 					) * 10,
273 273
 			)
274 274
 		);
@@ -280,16 +280,16 @@  discard block
 block discarded – undo
280 280
 	 * @param EE_Payment_Method $payment_method
281 281
 	 * @return EE_Payment_Method
282 282
 	 */
283
-	public function initialize_payment_method( $payment_method ) {
283
+	public function initialize_payment_method($payment_method) {
284 284
 		$pm_type_obj = $payment_method->type_obj();
285
-		$payment_method->set_description( $pm_type_obj->default_description() );
286
-		if( ! $payment_method->button_url() ){
287
-			$payment_method->set_button_url( $pm_type_obj->default_button_url() );
285
+		$payment_method->set_description($pm_type_obj->default_description());
286
+		if ( ! $payment_method->button_url()) {
287
+			$payment_method->set_button_url($pm_type_obj->default_button_url());
288 288
 		}	
289 289
 		//now add setup its default extra meta properties
290 290
 		$extra_metas = $pm_type_obj->settings_form()->extra_meta_inputs();
291
-		foreach( $extra_metas as $meta_name => $input ){
292
-			$payment_method->update_extra_meta($meta_name, $input->raw_value() );
291
+		foreach ($extra_metas as $meta_name => $input) {
292
+			$payment_method->update_extra_meta($meta_name, $input->raw_value());
293 293
 		}
294 294
 		return $payment_method;
295 295
 	}
@@ -299,8 +299,8 @@  discard block
 block discarded – undo
299 299
 	 * @param EE_Payment_Method $payment_method
300 300
 	 * @return EE_Payment_Method
301 301
 	 */
302
-	public function set_usable_currencies_on_payment_method( $payment_method ) {
303
-		foreach($payment_method->get_all_usable_currencies() as $currency_obj){
302
+	public function set_usable_currencies_on_payment_method($payment_method) {
303
+		foreach ($payment_method->get_all_usable_currencies() as $currency_obj) {
304 304
 			$payment_method->_add_relation_to($currency_obj, 'Currency');
305 305
 		}
306 306
 		return $payment_method;
@@ -318,8 +318,8 @@  discard block
 block discarded – undo
318 318
 	 *
319 319
 	 * @return int count of rows updated.
320 320
 	 */
321
-	public function deactivate_payment_method( $payment_method_slug ) {
322
-		$count_updated = EEM_Payment_Method::instance()->update(array('PMD_scope'=>array()),array(array('PMD_slug'=>$payment_method_slug)));
321
+	public function deactivate_payment_method($payment_method_slug) {
322
+		$count_updated = EEM_Payment_Method::instance()->update(array('PMD_scope'=>array()), array(array('PMD_slug'=>$payment_method_slug)));
323 323
 		return $count_updated;
324 324
 	}
325 325
 
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 	 * @param array $caps capabilities being filtered
333 333
 	 * @return array
334 334
 	 */
335
-	public function add_payment_method_caps( $caps ) {
335
+	public function add_payment_method_caps($caps) {
336 336
 		/* add dynamic caps from payment methods
337 337
 		 * at the time of writing, october 20 2014, these are the caps added:
338 338
 		 * ee_payment_method_admin_only
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 		 * their related capability automatically added too, so long as they are
348 348
 		 * registered properly using EE_Register_Payment_Method::register()
349 349
 		 */
350
-		foreach( $this->payment_method_types() as $payment_method_type_obj ){
350
+		foreach ($this->payment_method_types() as $payment_method_type_obj) {
351 351
 			$caps['administrator'][] = $payment_method_type_obj->cap_name();
352 352
 		}
353 353
 		return $caps;
Please login to merge, or discard this patch.
core/db_models/EEM_Extra_Join.model.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,26 +21,26 @@
 block discarded – undo
21 21
  * @since		 	   $VID:$
22 22
  *
23 23
  */
24
-if (!defined('EVENT_ESPRESSO_VERSION')) {
24
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
25 25
 	exit('No direct script access allowed');
26 26
 }
27 27
 
28
-class EEM_Extra_Join extends EEM_Base{
28
+class EEM_Extra_Join extends EEM_Base {
29 29
 	// private instance of the Extra Join object
30 30
 	protected static $_instance = NULL;
31 31
 	
32 32
 	public function __construct($timezone = NULL) {
33
-		$models_this_can_join = array_keys( EE_Registry::instance()->non_abstract_db_models );
33
+		$models_this_can_join = array_keys(EE_Registry::instance()->non_abstract_db_models);
34 34
 		$this->_tables = array(
35
-			'Extra_Join' => new EE_Primary_Table( 'esp_extra_join', 'EXJ_ID' ),
35
+			'Extra_Join' => new EE_Primary_Table('esp_extra_join', 'EXJ_ID'),
36 36
 		);
37 37
 		$this->_fields = array(
38 38
 			'Extra_Join' => array(
39
-				'EXJ_ID' => new EE_Primary_Key_Int_Field( 'EXJ_ID', __( 'Extra Join ID', 'event_espresso' ) ),
40
-				'EXJ_first_model_ID' => new EE_Foreign_Key_String_Field( 'EXJ_first_model_ID', __( 'First Model ID', 'event_espresso' ), true, 0, $models_this_can_join ),
41
-				'EXJ_first_model_name' => new EE_Any_Foreign_Model_Name_Field( 'EXJ_first_model_name', __( 'First Model Name', 'event_espresso'), true, '', $models_this_can_join ),
42
-				'EXJ_second_model_ID' => new EE_Foreign_Key_String_Field( 'EXJ_second_model_ID', __( 'Second Model ID', 'event_espresso' ), true, 0, $models_this_can_join ),
43
-				'EXJ_second_model_name' => new EE_Any_Foreign_Model_Name_Field( 'EXJ_second_model_name', __( 'Second Model Name', 'event_espresso'), true, '', $models_this_can_join ),
39
+				'EXJ_ID' => new EE_Primary_Key_Int_Field('EXJ_ID', __('Extra Join ID', 'event_espresso')),
40
+				'EXJ_first_model_ID' => new EE_Foreign_Key_String_Field('EXJ_first_model_ID', __('First Model ID', 'event_espresso'), true, 0, $models_this_can_join),
41
+				'EXJ_first_model_name' => new EE_Any_Foreign_Model_Name_Field('EXJ_first_model_name', __('First Model Name', 'event_espresso'), true, '', $models_this_can_join),
42
+				'EXJ_second_model_ID' => new EE_Foreign_Key_String_Field('EXJ_second_model_ID', __('Second Model ID', 'event_espresso'), true, 0, $models_this_can_join),
43
+				'EXJ_second_model_name' => new EE_Any_Foreign_Model_Name_Field('EXJ_second_model_name', __('Second Model Name', 'event_espresso'), true, '', $models_this_can_join),
44 44
 				
45 45
 			)
46 46
 		);
Please login to merge, or discard this patch.
core/db_models/EEM_Base.model.php 2 patches
Doc Comments   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
 	 * Returns the name of the field's name that points to the WP_User table
742 742
 	 *  on this model (or follows the _model_chain_to_wp_user and uses that model's
743 743
 	 * foreign key to the WP_User table)
744
-	 * @return string|boolean string on success, boolean false when there is no
744
+	 * @return string|false string on success, boolean false when there is no
745 745
 	 * foreign key to the WP_User table
746 746
 	 */
747 747
 	function wp_user_field_name() {
@@ -837,6 +837,7 @@  discard block
 block discarded – undo
837 837
 	 * If you would like to use these custom selections in WHERE, GROUP_BY, or HAVING clauses, you must instead provide an array.
838 838
 	 * Array keys are the aliases used to refer to this selection, and values are to be numerically-indexed arrays, where 0 is the selection
839 839
 	 * and 1 is the data type. Eg, array('count'=>array('COUNT(REG_ID)','%d'))
840
+	 * @param string $columns_to_select
840 841
 	 * @return stdClass[] like results of $wpdb->get_results($sql,OBJECT), (ie, output type is OBJECT)
841 842
 	 */
842 843
 	public function  get_all_wpdb_results($query_params = array(), $output = ARRAY_A, $columns_to_select = null){
@@ -1139,7 +1140,7 @@  discard block
 block discarded – undo
1139 1140
 	 * @param bool   $pretty          Whether to return the pretty formats (true) or not (false).
1140 1141
 	 * @throws EE_Error   If the given field_name is not of the EE_Datetime_Field type.
1141 1142
 	 *
1142
-	 * @return array formats in an array with the date format first, and the time format last.
1143
+	 * @return string[] formats in an array with the date format first, and the time format last.
1143 1144
 	 */
1144 1145
 	public function get_formats_for( $field_name, $pretty = false ) {
1145 1146
 		$field_settings = $this->field_settings_for( $field_name );
@@ -1174,7 +1175,7 @@  discard block
 block discarded – undo
1174 1175
 	 *
1175 1176
 	 * @throws EE_Error   	If the given field_name is not of the EE_Datetime_Field type.
1176 1177
 	 *
1177
-	 * @return int|string  If the given field_name is not of the EE_Datetime_Field type, then an EE_Error
1178
+	 * @return string|null  If the given field_name is not of the EE_Datetime_Field type, then an EE_Error
1178 1179
 	 *                    	     exception is triggered.
1179 1180
 	 */
1180 1181
 	public function current_time_for_query( $field_name, $timestamp = false, $what = 'both' ) {
@@ -1474,7 +1475,7 @@  discard block
 block discarded – undo
1474 1475
 	 * Deletes a single row from the DB given the model object's primary key value. (eg, EE_Attendee->ID()'s value).
1475 1476
 	 * Wrapper for EEM_Base::delete()
1476 1477
 	 * @param mixed $id
1477
-	 * @return boolean whether the row got deleted or not
1478
+	 * @return integer whether the row got deleted or not
1478 1479
 	 */
1479 1480
 	public function delete_by_ID( $id ){
1480 1481
 		return $this->delete( array(
@@ -1834,7 +1835,7 @@  discard block
 block discarded – undo
1834 1835
 	/**
1835 1836
 	 * Verifies the EE addons' database is up-to-date and records that we've done it on
1836 1837
 	 * EEM_Base::$_db_verification_level
1837
-	 * @param $wpdb_method
1838
+	 * @param string $wpdb_method
1838 1839
 	 * @param $arguments_to_provide
1839 1840
 	 * @return string
1840 1841
 	 */
@@ -1902,7 +1903,6 @@  discard block
 block discarded – undo
1902 1903
 	 * 'hasAndBelongsToMany' relationships: checks that there isn't already an entry in the join table, and adds one.
1903 1904
 	 * If one of the model Objects has not yet been saved to the database, it is saved before adding the entry in the join table
1904 1905
 	 *
1905
-	 * @param EE_Base_Class/int $thisModelObject
1906 1906
 	 * @param EE_Base_Class/int $id_or_obj EE_base_Class or ID of other Model Object
1907 1907
 	 * @param string $relationName, key in EEM_Base::_relations
1908 1908
 	 * an attendee to a group, you also want to specify which role they will have in that group. So you would use this parameter to specify array('role-column-name'=>'role-id')
@@ -1924,8 +1924,8 @@  discard block
 block discarded – undo
1924 1924
 	 *
1925 1925
 	 * 'hasAndBelongsToMany' relationships:removes any existing entry in the join table between the two models.
1926 1926
 	 *
1927
-	 * @param EE_Base_Class/int $id_or_obj
1928
-	 * @param EE_Base_Class/int $other_model_id_or_obj EE_Base_Class or ID of other Model Object
1927
+	 * @param EE_CPT_Base $id_or_obj
1928
+	 * @param EE_Term_Taxonomy $other_model_id_or_obj EE_Base_Class or ID of other Model Object
1929 1929
 	 * @param string $relationName key in EEM_Base::_relations
1930 1930
 	 * @return boolean of success
1931 1931
 	 * @param array   $where_query This allows you to enter further query params for the relation to for relation to methods that allow you to further specify extra columns to join by (such as HABTM).  Keep in mind that the only acceptable query_params is strict "col" => "value" pairs because these will be inserted in any new rows created as well.
@@ -2001,7 +2001,7 @@  discard block
 block discarded – undo
2001 2001
 	/**
2002 2002
 	 * Instead of getting the related model objects, simply counts them. Ignores default_where_conditions by default,
2003 2003
 	 * unless otherwise specified in the $query_params
2004
-	 * @param int/EE_Base_Class $id_or_obj
2004
+	 * @param EE_Event $id_or_obj
2005 2005
 	 * @param string $model_name like 'Event', or 'Registration'
2006 2006
 	 * @param array $query_params like EEM_Base::get_all's
2007 2007
 	 * @param string $field_to_count name of field to count by. By default, uses primary key
@@ -2390,7 +2390,7 @@  discard block
 block discarded – undo
2390 2390
 	/**
2391 2391
 	 * Finds all the fields that correspond to the given table
2392 2392
 	 * @param string $table_alias, array key in EEM_Base::_tables
2393
-	 * @return EE_Model_Field_Base[]
2393
+	 * @return EE_Model_Field_Base
2394 2394
 	 */
2395 2395
 	function _get_fields_for_table($table_alias){
2396 2396
 		return $this->_fields[$table_alias];
@@ -3454,8 +3454,8 @@  discard block
 block discarded – undo
3454 3454
 	/**
3455 3455
 	 * gets the field object of type 'primary_key' from the fieldsSettings attribute.
3456 3456
 	 * Eg, on EE_Answer that would be ANS_ID field object
3457
-	 * @param $field_obj
3458
-	 * @return EE_Model_Field_Base
3457
+	 * @param EE_Model_Field_Base $field_obj
3458
+	 * @return boolean
3459 3459
 	 */
3460 3460
 	public function is_primary_key_field( $field_obj ){
3461 3461
 		return $field_obj instanceof EE_Primary_Key_Field_Base ? TRUE : FALSE;
@@ -3549,7 +3549,7 @@  discard block
 block discarded – undo
3549 3549
 	 * Gets the actual table for the table alias
3550 3550
 	 * @param string $table_alias eg Event, Event_Meta, Registration, Transaction, but maybe
3551 3551
 	 * a table alias with a model chain prefix, like 'Venue__Event_Venue___Event_Meta'. Either one works
3552
-	 * @return EE_Table_Base
3552
+	 * @return string
3553 3553
 	 */
3554 3554
 	function get_table_for_alias($table_alias){
3555 3555
 		$table_alias_sans_model_relation_chain_prefix = EE_Model_Parser::remove_table_alias_model_relation_chain_prefix($table_alias);
@@ -3676,7 +3676,7 @@  discard block
 block discarded – undo
3676 3676
 	 * The purpose of this method is to allow us to create a model object that is not in the db that holds default values.
3677 3677
 	 * A typical example of where this is used is when creating a new item and the initial load of a form.  We dont' necessarily want to test for if the object is present but just assume it is BUT load the defaults from the object (as set in the model_field!).
3678 3678
 	 *
3679
-	 * @return EE_Base_Class single EE_Base_Class object with default values for the properties.
3679
+	 * @return boolean single EE_Base_Class object with default values for the properties.
3680 3680
 	 */
3681 3681
 	public function create_default_object() {
3682 3682
 
@@ -4066,7 +4066,7 @@  discard block
 block discarded – undo
4066 4066
 	}
4067 4067
 	/**
4068 4068
 	 * Read comments for assume_values_already_prepared_by_model_object()
4069
-	 * @return int
4069
+	 * @return boolean
4070 4070
 	 */
4071 4071
 	public function get_assumption_concerning_values_already_prepared_by_model_object(){
4072 4072
 		return $this->_values_already_prepared_by_model_object;
Please login to merge, or discard this patch.
Spacing   +946 added lines, -946 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
  * @since 				EE4
24 24
  *
25 25
  */
26
-abstract class EEM_Base extends EE_Base{
26
+abstract class EEM_Base extends EE_Base {
27 27
 
28 28
 	//admin posty
29 29
 	//basic -> grants access to mine -> if they don't have it, select none
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 	 * Flag indicating whether this model has a primary key or not
229 229
 	 * @var boolean
230 230
 	 */
231
-	protected $_has_primary_key_field=null;
231
+	protected $_has_primary_key_field = null;
232 232
 
233 233
 	/**
234 234
 	 * Whether or not this model is based off a table in WP core only (CPTs should set
@@ -290,19 +290,19 @@  discard block
 block discarded – undo
290 290
 	 * operators that work like 'BETWEEN'.  Typically used for datetime calculations, i.e. "BETWEEN '12-1-2011' AND '12-31-2012'"
291 291
 	 * @var array
292 292
 	 */
293
-	protected $_between_style_operators = array( 'BETWEEN' );
293
+	protected $_between_style_operators = array('BETWEEN');
294 294
 
295 295
 	/**
296 296
 	 * operators that are used for handling NUll and !NULL queries.  Typically used for when checking if a row exists on a join table.
297 297
 	 * @var array
298 298
 	 */
299
-	protected $_null_style_operators = array( 'IS NOT NULL', 'IS NULL');
299
+	protected $_null_style_operators = array('IS NOT NULL', 'IS NULL');
300 300
 
301 301
 	/**
302 302
 	 * Allowed values for $query_params['order'] for ordering in queries
303 303
 	 * @var array
304 304
 	 */
305
-	protected $_allowed_order_values = array('asc','desc','ASC','DESC');
305
+	protected $_allowed_order_values = array('asc', 'desc', 'ASC', 'DESC');
306 306
 
307 307
 	/**
308 308
 	 * When these are keys in a WHERE or HAVING clause, they are handled much differently
@@ -316,13 +316,13 @@  discard block
 block discarded – undo
316 316
 	 * 'where', but 'where' clauses are so common that we thought we'd omit it
317 317
 	 * @var array
318 318
 	 */
319
-	private $_allowed_query_params = array(0, 'limit','order_by','group_by','having','force_join','order','on_join_limit','default_where_conditions', 'caps');
319
+	private $_allowed_query_params = array(0, 'limit', 'order_by', 'group_by', 'having', 'force_join', 'order', 'on_join_limit', 'default_where_conditions', 'caps');
320 320
 
321 321
 	/**
322 322
 	 * All the data types that can be used in $wpdb->prepare statements.
323 323
 	 * @var array
324 324
 	 */
325
-	private $_valid_wpdb_data_types = array('%d','%s','%f');
325
+	private $_valid_wpdb_data_types = array('%d', '%s', '%f');
326 326
 
327 327
 	/**
328 328
 	 * 	EE_Registry Object
@@ -355,17 +355,17 @@  discard block
 block discarded – undo
355 355
 	/**
356 356
 	 * constant used to show EEM_Base has not yet verified the db on this http request
357 357
 	 */
358
-	const db_verified_none 		= 0;
358
+	const db_verified_none = 0;
359 359
 	/**
360 360
 	 * constant used to show EEM_Base has verified the EE core db on this http request,
361 361
 	 * but not the addons' dbs
362 362
 	 */
363
-	const db_verified_core 		= 1;
363
+	const db_verified_core = 1;
364 364
 	/**
365 365
 	 * constant used to show EEM_Base has verified the addons' dbs (and implicitly
366 366
 	 * the EE core db too)
367 367
 	 */
368
-	const db_verified_addons 	= 2;
368
+	const db_verified_addons = 2;
369 369
 
370 370
 	/**
371 371
 	 * indicates whether an EEM_Base child has already re-verified the DB
@@ -396,13 +396,13 @@  discard block
 block discarded – undo
396 396
 	 * @param null $timezone
397 397
 	 * @throws \EE_Error
398 398
 	 */
399
-	protected function __construct( $timezone = NULL ){
399
+	protected function __construct($timezone = NULL) {
400 400
 		// check that the model has not been loaded too soon
401
-		if ( ! did_action( 'AHEE__EE_System__load_espresso_addons' )) {
402
-			throw new EE_Error (
401
+		if ( ! did_action('AHEE__EE_System__load_espresso_addons')) {
402
+			throw new EE_Error(
403 403
 				sprintf(
404
-					__( 'The %1$s model can not be loaded before the "AHEE__EE_System__load_espresso_addons" hook has been called. This gives other addons a chance to extend this model.', 'event_espresso' ),
405
-					get_class( $this )
404
+					__('The %1$s model can not be loaded before the "AHEE__EE_System__load_espresso_addons" hook has been called. This gives other addons a chance to extend this model.', 'event_espresso'),
405
+					get_class($this)
406 406
 				)
407 407
 			);
408 408
 		}
@@ -412,11 +412,11 @@  discard block
 block discarded – undo
412 412
 		 * just use EE_Register_Model_Extension
413 413
 		 * @var EE_Table_Base[] $_tables
414 414
 		 */
415
-		$this->_tables = apply_filters( 'FHEE__'.get_class($this).'__construct__tables', $this->_tables );
416
-		foreach($this->_tables as $table_alias => $table_obj){
415
+		$this->_tables = apply_filters('FHEE__'.get_class($this).'__construct__tables', $this->_tables);
416
+		foreach ($this->_tables as $table_alias => $table_obj) {
417 417
 			/** @var $table_obj EE_Table_Base */
418 418
 			$table_obj->_construct_finalize_with_alias($table_alias);
419
-			if( $table_obj instanceof EE_Secondary_Table ){
419
+			if ($table_obj instanceof EE_Secondary_Table) {
420 420
 				/** @var $table_obj EE_Secondary_Table */
421 421
 				$table_obj->_construct_finalize_set_table_to_join_with($this->_get_main_table());
422 422
 			}
@@ -426,48 +426,48 @@  discard block
 block discarded – undo
426 426
 		 * EE_Register_Model_Extension
427 427
 		 * @param EE_Model_Field_Base[] $_fields
428 428
 		 */
429
-		$this->_fields = apply_filters('FHEE__'.get_class($this).'__construct__fields',$this->_fields);
430
-		foreach($this->_fields as $table_alias => $fields_for_table){
431
-			if ( ! array_key_exists( $table_alias, $this->_tables )){
432
-				throw new EE_Error(sprintf(__("Table alias %s does not exist in EEM_Base child's _tables array. Only tables defined are %s",'event_espresso'),$table_alias,implode(",",$this->_fields)));
429
+		$this->_fields = apply_filters('FHEE__'.get_class($this).'__construct__fields', $this->_fields);
430
+		foreach ($this->_fields as $table_alias => $fields_for_table) {
431
+			if ( ! array_key_exists($table_alias, $this->_tables)) {
432
+				throw new EE_Error(sprintf(__("Table alias %s does not exist in EEM_Base child's _tables array. Only tables defined are %s", 'event_espresso'), $table_alias, implode(",", $this->_fields)));
433 433
 			}
434
-			foreach($fields_for_table as $field_name => $field_obj){
434
+			foreach ($fields_for_table as $field_name => $field_obj) {
435 435
 				/** @var $field_obj EE_Model_Field_Base | EE_Primary_Key_Field_Base */
436 436
 				//primary key field base has a slightly different _construct_finalize
437 437
 				/** @var $field_obj EE_Model_Field_Base */
438
-				$field_obj->_construct_finalize( $table_alias, $field_name, $this->get_this_model_name() );
438
+				$field_obj->_construct_finalize($table_alias, $field_name, $this->get_this_model_name());
439 439
 			}
440 440
 		}
441 441
 
442 442
 		// everything is related to Extra_Meta
443
-		if( get_class($this) != 'EEM_Extra_Meta'){
443
+		if (get_class($this) != 'EEM_Extra_Meta') {
444 444
 			//make extra meta related to everything, but don't block deleting things just
445 445
 			//because they have related extra meta info. For now just orphan those extra meta
446 446
 			//in the future we should automatically delete them
447
-			$this->_model_relations['Extra_Meta'] = new EE_Has_Many_Any_Relation( FALSE );
447
+			$this->_model_relations['Extra_Meta'] = new EE_Has_Many_Any_Relation(FALSE);
448 448
 		}
449 449
 		//and change logs
450
-		if( get_class( $this) !=  'EEM_Change_Log' ) {
451
-			$this->_model_relations[ 'Change_Log' ] = new EE_Has_Many_Any_Relation( FALSE );
450
+		if (get_class($this) != 'EEM_Change_Log') {
451
+			$this->_model_relations['Change_Log'] = new EE_Has_Many_Any_Relation(FALSE);
452 452
 		}
453 453
 		/**
454 454
 		 * Filters the list of relations on a model. It is best to NOT use this directly and instead just use
455 455
 		 * EE_Register_Model_Extension
456 456
 		 * @param EE_Model_Relation_Base[] $_model_relations
457 457
 		 */
458
-		$this->_model_relations = apply_filters('FHEE__'.get_class($this).'__construct__model_relations',$this->_model_relations);
459
-		foreach($this->_model_relations as $model_name => $relation_obj){
458
+		$this->_model_relations = apply_filters('FHEE__'.get_class($this).'__construct__model_relations', $this->_model_relations);
459
+		foreach ($this->_model_relations as $model_name => $relation_obj) {
460 460
 			/** @var $relation_obj EE_Model_Relation_Base */
461 461
 			$relation_obj->_construct_finalize_set_models($this->get_this_model_name(), $model_name);
462 462
 		}
463
-		foreach($this->_indexes as $index_name => $index_obj){
463
+		foreach ($this->_indexes as $index_name => $index_obj) {
464 464
 			/** @var $index_obj EE_Index */
465 465
 			$index_obj->_construct_finalize($index_name, $this->get_this_model_name());
466 466
 		}
467 467
 
468 468
 		$this->set_timezone($timezone);
469 469
 		//finalize default where condition strategy, or set default
470
-		if( ! $this->_default_where_conditions_strategy){
470
+		if ( ! $this->_default_where_conditions_strategy) {
471 471
 			//nothing was set during child constructor, so set default
472 472
 			$this->_default_where_conditions_strategy = new EE_Default_Where_Conditions();
473 473
 		}
@@ -475,15 +475,15 @@  discard block
 block discarded – undo
475 475
 
476 476
 		//if the cap slug hasn't been set, and we haven't set it to false on purpose
477 477
 		//to indicate to NOT set it, set it to the logical default
478
-		if( $this->_caps_slug === null ) {
479
-			EE_Registry::instance()->load_helper( 'Inflector' );
480
-			$this->_caps_slug = EEH_Inflector::pluralize_and_lower( $this->get_this_model_name() );
478
+		if ($this->_caps_slug === null) {
479
+			EE_Registry::instance()->load_helper('Inflector');
480
+			$this->_caps_slug = EEH_Inflector::pluralize_and_lower($this->get_this_model_name());
481 481
 		}
482 482
 		//initialize the standard cap restriction generators if none were specified by the child constructor
483
-		if( $this->_cap_restriction_generators !== false ){
484
-			foreach( $this->cap_contexts_to_cap_action_map() as $cap_context => $action ){
485
-				if( ! isset( $this->_cap_restriction_generators[ $cap_context ] ) ) {
486
-					$this->_cap_restriction_generators[ $cap_context ] = apply_filters(
483
+		if ($this->_cap_restriction_generators !== false) {
484
+			foreach ($this->cap_contexts_to_cap_action_map() as $cap_context => $action) {
485
+				if ( ! isset($this->_cap_restriction_generators[$cap_context])) {
486
+					$this->_cap_restriction_generators[$cap_context] = apply_filters(
487 487
 						'FHEE__EEM_Base___construct__standard_cap_restriction_generator',
488 488
 						new EE_Restriction_Generator_Protected(),
489 489
 						$cap_context,
@@ -493,23 +493,23 @@  discard block
 block discarded – undo
493 493
 			}
494 494
 		}
495 495
 		//if there are cap restriction generators, use them to make the default cap restrictions
496
-		if( $this->_cap_restriction_generators !== false ){
497
-			foreach( $this->_cap_restriction_generators as $context => $generator_object ) {
498
-				if( ! $generator_object ){
496
+		if ($this->_cap_restriction_generators !== false) {
497
+			foreach ($this->_cap_restriction_generators as $context => $generator_object) {
498
+				if ( ! $generator_object) {
499 499
 					continue;
500 500
 				}
501
-				if( ! $generator_object instanceof EE_Restriction_Generator_Base ){
501
+				if ( ! $generator_object instanceof EE_Restriction_Generator_Base) {
502 502
 					throw new EE_Error(
503 503
 						sprintf(
504
-							__( 'Index "%1$s" in the model %2$s\'s _cap_restriction_generators is not a child of EE_Restriction_Generator_Base. It should be that or NULL.', 'event_espresso' ),
504
+							__('Index "%1$s" in the model %2$s\'s _cap_restriction_generators is not a child of EE_Restriction_Generator_Base. It should be that or NULL.', 'event_espresso'),
505 505
 							$context,
506 506
 							$this->get_this_model_name()
507 507
 						)
508 508
 					);
509 509
 				}
510
-				$action = $this->cap_action_for_context( $context );
511
-				if( ! $generator_object->construction_finalized() ){
512
-					$generator_object->_construct_finalize( $this, $action );
510
+				$action = $this->cap_action_for_context($context);
511
+				if ( ! $generator_object->construction_finalized()) {
512
+					$generator_object->_construct_finalize($this, $action);
513 513
 				}
514 514
 
515 515
 			}
@@ -523,11 +523,11 @@  discard block
 block discarded – undo
523 523
 	 * @param string $context one of EEM_Base::valid_cap_contexts()
524 524
 	 * @return EE_Default_Where_Conditions[]
525 525
 	 */
526
-	protected function _generate_cap_restrictions( $context ){
527
-		if( isset( $this->_cap_restriction_generators[ $context ] ) &&
528
-				$this->_cap_restriction_generators[ $context ] instanceof EE_Restriction_Generator_Base ) {
529
-			return $this->_cap_restriction_generators[ $context ]->generate_restrictions();
530
-		}else{
526
+	protected function _generate_cap_restrictions($context) {
527
+		if (isset($this->_cap_restriction_generators[$context]) &&
528
+				$this->_cap_restriction_generators[$context] instanceof EE_Restriction_Generator_Base) {
529
+			return $this->_cap_restriction_generators[$context]->generate_restrictions();
530
+		} else {
531 531
 			return array();
532 532
 		}
533 533
 }
@@ -540,16 +540,16 @@  discard block
 block discarded – undo
540 540
 	 *		@param string $timezone string representing the timezone we want to set for returned Date Time Strings (and any incoming timezone data that gets saved).  Note this just sends the timezone info to the date time model field objects.  Default is NULL (and will be assumed using the set timezone in the 'timezone_string' wp option)
541 541
 	 *		@return static (as in the concrete child class)
542 542
 	 */
543
-	public static function instance( $timezone = NULL ){
543
+	public static function instance($timezone = NULL) {
544 544
 
545 545
 		// check if instance of Espresso_model already exists
546 546
 		if ( ! static::$_instance instanceof static) {
547 547
 			// instantiate Espresso_model
548
-			static::$_instance = new static( $timezone );
548
+			static::$_instance = new static($timezone);
549 549
 		}
550 550
 
551 551
 		//we might have a timezone set, let set_timezone decide what to do with it
552
-		static::$_instance->set_timezone( $timezone );
552
+		static::$_instance->set_timezone($timezone);
553 553
 
554 554
 		// Espresso_model object
555 555
 		return static::$_instance;
@@ -562,11 +562,11 @@  discard block
 block discarded – undo
562 562
 	 * @param null | string $timezone
563 563
 	 * @return static
564 564
 	 */
565
-	public static function reset(  $timezone = NULL ){
566
-		if ( ! is_null( static::$_instance ) ) {
565
+	public static function reset($timezone = NULL) {
566
+		if ( ! is_null(static::$_instance)) {
567 567
 			static::$_instance = null;
568 568
 
569
-			return self::instance( $timezone );
569
+			return self::instance($timezone);
570 570
 		}
571 571
 		return null;
572 572
 	}
@@ -577,15 +577,15 @@  discard block
 block discarded – undo
577 577
 	 * @param  boolean $translated return localized strings or JUST the array.
578 578
 	 * @return array
579 579
 	 */
580
-	 public function status_array( $translated = FALSE ) {
581
-	 	if ( !array_key_exists('Status', $this->_model_relations ) )
580
+	 public function status_array($translated = FALSE) {
581
+	 	if ( ! array_key_exists('Status', $this->_model_relations))
582 582
 	 		return array();
583 583
 	 	$model_name = $this->get_this_model_name();
584
-	 	$status_type = str_replace(' ', '_', strtolower( str_replace('_', ' ', $model_name) ) );
585
-	 	$stati = EEM_Status::instance()->get_all(array(array('STS_type' => $status_type) ) );
584
+	 	$status_type = str_replace(' ', '_', strtolower(str_replace('_', ' ', $model_name)));
585
+	 	$stati = EEM_Status::instance()->get_all(array(array('STS_type' => $status_type)));
586 586
 	 	$status_array = array();
587
-	 	foreach ( $stati as $status ) {
588
-            $status_array[ $status->ID() ] = $status->get('STS_code');
587
+	 	foreach ($stati as $status) {
588
+            $status_array[$status->ID()] = $status->get('STS_code');
589 589
         }
590 590
         return $translated ? EEM_Status::instance()->localized_status($status_array, FALSE, 'sentence') : $status_array;
591 591
     }
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
 	 *			'order_by'=>array('ANS_value'=>'ASC')
727 727
 	 *		));
728 728
 	 */
729
-	function get_all($query_params = array()){
729
+	function get_all($query_params = array()) {
730 730
 		return $this->_create_objects($this->_get_all_wpdb_results($query_params, ARRAY_A, NULL));
731 731
 	}
732 732
 
@@ -736,10 +736,10 @@  discard block
 block discarded – undo
736 736
 	 * @param array $query_params @see EEM_Base::get_all()
737 737
 	 * @return array like EEM_Base::get_all
738 738
 	 */
739
-	function alter_query_params_to_only_include_mine( $query_params = array() ) {
739
+	function alter_query_params_to_only_include_mine($query_params = array()) {
740 740
 		$wp_user_field_name = $this->wp_user_field_name();
741
-		if( $wp_user_field_name ){
742
-			$query_params[0][ $wp_user_field_name ] = get_current_user_id();
741
+		if ($wp_user_field_name) {
742
+			$query_params[0][$wp_user_field_name] = get_current_user_id();
743 743
 		}
744 744
 		return $query_params;
745 745
 	}
@@ -752,19 +752,19 @@  discard block
 block discarded – undo
752 752
 	 * foreign key to the WP_User table
753 753
 	 */
754 754
 	function wp_user_field_name() {
755
-		try{
756
-			if( ! empty( $this->_model_chain_to_wp_user ) ) {
757
-				$models_to_follow_to_wp_users = explode( '.', $this->_model_chain_to_wp_user );
758
-				$last_model_name = end( $models_to_follow_to_wp_users );
759
-				$model_with_fk_to_wp_users = EE_Registry::instance()->load_model( $last_model_name );
760
-				$model_chain_to_wp_user = $this->_model_chain_to_wp_user . '.';
761
-			}else{
755
+		try {
756
+			if ( ! empty($this->_model_chain_to_wp_user)) {
757
+				$models_to_follow_to_wp_users = explode('.', $this->_model_chain_to_wp_user);
758
+				$last_model_name = end($models_to_follow_to_wp_users);
759
+				$model_with_fk_to_wp_users = EE_Registry::instance()->load_model($last_model_name);
760
+				$model_chain_to_wp_user = $this->_model_chain_to_wp_user.'.';
761
+			} else {
762 762
 				$model_with_fk_to_wp_users = $this;
763 763
 				$model_chain_to_wp_user = '';
764 764
 			}
765
-			$wp_user_field = $model_with_fk_to_wp_users->get_foreign_key_to( 'WP_User' );
766
-			return $model_chain_to_wp_user . $wp_user_field->get_name();
767
-		}catch( EE_Error $e ) {
765
+			$wp_user_field = $model_with_fk_to_wp_users->get_foreign_key_to('WP_User');
766
+			return $model_chain_to_wp_user.$wp_user_field->get_name();
767
+		} catch (EE_Error $e) {
768 768
 			return false;
769 769
 		}
770 770
 	}
@@ -778,7 +778,7 @@  discard block
 block discarded – undo
778 778
 	 * (or transiently-related model)
779 779
 	 * @return string
780 780
 	 */
781
-	public function model_chain_to_wp_user(){
781
+	public function model_chain_to_wp_user() {
782 782
 		return $this->_model_chain_to_wp_user;
783 783
 	}
784 784
 
@@ -790,13 +790,13 @@  discard block
 block discarded – undo
790 790
 	 * @return boolean
791 791
 	 */
792 792
 	public function is_owned() {
793
-		if( $this->model_chain_to_wp_user() ){
793
+		if ($this->model_chain_to_wp_user()) {
794 794
 			return true;
795
-		}else{
796
-			try{
797
-				$this->get_foreign_key_to( 'WP_User' );
795
+		} else {
796
+			try {
797
+				$this->get_foreign_key_to('WP_User');
798 798
 				return true;
799
-			}catch( EE_Error $e ){
799
+			} catch (EE_Error $e) {
800 800
 				return false;
801 801
 			}
802 802
 		}
@@ -815,21 +815,21 @@  discard block
 block discarded – undo
815 815
 	 * and 1 is the data type. Eg, array('count'=>array('COUNT(REG_ID)','%d'))
816 816
 	 * @return array | stdClass[] like results of $wpdb->get_results($sql,OBJECT), (ie, output type is OBJECT)
817 817
 	 */
818
-	protected function  _get_all_wpdb_results($query_params = array(), $output = ARRAY_A, $columns_to_select = null){
818
+	protected function  _get_all_wpdb_results($query_params = array(), $output = ARRAY_A, $columns_to_select = null) {
819 819
 		//remember the custom selections, if any
820
-		if(is_array($columns_to_select)){
820
+		if (is_array($columns_to_select)) {
821 821
 			$this->_custom_selections = $columns_to_select;
822
-		}elseif(is_string($columns_to_select)){
822
+		}elseif (is_string($columns_to_select)) {
823 823
 			$this->_custom_selections = array($this->_custom_selections);
824
-		}else{
824
+		} else {
825 825
 			$this->_custom_selections = array();
826 826
 		}
827 827
 
828 828
 		$model_query_info = $this->_create_model_query_info_carrier($query_params);
829 829
 		$select_expressions = $columns_to_select ? $this->_construct_select_from_input($columns_to_select) : $this->_construct_default_select_sql($model_query_info);
830
-		$SQL ="SELECT $select_expressions ".$this->_construct_2nd_half_of_select_query($model_query_info);
830
+		$SQL = "SELECT $select_expressions ".$this->_construct_2nd_half_of_select_query($model_query_info);
831 831
 //		echo "sql:$SQL";
832
-		$results =  $this->_do_wpdb_query( 'get_results', array($SQL, $output ) );// $wpdb->get_results($SQL, $output);
832
+		$results = $this->_do_wpdb_query('get_results', array($SQL, $output)); // $wpdb->get_results($SQL, $output);
833 833
 		return $results;
834 834
 	}
835 835
 
@@ -847,7 +847,7 @@  discard block
 block discarded – undo
847 847
 	 * and 1 is the data type. Eg, array('count'=>array('COUNT(REG_ID)','%d'))
848 848
 	 * @return array|stdClass[] like results of $wpdb->get_results($sql,OBJECT), (ie, output type is OBJECT)
849 849
 	 */
850
-	public function  get_all_wpdb_results($query_params = array(), $output = ARRAY_A, $columns_to_select = null){
850
+	public function  get_all_wpdb_results($query_params = array(), $output = ARRAY_A, $columns_to_select = null) {
851 851
 		return $this->_get_all_wpdb_results($query_params, $output, $columns_to_select);
852 852
 	}
853 853
 
@@ -859,12 +859,12 @@  discard block
 block discarded – undo
859 859
 	 * @throws EE_Error
860 860
 	 * @return string
861 861
 	 */
862
-	private function _construct_select_from_input($columns_to_select){
863
-		if(is_array($columns_to_select)){
862
+	private function _construct_select_from_input($columns_to_select) {
863
+		if (is_array($columns_to_select)) {
864 864
 			$select_sql_array = array();
865 865
 
866
-			foreach($columns_to_select as $alias => $selection_and_datatype){
867
-				if( ! is_array($selection_and_datatype) || ! isset($selection_and_datatype[1])){
866
+			foreach ($columns_to_select as $alias => $selection_and_datatype) {
867
+				if ( ! is_array($selection_and_datatype) || ! isset($selection_and_datatype[1])) {
868 868
 					throw new EE_Error(
869 869
 						sprintf(
870 870
 							__(
@@ -876,24 +876,24 @@  discard block
 block discarded – undo
876 876
 						)
877 877
 					);
878 878
 				}
879
-				if( ! in_array( $selection_and_datatype[1],$this->_valid_wpdb_data_types)){
879
+				if ( ! in_array($selection_and_datatype[1], $this->_valid_wpdb_data_types)) {
880 880
 					throw new EE_Error(
881 881
 						sprintf(
882 882
 							__(
883 883
 								"Datatype %s (for selection '%s' and alias '%s') is not a valid wpdb datatype (eg %%s)",
884 884
 								"event_espresso"
885 885
 							),
886
-							$selection_and_datatype[ 1 ],
887
-							$selection_and_datatype[ 0 ],
886
+							$selection_and_datatype[1],
887
+							$selection_and_datatype[0],
888 888
 							$alias,
889
-							implode( ",", $this->_valid_wpdb_data_types )
889
+							implode(",", $this->_valid_wpdb_data_types)
890 890
 						)
891 891
 					);
892 892
 				}
893 893
 				$select_sql_array[] = "{$selection_and_datatype[0]} AS $alias";
894 894
 			}
895
-			$columns_to_select_string = implode(", ",$select_sql_array);
896
-		}else{
895
+			$columns_to_select_string = implode(", ", $select_sql_array);
896
+		} else {
897 897
 			$columns_to_select_string = $columns_to_select;
898 898
 		}
899 899
 		return $columns_to_select_string;
@@ -906,7 +906,7 @@  discard block
 block discarded – undo
906 906
 	 * Convenient wrapper for getting the primary key field's name. Eg, on Registration, this would be 'REG_ID'
907 907
 	 * @return string
908 908
 	 */
909
-	function primary_key_name(){
909
+	function primary_key_name() {
910 910
 		return $this->get_primary_key_field()->get_name();
911 911
 	}
912 912
 
@@ -918,15 +918,15 @@  discard block
 block discarded – undo
918 918
 	 * @param mixed $id int or string, depending on the type of the model's primary key
919 919
 	 * @return EE_Base_Class
920 920
 	 */
921
-	function get_one_by_ID($id){
922
-		if( $this->get_from_entity_map( $id ) ){
923
-			return $this->get_from_entity_map( $id );
924
-		}elseif( $this->has_primary_key_field ( ) ) {
921
+	function get_one_by_ID($id) {
922
+		if ($this->get_from_entity_map($id)) {
923
+			return $this->get_from_entity_map($id);
924
+		}elseif ($this->has_primary_key_field( )) {
925 925
 			$primary_key_name = $this->get_primary_key_field()->get_name();
926 926
 			return $this->get_one(array(array($primary_key_name => $id)));
927
-		}else{
927
+		} else {
928 928
 			//no primary key, so the $id must be from the get_index_primary_key_string()
929
-			return $this->get_one( array( $this->parse_index_primary_key_string( $id ) ) );
929
+			return $this->get_one(array($this->parse_index_primary_key_string($id)));
930 930
 		}
931 931
 	}
932 932
 
@@ -937,16 +937,16 @@  discard block
 block discarded – undo
937 937
 	 * @param array $query_params like EEM_Base's $query_params variable.
938 938
 	 * @return EE_Base_Class | NULL
939 939
 	 */
940
-	function get_one($query_params = array()){
941
-		if( ! is_array( $query_params ) ){
942
-			EE_Error::doing_it_wrong('EEM_Base::get_one', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
940
+	function get_one($query_params = array()) {
941
+		if ( ! is_array($query_params)) {
942
+			EE_Error::doing_it_wrong('EEM_Base::get_one', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
943 943
 			$query_params = array();
944 944
 		}
945 945
 		$query_params['limit'] = 1;
946 946
 		$items = $this->get_all($query_params);
947
-		if(empty($items)){
947
+		if (empty($items)) {
948 948
 			return null;
949
-		}else{
949
+		} else {
950 950
 			return array_shift($items);
951 951
 		}
952 952
 	}
@@ -970,8 +970,8 @@  discard block
 block discarded – undo
970 970
 	 *
971 971
 	 * @return EE_Base_Class[]|array
972 972
 	 */
973
-	public function next_x( $current_field_value, $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null ) {
974
-		return $this->_get_consecutive( $current_field_value, '>', $field_to_order_by, $limit, $query_params, $columns_to_select );
973
+	public function next_x($current_field_value, $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null) {
974
+		return $this->_get_consecutive($current_field_value, '>', $field_to_order_by, $limit, $query_params, $columns_to_select);
975 975
 	}
976 976
 
977 977
 
@@ -994,8 +994,8 @@  discard block
 block discarded – undo
994 994
 	 *
995 995
 	 * @return EE_Base_Class[]|array
996 996
 	 */
997
-	public function previous_x( $current_field_value, $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null ) {
998
-		return $this->_get_consecutive( $current_field_value, '<', $field_to_order_by, $limit, $query_params, $columns_to_select );
997
+	public function previous_x($current_field_value, $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null) {
998
+		return $this->_get_consecutive($current_field_value, '<', $field_to_order_by, $limit, $query_params, $columns_to_select);
999 999
 	}
1000 1000
 
1001 1001
 
@@ -1017,9 +1017,9 @@  discard block
 block discarded – undo
1017 1017
 	 *
1018 1018
 	 * @return EE_Base_Class|null|array()
1019 1019
 	 */
1020
-	public function next( $current_field_value, $field_to_order_by = null, $query_params = array(), $columns_to_select = null ) {
1021
-		$results = $this->_get_consecutive( $current_field_value, '>', $field_to_order_by, 1, $query_params, $columns_to_select );
1022
-		return empty( $results ) ? null : reset( $results );
1020
+	public function next($current_field_value, $field_to_order_by = null, $query_params = array(), $columns_to_select = null) {
1021
+		$results = $this->_get_consecutive($current_field_value, '>', $field_to_order_by, 1, $query_params, $columns_to_select);
1022
+		return empty($results) ? null : reset($results);
1023 1023
 	}
1024 1024
 
1025 1025
 
@@ -1041,9 +1041,9 @@  discard block
 block discarded – undo
1041 1041
 	 *
1042 1042
 	 * @return EE_Base_Class|null|array()
1043 1043
 	 */
1044
-	public function previous( $current_field_value, $field_to_order_by = null, $query_params = array(), $columns_to_select = null ) {
1045
-		$results = $this->_get_consecutive( $current_field_value, '<', $field_to_order_by, 1, $query_params, $columns_to_select );
1046
-		return empty( $results ) ? null : reset( $results );
1044
+	public function previous($current_field_value, $field_to_order_by = null, $query_params = array(), $columns_to_select = null) {
1045
+		$results = $this->_get_consecutive($current_field_value, '<', $field_to_order_by, 1, $query_params, $columns_to_select);
1046
+		return empty($results) ? null : reset($results);
1047 1047
 	}
1048 1048
 
1049 1049
 
@@ -1069,40 +1069,40 @@  discard block
 block discarded – undo
1069 1069
 	 * @return EE_Base_Class[]|array
1070 1070
 	 * @throws EE_Error
1071 1071
 	 */
1072
-	protected function _get_consecutive( $current_field_value, $operand = '>', $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null ) {
1072
+	protected function _get_consecutive($current_field_value, $operand = '>', $field_to_order_by = null, $limit = 1, $query_params = array(), $columns_to_select = null) {
1073 1073
 		//if $field_to_order_by is empty then let's assume we're ordering by the primary key.
1074
-		if ( empty( $field_to_order_by ) ) {
1075
-			if ( $this->has_primary_key_field() ) {
1074
+		if (empty($field_to_order_by)) {
1075
+			if ($this->has_primary_key_field()) {
1076 1076
 				$field_to_order_by = $this->get_primary_key_field()->get_name();
1077 1077
 			} else {
1078 1078
 
1079
-				if ( WP_DEBUG ) {
1080
-					throw new EE_Error( __( 'EEM_Base::_get_consecutive() has been called with no $field_to_order_by argument and there is no primary key on the field.  Please provide the field you would like to use as the base for retrieving the next item(s).', 'event_espresso' ) );
1079
+				if (WP_DEBUG) {
1080
+					throw new EE_Error(__('EEM_Base::_get_consecutive() has been called with no $field_to_order_by argument and there is no primary key on the field.  Please provide the field you would like to use as the base for retrieving the next item(s).', 'event_espresso'));
1081 1081
 				}
1082
-				EE_Error::add_error( __('There was an error with the query.', 'event_espresso') );
1082
+				EE_Error::add_error(__('There was an error with the query.', 'event_espresso'));
1083 1083
 				return array();
1084 1084
 			}
1085 1085
 		}
1086 1086
 
1087
-		if( ! is_array( $query_params ) ){
1088
-			EE_Error::doing_it_wrong('EEM_Base::_get_consecutive', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
1087
+		if ( ! is_array($query_params)) {
1088
+			EE_Error::doing_it_wrong('EEM_Base::_get_consecutive', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
1089 1089
 			$query_params = array();
1090 1090
 		}
1091 1091
 
1092 1092
 		//let's add the where query param for consecutive look up.
1093
-		$query_params[0][ $field_to_order_by ] = array( $operand, $current_field_value );
1093
+		$query_params[0][$field_to_order_by] = array($operand, $current_field_value);
1094 1094
 		$query_params['limit'] = $limit;
1095 1095
 
1096 1096
 		//set direction
1097
-		$incoming_orderby = isset( $query_params['order_by'] ) ? $query_params['order_by'] : array();
1098
-		$query_params['order_by'] = $operand == '>' ? array( $field_to_order_by => 'ASC' ) + $incoming_orderby : array( $field_to_order_by => 'DESC') + $incoming_orderby;
1097
+		$incoming_orderby = isset($query_params['order_by']) ? $query_params['order_by'] : array();
1098
+		$query_params['order_by'] = $operand == '>' ? array($field_to_order_by => 'ASC') + $incoming_orderby : array($field_to_order_by => 'DESC') + $incoming_orderby;
1099 1099
 
1100 1100
 		//if $columns_to_select is empty then that means we're returning EE_Base_Class objects
1101
-		if ( empty( $columns_to_select ) ) {
1102
-			return $this->get_all( $query_params );
1101
+		if (empty($columns_to_select)) {
1102
+			return $this->get_all($query_params);
1103 1103
 		} else {
1104 1104
 			//getting just the fields
1105
-			return $this->_get_all_wpdb_results( $query_params, ARRAY_A, $columns_to_select );
1105
+			return $this->_get_all_wpdb_results($query_params, ARRAY_A, $columns_to_select);
1106 1106
 		}
1107 1107
 	}
1108 1108
 
@@ -1113,18 +1113,18 @@  discard block
 block discarded – undo
1113 1113
 	 * This sets the _timezone property after model object has been instantiated.
1114 1114
 	 * @param null | string $timezone valid PHP DateTimeZone timezone string
1115 1115
 	 */
1116
-	public function set_timezone( $timezone ) {
1117
-		if ( $timezone !== null ) {
1116
+	public function set_timezone($timezone) {
1117
+		if ($timezone !== null) {
1118 1118
 			$this->_timezone = $timezone;
1119 1119
 		}
1120 1120
 		//note we need to loop through relations and set the timezone on those objects as well.
1121
-		foreach ( $this->_model_relations as $relation ) {
1122
-			$relation->set_timezone( $timezone );
1121
+		foreach ($this->_model_relations as $relation) {
1122
+			$relation->set_timezone($timezone);
1123 1123
 		}
1124 1124
 		//and finally we do the same for any datetime fields
1125
-		foreach ( $this->_fields as $field ) {
1126
-			if ( $field instanceof EE_Datetime_Field ) {
1127
-				$field->set_timezone( $timezone );
1125
+		foreach ($this->_fields as $field) {
1126
+			if ($field instanceof EE_Datetime_Field) {
1127
+				$field->set_timezone($timezone);
1128 1128
 			}
1129 1129
 		}
1130 1130
 	}
@@ -1139,9 +1139,9 @@  discard block
 block discarded – undo
1139 1139
 	 */
1140 1140
 	public function get_timezone() {
1141 1141
 		//first validate if timezone is set.  If not, then let's set it be whatever is set on the model fields.
1142
-		if ( empty( $this->_timezone ) ) {
1143
-			foreach( $this->_fields as $field ) {
1144
-				if ( $field instanceof EE_Datetime_Field ) {
1142
+		if (empty($this->_timezone)) {
1143
+			foreach ($this->_fields as $field) {
1144
+				if ($field instanceof EE_Datetime_Field) {
1145 1145
 					$this->set_timezone($field->get_timezone());
1146 1146
 					break;
1147 1147
 				}
@@ -1149,9 +1149,9 @@  discard block
 block discarded – undo
1149 1149
 		}
1150 1150
 
1151 1151
 		//if timezone STILL empty then return the default timezone for the site.
1152
-		if ( empty( $this->_timezone ) ) {
1153
-			EE_Registry::instance()->load_helper( 'DTT_Helper' );
1154
-			$this->set_timezone( EEH_DTT_Helper::get_timezone() );
1152
+		if (empty($this->_timezone)) {
1153
+			EE_Registry::instance()->load_helper('DTT_Helper');
1154
+			$this->set_timezone(EEH_DTT_Helper::get_timezone());
1155 1155
 		}
1156 1156
 		return $this->_timezone;
1157 1157
 	}
@@ -1169,19 +1169,19 @@  discard block
 block discarded – undo
1169 1169
 	 *
1170 1170
 	 * @return array formats in an array with the date format first, and the time format last.
1171 1171
 	 */
1172
-	public function get_formats_for( $field_name, $pretty = false ) {
1173
-		$field_settings = $this->field_settings_for( $field_name );
1172
+	public function get_formats_for($field_name, $pretty = false) {
1173
+		$field_settings = $this->field_settings_for($field_name);
1174 1174
 
1175 1175
 		//if not a valid EE_Datetime_Field then throw error
1176
-		if ( ! $field_settings instanceof EE_Datetime_Field ) {
1177
-			throw new EE_Error( sprintf( __('The field sent into EEM_Base::get_formats_for (%s) is not registered as a EE_Datetime_Field. Please check the spelling and make sure you are submitting the right field name to retrieve date_formats for.', 'event_espresso' ), $field_name ) );
1176
+		if ( ! $field_settings instanceof EE_Datetime_Field) {
1177
+			throw new EE_Error(sprintf(__('The field sent into EEM_Base::get_formats_for (%s) is not registered as a EE_Datetime_Field. Please check the spelling and make sure you are submitting the right field name to retrieve date_formats for.', 'event_espresso'), $field_name));
1178 1178
 		}
1179 1179
 
1180 1180
 		//while we are here, let's make sure the timezone internally in EEM_Base matches what is stored on
1181 1181
 		//the field.
1182 1182
 		$this->_timezone = $field_settings->get_timezone();
1183 1183
 
1184
-		return array( $field_settings->get_date_format( $pretty ), $field_settings->get_time_format( $pretty ) );
1184
+		return array($field_settings->get_date_format($pretty), $field_settings->get_time_format($pretty));
1185 1185
 	}
1186 1186
 
1187 1187
 
@@ -1205,25 +1205,25 @@  discard block
 block discarded – undo
1205 1205
 	 * @return int|string  If the given field_name is not of the EE_Datetime_Field type, then an EE_Error
1206 1206
 	 *                    	     exception is triggered.
1207 1207
 	 */
1208
-	public function current_time_for_query( $field_name, $timestamp = false, $what = 'both' ) {
1209
-		$formats = $this->get_formats_for( $field_name );
1208
+	public function current_time_for_query($field_name, $timestamp = false, $what = 'both') {
1209
+		$formats = $this->get_formats_for($field_name);
1210 1210
 
1211
-		$DateTime = new DateTime( "now", new DateTimeZone( $this->_timezone ) );
1211
+		$DateTime = new DateTime("now", new DateTimeZone($this->_timezone));
1212 1212
 
1213
-		if ( $timestamp ) {
1214
-			return $DateTime->format( 'U' );
1213
+		if ($timestamp) {
1214
+			return $DateTime->format('U');
1215 1215
 		}
1216 1216
 
1217 1217
 		//not returning timestamp, so return formatted string in timezone.
1218
-		switch( $what ) {
1218
+		switch ($what) {
1219 1219
 			case 'time' :
1220
-				return $DateTime->format( $formats[1] );
1220
+				return $DateTime->format($formats[1]);
1221 1221
 				break;
1222 1222
 			case 'date' :
1223
-				return $DateTime->format( $formats[0] );
1223
+				return $DateTime->format($formats[0]);
1224 1224
 				break;
1225 1225
 			default :
1226
-				return $DateTime->format( implode( ' ', $formats ) );
1226
+				return $DateTime->format(implode(' ', $formats));
1227 1227
 				break;
1228 1228
 		}
1229 1229
 	}
@@ -1247,18 +1247,18 @@  discard block
 block discarded – undo
1247 1247
 	 *                           		'U', this is ignored.
1248 1248
 	 * @return DateTime
1249 1249
 	 */
1250
-	public function convert_datetime_for_query( $field_name, $timestring, $incoming_format, $timezone = '' ) {
1250
+	public function convert_datetime_for_query($field_name, $timestring, $incoming_format, $timezone = '') {
1251 1251
 
1252 1252
 		//just using this to ensure the timezone is set correctly internally
1253
-		$this->get_formats_for( $field_name );
1253
+		$this->get_formats_for($field_name);
1254 1254
 
1255 1255
 		//load EEH_DTT_Helper
1256
-		EE_Registry::instance()->load_helper( 'DTT_Helper' );
1257
-		$set_timezone = empty( $timezone ) ? EEH_DTT_Helper::get_timezone() : $timezone;
1256
+		EE_Registry::instance()->load_helper('DTT_Helper');
1257
+		$set_timezone = empty($timezone) ? EEH_DTT_Helper::get_timezone() : $timezone;
1258 1258
 
1259
-		$incomingDateTime = date_create_from_format( $incoming_format, $timestring, new DateTimeZone( $set_timezone ) );
1259
+		$incomingDateTime = date_create_from_format($incoming_format, $timestring, new DateTimeZone($set_timezone));
1260 1260
 
1261
-		return $incomingDateTime->setTimeZone( new DateTimeZone( $this->_timezone ) );
1261
+		return $incomingDateTime->setTimeZone(new DateTimeZone($this->_timezone));
1262 1262
 	}
1263 1263
 
1264 1264
 
@@ -1268,7 +1268,7 @@  discard block
 block discarded – undo
1268 1268
 	 * Gets all the tables comprising this model. Array keys are the table aliases, and values are EE_Table objects
1269 1269
 	 * @return EE_Table_Base[]
1270 1270
 	 */
1271
-	function get_tables(){
1271
+	function get_tables() {
1272 1272
 		return $this->_tables;
1273 1273
 	}
1274 1274
 
@@ -1302,9 +1302,9 @@  discard block
 block discarded – undo
1302 1302
 	 * be aware that model objects being used could get out-of-sync with the database
1303 1303
 	 * @return int how many rows got updated or FALSE if something went wrong with the query (wp returns FALSE or num rows affected which *could* include 0 which DOES NOT mean the query was bad)
1304 1304
 	 */
1305
-	function update($fields_n_values, $query_params, $keep_model_objs_in_sync = TRUE){
1306
-		if( ! is_array( $query_params ) ){
1307
-			EE_Error::doing_it_wrong('EEM_Base::update', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
1305
+	function update($fields_n_values, $query_params, $keep_model_objs_in_sync = TRUE) {
1306
+		if ( ! is_array($query_params)) {
1307
+			EE_Error::doing_it_wrong('EEM_Base::update', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
1308 1308
 			$query_params = array();
1309 1309
 		}
1310 1310
 		/**
@@ -1314,7 +1314,7 @@  discard block
 block discarded – undo
1314 1314
 		 * @param array $fields_n_values the updated fields and their new values
1315 1315
 		 * @param array $query_params @see EEM_Base::get_all()
1316 1316
 		 */
1317
-		do_action( 'AHEE__EEM_Base__update__begin',$this, $fields_n_values, $query_params );
1317
+		do_action('AHEE__EEM_Base__update__begin', $this, $fields_n_values, $query_params);
1318 1318
 		/**
1319 1319
 		 * Filters the fields about to be updated given the query parameters. You can provide the
1320 1320
 		 * $query_params to $this->get_all() to find exactly which records will be updated
@@ -1322,10 +1322,10 @@  discard block
 block discarded – undo
1322 1322
 		 * @param EEM_Base $model the model being queried
1323 1323
 		 * @param array $query_params see EEM_Base::get_all()
1324 1324
 		 */
1325
-		$fields_n_values = apply_filters( 'FHEE__EEM_Base__update__fields_n_values', $fields_n_values, $this, $query_params );
1325
+		$fields_n_values = apply_filters('FHEE__EEM_Base__update__fields_n_values', $fields_n_values, $this, $query_params);
1326 1326
 		//need to verify that, for any entry we want to update, there are entries in each secondary table.
1327 1327
 		//to do that, for each table, verify that it's PK isn't null.
1328
-		$tables= $this->get_tables();
1328
+		$tables = $this->get_tables();
1329 1329
 
1330 1330
 		//and if the other tables don't have a row for each table-to-be-updated, we'll insert one with whatever values available in the current update query
1331 1331
 		//NOTE: we should make this code more efficient by NOT querying twice
@@ -1335,29 +1335,29 @@  discard block
 block discarded – undo
1335 1335
 			//we want to make sure the default_where strategy is ignored
1336 1336
 			$this->_ignore_where_strategy = TRUE;
1337 1337
 			$wpdb_select_results = $this->_get_all_wpdb_results($query_params);
1338
-			foreach( $wpdb_select_results as $wpdb_result ){
1338
+			foreach ($wpdb_select_results as $wpdb_result) {
1339 1339
 				// type cast stdClass as array
1340
-				$wpdb_result = (array)$wpdb_result;
1340
+				$wpdb_result = (array) $wpdb_result;
1341 1341
 				//get the model object's PK, as we'll want this if we need to insert a row into secondary tables
1342
-				if( $this->has_primary_key_field() ){
1343
-					$main_table_pk_value = $wpdb_result[ $this->get_primary_key_field()->get_qualified_column() ];
1344
-				}else{
1342
+				if ($this->has_primary_key_field()) {
1343
+					$main_table_pk_value = $wpdb_result[$this->get_primary_key_field()->get_qualified_column()];
1344
+				} else {
1345 1345
 					//if there's no primary key, we basically can't support having a 2nd table on the model (we could but it would be lots of work)
1346 1346
 					$main_table_pk_value = null;
1347 1347
 				}
1348 1348
 				//if there are more than 1 tables, we'll want to verify that each table for this model has an entry in the other tables
1349 1349
 				//and if the other tables don't have a row for each table-to-be-updated, we'll insert one with whatever values available in the current update query
1350
-				if(count($tables) > 1){
1350
+				if (count($tables) > 1) {
1351 1351
 					//foreach matching row in the DB, ensure that each table's PK isn't null. If so, there must not be an entry
1352 1352
 					//in that table, and so we'll want to insert one
1353
-					foreach($tables as $table_obj){
1353
+					foreach ($tables as $table_obj) {
1354 1354
 						$this_table_pk_column = $table_obj->get_fully_qualified_pk_column();
1355 1355
 						//if there is no private key for this table on the results, it means there's no entry
1356 1356
 						//in this table, right? so insert a row in the current table, using any fields available
1357
-						if( ! ( array_key_exists( $this_table_pk_column, $wpdb_result) && $wpdb_result[ $this_table_pk_column ] )){
1357
+						if ( ! (array_key_exists($this_table_pk_column, $wpdb_result) && $wpdb_result[$this_table_pk_column])) {
1358 1358
 							$success = $this->_insert_into_specific_table($table_obj, $fields_n_values, $main_table_pk_value);
1359 1359
 							//if we died here, report the error
1360
-							if( ! $success ) {
1360
+							if ( ! $success) {
1361 1361
 								return false;
1362 1362
 							}
1363 1363
 						}
@@ -1377,44 +1377,44 @@  discard block
 block discarded – undo
1377 1377
 		//if this wasn't called from a model object (to update itself)
1378 1378
 		//then we want to make sure we keep all the existing
1379 1379
 		//model objects in sync with the db
1380
-		if( $keep_model_objs_in_sync && ! $this->_values_already_prepared_by_model_object ){
1381
-			if( $this->has_primary_key_field() ){
1382
-				$model_objs_affected_ids = $this->get_col( $query_params );
1383
-			}else{
1380
+		if ($keep_model_objs_in_sync && ! $this->_values_already_prepared_by_model_object) {
1381
+			if ($this->has_primary_key_field()) {
1382
+				$model_objs_affected_ids = $this->get_col($query_params);
1383
+			} else {
1384 1384
 				//we need to select a bunch of columns and then combine them into the the "index primary key string"s
1385
-				$models_affected_key_columns = $this->_get_all_wpdb_results($query_params, ARRAY_A );
1385
+				$models_affected_key_columns = $this->_get_all_wpdb_results($query_params, ARRAY_A);
1386 1386
 				$model_objs_affected_ids = array();
1387
-				foreach( $models_affected_key_columns as $row ){
1388
-					$combined_index_key = $this->get_index_primary_key_string( $row );
1389
-					$model_objs_affected_ids[ $combined_index_key ] = $combined_index_key;
1387
+				foreach ($models_affected_key_columns as $row) {
1388
+					$combined_index_key = $this->get_index_primary_key_string($row);
1389
+					$model_objs_affected_ids[$combined_index_key] = $combined_index_key;
1390 1390
 				}
1391 1391
 
1392 1392
 			}
1393 1393
 
1394
-			if( ! $model_objs_affected_ids ){
1394
+			if ( ! $model_objs_affected_ids) {
1395 1395
 				//wait wait wait- if nothing was affected let's stop here
1396 1396
 				return 0;
1397 1397
 			}
1398
-			foreach( $model_objs_affected_ids as $id ){
1399
-				$model_obj_in_entity_map = $this->get_from_entity_map( $id );
1400
-				if( $model_obj_in_entity_map ){
1401
-					foreach( $fields_n_values as $field => $new_value ){
1402
-						$model_obj_in_entity_map->set( $field, $new_value );
1398
+			foreach ($model_objs_affected_ids as $id) {
1399
+				$model_obj_in_entity_map = $this->get_from_entity_map($id);
1400
+				if ($model_obj_in_entity_map) {
1401
+					foreach ($fields_n_values as $field => $new_value) {
1402
+						$model_obj_in_entity_map->set($field, $new_value);
1403 1403
 					}
1404 1404
 				}
1405 1405
 			}
1406 1406
 			//if there is a primary key on this model, we can now do a slight optimization
1407
-			if( $this->has_primary_key_field() ){
1407
+			if ($this->has_primary_key_field()) {
1408 1408
 				//we already know what we want to update. So let's make the query simpler so it's a little more efficient
1409 1409
 				$query_params = array(
1410
-					array( $this->primary_key_name() => array( 'IN', $model_objs_affected_ids ) ),
1411
-					'limit' => count( $model_objs_affected_ids ), 'default_where_conditions' => 'none' );
1410
+					array($this->primary_key_name() => array('IN', $model_objs_affected_ids)),
1411
+					'limit' => count($model_objs_affected_ids), 'default_where_conditions' => 'none' );
1412 1412
 			}
1413 1413
 		}
1414 1414
 
1415
-		$model_query_info = $this->_create_model_query_info_carrier( $query_params );
1416
-		$SQL = "UPDATE ".$model_query_info->get_full_join_sql()." SET ".$this->_construct_update_sql($fields_n_values).$model_query_info->get_where_sql();//note: doesn't use _construct_2nd_half_of_select_query() because doesn't accept LIMIT, ORDER BY, etc.
1417
-		$rows_affected = $this->_do_wpdb_query('query', array( $SQL ) );
1415
+		$model_query_info = $this->_create_model_query_info_carrier($query_params);
1416
+		$SQL = "UPDATE ".$model_query_info->get_full_join_sql()." SET ".$this->_construct_update_sql($fields_n_values).$model_query_info->get_where_sql(); //note: doesn't use _construct_2nd_half_of_select_query() because doesn't accept LIMIT, ORDER BY, etc.
1417
+		$rows_affected = $this->_do_wpdb_query('query', array($SQL));
1418 1418
 		/**
1419 1419
 		 * Action called after a model update call has been made.
1420 1420
 		 *
@@ -1423,8 +1423,8 @@  discard block
 block discarded – undo
1423 1423
 		 * @param array $query_params @see EEM_Base::get_all()
1424 1424
 		 * @param int $rows_affected
1425 1425
 		 */
1426
-		do_action( 'AHEE__EEM_Base__update__end',$this, $fields_n_values, $query_params, $rows_affected );
1427
-		return $rows_affected;//how many supposedly got updated
1426
+		do_action('AHEE__EEM_Base__update__end', $this, $fields_n_values, $query_params, $rows_affected);
1427
+		return $rows_affected; //how many supposedly got updated
1428 1428
 	}
1429 1429
 
1430 1430
 	/**
@@ -1436,22 +1436,22 @@  discard block
 block discarded – undo
1436 1436
 	 * @param string $field_to_select
1437 1437
 	 * @return array just like $wpdb->get_col()
1438 1438
 	 */
1439
-	public function get_col( $query_params  = array(), $field_to_select = NULL ){
1439
+	public function get_col($query_params = array(), $field_to_select = NULL) {
1440 1440
 
1441
-		if( $field_to_select ){
1442
-			$field = $this->field_settings_for( $field_to_select );
1443
-		}elseif( $this->has_primary_key_field ( ) ){
1441
+		if ($field_to_select) {
1442
+			$field = $this->field_settings_for($field_to_select);
1443
+		}elseif ($this->has_primary_key_field( )) {
1444 1444
 			$field = $this->get_primary_key_field();
1445
-		}else{
1445
+		} else {
1446 1446
 			//no primary key, just grab the first column
1447
-			$field = reset( $this->field_settings());
1447
+			$field = reset($this->field_settings());
1448 1448
 		}
1449 1449
 
1450 1450
 
1451 1451
 		$model_query_info = $this->_create_model_query_info_carrier($query_params);
1452 1452
 		$select_expressions = $field->get_qualified_column();
1453
-		$SQL ="SELECT $select_expressions ".$this->_construct_2nd_half_of_select_query($model_query_info);
1454
-		$results =  $this->_do_wpdb_query('get_col', array( $SQL ) );
1453
+		$SQL = "SELECT $select_expressions ".$this->_construct_2nd_half_of_select_query($model_query_info);
1454
+		$results = $this->_do_wpdb_query('get_col', array($SQL));
1455 1455
 		return $results;
1456 1456
 	}
1457 1457
 
@@ -1461,12 +1461,12 @@  discard block
 block discarded – undo
1461 1461
 	 * @param string $field_to_select @see EEM_Base::get_col()
1462 1462
 	 * @return string
1463 1463
 	 */
1464
-	public function get_var( $query_params = array(), $field_to_select = NULL ) {
1465
-		$query_params[ 'limit' ] = 1;
1466
-		$col = $this->get_col( $query_params, $field_to_select );
1467
-		if( ! empty( $col ) ) {
1468
-			return reset( $col );
1469
-		}else{
1464
+	public function get_var($query_params = array(), $field_to_select = NULL) {
1465
+		$query_params['limit'] = 1;
1466
+		$col = $this->get_col($query_params, $field_to_select);
1467
+		if ( ! empty($col)) {
1468
+			return reset($col);
1469
+		} else {
1470 1470
 			return NULL;
1471 1471
 		}
1472 1472
 	}
@@ -1480,19 +1480,19 @@  discard block
 block discarded – undo
1480 1480
 	 * @param array $fields_n_values array keys are field names on this model, and values are what those fields should be updated to in the DB
1481 1481
 	 * @return string of SQL
1482 1482
 	 */
1483
-	function _construct_update_sql($fields_n_values){
1483
+	function _construct_update_sql($fields_n_values) {
1484 1484
 		/** @type WPDB $wpdb */
1485 1485
 		global $wpdb;
1486 1486
 		$cols_n_values = array();
1487
-		foreach($fields_n_values as $field_name => $value){
1487
+		foreach ($fields_n_values as $field_name => $value) {
1488 1488
 			$field_obj = $this->field_settings_for($field_name);
1489 1489
 			//if the value is NULL, we want to assign the value to that.
1490 1490
 			//wpdb->prepare doesn't really handle that properly
1491
-			$prepared_value = $this->_prepare_value_or_use_default( $field_obj, $fields_n_values );
1492
-			$value_sql = $prepared_value===NULL ? 'NULL' : $wpdb->prepare( $field_obj->get_wpdb_data_type(), $prepared_value );
1491
+			$prepared_value = $this->_prepare_value_or_use_default($field_obj, $fields_n_values);
1492
+			$value_sql = $prepared_value === NULL ? 'NULL' : $wpdb->prepare($field_obj->get_wpdb_data_type(), $prepared_value);
1493 1493
 			$cols_n_values[] = $field_obj->get_qualified_column()."=".$value_sql;
1494 1494
 		}
1495
-		return implode(",",$cols_n_values);
1495
+		return implode(",", $cols_n_values);
1496 1496
 
1497 1497
 	}
1498 1498
 
@@ -1504,11 +1504,11 @@  discard block
 block discarded – undo
1504 1504
 	 * @param mixed $id
1505 1505
 	 * @return boolean whether the row got deleted or not
1506 1506
 	 */
1507
-	public function delete_by_ID( $id ){
1508
-		return $this->delete( array(
1509
-			array( $this->get_primary_key_field()->get_name() => $id ),
1507
+	public function delete_by_ID($id) {
1508
+		return $this->delete(array(
1509
+			array($this->get_primary_key_field()->get_name() => $id),
1510 1510
 			'limit' 	=> 1
1511
-		) );
1511
+		));
1512 1512
 	}
1513 1513
 
1514 1514
 
@@ -1523,7 +1523,7 @@  discard block
 block discarded – undo
1523 1523
 	 * which may depend on it. Its generally advisable to always leave this as TRUE, otherwise you could easily corrupt your DB
1524 1524
 	 * @return int how many rows got deleted
1525 1525
 	 */
1526
-	function delete($query_params,$allow_blocking = true){
1526
+	function delete($query_params, $allow_blocking = true) {
1527 1527
 		/**
1528 1528
 		 * Action called just before performing a real deletion query. You can use the
1529 1529
 		 * model and its $query_params to find exactly which items will be deleted
@@ -1532,34 +1532,34 @@  discard block
 block discarded – undo
1532 1532
 		 * @param boolean $allow_blocking whether or not to allow related model objects
1533 1533
 		 * to block (prevent) this deletion
1534 1534
 		 */
1535
-		do_action( 'AHEE__EEM_Base__delete__begin', $this, $query_params, $allow_blocking );
1535
+		do_action('AHEE__EEM_Base__delete__begin', $this, $query_params, $allow_blocking);
1536 1536
 		//some MySQL databases may be running safe mode, which may restrict
1537 1537
 		//deletion if there is no KEY column used in the WHERE statement of a deletion.
1538 1538
 		//to get around this, we first do a SELECT, get all the IDs, and then run another query
1539 1539
 		//to delete them
1540 1540
 		$items_for_deletion = $this->_get_all_wpdb_results($query_params);
1541
-		$deletion_where = $this->_setup_ids_for_delete( $items_for_deletion, $allow_blocking);
1542
-		if($deletion_where){
1541
+		$deletion_where = $this->_setup_ids_for_delete($items_for_deletion, $allow_blocking);
1542
+		if ($deletion_where) {
1543 1543
 			//echo "objects for deletion:";var_dump($objects_for_deletion);
1544 1544
 			$model_query_info = $this->_create_model_query_info_carrier($query_params);
1545 1545
 			$table_aliases = array();
1546
-			foreach(array_keys($this->_tables) as $table_alias){
1546
+			foreach (array_keys($this->_tables) as $table_alias) {
1547 1547
 				$table_aliases[] = $table_alias;
1548 1548
 			}
1549
-			$SQL = "DELETE ".implode(", ",$table_aliases)." FROM ".$model_query_info->get_full_join_sql()." WHERE ".$deletion_where;
1549
+			$SQL = "DELETE ".implode(", ", $table_aliases)." FROM ".$model_query_info->get_full_join_sql()." WHERE ".$deletion_where;
1550 1550
 
1551 1551
 			//		/echo "delete sql:$SQL";
1552
-			$rows_deleted = $this->_do_wpdb_query( 'query', array( $SQL ) );
1553
-		}else{
1552
+			$rows_deleted = $this->_do_wpdb_query('query', array($SQL));
1553
+		} else {
1554 1554
 			$rows_deleted = 0;
1555 1555
 		}
1556 1556
 
1557 1557
 		//and lastly make sure those items are removed from the entity map; if they could be put into it at all
1558
-		if( $this->has_primary_key_field() ){
1559
-			foreach($items_for_deletion as $item_for_deletion_row ){
1560
-				$pk_value = $item_for_deletion_row[ $this->get_primary_key_field()->get_qualified_column() ];
1561
-				if( isset( $this->_entity_map[ $pk_value ] ) ){
1562
-					unset( $this->_entity_map[ $pk_value ] );
1558
+		if ($this->has_primary_key_field()) {
1559
+			foreach ($items_for_deletion as $item_for_deletion_row) {
1560
+				$pk_value = $item_for_deletion_row[$this->get_primary_key_field()->get_qualified_column()];
1561
+				if (isset($this->_entity_map[$pk_value])) {
1562
+					unset($this->_entity_map[$pk_value]);
1563 1563
 				}
1564 1564
 			}
1565 1565
 		}
@@ -1571,8 +1571,8 @@  discard block
 block discarded – undo
1571 1571
 		 * @param array $query_params @see EEM_Base::get_all()
1572 1572
 		 * @param int $rows_deleted
1573 1573
 		 */
1574
-		do_action( 'AHEE__EEM_Base__delete__end', $this, $query_params, $rows_deleted );
1575
-		return $rows_deleted;//how many supposedly got deleted
1574
+		do_action('AHEE__EEM_Base__delete__end', $this, $query_params, $rows_deleted);
1575
+		return $rows_deleted; //how many supposedly got deleted
1576 1576
 	}
1577 1577
 
1578 1578
 
@@ -1588,28 +1588,28 @@  discard block
 block discarded – undo
1588 1588
 	 * blocking its deletion before removing the relation between A and B
1589 1589
 	 * @return boolean
1590 1590
 	 */
1591
-	public function delete_is_blocked_by_related_models($this_model_obj_or_id, $ignore_this_model_obj = null){
1591
+	public function delete_is_blocked_by_related_models($this_model_obj_or_id, $ignore_this_model_obj = null) {
1592 1592
 		//first, if $ignore_this_model_obj was supplied, get its model
1593
-		if($ignore_this_model_obj && $ignore_this_model_obj instanceof EE_Base_Class){
1593
+		if ($ignore_this_model_obj && $ignore_this_model_obj instanceof EE_Base_Class) {
1594 1594
 			$ignored_model = $ignore_this_model_obj->get_model();
1595
-		}else{
1595
+		} else {
1596 1596
 			$ignored_model = null;
1597 1597
 		}
1598 1598
 		//now check all the relations of $this_model_obj_or_id and see if there
1599 1599
 		//are any related model objects blocking it?
1600 1600
 		$is_blocked = false;
1601
-		foreach($this->_model_relations as $relation_name => $relation_obj){
1602
-			if( $relation_obj->block_delete_if_related_models_exist()){
1601
+		foreach ($this->_model_relations as $relation_name => $relation_obj) {
1602
+			if ($relation_obj->block_delete_if_related_models_exist()) {
1603 1603
 				//if $ignore_this_model_obj was supplied, then for the query
1604 1604
 				//on that model needs to be told to ignore $ignore_this_model_obj
1605
-				if($ignored_model && $relation_name == $ignored_model->get_this_model_name()){
1606
-					$related_model_objects = $relation_obj->get_all_related($this_model_obj_or_id,array(
1607
-					array($ignored_model->get_primary_key_field()->get_name() => array('!=',$ignore_this_model_obj->ID()))));
1608
-				}else{
1605
+				if ($ignored_model && $relation_name == $ignored_model->get_this_model_name()) {
1606
+					$related_model_objects = $relation_obj->get_all_related($this_model_obj_or_id, array(
1607
+					array($ignored_model->get_primary_key_field()->get_name() => array('!=', $ignore_this_model_obj->ID()))));
1608
+				} else {
1609 1609
 					$related_model_objects = $relation_obj->get_all_related($this_model_obj_or_id);
1610 1610
 				}
1611 1611
 
1612
-				if($related_model_objects){
1612
+				if ($related_model_objects) {
1613 1613
 					EE_Error::add_error($relation_obj->get_deletion_error_message(), __FILE__, __FUNCTION__, __LINE__);
1614 1614
 					$is_blocked = true;
1615 1615
 				}
@@ -1629,65 +1629,65 @@  discard block
 block discarded – undo
1629 1629
 	 * @throws EE_Error
1630 1630
 	 * @return string    everything that comes after the WHERE statement.
1631 1631
 	 */
1632
-	protected function _setup_ids_for_delete( $objects_for_deletion, $allow_blocking = true) {
1633
-		if($this->has_primary_key_field()){
1632
+	protected function _setup_ids_for_delete($objects_for_deletion, $allow_blocking = true) {
1633
+		if ($this->has_primary_key_field()) {
1634 1634
 			$primary_table = $this->_get_main_table();
1635 1635
 			$other_tables = $this->_get_other_tables();
1636 1636
 			$deletes = $query = array();
1637
-			foreach ( $objects_for_deletion as $delete_object ) {
1637
+			foreach ($objects_for_deletion as $delete_object) {
1638 1638
 				//before we mark this object for deletion,
1639 1639
 				//make sure there's no related objects blocking its deletion (if we're checking)
1640
-				if( $allow_blocking && $this->delete_is_blocked_by_related_models($delete_object[$primary_table->get_fully_qualified_pk_column()]) ){
1640
+				if ($allow_blocking && $this->delete_is_blocked_by_related_models($delete_object[$primary_table->get_fully_qualified_pk_column()])) {
1641 1641
 					continue;
1642 1642
 				}
1643 1643
 
1644 1644
 				//primary table deletes
1645
-				if ( isset( $delete_object[$primary_table->get_fully_qualified_pk_column()] ) )
1645
+				if (isset($delete_object[$primary_table->get_fully_qualified_pk_column()]))
1646 1646
 					$deletes[$primary_table->get_fully_qualified_pk_column()][] = $delete_object[$primary_table->get_fully_qualified_pk_column()];
1647 1647
 
1648 1648
 				//other tables
1649
-				if ( !empty( $other_tables ) ) {
1650
-					foreach ( $other_tables as $ot ) {
1649
+				if ( ! empty($other_tables)) {
1650
+					foreach ($other_tables as $ot) {
1651 1651
 
1652 1652
 						//first check if we've got the foreign key column here.
1653
-						if ( isset( $delete_object[$ot->get_fully_qualified_fk_column()] ) )
1653
+						if (isset($delete_object[$ot->get_fully_qualified_fk_column()]))
1654 1654
 							$deletes[$ot->get_fully_qualified_pk_column()][] = $delete_object[$ot->get_fully_qualified_fk_column()];
1655 1655
 
1656 1656
 						//wait! it's entirely possible that we'll have a the primary key for this table in here if it's a foreign key for one of the other secondary tables
1657
-						if ( isset( $delete_object[$ot->get_fully_qualified_pk_column()] ) )
1657
+						if (isset($delete_object[$ot->get_fully_qualified_pk_column()]))
1658 1658
 							$deletes[$ot->get_fully_qualified_pk_column()][] = $delete_object[$ot->get_fully_qualified_pk_column()];
1659 1659
 
1660 1660
 						//finally, it is possible that the fk for this table is found in the fully qualified pk column for the fk table, so let's see if that's there!
1661
-						if ( isset( $delete_object[$ot->get_fully_qualified_pk_on_fk_table()]) )
1661
+						if (isset($delete_object[$ot->get_fully_qualified_pk_on_fk_table()]))
1662 1662
 							$deletes[$ot->get_fully_qualified_pk_column()][] = $delete_object[$ot->get_fully_qualified_pk_column()];
1663 1663
 					}
1664 1664
 				}
1665 1665
 			}
1666 1666
 
1667 1667
 			//we should have deletes now, so let's just go through and setup the where statement
1668
-			foreach ( $deletes as $column => $values ) {
1668
+			foreach ($deletes as $column => $values) {
1669 1669
 				//make sure we have unique $values;
1670 1670
 				$values = array_unique($values);
1671
-				$query[] = $column . ' IN(' . implode(",",$values) . ')';
1671
+				$query[] = $column.' IN('.implode(",", $values).')';
1672 1672
 			}
1673 1673
 
1674
-			return !empty($query) ? implode(' AND ', $query ) : '';
1675
-		}elseif(count($this->get_combined_primary_key_fields()) > 1){
1674
+			return ! empty($query) ? implode(' AND ', $query) : '';
1675
+		}elseif (count($this->get_combined_primary_key_fields()) > 1) {
1676 1676
 			$ways_to_identify_a_row = array();
1677 1677
 			$fields = $this->get_combined_primary_key_fields();
1678 1678
 			//note: because there' sno primary key, that means nothing else  can be pointing to this model, right?
1679
-			foreach($objects_for_deletion as  $delete_object){
1679
+			foreach ($objects_for_deletion as  $delete_object) {
1680 1680
 				$values_for_each_cpk_for_a_row = array();
1681
-				foreach($fields as $cpk_field){
1681
+				foreach ($fields as $cpk_field) {
1682 1682
 					$values_for_each_cpk_for_a_row[] = $cpk_field->get_qualified_column()."=".$delete_object[$cpk_field->get_qualified_column()];
1683 1683
 				}
1684
-				$ways_to_identify_a_row[] = "(".implode(" AND ",$values_for_each_cpk_for_a_row).")";
1684
+				$ways_to_identify_a_row[] = "(".implode(" AND ", $values_for_each_cpk_for_a_row).")";
1685 1685
 			}
1686
-			return implode(" OR ",$ways_to_identify_a_row);
1687
-		}else{
1686
+			return implode(" OR ", $ways_to_identify_a_row);
1687
+		} else {
1688 1688
 			//so there's no primary key and no combined key...
1689 1689
 			//sorry, can't help you
1690
-			throw new EE_Error(sprintf(__("Cannot delete objects of type %s because there is no primary key NOR combined key", "event_espresso"),get_class($this)));
1690
+			throw new EE_Error(sprintf(__("Cannot delete objects of type %s because there is no primary key NOR combined key", "event_espresso"), get_class($this)));
1691 1691
 		}
1692 1692
 	}
1693 1693
 
@@ -1701,21 +1701,21 @@  discard block
 block discarded – undo
1701 1701
 	 * @param bool 	 $distinct if we want to only count the distinct values for the column then you can trigger that by the setting $distinct to TRUE;
1702 1702
 	 * @return int
1703 1703
 	 */
1704
-	function count($query_params =array(),$field_to_count = NULL, $distinct = FALSE){
1704
+	function count($query_params = array(), $field_to_count = NULL, $distinct = FALSE) {
1705 1705
 		$model_query_info = $this->_create_model_query_info_carrier($query_params);
1706
-		if($field_to_count){
1706
+		if ($field_to_count) {
1707 1707
 			$field_obj = $this->field_settings_for($field_to_count);
1708 1708
 			$column_to_count = $field_obj->get_qualified_column();
1709
-		}elseif($this->has_primary_key_field ()){
1709
+		}elseif ($this->has_primary_key_field()) {
1710 1710
 			$pk_field_obj = $this->get_primary_key_field();
1711 1711
 			$column_to_count = $pk_field_obj->get_qualified_column();
1712
-		}else{//there's no primary key
1712
+		} else {//there's no primary key
1713 1713
 			$column_to_count = '*';
1714 1714
 		}
1715 1715
 
1716
-		$column_to_count = $distinct ? "DISTINCT (" . $column_to_count . " )" : $column_to_count;
1717
-		$SQL ="SELECT COUNT(".$column_to_count.")" . $this->_construct_2nd_half_of_select_query($model_query_info);
1718
-		return (int)$this->_do_wpdb_query( 'get_var', array( $SQL) );
1716
+		$column_to_count = $distinct ? "DISTINCT (".$column_to_count." )" : $column_to_count;
1717
+		$SQL = "SELECT COUNT(".$column_to_count.")".$this->_construct_2nd_half_of_select_query($model_query_info);
1718
+		return (int) $this->_do_wpdb_query('get_var', array($SQL));
1719 1719
 	}
1720 1720
 
1721 1721
 	/**
@@ -1725,23 +1725,23 @@  discard block
 block discarded – undo
1725 1725
 	 * @param string $field_to_sum name of field (array key in $_fields array)
1726 1726
 	 * @return float
1727 1727
 	 */
1728
-	function sum($query_params, $field_to_sum = NULL){
1728
+	function sum($query_params, $field_to_sum = NULL) {
1729 1729
 		$model_query_info = $this->_create_model_query_info_carrier($query_params);
1730 1730
 
1731
-		if($field_to_sum){
1731
+		if ($field_to_sum) {
1732 1732
 			$field_obj = $this->field_settings_for($field_to_sum);
1733 1733
 
1734
-		}else{
1734
+		} else {
1735 1735
 			$field_obj = $this->get_primary_key_field();
1736 1736
 		}
1737 1737
 		$column_to_count = $field_obj->get_qualified_column();
1738 1738
 
1739
-		$SQL ="SELECT SUM(".$column_to_count.")" . $this->_construct_2nd_half_of_select_query($model_query_info);
1740
-		$return_value = $this->_do_wpdb_query('get_var',array( $SQL ) );
1741
-		if($field_obj->get_wpdb_data_type() == '%d' || $field_obj->get_wpdb_data_type() == '%s' ){
1742
-			return (float)$return_value;
1743
-		}else{//must be %f
1744
-			return (float)$return_value;
1739
+		$SQL = "SELECT SUM(".$column_to_count.")".$this->_construct_2nd_half_of_select_query($model_query_info);
1740
+		$return_value = $this->_do_wpdb_query('get_var', array($SQL));
1741
+		if ($field_obj->get_wpdb_data_type() == '%d' || $field_obj->get_wpdb_data_type() == '%s') {
1742
+			return (float) $return_value;
1743
+		} else {//must be %f
1744
+			return (float) $return_value;
1745 1745
 		}
1746 1746
 	}
1747 1747
 
@@ -1756,33 +1756,33 @@  discard block
 block discarded – undo
1756 1756
 	 * @global wpdb $wpdb
1757 1757
 	 * @return mixed
1758 1758
 	 */
1759
-	protected function _do_wpdb_query( $wpdb_method, $arguments_to_provide ){
1759
+	protected function _do_wpdb_query($wpdb_method, $arguments_to_provide) {
1760 1760
 		//if we're in maintenance mode level 2, DON'T run any queries
1761 1761
 		//because level 2 indicates the database needs updating and
1762 1762
 		//is probably out of sync with the code
1763
-		if( ! EE_Maintenance_Mode::instance()->models_can_query()){
1763
+		if ( ! EE_Maintenance_Mode::instance()->models_can_query()) {
1764 1764
 			throw new EE_Error(sprintf(__("Event Espresso Level 2 Maintenance mode is active. That means EE can not run ANY database queries until the necessary migration scripts have run which will take EE out of maintenance mode level 2. Please inform support of this error.", "event_espresso")));
1765 1765
 		}
1766 1766
 		/** @type WPDB $wpdb */
1767 1767
 		global $wpdb;
1768
-		if( ! method_exists( $wpdb, $wpdb_method ) ){
1769
-			throw new EE_Error( sprintf( __( 'There is no method named "%s" on Wordpress\' $wpdb object','event_espresso' ), $wpdb_method ) );
1768
+		if ( ! method_exists($wpdb, $wpdb_method)) {
1769
+			throw new EE_Error(sprintf(__('There is no method named "%s" on Wordpress\' $wpdb object', 'event_espresso'), $wpdb_method));
1770 1770
 		}
1771
-		if( WP_DEBUG ){
1771
+		if (WP_DEBUG) {
1772 1772
 			$old_show_errors_value = $wpdb->show_errors;
1773
-			$wpdb->show_errors( FALSE );
1774
-		}
1775
-		$result = $this->_process_wpdb_query( $wpdb_method, $arguments_to_provide );
1776
-		$this->show_db_query_if_previously_requested( $wpdb->last_query );
1777
-		if( WP_DEBUG ){
1778
-			$wpdb->show_errors( $old_show_errors_value );
1779
-			if( ! empty( $wpdb->last_error ) ){
1780
-				throw new EE_Error( sprintf( __( 'WPDB Error: "%s"', 'event_espresso' ), $wpdb->last_error ) );
1781
-			}elseif( $result === false ){
1782
-				throw new EE_Error( sprintf( __( 'WPDB Error occurred, but no error message was logged by wpdb! The wpdb method called was "%1$s" and the arguments were "%2$s"', 'event_espresso' ), $wpdb_method, var_export( $arguments_to_provide, true ) ) );
1773
+			$wpdb->show_errors(FALSE);
1774
+		}
1775
+		$result = $this->_process_wpdb_query($wpdb_method, $arguments_to_provide);
1776
+		$this->show_db_query_if_previously_requested($wpdb->last_query);
1777
+		if (WP_DEBUG) {
1778
+			$wpdb->show_errors($old_show_errors_value);
1779
+			if ( ! empty($wpdb->last_error)) {
1780
+				throw new EE_Error(sprintf(__('WPDB Error: "%s"', 'event_espresso'), $wpdb->last_error));
1781
+			}elseif ($result === false) {
1782
+				throw new EE_Error(sprintf(__('WPDB Error occurred, but no error message was logged by wpdb! The wpdb method called was "%1$s" and the arguments were "%2$s"', 'event_espresso'), $wpdb_method, var_export($arguments_to_provide, true)));
1783 1783
 			}
1784
-		}elseif( $result === false ) {
1785
-			EE_Error::add_error( sprintf( __( 'A database error has occurred. Turn on WP_DEBUG for more information.', 'event_espresso' )), __FILE__, __FUNCTION__, __LINE__);
1784
+		}elseif ($result === false) {
1785
+			EE_Error::add_error(sprintf(__('A database error has occurred. Turn on WP_DEBUG for more information.', 'event_espresso')), __FILE__, __FUNCTION__, __LINE__);
1786 1786
 		}
1787 1787
 		return $result;
1788 1788
 	}
@@ -1798,23 +1798,23 @@  discard block
 block discarded – undo
1798 1798
 	 * @param array $arguments_to_provide
1799 1799
 	 * @return mixed
1800 1800
 	 */
1801
-	private function _process_wpdb_query( $wpdb_method, $arguments_to_provide ) {
1801
+	private function _process_wpdb_query($wpdb_method, $arguments_to_provide) {
1802 1802
 		/** @type WPDB $wpdb */
1803 1803
 		global $wpdb;
1804 1804
 		$wpdb->last_error = null;
1805
-		$result = call_user_func_array( array( $wpdb, $wpdb_method ), $arguments_to_provide );
1805
+		$result = call_user_func_array(array($wpdb, $wpdb_method), $arguments_to_provide);
1806 1806
 		// was there an error running the query?
1807
-		if ( ( $result === false || ! empty( $wpdb->last_error ) ) ) {
1808
-			switch ( EEM_Base::$_db_verification_level ) {
1807
+		if (($result === false || ! empty($wpdb->last_error))) {
1808
+			switch (EEM_Base::$_db_verification_level) {
1809 1809
 
1810 1810
 				case EEM_Base::db_verified_none :
1811 1811
 					// let's double-check core's DB
1812
-					$error_message = $this->_verify_core_db( $wpdb_method, $arguments_to_provide );
1812
+					$error_message = $this->_verify_core_db($wpdb_method, $arguments_to_provide);
1813 1813
 					break;
1814 1814
 
1815 1815
 				case EEM_Base::db_verified_core :
1816 1816
 					// STILL NO LOVE?? verify all the addons too. Maybe they need to be fixed
1817
-					$error_message = $this->_verify_addons_db( $wpdb_method, $arguments_to_provide );
1817
+					$error_message = $this->_verify_addons_db($wpdb_method, $arguments_to_provide);
1818 1818
 					break;
1819 1819
 
1820 1820
 				case EEM_Base::db_verified_addons :
@@ -1822,11 +1822,11 @@  discard block
 block discarded – undo
1822 1822
 					return $result;
1823 1823
 					break;
1824 1824
 			}
1825
-			if ( ! empty( $error_message ) ) {
1826
-				EE_Log::instance()->log( __FILE__, __FUNCTION__, $error_message, 'error' );
1827
-				trigger_error( $error_message );
1825
+			if ( ! empty($error_message)) {
1826
+				EE_Log::instance()->log(__FILE__, __FUNCTION__, $error_message, 'error');
1827
+				trigger_error($error_message);
1828 1828
 			}
1829
-			return $this->_process_wpdb_query( $wpdb_method, $arguments_to_provide );
1829
+			return $this->_process_wpdb_query($wpdb_method, $arguments_to_provide);
1830 1830
 
1831 1831
 		}
1832 1832
 
@@ -1842,18 +1842,18 @@  discard block
 block discarded – undo
1842 1842
 	 * @param array $arguments_to_provide
1843 1843
 	 * @return string
1844 1844
 	 */
1845
-	private function _verify_core_db( $wpdb_method, $arguments_to_provide ){
1845
+	private function _verify_core_db($wpdb_method, $arguments_to_provide) {
1846 1846
 		/** @type WPDB $wpdb */
1847 1847
 		global $wpdb;
1848 1848
 		//ok remember that we've already attempted fixing the core db, in case the problem persists
1849 1849
 		EEM_Base::$_db_verification_level = EEM_Base::db_verified_core;
1850 1850
 		$error_message = sprintf(
1851
-			__( 'WPDB Error "%1$s" while running wpdb method "%2$s" with arguments %3$s. Automatically attempting to fix EE Core DB', 'event_espresso' ),
1851
+			__('WPDB Error "%1$s" while running wpdb method "%2$s" with arguments %3$s. Automatically attempting to fix EE Core DB', 'event_espresso'),
1852 1852
 			$wpdb->last_error,
1853 1853
 			$wpdb_method,
1854
-			json_encode( $arguments_to_provide )
1854
+			json_encode($arguments_to_provide)
1855 1855
 		);
1856
-		EE_System::instance()->initialize_db_if_no_migrations_required( false, true );
1856
+		EE_System::instance()->initialize_db_if_no_migrations_required(false, true);
1857 1857
 		return $error_message;
1858 1858
 	}
1859 1859
 
@@ -1866,16 +1866,16 @@  discard block
 block discarded – undo
1866 1866
 	 * @param $arguments_to_provide
1867 1867
 	 * @return string
1868 1868
 	 */
1869
-	private function _verify_addons_db( $wpdb_method, $arguments_to_provide ) {
1869
+	private function _verify_addons_db($wpdb_method, $arguments_to_provide) {
1870 1870
 		/** @type WPDB $wpdb */
1871 1871
 		global $wpdb;
1872 1872
 		//ok remember that we've already attempted fixing the addons dbs, in case the problem persists
1873 1873
 		EEM_Base::$_db_verification_level = EEM_Base::db_verified_addons;
1874 1874
 		$error_message = sprintf(
1875
-			__( 'WPDB AGAIN: Error "%1$s" while running the same method and arguments as before. Automatically attempting to fix EE Addons DB', 'event_espresso' ),
1875
+			__('WPDB AGAIN: Error "%1$s" while running the same method and arguments as before. Automatically attempting to fix EE Addons DB', 'event_espresso'),
1876 1876
 			$wpdb->last_error,
1877 1877
 			$wpdb_method,
1878
-			json_encode( $arguments_to_provide )
1878
+			json_encode($arguments_to_provide)
1879 1879
 		);
1880 1880
 		EE_System::instance()->initialize_addons();
1881 1881
 		return $error_message;
@@ -1890,7 +1890,7 @@  discard block
 block discarded – undo
1890 1890
 	 * @param EE_Model_Query_Info_Carrier $model_query_info
1891 1891
 	 * @return string
1892 1892
 	 */
1893
-	private function _construct_2nd_half_of_select_query(EE_Model_Query_Info_Carrier $model_query_info){
1893
+	private function _construct_2nd_half_of_select_query(EE_Model_Query_Info_Carrier $model_query_info) {
1894 1894
 		return " FROM ".$model_query_info->get_full_join_sql().
1895 1895
 				$model_query_info->get_where_sql().
1896 1896
 				$model_query_info->get_group_by_sql().
@@ -1903,7 +1903,7 @@  discard block
 block discarded – undo
1903 1903
 	 * Set to easily debug the next X queries ran from this model.
1904 1904
 	 * @param int $count
1905 1905
 	 */
1906
-	function show_next_x_db_queries($count = 1){
1906
+	function show_next_x_db_queries($count = 1) {
1907 1907
 		$this->_show_next_x_db_queries = $count;
1908 1908
 	}
1909 1909
 
@@ -1912,8 +1912,8 @@  discard block
 block discarded – undo
1912 1912
 	/**
1913 1913
 	 * @param $sql_query
1914 1914
 	 */
1915
-	function show_db_query_if_previously_requested($sql_query){
1916
-		if($this->_show_next_x_db_queries > 0){
1915
+	function show_db_query_if_previously_requested($sql_query) {
1916
+		if ($this->_show_next_x_db_queries > 0) {
1917 1917
 			echo $sql_query;
1918 1918
 			$this->_show_next_x_db_queries--;
1919 1919
 		}
@@ -1937,9 +1937,9 @@  discard block
 block discarded – undo
1937 1937
 	 * @param array   $extra_join_model_fields_n_values This allows you to enter further query params for the relation to for relation to methods that allow you to further specify extra columns to join by (such as HABTM).  Keep in mind that the only acceptable query_params is strict "col" => "value" pairs because these will be inserted in any new rows created as well.
1938 1938
 	 * @return EE_Base_Class which was added as a relation. Object referred to by $other_model_id_or_obj
1939 1939
 	 */
1940
-	public function add_relationship_to($id_or_obj,$other_model_id_or_obj, $relationName, $extra_join_model_fields_n_values = array()){
1940
+	public function add_relationship_to($id_or_obj, $other_model_id_or_obj, $relationName, $extra_join_model_fields_n_values = array()) {
1941 1941
 		$relation_obj = $this->related_settings_for($relationName);
1942
-		return $relation_obj->add_relation_to( $id_or_obj, $other_model_id_or_obj, $extra_join_model_fields_n_values);
1942
+		return $relation_obj->add_relation_to($id_or_obj, $other_model_id_or_obj, $extra_join_model_fields_n_values);
1943 1943
 	}
1944 1944
 
1945 1945
 	/**
@@ -1958,9 +1958,9 @@  discard block
 block discarded – undo
1958 1958
 	 * @return boolean of success
1959 1959
 	 * @param array   $where_query This allows you to enter further query params for the relation to for relation to methods that allow you to further specify extra columns to join by (such as HABTM).  Keep in mind that the only acceptable query_params is strict "col" => "value" pairs because these will be inserted in any new rows created as well.
1960 1960
 	 */
1961
-	public function remove_relationship_to($id_or_obj,  $other_model_id_or_obj, $relationName, $where_query= array() ){
1961
+	public function remove_relationship_to($id_or_obj, $other_model_id_or_obj, $relationName, $where_query = array()) {
1962 1962
 		$relation_obj = $this->related_settings_for($relationName);
1963
-		return $relation_obj->remove_relation_to($id_or_obj, $other_model_id_or_obj, $where_query );
1963
+		return $relation_obj->remove_relation_to($id_or_obj, $other_model_id_or_obj, $where_query);
1964 1964
 	}
1965 1965
 
1966 1966
 
@@ -1973,9 +1973,9 @@  discard block
 block discarded – undo
1973 1973
 	 * @param EE_Base_Class[] objects to which relations were removed
1974 1974
 	 * @return \EE_Base_Class[]
1975 1975
 	 */
1976
-	public function remove_relations($id_or_obj,$relationName,$where_query_params = array()){
1976
+	public function remove_relations($id_or_obj, $relationName, $where_query_params = array()) {
1977 1977
 		$relation_obj = $this->related_settings_for($relationName);
1978
-		return $relation_obj->remove_relations($id_or_obj, $where_query_params );
1978
+		return $relation_obj->remove_relations($id_or_obj, $where_query_params);
1979 1979
 	}
1980 1980
 
1981 1981
 
@@ -1988,10 +1988,10 @@  discard block
 block discarded – undo
1988 1988
 	 * @param array $query_params like EEM_Base::get_all
1989 1989
 	 * @return EE_Base_Class[]
1990 1990
 	 */
1991
-	function get_all_related($id_or_obj, $model_name, $query_params = null){
1991
+	function get_all_related($id_or_obj, $model_name, $query_params = null) {
1992 1992
 		$model_obj = $this->ensure_is_obj($id_or_obj);
1993 1993
 		$relation_settings = $this->related_settings_for($model_name);
1994
-		return $relation_settings->get_all_related($model_obj,$query_params);
1994
+		return $relation_settings->get_all_related($model_obj, $query_params);
1995 1995
 	}
1996 1996
 
1997 1997
 	/**
@@ -2004,10 +2004,10 @@  discard block
 block discarded – undo
2004 2004
 	 * @param array $query_params
2005 2005
 	 * @return int how many deleted
2006 2006
 	 */
2007
-	public function delete_related($id_or_obj,$model_name, $query_params = array()){
2007
+	public function delete_related($id_or_obj, $model_name, $query_params = array()) {
2008 2008
 		$model_obj = $this->ensure_is_obj($id_or_obj);
2009 2009
 		$relation_settings = $this->related_settings_for($model_name);
2010
-		return $relation_settings->delete_all_related($model_obj,$query_params);
2010
+		return $relation_settings->delete_all_related($model_obj, $query_params);
2011 2011
 	}
2012 2012
 
2013 2013
 	/**
@@ -2020,10 +2020,10 @@  discard block
 block discarded – undo
2020 2020
 	 * @param array $query_params
2021 2021
 	 * @return int how many deleted
2022 2022
 	 */
2023
-	public function delete_related_permanently($id_or_obj,$model_name, $query_params = array()){
2023
+	public function delete_related_permanently($id_or_obj, $model_name, $query_params = array()) {
2024 2024
 		$model_obj = $this->ensure_is_obj($id_or_obj);
2025 2025
 		$relation_settings = $this->related_settings_for($model_name);
2026
-		return $relation_settings->delete_related_permanently($model_obj,$query_params);
2026
+		return $relation_settings->delete_related_permanently($model_obj, $query_params);
2027 2027
 	}
2028 2028
 
2029 2029
 	/**
@@ -2036,17 +2036,17 @@  discard block
 block discarded – undo
2036 2036
 	 * @param bool 	 $distinct if we want to only count the distinct values for the column then you can trigger that by the setting $distinct to TRUE;
2037 2037
 	 * @return int
2038 2038
 	 */
2039
-	function count_related($id_or_obj,$model_name,$query_params = array(),$field_to_count = null, $distinct = FALSE){
2039
+	function count_related($id_or_obj, $model_name, $query_params = array(), $field_to_count = null, $distinct = FALSE) {
2040 2040
 		$related_model = $this->get_related_model_obj($model_name);
2041 2041
 		//we're just going to use the query params on the related model's normal get_all query,
2042 2042
 		//except add a condition to say to match the current mod
2043
-		if( ! isset($query_params['default_where_conditions'])){
2044
-			$query_params['default_where_conditions']='none';
2043
+		if ( ! isset($query_params['default_where_conditions'])) {
2044
+			$query_params['default_where_conditions'] = 'none';
2045 2045
 		}
2046 2046
 		$this_model_name = $this->get_this_model_name();
2047 2047
 		$this_pk_field_name = $this->get_primary_key_field()->get_name();
2048
-		$query_params[0][$this_model_name.".".$this_pk_field_name]=$id_or_obj;
2049
-		return $related_model->count($query_params,$field_to_count,$distinct);
2048
+		$query_params[0][$this_model_name.".".$this_pk_field_name] = $id_or_obj;
2049
+		return $related_model->count($query_params, $field_to_count, $distinct);
2050 2050
 	}
2051 2051
 
2052 2052
 
@@ -2060,21 +2060,21 @@  discard block
 block discarded – undo
2060 2060
 	 * @param string $field_to_sum name of field to count by. By default, uses primary key
2061 2061
 	 * @return float
2062 2062
 	 */
2063
-	function sum_related($id_or_obj,$model_name,$query_params,$field_to_sum = null){
2063
+	function sum_related($id_or_obj, $model_name, $query_params, $field_to_sum = null) {
2064 2064
 		$related_model = $this->get_related_model_obj($model_name);
2065
-		if( ! is_array( $query_params ) ){
2066
-			EE_Error::doing_it_wrong('EEM_Base::sum_related', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
2065
+		if ( ! is_array($query_params)) {
2066
+			EE_Error::doing_it_wrong('EEM_Base::sum_related', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
2067 2067
 			$query_params = array();
2068 2068
 		}
2069 2069
 		//we're just going to use the query params on the related model's normal get_all query,
2070 2070
 		//except add a condition to say to match the current mod
2071
-		if( ! isset($query_params['default_where_conditions'])){
2072
-			$query_params['default_where_conditions']='none';
2071
+		if ( ! isset($query_params['default_where_conditions'])) {
2072
+			$query_params['default_where_conditions'] = 'none';
2073 2073
 		}
2074 2074
 		$this_model_name = $this->get_this_model_name();
2075 2075
 		$this_pk_field_name = $this->get_primary_key_field()->get_name();
2076
-		$query_params[0][$this_model_name.".".$this_pk_field_name]=$id_or_obj;
2077
-		return $related_model->sum($query_params,$field_to_sum);
2076
+		$query_params[0][$this_model_name.".".$this_pk_field_name] = $id_or_obj;
2077
+		return $related_model->sum($query_params, $field_to_sum);
2078 2078
 	}
2079 2079
 
2080 2080
 
@@ -2086,12 +2086,12 @@  discard block
 block discarded – undo
2086 2086
 	 * @param array $query_params like EEM_Base::get_all's
2087 2087
 	 * @return EE_Base_Class
2088 2088
 	 */
2089
-	public function get_first_related( EE_Base_Class $id_or_obj, $other_model_name, $query_params ){
2090
-		$query_params['limit']=1;
2091
-		$results = $this->get_all_related($id_or_obj,$other_model_name,$query_params);
2092
-		if( $results ){
2089
+	public function get_first_related(EE_Base_Class $id_or_obj, $other_model_name, $query_params) {
2090
+		$query_params['limit'] = 1;
2091
+		$results = $this->get_all_related($id_or_obj, $other_model_name, $query_params);
2092
+		if ($results) {
2093 2093
 			return array_shift($results);
2094
-		}else{
2094
+		} else {
2095 2095
 			return null;
2096 2096
 		}
2097 2097
 
@@ -2101,8 +2101,8 @@  discard block
 block discarded – undo
2101 2101
 	 * Gets the model's name as it's expected in queries. For example, if this is EEM_Event model, that would be Event
2102 2102
 	 * @return string
2103 2103
 	 */
2104
-	function get_this_model_name(){
2105
-		return str_replace("EEM_","",get_class($this));
2104
+	function get_this_model_name() {
2105
+		return str_replace("EEM_", "", get_class($this));
2106 2106
 	}
2107 2107
 
2108 2108
 	/**
@@ -2110,14 +2110,14 @@  discard block
 block discarded – undo
2110 2110
 	 * @return EE_Any_Foreign_Model_Name_Field
2111 2111
 	 * @throws EE_Error
2112 2112
 	 */
2113
-	public function get_field_containing_related_model_name(){
2114
-		foreach($this->field_settings(true) as $field){
2115
-			if($field instanceof EE_Any_Foreign_Model_Name_Field){
2113
+	public function get_field_containing_related_model_name() {
2114
+		foreach ($this->field_settings(true) as $field) {
2115
+			if ($field instanceof EE_Any_Foreign_Model_Name_Field) {
2116 2116
 				$field_with_model_name = $field;
2117 2117
 			}
2118 2118
 		}
2119
-		if( !isset($field_with_model_name) || !$field_with_model_name ){
2120
-			throw new EE_Error(sprintf(__("There is no EE_Any_Foreign_Model_Name field on model %s", "event_espresso"), $this->get_this_model_name() ));
2119
+		if ( ! isset($field_with_model_name) || ! $field_with_model_name) {
2120
+			throw new EE_Error(sprintf(__("There is no EE_Any_Foreign_Model_Name field on model %s", "event_espresso"), $this->get_this_model_name()));
2121 2121
 		}
2122 2122
 		return $field_with_model_name;
2123 2123
 	}
@@ -2138,19 +2138,19 @@  discard block
 block discarded – undo
2138 2138
 	 * @return int new primary key on main table that got inserted
2139 2139
 	 * @throws EE_Error
2140 2140
 	 */
2141
-	function insert($field_n_values){
2141
+	function insert($field_n_values) {
2142 2142
 		/**
2143 2143
 		 * Filters the fields and their values before inserting an item using the models
2144 2144
 		 * @param array $fields_n_values keys are the fields and values are their new values
2145 2145
 		 * @param EEM_Base $model the model used
2146 2146
 		 */
2147
-		$field_n_values = apply_filters( 'FHEE__EEM_Base__insert__fields_n_values', $field_n_values, $this );
2148
-		if($this->_satisfies_unique_indexes($field_n_values)){
2147
+		$field_n_values = apply_filters('FHEE__EEM_Base__insert__fields_n_values', $field_n_values, $this);
2148
+		if ($this->_satisfies_unique_indexes($field_n_values)) {
2149 2149
 			$main_table = $this->_get_main_table();
2150 2150
 			$new_id = $this->_insert_into_specific_table($main_table, $field_n_values, false);
2151
-			if( $new_id !== false ) {
2152
-				foreach($this->_get_other_tables() as $other_table){
2153
-					$this->_insert_into_specific_table($other_table, $field_n_values,$new_id);
2151
+			if ($new_id !== false) {
2152
+				foreach ($this->_get_other_tables() as $other_table) {
2153
+					$this->_insert_into_specific_table($other_table, $field_n_values, $new_id);
2154 2154
 				}
2155 2155
 			}
2156 2156
 			/**
@@ -2160,9 +2160,9 @@  discard block
 block discarded – undo
2160 2160
 			 * @param array $fields_n_values fields and their values
2161 2161
 			 * @param int|string the ID of the newly-inserted model object
2162 2162
 			 */
2163
-			do_action( 'AHEE__EEM_Base__insert__end', $this, $field_n_values, $new_id );
2163
+			do_action('AHEE__EEM_Base__insert__end', $this, $field_n_values, $new_id);
2164 2164
 			return $new_id;
2165
-		}else{
2165
+		} else {
2166 2166
 			return FALSE;
2167 2167
 		}
2168 2168
 	}
@@ -2175,11 +2175,11 @@  discard block
 block discarded – undo
2175 2175
 	 * @param string $action
2176 2176
 	 * @return boolean
2177 2177
 	 */
2178
-	protected function _satisfies_unique_indexes($field_n_values,$action = 'insert'){
2179
-		foreach($this->unique_indexes() as $index_name => $index){
2178
+	protected function _satisfies_unique_indexes($field_n_values, $action = 'insert') {
2179
+		foreach ($this->unique_indexes() as $index_name => $index) {
2180 2180
 			$uniqueness_where_params = array_intersect_key($field_n_values, $index->fields());
2181
-			if($this->exists(array($uniqueness_where_params))){
2182
-				EE_Error::add_error(sprintf(__("Could not %s %s. %s uniqueness index failed. Fields %s must form a unique set, but an entry already exists with values %s.", "event_espresso"),$action,$this->_get_class_name(),$index_name,implode(",",$index->field_names()),http_build_query($uniqueness_where_params)), __FILE__, __FUNCTION__, __LINE__ );
2181
+			if ($this->exists(array($uniqueness_where_params))) {
2182
+				EE_Error::add_error(sprintf(__("Could not %s %s. %s uniqueness index failed. Fields %s must form a unique set, but an entry already exists with values %s.", "event_espresso"), $action, $this->_get_class_name(), $index_name, implode(",", $index->field_names()), http_build_query($uniqueness_where_params)), __FILE__, __FUNCTION__, __LINE__);
2183 2183
 				return false;
2184 2184
 			}
2185 2185
 		}
@@ -2200,28 +2200,28 @@  discard block
 block discarded – undo
2200 2200
 	 * @throws EE_Error
2201 2201
 	 * @return EE_Base_Class
2202 2202
 	 */
2203
-	public function get_one_conflicting($obj_or_fields_array, $include_primary_key = true ){
2204
-		if($obj_or_fields_array instanceof EE_Base_Class){
2203
+	public function get_one_conflicting($obj_or_fields_array, $include_primary_key = true) {
2204
+		if ($obj_or_fields_array instanceof EE_Base_Class) {
2205 2205
 			$fields_n_values = $obj_or_fields_array->model_field_array();
2206
-		}elseif( is_array($obj_or_fields_array)){
2206
+		}elseif (is_array($obj_or_fields_array)) {
2207 2207
 			$fields_n_values = $obj_or_fields_array;
2208
-		}else{
2209
-			throw new EE_Error(sprintf(__("%s get_all_conflicting should be called with a model object or an array of field names and values, you provided %d", "event_espresso"),get_class($this),$obj_or_fields_array));
2208
+		} else {
2209
+			throw new EE_Error(sprintf(__("%s get_all_conflicting should be called with a model object or an array of field names and values, you provided %d", "event_espresso"), get_class($this), $obj_or_fields_array));
2210 2210
 		}
2211 2211
 		$query_params = array();
2212
-		if( $this->has_primary_key_field() &&
2213
-				( $include_primary_key || $this->get_primary_key_field() instanceof EE_Primary_Key_String_Field) &&
2214
-				isset($fields_n_values[$this->primary_key_name()])){
2212
+		if ($this->has_primary_key_field() &&
2213
+				($include_primary_key || $this->get_primary_key_field() instanceof EE_Primary_Key_String_Field) &&
2214
+				isset($fields_n_values[$this->primary_key_name()])) {
2215 2215
 			$query_params[0]['OR'][$this->primary_key_name()] = $fields_n_values[$this->primary_key_name()];
2216 2216
 		}
2217
-		foreach($this->unique_indexes() as $unique_index_name=>$unique_index){
2217
+		foreach ($this->unique_indexes() as $unique_index_name=>$unique_index) {
2218 2218
 			$uniqueness_where_params = array_intersect_key($fields_n_values, $unique_index->fields());
2219 2219
 			$query_params[0]['OR']['AND*'.$unique_index_name] = $uniqueness_where_params;
2220 2220
 		}
2221 2221
 		//if there is nothing to base this search on, then we shouldn't find anything
2222
-		if( empty( $query_params ) ){
2222
+		if (empty($query_params)) {
2223 2223
 			return array();
2224
-		}else{
2224
+		} else {
2225 2225
 			return $this->get_one($query_params);
2226 2226
 		}
2227 2227
 	}
@@ -2231,7 +2231,7 @@  discard block
 block discarded – undo
2231 2231
 	 * @param array $query_params
2232 2232
 	 * @return boolean
2233 2233
 	 */
2234
-	function exists($query_params){
2234
+	function exists($query_params) {
2235 2235
 		$query_params['limit'] = 1;
2236 2236
 		return $this->count($query_params) > 0;
2237 2237
 	}
@@ -2241,7 +2241,7 @@  discard block
 block discarded – undo
2241 2241
 	 * @param int|string $id
2242 2242
 	 * @return boolean
2243 2243
 	 */
2244
-	function exists_by_ID($id){
2244
+	function exists_by_ID($id) {
2245 2245
 		return $this->exists(array('default_where_conditions'=>'none', array($this->primary_key_name() => $id)));
2246 2246
 	}
2247 2247
 
@@ -2261,45 +2261,45 @@  discard block
 block discarded – undo
2261 2261
 	 * @global WPDB $wpdb only used to get the $wpdb->insert_id after performing an insert
2262 2262
 	 * @return int ID of new row inserted, or FALSE on failure
2263 2263
 	 */
2264
-	protected function _insert_into_specific_table(EE_Table_Base $table, $fields_n_values, $new_id = 0 ){
2264
+	protected function _insert_into_specific_table(EE_Table_Base $table, $fields_n_values, $new_id = 0) {
2265 2265
 		global $wpdb;
2266 2266
 		$insertion_col_n_values = array();
2267 2267
 		$format_for_insertion = array();
2268 2268
 		$fields_on_table = $this->_get_fields_for_table($table->get_table_alias());
2269
-		foreach($fields_on_table as $field_name => $field_obj){
2269
+		foreach ($fields_on_table as $field_name => $field_obj) {
2270 2270
 			//check if its an auto-incrementing column, in which case we should just leave it to do its autoincrement thing
2271
-			if($field_obj->is_auto_increment()){
2271
+			if ($field_obj->is_auto_increment()) {
2272 2272
 				continue;
2273 2273
 			}
2274 2274
 			$prepared_value = $this->_prepare_value_or_use_default($field_obj, $fields_n_values);
2275 2275
 			//if the value we want to assign it to is NULL, just don't mention it for the insertion
2276
-			if( $prepared_value !== NULL ){
2277
-				$insertion_col_n_values[ $field_obj->get_table_column() ] = $prepared_value;
2276
+			if ($prepared_value !== NULL) {
2277
+				$insertion_col_n_values[$field_obj->get_table_column()] = $prepared_value;
2278 2278
 				$format_for_insertion[] = $field_obj->get_wpdb_data_type();
2279 2279
 			}
2280 2280
 		}
2281 2281
 
2282
-		if($table instanceof EE_Secondary_Table && $new_id){
2282
+		if ($table instanceof EE_Secondary_Table && $new_id) {
2283 2283
 			//its not the main table, so we should have already saved the main table's PK which we just inserted
2284 2284
 			//so add the fk to the main table as a column
2285 2285
 			$insertion_col_n_values[$table->get_fk_on_table()] = $new_id;
2286
-			$format_for_insertion[]='%d';//yes right now we're only allowing these foreign keys to be INTs
2286
+			$format_for_insertion[] = '%d'; //yes right now we're only allowing these foreign keys to be INTs
2287 2287
 		}
2288 2288
 		//insert the new entry
2289
-		$result = $this->_do_wpdb_query( 'insert', array( $table->get_table_name(), $insertion_col_n_values, $format_for_insertion ) );
2290
-		if( $result === false ) {
2289
+		$result = $this->_do_wpdb_query('insert', array($table->get_table_name(), $insertion_col_n_values, $format_for_insertion));
2290
+		if ($result === false) {
2291 2291
 			return false;
2292 2292
 		}
2293 2293
 		//ok, now what do we return for the ID of the newly-inserted thing?
2294
-		if($this->has_primary_key_field()){
2295
-			if($this->get_primary_key_field()->is_auto_increment()){
2294
+		if ($this->has_primary_key_field()) {
2295
+			if ($this->get_primary_key_field()->is_auto_increment()) {
2296 2296
 				return $wpdb->insert_id;
2297
-			}else{
2297
+			} else {
2298 2298
 				//it's not an auto-increment primary key, so
2299 2299
 				//it must have been supplied
2300 2300
 				return $fields_n_values[$this->get_primary_key_field()->get_name()];
2301 2301
 			}
2302
-		}else{
2302
+		} else {
2303 2303
 			//we can't return a  primary key because there is none. instead return
2304 2304
 			//a unique string indicating this model
2305 2305
 			return $this->get_index_primary_key_string($fields_n_values);
@@ -2314,15 +2314,15 @@  discard block
 block discarded – undo
2314 2314
 	 * @param array $fields_n_values
2315 2315
 	 * @return mixed string|int|float depending on what the table column will be expecting
2316 2316
 	 */
2317
-	protected function _prepare_value_or_use_default( $field_obj, $fields_n_values ){
2317
+	protected function _prepare_value_or_use_default($field_obj, $fields_n_values) {
2318 2318
 		//if this field doesn't allow nullable, don't allow it
2319
-		if( ! $field_obj->is_nullable() && (
2320
-				! isset( $fields_n_values[ $field_obj->get_name() ] ) ||
2321
-				$fields_n_values[ $field_obj->get_name() ] === NULL ) ){
2322
-			$fields_n_values[ $field_obj->get_name() ] = $field_obj->get_default_value();
2319
+		if ( ! $field_obj->is_nullable() && (
2320
+				! isset($fields_n_values[$field_obj->get_name()]) ||
2321
+				$fields_n_values[$field_obj->get_name()] === NULL )) {
2322
+			$fields_n_values[$field_obj->get_name()] = $field_obj->get_default_value();
2323 2323
 		}
2324
-		$unprepared_value = isset( $fields_n_values[ $field_obj->get_name() ] ) ? $fields_n_values[ $field_obj->get_name() ] : NULL;
2325
-		return $this->_prepare_value_for_use_in_db( $unprepared_value, $field_obj);
2324
+		$unprepared_value = isset($fields_n_values[$field_obj->get_name()]) ? $fields_n_values[$field_obj->get_name()] : NULL;
2325
+		return $this->_prepare_value_for_use_in_db($unprepared_value, $field_obj);
2326 2326
 	}
2327 2327
 
2328 2328
 
@@ -2334,9 +2334,9 @@  discard block
 block discarded – undo
2334 2334
 	 * @param EE_Model_Field_Base $field field which will be doing the preparing of the value. If null, we assume $value is a custom selection
2335 2335
 	 * @return mixed a value ready for use in the database for insertions, updating, or in a where clause
2336 2336
 	 */
2337
-	private function _prepare_value_for_use_in_db($value, $field){
2338
-		if($field && $field instanceof EE_Model_Field_Base){
2339
-			switch( $this->_values_already_prepared_by_model_object ){
2337
+	private function _prepare_value_for_use_in_db($value, $field) {
2338
+		if ($field && $field instanceof EE_Model_Field_Base) {
2339
+			switch ($this->_values_already_prepared_by_model_object) {
2340 2340
 				/** @noinspection PhpMissingBreakStatementInspection */
2341 2341
 				case self::not_prepared_by_model_object:
2342 2342
 					$value = $field->prepare_for_set($value);
@@ -2347,7 +2347,7 @@  discard block
 block discarded – undo
2347 2347
 					//leave the value alone
2348 2348
 			}
2349 2349
 			return $value;
2350
-		}else{
2350
+		} else {
2351 2351
 			return $value;
2352 2352
 		}
2353 2353
 	}
@@ -2357,13 +2357,13 @@  discard block
 block discarded – undo
2357 2357
 	 * @return EE_Primary_Table
2358 2358
 	 * @throws EE_Error
2359 2359
 	 */
2360
-	protected function _get_main_table(){
2361
-		foreach($this->_tables as $table){
2362
-			if($table instanceof EE_Primary_Table){
2360
+	protected function _get_main_table() {
2361
+		foreach ($this->_tables as $table) {
2362
+			if ($table instanceof EE_Primary_Table) {
2363 2363
 				return $table;
2364 2364
 			}
2365 2365
 		}
2366
-		throw new EE_Error(sprintf(__('There are no main tables on %s. They should be added to _tables array in the constructor','event_espresso'),get_class($this)));
2366
+		throw new EE_Error(sprintf(__('There are no main tables on %s. They should be added to _tables array in the constructor', 'event_espresso'), get_class($this)));
2367 2367
 	}
2368 2368
 
2369 2369
 	/**
@@ -2382,7 +2382,7 @@  discard block
 block discarded – undo
2382 2382
 	 */
2383 2383
 	public function second_table() {
2384 2384
 		// grab second table from tables array
2385
-		$second_table = end( $this->_tables );
2385
+		$second_table = end($this->_tables);
2386 2386
 		return $second_table instanceof EE_Secondary_Table ? $second_table->get_table_name() : NULL;
2387 2387
 	}
2388 2388
 
@@ -2395,8 +2395,8 @@  discard block
 block discarded – undo
2395 2395
 	 * @param string $table_alias
2396 2396
 	 * @return EE_Primary_Table | EE_Secondary_Table
2397 2397
 	 */
2398
-	public function get_table_obj_by_alias( $table_alias = '' ) {
2399
-		return isset( $this->_tables[ $table_alias ] ) ? $this->_tables[ $table_alias ] : NULL;
2398
+	public function get_table_obj_by_alias($table_alias = '') {
2399
+		return isset($this->_tables[$table_alias]) ? $this->_tables[$table_alias] : NULL;
2400 2400
 	}
2401 2401
 
2402 2402
 
@@ -2405,10 +2405,10 @@  discard block
 block discarded – undo
2405 2405
 	 * Gets all the tables of type EE_Other_Table from EEM_CPT_Basel_Model::_tables
2406 2406
 	 * @return EE_Secondary_Table[]
2407 2407
 	 */
2408
-	protected function _get_other_tables(){
2409
-		$other_tables =array();
2410
-		foreach($this->_tables as $table_alias => $table){
2411
-			if($table instanceof EE_Secondary_Table){
2408
+	protected function _get_other_tables() {
2409
+		$other_tables = array();
2410
+		foreach ($this->_tables as $table_alias => $table) {
2411
+			if ($table instanceof EE_Secondary_Table) {
2412 2412
 				$other_tables[$table_alias] = $table;
2413 2413
 			}
2414 2414
 		}
@@ -2420,7 +2420,7 @@  discard block
 block discarded – undo
2420 2420
 	 * @param string $table_alias, array key in EEM_Base::_tables
2421 2421
 	 * @return EE_Model_Field_Base[]
2422 2422
 	 */
2423
-	function _get_fields_for_table($table_alias){
2423
+	function _get_fields_for_table($table_alias) {
2424 2424
 		return $this->_fields[$table_alias];
2425 2425
 	}
2426 2426
 
@@ -2432,29 +2432,29 @@  discard block
 block discarded – undo
2432 2432
 	 * @param array $query_params like EEM_Base::get_all's $query_parameters['where']
2433 2433
 	 * @return EE_Model_Query_Info_Carrier
2434 2434
 	 */
2435
-	function _extract_related_models_from_query($query_params){
2435
+	function _extract_related_models_from_query($query_params) {
2436 2436
 		$query_info_carrier = new EE_Model_Query_Info_Carrier();
2437
-		if(array_key_exists(0,$query_params)){
2438
-			$this->_extract_related_models_from_sub_params_array_keys($query_params[0], $query_info_carrier,0);
2439
-		}
2440
-		if(array_key_exists('group_by', $query_params)){
2441
-			if(is_array($query_params['group_by'])){
2442
-				$this->_extract_related_models_from_sub_params_array_values($query_params['group_by'],$query_info_carrier,'group_by');
2443
-			}elseif( ! empty ( $query_params['group_by'] )){
2444
-				$this->_extract_related_model_info_from_query_param( $query_params['group_by'],$query_info_carrier,'group_by');
2437
+		if (array_key_exists(0, $query_params)) {
2438
+			$this->_extract_related_models_from_sub_params_array_keys($query_params[0], $query_info_carrier, 0);
2439
+		}
2440
+		if (array_key_exists('group_by', $query_params)) {
2441
+			if (is_array($query_params['group_by'])) {
2442
+				$this->_extract_related_models_from_sub_params_array_values($query_params['group_by'], $query_info_carrier, 'group_by');
2443
+			}elseif ( ! empty ($query_params['group_by'])) {
2444
+				$this->_extract_related_model_info_from_query_param($query_params['group_by'], $query_info_carrier, 'group_by');
2445 2445
 			}
2446 2446
 		}
2447
-		if(array_key_exists('having',$query_params)){
2448
-			$this->_extract_related_models_from_sub_params_array_keys($query_params[0], $query_info_carrier,'having');
2447
+		if (array_key_exists('having', $query_params)) {
2448
+			$this->_extract_related_models_from_sub_params_array_keys($query_params[0], $query_info_carrier, 'having');
2449 2449
 		}
2450
-		if(array_key_exists('order_by', $query_params)){
2451
-			if ( is_array( $query_params['order_by'] ) )
2452
-				$this->_extract_related_models_from_sub_params_array_keys($query_params['order_by'],$query_info_carrier,'order_by');
2453
-			elseif( ! empty( $query_params['order_by'] ))
2454
-				$this->_extract_related_model_info_from_query_param( $query_params['order_by'], $query_info_carrier,'order_by');
2450
+		if (array_key_exists('order_by', $query_params)) {
2451
+			if (is_array($query_params['order_by']))
2452
+				$this->_extract_related_models_from_sub_params_array_keys($query_params['order_by'], $query_info_carrier, 'order_by');
2453
+			elseif ( ! empty($query_params['order_by']))
2454
+				$this->_extract_related_model_info_from_query_param($query_params['order_by'], $query_info_carrier, 'order_by');
2455 2455
 		}
2456
-		if(array_key_exists('force_join', $query_params)){
2457
-			$this->_extract_related_models_from_sub_params_array_values($query_params['force_join'],$query_info_carrier,'force_join');
2456
+		if (array_key_exists('force_join', $query_params)) {
2457
+			$this->_extract_related_models_from_sub_params_array_values($query_params['force_join'], $query_info_carrier, 'force_join');
2458 2458
 		}
2459 2459
 		return $query_info_carrier;
2460 2460
 	}
@@ -2467,34 +2467,34 @@  discard block
 block discarded – undo
2467 2467
 	 * @throws EE_Error
2468 2468
 	 * @return \EE_Model_Query_Info_Carrier
2469 2469
 	 */
2470
-	private function _extract_related_models_from_sub_params_array_keys($sub_query_params, EE_Model_Query_Info_Carrier $model_query_info_carrier,$query_param_type){
2471
-		if (!empty($sub_query_params)){
2470
+	private function _extract_related_models_from_sub_params_array_keys($sub_query_params, EE_Model_Query_Info_Carrier $model_query_info_carrier, $query_param_type) {
2471
+		if ( ! empty($sub_query_params)) {
2472 2472
 			$sub_query_params = (array) $sub_query_params;
2473
-			foreach($sub_query_params as $param => $possibly_array_of_params){
2473
+			foreach ($sub_query_params as $param => $possibly_array_of_params) {
2474 2474
 				//$param could be simply 'EVT_ID', or it could be 'Registrations.REG_ID', or even 'Registrations.Transactions.Payments.PAY_amount'
2475
-				$this->_extract_related_model_info_from_query_param( $param, $model_query_info_carrier,$query_param_type);
2475
+				$this->_extract_related_model_info_from_query_param($param, $model_query_info_carrier, $query_param_type);
2476 2476
 
2477 2477
 				//if $possibly_array_of_params is an array, try recursing into it, searching for keys which
2478 2478
 				//indicate needed joins. Eg, array('NOT'=>array('Registration.TXN_ID'=>23)). In this case, we tried
2479 2479
 				//extracting models out of the 'NOT', which obviously wasn't successful, and then we recurse into the value
2480 2480
 				//of array('Registration.TXN_ID'=>23)
2481 2481
 				$query_param_sans_stars = $this->_remove_stars_and_anything_after_from_condition_query_param_key($param);
2482
-				if(in_array($query_param_sans_stars, $this->_logic_query_param_keys,true)){
2483
-					if (! is_array($possibly_array_of_params)){
2482
+				if (in_array($query_param_sans_stars, $this->_logic_query_param_keys, true)) {
2483
+					if ( ! is_array($possibly_array_of_params)) {
2484 2484
 						throw new EE_Error(sprintf(__("You used a special where query param %s, but the value isn't an array of where query params, it's just %s'. It should be an array, eg array('EVT_ID'=>23,'OR'=>array('Venue.VNU_ID'=>32,'Venue.VNU_name'=>'monkey_land'))", "event_espresso"),
2485
-							$param,$possibly_array_of_params));
2486
-					}else{
2487
-						$this->_extract_related_models_from_sub_params_array_keys($possibly_array_of_params, $model_query_info_carrier,$query_param_type);
2485
+							$param, $possibly_array_of_params));
2486
+					} else {
2487
+						$this->_extract_related_models_from_sub_params_array_keys($possibly_array_of_params, $model_query_info_carrier, $query_param_type);
2488 2488
 					}
2489
-				}elseif($query_param_type === 0 //ie WHERE
2489
+				}elseif ($query_param_type === 0 //ie WHERE
2490 2490
 						&& is_array($possibly_array_of_params)
2491 2491
 						&& isset($possibly_array_of_params[2])
2492
-						&& $possibly_array_of_params[2] == true){
2492
+						&& $possibly_array_of_params[2] == true) {
2493 2493
 					//then $possible_array_of_params looks something like array('<','DTT_sold',true)
2494 2494
 					//indicating that $possible_array_of_params[1] is actually a field name,
2495 2495
 					//from which we should extract query parameters!
2496
-					if(! isset($possibly_array_of_params[0]) || ! isset($possibly_array_of_params[1])){
2497
-						throw new EE_Error(sprintf(__("Improperly formed query parameter %s. It should be numerically indexed like array('<','DTT_sold',true); but you provided %s", "event_espresso"),$query_param_type,implode(",",$possibly_array_of_params)));
2496
+					if ( ! isset($possibly_array_of_params[0]) || ! isset($possibly_array_of_params[1])) {
2497
+						throw new EE_Error(sprintf(__("Improperly formed query parameter %s. It should be numerically indexed like array('<','DTT_sold',true); but you provided %s", "event_espresso"), $query_param_type, implode(",", $possibly_array_of_params)));
2498 2498
 					}
2499 2499
 					$this->_extract_related_model_info_from_query_param($possibly_array_of_params[1], $model_query_info_carrier, $query_param_type);
2500 2500
 				}
@@ -2513,14 +2513,14 @@  discard block
 block discarded – undo
2513 2513
 	 * @throws EE_Error
2514 2514
 	 * @return \EE_Model_Query_Info_Carrier
2515 2515
 	 */
2516
-	private function _extract_related_models_from_sub_params_array_values($sub_query_params, EE_Model_Query_Info_Carrier $model_query_info_carrier,$query_param_type){
2517
-		if (!empty($sub_query_params)){
2518
-			if(!is_array($sub_query_params)){
2519
-				throw new EE_Error(sprintf(__("Query parameter %s should be an array, but it isn't.", "event_espresso"),$sub_query_params));
2516
+	private function _extract_related_models_from_sub_params_array_values($sub_query_params, EE_Model_Query_Info_Carrier $model_query_info_carrier, $query_param_type) {
2517
+		if ( ! empty($sub_query_params)) {
2518
+			if ( ! is_array($sub_query_params)) {
2519
+				throw new EE_Error(sprintf(__("Query parameter %s should be an array, but it isn't.", "event_espresso"), $sub_query_params));
2520 2520
 			}
2521
-			foreach($sub_query_params as $param){
2521
+			foreach ($sub_query_params as $param) {
2522 2522
 				//$param could be simply 'EVT_ID', or it could be 'Registrations.REG_ID', or even 'Registrations.Transactions.Payments.PAY_amount'
2523
-				$this->_extract_related_model_info_from_query_param( $param, $model_query_info_carrier, $query_param_type);
2523
+				$this->_extract_related_model_info_from_query_param($param, $model_query_info_carrier, $query_param_type);
2524 2524
 			}
2525 2525
 		}
2526 2526
 		return $model_query_info_carrier;
@@ -2539,81 +2539,81 @@  discard block
 block discarded – undo
2539 2539
 	 * @throws EE_Error
2540 2540
 	 * @return EE_Model_Query_Info_Carrier
2541 2541
 	 */
2542
-	function _create_model_query_info_carrier($query_params){
2543
-		if( ! is_array( $query_params ) ){
2544
-			EE_Error::doing_it_wrong('EEM_Base::_create_model_query_info_carrier', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
2542
+	function _create_model_query_info_carrier($query_params) {
2543
+		if ( ! is_array($query_params)) {
2544
+			EE_Error::doing_it_wrong('EEM_Base::_create_model_query_info_carrier', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
2545 2545
 			$query_params = array();
2546 2546
 		}
2547
-		if( isset( $query_params[0] ) ) {
2547
+		if (isset($query_params[0])) {
2548 2548
 			$where_query_params = $query_params[0];
2549
-		}else{
2549
+		} else {
2550 2550
 			$where_query_params = array();
2551 2551
 		}
2552 2552
 		//first check if we should alter the query to account for caps or not
2553 2553
 		//because the caps might require us to do extra joins
2554
-		if( isset( $query_params[ 'caps' ] ) && $query_params[ 'caps' ] != 'none' ) {
2555
-			$query_params[0] = $where_query_params = array_replace_recursive( $where_query_params, $this->caps_where_conditions( $query_params[ 'caps' ] ) );
2554
+		if (isset($query_params['caps']) && $query_params['caps'] != 'none') {
2555
+			$query_params[0] = $where_query_params = array_replace_recursive($where_query_params, $this->caps_where_conditions($query_params['caps']));
2556 2556
 		}
2557 2557
 		$query_object = $this->_extract_related_models_from_query($query_params);
2558 2558
 
2559 2559
 		//verify where_query_params has NO numeric indexes.... that's simply not how you use it!
2560
-		foreach($where_query_params as $key => $value){
2561
-			if(is_int($key)){
2562
-				throw new EE_Error(sprintf(__("WHERE query params must NOT be numerically-indexed. You provided the array key '%s' for value '%s' while querying model %s. All the query params provided were '%s' Please read documentation on EEM_Base::get_all.", "event_espresso"),$key, var_export( $value, true ), var_export( $query_params, true ), get_class($this)));
2560
+		foreach ($where_query_params as $key => $value) {
2561
+			if (is_int($key)) {
2562
+				throw new EE_Error(sprintf(__("WHERE query params must NOT be numerically-indexed. You provided the array key '%s' for value '%s' while querying model %s. All the query params provided were '%s' Please read documentation on EEM_Base::get_all.", "event_espresso"), $key, var_export($value, true), var_export($query_params, true), get_class($this)));
2563 2563
 			}
2564 2564
 		}
2565
-		if( array_key_exists( 'default_where_conditions',$query_params) && ! empty( $query_params['default_where_conditions'] )){
2565
+		if (array_key_exists('default_where_conditions', $query_params) && ! empty($query_params['default_where_conditions'])) {
2566 2566
 			$use_default_where_conditions = $query_params['default_where_conditions'];
2567
-		}else{
2567
+		} else {
2568 2568
 			$use_default_where_conditions = 'all';
2569 2569
 		}
2570
-		$where_query_params = array_merge($this->_get_default_where_conditions_for_models_in_query($query_object,$use_default_where_conditions,$where_query_params), $where_query_params );
2571
-		$query_object->set_where_sql( $this->_construct_where_clause($where_query_params));
2570
+		$where_query_params = array_merge($this->_get_default_where_conditions_for_models_in_query($query_object, $use_default_where_conditions, $where_query_params), $where_query_params);
2571
+		$query_object->set_where_sql($this->_construct_where_clause($where_query_params));
2572 2572
 
2573 2573
 
2574 2574
 		//if this is a "on_join_limit" then we are limiting on on a specific table in a multi_table join.  So we need to setup a subquery and use that for the main join.  Note for now this only works on the primary table for the model.  So for instance, you could set the limit array like this:
2575 2575
 		//array( 'on_join_limit' => array('Primary_Table_Alias', array(1,10) ) )
2576
-		if ( array_key_exists('on_join_limit', $query_params ) && ! empty( $query_params['on_join_limit'] )) {
2577
-			$query_object->set_main_model_join_sql( $this->_construct_limit_join_select( $query_params['on_join_limit'][0], $query_params['on_join_limit'][1] ) );
2576
+		if (array_key_exists('on_join_limit', $query_params) && ! empty($query_params['on_join_limit'])) {
2577
+			$query_object->set_main_model_join_sql($this->_construct_limit_join_select($query_params['on_join_limit'][0], $query_params['on_join_limit'][1]));
2578 2578
 		}
2579 2579
 
2580 2580
 
2581 2581
 		//set limit
2582
-		if(array_key_exists('limit',$query_params)){
2583
-			if(is_array($query_params['limit'])){
2584
-				if( ! isset($query_params['limit'][0]) || ! isset($query_params['limit'][1])){
2585
-					$e = sprintf(__("Invalid DB query. You passed '%s' for the LIMIT, but only the following are valid: an integer, string representing an integer, a string like 'int,int', or an array like array(int,int)", "event_espresso"),  http_build_query($query_params['limit']));
2582
+		if (array_key_exists('limit', $query_params)) {
2583
+			if (is_array($query_params['limit'])) {
2584
+				if ( ! isset($query_params['limit'][0]) || ! isset($query_params['limit'][1])) {
2585
+					$e = sprintf(__("Invalid DB query. You passed '%s' for the LIMIT, but only the following are valid: an integer, string representing an integer, a string like 'int,int', or an array like array(int,int)", "event_espresso"), http_build_query($query_params['limit']));
2586 2586
 					throw new EE_Error($e."|".$e);
2587 2587
 				}
2588 2588
 				//they passed us an array for the limit. Assume it's like array(50,25), meaning offset by 50, and get 25
2589 2589
 				$query_object->set_limit_sql(" LIMIT ".$query_params['limit'][0].",".$query_params['limit'][1]);
2590
-			}elseif( ! empty ( $query_params['limit'] )){
2590
+			}elseif ( ! empty ($query_params['limit'])) {
2591 2591
 				$query_object->set_limit_sql((" LIMIT ".$query_params['limit']));
2592 2592
 			}
2593 2593
 		}
2594 2594
 		//set order by
2595
-		if(array_key_exists('order_by',$query_params)){
2596
-			if(is_array($query_params['order_by'])){
2595
+		if (array_key_exists('order_by', $query_params)) {
2596
+			if (is_array($query_params['order_by'])) {
2597 2597
 				//if they're using 'order_by' as an array, they can't use 'order' (because 'order_by' must
2598 2598
 				//specify whether to ascend or descend on each field. Eg 'order_by'=>array('EVT_ID'=>'ASC'). So
2599 2599
 				//including 'order' wouldn't make any sense if 'order_by' has already specified which way to order!
2600
-				if(array_key_exists('order', $query_params)){
2600
+				if (array_key_exists('order', $query_params)) {
2601 2601
 					throw new EE_Error(sprintf(__("In querying %s, we are using query parameter 'order_by' as an array (keys:%s,values:%s), and so we can't use query parameter 'order' (value %s). You should just use the 'order_by' parameter ", "event_espresso"),
2602
-							get_class($this),implode(", ",array_keys($query_params['order_by'])),implode(", ",$query_params['order_by']),$query_params['order']));
2602
+							get_class($this), implode(", ", array_keys($query_params['order_by'])), implode(", ", $query_params['order_by']), $query_params['order']));
2603 2603
 				}
2604
-				 $this->_extract_related_models_from_sub_params_array_keys($query_params['order_by'],$query_object,'order_by');
2604
+				 $this->_extract_related_models_from_sub_params_array_keys($query_params['order_by'], $query_object, 'order_by');
2605 2605
 				//assume it's an array of fields to order by
2606 2606
 				$order_array = array();
2607
-				foreach($query_params['order_by'] as $field_name_to_order_by => $order){
2607
+				foreach ($query_params['order_by'] as $field_name_to_order_by => $order) {
2608 2608
 					$order = $this->_extract_order($order);
2609 2609
 					$order_array[] = $this->_deduce_column_name_from_query_param($field_name_to_order_by).SP.$order;
2610 2610
 				}
2611
-				$query_object->set_order_by_sql(" ORDER BY ".implode(",",$order_array));
2612
-			}elseif( ! empty ( $query_params['order_by'] )){
2613
-				$this->_extract_related_model_info_from_query_param($query_params['order_by'],$query_object,'order',$query_params['order_by']);
2614
-				if(isset($query_params['order'])){
2611
+				$query_object->set_order_by_sql(" ORDER BY ".implode(",", $order_array));
2612
+			}elseif ( ! empty ($query_params['order_by'])) {
2613
+				$this->_extract_related_model_info_from_query_param($query_params['order_by'], $query_object, 'order', $query_params['order_by']);
2614
+				if (isset($query_params['order'])) {
2615 2615
 					$order = $this->_extract_order($query_params['order']);
2616
-				}else{
2616
+				} else {
2617 2617
 					$order = 'DESC';
2618 2618
 				}
2619 2619
 				$query_object->set_order_by_sql(" ORDER BY ".$this->_deduce_column_name_from_query_param($query_params['order_by']).SP.$order);
@@ -2621,46 +2621,46 @@  discard block
 block discarded – undo
2621 2621
 		}
2622 2622
 
2623 2623
 		//if 'order_by' wasn't set, maybe they are just using 'order' on its own?
2624
-		if( ! array_key_exists('order_by',$query_params) && array_key_exists('order',$query_params) && ! empty( $query_params['order'] )){
2624
+		if ( ! array_key_exists('order_by', $query_params) && array_key_exists('order', $query_params) && ! empty($query_params['order'])) {
2625 2625
 			$pk_field = $this->get_primary_key_field();
2626 2626
 			$order = $this->_extract_order($query_params['order']);
2627 2627
 			$query_object->set_order_by_sql(" ORDER BY ".$pk_field->get_qualified_column().SP.$order);
2628 2628
 		}
2629 2629
 
2630 2630
 		//set group by
2631
-		if(array_key_exists('group_by',$query_params)){
2632
-			if(is_array($query_params['group_by'])){
2631
+		if (array_key_exists('group_by', $query_params)) {
2632
+			if (is_array($query_params['group_by'])) {
2633 2633
 				//it's an array, so assume we'll be grouping by a bunch of stuff
2634 2634
 				$group_by_array = array();
2635
-				foreach($query_params['group_by'] as $field_name_to_group_by){
2635
+				foreach ($query_params['group_by'] as $field_name_to_group_by) {
2636 2636
 					$group_by_array[] = $this->_deduce_column_name_from_query_param($field_name_to_group_by);
2637 2637
 				}
2638
-				$query_object->set_group_by_sql(" GROUP BY ".implode(", ",$group_by_array));
2639
-			}elseif( ! empty ( $query_params['group_by'] )){
2638
+				$query_object->set_group_by_sql(" GROUP BY ".implode(", ", $group_by_array));
2639
+			}elseif ( ! empty ($query_params['group_by'])) {
2640 2640
 				$query_object->set_group_by_sql(" GROUP BY ".$this->_deduce_column_name_from_query_param($query_params['group_by']));
2641 2641
 			}
2642 2642
 		}
2643 2643
 		//set having
2644
-		if(array_key_exists('having',$query_params) && $query_params['having']){
2645
-			$query_object->set_having_sql( $this->_construct_having_clause($query_params['having']));
2644
+		if (array_key_exists('having', $query_params) && $query_params['having']) {
2645
+			$query_object->set_having_sql($this->_construct_having_clause($query_params['having']));
2646 2646
 		}
2647 2647
 
2648 2648
 		//now, just verify they didn't pass anything wack
2649
-		foreach($query_params as $query_key => $query_value){
2650
-			if( ! in_array($query_key,$this->_allowed_query_params,true)){
2649
+		foreach ($query_params as $query_key => $query_value) {
2650
+			if ( ! in_array($query_key, $this->_allowed_query_params, true)) {
2651 2651
 				throw new EE_Error(
2652 2652
 					sprintf(
2653
-						__("You passed %s as a query parameter to %s, which is illegal! The allowed query parameters are %s",'event_espresso'),
2653
+						__("You passed %s as a query parameter to %s, which is illegal! The allowed query parameters are %s", 'event_espresso'),
2654 2654
 						$query_key,
2655 2655
 						get_class($this),
2656 2656
 //						print_r( $this->_allowed_query_params, TRUE )
2657
-						implode( ',', $this->_allowed_query_params )
2657
+						implode(',', $this->_allowed_query_params)
2658 2658
 					)
2659 2659
 				);
2660 2660
 			}
2661 2661
 		}
2662 2662
 		$main_model_join_sql = $query_object->get_main_model_join_sql();
2663
-		if ( empty( $main_model_join_sql ) )
2663
+		if (empty($main_model_join_sql))
2664 2664
 			$query_object->set_main_model_join_sql($this->_construct_internal_join());
2665 2665
 		return $query_object;
2666 2666
 	}
@@ -2671,17 +2671,17 @@  discard block
 block discarded – undo
2671 2671
 	 * @param string $context one of EEM_Base::valid_cap_contexts()
2672 2672
 	 * @return array like EEM_Base::get_all() 's $query_params[0]
2673 2673
 	 */
2674
-	public function caps_where_conditions( $context = self::caps_read ) {
2675
-		EEM_Base::verify_is_valid_cap_context( $context );
2674
+	public function caps_where_conditions($context = self::caps_read) {
2675
+		EEM_Base::verify_is_valid_cap_context($context);
2676 2676
 		$cap_where_conditions = array();
2677
-		$cap_restrictions = $this->caps_missing( $context );
2677
+		$cap_restrictions = $this->caps_missing($context);
2678 2678
 		/**
2679 2679
 		 * @var $cap_restrictions EE_Default_Where_Conditions[]
2680 2680
 		 */
2681
-		foreach( $cap_restrictions as $cap => $restriction_if_no_cap ) {
2682
-				$cap_where_conditions = array_replace_recursive( $cap_where_conditions, $restriction_if_no_cap->get_default_where_conditions() );
2681
+		foreach ($cap_restrictions as $cap => $restriction_if_no_cap) {
2682
+				$cap_where_conditions = array_replace_recursive($cap_where_conditions, $restriction_if_no_cap->get_default_where_conditions());
2683 2683
 		}
2684
-		return apply_filters( 'FHEE__EEM_Base__caps_where_conditions__return', $cap_where_conditions, $this, $context, $cap_restrictions );
2684
+		return apply_filters('FHEE__EEM_Base__caps_where_conditions__return', $cap_where_conditions, $this, $context, $cap_restrictions);
2685 2685
 	}
2686 2686
 
2687 2687
 	/**
@@ -2691,11 +2691,11 @@  discard block
 block discarded – undo
2691 2691
 	 * @return string either ASC, asc, DESC or desc
2692 2692
 	 * @throws EE_Error
2693 2693
 	 */
2694
-	private function _extract_order($should_be_order_string){
2695
-		if(in_array($should_be_order_string, $this->_allowed_order_values)){
2694
+	private function _extract_order($should_be_order_string) {
2695
+		if (in_array($should_be_order_string, $this->_allowed_order_values)) {
2696 2696
 			return $should_be_order_string;
2697
-		}else{
2698
-			throw new EE_Error(sprintf(__("While performing a query on '%s', tried to use '%s' as an order parameter. ", "event_espresso"),get_class($this),$should_be_order_string));
2697
+		} else {
2698
+			throw new EE_Error(sprintf(__("While performing a query on '%s', tried to use '%s' as an order parameter. ", "event_espresso"), get_class($this), $should_be_order_string));
2699 2699
 		}
2700 2700
 	}
2701 2701
 
@@ -2713,19 +2713,19 @@  discard block
 block discarded – undo
2713 2713
 	 * @throws EE_Error
2714 2714
 	 * @return array like $query_params[0], see EEM_Base::get_all for documentation
2715 2715
 	 */
2716
-	private function _get_default_where_conditions_for_models_in_query(EE_Model_Query_Info_Carrier $query_info_carrier,$use_default_where_conditions = 'all',$where_query_params = array()){
2717
-		$allowed_used_default_where_conditions_values = array('all','this_model_only', 'other_models_only','none');
2718
-		if( ! in_array($use_default_where_conditions,$allowed_used_default_where_conditions_values)){
2719
-			throw new EE_Error(sprintf(__("You passed an invalid value to the query parameter 'default_where_conditions' of '%s'. Allowed values are %s", "event_espresso"),$use_default_where_conditions,implode(", ",$allowed_used_default_where_conditions_values)));
2716
+	private function _get_default_where_conditions_for_models_in_query(EE_Model_Query_Info_Carrier $query_info_carrier, $use_default_where_conditions = 'all', $where_query_params = array()) {
2717
+		$allowed_used_default_where_conditions_values = array('all', 'this_model_only', 'other_models_only', 'none');
2718
+		if ( ! in_array($use_default_where_conditions, $allowed_used_default_where_conditions_values)) {
2719
+			throw new EE_Error(sprintf(__("You passed an invalid value to the query parameter 'default_where_conditions' of '%s'. Allowed values are %s", "event_espresso"), $use_default_where_conditions, implode(", ", $allowed_used_default_where_conditions_values)));
2720 2720
 		}
2721
-		if( in_array($use_default_where_conditions, array('all','this_model_only')) ){
2721
+		if (in_array($use_default_where_conditions, array('all', 'this_model_only'))) {
2722 2722
 			$universal_query_params = $this->_get_default_where_conditions();
2723
-		}else{
2723
+		} else {
2724 2724
 			$universal_query_params = array();
2725 2725
 		}
2726 2726
 
2727
-		if(in_array($use_default_where_conditions,array('all','other_models_only'))){
2728
-			foreach($query_info_carrier->get_model_names_included() as $model_relation_path => $model_name){
2727
+		if (in_array($use_default_where_conditions, array('all', 'other_models_only'))) {
2728
+			foreach ($query_info_carrier->get_model_names_included() as $model_relation_path => $model_name) {
2729 2729
 				$related_model = $this->get_related_model_obj($model_name);
2730 2730
 				$related_model_universal_where_params = $related_model->_get_default_where_conditions($model_relation_path);
2731 2731
 
@@ -2752,22 +2752,22 @@  discard block
 block discarded – undo
2752 2752
 	 * @param string $model_relation_path like 'Transaction.Payment.'
2753 2753
 	 * @return array like EEM_Base::get_all's $query_params[0]
2754 2754
 	 */
2755
-	private function _override_defaults_or_make_null_friendly($default_where_conditions,$provided_where_conditions,$model,$model_relation_path){
2755
+	private function _override_defaults_or_make_null_friendly($default_where_conditions, $provided_where_conditions, $model, $model_relation_path) {
2756 2756
 		$null_friendly_where_conditions = array();
2757 2757
 		$none_overridden = true;
2758 2758
 		$or_condition_key_for_defaults = 'OR*'.get_class($model);
2759 2759
 
2760
-		foreach($default_where_conditions as $key => $val){
2761
-			if( isset($provided_where_conditions[$key])){
2760
+		foreach ($default_where_conditions as $key => $val) {
2761
+			if (isset($provided_where_conditions[$key])) {
2762 2762
 				$none_overridden = false;
2763
-			}else{
2763
+			} else {
2764 2764
 				$null_friendly_where_conditions[$or_condition_key_for_defaults]['AND'][$key] = $val;
2765 2765
 			}
2766 2766
 		}
2767
-		if( $none_overridden && $default_where_conditions){
2768
-			if($model->has_primary_key_field()){
2767
+		if ($none_overridden && $default_where_conditions) {
2768
+			if ($model->has_primary_key_field()) {
2769 2769
 				$null_friendly_where_conditions[$or_condition_key_for_defaults][$model_relation_path.".".$model->primary_key_name()] = array('IS NULL');
2770
-			}else{
2770
+			} else {
2771 2771
 				//@todo NO PK, use other defaults
2772 2772
 			}
2773 2773
 		}
@@ -2782,8 +2782,8 @@  discard block
 block discarded – undo
2782 2782
 	 * @param string $model_relation_path eg, path from Event to Payment is "Registration.Transaction.Payment."
2783 2783
 	 * @return array like EEM_Base::get_all's $query_params[0] (where conditions)
2784 2784
 	 */
2785
-	private function _get_default_where_conditions($model_relation_path = null){
2786
-		if ( $this->_ignore_where_strategy )
2785
+	private function _get_default_where_conditions($model_relation_path = null) {
2786
+		if ($this->_ignore_where_strategy)
2787 2787
 			return array();
2788 2788
 
2789 2789
 		return $this->_default_where_conditions_strategy->get_default_where_conditions($model_relation_path);
@@ -2794,13 +2794,13 @@  discard block
 block discarded – undo
2794 2794
 	 * @param EE_Model_Query_Info_Carrier $model_query_info
2795 2795
 	 * @return string
2796 2796
 	 */
2797
-	private function _construct_default_select_sql(EE_Model_Query_Info_Carrier $model_query_info){
2797
+	private function _construct_default_select_sql(EE_Model_Query_Info_Carrier $model_query_info) {
2798 2798
 		$selects = $this->_get_columns_to_select_for_this_model();
2799
-		foreach($model_query_info->get_model_names_included() as $model_relation_chain => $name_of_other_model_included){
2799
+		foreach ($model_query_info->get_model_names_included() as $model_relation_chain => $name_of_other_model_included) {
2800 2800
 			$other_model_included = $this->get_related_model_obj($name_of_other_model_included);
2801 2801
 			$selects = array_merge($selects, $other_model_included->_get_columns_to_select_for_this_model($model_relation_chain));
2802 2802
 		}
2803
-		return implode(", ",$selects);
2803
+		return implode(", ", $selects);
2804 2804
 	}
2805 2805
 
2806 2806
 	/**
@@ -2809,19 +2809,19 @@  discard block
 block discarded – undo
2809 2809
 	 * @param string $model_relation_chain like 'Question.Question_Group.Event'
2810 2810
 	 * @return array numerically indexed, values are columns to select and rename, eg "Event.ID AS 'Event.ID'"
2811 2811
 	 */
2812
-	public function _get_columns_to_select_for_this_model($model_relation_chain = ''){
2812
+	public function _get_columns_to_select_for_this_model($model_relation_chain = '') {
2813 2813
 		$fields = $this->field_settings();
2814 2814
 		$selects = array();
2815 2815
 		$table_alias_with_model_relation_chain_prefix = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model_name());
2816
-		foreach($fields as $field_obj){
2817
-			$selects[] = $table_alias_with_model_relation_chain_prefix . $field_obj->get_table_alias().".".$field_obj->get_table_column()." AS '".$table_alias_with_model_relation_chain_prefix.$field_obj->get_table_alias().".".$field_obj->get_table_column()."'";
2816
+		foreach ($fields as $field_obj) {
2817
+			$selects[] = $table_alias_with_model_relation_chain_prefix.$field_obj->get_table_alias().".".$field_obj->get_table_column()." AS '".$table_alias_with_model_relation_chain_prefix.$field_obj->get_table_alias().".".$field_obj->get_table_column()."'";
2818 2818
 		}
2819 2819
 		//make sure we are also getting the PKs of each table
2820 2820
 		$tables = $this->get_tables();
2821
-		if(count($tables) > 1){
2822
-			foreach($tables as $table_obj){
2823
-				$qualified_pk_column = $table_alias_with_model_relation_chain_prefix . $table_obj->get_fully_qualified_pk_column();
2824
-				if( ! in_array($qualified_pk_column,$selects)){
2821
+		if (count($tables) > 1) {
2822
+			foreach ($tables as $table_obj) {
2823
+				$qualified_pk_column = $table_alias_with_model_relation_chain_prefix.$table_obj->get_fully_qualified_pk_column();
2824
+				if ( ! in_array($qualified_pk_column, $selects)) {
2825 2825
 					$selects[] = "$qualified_pk_column AS '$qualified_pk_column'";
2826 2826
 				}
2827 2827
 			}
@@ -2845,66 +2845,66 @@  discard block
 block discarded – undo
2845 2845
 	 * @throws EE_Error
2846 2846
 	 * @return void only modifies the EEM_Related_Model_Info_Carrier passed into it
2847 2847
 	 */
2848
-	private function _extract_related_model_info_from_query_param( $query_param, EE_Model_Query_Info_Carrier $passed_in_query_info, $query_param_type, $original_query_param = NULL ){
2849
-		if($original_query_param == NULL){
2848
+	private function _extract_related_model_info_from_query_param($query_param, EE_Model_Query_Info_Carrier $passed_in_query_info, $query_param_type, $original_query_param = NULL) {
2849
+		if ($original_query_param == NULL) {
2850 2850
 			$original_query_param = $query_param;
2851 2851
 		}
2852 2852
 		$query_param = $this->_remove_stars_and_anything_after_from_condition_query_param_key($query_param);
2853 2853
 		/** @var $allow_logic_query_params bool whether or not to allow logic_query_params like 'NOT','OR', or 'AND' */
2854
-		$allow_logic_query_params = in_array($query_param_type,array('where','having'));
2855
-		$allow_fields = in_array($query_param_type,array('where','having','order_by','group_by','order'));
2854
+		$allow_logic_query_params = in_array($query_param_type, array('where', 'having'));
2855
+		$allow_fields = in_array($query_param_type, array('where', 'having', 'order_by', 'group_by', 'order'));
2856 2856
 		//check to see if we have a field on this model
2857 2857
 		$this_model_fields = $this->field_settings(true);
2858
-		if(array_key_exists($query_param,$this_model_fields)){
2859
-			if($allow_fields){
2858
+		if (array_key_exists($query_param, $this_model_fields)) {
2859
+			if ($allow_fields) {
2860 2860
 				return;
2861
-			}else{
2861
+			} else {
2862 2862
 				throw new EE_Error(sprintf(__("Using a field name (%s) on model %s is not allowed on this query param type '%s'. Original query param was %s", "event_espresso"),
2863
-						$query_param,get_class($this),$query_param_type,$original_query_param));
2863
+						$query_param, get_class($this), $query_param_type, $original_query_param));
2864 2864
 			}
2865 2865
 		}
2866 2866
 		//check if this is a special logic query param
2867
-		elseif(in_array($query_param, $this->_logic_query_param_keys, TRUE)){
2868
-			if($allow_logic_query_params){
2867
+		elseif (in_array($query_param, $this->_logic_query_param_keys, TRUE)) {
2868
+			if ($allow_logic_query_params) {
2869 2869
 				return;
2870
-			}else{
2870
+			} else {
2871 2871
 				throw new EE_Error(
2872 2872
 					sprintf(
2873
-						__( 'Logic query params ("%1$s") are being used incorrectly with the following query param ("%2$s") on model %3$s. %4$sAdditional Info:%4$s%5$s', 'event_espresso' ),
2874
-						implode( '", "', $this->_logic_query_param_keys ),
2875
-						$query_param ,
2876
-						get_class( $this ),
2873
+						__('Logic query params ("%1$s") are being used incorrectly with the following query param ("%2$s") on model %3$s. %4$sAdditional Info:%4$s%5$s', 'event_espresso'),
2874
+						implode('", "', $this->_logic_query_param_keys),
2875
+						$query_param,
2876
+						get_class($this),
2877 2877
 						'<br />',
2878
-						"\t" . ' $passed_in_query_info = <pre>' . print_r( $passed_in_query_info, TRUE ) . '</pre>' . "\n\t" . ' $query_param_type = ' . $query_param_type . "\n\t" . ' $original_query_param = ' . $original_query_param
2878
+						"\t".' $passed_in_query_info = <pre>'.print_r($passed_in_query_info, TRUE).'</pre>'."\n\t".' $query_param_type = '.$query_param_type."\n\t".' $original_query_param = '.$original_query_param
2879 2879
 					)
2880 2880
 				);
2881 2881
 			}
2882 2882
 		}
2883 2883
 
2884 2884
 		//check if it's a custom selection
2885
-		elseif(array_key_exists($query_param,$this->_custom_selections)){
2885
+		elseif (array_key_exists($query_param, $this->_custom_selections)) {
2886 2886
 			return;
2887 2887
 		}
2888 2888
 
2889 2889
 		//check if has a model name at the beginning
2890 2890
 		//and
2891 2891
 		//check if it's a field on a related model
2892
-		foreach($this->_model_relations as $valid_related_model_name=>$relation_obj){
2893
-			if(strpos($query_param, $valid_related_model_name.".") === 0){
2894
-				$this->_add_join_to_model($valid_related_model_name, $passed_in_query_info,$original_query_param);
2892
+		foreach ($this->_model_relations as $valid_related_model_name=>$relation_obj) {
2893
+			if (strpos($query_param, $valid_related_model_name.".") === 0) {
2894
+				$this->_add_join_to_model($valid_related_model_name, $passed_in_query_info, $original_query_param);
2895 2895
 				$query_param = substr($query_param, strlen($valid_related_model_name."."));
2896
-				if($query_param == ''){
2896
+				if ($query_param == '') {
2897 2897
 					//nothing left to $query_param
2898 2898
 					//we should actually end in a field name, not a model like this!
2899 2899
 					throw new EE_Error(sprintf(__("Query param '%s' (of type %s on model %s) shouldn't end on a period (.) ", "event_espresso"),
2900
-					$query_param,$query_param_type,get_class($this),$valid_related_model_name));
2901
-				}else{
2900
+					$query_param, $query_param_type, get_class($this), $valid_related_model_name));
2901
+				} else {
2902 2902
 					$related_model_obj = $this->get_related_model_obj($valid_related_model_name);
2903 2903
 					$related_model_obj->_extract_related_model_info_from_query_param($query_param, $passed_in_query_info, $query_param_type, $original_query_param);
2904 2904
 					return;
2905 2905
 				}
2906
-			}elseif($query_param == $valid_related_model_name){
2907
-				$this->_add_join_to_model($valid_related_model_name, $passed_in_query_info,$original_query_param);
2906
+			}elseif ($query_param == $valid_related_model_name) {
2907
+				$this->_add_join_to_model($valid_related_model_name, $passed_in_query_info, $original_query_param);
2908 2908
 				return;
2909 2909
 			}
2910 2910
 		}
@@ -2914,7 +2914,7 @@  discard block
 block discarded – undo
2914 2914
 		//and we previously confirmed it wasn't a logic query param or field on the current model
2915 2915
 		//it's wack, that's what it is
2916 2916
 		throw new EE_Error(sprintf(__("There is no model named '%s' related to %s. Query param type is %s and original query param is %s", "event_espresso"),
2917
-				$query_param,get_class($this),$query_param_type,$original_query_param));
2917
+				$query_param, get_class($this), $query_param_type, $original_query_param));
2918 2918
 
2919 2919
 	}
2920 2920
 
@@ -2931,26 +2931,26 @@  discard block
 block discarded – undo
2931 2931
 	 * what models to prepend onto its default query params or in case it wants to rename tables (in case there are multiple joins to the same table)
2932 2932
 	 * @return void
2933 2933
 	 */
2934
-	private function _add_join_to_model($model_name, EE_Model_Query_Info_Carrier $passed_in_query_info,$original_query_param){
2934
+	private function _add_join_to_model($model_name, EE_Model_Query_Info_Carrier $passed_in_query_info, $original_query_param) {
2935 2935
 		$relation_obj = $this->related_settings_for($model_name);
2936 2936
 
2937 2937
 		$model_relation_chain = EE_Model_Parser::extract_model_relation_chain($model_name, $original_query_param);
2938 2938
 		//check if the relation is HABTM, because then we're essentially doing two joins
2939 2939
 		//If so, join first to the JOIN table, and add its data types, and then continue as normal
2940
-		if($relation_obj instanceof EE_HABTM_Relation){
2940
+		if ($relation_obj instanceof EE_HABTM_Relation) {
2941 2941
 			$join_model_obj = $relation_obj->get_join_model();
2942 2942
 			//replace the model specified with the join model for this relation chain, whi
2943 2943
 			$relation_chain_to_join_model = EE_Model_Parser::replace_model_name_with_join_model_name_in_model_relation_chain($model_name, $join_model_obj->get_this_model_name(), $model_relation_chain);
2944 2944
 			$new_query_info = new EE_Model_Query_Info_Carrier(
2945 2945
 					array($relation_chain_to_join_model => $join_model_obj->get_this_model_name()),
2946 2946
 					$relation_obj->get_join_to_intermediate_model_statement($relation_chain_to_join_model));
2947
-			$passed_in_query_info->merge( $new_query_info  );
2947
+			$passed_in_query_info->merge($new_query_info);
2948 2948
 		}
2949 2949
 		//now just join to the other table pointed to by the relation object, and add its data types
2950 2950
 		$new_query_info = new EE_Model_Query_Info_Carrier(
2951 2951
 				array($model_relation_chain=>$model_name),
2952 2952
 				$relation_obj->get_join_statement($model_relation_chain));
2953
-		$passed_in_query_info->merge( $new_query_info  );
2953
+		$passed_in_query_info->merge($new_query_info);
2954 2954
 	}
2955 2955
 
2956 2956
 
@@ -2959,11 +2959,11 @@  discard block
 block discarded – undo
2959 2959
 	 * @param array $where_params like EEM_Base::get_all
2960 2960
 	 * @return string of SQL
2961 2961
 	 */
2962
-	private function _construct_where_clause($where_params){
2962
+	private function _construct_where_clause($where_params) {
2963 2963
 		$SQL = $this->_construct_condition_clause_recursive($where_params, ' AND ');
2964
-		if($SQL){
2965
-			return " WHERE ". $SQL;
2966
-		}else{
2964
+		if ($SQL) {
2965
+			return " WHERE ".$SQL;
2966
+		} else {
2967 2967
 			return '';
2968 2968
 		}
2969 2969
 	}
@@ -2974,11 +2974,11 @@  discard block
 block discarded – undo
2974 2974
 	 * @param array $having_params
2975 2975
 	 * @return string
2976 2976
 	 */
2977
-	private function _construct_having_clause($having_params){
2977
+	private function _construct_having_clause($having_params) {
2978 2978
 		$SQL = $this->_construct_condition_clause_recursive($having_params, ' AND ');
2979
-		if($SQL){
2980
-			return " HAVING ". $SQL;
2981
-		}else{
2979
+		if ($SQL) {
2980
+			return " HAVING ".$SQL;
2981
+		} else {
2982 2982
 			return '';
2983 2983
 		}
2984 2984
 
@@ -2992,17 +2992,17 @@  discard block
 block discarded – undo
2992 2992
 	 * @return EE_Model_Field_Base
2993 2993
 	 * @throws EE_Error
2994 2994
 	 */
2995
-	protected function _get_field_on_model($field_name,$model_name){
2995
+	protected function _get_field_on_model($field_name, $model_name) {
2996 2996
 		$model_class = 'EEM_'.$model_name;
2997 2997
 		$model_filepath = $model_class.".model.php";
2998
-		EE_Registry::instance()->load_helper( 'File' );
2999
-		if ( is_readable($model_filepath)){
2998
+		EE_Registry::instance()->load_helper('File');
2999
+		if (is_readable($model_filepath)) {
3000 3000
 			require_once($model_filepath);
3001
-			$model_instance=call_user_func($model_name."::instance");
3001
+			$model_instance = call_user_func($model_name."::instance");
3002 3002
 			/* @var $model_instance EEM_Base */
3003 3003
 			return $model_instance->field_settings_for($field_name);
3004
-		}else{
3005
-			throw new EE_Error(sprintf(__('No model named %s exists, with classname %s and filepath %s','event_espresso'),$model_name,$model_class,$model_filepath));
3004
+		} else {
3005
+			throw new EE_Error(sprintf(__('No model named %s exists, with classname %s and filepath %s', 'event_espresso'), $model_name, $model_class, $model_filepath));
3006 3006
 		}
3007 3007
 	}
3008 3008
 
@@ -3015,43 +3015,43 @@  discard block
 block discarded – undo
3015 3015
 	 * @throws EE_Error
3016 3016
 	 * @return string of SQL
3017 3017
 	 */
3018
-	private function _construct_condition_clause_recursive($where_params, $glue = ' AND'){
3019
-		$where_clauses=array();
3020
-		foreach($where_params as $query_param => $op_and_value_or_sub_condition){
3021
-			$query_param = $this->_remove_stars_and_anything_after_from_condition_query_param_key($query_param);//str_replace("*",'',$query_param);
3022
-			if(in_array($query_param,$this->_logic_query_param_keys)){
3023
-				switch($query_param){
3018
+	private function _construct_condition_clause_recursive($where_params, $glue = ' AND') {
3019
+		$where_clauses = array();
3020
+		foreach ($where_params as $query_param => $op_and_value_or_sub_condition) {
3021
+			$query_param = $this->_remove_stars_and_anything_after_from_condition_query_param_key($query_param); //str_replace("*",'',$query_param);
3022
+			if (in_array($query_param, $this->_logic_query_param_keys)) {
3023
+				switch ($query_param) {
3024 3024
 					case 'not':
3025 3025
 					case 'NOT':
3026
-						$where_clauses[] = "! (". $this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, $glue).")";
3026
+						$where_clauses[] = "! (".$this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, $glue).")";
3027 3027
 						break;
3028 3028
 					case 'and':
3029 3029
 					case 'AND':
3030
-						$where_clauses[] = " (". $this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, ' AND ') .")";
3030
+						$where_clauses[] = " (".$this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, ' AND ').")";
3031 3031
 						break;
3032 3032
 					case 'or':
3033 3033
 					case 'OR':
3034
-						$where_clauses[] = " (". $this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, ' OR ') .")";
3034
+						$where_clauses[] = " (".$this->_construct_condition_clause_recursive($op_and_value_or_sub_condition, ' OR ').")";
3035 3035
 						break;
3036 3036
 				}
3037
-			}else{
3037
+			} else {
3038 3038
 				$field_obj = $this->_deduce_field_from_query_param($query_param);
3039 3039
 
3040 3040
 				//if it's not a normal field, maybe it's a custom selection?
3041
-				if( ! $field_obj){
3042
-					if(isset( $this->_custom_selections[$query_param][1])){
3041
+				if ( ! $field_obj) {
3042
+					if (isset($this->_custom_selections[$query_param][1])) {
3043 3043
 						$field_obj = $this->_custom_selections[$query_param][1];
3044
-					}else{
3045
-						throw new EE_Error(sprintf(__("%s is neither a valid model field name, nor a custom selection", "event_espresso"),$query_param));
3044
+					} else {
3045
+						throw new EE_Error(sprintf(__("%s is neither a valid model field name, nor a custom selection", "event_espresso"), $query_param));
3046 3046
 					}
3047 3047
 				}
3048 3048
 				$op_and_value_sql = $this->_construct_op_and_value($op_and_value_or_sub_condition, $field_obj);
3049
-				$where_clauses[]=$this->_deduce_column_name_from_query_param($query_param).SP.$op_and_value_sql;
3049
+				$where_clauses[] = $this->_deduce_column_name_from_query_param($query_param).SP.$op_and_value_sql;
3050 3050
 			}
3051 3051
 		}
3052
-		if($where_clauses){
3053
-			$SQL = implode($glue,$where_clauses);
3054
-		}else{
3052
+		if ($where_clauses) {
3053
+			$SQL = implode($glue, $where_clauses);
3054
+		} else {
3055 3055
 			$SQL = '';
3056 3056
 		}
3057 3057
 		return $SQL;
@@ -3065,18 +3065,18 @@  discard block
 block discarded – undo
3065 3065
 	 * @throws EE_Error
3066 3066
 	 * @return string table alias and column name for SQL, eg "Transaction.TXN_ID"
3067 3067
 	 */
3068
-	private function _deduce_column_name_from_query_param($query_param){
3068
+	private function _deduce_column_name_from_query_param($query_param) {
3069 3069
 		$field = $this->_deduce_field_from_query_param($query_param);
3070 3070
 
3071
-		if( $field ){
3072
-			$table_alias_prefix = EE_Model_Parser::extract_table_alias_model_relation_chain_from_query_param( $field->get_model_name(), $query_param );
3073
-			return $table_alias_prefix . $field->get_qualified_column();
3074
-		}elseif(array_key_exists($query_param,$this->_custom_selections)){
3071
+		if ($field) {
3072
+			$table_alias_prefix = EE_Model_Parser::extract_table_alias_model_relation_chain_from_query_param($field->get_model_name(), $query_param);
3073
+			return $table_alias_prefix.$field->get_qualified_column();
3074
+		}elseif (array_key_exists($query_param, $this->_custom_selections)) {
3075 3075
 			//maybe it's custom selection item?
3076 3076
 			//if so, just use it as the "column name"
3077 3077
 			return $query_param;
3078
-		}else{
3079
-			throw new EE_Error(sprintf(__("%s is not a valid field on this model, nor a custom selection (%s)", "event_espresso"),$query_param,implode(",",$this->_custom_selections)));
3078
+		} else {
3079
+			throw new EE_Error(sprintf(__("%s is not a valid field on this model, nor a custom selection (%s)", "event_espresso"), $query_param, implode(",", $this->_custom_selections)));
3080 3080
 		}
3081 3081
 	}
3082 3082
 
@@ -3088,11 +3088,11 @@  discard block
 block discarded – undo
3088 3088
 	 * @param string $condition_query_param_key
3089 3089
 	 * @return string
3090 3090
 	 */
3091
-	private function _remove_stars_and_anything_after_from_condition_query_param_key($condition_query_param_key){
3091
+	private function _remove_stars_and_anything_after_from_condition_query_param_key($condition_query_param_key) {
3092 3092
 		$pos_of_star = strpos($condition_query_param_key, '*');
3093
-		if($pos_of_star === FALSE){
3093
+		if ($pos_of_star === FALSE) {
3094 3094
 			return $condition_query_param_key;
3095
-		}else{
3095
+		} else {
3096 3096
 			$condition_query_param_sans_star = substr($condition_query_param_key, 0, $pos_of_star);
3097 3097
 			return $condition_query_param_sans_star;
3098 3098
 		}
@@ -3107,54 +3107,54 @@  discard block
 block discarded – undo
3107 3107
 	 * @throws EE_Error
3108 3108
 	 * @return string
3109 3109
 	 */
3110
-	private function _construct_op_and_value($op_and_value, $field_obj){
3111
-		if(is_array( $op_and_value )){
3110
+	private function _construct_op_and_value($op_and_value, $field_obj) {
3111
+		if (is_array($op_and_value)) {
3112 3112
 			$operator = isset($op_and_value[0]) ? $this->_prepare_operator_for_sql($op_and_value[0]) : null;
3113
-			if( ! $operator){
3113
+			if ( ! $operator) {
3114 3114
 				$php_array_like_string = array();
3115
-				foreach($op_and_value as $key => $value){
3115
+				foreach ($op_and_value as $key => $value) {
3116 3116
 					$php_array_like_string[] = "$key=>$value";
3117 3117
 				}
3118
-				throw new EE_Error(sprintf(__("You setup a query parameter like you were going to specify an operator, but didn't. You provided '(%s)', but the operator should be at array key index 0 (eg array('>',32))", "event_espresso"), implode(",",$php_array_like_string)));
3118
+				throw new EE_Error(sprintf(__("You setup a query parameter like you were going to specify an operator, but didn't. You provided '(%s)', but the operator should be at array key index 0 (eg array('>',32))", "event_espresso"), implode(",", $php_array_like_string)));
3119 3119
 			}
3120 3120
 			$value = isset($op_and_value[1]) ? $op_and_value[1] : null;
3121
-		}else{
3121
+		} else {
3122 3122
 			$operator = '=';
3123 3123
 			$value = $op_and_value;
3124 3124
 		}
3125 3125
 
3126 3126
 		//check to see if the value is actually another field
3127
-		if(is_array($op_and_value) && isset($op_and_value[2]) && $op_and_value[2] == true){
3127
+		if (is_array($op_and_value) && isset($op_and_value[2]) && $op_and_value[2] == true) {
3128 3128
 			return $operator.SP.$this->_deduce_column_name_from_query_param($value);
3129
-		}elseif(in_array($operator, $this->_in_style_operators) && is_array($value)){
3129
+		}elseif (in_array($operator, $this->_in_style_operators) && is_array($value)) {
3130 3130
 			//in this case, the value should be an array, or at least a comma-separated list
3131 3131
 			//it will need to handle a little differently
3132 3132
 			$cleaned_value = $this->_construct_in_value($value, $field_obj);
3133 3133
 			//note: $cleaned_value has already been run through $wpdb->prepare()
3134 3134
 			return $operator.SP.$cleaned_value;
3135
-		} elseif( in_array( $operator, $this->_between_style_operators ) && is_array( $value ) ) {
3135
+		} elseif (in_array($operator, $this->_between_style_operators) && is_array($value)) {
3136 3136
 			//the value should be an array with count of two.
3137
-			if ( count($value) !== 2 )
3138
-				throw new EE_Error( sprintf( __("The '%s' operator must be used with an array of values and there must be exactly TWO values in that array.", 'event_espresso'), "BETWEEN" ) );
3139
-			$cleaned_value = $this->_construct_between_value( $value, $field_obj );
3137
+			if (count($value) !== 2)
3138
+				throw new EE_Error(sprintf(__("The '%s' operator must be used with an array of values and there must be exactly TWO values in that array.", 'event_espresso'), "BETWEEN"));
3139
+			$cleaned_value = $this->_construct_between_value($value, $field_obj);
3140 3140
 			return $operator.SP.$cleaned_value;
3141
-		} elseif( in_array( $operator, $this->_null_style_operators ) ) {
3142
-			if($value != NULL){
3143
-				throw new EE_Error(sprintf(__("You attempted to give a value  (%s) while using a NULL-style operator (%s). That isn't valid", "event_espresso"),$value,$operator));
3141
+		} elseif (in_array($operator, $this->_null_style_operators)) {
3142
+			if ($value != NULL) {
3143
+				throw new EE_Error(sprintf(__("You attempted to give a value  (%s) while using a NULL-style operator (%s). That isn't valid", "event_espresso"), $value, $operator));
3144 3144
 			}
3145 3145
 			return $operator;
3146
-		}elseif( $operator == 'LIKE' && ! is_array($value)){
3146
+		}elseif ($operator == 'LIKE' && ! is_array($value)) {
3147 3147
 			//if the operator is 'LIKE', we want to allow percent signs (%) and not
3148 3148
 			//remove other junk. So just treat it as a string.
3149 3149
 			return $operator.SP.$this->_wpdb_prepare_using_field($value, '%s');
3150
-		}elseif( ! in_array($operator, $this->_in_style_operators) && ! is_array($value)){
3151
-			return $operator.SP.$this->_wpdb_prepare_using_field($value,$field_obj);
3152
-		}elseif(in_array($operator, $this->_in_style_operators) && ! is_array($value)){
3153
-			throw new EE_Error(sprintf(__("Operator '%s' must be used with an array of values, eg 'Registration.REG_ID' => array('%s',array(1,2,3))",'event_espresso'),$operator, $operator));
3154
-		}elseif( ! in_array($operator, $this->_in_style_operators) && is_array($value)){
3155
-			throw new EE_Error(sprintf(__("Operator '%s' must be used with a single value, not an array. Eg 'Registration.REG_ID => array('%s',23))",'event_espresso'),$operator,$operator));
3156
-		}else{
3157
-			throw new EE_Error(sprintf(__("It appears you've provided some totally invalid query parameters. Operator and value were:'%s', which isn't right at all", "event_espresso"),  http_build_query($op_and_value)));
3150
+		}elseif ( ! in_array($operator, $this->_in_style_operators) && ! is_array($value)) {
3151
+			return $operator.SP.$this->_wpdb_prepare_using_field($value, $field_obj);
3152
+		}elseif (in_array($operator, $this->_in_style_operators) && ! is_array($value)) {
3153
+			throw new EE_Error(sprintf(__("Operator '%s' must be used with an array of values, eg 'Registration.REG_ID' => array('%s',array(1,2,3))", 'event_espresso'), $operator, $operator));
3154
+		}elseif ( ! in_array($operator, $this->_in_style_operators) && is_array($value)) {
3155
+			throw new EE_Error(sprintf(__("Operator '%s' must be used with a single value, not an array. Eg 'Registration.REG_ID => array('%s',23))", 'event_espresso'), $operator, $operator));
3156
+		} else {
3157
+			throw new EE_Error(sprintf(__("It appears you've provided some totally invalid query parameters. Operator and value were:'%s', which isn't right at all", "event_espresso"), http_build_query($op_and_value)));
3158 3158
 		}
3159 3159
 	}
3160 3160
 
@@ -3166,12 +3166,12 @@  discard block
 block discarded – undo
3166 3166
 	 * @param EE_Model_Field_Base|string $field_obj if string, it should be the datatype to be used when querying, eg '%s'
3167 3167
 	 * @return string
3168 3168
 	 */
3169
-	function _construct_between_value( $values, $field_obj ) {
3169
+	function _construct_between_value($values, $field_obj) {
3170 3170
 		$cleaned_values = array();
3171
-		foreach ( $values as $value ) {
3172
-			$cleaned_values[] = $this->_wpdb_prepare_using_field($value,$field_obj);
3171
+		foreach ($values as $value) {
3172
+			$cleaned_values[] = $this->_wpdb_prepare_using_field($value, $field_obj);
3173 3173
 		}
3174
-		return  $cleaned_values[0] . " AND " . $cleaned_values[1];
3174
+		return  $cleaned_values[0]." AND ".$cleaned_values[1];
3175 3175
 	}
3176 3176
 
3177 3177
 
@@ -3187,26 +3187,26 @@  discard block
 block discarded – undo
3187 3187
 	 * @param EE_Model_Field_Base|string $field_obj if string, it should be a wpdb data type like '%s', or '%d'
3188 3188
 	 * @return string of SQL to follow an 'IN' or 'NOT IN' operator
3189 3189
 	 */
3190
-	function _construct_in_value($values,  $field_obj){
3190
+	function _construct_in_value($values, $field_obj) {
3191 3191
 		//check if the value is a CSV list
3192
-		if(is_string($values)){
3192
+		if (is_string($values)) {
3193 3193
 			//in which case, turn it into an array
3194
-			$values = explode(",",$values);
3194
+			$values = explode(",", $values);
3195 3195
 		}
3196 3196
 		$cleaned_values = array();
3197
-		foreach($values as $value){
3198
-			$cleaned_values[] = $this->_wpdb_prepare_using_field($value,$field_obj);
3197
+		foreach ($values as $value) {
3198
+			$cleaned_values[] = $this->_wpdb_prepare_using_field($value, $field_obj);
3199 3199
 		}
3200 3200
 		//we would just LOVE to leave $cleaned_values as an empty array, and return the value as "()",
3201 3201
 		//but unfortunately that's invalid SQL. So instead we return a string which we KNOW will evaluate to be the empty set
3202 3202
 		//which is effectively equivalent to returning "()". We don't return "(0)" because that only works for auto-incrementing columns
3203
-		if(empty($cleaned_values)){
3203
+		if (empty($cleaned_values)) {
3204 3204
 			$all_fields = $this->field_settings();
3205 3205
 			$a_field = array_shift($all_fields);
3206 3206
 			$main_table = $this->_get_main_table();
3207 3207
 			$cleaned_values[] = "SELECT ".$a_field->get_table_column()." FROM ".$main_table->get_table_name()." WHERE FALSE";
3208 3208
 		}
3209
-		return "(".implode(",",$cleaned_values).")";
3209
+		return "(".implode(",", $cleaned_values).")";
3210 3210
 	}
3211 3211
 
3212 3212
 
@@ -3218,16 +3218,16 @@  discard block
 block discarded – undo
3218 3218
 	 * @throws EE_Error
3219 3219
 	 * @return false|null|string
3220 3220
 	 */
3221
-	private function _wpdb_prepare_using_field($value,$field_obj){
3221
+	private function _wpdb_prepare_using_field($value, $field_obj) {
3222 3222
 		/** @type WPDB $wpdb */
3223 3223
 		global $wpdb;
3224
-		if($field_obj instanceof EE_Model_Field_Base){
3225
-			return $wpdb->prepare($field_obj->get_wpdb_data_type(),$this->_prepare_value_for_use_in_db($value, $field_obj));
3226
-		}else{//$field_obj should really just be a data type
3227
-			if( ! in_array($field_obj,$this->_valid_wpdb_data_types)){
3228
-				throw new EE_Error(sprintf(__("%s is not a valid wpdb datatype. Valid ones are %s", "event_espresso"),$field_obj,implode(",",$this->_valid_wpdb_data_types)));
3224
+		if ($field_obj instanceof EE_Model_Field_Base) {
3225
+			return $wpdb->prepare($field_obj->get_wpdb_data_type(), $this->_prepare_value_for_use_in_db($value, $field_obj));
3226
+		} else {//$field_obj should really just be a data type
3227
+			if ( ! in_array($field_obj, $this->_valid_wpdb_data_types)) {
3228
+				throw new EE_Error(sprintf(__("%s is not a valid wpdb datatype. Valid ones are %s", "event_espresso"), $field_obj, implode(",", $this->_valid_wpdb_data_types)));
3229 3229
 			}
3230
-			return $wpdb->prepare($field_obj,$value);
3230
+			return $wpdb->prepare($field_obj, $value);
3231 3231
 		}
3232 3232
 	}
3233 3233
 
@@ -3239,27 +3239,27 @@  discard block
 block discarded – undo
3239 3239
 	 * @throws EE_Error
3240 3240
 	 * @return EE_Model_Field_Base
3241 3241
 	 */
3242
-	protected function _deduce_field_from_query_param($query_param_name){
3242
+	protected function _deduce_field_from_query_param($query_param_name) {
3243 3243
 		//ok, now proceed with deducing which part is the model's name, and which is the field's name
3244 3244
 		//which will help us find the database table and column
3245 3245
 
3246
-		$query_param_parts = explode(".",$query_param_name);
3247
-		if(empty($query_param_parts)){
3248
-			throw new EE_Error(sprintf(__("_extract_column_name is empty when trying to extract column and table name from %s",'event_espresso'),$query_param_name));
3246
+		$query_param_parts = explode(".", $query_param_name);
3247
+		if (empty($query_param_parts)) {
3248
+			throw new EE_Error(sprintf(__("_extract_column_name is empty when trying to extract column and table name from %s", 'event_espresso'), $query_param_name));
3249 3249
 		}
3250 3250
 		$number_of_parts = count($query_param_parts);
3251
-		$last_query_param_part = $query_param_parts[ count($query_param_parts) - 1 ];
3252
-		if($number_of_parts == 1){
3251
+		$last_query_param_part = $query_param_parts[count($query_param_parts) - 1];
3252
+		if ($number_of_parts == 1) {
3253 3253
 			$field_name = $last_query_param_part;
3254 3254
 			$model_obj = $this;
3255
-		}else{// $number_of_parts >= 2
3255
+		} else {// $number_of_parts >= 2
3256 3256
 			//the last part is the column name, and there are only 2parts. therefore...
3257 3257
 			$field_name = $last_query_param_part;
3258
-			$model_obj = $this->get_related_model_obj( $query_param_parts[ $number_of_parts - 2 ]);
3258
+			$model_obj = $this->get_related_model_obj($query_param_parts[$number_of_parts - 2]);
3259 3259
 		}
3260
-		try{
3260
+		try {
3261 3261
 			return $model_obj->field_settings_for($field_name);
3262
-		}catch(EE_Error $e){
3262
+		} catch (EE_Error $e) {
3263 3263
 			return null;
3264 3264
 		}
3265 3265
 	}
@@ -3273,13 +3273,13 @@  discard block
 block discarded – undo
3273 3273
 	 * @throws EE_Error
3274 3274
 	 * @return string
3275 3275
 	 */
3276
-	function _get_qualified_column_for_field($field_name){
3276
+	function _get_qualified_column_for_field($field_name) {
3277 3277
 		$all_fields = $this->field_settings();
3278 3278
 		$field = isset($all_fields[$field_name]) ? $all_fields[$field_name] : FALSE;
3279
-		if($field){
3279
+		if ($field) {
3280 3280
 			return $field->get_qualified_column();
3281
-		}else{
3282
-			throw new EE_Error(sprintf(__("There is no field titled %s on model %s. Either the query trying to use it is bad, or you need to add it to the list of fields on the model.",'event_espresso'),$field_name,get_class($this)));
3281
+		} else {
3282
+			throw new EE_Error(sprintf(__("There is no field titled %s on model %s. Either the query trying to use it is bad, or you need to add it to the list of fields on the model.", 'event_espresso'), $field_name, get_class($this)));
3283 3283
 		}
3284 3284
 	}
3285 3285
 
@@ -3293,14 +3293,14 @@  discard block
 block discarded – undo
3293 3293
 	 * @param  mixed|string $limit The limit for this select
3294 3294
 	 * @return string 				The final select join element for the query.
3295 3295
 	 */
3296
-	function _construct_limit_join_select( $table_alias, $limit ) {
3296
+	function _construct_limit_join_select($table_alias, $limit) {
3297 3297
 		$SQL = '';
3298 3298
 
3299
-		foreach ( $this->_tables as $table_obj ) {
3300
-			if ( $table_obj instanceof EE_Primary_Table ) {
3301
-				$SQL .= $table_alias == $table_obj->get_table_alias() ? $table_obj->get_select_join_limit( $limit ) : SP.$table_obj->get_table_name()." AS ".$table_obj->get_table_alias().SP;
3302
-			} elseif ( $table_obj instanceof EE_Secondary_Table ) {
3303
-				$SQL .= $table_alias == $table_obj->get_table_alias() ? $table_obj->get_select_join_limit_join($limit) : SP . $table_obj->get_join_sql( $table_alias ).SP;
3299
+		foreach ($this->_tables as $table_obj) {
3300
+			if ($table_obj instanceof EE_Primary_Table) {
3301
+				$SQL .= $table_alias == $table_obj->get_table_alias() ? $table_obj->get_select_join_limit($limit) : SP.$table_obj->get_table_name()." AS ".$table_obj->get_table_alias().SP;
3302
+			} elseif ($table_obj instanceof EE_Secondary_Table) {
3303
+				$SQL .= $table_alias == $table_obj->get_table_alias() ? $table_obj->get_select_join_limit_join($limit) : SP.$table_obj->get_join_sql($table_alias).SP;
3304 3304
 			}
3305 3305
 		}
3306 3306
 		return $SQL;
@@ -3313,7 +3313,7 @@  discard block
 block discarded – undo
3313 3313
 	 * Eg "wp_post AS Event" or "wp_post AS Event INNER JOIN wp_postmeta Event_Meta ON Event.ID = Event_Meta.post_id"
3314 3314
 	 * @return string SQL
3315 3315
 	 */
3316
-	function _construct_internal_join(){
3316
+	function _construct_internal_join() {
3317 3317
 		$SQL = $this->_get_main_table()->get_table_sql();
3318 3318
 		$SQL .= $this->_construct_internal_join_to_table_with_alias($this->_get_main_table()->get_table_alias());
3319 3319
 		return $SQL;
@@ -3334,17 +3334,17 @@  discard block
 block discarded – undo
3334 3334
 	 * @param string $alias_prefixed table alias to join to (this table should already be in the FROM SQL clause)
3335 3335
 	 * @return string
3336 3336
 	 */
3337
-	function _construct_internal_join_to_table_with_alias($alias_prefixed){
3337
+	function _construct_internal_join_to_table_with_alias($alias_prefixed) {
3338 3338
 		$SQL = '';
3339 3339
 		$alias_sans_prefix = EE_Model_Parser::remove_table_alias_model_relation_chain_prefix($alias_prefixed);
3340
-		foreach($this->_tables as $table_obj){
3341
-			if($table_obj instanceof EE_Secondary_Table){//table is secondary table
3342
-				if($alias_sans_prefix == $table_obj->get_table_alias()){
3340
+		foreach ($this->_tables as $table_obj) {
3341
+			if ($table_obj instanceof EE_Secondary_Table) {//table is secondary table
3342
+				if ($alias_sans_prefix == $table_obj->get_table_alias()) {
3343 3343
 					//so we're joining to this table, meaning the table is already in
3344 3344
 					//the FROM statement, BUT the primary table isn't. So we want
3345 3345
 					//to add the inverse join sql
3346 3346
 					$SQL .= $table_obj->get_inverse_join_sql($alias_prefixed);
3347
-				}else{
3347
+				} else {
3348 3348
 					//just add a regular JOIN to this table from the primary table
3349 3349
 					$SQL .= $table_obj->get_join_sql($alias_prefixed);
3350 3350
 				}
@@ -3358,9 +3358,9 @@  discard block
 block discarded – undo
3358 3358
 	 * This should be a growing array of keys being table-columns (eg 'EVT_ID' and 'Event.EVT_ID'), and values being their data type (eg, '%s', '%d', etc)
3359 3359
 	 * @return array
3360 3360
 	 */
3361
-	function _get_data_types(){
3361
+	function _get_data_types() {
3362 3362
 		$data_types = array();
3363
-		foreach(array_values($this->field_settings()) as $field_obj){
3363
+		foreach (array_values($this->field_settings()) as $field_obj) {
3364 3364
 			//$data_types[$field_obj->get_table_column()] = $field_obj->get_wpdb_data_type();
3365 3365
 			/** @var $field_obj EE_Model_Field_Base */
3366 3366
 			$data_types[$field_obj->get_qualified_column()] = $field_obj->get_wpdb_data_type();
@@ -3376,11 +3376,11 @@  discard block
 block discarded – undo
3376 3376
 	 * @throws EE_Error
3377 3377
 	 * @return EEM_Base
3378 3378
 	 */
3379
-	function get_related_model_obj($model_name){
3379
+	function get_related_model_obj($model_name) {
3380 3380
 
3381 3381
 		$model_classname = "EEM_".$model_name;
3382
-		if(!class_exists($model_classname)){
3383
-			throw new EE_Error(sprintf(__("You specified a related model named %s in your query. No such model exists, if it did, it would have the classname %s",'event_espresso'),$model_name,$model_classname));
3382
+		if ( ! class_exists($model_classname)) {
3383
+			throw new EE_Error(sprintf(__("You specified a related model named %s in your query. No such model exists, if it did, it would have the classname %s", 'event_espresso'), $model_name, $model_classname));
3384 3384
 		}
3385 3385
 		$model_obj = call_user_func($model_classname."::instance");
3386 3386
 		return $model_obj;
@@ -3391,7 +3391,7 @@  discard block
 block discarded – undo
3391 3391
 	 * Returns the array of EE_ModelRelations for this model.
3392 3392
 	 * @return EE_Model_Relation_Base[]
3393 3393
 	 */
3394
-	public function relation_settings(){
3394
+	public function relation_settings() {
3395 3395
 		return $this->_model_relations;
3396 3396
 	}
3397 3397
 
@@ -3401,10 +3401,10 @@  discard block
 block discarded – undo
3401 3401
 	 * (Eg, without an event, datetimes have little purpose.)
3402 3402
 	 * @return EE_Belongs_To_Relation[]
3403 3403
 	 */
3404
-	public function belongs_to_relations(){
3404
+	public function belongs_to_relations() {
3405 3405
 		$belongs_to_relations = array();
3406
-		foreach($this->relation_settings() as $model_name => $relation_obj){
3407
-			if($relation_obj instanceof EE_Belongs_To_Relation){
3406
+		foreach ($this->relation_settings() as $model_name => $relation_obj) {
3407
+			if ($relation_obj instanceof EE_Belongs_To_Relation) {
3408 3408
 				$belongs_to_relations[$model_name] = $relation_obj;
3409 3409
 			}
3410 3410
 		}
@@ -3419,15 +3419,15 @@  discard block
 block discarded – undo
3419 3419
 	 * @throws EE_Error
3420 3420
 	 * @return EE_Model_Relation_Base
3421 3421
 	 */
3422
-	public function related_settings_for($relation_name){
3423
-		$relatedModels=$this->relation_settings();
3424
-		if(!array_key_exists($relation_name,$relatedModels)){
3422
+	public function related_settings_for($relation_name) {
3423
+		$relatedModels = $this->relation_settings();
3424
+		if ( ! array_key_exists($relation_name, $relatedModels)) {
3425 3425
 			throw new EE_Error(
3426 3426
 				sprintf(
3427
-					__('Cannot get %s related to %s. There is no model relation of that type. There is, however, %s...','event_espresso'),
3427
+					__('Cannot get %s related to %s. There is no model relation of that type. There is, however, %s...', 'event_espresso'),
3428 3428
 					$relation_name,
3429 3429
 					$this->_get_class_name(),
3430
-					implode( ', ', array_keys( $relatedModels ))
3430
+					implode(', ', array_keys($relatedModels))
3431 3431
 				)
3432 3432
 			);
3433 3433
 		}
@@ -3442,10 +3442,10 @@  discard block
 block discarded – undo
3442 3442
 	 * @throws EE_Error
3443 3443
 	 * @return EE_Model_Field_Base
3444 3444
 	 */
3445
-	public function field_settings_for($fieldName){
3446
-		$fieldSettings=$this->field_settings(true);
3447
-		if( ! array_key_exists($fieldName,$fieldSettings)){
3448
-			throw new EE_Error(sprintf(__("There is no field/column '%s' on '%s'",'event_espresso'),$fieldName,get_class($this)));
3445
+	public function field_settings_for($fieldName) {
3446
+		$fieldSettings = $this->field_settings(true);
3447
+		if ( ! array_key_exists($fieldName, $fieldSettings)) {
3448
+			throw new EE_Error(sprintf(__("There is no field/column '%s' on '%s'", 'event_espresso'), $fieldName, get_class($this)));
3449 3449
 		}
3450 3450
 		return $fieldSettings[$fieldName];
3451 3451
 	}
@@ -3455,11 +3455,11 @@  discard block
 block discarded – undo
3455 3455
 	 * @param string $fieldName a key in the model's _field_settings array
3456 3456
 	 * @return boolean
3457 3457
 	 */
3458
-	public function has_field($fieldName){
3458
+	public function has_field($fieldName) {
3459 3459
 		$fieldSettings = $this->field_settings(true);
3460
-		if( isset($fieldSettings[$fieldName])){
3460
+		if (isset($fieldSettings[$fieldName])) {
3461 3461
 			return true;
3462
-		}else{
3462
+		} else {
3463 3463
 			return false;
3464 3464
 		}
3465 3465
 	}
@@ -3469,11 +3469,11 @@  discard block
 block discarded – undo
3469 3469
 	 * @param string $relation_name possibly one of the keys in the relation_settings array
3470 3470
 	 * @return boolean
3471 3471
 	 */
3472
-	public function has_relation($relation_name){
3472
+	public function has_relation($relation_name) {
3473 3473
 		$relations = $this->relation_settings();
3474
-		if(isset($relations[$relation_name])){
3474
+		if (isset($relations[$relation_name])) {
3475 3475
 			return true;
3476
-		}else{
3476
+		} else {
3477 3477
 			return false;
3478 3478
 		}
3479 3479
 	}
@@ -3485,7 +3485,7 @@  discard block
 block discarded – undo
3485 3485
 	 * @param $field_obj
3486 3486
 	 * @return EE_Model_Field_Base
3487 3487
 	 */
3488
-	public function is_primary_key_field( $field_obj ){
3488
+	public function is_primary_key_field($field_obj) {
3489 3489
 		return $field_obj instanceof EE_Primary_Key_Field_Base ? TRUE : FALSE;
3490 3490
 	}
3491 3491
 
@@ -3497,16 +3497,16 @@  discard block
 block discarded – undo
3497 3497
 	 * @return EE_Model_Field_Base
3498 3498
 	 * @throws EE_Error
3499 3499
 	 */
3500
-	public function get_primary_key_field(){
3501
-		if( $this->_primary_key_field === NULL ){
3502
-			foreach( $this->field_settings( TRUE ) as $field_obj ){
3503
-				if( $this->is_primary_key_field( $field_obj )){
3500
+	public function get_primary_key_field() {
3501
+		if ($this->_primary_key_field === NULL) {
3502
+			foreach ($this->field_settings(TRUE) as $field_obj) {
3503
+				if ($this->is_primary_key_field($field_obj)) {
3504 3504
 					$this->_primary_key_field = $field_obj;
3505 3505
 					break;
3506 3506
 				}
3507 3507
 			}
3508
-			if( ! $this->_primary_key_field instanceof EE_Primary_Key_Field_Base ){
3509
-				throw new EE_Error(sprintf(__("There is no Primary Key defined on model %s",'event_espresso'),get_class($this)));
3508
+			if ( ! $this->_primary_key_field instanceof EE_Primary_Key_Field_Base) {
3509
+				throw new EE_Error(sprintf(__("There is no Primary Key defined on model %s", 'event_espresso'), get_class($this)));
3510 3510
 			}
3511 3511
 		}
3512 3512
 		return $this->_primary_key_field;
@@ -3519,12 +3519,12 @@  discard block
 block discarded – undo
3519 3519
 	 * Internally does some caching.
3520 3520
 	 * @return boolean
3521 3521
 	 */
3522
-	public function has_primary_key_field(){
3523
-		if($this->_has_primary_key_field === null){
3524
-			try{
3522
+	public function has_primary_key_field() {
3523
+		if ($this->_has_primary_key_field === null) {
3524
+			try {
3525 3525
 				$this->get_primary_key_field();
3526 3526
 				$this->_has_primary_key_field = true;
3527
-			}catch(EE_Error $e){
3527
+			} catch (EE_Error $e) {
3528 3528
 				$this->_has_primary_key_field = false;
3529 3529
 			}
3530 3530
 		}
@@ -3538,9 +3538,9 @@  discard block
 block discarded – undo
3538 3538
 	 * @param string $field_class_name class name of field that you want to find. Eg, EE_Datetime_Field, EE_Foreign_Key_Field, etc
3539 3539
 	 * @return EE_Model_Field_Base or null if none is found
3540 3540
 	 */
3541
-	public function get_a_field_of_type($field_class_name){
3542
-		foreach($this->field_settings() as $field){
3543
-			if( $field instanceof $field_class_name ){
3541
+	public function get_a_field_of_type($field_class_name) {
3542
+		foreach ($this->field_settings() as $field) {
3543
+			if ($field instanceof $field_class_name) {
3544 3544
 				return $field;
3545 3545
 			}
3546 3546
 		}
@@ -3554,21 +3554,21 @@  discard block
 block discarded – undo
3554 3554
 	 * @return EE_Foreign_Key_Field_Base
3555 3555
 	 * @throws EE_Error
3556 3556
 	 */
3557
-	public function get_foreign_key_to($model_name){
3558
-		if( ! isset( $this->_cache_foreign_key_to_fields[ $model_name ] ) ){
3559
-			foreach($this->field_settings() as $field){
3557
+	public function get_foreign_key_to($model_name) {
3558
+		if ( ! isset($this->_cache_foreign_key_to_fields[$model_name])) {
3559
+			foreach ($this->field_settings() as $field) {
3560 3560
 //				if(is_subclass_of($field, 'EE_Foreign_Key_Field_Base')){
3561
-				if( $field instanceof EE_Foreign_Key_Field_Base ){
3562
-					if (in_array($model_name,$field->get_model_names_pointed_to() ) ) {
3563
-						$this->_cache_foreign_key_to_fields[ $model_name ] = $field;
3561
+				if ($field instanceof EE_Foreign_Key_Field_Base) {
3562
+					if (in_array($model_name, $field->get_model_names_pointed_to())) {
3563
+						$this->_cache_foreign_key_to_fields[$model_name] = $field;
3564 3564
 					}
3565 3565
 				}
3566 3566
 			}
3567
-			if( ! isset( $this->_cache_foreign_key_to_fields[ $model_name ] ) ){
3568
-				throw new EE_Error(sprintf(__("There is no foreign key field pointing to model %s on model %s",'event_espresso'),$model_name,get_class($this)));
3567
+			if ( ! isset($this->_cache_foreign_key_to_fields[$model_name])) {
3568
+				throw new EE_Error(sprintf(__("There is no foreign key field pointing to model %s on model %s", 'event_espresso'), $model_name, get_class($this)));
3569 3569
 			}
3570 3570
 		}
3571
-		return $this->_cache_foreign_key_to_fields[ $model_name ];
3571
+		return $this->_cache_foreign_key_to_fields[$model_name];
3572 3572
 	}
3573 3573
 
3574 3574
 
@@ -3579,7 +3579,7 @@  discard block
 block discarded – undo
3579 3579
 	 * a table alias with a model chain prefix, like 'Venue__Event_Venue___Event_Meta'. Either one works
3580 3580
 	 * @return EE_Table_Base
3581 3581
 	 */
3582
-	function get_table_for_alias($table_alias){
3582
+	function get_table_for_alias($table_alias) {
3583 3583
 		$table_alias_sans_model_relation_chain_prefix = EE_Model_Parser::remove_table_alias_model_relation_chain_prefix($table_alias);
3584 3584
 		return $this->_tables[$table_alias_sans_model_relation_chain_prefix]->get_table_name();
3585 3585
 	}
@@ -3592,25 +3592,25 @@  discard block
 block discarded – undo
3592 3592
 	 * @param bool $include_db_only_fields flag indicating whether or not to include the db-only fields
3593 3593
 	 * @return EE_Model_Field_Base[] where the keys are the field's name
3594 3594
 	 */
3595
-	public function field_settings($include_db_only_fields = false){
3596
-		if( $include_db_only_fields ){
3597
-			if( $this->_cached_fields === NULL ){
3595
+	public function field_settings($include_db_only_fields = false) {
3596
+		if ($include_db_only_fields) {
3597
+			if ($this->_cached_fields === NULL) {
3598 3598
 				$this->_cached_fields = array();
3599
-				foreach($this->_fields as $fields_corresponding_to_table){
3600
-					foreach($fields_corresponding_to_table as $field_name => $field_obj){
3601
-						$this->_cached_fields[$field_name]=$field_obj;
3599
+				foreach ($this->_fields as $fields_corresponding_to_table) {
3600
+					foreach ($fields_corresponding_to_table as $field_name => $field_obj) {
3601
+						$this->_cached_fields[$field_name] = $field_obj;
3602 3602
 					}
3603 3603
 				}
3604 3604
 			}
3605 3605
 			return $this->_cached_fields;
3606
-		}else{
3607
-			if( $this->_cached_fields_non_db_only === NULL ){
3606
+		} else {
3607
+			if ($this->_cached_fields_non_db_only === NULL) {
3608 3608
 				$this->_cached_fields_non_db_only = array();
3609
-				foreach($this->_fields as $fields_corresponding_to_table){
3610
-					foreach($fields_corresponding_to_table as $field_name => $field_obj){
3609
+				foreach ($this->_fields as $fields_corresponding_to_table) {
3610
+					foreach ($fields_corresponding_to_table as $field_name => $field_obj) {
3611 3611
 						/** @var $field_obj EE_Model_Field_Base */
3612
-						if( ! $field_obj->is_db_only_field() ){
3613
-							$this->_cached_fields_non_db_only[$field_name]=$field_obj;
3612
+						if ( ! $field_obj->is_db_only_field()) {
3613
+							$this->_cached_fields_non_db_only[$field_name] = $field_obj;
3614 3614
 						}
3615 3615
 					}
3616 3616
 				}
@@ -3629,67 +3629,67 @@  discard block
 block discarded – undo
3629 3629
 	 * @return \EE_Base_Class[] array keys are primary keys (if there is a primary key on the model. if not, numerically indexed)
3630 3630
 	 * @throws \EE_Error
3631 3631
 	 */
3632
-	protected function _create_objects( $rows = array() ) {
3633
-		$array_of_objects=array();
3634
-		if(empty($rows)){
3632
+	protected function _create_objects($rows = array()) {
3633
+		$array_of_objects = array();
3634
+		if (empty($rows)) {
3635 3635
 			return array();
3636 3636
 		}
3637 3637
 		$count_if_model_has_no_primary_key = 0;
3638 3638
 		$has_primary_key = $this->has_primary_key_field();
3639
-		if( $has_primary_key ) {
3639
+		if ($has_primary_key) {
3640 3640
 			$primary_key_field = $this->get_primary_key_field();
3641 3641
 		} else {
3642 3642
 			$primary_key_field = null;
3643 3643
 		}
3644
-		foreach ( $rows as $row ) {
3645
-			if(empty($row)){
3644
+		foreach ($rows as $row) {
3645
+			if (empty($row)) {
3646 3646
 				//wp did its weird thing where it returns an array like array(0=>null), which is totally not helpful...
3647 3647
 				return array();
3648 3648
 			}
3649 3649
 			//check if we've already set this object in the results array,
3650 3650
 			//in which case there's no need to process it further (again)
3651
-			if( $has_primary_key ) {
3651
+			if ($has_primary_key) {
3652 3652
 				$table_pk_value = $this->_get_column_value_with_table_alias_or_not(
3653 3653
 					$row,
3654 3654
 					$primary_key_field->get_qualified_column(),
3655 3655
 					$primary_key_field->get_table_column()
3656 3656
 				);
3657
-				if( $table_pk_value &&
3658
-					isset( $array_of_objects[ $table_pk_value ] ) ) {
3657
+				if ($table_pk_value &&
3658
+					isset($array_of_objects[$table_pk_value])) {
3659 3659
 					continue;
3660 3660
 				}
3661 3661
 			}
3662
-			$classInstance=$this->instantiate_class_from_array_or_object($row);
3663
-			if( ! $classInstance ) {
3662
+			$classInstance = $this->instantiate_class_from_array_or_object($row);
3663
+			if ( ! $classInstance) {
3664 3664
 				throw new EE_Error(
3665 3665
 					sprintf(
3666
-						__( 'Could not create instance of class %s from row %s', 'event_espresso' ),
3666
+						__('Could not create instance of class %s from row %s', 'event_espresso'),
3667 3667
 						$this->get_this_model_name(),
3668
-						http_build_query( $row )
3668
+						http_build_query($row)
3669 3669
 					)
3670 3670
 				);
3671 3671
 			}
3672 3672
 			//set the timezone on the instantiated objects
3673
-			$classInstance->set_timezone( $this->_timezone );
3673
+			$classInstance->set_timezone($this->_timezone);
3674 3674
 			//make sure if there is any timezone setting present that we set the timezone for the object
3675 3675
 			$key = $has_primary_key ? $classInstance->ID() : $count_if_model_has_no_primary_key++;
3676
-			$array_of_objects[ $key ] = $classInstance;
3676
+			$array_of_objects[$key] = $classInstance;
3677 3677
 			//also, for all the relations of type BelongsTo, see if we can cache
3678 3678
 			//those related models
3679 3679
 			//(we could do this for other relations too, but if there are conditions
3680 3680
 			//that filtered out some fo the results, then we'd be caching an incomplete set
3681 3681
 			//so it requires a little more thought than just caching them immediately...)
3682
-			foreach($this->_model_relations as $modelName => $relation_obj){
3683
-				if( $relation_obj instanceof EE_Belongs_To_Relation){
3682
+			foreach ($this->_model_relations as $modelName => $relation_obj) {
3683
+				if ($relation_obj instanceof EE_Belongs_To_Relation) {
3684 3684
 					//check if this model's INFO is present. If so, cache it on the model
3685 3685
 					$other_model = $relation_obj->get_other_model();
3686 3686
 
3687 3687
 					$other_model_obj_maybe = $other_model->instantiate_class_from_array_or_object($row);
3688 3688
 
3689 3689
 					//if we managed to make a model object from the results, cache it on the main model object
3690
-					if( $other_model_obj_maybe ){
3690
+					if ($other_model_obj_maybe) {
3691 3691
 						//set timezone on these other model objects if they are present
3692
-						$other_model_obj_maybe->set_timezone( $this->_timezone );
3692
+						$other_model_obj_maybe->set_timezone($this->_timezone);
3693 3693
 						$classInstance->cache($modelName, $other_model_obj_maybe);
3694 3694
 					}
3695 3695
 				}
@@ -3710,12 +3710,12 @@  discard block
 block discarded – undo
3710 3710
 
3711 3711
 		$this_model_fields_and_values = array();
3712 3712
 		//setup the row using default values;
3713
-		foreach ( $this->field_settings() as $field_name => $field_obj ) {
3713
+		foreach ($this->field_settings() as $field_name => $field_obj) {
3714 3714
 			$this_model_fields_and_values[$field_name] = $field_obj->get_default_value();
3715 3715
 		}
3716 3716
 
3717 3717
 		$className = $this->_get_class_name();
3718
-		$classInstance = EE_Registry::instance()->load_class( $className, array( $this_model_fields_and_values ), FALSE, FALSE );
3718
+		$classInstance = EE_Registry::instance()->load_class($className, array($this_model_fields_and_values), FALSE, FALSE);
3719 3719
 
3720 3720
 		return $classInstance;
3721 3721
 	}
@@ -3728,45 +3728,45 @@  discard block
 block discarded – undo
3728 3728
 	 * or an stdClass where each property is the name of a column,
3729 3729
 	 * @return EE_Base_Class
3730 3730
 	 */
3731
-	public function instantiate_class_from_array_or_object($cols_n_values){
3732
-		if( ! is_array( $cols_n_values ) && is_object( $cols_n_values )) {
3733
-			$cols_n_values = get_object_vars( $cols_n_values );
3731
+	public function instantiate_class_from_array_or_object($cols_n_values) {
3732
+		if ( ! is_array($cols_n_values) && is_object($cols_n_values)) {
3733
+			$cols_n_values = get_object_vars($cols_n_values);
3734 3734
 		}
3735 3735
 		$primary_key = NULL;
3736 3736
 		//make sure the array only has keys that are fields/columns on this model
3737
-		$this_model_fields_n_values = $this->_deduce_fields_n_values_from_cols_n_values( $cols_n_values );
3738
-		if( $this->has_primary_key_field() && isset( $this_model_fields_n_values[ $this->primary_key_name() ] ) ){
3739
-			$primary_key = $this_model_fields_n_values[ $this->primary_key_name() ];
3737
+		$this_model_fields_n_values = $this->_deduce_fields_n_values_from_cols_n_values($cols_n_values);
3738
+		if ($this->has_primary_key_field() && isset($this_model_fields_n_values[$this->primary_key_name()])) {
3739
+			$primary_key = $this_model_fields_n_values[$this->primary_key_name()];
3740 3740
 		}
3741
-		$className=$this->_get_class_name();
3741
+		$className = $this->_get_class_name();
3742 3742
 
3743 3743
 		//check we actually found results that we can use to build our model object
3744 3744
 		//if not, return null
3745
-		if( $this->has_primary_key_field()){
3746
-			if(empty( $this_model_fields_n_values[$this->primary_key_name()] )){
3745
+		if ($this->has_primary_key_field()) {
3746
+			if (empty($this_model_fields_n_values[$this->primary_key_name()])) {
3747 3747
 				return NULL;
3748 3748
 			}
3749
-		}else if($this->unique_indexes()){
3749
+		} else if ($this->unique_indexes()) {
3750 3750
 			$first_column = reset($this_model_fields_n_values);
3751
-			if(empty($first_column)){
3751
+			if (empty($first_column)) {
3752 3752
 				return NULL;
3753 3753
 			}
3754 3754
 		}
3755 3755
 
3756 3756
 		// if there is no primary key or the object doesn't already exist in the entity map, then create a new instance
3757
-		if ( $primary_key){
3758
-			$classInstance = $this->get_from_entity_map( $primary_key );
3759
-			if( ! $classInstance) {
3760
-				$classInstance = EE_Registry::instance()->load_class( $className, array( $this_model_fields_n_values, $this->_timezone ), TRUE, FALSE );
3757
+		if ($primary_key) {
3758
+			$classInstance = $this->get_from_entity_map($primary_key);
3759
+			if ( ! $classInstance) {
3760
+				$classInstance = EE_Registry::instance()->load_class($className, array($this_model_fields_n_values, $this->_timezone), TRUE, FALSE);
3761 3761
 				// add this new object to the entity map
3762
-				$classInstance = $this->add_to_entity_map( $classInstance );
3762
+				$classInstance = $this->add_to_entity_map($classInstance);
3763 3763
 			}
3764
-		}else{
3765
-			$classInstance = EE_Registry::instance()->load_class( $className, array( $this_model_fields_n_values, $this->_timezone ), TRUE, FALSE );
3764
+		} else {
3765
+			$classInstance = EE_Registry::instance()->load_class($className, array($this_model_fields_n_values, $this->_timezone), TRUE, FALSE);
3766 3766
 		}
3767 3767
 
3768 3768
 			//it is entirely possible that the instantiated class object has a set timezone_string db field and has set it's internal _timezone property accordingly (see new_instance_from_db in model objects particularly EE_Event for example).  In this case, we want to make sure the model object doesn't have its timezone string overwritten by any timezone property currently set here on the model so, we intentionally override the model _timezone property with the model_object timezone property.
3769
-		$this->set_timezone( $classInstance->get_timezone() );
3769
+		$this->set_timezone($classInstance->get_timezone());
3770 3770
 		return $classInstance;
3771 3771
 	}
3772 3772
 	/**
@@ -3774,8 +3774,8 @@  discard block
 block discarded – undo
3774 3774
 	 * @param int|string $id the ID of the model object
3775 3775
 	 * @return EE_Base_Class
3776 3776
 	 */
3777
-	public function get_from_entity_map( $id ){
3778
-		return isset( $this->_entity_map[ $id ] ) ? $this->_entity_map[ $id ] : NULL;
3777
+	public function get_from_entity_map($id) {
3778
+		return isset($this->_entity_map[$id]) ? $this->_entity_map[$id] : NULL;
3779 3779
 	}
3780 3780
 
3781 3781
 
@@ -3794,21 +3794,21 @@  discard block
 block discarded – undo
3794 3794
 	 * @throws EE_Error
3795 3795
 	 * @return \EE_Base_Class
3796 3796
 	 */
3797
-	public function add_to_entity_map( EE_Base_Class $object) {
3797
+	public function add_to_entity_map(EE_Base_Class $object) {
3798 3798
 		$className = $this->_get_class_name();
3799
-		if( ! $object instanceof $className ){
3800
-			throw new EE_Error(sprintf(__("You tried adding a %s to a mapping of %ss", "event_espresso"),is_object( $object ) ? get_class( $object ) : $object, $className ) );
3799
+		if ( ! $object instanceof $className) {
3800
+			throw new EE_Error(sprintf(__("You tried adding a %s to a mapping of %ss", "event_espresso"), is_object($object) ? get_class($object) : $object, $className));
3801 3801
 		}
3802 3802
 		/** @var $object EE_Base_Class */
3803
-		if ( ! $object->ID() ){
3804
-			throw new EE_Error(sprintf(__("You tried storing a model object with NO ID in the %s entity mapper.", "event_espresso"),get_class($this)));
3803
+		if ( ! $object->ID()) {
3804
+			throw new EE_Error(sprintf(__("You tried storing a model object with NO ID in the %s entity mapper.", "event_espresso"), get_class($this)));
3805 3805
 		}
3806 3806
 		// double check it's not already there
3807
-		$classInstance = $this->get_from_entity_map( $object->ID() );
3808
-		if ( $classInstance ) {
3807
+		$classInstance = $this->get_from_entity_map($object->ID());
3808
+		if ($classInstance) {
3809 3809
 			return $classInstance;
3810 3810
 		} else {
3811
-			$this->_entity_map[ $object->ID() ] = $object;
3811
+			$this->_entity_map[$object->ID()] = $object;
3812 3812
 			return $object;
3813 3813
 		}
3814 3814
 	}
@@ -3821,8 +3821,8 @@  discard block
 block discarded – undo
3821 3821
 	 * @param array $cols_n_values
3822 3822
 	 * @return array
3823 3823
 	 */
3824
-	public function deduce_fields_n_values_from_cols_n_values( $cols_n_values ) {
3825
-		return $this->_deduce_fields_n_values_from_cols_n_values( $cols_n_values );
3824
+	public function deduce_fields_n_values_from_cols_n_values($cols_n_values) {
3825
+		return $this->_deduce_fields_n_values_from_cols_n_values($cols_n_values);
3826 3826
 	}
3827 3827
 
3828 3828
 
@@ -3835,40 +3835,40 @@  discard block
 block discarded – undo
3835 3835
 	 * @param string $cols_n_values
3836 3836
 	 * @return array
3837 3837
 	 */
3838
-	protected function _deduce_fields_n_values_from_cols_n_values( $cols_n_values ){
3838
+	protected function _deduce_fields_n_values_from_cols_n_values($cols_n_values) {
3839 3839
 		$this_model_fields_n_values = array();
3840
-		foreach( $this->get_tables() as $table_alias => $table_obj ) {
3841
-			$table_pk_value = $this->_get_column_value_with_table_alias_or_not($cols_n_values, $table_obj->get_fully_qualified_pk_column(), $table_obj->get_pk_column() );
3840
+		foreach ($this->get_tables() as $table_alias => $table_obj) {
3841
+			$table_pk_value = $this->_get_column_value_with_table_alias_or_not($cols_n_values, $table_obj->get_fully_qualified_pk_column(), $table_obj->get_pk_column());
3842 3842
 			//there is a primary key on this table and its not set. Use defaults for all its columns
3843
-			if( $table_obj->get_pk_column() && $table_pk_value === NULL ){
3844
-				foreach( $this->_get_fields_for_table( $table_alias ) as $field_name => $field_obj ) {
3845
-					if( ! $field_obj->is_db_only_field() ){
3843
+			if ($table_obj->get_pk_column() && $table_pk_value === NULL) {
3844
+				foreach ($this->_get_fields_for_table($table_alias) as $field_name => $field_obj) {
3845
+					if ( ! $field_obj->is_db_only_field()) {
3846 3846
 						//prepare field as if its coming from db
3847
-						$prepared_value = $field_obj->prepare_for_set( $field_obj->get_default_value() );
3848
-						$this_model_fields_n_values[$field_name] = $field_obj->prepare_for_use_in_db( $prepared_value );
3847
+						$prepared_value = $field_obj->prepare_for_set($field_obj->get_default_value());
3848
+						$this_model_fields_n_values[$field_name] = $field_obj->prepare_for_use_in_db($prepared_value);
3849 3849
 					}
3850 3850
 				}
3851
-			}else{
3851
+			} else {
3852 3852
 				//the table's rows existed. Use their values
3853
-				foreach( $this->_get_fields_for_table( $table_alias ) as $field_name => $field_obj ) {
3854
-					if( ! $field_obj->is_db_only_field() )
3855
-					$this_model_fields_n_values[$field_name] = $this->_get_column_value_with_table_alias_or_not($cols_n_values, $field_obj->get_qualified_column(), $field_obj->get_table_column() );
3853
+				foreach ($this->_get_fields_for_table($table_alias) as $field_name => $field_obj) {
3854
+					if ( ! $field_obj->is_db_only_field())
3855
+					$this_model_fields_n_values[$field_name] = $this->_get_column_value_with_table_alias_or_not($cols_n_values, $field_obj->get_qualified_column(), $field_obj->get_table_column());
3856 3856
 				}
3857 3857
 			}
3858 3858
 		}
3859 3859
 		return $this_model_fields_n_values;
3860 3860
 	}
3861 3861
 
3862
-	protected function _get_column_value_with_table_alias_or_not( $cols_n_values, $qualified_column, $regular_column ){
3862
+	protected function _get_column_value_with_table_alias_or_not($cols_n_values, $qualified_column, $regular_column) {
3863 3863
 		//ask the field what it think it's table_name.column_name should be, and call it the "qualified column"
3864 3864
 		//does the field on the model relate to this column retrieved from the db?
3865 3865
 		//or is it a db-only field? (not relating to the model)
3866
-		if( isset( $cols_n_values[ $qualified_column ] ) ){
3867
-			$value = $cols_n_values[ $qualified_column ];
3866
+		if (isset($cols_n_values[$qualified_column])) {
3867
+			$value = $cols_n_values[$qualified_column];
3868 3868
 
3869
-		}elseif( isset( $cols_n_values[ $regular_column ] ) ){
3870
-			$value = $cols_n_values[ $regular_column ];
3871
-		}else{
3869
+		}elseif (isset($cols_n_values[$regular_column])) {
3870
+			$value = $cols_n_values[$regular_column];
3871
+		} else {
3872 3872
 			$value = NULL;
3873 3873
 		}
3874 3874
 
@@ -3886,23 +3886,23 @@  discard block
 block discarded – undo
3886 3886
 	 * @param int|string $id
3887 3887
 	 * @return EE_Base_Class
3888 3888
 	 */
3889
-	public function refresh_entity_map_from_db( $id ){
3890
-		$obj_in_map = $this->get_from_entity_map( $id );
3891
-		if( $obj_in_map ){
3892
-			$wpdb_results = $this->_get_all_wpdb_results( array( array ( $this->get_primary_key_field()->get_name() => $id ), 'limit' => 1 ) );
3893
-			if( $wpdb_results && is_array( $wpdb_results ) ){
3894
-				$one_row = reset( $wpdb_results );
3895
-				foreach( $this->_deduce_fields_n_values_from_cols_n_values($one_row ) as $field_name => $db_value ) {
3896
-					$obj_in_map->set_from_db( $field_name, $db_value );
3889
+	public function refresh_entity_map_from_db($id) {
3890
+		$obj_in_map = $this->get_from_entity_map($id);
3891
+		if ($obj_in_map) {
3892
+			$wpdb_results = $this->_get_all_wpdb_results(array(array($this->get_primary_key_field()->get_name() => $id), 'limit' => 1));
3893
+			if ($wpdb_results && is_array($wpdb_results)) {
3894
+				$one_row = reset($wpdb_results);
3895
+				foreach ($this->_deduce_fields_n_values_from_cols_n_values($one_row) as $field_name => $db_value) {
3896
+					$obj_in_map->set_from_db($field_name, $db_value);
3897 3897
 				}
3898 3898
 				//clear the cache of related model objects
3899
-				foreach ( $this->relation_settings() as $relation_name => $relation_obj ){
3900
-					$obj_in_map->clear_cache($relation_name, NULL, TRUE );
3899
+				foreach ($this->relation_settings() as $relation_name => $relation_obj) {
3900
+					$obj_in_map->clear_cache($relation_name, NULL, TRUE);
3901 3901
 				}
3902 3902
 			}
3903 3903
 			return $obj_in_map;
3904
-		}else{
3905
-			return $this->get_one_by_ID( $id );
3904
+		} else {
3905
+			return $this->get_one_by_ID($id);
3906 3906
 		}
3907 3907
 	}
3908 3908
 
@@ -3920,24 +3920,24 @@  discard block
 block discarded – undo
3920 3920
 	 * @param EE_Base_Class $replacing_model_obj
3921 3921
 	 * @return \EE_Base_Class
3922 3922
 	 */
3923
-	public function refresh_entity_map_with( $id, $replacing_model_obj ) {
3924
-		$obj_in_map = $this->get_from_entity_map( $id );
3925
-		if( $obj_in_map ){
3926
-			if( $replacing_model_obj instanceof EE_Base_Class ){
3927
-				foreach( $replacing_model_obj->model_field_array() as $field_name => $value ) {
3928
-					$obj_in_map->set( $field_name, $value );
3923
+	public function refresh_entity_map_with($id, $replacing_model_obj) {
3924
+		$obj_in_map = $this->get_from_entity_map($id);
3925
+		if ($obj_in_map) {
3926
+			if ($replacing_model_obj instanceof EE_Base_Class) {
3927
+				foreach ($replacing_model_obj->model_field_array() as $field_name => $value) {
3928
+					$obj_in_map->set($field_name, $value);
3929 3929
 				}
3930 3930
 				//make the model object in the entity map's cache match the $replacing_model_obj
3931
-				foreach ( $this->relation_settings() as $relation_name => $relation_obj ){
3932
-					$obj_in_map->clear_cache($relation_name, NULL, TRUE );
3933
-					foreach( $replacing_model_obj->get_all_from_cache( $relation_name ) as $cache_id => $cached_obj ) {
3934
-						$obj_in_map->cache( $relation_name, $cached_obj, $cache_id );
3931
+				foreach ($this->relation_settings() as $relation_name => $relation_obj) {
3932
+					$obj_in_map->clear_cache($relation_name, NULL, TRUE);
3933
+					foreach ($replacing_model_obj->get_all_from_cache($relation_name) as $cache_id => $cached_obj) {
3934
+						$obj_in_map->cache($relation_name, $cached_obj, $cache_id);
3935 3935
 					}
3936 3936
 				}
3937 3937
 			}
3938 3938
 			return $obj_in_map;
3939
-		}else{
3940
-			$this->add_to_entity_map( $replacing_model_obj );
3939
+		} else {
3940
+			$this->add_to_entity_map($replacing_model_obj);
3941 3941
 			return $replacing_model_obj;
3942 3942
 		}
3943 3943
 	}
@@ -3950,7 +3950,7 @@  discard block
 block discarded – undo
3950 3950
 	 * require_once($this->_getClassName().".class.php");
3951 3951
 	 * @return string
3952 3952
 	 */
3953
-	private function _get_class_name(){
3953
+	private function _get_class_name() {
3954 3954
 		return "EE_".$this->get_this_model_name();
3955 3955
 	}
3956 3956
 
@@ -3963,10 +3963,10 @@  discard block
 block discarded – undo
3963 3963
 	 * @param int $quantity
3964 3964
 	 * @return string
3965 3965
 	 */
3966
-	public function item_name($quantity = 1){
3967
-		if($quantity == 1){
3966
+	public function item_name($quantity = 1) {
3967
+		if ($quantity == 1) {
3968 3968
 			return $this->singular_item;
3969
-		}else{
3969
+		} else {
3970 3970
 			return $this->plural_item;
3971 3971
 		}
3972 3972
 	}
@@ -3995,13 +3995,13 @@  discard block
 block discarded – undo
3995 3995
 	 * @throws EE_Error
3996 3996
 	 * @return mixed whatever the plugin which calls add_filter decides
3997 3997
 	 */
3998
-	public function __call($methodName,$args){
3999
-		$className=get_class($this);
4000
-		$tagName="FHEE__{$className}__{$methodName}";
4001
-		if(!has_filter($tagName)){
3998
+	public function __call($methodName, $args) {
3999
+		$className = get_class($this);
4000
+		$tagName = "FHEE__{$className}__{$methodName}";
4001
+		if ( ! has_filter($tagName)) {
4002 4002
 			throw new EE_Error(
4003 4003
 				sprintf(
4004
-					__( 'Method %1$s on model %2$s does not exist! You can create one with the following code in functions.php or in a plugin: %4$s function my_callback(%4$s \$previousReturnValue, EEM_Base \$object\ $argsArray=NULL ){%4$s     /*function body*/%4$s      return \$whatever;%4$s }%4$s add_filter( \'%3$s\', \'my_callback\', 10, 3 );', 'event_espresso' ),
4004
+					__('Method %1$s on model %2$s does not exist! You can create one with the following code in functions.php or in a plugin: %4$s function my_callback(%4$s \$previousReturnValue, EEM_Base \$object\ $argsArray=NULL ){%4$s     /*function body*/%4$s      return \$whatever;%4$s }%4$s add_filter( \'%3$s\', \'my_callback\', 10, 3 );', 'event_espresso'),
4005 4005
 					$methodName,
4006 4006
 					$className,
4007 4007
 					$tagName,
@@ -4010,7 +4010,7 @@  discard block
 block discarded – undo
4010 4010
 			);
4011 4011
 		}
4012 4012
 
4013
-		return apply_filters($tagName,null,$this,$args);
4013
+		return apply_filters($tagName, null, $this, $args);
4014 4014
 	}
4015 4015
 
4016 4016
 
@@ -4023,22 +4023,22 @@  discard block
 block discarded – undo
4023 4023
 	 * @throws EE_Error
4024 4024
 	 * @return EE_Base_Class
4025 4025
 	 */
4026
-	public function ensure_is_obj( $base_class_obj_or_id, $ensure_is_in_db = FALSE ){
4026
+	public function ensure_is_obj($base_class_obj_or_id, $ensure_is_in_db = FALSE) {
4027 4027
 		$className = $this->_get_class_name();
4028 4028
 		$primary_key_field = $this->get_primary_key_field();
4029
-		if( $base_class_obj_or_id instanceof $className ){
4029
+		if ($base_class_obj_or_id instanceof $className) {
4030 4030
 			$model_object = $base_class_obj_or_id;
4031
-		}elseif( $primary_key_field instanceof EE_Primary_Key_Int_Field && (
4032
-				is_int( $base_class_obj_or_id ) ||
4033
-				is_string( $base_class_obj_or_id ) )){//assume it's an ID. either a proper integer or a string representing an integer (eg "101" instead of 101)
4031
+		}elseif ($primary_key_field instanceof EE_Primary_Key_Int_Field && (
4032
+				is_int($base_class_obj_or_id) ||
4033
+				is_string($base_class_obj_or_id) )) {//assume it's an ID. either a proper integer or a string representing an integer (eg "101" instead of 101)
4034 4034
 			$model_object = $this->get_one_by_ID($base_class_obj_or_id);
4035
-		}elseif( $primary_key_field instanceof EE_Primary_Key_String_Field && is_string($base_class_obj_or_id) ){
4035
+		}elseif ($primary_key_field instanceof EE_Primary_Key_String_Field && is_string($base_class_obj_or_id)) {
4036 4036
 			//assume its a string representation of the object
4037 4037
 			$model_object = $this->get_one_by_ID($base_class_obj_or_id);
4038
-		}else{
4039
-			throw new EE_Error(sprintf(__("'%s' is neither an object of type %s, nor an ID! Its full value is '%s'",'event_espresso'),$base_class_obj_or_id,$this->_get_class_name(),print_r($base_class_obj_or_id,true)));
4038
+		} else {
4039
+			throw new EE_Error(sprintf(__("'%s' is neither an object of type %s, nor an ID! Its full value is '%s'", 'event_espresso'), $base_class_obj_or_id, $this->_get_class_name(), print_r($base_class_obj_or_id, true)));
4040 4040
 		}
4041
-		if( $model_object->ID() == NULL && $ensure_is_in_db){
4041
+		if ($model_object->ID() == NULL && $ensure_is_in_db) {
4042 4042
 			$model_object->save();
4043 4043
 		}
4044 4044
 		return $model_object;
@@ -4054,19 +4054,19 @@  discard block
 block discarded – undo
4054 4054
 	 * @return int|string depending on the type of this model object's ID
4055 4055
 	 * @throws EE_Error
4056 4056
 	 */
4057
-	public function ensure_is_ID($base_class_obj_or_id){
4057
+	public function ensure_is_ID($base_class_obj_or_id) {
4058 4058
 		$className = $this->_get_class_name();
4059
-		if( $base_class_obj_or_id instanceof $className ){
4059
+		if ($base_class_obj_or_id instanceof $className) {
4060 4060
 			/** @var $base_class_obj_or_id EE_Base_Class */
4061 4061
 			$id = $base_class_obj_or_id->ID();
4062
-		}elseif(is_int($base_class_obj_or_id)){
4062
+		}elseif (is_int($base_class_obj_or_id)) {
4063 4063
 			//assume it's an ID
4064 4064
 			$id = $base_class_obj_or_id;
4065
-		}elseif(is_string($base_class_obj_or_id)){
4065
+		}elseif (is_string($base_class_obj_or_id)) {
4066 4066
 			//assume its a string representation of the object
4067 4067
 			$id = $base_class_obj_or_id;
4068
-		}else{
4069
-			throw new EE_Error(sprintf(__("'%s' is neither an object of type %s, nor an ID! Its full value is '%s'",'event_espresso'),$base_class_obj_or_id,$this->_get_class_name(),print_r($base_class_obj_or_id,true)));
4068
+		} else {
4069
+			throw new EE_Error(sprintf(__("'%s' is neither an object of type %s, nor an ID! Its full value is '%s'", 'event_espresso'), $base_class_obj_or_id, $this->_get_class_name(), print_r($base_class_obj_or_id, true)));
4070 4070
 		}
4071 4071
 		return $id;
4072 4072
 	}
@@ -4089,14 +4089,14 @@  discard block
 block discarded – undo
4089 4089
 	 * @param int $values_already_prepared like one of the constants on EEM_Base
4090 4090
 	 * @return void
4091 4091
 	 */
4092
-	public function assume_values_already_prepared_by_model_object($values_already_prepared = self::not_prepared_by_model_object){
4092
+	public function assume_values_already_prepared_by_model_object($values_already_prepared = self::not_prepared_by_model_object) {
4093 4093
 		$this->_values_already_prepared_by_model_object = $values_already_prepared;
4094 4094
 	}
4095 4095
 	/**
4096 4096
 	 * Read comments for assume_values_already_prepared_by_model_object()
4097 4097
 	 * @return int
4098 4098
 	 */
4099
-	public function get_assumption_concerning_values_already_prepared_by_model_object(){
4099
+	public function get_assumption_concerning_values_already_prepared_by_model_object() {
4100 4100
 		return $this->_values_already_prepared_by_model_object;
4101 4101
 	}
4102 4102
 
@@ -4104,17 +4104,17 @@  discard block
 block discarded – undo
4104 4104
 	 * Gets all the indexes on this model
4105 4105
 	 * @return EE_Index[]
4106 4106
 	 */
4107
-	public function indexes(){
4107
+	public function indexes() {
4108 4108
 		return $this->_indexes;
4109 4109
 	}
4110 4110
 	/**
4111 4111
 	 * Gets all the Unique Indexes on this model
4112 4112
 	 * @return EE_Unique_Index[]
4113 4113
 	 */
4114
-	public function unique_indexes(){
4114
+	public function unique_indexes() {
4115 4115
 		$unique_indexes = array();
4116
-		foreach($this->_indexes as $name => $index){
4117
-			if($index instanceof EE_Unique_Index){
4116
+		foreach ($this->_indexes as $name => $index) {
4117
+			if ($index instanceof EE_Unique_Index) {
4118 4118
 				$unique_indexes [$name] = $index;
4119 4119
 			}
4120 4120
 		}
@@ -4127,9 +4127,9 @@  discard block
 block discarded – undo
4127 4127
 	 * on a primary index
4128 4128
 	 * @return EE_Model_Field_Base[]
4129 4129
 	 */
4130
-	public function get_combined_primary_key_fields(){
4131
-		foreach($this->indexes() as $index){
4132
-			if($index instanceof EE_Primary_Key_Index){
4130
+	public function get_combined_primary_key_fields() {
4131
+		foreach ($this->indexes() as $index) {
4132
+			if ($index instanceof EE_Primary_Key_Index) {
4133 4133
 				return $index->fields();
4134 4134
 			}
4135 4135
 		}
@@ -4142,7 +4142,7 @@  discard block
 block discarded – undo
4142 4142
 	 * @param array $cols_n_values keys are field names, values are their values
4143 4143
 	 * @return string
4144 4144
 	 */
4145
-	public function get_index_primary_key_string($cols_n_values){
4145
+	public function get_index_primary_key_string($cols_n_values) {
4146 4146
 		$cols_n_values_for_primary_key_index = array_intersect_key($cols_n_values, $this->get_combined_primary_key_fields());
4147 4147
 		return http_build_query($cols_n_values_for_primary_key_index);
4148 4148
 	}
@@ -4154,13 +4154,13 @@  discard block
 block discarded – undo
4154 4154
 	 * @param string $index_primary_key_string
4155 4155
 	 * @return null|array
4156 4156
 	 */
4157
-	function parse_index_primary_key_string( $index_primary_key_string) {
4157
+	function parse_index_primary_key_string($index_primary_key_string) {
4158 4158
 		$key_fields = $this->get_combined_primary_key_fields();
4159 4159
 		//check all of them are in the $id
4160 4160
 		$key_vals_in_combined_pk = array();
4161
-		parse_str( $index_primary_key_string, $key_vals_in_combined_pk );
4162
-		foreach( $key_fields as $key_field_name => $field_obj ) {
4163
-			if( ! isset( $key_vals_in_combined_pk[ $key_field_name ] ) ){
4161
+		parse_str($index_primary_key_string, $key_vals_in_combined_pk);
4162
+		foreach ($key_fields as $key_field_name => $field_obj) {
4163
+			if ( ! isset($key_vals_in_combined_pk[$key_field_name])) {
4164 4164
 				return NULL;
4165 4165
 			}
4166 4166
 		}
@@ -4173,10 +4173,10 @@  discard block
 block discarded – undo
4173 4173
 	 * @param array $key_vals
4174 4174
 	 * @return boolean
4175 4175
 	 */
4176
-	function has_all_combined_primary_key_fields( $key_vals ) {
4177
-		$keys_it_should_have = array_keys( $this->get_combined_primary_key_fields() );
4178
-		foreach( $keys_it_should_have as $key ){
4179
-			if( ! isset( $key_vals[ $key ] ) ){
4176
+	function has_all_combined_primary_key_fields($key_vals) {
4177
+		$keys_it_should_have = array_keys($this->get_combined_primary_key_fields());
4178
+		foreach ($keys_it_should_have as $key) {
4179
+			if ( ! isset($key_vals[$key])) {
4180 4180
 				return false;
4181 4181
 			}
4182 4182
 		}
@@ -4192,23 +4192,23 @@  discard block
 block discarded – undo
4192 4192
 	 * @throws EE_Error
4193 4193
 	 * @return \EE_Base_Class[] Array keys are object IDs (if there is a primary key on the model. if not, numerically indexed)
4194 4194
 	 */
4195
-	public function get_all_copies($model_object_or_attributes_array, $query_params = array()){
4195
+	public function get_all_copies($model_object_or_attributes_array, $query_params = array()) {
4196 4196
 
4197
-		if($model_object_or_attributes_array instanceof EE_Base_Class){
4197
+		if ($model_object_or_attributes_array instanceof EE_Base_Class) {
4198 4198
 			$attributes_array = $model_object_or_attributes_array->model_field_array();
4199
-		}elseif(is_array($model_object_or_attributes_array)){
4199
+		}elseif (is_array($model_object_or_attributes_array)) {
4200 4200
 			$attributes_array = $model_object_or_attributes_array;
4201
-		}else{
4202
-			throw new EE_Error(sprintf(__("get_all_copies should be provided with either a model object or an array of field-value-pairs, but was given %s", "event_espresso"),$model_object_or_attributes_array));
4201
+		} else {
4202
+			throw new EE_Error(sprintf(__("get_all_copies should be provided with either a model object or an array of field-value-pairs, but was given %s", "event_espresso"), $model_object_or_attributes_array));
4203 4203
 		}
4204 4204
 		//even copies obviously won't have the same ID, so remove the primary key
4205 4205
 		//from the WHERE conditions for finding copies (if there is a primary key, of course)
4206
-		if($this->has_primary_key_field() && isset($attributes_array[$this->primary_key_name()])){
4206
+		if ($this->has_primary_key_field() && isset($attributes_array[$this->primary_key_name()])) {
4207 4207
 			unset($attributes_array[$this->primary_key_name()]);
4208 4208
 		}
4209
-		if(isset($query_params[0])){
4210
-			$query_params[0] = array_merge($attributes_array,$query_params);
4211
-		}else{
4209
+		if (isset($query_params[0])) {
4210
+			$query_params[0] = array_merge($attributes_array, $query_params);
4211
+		} else {
4212 4212
 			$query_params[0] = $attributes_array;
4213 4213
 		}
4214 4214
 		return $this->get_all($query_params);
@@ -4222,16 +4222,16 @@  discard block
 block discarded – undo
4222 4222
 	 * @param array $query_params
4223 4223
 	 * @return EE_Base_Class
4224 4224
 	 */
4225
-	function get_one_copy($model_object_or_attributes_array,$query_params = array()){
4226
-		if( ! is_array( $query_params ) ){
4227
-			EE_Error::doing_it_wrong('EEM_Base::get_one_copy', sprintf( __( '$query_params should be an array, you passed a variable of type %s', 'event_espresso' ), gettype( $query_params ) ), '4.6.0' );
4225
+	function get_one_copy($model_object_or_attributes_array, $query_params = array()) {
4226
+		if ( ! is_array($query_params)) {
4227
+			EE_Error::doing_it_wrong('EEM_Base::get_one_copy', sprintf(__('$query_params should be an array, you passed a variable of type %s', 'event_espresso'), gettype($query_params)), '4.6.0');
4228 4228
 			$query_params = array();
4229 4229
 		}
4230 4230
 		$query_params['limit'] = 1;
4231
-		$copies = $this->get_all_copies($model_object_or_attributes_array,$query_params);
4232
-		if(is_array($copies)){
4231
+		$copies = $this->get_all_copies($model_object_or_attributes_array, $query_params);
4232
+		if (is_array($copies)) {
4233 4233
 			return array_shift($copies);
4234
-		}else{
4234
+		} else {
4235 4235
 			return null;
4236 4236
 		}
4237 4237
 	}
@@ -4245,10 +4245,10 @@  discard block
 block discarded – undo
4245 4245
 	 * @param int|string $id the value of the primary key to update
4246 4246
 	 * @return int number of rows updated
4247 4247
 	 */
4248
-	public function update_by_ID($fields_n_values,$id){
4248
+	public function update_by_ID($fields_n_values, $id) {
4249 4249
 		$query_params = array(0=>array($this->get_primary_key_field()->get_name() => $id),
4250 4250
 			'default_where_conditions'=>'other_models_only',);
4251
-		return $this->update($fields_n_values,$query_params);
4251
+		return $this->update($fields_n_values, $query_params);
4252 4252
 	}
4253 4253
 
4254 4254
 
@@ -4259,12 +4259,12 @@  discard block
 block discarded – undo
4259 4259
 	 * @return string an operator which can be used in SQL
4260 4260
 	 * @throws EE_Error
4261 4261
 	 */
4262
-	private function _prepare_operator_for_sql($operator_supplied){
4262
+	private function _prepare_operator_for_sql($operator_supplied) {
4263 4263
 		$sql_operator = isset($this->_valid_operators[$operator_supplied]) ? $this->_valid_operators[$operator_supplied] : null;
4264
-		if($sql_operator){
4264
+		if ($sql_operator) {
4265 4265
 			return $sql_operator;
4266
-		}else{
4267
-			throw new EE_Error(sprintf(__("The operator '%s' is not in the list of valid operators: %s", "event_espresso"),$operator_supplied,implode(",",array_keys($this->_valid_operators))));
4266
+		} else {
4267
+			throw new EE_Error(sprintf(__("The operator '%s' is not in the list of valid operators: %s", "event_espresso"), $operator_supplied, implode(",", array_keys($this->_valid_operators))));
4268 4268
 		}
4269 4269
 	}
4270 4270
 
@@ -4274,10 +4274,10 @@  discard block
 block discarded – undo
4274 4274
 	 * @param array $query_params like get_all's
4275 4275
 	 * @return string[]
4276 4276
 	 */
4277
-	public function get_all_names($query_params = array()){
4277
+	public function get_all_names($query_params = array()) {
4278 4278
 		$objs = $this->get_all($query_params);
4279 4279
 		$names = array();
4280
-		foreach($objs as $obj){
4280
+		foreach ($objs as $obj) {
4281 4281
 			$names[$obj->ID()] = $obj->name();
4282 4282
 		}
4283 4283
 		return $names;
@@ -4292,22 +4292,22 @@  discard block
 block discarded – undo
4292 4292
 	 * @param boolean $filter_out_empty_ids if a model object has an ID of '' or 0, don't bother including it in the returned array
4293 4293
 	 * @return array
4294 4294
 	 */
4295
-	public function get_IDs( $model_objects, $filter_out_empty_ids = false) {
4296
-		if( ! $this->has_primary_key_field() ) {
4297
-			if( WP_DEBUG ) {
4298
-				EE_Error::add_error( __( 'Trying to get IDs from a model than has no primary key', 'event_espresso' ), __FILE__, __FUNCTION__, __LINE__ );
4295
+	public function get_IDs($model_objects, $filter_out_empty_ids = false) {
4296
+		if ( ! $this->has_primary_key_field()) {
4297
+			if (WP_DEBUG) {
4298
+				EE_Error::add_error(__('Trying to get IDs from a model than has no primary key', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__);
4299 4299
 				return array();
4300 4300
 			}
4301 4301
 		}
4302 4302
 		$IDs = array();
4303
-		foreach( $model_objects as $model_object ) {
4303
+		foreach ($model_objects as $model_object) {
4304 4304
 			$id = $model_object->ID();
4305
-			if( ! $id ) {
4306
-				if( $filter_out_empty_ids ) {
4305
+			if ( ! $id) {
4306
+				if ($filter_out_empty_ids) {
4307 4307
 					continue;
4308 4308
 				}
4309
-				if( WP_DEBUG ) {
4310
-					EE_Error::add_error(__( 'Called %1$s on a model object that has no ID and so probably hasn\'t been saved to the database', 'event_espresso' ), __FILE__, __FUNCTION__, __LINE__ );
4309
+				if (WP_DEBUG) {
4310
+					EE_Error::add_error(__('Called %1$s on a model object that has no ID and so probably hasn\'t been saved to the database', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__);
4311 4311
 				}
4312 4312
 			}
4313 4313
 			$IDs[] = $id;
@@ -4320,8 +4320,8 @@  discard block
 block discarded – undo
4320 4320
 	 * are no capabilities that relate to this model returns false
4321 4321
 	 * @return string|false
4322 4322
 	 */
4323
-	public function cap_slug(){
4324
-		return apply_filters( 'FHEE__EEM_Base__cap_slug', $this->_caps_slug, $this);
4323
+	public function cap_slug() {
4324
+		return apply_filters('FHEE__EEM_Base__cap_slug', $this->_caps_slug, $this);
4325 4325
 	}
4326 4326
 
4327 4327
 	/**
@@ -4333,27 +4333,27 @@  discard block
 block discarded – undo
4333 4333
 	 * @param string $context
4334 4334
 	 * @return EE_Default_Where_Conditions[] indexed by associated capability
4335 4335
 	 */
4336
-	public function cap_restrictions( $context = EEM_Base::caps_read ) {
4337
-		EEM_Base::verify_is_valid_cap_context( $context );
4336
+	public function cap_restrictions($context = EEM_Base::caps_read) {
4337
+		EEM_Base::verify_is_valid_cap_context($context);
4338 4338
 		//check if we ought to run the restriction generator first
4339
-		if( isset( $this->_cap_restriction_generators[ $context ] ) &&
4340
-				$this->_cap_restriction_generators[ $context ] instanceof EE_Restriction_Generator_Base &&
4341
-				! $this->_cap_restriction_generators[ $context ]->has_generated_cap_restrictions() ) {
4342
-			$this->_cap_restrictions[ $context ] = array_merge( $this->_cap_restrictions[ $context ],  $this->_cap_restriction_generators[ $context ]->generate_restrictions() );
4339
+		if (isset($this->_cap_restriction_generators[$context]) &&
4340
+				$this->_cap_restriction_generators[$context] instanceof EE_Restriction_Generator_Base &&
4341
+				! $this->_cap_restriction_generators[$context]->has_generated_cap_restrictions()) {
4342
+			$this->_cap_restrictions[$context] = array_merge($this->_cap_restrictions[$context], $this->_cap_restriction_generators[$context]->generate_restrictions());
4343 4343
 		}
4344 4344
 		//and make sure we've finalized the construction of each restriction
4345
-		foreach( $this->_cap_restrictions[ $context ] as $where_conditions_obj ) {
4346
-			$where_conditions_obj->_finalize_construct( $this );
4345
+		foreach ($this->_cap_restrictions[$context] as $where_conditions_obj) {
4346
+			$where_conditions_obj->_finalize_construct($this);
4347 4347
 		}
4348 4348
 
4349
-		return $this->_cap_restrictions[ $context ];
4349
+		return $this->_cap_restrictions[$context];
4350 4350
 	}
4351 4351
 
4352 4352
 	/**
4353 4353
 	 * Indicating whether or not this model thinks its a wp core model
4354 4354
 	 * @return boolean
4355 4355
 	 */
4356
-	public function is_wp_core_model(){
4356
+	public function is_wp_core_model() {
4357 4357
 		return $this->_wp_core_model;
4358 4358
 	}
4359 4359
 
@@ -4363,12 +4363,12 @@  discard block
 block discarded – undo
4363 4363
 	 * @param string $context one of EEM_Base::caps_ constants
4364 4364
 	 * @return EE_Default_Where_Conditions[] indexed by capability name
4365 4365
 	 */
4366
-	public function caps_missing( $context = EEM_Base::caps_read ) {
4366
+	public function caps_missing($context = EEM_Base::caps_read) {
4367 4367
 		$missing_caps = array();
4368
-		$cap_restrictions = $this->cap_restrictions( $context );
4369
-		foreach( $cap_restrictions as $cap => $restriction_if_no_cap ) {
4370
-			if( ! EE_Capabilities::instance()->current_user_can( $cap, $this->get_this_model_name() . '_model_applying_caps') ) {
4371
-				$missing_caps[ $cap ] = $restriction_if_no_cap;
4368
+		$cap_restrictions = $this->cap_restrictions($context);
4369
+		foreach ($cap_restrictions as $cap => $restriction_if_no_cap) {
4370
+			if ( ! EE_Capabilities::instance()->current_user_can($cap, $this->get_this_model_name().'_model_applying_caps')) {
4371
+				$missing_caps[$cap] = $restriction_if_no_cap;
4372 4372
 			}
4373 4373
 		}
4374 4374
 		return $missing_caps;
@@ -4380,7 +4380,7 @@  discard block
 block discarded – undo
4380 4380
 	 * one of 'read', 'edit', or 'delete'
4381 4381
 	 */
4382 4382
 	public function cap_contexts_to_cap_action_map() {
4383
-		return apply_filters( 'FHEE__EEM_Base__cap_contexts_to_cap_action_map', $this->_cap_contexts_to_cap_action_map, $this );
4383
+		return apply_filters('FHEE__EEM_Base__cap_contexts_to_cap_action_map', $this->_cap_contexts_to_cap_action_map, $this);
4384 4384
 	}
4385 4385
 
4386 4386
 
@@ -4391,19 +4391,19 @@  discard block
 block discarded – undo
4391 4391
 	 * @return string one of EEM_Base::cap_contexts_to_cap_action_map() values
4392 4392
 	 * @throws \EE_Error
4393 4393
 	 */
4394
-	public function cap_action_for_context( $context ) {
4394
+	public function cap_action_for_context($context) {
4395 4395
 		$mapping = $this->cap_contexts_to_cap_action_map();
4396
-		if( isset( $mapping[ $context ] ) ) {
4397
-			return $mapping[ $context ];
4396
+		if (isset($mapping[$context])) {
4397
+			return $mapping[$context];
4398 4398
 		}
4399
-		if( $action = apply_filters( 'FHEE__EEM_Base__cap_action_for_context', null, $this, $mapping, $context ) ) {
4399
+		if ($action = apply_filters('FHEE__EEM_Base__cap_action_for_context', null, $this, $mapping, $context)) {
4400 4400
 			return $action;
4401 4401
 		}
4402 4402
 		throw new EE_Error(
4403 4403
 			sprintf(
4404
-				__( 'Cannot find capability restrictions for context "%1$s", allowed values are:%2$s', 'event_espresso' ),
4404
+				__('Cannot find capability restrictions for context "%1$s", allowed values are:%2$s', 'event_espresso'),
4405 4405
 				$context,
4406
-				implode(',', array_keys( $this->cap_contexts_to_cap_action_map() ) )
4406
+				implode(',', array_keys($this->cap_contexts_to_cap_action_map()))
4407 4407
 			)
4408 4408
 		);
4409 4409
 
@@ -4414,7 +4414,7 @@  discard block
 block discarded – undo
4414 4414
 	 * @return array
4415 4415
 	 */
4416 4416
 	static public function valid_cap_contexts() {
4417
-		return apply_filters( 'FHEE__EEM_Base__valid_cap_contexts', array(
4417
+		return apply_filters('FHEE__EEM_Base__valid_cap_contexts', array(
4418 4418
 			self::caps_read,
4419 4419
 			self::caps_read_admin,
4420 4420
 			self::caps_edit,
@@ -4430,17 +4430,17 @@  discard block
 block discarded – undo
4430 4430
 	 * @return bool
4431 4431
 	 * @throws \EE_Error
4432 4432
 	 */
4433
-	static public function verify_is_valid_cap_context( $context ) {
4433
+	static public function verify_is_valid_cap_context($context) {
4434 4434
 		$valid_cap_contexts = EEM_Base::valid_cap_contexts();
4435
-		if( in_array( $context, $valid_cap_contexts ) ) {
4435
+		if (in_array($context, $valid_cap_contexts)) {
4436 4436
 			return true;
4437
-		}else{
4437
+		} else {
4438 4438
 			throw new EE_Error(
4439 4439
 				sprintf(
4440
-					__( 'Context "%1$s" passed into model "%2$s" is not a valid context. They are: %3$s', 'event_espresso' ),
4440
+					__('Context "%1$s" passed into model "%2$s" is not a valid context. They are: %3$s', 'event_espresso'),
4441 4441
 					$context,
4442
-					'EEM_Base' ,
4443
-					implode(',', $valid_cap_contexts )
4442
+					'EEM_Base',
4443
+					implode(',', $valid_cap_contexts)
4444 4444
 				)
4445 4445
 			);
4446 4446
 		}
Please login to merge, or discard this patch.