eventespresso / event-espresso-core

core/libraries/form_sections/strategies/validation/EE_Email_Validation_Strategy.strategy.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     * just checks the field isn't blank
     *
     * @param $normalized_value
-    * @return bool
+    * @return boolean|null
     * @throws \EE_Validation_Error
     */
 	function validate($normalized_value) {

Indentation +50 added lines, -50 removed lines

@@ -11,8 +11,8 @@ 
 class EE_Email_Validation_Strategy extends EE_Text_Validation_Strategy{
 
 	/**
-     * @param null $validation_error_message
-     */
+	 * @param null $validation_error_message
+	 */
    public function __construct( $validation_error_message = NULL ) {
 		if( ! $validation_error_message ){
 			$validation_error_message = __("Please enter a valid email address.", "event_espresso");
@@ -38,8 +38,8 @@ 
 
 
 	/**
-     * @return array
-     */
+	 * @return array
+	 */
    function get_jquery_validation_rule_array(){
 		return array( 'email'=>true, 'messages' => array( 'email' => $this->get_validation_error_message() ) );
 	}
@@ -59,56 +59,56 @@ 
    $atIndex = strrpos($email, "@");
    if (is_bool($atIndex) && !$atIndex)
    {
-      $isValid = false;
+	  $isValid = false;
    }
    else
    {
-      $domain = substr($email, $atIndex+1);
-      $local = substr($email, 0, $atIndex);
-      $localLen = strlen($local);
-      $domainLen = strlen($domain);
-      if ($localLen < 1 || $localLen > 64)
-      {
-         // local part length exceeded
-         $isValid = false;
-      }
-      else if ($domainLen < 1 || $domainLen > 255)
-      {
-         // domain part length exceeded
-         $isValid = false;
-      }
-      else if ($local[0] == '.' || $local[$localLen-1] == '.')
-      {
-         // local part starts or ends with '.'
-         $isValid = false;
-      }
-      else if (preg_match('/\\.\\./', $local))
-      {
-         // local part has two consecutive dots
-         $isValid = false;
-      }
-      else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
-      {
-         // character not valid in domain part
-         $isValid = false;
-      }
-      else if (preg_match('/\\.\\./', $domain))
-      {
-         // domain part has two consecutive dots
-         $isValid = false;
-      }
-      else if
+	  $domain = substr($email, $atIndex+1);
+	  $local = substr($email, 0, $atIndex);
+	  $localLen = strlen($local);
+	  $domainLen = strlen($domain);
+	  if ($localLen < 1 || $localLen > 64)
+	  {
+		 // local part length exceeded
+		 $isValid = false;
+	  }
+	  else if ($domainLen < 1 || $domainLen > 255)
+	  {
+		 // domain part length exceeded
+		 $isValid = false;
+	  }
+	  else if ($local[0] == '.' || $local[$localLen-1] == '.')
+	  {
+		 // local part starts or ends with '.'
+		 $isValid = false;
+	  }
+	  else if (preg_match('/\\.\\./', $local))
+	  {
+		 // local part has two consecutive dots
+		 $isValid = false;
+	  }
+	  else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
+	  {
+		 // character not valid in domain part
+		 $isValid = false;
+	  }
+	  else if (preg_match('/\\.\\./', $domain))
+	  {
+		 // domain part has two consecutive dots
+		 $isValid = false;
+	  }
+	  else if
 (!preg_match('/^(\\\\.|[A-Za-z0-9!#%&`_=\\/$\'*+?^{}|~.-])+$/',
-                 str_replace("\\\\","",$local)))
-      {
-         // character not valid in local part unless
-         // local part is quoted
-         if (!preg_match('/^"(\\\\"|[^"])+"$/',
-             str_replace("\\\\","",$local)))
-         {
-            $isValid = false;
-         }
-      }
+				 str_replace("\\\\","",$local)))
+	  {
+		 // character not valid in local part unless
+		 // local part is quoted
+		 if (!preg_match('/^"(\\\\"|[^"])+"$/',
+			 str_replace("\\\\","",$local)))
+		 {
+			$isValid = false;
+		 }
+	  }
 	  //don't check the DNS records... just personal preference
 //      if ($isValid && !(checkdnsrr($domain,"MX") || checkdnsrr($domain,"A")))
 //      {

Spacing +16 added lines, -17 removed lines

@@ -8,16 +8,16 @@ 
  * @since 				4.6
  *
  */
-class EE_Email_Validation_Strategy extends EE_Text_Validation_Strategy{
+class EE_Email_Validation_Strategy extends EE_Text_Validation_Strategy {
 
 	/**
      * @param null $validation_error_message
      */
-   public function __construct( $validation_error_message = NULL ) {
-		if( ! $validation_error_message ){
+   public function __construct($validation_error_message = NULL) {
+		if ( ! $validation_error_message) {
 			$validation_error_message = __("Please enter a valid email address.", "event_espresso");
 		}
-		parent::__construct( $validation_error_message );
+		parent::__construct($validation_error_message);
 	}
 
 
@@ -30,8 +30,8 @@ 
     * @throws \EE_Validation_Error
     */
 	function validate($normalized_value) {
-		if( $normalized_value && ! $this->_validate_email($normalized_value) ){
-			throw new EE_Validation_Error( $this->get_validation_error_message(), 'required');
+		if ($normalized_value && ! $this->_validate_email($normalized_value)) {
+			throw new EE_Validation_Error($this->get_validation_error_message(), 'required');
 		}
 	}
 
@@ -40,8 +40,8 @@ 
 	/**
      * @return array
      */
-   function get_jquery_validation_rule_array(){
-		return array( 'email'=>true, 'messages' => array( 'email' => $this->get_validation_error_message() ) );
+   function get_jquery_validation_rule_array() {
+		return array('email'=>true, 'messages' => array('email' => $this->get_validation_error_message()));
 	}
 
 
@@ -57,13 +57,13 @@ 
 {
    $isValid = true;
    $atIndex = strrpos($email, "@");
-   if (is_bool($atIndex) && !$atIndex)
+   if (is_bool($atIndex) && ! $atIndex)
    {
       $isValid = false;
    }
    else
    {
-      $domain = substr($email, $atIndex+1);
+      $domain = substr($email, $atIndex + 1);
       $local = substr($email, 0, $atIndex);
       $localLen = strlen($local);
       $domainLen = strlen($domain);
@@ -77,7 +77,7 @@ 
          // domain part length exceeded
          $isValid = false;
       }
-      else if ($local[0] == '.' || $local[$localLen-1] == '.')
+      else if ($local[0] == '.' || $local[$localLen - 1] == '.')
       {
          // local part starts or ends with '.'
          $isValid = false;
@@ -87,7 +87,7 @@ 
          // local part has two consecutive dots
          $isValid = false;
       }
-      else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
+      else if ( ! preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
       {
          // character not valid in domain part
          $isValid = false;
@@ -97,14 +97,13 @@ 
          // domain part has two consecutive dots
          $isValid = false;
       }
-      else if
-(!preg_match('/^(\\\\.|[A-Za-z0-9!#%&`_=\\/$\'*+?^{}|~.-])+$/',
-                 str_replace("\\\\","",$local)))
+      else if ( ! preg_match('/^(\\\\.|[A-Za-z0-9!#%&`_=\\/$\'*+?^{}|~.-])+$/',
+                 str_replace("\\\\", "", $local)))
       {
          // character not valid in local part unless
          // local part is quoted
-         if (!preg_match('/^"(\\\\"|[^"])+"$/',
-             str_replace("\\\\","",$local)))
+         if ( ! preg_match('/^"(\\\\"|[^"])+"$/',
+             str_replace("\\\\", "", $local)))
          {
             $isValid = false;
          }

Braces +7 added lines, -14 removed lines

@@ -60,8 +60,7 @@ 
    if (is_bool($atIndex) && !$atIndex)
    {
       $isValid = false;
-   }
-   else
+   } else
    {
       $domain = substr($email, $atIndex+1);
       $local = substr($email, 0, $atIndex);
@@ -71,33 +70,27 @@ 
       {
          // local part length exceeded
          $isValid = false;
-      }
-      else if ($domainLen < 1 || $domainLen > 255)
+      } else if ($domainLen < 1 || $domainLen > 255)
       {
          // domain part length exceeded
          $isValid = false;
-      }
-      else if ($local[0] == '.' || $local[$localLen-1] == '.')
+      } else if ($local[0] == '.' || $local[$localLen-1] == '.')
       {
          // local part starts or ends with '.'
          $isValid = false;
-      }
-      else if (preg_match('/\\.\\./', $local))
+      } else if (preg_match('/\\.\\./', $local))
       {
          // local part has two consecutive dots
          $isValid = false;
-      }
-      else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
+      } else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))
       {
          // character not valid in domain part
          $isValid = false;
-      }
-      else if (preg_match('/\\.\\./', $domain))
+      } else if (preg_match('/\\.\\./', $domain))
       {
          // domain part has two consecutive dots
          $isValid = false;
-      }
-      else if
+      } else if
 (!preg_match('/^(\\\\.|[A-Za-z0-9!#%&`_=\\/$\'*+?^{}|~.-])+$/',
                  str_replace("\\\\","",$local)))
       {

core/libraries/form_sections/strategies/validation/EE_Float_Validation_Strategy.strategy.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 	/**
 	 *
 	 * @param $normalized_value
-	 * @return bool
+	 * @return boolean|null
 	 */
 	function validate($normalized_value) {
 		//errors should have been detected by the normalization strategy

Spacing +6 added lines, -6 removed lines

@@ -8,16 +8,16 @@ 
  * @since 				4.6
  *
  */
-class EE_Float_Validation_Strategy extends EE_Validation_Strategy_Base{
+class EE_Float_Validation_Strategy extends EE_Validation_Strategy_Base {
 
 	/**
 	 * @param null $validation_error_message
 	 */
-	public function __construct( $validation_error_message = NULL ) {
-		if( ! $validation_error_message ){
+	public function __construct($validation_error_message = NULL) {
+		if ( ! $validation_error_message) {
 			$validation_error_message = sprintf(__("Only numeric characters, commas, periods, and spaces, please!", "event_espresso"));
 		}
-		parent::__construct( $validation_error_message );
+		parent::__construct($validation_error_message);
 	}
 
 
@@ -36,8 +36,8 @@ 
 	/**
 	 * @return array
 	 */
-	function get_jquery_validation_rule_array(){
-		return array('number'=>true, 'messages' => array( 'number' => $this->get_validation_error_message() ) );
+	function get_jquery_validation_rule_array() {
+		return array('number'=>true, 'messages' => array('number' => $this->get_validation_error_message()));
 	}
 }
 

core/libraries/form_sections/strategies/validation/EE_Many_Valued_Validation_Strategy.strategy.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 	/**
 	 * Applies all teh individual item validation strategies on each item in the array
 	 * @param array $normalized_value
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	function validate($normalized_value) {
 		if( is_array($normalized_value)){

Spacing +9 added lines, -9 removed lines

@@ -11,14 +11,14 @@ 
  * @since 				4.6
  *
  */
-class EE_Many_Valued_Validation_Strategy extends EE_Validation_Strategy_Base{
+class EE_Many_Valued_Validation_Strategy extends EE_Validation_Strategy_Base {
 	protected $_individual_item_validation_strategies = array();
 	/**
 	 *
 	 * @param EE_Validation_Strategy_Base[] $individual_item_validation_strategies (or a single EE_Validation_Strategy_Base)
 	 */
 	public function __construct($individual_item_validation_strategies) {
-		if( ! is_array($individual_item_validation_strategies)){
+		if ( ! is_array($individual_item_validation_strategies)) {
 			$individual_item_validation_strategies = array($individual_item_validation_strategies);
 		}
 		$this->_individual_item_validation_strategies = $individual_item_validation_strategies;
@@ -30,14 +30,14 @@ 
 	 * @return boolean
 	 */
 	function validate($normalized_value) {
-		if( is_array($normalized_value)){
+		if (is_array($normalized_value)) {
 			$items_to_validate = $normalized_value;
-		}else{
+		} else {
 			$items_to_validate = array($normalized_value);
 		}
-		foreach($items_to_validate as $individual_item){
-			foreach($this->_individual_item_validation_strategies as $validation_strategy){
-				if ( $validation_strategy instanceof EE_Validation_Strategy_Base ) {
+		foreach ($items_to_validate as $individual_item) {
+			foreach ($this->_individual_item_validation_strategies as $validation_strategy) {
+				if ($validation_strategy instanceof EE_Validation_Strategy_Base) {
 					$validation_strategy->validate($individual_item);
 				}
 			}
@@ -50,8 +50,8 @@ 
 	 */
 	function _construct_finalize(\EE_Form_Input_Base $form_input) {
 		parent::_construct_finalize($form_input);
-		foreach($this->_individual_item_validation_strategies as $item_validation_strategy){
-			if ( $item_validation_strategy instanceof EE_Validation_Strategy_Base ) {
+		foreach ($this->_individual_item_validation_strategies as $item_validation_strategy) {
+			if ($item_validation_strategy instanceof EE_Validation_Strategy_Base) {
 				$item_validation_strategy->_construct_finalize($form_input);
 			}
 		}

Braces +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	function validate($normalized_value) {
 		if( is_array($normalized_value)){
 			$items_to_validate = $normalized_value;
-		}else{
+		} else{
 			$items_to_validate = array($normalized_value);
 		}
 		foreach($items_to_validate as $individual_item){

core/libraries/form_sections/strategies/validation/EE_Text_Validation_Strategy.strategy.php

Doc Comments +4 added lines

@@ -10,6 +10,10 @@
 class EE_Text_Validation_Strategy extends EE_Validation_Strategy_Base{
 
 	protected $_regex = null;
+
+	/**
+	 * @param string $regex
+	 */
 	public function __construct( $validation_error_message = NULL, $regex = null ) {
 		$this->_regex = $regex;
 		parent::__construct( $validation_error_message );

Spacing +12 added lines, -12 removed lines

@@ -7,21 +7,21 @@ 
  * @subpackage	Expression package is undefined on line 19, column 19 in Templates/Scripting/PHPClass.php.
  * @author				Mike Nelson
  */
-class EE_Text_Validation_Strategy extends EE_Validation_Strategy_Base{
+class EE_Text_Validation_Strategy extends EE_Validation_Strategy_Base {
 
 	protected $_regex = null;
-	public function __construct( $validation_error_message = NULL, $regex = null ) {
+	public function __construct($validation_error_message = NULL, $regex = null) {
 		$this->_regex = $regex;
-		parent::__construct( $validation_error_message );
+		parent::__construct($validation_error_message);
 	}
 
 	/**
 	 * @param $normalized_value
 	 */
 	public function validate($normalized_value) {
-		if( $this->_regex && $normalized_value) {
-			if( ! preg_match( $this->_regex, $normalized_value ) ) {
-				throw new EE_Validation_Error( $this->get_validation_error_message(), 'regex' );
+		if ($this->_regex && $normalized_value) {
+			if ( ! preg_match($this->_regex, $normalized_value)) {
+				throw new EE_Validation_Error($this->get_validation_error_message(), 'regex');
 			}
 		}
 	}
@@ -29,10 +29,10 @@ 
 	/**
 	 * @return array
 	 */
-	function get_jquery_validation_rule_array(){
-		if( $this->_regex !== null ){
-			return array( 'regex'=> $this->regex_js(), 'messages' => array( 'regex' => $this->get_validation_error_message() ) );
-		}else{
+	function get_jquery_validation_rule_array() {
+		if ($this->_regex !== null) {
+			return array('regex'=> $this->regex_js(), 'messages' => array('regex' => $this->get_validation_error_message()));
+		} else {
 			return array();
 		}
 
@@ -46,8 +46,8 @@ 
 	function regex_js() {
 		//first character must be the delimiter
 		$delimeter = $this->_regex[0];
-		$last_occurence_of_delimieter = strrpos($this->_regex, $delimeter );
-		return substr( $this->_regex, 1, $last_occurence_of_delimieter - 1 );
+		$last_occurence_of_delimieter = strrpos($this->_regex, $delimeter);
+		return substr($this->_regex, 1, $last_occurence_of_delimieter - 1);
 	}
 }
 

Braces +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	function get_jquery_validation_rule_array(){
 		if( $this->_regex !== null ){
 			return array( 'regex'=> $this->regex_js(), 'messages' => array( 'regex' => $this->get_validation_error_message() ) );
-		}else{
+		} else{
 			return array();
 		}
 

core/libraries/form_sections/strategies/validation/EE_URL_Validation_Strategy.strategy.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 	 * just checks the field isn't blank
 	 *
 	 * @param $normalized_value
-	 * @return bool
+	 * @return boolean|null
 	 * @throws \EE_Validation_Error
 	 */
 	function validate($normalized_value) {

Spacing +11 added lines, -11 removed lines

@@ -8,16 +8,16 @@ 
  * @since 				4.6
  *
  */
-class EE_URL_Validation_Strategy extends EE_Validation_Strategy_Base{
+class EE_URL_Validation_Strategy extends EE_Validation_Strategy_Base {
 
 	/**
 	 * @param null $validation_error_message
 	 */
-	public function __construct( $validation_error_message = NULL ) {
-		if( ! $validation_error_message ){
+	public function __construct($validation_error_message = NULL) {
+		if ( ! $validation_error_message) {
 			$validation_error_message = __("Please enter a valid URL", "event_espresso");
 		}
-		parent::__construct( $validation_error_message );
+		parent::__construct($validation_error_message);
 	}
 
 
@@ -30,12 +30,12 @@ 
 	 * @throws \EE_Validation_Error
 	 */
 	function validate($normalized_value) {
-		if( $normalized_value ){
-			if (filter_var($normalized_value, FILTER_VALIDATE_URL) === false){
-				throw new EE_Validation_Error( $this->get_validation_error_message(), 'invalid_url');
-			}else{
+		if ($normalized_value) {
+			if (filter_var($normalized_value, FILTER_VALIDATE_URL) === false) {
+				throw new EE_Validation_Error($this->get_validation_error_message(), 'invalid_url');
+			} else {
 				EE_Registry::instance()->load_helper('URL');
-				if( ! EEH_URL::remote_file_exists($normalized_value)){
+				if ( ! EEH_URL::remote_file_exists($normalized_value)) {
 					throw new EE_Validation_Error(sprintf(__("That URL seems to be broken. Please enter a valid URL", "event_espresso")));
 				}
 			}
@@ -47,8 +47,8 @@ 
 	/**
 	 * @return array
 	 */
-	function get_jquery_validation_rule_array(){
-		return array( 'validUrl'=>true, 'messages' => array( 'validUrl' => $this->get_validation_error_message() ) );
+	function get_jquery_validation_rule_array() {
+		return array('validUrl'=>true, 'messages' => array('validUrl' => $this->get_validation_error_message()));
 	}
 }
 

Braces +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 		if( $normalized_value ){
 			if (filter_var($normalized_value, FILTER_VALIDATE_URL) === false){
 				throw new EE_Validation_Error( $this->get_validation_error_message(), 'invalid_url');
-			}else{
+			} else{
 				EE_Registry::instance()->load_helper('URL');
 				if( ! EEH_URL::remote_file_exists($normalized_value)){
 					throw new EE_Validation_Error(sprintf(__("That URL seems to be broken. Please enter a valid URL", "event_espresso")));

core/libraries/line_item_display/EE_Invoice_Line_Item_Display_Strategy.strategy.php

Doc Comments +6 added lines, -6 removed lines

@@ -16,7 +16,7 @@ 
 	/**
 	 * @param EE_Line_Item $line_item
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	public function display_line_item( EE_Line_Item $line_item, $options = array() ) {
 
@@ -94,7 +94,7 @@ 
 	 *
 	 * @param EE_Line_Item $line_item
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	private function _item_row( EE_Line_Item $line_item, $options = array() ) {
 		// start of row
@@ -123,7 +123,7 @@ 
 	 *
 	 * @param EE_Line_Item $line_item
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	private function _sub_item_row( EE_Line_Item $line_item, $options = array() ) {
 		// start of row
@@ -153,7 +153,7 @@ 
 	 *
 	 * @param EE_Line_Item $line_item
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	private function _tax_row( EE_Line_Item $line_item, $options = array() ) {
 		// start of row
@@ -179,7 +179,7 @@ 
 	 * @param EE_Line_Item $line_item
 	 * @param string       $text
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	private function _total_row( EE_Line_Item $line_item, $text = '', $options = array() ) {
 		// colspan
@@ -203,7 +203,7 @@ 
 	 * 	_separator_row
 	 *
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	private function _separator_row( $options = array() ) {
 		// colspan

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php if ( ! defined('EVENT_ESPRESSO_VERSION')) { exit('No direct script access allowed'); }
  /**
- *
- * Class EE_Invoice_Line_Item_Display_Strategy
- *
- * Description
- *
- * @package         Event Espresso
- * @subpackage    core
- * @author				Brent Christensen
- * @since		 	   $VID:$
- *
- */
+  *
+  * Class EE_Invoice_Line_Item_Display_Strategy
+  *
+  * Description
+  *
+  * @package         Event Espresso
+  * @subpackage    core
+  * @author				Brent Christensen
+  * @since		 	   $VID:$
+  *
+  */
 class EE_Invoice_Line_Item_Display_Strategy implements EEI_Line_Item_Display {
 
 	/**

Spacing +49 added lines, -49 removed lines

@@ -18,9 +18,9 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	public function display_line_item( EE_Line_Item $line_item, $options = array() ) {
+	public function display_line_item(EE_Line_Item $line_item, $options = array()) {
 
-		EE_Registry::instance()->load_helper( 'HTML' );
+		EE_Registry::instance()->load_helper('HTML');
 
 		$html = '';
 		// set some default options and merge with incoming
@@ -28,58 +28,58 @@ 
 			'show_desc' => TRUE,
 			'odd' => FALSE
 		);
-		$options = array_merge( $default_options, (array)$options );
+		$options = array_merge($default_options, (array) $options);
 
-		switch( $line_item->type() ) {
+		switch ($line_item->type()) {
 
 			case EEM_Line_Item::type_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
-					$html .= $this->display_line_item( $child_line_item, $options );
+					$html .= $this->display_line_item($child_line_item, $options);
 				}
-				$html .= $this->_separator_row( $options );
-				$html .= $this->_total_row( $line_item, __('Total', 'event_espresso'), $options );
+				$html .= $this->_separator_row($options);
+				$html .= $this->_total_row($line_item, __('Total', 'event_espresso'), $options);
 				 break;
 
 
 			case EEM_Line_Item::type_sub_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
-					$html .= $this->display_line_item( $child_line_item, $options );
+					$html .= $this->display_line_item($child_line_item, $options);
 				}
-				$html .= $this->_total_row( $line_item, __('Sub-Total', 'event_espresso'), $options );
+				$html .= $this->_total_row($line_item, __('Sub-Total', 'event_espresso'), $options);
 				break;
 
 
 			case EEM_Line_Item::type_tax_sub_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
-					$html .= $this->display_line_item( $child_line_item, $options );
+					$html .= $this->display_line_item($child_line_item, $options);
 				}
-				$html .= $this->_total_row( $line_item, __('Tax Total', 'event_espresso'), $options );
+				$html .= $this->_total_row($line_item, __('Tax Total', 'event_espresso'), $options);
 				break;
 
 
 			case EEM_Line_Item::type_line_item:
 				// item row
-				$html .= $this->_item_row( $line_item, $options );
+				$html .= $this->_item_row($line_item, $options);
 				// got any kids?
-				foreach( $line_item->children() as $child_line_item ) {
-					$this->display_line_item( $child_line_item, $options );
+				foreach ($line_item->children() as $child_line_item) {
+					$this->display_line_item($child_line_item, $options);
 				}
 				break;
 
 
 			case EEM_Line_Item::type_sub_line_item:
-				$html .= $this->_sub_item_row( $line_item, $options );
+				$html .= $this->_sub_item_row($line_item, $options);
 				break;
 
 
 			case EEM_Line_Item::type_tax:
-				$html .= $this->_tax_row( $line_item, $options );
+				$html .= $this->_tax_row($line_item, $options);
 				break;
 
 		}
@@ -96,21 +96,21 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	private function _item_row( EE_Line_Item $line_item, $options = array() ) {
+	private function _item_row(EE_Line_Item $line_item, $options = array()) {
 		// start of row
 		$row_class = $options['odd'] ? 'item odd' : 'item';
-		$html = EEH_HTML::tr( '', $row_class );
+		$html = EEH_HTML::tr('', $row_class);
 		// name td
-		$html .= EEH_HTML::td( $line_item->name(), '',  'item_l' );
+		$html .= EEH_HTML::td($line_item->name(), '', 'item_l');
 		// desc td
-		$html .= $options['show_desc'] ? EEH_HTML::td( $line_item->desc(), '',  'item_l' ) : '';
+		$html .= $options['show_desc'] ? EEH_HTML::td($line_item->desc(), '', 'item_l') : '';
 		// quantity td
-		$html .= EEH_HTML::td( $line_item->quantity(), '',  'item_l' );
+		$html .= EEH_HTML::td($line_item->quantity(), '', 'item_l');
 		// price td
-		$html .= EEH_HTML::td( $line_item->unit_price_no_code(), '',  'item_c' );
+		$html .= EEH_HTML::td($line_item->unit_price_no_code(), '', 'item_c');
 		// total td
-		$total = $line_item->is_taxable() ? $line_item->total_no_code() . '*' : $line_item->total_no_code();
-		$html .= EEH_HTML::td( $total, '',  'item_r' );
+		$total = $line_item->is_taxable() ? $line_item->total_no_code().'*' : $line_item->total_no_code();
+		$html .= EEH_HTML::td($total, '', 'item_r');
 		// end of row
 		$html .= EEH_HTML::trx();
 		return $html;
@@ -125,22 +125,22 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	private function _sub_item_row( EE_Line_Item $line_item, $options = array() ) {
+	private function _sub_item_row(EE_Line_Item $line_item, $options = array()) {
 		// start of row
-		$html = EEH_HTML::tr( '', 'item sub-item-row' );
+		$html = EEH_HTML::tr('', 'item sub-item-row');
 		// name td
-		$html .= EEH_HTML::td( $line_item->name(), '',  'item_l sub-item' );
+		$html .= EEH_HTML::td($line_item->name(), '', 'item_l sub-item');
 		// desc td
-		$html .= $options['show_desc'] ? EEH_HTML::td( $line_item->desc(), '',  'item_l' ) : '';
-		$html .= EEH_HTML::td() . EEH_HTML::tdx();
+		$html .= $options['show_desc'] ? EEH_HTML::td($line_item->desc(), '', 'item_l') : '';
+		$html .= EEH_HTML::td().EEH_HTML::tdx();
 		// discount/surcharge td
-		if ( $line_item->is_percent() ) {
-			$html .= EEH_HTML::td( $line_item->percent() . '%', '',  'item_c' );
+		if ($line_item->is_percent()) {
+			$html .= EEH_HTML::td($line_item->percent().'%', '', 'item_c');
 		} else {
-			$html .= EEH_HTML::td( $line_item->unit_price_no_code(), '',  'item_c' );
+			$html .= EEH_HTML::td($line_item->unit_price_no_code(), '', 'item_c');
 		}
 		// total td
-		$html .= EEH_HTML::td( $line_item->total_no_code(), '',  'item_r' );
+		$html .= EEH_HTML::td($line_item->total_no_code(), '', 'item_r');
 		// end of row
 		$html .= EEH_HTML::trx();
 		return $html;
@@ -155,17 +155,17 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	private function _tax_row( EE_Line_Item $line_item, $options = array() ) {
+	private function _tax_row(EE_Line_Item $line_item, $options = array()) {
 		// start of row
-		$html = EEH_HTML::tr( '', 'item sub-item tax-total' );
+		$html = EEH_HTML::tr('', 'item sub-item tax-total');
 		// name td
-		$html .= EEH_HTML::td( $line_item->name(), '',  'item_l sub-item' );
+		$html .= EEH_HTML::td($line_item->name(), '', 'item_l sub-item');
 		// desc td
-		$html .= $options['show_desc'] ? EEH_HTML::td( $line_item->desc(), '',  'item_l' ) : '';
+		$html .= $options['show_desc'] ? EEH_HTML::td($line_item->desc(), '', 'item_l') : '';
 		// percent td
-		$html .= EEH_HTML::td( $line_item->percent() . '%', '',  'item_c', '', ' colspan="2"' );
+		$html .= EEH_HTML::td($line_item->percent().'%', '', 'item_c', '', ' colspan="2"');
 		// total td
-		$html .= EEH_HTML::td( $line_item->total_no_code(), '',  'item_r' );
+		$html .= EEH_HTML::td($line_item->total_no_code(), '', 'item_r');
 		// end of row
 		$html .= EEH_HTML::trx();
 		return $html;
@@ -181,17 +181,17 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	private function _total_row( EE_Line_Item $line_item, $text = '', $options = array() ) {
+	private function _total_row(EE_Line_Item $line_item, $text = '', $options = array()) {
 		// colspan
 		$colspan = $options['show_desc'] ? ' colspan="2"' : '';
 		// start of row
-		$html = EEH_HTML::tr( '', '', 'total_tr odd' );
+		$html = EEH_HTML::tr('', '', 'total_tr odd');
 		// empty td
-		$html .= EEH_HTML::td( EEH_HTML::nbsp(), '',  '',  '',  $colspan );
+		$html .= EEH_HTML::td(EEH_HTML::nbsp(), '', '', '', $colspan);
 		// total td
-		$html .= EEH_HTML::td( $text, '',  'total_currency total',  '',  $colspan );
+		$html .= EEH_HTML::td($text, '', 'total_currency total', '', $colspan);
 		// total td
-		$html .= EEH_HTML::td( $line_item->total_no_code(), '',  'total' );
+		$html .= EEH_HTML::td($line_item->total_no_code(), '', 'total');
 		// end of row
 		$html .= EEH_HTML::trx();
 		return $html;
@@ -205,11 +205,11 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	private function _separator_row( $options = array() ) {
+	private function _separator_row($options = array()) {
 		// colspan
 		$colspan = $options['show_desc'] ? ' colspan="5"' : ' colspan="4"';
 		// start of row
-		$html = EEH_HTML::tr( EEH_HTML::td( '<hr>', '',  '',  '',  $colspan ));
+		$html = EEH_HTML::tr(EEH_HTML::td('<hr>', '', '', '', $colspan));
 //		// separator td
 //		$html .= EEH_HTML::td( '<hr>', '',  '',  '',  $colspan );
 //		// end of row

core/libraries/line_item_display/EE_Receipt_Line_Item_Display_Strategy.strategy.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 	/**
 	 * @param EE_Line_Item $line_item
 	 * @param array        $options
-	 * @return mixed
+	 * @return string
 	 */
 	public function display_line_item( EE_Line_Item $line_item, $options = array() ) {
 

Indentation +11 added lines, -11 removed lines

@@ -14,17 +14,17 @@
  * ------------------------------------------------------------------------
  */
  /**
- *
- * Class EE_Receipt_Line_Item_Display_Strategy
- *
- * Description
- *
- * @package         Event Espresso
- * @subpackage    core
- * @author				Brent Christensen
- * @since		 	   $VID:$
- *
- */
+  *
+  * Class EE_Receipt_Line_Item_Display_Strategy
+  *
+  * Description
+  *
+  * @package         Event Espresso
+  * @subpackage    core
+  * @author				Brent Christensen
+  * @since		 	   $VID:$
+  *
+  */
 
 class EE_Receipt_Line_Item_Display_Strategy  implements EEI_Line_Item_Display {
 

Spacing +8 added lines, -8 removed lines

@@ -33,9 +33,9 @@ 
 	 * @param array        $options
 	 * @return mixed
 	 */
-	public function display_line_item( EE_Line_Item $line_item, $options = array() ) {
+	public function display_line_item(EE_Line_Item $line_item, $options = array()) {
 
-		EE_Registry::instance()->load_helper( 'HTML' );
+		EE_Registry::instance()->load_helper('HTML');
 
 		$html = '';
 		// set some default options and merge with incoming
@@ -43,12 +43,12 @@ 
 			'show_desc' => TRUE,
 			'odd' => FALSE
 		);
-		$options = array_merge( $default_options, (array)$options );
-		switch( $line_item->type() ) {
+		$options = array_merge($default_options, (array) $options);
+		switch ($line_item->type()) {
 
 			case EEM_Line_Item::type_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
 //					$html .= $this->display_line_item( $child_line_item, $options );
 				}
@@ -59,7 +59,7 @@ 
 
 			case EEM_Line_Item::type_sub_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
 //					$html .= $this->display_line_item( $child_line_item, $options );
 				}
@@ -69,7 +69,7 @@ 
 
 			case EEM_Line_Item::type_tax_sub_total:
 				// loop thru children
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 					// recursively feed children back into this method
 //					$html .= $this->display_line_item( $child_line_item, $options );
 				}
@@ -81,7 +81,7 @@ 
 				// item row
 //				$html .= $this->_item_row( $line_item, $options );
 				// got any kids?
-				foreach( $line_item->children() as $child_line_item ) {
+				foreach ($line_item->children() as $child_line_item) {
 //					$this->display_line_item( $child_line_item, $options );
 				}
 				break;

core/libraries/messages/defaults/EE_Messages_Template_Pack.core.php

Doc Comments +1 added lines

@@ -316,6 +316,7 @@
 	 * @param EE_message_type $message_type
 	 * @param string          $field          The field reference for the specific template being looked up.
 	 * @param string          $context      The context reference for the specific template being looked up
+	 * @param EE_Messages_Template_Pack_Default|null $default_pack
 	 *
 	 * @return string          The template contents.
 	 */

Spacing +86 added lines, -86 removed lines

@@ -167,48 +167,48 @@ 
 	public function __construct() {
 		$this->_set_props();
 		//make sure classname is correct
-		$classname = get_class( $this );
+		$classname = get_class($this);
 		//make sure required props have been set
 
 		//if label is empty then throw an error because we should have it defined by now.
-		if ( ! isset( $this->label )  ) {
-			throw new EE_Error( sprintf( __('The label property is not set for %s.  Please ensure that is set for the class.', 'event_espresso' ), $classname ) );
+		if ( ! isset($this->label)) {
+			throw new EE_Error(sprintf(__('The label property is not set for %s.  Please ensure that is set for the class.', 'event_espresso'), $classname));
 		}
 
 
 		//the reference for this template pack
-		if ( ! isset( $this->dbref )  ) {
-			throw new EE_Error( sprintf( __('The dbref property is not set for %s.  Please ensure that is set for the class.', 'event_espresso' ), $classname ) );
+		if ( ! isset($this->dbref)) {
+			throw new EE_Error(sprintf(__('The dbref property is not set for %s.  Please ensure that is set for the class.', 'event_espresso'), $classname));
 		}
 
 		//make sure dbref is safe
-		$this->dbref = str_replace( '-', '_', sanitize_key( $this->dbref ) );
+		$this->dbref = str_replace('-', '_', sanitize_key($this->dbref));
 
-		$should_be = 'EE_Messages_Template_Pack_' . str_replace( ' ', '_', ucwords( str_replace( '_', ' ', $this->dbref ) ) );
+		$should_be = 'EE_Messages_Template_Pack_'.str_replace(' ', '_', ucwords(str_replace('_', ' ', $this->dbref)));
 
-		if ( $should_be !== $classname ) {
-			throw new EE_Error( sprintf( __('The name of the template pack instantiated class is "%s".  It should be "%s".  Make sure that the name of the template pack class matches is prepended with "EE_Messages_Template_Pack_" and appended with a sentence case iteration of the value for your template pack\'s dbref property.', 'event_espresso' ), $classname, $should_be ) );
+		if ($should_be !== $classname) {
+			throw new EE_Error(sprintf(__('The name of the template pack instantiated class is "%s".  It should be "%s".  Make sure that the name of the template pack class matches is prepended with "EE_Messages_Template_Pack_" and appended with a sentence case iteration of the value for your template pack\'s dbref property.', 'event_espresso'), $classname, $should_be));
 		}
 
 		//if _base_path is not set then throw an error because a base path string is needed.
-		if ( empty( $this->_base_path ) ) {
-			throw new EE_Error( sprintf( __('The _base_path property is not set for %s.  Please ensure that is set for the class.', 'event_espresso' ), $classname ) );
+		if (empty($this->_base_path)) {
+			throw new EE_Error(sprintf(__('The _base_path property is not set for %s.  Please ensure that is set for the class.', 'event_espresso'), $classname));
 		}
 
 
 		//if _base_url is not set then throw an error because a  string is needed for variations.
-		if ( empty( $this->_base_url ) ) {
-			throw new EE_Error( sprintf( __('The _base_url property is not set for %s.  Please ensure that is set for the class.', 'event_espresso' ), $classname ) );
+		if (empty($this->_base_url)) {
+			throw new EE_Error(sprintf(__('The _base_url property is not set for %s.  Please ensure that is set for the class.', 'event_espresso'), $classname));
 		}
 
 
 		//if $supports is not set then throw an error because that effectively means this template_pack does not have any templates!
-		if ( empty( $this->_supports ) ) {
-			throw new EE_Error( sprintf( __('The supports property is not set for %s.  Please ensure that is set for the class.', 'event_espresso' ), $classname ) );
+		if (empty($this->_supports)) {
+			throw new EE_Error(sprintf(__('The supports property is not set for %s.  Please ensure that is set for the class.', 'event_espresso'), $classname));
 		}
 
 		//load template helper
-		EE_Registry::instance()->load_helper( 'Template' );
+		EE_Registry::instance()->load_helper('Template');
 
 	}
 
@@ -243,8 +243,8 @@ 
 	 *
 	 * @return array
 	 */
-	public function get_templates( EE_messenger $messenger, EE_message_type $message_type ) {
-		return isset( $this->_templates[$messenger->name][$message_type->name] ) ? $this->_templates[$messenger->name][$message_type->name] : $this->_get_templates( $messenger, $message_type );
+	public function get_templates(EE_messenger $messenger, EE_message_type $message_type) {
+		return isset($this->_templates[$messenger->name][$message_type->name]) ? $this->_templates[$messenger->name][$message_type->name] : $this->_get_templates($messenger, $message_type);
 	}
 
 
@@ -261,7 +261,7 @@ 
 	 * @return array          Returns an multi-level associative array indexed by template context and field in the format:
 	 *                                array( 'context' => array( 'field' => 'value', 'another-field', 'value' ) );
 	 */
-	protected function _get_templates( EE_messenger $messenger, EE_message_type $message_type ) {
+	protected function _get_templates(EE_messenger $messenger, EE_message_type $message_type) {
 		$templates = array();
 
 		/**
@@ -280,28 +280,28 @@ 
 		$contexts = $message_type->get_contexts();
 
 
-		foreach ( $contexts as $context => $details ) {
-			foreach ( $fields as $field => $field_details ) {
-				if ( empty( $field_details ) )
+		foreach ($contexts as $context => $details) {
+			foreach ($fields as $field => $field_details) {
+				if (empty($field_details))
 					continue;
 				/**
 				 * is this a field array (linked to a main field)?
 				 */
-				if ( $field == 'extra'  ) {
-					foreach ( $field_details as $main_field => $sub_fields ) {
-						foreach ( $sub_fields as $sub_field => $sub_field_details ) {
+				if ($field == 'extra') {
+					foreach ($field_details as $main_field => $sub_fields) {
+						foreach ($sub_fields as $sub_field => $sub_field_details) {
 							//make sure that the template_field_ref matches what the main template field is for this template group.
 							$template_field_ref = $sub_field == 'main' ? $main_field : $sub_field;
-							$templates[ $context ][ $main_field ][ $sub_field ] = $this->_get_specific_template( $default_pack, $messenger, $message_type, $template_field_ref, $context );
+							$templates[$context][$main_field][$sub_field] = $this->_get_specific_template($default_pack, $messenger, $message_type, $template_field_ref, $context);
 						}
 					}
 				} else {
-					$templates[ $context ][ $field ] = $this->_get_specific_template( $default_pack, $messenger, $message_type, $field, $context );
+					$templates[$context][$field] = $this->_get_specific_template($default_pack, $messenger, $message_type, $field, $context);
 				}
 			}
 		}
 
-		$templates = apply_filters( 'FHEE__EE_Template_Pack___get_templates__templates', $templates, $messenger, $message_type, $this );
+		$templates = apply_filters('FHEE__EE_Template_Pack___get_templates__templates', $templates, $messenger, $message_type, $this);
 
 		$this->_templates[$messenger->name][$message_type->name] = $templates;
 		 return $templates;
@@ -319,22 +319,22 @@ 
 	 *
 	 * @return string          The template contents.
 	 */
-	protected function _get_specific_template( $default_pack, EE_messenger $messenger, EE_message_type $message_type, $field, $context ) {
+	protected function _get_specific_template($default_pack, EE_messenger $messenger, EE_message_type $message_type, $field, $context) {
 
 		//default templates
-		$default_templates = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_templates( $messenger, $message_type ) : array();
+		$default_templates = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_templates($messenger, $message_type) : array();
 
 		//first we allow for the $_base_path to be filtered.  However, we assign this to a new variable so that we have the original base_path as a fallback.
-		$filtered_base_path = apply_filters( 'FHEE__EE_Template_Pack___get_specific_template__filtered_base_path', $this->_base_path, $messenger, $message_type, $field, $context, $this );
+		$filtered_base_path = apply_filters('FHEE__EE_Template_Pack___get_specific_template__filtered_base_path', $this->_base_path, $messenger, $message_type, $field, $context, $this);
 
 		$master_templates = $message_type->get_master_templates();
-		$master_templates_mt = isset( $master_templates[$messenger->name] ) ? $master_templates[$messenger->name] : $message_type->name;
-		$full_path = $filtered_base_path . $messenger->name . '_' . $message_type->name . '_' . $field . '_' . $context . '.template.php';
-		$fallback_path = $filtered_base_path . $messenger->name . '_' . $message_type->name . '_' . $field . '.template.php';
-		$mt_defined_full_path = $filtered_base_path . $messenger->name . '_' . $master_templates_mt . '_' . $field . '_' . $context . '.template.php';
-		$mt_defined_fallback_path = $filtered_base_path . $messenger->name . '_' . $master_templates_mt . '_' . $field . '.template.php';
-		$base_defined_full_path = $this->_base_path . $messenger->name . '_' . $master_templates_mt . '_' . $field . '_' . $context . '.template.php';
-		$base_defined_fallback_path = $this->_base_path . $messenger->name . '_' . $master_templates_mt . '_' . $field . '.template.php';
+		$master_templates_mt = isset($master_templates[$messenger->name]) ? $master_templates[$messenger->name] : $message_type->name;
+		$full_path = $filtered_base_path.$messenger->name.'_'.$message_type->name.'_'.$field.'_'.$context.'.template.php';
+		$fallback_path = $filtered_base_path.$messenger->name.'_'.$message_type->name.'_'.$field.'.template.php';
+		$mt_defined_full_path = $filtered_base_path.$messenger->name.'_'.$master_templates_mt.'_'.$field.'_'.$context.'.template.php';
+		$mt_defined_fallback_path = $filtered_base_path.$messenger->name.'_'.$master_templates_mt.'_'.$field.'.template.php';
+		$base_defined_full_path = $this->_base_path.$messenger->name.'_'.$master_templates_mt.'_'.$field.'_'.$context.'.template.php';
+		$base_defined_fallback_path = $this->_base_path.$messenger->name.'_'.$master_templates_mt.'_'.$field.'.template.php';
 
 		/**
 		 * Template checks are done hierarchically in the following order:
@@ -348,28 +348,28 @@ 
 		 */
 
 
-		if ( is_readable( $full_path ) ) {
+		if (is_readable($full_path)) {
 			$actual_path = $full_path;
-		} elseif ( is_readable( $fallback_path ) ) {
+		} elseif (is_readable($fallback_path)) {
 			$actual_path = $fallback_path;
-		} elseif ( is_readable( $mt_defined_full_path ) ) {
+		} elseif (is_readable($mt_defined_full_path)) {
 			$actual_path = $mt_defined_full_path;
-		} elseif ( is_readable( $mt_defined_fallback_path ) ) {
+		} elseif (is_readable($mt_defined_fallback_path)) {
 			$actual_path = $mt_defined_fallback_path;
-		} elseif ( is_readable( $base_defined_full_path ) ) {
+		} elseif (is_readable($base_defined_full_path)) {
 			$actual_path = $base_defined_full_path;
-		} elseif ( is_readable( $base_defined_fallback_path ) ) {
+		} elseif (is_readable($base_defined_fallback_path)) {
 			$actual_path = $base_defined_fallback_path;
-		} else  {
+		} else {
 			$actual_path = '';
 		}
-		if ( empty( $actual_path ) ) {
-			$contents = isset( $default_templates[$context][$field] ) ? $default_templates[$context][$field] : '';
+		if (empty($actual_path)) {
+			$contents = isset($default_templates[$context][$field]) ? $default_templates[$context][$field] : '';
 		} else {
-			$contents = EEH_Template::display_template( $actual_path, array(), TRUE );
+			$contents = EEH_Template::display_template($actual_path, array(), TRUE);
 		}
 
-		return apply_filters( 'FHEE__EE_Messages_Template_Pack__get_specific_template__contents', $contents, $actual_path, $messenger, $message_type, $field, $context, $this );
+		return apply_filters('FHEE__EE_Messages_Template_Pack__get_specific_template__contents', $contents, $actual_path, $messenger, $message_type, $field, $context, $this);
 	}
 
 
@@ -384,8 +384,8 @@ 
 	 * @return array
 	 */
 	public function get_supports() {
-		$supports = apply_filters( 'FHEE__' . get_class( $this ) . '__get_supports', $this->_supports );
-		return apply_filters( 'FHEE__EE_Messages_Template_Pack__get_supports', $supports, $this );
+		$supports = apply_filters('FHEE__'.get_class($this).'__get_supports', $this->_supports);
+		return apply_filters('FHEE__EE_Messages_Template_Pack__get_supports', $supports, $this);
 	}
 
 
@@ -400,11 +400,11 @@ 
 	 *
 	 * @return array|string
 	 */
-	public function get_default_variation_labels( $messenger = '' ) {
-		$label = empty( $messenger ) ? $this->_default_variation_labels : array();
-		$label = empty( $label ) && ! empty( $this->_default_variation_labels[$messenger] ) ? $this->_default_variation_labels[$messenger] : __('Default', 'event_espresso');
+	public function get_default_variation_labels($messenger = '') {
+		$label = empty($messenger) ? $this->_default_variation_labels : array();
+		$label = empty($label) && ! empty($this->_default_variation_labels[$messenger]) ? $this->_default_variation_labels[$messenger] : __('Default', 'event_espresso');
 
-		return apply_filters( 'FHEE__EE_Messages_Template_Pack__get_default_variation_labels', $label, $this->_default_variation_labels, $messenger );
+		return apply_filters('FHEE__EE_Messages_Template_Pack__get_default_variation_labels', $label, $this->_default_variation_labels, $messenger);
 	}
 
 
@@ -420,25 +420,25 @@ 
 	 * @param string $message_type if included then css variations matching the message_type are returned (must have $messenger set).  Otherwise the array of variations per message type are returned.  If message_type is provided but NOT the messenger, then just all variations for all messengers are returned.
 	 * @return array
 	 */
-	public function get_variations( $messenger = '', $message_type = '' ) {
-		$messenger_variations = ! empty( $messenger ) && isset( $this->_variations[$messenger] ) ? $this->_variations[$messenger] : array();
+	public function get_variations($messenger = '', $message_type = '') {
+		$messenger_variations = ! empty($messenger) && isset($this->_variations[$messenger]) ? $this->_variations[$messenger] : array();
 
 		//message_type provided? IF so, then we've requested a specific set of variations, so we need to make sure we set it as empty if that's not present.
-		$variations = !empty( $messenger ) && !empty( $message_type ) && isset( $messenger_variations[$message_type] ) ? $messenger_variations[$message_type] : array();
+		$variations = ! empty($messenger) && ! empty($message_type) && isset($messenger_variations[$message_type]) ? $messenger_variations[$message_type] : array();
 
 		//now let's account for the possibility we just want all the variations for a messenger (which is indicated by providing the messenger but not the message type).
-		$variations = empty( $variations ) && !empty( $messenger ) && empty( $message_type ) ? $messenger_variations : $variations;
+		$variations = empty($variations) && ! empty($messenger) && empty($message_type) ? $messenger_variations : $variations;
 
 		//filter per template pack and globally.
-		$variations = apply_filters( 'FHEE__' . get_class( $this ) . '__get_variations', $variations, $messenger, $message_type );
-		$variations = apply_filters( 'FHEE__EE_Messages_Template_Pack__get_variations', $variations, $messenger, $message_type, $this );
+		$variations = apply_filters('FHEE__'.get_class($this).'__get_variations', $variations, $messenger, $message_type);
+		$variations = apply_filters('FHEE__EE_Messages_Template_Pack__get_variations', $variations, $messenger, $message_type, $this);
 
 		//prepend the _default_variation, but ONLY if we're returning the fully validated array.
-		if ( !empty( $messenger ) && !empty( $message_type ) && ! empty( $variations ) ) {
-			$variations = array( 'default' => $this->get_default_variation_labels( $messenger ) ) + $variations;
+		if ( ! empty($messenger) && ! empty($message_type) && ! empty($variations)) {
+			$variations = array('default' => $this->get_default_variation_labels($messenger)) + $variations;
 		}
 
-		return empty( $variations ) ? array( 'default' => $this->get_default_variation_labels('dft') ): $variations;
+		return empty($variations) ? array('default' => $this->get_default_variation_labels('dft')) : $variations;
 	}
 
 
@@ -459,39 +459,39 @@ 
 	 *
 	 * @return string The variation path or url (typically css reference)
 	 */
-	public function get_variation( $messenger, $message_type, $type, $variation, $url = true, $file_extension = '.css', $skip_filters = FALSE ) {
+	public function get_variation($messenger, $message_type, $type, $variation, $url = true, $file_extension = '.css', $skip_filters = FALSE) {
 
 		$base = $url ? $this->_base_url : $this->_base_path;
 		$base_path = $this->_base_path;
 
-		if ( ! $skip_filters ) {
-			$base =  apply_filters( 'FHEE__EE_Messages_Template_Pack__get_variation__base_path_or_url', $base, $messenger, $message_type, $type, $variation, $url, $file_extension, $this );
-			$base_path = apply_filters( 'FHEE__EE_Messages_Template_Pack__get_variation__base_path', $base_path, $messenger, $message_type, $type, $variation, FALSE, $file_extension, $this );
+		if ( ! $skip_filters) {
+			$base = apply_filters('FHEE__EE_Messages_Template_Pack__get_variation__base_path_or_url', $base, $messenger, $message_type, $type, $variation, $url, $file_extension, $this);
+			$base_path = apply_filters('FHEE__EE_Messages_Template_Pack__get_variation__base_path', $base_path, $messenger, $message_type, $type, $variation, FALSE, $file_extension, $this);
 		}
 
-		$default_pack = get_class( $this ) != 'EE_Messages_Template_Pack_Default' ? new EE_Messages_Template_Pack_Default() : $this;
+		$default_pack = get_class($this) != 'EE_Messages_Template_Pack_Default' ? new EE_Messages_Template_Pack_Default() : $this;
 
 		//possible variation paths considering whether message type is present or not in the file name.
-		$path_string = 'variations/' . $messenger . '_' . $message_type . '_'  . $type . '_' . $variation . $file_extension;
-		$default_path_string = 'variations/' . $messenger . '_' . $type . '_' . $variation . $file_extension;
+		$path_string = 'variations/'.$messenger.'_'.$message_type.'_'.$type.'_'.$variation.$file_extension;
+		$default_path_string = 'variations/'.$messenger.'_'.$type.'_'.$variation.$file_extension;
 
 		//first see if fully validated file exists.
-		if ( is_readable( $base_path . $path_string ) ) {
-			$variation_path = $base . $path_string;
+		if (is_readable($base_path.$path_string)) {
+			$variation_path = $base.$path_string;
 		//otherwise see if default exists.
-		} elseif ( is_readable( $base_path . $default_path_string ) ) {
-			$variation_path = $base . $default_path_string;
+		} elseif (is_readable($base_path.$default_path_string)) {
+			$variation_path = $base.$default_path_string;
 		} else {
-			$variation_path = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_default_variation( $messenger, $message_type, $type, $url, $file_extension ) : '';
+			$variation_path = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_default_variation($messenger, $message_type, $type, $url, $file_extension) : '';
 		}
 
-		if ( $skip_filters ) {
+		if ($skip_filters) {
 			return $variation_path;
 		}
 
 		//filter result
-		$variation_path = apply_filters( 'FHEE__' . get_class( $this ) . '__get_variation', $variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url );
-		return apply_filters( 'FHEE__EE_Messages_Template_Pack__get_variation', $variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url, $this );
+		$variation_path = apply_filters('FHEE__'.get_class($this).'__get_variation', $variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url);
+		return apply_filters('FHEE__EE_Messages_Template_Pack__get_variation', $variation_path, $messenger, $message_type, $type, $variation, $file_extension, $url, $this);
 	}
 
 
@@ -506,19 +506,19 @@ 
 	 *
 	 * @return string returns the path for the requested wrapper template.
 	 */
-	public function get_wrapper( $messenger, $type = 'main' ) {
-		$default_pack = get_class( $this ) !== 'EE_Messages_Template_Pack_Default' ? new EE_Messages_Template_Pack_Default() : NULL;
+	public function get_wrapper($messenger, $type = 'main') {
+		$default_pack = get_class($this) !== 'EE_Messages_Template_Pack_Default' ? new EE_Messages_Template_Pack_Default() : NULL;
 
-		$path_string = $this->_base_path . $messenger . '_' . $type . '_wrapper.template.php';
+		$path_string = $this->_base_path.$messenger.'_'.$type.'_wrapper.template.php';
 
-		if ( is_readable( $path_string ) ) {
+		if (is_readable($path_string)) {
 			$template = $path_string;
 		} else {
-			$template = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_wrapper( $messenger, $type ) : '';
+			$template = $default_pack instanceof EE_Messages_Template_Pack_Default ? $default_pack->get_wrapper($messenger, $type) : '';
 		}
 
 		//filter
-		$template = apply_filters( 'FHEE__' . get_class( $this ) . '__get_wrapper', $template, $messenger, $type );
-		return apply_filters( 'FHEE__EE_Messages_Template_Pack__get_wrapper', $template, $messenger, $type, $this );
+		$template = apply_filters('FHEE__'.get_class($this).'__get_wrapper', $template, $messenger, $type);
+		return apply_filters('FHEE__EE_Messages_Template_Pack__get_wrapper', $template, $messenger, $type, $this);
 	}
 }

Braces +6 added lines, -3 removed lines

@@ -5,7 +5,9 @@ 
  * @subpackage messages
  * @since           4.5.0
  */
-if ( ! defined('EVENT_ESPRESSO_VERSION')) exit('No direct script access allowed');
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
+}
 
 /**
  * EE_Template_Packs are classes that contain all the information related to messages templates for a given "template pack".
@@ -282,8 +284,9 @@ 
 
 		foreach ( $contexts as $context => $details ) {
 			foreach ( $fields as $field => $field_details ) {
-				if ( empty( $field_details ) )
-					continue;
+				if ( empty( $field_details ) ) {
+									continue;
+				}
 				/**
 				 * is this a field array (linked to a main field)?
 				 */

core/libraries/messages/EE_messages.lib.php

Doc Comments +7 added lines, -6 removed lines

@@ -125,9 +125,6 @@ 
 	/**
 	 * Activates the specified messenger
 	 * @param string $messenger_name
-	 * @param array $message_types (optional) An array of message types to activate with this messenger.  If
-	 *                             				included we do NOT setup the default message types (assuming
-	 *                             				they are already setup.)
 	 * @return boolean an array of generated templates or false if nothing generated/activated.
 	 */
 	public function activate_messenger( $messenger_name, $mts = array() ){
@@ -275,7 +272,7 @@ 
 	 * Used to verify if a message can be sent for the given messenger and message type and that it is a generating messenger (used for generating message templates).
 	 *
 	 * @param EE_messenger $messenger    messenger used in trigger
-	 * @param EE_messagetype $message_type message type used in trigger
+	 * @param EE_message_type $message_type message type used in trigger
 	 *
 	 * @return bool true is a generating messenger and can be sent OR FALSE meaning cannot send.
 	 */
@@ -500,7 +497,7 @@ 
 	 *
 	 * @param string       $messenger a string matching a valid active messenger in the system
 	 * @param string       $message_type   Although it seems contrary to the name of the method, a message type name is still required to send along the message type to the messenger because this is used for determining what specific variations might be loaded for the generated message.
-	 * @param stdClass $messages  a stdClass object in the format expected by the messenger.
+	 * @param stdClass $message  a stdClass object in the format expected by the messenger.
 	 *
 	 * @return bool          success or fail.
 	 */
@@ -573,6 +570,7 @@ 
 	/**
 	 * This is a wrapper for the protected _create_new_templates function
 	 * @param  string $message_type message type that the templates are being created for
+	 * @param string $messenger
 	 * @return array|object               if creation is succesful then we return an array of info, otherwise an error_object is returned.
 	 */
 	public function create_new_templates( $messenger, $message_type, $GRP_ID = 0, $is_global = false ) {
@@ -594,6 +592,10 @@ 
 		return $this->_create_new_templates($GRP_ID, $is_global);
 	}
 
+	/**
+	 * @param integer $GRP_ID
+	 * @param boolean $is_global
+	 */
 	protected function _create_new_templates($GRP_ID, $is_global) {
 
 		//if we're creating a custom template then we don't need to use the defaults class
@@ -713,7 +715,6 @@ 
 	 *
 	 * @access public
 	 * @param string $type we can indicate just returning installed message types or messengers (or both) via this parameter.
-	 * @param bool  $set if true then we skip the cache and retrieve via files.
 	 * @return array multidimensional array of messenger and message_type objects (messengers index, and message_type index);
 	 */
 	public function get_installed( $type = 'all', $skip_cache = false ) {

Indentation +1 added lines, -1 removed lines

@@ -302,7 +302,7 @@
 	 * @param  string $sending_messenger if included then we ONLY use the specified messenger for delivery.  Otherwise we cycle through all active messengers.
 	 * @param string $generating_messenger if included then this messenger is used for generating the message templates (but not for sending).
 	 * @param string $context If included then only a message type for a specific context will be generated.
-	  * @param bool  $send 			       Default TRUE.  If false, then this will just return the generated EE_Messages objects which might be used by the trigger to setup a batch message (typically html messenger uses it).
+	 * @param bool  $send 			       Default TRUE.  If false, then this will just return the generated EE_Messages objects which might be used by the trigger to setup a batch message (typically html messenger uses it).
 	 * @return bool
 	 */
 	public function send_message( $type, $vars, $sending_messenger = '', $generating_messenger='', $context='', $send = TRUE ) {

Braces +27 added lines, -16 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('EVENT_ESPRESSO_VERSION') )
+if (!defined('EVENT_ESPRESSO_VERSION') ) {
 	exit('NO direct script access allowed');
+}
 
 /**
  * Event Espresso
@@ -90,7 +91,7 @@ 
 		if( ! isset( $active_messengers[ $messenger_name ] ) ) {
 			$this->activate_messenger( $messenger_name );
 			return FALSE;
-		}else{
+		} else{
 			return TRUE;
 		}
 	}
@@ -207,7 +208,9 @@ 
 	private function _load_files($kind, $actives) {
 		$active_names = array();
 		$base_path = EE_LIBRARIES . 'messages' . DS . $kind . DS;
-		if ( empty($actives) ) return false;
+		if ( empty($actives) ) {
+			return false;
+		}
 
 		//make sure autoloaders are set (failsafe)
 		EED_Messages::set_autoloaders();
@@ -418,8 +421,9 @@ 
 			if ( isset( $this->_active_messengers[$messenger] ) ) {
 
 				//we ONLY continue if the given messenger has that message type active with it (note previews only come from primary messengers so no need to check secondarys)
-				if ( !isset( $this->_active_message_types[$messenger][$type] ) )
-					return false;
+				if ( !isset( $this->_active_message_types[$messenger][$type] ) ) {
+									return false;
+				}
 
 				$message = $installed_message_types[$type];
 				$messenger = $this->_active_messengers[$messenger];
@@ -553,8 +557,9 @@ 
 
 
 		//do we have the necessary objects loaded?
-		if ( empty( $this->_messenger) || empty($this->_message_type) )
-			throw new EE_Error( sprintf( __(' The %s messenger or the %s message_type are not active. Are you sure they exist?', 'event_espresso'), $messenger, $message_type ) );
+		if ( empty( $this->_messenger) || empty($this->_message_type) ) {
+					throw new EE_Error( sprintf( __(' The %s messenger or the %s message_type are not active. Are you sure they exist?', 'event_espresso'), $messenger, $message_type ) );
+		}
 
 		//is given message_type valid for given messenger (if this is not a global save)
 		$types_to_check = array();
@@ -597,8 +602,9 @@ 
 	protected function _create_new_templates($GRP_ID, $is_global) {
 
 		//if we're creating a custom template then we don't need to use the defaults class
-		if ( ! $is_global )
-			return $this->_create_custom_template_group( $GRP_ID );
+		if ( ! $is_global ) {
+					return $this->_create_custom_template_group( $GRP_ID );
+		}
 
 		$DFLT = new EE_Message_Template_Defaults( $this, $this->_messenger->name, $this->_message_type->name, $GRP_ID );
 
@@ -663,14 +669,16 @@ 
 
 		//add new message templates and add relation to.
 		foreach ( $mtts as $mtt ) {
-			if ( ! $mtt instanceof EE_Message_Template )
-				continue;
+			if ( ! $mtt instanceof EE_Message_Template ) {
+							continue;
+			}
 			$nmtt = clone $mtt;
 			$nmtt->set('MTP_ID', 0);
 			$nmtt->set( 'GRP_ID', $new_mtg->ID() ); //relation
 			$nmtt->save();
-			if ( empty( $success['MTP_context'] ) )
-				$success['MTP_context'] = $nmtt->get('MTP_context');
+			if ( empty( $success['MTP_context'] ) ) {
+							$success['MTP_context'] = $nmtt->get('MTP_context');
+			}
 		}
 
 		return $success;
@@ -761,7 +769,9 @@ 
 			$classname = preg_match("/" . $replace . "/", $filename ) ? str_replace($replace, "", $filename) : false;
 
 			//no classname? no match? move along, nothing to see here. note, the stripos is checking to make sure the filename (classname) begins with EE.
-			if ( !$classname || 0 !== stripos($classname, 'EE') ) continue;
+			if ( !$classname || 0 !== stripos($classname, 'EE') ) {
+				continue;
+			}
 
 			//note: I'm not sure if this will work without including the file.  We do have autoloaders so it "may" work.
 			$a = new ReflectionClass($classname);
@@ -786,8 +796,9 @@ 
 		$message_types = array();
 		foreach ( $this->_active_message_types as $messenger => $mtvalues ) {
 			foreach ( $mtvalues as $mt => $config ) {
-				if ( !in_array( $mt, $message_types ) )
-					$message_types[] = $mt;
+				if ( !in_array( $mt, $message_types ) ) {
+									$message_types[] = $mt;
+				}
 			}
 		}
 

Spacing +163 added lines, -163 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (!defined('EVENT_ESPRESSO_VERSION') )
+if ( ! defined('EVENT_ESPRESSO_VERSION'))
 	exit('NO direct script access allowed');
 
 /**
@@ -63,17 +63,17 @@ 
 		$actives = is_array($_actives) ? array_keys($_actives) : $_actives;
 		$active_names = $this->_load_files('messenger', $actives);
 
-		if ( is_array($active_names) ) {
-			foreach ( $active_names as $name => $class ) {
-				$a = new ReflectionClass( $class );
+		if (is_array($active_names)) {
+			foreach ($active_names as $name => $class) {
+				$a = new ReflectionClass($class);
 				$active = $a->newInstance();
-				if ( is_wp_error($active) ) {
+				if (is_wp_error($active)) {
 					//we've got an error so let's bubble up the error_object to be caught by caller.
 					//todo: would be better to just catch the errors and then return any aggregated errors later.
 					EE_Error::add_error($active->get_error_message(), __FILE__, __FUNCTION__, __LINE__);
 				}
 				$this->_active_messengers[$name] = $active;
-				$this->_active_message_types[$name] = ! empty( $_actives[$name]['settings'][$name . '-message_types'] ) ? $_actives[$name]['settings'][$name . '-message_types'] : array();
+				$this->_active_message_types[$name] = ! empty($_actives[$name]['settings'][$name.'-message_types']) ? $_actives[$name]['settings'][$name.'-message_types'] : array();
 			}
 		}
 	}
@@ -84,13 +84,13 @@ 
 	 * @param string $messenger_name
 	 * @return boolean TRUE if it was PREVIOUSLY active, and FALSE if it was previously inactive
 	 */
-	public function ensure_messenger_is_active( $messenger_name ){
+	public function ensure_messenger_is_active($messenger_name) {
 		//note: active messengers indexed by their names
 		$active_messengers = EEH_MSG_Template::get_active_messengers_in_db();
-		if( ! isset( $active_messengers[ $messenger_name ] ) ) {
-			$this->activate_messenger( $messenger_name );
+		if ( ! isset($active_messengers[$messenger_name])) {
+			$this->activate_messenger($messenger_name);
 			return FALSE;
-		}else{
+		} else {
 			return TRUE;
 		}
 	}
@@ -105,21 +105,21 @@ 
 	 *
 	 * @return boolean true if it got activated (or was active) and false if not.
 	 */
-	public function ensure_message_type_is_active( $message_type, $messenger ) {
+	public function ensure_message_type_is_active($message_type, $messenger) {
 		//first validate that the incoming messenger allows this message type to be activated.
 		$messengers = $this->get_installed_messengers();
-		if ( ! isset( $messengers[$messenger] ) ) {
-			throw new EE_Error( sprintf( __('The messenger sent to %s is not installed', 'event_espresso'), __METHOD__ ) );
+		if ( ! isset($messengers[$messenger])) {
+			throw new EE_Error(sprintf(__('The messenger sent to %s is not installed', 'event_espresso'), __METHOD__));
 		}
 
 		$msgr = $messengers[$messenger];
 		$valid_message_types = $msgr->get_valid_message_types();
-		if ( ! in_array( $message_type, $valid_message_types ) ) {
-			throw new EE_Error( sprint_f( __('The message type ($1%s) sent to $2%s is not valid for the $3%s messenger.  Doublecheck the spelling and verify that message type has been registered as a valid type with the messenger.', 'event_espresso' ), $message_type, __METHOD__, $messenger ) );
+		if ( ! in_array($message_type, $valid_message_types)) {
+			throw new EE_Error(sprint_f(__('The message type ($1%s) sent to $2%s is not valid for the $3%s messenger.  Doublecheck the spelling and verify that message type has been registered as a valid type with the messenger.', 'event_espresso'), $message_type, __METHOD__, $messenger));
 		}
 
 		//all is good so let's just get it active
-		return $this->activate_messenger( $messenger, array( $message_type ) );
+		return $this->activate_messenger($messenger, array($message_type));
 	}
 
 	/**
@@ -130,7 +130,7 @@ 
 	 *                             				they are already setup.)
 	 * @return boolean an array of generated templates or false if nothing generated/activated.
 	 */
-	public function activate_messenger( $messenger_name, $mts = array() ){
+	public function activate_messenger($messenger_name, $mts = array()) {
 		$active_messengers = EEH_MSG_Template::get_active_messengers_in_db();
 		$message_types = $this->get_installed_message_types();
 		$installed_messengers = $this->get_installed_messengers();
@@ -138,33 +138,33 @@ 
 		$templates = false;
 
 		//get has_active so we can be sure its kept up to date.
-		$has_activated = get_option( 'ee_has_activated_messenger' );
+		$has_activated = get_option('ee_has_activated_messenger');
 
 		//grab the messenger to work with.
-		$messenger = isset( $installed_messengers[$messenger_name] ) ? $installed_messengers[$messenger_name] : null;
+		$messenger = isset($installed_messengers[$messenger_name]) ? $installed_messengers[$messenger_name] : null;
 
 		//it's inactive. Activate it.
 
-		if( $messenger instanceof EE_messenger ) {
-			$active_messengers[ $messenger->name ][ 'obj' ] = $messenger;
+		if ($messenger instanceof EE_messenger) {
+			$active_messengers[$messenger->name]['obj'] = $messenger;
 
 			/** @var EE_messenger[] $installed_messengers  */
-			$mts_to_activate = ! empty( $mts ) ? $mts :  $messenger->get_default_message_types();
-			foreach ( $mts_to_activate as $message_type ) {
+			$mts_to_activate = ! empty($mts) ? $mts : $messenger->get_default_message_types();
+			foreach ($mts_to_activate as $message_type) {
 				//we need to setup any initial settings for message types
 				/** @var EE_message_type[] $installed_mts */
-				$settings_fields = isset( $message_types[$message_type] ) ? $message_types[ $message_type ]->get_admin_settings_fields() : array();
-				if ( !empty( $settings_fields ) ) {
-					foreach ( $settings_fields as $field => $values ) {
-						$settings[$field] = $values[ 'default' ];
+				$settings_fields = isset($message_types[$message_type]) ? $message_types[$message_type]->get_admin_settings_fields() : array();
+				if ( ! empty($settings_fields)) {
+					foreach ($settings_fields as $field => $values) {
+						$settings[$field] = $values['default'];
 					}
 				} else {
 					$settings = array();
 				}
 
-				$active_messengers[ $messenger->name ][ 'settings' ][ $messenger->name . '-message_types' ][ $message_type ][ 'settings' ] = $settings;
+				$active_messengers[$messenger->name]['settings'][$messenger->name.'-message_types'][$message_type]['settings'] = $settings;
 
-				if (  ! empty( $has_activated[$messenger->name] ) && ! in_array( $message_type, $has_activated[$messenger->name] ) ) {
+				if ( ! empty($has_activated[$messenger->name]) && ! in_array($message_type, $has_activated[$messenger->name])) {
 					$has_activated[$messenger->name][] = $message_type;
 				}
 			}
@@ -172,22 +172,22 @@ 
 			//setup any initial settings for the messenger
 			$msgr_settings = $messenger->get_admin_settings_fields();
 
-			if ( !empty( $msgr_settings ) ) {
-				foreach ( $msgr_settings as $field => $value ) {
-					$active_messengers[ $messenger->name ][ 'settings' ][ $field ] = $value;
+			if ( ! empty($msgr_settings)) {
+				foreach ($msgr_settings as $field => $value) {
+					$active_messengers[$messenger->name]['settings'][$field] = $value;
 				}
 			}
 
-			EEH_MSG_Template::update_active_messengers_in_db( $active_messengers );
-			update_option( 'ee_has_activated_messenger', $has_activated );
+			EEH_MSG_Template::update_active_messengers_in_db($active_messengers);
+			update_option('ee_has_activated_messenger', $has_activated);
 
 			//make sure that the cached active_messengers is set on this object
 			$this->_active_messengers[$messenger->name] = $messenger;
 			$this->_active_message_types[$messenger->name] = $active_messengers[$messenger->name];
 
 			//might need to generate new templates
-			if ( ! empty( $mts_to_activate ) ) {
-				$templates = EEH_MSG_Template::generate_new_templates( $messenger->name, $mts_to_activate, 0, TRUE );
+			if ( ! empty($mts_to_activate)) {
+				$templates = EEH_MSG_Template::generate_new_templates($messenger->name, $mts_to_activate, 0, TRUE);
 			}
 		}
 
@@ -206,8 +206,8 @@ 
 	 */
 	private function _load_files($kind, $actives) {
 		$active_names = array();
-		$base_path = EE_LIBRARIES . 'messages' . DS . $kind . DS;
-		if ( empty($actives) ) return false;
+		$base_path = EE_LIBRARIES.'messages'.DS.$kind.DS;
+		if (empty($actives)) return false;
 
 		//make sure autoloaders are set (failsafe)
 		EED_Messages::set_autoloaders();
@@ -215,18 +215,18 @@ 
 		//make sure $actives is an array
 		$actives = (array) $actives;
 
-		EE_Registry::instance()->load_helper( 'File' );
-		foreach ( $actives as $active ) {
-			$msg_name = 'EE_' . ucwords( str_replace( ' ', '_', $active) ) . '_' . $kind;
-			$filename = $msg_name . '.class.php';
-			$load_file = $base_path . DS . $filename;
-			if ( is_readable($load_file) ) {
+		EE_Registry::instance()->load_helper('File');
+		foreach ($actives as $active) {
+			$msg_name = 'EE_'.ucwords(str_replace(' ', '_', $active)).'_'.$kind;
+			$filename = $msg_name.'.class.php';
+			$load_file = $base_path.DS.$filename;
+			if (is_readable($load_file)) {
 				require_once($load_file);
 				$active_names[$active] = $msg_name;
 			} else {
 				$this->_unset_active($active, $kind);
 				//set WP_Error
-				return EE_Error::add_error( sprintf( __("Missing messages system file set as inactive: (%s) %s has been made inactive.", 'event_espresso'), $load_file, $msg_name), __FILE__, __FUNCTION__, __LINE__ );
+				return EE_Error::add_error(sprintf(__("Missing messages system file set as inactive: (%s) %s has been made inactive.", 'event_espresso'), $load_file, $msg_name), __FILE__, __FUNCTION__, __LINE__);
 			}
 		}
 		return $active_names;
@@ -243,25 +243,25 @@ 
 	 * @param  string $kind        messenger or message_type?
 	 * @return void
 	 */
-	private function _unset_active( $active_name, $kind ) {
+	private function _unset_active($active_name, $kind) {
 		//pluralize
 		$active_messengers = EEH_MSG_Template::get_active_messengers_in_db();
-		EE_Registry::instance()->load_helper( 'MSG_Template' );
-		if ( $kind == 'messenger' ) {
-			unset( $active_messengers[$active_name] );
-			EEH_MSG_Template::update_to_inactive( $active_name );
-			if ( isset( $this->_active_messengers[$active_name] ) ) {
-				unset( $this->_active_messengers[$active_name] );
+		EE_Registry::instance()->load_helper('MSG_Template');
+		if ($kind == 'messenger') {
+			unset($active_messengers[$active_name]);
+			EEH_MSG_Template::update_to_inactive($active_name);
+			if (isset($this->_active_messengers[$active_name])) {
+				unset($this->_active_messengers[$active_name]);
 			}
 		} else {
-			foreach( $active_messengers as $messenger => $settings ) {
-				if ( ! empty( $settings['settings'][$messenger . '-message_types'][$active_name] ) ) {
-					unset( $active_messengers[$messenger]['settings'][$messenger . '-message_types'][$active_name] );
+			foreach ($active_messengers as $messenger => $settings) {
+				if ( ! empty($settings['settings'][$messenger.'-message_types'][$active_name])) {
+					unset($active_messengers[$messenger]['settings'][$messenger.'-message_types'][$active_name]);
 				}
 			}
-			EEH_MSG_Template::update_to_inactive( '', $active_name );
-			if ( isset( $this->_active_message_types[$active_name] ) ) {
-				unset( $this->_active_message_types[$active_name] );
+			EEH_MSG_Template::update_to_inactive('', $active_name);
+			if (isset($this->_active_message_types[$active_name])) {
+				unset($this->_active_message_types[$active_name]);
 			}
 		}
 
@@ -279,13 +279,13 @@ 
 	 *
 	 * @return bool true is a generating messenger and can be sent OR FALSE meaning cannot send.
 	 */
-	private function _is_generating_messenger_and_active( EE_messenger $messenger, EE_message_type $message_type ) {
+	private function _is_generating_messenger_and_active(EE_messenger $messenger, EE_message_type $message_type) {
 		$generating_msgrs = array();
 		//get the $messengers the message type says it can be used with.
 		$used_with = $message_type->with_messengers();
 
-		foreach ( $used_with as $generating_msgr => $secondary_msgrs ) {
-			if ( $messenger->name == $generating_msgr && isset( $this->_active_message_types[$generating_msgr][$message_type->name] ) ) {
+		foreach ($used_with as $generating_msgr => $secondary_msgrs) {
+			if ($messenger->name == $generating_msgr && isset($this->_active_message_types[$generating_msgr][$message_type->name])) {
 				return true;
 			}
 		}
@@ -305,17 +305,17 @@ 
 	  * @param bool  $send 			       Default TRUE.  If false, then this will just return the generated EE_Messages objects which might be used by the trigger to setup a batch message (typically html messenger uses it).
 	 * @return bool
 	 */
-	public function send_message( $type, $vars, $sending_messenger = '', $generating_messenger='', $context='', $send = TRUE ) {
+	public function send_message($type, $vars, $sending_messenger = '', $generating_messenger = '', $context = '', $send = TRUE) {
 
 		$error = FALSE;
 		$installed_message_types = $this->get_installed_message_types();
-		$debug_index = 'Messages: ' . $type;
-		foreach ( $vars as $var ) {
-			if ( method_exists( $var, 'ID' ) ) {
-				$debug_index = get_class( $var ) .  ': ' . $var->ID();
+		$debug_index = 'Messages: '.$type;
+		foreach ($vars as $var) {
+			if (method_exists($var, 'ID')) {
+				$debug_index = get_class($var).': '.$var->ID();
 				break;
-			} else if ( is_object( $var )) {
-				$debug_index = spl_object_hash( $var );
+			} else if (is_object($var)) {
+				$debug_index = spl_object_hash($var);
 			}
 		}
 		//EEH_Debug_Tools::log(
@@ -334,34 +334,34 @@ 
 		//);
 
 		// is that a real class ?
-		if ( isset(  $installed_message_types[$type] ) ) {
+		if (isset($installed_message_types[$type])) {
 			//is the messenger specified? If so then let's see if can send.  This is the check where its possible secondary messengers might be in use.
-			if ( !empty ( $sending_messenger ) ) {
-				$generating_messenger =  !empty( $generating_messenger ) && !empty( $this->_active_messengers[$generating_messenger] ) ? $this->_active_messengers[$generating_messenger]: NULL;
-				$generating_messenger = empty( $generating_messenger ) && ! empty( $this->_active_messengers[$sending_messenger] ) ? $this->_active_messengers[$sending_messenger] : $generating_messenger;
+			if ( ! empty ($sending_messenger)) {
+				$generating_messenger = ! empty($generating_messenger) && ! empty($this->_active_messengers[$generating_messenger]) ? $this->_active_messengers[$generating_messenger] : NULL;
+				$generating_messenger = empty($generating_messenger) && ! empty($this->_active_messengers[$sending_messenger]) ? $this->_active_messengers[$sending_messenger] : $generating_messenger;
 
-				if ( !$this->_is_generating_messenger_and_active( $generating_messenger, $installed_message_types[$type] ) ) {
+				if ( ! $this->_is_generating_messenger_and_active($generating_messenger, $installed_message_types[$type])) {
 					return false;
 				}
-				$sending_messenger = ! empty( $this->_active_messengers[$sending_messenger] ) ? $this->_active_messengers[$sending_messenger] : NULL;
+				$sending_messenger = ! empty($this->_active_messengers[$sending_messenger]) ? $this->_active_messengers[$sending_messenger] : NULL;
 
-				$context = !empty( $context ) ? $context : FALSE;
-				$success = $this->_send_message( $generating_messenger, $installed_message_types[$type], $vars, $sending_messenger, $context, $send );
-				if ( ! $send ) {
+				$context = ! empty($context) ? $context : FALSE;
+				$success = $this->_send_message($generating_messenger, $installed_message_types[$type], $vars, $sending_messenger, $context, $send);
+				if ( ! $send) {
 					return $success; //returning generated EE_Messages objects
 				}
 			} else {
 				//no messenger sent so let's just loop through active messengers (this method is only acceptable for primary messengers)
 				$send_messages = array();
-				foreach ( $this->_active_messengers as $active_messenger ) {
+				foreach ($this->_active_messengers as $active_messenger) {
 
 					//we ONLY continue if the given messenger is a primary messenger and is an active messenger for the given message type.  Otherwise we skip.
-					if ( ! $this->_is_generating_messenger_and_active( $active_messenger, $installed_message_types[$type] ) ) {
+					if ( ! $this->_is_generating_messenger_and_active($active_messenger, $installed_message_types[$type])) {
 						continue;
 					}
 
-					$success = $this->_send_message( $active_messenger, $installed_message_types[$type], $vars, $active_messenger );
-					if ( $success === FALSE  ) {
+					$success = $this->_send_message($active_messenger, $installed_message_types[$type], $vars, $active_messenger);
+					if ($success === FALSE) {
 						$error = TRUE;
 					} else {
 						$send_messages[] = $success;
@@ -381,17 +381,17 @@ 
 				//	);
 
 				//return generated EE_Messages objects?
-				if ( ! $send ) {
+				if ( ! $send) {
 					return $send_messages;
 				}
 			}
 		} else {
-			EE_Error::add_error( sprintf( __('Message type: %s does not exist', 'event_espresso'), $type ), __FILE__, __FUNCTION__, __LINE__ );
+			EE_Error::add_error(sprintf(__('Message type: %s does not exist', 'event_espresso'), $type), __FILE__, __FUNCTION__, __LINE__);
 			return false;
 		}
 		// add a success message
-		if ( ! $error ) {
-			EE_Error::add_success( sprintf( __( 'The %s message has been successfully sent.', 'event_espresso'), $installed_message_types[$type]->label['singular'] ), __FILE__, __FUNCTION__, __LINE__ );
+		if ( ! $error) {
+			EE_Error::add_success(sprintf(__('The %s message has been successfully sent.', 'event_espresso'), $installed_message_types[$type]->label['singular']), __FILE__, __FUNCTION__, __LINE__);
 		}
 
 		return $error ? FALSE : TRUE; //yeah backwards eh?  Really what we're returning is if there is a total success for all the messages or not.  We'll modify this once we get message recording in place.
@@ -408,35 +408,35 @@ 
 	 * @param bool 	$send true we will do a test send using the messenger delivery, false we just do a regular preview
 	 * @return string          The body of the message.
 	 */
-	public function preview_message( $type, $context, $messenger, $send = FALSE ) {
+	public function preview_message($type, $context, $messenger, $send = FALSE) {
 
 		$installed_message_types = $this->get_installed_message_types();
 
 		//does the given type match an actual message type class.
-		if ( isset(  $installed_message_types[$type] ) ) {
+		if (isset($installed_message_types[$type])) {
 			// valid messenger?
-			if ( isset( $this->_active_messengers[$messenger] ) ) {
+			if (isset($this->_active_messengers[$messenger])) {
 
 				//we ONLY continue if the given messenger has that message type active with it (note previews only come from primary messengers so no need to check secondarys)
-				if ( !isset( $this->_active_message_types[$messenger][$type] ) )
+				if ( ! isset($this->_active_message_types[$messenger][$type]))
 					return false;
 
 				$message = $installed_message_types[$type];
 				$messenger = $this->_active_messengers[$messenger];
 
 				//set data for preview
-				$message->set_messages( array(), $messenger, $context, TRUE );
+				$message->set_messages(array(), $messenger, $context, TRUE);
 
 				//let's GET the message body from the messenger (instead of the normal send_message)
-				return $messenger->get_preview( $message->messages[0], $message, $send );
+				return $messenger->get_preview($message->messages[0], $message, $send);
 
 			} else {
-				EE_Error::add_error( sprintf( __('Messenger: %s does not exist', 'event_espresso'), $messenger ), __FILE__, __FUNCTION__, __LINE__ );
+				EE_Error::add_error(sprintf(__('Messenger: %s does not exist', 'event_espresso'), $messenger), __FILE__, __FUNCTION__, __LINE__);
 				return FALSE;
 			}
 
 		} else {
-			EE_Error::add_error( sprintf( __('Message type: %s does not exist', 'event_espresso'), $type ), __FILE__, __FUNCTION__, __LINE__ );
+			EE_Error::add_error(sprintf(__('Message type: %s does not exist', 'event_espresso'), $type), __FILE__, __FUNCTION__, __LINE__);
 			return FALSE;
 		}
 
@@ -457,22 +457,22 @@ 
 	 *
 	 * @return mixed(bool|std_Class[])
 	 */
-	private function _send_message( EE_messenger $generating_messenger, EE_message_type $message_type, $data, EE_messenger $sending_messenger, $context = FALSE, $send = TRUE ) {
+	private function _send_message(EE_messenger $generating_messenger, EE_message_type $message_type, $data, EE_messenger $sending_messenger, $context = FALSE, $send = TRUE) {
 		//can't even get started yo!
-		if ( $message_type === FALSE || is_wp_error( $message_type ) || $message_type->set_messages( $data, $generating_messenger, $context ) === FALSE ) {
+		if ($message_type === FALSE || is_wp_error($message_type) || $message_type->set_messages($data, $generating_messenger, $context) === FALSE) {
 			return FALSE;
 		}
 		// if the generating messenger and the sending messengers are different...
 		// then are there any hooks that the generating messenger sets for the sending messenger (i.e. css file swap outs etc.)
-		if ( $sending_messenger != $generating_messenger ) {
-			$generating_messenger->do_secondary_messenger_hooks( $sending_messenger->name );
+		if ($sending_messenger != $generating_messenger) {
+			$generating_messenger->do_secondary_messenger_hooks($sending_messenger->name);
 		}
 		//it is possible that the user has the messenger turned off for this type.
-		if ( $message_type->count === 0 ) {
+		if ($message_type->count === 0) {
 			return FALSE;
 		}
 		//are we just sending the EE_Messages stdClass objects back?
-		if ( ! $send ) {
+		if ( ! $send) {
 			return $message_type->messages;
 		}
 		//TODO: check count (at some point we'll use this to decide whether we send to queue or not i.e.
@@ -480,12 +480,12 @@ 
 		//else...
 		$success = TRUE;
 		// $success is a flag for the loop.  If there is NO error then everything is a success (true) otherwise it wasn't a success (false)
-		foreach ( $message_type->messages as $message ) {
+		foreach ($message_type->messages as $message) {
 			//todo: should we do some reporting on messages gone out at some point?  I think we could have the $active_messenger object return bool for whether message was sent or not and we can compile a report based on that.
 			// if messages send successfully then $success retains it's value, but a single fail will toggle it to FALSE
-			$success = $sending_messenger->send_message( $message, $message_type ) === TRUE ? $success : FALSE;
+			$success = $sending_messenger->send_message($message, $message_type) === TRUE ? $success : FALSE;
 		}
-		unset( $message_type );
+		unset($message_type);
 		return $success;
 	}
 
@@ -504,24 +504,24 @@ 
 	 *
 	 * @return bool          success or fail.
 	 */
-	public function send_message_with_messenger_only( $messenger, $message_type, $message ) {
+	public function send_message_with_messenger_only($messenger, $message_type, $message) {
 
 		//get EE_messenger object (which also checks if its active)
-		$msgr =  !empty( $messenger ) && !empty( $this->_active_messengers[$messenger] ) ? $this->_active_messengers[$messenger]: NULL;
+		$msgr = ! empty($messenger) && ! empty($this->_active_messengers[$messenger]) ? $this->_active_messengers[$messenger] : NULL;
 		$installed_message_types = $this->get_installed_message_types();
 
-		if ( ! $msgr instanceof EE_messenger ) {
+		if ( ! $msgr instanceof EE_messenger) {
 			return false; //can't do anything without a valid messenger.
 		}
 
 		//check valid message type
-		$mtype = isset(  $installed_message_types[$message_type] ) ? $installed_message_types[$message_type] : NULL;
+		$mtype = isset($installed_message_types[$message_type]) ? $installed_message_types[$message_type] : NULL;
 
-		if( ! $mtype instanceof EE_message_type ) {
+		if ( ! $mtype instanceof EE_message_type) {
 			return false; //can't do anything without a valid message type.
 		}
 
-		return $msgr->send_message( $message, $mtype );
+		return $msgr->send_message($message, $mtype);
 	}
 
 
@@ -537,7 +537,7 @@ 
 	 */
 	private function _validate_setup($messenger, $message_type, $is_global = FALSE) {
 
-		$message_type = strtolower(str_replace(' ', '_', $message_type) );
+		$message_type = strtolower(str_replace(' ', '_', $message_type));
 		$messenger = strtolower(str_replace(' ', '_', $messenger));
 		$installed_message_types = $this->get_installed_message_types();
 
@@ -553,16 +553,16 @@ 
 
 
 		//do we have the necessary objects loaded?
-		if ( empty( $this->_messenger) || empty($this->_message_type) )
-			throw new EE_Error( sprintf( __(' The %s messenger or the %s message_type are not active. Are you sure they exist?', 'event_espresso'), $messenger, $message_type ) );
+		if (empty($this->_messenger) || empty($this->_message_type))
+			throw new EE_Error(sprintf(__(' The %s messenger or the %s message_type are not active. Are you sure they exist?', 'event_espresso'), $messenger, $message_type));
 
 		//is given message_type valid for given messenger (if this is not a global save)
 		$types_to_check = array();
-		if ( !$is_global ) {
-			$has_active = EEM_Message_Template_Group::instance()->count( array( array( 'MTP_is_active' => TRUE, 'MTP_messenger' => $this->_messenger->name, 'MTP_message_type' => $message_type ) ) );
+		if ( ! $is_global) {
+			$has_active = EEM_Message_Template_Group::instance()->count(array(array('MTP_is_active' => TRUE, 'MTP_messenger' => $this->_messenger->name, 'MTP_message_type' => $message_type)));
 
-			if ( $has_active == 0 ) {
-				EE_Error::add_error( sprintf(__(' The %s message type is not registered with the %s messenger. Please visit the Messenger activation page to assign this message type first if you want to use it.', 'event_espresso'), $message_type, $messenger), __FILE__, __FUNCTION__, __LINE__ );
+			if ($has_active == 0) {
+				EE_Error::add_error(sprintf(__(' The %s message type is not registered with the %s messenger. Please visit the Messenger activation page to assign this message type first if you want to use it.', 'event_espresso'), $message_type, $messenger), __FILE__, __FUNCTION__, __LINE__);
 				return false;
 			}
 
@@ -575,17 +575,17 @@ 
 	 * @param  string $message_type message type that the templates are being created for
 	 * @return array|object               if creation is succesful then we return an array of info, otherwise an error_object is returned.
 	 */
-	public function create_new_templates( $messenger, $message_type, $GRP_ID = 0, $is_global = false ) {
+	public function create_new_templates($messenger, $message_type, $GRP_ID = 0, $is_global = false) {
 		$valid_mt = false;
 
 		$valid_mt = $this->_validate_setup($messenger, $message_type, $is_global);
 
-		if ( is_wp_error($valid_mt) && $is_global ) {
+		if (is_wp_error($valid_mt) && $is_global) {
 			//we're setting up a brand new global templates (with messenger activation) so we're assuming that the message types sent in are valid.
 			$valid_mt = true;
 		}
 
-		if ( is_wp_error($valid_mt) ) {
+		if (is_wp_error($valid_mt)) {
 			//if we've still got no valid_mt then bubble up error object
 			return $valid_mt;
 		}
@@ -597,10 +597,10 @@ 
 	protected function _create_new_templates($GRP_ID, $is_global) {
 
 		//if we're creating a custom template then we don't need to use the defaults class
-		if ( ! $is_global )
-			return $this->_create_custom_template_group( $GRP_ID );
+		if ( ! $is_global)
+			return $this->_create_custom_template_group($GRP_ID);
 
-		$DFLT = new EE_Message_Template_Defaults( $this, $this->_messenger->name, $this->_message_type->name, $GRP_ID );
+		$DFLT = new EE_Message_Template_Defaults($this, $this->_messenger->name, $this->_message_type->name, $GRP_ID);
 
 		//generate templates
 		$success = $DFLT->create_new_templates();
@@ -628,16 +628,16 @@ 
 	 *                                     			)
 	 * @access private
 	 */
-	private function _create_custom_template_group( $GRP_ID ) {
+	private function _create_custom_template_group($GRP_ID) {
 		//defaults
-		$success = array( 'GRP_ID' => NULL, 'MTP_context' => '' );
+		$success = array('GRP_ID' => NULL, 'MTP_context' => '');
 
 		//get the template group to use as a template from the db.  If $GRP_ID is empty then we'll assume the base will be the global template matching the messenger and message type.
-		$mtg = empty( $GRP_ID ) ? EEM_Message_Template_Group::instance()->get_one( array( array( 'MTP_messenger' => $this->_messenger->name, 'MTP_message_type' => $this->_message_type->name, 'MTP_is_global' => TRUE ) ) ) : EEM_Message_Template_Group::instance()->get_one_by_ID( $GRP_ID );
+		$mtg = empty($GRP_ID) ? EEM_Message_Template_Group::instance()->get_one(array(array('MTP_messenger' => $this->_messenger->name, 'MTP_message_type' => $this->_message_type->name, 'MTP_is_global' => TRUE))) : EEM_Message_Template_Group::instance()->get_one_by_ID($GRP_ID);
 
 		//if we don't have a mtg at this point then we need to bail.
-		if ( ! $mtg instanceof EE_Message_Template_Group ) {
-			EE_Error::add_error( sprintf( __('Something went wrong with generating the custom template from this group id: %s.  This usually happens when there is no matching message template group in the db.', 'event_espresso'), $GRP_ID ), __FILE__, __FUNCTION__, __LINE__ );
+		if ( ! $mtg instanceof EE_Message_Template_Group) {
+			EE_Error::add_error(sprintf(__('Something went wrong with generating the custom template from this group id: %s.  This usually happens when there is no matching message template group in the db.', 'event_espresso'), $GRP_ID), __FILE__, __FUNCTION__, __LINE__);
 			return $success;
 		}
 
@@ -649,27 +649,27 @@ 
 		$new_mtg->set('GRP_ID', 0);
 		$new_mtg->set('MTP_is_global', FALSE);
 
-		$template_name = defined('DOING_AJAX') && !empty( $_POST['templateName'] ) ? $_POST['templateName'] : __('New Custom Template', 'event_espresso');
-		$template_description = defined("DOING_AJAX") && !empty( $_POST['templateDescription'] ) ? $_POST['templateDescription'] : sprintf( __('This is a custom template that was created for the %s messenger and %s message type.', 'event_espresso' ), $new_mtg->messenger_obj()->label['singular'], $new_mtg->message_type_obj()->label['singular'] );
+		$template_name = defined('DOING_AJAX') && ! empty($_POST['templateName']) ? $_POST['templateName'] : __('New Custom Template', 'event_espresso');
+		$template_description = defined("DOING_AJAX") && ! empty($_POST['templateDescription']) ? $_POST['templateDescription'] : sprintf(__('This is a custom template that was created for the %s messenger and %s message type.', 'event_espresso'), $new_mtg->messenger_obj()->label['singular'], $new_mtg->message_type_obj()->label['singular']);
 
 
-		$new_mtg->set('MTP_name', $template_name );
-		$new_mtg->set('MTP_description', $template_description );
+		$new_mtg->set('MTP_name', $template_name);
+		$new_mtg->set('MTP_description', $template_description);
 		//remove ALL relations on this template group so they don't get saved!
-		$new_mtg->_remove_relations( 'Message_Template' );
+		$new_mtg->_remove_relations('Message_Template');
 		$new_mtg->save();
 		$success['GRP_ID'] = $new_mtg->ID();
 		$success['template_name'] = $template_name;
 
 		//add new message templates and add relation to.
-		foreach ( $mtts as $mtt ) {
-			if ( ! $mtt instanceof EE_Message_Template )
+		foreach ($mtts as $mtt) {
+			if ( ! $mtt instanceof EE_Message_Template)
 				continue;
 			$nmtt = clone $mtt;
 			$nmtt->set('MTP_ID', 0);
-			$nmtt->set( 'GRP_ID', $new_mtg->ID() ); //relation
+			$nmtt->set('GRP_ID', $new_mtg->ID()); //relation
 			$nmtt->save();
-			if ( empty( $success['MTP_context'] ) )
+			if (empty($success['MTP_context']))
 				$success['MTP_context'] = $nmtt->get('MTP_context');
 		}
 
@@ -694,14 +694,14 @@ 
 
 
 		//okay now let's assemble an array with the messenger template fields added to the message_type contexts.
-		foreach ( $this->_message_type->get_contexts() as $context => $details ) {
-			foreach ( $this->_messenger->get_template_fields() as $field => $value ) {
+		foreach ($this->_message_type->get_contexts() as $context => $details) {
+			foreach ($this->_messenger->get_template_fields() as $field => $value) {
 				$template_fields[$context][$field] = $value;
 			}
 		}
 
-		if ( empty($template_fields) ) {
-			EE_Error::add_error( __('Something went wrong and we couldn\'t get any templates assembled', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__ );
+		if (empty($template_fields)) {
+			EE_Error::add_error(__('Something went wrong and we couldn\'t get any templates assembled', 'event_espresso'), __FILE__, __FUNCTION__, __LINE__);
 			return FALSE;
 		}
 
@@ -716,30 +716,30 @@ 
 	 * @param bool  $set if true then we skip the cache and retrieve via files.
 	 * @return array multidimensional array of messenger and message_type objects (messengers index, and message_type index);
 	 */
-	public function get_installed( $type = 'all', $skip_cache = false ) {
+	public function get_installed($type = 'all', $skip_cache = false) {
 		$installed = array();
 
 		//first let's account for caching
-		if ( $skip_cache ) {
-			$message_base = EE_LIBRARIES . "messages" . DS;
+		if ($skip_cache) {
+			$message_base = EE_LIBRARIES."messages".DS;
 
-			$messenger_files = $type == 'all' || $type == 'messengers' ? scandir( $message_base . "messenger", 1) : NULL;
-			$messagetype_files = $type == 'all' || $type == 'message_types' ? scandir( $message_base . "message_type", 1) : NULL;
+			$messenger_files = $type == 'all' || $type == 'messengers' ? scandir($message_base."messenger", 1) : NULL;
+			$messagetype_files = $type == 'all' || $type == 'message_types' ? scandir($message_base."message_type", 1) : NULL;
 
 
 			//allow plugins to filter in their messenger/message_type files
-			$messenger_files = apply_filters('FHEE__EE_messages__get_installed__messenger_files', $messenger_files, $type );
-			$messagetype_files = apply_filters('FHEE__EE_messages__get_installed__messagetype_files', $messagetype_files, $type );
+			$messenger_files = apply_filters('FHEE__EE_messages__get_installed__messenger_files', $messenger_files, $type);
+			$messagetype_files = apply_filters('FHEE__EE_messages__get_installed__messagetype_files', $messagetype_files, $type);
 
-			$installed['messengers'] = !empty($messenger_files ) ? $this->_get_installed($messenger_files) : '';
-			$installed['message_types'] = !empty($messagetype_files) ? $this->_get_installed($messagetype_files) : '';
+			$installed['messengers'] = ! empty($messenger_files) ? $this->_get_installed($messenger_files) : '';
+			$installed['message_types'] = ! empty($messagetype_files) ? $this->_get_installed($messagetype_files) : '';
 		} else {
 			$installed['messengers'] = $this->get_installed_messengers();
 			$installed['message_types'] = $this->get_installed_message_types();
 		}
 
 
-		if ( $type != 'all' ) {
+		if ($type != 'all') {
 			$installed = $type == 'messengers' ? $installed['messengers'] : $installed['message_types'];
 		}
 
@@ -757,11 +757,11 @@ 
 		$the_goods = array();
 		$filenames = (array) $filenames;
 		$replace = ".class.php";
-		foreach ( $filenames as $filename ) {
-			$classname = preg_match("/" . $replace . "/", $filename ) ? str_replace($replace, "", $filename) : false;
+		foreach ($filenames as $filename) {
+			$classname = preg_match("/".$replace."/", $filename) ? str_replace($replace, "", $filename) : false;
 
 			//no classname? no match? move along, nothing to see here. note, the stripos is checking to make sure the filename (classname) begins with EE.
-			if ( !$classname || 0 !== stripos($classname, 'EE') ) continue;
+			if ( ! $classname || 0 !== stripos($classname, 'EE')) continue;
 
 			//note: I'm not sure if this will work without including the file.  We do have autoloaders so it "may" work.
 			$a = new ReflectionClass($classname);
@@ -784,9 +784,9 @@ 
 	 */
 	public function get_active_message_types() {
 		$message_types = array();
-		foreach ( $this->_active_message_types as $messenger => $mtvalues ) {
-			foreach ( $mtvalues as $mt => $config ) {
-				if ( !in_array( $mt, $message_types ) )
+		foreach ($this->_active_message_types as $messenger => $mtvalues) {
+			foreach ($mtvalues as $mt => $config) {
+				if ( ! in_array($mt, $message_types))
 					$message_types[] = $mt;
 			}
 		}
@@ -806,17 +806,17 @@ 
 	 *
 	 * @return EE_message_type[]    (or empty array if none present)
 	 */
-	public function get_active_message_types_per_messenger( $messenger ) {
+	public function get_active_message_types_per_messenger($messenger) {
 		$messenger = (string) $messenger;
-		if ( empty( $this->_active_message_types[$messenger] ) ) {
+		if (empty($this->_active_message_types[$messenger])) {
 			return array();
 		}
 
 		$mts = array();
 		$message_types = $this->_active_message_types[$messenger];
 		$installed_message_types = $this->get_installed_message_types();
-		foreach ( $message_types as $mt => $settings ) {
-			if ( ! empty( $installed_message_types[$mt] ) )  {
+		foreach ($message_types as $mt => $settings) {
+			if ( ! empty($installed_message_types[$mt])) {
 				$mts[] = $installed_message_types[$mt];
 			}
 		}
@@ -833,9 +833,9 @@ 
 	 *
 	 * @return EE_Message_Type|null
 	 */
-	public function get_active_message_type( $messenger, $message_type ) {
+	public function get_active_message_type($messenger, $message_type) {
 		$installed_message_types = $this->get_installed_message_types();
-		if ( !empty( $this->_active_message_types[$messenger][$message_type] ) && !empty( $installed_message_types[$message_type] ) )  {
+		if ( ! empty($this->_active_message_types[$messenger][$message_type]) && ! empty($installed_message_types[$message_type])) {
 			return $installed_message_types[$message_type];
 		}
 		return NULL;
@@ -844,13 +844,13 @@ 
 
 
 	public function get_installed_message_types() {
-		$this->_installed_message_types = empty( $this->_installed_message_types ) ? $this->get_installed( 'message_types', true ) : $this->_installed_message_types;
+		$this->_installed_message_types = empty($this->_installed_message_types) ? $this->get_installed('message_types', true) : $this->_installed_message_types;
 		return $this->_installed_message_types;
 	}
 
 
 	public function get_installed_messengers() {
-		$this->_installed_messengers = empty( $this->_installed_messengers ) ? $this->get_installed( 'messengers', true ) : $this->_installed_messengers;
+		$this->_installed_messengers = empty($this->_installed_messengers) ? $this->get_installed('messengers', true) : $this->_installed_messengers;
 		return $this->_installed_messengers;
 	}
 }